{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1240","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1240/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1240/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1240/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1240","id":116831393,"number":1240,"title":"simple a2ensite/a2dissite module","user":{"login":"fabfurnari","id":554134,"avatar_url":"https://avatars.githubusercontent.com/u/554134?v=3","gravatar_id":"","url":"https://api.github.com/users/fabfurnari","html_url":"https://github.com/fabfurnari","followers_url":"https://api.github.com/users/fabfurnari/followers","following_url":"https://api.github.com/users/fabfurnari/following{/other_user}","gists_url":"https://api.github.com/users/fabfurnari/gists{/gist_id}","starred_url":"https://api.github.com/users/fabfurnari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabfurnari/subscriptions","organizations_url":"https://api.github.com/users/fabfurnari/orgs","repos_url":"https://api.github.com/users/fabfurnari/repos","events_url":"https://api.github.com/users/fabfurnari/events{/privacy}","received_events_url":"https://api.github.com/users/fabfurnari/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/community_review","name":"community_review","color":"fad8c7"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/new_plugin","name":"new_plugin","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-11-13T19:04:34Z","updated_at":"2016-08-25T20:24:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1240","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1240","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/1240.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/1240.patch"},"body":"Just a copy of the very useful apache2_module module. It manages the activation and deactivation of sites using a2ensite/a2dissite commands.\r\nIt's tested and should work fine..."},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/242525854","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1240#issuecomment-242525854","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1240","id":242525854,"user":{"login":"robinro","id":107032,"avatar_url":"https://avatars.githubusercontent.com/u/107032?v=3","gravatar_id":"","url":"https://api.github.com/users/robinro","html_url":"https://github.com/robinro","followers_url":"https://api.github.com/users/robinro/followers","following_url":"https://api.github.com/users/robinro/following{/other_user}","gists_url":"https://api.github.com/users/robinro/gists{/gist_id}","starred_url":"https://api.github.com/users/robinro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinro/subscriptions","organizations_url":"https://api.github.com/users/robinro/orgs","repos_url":"https://api.github.com/users/robinro/repos","events_url":"https://api.github.com/users/robinro/events{/privacy}","received_events_url":"https://api.github.com/users/robinro/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T20:24:39Z","updated_at":"2016-08-25T20:24:39Z","body":"The module looks good to me. Things to extend:\r\n* implement check mode; not sure how to best do this since a2ensite has no dry-run, so one would have to look in the filesystem and reimplement some part of a2ensite within the module.\r\n* write integration tests (see https://github.com/ansible/ansible/blob/devel/test/integration/roles/test_apache2_module/tasks/actualtest.yml)\r\n\r\nSince `a2ensite`, `a2enmod` and `a2enconf` are the same (under debian/ubuntu), one could also consider to do a combined ansible module `apach2_settings` with `type = {site, mod, conf}`.\r\nOn the other hand: Suse has it's own implementation of `a2enmod` and doesn't have the other tools."}}
{"actor":{"display_login":"robinro"}}