{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/html/issues/1189","repository_url":"https://api.github.com/repos/whatwg/html","labels_url":"https://api.github.com/repos/whatwg/html/issues/1189/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/html/issues/1189/comments","events_url":"https://api.github.com/repos/whatwg/html/issues/1189/events","html_url":"https://github.com/whatwg/html/pull/1189","id":153080767,"number":1189,"title":"Fix and expand incumbent settings object definition","user":{"login":"domenic","id":617481,"avatar_url":"https://avatars.githubusercontent.com/u/617481?v=3","gravatar_id":"","url":"https://api.github.com/users/domenic","html_url":"https://github.com/domenic","followers_url":"https://api.github.com/users/domenic/followers","following_url":"https://api.github.com/users/domenic/following{/other_user}","gists_url":"https://api.github.com/users/domenic/gists{/gist_id}","starred_url":"https://api.github.com/users/domenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domenic/subscriptions","organizations_url":"https://api.github.com/users/domenic/orgs","repos_url":"https://api.github.com/users/domenic/repos","events_url":"https://api.github.com/users/domenic/events{/privacy}","received_events_url":"https://api.github.com/users/domenic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bzbarsky","id":1457979,"avatar_url":"https://avatars.githubusercontent.com/u/1457979?v=3","gravatar_id":"","url":"https://api.github.com/users/bzbarsky","html_url":"https://github.com/bzbarsky","followers_url":"https://api.github.com/users/bzbarsky/followers","following_url":"https://api.github.com/users/bzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/bzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzbarsky/subscriptions","organizations_url":"https://api.github.com/users/bzbarsky/orgs","repos_url":"https://api.github.com/users/bzbarsky/repos","events_url":"https://api.github.com/users/bzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/bzbarsky/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-05-04T18:20:02Z","updated_at":"2016-05-18T21:56:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whatwg/html/pulls/1189","html_url":"https://github.com/whatwg/html/pull/1189","diff_url":"https://github.com/whatwg/html/pull/1189.diff","patch_url":"https://github.com/whatwg/html/pull/1189.patch"},"body":"As discussed in #473, starting especially from around\r\nhttps://github.com/whatwg/html/issues/473#issuecomment-216656556, the\r\ndefinition of incumbent introduced in #401 falls down in certain\r\nimportant cases. In order to fix this, we introduce the \"backup\r\nincumbent settings object stack\", which takes care of these trickier\r\ncases. This commit also adds a few examples of how exactly incumbent\r\nsettings object calculation works, especially in the case where the\r\nbackup incumbent settings object stack ends up mattering.\r\n\r\nFor this story to be fully coherent, we will also need the minor fixes\r\nfound in tc39/ecma262#556, as well as further revisions to Web IDL to\r\nupdate it for this new framework. This commit is the first step,\r\nhowever.\r\n\r\n@bzbarsky review appreciated!!"},"comment":{"url":"https://api.github.com/repos/whatwg/html/issues/comments/220170444","html_url":"https://github.com/whatwg/html/pull/1189#issuecomment-220170444","issue_url":"https://api.github.com/repos/whatwg/html/issues/1189","id":220170444,"user":{"login":"bzbarsky","id":1457979,"avatar_url":"https://avatars.githubusercontent.com/u/1457979?v=3","gravatar_id":"","url":"https://api.github.com/users/bzbarsky","html_url":"https://github.com/bzbarsky","followers_url":"https://api.github.com/users/bzbarsky/followers","following_url":"https://api.github.com/users/bzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/bzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/bzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzbarsky/subscriptions","organizations_url":"https://api.github.com/users/bzbarsky/orgs","repos_url":"https://api.github.com/users/bzbarsky/repos","events_url":"https://api.github.com/users/bzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/bzbarsky/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T21:56:57Z","updated_at":"2016-05-18T21:56:57Z","body":"Oh, and we presumably still need IDL changes here too, right, to push/pop stuff onto this stack?"}}