{"action":"created","comment":{"url":"https://api.github.com/repos/servo/saltfs/pulls/comments/62778923","id":62778923,"diff_hunk":"@@ -40,16 +40,14 @@ servo:\n     - shell: /bin/bash\n     - home: {{ common.servo_home }}\n \n-{% for hostname, ip in common.hosts.items() %}\n-host-{{ hostname }}:\n-  host.present:\n-    - name: {{ hostname }}\n-    - ip: {{ ip }}\n-{% endfor %}\n-\n {% for ssh_user in common.ssh_users %}\n sshkey-{{ ssh_user }}:\n   ssh_auth.present:\n     - user: root\n     - source: salt://{{ tpldir }}/ssh/{{ ssh_user }}.pub\n {% endfor %}\n+\n+/etc/hosts:\n+  file.managed:\n+    - contents: \"127.0.0.1           localhost\\n::1                 localhost\\n255.255.255.255     broadcasthost\"","path":"common/init.sls","position":20,"original_position":20,"commit_id":"a6ede2bb7a5cca39675033d277a2360db02f93a0","original_commit_id":"a6ede2bb7a5cca39675033d277a2360db02f93a0","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"body":"We should put these into a file and refer to them using `source` instead of `contents`. Please make a `common/files` directory, and put these into a file called `hosts` in that directory.","created_at":"2016-05-11T01:00:16Z","updated_at":"2016-05-11T01:00:16Z","html_url":"https://github.com/servo/saltfs/pull/369#discussion_r62778923","pull_request_url":"https://api.github.com/repos/servo/saltfs/pulls/369","_links":{"self":{"href":"https://api.github.com/repos/servo/saltfs/pulls/comments/62778923"},"html":{"href":"https://github.com/servo/saltfs/pull/369#discussion_r62778923"},"pull_request":{"href":"https://api.github.com/repos/servo/saltfs/pulls/369"}}},"pull_request":{"url":"https://api.github.com/repos/servo/saltfs/pulls/369","id":69591688,"html_url":"https://github.com/servo/saltfs/pull/369","diff_url":"https://github.com/servo/saltfs/pull/369.diff","patch_url":"https://github.com/servo/saltfs/pull/369.patch","issue_url":"https://api.github.com/repos/servo/saltfs/issues/369","number":369,"state":"open","locked":false,"title":"Changed IPs to Hostnames where possible, and removed host.present tes…","user":{"login":"setupminimal","id":6630487,"avatar_url":"https://avatars.githubusercontent.com/u/6630487?v=3","gravatar_id":"","url":"https://api.github.com/users/setupminimal","html_url":"https://github.com/setupminimal","followers_url":"https://api.github.com/users/setupminimal/followers","following_url":"https://api.github.com/users/setupminimal/following{/other_user}","gists_url":"https://api.github.com/users/setupminimal/gists{/gist_id}","starred_url":"https://api.github.com/users/setupminimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/setupminimal/subscriptions","organizations_url":"https://api.github.com/users/setupminimal/orgs","repos_url":"https://api.github.com/users/setupminimal/repos","events_url":"https://api.github.com/users/setupminimal/events{/privacy}","received_events_url":"https://api.github.com/users/setupminimal/received_events","type":"User","site_admin":false},"body":"…ts from common/init.sls\r\n\r\nThis theoretically solves Issue #288. It certainly prevents  /etc/hosts from being messed with, and the recommended testing in Vagrant returns all green. I'm still not entirely sure that I didn't miss something, just because I'm unfamiliar with saltfs's code, so I would appreciate some feedback.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/saltfs/369)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-05-10T23:00:37Z","updated_at":"2016-05-11T01:00:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d974c2915894bd78a13c0d5151099d5d86c98800","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/saltfs/pulls/369/commits","review_comments_url":"https://api.github.com/repos/servo/saltfs/pulls/369/comments","review_comment_url":"https://api.github.com/repos/servo/saltfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/saltfs/issues/369/comments","statuses_url":"https://api.github.com/repos/servo/saltfs/statuses/a6ede2bb7a5cca39675033d277a2360db02f93a0","head":{"label":"setupminimal:master","ref":"master","sha":"a6ede2bb7a5cca39675033d277a2360db02f93a0","user":{"login":"setupminimal","id":6630487,"avatar_url":"https://avatars.githubusercontent.com/u/6630487?v=3","gravatar_id":"","url":"https://api.github.com/users/setupminimal","html_url":"https://github.com/setupminimal","followers_url":"https://api.github.com/users/setupminimal/followers","following_url":"https://api.github.com/users/setupminimal/following{/other_user}","gists_url":"https://api.github.com/users/setupminimal/gists{/gist_id}","starred_url":"https://api.github.com/users/setupminimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/setupminimal/subscriptions","organizations_url":"https://api.github.com/users/setupminimal/orgs","repos_url":"https://api.github.com/users/setupminimal/repos","events_url":"https://api.github.com/users/setupminimal/events{/privacy}","received_events_url":"https://api.github.com/users/setupminimal/received_events","type":"User","site_admin":false},"repo":{"id":58380041,"name":"saltfs","full_name":"setupminimal/saltfs","owner":{"login":"setupminimal","id":6630487,"avatar_url":"https://avatars.githubusercontent.com/u/6630487?v=3","gravatar_id":"","url":"https://api.github.com/users/setupminimal","html_url":"https://github.com/setupminimal","followers_url":"https://api.github.com/users/setupminimal/followers","following_url":"https://api.github.com/users/setupminimal/following{/other_user}","gists_url":"https://api.github.com/users/setupminimal/gists{/gist_id}","starred_url":"https://api.github.com/users/setupminimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/setupminimal/subscriptions","organizations_url":"https://api.github.com/users/setupminimal/orgs","repos_url":"https://api.github.com/users/setupminimal/repos","events_url":"https://api.github.com/users/setupminimal/events{/privacy}","received_events_url":"https://api.github.com/users/setupminimal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/setupminimal/saltfs","description":"Salt Stack Filesystem","fork":true,"url":"https://api.github.com/repos/setupminimal/saltfs","forks_url":"https://api.github.com/repos/setupminimal/saltfs/forks","keys_url":"https://api.github.com/repos/setupminimal/saltfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/setupminimal/saltfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/setupminimal/saltfs/teams","hooks_url":"https://api.github.com/repos/setupminimal/saltfs/hooks","issue_events_url":"https://api.github.com/repos/setupminimal/saltfs/issues/events{/number}","events_url":"https://api.github.com/repos/setupminimal/saltfs/events","assignees_url":"https://api.github.com/repos/setupminimal/saltfs/assignees{/user}","branches_url":"https://api.github.com/repos/setupminimal/saltfs/branches{/branch}","tags_url":"https://api.github.com/repos/setupminimal/saltfs/tags","blobs_url":"https://api.github.com/repos/setupminimal/saltfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/setupminimal/saltfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/setupminimal/saltfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/setupminimal/saltfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/setupminimal/saltfs/statuses/{sha}","languages_url":"https://api.github.com/repos/setupminimal/saltfs/languages","stargazers_url":"https://api.github.com/repos/setupminimal/saltfs/stargazers","contributors_url":"https://api.github.com/repos/setupminimal/saltfs/contributors","subscribers_url":"https://api.github.com/repos/setupminimal/saltfs/subscribers","subscription_url":"https://api.github.com/repos/setupminimal/saltfs/subscription","commits_url":"https://api.github.com/repos/setupminimal/saltfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/setupminimal/saltfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/setupminimal/saltfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/setupminimal/saltfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/setupminimal/saltfs/contents/{+path}","compare_url":"https://api.github.com/repos/setupminimal/saltfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/setupminimal/saltfs/merges","archive_url":"https://api.github.com/repos/setupminimal/saltfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/setupminimal/saltfs/downloads","issues_url":"https://api.github.com/repos/setupminimal/saltfs/issues{/number}","pulls_url":"https://api.github.com/repos/setupminimal/saltfs/pulls{/number}","milestones_url":"https://api.github.com/repos/setupminimal/saltfs/milestones{/number}","notifications_url":"https://api.github.com/repos/setupminimal/saltfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/setupminimal/saltfs/labels{/name}","releases_url":"https://api.github.com/repos/setupminimal/saltfs/releases{/id}","deployments_url":"https://api.github.com/repos/setupminimal/saltfs/deployments","created_at":"2016-05-09T13:48:46Z","updated_at":"2016-05-09T13:48:47Z","pushed_at":"2016-05-11T00:45:45Z","git_url":"git://github.com/setupminimal/saltfs.git","ssh_url":"git@github.com:setupminimal/saltfs.git","clone_url":"https://github.com/setupminimal/saltfs.git","svn_url":"https://github.com/setupminimal/saltfs","homepage":null,"size":425,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"7de086d85f75743f161967a0f2ed644b2b974ecc","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":24253493,"name":"saltfs","full_name":"servo/saltfs","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/saltfs","description":"Salt Stack Filesystem","fork":false,"url":"https://api.github.com/repos/servo/saltfs","forks_url":"https://api.github.com/repos/servo/saltfs/forks","keys_url":"https://api.github.com/repos/servo/saltfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/saltfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/saltfs/teams","hooks_url":"https://api.github.com/repos/servo/saltfs/hooks","issue_events_url":"https://api.github.com/repos/servo/saltfs/issues/events{/number}","events_url":"https://api.github.com/repos/servo/saltfs/events","assignees_url":"https://api.github.com/repos/servo/saltfs/assignees{/user}","branches_url":"https://api.github.com/repos/servo/saltfs/branches{/branch}","tags_url":"https://api.github.com/repos/servo/saltfs/tags","blobs_url":"https://api.github.com/repos/servo/saltfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/saltfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/saltfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/saltfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/saltfs/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/saltfs/languages","stargazers_url":"https://api.github.com/repos/servo/saltfs/stargazers","contributors_url":"https://api.github.com/repos/servo/saltfs/contributors","subscribers_url":"https://api.github.com/repos/servo/saltfs/subscribers","subscription_url":"https://api.github.com/repos/servo/saltfs/subscription","commits_url":"https://api.github.com/repos/servo/saltfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/saltfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/saltfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/saltfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/saltfs/contents/{+path}","compare_url":"https://api.github.com/repos/servo/saltfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/saltfs/merges","archive_url":"https://api.github.com/repos/servo/saltfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/saltfs/downloads","issues_url":"https://api.github.com/repos/servo/saltfs/issues{/number}","pulls_url":"https://api.github.com/repos/servo/saltfs/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/saltfs/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/saltfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/saltfs/labels{/name}","releases_url":"https://api.github.com/repos/servo/saltfs/releases{/id}","deployments_url":"https://api.github.com/repos/servo/saltfs/deployments","created_at":"2014-09-20T04:16:27Z","updated_at":"2016-04-28T11:38:26Z","pushed_at":"2016-05-11T00:45:49Z","git_url":"git://github.com/servo/saltfs.git","ssh_url":"git@github.com:servo/saltfs.git","clone_url":"https://github.com/servo/saltfs.git","svn_url":"https://github.com/servo/saltfs","homepage":null,"size":533,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":48,"forks":34,"open_issues":48,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/saltfs/pulls/369"},"html":{"href":"https://github.com/servo/saltfs/pull/369"},"issue":{"href":"https://api.github.com/repos/servo/saltfs/issues/369"},"comments":{"href":"https://api.github.com/repos/servo/saltfs/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/saltfs/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/saltfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/saltfs/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/servo/saltfs/statuses/a6ede2bb7a5cca39675033d277a2360db02f93a0"}}}}