{"action":"created","comment":{"url":"https://api.github.com/repos/google/upb/pulls/comments/91423307","pull_request_review_id":11931664,"id":91423307,"diff_hunk":"@@ -361,13 +368,17 @@ void upb_msgfactory_free(upb_msgfactory *f) {\n   upb_gfree(f);\n }\n \n+const upb_symtab *upb_msgfactory_symtab(const upb_msgfactory *f) {\n+  return f->symtab;\n+}\n+\n /* Requires:\n  * - m is in upb_msgfactory_symtab(f)","path":"upb/msg.c","position":null,"original_position":143,"commit_id":"2b77da3da8234484ebc099c560671ea21ab7181b","original_commit_id":"ba4e23f1702996336f580312dcdc67d55ed29ae7","user":{"login":"haberman","id":1270,"avatar_url":"https://avatars.githubusercontent.com/u/1270?v=3","gravatar_id":"","url":"https://api.github.com/users/haberman","html_url":"https://github.com/haberman","followers_url":"https://api.github.com/users/haberman/followers","following_url":"https://api.github.com/users/haberman/following{/other_user}","gists_url":"https://api.github.com/users/haberman/gists{/gist_id}","starred_url":"https://api.github.com/users/haberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haberman/subscriptions","organizations_url":"https://api.github.com/users/haberman/orgs","repos_url":"https://api.github.com/users/haberman/repos","events_url":"https://api.github.com/users/haberman/events{/privacy}","received_events_url":"https://api.github.com/users/haberman/received_events","type":"User","site_admin":false},"body":"Removed comment since it was redundant from .h file. I added a TODO in the .h file.","created_at":"2016-12-08T01:03:46Z","updated_at":"2016-12-08T01:03:46Z","html_url":"https://github.com/google/upb/pull/74#discussion_r91423307","pull_request_url":"https://api.github.com/repos/google/upb/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/google/upb/pulls/comments/91423307"},"html":{"href":"https://github.com/google/upb/pull/74#discussion_r91423307"},"pull_request":{"href":"https://api.github.com/repos/google/upb/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/google/upb/pulls/74","id":95754311,"html_url":"https://github.com/google/upb/pull/74","diff_url":"https://github.com/google/upb/pull/74.diff","patch_url":"https://github.com/google/upb/pull/74.patch","issue_url":"https://api.github.com/repos/google/upb/issues/74","number":74,"state":"open","locked":false,"title":"Added upb_msg and Lua bindings for using it.","user":{"login":"haberman","id":1270,"avatar_url":"https://avatars.githubusercontent.com/u/1270?v=3","gravatar_id":"","url":"https://api.github.com/users/haberman","html_url":"https://github.com/haberman","followers_url":"https://api.github.com/users/haberman/followers","following_url":"https://api.github.com/users/haberman/following{/other_user}","gists_url":"https://api.github.com/users/haberman/gists{/gist_id}","starred_url":"https://api.github.com/users/haberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haberman/subscriptions","organizations_url":"https://api.github.com/users/haberman/orgs","repos_url":"https://api.github.com/users/haberman/repos","events_url":"https://api.github.com/users/haberman/events{/privacy}","received_events_url":"https://api.github.com/users/haberman/received_events","type":"User","site_admin":false},"body":"upb_msg is a major step forward for upb. We will finally have a standard message representation, but one that interoperates with different memory management schemes (arena allocation, unique ownership, etc). This will also pave the way for representing custom options properly.\r\n\r\nThis PR is pretty big, but it's not quite as big as it looks, because several things were shuffled around.\r\n\r\nIn particular, the main`upb.c` in the Lua bindings was split into 3: `upb.c`, `msg.c`, and `def.c`. So basically none of the code in `def.c` is actually new, even though GitHub is showing it all as added in the PR.\r\n\r\nAlso, `upb/shim/*` functionality was moved into `upb/msg.c`.\r\n\r\nThere is some dead code here: functionality that I implemented in `upb_msg` but is not tested yet (like maps, extensions, repeated string fields, etc). I didn't want to make this CL grow even more, so I decided to stop when I had parity with what the Lua implementation could do before this change. Follow-up CLs will flesh out the tests to exercise all these cases, and will fix the inevitable bugs.\r\n\r\nReview to @scwhittle.","created_at":"2016-11-29T19:03:11Z","updated_at":"2016-12-08T01:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26369942532661f2cfe29f3af255545997591ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/upb/pulls/74/commits","review_comments_url":"https://api.github.com/repos/google/upb/pulls/74/comments","review_comment_url":"https://api.github.com/repos/google/upb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/upb/issues/74/comments","statuses_url":"https://api.github.com/repos/google/upb/statuses/2b77da3da8234484ebc099c560671ea21ab7181b","head":{"label":"haberman:msg","ref":"msg","sha":"2b77da3da8234484ebc099c560671ea21ab7181b","user":{"login":"haberman","id":1270,"avatar_url":"https://avatars.githubusercontent.com/u/1270?v=3","gravatar_id":"","url":"https://api.github.com/users/haberman","html_url":"https://github.com/haberman","followers_url":"https://api.github.com/users/haberman/followers","following_url":"https://api.github.com/users/haberman/following{/other_user}","gists_url":"https://api.github.com/users/haberman/gists{/gist_id}","starred_url":"https://api.github.com/users/haberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haberman/subscriptions","organizations_url":"https://api.github.com/users/haberman/orgs","repos_url":"https://api.github.com/users/haberman/repos","events_url":"https://api.github.com/users/haberman/events{/privacy}","received_events_url":"https://api.github.com/users/haberman/received_events","type":"User","site_admin":false},"repo":{"id":35840835,"name":"upb","full_name":"haberman/upb","owner":{"login":"haberman","id":1270,"avatar_url":"https://avatars.githubusercontent.com/u/1270?v=3","gravatar_id":"","url":"https://api.github.com/users/haberman","html_url":"https://github.com/haberman","followers_url":"https://api.github.com/users/haberman/followers","following_url":"https://api.github.com/users/haberman/following{/other_user}","gists_url":"https://api.github.com/users/haberman/gists{/gist_id}","starred_url":"https://api.github.com/users/haberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haberman/subscriptions","organizations_url":"https://api.github.com/users/haberman/orgs","repos_url":"https://api.github.com/users/haberman/repos","events_url":"https://api.github.com/users/haberman/events{/privacy}","received_events_url":"https://api.github.com/users/haberman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haberman/upb","description":"small, fast parsers for the 21st century","fork":true,"url":"https://api.github.com/repos/haberman/upb","forks_url":"https://api.github.com/repos/haberman/upb/forks","keys_url":"https://api.github.com/repos/haberman/upb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haberman/upb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haberman/upb/teams","hooks_url":"https://api.github.com/repos/haberman/upb/hooks","issue_events_url":"https://api.github.com/repos/haberman/upb/issues/events{/number}","events_url":"https://api.github.com/repos/haberman/upb/events","assignees_url":"https://api.github.com/repos/haberman/upb/assignees{/user}","branches_url":"https://api.github.com/repos/haberman/upb/branches{/branch}","tags_url":"https://api.github.com/repos/haberman/upb/tags","blobs_url":"https://api.github.com/repos/haberman/upb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haberman/upb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haberman/upb/git/refs{/sha}","trees_url":"https://api.github.com/repos/haberman/upb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haberman/upb/statuses/{sha}","languages_url":"https://api.github.com/repos/haberman/upb/languages","stargazers_url":"https://api.github.com/repos/haberman/upb/stargazers","contributors_url":"https://api.github.com/repos/haberman/upb/contributors","subscribers_url":"https://api.github.com/repos/haberman/upb/subscribers","subscription_url":"https://api.github.com/repos/haberman/upb/subscription","commits_url":"https://api.github.com/repos/haberman/upb/commits{/sha}","git_commits_url":"https://api.github.com/repos/haberman/upb/git/commits{/sha}","comments_url":"https://api.github.com/repos/haberman/upb/comments{/number}","issue_comment_url":"https://api.github.com/repos/haberman/upb/issues/comments{/number}","contents_url":"https://api.github.com/repos/haberman/upb/contents/{+path}","compare_url":"https://api.github.com/repos/haberman/upb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haberman/upb/merges","archive_url":"https://api.github.com/repos/haberman/upb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haberman/upb/downloads","issues_url":"https://api.github.com/repos/haberman/upb/issues{/number}","pulls_url":"https://api.github.com/repos/haberman/upb/pulls{/number}","milestones_url":"https://api.github.com/repos/haberman/upb/milestones{/number}","notifications_url":"https://api.github.com/repos/haberman/upb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haberman/upb/labels{/name}","releases_url":"https://api.github.com/repos/haberman/upb/releases{/id}","deployments_url":"https://api.github.com/repos/haberman/upb/deployments","created_at":"2015-05-18T20:29:27Z","updated_at":"2016-12-06T03:39:50Z","pushed_at":"2016-12-08T01:03:18Z","git_url":"git://github.com/haberman/upb.git","ssh_url":"git@github.com:haberman/upb.git","clone_url":"https://github.com/haberman/upb.git","svn_url":"https://github.com/haberman/upb","homepage":"https://github.com/haberman/upb/wiki","size":5290,"stargazers_count":35,"watchers_count":35,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":35,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"9a91f7bba8c89ed4d1cb0d56b8a394a9590df029","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":196334,"name":"upb","full_name":"google/upb","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/upb","description":"small, fast parsers for the 21st century","fork":false,"url":"https://api.github.com/repos/google/upb","forks_url":"https://api.github.com/repos/google/upb/forks","keys_url":"https://api.github.com/repos/google/upb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/upb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/upb/teams","hooks_url":"https://api.github.com/repos/google/upb/hooks","issue_events_url":"https://api.github.com/repos/google/upb/issues/events{/number}","events_url":"https://api.github.com/repos/google/upb/events","assignees_url":"https://api.github.com/repos/google/upb/assignees{/user}","branches_url":"https://api.github.com/repos/google/upb/branches{/branch}","tags_url":"https://api.github.com/repos/google/upb/tags","blobs_url":"https://api.github.com/repos/google/upb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/upb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/upb/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/upb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/upb/statuses/{sha}","languages_url":"https://api.github.com/repos/google/upb/languages","stargazers_url":"https://api.github.com/repos/google/upb/stargazers","contributors_url":"https://api.github.com/repos/google/upb/contributors","subscribers_url":"https://api.github.com/repos/google/upb/subscribers","subscription_url":"https://api.github.com/repos/google/upb/subscription","commits_url":"https://api.github.com/repos/google/upb/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/upb/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/upb/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/upb/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/upb/contents/{+path}","compare_url":"https://api.github.com/repos/google/upb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/upb/merges","archive_url":"https://api.github.com/repos/google/upb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/upb/downloads","issues_url":"https://api.github.com/repos/google/upb/issues{/number}","pulls_url":"https://api.github.com/repos/google/upb/pulls{/number}","milestones_url":"https://api.github.com/repos/google/upb/milestones{/number}","notifications_url":"https://api.github.com/repos/google/upb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/upb/labels{/name}","releases_url":"https://api.github.com/repos/google/upb/releases{/id}","deployments_url":"https://api.github.com/repos/google/upb/deployments","created_at":"2009-05-09T02:38:42Z","updated_at":"2016-12-04T01:43:31Z","pushed_at":"2016-12-08T01:03:19Z","git_url":"git://github.com/google/upb.git","ssh_url":"git@github.com:google/upb.git","clone_url":"https://github.com/google/upb.git","svn_url":"https://github.com/google/upb","homepage":"https://github.com/haberman/upb/wiki","size":5265,"stargazers_count":713,"watchers_count":713,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":17,"forks":98,"open_issues":17,"watchers":713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/upb/pulls/74"},"html":{"href":"https://github.com/google/upb/pull/74"},"issue":{"href":"https://api.github.com/repos/google/upb/issues/74"},"comments":{"href":"https://api.github.com/repos/google/upb/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/google/upb/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/google/upb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/upb/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/google/upb/statuses/2b77da3da8234484ebc099c560671ea21ab7181b"}}}}
{"actor":{"display_login":"haberman"}}