{"action":"opened","number":10173,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10173","id":97010388,"html_url":"https://github.com/nodejs/node/pull/10173","diff_url":"https://github.com/nodejs/node/pull/10173.diff","patch_url":"https://github.com/nodejs/node/pull/10173.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10173","number":10173,"state":"open","locked":false,"title":"deps: define missing operator delete functions","user":{"login":"jBarz","id":15161981,"avatar_url":"https://avatars.githubusercontent.com/u/15161981?v=3","gravatar_id":"","url":"https://api.github.com/users/jBarz","html_url":"https://github.com/jBarz","followers_url":"https://api.github.com/users/jBarz/followers","following_url":"https://api.github.com/users/jBarz/following{/other_user}","gists_url":"https://api.github.com/users/jBarz/gists{/gist_id}","starred_url":"https://api.github.com/users/jBarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jBarz/subscriptions","organizations_url":"https://api.github.com/users/jBarz/orgs","repos_url":"https://api.github.com/users/jBarz/repos","events_url":"https://api.github.com/users/jBarz/events{/privacy}","received_events_url":"https://api.github.com/users/jBarz/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nv8\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\nSection 3.2 of the C++ standard states that destructor definitions\r\nimplicitly \"use\" operator delete functions. Therefore, these operator\r\ndelete functions must be defined even if they are never called by\r\nuser code explicitly.\r\nhttp://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261\r\n\r\ngcc allows them to remain as empty definitions. However, not all\r\ncompilers allow this.\r\n\r\nThis pull request creates definitions which if ever called, result\r\nin an abort.","created_at":"2016-12-07T21:26:24Z","updated_at":"2016-12-07T21:26:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10173/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10173/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10173/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b2dac38ebf6f970b5c1239f3f5b0524b6bbda5b7","head":{"label":"jBarz:v0.12-staging","ref":"v0.12-staging","sha":"b2dac38ebf6f970b5c1239f3f5b0524b6bbda5b7","user":{"login":"jBarz","id":15161981,"avatar_url":"https://avatars.githubusercontent.com/u/15161981?v=3","gravatar_id":"","url":"https://api.github.com/users/jBarz","html_url":"https://github.com/jBarz","followers_url":"https://api.github.com/users/jBarz/followers","following_url":"https://api.github.com/users/jBarz/following{/other_user}","gists_url":"https://api.github.com/users/jBarz/gists{/gist_id}","starred_url":"https://api.github.com/users/jBarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jBarz/subscriptions","organizations_url":"https://api.github.com/users/jBarz/orgs","repos_url":"https://api.github.com/users/jBarz/repos","events_url":"https://api.github.com/users/jBarz/events{/privacy}","received_events_url":"https://api.github.com/users/jBarz/received_events","type":"User","site_admin":false},"repo":{"id":75851435,"name":"node-core","full_name":"jBarz/node-core","owner":{"login":"jBarz","id":15161981,"avatar_url":"https://avatars.githubusercontent.com/u/15161981?v=3","gravatar_id":"","url":"https://api.github.com/users/jBarz","html_url":"https://github.com/jBarz","followers_url":"https://api.github.com/users/jBarz/followers","following_url":"https://api.github.com/users/jBarz/following{/other_user}","gists_url":"https://api.github.com/users/jBarz/gists{/gist_id}","starred_url":"https://api.github.com/users/jBarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jBarz/subscriptions","organizations_url":"https://api.github.com/users/jBarz/orgs","repos_url":"https://api.github.com/users/jBarz/repos","events_url":"https://api.github.com/users/jBarz/events{/privacy}","received_events_url":"https://api.github.com/users/jBarz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jBarz/node-core","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/jBarz/node-core","forks_url":"https://api.github.com/repos/jBarz/node-core/forks","keys_url":"https://api.github.com/repos/jBarz/node-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jBarz/node-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jBarz/node-core/teams","hooks_url":"https://api.github.com/repos/jBarz/node-core/hooks","issue_events_url":"https://api.github.com/repos/jBarz/node-core/issues/events{/number}","events_url":"https://api.github.com/repos/jBarz/node-core/events","assignees_url":"https://api.github.com/repos/jBarz/node-core/assignees{/user}","branches_url":"https://api.github.com/repos/jBarz/node-core/branches{/branch}","tags_url":"https://api.github.com/repos/jBarz/node-core/tags","blobs_url":"https://api.github.com/repos/jBarz/node-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jBarz/node-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jBarz/node-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jBarz/node-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jBarz/node-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jBarz/node-core/languages","stargazers_url":"https://api.github.com/repos/jBarz/node-core/stargazers","contributors_url":"https://api.github.com/repos/jBarz/node-core/contributors","subscribers_url":"https://api.github.com/repos/jBarz/node-core/subscribers","subscription_url":"https://api.github.com/repos/jBarz/node-core/subscription","commits_url":"https://api.github.com/repos/jBarz/node-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jBarz/node-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jBarz/node-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jBarz/node-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jBarz/node-core/contents/{+path}","compare_url":"https://api.github.com/repos/jBarz/node-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jBarz/node-core/merges","archive_url":"https://api.github.com/repos/jBarz/node-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jBarz/node-core/downloads","issues_url":"https://api.github.com/repos/jBarz/node-core/issues{/number}","pulls_url":"https://api.github.com/repos/jBarz/node-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jBarz/node-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jBarz/node-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jBarz/node-core/labels{/name}","releases_url":"https://api.github.com/repos/jBarz/node-core/releases{/id}","deployments_url":"https://api.github.com/repos/jBarz/node-core/deployments","created_at":"2016-12-07T15:51:51Z","updated_at":"2016-12-07T15:54:04Z","pushed_at":"2016-12-07T21:20:36Z","git_url":"git://github.com/jBarz/node-core.git","ssh_url":"git@github.com:jBarz/node-core.git","clone_url":"https://github.com/jBarz/node-core.git","svn_url":"https://github.com/jBarz/node-core","homepage":"https://nodejs.org","size":378530,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:v0.12-staging","ref":"v0.12-staging","sha":"c130b31cba9e536925c4f9cbebaed91931750b70","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-12-07T21:09:36Z","pushed_at":"2016-12-07T21:13:03Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":377502,"stargazers_count":29632,"watchers_count":29632,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5285,"mirror_url":null,"open_issues_count":1041,"forks":5285,"open_issues":1041,"watchers":29632,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10173"},"html":{"href":"https://github.com/nodejs/node/pull/10173"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10173"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10173/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10173/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10173/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b2dac38ebf6f970b5c1239f3f5b0524b6bbda5b7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"jBarz"}}