{"action":"created","comment":{"url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/comments/88491363","pull_request_review_id":9038817,"id":88491363,"diff_hunk":"@@ -41,10 +41,15 @@ class XFormSubmissionViewSet(OpenRosaHeadersMixin,\n     parser_classes = (FormParser, MultiPartParser,)\n     serializer_class = XFormSubmissionSerializer\n \n+    def dispatch(self, *args, **kwargs):\n+        print(args[0].__dict__)","path":"cadasta/xforms/views/api.py","position":5,"original_position":5,"commit_id":"ad59de8a66a068dc89612f186d83945270274ff3","original_commit_id":"ad59de8a66a068dc89612f186d83945270274ff3","user":{"login":"bjohare","id":3308136,"avatar_url":"https://avatars.githubusercontent.com/u/3308136?v=3","gravatar_id":"","url":"https://api.github.com/users/bjohare","html_url":"https://github.com/bjohare","followers_url":"https://api.github.com/users/bjohare/followers","following_url":"https://api.github.com/users/bjohare/following{/other_user}","gists_url":"https://api.github.com/users/bjohare/gists{/gist_id}","starred_url":"https://api.github.com/users/bjohare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjohare/subscriptions","organizations_url":"https://api.github.com/users/bjohare/orgs","repos_url":"https://api.github.com/users/bjohare/repos","events_url":"https://api.github.com/users/bjohare/events{/privacy}","received_events_url":"https://api.github.com/users/bjohare/received_events","type":"User","site_admin":false},"body":"Can this be removed?","created_at":"2016-11-17T16:34:53Z","updated_at":"2016-11-17T16:46:01Z","html_url":"https://github.com/Cadasta/cadasta-platform/pull/938#discussion_r88491363","pull_request_url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938","_links":{"self":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/comments/88491363"},"html":{"href":"https://github.com/Cadasta/cadasta-platform/pull/938#discussion_r88491363"},"pull_request":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938"}}},"pull_request":{"url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938","id":93996700,"html_url":"https://github.com/Cadasta/cadasta-platform/pull/938","diff_url":"https://github.com/Cadasta/cadasta-platform/pull/938.diff","patch_url":"https://github.com/Cadasta/cadasta-platform/pull/938.patch","issue_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/938","number":938,"state":"open","locked":false,"title":"Questioannire API","user":{"login":"oliverroick","id":159510,"avatar_url":"https://avatars.githubusercontent.com/u/159510?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverroick","html_url":"https://github.com/oliverroick","followers_url":"https://api.github.com/users/oliverroick/followers","following_url":"https://api.github.com/users/oliverroick/following{/other_user}","gists_url":"https://api.github.com/users/oliverroick/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverroick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverroick/subscriptions","organizations_url":"https://api.github.com/users/oliverroick/orgs","repos_url":"https://api.github.com/users/oliverroick/repos","events_url":"https://api.github.com/users/oliverroick/events{/privacy}","received_events_url":"https://api.github.com/users/oliverroick/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\n- Block questionnaires from uploading if the project has data\r\n- Render XForm from questionnaire instance\r\n- Add XForm rendering to API view\r\n- Extend API to update questioanaires\r\n\r\n### When should this PR be merged\r\n\r\nFor sprint 11\r\n\r\n\r\n### Risks\r\n\r\nThere is one migration, which only adds fields, this should not be a huge problem.\r\n\r\nThis PR changes the way XForms are created and provided to GeoODK. I have tested with most questionnaires that we use in production but there is a chance that I haven't though of all possible edge cases. Loading forms into GeoODK, collecting and submitting data should be carefully tested on staging. \r\n\r\n### Follow up actions\r\n\r\nNone. ","created_at":"2016-11-16T16:11:36Z","updated_at":"2016-11-17T16:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"940efe58770ceca0984fc676f2bbd4712218fe91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938/commits","review_comments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938/comments","review_comment_url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/938/comments","statuses_url":"https://api.github.com/repos/Cadasta/cadasta-platform/statuses/ad59de8a66a068dc89612f186d83945270274ff3","head":{"label":"Cadasta:feature/686-questionnaire-api","ref":"feature/686-questionnaire-api","sha":"ad59de8a66a068dc89612f186d83945270274ff3","user":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars.githubusercontent.com/u/11321107?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"repo":{"id":45993428,"name":"cadasta-platform","full_name":"Cadasta/cadasta-platform","owner":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars.githubusercontent.com/u/11321107?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cadasta/cadasta-platform","description":null,"fork":false,"url":"https://api.github.com/repos/Cadasta/cadasta-platform","forks_url":"https://api.github.com/repos/Cadasta/cadasta-platform/forks","keys_url":"https://api.github.com/repos/Cadasta/cadasta-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cadasta/cadasta-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cadasta/cadasta-platform/teams","hooks_url":"https://api.github.com/repos/Cadasta/cadasta-platform/hooks","issue_events_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/events{/number}","events_url":"https://api.github.com/repos/Cadasta/cadasta-platform/events","assignees_url":"https://api.github.com/repos/Cadasta/cadasta-platform/assignees{/user}","branches_url":"https://api.github.com/repos/Cadasta/cadasta-platform/branches{/branch}","tags_url":"https://api.github.com/repos/Cadasta/cadasta-platform/tags","blobs_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cadasta/cadasta-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Cadasta/cadasta-platform/languages","stargazers_url":"https://api.github.com/repos/Cadasta/cadasta-platform/stargazers","contributors_url":"https://api.github.com/repos/Cadasta/cadasta-platform/contributors","subscribers_url":"https://api.github.com/repos/Cadasta/cadasta-platform/subscribers","subscription_url":"https://api.github.com/repos/Cadasta/cadasta-platform/subscription","commits_url":"https://api.github.com/repos/Cadasta/cadasta-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cadasta/cadasta-platform/contents/{+path}","compare_url":"https://api.github.com/repos/Cadasta/cadasta-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cadasta/cadasta-platform/merges","archive_url":"https://api.github.com/repos/Cadasta/cadasta-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cadasta/cadasta-platform/downloads","issues_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues{/number}","pulls_url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Cadasta/cadasta-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Cadasta/cadasta-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cadasta/cadasta-platform/labels{/name}","releases_url":"https://api.github.com/repos/Cadasta/cadasta-platform/releases{/id}","deployments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/deployments","created_at":"2015-11-11T16:26:25Z","updated_at":"2016-10-23T19:31:37Z","pushed_at":"2016-11-17T10:47:49Z","git_url":"git://github.com/Cadasta/cadasta-platform.git","ssh_url":"git@github.com:Cadasta/cadasta-platform.git","clone_url":"https://github.com/Cadasta/cadasta-platform.git","svn_url":"https://github.com/Cadasta/cadasta-platform","homepage":null,"size":14018,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":137,"forks":14,"open_issues":137,"watchers":13,"default_branch":"master"}},"base":{"label":"Cadasta:master","ref":"master","sha":"1c1302e1b00aed145e26bbd2b77383e5ac3f8d05","user":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars.githubusercontent.com/u/11321107?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"repo":{"id":45993428,"name":"cadasta-platform","full_name":"Cadasta/cadasta-platform","owner":{"login":"Cadasta","id":11321107,"avatar_url":"https://avatars.githubusercontent.com/u/11321107?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadasta","html_url":"https://github.com/Cadasta","followers_url":"https://api.github.com/users/Cadasta/followers","following_url":"https://api.github.com/users/Cadasta/following{/other_user}","gists_url":"https://api.github.com/users/Cadasta/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadasta/subscriptions","organizations_url":"https://api.github.com/users/Cadasta/orgs","repos_url":"https://api.github.com/users/Cadasta/repos","events_url":"https://api.github.com/users/Cadasta/events{/privacy}","received_events_url":"https://api.github.com/users/Cadasta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cadasta/cadasta-platform","description":null,"fork":false,"url":"https://api.github.com/repos/Cadasta/cadasta-platform","forks_url":"https://api.github.com/repos/Cadasta/cadasta-platform/forks","keys_url":"https://api.github.com/repos/Cadasta/cadasta-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cadasta/cadasta-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cadasta/cadasta-platform/teams","hooks_url":"https://api.github.com/repos/Cadasta/cadasta-platform/hooks","issue_events_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/events{/number}","events_url":"https://api.github.com/repos/Cadasta/cadasta-platform/events","assignees_url":"https://api.github.com/repos/Cadasta/cadasta-platform/assignees{/user}","branches_url":"https://api.github.com/repos/Cadasta/cadasta-platform/branches{/branch}","tags_url":"https://api.github.com/repos/Cadasta/cadasta-platform/tags","blobs_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cadasta/cadasta-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Cadasta/cadasta-platform/languages","stargazers_url":"https://api.github.com/repos/Cadasta/cadasta-platform/stargazers","contributors_url":"https://api.github.com/repos/Cadasta/cadasta-platform/contributors","subscribers_url":"https://api.github.com/repos/Cadasta/cadasta-platform/subscribers","subscription_url":"https://api.github.com/repos/Cadasta/cadasta-platform/subscription","commits_url":"https://api.github.com/repos/Cadasta/cadasta-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cadasta/cadasta-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cadasta/cadasta-platform/contents/{+path}","compare_url":"https://api.github.com/repos/Cadasta/cadasta-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cadasta/cadasta-platform/merges","archive_url":"https://api.github.com/repos/Cadasta/cadasta-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cadasta/cadasta-platform/downloads","issues_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues{/number}","pulls_url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Cadasta/cadasta-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Cadasta/cadasta-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cadasta/cadasta-platform/labels{/name}","releases_url":"https://api.github.com/repos/Cadasta/cadasta-platform/releases{/id}","deployments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/deployments","created_at":"2015-11-11T16:26:25Z","updated_at":"2016-10-23T19:31:37Z","pushed_at":"2016-11-17T10:47:49Z","git_url":"git://github.com/Cadasta/cadasta-platform.git","ssh_url":"git@github.com:Cadasta/cadasta-platform.git","clone_url":"https://github.com/Cadasta/cadasta-platform.git","svn_url":"https://github.com/Cadasta/cadasta-platform","homepage":null,"size":14018,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":137,"forks":14,"open_issues":137,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938"},"html":{"href":"https://github.com/Cadasta/cadasta-platform/pull/938"},"issue":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/938"},"comments":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/938/comments"},"review_comments":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938/comments"},"review_comment":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/938/commits"},"statuses":{"href":"https://api.github.com/repos/Cadasta/cadasta-platform/statuses/ad59de8a66a068dc89612f186d83945270274ff3"}}}}
{"actor":{"display_login":"bjohare"}}