{"action":"created","issue":{"url":"https://api.github.com/repos/druid-io/druid/issues/2459","repository_url":"https://api.github.com/repos/druid-io/druid","labels_url":"https://api.github.com/repos/druid-io/druid/issues/2459/labels{/name}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/2459/comments","events_url":"https://api.github.com/repos/druid-io/druid/issues/2459/events","html_url":"https://github.com/druid-io/druid/pull/2459","id":133273026,"number":2459,"title":"Flush oldest sink when total rows in all sinks exceeds maxRowsInMemory","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/druid-io/druid/labels/Ease%20of%20Use","name":"Ease of Use","color":"006b75"},{"url":"https://api.github.com/repos/druid-io/druid/labels/Improvement","name":"Improvement","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/21","html_url":"https://github.com/druid-io/druid/milestones/0.9.3","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/21/labels","id":1831000,"number":21,"title":"0.9.3","description":"","creator":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":0,"state":"open","created_at":"2016-06-15T22:35:58Z","updated_at":"2016-07-26T02:13:05Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-02-12T15:46:13Z","updated_at":"2016-07-26T03:12:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/2459","html_url":"https://github.com/druid-io/druid/pull/2459","diff_url":"https://github.com/druid-io/druid/pull/2459.diff","patch_url":"https://github.com/druid-io/druid/pull/2459.patch"},"body":"Currently `maxRowsInMemory` in RealtimeIndexTask is applied per sink base, which can cause OOM if too many sinks under the size of the threshold are created for some reason. This patch periodically checks total count of currently active sinks and persist the least recently accessed one if it exceeds the threshold."},"comment":{"url":"https://api.github.com/repos/druid-io/druid/issues/comments/235151037","html_url":"https://github.com/druid-io/druid/pull/2459#issuecomment-235151037","issue_url":"https://api.github.com/repos/druid-io/druid/issues/2459","id":235151037,"user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?v=3","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T03:12:14Z","updated_at":"2016-07-26T03:12:14Z","body":"@navis, this looks like a great change that would make druid easier to configure. my main comments are https://github.com/druid-io/druid/pull/2459#discussion_r72181462 & https://github.com/druid-io/druid/pull/2459#discussion_r72179368."}}
{"actor":{"display_login":"gianm"}}