{"action":"created","issue":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/206","repository_url":"https://api.github.com/repos/gulpjs/vinyl-fs","labels_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/206/comments","events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/206/events","html_url":"https://github.com/gulpjs/vinyl-fs/issues/206","id":173643862,"number":206,"title":"['**/*.js', '!node_modules/**'] - SLOW","user":{"login":"julesmoretti","id":744300,"avatar_url":"https://avatars.githubusercontent.com/u/744300?v=3","gravatar_id":"","url":"https://api.github.com/users/julesmoretti","html_url":"https://github.com/julesmoretti","followers_url":"https://api.github.com/users/julesmoretti/followers","following_url":"https://api.github.com/users/julesmoretti/following{/other_user}","gists_url":"https://api.github.com/users/julesmoretti/gists{/gist_id}","starred_url":"https://api.github.com/users/julesmoretti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julesmoretti/subscriptions","organizations_url":"https://api.github.com/users/julesmoretti/orgs","repos_url":"https://api.github.com/users/julesmoretti/repos","events_url":"https://api.github.com/users/julesmoretti/events{/privacy}","received_events_url":"https://api.github.com/users/julesmoretti/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-28T12:15:05Z","updated_at":"2016-08-28T18:38:16Z","closed_at":"2016-08-28T18:38:16Z","body":"Please refer to this post for this issue: https://github.com/adametry/gulp-eslint/issues/174\r\n\r\nand here is what I had written:\r\n\r\nSomehow having the following in my gulpfile.js is really slow to load despite having a really light structure:\r\n\r\n```\r\n// gulpfile.js\r\ngulp.task('default', () => {\r\n\treturn gulp\r\n\t\t.src(['**/*.js', '!node_modules/**'])\r\n\t\t.pipe(eslint({configFile: 'tools/gulp/eslint-config.json'}))\r\n\t\t.pipe(eslint.format());\r\n});\r\n```\r\n\r\n```\r\n// package.json\r\n{\r\n\t...\r\n\t\"dependencies\": {\r\n\t\t\"express\": \"^4.14.0\",\r\n\t\t\"express-handlebars\": \"^3.0.0\",\r\n\t\t\"morgan\": \"^1.7.0\",\r\n\t\t\"serve-favicon\": \"^2.3.0\"\r\n\t},\r\n\t\"devDependencies\": {\r\n\t\t\"dotenv\": \"^2.0.0\",\r\n\t\t\"gulp\": \"^3.9.1\",\r\n\t\t\"gulp-eslint\": \"^3.0.1\",\r\n\t\t\"gulp-nodemon\": \"^2.1.0\",\r\n\t\t\"gulp-sass\": \"^2.3.2\",\r\n\t\t\"gulp-spawn-mocha\": \"^3.1.0\",\r\n\t\t\"react\": \"^15.3.1\",\r\n\t\t\"react-dom\": \"^15.3.1\"\r\n\t}\r\n}\r\n\r\n```\r\n\r\nDirectory structure:\r\n* app/\r\n* node_modules/\r\n* tools/\r\n * gulp/\r\n   * eslint-config.json\r\n    * test.js\r\n* gulpfile.js\r\n* package.json\r\n\r\n\r\n```\r\n// test.js\r\nconst hello = () =>{\r\n\t\tconsole.log('thats it!' )\r\n};\r\n\r\nhello();\r\n```\r\n\r\n```\r\n// eslint-config.json\r\n{\r\n\t\"env\": {\r\n\t\t\"es6\": true\r\n\t},\r\n\t\"rules\": {\r\n\t\t\"indent\": [2, \"tab\"]\r\n\t}\r\n}\r\n\r\n```\r\n\r\nWhereas if I do the following in my gulpfile it is instantaneous:\r\n\r\n```\r\ngulp.task('default', () => {\r\n\treturn gulp\r\n\t\t.src(['app/**/*.js',\r\n\t\t\t'tools/**/*.js',\r\n\t\t\t'gulpfile.js'])\r\n\r\n\t\t.pipe(eslint({configFile: 'tools/gulp/eslint-config.json'}))\r\n\t\t.pipe(eslint.format());\r\n});\r\n```\r\n\r\nSo it looks like it still recurse through everything and then neglect the node_modules..."},"comment":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/comments/242991362","html_url":"https://github.com/gulpjs/vinyl-fs/issues/206#issuecomment-242991362","issue_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/206","id":242991362,"user":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T18:38:16Z","updated_at":"2016-08-28T18:38:16Z","body":"That's what `**` in your node_modules glob is doing (traversing).  Remove the `**` and it won't traverse but it still removes those files from the result.\r\n\r\nSupport questions should be directed to StackOverflow."}}
{"actor":{"display_login":"phated"}}