{"action":"created","issue":{"url":"https://api.github.com/repos/draios/falco/issues/79","repository_url":"https://api.github.com/repos/draios/falco","labels_url":"https://api.github.com/repos/draios/falco/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/draios/falco/issues/79/comments","events_url":"https://api.github.com/repos/draios/falco/issues/79/events","html_url":"https://github.com/draios/falco/issues/79","id":155680654,"number":79,"title":"Complete quoting for parameters of some CMake commands","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/draios/falco/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"mstemm","id":13422831,"avatar_url":"https://avatars.githubusercontent.com/u/13422831?v=3","gravatar_id":"","url":"https://api.github.com/users/mstemm","html_url":"https://github.com/mstemm","followers_url":"https://api.github.com/users/mstemm/followers","following_url":"https://api.github.com/users/mstemm/following{/other_user}","gists_url":"https://api.github.com/users/mstemm/gists{/gist_id}","starred_url":"https://api.github.com/users/mstemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstemm/subscriptions","organizations_url":"https://api.github.com/users/mstemm/orgs","repos_url":"https://api.github.com/users/mstemm/repos","events_url":"https://api.github.com/users/mstemm/events{/privacy}","received_events_url":"https://api.github.com/users/mstemm/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-05-19T08:30:20Z","updated_at":"2016-05-24T00:39:07Z","closed_at":null,"body":"Some parameters (like \"[${SYSDIG_DIR}/driver](https://github.com/draios/falco/blob/acfa8e768669952cd7f24e02f67dca7bdd906193/CMakeLists.txt#L183)\" and \"[${PROJECT_SOURCE_DIR}/scripts/debian/falco](https://github.com/draios/falco/blob/cfc89127e75c820ebcaa6c8b7547cb0e64411842/scripts/CMakeLists.txt#L1)\") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.\r\n\r\nI would recommend to apply [advices from a wiki article](https://cmake.org/Wiki/CMake/Language_Syntax#CMake_splits_arguments_unless_you_use_quotation_marks_or_escapes. \"CMake splits arguments unless you use quotation marks or escapes.\")."},"comment":{"url":"https://api.github.com/repos/draios/falco/issues/comments/221136050","html_url":"https://github.com/draios/falco/issues/79#issuecomment-221136050","issue_url":"https://api.github.com/repos/draios/falco/issues/79","id":221136050,"user":{"login":"mstemm","id":13422831,"avatar_url":"https://avatars.githubusercontent.com/u/13422831?v=3","gravatar_id":"","url":"https://api.github.com/users/mstemm","html_url":"https://github.com/mstemm","followers_url":"https://api.github.com/users/mstemm/followers","following_url":"https://api.github.com/users/mstemm/following{/other_user}","gists_url":"https://api.github.com/users/mstemm/gists{/gist_id}","starred_url":"https://api.github.com/users/mstemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstemm/subscriptions","organizations_url":"https://api.github.com/users/mstemm/orgs","repos_url":"https://api.github.com/users/mstemm/repos","events_url":"https://api.github.com/users/mstemm/events{/privacy}","received_events_url":"https://api.github.com/users/mstemm/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T00:39:07Z","updated_at":"2016-05-24T00:39:07Z","body":"Thanks, fix otw."}}
{"actor":{"display_login":"mstemm"}}