{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments/49309959","id":49309959,"diff_hunk":"@@ -53,6 +72,13 @@ class IdentityServiceRequestHandler (ws: WSClient) extends IdentityClientRequest\n           logger.warn(s\"Unexpected response from server: ${response.status} ${response.statusText} ${response.body}\")\n           Left(Seq(GatewayError(\"Unexpected response from server\")))\n         }\n+    case r: RegisterApiRequest =>\n+      response.json.asOpt[RegisterResponse]\n+      .map(Right.apply)","path":"app/com/gu/identity/frontend/services/IdentityServiceRequestHandler.scala","position":47,"original_position":47,"commit_id":"44ea6634665bb9db55b7328b246caa5262facbd4","original_commit_id":"44ea6634665bb9db55b7328b246caa5262facbd4","user":{"login":"jamespamplin","id":2298529,"avatar_url":"https://avatars.githubusercontent.com/u/2298529?v=3","gravatar_id":"","url":"https://api.github.com/users/jamespamplin","html_url":"https://github.com/jamespamplin","followers_url":"https://api.github.com/users/jamespamplin/followers","following_url":"https://api.github.com/users/jamespamplin/following{/other_user}","gists_url":"https://api.github.com/users/jamespamplin/gists{/gist_id}","starred_url":"https://api.github.com/users/jamespamplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamespamplin/subscriptions","organizations_url":"https://api.github.com/users/jamespamplin/orgs","repos_url":"https://api.github.com/users/jamespamplin/repos","events_url":"https://api.github.com/users/jamespamplin/events{/privacy}","received_events_url":"https://api.github.com/users/jamespamplin/received_events","type":"User","site_admin":false},"body":"Indentation here is a bit off.","created_at":"2016-01-11T11:09:45Z","updated_at":"2016-01-11T11:09:45Z","html_url":"https://github.com/guardian/identity-frontend/pull/50#discussion_r49309959","pull_request_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments/49309959"},"html":{"href":"https://github.com/guardian/identity-frontend/pull/50#discussion_r49309959"},"pull_request":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/identity-frontend/pulls/50","id":55456293,"html_url":"https://github.com/guardian/identity-frontend/pull/50","diff_url":"https://github.com/guardian/identity-frontend/pull/50.diff","patch_url":"https://github.com/guardian/identity-frontend/pull/50.patch","issue_url":"https://api.github.com/repos/guardian/identity-frontend/issues/50","number":50,"state":"open","locked":false,"title":"Register endpoint","user":{"login":"susiecoleman","id":6666113,"avatar_url":"https://avatars.githubusercontent.com/u/6666113?v=3","gravatar_id":"","url":"https://api.github.com/users/susiecoleman","html_url":"https://github.com/susiecoleman","followers_url":"https://api.github.com/users/susiecoleman/followers","following_url":"https://api.github.com/users/susiecoleman/following{/other_user}","gists_url":"https://api.github.com/users/susiecoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/susiecoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susiecoleman/subscriptions","organizations_url":"https://api.github.com/users/susiecoleman/orgs","repos_url":"https://api.github.com/users/susiecoleman/repos","events_url":"https://api.github.com/users/susiecoleman/events{/privacy}","received_events_url":"https://api.github.com/users/susiecoleman/received_events","type":"User","site_admin":false},"body":"The first pass:\r\nFeatures already listed in the ticket for the 2nd pass are:\r\n- Specific error messages\r\n- Handling skip confirmation\r\n- Handling T&Cs\r\n- Where(and what) form input validation will be performed","created_at":"2016-01-08T12:26:05Z","updated_at":"2016-01-11T11:09:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dfde44f652f4e4c936b240c3e181f89c24c7b12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/50/commits","review_comments_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/50/comments","review_comment_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/issues/50/comments","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/44ea6634665bb9db55b7328b246caa5262facbd4","head":{"label":"guardian:register-endpoint","ref":"register-endpoint","sha":"44ea6634665bb9db55b7328b246caa5262facbd4","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":45927868,"name":"identity-frontend","full_name":"guardian/identity-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/identity-frontend","description":"Frontend for sign-in and registration at theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/identity-frontend","forks_url":"https://api.github.com/repos/guardian/identity-frontend/forks","keys_url":"https://api.github.com/repos/guardian/identity-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/identity-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-frontend/events","assignees_url":"https://api.github.com/repos/guardian/identity-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/identity-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/identity-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-frontend/merges","archive_url":"https://api.github.com/repos/guardian/identity-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/identity-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-frontend/releases{/id}","created_at":"2015-11-10T17:19:02Z","updated_at":"2016-01-11T10:39:32Z","pushed_at":"2016-01-11T10:39:32Z","git_url":"git://github.com/guardian/identity-frontend.git","ssh_url":"git@github.com:guardian/identity-frontend.git","clone_url":"https://github.com/guardian/identity-frontend.git","svn_url":"https://github.com/guardian/identity-frontend","homepage":"","size":2878,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"2d18d68c02c8f2c3a494c77d0037d4b474718fbe","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":45927868,"name":"identity-frontend","full_name":"guardian/identity-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/identity-frontend","description":"Frontend for sign-in and registration at theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/identity-frontend","forks_url":"https://api.github.com/repos/guardian/identity-frontend/forks","keys_url":"https://api.github.com/repos/guardian/identity-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/identity-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-frontend/events","assignees_url":"https://api.github.com/repos/guardian/identity-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/identity-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/identity-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-frontend/merges","archive_url":"https://api.github.com/repos/guardian/identity-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/identity-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-frontend/releases{/id}","created_at":"2015-11-10T17:19:02Z","updated_at":"2016-01-11T10:39:32Z","pushed_at":"2016-01-11T10:39:32Z","git_url":"git://github.com/guardian/identity-frontend.git","ssh_url":"git@github.com:guardian/identity-frontend.git","clone_url":"https://github.com/guardian/identity-frontend.git","svn_url":"https://github.com/guardian/identity-frontend","homepage":"","size":2878,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/50"},"html":{"href":"https://github.com/guardian/identity-frontend/pull/50"},"issue":{"href":"https://api.github.com/repos/guardian/identity-frontend/issues/50"},"comments":{"href":"https://api.github.com/repos/guardian/identity-frontend/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/identity-frontend/statuses/44ea6634665bb9db55b7328b246caa5262facbd4"}}}}