{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/80242008","id":80242008,"diff_hunk":"@@ -99,10 +99,17 @@ public MetricRegistry(Configuration config) {\n \t\t\t\tDelegatingConfiguration reporterConfig = new DelegatingConfiguration(config, ConfigConstants.METRICS_REPORTER_PREFIX + namedReporter + \".\");\n \t\t\t\tfinal String className = reporterConfig.getString(ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX, null);\n \t\t\t\tif (className == null) {\n-\t\t\t\t\tLOG.error(\"No reporter class set for reporter \" + namedReporter + \". Metrics might not be exposed/reported.\");\n+\t\t\t\t\tLOG.error(\"No reporter class set for reporter {}. Metrics might not be exposed/reported.\",namedReporter);\n \t\t\t\t\tcontinue;\n \t\t\t\t}\n \n+\t\t\t\tString delimiterForReporter = reporterConfig.getString(ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,defaultDelimiter);\n+\t\t\t\tif(delimiterForReporter.length()!=1){\n+\t\t\t\t\tLOG.warn(\"Failed to parse delimiter for reporter {}, using global delimiter.\",namedReporter);","path":"flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java","position":51,"original_position":51,"commit_id":"b9df49b7cea72679dbf70b7cb02607bb899f1b4c","original_commit_id":"b9df49b7cea72679dbf70b7cb02607bb899f1b4c","user":{"login":"zentol","id":5725237,"avatar_url":"https://avatars.githubusercontent.com/u/5725237?v=3","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"body":"and possibly the what was parsed.","created_at":"2016-09-23T13:18:26Z","updated_at":"2016-09-23T13:21:24Z","html_url":"https://github.com/apache/flink/pull/2517#discussion_r80242008","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/2517","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/80242008"},"html":{"href":"https://github.com/apache/flink/pull/2517#discussion_r80242008"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/2517"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2517","id":85946795,"html_url":"https://github.com/apache/flink/pull/2517","diff_url":"https://github.com/apache/flink/pull/2517.diff","patch_url":"https://github.com/apache/flink/pull/2517.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/2517","number":2517,"state":"open","locked":false,"title":"[FLINK-4564] [metrics] Delimiter should be configured per reporter","user":{"login":"ex00","id":13835761,"avatar_url":"https://avatars.githubusercontent.com/u/13835761?v=3","gravatar_id":"","url":"https://api.github.com/users/ex00","html_url":"https://github.com/ex00","followers_url":"https://api.github.com/users/ex00/followers","following_url":"https://api.github.com/users/ex00/following{/other_user}","gists_url":"https://api.github.com/users/ex00/gists{/gist_id}","starred_url":"https://api.github.com/users/ex00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex00/subscriptions","organizations_url":"https://api.github.com/users/ex00/orgs","repos_url":"https://api.github.com/users/ex00/repos","events_url":"https://api.github.com/users/ex00/events{/privacy}","received_events_url":"https://api.github.com/users/ex00/received_events","type":"User","site_admin":false},"body":"Hi\r\nIt is my fix FLINK-4564. I want fix this issue, please send me your comments about this implementation.\r\nI could assign to me [issue](https://issues.apache.org/jira/browse/FLINK-4564) in jira?\r\nThanks.","created_at":"2016-09-20T10:13:33Z","updated_at":"2016-09-23T13:21:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbd9386d6d21384b1729744bea62febe17373d2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/2517/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/2517/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/2517/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/b9df49b7cea72679dbf70b7cb02607bb899f1b4c","head":{"label":"ex00:FLINK-4564","ref":"FLINK-4564","sha":"b9df49b7cea72679dbf70b7cb02607bb899f1b4c","user":{"login":"ex00","id":13835761,"avatar_url":"https://avatars.githubusercontent.com/u/13835761?v=3","gravatar_id":"","url":"https://api.github.com/users/ex00","html_url":"https://github.com/ex00","followers_url":"https://api.github.com/users/ex00/followers","following_url":"https://api.github.com/users/ex00/following{/other_user}","gists_url":"https://api.github.com/users/ex00/gists{/gist_id}","starred_url":"https://api.github.com/users/ex00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex00/subscriptions","organizations_url":"https://api.github.com/users/ex00/orgs","repos_url":"https://api.github.com/users/ex00/repos","events_url":"https://api.github.com/users/ex00/events{/privacy}","received_events_url":"https://api.github.com/users/ex00/received_events","type":"User","site_admin":false},"repo":{"id":68594087,"name":"flink","full_name":"ex00/flink","owner":{"login":"ex00","id":13835761,"avatar_url":"https://avatars.githubusercontent.com/u/13835761?v=3","gravatar_id":"","url":"https://api.github.com/users/ex00","html_url":"https://github.com/ex00","followers_url":"https://api.github.com/users/ex00/followers","following_url":"https://api.github.com/users/ex00/following{/other_user}","gists_url":"https://api.github.com/users/ex00/gists{/gist_id}","starred_url":"https://api.github.com/users/ex00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ex00/subscriptions","organizations_url":"https://api.github.com/users/ex00/orgs","repos_url":"https://api.github.com/users/ex00/repos","events_url":"https://api.github.com/users/ex00/events{/privacy}","received_events_url":"https://api.github.com/users/ex00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ex00/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/ex00/flink","forks_url":"https://api.github.com/repos/ex00/flink/forks","keys_url":"https://api.github.com/repos/ex00/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ex00/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ex00/flink/teams","hooks_url":"https://api.github.com/repos/ex00/flink/hooks","issue_events_url":"https://api.github.com/repos/ex00/flink/issues/events{/number}","events_url":"https://api.github.com/repos/ex00/flink/events","assignees_url":"https://api.github.com/repos/ex00/flink/assignees{/user}","branches_url":"https://api.github.com/repos/ex00/flink/branches{/branch}","tags_url":"https://api.github.com/repos/ex00/flink/tags","blobs_url":"https://api.github.com/repos/ex00/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ex00/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ex00/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/ex00/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ex00/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/ex00/flink/languages","stargazers_url":"https://api.github.com/repos/ex00/flink/stargazers","contributors_url":"https://api.github.com/repos/ex00/flink/contributors","subscribers_url":"https://api.github.com/repos/ex00/flink/subscribers","subscription_url":"https://api.github.com/repos/ex00/flink/subscription","commits_url":"https://api.github.com/repos/ex00/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/ex00/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/ex00/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/ex00/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/ex00/flink/contents/{+path}","compare_url":"https://api.github.com/repos/ex00/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ex00/flink/merges","archive_url":"https://api.github.com/repos/ex00/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ex00/flink/downloads","issues_url":"https://api.github.com/repos/ex00/flink/issues{/number}","pulls_url":"https://api.github.com/repos/ex00/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/ex00/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/ex00/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ex00/flink/labels{/name}","releases_url":"https://api.github.com/repos/ex00/flink/releases{/id}","deployments_url":"https://api.github.com/repos/ex00/flink/deployments","created_at":"2016-09-19T10:10:58Z","updated_at":"2016-09-19T10:11:19Z","pushed_at":"2016-09-23T12:15:24Z","git_url":"git://github.com/ex00/flink.git","ssh_url":"git@github.com:ex00/flink.git","clone_url":"https://github.com/ex00/flink.git","svn_url":"https://github.com/ex00/flink","homepage":null,"size":93016,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5066125f9a377d232f77f6fbcac3c22ebea66b39","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-09-23T04:23:34Z","pushed_at":"2016-09-23T13:14:26Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":126900,"stargazers_count":1595,"watchers_count":1595,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1071,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":150,"forks":1071,"open_issues":150,"watchers":1595,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/2517"},"html":{"href":"https://github.com/apache/flink/pull/2517"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/2517"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/2517/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/2517/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/2517/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/b9df49b7cea72679dbf70b7cb02607bb899f1b4c"}}}}
{"actor":{"display_login":"zentol"}}