{"action":"closed","number":622,"pull_request":{"url":"https://api.github.com/repos/openMVG/openMVG/pulls/622","id":84656686,"html_url":"https://github.com/openMVG/openMVG/pull/622","diff_url":"https://github.com/openMVG/openMVG/pull/622.diff","patch_url":"https://github.com/openMVG/openMVG/pull/622.patch","issue_url":"https://api.github.com/repos/openMVG/openMVG/issues/622","number":622,"state":"closed","locked":false,"title":"Develop fast resection","user":{"login":"hcjghr","id":1965036,"avatar_url":"https://avatars.githubusercontent.com/u/1965036?v=3","gravatar_id":"","url":"https://api.github.com/users/hcjghr","html_url":"https://github.com/hcjghr","followers_url":"https://api.github.com/users/hcjghr/followers","following_url":"https://api.github.com/users/hcjghr/following{/other_user}","gists_url":"https://api.github.com/users/hcjghr/gists{/gist_id}","starred_url":"https://api.github.com/users/hcjghr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcjghr/subscriptions","organizations_url":"https://api.github.com/users/hcjghr/orgs","repos_url":"https://api.github.com/users/hcjghr/repos","events_url":"https://api.github.com/users/hcjghr/events{/privacy}","received_events_url":"https://api.github.com/users/hcjghr/received_events","type":"User","site_admin":false},"body":"Hi @pmoulon,\r\n\r\nAs I was reconstructing a model with approx. 2000 views I noticed that the augmentation of already reconstructed landmarks and triangulation of new ones in the resection method took significant amount of time (in my case after  around 1000 views were added only this part of resection took 13s).  \r\n\r\nThe reason was that the procedure took each already reconstructed view and found all the tracks that are in common with the newly added view. These tracks were then searched to find the tracks that were already reconstructed (and so the new observations could be added) or new landmark can be created through the triangulation process between the steps. As the number of reconstructed views increased this took longer and longer.\r\n\r\nIn the method I propose the procedure takes all the tracks that are seen in the newly added view and check each of them to see if it was already reconstructed (only add the observation from the current view)  and if not checks all the views that see each track. From the views that have already been reconstructed it tries to triangulate a new landmark and add the rest as observations.\r\n\r\nIn the same dataset this reduced the computational time of this step to approx 1.5s.\r\n\r\nIs this a valid thinking or am I missing an important fact for which reason the \"old\" procedure should be used?\r\n\r\nbest\r\n\r\n","created_at":"2016-09-09T14:06:34Z","updated_at":"2016-09-12T08:40:26Z","closed_at":"2016-09-12T08:40:26Z","merged_at":"2016-09-12T08:40:26Z","merge_commit_sha":"558c596f3ea36e799b42ab448afb15367ca6ae50","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openMVG/openMVG/pulls/622/commits","review_comments_url":"https://api.github.com/repos/openMVG/openMVG/pulls/622/comments","review_comment_url":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openMVG/openMVG/issues/622/comments","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/558c596f3ea36e799b42ab448afb15367ca6ae50","head":{"label":"hcjghr:develop_fast_resection","ref":"develop_fast_resection","sha":"558c596f3ea36e799b42ab448afb15367ca6ae50","user":{"login":"hcjghr","id":1965036,"avatar_url":"https://avatars.githubusercontent.com/u/1965036?v=3","gravatar_id":"","url":"https://api.github.com/users/hcjghr","html_url":"https://github.com/hcjghr","followers_url":"https://api.github.com/users/hcjghr/followers","following_url":"https://api.github.com/users/hcjghr/following{/other_user}","gists_url":"https://api.github.com/users/hcjghr/gists{/gist_id}","starred_url":"https://api.github.com/users/hcjghr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcjghr/subscriptions","organizations_url":"https://api.github.com/users/hcjghr/orgs","repos_url":"https://api.github.com/users/hcjghr/repos","events_url":"https://api.github.com/users/hcjghr/events{/privacy}","received_events_url":"https://api.github.com/users/hcjghr/received_events","type":"User","site_admin":false},"repo":{"id":47817821,"name":"openMVG","full_name":"hcjghr/openMVG","owner":{"login":"hcjghr","id":1965036,"avatar_url":"https://avatars.githubusercontent.com/u/1965036?v=3","gravatar_id":"","url":"https://api.github.com/users/hcjghr","html_url":"https://github.com/hcjghr","followers_url":"https://api.github.com/users/hcjghr/followers","following_url":"https://api.github.com/users/hcjghr/following{/other_user}","gists_url":"https://api.github.com/users/hcjghr/gists{/gist_id}","starred_url":"https://api.github.com/users/hcjghr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcjghr/subscriptions","organizations_url":"https://api.github.com/users/hcjghr/orgs","repos_url":"https://api.github.com/users/hcjghr/repos","events_url":"https://api.github.com/users/hcjghr/events{/privacy}","received_events_url":"https://api.github.com/users/hcjghr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hcjghr/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/hcjghr/openMVG","forks_url":"https://api.github.com/repos/hcjghr/openMVG/forks","keys_url":"https://api.github.com/repos/hcjghr/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcjghr/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcjghr/openMVG/teams","hooks_url":"https://api.github.com/repos/hcjghr/openMVG/hooks","issue_events_url":"https://api.github.com/repos/hcjghr/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/hcjghr/openMVG/events","assignees_url":"https://api.github.com/repos/hcjghr/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/hcjghr/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/hcjghr/openMVG/tags","blobs_url":"https://api.github.com/repos/hcjghr/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcjghr/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcjghr/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcjghr/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcjghr/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/hcjghr/openMVG/languages","stargazers_url":"https://api.github.com/repos/hcjghr/openMVG/stargazers","contributors_url":"https://api.github.com/repos/hcjghr/openMVG/contributors","subscribers_url":"https://api.github.com/repos/hcjghr/openMVG/subscribers","subscription_url":"https://api.github.com/repos/hcjghr/openMVG/subscription","commits_url":"https://api.github.com/repos/hcjghr/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcjghr/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcjghr/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcjghr/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcjghr/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/hcjghr/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcjghr/openMVG/merges","archive_url":"https://api.github.com/repos/hcjghr/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcjghr/openMVG/downloads","issues_url":"https://api.github.com/repos/hcjghr/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/hcjghr/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/hcjghr/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/hcjghr/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcjghr/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/hcjghr/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/hcjghr/openMVG/deployments","created_at":"2015-12-11T09:37:32Z","updated_at":"2016-06-22T11:43:00Z","pushed_at":"2016-09-09T14:47:08Z","git_url":"git://github.com/hcjghr/openMVG.git","ssh_url":"git@github.com:hcjghr/openMVG.git","clone_url":"https://github.com/hcjghr/openMVG.git","svn_url":"https://github.com/hcjghr/openMVG","homepage":"","size":24604,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openMVG:develop","ref":"develop","sha":"e791ba38d88bb290639915ef9c53cf4c47f83efc","user":{"login":"openMVG","id":3512104,"avatar_url":"https://avatars.githubusercontent.com/u/3512104?v=3","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"repo":{"id":8096326,"name":"openMVG","full_name":"openMVG/openMVG","owner":{"login":"openMVG","id":3512104,"avatar_url":"https://avatars.githubusercontent.com/u/3512104?v=3","gravatar_id":"","url":"https://api.github.com/users/openMVG","html_url":"https://github.com/openMVG","followers_url":"https://api.github.com/users/openMVG/followers","following_url":"https://api.github.com/users/openMVG/following{/other_user}","gists_url":"https://api.github.com/users/openMVG/gists{/gist_id}","starred_url":"https://api.github.com/users/openMVG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMVG/subscriptions","organizations_url":"https://api.github.com/users/openMVG/orgs","repos_url":"https://api.github.com/users/openMVG/repos","events_url":"https://api.github.com/users/openMVG/events{/privacy}","received_events_url":"https://api.github.com/users/openMVG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openMVG/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":false,"url":"https://api.github.com/repos/openMVG/openMVG","forks_url":"https://api.github.com/repos/openMVG/openMVG/forks","keys_url":"https://api.github.com/repos/openMVG/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openMVG/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openMVG/openMVG/teams","hooks_url":"https://api.github.com/repos/openMVG/openMVG/hooks","issue_events_url":"https://api.github.com/repos/openMVG/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/openMVG/openMVG/events","assignees_url":"https://api.github.com/repos/openMVG/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/openMVG/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/openMVG/openMVG/tags","blobs_url":"https://api.github.com/repos/openMVG/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openMVG/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openMVG/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/openMVG/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openMVG/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/openMVG/openMVG/languages","stargazers_url":"https://api.github.com/repos/openMVG/openMVG/stargazers","contributors_url":"https://api.github.com/repos/openMVG/openMVG/contributors","subscribers_url":"https://api.github.com/repos/openMVG/openMVG/subscribers","subscription_url":"https://api.github.com/repos/openMVG/openMVG/subscription","commits_url":"https://api.github.com/repos/openMVG/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/openMVG/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/openMVG/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/openMVG/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/openMVG/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/openMVG/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openMVG/openMVG/merges","archive_url":"https://api.github.com/repos/openMVG/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openMVG/openMVG/downloads","issues_url":"https://api.github.com/repos/openMVG/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/openMVG/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/openMVG/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/openMVG/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openMVG/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/openMVG/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/openMVG/openMVG/deployments","created_at":"2013-02-08T16:01:08Z","updated_at":"2016-09-12T07:41:23Z","pushed_at":"2016-09-12T08:40:24Z","git_url":"git://github.com/openMVG/openMVG.git","ssh_url":"git@github.com:openMVG/openMVG.git","clone_url":"https://github.com/openMVG/openMVG.git","svn_url":"https://github.com/openMVG/openMVG","homepage":"","size":26792,"stargazers_count":779,"watchers_count":779,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":384,"mirror_url":null,"open_issues_count":32,"forks":384,"open_issues":32,"watchers":779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/622"},"html":{"href":"https://github.com/openMVG/openMVG/pull/622"},"issue":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/622"},"comments":{"href":"https://api.github.com/repos/openMVG/openMVG/issues/622/comments"},"review_comments":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/622/comments"},"review_comment":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openMVG/openMVG/pulls/622/commits"},"statuses":{"href":"https://api.github.com/repos/openMVG/openMVG/statuses/558c596f3ea36e799b42ab448afb15367ca6ae50"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pmoulon","id":3235050,"avatar_url":"https://avatars.githubusercontent.com/u/3235050?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoulon","html_url":"https://github.com/pmoulon","followers_url":"https://api.github.com/users/pmoulon/followers","following_url":"https://api.github.com/users/pmoulon/following{/other_user}","gists_url":"https://api.github.com/users/pmoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoulon/subscriptions","organizations_url":"https://api.github.com/users/pmoulon/orgs","repos_url":"https://api.github.com/users/pmoulon/repos","events_url":"https://api.github.com/users/pmoulon/events{/privacy}","received_events_url":"https://api.github.com/users/pmoulon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":5,"commits":5,"additions":112,"deletions":117,"changed_files":1}}
{"actor":{"display_login":"pmoulon"}}