{"action":"created","issue":{"url":"https://api.github.com/repos/airbnb/airpal/issues/179","repository_url":"https://api.github.com/repos/airbnb/airpal","labels_url":"https://api.github.com/repos/airbnb/airpal/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/airbnb/airpal/issues/179/comments","events_url":"https://api.github.com/repos/airbnb/airpal/issues/179/events","html_url":"https://github.com/airbnb/airpal/pull/179","id":155607333,"number":179,"title":"Support for Presto 0.145 (work in progress)","user":{"login":"gwittel","id":484093,"avatar_url":"https://avatars.githubusercontent.com/u/484093?v=3","gravatar_id":"","url":"https://api.github.com/users/gwittel","html_url":"https://github.com/gwittel","followers_url":"https://api.github.com/users/gwittel/followers","following_url":"https://api.github.com/users/gwittel/following{/other_user}","gists_url":"https://api.github.com/users/gwittel/gists{/gist_id}","starred_url":"https://api.github.com/users/gwittel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwittel/subscriptions","organizations_url":"https://api.github.com/users/gwittel/orgs","repos_url":"https://api.github.com/users/gwittel/repos","events_url":"https://api.github.com/users/gwittel/events{/privacy}","received_events_url":"https://api.github.com/users/gwittel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-05-18T21:36:34Z","updated_at":"2016-08-23T17:01:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/airbnb/airpal/pulls/179","html_url":"https://github.com/airbnb/airpal/pull/179","diff_url":"https://github.com/airbnb/airpal/pull/179.diff","patch_url":"https://github.com/airbnb/airpal/pull/179.patch"},"body":"Opening this PR per request in Issue https://github.com/airbnb/airpal/issues/145#issuecomment-220160512.  Unfortunately I don't have time to work further on this, so hopefully someone can take this and run with it.\r\n\r\nPlease note that all caveats mentioned in that thread still apply (see my comment here https://github.com/airbnb/airpal/issues/145#issuecomment-216400626).  This PR represents a work in progress.  It compiles, and launches.  However, I was unable to test functionality end to end.  I'm not confident that things all work.\r\n\r\nTwo main risk points I'm less confident with my changes:\r\n\r\n* The main thing that is likely broken is the Column type field mapping. The API isn't well documented and I just took a guess at what was needed (I didn't have a Hive cluster handy to compare output of SHOW COLUMNS FOR). This impacts the column cache (HiveColumn). When querying a table I do get an exception related to this, but I don't have the time to debug further at the moment.\r\n* Shiro -- Several APIs changed and while I think I've migrated the code to match the original intent (basically its about how principals and subjects are injected), I haven't checked/tested it in any way\r\n"},"comment":{"url":"https://api.github.com/repos/airbnb/airpal/issues/comments/241801722","html_url":"https://github.com/airbnb/airpal/pull/179#issuecomment-241801722","issue_url":"https://api.github.com/repos/airbnb/airpal/issues/179","id":241801722,"user":{"login":"gwittel","id":484093,"avatar_url":"https://avatars.githubusercontent.com/u/484093?v=3","gravatar_id":"","url":"https://api.github.com/users/gwittel","html_url":"https://github.com/gwittel","followers_url":"https://api.github.com/users/gwittel/followers","following_url":"https://api.github.com/users/gwittel/following{/other_user}","gists_url":"https://api.github.com/users/gwittel/gists{/gist_id}","starred_url":"https://api.github.com/users/gwittel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwittel/subscriptions","organizations_url":"https://api.github.com/users/gwittel/orgs","repos_url":"https://api.github.com/users/gwittel/repos","events_url":"https://api.github.com/users/gwittel/events{/privacy}","received_events_url":"https://api.github.com/users/gwittel/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T17:01:18Z","updated_at":"2016-08-23T17:01:18Z","body":"Done. Seems to work but would be good to confirm if you have a real vs dev environment to test against."}}
{"actor":{"display_login":"gwittel"}}