{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/comments/66388899","id":66388899,"diff_hunk":"@@ -23,7 +23,7 @@ type tCertPool interface {\n \n \tStop() error\n \n-\tGetNextTCert() (tCert, error)\n+\tGetNextTCert(attributes []string) (*TCertBlock, error)","path":"core/crypto/client_tcert_pool.go","position":5,"original_position":5,"commit_id":"5c0b36aa5b755f332d5967ee536b91b0f29618f5","original_commit_id":"5c0b36aa5b755f332d5967ee536b91b0f29618f5","user":{"login":"adecaro","id":782238,"avatar_url":"https://avatars.githubusercontent.com/u/782238?v=3","gravatar_id":"","url":"https://api.github.com/users/adecaro","html_url":"https://github.com/adecaro","followers_url":"https://api.github.com/users/adecaro/followers","following_url":"https://api.github.com/users/adecaro/following{/other_user}","gists_url":"https://api.github.com/users/adecaro/gists{/gist_id}","starred_url":"https://api.github.com/users/adecaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adecaro/subscriptions","organizations_url":"https://api.github.com/users/adecaro/orgs","repos_url":"https://api.github.com/users/adecaro/repos","events_url":"https://api.github.com/users/adecaro/events{/privacy}","received_events_url":"https://api.github.com/users/adecaro/received_events","type":"User","site_admin":false},"body":"Shall TCertBlock be an internal interface?","created_at":"2016-06-09T06:28:28Z","updated_at":"2016-06-09T06:28:28Z","html_url":"https://github.com/hyperledger/fabric/pull/1763#discussion_r66388899","pull_request_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1763","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/comments/66388899"},"html":{"href":"https://github.com/hyperledger/fabric/pull/1763#discussion_r66388899"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1763"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/fabric/pulls/1763","id":73161224,"html_url":"https://github.com/hyperledger/fabric/pull/1763","diff_url":"https://github.com/hyperledger/fabric/pull/1763.diff","patch_url":"https://github.com/hyperledger/fabric/pull/1763.patch","issue_url":"https://api.github.com/repos/hyperledger/fabric/issues/1763","number":1763,"state":"open","locked":false,"title":"Client and chaincode support for attributes","user":{"login":"andresgaragiola","id":1229370,"avatar_url":"https://avatars.githubusercontent.com/u/1229370?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgaragiola","html_url":"https://github.com/andresgaragiola","followers_url":"https://api.github.com/users/andresgaragiola/followers","following_url":"https://api.github.com/users/andresgaragiola/following{/other_user}","gists_url":"https://api.github.com/users/andresgaragiola/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgaragiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgaragiola/subscriptions","organizations_url":"https://api.github.com/users/andresgaragiola/orgs","repos_url":"https://api.github.com/users/andresgaragiola/repos","events_url":"https://api.github.com/users/andresgaragiola/events{/privacy}","received_events_url":"https://api.github.com/users/andresgaragiola/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis is the last PR of PR #1513 split into smaller PR's we were doing it with @diegomasini, @jeronimoirazabal, @raullaprida and @gromeroar. It includes the client and chaincode functions needed for Attribute Management.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nThis is a required feature to address #1139\r\n\r\n## How Has This Been Tested?\r\nCurrent behave tests has been run without errors.\r\nCurrent unit tests has been run without errors.\r\nAdditional unit tests where included (attr_support_test.go and in file crypto_test.go).\r\nA new behave test is pending we will work with @jeffgarratt on that.\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff)\r\n- [X] I added new documentation (update to attributes.md)\r\n- [X] I added new tests\r\n- [X] I have run [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go vet](https://golang.org/cmd/vet/), and [golint](https://github.com/golang/lint). I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.\r\n\r\nSigned-off-by: Andres Garagiola andresgaragiola@gmail.com / garagiol@ar.ibm.com \r\n","created_at":"2016-06-09T06:01:53Z","updated_at":"2016-06-09T06:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c86bf24185875cfd1654041cf010fb5f6f130b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1763/commits","review_comments_url":"https://api.github.com/repos/hyperledger/fabric/pulls/1763/comments","review_comment_url":"https://api.github.com/repos/hyperledger/fabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/fabric/issues/1763/comments","statuses_url":"https://api.github.com/repos/hyperledger/fabric/statuses/5c0b36aa5b755f332d5967ee536b91b0f29618f5","head":{"label":"andresgaragiola:attributes-chaincode","ref":"attributes-chaincode","sha":"5c0b36aa5b755f332d5967ee536b91b0f29618f5","user":{"login":"andresgaragiola","id":1229370,"avatar_url":"https://avatars.githubusercontent.com/u/1229370?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgaragiola","html_url":"https://github.com/andresgaragiola","followers_url":"https://api.github.com/users/andresgaragiola/followers","following_url":"https://api.github.com/users/andresgaragiola/following{/other_user}","gists_url":"https://api.github.com/users/andresgaragiola/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgaragiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgaragiola/subscriptions","organizations_url":"https://api.github.com/users/andresgaragiola/orgs","repos_url":"https://api.github.com/users/andresgaragiola/repos","events_url":"https://api.github.com/users/andresgaragiola/events{/privacy}","received_events_url":"https://api.github.com/users/andresgaragiola/received_events","type":"User","site_admin":false},"repo":{"id":56091071,"name":"fabric","full_name":"andresgaragiola/fabric","owner":{"login":"andresgaragiola","id":1229370,"avatar_url":"https://avatars.githubusercontent.com/u/1229370?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgaragiola","html_url":"https://github.com/andresgaragiola","followers_url":"https://api.github.com/users/andresgaragiola/followers","following_url":"https://api.github.com/users/andresgaragiola/following{/other_user}","gists_url":"https://api.github.com/users/andresgaragiola/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgaragiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgaragiola/subscriptions","organizations_url":"https://api.github.com/users/andresgaragiola/orgs","repos_url":"https://api.github.com/users/andresgaragiola/repos","events_url":"https://api.github.com/users/andresgaragiola/events{/privacy}","received_events_url":"https://api.github.com/users/andresgaragiola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andresgaragiola/fabric","description":"Fabric is a blockchain project in Incubation proposed to the community and documented at https://docs.google.com/document/d/1XECRVN9hXGrjAjysrnuNSdggzAKYm6XESR6KmABwhkE.  Information on what Incubation entails can be found in the Hyperledger Project Lifecycle document (https://github.com/hyperledger/hyperledger/wiki/Project-Lifecycle)","fork":true,"url":"https://api.github.com/repos/andresgaragiola/fabric","forks_url":"https://api.github.com/repos/andresgaragiola/fabric/forks","keys_url":"https://api.github.com/repos/andresgaragiola/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andresgaragiola/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andresgaragiola/fabric/teams","hooks_url":"https://api.github.com/repos/andresgaragiola/fabric/hooks","issue_events_url":"https://api.github.com/repos/andresgaragiola/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/andresgaragiola/fabric/events","assignees_url":"https://api.github.com/repos/andresgaragiola/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/andresgaragiola/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/andresgaragiola/fabric/tags","blobs_url":"https://api.github.com/repos/andresgaragiola/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andresgaragiola/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andresgaragiola/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/andresgaragiola/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andresgaragiola/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/andresgaragiola/fabric/languages","stargazers_url":"https://api.github.com/repos/andresgaragiola/fabric/stargazers","contributors_url":"https://api.github.com/repos/andresgaragiola/fabric/contributors","subscribers_url":"https://api.github.com/repos/andresgaragiola/fabric/subscribers","subscription_url":"https://api.github.com/repos/andresgaragiola/fabric/subscription","commits_url":"https://api.github.com/repos/andresgaragiola/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/andresgaragiola/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/andresgaragiola/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/andresgaragiola/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/andresgaragiola/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/andresgaragiola/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andresgaragiola/fabric/merges","archive_url":"https://api.github.com/repos/andresgaragiola/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andresgaragiola/fabric/downloads","issues_url":"https://api.github.com/repos/andresgaragiola/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/andresgaragiola/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/andresgaragiola/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/andresgaragiola/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andresgaragiola/fabric/labels{/name}","releases_url":"https://api.github.com/repos/andresgaragiola/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/andresgaragiola/fabric/deployments","created_at":"2016-04-12T19:16:59Z","updated_at":"2016-04-12T19:17:01Z","pushed_at":"2016-06-09T06:25:16Z","git_url":"git://github.com/andresgaragiola/fabric.git","ssh_url":"git@github.com:andresgaragiola/fabric.git","clone_url":"https://github.com/andresgaragiola/fabric.git","svn_url":"https://github.com/andresgaragiola/fabric","homepage":"","size":53024,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"a94f5a7f559a4b7459e6ba37419e44bf335db81b","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":42975662,"name":"fabric","full_name":"hyperledger/fabric","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/fabric","description":"Fabric is a blockchain project in Incubation proposed to the community and documented at https://goo.gl/RYQZ5N.  Information on what Incubation entails can be found in the Hyperledger Project Lifecycle document (https://goo.gl/4edNRc)","fork":false,"url":"https://api.github.com/repos/hyperledger/fabric","forks_url":"https://api.github.com/repos/hyperledger/fabric/forks","keys_url":"https://api.github.com/repos/hyperledger/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/fabric/teams","hooks_url":"https://api.github.com/repos/hyperledger/fabric/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/fabric/events","assignees_url":"https://api.github.com/repos/hyperledger/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/fabric/tags","blobs_url":"https://api.github.com/repos/hyperledger/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/fabric/languages","stargazers_url":"https://api.github.com/repos/hyperledger/fabric/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/fabric/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/fabric/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/fabric/subscription","commits_url":"https://api.github.com/repos/hyperledger/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/fabric/merges","archive_url":"https://api.github.com/repos/hyperledger/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/fabric/downloads","issues_url":"https://api.github.com/repos/hyperledger/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/fabric/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/fabric/deployments","created_at":"2015-09-23T03:17:14Z","updated_at":"2016-06-08T18:32:17Z","pushed_at":"2016-06-09T06:01:54Z","git_url":"git://github.com/hyperledger/fabric.git","ssh_url":"git@github.com:hyperledger/fabric.git","clone_url":"https://github.com/hyperledger/fabric.git","svn_url":"https://github.com/hyperledger/fabric","homepage":"","size":73192,"stargazers_count":751,"watchers_count":751,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":667,"mirror_url":null,"open_issues_count":335,"forks":667,"open_issues":335,"watchers":751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1763"},"html":{"href":"https://github.com/hyperledger/fabric/pull/1763"},"issue":{"href":"https://api.github.com/repos/hyperledger/fabric/issues/1763"},"comments":{"href":"https://api.github.com/repos/hyperledger/fabric/issues/1763/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1763/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/fabric/pulls/1763/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/fabric/statuses/5c0b36aa5b755f332d5967ee536b91b0f29618f5"}}}}
{"actor":{"display_login":"adecaro"}}