{"action":"opened","number":2560,"pull_request":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2560","id":87419398,"html_url":"https://github.com/otwcode/otwarchive/pull/2560","diff_url":"https://github.com/otwcode/otwarchive/pull/2560.diff","patch_url":"https://github.com/otwcode/otwarchive/pull/2560.patch","issue_url":"https://api.github.com/repos/otwcode/otwarchive/issues/2560","number":2560,"state":"open","locked":false,"title":"AO3-4616 Add delays for the skin tests.","user":{"login":"tickinginstant","id":20977630,"avatar_url":"https://avatars.githubusercontent.com/u/20977630?v=3","gravatar_id":"","url":"https://api.github.com/users/tickinginstant","html_url":"https://github.com/tickinginstant","followers_url":"https://api.github.com/users/tickinginstant/followers","following_url":"https://api.github.com/users/tickinginstant/following{/other_user}","gists_url":"https://api.github.com/users/tickinginstant/gists{/gist_id}","starred_url":"https://api.github.com/users/tickinginstant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tickinginstant/subscriptions","organizations_url":"https://api.github.com/users/tickinginstant/orgs","repos_url":"https://api.github.com/users/tickinginstant/repos","events_url":"https://api.github.com/users/tickinginstant/events{/privacy}","received_events_url":"https://api.github.com/users/tickinginstant/received_events","type":"User","site_admin":false},"body":"# Pull Request Checklist\r\n\r\n* [x] Have you read [How to write the perfect pull request](https://github.com/blog/1943-how-to-write-the-perfect-pull-request)?\r\n* [x] Have you read through the [contributor guidelines](https://github.com/otwcode/otwarchive/blob/master/CONTRIBUTING.md)?\r\n* [x] Have you added tests for any changed functionality?\r\n* [x] Have you added the JIRA issue number as the *first* thing in your pull request title (eg: `AO3-1234 Fix thing`)\r\n* [x] Have you updated the JIRA issue with the information below?\r\n\r\n## Issue\r\n\r\nhttps://otwarchive.atlassian.net/browse/AO3-4616\r\n\r\n## Purpose\r\n\r\nThe updated_at field only has resolution down to the second, not the millisecond, so if two updates to the same skin are performed within the same second, the cache key used to access the cached version of the data won't change between updates. But in order to ensure that caching always has the most recent version of the data, the cache key has to change whenever the underlying data changes.\r\n\r\nThis pull request adds a small delay to two of the automated skins tests, in an attempt to ensure that the cache key has changed when the data changes. This is a stopgap measure that will hopefully stop the intermittent Travis skin test failures until the larger caching problem is handled (likely by updating Rails).\r\n\r\n## Testing\r\n\r\nThis is an update to the automated tests, so I don't think it really requires any manual QA. (Aside from possibly making Travis CI run the other_b tests over and over again to check whether this fixes the problem.)\r\n\r\n## Credit\r\n\r\ntickinginstant, she/her","created_at":"2016-09-30T00:58:34Z","updated_at":"2016-09-30T00:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2560/commits","review_comments_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/2560/comments","review_comment_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/issues/2560/comments","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/09fb67af35beac4910a9cab0bbbd80a0a8933d55","head":{"label":"tickinginstant:AO3-4616-add-test-delays","ref":"AO3-4616-add-test-delays","sha":"09fb67af35beac4910a9cab0bbbd80a0a8933d55","user":{"login":"tickinginstant","id":20977630,"avatar_url":"https://avatars.githubusercontent.com/u/20977630?v=3","gravatar_id":"","url":"https://api.github.com/users/tickinginstant","html_url":"https://github.com/tickinginstant","followers_url":"https://api.github.com/users/tickinginstant/followers","following_url":"https://api.github.com/users/tickinginstant/following{/other_user}","gists_url":"https://api.github.com/users/tickinginstant/gists{/gist_id}","starred_url":"https://api.github.com/users/tickinginstant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tickinginstant/subscriptions","organizations_url":"https://api.github.com/users/tickinginstant/orgs","repos_url":"https://api.github.com/users/tickinginstant/repos","events_url":"https://api.github.com/users/tickinginstant/events{/privacy}","received_events_url":"https://api.github.com/users/tickinginstant/received_events","type":"User","site_admin":false},"repo":{"id":65503912,"name":"otwarchive","full_name":"tickinginstant/otwarchive","owner":{"login":"tickinginstant","id":20977630,"avatar_url":"https://avatars.githubusercontent.com/u/20977630?v=3","gravatar_id":"","url":"https://api.github.com/users/tickinginstant","html_url":"https://github.com/tickinginstant","followers_url":"https://api.github.com/users/tickinginstant/followers","following_url":"https://api.github.com/users/tickinginstant/following{/other_user}","gists_url":"https://api.github.com/users/tickinginstant/gists{/gist_id}","starred_url":"https://api.github.com/users/tickinginstant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tickinginstant/subscriptions","organizations_url":"https://api.github.com/users/tickinginstant/orgs","repos_url":"https://api.github.com/users/tickinginstant/repos","events_url":"https://api.github.com/users/tickinginstant/events{/privacy}","received_events_url":"https://api.github.com/users/tickinginstant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tickinginstant/otwarchive","description":"The Organization for Transformative Works (OTW) - Archive Of Our Own (AO3) Project","fork":true,"url":"https://api.github.com/repos/tickinginstant/otwarchive","forks_url":"https://api.github.com/repos/tickinginstant/otwarchive/forks","keys_url":"https://api.github.com/repos/tickinginstant/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tickinginstant/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tickinginstant/otwarchive/teams","hooks_url":"https://api.github.com/repos/tickinginstant/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/tickinginstant/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/tickinginstant/otwarchive/events","assignees_url":"https://api.github.com/repos/tickinginstant/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/tickinginstant/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/tickinginstant/otwarchive/tags","blobs_url":"https://api.github.com/repos/tickinginstant/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tickinginstant/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tickinginstant/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/tickinginstant/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tickinginstant/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/tickinginstant/otwarchive/languages","stargazers_url":"https://api.github.com/repos/tickinginstant/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/tickinginstant/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/tickinginstant/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/tickinginstant/otwarchive/subscription","commits_url":"https://api.github.com/repos/tickinginstant/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/tickinginstant/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/tickinginstant/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/tickinginstant/otwarchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/tickinginstant/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/tickinginstant/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tickinginstant/otwarchive/merges","archive_url":"https://api.github.com/repos/tickinginstant/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tickinginstant/otwarchive/downloads","issues_url":"https://api.github.com/repos/tickinginstant/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/tickinginstant/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/tickinginstant/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/tickinginstant/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tickinginstant/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/tickinginstant/otwarchive/releases{/id}","deployments_url":"https://api.github.com/repos/tickinginstant/otwarchive/deployments","created_at":"2016-08-11T21:52:08Z","updated_at":"2016-08-11T21:52:13Z","pushed_at":"2016-09-30T00:29:25Z","git_url":"git://github.com/tickinginstant/otwarchive.git","ssh_url":"git@github.com:tickinginstant/otwarchive.git","clone_url":"https://github.com/tickinginstant/otwarchive.git","svn_url":"https://github.com/tickinginstant/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":51573,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"otwcode:master","ref":"master","sha":"c5e76701bb4baad0cd744d520fe29fb1ecde0191","user":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"repo":{"id":1338040,"name":"otwarchive","full_name":"otwcode/otwarchive","owner":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otwcode/otwarchive","description":"The Organization for Transformative Works (OTW) - Archive Of Our Own (AO3) Project","fork":false,"url":"https://api.github.com/repos/otwcode/otwarchive","forks_url":"https://api.github.com/repos/otwcode/otwarchive/forks","keys_url":"https://api.github.com/repos/otwcode/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otwcode/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otwcode/otwarchive/teams","hooks_url":"https://api.github.com/repos/otwcode/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/otwcode/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/otwcode/otwarchive/events","assignees_url":"https://api.github.com/repos/otwcode/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/otwcode/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/otwcode/otwarchive/tags","blobs_url":"https://api.github.com/repos/otwcode/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otwcode/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otwcode/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/otwcode/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/otwcode/otwarchive/languages","stargazers_url":"https://api.github.com/repos/otwcode/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/otwcode/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/otwcode/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/otwcode/otwarchive/subscription","commits_url":"https://api.github.com/repos/otwcode/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/otwcode/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/otwcode/otwarchive/issues/comments{/number}","contents_url":"https://api.github.com/repos/otwcode/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/otwcode/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otwcode/otwarchive/merges","archive_url":"https://api.github.com/repos/otwcode/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otwcode/otwarchive/downloads","issues_url":"https://api.github.com/repos/otwcode/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/otwcode/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/otwcode/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/otwcode/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otwcode/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/otwcode/otwarchive/releases{/id}","deployments_url":"https://api.github.com/repos/otwcode/otwarchive/deployments","created_at":"2011-02-07T14:50:58Z","updated_at":"2016-09-27T17:50:22Z","pushed_at":"2016-09-30T00:58:34Z","git_url":"git://github.com/otwcode/otwarchive.git","ssh_url":"git@github.com:otwcode/otwarchive.git","clone_url":"https://github.com/otwcode/otwarchive.git","svn_url":"https://github.com/otwcode/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":70978,"stargazers_count":214,"watchers_count":214,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"open_issues_count":47,"forks":125,"open_issues":47,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2560"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/2560"},"issue":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/2560"},"comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/2560/comments"},"review_comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2560/comments"},"review_comment":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/2560/commits"},"statuses":{"href":"https://api.github.com/repos/otwcode/otwarchive/statuses/09fb67af35beac4910a9cab0bbbd80a0a8933d55"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"tickinginstant"}}