{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/64588722","id":64588722,"diff_hunk":"@@ -63,55 +65,55 @@\n \t\t\t\t\t\t<?php $rel = ' data-showon=\\'' . json_encode($showonarr) . '\\''; ?>\n \t\t\t\t\t<?php endif; ?>\n \t\t\t\t\t<?php $label = empty($fieldSet->label) ? 'COM_CONFIG_' . $name . '_FIELDSET_LABEL' : $fieldSet->label; ?>\n-\t\t\t\t\t<li<?php echo $rel; ?>><a href=\"#<?php echo $name; ?>\" data-toggle=\"tab\"><?php echo JText::_($label); ?></a></li>\n+\t\t\t\t\t<li<?php echo $rel; ?>><a data-toggle=\"tab\" href=\"#<?php echo $name; ?>\"><?php echo JText::_($label); ?></a></li>","path":"administrator/components/com_config/view/component/tmpl/default.php","position":35,"original_position":35,"commit_id":"497e7dbb626db160ef146f65ffb78e4ea8da45da","original_commit_id":"497e7dbb626db160ef146f65ffb78e4ea8da45da","user":{"login":"JoomliC","id":2385058,"avatar_url":"https://avatars.githubusercontent.com/u/2385058?v=3","gravatar_id":"","url":"https://api.github.com/users/JoomliC","html_url":"https://github.com/JoomliC","followers_url":"https://api.github.com/users/JoomliC/followers","following_url":"https://api.github.com/users/JoomliC/following{/other_user}","gists_url":"https://api.github.com/users/JoomliC/gists{/gist_id}","starred_url":"https://api.github.com/users/JoomliC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoomliC/subscriptions","organizations_url":"https://api.github.com/users/JoomliC/orgs","repos_url":"https://api.github.com/users/JoomliC/repos","events_url":"https://api.github.com/users/JoomliC/events{/privacy}","received_events_url":"https://api.github.com/users/JoomliC/received_events","type":"User","site_admin":false},"body":"Same as above: code standards ;-)","created_at":"2016-05-25T14:58:28Z","updated_at":"2016-05-25T14:58:28Z","html_url":"https://github.com/joomla/joomla-cms/pull/10622#discussion_r64588722","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/64588722"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10622#discussion_r64588722"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622","id":71370876,"html_url":"https://github.com/joomla/joomla-cms/pull/10622","diff_url":"https://github.com/joomla/joomla-cms/pull/10622.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10622.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10622","number":10622,"state":"open","locked":false,"title":"Component config: Improve and fix code style, hidden field + Add style for fieldset description","user":{"login":"JoomliC","id":2385058,"avatar_url":"https://avatars.githubusercontent.com/u/2385058?v=3","gravatar_id":"","url":"https://api.github.com/users/JoomliC","html_url":"https://github.com/JoomliC","followers_url":"https://api.github.com/users/JoomliC/followers","following_url":"https://api.github.com/users/JoomliC/following{/other_user}","gists_url":"https://api.github.com/users/JoomliC/gists{/gist_id}","starred_url":"https://api.github.com/users/JoomliC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoomliC/subscriptions","organizations_url":"https://api.github.com/users/JoomliC/orgs","repos_url":"https://api.github.com/users/JoomliC/repos","events_url":"https://api.github.com/users/JoomliC/events{/privacy}","received_events_url":"https://api.github.com/users/JoomliC/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\r\n- Fix code style\r\n- Fix hidden field (no html to be rendered when field is hidden, to prevent empty lines (due to css classes for fields)\r\n- Add style alert-info + icon for the description of a fieldset (description in top of each tab, when filled)\r\n\r\n#### Testing Instructions\r\n**Test for fieldset description style:**\r\n- Go to any component configuration page (Options) and check description has now an alert-info look\r\n\r\n**Before Patch**:\r\n![capture d ecran 2016-05-24 a 01 07 00](https://cloud.githubusercontent.com/assets/2385058/15537750/69c0c09c-2278-11e6-9056-4fa174745c43.png)\r\n\r\n**After Patch**:\r\n![capture d ecran 2016-05-24 a 01 07 30](https://cloud.githubusercontent.com/assets/2385058/15537763/7a143776-2278-11e6-8a05-d9849c795b6d.png)\r\n\r\n\r\n\r\n**Test for hidden fields fix:**\r\n- To test fix for hidden fields, add in a config.xml those lines : \r\n```\r\n\t\t<field\r\n\t\t\tname=\"hidden1\"\r\n\t\t\ttype=\"hidden\"\r\n\t\t\tdefault=\"1\"\r\n\t\t/>\r\n\r\n\t\t<field\r\n\t\t\tname=\"hidden2\"\r\n\t\t\ttype=\"hidden\"\r\n\t\t\tdefault=\"1\"\r\n\t\t/>\r\n\r\n\t\t<field\r\n\t\t\tname=\"hidden3\"\r\n\t\t\ttype=\"hidden\"\r\n\t\t\tdefault=\"1\"\r\n\t\t/>\r\n\r\n\t\t<field\r\n\t\t\tname=\"hidden4\"\r\n\t\t\ttype=\"hidden\"\r\n\t\t\tdefault=\"1\"\r\n\t\t/>\r\n```\r\n**Before Patch**:\r\n![capture d ecran 2016-05-25 a 12 47 05](https://cloud.githubusercontent.com/assets/2385058/15537645/f5342b56-2277-11e6-942d-08207d01bdcb.png)\r\n\r\n**After Patch**:\r\n![capture d ecran 2016-05-25 a 12 47 37](https://cloud.githubusercontent.com/assets/2385058/15537661/035877be-2278-11e6-9d6d-f959ae7010c8.png)\r\n\r\n- You can control after save, that hidden fields are saved in the database (#__extensions > component params)\r\n\r\n","created_at":"2016-05-25T11:00:57Z","updated_at":"2016-05-25T14:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efd9e7338b12e90f04a8d7307b8cc01053a63e69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10622/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/497e7dbb626db160ef146f65ffb78e4ea8da45da","head":{"label":"JoomliC:Add-style-alert-info-for-fieldset-description-in-component-config","ref":"Add-style-alert-info-for-fieldset-description-in-component-config","sha":"497e7dbb626db160ef146f65ffb78e4ea8da45da","user":{"login":"JoomliC","id":2385058,"avatar_url":"https://avatars.githubusercontent.com/u/2385058?v=3","gravatar_id":"","url":"https://api.github.com/users/JoomliC","html_url":"https://github.com/JoomliC","followers_url":"https://api.github.com/users/JoomliC/followers","following_url":"https://api.github.com/users/JoomliC/following{/other_user}","gists_url":"https://api.github.com/users/JoomliC/gists{/gist_id}","starred_url":"https://api.github.com/users/JoomliC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoomliC/subscriptions","organizations_url":"https://api.github.com/users/JoomliC/orgs","repos_url":"https://api.github.com/users/JoomliC/repos","events_url":"https://api.github.com/users/JoomliC/events{/privacy}","received_events_url":"https://api.github.com/users/JoomliC/received_events","type":"User","site_admin":false},"repo":{"id":13361373,"name":"joomla-cms","full_name":"JoomliC/joomla-cms","owner":{"login":"JoomliC","id":2385058,"avatar_url":"https://avatars.githubusercontent.com/u/2385058?v=3","gravatar_id":"","url":"https://api.github.com/users/JoomliC","html_url":"https://github.com/JoomliC","followers_url":"https://api.github.com/users/JoomliC/followers","following_url":"https://api.github.com/users/JoomliC/following{/other_user}","gists_url":"https://api.github.com/users/JoomliC/gists{/gist_id}","starred_url":"https://api.github.com/users/JoomliC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoomliC/subscriptions","organizations_url":"https://api.github.com/users/JoomliC/orgs","repos_url":"https://api.github.com/users/JoomliC/repos","events_url":"https://api.github.com/users/JoomliC/events{/privacy}","received_events_url":"https://api.github.com/users/JoomliC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoomliC/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/JoomliC/joomla-cms","forks_url":"https://api.github.com/repos/JoomliC/joomla-cms/forks","keys_url":"https://api.github.com/repos/JoomliC/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoomliC/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoomliC/joomla-cms/teams","hooks_url":"https://api.github.com/repos/JoomliC/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/JoomliC/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/JoomliC/joomla-cms/events","assignees_url":"https://api.github.com/repos/JoomliC/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/JoomliC/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/JoomliC/joomla-cms/tags","blobs_url":"https://api.github.com/repos/JoomliC/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoomliC/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoomliC/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoomliC/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoomliC/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/JoomliC/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/JoomliC/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/JoomliC/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/JoomliC/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/JoomliC/joomla-cms/subscription","commits_url":"https://api.github.com/repos/JoomliC/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoomliC/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoomliC/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoomliC/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoomliC/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/JoomliC/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoomliC/joomla-cms/merges","archive_url":"https://api.github.com/repos/JoomliC/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoomliC/joomla-cms/downloads","issues_url":"https://api.github.com/repos/JoomliC/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/JoomliC/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/JoomliC/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/JoomliC/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoomliC/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/JoomliC/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/JoomliC/joomla-cms/deployments","created_at":"2013-10-06T11:50:48Z","updated_at":"2016-04-07T00:50:12Z","pushed_at":"2016-05-25T10:49:14Z","git_url":"git://github.com/JoomliC/joomla-cms.git","ssh_url":"git@github.com:JoomliC/joomla-cms.git","clone_url":"https://github.com/JoomliC/joomla-cms.git","svn_url":"https://github.com/JoomliC/joomla-cms","homepage":"http://joomla.org","size":149809,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"2ba3b12072e299bb055a331303fab7c63c89fbd1","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-05-25T02:29:04Z","pushed_at":"2016-05-25T13:02:03Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":278360,"stargazers_count":2013,"watchers_count":2013,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2174,"mirror_url":null,"open_issues_count":414,"forks":2174,"open_issues":414,"watchers":2013,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10622"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10622"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10622/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10622/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/497e7dbb626db160ef146f65ffb78e4ea8da45da"}}}}
{"actor":{"display_login":"JoomliC"}}