{"action":"opened","number":906,"pull_request":{"url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/906","id":75206037,"html_url":"https://github.com/CounterpartyXCP/counterparty-lib/pull/906","diff_url":"https://github.com/CounterpartyXCP/counterparty-lib/pull/906.diff","patch_url":"https://github.com/CounterpartyXCP/counterparty-lib/pull/906.patch","issue_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues/906","number":906,"state":"open","locked":false,"title":"test suite refactoring [take 101]","user":{"login":"rubensayshi","id":649160,"avatar_url":"https://avatars.githubusercontent.com/u/649160?v=3","gravatar_id":"","url":"https://api.github.com/users/rubensayshi","html_url":"https://github.com/rubensayshi","followers_url":"https://api.github.com/users/rubensayshi/followers","following_url":"https://api.github.com/users/rubensayshi/following{/other_user}","gists_url":"https://api.github.com/users/rubensayshi/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensayshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensayshi/subscriptions","organizations_url":"https://api.github.com/users/rubensayshi/orgs","repos_url":"https://api.github.com/users/rubensayshi/repos","events_url":"https://api.github.com/users/rubensayshi/events{/privacy}","received_events_url":"https://api.github.com/users/rubensayshi/received_events","type":"User","site_admin":false},"body":"yet another refactoring of the test suite...\r\n\r\nit started out as creating a small 'complex unittest' template for @f483 to use for the payment channels, but I got sucked in and did a bunch more things ...\r\n\r\nI changed the test suite to actually track UTXOs (still initial state setup from the same .json file), this makes it possible (for @f483) to actually test different states of a chain of transactions and test between confirmed and unconfirmed states etc.  \r\nIt's not perfect, but it will do.\r\n\r\nOnce I implemented that it resulted in a big diff in the test scenarios, because their inputs changed and as a result the txid, etc...  \r\nThis happens a lot ... and I was tired of it; so I changed a few things that should ensure that vectors change less when we make even the smallest change in a scenario.  \r\n\r\nSo arc4 is being mocked with a fixed seed to avoid that ever changing in the vectors, and when constructing the txid of transactions the inputs are blanked so that different inputs also no longer change the txids.\r\n\r\nSee inline comments for more ;-) ","created_at":"2016-06-25T14:34:13Z","updated_at":"2016-06-25T14:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/906/commits","review_comments_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/906/comments","review_comment_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues/906/comments","statuses_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/statuses/3ad2bc6232a246f9e2e567008168fc4d90d8705c","head":{"label":"rubensayshi:complex-unittests","ref":"complex-unittests","sha":"3ad2bc6232a246f9e2e567008168fc4d90d8705c","user":{"login":"rubensayshi","id":649160,"avatar_url":"https://avatars.githubusercontent.com/u/649160?v=3","gravatar_id":"","url":"https://api.github.com/users/rubensayshi","html_url":"https://github.com/rubensayshi","followers_url":"https://api.github.com/users/rubensayshi/followers","following_url":"https://api.github.com/users/rubensayshi/following{/other_user}","gists_url":"https://api.github.com/users/rubensayshi/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensayshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensayshi/subscriptions","organizations_url":"https://api.github.com/users/rubensayshi/orgs","repos_url":"https://api.github.com/users/rubensayshi/repos","events_url":"https://api.github.com/users/rubensayshi/events{/privacy}","received_events_url":"https://api.github.com/users/rubensayshi/received_events","type":"User","site_admin":false},"repo":{"id":46419497,"name":"counterparty-lib","full_name":"rubensayshi/counterparty-lib","owner":{"login":"rubensayshi","id":649160,"avatar_url":"https://avatars.githubusercontent.com/u/649160?v=3","gravatar_id":"","url":"https://api.github.com/users/rubensayshi","html_url":"https://github.com/rubensayshi","followers_url":"https://api.github.com/users/rubensayshi/followers","following_url":"https://api.github.com/users/rubensayshi/following{/other_user}","gists_url":"https://api.github.com/users/rubensayshi/gists{/gist_id}","starred_url":"https://api.github.com/users/rubensayshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubensayshi/subscriptions","organizations_url":"https://api.github.com/users/rubensayshi/orgs","repos_url":"https://api.github.com/users/rubensayshi/repos","events_url":"https://api.github.com/users/rubensayshi/events{/privacy}","received_events_url":"https://api.github.com/users/rubensayshi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubensayshi/counterparty-lib","description":"Counterparty Protocol Reference Implementation","fork":true,"url":"https://api.github.com/repos/rubensayshi/counterparty-lib","forks_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/forks","keys_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/teams","hooks_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/hooks","issue_events_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/issues/events{/number}","events_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/events","assignees_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/assignees{/user}","branches_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/branches{/branch}","tags_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/tags","blobs_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/languages","stargazers_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/stargazers","contributors_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/contributors","subscribers_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/subscribers","subscription_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/subscription","commits_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/contents/{+path}","compare_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/merges","archive_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/downloads","issues_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/issues{/number}","pulls_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/labels{/name}","releases_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/releases{/id}","deployments_url":"https://api.github.com/repos/rubensayshi/counterparty-lib/deployments","created_at":"2015-11-18T13:11:04Z","updated_at":"2015-11-18T13:11:07Z","pushed_at":"2016-06-25T13:50:59Z","git_url":"git://github.com/rubensayshi/counterparty-lib.git","ssh_url":"git@github.com:rubensayshi/counterparty-lib.git","clone_url":"https://github.com/rubensayshi/counterparty-lib.git","svn_url":"https://github.com/rubensayshi/counterparty-lib","homepage":"http://counterparty.io","size":16409,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"CounterpartyXCP:develop","ref":"develop","sha":"be2cd3ba051e96ea9ed3202f8339aee5c905ab78","user":{"login":"CounterpartyXCP","id":7490848,"avatar_url":"https://avatars.githubusercontent.com/u/7490848?v=3","gravatar_id":"","url":"https://api.github.com/users/CounterpartyXCP","html_url":"https://github.com/CounterpartyXCP","followers_url":"https://api.github.com/users/CounterpartyXCP/followers","following_url":"https://api.github.com/users/CounterpartyXCP/following{/other_user}","gists_url":"https://api.github.com/users/CounterpartyXCP/gists{/gist_id}","starred_url":"https://api.github.com/users/CounterpartyXCP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CounterpartyXCP/subscriptions","organizations_url":"https://api.github.com/users/CounterpartyXCP/orgs","repos_url":"https://api.github.com/users/CounterpartyXCP/repos","events_url":"https://api.github.com/users/CounterpartyXCP/events{/privacy}","received_events_url":"https://api.github.com/users/CounterpartyXCP/received_events","type":"Organization","site_admin":false},"repo":{"id":15202468,"name":"counterparty-lib","full_name":"CounterpartyXCP/counterparty-lib","owner":{"login":"CounterpartyXCP","id":7490848,"avatar_url":"https://avatars.githubusercontent.com/u/7490848?v=3","gravatar_id":"","url":"https://api.github.com/users/CounterpartyXCP","html_url":"https://github.com/CounterpartyXCP","followers_url":"https://api.github.com/users/CounterpartyXCP/followers","following_url":"https://api.github.com/users/CounterpartyXCP/following{/other_user}","gists_url":"https://api.github.com/users/CounterpartyXCP/gists{/gist_id}","starred_url":"https://api.github.com/users/CounterpartyXCP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CounterpartyXCP/subscriptions","organizations_url":"https://api.github.com/users/CounterpartyXCP/orgs","repos_url":"https://api.github.com/users/CounterpartyXCP/repos","events_url":"https://api.github.com/users/CounterpartyXCP/events{/privacy}","received_events_url":"https://api.github.com/users/CounterpartyXCP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CounterpartyXCP/counterparty-lib","description":"Counterparty Protocol Reference Implementation","fork":false,"url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib","forks_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/forks","keys_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/teams","hooks_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/hooks","issue_events_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues/events{/number}","events_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/events","assignees_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/assignees{/user}","branches_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/branches{/branch}","tags_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/tags","blobs_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/languages","stargazers_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/stargazers","contributors_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/contributors","subscribers_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/subscribers","subscription_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/subscription","commits_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/contents/{+path}","compare_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/merges","archive_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/downloads","issues_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues{/number}","pulls_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/labels{/name}","releases_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/releases{/id}","deployments_url":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/deployments","created_at":"2013-12-15T11:44:46Z","updated_at":"2016-06-24T15:43:42Z","pushed_at":"2016-06-25T14:34:14Z","git_url":"git://github.com/CounterpartyXCP/counterparty-lib.git","ssh_url":"git@github.com:CounterpartyXCP/counterparty-lib.git","clone_url":"https://github.com/CounterpartyXCP/counterparty-lib.git","svn_url":"https://github.com/CounterpartyXCP/counterparty-lib","homepage":"http://counterparty.io","size":19233,"stargazers_count":184,"watchers_count":184,"language":"PLpgSQL","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":119,"mirror_url":null,"open_issues_count":68,"forks":119,"open_issues":68,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/906"},"html":{"href":"https://github.com/CounterpartyXCP/counterparty-lib/pull/906"},"issue":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues/906"},"comments":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/CounterpartyXCP/counterparty-lib/statuses/3ad2bc6232a246f9e2e567008168fc4d90d8705c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":5633,"deletions":4979,"changed_files":43}}
{"actor":{"display_login":"rubensayshi"}}