{"action":"opened","number":159,"pull_request":{"url":"https://api.github.com/repos/collective/collective.solr/pulls/159","id":94163443,"html_url":"https://github.com/collective/collective.solr/pull/159","diff_url":"https://github.com/collective/collective.solr/pull/159.diff","patch_url":"https://github.com/collective/collective.solr/pull/159.patch","issue_url":"https://api.github.com/repos/collective/collective.solr/issues/159","number":159,"state":"open","locked":false,"title":"solr.cfg: configure JMX host and port separately.","user":{"login":"mauritsvanrees","id":210587,"avatar_url":"https://avatars.githubusercontent.com/u/210587?v=3","gravatar_id":"","url":"https://api.github.com/users/mauritsvanrees","html_url":"https://github.com/mauritsvanrees","followers_url":"https://api.github.com/users/mauritsvanrees/followers","following_url":"https://api.github.com/users/mauritsvanrees/following{/other_user}","gists_url":"https://api.github.com/users/mauritsvanrees/gists{/gist_id}","starred_url":"https://api.github.com/users/mauritsvanrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauritsvanrees/subscriptions","organizations_url":"https://api.github.com/users/mauritsvanrees/orgs","repos_url":"https://api.github.com/users/mauritsvanrees/repos","events_url":"https://api.github.com/users/mauritsvanrees/events{/privacy}","received_events_url":"https://api.github.com/users/mauritsvanrees/received_events","type":"User","site_admin":false},"body":"The config was hardcoding the JMX (Java Management Extensions) host and port. Now it is clearer that you can configure them.\r\n\r\nMostly, I found it strange that there was a `solr-port` setting and we were completely ignoring that in the `java_opts` and instead used hardcoded port 8984. To me this gave the impression that this port 8984 was only used at build time to maybe set a default, and that `solr-instance fg` would just use the port from the settings and port 8984 would never be used.\r\n\r\nInitially I changed that to use the same settings, with `${:host}` and `${:port}`.\r\nThat seems to work fine, and we could also use that to keep things simple.\r\nBut probably it is better to keep the ports separate.\r\n\r\nI did not know JMX, but you can start `jconsole` and connect to your Solr instance and see some statistics. See https://cwiki.apache.org/confluence/display/solr/Using+JMX+with+Solr","created_at":"2016-11-17T13:04:52Z","updated_at":"2016-11-17T13:04:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/collective/collective.solr/pulls/159/commits","review_comments_url":"https://api.github.com/repos/collective/collective.solr/pulls/159/comments","review_comment_url":"https://api.github.com/repos/collective/collective.solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collective/collective.solr/issues/159/comments","statuses_url":"https://api.github.com/repos/collective/collective.solr/statuses/3af9ec72afc4aca932d0383ee48199a5d6d412d0","head":{"label":"collective:separate-jmx-port-setting","ref":"separate-jmx-port-setting","sha":"3af9ec72afc4aca932d0383ee48199a5d6d412d0","user":{"login":"collective","id":362867,"avatar_url":"https://avatars.githubusercontent.com/u/362867?v=3","gravatar_id":"","url":"https://api.github.com/users/collective","html_url":"https://github.com/collective","followers_url":"https://api.github.com/users/collective/followers","following_url":"https://api.github.com/users/collective/following{/other_user}","gists_url":"https://api.github.com/users/collective/gists{/gist_id}","starred_url":"https://api.github.com/users/collective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collective/subscriptions","organizations_url":"https://api.github.com/users/collective/orgs","repos_url":"https://api.github.com/users/collective/repos","events_url":"https://api.github.com/users/collective/events{/privacy}","received_events_url":"https://api.github.com/users/collective/received_events","type":"Organization","site_admin":false},"repo":{"id":5714637,"name":"collective.solr","full_name":"collective/collective.solr","owner":{"login":"collective","id":362867,"avatar_url":"https://avatars.githubusercontent.com/u/362867?v=3","gravatar_id":"","url":"https://api.github.com/users/collective","html_url":"https://github.com/collective","followers_url":"https://api.github.com/users/collective/followers","following_url":"https://api.github.com/users/collective/following{/other_user}","gists_url":"https://api.github.com/users/collective/gists{/gist_id}","starred_url":"https://api.github.com/users/collective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collective/subscriptions","organizations_url":"https://api.github.com/users/collective/orgs","repos_url":"https://api.github.com/users/collective/repos","events_url":"https://api.github.com/users/collective/events{/privacy}","received_events_url":"https://api.github.com/users/collective/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collective/collective.solr","description":"Solr search engine integration for Plone","fork":false,"url":"https://api.github.com/repos/collective/collective.solr","forks_url":"https://api.github.com/repos/collective/collective.solr/forks","keys_url":"https://api.github.com/repos/collective/collective.solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collective/collective.solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collective/collective.solr/teams","hooks_url":"https://api.github.com/repos/collective/collective.solr/hooks","issue_events_url":"https://api.github.com/repos/collective/collective.solr/issues/events{/number}","events_url":"https://api.github.com/repos/collective/collective.solr/events","assignees_url":"https://api.github.com/repos/collective/collective.solr/assignees{/user}","branches_url":"https://api.github.com/repos/collective/collective.solr/branches{/branch}","tags_url":"https://api.github.com/repos/collective/collective.solr/tags","blobs_url":"https://api.github.com/repos/collective/collective.solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collective/collective.solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collective/collective.solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/collective/collective.solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collective/collective.solr/statuses/{sha}","languages_url":"https://api.github.com/repos/collective/collective.solr/languages","stargazers_url":"https://api.github.com/repos/collective/collective.solr/stargazers","contributors_url":"https://api.github.com/repos/collective/collective.solr/contributors","subscribers_url":"https://api.github.com/repos/collective/collective.solr/subscribers","subscription_url":"https://api.github.com/repos/collective/collective.solr/subscription","commits_url":"https://api.github.com/repos/collective/collective.solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/collective/collective.solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/collective/collective.solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/collective/collective.solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/collective/collective.solr/contents/{+path}","compare_url":"https://api.github.com/repos/collective/collective.solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collective/collective.solr/merges","archive_url":"https://api.github.com/repos/collective/collective.solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collective/collective.solr/downloads","issues_url":"https://api.github.com/repos/collective/collective.solr/issues{/number}","pulls_url":"https://api.github.com/repos/collective/collective.solr/pulls{/number}","milestones_url":"https://api.github.com/repos/collective/collective.solr/milestones{/number}","notifications_url":"https://api.github.com/repos/collective/collective.solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collective/collective.solr/labels{/name}","releases_url":"https://api.github.com/repos/collective/collective.solr/releases{/id}","deployments_url":"https://api.github.com/repos/collective/collective.solr/deployments","created_at":"2012-09-07T09:04:07Z","updated_at":"2016-11-11T08:30:15Z","pushed_at":"2016-11-17T13:04:52Z","git_url":"git://github.com/collective/collective.solr.git","ssh_url":"git@github.com:collective/collective.solr.git","clone_url":"https://github.com/collective/collective.solr.git","svn_url":"https://github.com/collective/collective.solr","homepage":"https://pypi.python.org/pypi/collective.solr/","size":5130,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":37,"forks":38,"open_issues":37,"watchers":13,"default_branch":"master"}},"base":{"label":"collective:master","ref":"master","sha":"29d56a9cff63a779f5dd61f0f809a1660f41e488","user":{"login":"collective","id":362867,"avatar_url":"https://avatars.githubusercontent.com/u/362867?v=3","gravatar_id":"","url":"https://api.github.com/users/collective","html_url":"https://github.com/collective","followers_url":"https://api.github.com/users/collective/followers","following_url":"https://api.github.com/users/collective/following{/other_user}","gists_url":"https://api.github.com/users/collective/gists{/gist_id}","starred_url":"https://api.github.com/users/collective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collective/subscriptions","organizations_url":"https://api.github.com/users/collective/orgs","repos_url":"https://api.github.com/users/collective/repos","events_url":"https://api.github.com/users/collective/events{/privacy}","received_events_url":"https://api.github.com/users/collective/received_events","type":"Organization","site_admin":false},"repo":{"id":5714637,"name":"collective.solr","full_name":"collective/collective.solr","owner":{"login":"collective","id":362867,"avatar_url":"https://avatars.githubusercontent.com/u/362867?v=3","gravatar_id":"","url":"https://api.github.com/users/collective","html_url":"https://github.com/collective","followers_url":"https://api.github.com/users/collective/followers","following_url":"https://api.github.com/users/collective/following{/other_user}","gists_url":"https://api.github.com/users/collective/gists{/gist_id}","starred_url":"https://api.github.com/users/collective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collective/subscriptions","organizations_url":"https://api.github.com/users/collective/orgs","repos_url":"https://api.github.com/users/collective/repos","events_url":"https://api.github.com/users/collective/events{/privacy}","received_events_url":"https://api.github.com/users/collective/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collective/collective.solr","description":"Solr search engine integration for Plone","fork":false,"url":"https://api.github.com/repos/collective/collective.solr","forks_url":"https://api.github.com/repos/collective/collective.solr/forks","keys_url":"https://api.github.com/repos/collective/collective.solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collective/collective.solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collective/collective.solr/teams","hooks_url":"https://api.github.com/repos/collective/collective.solr/hooks","issue_events_url":"https://api.github.com/repos/collective/collective.solr/issues/events{/number}","events_url":"https://api.github.com/repos/collective/collective.solr/events","assignees_url":"https://api.github.com/repos/collective/collective.solr/assignees{/user}","branches_url":"https://api.github.com/repos/collective/collective.solr/branches{/branch}","tags_url":"https://api.github.com/repos/collective/collective.solr/tags","blobs_url":"https://api.github.com/repos/collective/collective.solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collective/collective.solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collective/collective.solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/collective/collective.solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collective/collective.solr/statuses/{sha}","languages_url":"https://api.github.com/repos/collective/collective.solr/languages","stargazers_url":"https://api.github.com/repos/collective/collective.solr/stargazers","contributors_url":"https://api.github.com/repos/collective/collective.solr/contributors","subscribers_url":"https://api.github.com/repos/collective/collective.solr/subscribers","subscription_url":"https://api.github.com/repos/collective/collective.solr/subscription","commits_url":"https://api.github.com/repos/collective/collective.solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/collective/collective.solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/collective/collective.solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/collective/collective.solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/collective/collective.solr/contents/{+path}","compare_url":"https://api.github.com/repos/collective/collective.solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collective/collective.solr/merges","archive_url":"https://api.github.com/repos/collective/collective.solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collective/collective.solr/downloads","issues_url":"https://api.github.com/repos/collective/collective.solr/issues{/number}","pulls_url":"https://api.github.com/repos/collective/collective.solr/pulls{/number}","milestones_url":"https://api.github.com/repos/collective/collective.solr/milestones{/number}","notifications_url":"https://api.github.com/repos/collective/collective.solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collective/collective.solr/labels{/name}","releases_url":"https://api.github.com/repos/collective/collective.solr/releases{/id}","deployments_url":"https://api.github.com/repos/collective/collective.solr/deployments","created_at":"2012-09-07T09:04:07Z","updated_at":"2016-11-11T08:30:15Z","pushed_at":"2016-11-17T13:04:52Z","git_url":"git://github.com/collective/collective.solr.git","ssh_url":"git@github.com:collective/collective.solr.git","clone_url":"https://github.com/collective/collective.solr.git","svn_url":"https://github.com/collective/collective.solr","homepage":"https://pypi.python.org/pypi/collective.solr/","size":5130,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":37,"forks":38,"open_issues":37,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collective/collective.solr/pulls/159"},"html":{"href":"https://github.com/collective/collective.solr/pull/159"},"issue":{"href":"https://api.github.com/repos/collective/collective.solr/issues/159"},"comments":{"href":"https://api.github.com/repos/collective/collective.solr/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/collective/collective.solr/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/collective/collective.solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collective/collective.solr/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/collective/collective.solr/statuses/3af9ec72afc4aca932d0383ee48199a5d6d412d0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"mauritsvanrees"}}