{"push_id":1461053360,"size":9,"distinct_size":8,"ref":"refs/heads/prevent-duplicate-join","head":"3c7b20f974400965511dc017904430a83477afd6","before":"71adf13763acb3308024f7e9188b32e44cd9c076","commits":[{"sha":"5e6ba655973719515609be9fd43e07463e127735","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"Add cyli to maintainers\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/5e6ba655973719515609be9fd43e07463e127735"},{"sha":"5abe2d0c0b7dada49eadc53d393368f88b79690f","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"raft: Correct comment\n\nThis comment had become outdated. The old data is now deleted.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":false,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/5abe2d0c0b7dada49eadc53d393368f88b79690f"},{"sha":"556563af87b606851b49dd28ea99e8bd14b7b010","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"raft: Stop manager on write error\n\nIf we failed to save some entries to durable storage, we must stop the\nmanager. The existing code just logs an error and continues, but this\nmeans the state essentially becomes corrupted and the manager may panic\nlater. It's better to fail immediately.\n\nThe code path that involves Run returning early is not especially\nrobust, and we've noticed some issues on demotion related to this.\nDespite this, the alternative of letting Run continue in this situation\nis much worse. We will need to fix the code path where Run returns early\nanyway, because it is used in demotion.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/556563af87b606851b49dd28ea99e8bd14b7b010"},{"sha":"1b6c3807f5d7628d6362cdf652737c8570d7c355","author":{"name":"Andrea Luzzardi","email":"235d21b3b32c6796a8bac0398830aedd44ed4d41@gmail.com"},"message":"Merge pull request #1818 from aaronlehmann/add-cyli\n\nAdd cyli to maintainers","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/1b6c3807f5d7628d6362cdf652737c8570d7c355"},{"sha":"71e47b6d1155fe87b63daa6cbf05695d25e0a125","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"Merge pull request #1819 from aaronlehmann/fix-raft-comment\n\nraft: Correct comment","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/71e47b6d1155fe87b63daa6cbf05695d25e0a125"},{"sha":"b6cabf77144ffd7775c51f278e2b5ad326c6a1fe","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"Merge pull request #1820 from aaronlehmann/stop-manager-on-io-failure\n\nraft: Stop manager on write error","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/b6cabf77144ffd7775c51f278e2b5ad326c6a1fe"},{"sha":"a2037c38c54a028fe11687fb2b6e5d73b78aad58","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"raft: Prevent the same manager from joining raft twice\n\nIf a manager's raft state is lost or corrupted, it may try to join the\nRaft cluster as a fresh member. This must be avoided, because it will\ninfluence the quorum of the Raft cluster, which can prevent leader\nelections from succeeding.\n\nAdd a check to Join that prevents a node with the same identity from\njoining twice.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/a2037c38c54a028fe11687fb2b6e5d73b78aad58"},{"sha":"8bab926a590c04f27f28b2df6145b566707bfb6b","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"raft: Ignore messages intended for a different member\n\nIf a node managed to join raft twice, it would receive messages meant\nfor both the new and old raft members. There was no check verifying that\nthe recipient of message is correct. Adding this check makes sure that\nif this situation were to arise (perhaps because the leader is an older\nversion that allows Join to be called twice by the same node), extra\nmessages meant for a different raft member wouldn't be passed through to\nStep and possibly cause a panic.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/8bab926a590c04f27f28b2df6145b566707bfb6b"},{"sha":"3c7b20f974400965511dc017904430a83477afd6","author":{"name":"Aaron Lehmann","email":"ab01047e91402f1a4542861b1076cf31bcc38777@docker.com"},"message":"raft: Add test that triggers etcd/raft panic\n\nThis test panics without the newly-added protection against having the\nsame manager call Join twice.\n\nSigned-off-by: Aaron Lehmann <aaron.lehmann@docker.com>","distinct":true,"url":"https://api.github.com/repos/aaronlehmann/swarmkit/commits/3c7b20f974400965511dc017904430a83477afd6"}]}
{"actor":{"display_login":"aaronlehmann"}}