{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/75725378","id":75725378,"diff_hunk":"@@ -185,6 +185,12 @@ int ofi_ep_bind_valid(struct fi_provider *prov, struct fid *bfid, uint64_t flags\n \t\t\treturn -FI_EBADFLAGS;\n \t\t}\n \t\tbreak;\n+\tcase FI_CLASS_SRX_CTX:\n+\t\tif (flags & ~(FI_RECV)) {\n+\t\t\tFI_WARN(prov, FI_LOG_EP_CTRL, \"invalid SRX ctx flags\\n\");\n+\t\t\treturn -FI_EBADFLAGS;\n+\t\t}\n+\t\tbreak;","path":"src/common.c","position":9,"original_position":9,"commit_id":"d70588459dc62f2ec10de08a14513efdbce42e15","original_commit_id":"bc90653e85992f6c42368923c3d90da3ea03e93a","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars.githubusercontent.com/u/8547674?v=3","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"The fi_endpoint man page doesn't mention requiring/using flags when binding a shared context to an endpoint. So I believe this check would not be needed. The app should not pass any flags.\r\n@j-xiong can you please confirm?","created_at":"2016-08-22T17:54:20Z","updated_at":"2016-08-22T17:54:20Z","html_url":"https://github.com/ofiwg/libfabric/pull/2281#discussion_r75725378","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/75725378"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2281#discussion_r75725378"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281","id":82167481,"html_url":"https://github.com/ofiwg/libfabric/pull/2281","diff_url":"https://github.com/ofiwg/libfabric/pull/2281.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/2281.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2281","number":2281,"state":"open","locked":false,"title":"Some fixes for psm2 and verbs providers","user":{"login":"sydidelot","id":377197,"avatar_url":"https://avatars.githubusercontent.com/u/377197?v=3","gravatar_id":"","url":"https://api.github.com/users/sydidelot","html_url":"https://github.com/sydidelot","followers_url":"https://api.github.com/users/sydidelot/followers","following_url":"https://api.github.com/users/sydidelot/following{/other_user}","gists_url":"https://api.github.com/users/sydidelot/gists{/gist_id}","starred_url":"https://api.github.com/users/sydidelot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydidelot/subscriptions","organizations_url":"https://api.github.com/users/sydidelot/orgs","repos_url":"https://api.github.com/users/sydidelot/repos","events_url":"https://api.github.com/users/sydidelot/events{/privacy}","received_events_url":"https://api.github.com/users/sydidelot/received_events","type":"User","site_admin":false},"body":"Here are some minor fixes for the psm2 and the verbs providers.\r\nThanks for your review,\r\n\r\nSylvain","created_at":"2016-08-22T10:30:34Z","updated_at":"2016-08-22T17:54:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a55f8b5cbb37803d43659a1f66157ecda78109d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2281/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/d70588459dc62f2ec10de08a14513efdbce42e15","head":{"label":"sydidelot:fixes","ref":"fixes","sha":"d70588459dc62f2ec10de08a14513efdbce42e15","user":{"login":"sydidelot","id":377197,"avatar_url":"https://avatars.githubusercontent.com/u/377197?v=3","gravatar_id":"","url":"https://api.github.com/users/sydidelot","html_url":"https://github.com/sydidelot","followers_url":"https://api.github.com/users/sydidelot/followers","following_url":"https://api.github.com/users/sydidelot/following{/other_user}","gists_url":"https://api.github.com/users/sydidelot/gists{/gist_id}","starred_url":"https://api.github.com/users/sydidelot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydidelot/subscriptions","organizations_url":"https://api.github.com/users/sydidelot/orgs","repos_url":"https://api.github.com/users/sydidelot/repos","events_url":"https://api.github.com/users/sydidelot/events{/privacy}","received_events_url":"https://api.github.com/users/sydidelot/received_events","type":"User","site_admin":false},"repo":{"id":59916042,"name":"libfabric","full_name":"sydidelot/libfabric","owner":{"login":"sydidelot","id":377197,"avatar_url":"https://avatars.githubusercontent.com/u/377197?v=3","gravatar_id":"","url":"https://api.github.com/users/sydidelot","html_url":"https://github.com/sydidelot","followers_url":"https://api.github.com/users/sydidelot/followers","following_url":"https://api.github.com/users/sydidelot/following{/other_user}","gists_url":"https://api.github.com/users/sydidelot/gists{/gist_id}","starred_url":"https://api.github.com/users/sydidelot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydidelot/subscriptions","organizations_url":"https://api.github.com/users/sydidelot/orgs","repos_url":"https://api.github.com/users/sydidelot/repos","events_url":"https://api.github.com/users/sydidelot/events{/privacy}","received_events_url":"https://api.github.com/users/sydidelot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sydidelot/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/sydidelot/libfabric","forks_url":"https://api.github.com/repos/sydidelot/libfabric/forks","keys_url":"https://api.github.com/repos/sydidelot/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sydidelot/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sydidelot/libfabric/teams","hooks_url":"https://api.github.com/repos/sydidelot/libfabric/hooks","issue_events_url":"https://api.github.com/repos/sydidelot/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/sydidelot/libfabric/events","assignees_url":"https://api.github.com/repos/sydidelot/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/sydidelot/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/sydidelot/libfabric/tags","blobs_url":"https://api.github.com/repos/sydidelot/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sydidelot/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sydidelot/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/sydidelot/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sydidelot/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/sydidelot/libfabric/languages","stargazers_url":"https://api.github.com/repos/sydidelot/libfabric/stargazers","contributors_url":"https://api.github.com/repos/sydidelot/libfabric/contributors","subscribers_url":"https://api.github.com/repos/sydidelot/libfabric/subscribers","subscription_url":"https://api.github.com/repos/sydidelot/libfabric/subscription","commits_url":"https://api.github.com/repos/sydidelot/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/sydidelot/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/sydidelot/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/sydidelot/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/sydidelot/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/sydidelot/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sydidelot/libfabric/merges","archive_url":"https://api.github.com/repos/sydidelot/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sydidelot/libfabric/downloads","issues_url":"https://api.github.com/repos/sydidelot/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/sydidelot/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/sydidelot/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/sydidelot/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sydidelot/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/sydidelot/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/sydidelot/libfabric/deployments","created_at":"2016-05-28T21:58:05Z","updated_at":"2016-05-28T21:58:08Z","pushed_at":"2016-08-22T10:26:26Z","git_url":"git://github.com/sydidelot/libfabric.git","ssh_url":"git@github.com:sydidelot/libfabric.git","clone_url":"https://github.com/sydidelot/libfabric.git","svn_url":"https://github.com/sydidelot/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":12673,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"44ee13cd1dbda73c510b39128b4ca8cf3f97319f","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2016-08-10T19:24:12Z","pushed_at":"2016-08-22T16:36:04Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":13851,"stargazers_count":74,"watchers_count":74,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":85,"forks":76,"open_issues":85,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2281"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2281"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2281/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2281/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/d70588459dc62f2ec10de08a14513efdbce42e15"}}}}
{"actor":{"display_login":"a-ilango"}}