{"action":"created","issue":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1137","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1137/labels{/name}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1137/comments","events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1137/events","html_url":"https://github.com/PCSX2/pcsx2/pull/1137","id":127842858,"number":1137,"title":"PCRTC: Proper handling for 720P/1080P video modes.","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-21T04:32:16Z","updated_at":"2016-01-23T15:40:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1137","html_url":"https://github.com/PCSX2/pcsx2/pull/1137","diff_url":"https://github.com/PCSX2/pcsx2/pull/1137.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1137.patch"},"body":"**Summary of changes:**\r\n\r\n* Properly Initialize the height , width value. we previously only initialize the DH, DW register values which aren't the exact height/width. I'm actually surprised that the older check for height (pool paradise) worked ! It's usually not a problem since MAGV value is usually 0 at most instances. The correct formula for width and height are ``(DW + 1) / (MAGH +1)`` and ``(DH + 1) / (MAGV + 1)``.\r\n\r\n* Add a nice print debug message to easily debug games by uncommenting the code. ( I can understand if you don't want this commit though )\r\n\r\n* Allow 640+ height values for all Vmodes except PAL/NTSC as they need the higher height value for proper display size. \r\n\r\n**Additional Information:**\r\nHere's a nice picture to explain the role of the Display register values :\r\n\r\n![pic](http://ultraimg.com/images/crt.jpg)\r\n\r\n\r\n\r\n**Example of observed changes of the commit:**\r\n\r\n\r\n**1080P (before commit)**\r\n![wrong](http://ultraimg.com/images/gsdx_20160120023759.png)\r\n\r\n**1080P (after commit)**\r\n![correct](http://ultraimg.com/images/gsdx_20160120021153.png)\r\n"},"comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments/174194465","html_url":"https://github.com/PCSX2/pcsx2/pull/1137#issuecomment-174194465","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1137","id":174194465,"user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"created_at":"2016-01-23T15:40:39Z","updated_at":"2016-01-23T15:40:39Z","body":"> Any changes on Gran Turismo 4? It zooms the image in 1080i mode.\r\n\r\n>> **Note**: This Pull request **only removes a part of the problems** with the 720P/1080P video modes , the other source of issue - wrong MAGH/MAGV values still needs to be dealt with for accurate display on 720P/1080P video modes.\r\n\r\n@gregory38 \r\n>It means a single cmode value but you code don't do that but !=\r\n\r\nI'm not sure i understand you.. only NTSC/PAL use different CMOD values 2 and 3. all other Vmode's have CMOD value of 0."}}