{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/50239083","id":50239083,"diff_hunk":"@@ -26,9 +26,6 @@ import path = require('path');\n // Quick start\n // https://github.com/atom/electron/blob/master/docs/tutorial/quick-start.md\n \n-// Report crashes to our server.\n-require('crash-reporter').start();\n-","path":"github-electron/github-electron-main-tests.ts","position":6,"original_position":6,"commit_id":"95b13ce5e2fe3ee496a1339e010f10aa74082fa3","original_commit_id":"95b13ce5e2fe3ee496a1339e010f10aa74082fa3","user":{"login":"hinamiyagk","id":8928378,"avatar_url":"https://avatars.githubusercontent.com/u/8928378?v=3","gravatar_id":"","url":"https://api.github.com/users/hinamiyagk","html_url":"https://github.com/hinamiyagk","followers_url":"https://api.github.com/users/hinamiyagk/followers","following_url":"https://api.github.com/users/hinamiyagk/following{/other_user}","gists_url":"https://api.github.com/users/hinamiyagk/gists{/gist_id}","starred_url":"https://api.github.com/users/hinamiyagk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hinamiyagk/subscriptions","organizations_url":"https://api.github.com/users/hinamiyagk/orgs","repos_url":"https://api.github.com/users/hinamiyagk/repos","events_url":"https://api.github.com/users/hinamiyagk/events{/privacy}","received_events_url":"https://api.github.com/users/hinamiyagk/received_events","type":"User","site_admin":false},"body":"https://github.com/hinamiyagk/DefinitelyTyped/blob/crashreporter-start-option/github-electron/github-electron-main-tests.ts#L493-L501\r\nI think it's OK because test already exists.","created_at":"2016-01-20T10:43:15Z","updated_at":"2016-01-20T10:43:15Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/7689#discussion_r50239083","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/50239083"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/7689#discussion_r50239083"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689","id":56441824,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/7689","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/7689.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/7689.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/7689","number":7689,"state":"open","locked":false,"title":"Make companyName and submitURL option required on crashReporter.start","user":{"login":"hinamiyagk","id":8928378,"avatar_url":"https://avatars.githubusercontent.com/u/8928378?v=3","gravatar_id":"","url":"https://api.github.com/users/hinamiyagk","html_url":"https://github.com/hinamiyagk","followers_url":"https://api.github.com/users/hinamiyagk/followers","following_url":"https://api.github.com/users/hinamiyagk/following{/other_user}","gists_url":"https://api.github.com/users/hinamiyagk/gists{/gist_id}","starred_url":"https://api.github.com/users/hinamiyagk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hinamiyagk/subscriptions","organizations_url":"https://api.github.com/users/hinamiyagk/orgs","repos_url":"https://api.github.com/users/hinamiyagk/repos","events_url":"https://api.github.com/users/hinamiyagk/events{/privacy}","received_events_url":"https://api.github.com/users/hinamiyagk/received_events","type":"User","site_admin":false},"body":"https://github.com/atom/electron/blob/v0.36.4/docs/api/crash-reporter.md#crashreporterstartoptions\r\nNow companyName and submitURL properties are required in crashReporter.start parameter.","created_at":"2016-01-19T09:43:40Z","updated_at":"2016-01-20T10:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eb1e3dbc8fb7eea415f00d26ec29fa7a2608a4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/7689/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/95b13ce5e2fe3ee496a1339e010f10aa74082fa3","head":{"label":"hinamiyagk:crashreporter-start-option","ref":"crashreporter-start-option","sha":"95b13ce5e2fe3ee496a1339e010f10aa74082fa3","user":{"login":"hinamiyagk","id":8928378,"avatar_url":"https://avatars.githubusercontent.com/u/8928378?v=3","gravatar_id":"","url":"https://api.github.com/users/hinamiyagk","html_url":"https://github.com/hinamiyagk","followers_url":"https://api.github.com/users/hinamiyagk/followers","following_url":"https://api.github.com/users/hinamiyagk/following{/other_user}","gists_url":"https://api.github.com/users/hinamiyagk/gists{/gist_id}","starred_url":"https://api.github.com/users/hinamiyagk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hinamiyagk/subscriptions","organizations_url":"https://api.github.com/users/hinamiyagk/orgs","repos_url":"https://api.github.com/users/hinamiyagk/repos","events_url":"https://api.github.com/users/hinamiyagk/events{/privacy}","received_events_url":"https://api.github.com/users/hinamiyagk/received_events","type":"User","site_admin":false},"repo":{"id":48700606,"name":"DefinitelyTyped","full_name":"hinamiyagk/DefinitelyTyped","owner":{"login":"hinamiyagk","id":8928378,"avatar_url":"https://avatars.githubusercontent.com/u/8928378?v=3","gravatar_id":"","url":"https://api.github.com/users/hinamiyagk","html_url":"https://github.com/hinamiyagk","followers_url":"https://api.github.com/users/hinamiyagk/followers","following_url":"https://api.github.com/users/hinamiyagk/following{/other_user}","gists_url":"https://api.github.com/users/hinamiyagk/gists{/gist_id}","starred_url":"https://api.github.com/users/hinamiyagk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hinamiyagk/subscriptions","organizations_url":"https://api.github.com/users/hinamiyagk/orgs","repos_url":"https://api.github.com/users/hinamiyagk/repos","events_url":"https://api.github.com/users/hinamiyagk/events{/privacy}","received_events_url":"https://api.github.com/users/hinamiyagk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hinamiyagk/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped","forks_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/hinamiyagk/DefinitelyTyped/releases{/id}","created_at":"2015-12-28T16:07:34Z","updated_at":"2016-01-19T09:23:18Z","pushed_at":"2016-01-19T10:09:48Z","git_url":"git://github.com/hinamiyagk/DefinitelyTyped.git","ssh_url":"git@github.com:hinamiyagk/DefinitelyTyped.git","clone_url":"https://github.com/hinamiyagk/DefinitelyTyped.git","svn_url":"https://github.com/hinamiyagk/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":80089,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"93bae1bb4c887c1375a4c1f0c3bb849ff06b8ac6","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","created_at":"2012-10-05T16:39:45Z","updated_at":"2016-01-20T09:50:47Z","pushed_at":"2016-01-20T10:27:44Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":99173,"stargazers_count":5900,"watchers_count":5900,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4150,"mirror_url":null,"open_issues_count":1018,"forks":4150,"open_issues":1018,"watchers":5900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/7689"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/7689"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/7689/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/7689/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/95b13ce5e2fe3ee496a1339e010f10aa74082fa3"}}}}