{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/71944066","id":71944066,"diff_hunk":"@@ -23,28 +23,46 @@\n \n import regex\n \n-def parse(lines, error_re, hilight_words, filters):\n+def parse(lines, hilight_words, filters, objref_dict):\n     \"\"\"\n-    Given filters returns indeces of wanted lines from the kubelet log\n+    Given filters returns indeces of wanted lines from log\n \n     Args:\n-        lines: array of kubelet log lines\n-        error_re: regular expression of the failed pod name\n+        lines: array of log lines\n         hilight_words: array of words that need to be bolded\n         filters: dictionary of which filters to apply","path":"gubernator/kubelet_parser.py","position":15,"original_position":15,"commit_id":"be92842ff6c06f39eebbb8ab95d301ffe3a3ada1","original_commit_id":"2c2562ae381121fb166a4e9917c546daef9f5e8a","user":{"login":"mnshaw","id":12521747,"avatar_url":"https://avatars.githubusercontent.com/u/12521747?v=3","gravatar_id":"","url":"https://api.github.com/users/mnshaw","html_url":"https://github.com/mnshaw","followers_url":"https://api.github.com/users/mnshaw/followers","following_url":"https://api.github.com/users/mnshaw/following{/other_user}","gists_url":"https://api.github.com/users/mnshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mnshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnshaw/subscriptions","organizations_url":"https://api.github.com/users/mnshaw/orgs","repos_url":"https://api.github.com/users/mnshaw/repos","events_url":"https://api.github.com/users/mnshaw/events{/privacy}","received_events_url":"https://api.github.com/users/mnshaw/received_events","type":"User","site_admin":false},"body":"Addressed in new commit. It's a dictionary between possible filters and what string they would bold in the logs if the filter was on. Right now it only has information lifted from a line with an ObjectReference mention in the kubelet log, but the variable name should be changed as more filters are added.","created_at":"2016-07-22T20:51:02Z","updated_at":"2016-07-22T20:51:02Z","html_url":"https://github.com/kubernetes/test-infra/pull/296#discussion_r71944066","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/296","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/71944066"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/296#discussion_r71944066"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/296","id":78221998,"html_url":"https://github.com/kubernetes/test-infra/pull/296","diff_url":"https://github.com/kubernetes/test-infra/pull/296.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/296.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/296","number":296,"state":"open","locked":false,"title":"Refactor objref dictionary, consolidate filtering into one page","user":{"login":"mnshaw","id":12521747,"avatar_url":"https://avatars.githubusercontent.com/u/12521747?v=3","gravatar_id":"","url":"https://api.github.com/users/mnshaw","html_url":"https://github.com/mnshaw","followers_url":"https://api.github.com/users/mnshaw/followers","following_url":"https://api.github.com/users/mnshaw/following{/other_user}","gists_url":"https://api.github.com/users/mnshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mnshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnshaw/subscriptions","organizations_url":"https://api.github.com/users/mnshaw/orgs","repos_url":"https://api.github.com/users/mnshaw/repos","events_url":"https://api.github.com/users/mnshaw/events{/privacy}","received_events_url":"https://api.github.com/users/mnshaw/received_events","type":"User","site_admin":false},"body":"Fixed bug where UID/Namespace was not actually found throughout log files.\r\nAdded line wrapping as option.\r\n\r\nThe dictionary from objref is found first in the kubelet log and then is used when parsing the kubelet or kube-api server log. I am planning on making one page for all logs/filtering so there won't be separate links for kubelet.log and kube-apiserver.log. Hopefully some of this refactoring will make sense more then. \r\n@timstclair  @rmmh \r\n","created_at":"2016-07-20T21:24:03Z","updated_at":"2016-07-22T20:51:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f1e9111e95a5c6fd91b18eb3709bcff69dd9172","assignee":{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/296/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/296/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/296/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/be92842ff6c06f39eebbb8ab95d301ffe3a3ada1","head":{"label":"mnshaw:dict-for-each-failure","ref":"dict-for-each-failure","sha":"be92842ff6c06f39eebbb8ab95d301ffe3a3ada1","user":{"login":"mnshaw","id":12521747,"avatar_url":"https://avatars.githubusercontent.com/u/12521747?v=3","gravatar_id":"","url":"https://api.github.com/users/mnshaw","html_url":"https://github.com/mnshaw","followers_url":"https://api.github.com/users/mnshaw/followers","following_url":"https://api.github.com/users/mnshaw/following{/other_user}","gists_url":"https://api.github.com/users/mnshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mnshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnshaw/subscriptions","organizations_url":"https://api.github.com/users/mnshaw/orgs","repos_url":"https://api.github.com/users/mnshaw/repos","events_url":"https://api.github.com/users/mnshaw/events{/privacy}","received_events_url":"https://api.github.com/users/mnshaw/received_events","type":"User","site_admin":false},"repo":{"id":62256956,"name":"test-infra","full_name":"mnshaw/test-infra","owner":{"login":"mnshaw","id":12521747,"avatar_url":"https://avatars.githubusercontent.com/u/12521747?v=3","gravatar_id":"","url":"https://api.github.com/users/mnshaw","html_url":"https://github.com/mnshaw","followers_url":"https://api.github.com/users/mnshaw/followers","following_url":"https://api.github.com/users/mnshaw/following{/other_user}","gists_url":"https://api.github.com/users/mnshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mnshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnshaw/subscriptions","organizations_url":"https://api.github.com/users/mnshaw/orgs","repos_url":"https://api.github.com/users/mnshaw/repos","events_url":"https://api.github.com/users/mnshaw/events{/privacy}","received_events_url":"https://api.github.com/users/mnshaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnshaw/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/mnshaw/test-infra","forks_url":"https://api.github.com/repos/mnshaw/test-infra/forks","keys_url":"https://api.github.com/repos/mnshaw/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnshaw/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnshaw/test-infra/teams","hooks_url":"https://api.github.com/repos/mnshaw/test-infra/hooks","issue_events_url":"https://api.github.com/repos/mnshaw/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/mnshaw/test-infra/events","assignees_url":"https://api.github.com/repos/mnshaw/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/mnshaw/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/mnshaw/test-infra/tags","blobs_url":"https://api.github.com/repos/mnshaw/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnshaw/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnshaw/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnshaw/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnshaw/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/mnshaw/test-infra/languages","stargazers_url":"https://api.github.com/repos/mnshaw/test-infra/stargazers","contributors_url":"https://api.github.com/repos/mnshaw/test-infra/contributors","subscribers_url":"https://api.github.com/repos/mnshaw/test-infra/subscribers","subscription_url":"https://api.github.com/repos/mnshaw/test-infra/subscription","commits_url":"https://api.github.com/repos/mnshaw/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnshaw/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnshaw/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnshaw/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnshaw/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/mnshaw/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnshaw/test-infra/merges","archive_url":"https://api.github.com/repos/mnshaw/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnshaw/test-infra/downloads","issues_url":"https://api.github.com/repos/mnshaw/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/mnshaw/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/mnshaw/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/mnshaw/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnshaw/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/mnshaw/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/mnshaw/test-infra/deployments","created_at":"2016-06-29T20:49:30Z","updated_at":"2016-06-29T20:49:31Z","pushed_at":"2016-07-22T20:43:57Z","git_url":"git://github.com/mnshaw/test-infra.git","ssh_url":"git@github.com:mnshaw/test-infra.git","clone_url":"https://github.com/mnshaw/test-infra.git","svn_url":"https://github.com/mnshaw/test-infra","homepage":null,"size":961,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d034ac59c541b8e5eba6b0a324da6581093cb912","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2016-07-14T21:58:10Z","pushed_at":"2016-07-22T20:43:57Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":1152,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":32,"forks":43,"open_issues":32,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/296"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/296"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/296"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/be92842ff6c06f39eebbb8ab95d301ffe3a3ada1"}}}}
{"actor":{"display_login":"mnshaw"}}