{"push_id":1135209919,"size":2,"distinct_size":1,"ref":"refs/heads/CHE-306-4","head":"f22454412fa0e7f9eea4888afe6793835552d2cf","before":"d5d0889aa97dc63625208efbd811b69578a4b970","commits":[{"sha":"ae4c5521bf2202740fc211ee3d2e94881e414d59","author":{"name":"Florent BENOIT","email":"ab49a16e71c1aaf40ed121e1cd3880c5715b93c4@codenvy.com"},"message":"CODENVY-560 : Introduce new type for providing docker recipes and remove InstanceKey\n\n#1 new docker recipe type\n\ncurrently we have type:\"dockerfile\", location: \"http://path-to-recipe\"\n\nnow we could provide\ntype:\"dockerfile\", content: \"FROM codenvy/foo\\nENV FLORENT=TRUE\\\"\n\nand\ntype:\"image\", location or content: \"codenvy/foo\"\n\n#2 InstanceKey\nUp to now, InstanceKey was used to perform snapshot recovery.\nBut machine source is a way to provide this information.\nSo remove InstanceKey and replace it by MachineSource (and DockerMachineSource instead of DockerInstanceKey)\n\nInstanceProvider:\nvoid removeInstanceSnapshot(InstanceKey instanceKey)\n--> void removeInstanceSnapshot(MachineSource machineSource)\n\nInstance:\nInstanceKey saveToSnapshot(String owner)\n--> MachineSource saveToSnapshot(String owner)\n\n#3 InstanceProvider model\nTo avoid also that MachineManager \"knows\" the inner type, the recipe handling is moved to the instance provider implementation\nAnd as the snapshot handling is with MachineSource (included in MachineConfig included in Machine), no need to give extra InstanceKey parameter\n\nReplace two previous methods\n\nInstance createInstance(Recipe recipe,\n                            Machine machine,\n                            LineConsumer creationLogsOutput)\n\n Instance createInstance(InstanceKey instanceKey,\n                            Machine machine,\n                            LineConsumer creationLogsOutput) throws NotFoundException, InvalidInstanceSnapshotException, MachineException;\n\nby only one:\n   createInstance(Machine machine,\n                            LineConsumer creationLogsOutput)\n\nChange-Id: Ia7ea97bc1a44059b4892f5db387f54f2e1709fa3\nSigned-off-by: Florent BENOIT <fbenoit@codenvy.com>","distinct":false,"url":"https://api.github.com/repos/eclipse/che/commits/ae4c5521bf2202740fc211ee3d2e94881e414d59"},{"sha":"f22454412fa0e7f9eea4888afe6793835552d2cf","author":{"name":"Alexander Garagatyi","email":"08e176077b00ca3684f39010301958ee0192148d@codenvy.com"},"message":"CHE-306: rework environment model\n\nSigned-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>","distinct":true,"url":"https://api.github.com/repos/eclipse/che/commits/f22454412fa0e7f9eea4888afe6793835552d2cf"}]}
{"actor":{"display_login":"garagatyi"}}