{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/88756226","pull_request_review_id":9323629,"id":88756226,"diff_hunk":"@@ -1872,7 +1872,8 @@ Store = Service.extend({\n     }\n     if (data) {\n       // normalize relationship IDs into records\n-      this._backburner.schedule('normalizeRelationships', this, this._setupRelationships, internalModel, data);\n+      this._pushedInternalModels.push(internalModel, data);\n+      this._backburner.schedule('normalizeRelationships', this, this._setupRelationships);","path":"addon/-private/system/store.js","position":6,"original_position":6,"commit_id":"ae3f97ca39bd2b057e38cb7089bfea0bb4027275","original_commit_id":"ae3f97ca39bd2b057e38cb7089bfea0bb4027275","user":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"body":"this should also check for an existing flush","created_at":"2016-11-18T23:00:25Z","updated_at":"2016-11-18T23:00:25Z","html_url":"https://github.com/emberjs/data/pull/4668#discussion_r88756226","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/4668","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/88756226"},"html":{"href":"https://github.com/emberjs/data/pull/4668#discussion_r88756226"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/4668"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4668","id":94451685,"html_url":"https://github.com/emberjs/data/pull/4668","diff_url":"https://github.com/emberjs/data/pull/4668.diff","patch_url":"https://github.com/emberjs/data/pull/4668.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/4668","number":4668,"state":"open","locked":false,"title":"[PERF] use micro-queue","user":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"body":"@stefanpenner and I were discussing how it's better to use a more specialized micro-queue than to push everything into backburner a few days ago. I was spelunking through a profile and noticed that pushing a bunch of records of one time wasn't batched even though I thought it should be, turns out the run.join + the excess calls to schedule were really hurting us.  In a few limited runs this seemed to help by as much as 30% on the time to push a bunch of records of the same type into the store.","created_at":"2016-11-18T22:55:02Z","updated_at":"2016-11-18T23:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a350f80d2e4399e8422325d8a82a50e1182c12d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/4668/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/4668/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4668/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/ae3f97ca39bd2b057e38cb7089bfea0bb4027275","head":{"label":"runspired:store-push-perf","ref":"store-push-perf","sha":"ae3f97ca39bd2b057e38cb7089bfea0bb4027275","user":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"repo":{"id":66430492,"name":"data","full_name":"runspired/data","owner":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runspired/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/runspired/data","forks_url":"https://api.github.com/repos/runspired/data/forks","keys_url":"https://api.github.com/repos/runspired/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runspired/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runspired/data/teams","hooks_url":"https://api.github.com/repos/runspired/data/hooks","issue_events_url":"https://api.github.com/repos/runspired/data/issues/events{/number}","events_url":"https://api.github.com/repos/runspired/data/events","assignees_url":"https://api.github.com/repos/runspired/data/assignees{/user}","branches_url":"https://api.github.com/repos/runspired/data/branches{/branch}","tags_url":"https://api.github.com/repos/runspired/data/tags","blobs_url":"https://api.github.com/repos/runspired/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runspired/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runspired/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/runspired/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runspired/data/statuses/{sha}","languages_url":"https://api.github.com/repos/runspired/data/languages","stargazers_url":"https://api.github.com/repos/runspired/data/stargazers","contributors_url":"https://api.github.com/repos/runspired/data/contributors","subscribers_url":"https://api.github.com/repos/runspired/data/subscribers","subscription_url":"https://api.github.com/repos/runspired/data/subscription","commits_url":"https://api.github.com/repos/runspired/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/runspired/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/runspired/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/runspired/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/runspired/data/contents/{+path}","compare_url":"https://api.github.com/repos/runspired/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runspired/data/merges","archive_url":"https://api.github.com/repos/runspired/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runspired/data/downloads","issues_url":"https://api.github.com/repos/runspired/data/issues{/number}","pulls_url":"https://api.github.com/repos/runspired/data/pulls{/number}","milestones_url":"https://api.github.com/repos/runspired/data/milestones{/number}","notifications_url":"https://api.github.com/repos/runspired/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runspired/data/labels{/name}","releases_url":"https://api.github.com/repos/runspired/data/releases{/id}","deployments_url":"https://api.github.com/repos/runspired/data/deployments","created_at":"2016-08-24T04:42:27Z","updated_at":"2016-08-24T04:42:29Z","pushed_at":"2016-11-18T22:51:14Z","git_url":"git://github.com/runspired/data.git","ssh_url":"git@github.com:runspired/data.git","clone_url":"https://github.com/runspired/data.git","svn_url":"https://github.com/runspired/data","homepage":"","size":12251,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"d291f94aa7bea373119e9befbbec1e7fb1b6e333","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2016-11-18T13:01:45Z","pushed_at":"2016-11-18T22:55:42Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":21959,"stargazers_count":2739,"watchers_count":2739,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1086,"mirror_url":null,"open_issues_count":187,"forks":1086,"open_issues":187,"watchers":2739,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/4668"},"html":{"href":"https://github.com/emberjs/data/pull/4668"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/4668"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/4668/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/4668/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/4668/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/ae3f97ca39bd2b057e38cb7089bfea0bb4027275"}}}}
{"actor":{"display_login":"runspired"}}