{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/60982350","id":60982350,"diff_hunk":"@@ -0,0 +1,52 @@\n+// Copyright (C) 2016 the V8 project authors. All rights reserved.\n+// This code is governed by the BSD license found in the LICENSE file.\n+/*---\n+esid: sec-%typedarray%.prototype.subarray\n+description: get inherited constructor on SpeciesConstructor\n+info: >\n+  22.2.3.27 %TypedArray%.prototype.subarray( begin , end )\n+\n+  ...\n+  17. Return ? TypedArraySpeciesCreate(O, argumentsList).\n+\n+  22.2.4.7 TypedArraySpeciesCreate ( exemplar, argumentList )\n+\n+  ...\n+  3. Let constructor be ? SpeciesConstructor(exemplar, defaultConstructor).\n+  ...\n+\n+  7.3.20 SpeciesConstructor ( O, defaultConstructor )\n+\n+  1. Assert: Type(O) is Object.\n+  2. Let C be ? Get(O, \"constructor\").\n+  3. If C is undefined, return defaultConstructor.\n+  ...\n+includes: [testTypedArray.js]\n+---*/\n+\n+testWithTypedArrayConstructors(function(TA) {\n+  var sample = new TA([40, 41, 42, 43]);\n+  var calls = 0;\n+  var result;\n+\n+  Object.defineProperty(TA.prototype, \"constructor\", {\n+    get: function() {\n+      calls++;\n+    }\n+  });\n+\n+  result = sample.subarray(0);\n+\n+  assert.sameValue(calls, 1, \"called custom ctor get accessor once\");\n+\n+  assert.sameValue(\n+    Object.getPrototypeOf(result),\n+    Object.getPrototypeOf(sample),\n+    \"use defaultCtor on an undefined return - getPrototypeOf check\"\n+  );\n+  assert.sameValue(\n+    result.constructor,\n+    undefined,\n+    \"used defaultCtor but still checks the inherited .constructor\"","path":"test/built-ins/TypedArray/prototype/subarray/speciesctor-get-ctor-inherited.js","position":50,"original_position":50,"commit_id":"1091944e8d4f077903f0aa0ffc1aa5b74ad0fcbb","original_commit_id":"e3b68a26b8bc96b62105862c04666cf0915fc897","user":{"login":"jugglinmike","id":677252,"avatar_url":"https://avatars.githubusercontent.com/u/677252?v=3","gravatar_id":"","url":"https://api.github.com/users/jugglinmike","html_url":"https://github.com/jugglinmike","followers_url":"https://api.github.com/users/jugglinmike/followers","following_url":"https://api.github.com/users/jugglinmike/following{/other_user}","gists_url":"https://api.github.com/users/jugglinmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jugglinmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jugglinmike/subscriptions","organizations_url":"https://api.github.com/users/jugglinmike/orgs","repos_url":"https://api.github.com/users/jugglinmike/repos","events_url":"https://api.github.com/users/jugglinmike/events{/privacy}","received_events_url":"https://api.github.com/users/jugglinmike/received_events","type":"User","site_admin":false},"body":"I don't think I explained myself very well. Let me try again.\r\n\r\nThe confusing part for me was that the assertion is \"proving\" that\r\n`result.constructor` is `undefind`, but there are many ways this could be true.\r\nIt could be that the instance has an \"own\" property whose value is `undefined`,\r\nit could be that the instance has no such \"own\" property, but that its\r\nprototype does, or it could be that a property with that name does not exist\r\nanywhere in the prototype chain at all.\r\n\r\nThe assertion message helps explain what is happening, but I was suggesting\r\nexplicit assertions that would also verify that.\r\n\r\n- An assertion using `hasOwnProperty` would clearly demonstrate that the value\r\n  `undefined` is *not* coming directly from the `result` object itself.\r\n\r\n    ```js\r\n    assert.sameValue(Object.hasOwnProperty.call(result, \"constructor\"), false);\r\n    ```\r\n\r\n- An assertion that `calls` is now `2` would demonstrate that the previous\r\n  assertion had triggered the invocation of the accessor property.\r\n\r\n    ```js\r\n    assert.sameValue(calls, 2);\r\n    ```\r\n\r\n  The newest assertion  does not demonstrate this because it re-sets the\r\n  `calls` variable. So as written, it seems like an unrelated test for accessor\r\n  properties. Asserting the value `2` *does* introduce a slight dependency\r\n  between the assertions, and I can appreciate if you want to avoid that. You\r\n  could avoid this by re-setting `calls` to `0` immediately before the\r\n  assertion.\r\n\r\nThat said, we are definitely going too far into tiny details. I haven't\r\nforgotten that the test is valid, all this discussion is just about a minor\r\nreadability improvement. I think it's fine to leave it as-is.\r\n\r\n> That's the scope for speciesctor-get-ctor only.\r\n\r\nAh, of course.","created_at":"2016-04-25T20:26:10Z","updated_at":"2016-04-25T20:26:10Z","html_url":"https://github.com/tc39/test262/pull/589#discussion_r60982350","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/589","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/60982350"},"html":{"href":"https://github.com/tc39/test262/pull/589#discussion_r60982350"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/589"}}},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/589","id":67088999,"html_url":"https://github.com/tc39/test262/pull/589","diff_url":"https://github.com/tc39/test262/pull/589.diff","patch_url":"https://github.com/tc39/test262/pull/589.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/589","number":589,"state":"open","locked":false,"title":"Add tests for %TypedArray%.prototype.subarray","user":{"login":"leobalter","id":301201,"avatar_url":"https://avatars.githubusercontent.com/u/301201?v=3","gravatar_id":"","url":"https://api.github.com/users/leobalter","html_url":"https://github.com/leobalter","followers_url":"https://api.github.com/users/leobalter/followers","following_url":"https://api.github.com/users/leobalter/following{/other_user}","gists_url":"https://api.github.com/users/leobalter/gists{/gist_id}","starred_url":"https://api.github.com/users/leobalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leobalter/subscriptions","organizations_url":"https://api.github.com/users/leobalter/orgs","repos_url":"https://api.github.com/users/leobalter/repos","events_url":"https://api.github.com/users/leobalter/events{/privacy}","received_events_url":"https://api.github.com/users/leobalter/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-19T21:00:03Z","updated_at":"2016-04-25T20:26:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f7570302c3dba6deb97bc1cff69bade1ccff113","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/589/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/589/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/589/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/1091944e8d4f077903f0aa0ffc1aa5b74ad0fcbb","head":{"label":"bocoup:ta-subarray","ref":"ta-subarray","sha":"1091944e8d4f077903f0aa0ffc1aa5b74ad0fcbb","user":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"repo":{"id":30556261,"name":"test262","full_name":"bocoup/test262","owner":{"login":"bocoup","id":497466,"avatar_url":"https://avatars.githubusercontent.com/u/497466?v=3","gravatar_id":"","url":"https://api.github.com/users/bocoup","html_url":"https://github.com/bocoup","followers_url":"https://api.github.com/users/bocoup/followers","following_url":"https://api.github.com/users/bocoup/following{/other_user}","gists_url":"https://api.github.com/users/bocoup/gists{/gist_id}","starred_url":"https://api.github.com/users/bocoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocoup/subscriptions","organizations_url":"https://api.github.com/users/bocoup/orgs","repos_url":"https://api.github.com/users/bocoup/repos","events_url":"https://api.github.com/users/bocoup/events{/privacy}","received_events_url":"https://api.github.com/users/bocoup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bocoup/test262","description":"","fork":true,"url":"https://api.github.com/repos/bocoup/test262","forks_url":"https://api.github.com/repos/bocoup/test262/forks","keys_url":"https://api.github.com/repos/bocoup/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bocoup/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bocoup/test262/teams","hooks_url":"https://api.github.com/repos/bocoup/test262/hooks","issue_events_url":"https://api.github.com/repos/bocoup/test262/issues/events{/number}","events_url":"https://api.github.com/repos/bocoup/test262/events","assignees_url":"https://api.github.com/repos/bocoup/test262/assignees{/user}","branches_url":"https://api.github.com/repos/bocoup/test262/branches{/branch}","tags_url":"https://api.github.com/repos/bocoup/test262/tags","blobs_url":"https://api.github.com/repos/bocoup/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bocoup/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bocoup/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/bocoup/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bocoup/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/bocoup/test262/languages","stargazers_url":"https://api.github.com/repos/bocoup/test262/stargazers","contributors_url":"https://api.github.com/repos/bocoup/test262/contributors","subscribers_url":"https://api.github.com/repos/bocoup/test262/subscribers","subscription_url":"https://api.github.com/repos/bocoup/test262/subscription","commits_url":"https://api.github.com/repos/bocoup/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/bocoup/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/bocoup/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/bocoup/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/bocoup/test262/contents/{+path}","compare_url":"https://api.github.com/repos/bocoup/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bocoup/test262/merges","archive_url":"https://api.github.com/repos/bocoup/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bocoup/test262/downloads","issues_url":"https://api.github.com/repos/bocoup/test262/issues{/number}","pulls_url":"https://api.github.com/repos/bocoup/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/bocoup/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/bocoup/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bocoup/test262/labels{/name}","releases_url":"https://api.github.com/repos/bocoup/test262/releases{/id}","deployments_url":"https://api.github.com/repos/bocoup/test262/deployments","created_at":"2015-02-09T20:17:23Z","updated_at":"2016-02-10T20:14:58Z","pushed_at":"2016-04-25T19:50:14Z","git_url":"git://github.com/bocoup/test262.git","ssh_url":"git@github.com:bocoup/test262.git","clone_url":"https://github.com/bocoup/test262.git","svn_url":"https://github.com/bocoup/test262","homepage":"http://test262.ecmascript.org","size":54528,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":64,"forks":0,"open_issues":64,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"04a3c28f7d3552df2d40de53a860e0feea0a4909","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2016-04-20T17:00:01Z","pushed_at":"2016-04-25T19:13:35Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":55964,"stargazers_count":276,"watchers_count":276,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":78,"forks":95,"open_issues":78,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/589"},"html":{"href":"https://github.com/tc39/test262/pull/589"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/589"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/1091944e8d4f077903f0aa0ffc1aa5b74ad0fcbb"}}}}