{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16692","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16692/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16692/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16692/events","html_url":"https://github.com/mantidproject/mantid/pull/16692","id":161563027,"number":16692,"title":"BioSANS sensitivity correction","user":{"login":"ricleal","id":1866557,"avatar_url":"https://avatars.githubusercontent.com/u/1866557?v=3","gravatar_id":"","url":"https://api.github.com/users/ricleal","html_url":"https://github.com/ricleal","followers_url":"https://api.github.com/users/ricleal/followers","following_url":"https://api.github.com/users/ricleal/following{/other_user}","gists_url":"https://api.github.com/users/ricleal/gists{/gist_id}","starred_url":"https://api.github.com/users/ricleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricleal/subscriptions","organizations_url":"https://api.github.com/users/ricleal/orgs","repos_url":"https://api.github.com/users/ricleal/repos","events_url":"https://api.github.com/users/ricleal/events{/privacy}","received_events_url":"https://api.github.com/users/ricleal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20SANS","name":"Component: SANS","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"mdoucet","id":1108748,"avatar_url":"https://avatars.githubusercontent.com/u/1108748?v=3","gravatar_id":"","url":"https://api.github.com/users/mdoucet","html_url":"https://github.com/mdoucet","followers_url":"https://api.github.com/users/mdoucet/followers","following_url":"https://api.github.com/users/mdoucet/following{/other_user}","gists_url":"https://api.github.com/users/mdoucet/gists{/gist_id}","starred_url":"https://api.github.com/users/mdoucet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdoucet/subscriptions","organizations_url":"https://api.github.com/users/mdoucet/orgs","repos_url":"https://api.github.com/users/mdoucet/repos","events_url":"https://api.github.com/users/mdoucet/events{/privacy}","received_events_url":"https://api.github.com/users/mdoucet/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":636,"closed_issues":181,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-06-23T01:01:52Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"comments":0,"created_at":"2016-06-21T23:29:30Z","updated_at":"2016-06-23T01:32:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16692","html_url":"https://github.com/mantidproject/mantid/pull/16692","diff_url":"https://github.com/mantidproject/mantid/pull/16692.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16692.patch"},"body":"`SensitivityCorrection` was not working for BioSANS (new wing detector)\r\n\r\nNow, if `MaskComponent(\"component name\")` is used, `SensitivityCorrection` discards this detector for the correction.\r\n\r\n`Mask(nx_low=0, nx_high=0, ny_low=5, ny_high=5, component_name=\"component name\")` was not masking all edges. It is now fixed.\r\n\r\nSee #16674\r\n\r\n**To test:**\r\n\r\nThis branch is is analysis in `/HFIR/CG3/shared/mantid/Build`. You can test it from there using the script:\r\n`/HFIR/CG3/shared/data/CG3_mantid_test/Exp318.py `\r\nCommenting out the Sensitivity to see the result in Iq.\r\n\r\nFor the Mask, either play with `Mask` and number of edges masked, or use `SANSMask` and play with the MaskEdges list.\r\n\r\nFixes #16674.\r\n\r\n*Does not need to be in the release notes.*\r\n\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/227926010","html_url":"https://github.com/mantidproject/mantid/pull/16692#issuecomment-227926010","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16692","id":227926010,"user":{"login":"ricleal","id":1866557,"avatar_url":"https://avatars.githubusercontent.com/u/1866557?v=3","gravatar_id":"","url":"https://api.github.com/users/ricleal","html_url":"https://github.com/ricleal","followers_url":"https://api.github.com/users/ricleal/followers","following_url":"https://api.github.com/users/ricleal/following{/other_user}","gists_url":"https://api.github.com/users/ricleal/gists{/gist_id}","starred_url":"https://api.github.com/users/ricleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricleal/subscriptions","organizations_url":"https://api.github.com/users/ricleal/orgs","repos_url":"https://api.github.com/users/ricleal/repos","events_url":"https://api.github.com/users/ricleal/events{/privacy}","received_events_url":"https://api.github.com/users/ricleal/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T01:32:25Z","updated_at":"2016-06-23T01:32:25Z","body":"@mdoucet : Can you please test this tomorrow (Thursday)? so the BioSANS folk can use on Friday...\r\n"}}
{"actor":{"display_login":"ricleal"}}