{"action":"created","comment":{"url":"https://api.github.com/repos/oVirt/vdsm/pulls/comments/81596848","pull_request_review_id":2562690,"id":81596848,"diff_hunk":"@@ -152,20 +150,20 @@ def __getResourceCandidatesList(self, resourceName, lockType):\n         try:\n             if template:\n                 if len(volUUIDChain) > 0:\n-                    volRes = rmanager.acquireResource(\n+                    volRes = rm.acquireResource(\n                         self.volumeResourcesNamespace,\n                         template, rm.SHARED,\n                         timeout=self.resource_default_timeout)\n                 else:\n-                    volRes = rmanager.acquireResource(\n+                    volRes = rm.acquireResource(\n                         self.volumeResourcesNamespace,\n                         template, lockType,\n                         timeout=self.resource_default_timeout)\n                 volResourcesList.append(volRes)\n \n             # Acquire 'lockType' volume locks\n             for volUUID in volUUIDChain:\n-                volRes = rmanager.acquireResource(\n+                volRes = rm.acquireResource(\n                     self.volumeResourcesNamespace,","path":"vdsm/storage/resourceFactories.py","position":30,"original_position":30,"commit_id":"34f717ab0347fca0644cbaaf2dd2a89f9165bb96","original_commit_id":"8a868cc576d012e46ded88ca69970c9d5faf88d2","user":{"login":"aglitke","id":333311,"avatar_url":"https://avatars.githubusercontent.com/u/333311?v=3","gravatar_id":"","url":"https://api.github.com/users/aglitke","html_url":"https://github.com/aglitke","followers_url":"https://api.github.com/users/aglitke/followers","following_url":"https://api.github.com/users/aglitke/following{/other_user}","gists_url":"https://api.github.com/users/aglitke/gists{/gist_id}","starred_url":"https://api.github.com/users/aglitke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aglitke/subscriptions","organizations_url":"https://api.github.com/users/aglitke/orgs","repos_url":"https://api.github.com/users/aglitke/repos","events_url":"https://api.github.com/users/aglitke/events{/privacy}","received_events_url":"https://api.github.com/users/aglitke/received_events","type":"User","site_admin":false},"body":"Looks good","created_at":"2016-10-03T17:22:14Z","updated_at":"2016-10-03T17:22:14Z","html_url":"https://github.com/oVirt/vdsm/pull/5#discussion_r81596848","pull_request_url":"https://api.github.com/repos/oVirt/vdsm/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/oVirt/vdsm/pulls/comments/81596848"},"html":{"href":"https://github.com/oVirt/vdsm/pull/5#discussion_r81596848"},"pull_request":{"href":"https://api.github.com/repos/oVirt/vdsm/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/oVirt/vdsm/pulls/5","id":87647907,"html_url":"https://github.com/oVirt/vdsm/pull/5","diff_url":"https://github.com/oVirt/vdsm/pull/5.diff","patch_url":"https://github.com/oVirt/vdsm/pull/5.patch","issue_url":"https://api.github.com/repos/oVirt/vdsm/issues/5","number":5,"state":"open","locked":false,"title":"Sp cleanup","user":{"login":"nirs","id":395026,"avatar_url":"https://avatars.githubusercontent.com/u/395026?v=3","gravatar_id":"","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"body":"Various cleanups","created_at":"2016-10-02T21:49:22Z","updated_at":"2016-10-03T18:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"532ecb291059c642b53936b8cf3bfc28e7db0a86","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oVirt/vdsm/pulls/5/commits","review_comments_url":"https://api.github.com/repos/oVirt/vdsm/pulls/5/comments","review_comment_url":"https://api.github.com/repos/oVirt/vdsm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oVirt/vdsm/issues/5/comments","statuses_url":"https://api.github.com/repos/oVirt/vdsm/statuses/34f717ab0347fca0644cbaaf2dd2a89f9165bb96","head":{"label":"nirs:sp-cleanup","ref":"sp-cleanup","sha":"34f717ab0347fca0644cbaaf2dd2a89f9165bb96","user":{"login":"nirs","id":395026,"avatar_url":"https://avatars.githubusercontent.com/u/395026?v=3","gravatar_id":"","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"repo":{"id":21412988,"name":"vdsm","full_name":"nirs/vdsm","owner":{"login":"nirs","id":395026,"avatar_url":"https://avatars.githubusercontent.com/u/395026?v=3","gravatar_id":"","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nirs/vdsm","description":"This is a mirror from gerrit.ovirt.org","fork":true,"url":"https://api.github.com/repos/nirs/vdsm","forks_url":"https://api.github.com/repos/nirs/vdsm/forks","keys_url":"https://api.github.com/repos/nirs/vdsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirs/vdsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirs/vdsm/teams","hooks_url":"https://api.github.com/repos/nirs/vdsm/hooks","issue_events_url":"https://api.github.com/repos/nirs/vdsm/issues/events{/number}","events_url":"https://api.github.com/repos/nirs/vdsm/events","assignees_url":"https://api.github.com/repos/nirs/vdsm/assignees{/user}","branches_url":"https://api.github.com/repos/nirs/vdsm/branches{/branch}","tags_url":"https://api.github.com/repos/nirs/vdsm/tags","blobs_url":"https://api.github.com/repos/nirs/vdsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirs/vdsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirs/vdsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirs/vdsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirs/vdsm/statuses/{sha}","languages_url":"https://api.github.com/repos/nirs/vdsm/languages","stargazers_url":"https://api.github.com/repos/nirs/vdsm/stargazers","contributors_url":"https://api.github.com/repos/nirs/vdsm/contributors","subscribers_url":"https://api.github.com/repos/nirs/vdsm/subscribers","subscription_url":"https://api.github.com/repos/nirs/vdsm/subscription","commits_url":"https://api.github.com/repos/nirs/vdsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirs/vdsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirs/vdsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirs/vdsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/nirs/vdsm/contents/{+path}","compare_url":"https://api.github.com/repos/nirs/vdsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirs/vdsm/merges","archive_url":"https://api.github.com/repos/nirs/vdsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirs/vdsm/downloads","issues_url":"https://api.github.com/repos/nirs/vdsm/issues{/number}","pulls_url":"https://api.github.com/repos/nirs/vdsm/pulls{/number}","milestones_url":"https://api.github.com/repos/nirs/vdsm/milestones{/number}","notifications_url":"https://api.github.com/repos/nirs/vdsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirs/vdsm/labels{/name}","releases_url":"https://api.github.com/repos/nirs/vdsm/releases{/id}","deployments_url":"https://api.github.com/repos/nirs/vdsm/deployments","created_at":"2014-07-02T05:52:50Z","updated_at":"2016-03-26T21:22:23Z","pushed_at":"2016-10-03T01:07:47Z","git_url":"git://github.com/nirs/vdsm.git","ssh_url":"git@github.com:nirs/vdsm.git","clone_url":"https://github.com/nirs/vdsm.git","svn_url":"https://github.com/nirs/vdsm","homepage":"http://www.ovirt.org","size":28384,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oVirt:master","ref":"master","sha":"1c387c5583186afdbc8a1a3d950588c57566a24e","user":{"login":"oVirt","id":1318634,"avatar_url":"https://avatars.githubusercontent.com/u/1318634?v=3","gravatar_id":"","url":"https://api.github.com/users/oVirt","html_url":"https://github.com/oVirt","followers_url":"https://api.github.com/users/oVirt/followers","following_url":"https://api.github.com/users/oVirt/following{/other_user}","gists_url":"https://api.github.com/users/oVirt/gists{/gist_id}","starred_url":"https://api.github.com/users/oVirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oVirt/subscriptions","organizations_url":"https://api.github.com/users/oVirt/orgs","repos_url":"https://api.github.com/users/oVirt/repos","events_url":"https://api.github.com/users/oVirt/events{/privacy}","received_events_url":"https://api.github.com/users/oVirt/received_events","type":"Organization","site_admin":false},"repo":{"id":6408204,"name":"vdsm","full_name":"oVirt/vdsm","owner":{"login":"oVirt","id":1318634,"avatar_url":"https://avatars.githubusercontent.com/u/1318634?v=3","gravatar_id":"","url":"https://api.github.com/users/oVirt","html_url":"https://github.com/oVirt","followers_url":"https://api.github.com/users/oVirt/followers","following_url":"https://api.github.com/users/oVirt/following{/other_user}","gists_url":"https://api.github.com/users/oVirt/gists{/gist_id}","starred_url":"https://api.github.com/users/oVirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oVirt/subscriptions","organizations_url":"https://api.github.com/users/oVirt/orgs","repos_url":"https://api.github.com/users/oVirt/repos","events_url":"https://api.github.com/users/oVirt/events{/privacy}","received_events_url":"https://api.github.com/users/oVirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oVirt/vdsm","description":"This is a mirror for http://gerrit.ovirt.org, for issues use http://bugzilla.redhat.com","fork":false,"url":"https://api.github.com/repos/oVirt/vdsm","forks_url":"https://api.github.com/repos/oVirt/vdsm/forks","keys_url":"https://api.github.com/repos/oVirt/vdsm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oVirt/vdsm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oVirt/vdsm/teams","hooks_url":"https://api.github.com/repos/oVirt/vdsm/hooks","issue_events_url":"https://api.github.com/repos/oVirt/vdsm/issues/events{/number}","events_url":"https://api.github.com/repos/oVirt/vdsm/events","assignees_url":"https://api.github.com/repos/oVirt/vdsm/assignees{/user}","branches_url":"https://api.github.com/repos/oVirt/vdsm/branches{/branch}","tags_url":"https://api.github.com/repos/oVirt/vdsm/tags","blobs_url":"https://api.github.com/repos/oVirt/vdsm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oVirt/vdsm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oVirt/vdsm/git/refs{/sha}","trees_url":"https://api.github.com/repos/oVirt/vdsm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oVirt/vdsm/statuses/{sha}","languages_url":"https://api.github.com/repos/oVirt/vdsm/languages","stargazers_url":"https://api.github.com/repos/oVirt/vdsm/stargazers","contributors_url":"https://api.github.com/repos/oVirt/vdsm/contributors","subscribers_url":"https://api.github.com/repos/oVirt/vdsm/subscribers","subscription_url":"https://api.github.com/repos/oVirt/vdsm/subscription","commits_url":"https://api.github.com/repos/oVirt/vdsm/commits{/sha}","git_commits_url":"https://api.github.com/repos/oVirt/vdsm/git/commits{/sha}","comments_url":"https://api.github.com/repos/oVirt/vdsm/comments{/number}","issue_comment_url":"https://api.github.com/repos/oVirt/vdsm/issues/comments{/number}","contents_url":"https://api.github.com/repos/oVirt/vdsm/contents/{+path}","compare_url":"https://api.github.com/repos/oVirt/vdsm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oVirt/vdsm/merges","archive_url":"https://api.github.com/repos/oVirt/vdsm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oVirt/vdsm/downloads","issues_url":"https://api.github.com/repos/oVirt/vdsm/issues{/number}","pulls_url":"https://api.github.com/repos/oVirt/vdsm/pulls{/number}","milestones_url":"https://api.github.com/repos/oVirt/vdsm/milestones{/number}","notifications_url":"https://api.github.com/repos/oVirt/vdsm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oVirt/vdsm/labels{/name}","releases_url":"https://api.github.com/repos/oVirt/vdsm/releases{/id}","deployments_url":"https://api.github.com/repos/oVirt/vdsm/deployments","created_at":"2012-10-26T18:07:35Z","updated_at":"2016-09-23T15:16:13Z","pushed_at":"2016-10-03T14:01:14Z","git_url":"git://github.com/oVirt/vdsm.git","ssh_url":"git@github.com:oVirt/vdsm.git","clone_url":"https://github.com/oVirt/vdsm.git","svn_url":"https://github.com/oVirt/vdsm","homepage":"","size":35418,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":2,"forks":45,"open_issues":2,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oVirt/vdsm/pulls/5"},"html":{"href":"https://github.com/oVirt/vdsm/pull/5"},"issue":{"href":"https://api.github.com/repos/oVirt/vdsm/issues/5"},"comments":{"href":"https://api.github.com/repos/oVirt/vdsm/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/oVirt/vdsm/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/oVirt/vdsm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oVirt/vdsm/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/oVirt/vdsm/statuses/34f717ab0347fca0644cbaaf2dd2a89f9165bb96"}}}}
{"actor":{"display_login":"aglitke"}}