{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/13","id":83730843,"html_url":"https://github.com/Mojang/LegacyLauncher/pull/13","diff_url":"https://github.com/Mojang/LegacyLauncher/pull/13.diff","patch_url":"https://github.com/Mojang/LegacyLauncher/pull/13.patch","issue_url":"https://api.github.com/repos/Mojang/LegacyLauncher/issues/13","number":13,"state":"closed","locked":false,"title":"Fixed order of insertion for VanillaTweakInjector patch","user":{"login":"FyberOptic","id":5086735,"avatar_url":"https://avatars.githubusercontent.com/u/5086735?v=3","gravatar_id":"","url":"https://api.github.com/users/FyberOptic","html_url":"https://github.com/FyberOptic","followers_url":"https://api.github.com/users/FyberOptic/followers","following_url":"https://api.github.com/users/FyberOptic/following{/other_user}","gists_url":"https://api.github.com/users/FyberOptic/gists{/gist_id}","starred_url":"https://api.github.com/users/FyberOptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FyberOptic/subscriptions","organizations_url":"https://api.github.com/users/FyberOptic/orgs","repos_url":"https://api.github.com/users/FyberOptic/repos","events_url":"https://api.github.com/users/FyberOptic/events{/privacy}","received_events_url":"https://api.github.com/users/FyberOptic/received_events","type":"User","site_admin":false},"body":"There's a bug in the VanillaTweakInjector where the hook to set the minecraftDir variable is being done at the end of main, **after** startMainThread is called.  This results in an intermittent issue where the game directory isn't always set properly in time.  I confirmed this in both the vanilla launcher and MultiMC by simply opening an instance of Minecraft Beta 1.7.3 repeatedly and checking where it was trying to get my world saves from, and it would vary between the proper instance folder and the root .minecraft folder.\r\n\r\nTo verify the difference you can compare disassembled versions of net.mincraft.client.Minecraft using the standard debug parms:  -Dlegacy.debugClassLoading=true -Dlegacy.debugClassLoadingFiner=true -Dlegacy.debugClassLoadingSave=true\r\n\r\nNote that a consequence of using modern builds of Launchwrapper with old versions of the game though is that you have to add log4j and update ASM to 5.0.3 in the version json.\r\n\r\n","created_at":"2016-09-02T00:56:27Z","updated_at":"2016-09-02T09:25:37Z","closed_at":"2016-09-02T09:25:37Z","merged_at":null,"merge_commit_sha":"cec7bdeb2dedc8d41bd74413e73a574a447ef920","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mojang/LegacyLauncher/issues/13/comments","statuses_url":"https://api.github.com/repos/Mojang/LegacyLauncher/statuses/8d76423c804f9218fbce526ae854faa1777ee508","head":{"label":"FyberOptic:dirfix","ref":"dirfix","sha":"8d76423c804f9218fbce526ae854faa1777ee508","user":{"login":"FyberOptic","id":5086735,"avatar_url":"https://avatars.githubusercontent.com/u/5086735?v=3","gravatar_id":"","url":"https://api.github.com/users/FyberOptic","html_url":"https://github.com/FyberOptic","followers_url":"https://api.github.com/users/FyberOptic/followers","following_url":"https://api.github.com/users/FyberOptic/following{/other_user}","gists_url":"https://api.github.com/users/FyberOptic/gists{/gist_id}","starred_url":"https://api.github.com/users/FyberOptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FyberOptic/subscriptions","organizations_url":"https://api.github.com/users/FyberOptic/orgs","repos_url":"https://api.github.com/users/FyberOptic/repos","events_url":"https://api.github.com/users/FyberOptic/events{/privacy}","received_events_url":"https://api.github.com/users/FyberOptic/received_events","type":"User","site_admin":false},"repo":{"id":67174385,"name":"LegacyLauncher","full_name":"FyberOptic/LegacyLauncher","owner":{"login":"FyberOptic","id":5086735,"avatar_url":"https://avatars.githubusercontent.com/u/5086735?v=3","gravatar_id":"","url":"https://api.github.com/users/FyberOptic","html_url":"https://github.com/FyberOptic","followers_url":"https://api.github.com/users/FyberOptic/followers","following_url":"https://api.github.com/users/FyberOptic/following{/other_user}","gists_url":"https://api.github.com/users/FyberOptic/gists{/gist_id}","starred_url":"https://api.github.com/users/FyberOptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FyberOptic/subscriptions","organizations_url":"https://api.github.com/users/FyberOptic/orgs","repos_url":"https://api.github.com/users/FyberOptic/repos","events_url":"https://api.github.com/users/FyberOptic/events{/privacy}","received_events_url":"https://api.github.com/users/FyberOptic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FyberOptic/LegacyLauncher","description":"Hacky code to launch our old versions from the new launcher!","fork":true,"url":"https://api.github.com/repos/FyberOptic/LegacyLauncher","forks_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/forks","keys_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/teams","hooks_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/hooks","issue_events_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/issues/events{/number}","events_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/events","assignees_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/assignees{/user}","branches_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/branches{/branch}","tags_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/tags","blobs_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/git/refs{/sha}","trees_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/statuses/{sha}","languages_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/languages","stargazers_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/stargazers","contributors_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/contributors","subscribers_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/subscribers","subscription_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/subscription","commits_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/commits{/sha}","git_commits_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/git/commits{/sha}","comments_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/comments{/number}","issue_comment_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/issues/comments{/number}","contents_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/contents/{+path}","compare_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/merges","archive_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/downloads","issues_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/issues{/number}","pulls_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/pulls{/number}","milestones_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/milestones{/number}","notifications_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/labels{/name}","releases_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/releases{/id}","deployments_url":"https://api.github.com/repos/FyberOptic/LegacyLauncher/deployments","created_at":"2016-09-01T23:47:40Z","updated_at":"2016-09-01T23:47:41Z","pushed_at":"2016-09-02T00:47:24Z","git_url":"git://github.com/FyberOptic/LegacyLauncher.git","ssh_url":"git@github.com:FyberOptic/LegacyLauncher.git","clone_url":"https://github.com/FyberOptic/LegacyLauncher.git","svn_url":"https://github.com/FyberOptic/LegacyLauncher","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mojang:master","ref":"master","sha":"59c38e589bf2be7d6b9d1b03d9793d82ba2fa12e","user":{"login":"Mojang","id":1162641,"avatar_url":"https://avatars.githubusercontent.com/u/1162641?v=3","gravatar_id":"","url":"https://api.github.com/users/Mojang","html_url":"https://github.com/Mojang","followers_url":"https://api.github.com/users/Mojang/followers","following_url":"https://api.github.com/users/Mojang/following{/other_user}","gists_url":"https://api.github.com/users/Mojang/gists{/gist_id}","starred_url":"https://api.github.com/users/Mojang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mojang/subscriptions","organizations_url":"https://api.github.com/users/Mojang/orgs","repos_url":"https://api.github.com/users/Mojang/repos","events_url":"https://api.github.com/users/Mojang/events{/privacy}","received_events_url":"https://api.github.com/users/Mojang/received_events","type":"Organization","site_admin":false},"repo":{"id":9652972,"name":"LegacyLauncher","full_name":"Mojang/LegacyLauncher","owner":{"login":"Mojang","id":1162641,"avatar_url":"https://avatars.githubusercontent.com/u/1162641?v=3","gravatar_id":"","url":"https://api.github.com/users/Mojang","html_url":"https://github.com/Mojang","followers_url":"https://api.github.com/users/Mojang/followers","following_url":"https://api.github.com/users/Mojang/following{/other_user}","gists_url":"https://api.github.com/users/Mojang/gists{/gist_id}","starred_url":"https://api.github.com/users/Mojang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mojang/subscriptions","organizations_url":"https://api.github.com/users/Mojang/orgs","repos_url":"https://api.github.com/users/Mojang/repos","events_url":"https://api.github.com/users/Mojang/events{/privacy}","received_events_url":"https://api.github.com/users/Mojang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mojang/LegacyLauncher","description":"Hacky code to launch our old versions from the new launcher!","fork":false,"url":"https://api.github.com/repos/Mojang/LegacyLauncher","forks_url":"https://api.github.com/repos/Mojang/LegacyLauncher/forks","keys_url":"https://api.github.com/repos/Mojang/LegacyLauncher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mojang/LegacyLauncher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mojang/LegacyLauncher/teams","hooks_url":"https://api.github.com/repos/Mojang/LegacyLauncher/hooks","issue_events_url":"https://api.github.com/repos/Mojang/LegacyLauncher/issues/events{/number}","events_url":"https://api.github.com/repos/Mojang/LegacyLauncher/events","assignees_url":"https://api.github.com/repos/Mojang/LegacyLauncher/assignees{/user}","branches_url":"https://api.github.com/repos/Mojang/LegacyLauncher/branches{/branch}","tags_url":"https://api.github.com/repos/Mojang/LegacyLauncher/tags","blobs_url":"https://api.github.com/repos/Mojang/LegacyLauncher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mojang/LegacyLauncher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mojang/LegacyLauncher/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mojang/LegacyLauncher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mojang/LegacyLauncher/statuses/{sha}","languages_url":"https://api.github.com/repos/Mojang/LegacyLauncher/languages","stargazers_url":"https://api.github.com/repos/Mojang/LegacyLauncher/stargazers","contributors_url":"https://api.github.com/repos/Mojang/LegacyLauncher/contributors","subscribers_url":"https://api.github.com/repos/Mojang/LegacyLauncher/subscribers","subscription_url":"https://api.github.com/repos/Mojang/LegacyLauncher/subscription","commits_url":"https://api.github.com/repos/Mojang/LegacyLauncher/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mojang/LegacyLauncher/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mojang/LegacyLauncher/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mojang/LegacyLauncher/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mojang/LegacyLauncher/contents/{+path}","compare_url":"https://api.github.com/repos/Mojang/LegacyLauncher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mojang/LegacyLauncher/merges","archive_url":"https://api.github.com/repos/Mojang/LegacyLauncher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mojang/LegacyLauncher/downloads","issues_url":"https://api.github.com/repos/Mojang/LegacyLauncher/issues{/number}","pulls_url":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls{/number}","milestones_url":"https://api.github.com/repos/Mojang/LegacyLauncher/milestones{/number}","notifications_url":"https://api.github.com/repos/Mojang/LegacyLauncher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mojang/LegacyLauncher/labels{/name}","releases_url":"https://api.github.com/repos/Mojang/LegacyLauncher/releases{/id}","deployments_url":"https://api.github.com/repos/Mojang/LegacyLauncher/deployments","created_at":"2013-04-24T16:58:46Z","updated_at":"2016-07-10T11:12:19Z","pushed_at":"2016-09-02T00:56:27Z","git_url":"git://github.com/Mojang/LegacyLauncher.git","ssh_url":"git@github.com:Mojang/LegacyLauncher.git","clone_url":"https://github.com/Mojang/LegacyLauncher.git","svn_url":"https://github.com/Mojang/LegacyLauncher","homepage":null,"size":553,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":2,"forks":27,"open_issues":2,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/13"},"html":{"href":"https://github.com/Mojang/LegacyLauncher/pull/13"},"issue":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/issues/13"},"comments":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Mojang/LegacyLauncher/statuses/8d76423c804f9218fbce526ae854faa1777ee508"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":9,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"LexManos"}}