{"action":"created","issue":{"url":"https://api.github.com/repos/gambitproject/jsgte/issues/91","repository_url":"https://api.github.com/repos/gambitproject/jsgte","labels_url":"https://api.github.com/repos/gambitproject/jsgte/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/gambitproject/jsgte/issues/91/comments","events_url":"https://api.github.com/repos/gambitproject/jsgte/issues/91/events","html_url":"https://github.com/gambitproject/jsgte/pull/91","id":154970690,"number":91,"title":"First try of payoff drawings","user":{"login":"amelieH","id":17950822,"avatar_url":"https://avatars.githubusercontent.com/u/17950822?v=3","gravatar_id":"","url":"https://api.github.com/users/amelieH","html_url":"https://github.com/amelieH","followers_url":"https://api.github.com/users/amelieH/followers","following_url":"https://api.github.com/users/amelieH/following{/other_user}","gists_url":"https://api.github.com/users/amelieH/gists{/gist_id}","starred_url":"https://api.github.com/users/amelieH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amelieH/subscriptions","organizations_url":"https://api.github.com/users/amelieH/orgs","repos_url":"https://api.github.com/users/amelieH/repos","events_url":"https://api.github.com/users/amelieH/events{/privacy}","received_events_url":"https://api.github.com/users/amelieH/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-16T06:43:54Z","updated_at":"2016-05-18T21:31:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gambitproject/jsgte/pulls/91","html_url":"https://github.com/gambitproject/jsgte/pull/91","diff_url":"https://github.com/gambitproject/jsgte/pull/91.diff","patch_url":"https://github.com/gambitproject/jsgte/pull/91.patch"},"body":"This is a first try for payoff drawings, with no unnecessary files.\r\nThey are interactive.\r\nI will also include labels, and clean the code a bit."},"comment":{"url":"https://api.github.com/repos/gambitproject/jsgte/issues/comments/220164442","html_url":"https://github.com/gambitproject/jsgte/pull/91#issuecomment-220164442","issue_url":"https://api.github.com/repos/gambitproject/jsgte/issues/91","id":220164442,"user":{"login":"stengel","id":798638,"avatar_url":"https://avatars.githubusercontent.com/u/798638?v=3","gravatar_id":"","url":"https://api.github.com/users/stengel","html_url":"https://github.com/stengel","followers_url":"https://api.github.com/users/stengel/followers","following_url":"https://api.github.com/users/stengel/following{/other_user}","gists_url":"https://api.github.com/users/stengel/gists{/gist_id}","starred_url":"https://api.github.com/users/stengel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stengel/subscriptions","organizations_url":"https://api.github.com/users/stengel/orgs","repos_url":"https://api.github.com/users/stengel/repos","events_url":"https://api.github.com/users/stengel/events{/privacy}","received_events_url":"https://api.github.com/users/stengel/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T21:31:16Z","updated_at":"2016-05-18T21:31:16Z","body":"Hi Amelie,\n\nI looked at jsgte/html/2by2.html and\nit looks already very nice!\n\nI like in particular the fonts.\n\nAs Rahul pointed out, if you draw a payoff that goes beyond \nthe top end of the diagram (and you can even drag it there),\nthen the shaded area is defined differently and creates this\neffect; the same happens if you go too low (see also\nattached diagram). I think a simple remedy is to not allow\npayoffs larger than the current top end, or smaller than the\ncurrent bottome end.\n\nAnother bug I noticed: you can change a payoff in the table\nand it changes the position in the diagram, but the position\nwhere it listens to it is still the previous endpoint, so\nyou cannot move it unless you point the mouse to the\nprevious endpoint! Should be easy to fix.\n\nNow, with canvas, it should be really easy to SNAP to an\ninteger point: Move it continuously, but when you release\nthe mouse, round it to the nearest integer, and take that as\nthe new endpoint. You do not need a \"snap\" function in JS\nfor that.\n\nFinally, another request: If you point the mouse at the\nline, can you make it so the entire line (with the same\nfixed slope) moves up and down, i.e. move endpoints? I think\nthat would be really cool.\n\nExcellent progress already for the initial \"community\nbonding\" period! \n\nThis is not using three.js I think, correct? \n\nRegards,\n--Bernhard \n\n* amelieH <notifications@github.com> [15-05-2016 23:43:54 -0700]:\n\n> This is a first try for payoff drawings, with no unnecessary files.\n> They are interactive.\n> I will also include labels, and clean the code a bit.\n> You can view, comment on, or merge this pull request online at:\n> \n>   https://github.com/gambitproject/jsgte/pull/91\n> \n> -- Commit Summary --\n> \n>   * trying with three.js\n>   * trying with three.js\n>   * first drawing with three.js\n>   * 2 lines with three.js\n>   * keep three.js in an other file to work mostly on JS\n>   * 2by2 only with JS. Still have to make points draggable\n>   * 2 interactive drawings, a lot of cleanning code to do\n>   * Merge branch '2by2_exp'\n>   * untrack a few files\n> \n> -- File Changes --\n> \n>     M html/2by2.html (411)\n>     M html/css/2by2.css (5)\n> \n> -- Patch Links --\n> \n> https://github.com/gambitproject/jsgte/pull/91.patch\n> https://github.com/gambitproject/jsgte/pull/91.diff\n> \n> ---\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/gambitproject/jsgte/pull/91\n\n-- \nProf Bernhard von Stengel         email: stengel@nash.lse.ac.uk\nDepartment of Mathematics         http://www.maths.lse.ac.uk/Personal/stengel\nLondon School of Economics        phone: +44-20-7955 6438  (office)\nHoughton St, Room COL 4.12               +44-20-7226 2325  (home)\nLondon WC2A 2AE, United Kingdom\n"}}