{"action":"created","issue":{"url":"https://api.github.com/repos/curl/curl/issues/845","repository_url":"https://api.github.com/repos/curl/curl","labels_url":"https://api.github.com/repos/curl/curl/issues/845/labels{/name}","comments_url":"https://api.github.com/repos/curl/curl/issues/845/comments","events_url":"https://api.github.com/repos/curl/curl/issues/845/events","html_url":"https://github.com/curl/curl/issues/845","id":157748000,"number":845,"title":"Unify GetVersionEx calls in libcurl","user":{"login":"bagder","id":177011,"avatar_url":"https://avatars.githubusercontent.com/u/177011?v=3","gravatar_id":"","url":"https://api.github.com/users/bagder","html_url":"https://github.com/bagder","followers_url":"https://api.github.com/users/bagder/followers","following_url":"https://api.github.com/users/bagder/following{/other_user}","gists_url":"https://api.github.com/users/bagder/gists{/gist_id}","starred_url":"https://api.github.com/users/bagder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bagder/subscriptions","organizations_url":"https://api.github.com/users/bagder/orgs","repos_url":"https://api.github.com/users/bagder/repos","events_url":"https://api.github.com/users/bagder/events{/privacy}","received_events_url":"https://api.github.com/users/bagder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-31T19:14:16Z","updated_at":"2016-06-04T20:29:30Z","closed_at":"2016-06-04T20:27:28Z","body":"We currently call GetVersionEx() in three places in the library and we're now discussing adding a fourth (in #840). The function call is used to figure out which Windows version libcurl runs on, and takes decisions based on that.\r\n\r\nI think we should consider making it so we call GetVersionEx() exactly once (in the global init perhaps) and we assign booleans for the uses we have \"has alpn\" (for #840), \"needs sndbuf\" (see Curl_sndbufset in connect.c), \"has security.dll\" (for curl_sspi.c) etc.\r\n\r\nThoughts @jay, @captain-caveman2k, @mback2k ?"},"comment":{"url":"https://api.github.com/repos/curl/curl/issues/comments/223776604","html_url":"https://github.com/curl/curl/issues/845#issuecomment-223776604","issue_url":"https://api.github.com/repos/curl/curl/issues/845","id":223776604,"user":{"login":"captain-caveman2k","id":1523871,"avatar_url":"https://avatars.githubusercontent.com/u/1523871?v=3","gravatar_id":"","url":"https://api.github.com/users/captain-caveman2k","html_url":"https://github.com/captain-caveman2k","followers_url":"https://api.github.com/users/captain-caveman2k/followers","following_url":"https://api.github.com/users/captain-caveman2k/following{/other_user}","gists_url":"https://api.github.com/users/captain-caveman2k/gists{/gist_id}","starred_url":"https://api.github.com/users/captain-caveman2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captain-caveman2k/subscriptions","organizations_url":"https://api.github.com/users/captain-caveman2k/orgs","repos_url":"https://api.github.com/users/captain-caveman2k/repos","events_url":"https://api.github.com/users/captain-caveman2k/events{/privacy}","received_events_url":"https://api.github.com/users/captain-caveman2k/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T20:29:30Z","updated_at":"2016-06-04T20:29:30Z","body":"Curl_verify_windows_version() added - comments and suggestions welcome."}}
{"actor":{"display_login":"captain-caveman2k"}}