{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/33","id":67072212,"html_url":"https://github.com/Blanket-Warriors/BentoTime/pull/33","diff_url":"https://github.com/Blanket-Warriors/BentoTime/pull/33.diff","patch_url":"https://github.com/Blanket-Warriors/BentoTime/pull/33.patch","issue_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues/33","number":33,"state":"closed","locked":false,"title":"Removes RxJS from BentoTime","user":{"login":"ivebencrazy","id":8182843,"avatar_url":"https://avatars.githubusercontent.com/u/8182843?v=3","gravatar_id":"","url":"https://api.github.com/users/ivebencrazy","html_url":"https://github.com/ivebencrazy","followers_url":"https://api.github.com/users/ivebencrazy/followers","following_url":"https://api.github.com/users/ivebencrazy/following{/other_user}","gists_url":"https://api.github.com/users/ivebencrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/ivebencrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivebencrazy/subscriptions","organizations_url":"https://api.github.com/users/ivebencrazy/orgs","repos_url":"https://api.github.com/users/ivebencrazy/repos","events_url":"https://api.github.com/users/ivebencrazy/events{/privacy}","received_events_url":"https://api.github.com/users/ivebencrazy/received_events","type":"User","site_admin":false},"body":"# Background\r\n\r\nThis PR removes RxJS from BentoTime. RxJS was adding another layer of complexity, taking away from the ability for people to use BentoTime as a way to learn newer ES Features, React, Redux, Webpack, and Electron. There's already a lot of complexity, and this was just raising the bar of entry. Also, this isn't a project where observables are used to their full potential anyway, since all we are doing is simple web requests that don't need to be cancelled. There's simply not a lot of reason to take on that extra bulk from Rx.\r\n\r\n# Changes\r\n\r\n- [x] Removes RxJS from BentoTime\r\n- [x] Adjusts tests and documentation to match\r\n- [x] Some tidying and dependency updating\r\n\r\n# Reviewers\r\n\r\n@aj-adams @ddrabik @mistermjtek \r\n","created_at":"2016-04-19T19:06:28Z","updated_at":"2016-04-21T16:16:28Z","closed_at":"2016-04-21T16:16:28Z","merged_at":"2016-04-21T16:16:28Z","merge_commit_sha":"aa98f78da10ea011ed1e44e1df0e746fe07df336","assignee":null,"milestone":{"url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/milestones/1","html_url":"https://github.com/Blanket-Warriors/BentoTime/milestones/Version%201.0","labels_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/milestones/1/labels","id":1592184,"number":1,"title":"Version 1.0","description":"# Pre 1.0: Function as a basic Manga reading site\r\n- One source (http://www.mangaeden.com/api/).\r\n- Organize data with Redux\r\n- Routing with React-Router\r\n- Be able to navigate through views\r\n  - List -> Book -> Page\r\n  - Page -> Book -> List\r\n  - Page -> Page -> Page -> Next Chapter First Page OR EOF\r\nList\r\n  - Call API only once per session\r\n  - Be able to filter results\r\nBook\r\n  - Call API only once per session\r\n  - Manga information, and chapter list\r\n  - Page\r\n  - Should be able to go to page by number\r\n","creator":{"login":"ivebencrazy","id":8182843,"avatar_url":"https://avatars.githubusercontent.com/u/8182843?v=3","gravatar_id":"","url":"https://api.github.com/users/ivebencrazy","html_url":"https://github.com/ivebencrazy","followers_url":"https://api.github.com/users/ivebencrazy/followers","following_url":"https://api.github.com/users/ivebencrazy/following{/other_user}","gists_url":"https://api.github.com/users/ivebencrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/ivebencrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivebencrazy/subscriptions","organizations_url":"https://api.github.com/users/ivebencrazy/orgs","repos_url":"https://api.github.com/users/ivebencrazy/repos","events_url":"https://api.github.com/users/ivebencrazy/events{/privacy}","received_events_url":"https://api.github.com/users/ivebencrazy/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":13,"state":"open","created_at":"2016-02-19T03:50:59Z","updated_at":"2016-04-21T16:16:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues/33/comments","statuses_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/statuses/2729da8c8808f6368d2db5c2aded2c1d14611eee","head":{"label":"ivebencrazy:master","ref":"master","sha":"2729da8c8808f6368d2db5c2aded2c1d14611eee","user":{"login":"ivebencrazy","id":8182843,"avatar_url":"https://avatars.githubusercontent.com/u/8182843?v=3","gravatar_id":"","url":"https://api.github.com/users/ivebencrazy","html_url":"https://github.com/ivebencrazy","followers_url":"https://api.github.com/users/ivebencrazy/followers","following_url":"https://api.github.com/users/ivebencrazy/following{/other_user}","gists_url":"https://api.github.com/users/ivebencrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/ivebencrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivebencrazy/subscriptions","organizations_url":"https://api.github.com/users/ivebencrazy/orgs","repos_url":"https://api.github.com/users/ivebencrazy/repos","events_url":"https://api.github.com/users/ivebencrazy/events{/privacy}","received_events_url":"https://api.github.com/users/ivebencrazy/received_events","type":"User","site_admin":false},"repo":{"id":43776682,"name":"BentoTime","full_name":"ivebencrazy/BentoTime","owner":{"login":"ivebencrazy","id":8182843,"avatar_url":"https://avatars.githubusercontent.com/u/8182843?v=3","gravatar_id":"","url":"https://api.github.com/users/ivebencrazy","html_url":"https://github.com/ivebencrazy","followers_url":"https://api.github.com/users/ivebencrazy/followers","following_url":"https://api.github.com/users/ivebencrazy/following{/other_user}","gists_url":"https://api.github.com/users/ivebencrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/ivebencrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivebencrazy/subscriptions","organizations_url":"https://api.github.com/users/ivebencrazy/orgs","repos_url":"https://api.github.com/users/ivebencrazy/repos","events_url":"https://api.github.com/users/ivebencrazy/events{/privacy}","received_events_url":"https://api.github.com/users/ivebencrazy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivebencrazy/BentoTime","description":"A native pc/mac/linux app for reading and saving manga.","fork":true,"url":"https://api.github.com/repos/ivebencrazy/BentoTime","forks_url":"https://api.github.com/repos/ivebencrazy/BentoTime/forks","keys_url":"https://api.github.com/repos/ivebencrazy/BentoTime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivebencrazy/BentoTime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivebencrazy/BentoTime/teams","hooks_url":"https://api.github.com/repos/ivebencrazy/BentoTime/hooks","issue_events_url":"https://api.github.com/repos/ivebencrazy/BentoTime/issues/events{/number}","events_url":"https://api.github.com/repos/ivebencrazy/BentoTime/events","assignees_url":"https://api.github.com/repos/ivebencrazy/BentoTime/assignees{/user}","branches_url":"https://api.github.com/repos/ivebencrazy/BentoTime/branches{/branch}","tags_url":"https://api.github.com/repos/ivebencrazy/BentoTime/tags","blobs_url":"https://api.github.com/repos/ivebencrazy/BentoTime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivebencrazy/BentoTime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivebencrazy/BentoTime/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivebencrazy/BentoTime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivebencrazy/BentoTime/statuses/{sha}","languages_url":"https://api.github.com/repos/ivebencrazy/BentoTime/languages","stargazers_url":"https://api.github.com/repos/ivebencrazy/BentoTime/stargazers","contributors_url":"https://api.github.com/repos/ivebencrazy/BentoTime/contributors","subscribers_url":"https://api.github.com/repos/ivebencrazy/BentoTime/subscribers","subscription_url":"https://api.github.com/repos/ivebencrazy/BentoTime/subscription","commits_url":"https://api.github.com/repos/ivebencrazy/BentoTime/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivebencrazy/BentoTime/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivebencrazy/BentoTime/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivebencrazy/BentoTime/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivebencrazy/BentoTime/contents/{+path}","compare_url":"https://api.github.com/repos/ivebencrazy/BentoTime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivebencrazy/BentoTime/merges","archive_url":"https://api.github.com/repos/ivebencrazy/BentoTime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivebencrazy/BentoTime/downloads","issues_url":"https://api.github.com/repos/ivebencrazy/BentoTime/issues{/number}","pulls_url":"https://api.github.com/repos/ivebencrazy/BentoTime/pulls{/number}","milestones_url":"https://api.github.com/repos/ivebencrazy/BentoTime/milestones{/number}","notifications_url":"https://api.github.com/repos/ivebencrazy/BentoTime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivebencrazy/BentoTime/labels{/name}","releases_url":"https://api.github.com/repos/ivebencrazy/BentoTime/releases{/id}","deployments_url":"https://api.github.com/repos/ivebencrazy/BentoTime/deployments","created_at":"2015-10-06T20:29:52Z","updated_at":"2016-01-13T06:27:30Z","pushed_at":"2016-04-19T19:02:15Z","git_url":"git://github.com/ivebencrazy/BentoTime.git","ssh_url":"git@github.com:ivebencrazy/BentoTime.git","clone_url":"https://github.com/ivebencrazy/BentoTime.git","svn_url":"https://github.com/ivebencrazy/BentoTime","homepage":null,"size":1741,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Blanket-Warriors:master","ref":"master","sha":"4fb6edd131205eef3ac84914f31dc1a6c1c951c0","user":{"login":"Blanket-Warriors","id":11801386,"avatar_url":"https://avatars.githubusercontent.com/u/11801386?v=3","gravatar_id":"","url":"https://api.github.com/users/Blanket-Warriors","html_url":"https://github.com/Blanket-Warriors","followers_url":"https://api.github.com/users/Blanket-Warriors/followers","following_url":"https://api.github.com/users/Blanket-Warriors/following{/other_user}","gists_url":"https://api.github.com/users/Blanket-Warriors/gists{/gist_id}","starred_url":"https://api.github.com/users/Blanket-Warriors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blanket-Warriors/subscriptions","organizations_url":"https://api.github.com/users/Blanket-Warriors/orgs","repos_url":"https://api.github.com/users/Blanket-Warriors/repos","events_url":"https://api.github.com/users/Blanket-Warriors/events{/privacy}","received_events_url":"https://api.github.com/users/Blanket-Warriors/received_events","type":"Organization","site_admin":false},"repo":{"id":43625276,"name":"BentoTime","full_name":"Blanket-Warriors/BentoTime","owner":{"login":"Blanket-Warriors","id":11801386,"avatar_url":"https://avatars.githubusercontent.com/u/11801386?v=3","gravatar_id":"","url":"https://api.github.com/users/Blanket-Warriors","html_url":"https://github.com/Blanket-Warriors","followers_url":"https://api.github.com/users/Blanket-Warriors/followers","following_url":"https://api.github.com/users/Blanket-Warriors/following{/other_user}","gists_url":"https://api.github.com/users/Blanket-Warriors/gists{/gist_id}","starred_url":"https://api.github.com/users/Blanket-Warriors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blanket-Warriors/subscriptions","organizations_url":"https://api.github.com/users/Blanket-Warriors/orgs","repos_url":"https://api.github.com/users/Blanket-Warriors/repos","events_url":"https://api.github.com/users/Blanket-Warriors/events{/privacy}","received_events_url":"https://api.github.com/users/Blanket-Warriors/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blanket-Warriors/BentoTime","description":"A native pc/mac/linux app for reading and saving manga.","fork":false,"url":"https://api.github.com/repos/Blanket-Warriors/BentoTime","forks_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/forks","keys_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/teams","hooks_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/hooks","issue_events_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues/events{/number}","events_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/events","assignees_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/assignees{/user}","branches_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/branches{/branch}","tags_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/tags","blobs_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/statuses/{sha}","languages_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/languages","stargazers_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/stargazers","contributors_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/contributors","subscribers_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/subscribers","subscription_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/subscription","commits_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/contents/{+path}","compare_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/merges","archive_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/downloads","issues_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues{/number}","pulls_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls{/number}","milestones_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/milestones{/number}","notifications_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/labels{/name}","releases_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/releases{/id}","deployments_url":"https://api.github.com/repos/Blanket-Warriors/BentoTime/deployments","created_at":"2015-10-04T04:43:10Z","updated_at":"2016-02-19T06:57:40Z","pushed_at":"2016-04-21T16:16:28Z","git_url":"git://github.com/Blanket-Warriors/BentoTime.git","ssh_url":"git@github.com:Blanket-Warriors/BentoTime.git","clone_url":"https://github.com/Blanket-Warriors/BentoTime.git","svn_url":"https://github.com/Blanket-Warriors/BentoTime","homepage":null,"size":1767,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/33"},"html":{"href":"https://github.com/Blanket-Warriors/BentoTime/pull/33"},"issue":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues/33"},"comments":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Blanket-Warriors/BentoTime/statuses/2729da8c8808f6368d2db5c2aded2c1d14611eee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ivebencrazy","id":8182843,"avatar_url":"https://avatars.githubusercontent.com/u/8182843?v=3","gravatar_id":"","url":"https://api.github.com/users/ivebencrazy","html_url":"https://github.com/ivebencrazy","followers_url":"https://api.github.com/users/ivebencrazy/followers","following_url":"https://api.github.com/users/ivebencrazy/following{/other_user}","gists_url":"https://api.github.com/users/ivebencrazy/gists{/gist_id}","starred_url":"https://api.github.com/users/ivebencrazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivebencrazy/subscriptions","organizations_url":"https://api.github.com/users/ivebencrazy/orgs","repos_url":"https://api.github.com/users/ivebencrazy/repos","events_url":"https://api.github.com/users/ivebencrazy/events{/privacy}","received_events_url":"https://api.github.com/users/ivebencrazy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":85,"deletions":112,"changed_files":14}}