{"action":"created","comment":{"url":"https://api.github.com/repos/OData/odata.net/pulls/comments/84852746","pull_request_review_id":5602660,"id":84852746,"diff_hunk":"@@ -982,6 +982,9 @@ internal static class XmlConstants\n         /// <summary>edm string primitive type name</summary>\r\n         internal const string EdmDateTimeOffsetTypeName = \"Edm.DateTimeOffset\";\r\n \r\n+        /// <summary>edm string primitive type name</summary>\r\n+        internal const string EdmDateTimeTypeName = \"Edm.DateTime\";\r","path":"src/Microsoft.OData.Client/XmlConstants.cs","position":5,"original_position":5,"commit_id":"23bb3974a8a20cda8f0e05fb57396269dcdf048b","original_commit_id":"23bb3974a8a20cda8f0e05fb57396269dcdf048b","user":{"login":"LaylaLiu","id":6811112,"avatar_url":"https://avatars.githubusercontent.com/u/6811112?v=3","gravatar_id":"","url":"https://api.github.com/users/LaylaLiu","html_url":"https://github.com/LaylaLiu","followers_url":"https://api.github.com/users/LaylaLiu/followers","following_url":"https://api.github.com/users/LaylaLiu/following{/other_user}","gists_url":"https://api.github.com/users/LaylaLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/LaylaLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaylaLiu/subscriptions","organizations_url":"https://api.github.com/users/LaylaLiu/orgs","repos_url":"https://api.github.com/users/LaylaLiu/repos","events_url":"https://api.github.com/users/LaylaLiu/events{/privacy}","received_events_url":"https://api.github.com/users/LaylaLiu/received_events","type":"User","site_admin":false},"body":"OData V4 removed Edm.DateTime from the spec. So this is actually not a built-in primitive type. And this type will never  show in CSDL file. So I think it is better to change both the variable name and the constant string. Please also update the comment.","created_at":"2016-10-25T08:28:43Z","updated_at":"2016-10-25T08:28:43Z","html_url":"https://github.com/OData/odata.net/pull/715#discussion_r84852746","pull_request_url":"https://api.github.com/repos/OData/odata.net/pulls/715","_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments/84852746"},"html":{"href":"https://github.com/OData/odata.net/pull/715#discussion_r84852746"},"pull_request":{"href":"https://api.github.com/repos/OData/odata.net/pulls/715"}}},"pull_request":{"url":"https://api.github.com/repos/OData/odata.net/pulls/715","id":89437140,"html_url":"https://github.com/OData/odata.net/pull/715","diff_url":"https://github.com/OData/odata.net/pull/715.diff","patch_url":"https://github.com/OData/odata.net/pull/715.patch","issue_url":"https://api.github.com/repos/OData/odata.net/issues/715","number":715,"state":"open","locked":false,"title":"DateTime Support on the Client Side Corresponding to the Server Side …","user":{"login":"jingjingrong","id":22382275,"avatar_url":"https://avatars.githubusercontent.com/u/22382275?v=3","gravatar_id":"","url":"https://api.github.com/users/jingjingrong","html_url":"https://github.com/jingjingrong","followers_url":"https://api.github.com/users/jingjingrong/followers","following_url":"https://api.github.com/users/jingjingrong/following{/other_user}","gists_url":"https://api.github.com/users/jingjingrong/gists{/gist_id}","starred_url":"https://api.github.com/users/jingjingrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingjingrong/subscriptions","organizations_url":"https://api.github.com/users/jingjingrong/orgs","repos_url":"https://api.github.com/users/jingjingrong/repos","events_url":"https://api.github.com/users/jingjingrong/events{/privacy}","received_events_url":"https://api.github.com/users/jingjingrong/received_events","type":"User","site_admin":false},"body":"### Issues\r\n*This pull request fixes issue #473.*  \r\n\r\n### Description\r\nOur team has encountered the same blocking issue when trying to upgrade from OData v3 to v4. Our existing base object already uses DateTime in production, therefore it would be a breaking change during the upgrade if there is no DateTime support. It would be great to find a workaround on the client side without changing the odata V4 protocol.\r\n\r\nfrom OData/WebApi#136 and also http://odata.github.io/WebApi/datetime-support, seems DateTime is officially supported by the OData server side while still maintain the compatibility with the OData v4 protocol, why we could not do the same for client side?\r\n\r\nIn other words, for the EDM model and over the wire, still use DateTimeOffset to be compatible with OData v4 protocol, while internally convert the DateTimeOffset from/to DateTime, to allow the actual C# object used in client side still be DateTime.\r\n\r\n### Checklist (Uncheck if it is not completed)\r\n- [ x ] Test cases added\r\n- [ x ] Build and test with one-click build and test script passed\r\n\r\n### Additional work necessary\r\n*If documentation update is needed, please add \"Docs Needed\" label to the issue and provide details about the required document change in the issue.*\r\n","created_at":"2016-10-14T19:01:27Z","updated_at":"2016-10-25T08:28:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df6c8fe21606147f01cf56a86da47072c397821c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OData/odata.net/pulls/715/commits","review_comments_url":"https://api.github.com/repos/OData/odata.net/pulls/715/comments","review_comment_url":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OData/odata.net/issues/715/comments","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/23bb3974a8a20cda8f0e05fb57396269dcdf048b","head":{"label":"jingjingrong:datetime","ref":"datetime","sha":"23bb3974a8a20cda8f0e05fb57396269dcdf048b","user":{"login":"jingjingrong","id":22382275,"avatar_url":"https://avatars.githubusercontent.com/u/22382275?v=3","gravatar_id":"","url":"https://api.github.com/users/jingjingrong","html_url":"https://github.com/jingjingrong","followers_url":"https://api.github.com/users/jingjingrong/followers","following_url":"https://api.github.com/users/jingjingrong/following{/other_user}","gists_url":"https://api.github.com/users/jingjingrong/gists{/gist_id}","starred_url":"https://api.github.com/users/jingjingrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingjingrong/subscriptions","organizations_url":"https://api.github.com/users/jingjingrong/orgs","repos_url":"https://api.github.com/users/jingjingrong/repos","events_url":"https://api.github.com/users/jingjingrong/events{/privacy}","received_events_url":"https://api.github.com/users/jingjingrong/received_events","type":"User","site_admin":false},"repo":{"id":68970152,"name":"odata.net","full_name":"jingjingrong/odata.net","owner":{"login":"jingjingrong","id":22382275,"avatar_url":"https://avatars.githubusercontent.com/u/22382275?v=3","gravatar_id":"","url":"https://api.github.com/users/jingjingrong","html_url":"https://github.com/jingjingrong","followers_url":"https://api.github.com/users/jingjingrong/followers","following_url":"https://api.github.com/users/jingjingrong/following{/other_user}","gists_url":"https://api.github.com/users/jingjingrong/gists{/gist_id}","starred_url":"https://api.github.com/users/jingjingrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingjingrong/subscriptions","organizations_url":"https://api.github.com/users/jingjingrong/orgs","repos_url":"https://api.github.com/users/jingjingrong/repos","events_url":"https://api.github.com/users/jingjingrong/events{/privacy}","received_events_url":"https://api.github.com/users/jingjingrong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jingjingrong/odata.net","description":"ODataLib: Open Data Protocol - .NET/Silverlight/WP8.1 Libraries and Frameworks","fork":true,"url":"https://api.github.com/repos/jingjingrong/odata.net","forks_url":"https://api.github.com/repos/jingjingrong/odata.net/forks","keys_url":"https://api.github.com/repos/jingjingrong/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jingjingrong/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jingjingrong/odata.net/teams","hooks_url":"https://api.github.com/repos/jingjingrong/odata.net/hooks","issue_events_url":"https://api.github.com/repos/jingjingrong/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/jingjingrong/odata.net/events","assignees_url":"https://api.github.com/repos/jingjingrong/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/jingjingrong/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/jingjingrong/odata.net/tags","blobs_url":"https://api.github.com/repos/jingjingrong/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jingjingrong/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jingjingrong/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/jingjingrong/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jingjingrong/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/jingjingrong/odata.net/languages","stargazers_url":"https://api.github.com/repos/jingjingrong/odata.net/stargazers","contributors_url":"https://api.github.com/repos/jingjingrong/odata.net/contributors","subscribers_url":"https://api.github.com/repos/jingjingrong/odata.net/subscribers","subscription_url":"https://api.github.com/repos/jingjingrong/odata.net/subscription","commits_url":"https://api.github.com/repos/jingjingrong/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/jingjingrong/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/jingjingrong/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/jingjingrong/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/jingjingrong/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/jingjingrong/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jingjingrong/odata.net/merges","archive_url":"https://api.github.com/repos/jingjingrong/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jingjingrong/odata.net/downloads","issues_url":"https://api.github.com/repos/jingjingrong/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/jingjingrong/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/jingjingrong/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/jingjingrong/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jingjingrong/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/jingjingrong/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/jingjingrong/odata.net/deployments","created_at":"2016-09-22T23:21:34Z","updated_at":"2016-09-22T23:22:04Z","pushed_at":"2016-10-14T19:00:07Z","git_url":"git://github.com/jingjingrong/odata.net.git","ssh_url":"git@github.com:jingjingrong/odata.net.git","clone_url":"https://github.com/jingjingrong/odata.net.git","svn_url":"https://github.com/jingjingrong/odata.net","homepage":"http://odata.github.io/odata.net","size":44264,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ODataV4-6.x"}},"base":{"label":"OData:ODataV4-6.x","ref":"ODataV4-6.x","sha":"5bb59c6209ea9e4dfa8d8851b20a404f0e58b54f","user":{"login":"OData","id":916520,"avatar_url":"https://avatars.githubusercontent.com/u/916520?v=3","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"repo":{"id":23308338,"name":"odata.net","full_name":"OData/odata.net","owner":{"login":"OData","id":916520,"avatar_url":"https://avatars.githubusercontent.com/u/916520?v=3","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OData/odata.net","description":"ODataLib: Open Data Protocol - .NET/Silverlight/WP8.1 Libraries and Frameworks","fork":false,"url":"https://api.github.com/repos/OData/odata.net","forks_url":"https://api.github.com/repos/OData/odata.net/forks","keys_url":"https://api.github.com/repos/OData/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OData/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OData/odata.net/teams","hooks_url":"https://api.github.com/repos/OData/odata.net/hooks","issue_events_url":"https://api.github.com/repos/OData/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/OData/odata.net/events","assignees_url":"https://api.github.com/repos/OData/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/OData/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/OData/odata.net/tags","blobs_url":"https://api.github.com/repos/OData/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OData/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OData/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/OData/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/OData/odata.net/languages","stargazers_url":"https://api.github.com/repos/OData/odata.net/stargazers","contributors_url":"https://api.github.com/repos/OData/odata.net/contributors","subscribers_url":"https://api.github.com/repos/OData/odata.net/subscribers","subscription_url":"https://api.github.com/repos/OData/odata.net/subscription","commits_url":"https://api.github.com/repos/OData/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/OData/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/OData/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/OData/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/OData/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/OData/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OData/odata.net/merges","archive_url":"https://api.github.com/repos/OData/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OData/odata.net/downloads","issues_url":"https://api.github.com/repos/OData/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/OData/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/OData/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/OData/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OData/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/OData/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/OData/odata.net/deployments","created_at":"2014-08-25T09:15:23Z","updated_at":"2016-10-18T10:07:41Z","pushed_at":"2016-10-14T19:01:27Z","git_url":"git://github.com/OData/odata.net.git","ssh_url":"git@github.com:OData/odata.net.git","clone_url":"https://github.com/OData/odata.net.git","svn_url":"https://github.com/OData/odata.net","homepage":"http://odata.github.io/odata.net","size":45813,"stargazers_count":195,"watchers_count":195,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":122,"mirror_url":null,"open_issues_count":273,"forks":122,"open_issues":273,"watchers":195,"default_branch":"ODataV4-6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/715"},"html":{"href":"https://github.com/OData/odata.net/pull/715"},"issue":{"href":"https://api.github.com/repos/OData/odata.net/issues/715"},"comments":{"href":"https://api.github.com/repos/OData/odata.net/issues/715/comments"},"review_comments":{"href":"https://api.github.com/repos/OData/odata.net/pulls/715/comments"},"review_comment":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OData/odata.net/pulls/715/commits"},"statuses":{"href":"https://api.github.com/repos/OData/odata.net/statuses/23bb3974a8a20cda8f0e05fb57396269dcdf048b"}}}}
{"actor":{"display_login":"LaylaLiu"}}