{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/watchman/pulls/comments/86009625","pull_request_review_id":6687803,"id":86009625,"diff_hunk":"@@ -136,7 +136,8 @@ TEST_DIR_SRCS_CPP=\\\n \ttests\\ht_test.cpp \\\n \ttests\\ignore_test.cpp \\\n \ttests\\log_stub.cpp \\\n-\ttests\\log.cpp\n+\ttests\\log.cpp \\\n+\ttests\\string.cpp\n \n OBJS=$(SRCS_CPP:.cpp=.obj) $(SRCS_C:.c=.obj)\n TEST_OBJS=$(TEST_SRCS_CPP:.cpp=.obj) $(TEST_SRCS_C:.c=.obj)","path":"winbuild/Makefile","position":9,"original_position":9,"commit_id":"404b5f01850549431f62b1b3d529357519e494d7","original_commit_id":"404b5f01850549431f62b1b3d529357519e494d7","user":{"login":"wez","id":117777,"avatar_url":"https://avatars.githubusercontent.com/u/117777?v=3","gravatar_id":"","url":"https://api.github.com/users/wez","html_url":"https://github.com/wez","followers_url":"https://api.github.com/users/wez/followers","following_url":"https://api.github.com/users/wez/following{/other_user}","gists_url":"https://api.github.com/users/wez/gists{/gist_id}","starred_url":"https://api.github.com/users/wez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wez/subscriptions","organizations_url":"https://api.github.com/users/wez/orgs","repos_url":"https://api.github.com/users/wez/repos","events_url":"https://api.github.com/users/wez/events{/privacy}","received_events_url":"https://api.github.com/users/wez/received_events","type":"User","site_admin":false},"body":"github won't let me comment on precisely the correct line, but you'll need to add `tests\\string.exe` to the list of `TESTS=` that is a couple of lines below this in order for the windows build to build and run your new test","created_at":"2016-11-01T19:51:40Z","updated_at":"2016-11-01T19:56:45Z","html_url":"https://github.com/facebook/watchman/pull/380#discussion_r86009625","pull_request_url":"https://api.github.com/repos/facebook/watchman/pulls/380","_links":{"self":{"href":"https://api.github.com/repos/facebook/watchman/pulls/comments/86009625"},"html":{"href":"https://github.com/facebook/watchman/pull/380#discussion_r86009625"},"pull_request":{"href":"https://api.github.com/repos/facebook/watchman/pulls/380"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/watchman/pulls/380","id":91514522,"html_url":"https://github.com/facebook/watchman/pull/380","diff_url":"https://github.com/facebook/watchman/pull/380.diff","patch_url":"https://github.com/facebook/watchman/pull/380.patch","issue_url":"https://api.github.com/repos/facebook/watchman/issues/380","number":380,"state":"open","locked":false,"title":"w_string_suffix return NULL if ends with '.'","user":{"login":"kaitian521","id":1303341,"avatar_url":"https://avatars.githubusercontent.com/u/1303341?v=3","gravatar_id":"","url":"https://api.github.com/users/kaitian521","html_url":"https://github.com/kaitian521","followers_url":"https://api.github.com/users/kaitian521/followers","following_url":"https://api.github.com/users/kaitian521/following{/other_user}","gists_url":"https://api.github.com/users/kaitian521/gists{/gist_id}","starred_url":"https://api.github.com/users/kaitian521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaitian521/subscriptions","organizations_url":"https://api.github.com/users/kaitian521/orgs","repos_url":"https://api.github.com/users/kaitian521/repos","events_url":"https://api.github.com/users/kaitian521/events{/privacy}","received_events_url":"https://api.github.com/users/kaitian521/received_events","type":"User","site_admin":false},"body":"1. if a string ends with a '.', absolutely it dose not have suffix\r\n2. `str->len - end >= sizeof(name_buf)` is more readable and comprehensible\r\n3. add unit test for w_string_suffix.","created_at":"2016-10-30T08:09:22Z","updated_at":"2016-11-01T19:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab7d4a3dac44001055941e1291f35c2e75ee7d85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/watchman/pulls/380/commits","review_comments_url":"https://api.github.com/repos/facebook/watchman/pulls/380/comments","review_comment_url":"https://api.github.com/repos/facebook/watchman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/watchman/issues/380/comments","statuses_url":"https://api.github.com/repos/facebook/watchman/statuses/404b5f01850549431f62b1b3d529357519e494d7","head":{"label":"kaitian521:master","ref":"master","sha":"404b5f01850549431f62b1b3d529357519e494d7","user":{"login":"kaitian521","id":1303341,"avatar_url":"https://avatars.githubusercontent.com/u/1303341?v=3","gravatar_id":"","url":"https://api.github.com/users/kaitian521","html_url":"https://github.com/kaitian521","followers_url":"https://api.github.com/users/kaitian521/followers","following_url":"https://api.github.com/users/kaitian521/following{/other_user}","gists_url":"https://api.github.com/users/kaitian521/gists{/gist_id}","starred_url":"https://api.github.com/users/kaitian521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaitian521/subscriptions","organizations_url":"https://api.github.com/users/kaitian521/orgs","repos_url":"https://api.github.com/users/kaitian521/repos","events_url":"https://api.github.com/users/kaitian521/events{/privacy}","received_events_url":"https://api.github.com/users/kaitian521/received_events","type":"User","site_admin":false},"repo":{"id":72175678,"name":"watchman","full_name":"kaitian521/watchman","owner":{"login":"kaitian521","id":1303341,"avatar_url":"https://avatars.githubusercontent.com/u/1303341?v=3","gravatar_id":"","url":"https://api.github.com/users/kaitian521","html_url":"https://github.com/kaitian521","followers_url":"https://api.github.com/users/kaitian521/followers","following_url":"https://api.github.com/users/kaitian521/following{/other_user}","gists_url":"https://api.github.com/users/kaitian521/gists{/gist_id}","starred_url":"https://api.github.com/users/kaitian521/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaitian521/subscriptions","organizations_url":"https://api.github.com/users/kaitian521/orgs","repos_url":"https://api.github.com/users/kaitian521/repos","events_url":"https://api.github.com/users/kaitian521/events{/privacy}","received_events_url":"https://api.github.com/users/kaitian521/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaitian521/watchman","description":"Watches files and records, or triggers actions, when they change. ","fork":true,"url":"https://api.github.com/repos/kaitian521/watchman","forks_url":"https://api.github.com/repos/kaitian521/watchman/forks","keys_url":"https://api.github.com/repos/kaitian521/watchman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaitian521/watchman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaitian521/watchman/teams","hooks_url":"https://api.github.com/repos/kaitian521/watchman/hooks","issue_events_url":"https://api.github.com/repos/kaitian521/watchman/issues/events{/number}","events_url":"https://api.github.com/repos/kaitian521/watchman/events","assignees_url":"https://api.github.com/repos/kaitian521/watchman/assignees{/user}","branches_url":"https://api.github.com/repos/kaitian521/watchman/branches{/branch}","tags_url":"https://api.github.com/repos/kaitian521/watchman/tags","blobs_url":"https://api.github.com/repos/kaitian521/watchman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaitian521/watchman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaitian521/watchman/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaitian521/watchman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaitian521/watchman/statuses/{sha}","languages_url":"https://api.github.com/repos/kaitian521/watchman/languages","stargazers_url":"https://api.github.com/repos/kaitian521/watchman/stargazers","contributors_url":"https://api.github.com/repos/kaitian521/watchman/contributors","subscribers_url":"https://api.github.com/repos/kaitian521/watchman/subscribers","subscription_url":"https://api.github.com/repos/kaitian521/watchman/subscription","commits_url":"https://api.github.com/repos/kaitian521/watchman/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaitian521/watchman/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaitian521/watchman/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaitian521/watchman/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaitian521/watchman/contents/{+path}","compare_url":"https://api.github.com/repos/kaitian521/watchman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaitian521/watchman/merges","archive_url":"https://api.github.com/repos/kaitian521/watchman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaitian521/watchman/downloads","issues_url":"https://api.github.com/repos/kaitian521/watchman/issues{/number}","pulls_url":"https://api.github.com/repos/kaitian521/watchman/pulls{/number}","milestones_url":"https://api.github.com/repos/kaitian521/watchman/milestones{/number}","notifications_url":"https://api.github.com/repos/kaitian521/watchman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaitian521/watchman/labels{/name}","releases_url":"https://api.github.com/repos/kaitian521/watchman/releases{/id}","deployments_url":"https://api.github.com/repos/kaitian521/watchman/deployments","created_at":"2016-10-28T05:17:00Z","updated_at":"2016-10-28T05:17:03Z","pushed_at":"2016-11-01T06:00:09Z","git_url":"git://github.com/kaitian521/watchman.git","ssh_url":"git@github.com:kaitian521/watchman.git","clone_url":"https://github.com/kaitian521/watchman.git","svn_url":"https://github.com/kaitian521/watchman","homepage":"https://facebook.github.io/watchman/","size":7443,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"fd5568248ab9d75b73b9b7f50b63f69df9158da6","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6930489,"name":"watchman","full_name":"facebook/watchman","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/watchman","description":"Watches files and records, or triggers actions, when they change. ","fork":false,"url":"https://api.github.com/repos/facebook/watchman","forks_url":"https://api.github.com/repos/facebook/watchman/forks","keys_url":"https://api.github.com/repos/facebook/watchman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/watchman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/watchman/teams","hooks_url":"https://api.github.com/repos/facebook/watchman/hooks","issue_events_url":"https://api.github.com/repos/facebook/watchman/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/watchman/events","assignees_url":"https://api.github.com/repos/facebook/watchman/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/watchman/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/watchman/tags","blobs_url":"https://api.github.com/repos/facebook/watchman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/watchman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/watchman/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/watchman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/watchman/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/watchman/languages","stargazers_url":"https://api.github.com/repos/facebook/watchman/stargazers","contributors_url":"https://api.github.com/repos/facebook/watchman/contributors","subscribers_url":"https://api.github.com/repos/facebook/watchman/subscribers","subscription_url":"https://api.github.com/repos/facebook/watchman/subscription","commits_url":"https://api.github.com/repos/facebook/watchman/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/watchman/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/watchman/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/watchman/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/watchman/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/watchman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/watchman/merges","archive_url":"https://api.github.com/repos/facebook/watchman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/watchman/downloads","issues_url":"https://api.github.com/repos/facebook/watchman/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/watchman/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/watchman/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/watchman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/watchman/labels{/name}","releases_url":"https://api.github.com/repos/facebook/watchman/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/watchman/deployments","created_at":"2012-11-29T23:35:52Z","updated_at":"2016-11-01T10:09:14Z","pushed_at":"2016-11-01T06:00:09Z","git_url":"git://github.com/facebook/watchman.git","ssh_url":"git@github.com:facebook/watchman.git","clone_url":"https://github.com/facebook/watchman.git","svn_url":"https://github.com/facebook/watchman","homepage":"https://facebook.github.io/watchman/","size":15843,"stargazers_count":4708,"watchers_count":4708,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":390,"mirror_url":null,"open_issues_count":29,"forks":390,"open_issues":29,"watchers":4708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/watchman/pulls/380"},"html":{"href":"https://github.com/facebook/watchman/pull/380"},"issue":{"href":"https://api.github.com/repos/facebook/watchman/issues/380"},"comments":{"href":"https://api.github.com/repos/facebook/watchman/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/watchman/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/watchman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/watchman/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/watchman/statuses/404b5f01850549431f62b1b3d529357519e494d7"}}}}
{"actor":{"display_login":"wez"}}