{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/49032752","id":49032752,"diff_hunk":"@@ -213,7 +213,11 @@ function showCreditCardExpiringWarning( purchase ) {\n }\n \n function showEditPaymentDetails( purchase ) {\n-\treturn ! isExpired( purchase ) && ! isOneTimePurchase( purchase ) && ! isIncludedWithPlan( purchase ) && isPaidWithCreditCard( purchase );\n+\treturn showEditPaymentDetailsOption( purchase ) && isPaidWithCreditCard( purchase );\n+}\n+\n+function showEditPaymentDetailsOption( purchase ) {","path":"client/lib/purchases/index.js","position":8,"original_position":8,"commit_id":"2ad231960204368bf8a53a44fa534dfb3932fb1d","original_commit_id":"2ad231960204368bf8a53a44fa534dfb3932fb1d","user":{"login":"drewblaisdell","id":1130674,"avatar_url":"https://avatars.githubusercontent.com/u/1130674?v=3","gravatar_id":"","url":"https://api.github.com/users/drewblaisdell","html_url":"https://github.com/drewblaisdell","followers_url":"https://api.github.com/users/drewblaisdell/followers","following_url":"https://api.github.com/users/drewblaisdell/following{/other_user}","gists_url":"https://api.github.com/users/drewblaisdell/gists{/gist_id}","starred_url":"https://api.github.com/users/drewblaisdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewblaisdell/subscriptions","organizations_url":"https://api.github.com/users/drewblaisdell/orgs","repos_url":"https://api.github.com/users/drewblaisdell/repos","events_url":"https://api.github.com/users/drewblaisdell/events{/privacy}","received_events_url":"https://api.github.com/users/drewblaisdell/received_events","type":"User","site_admin":false},"body":"I'm having trouble understanding why it is necessary to have both of these functions. Could you explain it?\r\n\r\nAlso, what do you think about moving these functions to `ManagePurchase`? Rationale:\r\n\r\n- They relate directly to presentation logic.\r\n- They're only used in that component.\r\n\r\nIt also might be nice to rename them, because they don't show anything. `canEditPaymentDetails`?","created_at":"2016-01-07T01:23:30Z","updated_at":"2016-01-07T01:23:30Z","html_url":"https://github.com/Automattic/wp-calypso/pull/2169#discussion_r49032752","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/49032752"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/2169#discussion_r49032752"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169","id":55281455,"html_url":"https://github.com/Automattic/wp-calypso/pull/2169","diff_url":"https://github.com/Automattic/wp-calypso/pull/2169.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/2169.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/2169","number":2169,"state":"open","locked":false,"title":"Purchases: Make it possible to edit payment details even if the user has no stored details","user":{"login":"scruffian","id":275961,"avatar_url":"https://avatars.githubusercontent.com/u/275961?v=3","gravatar_id":"","url":"https://api.github.com/users/scruffian","html_url":"https://github.com/scruffian","followers_url":"https://api.github.com/users/scruffian/followers","following_url":"https://api.github.com/users/scruffian/following{/other_user}","gists_url":"https://api.github.com/users/scruffian/gists{/gist_id}","starred_url":"https://api.github.com/users/scruffian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scruffian/subscriptions","organizations_url":"https://api.github.com/users/scruffian/orgs","repos_url":"https://api.github.com/users/scruffian/repos","events_url":"https://api.github.com/users/scruffian/events{/privacy}","received_events_url":"https://api.github.com/users/scruffian/received_events","type":"User","site_admin":false},"body":"Currently the option to edit payment details is only available to users who have a credit card saved for a purchase. This is an unnecessary restriction, since we can add new cards for any purchase.\r\n\r\nThis PR makes it possible users to update the CC data for any purchase that will renew and hasn't expired, and isn't included in another purchase.\r\n\r\nThere is one outstanding issue with this - when you update the information, the data isn't shown on the manage purchase screen right away - we probably need to add a placeholder state and fetch the data again.\r\n\r\nPinging @peterbutler for a sanity check.\r\n \r\n#### Testing instructions\r\n\r\nThere are several cases to test:\r\n1. The purchase is a one time purchase (e.g. a theme) --> do not show a link to edit payment details\r\n2. The purchase is has expired --> do not show a link to edit payment details\r\n3. The purchase is included in another purchase (e.g. a domain in a plan) --> do not show a link to edit payment details\r\n4. The purchase has a current valid credit card --> the link to edit payment details contains a card id and shows some information for the current card.\r\n5. The purchase was made with PayPal or has no payment data --> there is still a link to edit payment details, but there is no card id and no card info. In this case it should be asserted that updating the information saves the changes.\r\n\r\n#### Reviews\r\n\r\n- [ ] Code\r\n- [ ] Product","created_at":"2016-01-06T23:44:18Z","updated_at":"2016-01-07T01:23:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"571cda2fbc962d5a918686b4070820e290a16622","assignee":{"login":"scruffian","id":275961,"avatar_url":"https://avatars.githubusercontent.com/u/275961?v=3","gravatar_id":"","url":"https://api.github.com/users/scruffian","html_url":"https://github.com/scruffian","followers_url":"https://api.github.com/users/scruffian/followers","following_url":"https://api.github.com/users/scruffian/following{/other_user}","gists_url":"https://api.github.com/users/scruffian/gists{/gist_id}","starred_url":"https://api.github.com/users/scruffian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scruffian/subscriptions","organizations_url":"https://api.github.com/users/scruffian/orgs","repos_url":"https://api.github.com/users/scruffian/repos","events_url":"https://api.github.com/users/scruffian/events{/privacy}","received_events_url":"https://api.github.com/users/scruffian/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/16","html_url":"https://github.com/Automattic/wp-calypso/milestones/Purchases:%20v1","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/16/labels","id":1419675,"number":16,"title":"Purchases: v1","description":"","creator":{"login":"fabianapsimoes","id":1248436,"avatar_url":"https://avatars.githubusercontent.com/u/1248436?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianapsimoes","html_url":"https://github.com/fabianapsimoes","followers_url":"https://api.github.com/users/fabianapsimoes/followers","following_url":"https://api.github.com/users/fabianapsimoes/following{/other_user}","gists_url":"https://api.github.com/users/fabianapsimoes/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianapsimoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianapsimoes/subscriptions","organizations_url":"https://api.github.com/users/fabianapsimoes/orgs","repos_url":"https://api.github.com/users/fabianapsimoes/repos","events_url":"https://api.github.com/users/fabianapsimoes/events{/privacy}","received_events_url":"https://api.github.com/users/fabianapsimoes/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":68,"state":"open","created_at":"2015-11-19T11:56:01Z","updated_at":"2016-01-06T23:44:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/2169/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/2ad231960204368bf8a53a44fa534dfb3932fb1d","head":{"label":"Automattic:update/edit-payment-method","ref":"update/edit-payment-method","sha":"2ad231960204368bf8a53a44fa534dfb3932fb1d","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-01-07T01:04:39Z","pushed_at":"2016-01-07T01:22:12Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":13845,"stargazers_count":6506,"watchers_count":6506,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":719,"mirror_url":null,"open_issues_count":1042,"forks":719,"open_issues":1042,"watchers":6506,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"eed07cca4b3e42d9de679bed4cfa613743c1cdc8","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-01-07T01:04:39Z","pushed_at":"2016-01-07T01:22:12Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":13845,"stargazers_count":6506,"watchers_count":6506,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":719,"mirror_url":null,"open_issues_count":1042,"forks":719,"open_issues":1042,"watchers":6506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/2169"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/2169"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/2169/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/2169/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/2ad231960204368bf8a53a44fa534dfb3932fb1d"}}}}