{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/89791668","pull_request_review_id":10325116,"id":89791668,"diff_hunk":"@@ -53,13 +55,41 @@\n \n     @Override\n     public void onMessage(Message message) {\n-        logger.fragmentCompletionTimeReceived();\n+        logger.invocationDetailsReceived();\n         try {\n             String data = ((TextMessage) message).getText();\n-            List<CompletionTime> items = mapper.readValue(data, new TypeReference<List<CompletionTime>>() {});\n-            publisher.publish(items, \"FragmentCompletionTime\");\n+            List<NodeDetails> items = mapper.readValue(data, new TypeReference<List<NodeDetails>>() {});\n+            List<Event> events = items.stream().filter(nd -> nd.isInitial())\n+                    .map(InvocationAlertsPublisherMDB::toEvent)\n+                    .collect(Collectors.toList());\n+            if (!events.isEmpty()) {\n+                publisher.publish(events);","path":"server/processors-alerts-publisher/src/main/java/org/hawkular/apm/processor/alerts/InvocationAlertsPublisherMDB.java","position":57,"original_position":57,"commit_id":"c9f55a8946505f8b61bd3da7cd0408e7a60d04ff","original_commit_id":"c9f55a8946505f8b61bd3da7cd0408e7a60d04ff","user":{"login":"jpkrohling","id":13387,"avatar_url":"https://avatars.githubusercontent.com/u/13387?v=3","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"body":"IIRC, the `#publish(List)` iterates over the list. It was thought as mostly a helper method, but on this case, it might be best to call `#publish(Event)` individually and spare the list.","created_at":"2016-11-28T14:34:51Z","updated_at":"2016-11-28T14:41:11Z","html_url":"https://github.com/hawkular/hawkular-apm/pull/692#discussion_r89791668","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments/89791668"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/692#discussion_r89791668"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692","id":95465269,"html_url":"https://github.com/hawkular/hawkular-apm/pull/692","diff_url":"https://github.com/hawkular/hawkular-apm/pull/692.diff","patch_url":"https://github.com/hawkular/hawkular-apm/pull/692.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/692","number":692,"state":"open","locked":false,"title":"HWKAPM-745 Remove the FragmentCompletionTime event type, use NodeDeta…","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"…ils instead when building the end to end Trace, and use the 'initial' NodeDetails for creating events for the Alerts engine","created_at":"2016-11-28T09:43:35Z","updated_at":"2016-11-28T14:41:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7af982a194e71031ab8d14b87de6f44319f7fdca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/692/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/c9f55a8946505f8b61bd3da7cd0408e7a60d04ff","head":{"label":"objectiser:HWKAPM-745","ref":"HWKAPM-745","sha":"c9f55a8946505f8b61bd3da7cd0408e7a60d04ff","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"repo":{"id":34446762,"name":"hawkular-apm","full_name":"objectiser/hawkular-apm","owner":{"login":"objectiser","id":164562,"avatar_url":"https://avatars.githubusercontent.com/u/164562?v=3","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objectiser/hawkular-apm","description":"Application Performance Management for Hawkular","fork":true,"url":"https://api.github.com/repos/objectiser/hawkular-apm","forks_url":"https://api.github.com/repos/objectiser/hawkular-apm/forks","keys_url":"https://api.github.com/repos/objectiser/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectiser/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectiser/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/objectiser/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/objectiser/hawkular-apm/events","assignees_url":"https://api.github.com/repos/objectiser/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/objectiser/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectiser/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/objectiser/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/objectiser/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/objectiser/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/objectiser/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectiser/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectiser/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectiser/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/objectiser/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectiser/hawkular-apm/merges","archive_url":"https://api.github.com/repos/objectiser/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectiser/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/objectiser/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/objectiser/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/objectiser/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/objectiser/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectiser/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/objectiser/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/objectiser/hawkular-apm/deployments","created_at":"2015-04-23T09:26:55Z","updated_at":"2016-10-25T07:04:55Z","pushed_at":"2016-11-28T11:11:47Z","git_url":"git://github.com/objectiser/hawkular-apm.git","ssh_url":"git@github.com:objectiser/hawkular-apm.git","clone_url":"https://github.com/objectiser/hawkular-apm.git","svn_url":"https://github.com/objectiser/hawkular-apm","homepage":"","size":7294,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"d5ef2b7d42302eb62e7d0fe19d58e4cec9377617","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34446334,"name":"hawkular-apm","full_name":"hawkular/hawkular-apm","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-apm","description":"Distributed Tracing and Application Performance Management","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-apm","forks_url":"https://api.github.com/repos/hawkular/hawkular-apm/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-apm/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-apm/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-apm/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-apm/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-apm/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-apm/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-apm/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-apm/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-apm/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-apm/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-apm/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-apm/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-apm/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-apm/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-apm/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-apm/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-apm/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-apm/deployments","created_at":"2015-04-23T09:17:50Z","updated_at":"2016-11-28T09:08:00Z","pushed_at":"2016-11-28T13:27:07Z","git_url":"git://github.com/hawkular/hawkular-apm.git","ssh_url":"git@github.com:hawkular/hawkular-apm.git","clone_url":"https://github.com/hawkular/hawkular-apm.git","svn_url":"https://github.com/hawkular/hawkular-apm","homepage":"","size":7397,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692"},"html":{"href":"https://github.com/hawkular/hawkular-apm/pull/692"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/692"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-apm/statuses/c9f55a8946505f8b61bd3da7cd0408e7a60d04ff"}}}}
{"actor":{"display_login":"jpkrohling"}}