{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/58907770","id":58907770,"diff_hunk":"@@ -31,9 +35,12 @@\n    * e.g. splitGlob(\"/a,/b\") -> [\"/a\",\"/b\"]\n    * splitGlob(\"/a/{c,d}\") -> [\"/a/c\", \"/a/d\"]\n    */\n-  public static List<StringBuilder> splitGlob(String path)\n+  public static Iterable<String> splitGlob(String path)\n   {\n-    return splitGlob(new CharStream(path));\n+    if (path.indexOf('{') < 0) {\n+      return Arrays.asList(path.split(\",\"));\n+    }","path":"indexing-hadoop/src/main/java/io/druid/indexer/path/HadoopGlobPathSplitter.java","position":22,"original_position":22,"commit_id":"f2aac6827731f8e511364208f798d793334a92df","original_commit_id":"f2aac6827731f8e511364208f798d793334a92df","user":{"login":"himanshug","id":246308,"avatar_url":"https://avatars.githubusercontent.com/u/246308?v=3","gravatar_id":"","url":"https://api.github.com/users/himanshug","html_url":"https://github.com/himanshug","followers_url":"https://api.github.com/users/himanshug/followers","following_url":"https://api.github.com/users/himanshug/following{/other_user}","gists_url":"https://api.github.com/users/himanshug/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshug/subscriptions","organizations_url":"https://api.github.com/users/himanshug/orgs","repos_url":"https://api.github.com/users/himanshug/repos","events_url":"https://api.github.com/users/himanshug/events{/privacy}","received_events_url":"https://api.github.com/users/himanshug/received_events","type":"User","site_admin":false},"body":"why this special case handling is necessary?","created_at":"2016-04-07T17:05:56Z","updated_at":"2016-04-07T17:05:56Z","html_url":"https://github.com/druid-io/druid/pull/2802#discussion_r58907770","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/2802","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/58907770"},"html":{"href":"https://github.com/druid-io/druid/pull/2802#discussion_r58907770"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2802"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/2802","id":65572871,"html_url":"https://github.com/druid-io/druid/pull/2802","diff_url":"https://github.com/druid-io/druid/pull/2802.diff","patch_url":"https://github.com/druid-io/druid/pull/2802.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/2802","number":2802,"state":"open","locked":false,"title":"Optimize adding lots of paths to pathspec","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"body":"Fix for #2792","created_at":"2016-04-07T04:34:38Z","updated_at":"2016-04-07T17:05:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5a941f8fd335f0d90f716d1dd83274592003030","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/2802/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/2802/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/2802/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/f2aac6827731f8e511364208f798d793334a92df","head":{"label":"navis:optimize_multiplepath_concat","ref":"optimize_multiplepath_concat","sha":"f2aac6827731f8e511364208f798d793334a92df","user":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"repo":{"id":45149930,"name":"druid","full_name":"navis/druid","owner":{"login":"navis","id":809395,"avatar_url":"https://avatars.githubusercontent.com/u/809395?v=3","gravatar_id":"","url":"https://api.github.com/users/navis","html_url":"https://github.com/navis","followers_url":"https://api.github.com/users/navis/followers","following_url":"https://api.github.com/users/navis/following{/other_user}","gists_url":"https://api.github.com/users/navis/gists{/gist_id}","starred_url":"https://api.github.com/users/navis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navis/subscriptions","organizations_url":"https://api.github.com/users/navis/orgs","repos_url":"https://api.github.com/users/navis/repos","events_url":"https://api.github.com/users/navis/events{/privacy}","received_events_url":"https://api.github.com/users/navis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/navis/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/navis/druid","forks_url":"https://api.github.com/repos/navis/druid/forks","keys_url":"https://api.github.com/repos/navis/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navis/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navis/druid/teams","hooks_url":"https://api.github.com/repos/navis/druid/hooks","issue_events_url":"https://api.github.com/repos/navis/druid/issues/events{/number}","events_url":"https://api.github.com/repos/navis/druid/events","assignees_url":"https://api.github.com/repos/navis/druid/assignees{/user}","branches_url":"https://api.github.com/repos/navis/druid/branches{/branch}","tags_url":"https://api.github.com/repos/navis/druid/tags","blobs_url":"https://api.github.com/repos/navis/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navis/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navis/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/navis/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navis/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/navis/druid/languages","stargazers_url":"https://api.github.com/repos/navis/druid/stargazers","contributors_url":"https://api.github.com/repos/navis/druid/contributors","subscribers_url":"https://api.github.com/repos/navis/druid/subscribers","subscription_url":"https://api.github.com/repos/navis/druid/subscription","commits_url":"https://api.github.com/repos/navis/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/navis/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/navis/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/navis/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/navis/druid/contents/{+path}","compare_url":"https://api.github.com/repos/navis/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navis/druid/merges","archive_url":"https://api.github.com/repos/navis/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navis/druid/downloads","issues_url":"https://api.github.com/repos/navis/druid/issues{/number}","pulls_url":"https://api.github.com/repos/navis/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/navis/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/navis/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navis/druid/labels{/name}","releases_url":"https://api.github.com/repos/navis/druid/releases{/id}","deployments_url":"https://api.github.com/repos/navis/druid/deployments","created_at":"2015-10-29T00:22:35Z","updated_at":"2015-10-29T00:22:47Z","pushed_at":"2016-04-07T04:49:39Z","git_url":"git://github.com/navis/druid.git","ssh_url":"git@github.com:navis/druid.git","clone_url":"https://github.com/navis/druid.git","svn_url":"https://github.com/navis/druid","homepage":"http://druid.io","size":105525,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"f915a591380eb56eee6a9ac4a08927e883d613e2","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2016-04-07T15:38:45Z","pushed_at":"2016-04-07T15:31:58Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":128687,"stargazers_count":2975,"watchers_count":2975,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":654,"mirror_url":null,"open_issues_count":398,"forks":654,"open_issues":398,"watchers":2975,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2802"},"html":{"href":"https://github.com/druid-io/druid/pull/2802"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/2802"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/2802/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2802/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2802/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/f2aac6827731f8e511364208f798d793334a92df"}}}}