{"action":"created","comment":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/57534997","id":57534997,"diff_hunk":"@@ -355,6 +360,16 @@ def visit_Module(self, module):\n \n         # Patch module body: prepend all imported function and import nodes\n         imported = self.registry.generate_ImportList()\n+        external_modules_name = [f for f in self.module.imported_modules\n+                                 if not is_builtin_module_name(f)]\n+        if not imported and external_modules_name:\n+            # We can't raise an exception as it may just be an unused import.\n+            # FIXME : To improve this, wa have to handle aliasing so that we","path":"pythran/transformations/handle_import.py","position":53,"original_position":53,"commit_id":"e8e57629036c15cc83383fa937f748cc3200f167","original_commit_id":"e8e57629036c15cc83383fa937f748cc3200f167","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"body":"wa -> we","created_at":"2016-03-27T21:24:34Z","updated_at":"2016-03-27T21:24:34Z","html_url":"https://github.com/serge-sans-paille/pythran/pull/529#discussion_r57534997","pull_request_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529","_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/57534997"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/529#discussion_r57534997"},"pull_request":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529"}}},"pull_request":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529","id":58531712,"html_url":"https://github.com/serge-sans-paille/pythran/pull/529","diff_url":"https://github.com/serge-sans-paille/pythran/pull/529.diff","patch_url":"https://github.com/serge-sans-paille/pythran/pull/529.patch","issue_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/529","number":529,"state":"open","locked":false,"title":"Proper error message when failing to import 3rd part module","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-06T22:07:23Z","updated_at":"2016-03-27T21:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afee4b78c2588cfc7f6bc7f29488799adec5bef5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529/commits","review_comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529/comments","review_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/529/comments","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/e8e57629036c15cc83383fa937f748cc3200f167","head":{"label":"serge-sans-paille:fix/handle-import-error-message","ref":"fix/handle-import-error-message","sha":"e8e57629036c15cc83383fa937f748cc3200f167","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments{/number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","deployments_url":"https://api.github.com/repos/serge-sans-paille/pythran/deployments","created_at":"2012-05-29T08:02:14Z","updated_at":"2016-03-11T15:04:58Z","pushed_at":"2016-03-27T21:23:10Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":27018,"stargazers_count":517,"watchers_count":517,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":68,"forks":45,"open_issues":68,"watchers":517,"default_branch":"master"}},"base":{"label":"serge-sans-paille:master","ref":"master","sha":"0bdd949e5166d47846caf7039d524411211f24ca","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments{/number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","deployments_url":"https://api.github.com/repos/serge-sans-paille/pythran/deployments","created_at":"2012-05-29T08:02:14Z","updated_at":"2016-03-11T15:04:58Z","pushed_at":"2016-03-27T21:23:10Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":27018,"stargazers_count":517,"watchers_count":517,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":68,"forks":45,"open_issues":68,"watchers":517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/529"},"issue":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/529"},"comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/e8e57629036c15cc83383fa937f748cc3200f167"}}}}