{"push_id":1461551128,"size":106,"distinct_size":1,"ref":"refs/heads/spencerkimball/node-liveness-cause","head":"00f3a2cf6ba088f7046ee6b5bafdfcfa660e5464","before":"9f7a6018920145a7e3eb9e83bfb60ff62b7116e3","commits":[{"sha":"5174aaec6bdcfcd9946fac06df2c7f53219fd23c","author":{"name":"irfan sharif","email":"6459e6dfc9d5c803b5aff383fc33ced6162ac481@gmail.com"},"message":"sql: miscellaneous cleanup\n\n- Changed `checkExpr` to be a method attached to the `distSQLPlanner`\ninstead of a standalone function.\n- Mirrored \"wrap\" logic in `SelectTopNode` when adding `sorters` to\naccommodate another `planNode` to be it's \"source\".\n- Added tests to check setting of DIST_SQL session variables.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/5174aaec6bdcfcd9946fac06df2c7f53219fd23c"},{"sha":"ff80294db45b4bad49925f08e1c1a5cb931b598b","author":{"name":"marc","email":"914bb1aa8f50cbee5072379fc4374eb10cf80dcc@cockroachlabs.com"},"message":"monitoring: bare bones prometheus config and rules.\n\nThis is meant to be used in the docs and is a working config/rules for a\nlocal node (with a single line to change for secure/insecure).\n\nWork torwards https://github.com/cockroachdb/docs/issues/469","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ff80294db45b4bad49925f08e1c1a5cb931b598b"},{"sha":"5cb9bbbb760eed9ea7e8fc438da54429ef7ced92","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@thaumogen.net"},"message":"sql: add a new flag to checkRenderStar().","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/5cb9bbbb760eed9ea7e8fc438da54429ef7ced92"},{"sha":"c55d1a21649506bf3425374bee3160e733ffca96","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@thaumogen.net"},"message":"sql: migrate addRender() and checkRenderStar() to a new file.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c55d1a21649506bf3425374bee3160e733ffca96"},{"sha":"9450059ada3d31fe73f0fe4573f4b39b4cbb9d79","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@thaumogen.net"},"message":"sql: factor the code around addRender()\n\nBoth the code for RETURNING, ORDER BY and for window functions was\ndoing something like addRender() but not quite. This patch recognizes\nthe commonalities and refactors as follows:\n\n- `addRender()` becomes `computeRender()` which computes a list of\n  rendered columns without adding them to the `selectNode`.\n\n- a new method `addOrMergeRenders()` is introduced which attempts\n  (under control of a flag) to reuse existing renders when possible.\n\n- the code that was previously using addRender() now uses the new\n  methods, resulting in somewhat shorter but mostly more readable and\n  maintainable code.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/9450059ada3d31fe73f0fe4573f4b39b4cbb9d79"},{"sha":"9314f97f897b47970ff5ee5fdd0a9f3b72fe61c9","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@thaumogen.net"},"message":"sql: detect more ambiguity cases in ORDER BY.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/9314f97f897b47970ff5ee5fdd0a9f3b72fe61c9"},{"sha":"7458c0ac96cf1a5bda29cfd116ead785f1f4f330","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: clarify the semantics of checkRenderStar.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/7458c0ac96cf1a5bda29cfd116ead785f1f4f330"},{"sha":"2d3d2046bcd5b8b87d86365864b31bdbd1f325f5","author":{"name":"Bram Gruneir","email":"c2c698b5c4e9a832f8becb94b691e2846d059921@cockroachlabs.com"},"message":"storage: rename candidates score fields to have score in their name\n\nPart of #10275.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/2d3d2046bcd5b8b87d86365864b31bdbd1f325f5"},{"sha":"a4454f5d48ef84a36ce7c54df8d9ef8b82a0135f","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: fix ORDER BY with aggregates.\n\nSince 146344b799cb94f42789336bb156c614a06be9d5 we have this\noptimization which elides a sort if the sort expression(s) are known\nto be constant throughout all the rows being sorted.\n\nHowever the test to decide whether to elide the sort was (incorrectly)\nrelying only on the presence of columns from the input data source;\nwhich was later extended (but still incorrectly) to the \"random\"\nfunction and \"count\" applied to a StarDatumInstance. This was still\nincorrect because *any* aggregate function is susceptible to change\nvalues between the rows being sorted -- the rows being sorted, with an\naggregate function, are the results of grouping, and the evaluated\nvalue of the aggregate function call is different for every group.\n\nThis patch addresses the issue more durably by:\n\n- introducing a new built-in attribute \"RowDependent\" which indicates\n  whether a particular function is row-dependent. \"random\" and all\n  aggregate functions are marked with this property.\n\n- using this new property in the code that elides the sort.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/a4454f5d48ef84a36ce7c54df8d9ef8b82a0135f"},{"sha":"046ed960435feac557673325c275f43a2f04bdd6","author":{"name":"Ben Darnell","email":"9c85637c38b80821c7bd8a03bde7b59da81ab77d@cockroachlabs.com"},"message":"storage: Cancel pending commands as soon as we get ReplicaTooOldError\n\nThey'd be canceled anyway when the ReplicaGCQueue processed them, but\ncanceling them is sometimes necessary to unblock operations that might\nbe necessary for the ReplicaGCQueue to do its job (in this case,\nresolving intents on the meta records).\n\nFixes #10698\nFixes #11709\n\nReturn AmbiguousResultError instead of RangeNotFoundError for commands\ncanceled in this way. The error gets replaced with an\nAmbiguousResultError further up the stack anyway.\n\nDisable async intent resolution and the replication queue in the\nSplitSnapshotRace tests to remove an additional source of flakiness.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/046ed960435feac557673325c275f43a2f04bdd6"},{"sha":"7d423bb30ea4a312b5b5d42dbf61c99e1d0efd41","author":{"name":"Peter Mattis","email":"96165b703fa5ad88ee03d1dd21db6648d592b647@gmail.com"},"message":"storage/engine: commit and close a batch in one cgo call","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/7d423bb30ea4a312b5b5d42dbf61c99e1d0efd41"},{"sha":"1e25662d812a064a593b1d7b4ef46f8569907e0d","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"*: Switch tests from using health endpoint to metrics endpoint\n\nA handful of tests were hitting the health check URL as a way of\nverifying basic responsiveness of the server. As of\nb314d64706b1dbf1db64a1ff487299a6d692cd37, the health check metric\ndoesn't just blindly return healthy, it relies on node liveness, which\nmeans it's now (very infrequently) flaky.\n\nThe local metrics endpoint shouldn't be flaky, since all it does is call\nthrough the prometheus export logic.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/1e25662d812a064a593b1d7b4ef46f8569907e0d"},{"sha":"96c40e362752477f049b50f4661fe7be73cfb078","author":{"name":"kena","email":"7541742341763867a641aada528529ea551ae635@users.noreply.github.com"},"message":"Merge pull request #12255 from knz/fix-sort\n\nsql: detect more ambiguity cases in ORDER BY.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/96c40e362752477f049b50f4661fe7be73cfb078"},{"sha":"c47c6eda302552c92f2bfd851e8758dbe2d824ea","author":{"name":"kena","email":"7541742341763867a641aada528529ea551ae635@users.noreply.github.com"},"message":"Merge pull request #12185 from knz/fix-count-again\n\nsql: fix ORDER BY with aggregates","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c47c6eda302552c92f2bfd851e8758dbe2d824ea"},{"sha":"e745b63987810a29f3d85a271294f741af54424a","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"client: Add a package or managing leases on arbitrary kv keys\n\nBuilt to initially be used by the migration code since our existing\nlease mechanisms for ranges and SQL schemas aren't very generalizable.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/e745b63987810a29f3d85a271294f741af54424a"},{"sha":"3a603c7aa29746e745dd20b41de8e6e7efbbd325","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"migrations: Add a package to manage system migrations on startup\n\nThis is needed to allow us to make certain changes between versions that\nwouldn't be safe otherwise.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/3a603c7aa29746e745dd20b41de8e6e7efbbd325"},{"sha":"10b72b95ca8a36f0f8c9c1434cea9d1cb6afced9","author":{"name":"Peter Mattis","email":"6214814a67b9688a08e8c6dc7fa5dee076dddc8d@cockroachlabs.com"},"message":"Merge pull request #12343 from petermattis/pmattis/commit-and-close-batch\n\nstorage/engine: commit and close a batch in one cgo call","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/10b72b95ca8a36f0f8c9c1434cea9d1cb6afced9"},{"sha":"967327dc8a7c68b7a63c3bbbb151540c7b900b4f","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"acceptance: Wait in StartCluster until nodes can serve SQL\n\nNow that there's a delay between when a node starts serving kv and when\nit starts serving SQL (due to the SQL migration code path), acceptance\ntests that rely on SQL can have a bad time without this.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/967327dc8a7c68b7a63c3bbbb151540c7b900b4f"},{"sha":"5ec48edd3648bed21bbb0a03c14422a3e385f7b7","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"Merge pull request #12330 from a-robinson/certs\n\n*: Switch tests from using health endpoint to metrics endpoint","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/5ec48edd3648bed21bbb0a03c14422a3e385f7b7"},{"sha":"87021fe7beb15a6ce0c2b589bc67a17cec22e58d","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"stop: Include stack trace in log message when Stop is called","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/87021fe7beb15a6ce0c2b589bc67a17cec22e58d"}]}
{"actor":{"display_login":"spencerkimball"}}