{"action":"created","comment":{"url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/comments/74217315","id":74217315,"diff_hunk":"@@ -484,6 +499,91 @@ public function field_data($table)\n \t// --------------------------------------------------------------------\n \n \t/**\n+\t * Fetch Index Names\n+\t *\n+\t * @param\tstring\t$table\tTable name\n+\t * @return\tarray\n+\t */\n+\tpublic function list_indexes($table)\n+\t{\n+\t\t// Is there a cached result?\n+\t\tif (isset($this->data_cache['table_indexes'][$table]))\n+\t\t{\n+\t\t\treturn $this->data_cache['table_indexes'][$table];\n+\t\t}\n+\t\n+\t\tif (FALSE === ($sql = $this->_list_indexes($table)))","path":"system/database/drivers/mysqli/mysqli_driver.php","position":39,"original_position":39,"commit_id":"6ecf4284c05e17a01799a43f1f2e090c67172e01","original_commit_id":"91a36f3d02cb066094d224b26556c1e00fbb6446","user":{"login":"pkarunyu","id":873150,"avatar_url":"https://avatars.githubusercontent.com/u/873150?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarunyu","html_url":"https://github.com/pkarunyu","followers_url":"https://api.github.com/users/pkarunyu/followers","following_url":"https://api.github.com/users/pkarunyu/following{/other_user}","gists_url":"https://api.github.com/users/pkarunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarunyu/subscriptions","organizations_url":"https://api.github.com/users/pkarunyu/orgs","repos_url":"https://api.github.com/users/pkarunyu/repos","events_url":"https://api.github.com/users/pkarunyu/events{/privacy}","received_events_url":"https://api.github.com/users/pkarunyu/received_events","type":"User","site_admin":false},"body":"@tianhe1986, \r\n> How about keeping list_indexes in DB_driver.php with calling a new function defined in each individual sub-classes to get the name of the index?\r\n\r\nThat would probably work and seems to be the more elegant way of implementing it.","created_at":"2016-08-10T10:00:58Z","updated_at":"2016-08-10T10:00:58Z","html_url":"https://github.com/bcit-ci/CodeIgniter/pull/4757#discussion_r74217315","pull_request_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757","_links":{"self":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/comments/74217315"},"html":{"href":"https://github.com/bcit-ci/CodeIgniter/pull/4757#discussion_r74217315"},"pull_request":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757"}}},"pull_request":{"url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757","id":80611280,"html_url":"https://github.com/bcit-ci/CodeIgniter/pull/4757","diff_url":"https://github.com/bcit-ci/CodeIgniter/pull/4757.diff","patch_url":"https://github.com/bcit-ci/CodeIgniter/pull/4757.patch","issue_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4757","number":4757,"state":"open","locked":false,"title":"Review PR for issue #4756","user":{"login":"pkarunyu","id":873150,"avatar_url":"https://avatars.githubusercontent.com/u/873150?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarunyu","html_url":"https://github.com/pkarunyu","followers_url":"https://api.github.com/users/pkarunyu/followers","following_url":"https://api.github.com/users/pkarunyu/following{/other_user}","gists_url":"https://api.github.com/users/pkarunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarunyu/subscriptions","organizations_url":"https://api.github.com/users/pkarunyu/orgs","repos_url":"https://api.github.com/users/pkarunyu/repos","events_url":"https://api.github.com/users/pkarunyu/events{/privacy}","received_events_url":"https://api.github.com/users/pkarunyu/received_events","type":"User","site_admin":false},"body":"Requesting for review of changes suggested in issue #4756","created_at":"2016-08-09T12:28:26Z","updated_at":"2016-08-10T10:00:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3840fd0e780db2f1674ccac9c71efa1cb7b3b15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757/commits","review_comments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757/comments","review_comment_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4757/comments","statuses_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/statuses/6ecf4284c05e17a01799a43f1f2e090c67172e01","head":{"label":"pkarunyu:develop","ref":"develop","sha":"6ecf4284c05e17a01799a43f1f2e090c67172e01","user":{"login":"pkarunyu","id":873150,"avatar_url":"https://avatars.githubusercontent.com/u/873150?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarunyu","html_url":"https://github.com/pkarunyu","followers_url":"https://api.github.com/users/pkarunyu/followers","following_url":"https://api.github.com/users/pkarunyu/following{/other_user}","gists_url":"https://api.github.com/users/pkarunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarunyu/subscriptions","organizations_url":"https://api.github.com/users/pkarunyu/orgs","repos_url":"https://api.github.com/users/pkarunyu/repos","events_url":"https://api.github.com/users/pkarunyu/events{/privacy}","received_events_url":"https://api.github.com/users/pkarunyu/received_events","type":"User","site_admin":false},"repo":{"id":65276180,"name":"CodeIgniter","full_name":"pkarunyu/CodeIgniter","owner":{"login":"pkarunyu","id":873150,"avatar_url":"https://avatars.githubusercontent.com/u/873150?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarunyu","html_url":"https://github.com/pkarunyu","followers_url":"https://api.github.com/users/pkarunyu/followers","following_url":"https://api.github.com/users/pkarunyu/following{/other_user}","gists_url":"https://api.github.com/users/pkarunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarunyu/subscriptions","organizations_url":"https://api.github.com/users/pkarunyu/orgs","repos_url":"https://api.github.com/users/pkarunyu/repos","events_url":"https://api.github.com/users/pkarunyu/events{/privacy}","received_events_url":"https://api.github.com/users/pkarunyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkarunyu/CodeIgniter","description":"Open Source PHP Framework (originally from EllisLab)","fork":true,"url":"https://api.github.com/repos/pkarunyu/CodeIgniter","forks_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/forks","keys_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/teams","hooks_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/hooks","issue_events_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/issues/events{/number}","events_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/events","assignees_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/assignees{/user}","branches_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/branches{/branch}","tags_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/tags","blobs_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/statuses/{sha}","languages_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/languages","stargazers_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/stargazers","contributors_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/contributors","subscribers_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/subscribers","subscription_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/subscription","commits_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/contents/{+path}","compare_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/merges","archive_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/downloads","issues_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/issues{/number}","pulls_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/pulls{/number}","milestones_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/milestones{/number}","notifications_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/labels{/name}","releases_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/releases{/id}","deployments_url":"https://api.github.com/repos/pkarunyu/CodeIgniter/deployments","created_at":"2016-08-09T08:13:00Z","updated_at":"2016-08-09T08:13:05Z","pushed_at":"2016-08-10T06:22:08Z","git_url":"git://github.com/pkarunyu/CodeIgniter.git","ssh_url":"git@github.com:pkarunyu/CodeIgniter.git","clone_url":"https://github.com/pkarunyu/CodeIgniter.git","svn_url":"https://github.com/pkarunyu/CodeIgniter","homepage":"https://codeigniter.com/","size":44244,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"bcit-ci:develop","ref":"develop","sha":"a4ed425b218942ed7e60d993325f592f5c24e59e","user":{"login":"bcit-ci","id":8863432,"avatar_url":"https://avatars.githubusercontent.com/u/8863432?v=3","gravatar_id":"","url":"https://api.github.com/users/bcit-ci","html_url":"https://github.com/bcit-ci","followers_url":"https://api.github.com/users/bcit-ci/followers","following_url":"https://api.github.com/users/bcit-ci/following{/other_user}","gists_url":"https://api.github.com/users/bcit-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/bcit-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcit-ci/subscriptions","organizations_url":"https://api.github.com/users/bcit-ci/orgs","repos_url":"https://api.github.com/users/bcit-ci/repos","events_url":"https://api.github.com/users/bcit-ci/events{/privacy}","received_events_url":"https://api.github.com/users/bcit-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":2234102,"name":"CodeIgniter","full_name":"bcit-ci/CodeIgniter","owner":{"login":"bcit-ci","id":8863432,"avatar_url":"https://avatars.githubusercontent.com/u/8863432?v=3","gravatar_id":"","url":"https://api.github.com/users/bcit-ci","html_url":"https://github.com/bcit-ci","followers_url":"https://api.github.com/users/bcit-ci/followers","following_url":"https://api.github.com/users/bcit-ci/following{/other_user}","gists_url":"https://api.github.com/users/bcit-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/bcit-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcit-ci/subscriptions","organizations_url":"https://api.github.com/users/bcit-ci/orgs","repos_url":"https://api.github.com/users/bcit-ci/repos","events_url":"https://api.github.com/users/bcit-ci/events{/privacy}","received_events_url":"https://api.github.com/users/bcit-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bcit-ci/CodeIgniter","description":"Open Source PHP Framework (originally from EllisLab)","fork":false,"url":"https://api.github.com/repos/bcit-ci/CodeIgniter","forks_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/forks","keys_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/teams","hooks_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/hooks","issue_events_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/events{/number}","events_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/events","assignees_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/assignees{/user}","branches_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/branches{/branch}","tags_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/tags","blobs_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/statuses/{sha}","languages_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/languages","stargazers_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/stargazers","contributors_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/contributors","subscribers_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/subscribers","subscription_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/subscription","commits_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/contents/{+path}","compare_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/merges","archive_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/downloads","issues_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues{/number}","pulls_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls{/number}","milestones_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/milestones{/number}","notifications_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/labels{/name}","releases_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/releases{/id}","deployments_url":"https://api.github.com/repos/bcit-ci/CodeIgniter/deployments","created_at":"2011-08-19T13:34:00Z","updated_at":"2016-08-10T07:42:15Z","pushed_at":"2016-08-10T06:22:18Z","git_url":"git://github.com/bcit-ci/CodeIgniter.git","ssh_url":"git@github.com:bcit-ci/CodeIgniter.git","clone_url":"https://github.com/bcit-ci/CodeIgniter.git","svn_url":"https://github.com/bcit-ci/CodeIgniter","homepage":"https://codeigniter.com/","size":88788,"stargazers_count":12833,"watchers_count":12833,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6398,"mirror_url":null,"open_issues_count":73,"forks":6398,"open_issues":73,"watchers":12833,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757"},"html":{"href":"https://github.com/bcit-ci/CodeIgniter/pull/4757"},"issue":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4757"},"comments":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/issues/4757/comments"},"review_comments":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757/comments"},"review_comment":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/pulls/4757/commits"},"statuses":{"href":"https://api.github.com/repos/bcit-ci/CodeIgniter/statuses/6ecf4284c05e17a01799a43f1f2e090c67172e01"}}}}
{"actor":{"display_login":"pkarunyu"}}