{"action":"created","comment":{"url":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments/57973169","id":57973169,"diff_hunk":"@@ -84,3 +84,9 @@ void SMTPSendWithDataOperation::main()\n     }\n     setError(error);\n }\n+\n+void SMTPSendWithDataOperation::cancel()\n+{\n+    SMTPOperation::cancel();\n+    session()->session()->cancelMessageSending();","path":"src/async/smtp/MCSMTPSendWithDataOperation.cpp","position":8,"original_position":8,"commit_id":"216ac38f71e4af28b750559e2467c0aaa032568d","original_commit_id":"216ac38f71e4af28b750559e2467c0aaa032568d","user":{"login":"dinhviethoa","id":332168,"avatar_url":"https://avatars.githubusercontent.com/u/332168?v=3","gravatar_id":"","url":"https://api.github.com/users/dinhviethoa","html_url":"https://github.com/dinhviethoa","followers_url":"https://api.github.com/users/dinhviethoa/followers","following_url":"https://api.github.com/users/dinhviethoa/following{/other_user}","gists_url":"https://api.github.com/users/dinhviethoa/gists{/gist_id}","starred_url":"https://api.github.com/users/dinhviethoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinhviethoa/subscriptions","organizations_url":"https://api.github.com/users/dinhviethoa/orgs","repos_url":"https://api.github.com/users/dinhviethoa/repos","events_url":"https://api.github.com/users/dinhviethoa/events{/privacy}","received_events_url":"https://api.github.com/users/dinhviethoa/received_events","type":"User","site_admin":false},"body":"Could you get rid of setSendingCancelled()?\r\nand check in main() if the operation is cancelled before running sendMessage()?\r\n","created_at":"2016-03-30T22:14:12Z","updated_at":"2016-03-30T22:14:12Z","html_url":"https://github.com/MailCore/mailcore2/pull/1392#discussion_r57973169","pull_request_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392","_links":{"self":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments/57973169"},"html":{"href":"https://github.com/MailCore/mailcore2/pull/1392#discussion_r57973169"},"pull_request":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392"}}},"pull_request":{"url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392","id":64537245,"html_url":"https://github.com/MailCore/mailcore2/pull/1392","diff_url":"https://github.com/MailCore/mailcore2/pull/1392.diff","patch_url":"https://github.com/MailCore/mailcore2/pull/1392.patch","issue_url":"https://api.github.com/repos/MailCore/mailcore2/issues/1392","number":1392,"state":"open","locked":false,"title":"Added ability of canceling for active sending operation","user":{"login":"AlexKar","id":1812346,"avatar_url":"https://avatars.githubusercontent.com/u/1812346?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKar","html_url":"https://github.com/AlexKar","followers_url":"https://api.github.com/users/AlexKar/followers","following_url":"https://api.github.com/users/AlexKar/following{/other_user}","gists_url":"https://api.github.com/users/AlexKar/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKar/subscriptions","organizations_url":"https://api.github.com/users/AlexKar/orgs","repos_url":"https://api.github.com/users/AlexKar/repos","events_url":"https://api.github.com/users/AlexKar/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKar/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-29T21:29:43Z","updated_at":"2016-03-30T22:14:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e0916506f29e013315cd01f72f1acb0bdb48ada","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392/commits","review_comments_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392/comments","review_comment_url":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MailCore/mailcore2/issues/1392/comments","statuses_url":"https://api.github.com/repos/MailCore/mailcore2/statuses/216ac38f71e4af28b750559e2467c0aaa032568d","head":{"label":"AlexKar:master","ref":"master","sha":"216ac38f71e4af28b750559e2467c0aaa032568d","user":{"login":"AlexKar","id":1812346,"avatar_url":"https://avatars.githubusercontent.com/u/1812346?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKar","html_url":"https://github.com/AlexKar","followers_url":"https://api.github.com/users/AlexKar/followers","following_url":"https://api.github.com/users/AlexKar/following{/other_user}","gists_url":"https://api.github.com/users/AlexKar/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKar/subscriptions","organizations_url":"https://api.github.com/users/AlexKar/orgs","repos_url":"https://api.github.com/users/AlexKar/repos","events_url":"https://api.github.com/users/AlexKar/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKar/received_events","type":"User","site_admin":false},"repo":{"id":51080126,"name":"mailcore2","full_name":"AlexKar/mailcore2","owner":{"login":"AlexKar","id":1812346,"avatar_url":"https://avatars.githubusercontent.com/u/1812346?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKar","html_url":"https://github.com/AlexKar","followers_url":"https://api.github.com/users/AlexKar/followers","following_url":"https://api.github.com/users/AlexKar/following{/other_user}","gists_url":"https://api.github.com/users/AlexKar/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKar/subscriptions","organizations_url":"https://api.github.com/users/AlexKar/orgs","repos_url":"https://api.github.com/users/AlexKar/repos","events_url":"https://api.github.com/users/AlexKar/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexKar/mailcore2","description":"MailCore 2 provide a simple and asynchronous API to work with e-mail protocols IMAP, POP and SMTP. The API has been redesigned from ground up.","fork":true,"url":"https://api.github.com/repos/AlexKar/mailcore2","forks_url":"https://api.github.com/repos/AlexKar/mailcore2/forks","keys_url":"https://api.github.com/repos/AlexKar/mailcore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexKar/mailcore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexKar/mailcore2/teams","hooks_url":"https://api.github.com/repos/AlexKar/mailcore2/hooks","issue_events_url":"https://api.github.com/repos/AlexKar/mailcore2/issues/events{/number}","events_url":"https://api.github.com/repos/AlexKar/mailcore2/events","assignees_url":"https://api.github.com/repos/AlexKar/mailcore2/assignees{/user}","branches_url":"https://api.github.com/repos/AlexKar/mailcore2/branches{/branch}","tags_url":"https://api.github.com/repos/AlexKar/mailcore2/tags","blobs_url":"https://api.github.com/repos/AlexKar/mailcore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexKar/mailcore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexKar/mailcore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexKar/mailcore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexKar/mailcore2/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexKar/mailcore2/languages","stargazers_url":"https://api.github.com/repos/AlexKar/mailcore2/stargazers","contributors_url":"https://api.github.com/repos/AlexKar/mailcore2/contributors","subscribers_url":"https://api.github.com/repos/AlexKar/mailcore2/subscribers","subscription_url":"https://api.github.com/repos/AlexKar/mailcore2/subscription","commits_url":"https://api.github.com/repos/AlexKar/mailcore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexKar/mailcore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexKar/mailcore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexKar/mailcore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexKar/mailcore2/contents/{+path}","compare_url":"https://api.github.com/repos/AlexKar/mailcore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexKar/mailcore2/merges","archive_url":"https://api.github.com/repos/AlexKar/mailcore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexKar/mailcore2/downloads","issues_url":"https://api.github.com/repos/AlexKar/mailcore2/issues{/number}","pulls_url":"https://api.github.com/repos/AlexKar/mailcore2/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexKar/mailcore2/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexKar/mailcore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexKar/mailcore2/labels{/name}","releases_url":"https://api.github.com/repos/AlexKar/mailcore2/releases{/id}","deployments_url":"https://api.github.com/repos/AlexKar/mailcore2/deployments","created_at":"2016-02-04T14:12:33Z","updated_at":"2016-02-04T14:12:39Z","pushed_at":"2016-03-30T20:50:24Z","git_url":"git://github.com/AlexKar/mailcore2.git","ssh_url":"git@github.com:AlexKar/mailcore2.git","clone_url":"https://github.com/AlexKar/mailcore2.git","svn_url":"https://github.com/AlexKar/mailcore2","homepage":"","size":12794,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MailCore:master","ref":"master","sha":"e9ae0191e85b4006a3cbeebf00af3e5d95a4b54c","user":{"login":"MailCore","id":3229324,"avatar_url":"https://avatars.githubusercontent.com/u/3229324?v=3","gravatar_id":"","url":"https://api.github.com/users/MailCore","html_url":"https://github.com/MailCore","followers_url":"https://api.github.com/users/MailCore/followers","following_url":"https://api.github.com/users/MailCore/following{/other_user}","gists_url":"https://api.github.com/users/MailCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MailCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MailCore/subscriptions","organizations_url":"https://api.github.com/users/MailCore/orgs","repos_url":"https://api.github.com/users/MailCore/repos","events_url":"https://api.github.com/users/MailCore/events{/privacy}","received_events_url":"https://api.github.com/users/MailCore/received_events","type":"Organization","site_admin":false},"repo":{"id":7527552,"name":"mailcore2","full_name":"MailCore/mailcore2","owner":{"login":"MailCore","id":3229324,"avatar_url":"https://avatars.githubusercontent.com/u/3229324?v=3","gravatar_id":"","url":"https://api.github.com/users/MailCore","html_url":"https://github.com/MailCore","followers_url":"https://api.github.com/users/MailCore/followers","following_url":"https://api.github.com/users/MailCore/following{/other_user}","gists_url":"https://api.github.com/users/MailCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MailCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MailCore/subscriptions","organizations_url":"https://api.github.com/users/MailCore/orgs","repos_url":"https://api.github.com/users/MailCore/repos","events_url":"https://api.github.com/users/MailCore/events{/privacy}","received_events_url":"https://api.github.com/users/MailCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MailCore/mailcore2","description":"MailCore 2 provide a simple and asynchronous API to work with e-mail protocols IMAP, POP and SMTP. The API has been redesigned from ground up.","fork":false,"url":"https://api.github.com/repos/MailCore/mailcore2","forks_url":"https://api.github.com/repos/MailCore/mailcore2/forks","keys_url":"https://api.github.com/repos/MailCore/mailcore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MailCore/mailcore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MailCore/mailcore2/teams","hooks_url":"https://api.github.com/repos/MailCore/mailcore2/hooks","issue_events_url":"https://api.github.com/repos/MailCore/mailcore2/issues/events{/number}","events_url":"https://api.github.com/repos/MailCore/mailcore2/events","assignees_url":"https://api.github.com/repos/MailCore/mailcore2/assignees{/user}","branches_url":"https://api.github.com/repos/MailCore/mailcore2/branches{/branch}","tags_url":"https://api.github.com/repos/MailCore/mailcore2/tags","blobs_url":"https://api.github.com/repos/MailCore/mailcore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MailCore/mailcore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MailCore/mailcore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/MailCore/mailcore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MailCore/mailcore2/statuses/{sha}","languages_url":"https://api.github.com/repos/MailCore/mailcore2/languages","stargazers_url":"https://api.github.com/repos/MailCore/mailcore2/stargazers","contributors_url":"https://api.github.com/repos/MailCore/mailcore2/contributors","subscribers_url":"https://api.github.com/repos/MailCore/mailcore2/subscribers","subscription_url":"https://api.github.com/repos/MailCore/mailcore2/subscription","commits_url":"https://api.github.com/repos/MailCore/mailcore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/MailCore/mailcore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/MailCore/mailcore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/MailCore/mailcore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/MailCore/mailcore2/contents/{+path}","compare_url":"https://api.github.com/repos/MailCore/mailcore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MailCore/mailcore2/merges","archive_url":"https://api.github.com/repos/MailCore/mailcore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MailCore/mailcore2/downloads","issues_url":"https://api.github.com/repos/MailCore/mailcore2/issues{/number}","pulls_url":"https://api.github.com/repos/MailCore/mailcore2/pulls{/number}","milestones_url":"https://api.github.com/repos/MailCore/mailcore2/milestones{/number}","notifications_url":"https://api.github.com/repos/MailCore/mailcore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MailCore/mailcore2/labels{/name}","releases_url":"https://api.github.com/repos/MailCore/mailcore2/releases{/id}","deployments_url":"https://api.github.com/repos/MailCore/mailcore2/deployments","created_at":"2013-01-09T19:35:49Z","updated_at":"2016-03-29T05:15:26Z","pushed_at":"2016-03-30T20:50:25Z","git_url":"git://github.com/MailCore/mailcore2.git","ssh_url":"git@github.com:MailCore/mailcore2.git","clone_url":"https://github.com/MailCore/mailcore2.git","svn_url":"https://github.com/MailCore/mailcore2","homepage":"","size":13628,"stargazers_count":1246,"watchers_count":1246,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":353,"mirror_url":null,"open_issues_count":38,"forks":353,"open_issues":38,"watchers":1246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392"},"html":{"href":"https://github.com/MailCore/mailcore2/pull/1392"},"issue":{"href":"https://api.github.com/repos/MailCore/mailcore2/issues/1392"},"comments":{"href":"https://api.github.com/repos/MailCore/mailcore2/issues/1392/comments"},"review_comments":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392/comments"},"review_comment":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MailCore/mailcore2/pulls/1392/commits"},"statuses":{"href":"https://api.github.com/repos/MailCore/mailcore2/statuses/216ac38f71e4af28b750559e2467c0aaa032568d"}}}}