{"action":"created","issue":{"url":"https://api.github.com/repos/projectatomic/commissaire/issues/186","repository_url":"https://api.github.com/repos/projectatomic/commissaire","labels_url":"https://api.github.com/repos/projectatomic/commissaire/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/projectatomic/commissaire/issues/186/comments","events_url":"https://api.github.com/repos/projectatomic/commissaire/issues/186/events","html_url":"https://github.com/projectatomic/commissaire/pull/186","id":170732187,"number":186,"title":"WIP: Delay saving host data until after bootstrapping","user":{"login":"mbarnes","id":56718,"avatar_url":"https://avatars.githubusercontent.com/u/56718?v=3","gravatar_id":"","url":"https://api.github.com/users/mbarnes","html_url":"https://github.com/mbarnes","followers_url":"https://api.github.com/users/mbarnes/followers","following_url":"https://api.github.com/users/mbarnes/following{/other_user}","gists_url":"https://api.github.com/users/mbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarnes/subscriptions","organizations_url":"https://api.github.com/users/mbarnes/orgs","repos_url":"https://api.github.com/users/mbarnes/repos","events_url":"https://api.github.com/users/mbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/mbarnes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/projectatomic/commissaire/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"assignees":[{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-08-11T19:58:12Z","updated_at":"2016-08-16T19:13:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/projectatomic/commissaire/pulls/186","html_url":"https://github.com/projectatomic/commissaire/pull/186","diff_url":"https://github.com/projectatomic/commissaire/pull/186.diff","patch_url":"https://github.com/projectatomic/commissaire/pull/186.patch"},"body":"Resolves #177 \r\n\r\nCouple subtle semantic changes:\r\n\r\n - A newly created host is not added to a cluster until *after* its bootstrapping successfully completes.  Otherwise if a cluster operation were to be started in the interim, the new host may not yet be in a usable state and the cluster operation would fail.\r\n\r\n - We lose some granularity in host status; namely, the `\"bootstrapping\"` status is no longer observable since host data is not saved until bootstapping is finished."},"comment":{"url":"https://api.github.com/repos/projectatomic/commissaire/issues/comments/240207194","html_url":"https://github.com/projectatomic/commissaire/pull/186#issuecomment-240207194","issue_url":"https://api.github.com/repos/projectatomic/commissaire/issues/186","id":240207194,"user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T19:13:09Z","updated_at":"2016-08-16T19:13:09Z","body":"Functionality is working as I expect! Good work @mbarnes!\r\n\r\nOne last thing, running e2e on ``slow`` doesn't pass. Please update them to pass **or** add a new tag such as ``requires_ssh`` if it's not something that can run without keys and use that instead of jumping over all the ``slow`` items.\r\n\r\n```\r\nFailing scenarios:\r\n  features/cluster/hosts.feature:231  Creating a new host with a valid cluster name (1)\r\n  features/cluster/hosts.feature:243  Creating a new host with a valid cluster name (2)\r\n  features/cluster/hosts.feature:255  Creating a new host with a valid cluster name (3)\r\n\r\n1 feature passed, 1 failed, 11 skipped\r\n2 scenarios passed, 3 failed, 58 skipped\r\n19 steps passed, 3 failed, 343 skipped, 0 undefined\r\nTook 0m58.970s\r\n```"}}
{"actor":{"display_login":"ashcrow"}}