{"action":"created","issue":{"url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/issues/1","labels_url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/issues/1/comments","events_url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/issues/1/events","html_url":"https://github.com/origin1tech/gulp-html-minifier/pull/1","id":124603428,"number":1,"title":"Fixed `lint` option","user":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-02T18:13:53Z","updated_at":"2016-01-02T18:37:04Z","closed_at":"2016-01-02T18:15:42Z","pull_request":{"url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/pulls/1","html_url":"https://github.com/origin1tech/gulp-html-minifier/pull/1","diff_url":"https://github.com/origin1tech/gulp-html-minifier/pull/1.diff","patch_url":"https://github.com/origin1tech/gulp-html-minifier/pull/1.patch"},"body":"I got a crash when I wanted to use this gulp plugin with `lint` option.\r\n\r\nI took a look to html-minifier and I found that minify function need that `lint` option must be an object which perform the operation than a boolean.\r\n\r\nhtml-minifier doc show `lint` option as a boolean because the CLI client checks [the option and replace the boolean by the instance of the HTMLLint object](https://github.com/kangax/html-minifier/blob/v1.0.1/cli.js#L278L280) before passing [the options to minifier object](https://github.com/kangax/html-minifier/blob/v1.0.1/cli.js#L163).\r\n\r\nBecause this plugin pass the options directly to the minifier object than using the CLI, due the gulp needs, is required to make that replacement as CLI does. \r\n\r\nThis is a proposed fix for the mentioned above.\r\n\r\nOn the other hand I upgraded the version of html-minifier to the last version available; I wanted to see the [CHANGELOG](https://github.com/kangax/html-minifier/blob/gh-pages/CHANGELOG.md) to know the breaking changes and see if it could be done with no issues, however CHANGELOG hasn't contain the changes the last versions created.\r\n"},"comment":{"url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/issues/comments/168415262","html_url":"https://github.com/origin1tech/gulp-html-minifier/pull/1#issuecomment-168415262","issue_url":"https://api.github.com/repos/origin1tech/gulp-html-minifier/issues/1","id":168415262,"user":{"login":"ifraixedes","id":1731633,"avatar_url":"https://avatars.githubusercontent.com/u/1731633?v=3","gravatar_id":"","url":"https://api.github.com/users/ifraixedes","html_url":"https://github.com/ifraixedes","followers_url":"https://api.github.com/users/ifraixedes/followers","following_url":"https://api.github.com/users/ifraixedes/following{/other_user}","gists_url":"https://api.github.com/users/ifraixedes/gists{/gist_id}","starred_url":"https://api.github.com/users/ifraixedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifraixedes/subscriptions","organizations_url":"https://api.github.com/users/ifraixedes/orgs","repos_url":"https://api.github.com/users/ifraixedes/repos","events_url":"https://api.github.com/users/ifraixedes/events{/privacy}","received_events_url":"https://api.github.com/users/ifraixedes/received_events","type":"User","site_admin":false},"created_at":"2016-01-02T18:37:04Z","updated_at":"2016-01-02T18:37:04Z","body":"You're welcome :+1: "}}