{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/6763","repository_url":"https://api.github.com/repos/sequelize/sequelize","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/6763/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/6763/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/6763/events","html_url":"https://github.com/sequelize/sequelize/issues/6763","id":185657697,"number":6763,"title":"Floats return as strings in 3.24.4","user":{"login":"yktv4","id":1670713,"avatar_url":"https://avatars.githubusercontent.com/u/1670713?v=3","gravatar_id":"","url":"https://api.github.com/users/yktv4","html_url":"https://github.com/yktv4","followers_url":"https://api.github.com/users/yktv4/followers","following_url":"https://api.github.com/users/yktv4/following{/other_user}","gists_url":"https://api.github.com/users/yktv4/gists{/gist_id}","starred_url":"https://api.github.com/users/yktv4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yktv4/subscriptions","organizations_url":"https://api.github.com/users/yktv4/orgs","repos_url":"https://api.github.com/users/yktv4/repos","events_url":"https://api.github.com/users/yktv4/events{/privacy}","received_events_url":"https://api.github.com/users/yktv4/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-27T12:43:29Z","updated_at":"2016-10-27T13:03:34Z","closed_at":"2016-10-27T13:03:34Z","body":"## What you are doing?\r\nI do a simple select of a float number and see what different sequelize versions return\r\n```js\r\nsequelize.query('SELECT 3.22 AS shouldBeFloat')\r\n  .spread(result => console.log(result, typeof result[0].shouldbefloat));\r\n```\r\n\r\n## What do you expect to happen?\r\nI would like floats to be returned as floats and not strings OR if it's not possible anymore, I'd like to have consistent library behavior which would not break my application by going a couple minor versions up.\r\n\r\n## What is actually happening?\r\nfloats are returned as strings in sequelize version `3.24.4` though they were returned as numbers at least in sequelize `3.19.3`. Here's what snippet above outputs for different sequelize versions:\r\n\r\n*sequelize 3.19.3:* `[ { shouldbefloat: '3.22' } ] 'string'`\r\n*sequelize 3.24.4:* `[ { shouldbefloat: 3.22 } ] 'number'`\r\n\r\n__Dialect:__ postgres\r\n__Database version:__ 9.5.3\r\n__Sequelize version:__ 3.24.4 vs 3.19.3\r\n"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/256634505","html_url":"https://github.com/sequelize/sequelize/issues/6763#issuecomment-256634505","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/6763","id":256634505,"user":{"login":"janmeier","id":1210224,"avatar_url":"https://avatars.githubusercontent.com/u/1210224?v=3","gravatar_id":"","url":"https://api.github.com/users/janmeier","html_url":"https://github.com/janmeier","followers_url":"https://api.github.com/users/janmeier/followers","following_url":"https://api.github.com/users/janmeier/following{/other_user}","gists_url":"https://api.github.com/users/janmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/janmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janmeier/subscriptions","organizations_url":"https://api.github.com/users/janmeier/orgs","repos_url":"https://api.github.com/users/janmeier/repos","events_url":"https://api.github.com/users/janmeier/events{/privacy}","received_events_url":"https://api.github.com/users/janmeier/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T13:03:34Z","updated_at":"2016-10-27T13:03:34Z","body":"I see where you are coming from, but parsing decimals into javascript floats was a bug that was introduced in 3.14 https://github.com/sequelize/sequelize/issues/4893, and then fixed again in 3.23.1"}}
{"actor":{"display_login":"janmeier"}}