{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/16365","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/16365/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/16365/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/16365/events","html_url":"https://github.com/mantidproject/mantid/pull/16365","id":156440193,"number":16365,"title":"Add PyCifRW as a dependency on Linux & Mac OS X","user":{"login":"MichaelWedel","id":6361996,"avatar_url":"https://avatars.githubusercontent.com/u/6361996?v=3","gravatar_id":"","url":"https://api.github.com/users/MichaelWedel","html_url":"https://github.com/MichaelWedel","followers_url":"https://api.github.com/users/MichaelWedel/followers","following_url":"https://api.github.com/users/MichaelWedel/following{/other_user}","gists_url":"https://api.github.com/users/MichaelWedel/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelWedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelWedel/subscriptions","organizations_url":"https://api.github.com/users/MichaelWedel/orgs","repos_url":"https://api.github.com/users/MichaelWedel/repos","events_url":"https://api.github.com/users/MichaelWedel/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelWedel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Python","name":"Component: Python","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Priority:%20High","name":"Priority: High","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"Code Freeze:13-May-2016\r\nBeta Testing: 17-May-2016 to 31-May-2016\r\n","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":982,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-05-27T08:14:11Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":3,"created_at":"2016-05-24T07:43:46Z","updated_at":"2016-05-27T08:22:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/16365","html_url":"https://github.com/mantidproject/mantid/pull/16365","diff_url":"https://github.com/mantidproject/mantid/pull/16365.diff","patch_url":"https://github.com/mantidproject/mantid/pull/16365.patch"},"body":"This closes #16364.\r\n\r\n`PyCifRW` has been added as a dependency for the package.\r\n\r\n**To test:**\r\n\r\n<!-- Instructions for testing. -->\r\n\r\nInstall the package and make sure it pulls in the additional dependency on Linux. You need the mantid ppa for Ubuntu and the copr repository for RHEL/fedora. Then start Mantid and try to load a CIF file using `LoadCIF`. It should not give you a warning about the additional package that needs to be installed.\r\n\r\nThis needs three tests:\r\n\r\n1. Ubuntu (installation/`LoadCIF`)\r\n2. RHEL (installation/`LoadCIF`)\r\n3. Mac OS X (`LoadCIF`)\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/222088964","html_url":"https://github.com/mantidproject/mantid/pull/16365#issuecomment-222088964","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/16365","id":222088964,"user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars.githubusercontent.com/u/733773?v=3","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"created_at":"2016-05-27T08:22:31Z","updated_at":"2016-05-27T08:22:31Z","body":"Looks good then.\r\n\r\nLet's :shipit: "}}
{"actor":{"display_login":"martyngigg"}}