{"push_id":1013512297,"size":372,"distinct_size":372,"ref":"refs/heads/master","head":"acde8964597de46a1ea7fc45d55c646d1fd57b91","before":"3efb8ea77cbb5f1716472ed8c9ca025b2c916203","commits":[{"sha":"156dfe15ea964021688f01ea9dbafb316f5814ad","author":{"email":"b0d458d620f2be7f0d1c004301ab450c8bd5d416@gmail.com","name":"Hugh Bellamy"},"message":"Fix #6286 for StringBuilder\n\nOverhauls the entire test file, providing > 90% coverage.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/156dfe15ea964021688f01ea9dbafb316f5814ad"},{"sha":"210bb464abe77fe255f80c18ae8fca06363115ec","author":{"email":"b0d458d620f2be7f0d1c004301ab450c8bd5d416@gmail.com","name":"Hugh Bellamy"},"message":"Fix #6286 for Guid","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/210bb464abe77fe255f80c18ae8fca06363115ec"},{"sha":"7cea040c2643fdcfcf5af138ba2e3f909a258850","author":{"email":"b0d458d620f2be7f0d1c004301ab450c8bd5d416@gmail.com","name":"Hugh Bellamy"},"message":"PR feedback","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/7cea040c2643fdcfcf5af138ba2e3f909a258850"},{"sha":"4d19ccc82bcedeefcd0eb902228329fbd823a7bf","author":{"email":"b0d458d620f2be7f0d1c004301ab450c8bd5d416@gmail.com","name":"Hugh Bellamy"},"message":"Fix inconsistent Equals implementations for Complex\n\nNow Complex.Equals(object) and Complex.Equals(Complex) will always\nreturn consistent results.\n\nExisting test data already cover this, but I removed a workaround for\nthis bug from the test code.\n\nFixes #6338","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/4d19ccc82bcedeefcd0eb902228329fbd823a7bf"},{"sha":"bee25a0f76b348f6ec68b9eb68ed1cb4e72a6200","author":{"email":"b0d458d620f2be7f0d1c004301ab450c8bd5d416@gmail.com","name":"Hugh Bellamy"},"message":"Cleanup ArraySegment tests\n\n- Take advantage of xunit\n- Add missing tests\n- Coverage increased to 100%\n\nContibutes to #6286","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/bee25a0f76b348f6ec68b9eb68ed1cb4e72a6200"},{"sha":"3803a0f1a6223eb49744b2c42a9b57a494e5c1cd","author":{"email":"ef88cdf223e82d966d05894857ed10061f9c24e7@microsoft.com","name":"bartonjs"},"message":"Register parent dependency to CSP SafeHandle types.\n\nAfter writing some scaffolding to ensure that the finalizer race condition from\nGetProviderParameter always happened in the bad order, this change was\nintroduced and was seen to fix the problem.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/3803a0f1a6223eb49744b2c42a9b57a494e5c1cd"},{"sha":"4b45dca00d66389aabf66ba45631fb47aec02319","author":{"email":"ef88cdf223e82d966d05894857ed10061f9c24e7@microsoft.com","name":"bartonjs"},"message":"Make CSP SafeHandle types reuse InvalidHandle values\n\nThe CSP SafeHandle types each had an InvalidHandle property which returned\na new object per call.  This led to a lot of finalization being required, since\nno one would really think to dispose a value which was explicitly the\nInvalidHandle output.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/4b45dca00d66389aabf66ba45631fb47aec02319"},{"sha":"e4b22d9373fd82b657375744b5a9fb5c4138bc03","author":{"email":"ef88cdf223e82d966d05894857ed10061f9c24e7@microsoft.com","name":"bartonjs"},"message":"Improve SafeHandle management in S.S.C.Csp.\n\n* Declare the handle allocating methods as out, instead of ref.\n* Propagate that change to calling methods\n* Dispose any handles that were allocated right before exceptions are thrown\n* Factor all of the complicated CspKeyContainerInfo property gets into two\nhelper methods\n    * And ensure that the temporary handles are disposed on exceptional paths\n* Delete SafeProvHandle::ReleaseProvider, in the VM it was tracking needing to\nfree an allocated BStr.\n* Delete the \"else if\" block in UpgradeRSA, it was unreachable.\n* Change RSACryptoServiceProvider to use lock (_parameters) instead of lock(this)\n* Changed _parameters to be readonly, since it could be.\n* Move most reads/writes of the SafeHandles in RSACryptoServiceProvider to\nproperties\n    * Ensures proper locking on allocation\n    * Ensures proper disposing of previous values on re-assignment\n\nThere were also some cleanup elements that snuck in:\n* Removed some stale comments\n* Corrected some others\n* Clipped down the long lines in RSACryptoServiceProvider\n* Removed unused using-import statements.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/e4b22d9373fd82b657375744b5a9fb5c4138bc03"},{"sha":"3a306215fe2f8f29e6999debf6c02ed996339dbc","author":{"email":"b0d458d620f2be7f0d1c004301ab450c8bd5d416@gmail.com","name":"Hugh Bellamy"},"message":"Cleanup Path tests\n- Use xunit InlineData\n- Follow some consistent test guidelines","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/3a306215fe2f8f29e6999debf6c02ed996339dbc"},{"sha":"96503d398e759510b7dd611130d317bdb5d5c072","author":{"email":"4bbe6463cdfbba0969975546ad242213ee3c349c@microsoft.com","name":"Nick Guerrera"},"message":"Add custom attribute decoder to S.R.Metadata vNext\n\nPort from dev/metadata branch.\n\nIt is internalized out of the upcoming release as with the metadata\nwriter and signature decoder, and equally subject to API review.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/96503d398e759510b7dd611130d317bdb5d5c072"},{"sha":"d6a5bbb4954dce4434cf9e66aa993461d76ed8fa","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Fix a few ArgumentException changes previously reverted\n\nThis reverts commit 1667fb568f05cb02eace29243b1d1b166d67d566.\n\nWe agreed in the design meeting today that these are acceptable changes.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/d6a5bbb4954dce4434cf9e66aa993461d76ed8fa"},{"sha":"908c81d7a8c98f3f4dc1f6302ad7690a952c33c4","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Remove problematic ArrayPool usage\n\nWe decided in the design meeting today that we should only be using ArrayPool in corefx itself in places where we can guarantee the types/methods won't cause corruption, even if due to misuse. Some of the usage we've already put in place doesn't meet this bar and needs to be removed.   For example, we use ```ArrayPool<byte>.Shared``` in a special CopyToAsync implementation, but in doing so we hand a buffer from the pool out to the constiuent streams, and a poorly behaving stream could end up holding on to the buffer even after CopyToAsync has returned to the pool, such as if a Stream.WriteAsync implementation had a bug and completed the returned task before it was actually done with the buffer.\n\nThis commit removes all such usage (which we only very recently added).","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/908c81d7a8c98f3f4dc1f6302ad7690a952c33c4"},{"sha":"3d3641f542dca224f0fdf7cb52a8b6dde3c8c03a","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Remove the issue and PR templates\n\nWe can replace them later with guidance, examples, etc.   Any such thing would need to be in a different form (e.g. the rendered view of these .md files is very different from the content, where a lot of the guidance is in comments that don't render), so I'm simply deleting these for now.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/3d3641f542dca224f0fdf7cb52a8b6dde3c8c03a"},{"sha":"b2b3886877e3f40cf703ab1d1d853f670ada8448","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"stephentoub"},"message":"Use nameof in System.Reflection.TypeExtensions\n\nIt has its own Requires.NotNull.  This changes them to use nameof rather than hardcoded strings.","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/b2b3886877e3f40cf703ab1d1d853f670ada8448"},{"sha":"9cc4f667cd77b101551bfd290a8f5f7da088d410","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #6473 from stephentoub/remove_buffer_usage\n\nRemove problematic ArrayPool usage","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/9cc4f667cd77b101551bfd290a8f5f7da088d410"},{"sha":"6c4dfb5dd438e425cd3ef3976ed456d8d6b7a9a8","author":{"email":"a88a421e76e570cc32414202048d4483ba2f0a1a@microsoft.com","name":"Jonathan Miller"},"message":"Fixing bug #5700 where a test validating a rename scenario could\nfail under high load since the OS X file watcher will send a\ndelete event if a rename pair is split into two notification\npayloads","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/6c4dfb5dd438e425cd3ef3976ed456d8d6b7a9a8"},{"sha":"3bb762dfa5aab9add006ee8cff6e74890bd996a5","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #6470 from stephentoub/fix_argbugs\n\nFix a few ArgumentException changes previously reverted","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/3bb762dfa5aab9add006ee8cff6e74890bd996a5"},{"sha":"70b1cc048a1b95a3ea963e39fcda7a8ad31c61a6","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #6475 from stephentoub/reflection_nameof\n\nUse nameof in System.Reflection.TypeExtensions","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/70b1cc048a1b95a3ea963e39fcda7a8ad31c61a6"},{"sha":"0b43b1a683615455a59563b03722201efe1bf59e","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #6474 from stephentoub/remove_templates\n\nRemove the issue and PR templates","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/0b43b1a683615455a59563b03722201efe1bf59e"},{"sha":"6d7a33a12c3a3236ca313cc0b1523bd008b65c7e","author":{"email":"94274d0b635748ad8df96c0fc4f19e1ecd3f67e2@microsoft.com","name":"Stephen Toub"},"message":"Merge pull request #6478 from sokket/tests\n\nFixing bug #5700 to stabilize a flaky test","distinct":true,"url":"https://api.github.com/repos/steveharter/dotnet_corefx/commits/6d7a33a12c3a3236ca313cc0b1523bd008b65c7e"}]}