{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/86253626","pull_request_review_id":6919156,"id":86253626,"diff_hunk":"@@ -0,0 +1,91 @@\n+dnl Configury specific to the libfabrics BGQ provider\n+\n+dnl Called to configure this provider\n+dnl\n+dnl Arguments:\n+dnl\n+dnl $1: action if configured successfully\n+dnl $2: action if not configured successfully\n+dnl\n+AC_DEFUN([FI_BGQ_CONFIGURE],[\n+\t# Determine if we can support the bgq provider\n+\tbgq_happy=0\n+\tbgq_direct=0\n+\n+\tbgq_driver=/bgsys/drivers/ppcfloor\n+\tAC_SUBST(bgq_driver)\n+\tAC_ARG_WITH([bgq-driver],\n+\t\t[AS_HELP_STRING([--with-bgq-driver=@<:@BGQ driver installation path@:>@],\n+\t\t\t[Provide path to where BGQ system headers are installed])\n+\t\t],\n+\t\t[bgq_driver=$with_bgq_driver])\n+\n+\tbgq_driver_CPPFLAGS=\"-I$bgq_driver -I$bgq_driver/spi/include/kernel/cnk\"\n+\tCPPFLAGS=\"$bgq_driver_CPPFLAGS $CPPFLAGS\"\n+\n+\tAS_IF([test x\"$enable_bgq\" != x\"no\"],\n+\t\t[AC_CHECK_HEADER(hwi/include/bqc/MU_Descriptor.h,\n+\t\t\t[bgq_happy=1],\n+\t\t\t[bgq_happy=0])])\n+\n+\tbgq_external_source=auto\n+\tAC_SUBST(bgq_external_source)\n+\tAC_ARG_WITH([bgq-src],\n+\t\t[AS_HELP_STRING([--with-bgq-src(=DIR)],\n+\t\t\t[bgq opensource distribution @<:@default=auto@:>@])\n+\t\t],\n+\t\t[bgq_external_source=$with_bgq_src])\n+\n+\tAS_IF([test x\"$bgq_external_source\" == x\"auto\"],\n+\t\tfor bgq_dir in `ls -r /bgsys/source`; do\n+\t\t\tAC_MSG_CHECKING([for bgq opensource distribution])\n+\t\t\tAS_IF([test -f /bgsys/source/$bgq_dir/spi/src/kernel/cnk/memory_impl.c],\n+\t\t\t\tbgq_external_source=\"/bgsys/source/$bgq_dir\"\n+\t\t\t\tAC_MSG_RESULT([$bgq_external_source])\n+\t\t\t\tbreak)","path":"prov/bgq/configure.m4","position":45,"original_position":45,"commit_id":"954ab8f39ed6febb90c1e03d08188ad0c8553312","original_commit_id":"d0863ca3b212232bb68c9143c93411dc2a3ced36","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"body":"The \"then\" clause of the `AS_IF` needs to be escaped with square brackets.","created_at":"2016-11-02T22:07:12Z","updated_at":"2016-11-02T22:29:50Z","html_url":"https://github.com/ofiwg/libfabric/pull/2500#discussion_r86253626","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/86253626"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2500#discussion_r86253626"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500","id":92057764,"html_url":"https://github.com/ofiwg/libfabric/pull/2500","diff_url":"https://github.com/ofiwg/libfabric/pull/2500.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/2500.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2500","number":2500,"state":"open","locked":false,"title":"Ofi bgq provider","user":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"body":"This is the initial pull request to add Blue Gene /Q as an official OFI Libfabric provider.\r\n","created_at":"2016-11-02T21:20:24Z","updated_at":"2016-11-02T22:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c29aab851d41b1b67f13122d1ef401f2fb7a69b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/2500/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/954ab8f39ed6febb90c1e03d08188ad0c8553312","head":{"label":"pkcoff:OFI-BGQ-Provider","ref":"OFI-BGQ-Provider","sha":"954ab8f39ed6febb90c1e03d08188ad0c8553312","user":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"repo":{"id":70538136,"name":"libfabric","full_name":"pkcoff/libfabric","owner":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkcoff/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/pkcoff/libfabric","forks_url":"https://api.github.com/repos/pkcoff/libfabric/forks","keys_url":"https://api.github.com/repos/pkcoff/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkcoff/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkcoff/libfabric/teams","hooks_url":"https://api.github.com/repos/pkcoff/libfabric/hooks","issue_events_url":"https://api.github.com/repos/pkcoff/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/pkcoff/libfabric/events","assignees_url":"https://api.github.com/repos/pkcoff/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/pkcoff/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/pkcoff/libfabric/tags","blobs_url":"https://api.github.com/repos/pkcoff/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkcoff/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkcoff/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkcoff/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkcoff/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/pkcoff/libfabric/languages","stargazers_url":"https://api.github.com/repos/pkcoff/libfabric/stargazers","contributors_url":"https://api.github.com/repos/pkcoff/libfabric/contributors","subscribers_url":"https://api.github.com/repos/pkcoff/libfabric/subscribers","subscription_url":"https://api.github.com/repos/pkcoff/libfabric/subscription","commits_url":"https://api.github.com/repos/pkcoff/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkcoff/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkcoff/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkcoff/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkcoff/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/pkcoff/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkcoff/libfabric/merges","archive_url":"https://api.github.com/repos/pkcoff/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkcoff/libfabric/downloads","issues_url":"https://api.github.com/repos/pkcoff/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/pkcoff/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/pkcoff/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/pkcoff/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkcoff/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/pkcoff/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/pkcoff/libfabric/deployments","created_at":"2016-10-10T23:47:13Z","updated_at":"2016-10-10T23:47:17Z","pushed_at":"2016-11-02T21:17:46Z","git_url":"git://github.com/pkcoff/libfabric.git","ssh_url":"git@github.com:pkcoff/libfabric.git","clone_url":"https://github.com/pkcoff/libfabric.git","svn_url":"https://github.com/pkcoff/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":13345,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"ea0449407b6b2e112aece7445f8d64358d1e5bb9","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2016-11-01T15:49:42Z","pushed_at":"2016-11-02T21:20:24Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":14410,"stargazers_count":81,"watchers_count":81,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":87,"forks":85,"open_issues":87,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/2500"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2500"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/2500/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/2500/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/954ab8f39ed6febb90c1e03d08188ad0c8553312"}}}}
{"actor":{"display_login":"jsquyres"}}