{"comment":{"url":"https://api.github.com/repos/spring/spring/comments/15358056","html_url":"https://github.com/spring/spring/commit/81335990321e3d57c3da6aa2685c4b3cc00daded#commitcomment-15358056","id":15358056,"user":{"login":"gajop","id":64901,"avatar_url":"https://avatars.githubusercontent.com/u/64901?v=3","gravatar_id":"","url":"https://api.github.com/users/gajop","html_url":"https://github.com/gajop","followers_url":"https://api.github.com/users/gajop/followers","following_url":"https://api.github.com/users/gajop/following{/other_user}","gists_url":"https://api.github.com/users/gajop/gists{/gist_id}","starred_url":"https://api.github.com/users/gajop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajop/subscriptions","organizations_url":"https://api.github.com/users/gajop/orgs","repos_url":"https://api.github.com/users/gajop/repos","events_url":"https://api.github.com/users/gajop/events{/privacy}","received_events_url":"https://api.github.com/users/gajop/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"81335990321e3d57c3da6aa2685c4b3cc00daded","created_at":"2016-01-10T05:06:10Z","updated_at":"2016-01-10T05:06:10Z","body":"1) Should any of this be applied to SetWaterParams?\r\n2) Water is currently reading/modifying the CMapInfo::water_t directly, should this be modified to work more like SunLighting and have a global instance instead and support events?\r\n3) SetWaterParams is unsynced but requires cheating, should it? It seems to be an odd exception in that regard, and I'd rather have it not require so or be synced. @jk3064  might know more \r\n"}}