{"action":"reopened","number":1076,"pull_request":{"url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1076","id":54912146,"html_url":"https://github.com/rockstor/rockstor-core/pull/1076","diff_url":"https://github.com/rockstor/rockstor-core/pull/1076.diff","patch_url":"https://github.com/rockstor/rockstor-core/pull/1076.patch","issue_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1076","number":1076,"state":"open","locked":false,"title":"no smart info on msa70. Fixes #997","user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"body":"By adding a mode that reads smartctl outputs directly from file dumps of the same I was able to use @priel71 's smartctl outputs from their lsi9207-8i setup and correct some parsing issues.\r\nThe most noteworthy of which caused the existing parser to report no smart availability.\r\nSince some smart info is not presented in a standard way I have also modified the UI presentation to dump raw output of for example Error Logs when no parsing for a summary was successful but when error info exists. Also the patch set adds info to user of no Attributes and Capabilities returned from some drives rather than just showing an empty table.\r\nI was unable to verify Error Logs & Self-Test Logs tab function as the supplied outputs had no info on either of these. I am assuming if present this info is formatted similarly to what has worked to date.\r\nWhere logs were previously saved verbatim but not displayed as such I have via \"pre\" tags reproduced the original formatting as this is important for interpreting tabulated / spaced output; and in the case of error logs is the only means of viewing them. There is apparently no standard formatting on non ATA/SATA drives.\r\n\r\nAll changes have been tested with several existing drives that have error logs and test logs and drives that have neither. \r\n\r\nNote that main presented in the Identity / Info tab is paired with equivalents and no db / model changes were required.\r\n\r\nFixes #997 Although the modifications were based on a later submitter they are assumed to be equivalent. I have re-contacted the original reporter on the forum but have not heard back.\r\n\r\nPossible simple improvements are to remove the redundant double spacing in the display of:-\r\nRaw S.M.A.R.T error log\r\nnon summary part of Self-Test Logs\r\nThis is currently better readability wise but aesthetically challenged.\r\n","created_at":"2016-01-02T20:35:20Z","updated_at":"2016-01-04T22:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b6c512c3e8ab640e213e2f29ed706afb9ca3e9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1076/commits","review_comments_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1076/comments","review_comment_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/1076/comments","statuses_url":"https://api.github.com/repos/rockstor/rockstor-core/statuses/cd1101e51d3421b83635482a282fcadc9578c372","head":{"label":"phillxnet:997_no_SMART_info_on_MSA70","ref":"997_no_SMART_info_on_MSA70","sha":"cd1101e51d3421b83635482a282fcadc9578c372","user":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"repo":{"id":35962271,"name":"rockstor-core","full_name":"phillxnet/rockstor-core","owner":{"login":"phillxnet","id":2521585,"avatar_url":"https://avatars.githubusercontent.com/u/2521585?v=3","gravatar_id":"","url":"https://api.github.com/users/phillxnet","html_url":"https://github.com/phillxnet","followers_url":"https://api.github.com/users/phillxnet/followers","following_url":"https://api.github.com/users/phillxnet/following{/other_user}","gists_url":"https://api.github.com/users/phillxnet/gists{/gist_id}","starred_url":"https://api.github.com/users/phillxnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillxnet/subscriptions","organizations_url":"https://api.github.com/users/phillxnet/orgs","repos_url":"https://api.github.com/users/phillxnet/repos","events_url":"https://api.github.com/users/phillxnet/events{/privacy}","received_events_url":"https://api.github.com/users/phillxnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phillxnet/rockstor-core","description":"Rockstor core","fork":true,"url":"https://api.github.com/repos/phillxnet/rockstor-core","forks_url":"https://api.github.com/repos/phillxnet/rockstor-core/forks","keys_url":"https://api.github.com/repos/phillxnet/rockstor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phillxnet/rockstor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phillxnet/rockstor-core/teams","hooks_url":"https://api.github.com/repos/phillxnet/rockstor-core/hooks","issue_events_url":"https://api.github.com/repos/phillxnet/rockstor-core/issues/events{/number}","events_url":"https://api.github.com/repos/phillxnet/rockstor-core/events","assignees_url":"https://api.github.com/repos/phillxnet/rockstor-core/assignees{/user}","branches_url":"https://api.github.com/repos/phillxnet/rockstor-core/branches{/branch}","tags_url":"https://api.github.com/repos/phillxnet/rockstor-core/tags","blobs_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phillxnet/rockstor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/phillxnet/rockstor-core/languages","stargazers_url":"https://api.github.com/repos/phillxnet/rockstor-core/stargazers","contributors_url":"https://api.github.com/repos/phillxnet/rockstor-core/contributors","subscribers_url":"https://api.github.com/repos/phillxnet/rockstor-core/subscribers","subscription_url":"https://api.github.com/repos/phillxnet/rockstor-core/subscription","commits_url":"https://api.github.com/repos/phillxnet/rockstor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/phillxnet/rockstor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/phillxnet/rockstor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/phillxnet/rockstor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/phillxnet/rockstor-core/contents/{+path}","compare_url":"https://api.github.com/repos/phillxnet/rockstor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phillxnet/rockstor-core/merges","archive_url":"https://api.github.com/repos/phillxnet/rockstor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phillxnet/rockstor-core/downloads","issues_url":"https://api.github.com/repos/phillxnet/rockstor-core/issues{/number}","pulls_url":"https://api.github.com/repos/phillxnet/rockstor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/phillxnet/rockstor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/phillxnet/rockstor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phillxnet/rockstor-core/labels{/name}","releases_url":"https://api.github.com/repos/phillxnet/rockstor-core/releases{/id}","created_at":"2015-05-20T17:10:38Z","updated_at":"2015-05-20T17:10:40Z","pushed_at":"2016-01-02T19:43:43Z","git_url":"git://github.com/phillxnet/rockstor-core.git","ssh_url":"git@github.com:phillxnet/rockstor-core.git","clone_url":"https://github.com/phillxnet/rockstor-core.git","svn_url":"https://github.com/phillxnet/rockstor-core","homepage":"http://www.rockstor.com/docs/contribute.html","size":9651,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rockstor:master","ref":"master","sha":"97ac4822c153975336793a47dc6219582f7d80f7","user":{"login":"rockstor","id":4014253,"avatar_url":"https://avatars.githubusercontent.com/u/4014253?v=3","gravatar_id":"","url":"https://api.github.com/users/rockstor","html_url":"https://github.com/rockstor","followers_url":"https://api.github.com/users/rockstor/followers","following_url":"https://api.github.com/users/rockstor/following{/other_user}","gists_url":"https://api.github.com/users/rockstor/gists{/gist_id}","starred_url":"https://api.github.com/users/rockstor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockstor/subscriptions","organizations_url":"https://api.github.com/users/rockstor/orgs","repos_url":"https://api.github.com/users/rockstor/repos","events_url":"https://api.github.com/users/rockstor/events{/privacy}","received_events_url":"https://api.github.com/users/rockstor/received_events","type":"Organization","site_admin":false},"repo":{"id":9136748,"name":"rockstor-core","full_name":"rockstor/rockstor-core","owner":{"login":"rockstor","id":4014253,"avatar_url":"https://avatars.githubusercontent.com/u/4014253?v=3","gravatar_id":"","url":"https://api.github.com/users/rockstor","html_url":"https://github.com/rockstor","followers_url":"https://api.github.com/users/rockstor/followers","following_url":"https://api.github.com/users/rockstor/following{/other_user}","gists_url":"https://api.github.com/users/rockstor/gists{/gist_id}","starred_url":"https://api.github.com/users/rockstor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockstor/subscriptions","organizations_url":"https://api.github.com/users/rockstor/orgs","repos_url":"https://api.github.com/users/rockstor/repos","events_url":"https://api.github.com/users/rockstor/events{/privacy}","received_events_url":"https://api.github.com/users/rockstor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rockstor/rockstor-core","description":"Linux/BTRFS based Network Attached Storage(NAS)","fork":false,"url":"https://api.github.com/repos/rockstor/rockstor-core","forks_url":"https://api.github.com/repos/rockstor/rockstor-core/forks","keys_url":"https://api.github.com/repos/rockstor/rockstor-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rockstor/rockstor-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rockstor/rockstor-core/teams","hooks_url":"https://api.github.com/repos/rockstor/rockstor-core/hooks","issue_events_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/events{/number}","events_url":"https://api.github.com/repos/rockstor/rockstor-core/events","assignees_url":"https://api.github.com/repos/rockstor/rockstor-core/assignees{/user}","branches_url":"https://api.github.com/repos/rockstor/rockstor-core/branches{/branch}","tags_url":"https://api.github.com/repos/rockstor/rockstor-core/tags","blobs_url":"https://api.github.com/repos/rockstor/rockstor-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rockstor/rockstor-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rockstor/rockstor-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rockstor/rockstor-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rockstor/rockstor-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rockstor/rockstor-core/languages","stargazers_url":"https://api.github.com/repos/rockstor/rockstor-core/stargazers","contributors_url":"https://api.github.com/repos/rockstor/rockstor-core/contributors","subscribers_url":"https://api.github.com/repos/rockstor/rockstor-core/subscribers","subscription_url":"https://api.github.com/repos/rockstor/rockstor-core/subscription","commits_url":"https://api.github.com/repos/rockstor/rockstor-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rockstor/rockstor-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rockstor/rockstor-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rockstor/rockstor-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rockstor/rockstor-core/contents/{+path}","compare_url":"https://api.github.com/repos/rockstor/rockstor-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rockstor/rockstor-core/merges","archive_url":"https://api.github.com/repos/rockstor/rockstor-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rockstor/rockstor-core/downloads","issues_url":"https://api.github.com/repos/rockstor/rockstor-core/issues{/number}","pulls_url":"https://api.github.com/repos/rockstor/rockstor-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rockstor/rockstor-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rockstor/rockstor-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rockstor/rockstor-core/labels{/name}","releases_url":"https://api.github.com/repos/rockstor/rockstor-core/releases{/id}","created_at":"2013-03-31T21:41:57Z","updated_at":"2015-12-25T07:31:53Z","pushed_at":"2016-01-04T21:35:18Z","git_url":"git://github.com/rockstor/rockstor-core.git","ssh_url":"git@github.com:rockstor/rockstor-core.git","clone_url":"https://github.com/rockstor/rockstor-core.git","svn_url":"https://github.com/rockstor/rockstor-core","homepage":"http://www.rockstor.com/docs/contribute.html","size":11688,"stargazers_count":137,"watchers_count":137,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":181,"forks":45,"open_issues":181,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1076"},"html":{"href":"https://github.com/rockstor/rockstor-core/pull/1076"},"issue":{"href":"https://api.github.com/repos/rockstor/rockstor-core/issues/1076"},"comments":{"href":"https://api.github.com/repos/rockstor/rockstor-core/issues/1076/comments"},"review_comments":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1076/comments"},"review_comment":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rockstor/rockstor-core/pulls/1076/commits"},"statuses":{"href":"https://api.github.com/repos/rockstor/rockstor-core/statuses/cd1101e51d3421b83635482a282fcadc9578c372"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":17,"additions":252,"deletions":130,"changed_files":2}}