{"action":"created","comment":{"url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/comments/69234796","id":69234796,"diff_hunk":"@@ -2350,6 +2352,9 @@ def export_render_settings(ri, rpass, scene, preview=False):\n     ri.PixelFilter(rm.pixelfilter, rm.pixelfilter_x, rm.pixelfilter_y)\n     ri.ShadingRate(rm.shadingrate)\n     ri.Attribute(\"trace\", depths)\n+    if rm.use_separate_path_depths:\n+        ri.Option(\"trace\", {'string depthmode': 'separate'})","path":"export.py","position":14,"original_position":14,"commit_id":"ebc2c9bc75101bf98114a1e08b377171093b6e6e","original_commit_id":"ebc2c9bc75101bf98114a1e08b377171093b6e6e","user":{"login":"jdent02","id":13521172,"avatar_url":"https://avatars.githubusercontent.com/u/13521172?v=3","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"body":"Sounds good. I'll fix er up\n\nSent from my iPhone\n\nOn Jun 30, 2016, at 7:22 PM, bsavery <notifications@github.com<mailto:notifications@github.com>> wrote:\n\n\nIn export.py<https://github.com/bsavery/PRMan-for-Blender/pull/295#discussion_r69231763>:\n\n> @@ -2350,6 +2352,9 @@ def export_render_settings(ri, rpass, scene, preview=False):\n>      ri.PixelFilter(rm.pixelfilter, rm.pixelfilter_x, rm.pixelfilter_y)\n>      ri.ShadingRate(rm.shadingrate)\n>      ri.Attribute(\"trace\", depths)\n> +    if rm.use_separate_path_depths:\n> +        ri.Option(\"trace\", {'string depthmode': 'separate'})\n\n\nOptions should be emit once. I like to keep them at the top of file.\n...\nOn Thu, Jun 30, 2016 at 5:05 PM, Jon D ***@***.***> wrote: In export.py <#295 (comment)<https://github.com/bsavery/PRMan-for-Blender/pull/295#discussion_r69230332>> : > @@ -2350,6 +2352,9 @@ def export_render_settings(ri, rpass, scene, preview=False): > ri.PixelFilter(rm.pixelfilter, rm.pixelfilter_x, rm.pixelfilter_y) > ri.ShadingRate(rm.shadingrate) > ri.Attribute(\"trace\", depths) > + if rm.use_separate_path_depths: > + ri.Option(\"trace\", {'string depthmode': 'separate'}) I wasn't sure if the option would work earlier in the rib but sure it can be moved there if needed. It does work in this location. Also being that it's a scene variable it will only be output once. I noticed all the other trace parameters were 'attributes' instead of 'options' so that's why it is by itself. Sent from my iPhone On Jun 30, 2016, at 5:00 PM, bsavery < ***@***.******@***.***>> wrote: In export.py<#295<https://github.com/bsavery/PRMan-for-Blender/pull/295> (comment) <#295 (comment)<https://github.com/bsavery/PRMan-for-Blender/pull/295#discussion_r69218182>> >: @@ -2350,6 +2352,9 @@ def export_render_settings(ri, rpass, scene, preview=False): ri.PixelFilter(rm.pixelfilter, rm.pixelfilter_x, rm.pixelfilter_y) ri.ShadingRate(rm.shadingrate) ri.Attribute(\"trace\", depths) + if rm.use_separate_path_depths: + ri.Option(\"trace\", {'string depthmode': 'separate'}) So first of all you're going to output an option multiple times postentially. Which doesn't really matter here but generally a weird idea. And options should really be output earlier in the rib with the others.... Maybe when options are output could scan through and see if any have relative pixel variance set? - You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://github.com/bsavery/PRMan-for-Blender/pull/295/files/ebc2c9bc75101bf98114a1e08b377171093b6e6e#r69218182>, or mute the thread< https://github.com/notifications/unsubscribe/AM5RFO2J9dh6tmQFY9ED2y_WUil6ZRakks5qRDxxgaJpZM4JCeTu >. - You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/bsavery/PRMan-for-Blender/pull/295/files/ebc2c9bc75101bf98114a1e08b377171093b6e6e#r69230332>, or mute the thread <https://github.com/notifications/unsubscribe/ABzffCgX_nMaJrlAgXh_ccTw9JEDrmqdks5qRFm6gaJpZM4JCeTu> .\n-- brian.savery@gmail.com<mailto:brian.savery@gmail.com> 508-274-8700\n\n-\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub<https://github.com/bsavery/PRMan-for-Blender/pull/295/files/ebc2c9bc75101bf98114a1e08b377171093b6e6e#r69231763>, or mute the thread<https://github.com/notifications/unsubscribe/AM5RFAnn7hEMQY37x_rp__5AK3cY6Uyjks5qRF3egaJpZM4JCeTu>.\n","created_at":"2016-07-01T01:02:37Z","updated_at":"2016-07-01T01:02:37Z","html_url":"https://github.com/bsavery/PRMan-for-Blender/pull/295#discussion_r69234796","pull_request_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/comments/69234796"},"html":{"href":"https://github.com/bsavery/PRMan-for-Blender/pull/295#discussion_r69234796"},"pull_request":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295","id":75870673,"html_url":"https://github.com/bsavery/PRMan-for-Blender/pull/295","diff_url":"https://github.com/bsavery/PRMan-for-Blender/pull/295.diff","patch_url":"https://github.com/bsavery/PRMan-for-Blender/pull/295.patch","issue_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues/295","number":295,"state":"open","locked":false,"title":"Add relative pixel variance and separable path depths (and some fixes)","user":{"login":"jdent02","id":13521172,"avatar_url":"https://avatars.githubusercontent.com/u/13521172?v=3","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-30T18:47:59Z","updated_at":"2016-07-01T01:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9046d49abca011fd4326e9d38c53233bc6545cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295/commits","review_comments_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295/comments","review_comment_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues/295/comments","statuses_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/statuses/ebc2c9bc75101bf98114a1e08b377171093b6e6e","head":{"label":"jdent02:devel","ref":"devel","sha":"ebc2c9bc75101bf98114a1e08b377171093b6e6e","user":{"login":"jdent02","id":13521172,"avatar_url":"https://avatars.githubusercontent.com/u/13521172?v=3","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"repo":{"id":58671500,"name":"PRMan-for-Blender","full_name":"jdent02/PRMan-for-Blender","owner":{"login":"jdent02","id":13521172,"avatar_url":"https://avatars.githubusercontent.com/u/13521172?v=3","gravatar_id":"","url":"https://api.github.com/users/jdent02","html_url":"https://github.com/jdent02","followers_url":"https://api.github.com/users/jdent02/followers","following_url":"https://api.github.com/users/jdent02/following{/other_user}","gists_url":"https://api.github.com/users/jdent02/gists{/gist_id}","starred_url":"https://api.github.com/users/jdent02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdent02/subscriptions","organizations_url":"https://api.github.com/users/jdent02/orgs","repos_url":"https://api.github.com/users/jdent02/repos","events_url":"https://api.github.com/users/jdent02/events{/privacy}","received_events_url":"https://api.github.com/users/jdent02/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdent02/PRMan-for-Blender","description":"PRMan for Blender render addon","fork":true,"url":"https://api.github.com/repos/jdent02/PRMan-for-Blender","forks_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/forks","keys_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/teams","hooks_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/hooks","issue_events_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/issues/events{/number}","events_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/events","assignees_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/assignees{/user}","branches_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/branches{/branch}","tags_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/tags","blobs_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/statuses/{sha}","languages_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/languages","stargazers_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/stargazers","contributors_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/contributors","subscribers_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/subscribers","subscription_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/subscription","commits_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/contents/{+path}","compare_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/merges","archive_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/downloads","issues_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/issues{/number}","pulls_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/pulls{/number}","milestones_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/milestones{/number}","notifications_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/labels{/name}","releases_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/releases{/id}","deployments_url":"https://api.github.com/repos/jdent02/PRMan-for-Blender/deployments","created_at":"2016-05-12T19:40:41Z","updated_at":"2016-05-12T19:40:42Z","pushed_at":"2016-06-30T21:34:20Z","git_url":"git://github.com/jdent02/PRMan-for-Blender.git","ssh_url":"git@github.com:jdent02/PRMan-for-Blender.git","clone_url":"https://github.com/jdent02/PRMan-for-Blender.git","svn_url":"https://github.com/jdent02/PRMan-for-Blender","homepage":"","size":78739,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bsavery:devel","ref":"devel","sha":"46d2175869c4f63e93b5f7a6a347e11eeade690a","user":{"login":"bsavery","id":1892220,"avatar_url":"https://avatars.githubusercontent.com/u/1892220?v=3","gravatar_id":"","url":"https://api.github.com/users/bsavery","html_url":"https://github.com/bsavery","followers_url":"https://api.github.com/users/bsavery/followers","following_url":"https://api.github.com/users/bsavery/following{/other_user}","gists_url":"https://api.github.com/users/bsavery/gists{/gist_id}","starred_url":"https://api.github.com/users/bsavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsavery/subscriptions","organizations_url":"https://api.github.com/users/bsavery/orgs","repos_url":"https://api.github.com/users/bsavery/repos","events_url":"https://api.github.com/users/bsavery/events{/privacy}","received_events_url":"https://api.github.com/users/bsavery/received_events","type":"User","site_admin":false},"repo":{"id":32901914,"name":"PRMan-for-Blender","full_name":"bsavery/PRMan-for-Blender","owner":{"login":"bsavery","id":1892220,"avatar_url":"https://avatars.githubusercontent.com/u/1892220?v=3","gravatar_id":"","url":"https://api.github.com/users/bsavery","html_url":"https://github.com/bsavery","followers_url":"https://api.github.com/users/bsavery/followers","following_url":"https://api.github.com/users/bsavery/following{/other_user}","gists_url":"https://api.github.com/users/bsavery/gists{/gist_id}","starred_url":"https://api.github.com/users/bsavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsavery/subscriptions","organizations_url":"https://api.github.com/users/bsavery/orgs","repos_url":"https://api.github.com/users/bsavery/repos","events_url":"https://api.github.com/users/bsavery/events{/privacy}","received_events_url":"https://api.github.com/users/bsavery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsavery/PRMan-for-Blender","description":"PRMan for Blender render addon","fork":true,"url":"https://api.github.com/repos/bsavery/PRMan-for-Blender","forks_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/forks","keys_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/teams","hooks_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/hooks","issue_events_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues/events{/number}","events_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/events","assignees_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/assignees{/user}","branches_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/branches{/branch}","tags_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/tags","blobs_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/statuses/{sha}","languages_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/languages","stargazers_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/stargazers","contributors_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/contributors","subscribers_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/subscribers","subscription_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/subscription","commits_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/contents/{+path}","compare_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/merges","archive_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/downloads","issues_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues{/number}","pulls_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls{/number}","milestones_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/milestones{/number}","notifications_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/labels{/name}","releases_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/releases{/id}","deployments_url":"https://api.github.com/repos/bsavery/PRMan-for-Blender/deployments","created_at":"2015-03-26T01:59:07Z","updated_at":"2016-06-24T22:41:39Z","pushed_at":"2016-06-30T21:34:20Z","git_url":"git://github.com/bsavery/PRMan-for-Blender.git","ssh_url":"git@github.com:bsavery/PRMan-for-Blender.git","clone_url":"https://github.com/bsavery/PRMan-for-Blender.git","svn_url":"https://github.com/bsavery/PRMan-for-Blender","homepage":"","size":78963,"stargazers_count":226,"watchers_count":226,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":29,"forks":34,"open_issues":29,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295"},"html":{"href":"https://github.com/bsavery/PRMan-for-Blender/pull/295"},"issue":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues/295"},"comments":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/bsavery/PRMan-for-Blender/statuses/ebc2c9bc75101bf98114a1e08b377171093b6e6e"}}}}
{"actor":{"display_login":"jdent02"}}