{"action":"created","issue":{"url":"https://api.github.com/repos/uber/tchannel-python/issues/415","repository_url":"https://api.github.com/repos/uber/tchannel-python","labels_url":"https://api.github.com/repos/uber/tchannel-python/issues/415/labels{/name}","comments_url":"https://api.github.com/repos/uber/tchannel-python/issues/415/comments","events_url":"https://api.github.com/repos/uber/tchannel-python/issues/415/events","html_url":"https://github.com/uber/tchannel-python/pull/415","id":163971464,"number":415,"title":"Native OpenTracing 1.x integration","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"assignees":[{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},{"login":"blampe","id":848843,"avatar_url":"https://avatars.githubusercontent.com/u/848843?v=3","gravatar_id":"","url":"https://api.github.com/users/blampe","html_url":"https://github.com/blampe","followers_url":"https://api.github.com/users/blampe/followers","following_url":"https://api.github.com/users/blampe/following{/other_user}","gists_url":"https://api.github.com/users/blampe/gists{/gist_id}","starred_url":"https://api.github.com/users/blampe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blampe/subscriptions","organizations_url":"https://api.github.com/users/blampe/orgs","repos_url":"https://api.github.com/users/blampe/repos","events_url":"https://api.github.com/users/blampe/events{/privacy}","received_events_url":"https://api.github.com/users/blampe/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2016-07-05T23:54:32Z","updated_at":"2016-07-13T01:52:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-python/pulls/415","html_url":"https://github.com/uber/tchannel-python/pull/415","diff_url":"https://github.com/uber/tchannel-python/pull/415.diff","patch_url":"https://github.com/uber/tchannel-python/pull/415.patch"},"body":"Ready for review. Main changes:\r\n * native tchannel tracing removed completely\r\n * `tracing` field is still the same, and is initialized randomly\r\n * the actual tracing is done via OpenTracing API\r\n * OT tracing only works with JSON/Thrift encoding as it needs app headers to propagate\r\n * `RequestContext` is removed and replaced by pluggable `TracingContextProvider`, which defaults to `opentracing_instrumentation` StackContext+thread-local based implementation, for interoperability with http patching\r\n\r\nWhat's _not_ implemented:\r\n * no tracing over Raw encoding. In the corresponding [tchannel-go PR](https://github.com/uber/tchannel-go/pull/426) tracing is supported even over Raw, provided that the OT tracer is \"zipkin-compatible\". However, Jaeger tracer is the only one zipkin-compatible, and it's not currently open-sourced (eta - mid-July). Once it's open-sourced, we can implement tracing over Raw as well (without baggage, same as in Go).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/uber/tchannel-python/issues/comments/232233046","html_url":"https://github.com/uber/tchannel-python/pull/415#issuecomment-232233046","issue_url":"https://api.github.com/repos/uber/tchannel-python/issues/415","id":232233046,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T01:52:39Z","updated_at":"2016-07-13T01:52:39Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6981573/badge)](https://coveralls.io/builds/6981573)\n\nCoverage decreased (-0.2%) to 93.414% when pulling **597e4128859b88d20754b352b448410ba3caaf11 on native-opentracing-integration** into **5b83f230d352d0c2d61e14b1c698acf7bcc277b7 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}