{"action":"closed","number":187,"pull_request":{"url":"https://api.github.com/repos/marcelm/cutadapt/pulls/187","id":61945872,"html_url":"https://github.com/marcelm/cutadapt/pull/187","diff_url":"https://github.com/marcelm/cutadapt/pull/187.diff","patch_url":"https://github.com/marcelm/cutadapt/pull/187.patch","issue_url":"https://api.github.com/repos/marcelm/cutadapt/issues/187","number":187,"state":"closed","locked":false,"title":"Remove buffer_size parameter","user":{"login":"jdidion","id":125854,"avatar_url":"https://avatars.githubusercontent.com/u/125854?v=3","gravatar_id":"","url":"https://api.github.com/users/jdidion","html_url":"https://github.com/jdidion","followers_url":"https://api.github.com/users/jdidion/followers","following_url":"https://api.github.com/users/jdidion/following{/other_user}","gists_url":"https://api.github.com/users/jdidion/gists{/gist_id}","starred_url":"https://api.github.com/users/jdidion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdidion/subscriptions","organizations_url":"https://api.github.com/users/jdidion/orgs","repos_url":"https://api.github.com/users/jdidion/repos","events_url":"https://api.github.com/users/jdidion/events{/privacy}","received_events_url":"https://api.github.com/users/jdidion/received_events","type":"User","site_admin":false},"body":"I did some performance testing with buffer_size. It can make a difference on performance, but it's really tricky and system specific. For example, using a larger buffer size can make a difference when disk seek time is slow, but with a SSD using a larger buffer size can make performance worse. And when it does make an improvement, it's not very big. So I removed the buffer_size parameter.","created_at":"2016-03-07T16:55:27Z","updated_at":"2016-03-08T13:12:16Z","closed_at":"2016-03-08T13:12:16Z","merged_at":null,"merge_commit_sha":"1886151ddf5471f5c6397261ac5bc89e729f9ae3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marcelm/cutadapt/pulls/187/commits","review_comments_url":"https://api.github.com/repos/marcelm/cutadapt/pulls/187/comments","review_comment_url":"https://api.github.com/repos/marcelm/cutadapt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marcelm/cutadapt/issues/187/comments","statuses_url":"https://api.github.com/repos/marcelm/cutadapt/statuses/06b1eba5ed3132621f681f93721f33a6ec1f24c4","head":{"label":"jdidion:master","ref":"master","sha":"06b1eba5ed3132621f681f93721f33a6ec1f24c4","user":{"login":"jdidion","id":125854,"avatar_url":"https://avatars.githubusercontent.com/u/125854?v=3","gravatar_id":"","url":"https://api.github.com/users/jdidion","html_url":"https://github.com/jdidion","followers_url":"https://api.github.com/users/jdidion/followers","following_url":"https://api.github.com/users/jdidion/following{/other_user}","gists_url":"https://api.github.com/users/jdidion/gists{/gist_id}","starred_url":"https://api.github.com/users/jdidion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdidion/subscriptions","organizations_url":"https://api.github.com/users/jdidion/orgs","repos_url":"https://api.github.com/users/jdidion/repos","events_url":"https://api.github.com/users/jdidion/events{/privacy}","received_events_url":"https://api.github.com/users/jdidion/received_events","type":"User","site_admin":false},"repo":{"id":53338929,"name":"cutadapt","full_name":"jdidion/cutadapt","owner":{"login":"jdidion","id":125854,"avatar_url":"https://avatars.githubusercontent.com/u/125854?v=3","gravatar_id":"","url":"https://api.github.com/users/jdidion","html_url":"https://github.com/jdidion","followers_url":"https://api.github.com/users/jdidion/followers","following_url":"https://api.github.com/users/jdidion/following{/other_user}","gists_url":"https://api.github.com/users/jdidion/gists{/gist_id}","starred_url":"https://api.github.com/users/jdidion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdidion/subscriptions","organizations_url":"https://api.github.com/users/jdidion/orgs","repos_url":"https://api.github.com/users/jdidion/repos","events_url":"https://api.github.com/users/jdidion/events{/privacy}","received_events_url":"https://api.github.com/users/jdidion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdidion/cutadapt","description":"cutadapt removes adapter sequences from sequencing reads","fork":true,"url":"https://api.github.com/repos/jdidion/cutadapt","forks_url":"https://api.github.com/repos/jdidion/cutadapt/forks","keys_url":"https://api.github.com/repos/jdidion/cutadapt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdidion/cutadapt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdidion/cutadapt/teams","hooks_url":"https://api.github.com/repos/jdidion/cutadapt/hooks","issue_events_url":"https://api.github.com/repos/jdidion/cutadapt/issues/events{/number}","events_url":"https://api.github.com/repos/jdidion/cutadapt/events","assignees_url":"https://api.github.com/repos/jdidion/cutadapt/assignees{/user}","branches_url":"https://api.github.com/repos/jdidion/cutadapt/branches{/branch}","tags_url":"https://api.github.com/repos/jdidion/cutadapt/tags","blobs_url":"https://api.github.com/repos/jdidion/cutadapt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdidion/cutadapt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdidion/cutadapt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdidion/cutadapt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdidion/cutadapt/statuses/{sha}","languages_url":"https://api.github.com/repos/jdidion/cutadapt/languages","stargazers_url":"https://api.github.com/repos/jdidion/cutadapt/stargazers","contributors_url":"https://api.github.com/repos/jdidion/cutadapt/contributors","subscribers_url":"https://api.github.com/repos/jdidion/cutadapt/subscribers","subscription_url":"https://api.github.com/repos/jdidion/cutadapt/subscription","commits_url":"https://api.github.com/repos/jdidion/cutadapt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdidion/cutadapt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdidion/cutadapt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdidion/cutadapt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdidion/cutadapt/contents/{+path}","compare_url":"https://api.github.com/repos/jdidion/cutadapt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdidion/cutadapt/merges","archive_url":"https://api.github.com/repos/jdidion/cutadapt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdidion/cutadapt/downloads","issues_url":"https://api.github.com/repos/jdidion/cutadapt/issues{/number}","pulls_url":"https://api.github.com/repos/jdidion/cutadapt/pulls{/number}","milestones_url":"https://api.github.com/repos/jdidion/cutadapt/milestones{/number}","notifications_url":"https://api.github.com/repos/jdidion/cutadapt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdidion/cutadapt/labels{/name}","releases_url":"https://api.github.com/repos/jdidion/cutadapt/releases{/id}","deployments_url":"https://api.github.com/repos/jdidion/cutadapt/deployments","created_at":"2016-03-07T16:07:50Z","updated_at":"2016-03-07T16:07:51Z","pushed_at":"2016-03-07T16:54:34Z","git_url":"git://github.com/jdidion/cutadapt.git","ssh_url":"git@github.com:jdidion/cutadapt.git","clone_url":"https://github.com/jdidion/cutadapt.git","svn_url":"https://github.com/jdidion/cutadapt","homepage":"","size":1412,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marcelm:master","ref":"master","sha":"697f6a051d46436a20dbfd2823cefe22870e1dbd","user":{"login":"marcelm","id":724864,"avatar_url":"https://avatars.githubusercontent.com/u/724864?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelm","html_url":"https://github.com/marcelm","followers_url":"https://api.github.com/users/marcelm/followers","following_url":"https://api.github.com/users/marcelm/following{/other_user}","gists_url":"https://api.github.com/users/marcelm/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelm/subscriptions","organizations_url":"https://api.github.com/users/marcelm/orgs","repos_url":"https://api.github.com/users/marcelm/repos","events_url":"https://api.github.com/users/marcelm/events{/privacy}","received_events_url":"https://api.github.com/users/marcelm/received_events","type":"User","site_admin":false},"repo":{"id":4577614,"name":"cutadapt","full_name":"marcelm/cutadapt","owner":{"login":"marcelm","id":724864,"avatar_url":"https://avatars.githubusercontent.com/u/724864?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelm","html_url":"https://github.com/marcelm","followers_url":"https://api.github.com/users/marcelm/followers","following_url":"https://api.github.com/users/marcelm/following{/other_user}","gists_url":"https://api.github.com/users/marcelm/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelm/subscriptions","organizations_url":"https://api.github.com/users/marcelm/orgs","repos_url":"https://api.github.com/users/marcelm/repos","events_url":"https://api.github.com/users/marcelm/events{/privacy}","received_events_url":"https://api.github.com/users/marcelm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcelm/cutadapt","description":"cutadapt removes adapter sequences from sequencing reads","fork":false,"url":"https://api.github.com/repos/marcelm/cutadapt","forks_url":"https://api.github.com/repos/marcelm/cutadapt/forks","keys_url":"https://api.github.com/repos/marcelm/cutadapt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcelm/cutadapt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcelm/cutadapt/teams","hooks_url":"https://api.github.com/repos/marcelm/cutadapt/hooks","issue_events_url":"https://api.github.com/repos/marcelm/cutadapt/issues/events{/number}","events_url":"https://api.github.com/repos/marcelm/cutadapt/events","assignees_url":"https://api.github.com/repos/marcelm/cutadapt/assignees{/user}","branches_url":"https://api.github.com/repos/marcelm/cutadapt/branches{/branch}","tags_url":"https://api.github.com/repos/marcelm/cutadapt/tags","blobs_url":"https://api.github.com/repos/marcelm/cutadapt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcelm/cutadapt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcelm/cutadapt/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcelm/cutadapt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcelm/cutadapt/statuses/{sha}","languages_url":"https://api.github.com/repos/marcelm/cutadapt/languages","stargazers_url":"https://api.github.com/repos/marcelm/cutadapt/stargazers","contributors_url":"https://api.github.com/repos/marcelm/cutadapt/contributors","subscribers_url":"https://api.github.com/repos/marcelm/cutadapt/subscribers","subscription_url":"https://api.github.com/repos/marcelm/cutadapt/subscription","commits_url":"https://api.github.com/repos/marcelm/cutadapt/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcelm/cutadapt/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcelm/cutadapt/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcelm/cutadapt/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcelm/cutadapt/contents/{+path}","compare_url":"https://api.github.com/repos/marcelm/cutadapt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcelm/cutadapt/merges","archive_url":"https://api.github.com/repos/marcelm/cutadapt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcelm/cutadapt/downloads","issues_url":"https://api.github.com/repos/marcelm/cutadapt/issues{/number}","pulls_url":"https://api.github.com/repos/marcelm/cutadapt/pulls{/number}","milestones_url":"https://api.github.com/repos/marcelm/cutadapt/milestones{/number}","notifications_url":"https://api.github.com/repos/marcelm/cutadapt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcelm/cutadapt/labels{/name}","releases_url":"https://api.github.com/repos/marcelm/cutadapt/releases{/id}","deployments_url":"https://api.github.com/repos/marcelm/cutadapt/deployments","created_at":"2012-06-06T20:26:25Z","updated_at":"2016-02-24T16:05:24Z","pushed_at":"2016-03-08T13:08:39Z","git_url":"git://github.com/marcelm/cutadapt.git","ssh_url":"git@github.com:marcelm/cutadapt.git","clone_url":"https://github.com/marcelm/cutadapt.git","svn_url":"https://github.com/marcelm/cutadapt","homepage":"","size":1656,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":22,"forks":33,"open_issues":22,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marcelm/cutadapt/pulls/187"},"html":{"href":"https://github.com/marcelm/cutadapt/pull/187"},"issue":{"href":"https://api.github.com/repos/marcelm/cutadapt/issues/187"},"comments":{"href":"https://api.github.com/repos/marcelm/cutadapt/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/marcelm/cutadapt/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/marcelm/cutadapt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marcelm/cutadapt/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/marcelm/cutadapt/statuses/06b1eba5ed3132621f681f93721f33a6ec1f24c4"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":8,"additions":92,"deletions":100,"changed_files":5}}