{"action":"created","comment":{"url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/comments/84657379","pull_request_review_id":5418320,"id":84657379,"diff_hunk":"@@ -0,0 +1,34 @@\n+package org.transmartproject.db.dataquery.highdim.rnaseq.transcript\n+\n+import org.transmartproject.db.dataquery.highdim.DeGplInfo\n+\n+class DeRnaseqTranscriptAnnot {\n+\n+    String chromosome\n+    Long start\n+    Long end\n+    String refId\n+    String transcript\n+\n+    static belongsTo = [platform: DeGplInfo]\n+\n+    static mapping = {\n+        table schema: 'deapp'\n+\n+        id generator: \"assigned\"","path":"transmart-core-db/grails-app/domain/org/transmartproject/db/dataquery/highdim/rnaseq/transcript/DeRnaseqTranscriptAnnot.groovy","position":18,"original_position":18,"commit_id":"979fc06db4b51a544b6ea8675dcbd7fdda8b8782","original_commit_id":"979fc06db4b51a544b6ea8675dcbd7fdda8b8782","user":{"login":"gijskant","id":7373499,"avatar_url":"https://avatars.githubusercontent.com/u/7373499?v=3","gravatar_id":"","url":"https://api.github.com/users/gijskant","html_url":"https://github.com/gijskant","followers_url":"https://api.github.com/users/gijskant/followers","following_url":"https://api.github.com/users/gijskant/following{/other_user}","gists_url":"https://api.github.com/users/gijskant/gists{/gist_id}","starred_url":"https://api.github.com/users/gijskant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijskant/subscriptions","organizations_url":"https://api.github.com/users/gijskant/orgs","repos_url":"https://api.github.com/users/gijskant/repos","events_url":"https://api.github.com/users/gijskant/events{/privacy}","received_events_url":"https://api.github.com/users/gijskant/received_events","type":"User","site_admin":false},"body":"I know that this works, because the column naming in `transmart-data` is consistent with the default naming strategy of Hibernate. But to be consistent with the rest of the codebase, I would use explicit mapping of table name and column names.\r\nE.g., adding `column: 'id'` in this case.","created_at":"2016-10-24T10:15:07Z","updated_at":"2016-10-24T10:23:44Z","html_url":"https://github.com/thehyve/transmart-upgrade/pull/19#discussion_r84657379","pull_request_url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/comments/84657379"},"html":{"href":"https://github.com/thehyve/transmart-upgrade/pull/19#discussion_r84657379"},"pull_request":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19","id":90580348,"html_url":"https://github.com/thehyve/transmart-upgrade/pull/19","diff_url":"https://github.com/thehyve/transmart-upgrade/pull/19.diff","patch_url":"https://github.com/thehyve/transmart-upgrade/pull/19.patch","issue_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/19","number":19,"state":"open","locked":false,"title":"Rnaseq","user":{"login":"gijskant","id":7373499,"avatar_url":"https://avatars.githubusercontent.com/u/7373499?v=3","gravatar_id":"","url":"https://api.github.com/users/gijskant","html_url":"https://github.com/gijskant","followers_url":"https://api.github.com/users/gijskant/followers","following_url":"https://api.github.com/users/gijskant/following{/other_user}","gists_url":"https://api.github.com/users/gijskant/gists{/gist_id}","starred_url":"https://api.github.com/users/gijskant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijskant/subscriptions","organizations_url":"https://api.github.com/users/gijskant/orgs","repos_url":"https://api.github.com/users/gijskant/repos","events_url":"https://api.github.com/users/gijskant/events{/privacy}","received_events_url":"https://api.github.com/users/gijskant/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-24T09:51:36Z","updated_at":"2016-10-24T10:23:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"caeb0cfe6dd6b5da6672dcb38dbccd290cee8ece","assignee":{"login":"gijskant","id":7373499,"avatar_url":"https://avatars.githubusercontent.com/u/7373499?v=3","gravatar_id":"","url":"https://api.github.com/users/gijskant","html_url":"https://github.com/gijskant","followers_url":"https://api.github.com/users/gijskant/followers","following_url":"https://api.github.com/users/gijskant/following{/other_user}","gists_url":"https://api.github.com/users/gijskant/gists{/gist_id}","starred_url":"https://api.github.com/users/gijskant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijskant/subscriptions","organizations_url":"https://api.github.com/users/gijskant/orgs","repos_url":"https://api.github.com/users/gijskant/repos","events_url":"https://api.github.com/users/gijskant/events{/privacy}","received_events_url":"https://api.github.com/users/gijskant/received_events","type":"User","site_admin":false},"assignees":[{"login":"gijskant","id":7373499,"avatar_url":"https://avatars.githubusercontent.com/u/7373499?v=3","gravatar_id":"","url":"https://api.github.com/users/gijskant","html_url":"https://github.com/gijskant","followers_url":"https://api.github.com/users/gijskant/followers","following_url":"https://api.github.com/users/gijskant/following{/other_user}","gists_url":"https://api.github.com/users/gijskant/gists{/gist_id}","starred_url":"https://api.github.com/users/gijskant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijskant/subscriptions","organizations_url":"https://api.github.com/users/gijskant/orgs","repos_url":"https://api.github.com/users/gijskant/repos","events_url":"https://api.github.com/users/gijskant/events{/privacy}","received_events_url":"https://api.github.com/users/gijskant/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19/commits","review_comments_url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19/comments","review_comment_url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/19/comments","statuses_url":"https://api.github.com/repos/thehyve/transmart-upgrade/statuses/979fc06db4b51a544b6ea8675dcbd7fdda8b8782","head":{"label":"thehyve:rnaseq","ref":"rnaseq","sha":"979fc06db4b51a544b6ea8675dcbd7fdda8b8782","user":{"login":"thehyve","id":1502440,"avatar_url":"https://avatars.githubusercontent.com/u/1502440?v=3","gravatar_id":"","url":"https://api.github.com/users/thehyve","html_url":"https://github.com/thehyve","followers_url":"https://api.github.com/users/thehyve/followers","following_url":"https://api.github.com/users/thehyve/following{/other_user}","gists_url":"https://api.github.com/users/thehyve/gists{/gist_id}","starred_url":"https://api.github.com/users/thehyve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehyve/subscriptions","organizations_url":"https://api.github.com/users/thehyve/orgs","repos_url":"https://api.github.com/users/thehyve/repos","events_url":"https://api.github.com/users/thehyve/events{/privacy}","received_events_url":"https://api.github.com/users/thehyve/received_events","type":"Organization","site_admin":false},"repo":{"id":66083886,"name":"transmart-upgrade","full_name":"thehyve/transmart-upgrade","owner":{"login":"thehyve","id":1502440,"avatar_url":"https://avatars.githubusercontent.com/u/1502440?v=3","gravatar_id":"","url":"https://api.github.com/users/thehyve","html_url":"https://github.com/thehyve","followers_url":"https://api.github.com/users/thehyve/followers","following_url":"https://api.github.com/users/thehyve/following{/other_user}","gists_url":"https://api.github.com/users/thehyve/gists{/gist_id}","starred_url":"https://api.github.com/users/thehyve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehyve/subscriptions","organizations_url":"https://api.github.com/users/thehyve/orgs","repos_url":"https://api.github.com/users/thehyve/repos","events_url":"https://api.github.com/users/thehyve/events{/privacy}","received_events_url":"https://api.github.com/users/thehyve/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thehyve/transmart-upgrade","description":"Temporary repo for sharing work on transmart upgrade to grails 3.1.10","fork":false,"url":"https://api.github.com/repos/thehyve/transmart-upgrade","forks_url":"https://api.github.com/repos/thehyve/transmart-upgrade/forks","keys_url":"https://api.github.com/repos/thehyve/transmart-upgrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thehyve/transmart-upgrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thehyve/transmart-upgrade/teams","hooks_url":"https://api.github.com/repos/thehyve/transmart-upgrade/hooks","issue_events_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/events{/number}","events_url":"https://api.github.com/repos/thehyve/transmart-upgrade/events","assignees_url":"https://api.github.com/repos/thehyve/transmart-upgrade/assignees{/user}","branches_url":"https://api.github.com/repos/thehyve/transmart-upgrade/branches{/branch}","tags_url":"https://api.github.com/repos/thehyve/transmart-upgrade/tags","blobs_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thehyve/transmart-upgrade/statuses/{sha}","languages_url":"https://api.github.com/repos/thehyve/transmart-upgrade/languages","stargazers_url":"https://api.github.com/repos/thehyve/transmart-upgrade/stargazers","contributors_url":"https://api.github.com/repos/thehyve/transmart-upgrade/contributors","subscribers_url":"https://api.github.com/repos/thehyve/transmart-upgrade/subscribers","subscription_url":"https://api.github.com/repos/thehyve/transmart-upgrade/subscription","commits_url":"https://api.github.com/repos/thehyve/transmart-upgrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/thehyve/transmart-upgrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/thehyve/transmart-upgrade/contents/{+path}","compare_url":"https://api.github.com/repos/thehyve/transmart-upgrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thehyve/transmart-upgrade/merges","archive_url":"https://api.github.com/repos/thehyve/transmart-upgrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thehyve/transmart-upgrade/downloads","issues_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues{/number}","pulls_url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls{/number}","milestones_url":"https://api.github.com/repos/thehyve/transmart-upgrade/milestones{/number}","notifications_url":"https://api.github.com/repos/thehyve/transmart-upgrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thehyve/transmart-upgrade/labels{/name}","releases_url":"https://api.github.com/repos/thehyve/transmart-upgrade/releases{/id}","deployments_url":"https://api.github.com/repos/thehyve/transmart-upgrade/deployments","created_at":"2016-08-19T13:21:47Z","updated_at":"2016-10-24T08:34:42Z","pushed_at":"2016-10-24T09:51:36Z","git_url":"git://github.com/thehyve/transmart-upgrade.git","ssh_url":"git@github.com:thehyve/transmart-upgrade.git","clone_url":"https://github.com/thehyve/transmart-upgrade.git","svn_url":"https://github.com/thehyve/transmart-upgrade","homepage":null,"size":78759,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"thehyve:master","ref":"master","sha":"3de4e84862d23626296880780aea32477251c58e","user":{"login":"thehyve","id":1502440,"avatar_url":"https://avatars.githubusercontent.com/u/1502440?v=3","gravatar_id":"","url":"https://api.github.com/users/thehyve","html_url":"https://github.com/thehyve","followers_url":"https://api.github.com/users/thehyve/followers","following_url":"https://api.github.com/users/thehyve/following{/other_user}","gists_url":"https://api.github.com/users/thehyve/gists{/gist_id}","starred_url":"https://api.github.com/users/thehyve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehyve/subscriptions","organizations_url":"https://api.github.com/users/thehyve/orgs","repos_url":"https://api.github.com/users/thehyve/repos","events_url":"https://api.github.com/users/thehyve/events{/privacy}","received_events_url":"https://api.github.com/users/thehyve/received_events","type":"Organization","site_admin":false},"repo":{"id":66083886,"name":"transmart-upgrade","full_name":"thehyve/transmart-upgrade","owner":{"login":"thehyve","id":1502440,"avatar_url":"https://avatars.githubusercontent.com/u/1502440?v=3","gravatar_id":"","url":"https://api.github.com/users/thehyve","html_url":"https://github.com/thehyve","followers_url":"https://api.github.com/users/thehyve/followers","following_url":"https://api.github.com/users/thehyve/following{/other_user}","gists_url":"https://api.github.com/users/thehyve/gists{/gist_id}","starred_url":"https://api.github.com/users/thehyve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehyve/subscriptions","organizations_url":"https://api.github.com/users/thehyve/orgs","repos_url":"https://api.github.com/users/thehyve/repos","events_url":"https://api.github.com/users/thehyve/events{/privacy}","received_events_url":"https://api.github.com/users/thehyve/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thehyve/transmart-upgrade","description":"Temporary repo for sharing work on transmart upgrade to grails 3.1.10","fork":false,"url":"https://api.github.com/repos/thehyve/transmart-upgrade","forks_url":"https://api.github.com/repos/thehyve/transmart-upgrade/forks","keys_url":"https://api.github.com/repos/thehyve/transmart-upgrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thehyve/transmart-upgrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thehyve/transmart-upgrade/teams","hooks_url":"https://api.github.com/repos/thehyve/transmart-upgrade/hooks","issue_events_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/events{/number}","events_url":"https://api.github.com/repos/thehyve/transmart-upgrade/events","assignees_url":"https://api.github.com/repos/thehyve/transmart-upgrade/assignees{/user}","branches_url":"https://api.github.com/repos/thehyve/transmart-upgrade/branches{/branch}","tags_url":"https://api.github.com/repos/thehyve/transmart-upgrade/tags","blobs_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thehyve/transmart-upgrade/statuses/{sha}","languages_url":"https://api.github.com/repos/thehyve/transmart-upgrade/languages","stargazers_url":"https://api.github.com/repos/thehyve/transmart-upgrade/stargazers","contributors_url":"https://api.github.com/repos/thehyve/transmart-upgrade/contributors","subscribers_url":"https://api.github.com/repos/thehyve/transmart-upgrade/subscribers","subscription_url":"https://api.github.com/repos/thehyve/transmart-upgrade/subscription","commits_url":"https://api.github.com/repos/thehyve/transmart-upgrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/thehyve/transmart-upgrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/thehyve/transmart-upgrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/thehyve/transmart-upgrade/contents/{+path}","compare_url":"https://api.github.com/repos/thehyve/transmart-upgrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thehyve/transmart-upgrade/merges","archive_url":"https://api.github.com/repos/thehyve/transmart-upgrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thehyve/transmart-upgrade/downloads","issues_url":"https://api.github.com/repos/thehyve/transmart-upgrade/issues{/number}","pulls_url":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls{/number}","milestones_url":"https://api.github.com/repos/thehyve/transmart-upgrade/milestones{/number}","notifications_url":"https://api.github.com/repos/thehyve/transmart-upgrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thehyve/transmart-upgrade/labels{/name}","releases_url":"https://api.github.com/repos/thehyve/transmart-upgrade/releases{/id}","deployments_url":"https://api.github.com/repos/thehyve/transmart-upgrade/deployments","created_at":"2016-08-19T13:21:47Z","updated_at":"2016-10-24T08:34:42Z","pushed_at":"2016-10-24T09:51:36Z","git_url":"git://github.com/thehyve/transmart-upgrade.git","ssh_url":"git@github.com:thehyve/transmart-upgrade.git","clone_url":"https://github.com/thehyve/transmart-upgrade.git","svn_url":"https://github.com/thehyve/transmart-upgrade","homepage":null,"size":78759,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19"},"html":{"href":"https://github.com/thehyve/transmart-upgrade/pull/19"},"issue":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/19"},"comments":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/thehyve/transmart-upgrade/statuses/979fc06db4b51a544b6ea8675dcbd7fdda8b8782"}}}}
{"actor":{"display_login":"gijskant"}}