{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/94198032","pull_request_review_id":14729101,"id":94198032,"diff_hunk":"@@ -269,22 +269,14 @@ end\n @inline broadcast_elwise_op(f, As...) =\n     broadcast!(f, similar(Array{promote_eltype_op(f, As...)}, broadcast_indices(As...)), As...)\n \n-ftype(f, A) = typeof(f)\n-ftype(f, A...) = typeof(a -> f(a...))\n-ftype(T::Type, A...) = Type{T}\n-typestuple(a) = (Base.@_pure_meta; Tuple{eltype(a)})\n-typestuple(T::Type) = (Base.@_pure_meta; Tuple{Type{T}})\n-typestuple(a, b...) = (Base.@_pure_meta; Tuple{typestuple(a).types..., typestuple(b...).types...})\n-ziptype(A) = typestuple(A)\n-ziptype(A, B) = (Base.@_pure_meta; Iterators.Zip2{typestuple(A), typestuple(B)})\n-@inline ziptype(A, B, C, D...) = Iterators.Zip{typestuple(A), ziptype(B, C, D...)}\n-\n-_broadcast_type(f, T::Type, As...) = Base._return_type(f, typestuple(T, As...))\n-_broadcast_type(f, A, Bs...) = Base._default_eltype(Base.Generator{ziptype(A, Bs...), ftype(f, A, Bs...)})\n+eltypestuple(a) = (Base.@_pure_meta; Tuple{eltype(a)})","path":"base/broadcast.jl","position":16,"original_position":16,"commit_id":"b78c9af91b2a26a4ce903764f3e5a94294b7764c","original_commit_id":"b78c9af91b2a26a4ce903764f3e5a94294b7764c","user":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"body":"Sounds like a good plan! Agreed another PR might be better. Perhaps we can chat about cleaning up these mechanisms after feature freeze? Thanks again!","created_at":"2016-12-30T02:14:46Z","updated_at":"2016-12-30T02:14:46Z","html_url":"https://github.com/JuliaLang/julia/pull/19723#discussion_r94198032","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19723","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/94198032"},"html":{"href":"https://github.com/JuliaLang/julia/pull/19723#discussion_r94198032"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19723"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/19723","id":99331500,"html_url":"https://github.com/JuliaLang/julia/pull/19723","diff_url":"https://github.com/JuliaLang/julia/pull/19723.diff","patch_url":"https://github.com/JuliaLang/julia/pull/19723.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/19723","number":19723,"state":"open","locked":false,"title":"Simplify and extend broadcast eltype promotion mechanism","user":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"body":"(Requires #19667.) This pull request restores the simplification of `broadcast`'s eltype promotion mechanism in #19421. With benefit of #19667 (thanks `@yuyichao`!), that simplification handles more cases (e.g. closures accepting more than two arguments) than the present mechanism (`_default_eltype`-`first`-`Generator`-`zip`). This pull request also gives `broadcast`'s eltype promotion mechanism a more precise name (`_broadcast_type` -> `_broadcast_eltype`). Best!\r\n","created_at":"2016-12-25T23:43:20Z","updated_at":"2016-12-30T02:14:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f9a7a0dd0672642f4508cf07ff0a991b46ee996","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/20","html_url":"https://github.com/JuliaLang/julia/milestone/20","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/20/labels","id":1298021,"number":20,"title":"0.6.0","description":"","creator":{"login":"JeffBezanson","id":744556,"avatar_url":"https://avatars.githubusercontent.com/u/744556?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffBezanson","html_url":"https://github.com/JeffBezanson","followers_url":"https://api.github.com/users/JeffBezanson/followers","following_url":"https://api.github.com/users/JeffBezanson/following{/other_user}","gists_url":"https://api.github.com/users/JeffBezanson/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffBezanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffBezanson/subscriptions","organizations_url":"https://api.github.com/users/JeffBezanson/orgs","repos_url":"https://api.github.com/users/JeffBezanson/repos","events_url":"https://api.github.com/users/JeffBezanson/events{/privacy}","received_events_url":"https://api.github.com/users/JeffBezanson/received_events","type":"User","site_admin":false},"open_issues":96,"closed_issues":94,"state":"open","created_at":"2015-09-09T16:35:16Z","updated_at":"2016-12-30T01:06:20Z","due_on":"2017-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19723/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/19723/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/19723/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/b78c9af91b2a26a4ce903764f3e5a94294b7764c","head":{"label":"Sacha0:bceltype","ref":"bceltype","sha":"b78c9af91b2a26a4ce903764f3e5a94294b7764c","user":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"repo":{"id":46197044,"name":"julia","full_name":"Sacha0/julia","owner":{"login":"Sacha0","id":5799177,"avatar_url":"https://avatars.githubusercontent.com/u/5799177?v=3","gravatar_id":"","url":"https://api.github.com/users/Sacha0","html_url":"https://github.com/Sacha0","followers_url":"https://api.github.com/users/Sacha0/followers","following_url":"https://api.github.com/users/Sacha0/following{/other_user}","gists_url":"https://api.github.com/users/Sacha0/gists{/gist_id}","starred_url":"https://api.github.com/users/Sacha0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sacha0/subscriptions","organizations_url":"https://api.github.com/users/Sacha0/orgs","repos_url":"https://api.github.com/users/Sacha0/repos","events_url":"https://api.github.com/users/Sacha0/events{/privacy}","received_events_url":"https://api.github.com/users/Sacha0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sacha0/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/Sacha0/julia","forks_url":"https://api.github.com/repos/Sacha0/julia/forks","keys_url":"https://api.github.com/repos/Sacha0/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sacha0/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sacha0/julia/teams","hooks_url":"https://api.github.com/repos/Sacha0/julia/hooks","issue_events_url":"https://api.github.com/repos/Sacha0/julia/issues/events{/number}","events_url":"https://api.github.com/repos/Sacha0/julia/events","assignees_url":"https://api.github.com/repos/Sacha0/julia/assignees{/user}","branches_url":"https://api.github.com/repos/Sacha0/julia/branches{/branch}","tags_url":"https://api.github.com/repos/Sacha0/julia/tags","blobs_url":"https://api.github.com/repos/Sacha0/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sacha0/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sacha0/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sacha0/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sacha0/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/Sacha0/julia/languages","stargazers_url":"https://api.github.com/repos/Sacha0/julia/stargazers","contributors_url":"https://api.github.com/repos/Sacha0/julia/contributors","subscribers_url":"https://api.github.com/repos/Sacha0/julia/subscribers","subscription_url":"https://api.github.com/repos/Sacha0/julia/subscription","commits_url":"https://api.github.com/repos/Sacha0/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sacha0/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sacha0/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sacha0/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sacha0/julia/contents/{+path}","compare_url":"https://api.github.com/repos/Sacha0/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sacha0/julia/merges","archive_url":"https://api.github.com/repos/Sacha0/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sacha0/julia/downloads","issues_url":"https://api.github.com/repos/Sacha0/julia/issues{/number}","pulls_url":"https://api.github.com/repos/Sacha0/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/Sacha0/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/Sacha0/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sacha0/julia/labels{/name}","releases_url":"https://api.github.com/repos/Sacha0/julia/releases{/id}","deployments_url":"https://api.github.com/repos/Sacha0/julia/deployments","created_at":"2015-11-14T23:50:27Z","updated_at":"2015-11-14T23:50:41Z","pushed_at":"2016-12-27T22:25:41Z","git_url":"git://github.com/Sacha0/julia.git","ssh_url":"git@github.com:Sacha0/julia.git","clone_url":"https://github.com/Sacha0/julia.git","svn_url":"https://github.com/Sacha0/julia","homepage":"http://julialang.org/","size":101977,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"4793e88185573387a514e3e40ca14128d4920886","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2016-12-29T22:56:52Z","pushed_at":"2016-12-30T00:42:50Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":117999,"stargazers_count":7956,"watchers_count":7956,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1869,"mirror_url":null,"open_issues_count":2236,"forks":1869,"open_issues":2236,"watchers":7956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19723"},"html":{"href":"https://github.com/JuliaLang/julia/pull/19723"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/19723"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/19723/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19723/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/19723/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/b78c9af91b2a26a4ce903764f3e5a94294b7764c"}}}}
{"actor":{"display_login":"Sacha0"}}