{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/68171892","id":68171892,"diff_hunk":"@@ -20,7 +20,7 @@ function main(conf) {\n   const len = +conf.len;\n \n   const msg = '\"' + Array(len).join('.') + '\"';\n-  const options = { 'stdio': ['ignore', 'pipe', 'ignore'] };\n+  const options = {'stdio': ['ignore', 'ipc', 'ignore']};","path":"benchmark/child_process/child-process-read.js","position":14,"original_position":14,"commit_id":"853da0619303a45abd1720f894a0ee7901bafce8","original_commit_id":"853da0619303a45abd1720f894a0ee7901bafce8","user":{"login":"mscdex","id":54666,"avatar_url":"https://avatars.githubusercontent.com/u/54666?v=3","gravatar_id":"","url":"https://api.github.com/users/mscdex","html_url":"https://github.com/mscdex","followers_url":"https://api.github.com/users/mscdex/followers","following_url":"https://api.github.com/users/mscdex/following{/other_user}","gists_url":"https://api.github.com/users/mscdex/gists{/gist_id}","starred_url":"https://api.github.com/users/mscdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscdex/subscriptions","organizations_url":"https://api.github.com/users/mscdex/orgs","repos_url":"https://api.github.com/users/mscdex/repos","events_url":"https://api.github.com/users/mscdex/events{/privacy}","received_events_url":"https://api.github.com/users/mscdex/received_events","type":"User","site_admin":false},"body":"Why this change?","created_at":"2016-06-23T03:44:54Z","updated_at":"2016-06-23T03:44:54Z","html_url":"https://github.com/nodejs/node/pull/7381#discussion_r68171892","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/7381","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/68171892"},"html":{"href":"https://github.com/nodejs/node/pull/7381#discussion_r68171892"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/7381"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7381","id":74888918,"html_url":"https://github.com/nodejs/node/pull/7381","diff_url":"https://github.com/nodejs/node/pull/7381.diff","patch_url":"https://github.com/nodejs/node/pull/7381.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7381","number":7381,"state":"open","locked":false,"title":"child_process: measure buffer length in bytes","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes\r\n- [x] a test and/or benchmark is included\r\n- [ ] documentation is changed or added\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\nchild_process\r\n\r\n##### Description of change\r\n<!-- provide a description of the change below this comment -->\r\n\r\nThis re-implements a previous fix that had to be reverted. The fix is to measure the `maxBuffer` option of `child_process.exec()` in bytes (per the documentation and user expectations) and not characters.\r\n\r\nUnfortunately, the fix had a side effect such the `child.stdout` and `child.stderr` `data` events sent their callbacks buffers by default rather than strings. This is undocumented but fully exposed and caused bugs in userland (e.g., https://github.com/tes/bosco/issues/152).\r\n\r\nThis PR depends on https://github.com/nodejs/node/pull/7377. It re-implements the change, but this time it is marked `semver-major` and tests are added to confirm the behavior change.","created_at":"2016-06-23T02:53:02Z","updated_at":"2016-06-23T03:44:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2d12d78b4b0d82f65a927ad7f07cf3d7b74ca47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7381/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7381/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7381/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/853da0619303a45abd1720f894a0ee7901bafce8","head":{"label":"Trott:major-general","ref":"major-general","sha":"853da0619303a45abd1720f894a0ee7901bafce8","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"repo":{"id":35707182,"name":"io.js","full_name":"Trott/io.js","owner":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Trott/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/Trott/io.js","forks_url":"https://api.github.com/repos/Trott/io.js/forks","keys_url":"https://api.github.com/repos/Trott/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trott/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trott/io.js/teams","hooks_url":"https://api.github.com/repos/Trott/io.js/hooks","issue_events_url":"https://api.github.com/repos/Trott/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/Trott/io.js/events","assignees_url":"https://api.github.com/repos/Trott/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/Trott/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/Trott/io.js/tags","blobs_url":"https://api.github.com/repos/Trott/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trott/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trott/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trott/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trott/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Trott/io.js/languages","stargazers_url":"https://api.github.com/repos/Trott/io.js/stargazers","contributors_url":"https://api.github.com/repos/Trott/io.js/contributors","subscribers_url":"https://api.github.com/repos/Trott/io.js/subscribers","subscription_url":"https://api.github.com/repos/Trott/io.js/subscription","commits_url":"https://api.github.com/repos/Trott/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trott/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trott/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trott/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trott/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/Trott/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trott/io.js/merges","archive_url":"https://api.github.com/repos/Trott/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trott/io.js/downloads","issues_url":"https://api.github.com/repos/Trott/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/Trott/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Trott/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Trott/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trott/io.js/labels{/name}","releases_url":"https://api.github.com/repos/Trott/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/Trott/io.js/deployments","created_at":"2015-05-16T02:50:59Z","updated_at":"2016-01-11T17:20:02Z","pushed_at":"2016-06-23T02:04:31Z","git_url":"git://github.com/Trott/io.js.git","ssh_url":"git@github.com:Trott/io.js.git","clone_url":"https://github.com/Trott/io.js.git","svn_url":"https://github.com/Trott/io.js","homepage":"https://iojs.org","size":215879,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c2e6078ed95cea135da8ebe4ef5a807e0bd0bbe2","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-06-23T03:30:42Z","pushed_at":"2016-06-23T02:53:03Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":283122,"stargazers_count":24253,"watchers_count":24253,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3568,"mirror_url":null,"open_issues_count":706,"forks":3568,"open_issues":706,"watchers":24253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7381"},"html":{"href":"https://github.com/nodejs/node/pull/7381"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7381"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7381/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7381/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7381/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/853da0619303a45abd1720f894a0ee7901bafce8"}}}}
{"actor":{"display_login":"mscdex"}}