{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/13856","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/13856/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/13856/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/13856/events","html_url":"https://github.com/pandas-dev/pandas/pull/13856","id":168517937,"number":13856,"title":"[WIP] TST: Use pytest","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars.githubusercontent.com/u/1312546?v=3","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"labels":[{"id":48070600,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/CI","name":"CI","color":"a2bca7","default":false},{"id":127685,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Testing","name":"Testing","color":"C4A000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/39","html_url":"https://github.com/pandas-dev/pandas/milestones/0.20.0","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/39/labels","id":1570595,"number":39,"title":"0.20.0","description":"after 0.19.x series","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":154,"closed_issues":19,"state":"open","created_at":"2016-02-08T15:30:21Z","updated_at":"2016-11-11T12:53:01Z","due_on":"2016-12-30T23:00:00Z","closed_at":null},"comments":7,"created_at":"2016-07-31T13:32:45Z","updated_at":"2016-11-11T13:06:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/13856","html_url":"https://github.com/pandas-dev/pandas/pull/13856","diff_url":"https://github.com/pandas-dev/pandas/pull/13856.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/13856.patch"},"body":"- [x] closes https://github.com/pydata/pandas/issues/13097\n- [ ] tests added / passed\n- [x] passes `git diff upstream/master | flake8 --diff`\n- [ ] whatsnew entry\n\nJust a WIP for now, will need to iterate on the CI stuff to ensure that's all good.\n\nWhat can I provide to make this easier to review? Refactoring tests is scary.\nI'll give verbose outputs of nose on master and pytest on this branch.\njunit.xml output too. Anything else?\n\nHere are some notes I took along the way\n### Kinds of Changes\n- Nosetests Generators to fixtures\n\nSee TestPickle, TestMsgPack and [this](http://stackoverflow.com/questions/6689537/nose-test-generators-inside-class) SO post. We switched to using parametrized fixtures (yay) and dependency injection instead of setUp + a for loop inside the test.\n- Different Discover Rules\n\nSee the sql tests. `py.test` discovers `_Test*` class (if they inherit from `TestCase`?), while unittest does not.\nSolution: move TestCase inheritance down a level\n- Assert Rewriting\n\nSee e.g. pandas/src/testing.py\n- solution: rewrite `assert cond, msg` as `if not cond; raise AssertionError(msg)`\n- looking into just excluding these files... They aren't actual tests, just test helpers.\n- CI work:\n  - updating nose to pytest\n"},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/259953413","html_url":"https://github.com/pandas-dev/pandas/pull/13856#issuecomment-259953413","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/13856","id":259953413,"user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars.githubusercontent.com/u/1312546?v=3","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T13:06:43Z","updated_at":"2016-11-11T13:06:43Z","body":"@jreback pretty close I think. The only ones I'm stumped on are the `read_stata` errors. You can see the failures in the last build [here](https://travis-ci.org/pandas-dev/pandas/jobs/174350589#L937), [This build](https://travis-ci.org/pandas-dev/pandas/jobs/173227412#L1080) from pre-segfaults has the tracebacks. I haven't been able to reproduce locally.\r\n\r\nOther than that, I just have a bit of cleanup and verification that we didn't drop any tests. I'll do that tonight and on Sunday, hopefully get the merged soon. And the `pd.test` issue."}}
{"actor":{"display_login":"TomAugspurger"}}