{"action":"created","issue":{"url":"https://api.github.com/repos/Teradata/presto/issues/292","repository_url":"https://api.github.com/repos/Teradata/presto","labels_url":"https://api.github.com/repos/Teradata/presto/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/Teradata/presto/issues/292/comments","events_url":"https://api.github.com/repos/Teradata/presto/issues/292/events","html_url":"https://github.com/Teradata/presto/pull/292","id":169613645,"number":292,"title":"Add product tests for access control checks","user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Teradata/presto/labels/changes-requested","name":"changes-requested","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"assignees":[{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-08-05T13:59:44Z","updated_at":"2016-08-23T21:10:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Teradata/presto/pulls/292","html_url":"https://github.com/Teradata/presto/pull/292","diff_url":"https://github.com/Teradata/presto/pull/292.diff","patch_url":"https://github.com/Teradata/presto/pull/292.patch"},"body":"This PR adds product tests for access control checks that are turned on when `hive.security=sql-standard` is set in `hive.properties` file. The table below shows the list of SQL commands for which Presto adds access control checks (defined in `presto-hive/src/main/java/com/facebook/presto/hive/SqlStandardAccessControl.java`) and the privileges required to execute these commands when the above Hive property is turned on. I have written product tests for each of these commands. \r\n\r\nPresto Command | Required Privileges\r\n-------------------- | ---------------------- \r\nALTER TABLE\t| OWNERSHIP\r\nCREATE TABLE AS | OWNERSHIP OF DATABASE + SELECT ON INPUT TABLE\r\nCREATE VIEW AS | SELECT WITH GRANT OPTION\r\nDELETE | DELETE\r\nDROP TABLE | OWNERSHIP\r\nDROP VIEW | OWNERSHIP\r\nINSERT | \tINSERT\r\nSELECT | SELECT"},"comment":{"url":"https://api.github.com/repos/Teradata/presto/issues/comments/241879636","html_url":"https://github.com/Teradata/presto/pull/292#issuecomment-241879636","issue_url":"https://api.github.com/repos/Teradata/presto/issues/292","id":241879636,"user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T21:10:12Z","updated_at":"2016-08-23T21:10:12Z","body":"@kokosing I have addressed your comments. Please have a look. Also, I am not sure if we can capture these as unit tests. We want to test end-to-end scenarios where a user tries to execute certain operations with and without having sufficient privileges."}}
{"actor":{"display_login":"amrutagokhale"}}