{"action":"created","issue":{"url":"https://api.github.com/repos/noelboss/featherlight/issues/260","repository_url":"https://api.github.com/repos/noelboss/featherlight","labels_url":"https://api.github.com/repos/noelboss/featherlight/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/noelboss/featherlight/issues/260/comments","events_url":"https://api.github.com/repos/noelboss/featherlight/issues/260/events","html_url":"https://github.com/noelboss/featherlight/issues/260","id":189535915,"number":260,"title":"Close button should be <button>, have accessible text.","user":{"login":"mrwweb","id":1238696,"avatar_url":"https://avatars.githubusercontent.com/u/1238696?v=3","gravatar_id":"","url":"https://api.github.com/users/mrwweb","html_url":"https://github.com/mrwweb","followers_url":"https://api.github.com/users/mrwweb/followers","following_url":"https://api.github.com/users/mrwweb/following{/other_user}","gists_url":"https://api.github.com/users/mrwweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwweb/subscriptions","organizations_url":"https://api.github.com/users/mrwweb/orgs","repos_url":"https://api.github.com/users/mrwweb/repos","events_url":"https://api.github.com/users/mrwweb/events{/privacy}","received_events_url":"https://api.github.com/users/mrwweb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-15T23:19:26Z","updated_at":"2016-11-16T19:59:04Z","closed_at":null,"body":"At present, the close button is just a `<span>`, so it can't have focus and therefore can't be navigated to with a keyboard. It should be made with a focusable element, probably a `<button>`. Further, that button needs a text label of some form. That could be done either with a span with class screen-reader-text or an aria-label attribute.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/noelboss/featherlight/issues/comments/261054592","html_url":"https://github.com/noelboss/featherlight/issues/260#issuecomment-261054592","issue_url":"https://api.github.com/repos/noelboss/featherlight/issues/260","id":261054592,"user":{"login":"mrwweb","id":1238696,"avatar_url":"https://avatars.githubusercontent.com/u/1238696?v=3","gravatar_id":"","url":"https://api.github.com/users/mrwweb","html_url":"https://github.com/mrwweb","followers_url":"https://api.github.com/users/mrwweb/followers","following_url":"https://api.github.com/users/mrwweb/following{/other_user}","gists_url":"https://api.github.com/users/mrwweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwweb/subscriptions","organizations_url":"https://api.github.com/users/mrwweb/orgs","repos_url":"https://api.github.com/users/mrwweb/repos","events_url":"https://api.github.com/users/mrwweb/events{/privacy}","received_events_url":"https://api.github.com/users/mrwweb/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T19:59:04Z","updated_at":"2016-11-16T19:59:04Z","body":"The general a11y rule is to use links for things that go to other pages (or page-like things) and buttons for actions. Therefore, a button is the preferable element."}}
{"actor":{"display_login":"mrwweb"}}