{"action":"created","comment":{"url":"https://api.github.com/repos/ruma/ruma/pulls/comments/83830833","pull_request_review_id":4647233,"id":83830833,"diff_hunk":"@@ -1,12 +1,20 @@\n //! Endpoints for joining rooms.","path":"src/api/r0/join.rs","position":1,"original_position":1,"commit_id":"650811c3c09284f134a8b2aa9fe2387b585d04f2","original_commit_id":"0bcceec9bed88b26ee0500b1483a73098ca0c850","user":{"login":"mujx","id":6430350,"avatar_url":"https://avatars.githubusercontent.com/u/6430350?v=3","gravatar_id":"","url":"https://api.github.com/users/mujx","html_url":"https://github.com/mujx","followers_url":"https://api.github.com/users/mujx/followers","following_url":"https://api.github.com/users/mujx/following{/other_user}","gists_url":"https://api.github.com/users/mujx/gists{/gist_id}","starred_url":"https://api.github.com/users/mujx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mujx/subscriptions","organizations_url":"https://api.github.com/users/mujx/orgs","repos_url":"https://api.github.com/users/mujx/repos","events_url":"https://api.github.com/users/mujx/events{/privacy}","received_events_url":"https://api.github.com/users/mujx/received_events","type":"User","site_admin":false},"body":"Seems reasonable. Maybe after #99.","created_at":"2016-10-18T11:12:57Z","updated_at":"2016-10-18T11:12:57Z","html_url":"https://github.com/ruma/ruma/pull/104#discussion_r83830833","pull_request_url":"https://api.github.com/repos/ruma/ruma/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/ruma/ruma/pulls/comments/83830833"},"html":{"href":"https://github.com/ruma/ruma/pull/104#discussion_r83830833"},"pull_request":{"href":"https://api.github.com/repos/ruma/ruma/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/ruma/ruma/pulls/104","id":89053443,"html_url":"https://github.com/ruma/ruma/pull/104","diff_url":"https://github.com/ruma/ruma/pull/104.diff","patch_url":"https://github.com/ruma/ruma/pull/104.patch","issue_url":"https://api.github.com/repos/ruma/ruma/issues/104","number":104,"state":"open","locked":false,"title":"Add basic implementation for local invites","user":{"login":"mujx","id":6430350,"avatar_url":"https://avatars.githubusercontent.com/u/6430350?v=3","gravatar_id":"","url":"https://api.github.com/users/mujx","html_url":"https://github.com/mujx","followers_url":"https://api.github.com/users/mujx/followers","following_url":"https://api.github.com/users/mujx/following{/other_user}","gists_url":"https://api.github.com/users/mujx/gists{/gist_id}","starred_url":"https://api.github.com/users/mujx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mujx/subscriptions","organizations_url":"https://api.github.com/users/mujx/orgs","repos_url":"https://api.github.com/users/mujx/repos","events_url":"https://api.github.com/users/mujx/events{/privacy}","received_events_url":"https://api.github.com/users/mujx/received_events","type":"User","site_admin":false},"body":"- Fixed a bug on `RoomMembership::create` where only memberships\r\n  with the same user_id and sender could be created, on invite-only rooms.\r\n\r\n- The `Join` endpoint was refactored to update an existing `RoomMembership`\r\n  (e.g join after an invite).\r\n\r\n- A new `MemberEvent` is created when a `RoomMembership` update occurs.\r\n\r\n- `RoomMemberships` for invited users are created when a new room is created.\r\n\r\n- Removed duplicated `MemberEvent` generation from Room into its own\r\n  function in `RoomMembership`.\r\n\r\nMost of the changes occurred while implementing the invite endpoint, so I included\r\nthem in this PR. \r\n\r\nApparently diesel needs an `id` field when you derive the `Identifiable` trait. Let me know \r\nif there is a workaround.","created_at":"2016-10-12T16:56:22Z","updated_at":"2016-10-18T11:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"137690bc20b81e96cd15f18041402189ea998ab8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruma/ruma/pulls/104/commits","review_comments_url":"https://api.github.com/repos/ruma/ruma/pulls/104/comments","review_comment_url":"https://api.github.com/repos/ruma/ruma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruma/ruma/issues/104/comments","statuses_url":"https://api.github.com/repos/ruma/ruma/statuses/650811c3c09284f134a8b2aa9fe2387b585d04f2","head":{"label":"mujx:invite","ref":"invite","sha":"650811c3c09284f134a8b2aa9fe2387b585d04f2","user":{"login":"mujx","id":6430350,"avatar_url":"https://avatars.githubusercontent.com/u/6430350?v=3","gravatar_id":"","url":"https://api.github.com/users/mujx","html_url":"https://github.com/mujx","followers_url":"https://api.github.com/users/mujx/followers","following_url":"https://api.github.com/users/mujx/following{/other_user}","gists_url":"https://api.github.com/users/mujx/gists{/gist_id}","starred_url":"https://api.github.com/users/mujx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mujx/subscriptions","organizations_url":"https://api.github.com/users/mujx/orgs","repos_url":"https://api.github.com/users/mujx/repos","events_url":"https://api.github.com/users/mujx/events{/privacy}","received_events_url":"https://api.github.com/users/mujx/received_events","type":"User","site_admin":false},"repo":{"id":68423806,"name":"ruma","full_name":"mujx/ruma","owner":{"login":"mujx","id":6430350,"avatar_url":"https://avatars.githubusercontent.com/u/6430350?v=3","gravatar_id":"","url":"https://api.github.com/users/mujx","html_url":"https://github.com/mujx","followers_url":"https://api.github.com/users/mujx/followers","following_url":"https://api.github.com/users/mujx/following{/other_user}","gists_url":"https://api.github.com/users/mujx/gists{/gist_id}","starred_url":"https://api.github.com/users/mujx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mujx/subscriptions","organizations_url":"https://api.github.com/users/mujx/orgs","repos_url":"https://api.github.com/users/mujx/repos","events_url":"https://api.github.com/users/mujx/events{/privacy}","received_events_url":"https://api.github.com/users/mujx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mujx/ruma","description":"A Matrix homeserver client API written in Rust.","fork":true,"url":"https://api.github.com/repos/mujx/ruma","forks_url":"https://api.github.com/repos/mujx/ruma/forks","keys_url":"https://api.github.com/repos/mujx/ruma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mujx/ruma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mujx/ruma/teams","hooks_url":"https://api.github.com/repos/mujx/ruma/hooks","issue_events_url":"https://api.github.com/repos/mujx/ruma/issues/events{/number}","events_url":"https://api.github.com/repos/mujx/ruma/events","assignees_url":"https://api.github.com/repos/mujx/ruma/assignees{/user}","branches_url":"https://api.github.com/repos/mujx/ruma/branches{/branch}","tags_url":"https://api.github.com/repos/mujx/ruma/tags","blobs_url":"https://api.github.com/repos/mujx/ruma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mujx/ruma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mujx/ruma/git/refs{/sha}","trees_url":"https://api.github.com/repos/mujx/ruma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mujx/ruma/statuses/{sha}","languages_url":"https://api.github.com/repos/mujx/ruma/languages","stargazers_url":"https://api.github.com/repos/mujx/ruma/stargazers","contributors_url":"https://api.github.com/repos/mujx/ruma/contributors","subscribers_url":"https://api.github.com/repos/mujx/ruma/subscribers","subscription_url":"https://api.github.com/repos/mujx/ruma/subscription","commits_url":"https://api.github.com/repos/mujx/ruma/commits{/sha}","git_commits_url":"https://api.github.com/repos/mujx/ruma/git/commits{/sha}","comments_url":"https://api.github.com/repos/mujx/ruma/comments{/number}","issue_comment_url":"https://api.github.com/repos/mujx/ruma/issues/comments{/number}","contents_url":"https://api.github.com/repos/mujx/ruma/contents/{+path}","compare_url":"https://api.github.com/repos/mujx/ruma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mujx/ruma/merges","archive_url":"https://api.github.com/repos/mujx/ruma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mujx/ruma/downloads","issues_url":"https://api.github.com/repos/mujx/ruma/issues{/number}","pulls_url":"https://api.github.com/repos/mujx/ruma/pulls{/number}","milestones_url":"https://api.github.com/repos/mujx/ruma/milestones{/number}","notifications_url":"https://api.github.com/repos/mujx/ruma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mujx/ruma/labels{/name}","releases_url":"https://api.github.com/repos/mujx/ruma/releases{/id}","deployments_url":"https://api.github.com/repos/mujx/ruma/deployments","created_at":"2016-09-17T00:45:12Z","updated_at":"2016-09-17T00:45:13Z","pushed_at":"2016-10-18T11:12:01Z","git_url":"git://github.com/mujx/ruma.git","ssh_url":"git@github.com:mujx/ruma.git","clone_url":"https://github.com/mujx/ruma.git","svn_url":"https://github.com/mujx/ruma","homepage":"https://www.ruma.io/","size":384,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruma:master","ref":"master","sha":"259d93e0f3b0df80f06399dd346e76807767d1b8","user":{"login":"ruma","id":16043271,"avatar_url":"https://avatars.githubusercontent.com/u/16043271?v=3","gravatar_id":"","url":"https://api.github.com/users/ruma","html_url":"https://github.com/ruma","followers_url":"https://api.github.com/users/ruma/followers","following_url":"https://api.github.com/users/ruma/following{/other_user}","gists_url":"https://api.github.com/users/ruma/gists{/gist_id}","starred_url":"https://api.github.com/users/ruma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruma/subscriptions","organizations_url":"https://api.github.com/users/ruma/orgs","repos_url":"https://api.github.com/users/ruma/repos","events_url":"https://api.github.com/users/ruma/events{/privacy}","received_events_url":"https://api.github.com/users/ruma/received_events","type":"Organization","site_admin":false},"repo":{"id":47059992,"name":"ruma","full_name":"ruma/ruma","owner":{"login":"ruma","id":16043271,"avatar_url":"https://avatars.githubusercontent.com/u/16043271?v=3","gravatar_id":"","url":"https://api.github.com/users/ruma","html_url":"https://github.com/ruma","followers_url":"https://api.github.com/users/ruma/followers","following_url":"https://api.github.com/users/ruma/following{/other_user}","gists_url":"https://api.github.com/users/ruma/gists{/gist_id}","starred_url":"https://api.github.com/users/ruma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruma/subscriptions","organizations_url":"https://api.github.com/users/ruma/orgs","repos_url":"https://api.github.com/users/ruma/repos","events_url":"https://api.github.com/users/ruma/events{/privacy}","received_events_url":"https://api.github.com/users/ruma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruma/ruma","description":"A Matrix homeserver client API written in Rust.","fork":false,"url":"https://api.github.com/repos/ruma/ruma","forks_url":"https://api.github.com/repos/ruma/ruma/forks","keys_url":"https://api.github.com/repos/ruma/ruma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruma/ruma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruma/ruma/teams","hooks_url":"https://api.github.com/repos/ruma/ruma/hooks","issue_events_url":"https://api.github.com/repos/ruma/ruma/issues/events{/number}","events_url":"https://api.github.com/repos/ruma/ruma/events","assignees_url":"https://api.github.com/repos/ruma/ruma/assignees{/user}","branches_url":"https://api.github.com/repos/ruma/ruma/branches{/branch}","tags_url":"https://api.github.com/repos/ruma/ruma/tags","blobs_url":"https://api.github.com/repos/ruma/ruma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruma/ruma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruma/ruma/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruma/ruma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruma/ruma/statuses/{sha}","languages_url":"https://api.github.com/repos/ruma/ruma/languages","stargazers_url":"https://api.github.com/repos/ruma/ruma/stargazers","contributors_url":"https://api.github.com/repos/ruma/ruma/contributors","subscribers_url":"https://api.github.com/repos/ruma/ruma/subscribers","subscription_url":"https://api.github.com/repos/ruma/ruma/subscription","commits_url":"https://api.github.com/repos/ruma/ruma/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruma/ruma/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruma/ruma/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruma/ruma/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruma/ruma/contents/{+path}","compare_url":"https://api.github.com/repos/ruma/ruma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruma/ruma/merges","archive_url":"https://api.github.com/repos/ruma/ruma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruma/ruma/downloads","issues_url":"https://api.github.com/repos/ruma/ruma/issues{/number}","pulls_url":"https://api.github.com/repos/ruma/ruma/pulls{/number}","milestones_url":"https://api.github.com/repos/ruma/ruma/milestones{/number}","notifications_url":"https://api.github.com/repos/ruma/ruma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruma/ruma/labels{/name}","releases_url":"https://api.github.com/repos/ruma/ruma/releases{/id}","deployments_url":"https://api.github.com/repos/ruma/ruma/deployments","created_at":"2015-11-29T10:59:46Z","updated_at":"2016-10-18T10:06:51Z","pushed_at":"2016-10-18T11:12:01Z","git_url":"git://github.com/ruma/ruma.git","ssh_url":"git@github.com:ruma/ruma.git","clone_url":"https://github.com/ruma/ruma.git","svn_url":"https://github.com/ruma/ruma","homepage":"https://www.ruma.io/","size":398,"stargazers_count":415,"watchers_count":415,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":64,"forks":16,"open_issues":64,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruma/ruma/pulls/104"},"html":{"href":"https://github.com/ruma/ruma/pull/104"},"issue":{"href":"https://api.github.com/repos/ruma/ruma/issues/104"},"comments":{"href":"https://api.github.com/repos/ruma/ruma/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/ruma/ruma/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/ruma/ruma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruma/ruma/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/ruma/ruma/statuses/650811c3c09284f134a8b2aa9fe2387b585d04f2"}}}}
{"actor":{"display_login":"mujx"}}