{"action":"created","comment":{"url":"https://api.github.com/repos/digipost/http-client-builder/pulls/comments/80635577","pull_request_review_id":1676961,"id":80635577,"diff_hunk":"@@ -128,7 +127,9 @@\n         public final int maxTotal;\n         public final int maxPerRoute;\n \n-        private ConnectionAmount(int maxTotal, int maxPerRoute) {\n+        public ConnectionAmount(int maxTotal, int maxPerRoute) {","path":"src/main/java/no/digipost/http/client/DigipostHttpClientDefaults.java","position":13,"original_position":13,"commit_id":"03a56ffe2d0dccbb147c7769e8916513cd230f0f","original_commit_id":"03a56ffe2d0dccbb147c7769e8916513cd230f0f","user":{"login":"runeflobakk","id":174823,"avatar_url":"https://avatars.githubusercontent.com/u/174823?v=3","gravatar_id":"","url":"https://api.github.com/users/runeflobakk","html_url":"https://github.com/runeflobakk","followers_url":"https://api.github.com/users/runeflobakk/followers","following_url":"https://api.github.com/users/runeflobakk/following{/other_user}","gists_url":"https://api.github.com/users/runeflobakk/gists{/gist_id}","starred_url":"https://api.github.com/users/runeflobakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runeflobakk/subscriptions","organizations_url":"https://api.github.com/users/runeflobakk/orgs","repos_url":"https://api.github.com/users/runeflobakk/repos","events_url":"https://api.github.com/users/runeflobakk/events{/privacy}","received_events_url":"https://api.github.com/users/runeflobakk/received_events","type":"User","site_admin":false},"body":"Synes `ConnectionAmount` bør følge samme pattern som `DigipostHttpClientMillisecondTimeouts`. Altså bør `ConnectionAmount` extractes som egen klasse -> `DigipostHttpClientConnectionAmount`, og ha litt metoder for å endre verdiene. `DigipostHttpClientMillisecondTimeouts` har også en metode `isPotentiallyDangerous`, som kalles i `DigipostHttpClientFactory`. Bør `DigipostHttpClientConnectionAmount` også ha en slik? Er det noen verdier som bør være gyldige, men som kun bør brukes f.eks. test?\r\n\r\nJeg foreslår at vi parprogrammerer disse endringene :)\r\n\r\n@froden nevnte at han synes det var litt forvirrende at for å lage custom `DigipostHttpClientMillisecondTimeouts` måtte han begynne med `DigipostHttpClientDefaults.DEFAULT_TIMEOUTS_MS` og \"modifisere\" denne, men jeg foreslår å fikse dette i en egen pull-request, og at vi nå følger \"patternet\" som allerede er etablert her.\r\n\r\n","created_at":"2016-09-27T07:41:07Z","updated_at":"2016-09-27T07:48:39Z","html_url":"https://github.com/digipost/http-client-builder/pull/1#discussion_r80635577","pull_request_url":"https://api.github.com/repos/digipost/http-client-builder/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/digipost/http-client-builder/pulls/comments/80635577"},"html":{"href":"https://github.com/digipost/http-client-builder/pull/1#discussion_r80635577"},"pull_request":{"href":"https://api.github.com/repos/digipost/http-client-builder/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/digipost/http-client-builder/pulls/1","id":86872364,"html_url":"https://github.com/digipost/http-client-builder/pull/1","diff_url":"https://github.com/digipost/http-client-builder/pull/1.diff","patch_url":"https://github.com/digipost/http-client-builder/pull/1.patch","issue_url":"https://api.github.com/repos/digipost/http-client-builder/issues/1","number":1,"state":"open","locked":false,"title":"New version 2.1","user":{"login":"SimonsUnikaNamn","id":1564038,"avatar_url":"https://avatars.githubusercontent.com/u/1564038?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonsUnikaNamn","html_url":"https://github.com/SimonsUnikaNamn","followers_url":"https://api.github.com/users/SimonsUnikaNamn/followers","following_url":"https://api.github.com/users/SimonsUnikaNamn/following{/other_user}","gists_url":"https://api.github.com/users/SimonsUnikaNamn/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonsUnikaNamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonsUnikaNamn/subscriptions","organizations_url":"https://api.github.com/users/SimonsUnikaNamn/orgs","repos_url":"https://api.github.com/users/SimonsUnikaNamn/repos","events_url":"https://api.github.com/users/SimonsUnikaNamn/events{/privacy}","received_events_url":"https://api.github.com/users/SimonsUnikaNamn/received_events","type":"User","site_admin":false},"body":"La till ett sätt att skapa egna ConnectionAmount med validering på inputen så att man slipper skapa en massa nya statiska exempel när man vill ha nya antal i poolen","created_at":"2016-09-27T07:02:15Z","updated_at":"2016-09-27T07:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f54d28b85e3f56e744ea0e56305164cb1488aca1","assignee":{"login":"runeflobakk","id":174823,"avatar_url":"https://avatars.githubusercontent.com/u/174823?v=3","gravatar_id":"","url":"https://api.github.com/users/runeflobakk","html_url":"https://github.com/runeflobakk","followers_url":"https://api.github.com/users/runeflobakk/followers","following_url":"https://api.github.com/users/runeflobakk/following{/other_user}","gists_url":"https://api.github.com/users/runeflobakk/gists{/gist_id}","starred_url":"https://api.github.com/users/runeflobakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runeflobakk/subscriptions","organizations_url":"https://api.github.com/users/runeflobakk/orgs","repos_url":"https://api.github.com/users/runeflobakk/repos","events_url":"https://api.github.com/users/runeflobakk/events{/privacy}","received_events_url":"https://api.github.com/users/runeflobakk/received_events","type":"User","site_admin":false},"assignees":[{"login":"runeflobakk","id":174823,"avatar_url":"https://avatars.githubusercontent.com/u/174823?v=3","gravatar_id":"","url":"https://api.github.com/users/runeflobakk","html_url":"https://github.com/runeflobakk","followers_url":"https://api.github.com/users/runeflobakk/followers","following_url":"https://api.github.com/users/runeflobakk/following{/other_user}","gists_url":"https://api.github.com/users/runeflobakk/gists{/gist_id}","starred_url":"https://api.github.com/users/runeflobakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runeflobakk/subscriptions","organizations_url":"https://api.github.com/users/runeflobakk/orgs","repos_url":"https://api.github.com/users/runeflobakk/repos","events_url":"https://api.github.com/users/runeflobakk/events{/privacy}","received_events_url":"https://api.github.com/users/runeflobakk/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/digipost/http-client-builder/pulls/1/commits","review_comments_url":"https://api.github.com/repos/digipost/http-client-builder/pulls/1/comments","review_comment_url":"https://api.github.com/repos/digipost/http-client-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digipost/http-client-builder/issues/1/comments","statuses_url":"https://api.github.com/repos/digipost/http-client-builder/statuses/03a56ffe2d0dccbb147c7769e8916513cd230f0f","head":{"label":"digipost:new-version-2.1","ref":"new-version-2.1","sha":"03a56ffe2d0dccbb147c7769e8916513cd230f0f","user":{"login":"digipost","id":1013853,"avatar_url":"https://avatars.githubusercontent.com/u/1013853?v=3","gravatar_id":"","url":"https://api.github.com/users/digipost","html_url":"https://github.com/digipost","followers_url":"https://api.github.com/users/digipost/followers","following_url":"https://api.github.com/users/digipost/following{/other_user}","gists_url":"https://api.github.com/users/digipost/gists{/gist_id}","starred_url":"https://api.github.com/users/digipost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipost/subscriptions","organizations_url":"https://api.github.com/users/digipost/orgs","repos_url":"https://api.github.com/users/digipost/repos","events_url":"https://api.github.com/users/digipost/events{/privacy}","received_events_url":"https://api.github.com/users/digipost/received_events","type":"Organization","site_admin":false},"repo":{"id":60642517,"name":"http-client-builder","full_name":"digipost/http-client-builder","owner":{"login":"digipost","id":1013853,"avatar_url":"https://avatars.githubusercontent.com/u/1013853?v=3","gravatar_id":"","url":"https://api.github.com/users/digipost","html_url":"https://github.com/digipost","followers_url":"https://api.github.com/users/digipost/followers","following_url":"https://api.github.com/users/digipost/following{/other_user}","gists_url":"https://api.github.com/users/digipost/gists{/gist_id}","starred_url":"https://api.github.com/users/digipost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipost/subscriptions","organizations_url":"https://api.github.com/users/digipost/orgs","repos_url":"https://api.github.com/users/digipost/repos","events_url":"https://api.github.com/users/digipost/events{/privacy}","received_events_url":"https://api.github.com/users/digipost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/digipost/http-client-builder","description":"Apache HTTP Client configured with sensible defaults.","fork":false,"url":"https://api.github.com/repos/digipost/http-client-builder","forks_url":"https://api.github.com/repos/digipost/http-client-builder/forks","keys_url":"https://api.github.com/repos/digipost/http-client-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digipost/http-client-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digipost/http-client-builder/teams","hooks_url":"https://api.github.com/repos/digipost/http-client-builder/hooks","issue_events_url":"https://api.github.com/repos/digipost/http-client-builder/issues/events{/number}","events_url":"https://api.github.com/repos/digipost/http-client-builder/events","assignees_url":"https://api.github.com/repos/digipost/http-client-builder/assignees{/user}","branches_url":"https://api.github.com/repos/digipost/http-client-builder/branches{/branch}","tags_url":"https://api.github.com/repos/digipost/http-client-builder/tags","blobs_url":"https://api.github.com/repos/digipost/http-client-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digipost/http-client-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digipost/http-client-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/digipost/http-client-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digipost/http-client-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/digipost/http-client-builder/languages","stargazers_url":"https://api.github.com/repos/digipost/http-client-builder/stargazers","contributors_url":"https://api.github.com/repos/digipost/http-client-builder/contributors","subscribers_url":"https://api.github.com/repos/digipost/http-client-builder/subscribers","subscription_url":"https://api.github.com/repos/digipost/http-client-builder/subscription","commits_url":"https://api.github.com/repos/digipost/http-client-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/digipost/http-client-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/digipost/http-client-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/digipost/http-client-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/digipost/http-client-builder/contents/{+path}","compare_url":"https://api.github.com/repos/digipost/http-client-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digipost/http-client-builder/merges","archive_url":"https://api.github.com/repos/digipost/http-client-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digipost/http-client-builder/downloads","issues_url":"https://api.github.com/repos/digipost/http-client-builder/issues{/number}","pulls_url":"https://api.github.com/repos/digipost/http-client-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/digipost/http-client-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/digipost/http-client-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digipost/http-client-builder/labels{/name}","releases_url":"https://api.github.com/repos/digipost/http-client-builder/releases{/id}","deployments_url":"https://api.github.com/repos/digipost/http-client-builder/deployments","created_at":"2016-06-07T20:01:00Z","updated_at":"2016-06-07T21:14:11Z","pushed_at":"2016-09-27T07:02:15Z","git_url":"git://github.com/digipost/http-client-builder.git","ssh_url":"git@github.com:digipost/http-client-builder.git","clone_url":"https://github.com/digipost/http-client-builder.git","svn_url":"https://github.com/digipost/http-client-builder","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"digipost:master","ref":"master","sha":"9656bf3fc24235f8dadd02688adcd9879e418359","user":{"login":"digipost","id":1013853,"avatar_url":"https://avatars.githubusercontent.com/u/1013853?v=3","gravatar_id":"","url":"https://api.github.com/users/digipost","html_url":"https://github.com/digipost","followers_url":"https://api.github.com/users/digipost/followers","following_url":"https://api.github.com/users/digipost/following{/other_user}","gists_url":"https://api.github.com/users/digipost/gists{/gist_id}","starred_url":"https://api.github.com/users/digipost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipost/subscriptions","organizations_url":"https://api.github.com/users/digipost/orgs","repos_url":"https://api.github.com/users/digipost/repos","events_url":"https://api.github.com/users/digipost/events{/privacy}","received_events_url":"https://api.github.com/users/digipost/received_events","type":"Organization","site_admin":false},"repo":{"id":60642517,"name":"http-client-builder","full_name":"digipost/http-client-builder","owner":{"login":"digipost","id":1013853,"avatar_url":"https://avatars.githubusercontent.com/u/1013853?v=3","gravatar_id":"","url":"https://api.github.com/users/digipost","html_url":"https://github.com/digipost","followers_url":"https://api.github.com/users/digipost/followers","following_url":"https://api.github.com/users/digipost/following{/other_user}","gists_url":"https://api.github.com/users/digipost/gists{/gist_id}","starred_url":"https://api.github.com/users/digipost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digipost/subscriptions","organizations_url":"https://api.github.com/users/digipost/orgs","repos_url":"https://api.github.com/users/digipost/repos","events_url":"https://api.github.com/users/digipost/events{/privacy}","received_events_url":"https://api.github.com/users/digipost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/digipost/http-client-builder","description":"Apache HTTP Client configured with sensible defaults.","fork":false,"url":"https://api.github.com/repos/digipost/http-client-builder","forks_url":"https://api.github.com/repos/digipost/http-client-builder/forks","keys_url":"https://api.github.com/repos/digipost/http-client-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digipost/http-client-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digipost/http-client-builder/teams","hooks_url":"https://api.github.com/repos/digipost/http-client-builder/hooks","issue_events_url":"https://api.github.com/repos/digipost/http-client-builder/issues/events{/number}","events_url":"https://api.github.com/repos/digipost/http-client-builder/events","assignees_url":"https://api.github.com/repos/digipost/http-client-builder/assignees{/user}","branches_url":"https://api.github.com/repos/digipost/http-client-builder/branches{/branch}","tags_url":"https://api.github.com/repos/digipost/http-client-builder/tags","blobs_url":"https://api.github.com/repos/digipost/http-client-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digipost/http-client-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digipost/http-client-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/digipost/http-client-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digipost/http-client-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/digipost/http-client-builder/languages","stargazers_url":"https://api.github.com/repos/digipost/http-client-builder/stargazers","contributors_url":"https://api.github.com/repos/digipost/http-client-builder/contributors","subscribers_url":"https://api.github.com/repos/digipost/http-client-builder/subscribers","subscription_url":"https://api.github.com/repos/digipost/http-client-builder/subscription","commits_url":"https://api.github.com/repos/digipost/http-client-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/digipost/http-client-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/digipost/http-client-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/digipost/http-client-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/digipost/http-client-builder/contents/{+path}","compare_url":"https://api.github.com/repos/digipost/http-client-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digipost/http-client-builder/merges","archive_url":"https://api.github.com/repos/digipost/http-client-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digipost/http-client-builder/downloads","issues_url":"https://api.github.com/repos/digipost/http-client-builder/issues{/number}","pulls_url":"https://api.github.com/repos/digipost/http-client-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/digipost/http-client-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/digipost/http-client-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digipost/http-client-builder/labels{/name}","releases_url":"https://api.github.com/repos/digipost/http-client-builder/releases{/id}","deployments_url":"https://api.github.com/repos/digipost/http-client-builder/deployments","created_at":"2016-06-07T20:01:00Z","updated_at":"2016-06-07T21:14:11Z","pushed_at":"2016-09-27T07:02:15Z","git_url":"git://github.com/digipost/http-client-builder.git","ssh_url":"git@github.com:digipost/http-client-builder.git","clone_url":"https://github.com/digipost/http-client-builder.git","svn_url":"https://github.com/digipost/http-client-builder","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digipost/http-client-builder/pulls/1"},"html":{"href":"https://github.com/digipost/http-client-builder/pull/1"},"issue":{"href":"https://api.github.com/repos/digipost/http-client-builder/issues/1"},"comments":{"href":"https://api.github.com/repos/digipost/http-client-builder/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/digipost/http-client-builder/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/digipost/http-client-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digipost/http-client-builder/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/digipost/http-client-builder/statuses/03a56ffe2d0dccbb147c7769e8916513cd230f0f"}}}}
{"actor":{"display_login":"runeflobakk"}}