{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/71413622","id":71413622,"diff_hunk":"@@ -63,7 +67,8 @@ class Disassembler {\n         header_(!spvIsInBitfield(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER, options)),\n         show_byte_offset_(spvIsInBitfield(\n             SPV_BINARY_TO_TEXT_OPTION_SHOW_BYTE_OFFSET, options)),\n-        byte_offset_(0) {}\n+        byte_offset_(0),\n+        name_mapper_(name_mapper) {}","path":"source/disassemble.cpp","position":35,"original_position":35,"commit_id":"7dbe6ee92f956f54f7d40ff71980e84d2e4cf4da","original_commit_id":"7dbe6ee92f956f54f7d40ff71980e84d2e4cf4da","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"`std::move`?","created_at":"2016-07-19T20:09:51Z","updated_at":"2016-07-19T20:09:51Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/263#discussion_r71413622","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/71413622"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/263#discussion_r71413622"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263","id":76815682,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/263","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/263.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/263.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/263","number":263,"state":"open","locked":false,"title":"Nice disasm","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"This is a long-requested feature.  It should make disassembly more readable.\r\nIt might enhance testabilty for SPIR-V generators since it will make it easier to write matchers against disassembled output.","created_at":"2016-07-08T21:16:59Z","updated_at":"2016-07-19T20:09:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43422c90ce9af44e8764d485efb45dfb36080691","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/263/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/7dbe6ee92f956f54f7d40ff71980e84d2e4cf4da","head":{"label":"dneto0:nice-disasm","ref":"nice-disasm","sha":"7dbe6ee92f956f54f7d40ff71980e84d2e4cf4da","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"repo":{"id":46365138,"name":"SPIRV-Tools","full_name":"dneto0/SPIRV-Tools","owner":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dneto0/SPIRV-Tools","description":"","fork":true,"url":"https://api.github.com/repos/dneto0/SPIRV-Tools","forks_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/dneto0/SPIRV-Tools/deployments","created_at":"2015-11-17T17:57:28Z","updated_at":"2016-03-24T18:57:43Z","pushed_at":"2016-07-08T21:40:34Z","git_url":"git://github.com/dneto0/SPIRV-Tools.git","ssh_url":"git@github.com:dneto0/SPIRV-Tools.git","clone_url":"https://github.com/dneto0/SPIRV-Tools.git","svn_url":"https://github.com/dneto0/SPIRV-Tools","homepage":null,"size":1870,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"06581f5ce6cb636ed1c6611da371656c26a1d871","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":"","fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2016-07-11T15:09:00Z","pushed_at":"2016-07-19T19:06:21Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":2310,"stargazers_count":127,"watchers_count":127,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/263"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/263"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/7dbe6ee92f956f54f7d40ff71980e84d2e4cf4da"}}}}
{"actor":{"display_login":"antiagainst"}}