{"action":"created","issue":{"url":"https://api.github.com/repos/poppy-project/poppy-torso/issues/12","labels_url":"https://api.github.com/repos/poppy-project/poppy-torso/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/poppy-project/poppy-torso/issues/12/comments","events_url":"https://api.github.com/repos/poppy-project/poppy-torso/issues/12/events","html_url":"https://github.com/poppy-project/poppy-torso/issues/12","id":125835528,"number":12,"title":"Prevent the monitor temperature primitive to be used in v-rep","user":{"login":"pierre-rouanet","id":4290742,"avatar_url":"https://avatars.githubusercontent.com/u/4290742?v=3","gravatar_id":"","url":"https://api.github.com/users/pierre-rouanet","html_url":"https://github.com/pierre-rouanet","followers_url":"https://api.github.com/users/pierre-rouanet/followers","following_url":"https://api.github.com/users/pierre-rouanet/following{/other_user}","gists_url":"https://api.github.com/users/pierre-rouanet/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre-rouanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre-rouanet/subscriptions","organizations_url":"https://api.github.com/users/pierre-rouanet/orgs","repos_url":"https://api.github.com/users/pierre-rouanet/repos","events_url":"https://api.github.com/users/pierre-rouanet/events{/privacy}","received_events_url":"https://api.github.com/users/pierre-rouanet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"show0k","id":3891499,"avatar_url":"https://avatars.githubusercontent.com/u/3891499?v=3","gravatar_id":"","url":"https://api.github.com/users/show0k","html_url":"https://github.com/show0k","followers_url":"https://api.github.com/users/show0k/followers","following_url":"https://api.github.com/users/show0k/following{/other_user}","gists_url":"https://api.github.com/users/show0k/gists{/gist_id}","starred_url":"https://api.github.com/users/show0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/show0k/subscriptions","organizations_url":"https://api.github.com/users/show0k/orgs","repos_url":"https://api.github.com/users/show0k/repos","events_url":"https://api.github.com/users/show0k/events{/privacy}","received_events_url":"https://api.github.com/users/show0k/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-01-10T18:11:23Z","updated_at":"2016-01-25T11:26:43Z","closed_at":null,"body":"Using the Torso in v-rep may raised an error as the temperature monitoring primitive may now raise an alert (see https://github.com/poppy-project/pypot/commit/f4f727815336b6a58a79583080578c5166f031c0). Yet, the \"safety sound\" is not packaged with the torso softwares.\r\n\r\n```python\r\nException in thread Thread-5:\r\nTraceback (most recent call last):\r\n  File \"/Users/pierrerouanet/.pyenv/versions/anaconda-2.4.0/lib/python2.7/threading.py\", line 810, in __bootstrap_inner\r\n    self.run()\r\n  File \"/Users/pierrerouanet/.pyenv/versions/anaconda-2.4.0/lib/python2.7/threading.py\", line 763, in run\r\n    self.__target(*self.__args, **self.__kwargs)\r\n  File \"/Users/pierrerouanet/dev/pypot/pypot/utils/stoppablethread.py\", line 119, in _wrapped_target\r\n    self._target()\r\n  File \"/Users/pierrerouanet/dev/pypot/pypot/primitive/primitive.py\", line 79, in _prim_run\r\n    self.run()\r\n  File \"/Users/pierrerouanet/dev/pypot/pypot/primitive/primitive.py\", line 167, in run\r\n    make_update_loop(self, self._wrapped_update)\r\n  File \"/Users/pierrerouanet/dev/pypot/pypot/utils/stoppablethread.py\", line 152, in make_update_loop\r\n    update_func()\r\n  File \"/Users/pierrerouanet/dev/pypot/pypot/primitive/primitive.py\", line 172, in _wrapped_update\r\n    self.update()\r\n  File \"/Users/pierrerouanet/dev/poppy-torso/software/poppy_torso/primitives/safe.py\", line 96, in update\r\n    self.check_temperature()\r\n  File \"/Users/pierrerouanet/dev/poppy-torso/software/poppy_torso/primitives/safe.py\", line 109, in check_temperature\r\n    self.raise_problem(motor_list)\r\n  File \"/Users/pierrerouanet/dev/poppy-torso/software/poppy_torso/primitives/safe.py\", line 112, in raise_problem\r\n    subprocess.call([self.player, self.sound])\r\n  File \"/Users/pierrerouanet/.pyenv/versions/anaconda-2.4.0/lib/python2.7/subprocess.py\", line 522, in call\r\n    return Popen(*popenargs, **kwargs).wait()\r\n  File \"/Users/pierrerouanet/.pyenv/versions/anaconda-2.4.0/lib/python2.7/subprocess.py\", line 710, in __init__\r\n    errread, errwrite)\r\n  File \"/Users/pierrerouanet/.pyenv/versions/anaconda-2.4.0/lib/python2.7/subprocess.py\", line 1335, in _execute_child\r\n    raise child_exception\r\nOSError: [Errno 2] No such file or directory\r\n```\r\n\r\nI would guess the better solution is to either disable the monitor primitive in v-rep or to simply log when there is a virtual motor \"burning\" instead of trying to play the sound."},"comment":{"url":"https://api.github.com/repos/poppy-project/poppy-torso/issues/comments/174477891","html_url":"https://github.com/poppy-project/poppy-torso/issues/12#issuecomment-174477891","issue_url":"https://api.github.com/repos/poppy-project/poppy-torso/issues/12","id":174477891,"user":{"login":"pierre-rouanet","id":4290742,"avatar_url":"https://avatars.githubusercontent.com/u/4290742?v=3","gravatar_id":"","url":"https://api.github.com/users/pierre-rouanet","html_url":"https://github.com/pierre-rouanet","followers_url":"https://api.github.com/users/pierre-rouanet/followers","following_url":"https://api.github.com/users/pierre-rouanet/following{/other_user}","gists_url":"https://api.github.com/users/pierre-rouanet/gists{/gist_id}","starred_url":"https://api.github.com/users/pierre-rouanet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierre-rouanet/subscriptions","organizations_url":"https://api.github.com/users/pierre-rouanet/orgs","repos_url":"https://api.github.com/users/pierre-rouanet/repos","events_url":"https://api.github.com/users/pierre-rouanet/events{/privacy}","received_events_url":"https://api.github.com/users/pierre-rouanet/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T11:26:43Z","updated_at":"2016-01-25T11:26:43Z","body":"I don't think it should go to pypot. The temperature monitoring should be creature based. For instance, we know the torso weakness point is the abs, etc. \r\n\r\nFor the sound, I think the good strategies is not to rely on sound exclusively. For the moment, on the Ergo we do not have an official way to play sound. So we should at least have another approach.\r\nFurthermore, I must say I don't like libraries that print stuff without asking, so playing sound when you just suppose to make motor turn doesn't seem to me like a good idea."}}