{"action":"created","issue":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/issues/899","repository_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp","labels_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/issues/899/labels{/name}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/issues/899/comments","events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/issues/899/events","html_url":"https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/pull/899","id":158130753,"number":899,"title":"Removing public const fields by making them internal, and defining fr…","user":{"login":"tvsonar","id":11485373,"avatar_url":"https://avatars.githubusercontent.com/u/11485373?v=3","gravatar_id":"","url":"https://api.github.com/users/tvsonar","html_url":"https://github.com/tvsonar","followers_url":"https://api.github.com/users/tvsonar/followers","following_url":"https://api.github.com/users/tvsonar/following{/other_user}","gists_url":"https://api.github.com/users/tvsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/tvsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvsonar/subscriptions","organizations_url":"https://api.github.com/users/tvsonar/orgs","repos_url":"https://api.github.com/users/tvsonar/repos","events_url":"https://api.github.com/users/tvsonar/events{/privacy}","received_events_url":"https://api.github.com/users/tvsonar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-02T12:40:02Z","updated_at":"2016-06-21T09:51:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/pulls/899","html_url":"https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/pull/899","diff_url":"https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/pull/899.diff","patch_url":"https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/pull/899.patch"},"body":"…iend assemblies"},"comment":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/issues/comments/227393303","html_url":"https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/pull/899#issuecomment-227393303","issue_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonaranalyzer-csharp/issues/899","id":227393303,"user":{"login":"SonarTech","id":1842438,"avatar_url":"https://avatars.githubusercontent.com/u/1842438?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarTech","html_url":"https://github.com/SonarTech","followers_url":"https://api.github.com/users/SonarTech/followers","following_url":"https://api.github.com/users/SonarTech/following{/other_user}","gists_url":"https://api.github.com/users/SonarTech/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarTech/subscriptions","organizations_url":"https://api.github.com/users/SonarTech/orgs","repos_url":"https://api.github.com/users/SonarTech/repos","events_url":"https://api.github.com/users/SonarTech/events{/privacy}","received_events_url":"https://api.github.com/users/SonarTech/received_events","type":"User","site_admin":false},"created_at":"2016-06-21T09:51:14Z","updated_at":"2016-06-21T09:51:14Z","body":"SonarQube analysis reported 20 issues\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 19 major\n* ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) 1 info\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L96](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L96): 'ControlFlowGraphBuilder.BuildStatement(StatementSyntax)' has a cyclomatic complexity of 28. Rewrite or refactor the method to reduce complexity to 25. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3AAvoidExcessiveComplexity)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L155](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L155): 'statement', a parameter, is cast to type 'YieldStatementSyntax' multiple times in method 'ControlFlowGraphBuilder.BuildStatement(StatementSyntax)'. Cache the result of the 'as' operator or direct cast in order to eliminate the redundant castclass instruction. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3ADoNotCastUnnecessarily)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L178](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L178): 'statement', a parameter, is cast to type 'GotoStatementSyntax' multiple times in method 'ControlFlowGraphBuilder.BuildStatement(StatementSyntax)'. Cache the result of the 'as' operator or direct cast in order to eliminate the redundant castclass instruction. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3ADoNotCastUnnecessarily)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L183](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L183): 'statement', a parameter, is cast to type 'GotoStatementSyntax' multiple times in method 'ControlFlowGraphBuilder.BuildStatement(StatementSyntax)'. Cache the result of the 'as' operator or direct cast in order to eliminate the redundant castclass instruction. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3ADoNotCastUnnecessarily)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L201](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L201): 'ControlFlowGraphBuilder.BuildExpression(ExpressionSyntax)' has a cyclomatic complexity of 42. Rewrite or refactor the method to reduce complexity to 25. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3AAvoidExcessiveComplexity)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L224](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L224): 'expression', a parameter, is cast to type 'AssignmentExpressionSyntax' multiple times in method 'ControlFlowGraphBuilder.BuildExpression(ExpressionSyntax)'. Cache the result of the 'as' operator or direct cast in order to eliminate the redundant castclass instruction. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3ADoNotCastUnnecessarily)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L319](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L319): 'expression', a parameter, is cast to type 'BinaryExpressionSyntax' multiple times in method 'ControlFlowGraphBuilder.BuildExpression(ExpressionSyntax)'. Cache the result of the 'as' operator or direct cast in order to eliminate the redundant castclass instruction. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3ADoNotCastUnnecessarily)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L330](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L330): Either merge this case with the identical one on line \"293\" or change one of the implementations. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=csharpsquid%3AS1871)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L334](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L334): Either merge this case with the identical one on line \"293\" or change one of the implementations. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=csharpsquid%3AS1871)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [ControlFlowGraphBuilder.cs#L361](https://github.com/SonarSource-VisualStudio/sonaranalyzer-csharp/blob/f92bd0cc9cb5302f8dcdaf9ab67ec5188df549e4/src/SonarLint.CSharp/Helpers/ControlFlowGraph/ControlFlowGraphBuilder.cs#L361): 'expression', a parameter, is cast to type 'BinaryExpressionSyntax' multiple times in method 'ControlFlowGraphBuilder.BuildExpression(ExpressionSyntax)'. Cache the result of the 'as' operator or direct cast in order to eliminate the redundant castclass instruction. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://dory.sonarsource.com/sonarqube/coding_rules#rule_key=fxcop%3ADoNotCastUnnecessarily)\n"}}
{"actor":{"display_login":"SonarTech"}}