{"action":"created","issue":{"url":"https://api.github.com/repos/mathtone/MIST/issues/8","repository_url":"https://api.github.com/repos/mathtone/MIST","labels_url":"https://api.github.com/repos/mathtone/MIST/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/mathtone/MIST/issues/8/comments","events_url":"https://api.github.com/repos/mathtone/MIST/issues/8/events","html_url":"https://github.com/mathtone/MIST/pull/8","id":159834414,"number":8,"title":"Branch/improved tests","user":{"login":"aquamoth","id":5458487,"avatar_url":"https://avatars.githubusercontent.com/u/5458487?v=3","gravatar_id":"","url":"https://api.github.com/users/aquamoth","html_url":"https://github.com/aquamoth","followers_url":"https://api.github.com/users/aquamoth/followers","following_url":"https://api.github.com/users/aquamoth/following{/other_user}","gists_url":"https://api.github.com/users/aquamoth/gists{/gist_id}","starred_url":"https://api.github.com/users/aquamoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aquamoth/subscriptions","organizations_url":"https://api.github.com/users/aquamoth/orgs","repos_url":"https://api.github.com/users/aquamoth/repos","events_url":"https://api.github.com/users/aquamoth/events{/privacy}","received_events_url":"https://api.github.com/users/aquamoth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-12T16:03:00Z","updated_at":"2016-06-12T22:55:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mathtone/MIST/pulls/8","html_url":"https://github.com/mathtone/MIST/pull/8","diff_url":"https://github.com/mathtone/MIST/pull/8.diff","patch_url":"https://github.com/mathtone/MIST/pull/8.patch"},"body":"The previous PR should be a no-brainer. It just makes testing easier.\r\nThis one you may need to think about... \r\n\r\nI've rewritten and amended to the unit tests to cover all cases I could think of.\r\nThis commit doesn't change any production code.\r\n\r\nIf you run the tests you see that 18 tests fail - mostly for OnChange functionality. 14 tests pass.\r\n\r\nI noticed you had dropped support for NotifyTargets with no or two parameters. If that is by design you can simply delete a couple of failing tests..\r\n"},"comment":{"url":"https://api.github.com/repos/mathtone/MIST/issues/comments/225465471","html_url":"https://github.com/mathtone/MIST/pull/8#issuecomment-225465471","issue_url":"https://api.github.com/repos/mathtone/MIST/issues/8","id":225465471,"user":{"login":"mathtone","id":7595818,"avatar_url":"https://avatars.githubusercontent.com/u/7595818?v=3","gravatar_id":"","url":"https://api.github.com/users/mathtone","html_url":"https://github.com/mathtone","followers_url":"https://api.github.com/users/mathtone/followers","following_url":"https://api.github.com/users/mathtone/following{/other_user}","gists_url":"https://api.github.com/users/mathtone/gists{/gist_id}","starred_url":"https://api.github.com/users/mathtone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathtone/subscriptions","organizations_url":"https://api.github.com/users/mathtone/orgs","repos_url":"https://api.github.com/users/mathtone/repos","events_url":"https://api.github.com/users/mathtone/events{/privacy}","received_events_url":"https://api.github.com/users/mathtone/received_events","type":"User","site_admin":false},"created_at":"2016-06-12T22:55:04Z","updated_at":"2016-06-12T22:55:04Z","body":"I'm going to re-instate support for NotifyTargets with 0 or 2 parameters, I pulled this out temporarily while I try to sort out some of these problems with the OnChange notification. These tests look pretty comprehensive though, nice job. "}}
{"actor":{"display_login":"mathtone"}}