{"action":"created","comment":{"url":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments/87701643","pull_request_review_id":8305747,"id":87701643,"diff_hunk":"@@ -1,3 +1,13 @@\n+.PHONY: deps aws-deps azure-deps testazure test\n+\n+ifndef TESTRUN","path":"Makefile","position":3,"original_position":3,"commit_id":"6bbaabffaf483b881a5bfb535bdf7f3ae67d460b","original_commit_id":"6bbaabffaf483b881a5bfb535bdf7f3ae67d460b","user":{"login":"katcipis","id":157634,"avatar_url":"https://avatars.githubusercontent.com/u/157634?v=3","gravatar_id":"","url":"https://api.github.com/users/katcipis","html_url":"https://github.com/katcipis","followers_url":"https://api.github.com/users/katcipis/followers","following_url":"https://api.github.com/users/katcipis/following{/other_user}","gists_url":"https://api.github.com/users/katcipis/gists{/gist_id}","starred_url":"https://api.github.com/users/katcipis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katcipis/subscriptions","organizations_url":"https://api.github.com/users/katcipis/orgs","repos_url":"https://api.github.com/users/katcipis/repos","events_url":"https://api.github.com/users/katcipis/events{/privacy}","received_events_url":"https://api.github.com/users/katcipis/received_events","type":"User","site_admin":false},"body":"Nah, just having fun :-)","created_at":"2016-11-12T22:33:18Z","updated_at":"2016-11-12T22:33:18Z","html_url":"https://github.com/NeowayLabs/klb/pull/10#discussion_r87701643","pull_request_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments/87701643"},"html":{"href":"https://github.com/NeowayLabs/klb/pull/10#discussion_r87701643"},"pull_request":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/NeowayLabs/klb/pulls/10","id":93439618,"html_url":"https://github.com/NeowayLabs/klb/pull/10","diff_url":"https://github.com/NeowayLabs/klb/pull/10.diff","patch_url":"https://github.com/NeowayLabs/klb/pull/10.patch","issue_url":"https://api.github.com/repos/NeowayLabs/klb/issues/10","number":10,"state":"open","locked":false,"title":"Change project to use subtests and per-feature travis build","user":{"login":"tiago4orion","id":251478,"avatar_url":"https://avatars.githubusercontent.com/u/251478?v=3","gravatar_id":"","url":"https://api.github.com/users/tiago4orion","html_url":"https://github.com/tiago4orion","followers_url":"https://api.github.com/users/tiago4orion/followers","following_url":"https://api.github.com/users/tiago4orion/following{/other_user}","gists_url":"https://api.github.com/users/tiago4orion/gists{/gist_id}","starred_url":"https://api.github.com/users/tiago4orion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiago4orion/subscriptions","organizations_url":"https://api.github.com/users/tiago4orion/orgs","repos_url":"https://api.github.com/users/tiago4orion/repos","events_url":"https://api.github.com/users/tiago4orion/events{/privacy}","received_events_url":"https://api.github.com/users/tiago4orion/received_events","type":"User","site_admin":false},"body":"Because of tests touch real cloud infra, tests are too slow. Then I created a file `azure_test.go` to consolidate all of the Azure tests in subtests per features implemented. That way we can:\r\n\r\n- Run only specific feature-tests\r\n- Have multiples CI tests (one per feature)\r\n- Run multiple instances of `go test -run=`\r\n\r\nTo test only a specific feature, you can set the environment variable `TESTRUN` (for example, TESTRUN=\"AzureAvailSet/.*\" run all tests for availsets in azure cloud).\r\n\r\n/cc @katcipis Look here https://travis-ci.org/NeowayLabs/klb/builds/175319723","created_at":"2016-11-12T13:52:33Z","updated_at":"2016-11-12T22:33:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d38b48bff8a6a731454b75efa7ab37eb8bb5d460","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/10/commits","review_comments_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/10/comments","review_comment_url":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NeowayLabs/klb/issues/10/comments","statuses_url":"https://api.github.com/repos/NeowayLabs/klb/statuses/6bbaabffaf483b881a5bfb535bdf7f3ae67d460b","head":{"label":"NeowayLabs:add-tests","ref":"add-tests","sha":"6bbaabffaf483b881a5bfb535bdf7f3ae67d460b","user":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66672315,"name":"klb","full_name":"NeowayLabs/klb","owner":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NeowayLabs/klb","description":"Nash library to your automate cloud infrastructure (AWS/Azure)","fork":false,"url":"https://api.github.com/repos/NeowayLabs/klb","forks_url":"https://api.github.com/repos/NeowayLabs/klb/forks","keys_url":"https://api.github.com/repos/NeowayLabs/klb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NeowayLabs/klb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NeowayLabs/klb/teams","hooks_url":"https://api.github.com/repos/NeowayLabs/klb/hooks","issue_events_url":"https://api.github.com/repos/NeowayLabs/klb/issues/events{/number}","events_url":"https://api.github.com/repos/NeowayLabs/klb/events","assignees_url":"https://api.github.com/repos/NeowayLabs/klb/assignees{/user}","branches_url":"https://api.github.com/repos/NeowayLabs/klb/branches{/branch}","tags_url":"https://api.github.com/repos/NeowayLabs/klb/tags","blobs_url":"https://api.github.com/repos/NeowayLabs/klb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NeowayLabs/klb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NeowayLabs/klb/git/refs{/sha}","trees_url":"https://api.github.com/repos/NeowayLabs/klb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NeowayLabs/klb/statuses/{sha}","languages_url":"https://api.github.com/repos/NeowayLabs/klb/languages","stargazers_url":"https://api.github.com/repos/NeowayLabs/klb/stargazers","contributors_url":"https://api.github.com/repos/NeowayLabs/klb/contributors","subscribers_url":"https://api.github.com/repos/NeowayLabs/klb/subscribers","subscription_url":"https://api.github.com/repos/NeowayLabs/klb/subscription","commits_url":"https://api.github.com/repos/NeowayLabs/klb/commits{/sha}","git_commits_url":"https://api.github.com/repos/NeowayLabs/klb/git/commits{/sha}","comments_url":"https://api.github.com/repos/NeowayLabs/klb/comments{/number}","issue_comment_url":"https://api.github.com/repos/NeowayLabs/klb/issues/comments{/number}","contents_url":"https://api.github.com/repos/NeowayLabs/klb/contents/{+path}","compare_url":"https://api.github.com/repos/NeowayLabs/klb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NeowayLabs/klb/merges","archive_url":"https://api.github.com/repos/NeowayLabs/klb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NeowayLabs/klb/downloads","issues_url":"https://api.github.com/repos/NeowayLabs/klb/issues{/number}","pulls_url":"https://api.github.com/repos/NeowayLabs/klb/pulls{/number}","milestones_url":"https://api.github.com/repos/NeowayLabs/klb/milestones{/number}","notifications_url":"https://api.github.com/repos/NeowayLabs/klb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NeowayLabs/klb/labels{/name}","releases_url":"https://api.github.com/repos/NeowayLabs/klb/releases{/id}","deployments_url":"https://api.github.com/repos/NeowayLabs/klb/deployments","created_at":"2016-08-26T18:58:07Z","updated_at":"2016-11-11T20:04:44Z","pushed_at":"2016-11-12T14:44:14Z","git_url":"git://github.com/NeowayLabs/klb.git","ssh_url":"git@github.com:NeowayLabs/klb.git","clone_url":"https://github.com/NeowayLabs/klb.git","svn_url":"https://github.com/NeowayLabs/klb","homepage":"","size":81,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"NeowayLabs:master","ref":"master","sha":"61fd473cdeeab2b380d5a8224ad9a71718fa14f5","user":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":66672315,"name":"klb","full_name":"NeowayLabs/klb","owner":{"login":"NeowayLabs","id":10208250,"avatar_url":"https://avatars.githubusercontent.com/u/10208250?v=3","gravatar_id":"","url":"https://api.github.com/users/NeowayLabs","html_url":"https://github.com/NeowayLabs","followers_url":"https://api.github.com/users/NeowayLabs/followers","following_url":"https://api.github.com/users/NeowayLabs/following{/other_user}","gists_url":"https://api.github.com/users/NeowayLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NeowayLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeowayLabs/subscriptions","organizations_url":"https://api.github.com/users/NeowayLabs/orgs","repos_url":"https://api.github.com/users/NeowayLabs/repos","events_url":"https://api.github.com/users/NeowayLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NeowayLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NeowayLabs/klb","description":"Nash library to your automate cloud infrastructure (AWS/Azure)","fork":false,"url":"https://api.github.com/repos/NeowayLabs/klb","forks_url":"https://api.github.com/repos/NeowayLabs/klb/forks","keys_url":"https://api.github.com/repos/NeowayLabs/klb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NeowayLabs/klb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NeowayLabs/klb/teams","hooks_url":"https://api.github.com/repos/NeowayLabs/klb/hooks","issue_events_url":"https://api.github.com/repos/NeowayLabs/klb/issues/events{/number}","events_url":"https://api.github.com/repos/NeowayLabs/klb/events","assignees_url":"https://api.github.com/repos/NeowayLabs/klb/assignees{/user}","branches_url":"https://api.github.com/repos/NeowayLabs/klb/branches{/branch}","tags_url":"https://api.github.com/repos/NeowayLabs/klb/tags","blobs_url":"https://api.github.com/repos/NeowayLabs/klb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NeowayLabs/klb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NeowayLabs/klb/git/refs{/sha}","trees_url":"https://api.github.com/repos/NeowayLabs/klb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NeowayLabs/klb/statuses/{sha}","languages_url":"https://api.github.com/repos/NeowayLabs/klb/languages","stargazers_url":"https://api.github.com/repos/NeowayLabs/klb/stargazers","contributors_url":"https://api.github.com/repos/NeowayLabs/klb/contributors","subscribers_url":"https://api.github.com/repos/NeowayLabs/klb/subscribers","subscription_url":"https://api.github.com/repos/NeowayLabs/klb/subscription","commits_url":"https://api.github.com/repos/NeowayLabs/klb/commits{/sha}","git_commits_url":"https://api.github.com/repos/NeowayLabs/klb/git/commits{/sha}","comments_url":"https://api.github.com/repos/NeowayLabs/klb/comments{/number}","issue_comment_url":"https://api.github.com/repos/NeowayLabs/klb/issues/comments{/number}","contents_url":"https://api.github.com/repos/NeowayLabs/klb/contents/{+path}","compare_url":"https://api.github.com/repos/NeowayLabs/klb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NeowayLabs/klb/merges","archive_url":"https://api.github.com/repos/NeowayLabs/klb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NeowayLabs/klb/downloads","issues_url":"https://api.github.com/repos/NeowayLabs/klb/issues{/number}","pulls_url":"https://api.github.com/repos/NeowayLabs/klb/pulls{/number}","milestones_url":"https://api.github.com/repos/NeowayLabs/klb/milestones{/number}","notifications_url":"https://api.github.com/repos/NeowayLabs/klb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NeowayLabs/klb/labels{/name}","releases_url":"https://api.github.com/repos/NeowayLabs/klb/releases{/id}","deployments_url":"https://api.github.com/repos/NeowayLabs/klb/deployments","created_at":"2016-08-26T18:58:07Z","updated_at":"2016-11-11T20:04:44Z","pushed_at":"2016-11-12T14:44:14Z","git_url":"git://github.com/NeowayLabs/klb.git","ssh_url":"git@github.com:NeowayLabs/klb.git","clone_url":"https://github.com/NeowayLabs/klb.git","svn_url":"https://github.com/NeowayLabs/klb","homepage":"","size":81,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/10"},"html":{"href":"https://github.com/NeowayLabs/klb/pull/10"},"issue":{"href":"https://api.github.com/repos/NeowayLabs/klb/issues/10"},"comments":{"href":"https://api.github.com/repos/NeowayLabs/klb/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NeowayLabs/klb/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/NeowayLabs/klb/statuses/6bbaabffaf483b881a5bfb535bdf7f3ae67d460b"}}}}
{"actor":{"display_login":"katcipis"}}