{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5229","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5229/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5229/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5229/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/5229","id":145271014,"number":5229,"title":"netdev ethernet: deal with too small packet buffer","user":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Device%20driver","name":"Device driver","color":"aaffff"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/GNRC","name":"GNRC","color":"d4c5f9"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/NEEDS%20SQUASHING","name":"NEEDS SQUASHING","color":"009800"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/network","name":"network","color":"8f00cc"},{"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Request%20for%20Comments","name":"Request for Comments","color":"23F823"}],"state":"open","locked":false,"assignee":{"login":"LudwigKnuepfer","id":3739173,"avatar_url":"https://avatars.githubusercontent.com/u/3739173?v=3","gravatar_id":"","url":"https://api.github.com/users/LudwigKnuepfer","html_url":"https://github.com/LudwigKnuepfer","followers_url":"https://api.github.com/users/LudwigKnuepfer/followers","following_url":"https://api.github.com/users/LudwigKnuepfer/following{/other_user}","gists_url":"https://api.github.com/users/LudwigKnuepfer/gists{/gist_id}","starred_url":"https://api.github.com/users/LudwigKnuepfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LudwigKnuepfer/subscriptions","organizations_url":"https://api.github.com/users/LudwigKnuepfer/orgs","repos_url":"https://api.github.com/users/LudwigKnuepfer/repos","events_url":"https://api.github.com/users/LudwigKnuepfer/events{/privacy}","received_events_url":"https://api.github.com/users/LudwigKnuepfer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/13","html_url":"https://github.com/RIOT-OS/RIOT/milestones/Release%202016.04","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/13/labels","id":1447832,"number":13,"title":"Release 2016.04","description":"The next major release.","creator":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":434,"state":"open","created_at":"2015-12-07T14:56:18Z","updated_at":"2016-04-08T11:36:11Z","due_on":"2016-04-14T22:00:00Z","closed_at":null},"comments":42,"created_at":"2016-04-01T19:58:13Z","updated_at":"2016-04-08T11:58:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5229","html_url":"https://github.com/RIOT-OS/RIOT/pull/5229","diff_url":"https://github.com/RIOT-OS/RIOT/pull/5229.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/5229.patch"},"body":"~~Rationale: some drivers, e.g. the Ethernet drivers, require a minimum size for the packet buffer. This commit introduces an optional minimal size that can be overwritten from the application.~~\r\n\r\n~~I reworked this PR to introduce a temporary buffer inside the Ethernet drivers themselves, instead of reallocating on the packet buffer. IMO that's a cleaner solution as it reduces the lines of code and makes it simpler. It introduces more statically allocated memory, but this memory is necessary with the current implementation anyway (it just moves from pktbuf to the driver), but at least fails at build time if not available.~~\r\n\r\nLet the native port check for a too small pktbuf size and adjust it.\r\n\r\nAdditionally this PR removes the (now not longer needed) hack from `gnrc_minimal_networking`'s Makefile and handle native the same as any other platform.\r\n\r\nWithout this PR the default example won't work on native (or other boards with an Ethernet device). Thanks for reporting, @LudwigKnuepfer."},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/207399805","html_url":"https://github.com/RIOT-OS/RIOT/pull/5229#issuecomment-207399805","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5229","id":207399805,"user":{"login":"OlegHahm","id":1590423,"avatar_url":"https://avatars.githubusercontent.com/u/1590423?v=3","gravatar_id":"","url":"https://api.github.com/users/OlegHahm","html_url":"https://github.com/OlegHahm","followers_url":"https://api.github.com/users/OlegHahm/followers","following_url":"https://api.github.com/users/OlegHahm/following{/other_user}","gists_url":"https://api.github.com/users/OlegHahm/gists{/gist_id}","starred_url":"https://api.github.com/users/OlegHahm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OlegHahm/subscriptions","organizations_url":"https://api.github.com/users/OlegHahm/orgs","repos_url":"https://api.github.com/users/OlegHahm/repos","events_url":"https://api.github.com/users/OlegHahm/events{/privacy}","received_events_url":"https://api.github.com/users/OlegHahm/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T11:58:00Z","updated_at":"2016-04-08T11:58:00Z","body":"@kaspar030 was against this."}}