{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-router/issues/3262","repository_url":"https://api.github.com/repos/reactjs/react-router","labels_url":"https://api.github.com/repos/reactjs/react-router/issues/3262/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-router/issues/3262/comments","events_url":"https://api.github.com/repos/reactjs/react-router/issues/3262/events","html_url":"https://github.com/reactjs/react-router/issues/3262","id":146777512,"number":3262,"title":"getComponent and getComponents should receive router state instead of location","user":{"login":"btipling","id":249641,"avatar_url":"https://avatars.githubusercontent.com/u/249641?v=3","gravatar_id":"","url":"https://api.github.com/users/btipling","html_url":"https://github.com/btipling","followers_url":"https://api.github.com/users/btipling/followers","following_url":"https://api.github.com/users/btipling/following{/other_user}","gists_url":"https://api.github.com/users/btipling/gists{/gist_id}","starred_url":"https://api.github.com/users/btipling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btipling/subscriptions","organizations_url":"https://api.github.com/users/btipling/orgs","repos_url":"https://api.github.com/users/btipling/repos","events_url":"https://api.github.com/users/btipling/events{/privacy}","received_events_url":"https://api.github.com/users/btipling/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/reactjs/react-router/labels/discussion","name":"discussion","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-08T00:16:13Z","updated_at":"2016-04-08T01:06:29Z","closed_at":null,"body":"\r\nCurrently `getComponents` return a location and not a state and I think it should return state instead.\r\nI would really think it would be easier to determine what components to return from getComponents if the params object was available instead of having to capture state in a closure or parse location manually.\r\n"},"comment":{"url":"https://api.github.com/repos/reactjs/react-router/issues/comments/207157588","html_url":"https://github.com/reactjs/react-router/issues/3262#issuecomment-207157588","issue_url":"https://api.github.com/repos/reactjs/react-router/issues/3262","id":207157588,"user":{"login":"taion","id":3112159,"avatar_url":"https://avatars.githubusercontent.com/u/3112159?v=3","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T01:06:29Z","updated_at":"2016-04-08T01:06:29Z","body":"This is somewhat related to #3232 in privileging `getComponent` over the route-based async hooks, which should generally not be used. I also mentioned this issue to @KyleAMathews after https://github.com/reactjs/react-router/issues/3215 to allow resolving based on the matched parameters in `getComponent`, but hadn't realized that it would be possible to do a reasonable deprecation here until a couple of days ago."}}