{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1476","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1476/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1476/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1476/events","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1476","id":170303764,"number":1476,"title":"Introduce Gapic-generated files for language API.","user":{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2016-08-10T00:43:06Z","updated_at":"2016-08-18T15:03:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/pulls/1476","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1476","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1476.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1476.patch"},"body":"- language_service_api.js and language_service_client_config.json:\r\n  auto-generated\r\n- v1beta1/index.js: manually written\r\n- index.js and package.json: manually modified\r\n\r\nUpdates #1463"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/comments/240751768","html_url":"https://github.com/GoogleCloudPlatform/gcloud-node/pull/1476#issuecomment-240751768","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-node/issues/1476","id":240751768,"user":{"login":"callmehiphop","id":1707267,"avatar_url":"https://avatars.githubusercontent.com/u/1707267?v=3","gravatar_id":"","url":"https://api.github.com/users/callmehiphop","html_url":"https://github.com/callmehiphop","followers_url":"https://api.github.com/users/callmehiphop/followers","following_url":"https://api.github.com/users/callmehiphop/following{/other_user}","gists_url":"https://api.github.com/users/callmehiphop/gists{/gist_id}","starred_url":"https://api.github.com/users/callmehiphop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callmehiphop/subscriptions","organizations_url":"https://api.github.com/users/callmehiphop/orgs","repos_url":"https://api.github.com/users/callmehiphop/repos","events_url":"https://api.github.com/users/callmehiphop/events{/privacy}","received_events_url":"https://api.github.com/users/callmehiphop/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T15:03:21Z","updated_at":"2016-08-18T15:03:21Z","body":"A little late to the party, so please forgive me. I kinda think that the version being a method name is a little confusing - only because it could imply that it's loading a different version of our library when in reality they'll have a lot of differences.\r\n\r\nWhat about something like..\r\n\r\n```js\r\nvar languageGrpc = require('@google-cloud/language').grpc({\r\n  version: 'v1beta1',\r\n  projectId: 'grape-spaceship-123',\r\n  keyFilename: '/Users/stephen/dev/keyfile.json'\r\n});\r\n\r\nvar language = languageGrpc.languageServiceApi();\r\n\r\nlanguage.analyzeEntities(..., function(err, apiResponse) {});\r\n```\r\n\r\nAlthough my concern can probably be remedied easily with clear documentation. So aside from that LGTM!"}}
{"actor":{"display_login":"callmehiphop"}}