{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/comments/60888615","id":60888615,"diff_hunk":"@@ -410,16 +420,17 @@ void fillMatrices(boost::shared_ptr<MayaObject> obj, renderer::TransformSequence\n     }\n }\n \n-void fillTransformMatrices(boost::shared_ptr<MayaObject> obj, renderer::Light *light)\n+void fillTransformMatrices(const MayaObject* obj, renderer::Light* light)\n {\n+    std::vector<MMatrix> transformMatrices = obj->transformMatrices;","path":"src/appleseedutils.cpp","position":299,"original_position":299,"commit_id":"7b6c76165b51b90900093cff16827b88ed7ac743","original_commit_id":"7b6c76165b51b90900093cff16827b88ed7ac743","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars.githubusercontent.com/u/321290?v=3","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"Assign in the `else` block of the `if` below.","created_at":"2016-04-25T09:56:42Z","updated_at":"2016-04-25T09:56:42Z","html_url":"https://github.com/appleseedhq/appleseed-maya/pull/80#discussion_r60888615","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/comments/60888615"},"html":{"href":"https://github.com/appleseedhq/appleseed-maya/pull/80#discussion_r60888615"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80","id":67640723,"html_url":"https://github.com/appleseedhq/appleseed-maya/pull/80","diff_url":"https://github.com/appleseedhq/appleseed-maya/pull/80.diff","patch_url":"https://github.com/appleseedhq/appleseed-maya/pull/80.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues/80","number":80,"state":"open","locked":false,"title":"Callbacks refactorings","user":{"login":"haggi","id":1830366,"avatar_url":"https://avatars.githubusercontent.com/u/1830366?v=3","gravatar_id":"","url":"https://api.github.com/users/haggi","html_url":"https://github.com/haggi","followers_url":"https://api.github.com/users/haggi/followers","following_url":"https://api.github.com/users/haggi/following{/other_user}","gists_url":"https://api.github.com/users/haggi/gists{/gist_id}","starred_url":"https://api.github.com/users/haggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haggi/subscriptions","organizations_url":"https://api.github.com/users/haggi/orgs","repos_url":"https://api.github.com/users/haggi/repos","events_url":"https://api.github.com/users/haggi/events{/privacy}","received_events_url":"https://api.github.com/users/haggi/received_events","type":"User","site_admin":false},"body":"Based on our callbacks refactoring last week, I implemented object addition and deletion in IPR. Do do it, I had to refactor parts of the appleseedutils and the assembly/assembly_instance creation.\r\nIn the appleseedutils I mostly used pointers instead of boost::smart pointers, is this okay?","created_at":"2016-04-24T15:37:16Z","updated_at":"2016-04-25T09:56:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea3107cb10962ca400ce07dac365addcaa319c06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues/80/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/statuses/7b6c76165b51b90900093cff16827b88ed7ac743","head":{"label":"haggi:CallbacksRefactorings","ref":"CallbacksRefactorings","sha":"7b6c76165b51b90900093cff16827b88ed7ac743","user":{"login":"haggi","id":1830366,"avatar_url":"https://avatars.githubusercontent.com/u/1830366?v=3","gravatar_id":"","url":"https://api.github.com/users/haggi","html_url":"https://github.com/haggi","followers_url":"https://api.github.com/users/haggi/followers","following_url":"https://api.github.com/users/haggi/following{/other_user}","gists_url":"https://api.github.com/users/haggi/gists{/gist_id}","starred_url":"https://api.github.com/users/haggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haggi/subscriptions","organizations_url":"https://api.github.com/users/haggi/orgs","repos_url":"https://api.github.com/users/haggi/repos","events_url":"https://api.github.com/users/haggi/events{/privacy}","received_events_url":"https://api.github.com/users/haggi/received_events","type":"User","site_admin":false},"repo":{"id":50856315,"name":"appleseed-maya","full_name":"haggi/appleseed-maya","owner":{"login":"haggi","id":1830366,"avatar_url":"https://avatars.githubusercontent.com/u/1830366?v=3","gravatar_id":"","url":"https://api.github.com/users/haggi","html_url":"https://github.com/haggi","followers_url":"https://api.github.com/users/haggi/followers","following_url":"https://api.github.com/users/haggi/following{/other_user}","gists_url":"https://api.github.com/users/haggi/gists{/gist_id}","starred_url":"https://api.github.com/users/haggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haggi/subscriptions","organizations_url":"https://api.github.com/users/haggi/orgs","repos_url":"https://api.github.com/users/haggi/repos","events_url":"https://api.github.com/users/haggi/events{/privacy}","received_events_url":"https://api.github.com/users/haggi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haggi/appleseed-maya","description":"appleseed plugin for Autodesk Maya","fork":true,"url":"https://api.github.com/repos/haggi/appleseed-maya","forks_url":"https://api.github.com/repos/haggi/appleseed-maya/forks","keys_url":"https://api.github.com/repos/haggi/appleseed-maya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haggi/appleseed-maya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haggi/appleseed-maya/teams","hooks_url":"https://api.github.com/repos/haggi/appleseed-maya/hooks","issue_events_url":"https://api.github.com/repos/haggi/appleseed-maya/issues/events{/number}","events_url":"https://api.github.com/repos/haggi/appleseed-maya/events","assignees_url":"https://api.github.com/repos/haggi/appleseed-maya/assignees{/user}","branches_url":"https://api.github.com/repos/haggi/appleseed-maya/branches{/branch}","tags_url":"https://api.github.com/repos/haggi/appleseed-maya/tags","blobs_url":"https://api.github.com/repos/haggi/appleseed-maya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haggi/appleseed-maya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haggi/appleseed-maya/git/refs{/sha}","trees_url":"https://api.github.com/repos/haggi/appleseed-maya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haggi/appleseed-maya/statuses/{sha}","languages_url":"https://api.github.com/repos/haggi/appleseed-maya/languages","stargazers_url":"https://api.github.com/repos/haggi/appleseed-maya/stargazers","contributors_url":"https://api.github.com/repos/haggi/appleseed-maya/contributors","subscribers_url":"https://api.github.com/repos/haggi/appleseed-maya/subscribers","subscription_url":"https://api.github.com/repos/haggi/appleseed-maya/subscription","commits_url":"https://api.github.com/repos/haggi/appleseed-maya/commits{/sha}","git_commits_url":"https://api.github.com/repos/haggi/appleseed-maya/git/commits{/sha}","comments_url":"https://api.github.com/repos/haggi/appleseed-maya/comments{/number}","issue_comment_url":"https://api.github.com/repos/haggi/appleseed-maya/issues/comments{/number}","contents_url":"https://api.github.com/repos/haggi/appleseed-maya/contents/{+path}","compare_url":"https://api.github.com/repos/haggi/appleseed-maya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haggi/appleseed-maya/merges","archive_url":"https://api.github.com/repos/haggi/appleseed-maya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haggi/appleseed-maya/downloads","issues_url":"https://api.github.com/repos/haggi/appleseed-maya/issues{/number}","pulls_url":"https://api.github.com/repos/haggi/appleseed-maya/pulls{/number}","milestones_url":"https://api.github.com/repos/haggi/appleseed-maya/milestones{/number}","notifications_url":"https://api.github.com/repos/haggi/appleseed-maya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haggi/appleseed-maya/labels{/name}","releases_url":"https://api.github.com/repos/haggi/appleseed-maya/releases{/id}","deployments_url":"https://api.github.com/repos/haggi/appleseed-maya/deployments","created_at":"2016-02-01T17:15:48Z","updated_at":"2016-02-01T17:15:50Z","pushed_at":"2016-04-24T15:32:16Z","git_url":"git://github.com/haggi/appleseed-maya.git","ssh_url":"git@github.com:haggi/appleseed-maya.git","clone_url":"https://github.com/haggi/appleseed-maya.git","svn_url":"https://github.com/haggi/appleseed-maya","homepage":"","size":2607,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"781a5a82097194fa79383ddc7e087be97117695f","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":48388718,"name":"appleseed-maya","full_name":"appleseedhq/appleseed-maya","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars.githubusercontent.com/u/6373510?v=3","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed-maya","description":"appleseed plugin for Autodesk Maya","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed-maya","forks_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed-maya/deployments","created_at":"2015-12-21T18:57:23Z","updated_at":"2016-03-02T13:52:14Z","pushed_at":"2016-04-24T15:37:17Z","git_url":"git://github.com/appleseedhq/appleseed-maya.git","ssh_url":"git@github.com:appleseedhq/appleseed-maya.git","clone_url":"https://github.com/appleseedhq/appleseed-maya.git","svn_url":"https://github.com/appleseedhq/appleseed-maya","homepage":"","size":2589,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80"},"html":{"href":"https://github.com/appleseedhq/appleseed-maya/pull/80"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues/80"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed-maya/statuses/7b6c76165b51b90900093cff16827b88ed7ac743"}}}}