{"action":"created","comment":{"url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments/68886313","id":68886313,"diff_hunk":"@@ -10,7 +9,7 @@ import rootReducer from '../reducers'\n \n const finalCreateStore = compose(\n   applyMiddleware(thunk, api),\n-  reduxReactRouter({ routes, createHistory }),\n+  reduxReactRouter({ routes, createBrowserHistory }),","path":"src/store/configureStore.dev.js","position":14,"original_position":14,"commit_id":"befd7070283404e0e299541943cdc97545e116df","original_commit_id":"befd7070283404e0e299541943cdc97545e116df","user":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"body":"Yes, I need modify my wrong code tonight.","created_at":"2016-06-29T05:11:12Z","updated_at":"2016-06-29T05:11:12Z","html_url":"https://github.com/twreporter/twreporter-react/pull/241#discussion_r68886313","pull_request_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments/68886313"},"html":{"href":"https://github.com/twreporter/twreporter-react/pull/241#discussion_r68886313"},"pull_request":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241","id":75496312,"html_url":"https://github.com/twreporter/twreporter-react/pull/241","diff_url":"https://github.com/twreporter/twreporter-react/pull/241.diff","patch_url":"https://github.com/twreporter/twreporter-react/pull/241.patch","issue_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/241","number":241,"state":"open","locked":false,"title":"Upgrade react / redux / react-router","user":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"body":"做了 upgrade branch，純參考。\r\n若目前無升級的打算，可不 merge；若考慮升級但 branch 有未盡之處，可提出我再嘗試改。\r\n\r\n## Steps\r\n從 revamp 衍生 https://github.com/aqutw/twreporter-react/commits/upgrade_react-router \r\n--> 升級 + 改 code (原實驗放在 https://github.com/aqutw/react-15-react-router_upgrade/commits/r15rr2 )\r\n\r\n從 upgrade_react-router 衍生 https://github.com/aqutw/twreporter-react/commits/upgrade_react_n_redux\r\n--> 僅升級 npm 即可(?lucky)\r\n\r\n## Result1\r\n有小測過，跟 revamp 現況一樣。\r\n\r\n## Result2\r\n黃色 warning \"Can't make class AlignedBlockQuote hot reloadable due to being read-only\" \r\n出自 react-hot-loader --- 見 https://github.com/gaearon/react-hot-loader/issues/158#issuecomment-222582396\r\n> Have tried all the solutions in this thread, nothing works to remove the warning. However, hot reloading is working as expected for the relevant components.\r\n\r\n目前沒打算糾結它 ( 因只用於 dev、不用在 production)。\r\n\r\n\r\n\r\n\r\n\r\nThanks reviewing!","created_at":"2016-06-28T15:18:51Z","updated_at":"2016-06-29T05:11:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f6be3dadaa3b2085db054d6913b18744110b4cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241/commits","review_comments_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241/comments","review_comment_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/241/comments","statuses_url":"https://api.github.com/repos/twreporter/twreporter-react/statuses/befd7070283404e0e299541943cdc97545e116df","head":{"label":"aqutw:upgrade_react_n_redux","ref":"upgrade_react_n_redux","sha":"befd7070283404e0e299541943cdc97545e116df","user":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"repo":{"id":61996519,"name":"twreporter-react","full_name":"aqutw/twreporter-react","owner":{"login":"aqutw","id":7347009,"avatar_url":"https://avatars.githubusercontent.com/u/7347009?v=3","gravatar_id":"","url":"https://api.github.com/users/aqutw","html_url":"https://github.com/aqutw","followers_url":"https://api.github.com/users/aqutw/followers","following_url":"https://api.github.com/users/aqutw/following{/other_user}","gists_url":"https://api.github.com/users/aqutw/gists{/gist_id}","starred_url":"https://api.github.com/users/aqutw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aqutw/subscriptions","organizations_url":"https://api.github.com/users/aqutw/orgs","repos_url":"https://api.github.com/users/aqutw/repos","events_url":"https://api.github.com/users/aqutw/events{/privacy}","received_events_url":"https://api.github.com/users/aqutw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aqutw/twreporter-react","description":"twreporter site with node.js","fork":true,"url":"https://api.github.com/repos/aqutw/twreporter-react","forks_url":"https://api.github.com/repos/aqutw/twreporter-react/forks","keys_url":"https://api.github.com/repos/aqutw/twreporter-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aqutw/twreporter-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aqutw/twreporter-react/teams","hooks_url":"https://api.github.com/repos/aqutw/twreporter-react/hooks","issue_events_url":"https://api.github.com/repos/aqutw/twreporter-react/issues/events{/number}","events_url":"https://api.github.com/repos/aqutw/twreporter-react/events","assignees_url":"https://api.github.com/repos/aqutw/twreporter-react/assignees{/user}","branches_url":"https://api.github.com/repos/aqutw/twreporter-react/branches{/branch}","tags_url":"https://api.github.com/repos/aqutw/twreporter-react/tags","blobs_url":"https://api.github.com/repos/aqutw/twreporter-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aqutw/twreporter-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aqutw/twreporter-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/aqutw/twreporter-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aqutw/twreporter-react/statuses/{sha}","languages_url":"https://api.github.com/repos/aqutw/twreporter-react/languages","stargazers_url":"https://api.github.com/repos/aqutw/twreporter-react/stargazers","contributors_url":"https://api.github.com/repos/aqutw/twreporter-react/contributors","subscribers_url":"https://api.github.com/repos/aqutw/twreporter-react/subscribers","subscription_url":"https://api.github.com/repos/aqutw/twreporter-react/subscription","commits_url":"https://api.github.com/repos/aqutw/twreporter-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/aqutw/twreporter-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/aqutw/twreporter-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/aqutw/twreporter-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/aqutw/twreporter-react/contents/{+path}","compare_url":"https://api.github.com/repos/aqutw/twreporter-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aqutw/twreporter-react/merges","archive_url":"https://api.github.com/repos/aqutw/twreporter-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aqutw/twreporter-react/downloads","issues_url":"https://api.github.com/repos/aqutw/twreporter-react/issues{/number}","pulls_url":"https://api.github.com/repos/aqutw/twreporter-react/pulls{/number}","milestones_url":"https://api.github.com/repos/aqutw/twreporter-react/milestones{/number}","notifications_url":"https://api.github.com/repos/aqutw/twreporter-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aqutw/twreporter-react/labels{/name}","releases_url":"https://api.github.com/repos/aqutw/twreporter-react/releases{/id}","deployments_url":"https://api.github.com/repos/aqutw/twreporter-react/deployments","created_at":"2016-06-26T15:55:02Z","updated_at":"2016-06-26T15:55:03Z","pushed_at":"2016-06-28T15:03:26Z","git_url":"git://github.com/aqutw/twreporter-react.git","ssh_url":"git@github.com:aqutw/twreporter-react.git","clone_url":"https://github.com/aqutw/twreporter-react.git","svn_url":"https://github.com/aqutw/twreporter-react","homepage":null,"size":6522,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twreporter:revamp","ref":"revamp","sha":"ad0dd28f574de62dbf0e6b8b3a21255c36aacb6d","user":{"login":"twreporter","id":13784512,"avatar_url":"https://avatars.githubusercontent.com/u/13784512?v=3","gravatar_id":"","url":"https://api.github.com/users/twreporter","html_url":"https://github.com/twreporter","followers_url":"https://api.github.com/users/twreporter/followers","following_url":"https://api.github.com/users/twreporter/following{/other_user}","gists_url":"https://api.github.com/users/twreporter/gists{/gist_id}","starred_url":"https://api.github.com/users/twreporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twreporter/subscriptions","organizations_url":"https://api.github.com/users/twreporter/orgs","repos_url":"https://api.github.com/users/twreporter/repos","events_url":"https://api.github.com/users/twreporter/events{/privacy}","received_events_url":"https://api.github.com/users/twreporter/received_events","type":"Organization","site_admin":false},"repo":{"id":43805497,"name":"twreporter-react","full_name":"twreporter/twreporter-react","owner":{"login":"twreporter","id":13784512,"avatar_url":"https://avatars.githubusercontent.com/u/13784512?v=3","gravatar_id":"","url":"https://api.github.com/users/twreporter","html_url":"https://github.com/twreporter","followers_url":"https://api.github.com/users/twreporter/followers","following_url":"https://api.github.com/users/twreporter/following{/other_user}","gists_url":"https://api.github.com/users/twreporter/gists{/gist_id}","starred_url":"https://api.github.com/users/twreporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twreporter/subscriptions","organizations_url":"https://api.github.com/users/twreporter/orgs","repos_url":"https://api.github.com/users/twreporter/repos","events_url":"https://api.github.com/users/twreporter/events{/privacy}","received_events_url":"https://api.github.com/users/twreporter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twreporter/twreporter-react","description":"twreporter site with node.js","fork":false,"url":"https://api.github.com/repos/twreporter/twreporter-react","forks_url":"https://api.github.com/repos/twreporter/twreporter-react/forks","keys_url":"https://api.github.com/repos/twreporter/twreporter-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twreporter/twreporter-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twreporter/twreporter-react/teams","hooks_url":"https://api.github.com/repos/twreporter/twreporter-react/hooks","issue_events_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/events{/number}","events_url":"https://api.github.com/repos/twreporter/twreporter-react/events","assignees_url":"https://api.github.com/repos/twreporter/twreporter-react/assignees{/user}","branches_url":"https://api.github.com/repos/twreporter/twreporter-react/branches{/branch}","tags_url":"https://api.github.com/repos/twreporter/twreporter-react/tags","blobs_url":"https://api.github.com/repos/twreporter/twreporter-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twreporter/twreporter-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twreporter/twreporter-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/twreporter/twreporter-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twreporter/twreporter-react/statuses/{sha}","languages_url":"https://api.github.com/repos/twreporter/twreporter-react/languages","stargazers_url":"https://api.github.com/repos/twreporter/twreporter-react/stargazers","contributors_url":"https://api.github.com/repos/twreporter/twreporter-react/contributors","subscribers_url":"https://api.github.com/repos/twreporter/twreporter-react/subscribers","subscription_url":"https://api.github.com/repos/twreporter/twreporter-react/subscription","commits_url":"https://api.github.com/repos/twreporter/twreporter-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/twreporter/twreporter-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/twreporter/twreporter-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/twreporter/twreporter-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/twreporter/twreporter-react/contents/{+path}","compare_url":"https://api.github.com/repos/twreporter/twreporter-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twreporter/twreporter-react/merges","archive_url":"https://api.github.com/repos/twreporter/twreporter-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twreporter/twreporter-react/downloads","issues_url":"https://api.github.com/repos/twreporter/twreporter-react/issues{/number}","pulls_url":"https://api.github.com/repos/twreporter/twreporter-react/pulls{/number}","milestones_url":"https://api.github.com/repos/twreporter/twreporter-react/milestones{/number}","notifications_url":"https://api.github.com/repos/twreporter/twreporter-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twreporter/twreporter-react/labels{/name}","releases_url":"https://api.github.com/repos/twreporter/twreporter-react/releases{/id}","deployments_url":"https://api.github.com/repos/twreporter/twreporter-react/deployments","created_at":"2015-10-07T09:12:39Z","updated_at":"2016-06-25T13:42:21Z","pushed_at":"2016-06-28T15:18:51Z","git_url":"git://github.com/twreporter/twreporter-react.git","ssh_url":"git@github.com:twreporter/twreporter-react.git","clone_url":"https://github.com/twreporter/twreporter-react.git","svn_url":"https://github.com/twreporter/twreporter-react","homepage":null,"size":6642,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":9,"forks":36,"open_issues":9,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241"},"html":{"href":"https://github.com/twreporter/twreporter-react/pull/241"},"issue":{"href":"https://api.github.com/repos/twreporter/twreporter-react/issues/241"},"comments":{"href":"https://api.github.com/repos/twreporter/twreporter-react/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twreporter/twreporter-react/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/twreporter/twreporter-react/statuses/befd7070283404e0e299541943cdc97545e116df"}}}}
{"actor":{"display_login":"aqutw"}}