{"action":"created","comment":{"url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments/62818673","id":62818673,"diff_hunk":"@@ -43,7 +43,8 @@\n     private boolean _distributedExecution;\n     private String _dateForOneTimeSchedule;\n \tprivate Map<String,String> _jobMetadataProperties;\n-    private boolean _runOnHadoop; \n+    private boolean _runOnHadoop;\n+    private String _hotFolder;","path":"monitor/api/src/main/java/org/datacleaner/monitor/scheduling/model/ScheduleDefinition.java","position":6,"original_position":6,"commit_id":"fca3f971d3a173a5d10d20cd33e888102dae9435","original_commit_id":"fca3f971d3a173a5d10d20cd33e888102dae9435","user":{"login":"LosD","id":1282832,"avatar_url":"https://avatars.githubusercontent.com/u/1282832?v=3","gravatar_id":"","url":"https://api.github.com/users/LosD","html_url":"https://github.com/LosD","followers_url":"https://api.github.com/users/LosD/followers","following_url":"https://api.github.com/users/LosD/following{/other_user}","gists_url":"https://api.github.com/users/LosD/gists{/gist_id}","starred_url":"https://api.github.com/users/LosD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LosD/subscriptions","organizations_url":"https://api.github.com/users/LosD/orgs","repos_url":"https://api.github.com/users/LosD/repos","events_url":"https://api.github.com/users/LosD/events{/privacy}","received_events_url":"https://api.github.com/users/LosD/received_events","type":"User","site_admin":false},"body":"Not on you, but why in the world does Git/Github think that the _runOnHadoop line has changed?","created_at":"2016-05-11T09:39:19Z","updated_at":"2016-05-11T09:39:19Z","html_url":"https://github.com/datacleaner/DataCleaner/pull/1333#discussion_r62818673","pull_request_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333","_links":{"self":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments/62818673"},"html":{"href":"https://github.com/datacleaner/DataCleaner/pull/1333#discussion_r62818673"},"pull_request":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333"}}},"pull_request":{"url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333","id":69640336,"html_url":"https://github.com/datacleaner/DataCleaner/pull/1333","diff_url":"https://github.com/datacleaner/DataCleaner/pull/1333.diff","patch_url":"https://github.com/datacleaner/DataCleaner/pull/1333.patch","issue_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1333","number":1333,"state":"open","locked":false,"title":"Hot folder monitoring","user":{"login":"arjansh","id":16542747,"avatar_url":"https://avatars.githubusercontent.com/u/16542747?v=3","gravatar_id":"","url":"https://api.github.com/users/arjansh","html_url":"https://github.com/arjansh","followers_url":"https://api.github.com/users/arjansh/followers","following_url":"https://api.github.com/users/arjansh/following{/other_user}","gists_url":"https://api.github.com/users/arjansh/gists{/gist_id}","starred_url":"https://api.github.com/users/arjansh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjansh/subscriptions","organizations_url":"https://api.github.com/users/arjansh/orgs","repos_url":"https://api.github.com/users/arjansh/repos","events_url":"https://api.github.com/users/arjansh/events{/privacy}","received_events_url":"https://api.github.com/users/arjansh/received_events","type":"User","site_admin":false},"body":"Fixes #1329.\r\n\r\nSome things which may need special attention when reviewing this pull request:\r\n\r\n- The ScheduleServiceImpl now spawns a `org.apache.commons.io.monitor.FileAlterationMonitor` instance on construction, which spawns a monitoring thread in the initialize method. Please check if the implementation doesn't introduce memory leaks or keeps unwanted references to objects.\r\n- The hot folder monitor is quite trigger happy, when a hot folder trigger is added to as a schedule to a job it instantly starts the job for all initial changes it detects, which may be more than one initially. Please test this and provide some feedback whether or not we want to suppress these first time triggers.\r\n- The Customize schedule dialog in DataCleaner monitor starts with a blue paragraph which describes some of different ways in which you can configure the schedule. It may be desirable to also add the hot folder trigger to this paragraph, which as yet has not been done.\r\n","created_at":"2016-05-11T09:26:38Z","updated_at":"2016-05-11T09:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"743385f252477de438015e83144354ad0e9f266b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333/commits","review_comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333/comments","review_comment_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1333/comments","statuses_url":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/fca3f971d3a173a5d10d20cd33e888102dae9435","head":{"label":"datacleaner:feature/1329-hot-folder-monitoring","ref":"feature/1329-hot-folder-monitoring","sha":"fca3f971d3a173a5d10d20cd33e888102dae9435","user":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"repo":{"id":17034809,"name":"DataCleaner","full_name":"datacleaner/DataCleaner","owner":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacleaner/DataCleaner","description":"The premier open source Data Quality solution","fork":false,"url":"https://api.github.com/repos/datacleaner/DataCleaner","forks_url":"https://api.github.com/repos/datacleaner/DataCleaner/forks","keys_url":"https://api.github.com/repos/datacleaner/DataCleaner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacleaner/DataCleaner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacleaner/DataCleaner/teams","hooks_url":"https://api.github.com/repos/datacleaner/DataCleaner/hooks","issue_events_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/events{/number}","events_url":"https://api.github.com/repos/datacleaner/DataCleaner/events","assignees_url":"https://api.github.com/repos/datacleaner/DataCleaner/assignees{/user}","branches_url":"https://api.github.com/repos/datacleaner/DataCleaner/branches{/branch}","tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/tags","blobs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/{sha}","languages_url":"https://api.github.com/repos/datacleaner/DataCleaner/languages","stargazers_url":"https://api.github.com/repos/datacleaner/DataCleaner/stargazers","contributors_url":"https://api.github.com/repos/datacleaner/DataCleaner/contributors","subscribers_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscribers","subscription_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscription","commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacleaner/DataCleaner/contents/{+path}","compare_url":"https://api.github.com/repos/datacleaner/DataCleaner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacleaner/DataCleaner/merges","archive_url":"https://api.github.com/repos/datacleaner/DataCleaner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacleaner/DataCleaner/downloads","issues_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues{/number}","pulls_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls{/number}","milestones_url":"https://api.github.com/repos/datacleaner/DataCleaner/milestones{/number}","notifications_url":"https://api.github.com/repos/datacleaner/DataCleaner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacleaner/DataCleaner/labels{/name}","releases_url":"https://api.github.com/repos/datacleaner/DataCleaner/releases{/id}","deployments_url":"https://api.github.com/repos/datacleaner/DataCleaner/deployments","created_at":"2014-02-20T20:37:25Z","updated_at":"2016-04-22T17:07:56Z","pushed_at":"2016-05-11T09:26:38Z","git_url":"git://github.com/datacleaner/DataCleaner.git","ssh_url":"git@github.com:datacleaner/DataCleaner.git","clone_url":"https://github.com/datacleaner/DataCleaner.git","svn_url":"https://github.com/datacleaner/DataCleaner","homepage":null,"size":170577,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":178,"forks":32,"open_issues":178,"watchers":59,"default_branch":"master"}},"base":{"label":"datacleaner:master","ref":"master","sha":"7b09d8ae721ed16d37d417c62945bbfd19fa1e0c","user":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"repo":{"id":17034809,"name":"DataCleaner","full_name":"datacleaner/DataCleaner","owner":{"login":"datacleaner","id":1665195,"avatar_url":"https://avatars.githubusercontent.com/u/1665195?v=3","gravatar_id":"","url":"https://api.github.com/users/datacleaner","html_url":"https://github.com/datacleaner","followers_url":"https://api.github.com/users/datacleaner/followers","following_url":"https://api.github.com/users/datacleaner/following{/other_user}","gists_url":"https://api.github.com/users/datacleaner/gists{/gist_id}","starred_url":"https://api.github.com/users/datacleaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datacleaner/subscriptions","organizations_url":"https://api.github.com/users/datacleaner/orgs","repos_url":"https://api.github.com/users/datacleaner/repos","events_url":"https://api.github.com/users/datacleaner/events{/privacy}","received_events_url":"https://api.github.com/users/datacleaner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datacleaner/DataCleaner","description":"The premier open source Data Quality solution","fork":false,"url":"https://api.github.com/repos/datacleaner/DataCleaner","forks_url":"https://api.github.com/repos/datacleaner/DataCleaner/forks","keys_url":"https://api.github.com/repos/datacleaner/DataCleaner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datacleaner/DataCleaner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datacleaner/DataCleaner/teams","hooks_url":"https://api.github.com/repos/datacleaner/DataCleaner/hooks","issue_events_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/events{/number}","events_url":"https://api.github.com/repos/datacleaner/DataCleaner/events","assignees_url":"https://api.github.com/repos/datacleaner/DataCleaner/assignees{/user}","branches_url":"https://api.github.com/repos/datacleaner/DataCleaner/branches{/branch}","tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/tags","blobs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/refs{/sha}","trees_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/{sha}","languages_url":"https://api.github.com/repos/datacleaner/DataCleaner/languages","stargazers_url":"https://api.github.com/repos/datacleaner/DataCleaner/stargazers","contributors_url":"https://api.github.com/repos/datacleaner/DataCleaner/contributors","subscribers_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscribers","subscription_url":"https://api.github.com/repos/datacleaner/DataCleaner/subscription","commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/commits{/sha}","git_commits_url":"https://api.github.com/repos/datacleaner/DataCleaner/git/commits{/sha}","comments_url":"https://api.github.com/repos/datacleaner/DataCleaner/comments{/number}","issue_comment_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues/comments{/number}","contents_url":"https://api.github.com/repos/datacleaner/DataCleaner/contents/{+path}","compare_url":"https://api.github.com/repos/datacleaner/DataCleaner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datacleaner/DataCleaner/merges","archive_url":"https://api.github.com/repos/datacleaner/DataCleaner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datacleaner/DataCleaner/downloads","issues_url":"https://api.github.com/repos/datacleaner/DataCleaner/issues{/number}","pulls_url":"https://api.github.com/repos/datacleaner/DataCleaner/pulls{/number}","milestones_url":"https://api.github.com/repos/datacleaner/DataCleaner/milestones{/number}","notifications_url":"https://api.github.com/repos/datacleaner/DataCleaner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datacleaner/DataCleaner/labels{/name}","releases_url":"https://api.github.com/repos/datacleaner/DataCleaner/releases{/id}","deployments_url":"https://api.github.com/repos/datacleaner/DataCleaner/deployments","created_at":"2014-02-20T20:37:25Z","updated_at":"2016-04-22T17:07:56Z","pushed_at":"2016-05-11T09:26:38Z","git_url":"git://github.com/datacleaner/DataCleaner.git","ssh_url":"git@github.com:datacleaner/DataCleaner.git","clone_url":"https://github.com/datacleaner/DataCleaner.git","svn_url":"https://github.com/datacleaner/DataCleaner","homepage":null,"size":170577,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":178,"forks":32,"open_issues":178,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333"},"html":{"href":"https://github.com/datacleaner/DataCleaner/pull/1333"},"issue":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1333"},"comments":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/issues/1333/comments"},"review_comments":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333/comments"},"review_comment":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/pulls/1333/commits"},"statuses":{"href":"https://api.github.com/repos/datacleaner/DataCleaner/statuses/fca3f971d3a173a5d10d20cd33e888102dae9435"}}}}