{"action":"created","issue":{"url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/issues/10","repository_url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016","labels_url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/issues/10/comments","events_url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/issues/10/events","html_url":"https://github.com/PandaStabber/Goldberg_et_al_2016/pull/10","id":138913199,"number":10,"title":"Update gridsearch params and golden files.","user":{"login":"peterthenelson","id":2358392,"avatar_url":"https://avatars.githubusercontent.com/u/2358392?v=3","gravatar_id":"","url":"https://api.github.com/users/peterthenelson","html_url":"https://github.com/peterthenelson","followers_url":"https://api.github.com/users/peterthenelson/followers","following_url":"https://api.github.com/users/peterthenelson/following{/other_user}","gists_url":"https://api.github.com/users/peterthenelson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterthenelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterthenelson/subscriptions","organizations_url":"https://api.github.com/users/peterthenelson/orgs","repos_url":"https://api.github.com/users/peterthenelson/repos","events_url":"https://api.github.com/users/peterthenelson/events{/privacy}","received_events_url":"https://api.github.com/users/peterthenelson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-07T08:06:18Z","updated_at":"2016-03-16T06:33:38Z","closed_at":"2016-03-12T12:55:28Z","pull_request":{"url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/pulls/10","html_url":"https://github.com/PandaStabber/Goldberg_et_al_2016/pull/10","diff_url":"https://github.com/PandaStabber/Goldberg_et_al_2016/pull/10.diff","patch_url":"https://github.com/PandaStabber/Goldberg_et_al_2016/pull/10.patch"},"body":"What broke the tests this morning was:\r\n- The change to the grid search params\r\n- The change to the default of using a holdout (and the test invoking that)\r\n\r\nThis change reapplies your change to the gridsearch params, and it also changes the test to use\r\ndefaults for the holdout. Then I just updated the goldens, given that nothing looked crazy. I'll let\r\nyou decide on merging this."},"comment":{"url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/issues/comments/197171452","html_url":"https://github.com/PandaStabber/Goldberg_et_al_2016/pull/10#issuecomment-197171452","issue_url":"https://api.github.com/repos/PandaStabber/Goldberg_et_al_2016/issues/10","id":197171452,"user":{"login":"peterthenelson","id":2358392,"avatar_url":"https://avatars.githubusercontent.com/u/2358392?v=3","gravatar_id":"","url":"https://api.github.com/users/peterthenelson","html_url":"https://github.com/peterthenelson","followers_url":"https://api.github.com/users/peterthenelson/followers","following_url":"https://api.github.com/users/peterthenelson/following{/other_user}","gists_url":"https://api.github.com/users/peterthenelson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterthenelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterthenelson/subscriptions","organizations_url":"https://api.github.com/users/peterthenelson/orgs","repos_url":"https://api.github.com/users/peterthenelson/repos","events_url":"https://api.github.com/users/peterthenelson/events{/privacy}","received_events_url":"https://api.github.com/users/peterthenelson/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T06:33:38Z","updated_at":"2016-03-16T06:33:38Z","body":"Answers:\r\n\r\n- Pre-commit hook: When you're in the main directory, in a shell:\r\n$ scripts/install_presubmit.sh\r\nThis will make it so when you run git commit, it will first run the presubmit. Also, if you want to just run the presubmit or the tests or lint or whatever, you just run the appropriate script directly:\r\n$ script/run_tests.sh  # runs the tests\r\n\r\n- For dropping columns, I can imagine two scenarios. Which do you want?:\r\n  - We only support some predetermined columns. Anything else in your database gets dropped.\r\n  - We will support any column unless you explicitly drop it. That column will be untransformed."}}