{"action":"created","comment":{"url":"https://api.github.com/repos/googlesamples/android-ndk/pulls/comments/76296615","id":76296615,"diff_hunk":"@@ -0,0 +1,50 @@\n+/*  This build is set for platform support ES3.\n+ *  to build for ES2:\n+ *      change android:glEsVersion=\"0x00030000 in AndroidManifest.txt to 0x00020000\n+ *      minSDVersion to  sth less than 11\n+ *      command line argument APP_PLATFORM=android-11 (or lower)\n+ */\n+\n+apply plugin: 'com.android.application'\n+\n+// pointing to cmake's source code for the same project\n+def REMOTE_SRC_ROOT = '../../../../' + rootProject.getName() + '/' +\n+                       project.getName() + '/src/main'\n+\n+android {\n+    compileSdkVersion 23\n+    buildToolsVersion '23.0.2'\n+\n+    defaultConfig {\n+        applicationId 'com.android.gles3jni'\n+        minSdkVersion 18\n+        targetSdkVersion 11\n+        ndkConfig.abiFilters 'x86', 'x86_64', 'armeabi', 'armeabi-v7a', 'arm64-v8a'\n+        externalNativeBuild {\n+            ndkBuild {\n+                arguments  'APP_PLATFORM=android-18'","path":"other-builds/ndkbuild/gles3jni/app/build.gradle","position":25,"original_position":25,"commit_id":"7d0e457b42497553cdc0b659fa7dc27e8f1f166b","original_commit_id":"1f442dcaf0a5ddcebf278625adcf2863ae6b6141","user":{"login":"ggfan","id":10564521,"avatar_url":"https://avatars.githubusercontent.com/u/10564521?v=3","gravatar_id":"","url":"https://api.github.com/users/ggfan","html_url":"https://github.com/ggfan","followers_url":"https://api.github.com/users/ggfan/followers","following_url":"https://api.github.com/users/ggfan/following{/other_user}","gists_url":"https://api.github.com/users/ggfan/gists{/gist_id}","starred_url":"https://api.github.com/users/ggfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggfan/subscriptions","organizations_url":"https://api.github.com/users/ggfan/orgs","repos_url":"https://api.github.com/users/ggfan/repos","events_url":"https://api.github.com/users/ggfan/events{/privacy}","received_events_url":"https://api.github.com/users/ggfan/received_events","type":"User","site_admin":false},"body":"I think APP_PLATFORM is taken from minSdkVersion 22; regardless of what I set inside Application.mk. it is the miSDKVersion get put into APP_PLATFORM and used on command line.  APP_PLATFORM in application.mk has no effect, correct?","created_at":"2016-08-25T18:14:54Z","updated_at":"2016-08-25T18:14:55Z","html_url":"https://github.com/googlesamples/android-ndk/pull/285#discussion_r76296615","pull_request_url":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285","_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-ndk/pulls/comments/76296615"},"html":{"href":"https://github.com/googlesamples/android-ndk/pull/285#discussion_r76296615"},"pull_request":{"href":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285","id":82656583,"html_url":"https://github.com/googlesamples/android-ndk/pull/285","diff_url":"https://github.com/googlesamples/android-ndk/pull/285.diff","patch_url":"https://github.com/googlesamples/android-ndk/pull/285.patch","issue_url":"https://api.github.com/repos/googlesamples/android-ndk/issues/285","number":285,"state":"open","locked":false,"title":"Merging master-ndkbuild branch into cmake branch","user":{"login":"ggfan","id":10564521,"avatar_url":"https://avatars.githubusercontent.com/u/10564521?v=3","gravatar_id":"","url":"https://api.github.com/users/ggfan","html_url":"https://github.com/ggfan","followers_url":"https://api.github.com/users/ggfan/followers","following_url":"https://api.github.com/users/ggfan/following{/other_user}","gists_url":"https://api.github.com/users/ggfan/gists{/gist_id}","starred_url":"https://api.github.com/users/ggfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggfan/subscriptions","organizations_url":"https://api.github.com/users/ggfan/orgs","repos_url":"https://api.github.com/users/ggfan/repos","events_url":"https://api.github.com/users/ggfan/events{/privacy}","received_events_url":"https://api.github.com/users/ggfan/received_events","type":"User","site_admin":false},"body":"  source code are shared with cmake's copy\r\n  two-libs and test-libstdc++ are not shared with cmake","created_at":"2016-08-25T04:44:08Z","updated_at":"2016-08-25T18:14:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3f98820fde61f80465638eb931c8b6567db26b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285/commits","review_comments_url":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285/comments","review_comment_url":"https://api.github.com/repos/googlesamples/android-ndk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlesamples/android-ndk/issues/285/comments","statuses_url":"https://api.github.com/repos/googlesamples/android-ndk/statuses/7d0e457b42497553cdc0b659fa7dc27e8f1f166b","head":{"label":"googlesamples:merge-ndkbuild","ref":"merge-ndkbuild","sha":"7d0e457b42497553cdc0b659fa7dc27e8f1f166b","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars.githubusercontent.com/u/7378196?v=3","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":35718695,"name":"android-ndk","full_name":"googlesamples/android-ndk","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars.githubusercontent.com/u/7378196?v=3","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-ndk","description":"Android NDK samples","fork":false,"url":"https://api.github.com/repos/googlesamples/android-ndk","forks_url":"https://api.github.com/repos/googlesamples/android-ndk/forks","keys_url":"https://api.github.com/repos/googlesamples/android-ndk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-ndk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-ndk/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-ndk/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-ndk/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-ndk/events","assignees_url":"https://api.github.com/repos/googlesamples/android-ndk/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-ndk/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-ndk/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-ndk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-ndk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-ndk/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-ndk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-ndk/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-ndk/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-ndk/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-ndk/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-ndk/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-ndk/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-ndk/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-ndk/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-ndk/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-ndk/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-ndk/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-ndk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-ndk/merges","archive_url":"https://api.github.com/repos/googlesamples/android-ndk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-ndk/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-ndk/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-ndk/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-ndk/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-ndk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-ndk/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-ndk/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-ndk/deployments","created_at":"2015-05-16T10:02:15Z","updated_at":"2016-08-25T15:32:05Z","pushed_at":"2016-08-25T17:54:52Z","git_url":"git://github.com/googlesamples/android-ndk.git","ssh_url":"git@github.com:googlesamples/android-ndk.git","clone_url":"https://github.com/googlesamples/android-ndk.git","svn_url":"https://github.com/googlesamples/android-ndk","homepage":"http://developer.android.com/ndk","size":32253,"stargazers_count":2033,"watchers_count":2033,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":916,"mirror_url":null,"open_issues_count":42,"forks":916,"open_issues":42,"watchers":2033,"default_branch":"master"}},"base":{"label":"googlesamples:master-cmake","ref":"master-cmake","sha":"f4b89cbc8336a2a56d62bc4f55d3a601ec0699c5","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars.githubusercontent.com/u/7378196?v=3","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":35718695,"name":"android-ndk","full_name":"googlesamples/android-ndk","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars.githubusercontent.com/u/7378196?v=3","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-ndk","description":"Android NDK samples","fork":false,"url":"https://api.github.com/repos/googlesamples/android-ndk","forks_url":"https://api.github.com/repos/googlesamples/android-ndk/forks","keys_url":"https://api.github.com/repos/googlesamples/android-ndk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-ndk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-ndk/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-ndk/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-ndk/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-ndk/events","assignees_url":"https://api.github.com/repos/googlesamples/android-ndk/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-ndk/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-ndk/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-ndk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-ndk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-ndk/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-ndk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-ndk/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-ndk/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-ndk/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-ndk/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-ndk/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-ndk/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-ndk/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-ndk/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-ndk/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-ndk/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-ndk/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-ndk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-ndk/merges","archive_url":"https://api.github.com/repos/googlesamples/android-ndk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-ndk/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-ndk/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-ndk/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-ndk/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-ndk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-ndk/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-ndk/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-ndk/deployments","created_at":"2015-05-16T10:02:15Z","updated_at":"2016-08-25T15:32:05Z","pushed_at":"2016-08-25T17:54:52Z","git_url":"git://github.com/googlesamples/android-ndk.git","ssh_url":"git@github.com:googlesamples/android-ndk.git","clone_url":"https://github.com/googlesamples/android-ndk.git","svn_url":"https://github.com/googlesamples/android-ndk","homepage":"http://developer.android.com/ndk","size":32253,"stargazers_count":2033,"watchers_count":2033,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":916,"mirror_url":null,"open_issues_count":42,"forks":916,"open_issues":42,"watchers":2033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285"},"html":{"href":"https://github.com/googlesamples/android-ndk/pull/285"},"issue":{"href":"https://api.github.com/repos/googlesamples/android-ndk/issues/285"},"comments":{"href":"https://api.github.com/repos/googlesamples/android-ndk/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/googlesamples/android-ndk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlesamples/android-ndk/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/googlesamples/android-ndk/statuses/7d0e457b42497553cdc0b659fa7dc27e8f1f166b"}}}}
{"actor":{"display_login":"ggfan"}}