{"action":"created","issue":{"url":"https://api.github.com/repos/Chisel-Team/Chisel/issues/260","repository_url":"https://api.github.com/repos/Chisel-Team/Chisel","labels_url":"https://api.github.com/repos/Chisel-Team/Chisel/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/Chisel-Team/Chisel/issues/260/comments","events_url":"https://api.github.com/repos/Chisel-Team/Chisel/issues/260/events","html_url":"https://github.com/Chisel-Team/Chisel/pull/260","id":183278884,"number":260,"title":"Allow ModelChiselBlock.getQuads to work with normal block states","user":{"login":"bdew","id":96327,"avatar_url":"https://avatars.githubusercontent.com/u/96327?v=3","gravatar_id":"","url":"https://api.github.com/users/bdew","html_url":"https://github.com/bdew","followers_url":"https://api.github.com/users/bdew/followers","following_url":"https://api.github.com/users/bdew/following{/other_user}","gists_url":"https://api.github.com/users/bdew/gists{/gist_id}","starred_url":"https://api.github.com/users/bdew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdew/subscriptions","organizations_url":"https://api.github.com/users/bdew/orgs","repos_url":"https://api.github.com/users/bdew/repos","events_url":"https://api.github.com/users/bdew/events{/privacy}","received_events_url":"https://api.github.com/users/bdew/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-16T17:25:47Z","updated_at":"2016-10-16T18:19:30Z","closed_at":"2016-10-16T18:11:50Z","pull_request":{"url":"https://api.github.com/repos/Chisel-Team/Chisel/pulls/260","html_url":"https://github.com/Chisel-Team/Chisel/pull/260","diff_url":"https://github.com/Chisel-Team/Chisel/pull/260.diff","patch_url":"https://github.com/Chisel-Team/Chisel/pull/260.patch"},"body":"With the current implementation if ModelChiselBlock.getQuads called with something that isn't a ChiselExtendedState it returns either a null or an empty list because faceQuads/genQuads is only filled in createModel which isn't called in the model registered for the block.\r\n\r\nThis change allows it to return a default set of quads for a block, allowing the models to be used in other blocks (e.g. as microblock covers)."},"comment":{"url":"https://api.github.com/repos/Chisel-Team/Chisel/issues/comments/254063945","html_url":"https://github.com/Chisel-Team/Chisel/pull/260#issuecomment-254063945","issue_url":"https://api.github.com/repos/Chisel-Team/Chisel/issues/260","id":254063945,"user":{"login":"bdew","id":96327,"avatar_url":"https://avatars.githubusercontent.com/u/96327?v=3","gravatar_id":"","url":"https://api.github.com/users/bdew","html_url":"https://github.com/bdew","followers_url":"https://api.github.com/users/bdew/followers","following_url":"https://api.github.com/users/bdew/following{/other_user}","gists_url":"https://api.github.com/users/bdew/gists{/gist_id}","starred_url":"https://api.github.com/users/bdew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdew/subscriptions","organizations_url":"https://api.github.com/users/bdew/orgs","repos_url":"https://api.github.com/users/bdew/repos","events_url":"https://api.github.com/users/bdew/events{/privacy}","received_events_url":"https://api.github.com/users/bdew/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T18:19:30Z","updated_at":"2016-10-16T18:19:30Z","body":"Great minds think alike, i guess :P"}}
{"actor":{"display_login":"bdew"}}