{"action":"created","issue":{"url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/issues/79","labels_url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/issues/79/comments","events_url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/issues/79/events","html_url":"https://github.com/steveathon/bootstrap-wysiwyg/pull/79","id":124613352,"number":79,"title":"Changed library to be OOP","user":{"login":"RandomlyKnighted","id":2483249,"avatar_url":"https://avatars.githubusercontent.com/u/2483249?v=3","gravatar_id":"","url":"https://api.github.com/users/RandomlyKnighted","html_url":"https://github.com/RandomlyKnighted","followers_url":"https://api.github.com/users/RandomlyKnighted/followers","following_url":"https://api.github.com/users/RandomlyKnighted/following{/other_user}","gists_url":"https://api.github.com/users/RandomlyKnighted/gists{/gist_id}","starred_url":"https://api.github.com/users/RandomlyKnighted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RandomlyKnighted/subscriptions","organizations_url":"https://api.github.com/users/RandomlyKnighted/orgs","repos_url":"https://api.github.com/users/RandomlyKnighted/repos","events_url":"https://api.github.com/users/RandomlyKnighted/events{/privacy}","received_events_url":"https://api.github.com/users/RandomlyKnighted/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-02T21:57:40Z","updated_at":"2016-01-08T13:39:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/pulls/79","html_url":"https://github.com/steveathon/bootstrap-wysiwyg/pull/79","diff_url":"https://github.com/steveathon/bootstrap-wysiwyg/pull/79.diff","patch_url":"https://github.com/steveathon/bootstrap-wysiwyg/pull/79.patch"},"body":"Not only is the library now completely object-oriented, but I've also added JSCS and updated JSHint so that the library now has a consistent code style.\r\n\r\nThis can be changed later if needed, but the code style I chose to use is the [jQuery Style Guide](https://contribute.jquery.org/style-guide/js/). I chose it because we were already following most of it's guidelines. I did; however, have to make a couple necessary changes to this style.\r\n\r\n1. I updated the ```maximumLineLength``` to be 175 characters. I did this because we have several if statements that exceed this limit. Some of our functions also have several parameters which makes the function declaration rather long. In the jQuery Style Guide a line can only be 100 characters and setting this to 175 gets around that limit with our long lines.\r\n2. Last, I had to update the ```validateLineBreaks``` to allow for ```CRLF```. This is due to the way Git handles line breaks.\r\n\r\nSpecial Thanks Goes Out To:\r\n* @johnkpaul  - for helping me understand more about developing an OOP library\r\n* @andymac-2 - for helping me work out the last few bugs in the library"},"comment":{"url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/issues/comments/170006588","html_url":"https://github.com/steveathon/bootstrap-wysiwyg/pull/79#issuecomment-170006588","issue_url":"https://api.github.com/repos/steveathon/bootstrap-wysiwyg/issues/79","id":170006588,"user":{"login":"johnkpaul","id":475621,"avatar_url":"https://avatars.githubusercontent.com/u/475621?v=3","gravatar_id":"","url":"https://api.github.com/users/johnkpaul","html_url":"https://github.com/johnkpaul","followers_url":"https://api.github.com/users/johnkpaul/followers","following_url":"https://api.github.com/users/johnkpaul/following{/other_user}","gists_url":"https://api.github.com/users/johnkpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkpaul/subscriptions","organizations_url":"https://api.github.com/users/johnkpaul/orgs","repos_url":"https://api.github.com/users/johnkpaul/repos","events_url":"https://api.github.com/users/johnkpaul/events{/privacy}","received_events_url":"https://api.github.com/users/johnkpaul/received_events","type":"User","site_admin":false},"created_at":"2016-01-08T13:39:21Z","updated_at":"2016-01-08T13:39:21Z","body":"So glad to have seen this come along so much since we chatted first a few months ago. Great job @RandomlyKnighted!"}}