{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/9684","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/9684/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/9684/comments","events_url":"https://api.github.com/repos/servo/servo/issues/9684/events","html_url":"https://github.com/servo/servo/pull/9684","id":134412282,"number":9684,"title":"Add methods to move ByteStrings underlying bytes","user":{"login":"danlrobertson","id":7504153,"avatar_url":"https://avatars.githubusercontent.com/u/7504153?v=3","gravatar_id":"","url":"https://api.github.com/users/danlrobertson","html_url":"https://github.com/danlrobertson","followers_url":"https://api.github.com/users/danlrobertson/followers","following_url":"https://api.github.com/users/danlrobertson/following{/other_user}","gists_url":"https://api.github.com/users/danlrobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/danlrobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlrobertson/subscriptions","organizations_url":"https://api.github.com/users/danlrobertson/orgs","repos_url":"https://api.github.com/users/danlrobertson/repos","events_url":"https://api.github.com/users/danlrobertson/events{/privacy}","received_events_url":"https://api.github.com/users/danlrobertson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-tests-failed","name":"S-tests-failed","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"milestone":null,"comments":15,"created_at":"2016-02-17T21:57:20Z","updated_at":"2016-02-19T13:30:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/9684","html_url":"https://github.com/servo/servo/pull/9684","diff_url":"https://github.com/servo/servo/pull/9684.diff","patch_url":"https://github.com/servo/servo/pull/9684.patch"},"body":"Add methods to move the underlying `Vec<u8>` for `ByteString`.\r\n\r\nI saw this as at least two methods. One to \"move and replace with and empty Vec<u8> (`bytes`), and one to take ownership of the whole object (`own_bytes`). I typically also don't like adding methods with out unit tests. If you think they're unnecessary, just let me know.\r\n\r\nAs always, please let me know if you have any comments, critiques, or nits!\r\n\r\nFixes #9655\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/9684)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/186214056","html_url":"https://github.com/servo/servo/pull/9684#issuecomment-186214056","issue_url":"https://api.github.com/repos/servo/servo/issues/9684","id":186214056,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T13:30:59Z","updated_at":"2016-02-19T13:30:59Z","body":":zap: Previous build results for [android](http://build.servo.org/builders/android/builds/1727), [gonk](http://build.servo.org/builders/gonk/builds/1762), [linux-dev](http://build.servo.org/builders/linux-dev/builds/1735), [mac-dev-unit](http://build.servo.org/builders/mac-dev-unit/builds/437), [mac-rel-css](http://build.servo.org/builders/mac-rel-css/builds/1793) are reusable. Rebuilding only [linux-rel](http://build.servo.org/builders/linux-rel/builds/1982), [mac-rel-wpt](http://build.servo.org/builders/mac-rel-wpt/builds/1833)..."}}