{"action":"created","issue":{"url":"https://api.github.com/repos/education/classroom/issues/614","repository_url":"https://api.github.com/repos/education/classroom","labels_url":"https://api.github.com/repos/education/classroom/issues/614/labels{/name}","comments_url":"https://api.github.com/repos/education/classroom/issues/614/comments","events_url":"https://api.github.com/repos/education/classroom/issues/614/events","html_url":"https://github.com/education/classroom/pull/614","id":157590739,"number":614,"title":"[WIP] Student Identifier","user":{"login":"dinever","id":1311594,"avatar_url":"https://avatars.githubusercontent.com/u/1311594?v=3","gravatar_id":"","url":"https://api.github.com/users/dinever","html_url":"https://github.com/dinever","followers_url":"https://api.github.com/users/dinever/followers","following_url":"https://api.github.com/users/dinever/following{/other_user}","gists_url":"https://api.github.com/users/dinever/gists{/gist_id}","starred_url":"https://api.github.com/users/dinever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinever/subscriptions","organizations_url":"https://api.github.com/users/dinever/orgs","repos_url":"https://api.github.com/users/dinever/repos","events_url":"https://api.github.com/users/dinever/events{/privacy}","received_events_url":"https://api.github.com/users/dinever/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/education/classroom/labels/in%20progress","name":"in progress","color":"1693A5"}],"state":"open","locked":false,"assignee":{"login":"dinever","id":1311594,"avatar_url":"https://avatars.githubusercontent.com/u/1311594?v=3","gravatar_id":"","url":"https://api.github.com/users/dinever","html_url":"https://github.com/dinever","followers_url":"https://api.github.com/users/dinever/followers","following_url":"https://api.github.com/users/dinever/following{/other_user}","gists_url":"https://api.github.com/users/dinever/gists{/gist_id}","starred_url":"https://api.github.com/users/dinever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinever/subscriptions","organizations_url":"https://api.github.com/users/dinever/orgs","repos_url":"https://api.github.com/users/dinever/repos","events_url":"https://api.github.com/users/dinever/events{/privacy}","received_events_url":"https://api.github.com/users/dinever/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2016-05-31T05:07:15Z","updated_at":"2016-06-07T19:34:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/education/classroom/pulls/614","html_url":"https://github.com/education/classroom/pull/614","diff_url":"https://github.com/education/classroom/pull/614.diff","patch_url":"https://github.com/education/classroom/pull/614.patch"},"body":"Hi guys,\r\n\r\nI'm working on the student identifier feature. This PR should close #448 at the end of the day.\r\n\r\nFor this feature I created two tables, one is for *student identifier type*, another one is for *student identifier*.\r\n\r\nEach *student identifier* relies on a *student identifier type*, which contains the name and description for the student identifier.\r\n\r\nTeachers will be able to create *student identifier type* in the classroom, and indicate an id type for an assignment.\r\n\r\nCreating a **student identifier type**:\r\n\r\n![demo-mobile](https://cloud.githubusercontent.com/assets/1311594/15821809/1effd592-2bc0-11e6-8def-e2c9d5f85ce7.gif)\r\n\r\nChoosing a **student identifier type** for an assignment:\r\n\r\n![demo-mobile](https://cloud.githubusercontent.com/assets/1311594/15821887/93c81e3e-2bc0-11e6-825d-85d1af50aa06.gif)\r\n\r\nWhen students visit the assignment invitation page, they will be redirected to another page and will be asked to fill in their identifiers if they don't have the required type of identifier recorded:\r\n\r\n![demo-mobile](https://cloud.githubusercontent.com/assets/1311594/15871797/6858f17e-2cc4-11e6-885c-6645ffa9a8f0.gif)\r\n\r\nStudents will not be asked to fill in the identifier again when accepting other assignment invitations using the same identifier type.\r\n\r\n**Roadmap:**\r\n\r\n- [x] Student identifier type selection in assignment options\r\n- [x] Index for Student identifier types\r\n- [x] Adding new student identifier types\r\n- [x] Deleting old student identifier types\r\n- [x] Recording student identifier when accepting an assignment\r\n- [x] Recording student identifier when accepting a group assignment\r\n- [ ] Displaying student identifier with student github login on the assignment page\r\n- [ ] Style polishing\r\n- [ ] Test cases\r\n\r\n@johndbritton @tarebyte Is this too complicated? Would ❤️  to hear your voice. 😸 "},"comment":{"url":"https://api.github.com/repos/education/classroom/issues/comments/224389419","html_url":"https://github.com/education/classroom/pull/614#issuecomment-224389419","issue_url":"https://api.github.com/repos/education/classroom/issues/614","id":224389419,"user":{"login":"dinever","id":1311594,"avatar_url":"https://avatars.githubusercontent.com/u/1311594?v=3","gravatar_id":"","url":"https://api.github.com/users/dinever","html_url":"https://github.com/dinever","followers_url":"https://api.github.com/users/dinever/followers","following_url":"https://api.github.com/users/dinever/following{/other_user}","gists_url":"https://api.github.com/users/dinever/gists{/gist_id}","starred_url":"https://api.github.com/users/dinever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinever/subscriptions","organizations_url":"https://api.github.com/users/dinever/orgs","repos_url":"https://api.github.com/users/dinever/repos","events_url":"https://api.github.com/users/dinever/events{/privacy}","received_events_url":"https://api.github.com/users/dinever/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T19:34:04Z","updated_at":"2016-06-07T19:34:04Z","body":"All changes mentioned above have been done. Thanks!\r\n\r\nNow I need to do some style polishing and figure out a 🆒 way to display student identifiers on the assignment page.\r\n\r\n/cc @tarebyte "}}
{"actor":{"display_login":"dinever"}}