{"action":"opened","number":148,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/148","id":65694591,"html_url":"https://github.com/GoogleChrome/lighthouse/pull/148","diff_url":"https://github.com/GoogleChrome/lighthouse/pull/148.diff","patch_url":"https://github.com/GoogleChrome/lighthouse/pull/148.patch","issue_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/148","number":148,"state":"open","locked":false,"title":"Introduce lifecycle phases for gatherers","user":{"login":"deepanjanroy","id":3505637,"avatar_url":"https://avatars.githubusercontent.com/u/3505637?v=3","gravatar_id":"","url":"https://api.github.com/users/deepanjanroy","html_url":"https://github.com/deepanjanroy","followers_url":"https://api.github.com/users/deepanjanroy/followers","following_url":"https://api.github.com/users/deepanjanroy/following{/other_user}","gists_url":"https://api.github.com/users/deepanjanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/deepanjanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepanjanroy/subscriptions","organizations_url":"https://api.github.com/users/deepanjanroy/orgs","repos_url":"https://api.github.com/users/deepanjanroy/repos","events_url":"https://api.github.com/users/deepanjanroy/events{/privacy}","received_events_url":"https://api.github.com/users/deepanjanroy/received_events","type":"User","site_admin":false},"body":"First attempt at making a gather lifecycle scheduler. Things to note:\r\n- The gatherers are now instantiated and methods are not static.\r\n- The gatherers no longer explicitly return an artifact. They instead save their artifact in a `artifact` field, which is extracted at the very end by the scheduler.\r\n- url navigation is handled by scheduler.\r\n- **tracing data collection is handled by scheduler**. The last two phases, `afterTraceCollected` and `tearDown` passes the tracing data to gather methods as argument.\r\n\r\nAside: I can't get rid of the lint error for unused variable in the gather superclass.\r\n\r\nLet me know what you think!\r\n\r\n#81 #146 \r\n","created_at":"2016-04-07T20:31:29Z","updated_at":"2016-04-07T20:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/148/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/148/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/148/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/618beb4ed50ebfb82b679d030cd1c606c1205cb5","head":{"label":"deepanjanroy:gatherscheduler","ref":"gatherscheduler","sha":"618beb4ed50ebfb82b679d030cd1c606c1205cb5","user":{"login":"deepanjanroy","id":3505637,"avatar_url":"https://avatars.githubusercontent.com/u/3505637?v=3","gravatar_id":"","url":"https://api.github.com/users/deepanjanroy","html_url":"https://github.com/deepanjanroy","followers_url":"https://api.github.com/users/deepanjanroy/followers","following_url":"https://api.github.com/users/deepanjanroy/following{/other_user}","gists_url":"https://api.github.com/users/deepanjanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/deepanjanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepanjanroy/subscriptions","organizations_url":"https://api.github.com/users/deepanjanroy/orgs","repos_url":"https://api.github.com/users/deepanjanroy/repos","events_url":"https://api.github.com/users/deepanjanroy/events{/privacy}","received_events_url":"https://api.github.com/users/deepanjanroy/received_events","type":"User","site_admin":false},"repo":{"id":55099739,"name":"lighthouse","full_name":"deepanjanroy/lighthouse","owner":{"login":"deepanjanroy","id":3505637,"avatar_url":"https://avatars.githubusercontent.com/u/3505637?v=3","gravatar_id":"","url":"https://api.github.com/users/deepanjanroy","html_url":"https://github.com/deepanjanroy","followers_url":"https://api.github.com/users/deepanjanroy/followers","following_url":"https://api.github.com/users/deepanjanroy/following{/other_user}","gists_url":"https://api.github.com/users/deepanjanroy/gists{/gist_id}","starred_url":"https://api.github.com/users/deepanjanroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepanjanroy/subscriptions","organizations_url":"https://api.github.com/users/deepanjanroy/orgs","repos_url":"https://api.github.com/users/deepanjanroy/repos","events_url":"https://api.github.com/users/deepanjanroy/events{/privacy}","received_events_url":"https://api.github.com/users/deepanjanroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepanjanroy/lighthouse","description":null,"fork":true,"url":"https://api.github.com/repos/deepanjanroy/lighthouse","forks_url":"https://api.github.com/repos/deepanjanroy/lighthouse/forks","keys_url":"https://api.github.com/repos/deepanjanroy/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepanjanroy/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepanjanroy/lighthouse/teams","hooks_url":"https://api.github.com/repos/deepanjanroy/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/deepanjanroy/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/deepanjanroy/lighthouse/events","assignees_url":"https://api.github.com/repos/deepanjanroy/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/deepanjanroy/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/deepanjanroy/lighthouse/tags","blobs_url":"https://api.github.com/repos/deepanjanroy/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepanjanroy/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepanjanroy/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepanjanroy/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepanjanroy/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/deepanjanroy/lighthouse/languages","stargazers_url":"https://api.github.com/repos/deepanjanroy/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/deepanjanroy/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/deepanjanroy/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/deepanjanroy/lighthouse/subscription","commits_url":"https://api.github.com/repos/deepanjanroy/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepanjanroy/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepanjanroy/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepanjanroy/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepanjanroy/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/deepanjanroy/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepanjanroy/lighthouse/merges","archive_url":"https://api.github.com/repos/deepanjanroy/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepanjanroy/lighthouse/downloads","issues_url":"https://api.github.com/repos/deepanjanroy/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/deepanjanroy/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/deepanjanroy/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/deepanjanroy/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepanjanroy/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/deepanjanroy/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/deepanjanroy/lighthouse/deployments","created_at":"2016-03-30T21:39:53Z","updated_at":"2016-03-30T21:39:54Z","pushed_at":"2016-04-07T20:20:06Z","git_url":"git://github.com/deepanjanroy/lighthouse.git","ssh_url":"git@github.com:deepanjanroy/lighthouse.git","clone_url":"https://github.com/deepanjanroy/lighthouse.git","svn_url":"https://github.com/deepanjanroy/lighthouse","homepage":null,"size":2426,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"0acab27d1ff6114c167d99479de5b12af98b11ee","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":53370988,"name":"lighthouse","full_name":"GoogleChrome/lighthouse","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/lighthouse","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChrome/lighthouse","forks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/forks","keys_url":"https://api.github.com/repos/GoogleChrome/lighthouse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/lighthouse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/lighthouse/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/lighthouse/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/events","assignees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/lighthouse/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/lighthouse/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/lighthouse/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/lighthouse/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/lighthouse/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/lighthouse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/lighthouse/merges","archive_url":"https://api.github.com/repos/GoogleChrome/lighthouse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/lighthouse/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/lighthouse/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/lighthouse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/lighthouse/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/deployments","created_at":"2016-03-08T01:03:11Z","updated_at":"2016-04-07T16:19:36Z","pushed_at":"2016-04-07T11:52:58Z","git_url":"git://github.com/GoogleChrome/lighthouse.git","ssh_url":"git@github.com:GoogleChrome/lighthouse.git","clone_url":"https://github.com/GoogleChrome/lighthouse.git","svn_url":"https://github.com/GoogleChrome/lighthouse","homepage":null,"size":2531,"stargazers_count":65,"watchers_count":65,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":26,"forks":11,"open_issues":26,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/148"},"html":{"href":"https://github.com/GoogleChrome/lighthouse/pull/148"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/148"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/lighthouse/statuses/618beb4ed50ebfb82b679d030cd1c606c1205cb5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":143,"deletions":131,"changed_files":13}}