{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/28","id":70895915,"html_url":"https://github.com/unified-font-object/ufoLib/pull/28","diff_url":"https://github.com/unified-font-object/ufoLib/pull/28.diff","patch_url":"https://github.com/unified-font-object/ufoLib/pull/28.patch","issue_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues/28","number":28,"state":"closed","locked":false,"title":"Use ElementTree in glifLib and drop embedded XML parsing infrastructure","user":{"login":"adrientetar","id":1250894,"avatar_url":"https://avatars.githubusercontent.com/u/1250894?v=3","gravatar_id":"","url":"https://api.github.com/users/adrientetar","html_url":"https://github.com/adrientetar","followers_url":"https://api.github.com/users/adrientetar/followers","following_url":"https://api.github.com/users/adrientetar/following{/other_user}","gists_url":"https://api.github.com/users/adrientetar/gists{/gist_id}","starred_url":"https://api.github.com/users/adrientetar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrientetar/subscriptions","organizations_url":"https://api.github.com/users/adrientetar/orgs","repos_url":"https://api.github.com/users/adrientetar/repos","events_url":"https://api.github.com/users/adrientetar/events{/privacy}","received_events_url":"https://api.github.com/users/adrientetar/received_events","type":"User","site_admin":false},"body":"- I think there is further optimization path with plistlib. It's a bit too tied to xmlTreeBuilder and could perhaps use a C implementation.\r\n- I guess we could drop the fontTools XML writer when writing (we don't need a custom XML reader/writer these days?)\r\n\r\nThere are some assertRaises tests that fail even though the assertions are raised in the code (I tried following the code paths...) I didn't change anything around testing so I'm not sure what's causing this. \r\ncc @moyogo @anthrotype \r\n\r\nCloses #16.\r\nCloses #17.\r\ncc #27 (should the issue be salvaged for further optimizations?)","created_at":"2016-05-20T18:16:05Z","updated_at":"2016-05-26T18:48:15Z","closed_at":"2016-05-26T18:48:14Z","merged_at":"2016-05-26T18:48:14Z","merge_commit_sha":"1c3526bcb87161f303aaaab9173775030558c864","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/28/commits","review_comments_url":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/28/comments","review_comment_url":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues/28/comments","statuses_url":"https://api.github.com/repos/unified-font-object/ufoLib/statuses/8044d2fb88f8845b45a29e7f38374040d13449b8","head":{"label":"unified-font-object:et","ref":"et","sha":"8044d2fb88f8845b45a29e7f38374040d13449b8","user":{"login":"unified-font-object","id":4999646,"avatar_url":"https://avatars.githubusercontent.com/u/4999646?v=3","gravatar_id":"","url":"https://api.github.com/users/unified-font-object","html_url":"https://github.com/unified-font-object","followers_url":"https://api.github.com/users/unified-font-object/followers","following_url":"https://api.github.com/users/unified-font-object/following{/other_user}","gists_url":"https://api.github.com/users/unified-font-object/gists{/gist_id}","starred_url":"https://api.github.com/users/unified-font-object/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unified-font-object/subscriptions","organizations_url":"https://api.github.com/users/unified-font-object/orgs","repos_url":"https://api.github.com/users/unified-font-object/repos","events_url":"https://api.github.com/users/unified-font-object/events{/privacy}","received_events_url":"https://api.github.com/users/unified-font-object/received_events","type":"Organization","site_admin":false},"repo":{"id":45680474,"name":"ufoLib","full_name":"unified-font-object/ufoLib","owner":{"login":"unified-font-object","id":4999646,"avatar_url":"https://avatars.githubusercontent.com/u/4999646?v=3","gravatar_id":"","url":"https://api.github.com/users/unified-font-object","html_url":"https://github.com/unified-font-object","followers_url":"https://api.github.com/users/unified-font-object/followers","following_url":"https://api.github.com/users/unified-font-object/following{/other_user}","gists_url":"https://api.github.com/users/unified-font-object/gists{/gist_id}","starred_url":"https://api.github.com/users/unified-font-object/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unified-font-object/subscriptions","organizations_url":"https://api.github.com/users/unified-font-object/orgs","repos_url":"https://api.github.com/users/unified-font-object/repos","events_url":"https://api.github.com/users/unified-font-object/events{/privacy}","received_events_url":"https://api.github.com/users/unified-font-object/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unified-font-object/ufoLib","description":"A low-level UFO reader and writer.","fork":false,"url":"https://api.github.com/repos/unified-font-object/ufoLib","forks_url":"https://api.github.com/repos/unified-font-object/ufoLib/forks","keys_url":"https://api.github.com/repos/unified-font-object/ufoLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unified-font-object/ufoLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unified-font-object/ufoLib/teams","hooks_url":"https://api.github.com/repos/unified-font-object/ufoLib/hooks","issue_events_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues/events{/number}","events_url":"https://api.github.com/repos/unified-font-object/ufoLib/events","assignees_url":"https://api.github.com/repos/unified-font-object/ufoLib/assignees{/user}","branches_url":"https://api.github.com/repos/unified-font-object/ufoLib/branches{/branch}","tags_url":"https://api.github.com/repos/unified-font-object/ufoLib/tags","blobs_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unified-font-object/ufoLib/statuses/{sha}","languages_url":"https://api.github.com/repos/unified-font-object/ufoLib/languages","stargazers_url":"https://api.github.com/repos/unified-font-object/ufoLib/stargazers","contributors_url":"https://api.github.com/repos/unified-font-object/ufoLib/contributors","subscribers_url":"https://api.github.com/repos/unified-font-object/ufoLib/subscribers","subscription_url":"https://api.github.com/repos/unified-font-object/ufoLib/subscription","commits_url":"https://api.github.com/repos/unified-font-object/ufoLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/unified-font-object/ufoLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/unified-font-object/ufoLib/contents/{+path}","compare_url":"https://api.github.com/repos/unified-font-object/ufoLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unified-font-object/ufoLib/merges","archive_url":"https://api.github.com/repos/unified-font-object/ufoLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unified-font-object/ufoLib/downloads","issues_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues{/number}","pulls_url":"https://api.github.com/repos/unified-font-object/ufoLib/pulls{/number}","milestones_url":"https://api.github.com/repos/unified-font-object/ufoLib/milestones{/number}","notifications_url":"https://api.github.com/repos/unified-font-object/ufoLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unified-font-object/ufoLib/labels{/name}","releases_url":"https://api.github.com/repos/unified-font-object/ufoLib/releases{/id}","deployments_url":"https://api.github.com/repos/unified-font-object/ufoLib/deployments","created_at":"2015-11-06T12:21:18Z","updated_at":"2016-04-05T05:43:18Z","pushed_at":"2016-05-26T18:48:14Z","git_url":"git://github.com/unified-font-object/ufoLib.git","ssh_url":"git@github.com:unified-font-object/ufoLib.git","clone_url":"https://github.com/unified-font-object/ufoLib.git","svn_url":"https://github.com/unified-font-object/ufoLib","homepage":null,"size":4340,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":13,"default_branch":"master"}},"base":{"label":"unified-font-object:master","ref":"master","sha":"4d26482e9a487f5a62933a178690d73d0e9e80fb","user":{"login":"unified-font-object","id":4999646,"avatar_url":"https://avatars.githubusercontent.com/u/4999646?v=3","gravatar_id":"","url":"https://api.github.com/users/unified-font-object","html_url":"https://github.com/unified-font-object","followers_url":"https://api.github.com/users/unified-font-object/followers","following_url":"https://api.github.com/users/unified-font-object/following{/other_user}","gists_url":"https://api.github.com/users/unified-font-object/gists{/gist_id}","starred_url":"https://api.github.com/users/unified-font-object/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unified-font-object/subscriptions","organizations_url":"https://api.github.com/users/unified-font-object/orgs","repos_url":"https://api.github.com/users/unified-font-object/repos","events_url":"https://api.github.com/users/unified-font-object/events{/privacy}","received_events_url":"https://api.github.com/users/unified-font-object/received_events","type":"Organization","site_admin":false},"repo":{"id":45680474,"name":"ufoLib","full_name":"unified-font-object/ufoLib","owner":{"login":"unified-font-object","id":4999646,"avatar_url":"https://avatars.githubusercontent.com/u/4999646?v=3","gravatar_id":"","url":"https://api.github.com/users/unified-font-object","html_url":"https://github.com/unified-font-object","followers_url":"https://api.github.com/users/unified-font-object/followers","following_url":"https://api.github.com/users/unified-font-object/following{/other_user}","gists_url":"https://api.github.com/users/unified-font-object/gists{/gist_id}","starred_url":"https://api.github.com/users/unified-font-object/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unified-font-object/subscriptions","organizations_url":"https://api.github.com/users/unified-font-object/orgs","repos_url":"https://api.github.com/users/unified-font-object/repos","events_url":"https://api.github.com/users/unified-font-object/events{/privacy}","received_events_url":"https://api.github.com/users/unified-font-object/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unified-font-object/ufoLib","description":"A low-level UFO reader and writer.","fork":false,"url":"https://api.github.com/repos/unified-font-object/ufoLib","forks_url":"https://api.github.com/repos/unified-font-object/ufoLib/forks","keys_url":"https://api.github.com/repos/unified-font-object/ufoLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unified-font-object/ufoLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unified-font-object/ufoLib/teams","hooks_url":"https://api.github.com/repos/unified-font-object/ufoLib/hooks","issue_events_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues/events{/number}","events_url":"https://api.github.com/repos/unified-font-object/ufoLib/events","assignees_url":"https://api.github.com/repos/unified-font-object/ufoLib/assignees{/user}","branches_url":"https://api.github.com/repos/unified-font-object/ufoLib/branches{/branch}","tags_url":"https://api.github.com/repos/unified-font-object/ufoLib/tags","blobs_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unified-font-object/ufoLib/statuses/{sha}","languages_url":"https://api.github.com/repos/unified-font-object/ufoLib/languages","stargazers_url":"https://api.github.com/repos/unified-font-object/ufoLib/stargazers","contributors_url":"https://api.github.com/repos/unified-font-object/ufoLib/contributors","subscribers_url":"https://api.github.com/repos/unified-font-object/ufoLib/subscribers","subscription_url":"https://api.github.com/repos/unified-font-object/ufoLib/subscription","commits_url":"https://api.github.com/repos/unified-font-object/ufoLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/unified-font-object/ufoLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/unified-font-object/ufoLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/unified-font-object/ufoLib/contents/{+path}","compare_url":"https://api.github.com/repos/unified-font-object/ufoLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unified-font-object/ufoLib/merges","archive_url":"https://api.github.com/repos/unified-font-object/ufoLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unified-font-object/ufoLib/downloads","issues_url":"https://api.github.com/repos/unified-font-object/ufoLib/issues{/number}","pulls_url":"https://api.github.com/repos/unified-font-object/ufoLib/pulls{/number}","milestones_url":"https://api.github.com/repos/unified-font-object/ufoLib/milestones{/number}","notifications_url":"https://api.github.com/repos/unified-font-object/ufoLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unified-font-object/ufoLib/labels{/name}","releases_url":"https://api.github.com/repos/unified-font-object/ufoLib/releases{/id}","deployments_url":"https://api.github.com/repos/unified-font-object/ufoLib/deployments","created_at":"2015-11-06T12:21:18Z","updated_at":"2016-04-05T05:43:18Z","pushed_at":"2016-05-26T18:48:14Z","git_url":"git://github.com/unified-font-object/ufoLib.git","ssh_url":"git@github.com:unified-font-object/ufoLib.git","clone_url":"https://github.com/unified-font-object/ufoLib.git","svn_url":"https://github.com/unified-font-object/ufoLib","homepage":null,"size":4340,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/28"},"html":{"href":"https://github.com/unified-font-object/ufoLib/pull/28"},"issue":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/issues/28"},"comments":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/unified-font-object/ufoLib/statuses/8044d2fb88f8845b45a29e7f38374040d13449b8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"typesupply","id":4992934,"avatar_url":"https://avatars.githubusercontent.com/u/4992934?v=3","gravatar_id":"","url":"https://api.github.com/users/typesupply","html_url":"https://github.com/typesupply","followers_url":"https://api.github.com/users/typesupply/followers","following_url":"https://api.github.com/users/typesupply/following{/other_user}","gists_url":"https://api.github.com/users/typesupply/gists{/gist_id}","starred_url":"https://api.github.com/users/typesupply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesupply/subscriptions","organizations_url":"https://api.github.com/users/typesupply/orgs","repos_url":"https://api.github.com/users/typesupply/repos","events_url":"https://api.github.com/users/typesupply/events{/privacy}","received_events_url":"https://api.github.com/users/typesupply/received_events","type":"User","site_admin":false},"comments":4,"review_comments":3,"commits":1,"additions":222,"deletions":388,"changed_files":4}}
{"actor":{"display_login":"typesupply"}}