{"action":"created","issue":{"url":"https://api.github.com/repos/JackAdams/meteor-transactions/issues/67","repository_url":"https://api.github.com/repos/JackAdams/meteor-transactions","labels_url":"https://api.github.com/repos/JackAdams/meteor-transactions/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/JackAdams/meteor-transactions/issues/67/comments","events_url":"https://api.github.com/repos/JackAdams/meteor-transactions/issues/67/events","html_url":"https://github.com/JackAdams/meteor-transactions/pull/67","id":197264297,"number":67,"title":"Make symlink from test app to package relative so it works for everyone.","user":{"login":"mattmccutchen","id":8885753,"avatar_url":"https://avatars.githubusercontent.com/u/8885753?v=3","gravatar_id":"","url":"https://api.github.com/users/mattmccutchen","html_url":"https://github.com/mattmccutchen","followers_url":"https://api.github.com/users/mattmccutchen/followers","following_url":"https://api.github.com/users/mattmccutchen/following{/other_user}","gists_url":"https://api.github.com/users/mattmccutchen/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmccutchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmccutchen/subscriptions","organizations_url":"https://api.github.com/users/mattmccutchen/orgs","repos_url":"https://api.github.com/users/mattmccutchen/repos","events_url":"https://api.github.com/users/mattmccutchen/events{/privacy}","received_events_url":"https://api.github.com/users/mattmccutchen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-22T20:53:35Z","updated_at":"2016-12-22T22:27:12Z","closed_at":"2016-12-22T21:49:05Z","pull_request":{"url":"https://api.github.com/repos/JackAdams/meteor-transactions/pulls/67","html_url":"https://github.com/JackAdams/meteor-transactions/pull/67","diff_url":"https://github.com/JackAdams/meteor-transactions/pull/67.diff","patch_url":"https://github.com/JackAdams/meteor-transactions/pull/67.patch"},"body":"Before this change, if /Users/babrahams/meteor-packages/transactions did\r\nnot exist locally, then the test app would silently use the published\r\nversion of the package.\r\n\r\nWith this change, I get four test failures:\r\n\r\n```\r\nFAILED jasmine-server-integration : rollback after updates are made => should still work with server error\r\n/home/user/objsheets/tools/babrahams_transactions/testapp/.meteor/local/mirrors/jasmine-server-integration/.meteor/local/build/programs/server/app/tests/jasmine/server/integration/rollback-spec.js:130:59: Expected true to be false.\r\n\r\nFAILED jasmine-server-integration : rollback after updates are made => should restore state if a non-existent document is removed\r\n/home/user/objsheets/tools/babrahams_transactions/testapp/.meteor/local/mirrors/jasmine-server-integration/.meteor/local/build/programs/server/app/tests/jasmine/server/integration/rollback-spec.js:21:26: TypeError: Cannot read property 'transaction_id' of undefined\r\n\r\nFAILED jasmine-server-integration : undo after multiple actions on a single doc field => should leave fields set that were already set\r\n/home/user/objsheets/tools/babrahams_transactions/testapp/.meteor/local/mirrors/jasmine-server-integration/.meteor/local/build/programs/server/app/tests/jasmine/server/integration/undo-spec.js:21:26: TypeError: Cannot read property 'transaction_id' of undefined\r\n\r\nFAILED jasmine-server-integration : undo after multiple actions on a single doc field => should return to initial state\r\n/home/user/objsheets/tools/babrahams_transactions/testapp/.meteor/local/mirrors/jasmine-server-integration/.meteor/local/build/programs/server/app/tests/jasmine/server/integration/undo-spec.js:21:26: TypeError: Cannot read property 'transaction_id' of undefined\r\n```\r\n\r\nHere is [the server log](https://github.com/JackAdams/meteor-transactions/files/669812/jasmine-server-integration.log.txt).\r\n\r\n@JackAdams, can you reproduce this?  Do you have an idea of what the problem is?  If I revert bbdf3a6 and 2cdf02f, then the tests pass.  If the test suite were working, I'd be happy to use it to test my changes before I send them to you, but I'm not willing to spend a lot of time debugging existing problems."},"comment":{"url":"https://api.github.com/repos/JackAdams/meteor-transactions/issues/comments/268904576","html_url":"https://github.com/JackAdams/meteor-transactions/pull/67#issuecomment-268904576","issue_url":"https://api.github.com/repos/JackAdams/meteor-transactions/issues/67","id":268904576,"user":{"login":"JackAdams","id":1647779,"avatar_url":"https://avatars.githubusercontent.com/u/1647779?v=3","gravatar_id":"","url":"https://api.github.com/users/JackAdams","html_url":"https://github.com/JackAdams","followers_url":"https://api.github.com/users/JackAdams/followers","following_url":"https://api.github.com/users/JackAdams/following{/other_user}","gists_url":"https://api.github.com/users/JackAdams/gists{/gist_id}","starred_url":"https://api.github.com/users/JackAdams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackAdams/subscriptions","organizations_url":"https://api.github.com/users/JackAdams/orgs","repos_url":"https://api.github.com/users/JackAdams/repos","events_url":"https://api.github.com/users/JackAdams/events{/privacy}","received_events_url":"https://api.github.com/users/JackAdams/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T22:27:12Z","updated_at":"2016-12-22T22:27:12Z","body":"Yes, I've reproduced this. I think the reason for the bugs in the tests is that the relative symlink works for getting the package included in the velocity test reporter app, but the meteor mirrors that get started for running the tests don't have access to the right package location (or something like that)."}}
{"actor":{"display_login":"JackAdams"}}