{"action":"created","issue":{"url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/issues/21","repository_url":"https://api.github.com/repos/dhoppe/puppet-fail2ban","labels_url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/issues/21/comments","events_url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/issues/21/events","html_url":"https://github.com/dhoppe/puppet-fail2ban/pull/21","id":188971338,"number":21,"title":"Consolidate classes - atomic","user":{"login":"Phil-Friderici","id":5038125,"avatar_url":"https://avatars.githubusercontent.com/u/5038125?v=3","gravatar_id":"","url":"https://api.github.com/users/Phil-Friderici","html_url":"https://github.com/Phil-Friderici","followers_url":"https://api.github.com/users/Phil-Friderici/followers","following_url":"https://api.github.com/users/Phil-Friderici/following{/other_user}","gists_url":"https://api.github.com/users/Phil-Friderici/gists{/gist_id}","starred_url":"https://api.github.com/users/Phil-Friderici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phil-Friderici/subscriptions","organizations_url":"https://api.github.com/users/Phil-Friderici/orgs","repos_url":"https://api.github.com/users/Phil-Friderici/repos","events_url":"https://api.github.com/users/Phil-Friderici/events{/privacy}","received_events_url":"https://api.github.com/users/Phil-Friderici/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-13T13:52:10Z","updated_at":"2016-11-26T07:09:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/pulls/21","html_url":"https://github.com/dhoppe/puppet-fail2ban/pull/21","diff_url":"https://github.com/dhoppe/puppet-fail2ban/pull/21.diff","patch_url":"https://github.com/dhoppe/puppet-fail2ban/pull/21.patch"},"body":"This patch consolidates the all classes into the main class as mentioned in issue #17.\r\nEach commit did pass all spec tests.\r\n\r\nIt also adds missing resources to the tests to reach full resource coverage."},"comment":{"url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/issues/comments/263048585","html_url":"https://github.com/dhoppe/puppet-fail2ban/pull/21#issuecomment-263048585","issue_url":"https://api.github.com/repos/dhoppe/puppet-fail2ban/issues/21","id":263048585,"user":{"login":"dhoppe","id":1111056,"avatar_url":"https://avatars.githubusercontent.com/u/1111056?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoppe","html_url":"https://github.com/dhoppe","followers_url":"https://api.github.com/users/dhoppe/followers","following_url":"https://api.github.com/users/dhoppe/following{/other_user}","gists_url":"https://api.github.com/users/dhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoppe/subscriptions","organizations_url":"https://api.github.com/users/dhoppe/orgs","repos_url":"https://api.github.com/users/dhoppe/repos","events_url":"https://api.github.com/users/dhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/dhoppe/received_events","type":"User","site_admin":false},"created_at":"2016-11-26T07:09:39Z","updated_at":"2016-11-26T07:09:39Z","body":"@Phil-Friderici I know that this module need to be refactored and that the best practices change over time, but could you explain to me why you made these changes? I really do not like to put all the code into one file. \r\n\r\nIf I take a look at the PuppetConf talks the params.pp might be obsolete, but install/config/service is still valid and the differences between operating systems might be put into single files which are included if necessary. "}}
{"actor":{"display_login":"dhoppe"}}