{"action":"created","issue":{"url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/127","repository_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype","labels_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/127/comments","events_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/127/events","html_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/issues/127","id":157866794,"number":127,"title":"split RouteConfig from app","user":{"login":"DylanMeeus","id":2179051,"avatar_url":"https://avatars.githubusercontent.com/u/2179051?v=3","gravatar_id":"","url":"https://api.github.com/users/DylanMeeus","html_url":"https://github.com/DylanMeeus","followers_url":"https://api.github.com/users/DylanMeeus/followers","following_url":"https://api.github.com/users/DylanMeeus/following{/other_user}","gists_url":"https://api.github.com/users/DylanMeeus/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanMeeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanMeeus/subscriptions","organizations_url":"https://api.github.com/users/DylanMeeus/orgs","repos_url":"https://api.github.com/users/DylanMeeus/repos","events_url":"https://api.github.com/users/DylanMeeus/events{/privacy}","received_events_url":"https://api.github.com/users/DylanMeeus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-01T09:53:17Z","updated_at":"2016-06-01T12:54:35Z","closed_at":null,"body":"I came across [this SO post](http://stackoverflow.com/questions/36308809/separate-angular-2-route-config-from-main-app-file) and I believe that it makes sense to put our RouteConfig in a separate file, rather than also adding them to app.component"},"comment":{"url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/comments/222983309","html_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/issues/127#issuecomment-222983309","issue_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/127","id":222983309,"user":{"login":"DylanMeeus","id":2179051,"avatar_url":"https://avatars.githubusercontent.com/u/2179051?v=3","gravatar_id":"","url":"https://api.github.com/users/DylanMeeus","html_url":"https://github.com/DylanMeeus","followers_url":"https://api.github.com/users/DylanMeeus/followers","following_url":"https://api.github.com/users/DylanMeeus/following{/other_user}","gists_url":"https://api.github.com/users/DylanMeeus/gists{/gist_id}","starred_url":"https://api.github.com/users/DylanMeeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DylanMeeus/subscriptions","organizations_url":"https://api.github.com/users/DylanMeeus/orgs","repos_url":"https://api.github.com/users/DylanMeeus/repos","events_url":"https://api.github.com/users/DylanMeeus/events{/privacy}","received_events_url":"https://api.github.com/users/DylanMeeus/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T12:54:35Z","updated_at":"2016-06-01T12:54:35Z","body":"The way in which we have used child routes now is okay I think. The item component is quite small (surely compared to app.component), and splitting it off for just two routes might be a overkill. \n\nTo me, it seems like app.component is already quite a large file. We are also going in against some style guidelines from angular2 about how to structure the components as it is.\n\n >  (Do extract templates and styles into a separate file, when more than 3 lines)\n\nIt is quite a big template, and we are adding a routeconfig and typescript in the same file. \n\nKeeping in mind that our RouteConfig is likely going to grow some more, it might be best to at least split this one."}}
{"actor":{"display_login":"DylanMeeus"}}