{"action":"created","issue":{"url":"https://api.github.com/repos/criteo/biggraphite/issues/120","repository_url":"https://api.github.com/repos/criteo/biggraphite","labels_url":"https://api.github.com/repos/criteo/biggraphite/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/criteo/biggraphite/issues/120/comments","events_url":"https://api.github.com/repos/criteo/biggraphite/issues/120/events","html_url":"https://github.com/criteo/biggraphite/pull/120","id":176699924,"number":120,"title":"#116","user":{"login":"natbraun","id":12711504,"avatar_url":"https://avatars.githubusercontent.com/u/12711504?v=3","gravatar_id":"","url":"https://api.github.com/users/natbraun","html_url":"https://github.com/natbraun","followers_url":"https://api.github.com/users/natbraun/followers","following_url":"https://api.github.com/users/natbraun/following{/other_user}","gists_url":"https://api.github.com/users/natbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/natbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natbraun/subscriptions","organizations_url":"https://api.github.com/users/natbraun/orgs","repos_url":"https://api.github.com/users/natbraun/repos","events_url":"https://api.github.com/users/natbraun/events{/privacy}","received_events_url":"https://api.github.com/users/natbraun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"iksaif","id":1032963,"avatar_url":"https://avatars.githubusercontent.com/u/1032963?v=3","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false},"assignees":[{"login":"iksaif","id":1032963,"avatar_url":"https://avatars.githubusercontent.com/u/1032963?v=3","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-13T17:21:46Z","updated_at":"2016-09-13T18:57:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/criteo/biggraphite/pulls/120","html_url":"https://github.com/criteo/biggraphite/pull/120","diff_url":"https://github.com/criteo/biggraphite/pull/120.diff","patch_url":"https://github.com/criteo/biggraphite/pull/120.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/criteo/biggraphite/120)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/criteo/biggraphite/issues/comments/246786762","html_url":"https://github.com/criteo/biggraphite/pull/120#issuecomment-246786762","issue_url":"https://api.github.com/repos/criteo/biggraphite/issues/120","id":246786762,"user":{"login":"iksaif","id":1032963,"avatar_url":"https://avatars.githubusercontent.com/u/1032963?v=3","gravatar_id":"","url":"https://api.github.com/users/iksaif","html_url":"https://github.com/iksaif","followers_url":"https://api.github.com/users/iksaif/followers","following_url":"https://api.github.com/users/iksaif/following{/other_user}","gists_url":"https://api.github.com/users/iksaif/gists{/gist_id}","starred_url":"https://api.github.com/users/iksaif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iksaif/subscriptions","organizations_url":"https://api.github.com/users/iksaif/orgs","repos_url":"https://api.github.com/users/iksaif/repos","events_url":"https://api.github.com/users/iksaif/events{/privacy}","received_events_url":"https://api.github.com/users/iksaif/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T18:57:03Z","updated_at":"2016-09-13T18:57:03Z","body":"Please add a etter  PR description\n\n---\n\nReview status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[biggraphite/accessor.py, line 743 at r1](https://reviewable.io:443/reviews/criteo/biggraphite/120#-KRZsLRH_dQ7sJoD-LOw:-KRZsLRH_dQ7sJoD-LOx:b9p4kg7) ([raw file](https://github.com/criteo/biggraphite/blob/c2b45156c3f8bfb774fb54ee45705b44c1a79669/biggraphite/accessor.py#L743)):*\n> ```Python\n>                  stage,\n>                  query_results,\n>                  offset_bit_shift=0):\n> ```\n\ndo not pass this as a parameter, this is an implementation detail of the driver. For now just make it so that the PointGroupper received the correct offset in query_results.\n\n---\n\n*[biggraphite/drivers/cassandra.py, line 36 at r1](https://reviewable.io:443/reviews/criteo/biggraphite/120#-KRZs_OCLvKZQBmt0XUu:-KRZs_OCLvKZQBmt0XUv:b-bski9d) ([raw file](https://github.com/criteo/biggraphite/blob/c2b45156c3f8bfb774fb54ee45705b44c1a79669/biggraphite/drivers/cassandra.py#L36)):*\n> ```Python\n> \n> # the offset is shifted when stored in C*\n> _OFFSET_BIT_SHIFT = 16\n> ```\n\nCreate offset_mangle(), offset_demangle() functions instead in `accessor.py` and allow the driver to override these.\n\n---\n\n*[biggraphite/drivers/cassandra.py, line 75 at r1](https://reviewable.io:443/reviews/criteo/biggraphite/120#-KRZsfLi5fL9Hb4I7c1g:-KRZsfLi5fL9Hb4I7c1h:b8rbhkg) ([raw file](https://github.com/criteo/biggraphite/blob/c2b45156c3f8bfb774fb54ee45705b44c1a79669/biggraphite/drivers/cassandra.py#L75)):*\n> ```Python\n> # the datatable.\n> # We store 1000 seconds per row\n> _ROW_SIZE_MS = 1000 * 1000\n> ```\n\nNo, we do not store 1000 seconds per row.\n\n---\n\n*[biggraphite/drivers/cassandra.py, line 160 at r1](https://reviewable.io:443/reviews/criteo/biggraphite/120#-KRZsoh2BaMEsgR4dtxS:-KRZsoh2BaMEsgR4dtxT:bajthv) ([raw file](https://github.com/criteo/biggraphite/blob/c2b45156c3f8bfb774fb54ee45705b44c1a79669/biggraphite/drivers/cassandra.py#L160)):*\n> ```Python\n> }\n> ```\n\ndo not remove this function.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/criteo/biggraphite/120#-:-KRZsBEJgrQ9KIWd7Y8h:bsuk9lt)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"iksaif"}}