{"action":"created","issue":{"url":"https://api.github.com/repos/ende76/brotli-rs/issues/26","repository_url":"https://api.github.com/repos/ende76/brotli-rs","labels_url":"https://api.github.com/repos/ende76/brotli-rs/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/ende76/brotli-rs/issues/26/comments","events_url":"https://api.github.com/repos/ende76/brotli-rs/issues/26/events","html_url":"https://github.com/ende76/brotli-rs/pull/26","id":152750322,"number":26,"title":"Fixed compiler warnings.","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-03T11:15:40Z","updated_at":"2016-05-06T19:00:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ende76/brotli-rs/pulls/26","html_url":"https://github.com/ende76/brotli-rs/pull/26","diff_url":"https://github.com/ende76/brotli-rs/pull/26.diff","patch_url":"https://github.com/ende76/brotli-rs/pull/26.patch"},"body":"This squelches the handful of compiler warnings which were being generated.\r\n\r\nIt also swaps some `assert_eq!` instances for `assert!`s, since these can result in very lengthy console messages of essentially binary data."},"comment":{"url":"https://api.github.com/repos/ende76/brotli-rs/issues/comments/217530221","html_url":"https://github.com/ende76/brotli-rs/pull/26#issuecomment-217530221","issue_url":"https://api.github.com/repos/ende76/brotli-rs/issues/26","id":217530221,"user":{"login":"ende76","id":423337,"avatar_url":"https://avatars.githubusercontent.com/u/423337?v=3","gravatar_id":"","url":"https://api.github.com/users/ende76","html_url":"https://github.com/ende76","followers_url":"https://api.github.com/users/ende76/followers","following_url":"https://api.github.com/users/ende76/following{/other_user}","gists_url":"https://api.github.com/users/ende76/gists{/gist_id}","starred_url":"https://api.github.com/users/ende76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ende76/subscriptions","organizations_url":"https://api.github.com/users/ende76/orgs","repos_url":"https://api.github.com/users/ende76/repos","events_url":"https://api.github.com/users/ende76/events{/privacy}","received_events_url":"https://api.github.com/users/ende76/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T19:00:11Z","updated_at":"2016-05-06T19:00:11Z","body":"Hmmm, feeling a little bit ambivalent about assert! vs assert_eq!. But I think I'm leaning slightly more towards agreeing with you.\r\nIf there's a difference in the test, you do tend to get overwhelmed with binary data, without actually being able to spot the difference at first glance. So you would have to debug again anyway, at which point the original output hasn't helped you.\r\nThanks again for your work!"}}