{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/11429","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/11429/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/11429/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/11429/events","html_url":"https://github.com/ceph/ceph/pull/11429","id":182288982,"number":11429,"title":"src/common/ceph_context.h: Help Clang decide for the correct log() reference","user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"e11d21"},{"url":"https://api.github.com/repos/ceph/ceph/labels/build/ops","name":"build/ops","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"assignees":[{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-10-11T15:03:16Z","updated_at":"2016-10-25T17:15:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/11429","html_url":"https://github.com/ceph/ceph/pull/11429","diff_url":"https://github.com/ceph/ceph/pull/11429.diff","patch_url":"https://github.com/ceph/ceph/pull/11429.patch"},"body":"\r\nClang is confused about selecting the correct log() function.\r\nIncluding math.h helps for the time being.\r\n(until this is fixed in Clang, or it turns out the be very tricky stuff in\r\nthe include order)\r\n\r\nWhen compiling under Clang 3.8.0 it reports:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/common/AsyncOpTracker.cc:6:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/include/Context.h:19:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/common/dout.h:20:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/common/config.h:24:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/common/entity_name.h:22:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/include/encoding.h:304:\r\nIn file included from /usr/srcs/Ceph/work/ceph/src/include/unordered_map.h:6:\r\nIn file included from /usr/include/c++/v1/unordered_map:369:\r\nIn file included from /usr/include/c++/v1/__hash_table:19:\r\nIn file included from /usr/include/c++/v1/cmath:301:\r\n/usr/include/c++/v1/math.h:845:37: error: reference to 'log' is ambiguous\r\nlog(_A1 __lcpp_x) _NOEXCEPT {return log((double)__lcpp_x);}\r\n                                    ^\r\n/usr/include/c++/v1/math.h:845:1: note: candidate found by name lookup is 'log'\r\nlog(_A1 __lcpp_x) _NOEXCEPT {return log((double)__lcpp_x);}\r\n^\r\n/usr/include/c++/v1/math.h:839:46: note: candidate found by name lookup is 'log'\r\ninline _LIBCPP_INLINE_VISIBILITY long double log(long double __lcpp_x) _NOEXCEPT {return logl(__lcpp_x);}\r\n                                             ^\r\n/usr/include/c++/v1/math.h:838:46: note: candidate found by name lookup is 'log'\r\ninline _LIBCPP_INLINE_VISIBILITY float       log(float __lcpp_x) _NOEXCEPT       {return logf(__lcpp_x);}\r\n                                             ^\r\n/usr/include/math.h:247:8: note: candidate found by name lookup is 'log'\r\ndouble  log(double);\r\n        ^\r\n/usr/srcs/Ceph/work/ceph/src/common/ceph_context.h:49:13: note: candidate found by name lookup is 'ceph::log'\r\n  namespace log {\r\n            ^\r\n1 error generated.\r\n\r\nSigned-off-by: Willem Jan Withagen <wjw@digiware.nl>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/256099650","html_url":"https://github.com/ceph/ceph/pull/11429#issuecomment-256099650","issue_url":"https://api.github.com/repos/ceph/ceph/issues/11429","id":256099650,"user":{"login":"wjwithagen","id":16081914,"avatar_url":"https://avatars.githubusercontent.com/u/16081914?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T17:15:17Z","updated_at":"2016-10-25T17:15:17Z","body":"@tchaikov \r\nIt seems to compile oke, and changing was about 15 minutes. 8=)\r\nNow the catch could be that rocksdb does use log as well. Got to wait until the whole build is finished."}}
{"actor":{"display_login":"wjwithagen"}}