{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/validation/issues/318","repository_url":"https://api.github.com/repos/aurelia/validation","labels_url":"https://api.github.com/repos/aurelia/validation/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/validation/issues/318/comments","events_url":"https://api.github.com/repos/aurelia/validation/issues/318/events","html_url":"https://github.com/aurelia/validation/issues/318","id":175243782,"number":318,"title":"Validation events...","user":{"login":"jsobell","id":834155,"avatar_url":"https://avatars.githubusercontent.com/u/834155?v=3","gravatar_id":"","url":"https://api.github.com/users/jsobell","html_url":"https://github.com/jsobell","followers_url":"https://api.github.com/users/jsobell/followers","following_url":"https://api.github.com/users/jsobell/following{/other_user}","gists_url":"https://api.github.com/users/jsobell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsobell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsobell/subscriptions","organizations_url":"https://api.github.com/users/jsobell/orgs","repos_url":"https://api.github.com/users/jsobell/repos","events_url":"https://api.github.com/users/jsobell/events{/privacy}","received_events_url":"https://api.github.com/users/jsobell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/aurelia/validation/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-09-06T13:14:11Z","updated_at":"2016-09-28T13:52:34Z","closed_at":null,"body":"There are times when it's helpful to know when the validation collection has been changed, for instance enabling/disabling buttons, and having custom error displays for specific rules/properties.\r\nIs it worth adding an event to the controller class so VMs can register to it?\r\nOne use-case I was experimenting with was how to display a specific property's error code in the UI. Obviously the errors collection can contain the error, but I don't see an obvious way to validation message for property \"A\", as without a Signal the message display fields won't refresh.\r\nI suppose we could tell people to add another validation renderer to generate a signal, but it's all a bit inelegant."},"comment":{"url":"https://api.github.com/repos/aurelia/validation/issues/comments/250172609","html_url":"https://github.com/aurelia/validation/issues/318#issuecomment-250172609","issue_url":"https://api.github.com/repos/aurelia/validation/issues/318","id":250172609,"user":{"login":"dkent600","id":1821666,"avatar_url":"https://avatars.githubusercontent.com/u/1821666?v=3","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T13:52:33Z","updated_at":"2016-09-28T13:52:33Z","body":"1) using ValidationRenderer to publish events violates SRP.  As such it constrains event publishing functionality to ValidationRenderer functionality.\r\n\r\n2) Using the nifty EventAggregator.includeEventsIn doesn't accomplish much unless the instance already publishes the desired events.  \r\n\r\nMy current use case:\r\n\r\nI am validating at the object level, thus must manually call ValidationController.validate().  At that point I can manually publish an event myself.  But if one is doing property-only validation, then validation can happen entirely under the hood, and some kind of built-in event or callback mechanism can then be desired."}}
{"actor":{"display_login":"dkent600"}}