{"action":"created","comment":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/81524142","pull_request_review_id":2497509,"id":81524142,"diff_hunk":"@@ -0,0 +1,252 @@\n+<?php\n+# MantisBT - A PHP based bugtracking system\n+\n+# MantisBT is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 2 of the License, or\n+# (at your option) any later version.\n+#\n+# MantisBT is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with MantisBT.  If not, see <http://www.gnu.org/licenses/>.\n+\n+/**\n+ * Bug Activity API\n+ *\n+ * @package CoreAPI\n+ * @subpackage AccessAPI\n+ * @copyright Copyright 2000 - 2002  Kenzaburo Ito - kenito@300baud.org","path":"core/bug_activity_api.php","position":22,"original_position":22,"commit_id":"66063824239f077007ea135b5a5b1f5badb1bd78","original_commit_id":"66063824239f077007ea135b5a5b1f5badb1bd78","user":{"login":"atrol","id":319317,"avatar_url":"https://avatars.githubusercontent.com/u/319317?v=3","gravatar_id":"","url":"https://api.github.com/users/atrol","html_url":"https://github.com/atrol","followers_url":"https://api.github.com/users/atrol/followers","following_url":"https://api.github.com/users/atrol/following{/other_user}","gists_url":"https://api.github.com/users/atrol/gists{/gist_id}","starred_url":"https://api.github.com/users/atrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrol/subscriptions","organizations_url":"https://api.github.com/users/atrol/orgs","repos_url":"https://api.github.com/users/atrol/repos","events_url":"https://api.github.com/users/atrol/events{/privacy}","received_events_url":"https://api.github.com/users/atrol/received_events","type":"User","site_admin":false},"body":"We do no longer add this line for new files.","created_at":"2016-10-03T10:20:49Z","updated_at":"2016-10-03T10:20:49Z","html_url":"https://github.com/mantisbt/mantisbt/pull/909#discussion_r81524142","pull_request_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909","_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments/81524142"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/909#discussion_r81524142"},"pull_request":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909"}}},"pull_request":{"url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909","id":87257965,"html_url":"https://github.com/mantisbt/mantisbt/pull/909","diff_url":"https://github.com/mantisbt/mantisbt/pull/909.diff","patch_url":"https://github.com/mantisbt/mantisbt/pull/909.patch","issue_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/909","number":909,"state":"open","locked":false,"title":"Show attachments inline with notes","user":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=3","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"body":"We should show up the attachments inline with the notes. That is specially useful when the user submits a note with one or more attachments, but it is helpful in all cases for attachments.\r\n\r\nIn the future as we gradually update the layout of the View Issue page, it is expected that history should also be shown inline, but this is outside the scope of this issue.\r\n\r\nHere is how it looks like.  The attachments were removed from the issue header details and are now displayed inline.  When a user submits attachments with a note, they appear as one entry.\r\n\r\n![inline_attachments](https://cloud.githubusercontent.com/assets/6446/18944242/2c71f8ea-85d9-11e6-8c94-aa76f8a272fc.png)\r\n\r\nI'll do some more testing, but it would be great to get feedback.\r\n\r\n**Questions and TODOs**\r\n- _Should we change the title of this section?_  Now the section includes \"Notes and Attachments\", but I can see history entries being added inline as well (in the future with a revised UI).  Every time we change the title, we lose all translations, so we either keep it or choose a durable name (e.g. Activities).\r\n- _Should deleting a note, delete its associated attachments?_  I would say yes.\r\n- _Should the user be able to delete a specific attachment associated with a note without deleting the note and other attachments associated with the same note?_  I would say for now, we should only allow deleting a row, since if user deletes an attachment associated with a note, they can't add an alternative one.\r\n\r\nFixes #21727","created_at":"2016-09-29T07:14:59Z","updated_at":"2016-10-03T10:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb1f62adfea4db878b31b13ffa117ed40db21208","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909/commits","review_comments_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909/comments","review_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/909/comments","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/66063824239f077007ea135b5a5b1f5badb1bd78","head":{"label":"vboctor:issue21727_inline_attachments","ref":"issue21727_inline_attachments","sha":"66063824239f077007ea135b5a5b1f5badb1bd78","user":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=3","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"repo":{"id":9786963,"name":"mantisbt","full_name":"vboctor/mantisbt","owner":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=3","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vboctor/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":true,"url":"https://api.github.com/repos/vboctor/mantisbt","forks_url":"https://api.github.com/repos/vboctor/mantisbt/forks","keys_url":"https://api.github.com/repos/vboctor/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vboctor/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vboctor/mantisbt/teams","hooks_url":"https://api.github.com/repos/vboctor/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/vboctor/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/vboctor/mantisbt/events","assignees_url":"https://api.github.com/repos/vboctor/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/vboctor/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/vboctor/mantisbt/tags","blobs_url":"https://api.github.com/repos/vboctor/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vboctor/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vboctor/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/vboctor/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vboctor/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/vboctor/mantisbt/languages","stargazers_url":"https://api.github.com/repos/vboctor/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/vboctor/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/vboctor/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/vboctor/mantisbt/subscription","commits_url":"https://api.github.com/repos/vboctor/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/vboctor/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/vboctor/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/vboctor/mantisbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/vboctor/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/vboctor/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vboctor/mantisbt/merges","archive_url":"https://api.github.com/repos/vboctor/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vboctor/mantisbt/downloads","issues_url":"https://api.github.com/repos/vboctor/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/vboctor/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/vboctor/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/vboctor/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vboctor/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/vboctor/mantisbt/releases{/id}","deployments_url":"https://api.github.com/repos/vboctor/mantisbt/deployments","created_at":"2013-05-01T06:35:52Z","updated_at":"2014-06-10T01:43:46Z","pushed_at":"2016-10-03T06:47:28Z","git_url":"git://github.com/vboctor/mantisbt.git","ssh_url":"git@github.com:vboctor/mantisbt.git","clone_url":"https://github.com/vboctor/mantisbt.git","svn_url":"https://github.com/vboctor/mantisbt","homepage":"http://www.mantisbt.org","size":69947,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master-1.2.x"}},"base":{"label":"mantisbt:master","ref":"master","sha":"cd74a2ebd022d88cf33c4eb3673a03777c9a3f37","user":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?v=3","gravatar_id":"","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"repo":{"id":747755,"name":"mantisbt","full_name":"mantisbt/mantisbt","owner":{"login":"mantisbt","id":318027,"avatar_url":"https://avatars.githubusercontent.com/u/318027?v=3","gravatar_id":"","url":"https://api.github.com/users/mantisbt","html_url":"https://github.com/mantisbt","followers_url":"https://api.github.com/users/mantisbt/followers","following_url":"https://api.github.com/users/mantisbt/following{/other_user}","gists_url":"https://api.github.com/users/mantisbt/gists{/gist_id}","starred_url":"https://api.github.com/users/mantisbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantisbt/subscriptions","organizations_url":"https://api.github.com/users/mantisbt/orgs","repos_url":"https://api.github.com/users/mantisbt/repos","events_url":"https://api.github.com/users/mantisbt/events{/privacy}","received_events_url":"https://api.github.com/users/mantisbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantisbt/mantisbt","description":"Mantis Bug Tracker (MantisBT)","fork":false,"url":"https://api.github.com/repos/mantisbt/mantisbt","forks_url":"https://api.github.com/repos/mantisbt/mantisbt/forks","keys_url":"https://api.github.com/repos/mantisbt/mantisbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantisbt/mantisbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantisbt/mantisbt/teams","hooks_url":"https://api.github.com/repos/mantisbt/mantisbt/hooks","issue_events_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/events{/number}","events_url":"https://api.github.com/repos/mantisbt/mantisbt/events","assignees_url":"https://api.github.com/repos/mantisbt/mantisbt/assignees{/user}","branches_url":"https://api.github.com/repos/mantisbt/mantisbt/branches{/branch}","tags_url":"https://api.github.com/repos/mantisbt/mantisbt/tags","blobs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantisbt/mantisbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantisbt/mantisbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantisbt/mantisbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantisbt/mantisbt/statuses/{sha}","languages_url":"https://api.github.com/repos/mantisbt/mantisbt/languages","stargazers_url":"https://api.github.com/repos/mantisbt/mantisbt/stargazers","contributors_url":"https://api.github.com/repos/mantisbt/mantisbt/contributors","subscribers_url":"https://api.github.com/repos/mantisbt/mantisbt/subscribers","subscription_url":"https://api.github.com/repos/mantisbt/mantisbt/subscription","commits_url":"https://api.github.com/repos/mantisbt/mantisbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantisbt/mantisbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantisbt/mantisbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantisbt/mantisbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantisbt/mantisbt/contents/{+path}","compare_url":"https://api.github.com/repos/mantisbt/mantisbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantisbt/mantisbt/merges","archive_url":"https://api.github.com/repos/mantisbt/mantisbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantisbt/mantisbt/downloads","issues_url":"https://api.github.com/repos/mantisbt/mantisbt/issues{/number}","pulls_url":"https://api.github.com/repos/mantisbt/mantisbt/pulls{/number}","milestones_url":"https://api.github.com/repos/mantisbt/mantisbt/milestones{/number}","notifications_url":"https://api.github.com/repos/mantisbt/mantisbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantisbt/mantisbt/labels{/name}","releases_url":"https://api.github.com/repos/mantisbt/mantisbt/releases{/id}","deployments_url":"https://api.github.com/repos/mantisbt/mantisbt/deployments","created_at":"2010-06-29T21:42:07Z","updated_at":"2016-10-01T12:33:05Z","pushed_at":"2016-10-03T06:47:29Z","git_url":"git://github.com/mantisbt/mantisbt.git","ssh_url":"git@github.com:mantisbt/mantisbt.git","clone_url":"https://github.com/mantisbt/mantisbt.git","svn_url":"https://github.com/mantisbt/mantisbt","homepage":"http://www.mantisbt.org","size":80835,"stargazers_count":635,"watchers_count":635,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":351,"mirror_url":null,"open_issues_count":67,"forks":351,"open_issues":67,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909"},"html":{"href":"https://github.com/mantisbt/mantisbt/pull/909"},"issue":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/909"},"comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/issues/909/comments"},"review_comments":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909/comments"},"review_comment":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantisbt/mantisbt/pulls/909/commits"},"statuses":{"href":"https://api.github.com/repos/mantisbt/mantisbt/statuses/66063824239f077007ea135b5a5b1f5badb1bd78"}}}}
{"actor":{"display_login":"atrol"}}