{"action":"opened","number":768,"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/768","id":92933444,"html_url":"https://github.com/chef-cookbooks/docker/pull/768","diff_url":"https://github.com/chef-cookbooks/docker/pull/768.diff","patch_url":"https://github.com/chef-cookbooks/docker/pull/768.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/768","number":768,"state":"open","locked":false,"title":"Added ro_rootfs => ReadonlyRootfs special cases mapping","user":{"login":"yruss972","id":1858636,"avatar_url":"https://avatars.githubusercontent.com/u/1858636?v=3","gravatar_id":"","url":"https://api.github.com/users/yruss972","html_url":"https://github.com/yruss972","followers_url":"https://api.github.com/users/yruss972/followers","following_url":"https://api.github.com/users/yruss972/following{/other_user}","gists_url":"https://api.github.com/users/yruss972/gists{/gist_id}","starred_url":"https://api.github.com/users/yruss972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yruss972/subscriptions","organizations_url":"https://api.github.com/users/yruss972/orgs","repos_url":"https://api.github.com/users/yruss972/repos","events_url":"https://api.github.com/users/yruss972/events{/privacy}","received_events_url":"https://api.github.com/users/yruss972/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis commit adds ReadonlyRootfs to the list of keys which are skipped in the automated load of state and then maps ro_rootfs to the ReadonlyRootfs manually as was done with other similar cases.\r\n\r\n### Issues Resolved\r\n\r\nThe ro_rootfs property of the docker_container resource doesn't match the property in the docker HostConfig (called ReadonlyRootfs).\r\nAs a result, chef fails to properly load the value into the state of the current resource and forces a redeploy even when no change has been made.\r\n\r\n### Check List\r\n\r\n- [ ] All tests pass. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD>\r\n- [ ] New functionality includes testing.\r\n- [ ] New functionality has been documented in the README if applicable\r\n- [x ] All commits have been signed for the Developer Certificate of Origin. See <https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD>\r\n\r\nto prevent redeploying containers with ro_rootfs = true\r\n\r\nSigned-off-by: Yonah Russ <me@yonahruss.com>","created_at":"2016-11-09T09:58:57Z","updated_at":"2016-11-09T09:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0cd3fa66a66f54d36f5322e2f14817cd8d67ce9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/768/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/768/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/768/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/docker/statuses/e82dc5c18599b5447678d9236020b493474cdda4","head":{"label":"yruss972:add_ro_rootfs_to_ReadonlyRootfs_mapping","ref":"add_ro_rootfs_to_ReadonlyRootfs_mapping","sha":"e82dc5c18599b5447678d9236020b493474cdda4","user":{"login":"yruss972","id":1858636,"avatar_url":"https://avatars.githubusercontent.com/u/1858636?v=3","gravatar_id":"","url":"https://api.github.com/users/yruss972","html_url":"https://github.com/yruss972","followers_url":"https://api.github.com/users/yruss972/followers","following_url":"https://api.github.com/users/yruss972/following{/other_user}","gists_url":"https://api.github.com/users/yruss972/gists{/gist_id}","starred_url":"https://api.github.com/users/yruss972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yruss972/subscriptions","organizations_url":"https://api.github.com/users/yruss972/orgs","repos_url":"https://api.github.com/users/yruss972/repos","events_url":"https://api.github.com/users/yruss972/events{/privacy}","received_events_url":"https://api.github.com/users/yruss972/received_events","type":"User","site_admin":false},"repo":{"id":73270440,"name":"docker","full_name":"yruss972/docker","owner":{"login":"yruss972","id":1858636,"avatar_url":"https://avatars.githubusercontent.com/u/1858636?v=3","gravatar_id":"","url":"https://api.github.com/users/yruss972","html_url":"https://github.com/yruss972","followers_url":"https://api.github.com/users/yruss972/followers","following_url":"https://api.github.com/users/yruss972/following{/other_user}","gists_url":"https://api.github.com/users/yruss972/gists{/gist_id}","starred_url":"https://api.github.com/users/yruss972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yruss972/subscriptions","organizations_url":"https://api.github.com/users/yruss972/orgs","repos_url":"https://api.github.com/users/yruss972/repos","events_url":"https://api.github.com/users/yruss972/events{/privacy}","received_events_url":"https://api.github.com/users/yruss972/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yruss972/docker","description":"Chef Cookbook for Docker","fork":true,"url":"https://api.github.com/repos/yruss972/docker","forks_url":"https://api.github.com/repos/yruss972/docker/forks","keys_url":"https://api.github.com/repos/yruss972/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yruss972/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yruss972/docker/teams","hooks_url":"https://api.github.com/repos/yruss972/docker/hooks","issue_events_url":"https://api.github.com/repos/yruss972/docker/issues/events{/number}","events_url":"https://api.github.com/repos/yruss972/docker/events","assignees_url":"https://api.github.com/repos/yruss972/docker/assignees{/user}","branches_url":"https://api.github.com/repos/yruss972/docker/branches{/branch}","tags_url":"https://api.github.com/repos/yruss972/docker/tags","blobs_url":"https://api.github.com/repos/yruss972/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yruss972/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yruss972/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/yruss972/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yruss972/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/yruss972/docker/languages","stargazers_url":"https://api.github.com/repos/yruss972/docker/stargazers","contributors_url":"https://api.github.com/repos/yruss972/docker/contributors","subscribers_url":"https://api.github.com/repos/yruss972/docker/subscribers","subscription_url":"https://api.github.com/repos/yruss972/docker/subscription","commits_url":"https://api.github.com/repos/yruss972/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/yruss972/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/yruss972/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/yruss972/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/yruss972/docker/contents/{+path}","compare_url":"https://api.github.com/repos/yruss972/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yruss972/docker/merges","archive_url":"https://api.github.com/repos/yruss972/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yruss972/docker/downloads","issues_url":"https://api.github.com/repos/yruss972/docker/issues{/number}","pulls_url":"https://api.github.com/repos/yruss972/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/yruss972/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/yruss972/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yruss972/docker/labels{/name}","releases_url":"https://api.github.com/repos/yruss972/docker/releases{/id}","deployments_url":"https://api.github.com/repos/yruss972/docker/deployments","created_at":"2016-11-09T09:42:27Z","updated_at":"2016-11-09T09:42:29Z","pushed_at":"2016-11-09T09:47:55Z","git_url":"git://github.com/yruss972/docker.git","ssh_url":"git@github.com:yruss972/docker.git","clone_url":"https://github.com/yruss972/docker.git","svn_url":"https://github.com/yruss972/docker","homepage":"https://supermarket.chef.io/cookbooks/docker","size":4230,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"58efdc555d611e53d1058df6b5e1500908e5d8ee","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":9992805,"name":"docker","full_name":"chef-cookbooks/docker","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/docker","description":"Chef Cookbook for Docker","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/docker","forks_url":"https://api.github.com/repos/chef-cookbooks/docker/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/docker/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/docker/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/docker/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/docker/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/docker/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/docker/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/docker/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/docker/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/docker/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/docker/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/docker/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/docker/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/docker/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/docker/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/docker/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/docker/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/docker/releases{/id}","deployments_url":"https://api.github.com/repos/chef-cookbooks/docker/deployments","created_at":"2013-05-11T00:21:06Z","updated_at":"2016-11-08T17:22:39Z","pushed_at":"2016-11-09T09:58:57Z","git_url":"git://github.com/chef-cookbooks/docker.git","ssh_url":"git@github.com:chef-cookbooks/docker.git","clone_url":"https://github.com/chef-cookbooks/docker.git","svn_url":"https://github.com/chef-cookbooks/docker","homepage":"https://supermarket.chef.io/cookbooks/docker","size":4230,"stargazers_count":648,"watchers_count":648,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":382,"mirror_url":null,"open_issues_count":29,"forks":382,"open_issues":29,"watchers":648,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/768"},"html":{"href":"https://github.com/chef-cookbooks/docker/pull/768"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/docker/issues/768"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/docker/issues/768/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/768/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/docker/pulls/768/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/docker/statuses/e82dc5c18599b5447678d9236020b493474cdda4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"yruss972"}}