{"action":"opened","number":2856,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2856","id":86023264,"html_url":"https://github.com/DataDog/dd-agent/pull/2856","diff_url":"https://github.com/DataDog/dd-agent/pull/2856.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2856.patch","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2856","number":2856,"state":"open","locked":false,"title":"dont combine connection states","user":{"login":"joewilliams","id":44418,"avatar_url":"https://avatars.githubusercontent.com/u/44418?v=3","gravatar_id":"","url":"https://api.github.com/users/joewilliams","html_url":"https://github.com/joewilliams","followers_url":"https://api.github.com/users/joewilliams/followers","following_url":"https://api.github.com/users/joewilliams/following{/other_user}","gists_url":"https://api.github.com/users/joewilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/joewilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewilliams/subscriptions","organizations_url":"https://api.github.com/users/joewilliams/orgs","repos_url":"https://api.github.com/users/joewilliams/repos","events_url":"https://api.github.com/users/joewilliams/events{/privacy}","received_events_url":"https://api.github.com/users/joewilliams/received_events","type":"User","site_admin":true},"body":"\r\n### What does this PR do?\r\n\r\nThis changes the networking check to use the individual connection states rather than combine them. This PR is a more manageable version of https://github.com/DataDog/dd-agent/pull/2720. We have our own `nstat` based plugin that does the extended TCP metrics included in that PR but would like to split connection states into their actual buckets.\r\n\r\n### Motivation\r\n\r\nIt bugs me that the states are added together.\r\n\r\n\r\n","created_at":"2016-09-20T17:44:52Z","updated_at":"2016-09-20T17:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9dc145890e6b22b20b00db1f297852987dce52","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2856/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2856/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2856/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/7f31e948271477f5cdc14263dba2b9aa48a17334","head":{"label":"joewilliams:split_connection_types","ref":"split_connection_types","sha":"7f31e948271477f5cdc14263dba2b9aa48a17334","user":{"login":"joewilliams","id":44418,"avatar_url":"https://avatars.githubusercontent.com/u/44418?v=3","gravatar_id":"","url":"https://api.github.com/users/joewilliams","html_url":"https://github.com/joewilliams","followers_url":"https://api.github.com/users/joewilliams/followers","following_url":"https://api.github.com/users/joewilliams/following{/other_user}","gists_url":"https://api.github.com/users/joewilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/joewilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewilliams/subscriptions","organizations_url":"https://api.github.com/users/joewilliams/orgs","repos_url":"https://api.github.com/users/joewilliams/repos","events_url":"https://api.github.com/users/joewilliams/events{/privacy}","received_events_url":"https://api.github.com/users/joewilliams/received_events","type":"User","site_admin":true},"repo":{"id":64501185,"name":"dd-agent","full_name":"joewilliams/dd-agent","owner":{"login":"joewilliams","id":44418,"avatar_url":"https://avatars.githubusercontent.com/u/44418?v=3","gravatar_id":"","url":"https://api.github.com/users/joewilliams","html_url":"https://github.com/joewilliams","followers_url":"https://api.github.com/users/joewilliams/followers","following_url":"https://api.github.com/users/joewilliams/following{/other_user}","gists_url":"https://api.github.com/users/joewilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/joewilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joewilliams/subscriptions","organizations_url":"https://api.github.com/users/joewilliams/orgs","repos_url":"https://api.github.com/users/joewilliams/repos","events_url":"https://api.github.com/users/joewilliams/events{/privacy}","received_events_url":"https://api.github.com/users/joewilliams/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/joewilliams/dd-agent","description":"Datadog Agent","fork":true,"url":"https://api.github.com/repos/joewilliams/dd-agent","forks_url":"https://api.github.com/repos/joewilliams/dd-agent/forks","keys_url":"https://api.github.com/repos/joewilliams/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joewilliams/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joewilliams/dd-agent/teams","hooks_url":"https://api.github.com/repos/joewilliams/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/joewilliams/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/joewilliams/dd-agent/events","assignees_url":"https://api.github.com/repos/joewilliams/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/joewilliams/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/joewilliams/dd-agent/tags","blobs_url":"https://api.github.com/repos/joewilliams/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joewilliams/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joewilliams/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/joewilliams/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joewilliams/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/joewilliams/dd-agent/languages","stargazers_url":"https://api.github.com/repos/joewilliams/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/joewilliams/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/joewilliams/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/joewilliams/dd-agent/subscription","commits_url":"https://api.github.com/repos/joewilliams/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/joewilliams/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/joewilliams/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/joewilliams/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/joewilliams/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/joewilliams/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joewilliams/dd-agent/merges","archive_url":"https://api.github.com/repos/joewilliams/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joewilliams/dd-agent/downloads","issues_url":"https://api.github.com/repos/joewilliams/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/joewilliams/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/joewilliams/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/joewilliams/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joewilliams/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/joewilliams/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/joewilliams/dd-agent/deployments","created_at":"2016-07-29T18:11:19Z","updated_at":"2016-07-29T18:11:22Z","pushed_at":"2016-09-20T17:41:00Z","git_url":"git://github.com/joewilliams/dd-agent.git","ssh_url":"git@github.com:joewilliams/dd-agent.git","clone_url":"https://github.com/joewilliams/dd-agent.git","svn_url":"https://github.com/joewilliams/dd-agent","homepage":"http://docs.datadoghq.com/","size":39422,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"a67b9f9873e6801319ebc86b19515ea8bae6d434","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":1210071,"name":"dd-agent","full_name":"DataDog/dd-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-agent","description":"Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/dd-agent","forks_url":"https://api.github.com/repos/DataDog/dd-agent/forks","keys_url":"https://api.github.com/repos/DataDog/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-agent/events","assignees_url":"https://api.github.com/repos/DataDog/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-agent/merges","archive_url":"https://api.github.com/repos/DataDog/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-agent/deployments","created_at":"2010-12-31T03:02:47Z","updated_at":"2016-09-19T09:51:58Z","pushed_at":"2016-09-20T17:44:53Z","git_url":"git://github.com/DataDog/dd-agent.git","ssh_url":"git@github.com:DataDog/dd-agent.git","clone_url":"https://github.com/DataDog/dd-agent.git","svn_url":"https://github.com/DataDog/dd-agent","homepage":"http://docs.datadoghq.com/","size":51622,"stargazers_count":608,"watchers_count":608,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":551,"mirror_url":null,"open_issues_count":226,"forks":551,"open_issues":226,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2856"},"html":{"href":"https://github.com/DataDog/dd-agent/pull/2856"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/2856"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/2856/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2856/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/2856/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-agent/statuses/7f31e948271477f5cdc14263dba2b9aa48a17334"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":55,"deletions":39,"changed_files":1}}
{"actor":{"display_login":"joewilliams"}}