{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/82411808","pull_request_review_id":3323434,"id":82411808,"diff_hunk":"@@ -2047,6 +2047,8 @@ function reboot_nodes_via_ipmi\n                 sleep $((50 + RANDOM % 20))\n \n                 ipmitool -H $ip -U root -P $pw chassis bootdev pxe\n+                # Please do not touch this sleep. It is important for the ipmi to work on qa hardware\n+                sleep $((50 + RANDOM % 20))","path":"scripts/qa_crowbarsetup.sh","position":5,"original_position":5,"commit_id":"9e64c5987457ae96e4cd93919aec7f26a9ae9e05","original_commit_id":"9e64c5987457ae96e4cd93919aec7f26a9ae9e05","user":{"login":"aspiers","id":100738,"avatar_url":"https://avatars.githubusercontent.com/u/100738?v=3","gravatar_id":"","url":"https://api.github.com/users/aspiers","html_url":"https://github.com/aspiers","followers_url":"https://api.github.com/users/aspiers/followers","following_url":"https://api.github.com/users/aspiers/following{/other_user}","gists_url":"https://api.github.com/users/aspiers/gists{/gist_id}","starred_url":"https://api.github.com/users/aspiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspiers/subscriptions","organizations_url":"https://api.github.com/users/aspiers/orgs","repos_url":"https://api.github.com/users/aspiers/repos","events_url":"https://api.github.com/users/aspiers/events{/privacy}","received_events_url":"https://api.github.com/users/aspiers/received_events","type":"User","site_admin":false},"body":"I agree with @jdsn and @aplanas. The need for the sleep should be explained, but even better, if it was using `wait_for` then it would be self-explanatory and also a lot more reliable than sleeping for a random amount of time.","created_at":"2016-10-07T15:26:34Z","updated_at":"2016-10-07T15:26:45Z","html_url":"https://github.com/SUSE-Cloud/automation/pull/1309#discussion_r82411808","pull_request_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309","_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments/82411808"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/1309#discussion_r82411808"},"pull_request":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309","id":88410788,"html_url":"https://github.com/SUSE-Cloud/automation/pull/1309","diff_url":"https://github.com/SUSE-Cloud/automation/pull/1309.diff","patch_url":"https://github.com/SUSE-Cloud/automation/pull/1309.patch","issue_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1309","number":1309,"state":"open","locked":false,"title":"Wait after setting up pxe boot on the QA hardware nodes","user":{"login":"vmoravec","id":1215576,"avatar_url":"https://avatars.githubusercontent.com/u/1215576?v=3","gravatar_id":"","url":"https://api.github.com/users/vmoravec","html_url":"https://github.com/vmoravec","followers_url":"https://api.github.com/users/vmoravec/followers","following_url":"https://api.github.com/users/vmoravec/following{/other_user}","gists_url":"https://api.github.com/users/vmoravec/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoravec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoravec/subscriptions","organizations_url":"https://api.github.com/users/vmoravec/orgs","repos_url":"https://api.github.com/users/vmoravec/repos","events_url":"https://api.github.com/users/vmoravec/events{/privacy}","received_events_url":"https://api.github.com/users/vmoravec/received_events","type":"User","site_admin":false},"body":"As we are loosing nodes during cloud deployment, a bit waiting should fix the problem.","created_at":"2016-10-07T09:58:08Z","updated_at":"2016-10-07T15:26:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ea942d53a825ee4555da155607b94df3d8a67bf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309/commits","review_comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309/comments","review_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1309/comments","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/9e64c5987457ae96e4cd93919aec7f26a9ae9e05","head":{"label":"vmoravec:add-sleep-pxe","ref":"add-sleep-pxe","sha":"9e64c5987457ae96e4cd93919aec7f26a9ae9e05","user":{"login":"vmoravec","id":1215576,"avatar_url":"https://avatars.githubusercontent.com/u/1215576?v=3","gravatar_id":"","url":"https://api.github.com/users/vmoravec","html_url":"https://github.com/vmoravec","followers_url":"https://api.github.com/users/vmoravec/followers","following_url":"https://api.github.com/users/vmoravec/following{/other_user}","gists_url":"https://api.github.com/users/vmoravec/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoravec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoravec/subscriptions","organizations_url":"https://api.github.com/users/vmoravec/orgs","repos_url":"https://api.github.com/users/vmoravec/repos","events_url":"https://api.github.com/users/vmoravec/events{/privacy}","received_events_url":"https://api.github.com/users/vmoravec/received_events","type":"User","site_admin":false},"repo":{"id":29188946,"name":"automation","full_name":"vmoravec/automation","owner":{"login":"vmoravec","id":1215576,"avatar_url":"https://avatars.githubusercontent.com/u/1215576?v=3","gravatar_id":"","url":"https://api.github.com/users/vmoravec","html_url":"https://github.com/vmoravec","followers_url":"https://api.github.com/users/vmoravec/followers","following_url":"https://api.github.com/users/vmoravec/following{/other_user}","gists_url":"https://api.github.com/users/vmoravec/gists{/gist_id}","starred_url":"https://api.github.com/users/vmoravec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmoravec/subscriptions","organizations_url":"https://api.github.com/users/vmoravec/orgs","repos_url":"https://api.github.com/users/vmoravec/repos","events_url":"https://api.github.com/users/vmoravec/events{/privacy}","received_events_url":"https://api.github.com/users/vmoravec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vmoravec/automation","description":"Automation scripts for development, testing, and CI","fork":true,"url":"https://api.github.com/repos/vmoravec/automation","forks_url":"https://api.github.com/repos/vmoravec/automation/forks","keys_url":"https://api.github.com/repos/vmoravec/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmoravec/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmoravec/automation/teams","hooks_url":"https://api.github.com/repos/vmoravec/automation/hooks","issue_events_url":"https://api.github.com/repos/vmoravec/automation/issues/events{/number}","events_url":"https://api.github.com/repos/vmoravec/automation/events","assignees_url":"https://api.github.com/repos/vmoravec/automation/assignees{/user}","branches_url":"https://api.github.com/repos/vmoravec/automation/branches{/branch}","tags_url":"https://api.github.com/repos/vmoravec/automation/tags","blobs_url":"https://api.github.com/repos/vmoravec/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmoravec/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmoravec/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmoravec/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmoravec/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/vmoravec/automation/languages","stargazers_url":"https://api.github.com/repos/vmoravec/automation/stargazers","contributors_url":"https://api.github.com/repos/vmoravec/automation/contributors","subscribers_url":"https://api.github.com/repos/vmoravec/automation/subscribers","subscription_url":"https://api.github.com/repos/vmoravec/automation/subscription","commits_url":"https://api.github.com/repos/vmoravec/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmoravec/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmoravec/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmoravec/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmoravec/automation/contents/{+path}","compare_url":"https://api.github.com/repos/vmoravec/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmoravec/automation/merges","archive_url":"https://api.github.com/repos/vmoravec/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmoravec/automation/downloads","issues_url":"https://api.github.com/repos/vmoravec/automation/issues{/number}","pulls_url":"https://api.github.com/repos/vmoravec/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/vmoravec/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/vmoravec/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmoravec/automation/labels{/name}","releases_url":"https://api.github.com/repos/vmoravec/automation/releases{/id}","deployments_url":"https://api.github.com/repos/vmoravec/automation/deployments","created_at":"2015-01-13T12:30:43Z","updated_at":"2016-04-26T12:03:18Z","pushed_at":"2016-10-07T10:21:03Z","git_url":"git://github.com/vmoravec/automation.git","ssh_url":"git@github.com:vmoravec/automation.git","clone_url":"https://github.com/vmoravec/automation.git","svn_url":"https://github.com/vmoravec/automation","homepage":"","size":6317,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE-Cloud:master","ref":"master","sha":"280f92feb77f994c0eb1bae6eb3c70ed14532276","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":6384356,"name":"automation","full_name":"SUSE-Cloud/automation","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/automation","description":"Automation scripts for development, testing, and CI","fork":false,"url":"https://api.github.com/repos/SUSE-Cloud/automation","forks_url":"https://api.github.com/repos/SUSE-Cloud/automation/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/automation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/automation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/automation/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/automation/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/automation/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/automation/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/automation/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/automation/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/automation/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/automation/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/automation/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/automation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/automation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/automation/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/automation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/automation/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/automation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/automation/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/automation/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/automation/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/automation/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/automation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/automation/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/automation/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE-Cloud/automation/deployments","created_at":"2012-10-25T08:45:31Z","updated_at":"2016-09-13T07:52:35Z","pushed_at":"2016-10-07T14:30:29Z","git_url":"git://github.com/SUSE-Cloud/automation.git","ssh_url":"git@github.com:SUSE-Cloud/automation.git","clone_url":"https://github.com/SUSE-Cloud/automation.git","svn_url":"https://github.com/SUSE-Cloud/automation","homepage":"","size":9138,"stargazers_count":18,"watchers_count":18,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":32,"forks":57,"open_issues":32,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309"},"html":{"href":"https://github.com/SUSE-Cloud/automation/pull/1309"},"issue":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1309"},"comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/issues/1309/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/pulls/1309/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE-Cloud/automation/statuses/9e64c5987457ae96e4cd93919aec7f26a9ae9e05"}}}}
{"actor":{"display_login":"aspiers"}}