{"action":"created","issue":{"url":"https://api.github.com/repos/stefan-muc/libb64/issues/1","repository_url":"https://api.github.com/repos/stefan-muc/libb64","labels_url":"https://api.github.com/repos/stefan-muc/libb64/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/stefan-muc/libb64/issues/1/comments","events_url":"https://api.github.com/repos/stefan-muc/libb64/issues/1/events","html_url":"https://github.com/stefan-muc/libb64/pull/1","id":163003837,"number":1,"title":"Further development of libb64","user":{"login":"thiloschulz","id":3193024,"avatar_url":"https://avatars.githubusercontent.com/u/3193024?v=3","gravatar_id":"","url":"https://api.github.com/users/thiloschulz","html_url":"https://github.com/thiloschulz","followers_url":"https://api.github.com/users/thiloschulz/followers","following_url":"https://api.github.com/users/thiloschulz/following{/other_user}","gists_url":"https://api.github.com/users/thiloschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/thiloschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiloschulz/subscriptions","organizations_url":"https://api.github.com/users/thiloschulz/orgs","repos_url":"https://api.github.com/users/thiloschulz/repos","events_url":"https://api.github.com/users/thiloschulz/events{/privacy}","received_events_url":"https://api.github.com/users/thiloschulz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-29T19:13:05Z","updated_at":"2016-07-19T12:47:03Z","closed_at":"2016-07-19T12:47:03Z","pull_request":{"url":"https://api.github.com/repos/stefan-muc/libb64/pulls/1","html_url":"https://github.com/stefan-muc/libb64/pull/1","diff_url":"https://github.com/stefan-muc/libb64/pull/1.diff","patch_url":"https://github.com/stefan-muc/libb64/pull/1.patch"},"body":"As libb64 seems pretty much unmaintained on the original sourceforge git, I think it would make sense to pool the effort for further development of this nice piece of software.\r\n\r\nChanges until including d901025 are cosmetic, they fix build errors on gcc.\r\n\r\nChanges afterwards are more extensive.\r\nIt's absurd that the library has a hardcoded line length limit for the encoded base64 string. I have introduced a few changes that make this max line length configurable via the encoder state structure.\r\nFurthermore, I have exchanged the int arguments with size_t which will make it possible to address blocks larger than 2GiB on 64 bit systems. Alas, this may introduce dependencies on system headers, though through clever ifdeffery building for embedded systems should keep working.\r\nBoth these changes are API breaking, which I guess won't be too bad if you consider that projects using this software probably include these sources in their own source tree.\r\n\r\nA quick search seems to indicate that your fork contains the most recent work including work for MSVC as an added bonus. Given the fact that I've started doing API changes, I'd like to do something that people with their various projects and requirements what libb64 should be able to do can agree on.\r\n\r\nMaybe open a new organisation on github so there's one commonly visible reference point?\r\nShould probably also give this fork a proper name then."},"comment":{"url":"https://api.github.com/repos/stefan-muc/libb64/issues/comments/233621101","html_url":"https://github.com/stefan-muc/libb64/pull/1#issuecomment-233621101","issue_url":"https://api.github.com/repos/stefan-muc/libb64/issues/1","id":233621101,"user":{"login":"stefan-muc","id":544335,"avatar_url":"https://avatars.githubusercontent.com/u/544335?v=3","gravatar_id":"","url":"https://api.github.com/users/stefan-muc","html_url":"https://github.com/stefan-muc","followers_url":"https://api.github.com/users/stefan-muc/followers","following_url":"https://api.github.com/users/stefan-muc/following{/other_user}","gists_url":"https://api.github.com/users/stefan-muc/gists{/gist_id}","starred_url":"https://api.github.com/users/stefan-muc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefan-muc/subscriptions","organizations_url":"https://api.github.com/users/stefan-muc/orgs","repos_url":"https://api.github.com/users/stefan-muc/repos","events_url":"https://api.github.com/users/stefan-muc/events{/privacy}","received_events_url":"https://api.github.com/users/stefan-muc/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T12:47:03Z","updated_at":"2016-07-19T12:47:03Z","body":"Thank's for your effort! I think it's the best to have two branches, one for the \"original\" version with bugfixes, and one for version 2 with your API breaking changes - so the users can decide itself which version they use.\r\n\r\nI created a new organisation [libb64](https://github.com/libb64), included your changes until [d901025](https://github.com/stefan-muc/libb64/commit/d901025d816e5be784ffdeb470729a729209f854) and created a new branch \"version2\" with all your other changes.\r\nYou should have recieved an invitation for joining this organisation, so you can continue development of libb64.\r\n\r\nWith change [04a1ee7](https://github.com/libb64/libb64/commit/04a1ee7590ebb8a81bbd3854ec141c2d4c2bead9) I also included a small note on the history of the project.\r\n\r\nWhat do you say, does this solution look good?"}}
{"actor":{"display_login":"stefan-muc"}}