{"action":"created","comment":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments/61657891","id":61657891,"diff_hunk":"@@ -496,8 +496,7 @@ inline bool contains(const Container & container, const Value & value)\n \n \n #if 1","path":"src/util.hpp","position":3,"original_position":3,"commit_id":"36b9f7aba401f697146a768191f6301b98715408","original_commit_id":"36b9f7aba401f697146a768191f6301b98715408","user":{"login":"aginor","id":51365,"avatar_url":"https://avatars.githubusercontent.com/u/51365?v=3","gravatar_id":"","url":"https://api.github.com/users/aginor","html_url":"https://github.com/aginor","followers_url":"https://api.github.com/users/aginor/followers","following_url":"https://api.github.com/users/aginor/following{/other_user}","gists_url":"https://api.github.com/users/aginor/gists{/gist_id}","starred_url":"https://api.github.com/users/aginor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aginor/subscriptions","organizations_url":"https://api.github.com/users/aginor/orgs","repos_url":"https://api.github.com/users/aginor/repos","events_url":"https://api.github.com/users/aginor/events{/privacy}","received_events_url":"https://api.github.com/users/aginor/received_events","type":"User","site_admin":false},"body":"remove #if 1?","created_at":"2016-04-29T23:35:02Z","updated_at":"2016-04-29T23:35:02Z","html_url":"https://github.com/wesnoth/wesnoth/pull/645#discussion_r61657891","pull_request_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments/61657891"},"html":{"href":"https://github.com/wesnoth/wesnoth/pull/645#discussion_r61657891"},"pull_request":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645","id":65758392,"html_url":"https://github.com/wesnoth/wesnoth/pull/645","diff_url":"https://github.com/wesnoth/wesnoth/pull/645.diff","patch_url":"https://github.com/wesnoth/wesnoth/pull/645.patch","issue_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/645","number":645,"state":"open","locked":false,"title":"[WIP] Make wesnothd use asio network api instead of SDL_net","user":{"login":"loonycyborg","id":862623,"avatar_url":"https://avatars.githubusercontent.com/u/862623?v=3","gravatar_id":"","url":"https://api.github.com/users/loonycyborg","html_url":"https://github.com/loonycyborg","followers_url":"https://api.github.com/users/loonycyborg/followers","following_url":"https://api.github.com/users/loonycyborg/following{/other_user}","gists_url":"https://api.github.com/users/loonycyborg/gists{/gist_id}","starred_url":"https://api.github.com/users/loonycyborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loonycyborg/subscriptions","organizations_url":"https://api.github.com/users/loonycyborg/orgs","repos_url":"https://api.github.com/users/loonycyborg/repos","events_url":"https://api.github.com/users/loonycyborg/events{/privacy}","received_events_url":"https://api.github.com/users/loonycyborg/received_events","type":"User","site_admin":false},"body":"This removes SDL and SDL_net dependency from wesnothd. This is part of general plan to drop SDL_net, though this PR is only about wesnothd, the multiplayer server.\r\n\r\nReasons for dropping SDL_net are:\r\n- Supporting  IPv6\r\n- Removing dependency on SDL from server components\r\n- Doing networking using proper asynchronous os primitives, which allows avoiding the use of threads and making code less hackish overall.","created_at":"2016-04-08T09:21:09Z","updated_at":"2016-04-29T23:35:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acbe28dfdcf0b100c0167675c1379e1cfd4b7e69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645/commits","review_comments_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645/comments","review_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/645/comments","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/36b9f7aba401f697146a768191f6301b98715408","head":{"label":"wesnoth:asio_wesnothd","ref":"asio_wesnothd","sha":"36b9f7aba401f697146a768191f6301b98715408","user":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?v=3","gravatar_id":"","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"repo":{"id":9432220,"name":"wesnoth","full_name":"wesnoth/wesnoth","owner":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?v=3","gravatar_id":"","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wesnoth/wesnoth","description":"Free, turn-based strategy game with a high fantasy theme, featuring both singleplayer and online/hotseat multiplayer combat.","fork":false,"url":"https://api.github.com/repos/wesnoth/wesnoth","forks_url":"https://api.github.com/repos/wesnoth/wesnoth/forks","keys_url":"https://api.github.com/repos/wesnoth/wesnoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesnoth/wesnoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesnoth/wesnoth/teams","hooks_url":"https://api.github.com/repos/wesnoth/wesnoth/hooks","issue_events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/events{/number}","events_url":"https://api.github.com/repos/wesnoth/wesnoth/events","assignees_url":"https://api.github.com/repos/wesnoth/wesnoth/assignees{/user}","branches_url":"https://api.github.com/repos/wesnoth/wesnoth/branches{/branch}","tags_url":"https://api.github.com/repos/wesnoth/wesnoth/tags","blobs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesnoth/wesnoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesnoth/wesnoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/{sha}","languages_url":"https://api.github.com/repos/wesnoth/wesnoth/languages","stargazers_url":"https://api.github.com/repos/wesnoth/wesnoth/stargazers","contributors_url":"https://api.github.com/repos/wesnoth/wesnoth/contributors","subscribers_url":"https://api.github.com/repos/wesnoth/wesnoth/subscribers","subscription_url":"https://api.github.com/repos/wesnoth/wesnoth/subscription","commits_url":"https://api.github.com/repos/wesnoth/wesnoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesnoth/wesnoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesnoth/wesnoth/contents/{+path}","compare_url":"https://api.github.com/repos/wesnoth/wesnoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesnoth/wesnoth/merges","archive_url":"https://api.github.com/repos/wesnoth/wesnoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesnoth/wesnoth/downloads","issues_url":"https://api.github.com/repos/wesnoth/wesnoth/issues{/number}","pulls_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls{/number}","milestones_url":"https://api.github.com/repos/wesnoth/wesnoth/milestones{/number}","notifications_url":"https://api.github.com/repos/wesnoth/wesnoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/labels{/name}","releases_url":"https://api.github.com/repos/wesnoth/wesnoth/releases{/id}","deployments_url":"https://api.github.com/repos/wesnoth/wesnoth/deployments","created_at":"2013-04-14T17:13:06Z","updated_at":"2016-04-28T08:57:51Z","pushed_at":"2016-04-28T02:24:12Z","git_url":"git://github.com/wesnoth/wesnoth.git","ssh_url":"git@github.com:wesnoth/wesnoth.git","clone_url":"https://github.com/wesnoth/wesnoth.git","svn_url":"https://github.com/wesnoth/wesnoth","homepage":"http://www.wesnoth.org/","size":2446993,"stargazers_count":829,"watchers_count":829,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":23,"forks":286,"open_issues":23,"watchers":829,"default_branch":"master"}},"base":{"label":"wesnoth:master","ref":"master","sha":"547bf2f1df2585968996fd38fb26d3539dde1f48","user":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?v=3","gravatar_id":"","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"repo":{"id":9432220,"name":"wesnoth","full_name":"wesnoth/wesnoth","owner":{"login":"wesnoth","id":4024232,"avatar_url":"https://avatars.githubusercontent.com/u/4024232?v=3","gravatar_id":"","url":"https://api.github.com/users/wesnoth","html_url":"https://github.com/wesnoth","followers_url":"https://api.github.com/users/wesnoth/followers","following_url":"https://api.github.com/users/wesnoth/following{/other_user}","gists_url":"https://api.github.com/users/wesnoth/gists{/gist_id}","starred_url":"https://api.github.com/users/wesnoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesnoth/subscriptions","organizations_url":"https://api.github.com/users/wesnoth/orgs","repos_url":"https://api.github.com/users/wesnoth/repos","events_url":"https://api.github.com/users/wesnoth/events{/privacy}","received_events_url":"https://api.github.com/users/wesnoth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wesnoth/wesnoth","description":"Free, turn-based strategy game with a high fantasy theme, featuring both singleplayer and online/hotseat multiplayer combat.","fork":false,"url":"https://api.github.com/repos/wesnoth/wesnoth","forks_url":"https://api.github.com/repos/wesnoth/wesnoth/forks","keys_url":"https://api.github.com/repos/wesnoth/wesnoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesnoth/wesnoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesnoth/wesnoth/teams","hooks_url":"https://api.github.com/repos/wesnoth/wesnoth/hooks","issue_events_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/events{/number}","events_url":"https://api.github.com/repos/wesnoth/wesnoth/events","assignees_url":"https://api.github.com/repos/wesnoth/wesnoth/assignees{/user}","branches_url":"https://api.github.com/repos/wesnoth/wesnoth/branches{/branch}","tags_url":"https://api.github.com/repos/wesnoth/wesnoth/tags","blobs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesnoth/wesnoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesnoth/wesnoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesnoth/wesnoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesnoth/wesnoth/statuses/{sha}","languages_url":"https://api.github.com/repos/wesnoth/wesnoth/languages","stargazers_url":"https://api.github.com/repos/wesnoth/wesnoth/stargazers","contributors_url":"https://api.github.com/repos/wesnoth/wesnoth/contributors","subscribers_url":"https://api.github.com/repos/wesnoth/wesnoth/subscribers","subscription_url":"https://api.github.com/repos/wesnoth/wesnoth/subscription","commits_url":"https://api.github.com/repos/wesnoth/wesnoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesnoth/wesnoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesnoth/wesnoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesnoth/wesnoth/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesnoth/wesnoth/contents/{+path}","compare_url":"https://api.github.com/repos/wesnoth/wesnoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesnoth/wesnoth/merges","archive_url":"https://api.github.com/repos/wesnoth/wesnoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesnoth/wesnoth/downloads","issues_url":"https://api.github.com/repos/wesnoth/wesnoth/issues{/number}","pulls_url":"https://api.github.com/repos/wesnoth/wesnoth/pulls{/number}","milestones_url":"https://api.github.com/repos/wesnoth/wesnoth/milestones{/number}","notifications_url":"https://api.github.com/repos/wesnoth/wesnoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesnoth/wesnoth/labels{/name}","releases_url":"https://api.github.com/repos/wesnoth/wesnoth/releases{/id}","deployments_url":"https://api.github.com/repos/wesnoth/wesnoth/deployments","created_at":"2013-04-14T17:13:06Z","updated_at":"2016-04-28T08:57:51Z","pushed_at":"2016-04-28T02:24:12Z","git_url":"git://github.com/wesnoth/wesnoth.git","ssh_url":"git@github.com:wesnoth/wesnoth.git","clone_url":"https://github.com/wesnoth/wesnoth.git","svn_url":"https://github.com/wesnoth/wesnoth","homepage":"http://www.wesnoth.org/","size":2446993,"stargazers_count":829,"watchers_count":829,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":23,"forks":286,"open_issues":23,"watchers":829,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645"},"html":{"href":"https://github.com/wesnoth/wesnoth/pull/645"},"issue":{"href":"https://api.github.com/repos/wesnoth/wesnoth/issues/645"},"comments":{"href":"https://api.github.com/repos/wesnoth/wesnoth/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wesnoth/wesnoth/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/wesnoth/wesnoth/statuses/36b9f7aba401f697146a768191f6301b98715408"}}}}