{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/comments/78185110","id":78185110,"diff_hunk":"@@ -94,33 +94,33 @@ def __init__(self, params):\n             alarm_constants.CHRONOS_NOT_YET_CLUSTERED)\n         pdlogs.NOT_YET_CLUSTERED_ALARM.log(cluster_desc=self.cluster_description())\n \n-    def key(self): # pragma: no cover\n+    def key(self):  # pragma: no cover","path":"chronos/chronos_plugin.py","position":5,"original_position":5,"commit_id":"949427b5ea1fb30260db132797bd0e890790fc9d","original_commit_id":"949427b5ea1fb30260db132797bd0e890790fc9d","user":{"login":"johadalin","id":14074163,"avatar_url":"https://avatars.githubusercontent.com/u/14074163?v=3","gravatar_id":"","url":"https://api.github.com/users/johadalin","html_url":"https://github.com/johadalin","followers_url":"https://api.github.com/users/johadalin/followers","following_url":"https://api.github.com/users/johadalin/following{/other_user}","gists_url":"https://api.github.com/users/johadalin/gists{/gist_id}","starred_url":"https://api.github.com/users/johadalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johadalin/subscriptions","organizations_url":"https://api.github.com/users/johadalin/orgs","repos_url":"https://api.github.com/users/johadalin/repos","events_url":"https://api.github.com/users/johadalin/events{/privacy}","received_events_url":"https://api.github.com/users/johadalin/received_events","type":"User","site_admin":false},"body":"Flake8 said there should be 2 spaces before end of line comments, and as i was doing so for everything else, i thought i'd better update for consistency here","created_at":"2016-09-09T14:04:36Z","updated_at":"2016-09-09T14:04:36Z","html_url":"https://github.com/Metaswitch/clearwater-etcd-plugins/pull/7#discussion_r78185110","pull_request_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/comments/78185110"},"html":{"href":"https://github.com/Metaswitch/clearwater-etcd-plugins/pull/7#discussion_r78185110"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7","id":84457471,"html_url":"https://github.com/Metaswitch/clearwater-etcd-plugins/pull/7","diff_url":"https://github.com/Metaswitch/clearwater-etcd-plugins/pull/7.diff","patch_url":"https://github.com/Metaswitch/clearwater-etcd-plugins/pull/7.patch","issue_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/7","number":7,"state":"open","locked":false,"title":"[Reviewer: Ellie] Ut coverage changes","user":{"login":"johadalin","id":14074163,"avatar_url":"https://avatars.githubusercontent.com/u/14074163?v=3","gravatar_id":"","url":"https://api.github.com/users/johadalin","html_url":"https://github.com/johadalin","followers_url":"https://api.github.com/users/johadalin/followers","following_url":"https://api.github.com/users/johadalin/following{/other_user}","gists_url":"https://api.github.com/users/johadalin/gists{/gist_id}","starred_url":"https://api.github.com/users/johadalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johadalin/subscriptions","organizations_url":"https://api.github.com/users/johadalin/orgs","repos_url":"https://api.github.com/users/johadalin/repos","events_url":"https://api.github.com/users/johadalin/events{/privacy}","received_events_url":"https://api.github.com/users/johadalin/received_events","type":"User","site_admin":false},"body":"The addition of `# pragma: no coverage` to the plugin files to make coverage tests sane. \r\nThese match up with the larger plugin_ut pull request in clearwater-etcd.\r\n\r\nThis will probably be an easy way for you to see what sections of the plugins are and aren't tested, and kick me if you think other sections can or should be tested more.","created_at":"2016-09-08T11:07:57Z","updated_at":"2016-09-09T14:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce0d364b902c1f944ae7e6e79259da9d74ed9546","assignee":{"login":"johadalin","id":14074163,"avatar_url":"https://avatars.githubusercontent.com/u/14074163?v=3","gravatar_id":"","url":"https://api.github.com/users/johadalin","html_url":"https://github.com/johadalin","followers_url":"https://api.github.com/users/johadalin/followers","following_url":"https://api.github.com/users/johadalin/following{/other_user}","gists_url":"https://api.github.com/users/johadalin/gists{/gist_id}","starred_url":"https://api.github.com/users/johadalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johadalin/subscriptions","organizations_url":"https://api.github.com/users/johadalin/orgs","repos_url":"https://api.github.com/users/johadalin/repos","events_url":"https://api.github.com/users/johadalin/events{/privacy}","received_events_url":"https://api.github.com/users/johadalin/received_events","type":"User","site_admin":false},"assignees":[{"login":"johadalin","id":14074163,"avatar_url":"https://avatars.githubusercontent.com/u/14074163?v=3","gravatar_id":"","url":"https://api.github.com/users/johadalin","html_url":"https://github.com/johadalin","followers_url":"https://api.github.com/users/johadalin/followers","following_url":"https://api.github.com/users/johadalin/following{/other_user}","gists_url":"https://api.github.com/users/johadalin/gists{/gist_id}","starred_url":"https://api.github.com/users/johadalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johadalin/subscriptions","organizations_url":"https://api.github.com/users/johadalin/orgs","repos_url":"https://api.github.com/users/johadalin/repos","events_url":"https://api.github.com/users/johadalin/events{/privacy}","received_events_url":"https://api.github.com/users/johadalin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/7/comments","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/statuses/949427b5ea1fb30260db132797bd0e890790fc9d","head":{"label":"Metaswitch:UT_coverage_changes","ref":"UT_coverage_changes","sha":"949427b5ea1fb30260db132797bd0e890790fc9d","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":66262076,"name":"clearwater-etcd-plugins","full_name":"Metaswitch/clearwater-etcd-plugins","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-etcd-plugins","description":"Plugins for clearwater-etcd","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/deployments","created_at":"2016-08-22T10:15:40Z","updated_at":"2016-08-22T12:09:53Z","pushed_at":"2016-09-09T10:28:09Z","git_url":"git://github.com/Metaswitch/clearwater-etcd-plugins.git","ssh_url":"git@github.com:Metaswitch/clearwater-etcd-plugins.git","clone_url":"https://github.com/Metaswitch/clearwater-etcd-plugins.git","svn_url":"https://github.com/Metaswitch/clearwater-etcd-plugins","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"171537e59df83bc8a6699a0c5f41b7486831c9e0","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":66262076,"name":"clearwater-etcd-plugins","full_name":"Metaswitch/clearwater-etcd-plugins","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/clearwater-etcd-plugins","description":"Plugins for clearwater-etcd","fork":false,"url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins","forks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/forks","keys_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/teams","hooks_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/events","assignees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/tags","blobs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/subscription","commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/merges","archive_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/downloads","issues_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/deployments","created_at":"2016-08-22T10:15:40Z","updated_at":"2016-08-22T12:09:53Z","pushed_at":"2016-09-09T10:28:09Z","git_url":"git://github.com/Metaswitch/clearwater-etcd-plugins.git","ssh_url":"git@github.com:Metaswitch/clearwater-etcd-plugins.git","clone_url":"https://github.com/Metaswitch/clearwater-etcd-plugins.git","svn_url":"https://github.com/Metaswitch/clearwater-etcd-plugins","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7"},"html":{"href":"https://github.com/Metaswitch/clearwater-etcd-plugins/pull/7"},"issue":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/7"},"comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/clearwater-etcd-plugins/statuses/949427b5ea1fb30260db132797bd0e890790fc9d"}}}}
{"actor":{"display_login":"johadalin"}}