{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/13240","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/13240/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13240/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/13240/events","html_url":"https://github.com/edx/edx-platform/pull/13240","id":171202390,"number":13240,"title":"TNL-5186: Remove \"All Discussions\" button","user":{"login":"bjacobel","id":407639,"avatar_url":"https://avatars.githubusercontent.com/u/407639?v=3","gravatar_id":"","url":"https://api.github.com/users/bjacobel","html_url":"https://github.com/bjacobel","followers_url":"https://api.github.com/users/bjacobel/followers","following_url":"https://api.github.com/users/bjacobel/following{/other_user}","gists_url":"https://api.github.com/users/bjacobel/gists{/gist_id}","starred_url":"https://api.github.com/users/bjacobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjacobel/subscriptions","organizations_url":"https://api.github.com/users/bjacobel/orgs","repos_url":"https://api.github.com/users/bjacobel/repos","events_url":"https://api.github.com/users/bjacobel/events{/privacy}","received_events_url":"https://api.github.com/users/bjacobel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-15T16:07:06Z","updated_at":"2016-08-16T20:34:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13240","html_url":"https://github.com/edx/edx-platform/pull/13240","diff_url":"https://github.com/edx/edx-platform/pull/13240.diff","patch_url":"https://github.com/edx/edx-platform/pull/13240.patch"},"body":"### Description\r\n \r\n[TNL-5186](https://openedx.atlassian.net/browse/TNL-5186)\r\n\r\nRemoves the button that sat atop the discussion thread list and assigns most of that button's actions to the root breadcrumb.\r\n\r\n### Sandbox\r\n- [x] https://bjacobel-remove-topic-btn.sandbox.edx.org (updated at Tue Aug 16 13:55:28 EDT 2016)\r\n\r\n### Testing\r\n- [x] i18n\r\n- [x] RTL\r\n- [x] safecommit violation code review process\r\n- [x] Unit, integration, acceptance tests as appropriate\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @andy-armstrong \r\n- [ ] Code review: @dianakhuang \r\n- [ ] Doc Review: @catong \r\n- [ ] UX review: @chris-mike \r\n- [ ] Accessibility review: @edx/edx-accessibility \r\n- [x] Product review: @marcotuts \r\n\r\n### Post-review\r\n- [ ] Squash commits"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/240229580","html_url":"https://github.com/edx/edx-platform/pull/13240#issuecomment-240229580","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13240","id":240229580,"user":{"login":"dianakhuang","id":2952947,"avatar_url":"https://avatars.githubusercontent.com/u/2952947?v=3","gravatar_id":"","url":"https://api.github.com/users/dianakhuang","html_url":"https://github.com/dianakhuang","followers_url":"https://api.github.com/users/dianakhuang/followers","following_url":"https://api.github.com/users/dianakhuang/following{/other_user}","gists_url":"https://api.github.com/users/dianakhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/dianakhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianakhuang/subscriptions","organizations_url":"https://api.github.com/users/dianakhuang/orgs","repos_url":"https://api.github.com/users/dianakhuang/repos","events_url":"https://api.github.com/users/dianakhuang/events{/privacy}","received_events_url":"https://api.github.com/users/dianakhuang/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T20:34:54Z","updated_at":"2016-08-16T20:34:54Z","body":"I agree with @catong that this line of text needs to be updated: https://github.com/edx/edx-platform/blob/086b0a14b583c3107998ab11558d1370c6020230/common/static/common/templates/discussion/discussion-home.underscore#L21\r\n\r\nOther than that and the i18n issue, it's looking good."}}
{"actor":{"display_login":"dianakhuang"}}