{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beat-generator/pulls/comments/55730297","id":55730297,"diff_hunk":"@@ -13,40 +11,36 @@ import (\n )\n \n type {{cookiecutter.beat|capitalize}} struct {\n-\tConfiguration *config.Config\n-\tdone          chan struct{}\n-\tperiod        time.Duration\n+    beatConfig *config.{{cookiecutter.beat|capitalize}}Config\n+    done       chan struct{}\n+    period     time.Duration\n }\n \n // Creates beater\n func New() *{{cookiecutter.beat|capitalize}} {\n-\treturn &{{cookiecutter.beat|capitalize}}{","path":"{{cookiecutter.beat}}/beater/{{cookiecutter.beat}}.go","position":26,"original_position":26,"commit_id":"962199ba74e46142a98b3c9f1c0f27ffbf4b888e","original_commit_id":"50a7ec4f8522dac47959a4dcb437e1192aaf3994","user":{"login":"buehler","id":1067213,"avatar_url":"https://avatars.githubusercontent.com/u/1067213?v=3","gravatar_id":"","url":"https://api.github.com/users/buehler","html_url":"https://github.com/buehler","followers_url":"https://api.github.com/users/buehler/followers","following_url":"https://api.github.com/users/buehler/following{/other_user}","gists_url":"https://api.github.com/users/buehler/gists{/gist_id}","starred_url":"https://api.github.com/users/buehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehler/subscriptions","organizations_url":"https://api.github.com/users/buehler/orgs","repos_url":"https://api.github.com/users/buehler/repos","events_url":"https://api.github.com/users/buehler/events{/privacy}","received_events_url":"https://api.github.com/users/buehler/received_events","type":"User","site_admin":false},"body":"oh.. this could be the IDE :-/\r\nactually I used \"goformat\"","created_at":"2016-03-10T18:57:12Z","updated_at":"2016-03-10T18:57:12Z","html_url":"https://github.com/elastic/beat-generator/pull/18#discussion_r55730297","pull_request_url":"https://api.github.com/repos/elastic/beat-generator/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/elastic/beat-generator/pulls/comments/55730297"},"html":{"href":"https://github.com/elastic/beat-generator/pull/18#discussion_r55730297"},"pull_request":{"href":"https://api.github.com/repos/elastic/beat-generator/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beat-generator/pulls/18","id":62393819,"html_url":"https://github.com/elastic/beat-generator/pull/18","diff_url":"https://github.com/elastic/beat-generator/pull/18.diff","patch_url":"https://github.com/elastic/beat-generator/pull/18.patch","issue_url":"https://api.github.com/repos/elastic/beat-generator/issues/18","number":18,"state":"open","locked":false,"title":"Configuration initializer and renaming","user":{"login":"buehler","id":1067213,"avatar_url":"https://avatars.githubusercontent.com/u/1067213?v=3","gravatar_id":"","url":"https://api.github.com/users/buehler","html_url":"https://github.com/buehler","followers_url":"https://api.github.com/users/buehler/followers","following_url":"https://api.github.com/users/buehler/following{/other_user}","gists_url":"https://api.github.com/users/buehler/gists{/gist_id}","starred_url":"https://api.github.com/users/buehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehler/subscriptions","organizations_url":"https://api.github.com/users/buehler/orgs","repos_url":"https://api.github.com/users/buehler/repos","events_url":"https://api.github.com/users/buehler/events{/privacy}","received_events_url":"https://api.github.com/users/buehler/received_events","type":"User","site_admin":false},"body":"Based on the discussion of #17, here is the config PR with the following commits:\r\n\r\n- Rename beat.yml to {{cookiecutter.beat}}.yml\r\n- Add the config initializer to get a pointer to the config struct (instead of init the config and set defaults in the beat code)\r\n- Rename the `Configuration` to `beatConfig` and thus make it private by default\r\n\r\nI'm happy for more input :smiley: ","created_at":"2016-03-10T14:05:22Z","updated_at":"2016-03-10T18:57:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db177795b63039322240c883d74661407d5bb68b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beat-generator/pulls/18/commits","review_comments_url":"https://api.github.com/repos/elastic/beat-generator/pulls/18/comments","review_comment_url":"https://api.github.com/repos/elastic/beat-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beat-generator/issues/18/comments","statuses_url":"https://api.github.com/repos/elastic/beat-generator/statuses/962199ba74e46142a98b3c9f1c0f27ffbf4b888e","head":{"label":"buehler:feature/config-init-and-rename","ref":"feature/config-init-and-rename","sha":"962199ba74e46142a98b3c9f1c0f27ffbf4b888e","user":{"login":"buehler","id":1067213,"avatar_url":"https://avatars.githubusercontent.com/u/1067213?v=3","gravatar_id":"","url":"https://api.github.com/users/buehler","html_url":"https://github.com/buehler","followers_url":"https://api.github.com/users/buehler/followers","following_url":"https://api.github.com/users/buehler/following{/other_user}","gists_url":"https://api.github.com/users/buehler/gists{/gist_id}","starred_url":"https://api.github.com/users/buehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehler/subscriptions","organizations_url":"https://api.github.com/users/buehler/orgs","repos_url":"https://api.github.com/users/buehler/repos","events_url":"https://api.github.com/users/buehler/events{/privacy}","received_events_url":"https://api.github.com/users/buehler/received_events","type":"User","site_admin":false},"repo":{"id":53411632,"name":"go-elastic-beat-generator","full_name":"buehler/go-elastic-beat-generator","owner":{"login":"buehler","id":1067213,"avatar_url":"https://avatars.githubusercontent.com/u/1067213?v=3","gravatar_id":"","url":"https://api.github.com/users/buehler","html_url":"https://github.com/buehler","followers_url":"https://api.github.com/users/buehler/followers","following_url":"https://api.github.com/users/buehler/following{/other_user}","gists_url":"https://api.github.com/users/buehler/gists{/gist_id}","starred_url":"https://api.github.com/users/buehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buehler/subscriptions","organizations_url":"https://api.github.com/users/buehler/orgs","repos_url":"https://api.github.com/users/buehler/repos","events_url":"https://api.github.com/users/buehler/events{/privacy}","received_events_url":"https://api.github.com/users/buehler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buehler/go-elastic-beat-generator","description":"Create the foundation of your own beat in seconds","fork":true,"url":"https://api.github.com/repos/buehler/go-elastic-beat-generator","forks_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/forks","keys_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/teams","hooks_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/hooks","issue_events_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/issues/events{/number}","events_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/events","assignees_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/assignees{/user}","branches_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/branches{/branch}","tags_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/tags","blobs_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/languages","stargazers_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/stargazers","contributors_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/contributors","subscribers_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/subscribers","subscription_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/subscription","commits_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/contents/{+path}","compare_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/merges","archive_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/downloads","issues_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/issues{/number}","pulls_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/labels{/name}","releases_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/releases{/id}","deployments_url":"https://api.github.com/repos/buehler/go-elastic-beat-generator/deployments","created_at":"2016-03-08T12:51:05Z","updated_at":"2016-03-08T12:51:37Z","pushed_at":"2016-03-10T18:54:09Z","git_url":"git://github.com/buehler/go-elastic-beat-generator.git","ssh_url":"git@github.com:buehler/go-elastic-beat-generator.git","clone_url":"https://github.com/buehler/go-elastic-beat-generator.git","svn_url":"https://github.com/buehler/go-elastic-beat-generator","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"b26a39e67a3a7f732f2094184d0397cd4a9f175e","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":50187058,"name":"beat-generator","full_name":"elastic/beat-generator","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beat-generator","description":"Create the foundation of your own beat in seconds","fork":false,"url":"https://api.github.com/repos/elastic/beat-generator","forks_url":"https://api.github.com/repos/elastic/beat-generator/forks","keys_url":"https://api.github.com/repos/elastic/beat-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beat-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beat-generator/teams","hooks_url":"https://api.github.com/repos/elastic/beat-generator/hooks","issue_events_url":"https://api.github.com/repos/elastic/beat-generator/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beat-generator/events","assignees_url":"https://api.github.com/repos/elastic/beat-generator/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beat-generator/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beat-generator/tags","blobs_url":"https://api.github.com/repos/elastic/beat-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beat-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beat-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beat-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beat-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beat-generator/languages","stargazers_url":"https://api.github.com/repos/elastic/beat-generator/stargazers","contributors_url":"https://api.github.com/repos/elastic/beat-generator/contributors","subscribers_url":"https://api.github.com/repos/elastic/beat-generator/subscribers","subscription_url":"https://api.github.com/repos/elastic/beat-generator/subscription","commits_url":"https://api.github.com/repos/elastic/beat-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beat-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beat-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beat-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beat-generator/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beat-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beat-generator/merges","archive_url":"https://api.github.com/repos/elastic/beat-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beat-generator/downloads","issues_url":"https://api.github.com/repos/elastic/beat-generator/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beat-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beat-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beat-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beat-generator/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beat-generator/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beat-generator/deployments","created_at":"2016-01-22T14:46:32Z","updated_at":"2016-03-02T06:25:27Z","pushed_at":"2016-03-10T18:54:10Z","git_url":"git://github.com/elastic/beat-generator.git","ssh_url":"git@github.com:elastic/beat-generator.git","clone_url":"https://github.com/elastic/beat-generator.git","svn_url":"https://github.com/elastic/beat-generator","homepage":null,"size":24,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beat-generator/pulls/18"},"html":{"href":"https://github.com/elastic/beat-generator/pull/18"},"issue":{"href":"https://api.github.com/repos/elastic/beat-generator/issues/18"},"comments":{"href":"https://api.github.com/repos/elastic/beat-generator/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beat-generator/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beat-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beat-generator/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beat-generator/statuses/962199ba74e46142a98b3c9f1c0f27ffbf4b888e"}}}}