{"action":"created","issue":{"url":"https://api.github.com/repos/sclorg/postgresql-container/issues/145","repository_url":"https://api.github.com/repos/sclorg/postgresql-container","labels_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/145/comments","events_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/145/events","html_url":"https://github.com/sclorg/postgresql-container/pull/145","id":179331859,"number":145,"title":"WIP: use secrets for postgres creds","user":{"login":"ibotty","id":296430,"avatar_url":"https://avatars.githubusercontent.com/u/296430?v=3","gravatar_id":"","url":"https://api.github.com/users/ibotty","html_url":"https://github.com/ibotty","followers_url":"https://api.github.com/users/ibotty/followers","following_url":"https://api.github.com/users/ibotty/following{/other_user}","gists_url":"https://api.github.com/users/ibotty/gists{/gist_id}","starred_url":"https://api.github.com/users/ibotty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibotty/subscriptions","organizations_url":"https://api.github.com/users/ibotty/orgs","repos_url":"https://api.github.com/users/ibotty/repos","events_url":"https://api.github.com/users/ibotty/events{/privacy}","received_events_url":"https://api.github.com/users/ibotty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hhorak","id":1405588,"avatar_url":"https://avatars.githubusercontent.com/u/1405588?v=3","gravatar_id":"","url":"https://api.github.com/users/hhorak","html_url":"https://github.com/hhorak","followers_url":"https://api.github.com/users/hhorak/followers","following_url":"https://api.github.com/users/hhorak/following{/other_user}","gists_url":"https://api.github.com/users/hhorak/gists{/gist_id}","starred_url":"https://api.github.com/users/hhorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhorak/subscriptions","organizations_url":"https://api.github.com/users/hhorak/orgs","repos_url":"https://api.github.com/users/hhorak/repos","events_url":"https://api.github.com/users/hhorak/events{/privacy}","received_events_url":"https://api.github.com/users/hhorak/received_events","type":"User","site_admin":false},"assignees":[{"login":"hhorak","id":1405588,"avatar_url":"https://avatars.githubusercontent.com/u/1405588?v=3","gravatar_id":"","url":"https://api.github.com/users/hhorak","html_url":"https://github.com/hhorak","followers_url":"https://api.github.com/users/hhorak/followers","following_url":"https://api.github.com/users/hhorak/following{/other_user}","gists_url":"https://api.github.com/users/hhorak/gists{/gist_id}","starred_url":"https://api.github.com/users/hhorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhorak/subscriptions","organizations_url":"https://api.github.com/users/hhorak/orgs","repos_url":"https://api.github.com/users/hhorak/repos","events_url":"https://api.github.com/users/hhorak/events{/privacy}","received_events_url":"https://api.github.com/users/hhorak/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2016-09-26T20:41:41Z","updated_at":"2016-10-10T17:42:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/145","html_url":"https://github.com/sclorg/postgresql-container/pull/145","diff_url":"https://github.com/sclorg/postgresql-container/pull/145.diff","patch_url":"https://github.com/sclorg/postgresql-container/pull/145.patch"},"body":"See issue #101.\r\n\r\nThis is only in the 9.5 directory for now.\r\n\r\nWhat do you think about it? I don't really like the logic re \"simple_db\", etc, but I left it as is. When using secrets, it might make sense to not use magic account names (e.g. the admin user `postgres` can be in any secret, no need for \"user\" credentials, one valid set of credentials is enough, etc.). If you have a preference on how that should be handled, I'll gladly implement it."},"comment":{"url":"https://api.github.com/repos/sclorg/postgresql-container/issues/comments/252689409","html_url":"https://github.com/sclorg/postgresql-container/pull/145#issuecomment-252689409","issue_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/145","id":252689409,"user":{"login":"ibotty","id":296430,"avatar_url":"https://avatars.githubusercontent.com/u/296430?v=3","gravatar_id":"","url":"https://api.github.com/users/ibotty","html_url":"https://github.com/ibotty","followers_url":"https://api.github.com/users/ibotty/followers","following_url":"https://api.github.com/users/ibotty/following{/other_user}","gists_url":"https://api.github.com/users/ibotty/gists{/gist_id}","starred_url":"https://api.github.com/users/ibotty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibotty/subscriptions","organizations_url":"https://api.github.com/users/ibotty/orgs","repos_url":"https://api.github.com/users/ibotty/repos","events_url":"https://api.github.com/users/ibotty/events{/privacy}","received_events_url":"https://api.github.com/users/ibotty/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T17:42:22Z","updated_at":"2016-10-10T17:42:22Z","body":"I disagree. Without the possibility to set multiple users it's not easily possible to, say, have a template generate an application, consisting of a database pod, a management pod and a frontend pod (with restricted db permissions). The implementation of that feature is really easy. Most parts are only moving around functionality (which makes sense regardless of mounting creds with secrets). If the crude simpledb logic were not included, the core part of that patch is maybe 5 lines!"}}
{"actor":{"display_login":"ibotty"}}