{"action":"created","issue":{"url":"https://api.github.com/repos/google/flatbuffers/issues/4048","repository_url":"https://api.github.com/repos/google/flatbuffers","labels_url":"https://api.github.com/repos/google/flatbuffers/issues/4048/labels{/name}","comments_url":"https://api.github.com/repos/google/flatbuffers/issues/4048/comments","events_url":"https://api.github.com/repos/google/flatbuffers/issues/4048/events","html_url":"https://github.com/google/flatbuffers/pull/4048","id":181673239,"number":4048,"title":"Add KeySearch schema and test data for testing by key look-up for all field types.","user":{"login":"blep","id":622106,"avatar_url":"https://avatars.githubusercontent.com/u/622106?v=3","gravatar_id":"","url":"https://api.github.com/users/blep","html_url":"https://github.com/blep","followers_url":"https://api.github.com/users/blep/followers","following_url":"https://api.github.com/users/blep/following{/other_user}","gists_url":"https://api.github.com/users/blep/gists{/gist_id}","starred_url":"https://api.github.com/users/blep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blep/subscriptions","organizations_url":"https://api.github.com/users/blep/orgs","repos_url":"https://api.github.com/users/blep/repos","events_url":"https://api.github.com/users/blep/events{/privacy}","received_events_url":"https://api.github.com/users/blep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-07T13:47:59Z","updated_at":"2016-10-17T17:15:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/4048","html_url":"https://github.com/google/flatbuffers/pull/4048","diff_url":"https://github.com/google/flatbuffers/pull/4048.diff","patch_url":"https://github.com/google/flatbuffers/pull/4048.patch"},"body":"I created this to validate the look-up by key implementation in Java and extended it to support all basic value types.\r\n\r\nIt found two bugs in the Java code generator related to default value handling (long constant not suffixed by L and unsigned constant not \"converted\" to the signed equivalent you would expect in Java).\r\n\r\nI wanted to have some feedbacks before I continued further (I was somewhat surprised not to find something like this existing on this project). I plan is to use this to validate the Java implementation.\r\n\r\nFor each basic type, the root object has a vector object field. The object has a key and a value of the basic type.\r\n\r\nThe default value is set to the min/max value of the type except for ulong as I'm not sure all languages can represent/manipulate it.\r\n\r\nThere is 3 data files:\r\n- empty vector field\r\n- vector field of size 1\r\n- vector field of varying size (3 to 8 I think), with key for min/max value of basic type and some random point between.\r\n"},"comment":{"url":"https://api.github.com/repos/google/flatbuffers/issues/comments/254271826","html_url":"https://github.com/google/flatbuffers/pull/4048#issuecomment-254271826","issue_url":"https://api.github.com/repos/google/flatbuffers/issues/4048","id":254271826,"user":{"login":"gwvo","id":6145400,"avatar_url":"https://avatars.githubusercontent.com/u/6145400?v=3","gravatar_id":"","url":"https://api.github.com/users/gwvo","html_url":"https://github.com/gwvo","followers_url":"https://api.github.com/users/gwvo/followers","following_url":"https://api.github.com/users/gwvo/following{/other_user}","gists_url":"https://api.github.com/users/gwvo/gists{/gist_id}","starred_url":"https://api.github.com/users/gwvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwvo/subscriptions","organizations_url":"https://api.github.com/users/gwvo/orgs","repos_url":"https://api.github.com/users/gwvo/repos","events_url":"https://api.github.com/users/gwvo/events{/privacy}","received_events_url":"https://api.github.com/users/gwvo/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T17:15:38Z","updated_at":"2016-10-17T17:15:38Z","body":"I believe LookupByKey is only supported in C++/Java/C# so far."}}
{"actor":{"display_login":"gwvo"}}