{"action":"created","comment":{"url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/comments/89237552","pull_request_review_id":9782265,"id":89237552,"diff_hunk":"@@ -71,93 +76,174 @@ describe('User', () => {\n       email: 'ablaw@test.com',\n       password: 'abilaw'\n     })\n-    .expect(201).end((err, res) => {\n+    .expect(201)\n+    .end((err, res) => {\n       expect(res.body.RoleId).to.equal(2);\n       done();\n     });\n   });\n \n   it('should validate that new users create First and Last names.', (done) => {\n-    request.get('/api/users/adlaw').set('x-access-token', token).set('Accept', 'application/json')\n-    .expect(200).end((err, res) => {\n+    request.get('/api/users/adlaw').set('x-access-token', token)\n+    .set('Accept', 'application/json').expect(200)\n+    .end((err, res) => {\n       expect(res.body.lastname).to.equal('Law');\n       expect(res.body.firstname).to.equal('Ade');\n       done();\n     });\n   });\n \n   it('should ensure new user cannot be created without first and last names.', (done) => {\n-    request.post('/api/users').set('x-access-token', token).set('Accept', 'application/json').send({\n+    request.post('/api/users').set('x-access-token', token)\n+    .set('Accept', 'application/json').send({\n       firstname: 'Ade2',\n       lastname: '',\n       username: '',\n       email: 'adlaw2@test.com',\n       password: 'adelaw2',\n       roleId: 2\n-    }).expect(400).end((req, res) => {\n+    })\n+    .expect(400)\n+    .end((req, res) => {\n       expect(res.body.message).to.equal('User not created.');\n-      expect(((res.body.error).split(','))[0]).to.equal('Validation error: Validation notEmpty failed');\n+      expect(((res.body.error).split(','))[0]).to\n+      .equal('Validation error: Validation notEmpty failed');","path":"test/users.spec.js","position":105,"original_position":105,"commit_id":"2a8a8b436c85e9de383fb51fd457070ac444f63b","original_commit_id":"2a8a8b436c85e9de383fb51fd457070ac444f63b","user":{"login":"andela-kakpobome","id":20772189,"avatar_url":"https://avatars.githubusercontent.com/u/20772189?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-kakpobome","html_url":"https://github.com/andela-kakpobome","followers_url":"https://api.github.com/users/andela-kakpobome/followers","following_url":"https://api.github.com/users/andela-kakpobome/following{/other_user}","gists_url":"https://api.github.com/users/andela-kakpobome/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-kakpobome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-kakpobome/subscriptions","organizations_url":"https://api.github.com/users/andela-kakpobome/orgs","repos_url":"https://api.github.com/users/andela-kakpobome/repos","events_url":"https://api.github.com/users/andela-kakpobome/events{/privacy}","received_events_url":"https://api.github.com/users/andela-kakpobome/received_events","type":"User","site_admin":false},"body":"### Critical\r\n\r\nPlease make this error message more descriptive of the actual issue","created_at":"2016-11-23T00:08:49Z","updated_at":"2016-11-23T00:08:49Z","html_url":"https://github.com/andela-abisoye/doc-manager/pull/22#discussion_r89237552","pull_request_url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/comments/89237552"},"html":{"href":"https://github.com/andela-abisoye/doc-manager/pull/22#discussion_r89237552"},"pull_request":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22","id":94647227,"html_url":"https://github.com/andela-abisoye/doc-manager/pull/22","diff_url":"https://github.com/andela-abisoye/doc-manager/pull/22.diff","patch_url":"https://github.com/andela-abisoye/doc-manager/pull/22.patch","issue_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/22","number":22,"state":"closed","locked":false,"title":"Add changes made after the 3rd review","user":{"login":"andela-abisoye","id":15850770,"avatar_url":"https://avatars.githubusercontent.com/u/15850770?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-abisoye","html_url":"https://github.com/andela-abisoye","followers_url":"https://api.github.com/users/andela-abisoye/followers","following_url":"https://api.github.com/users/andela-abisoye/following{/other_user}","gists_url":"https://api.github.com/users/andela-abisoye/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-abisoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-abisoye/subscriptions","organizations_url":"https://api.github.com/users/andela-abisoye/orgs","repos_url":"https://api.github.com/users/andela-abisoye/repos","events_url":"https://api.github.com/users/andela-abisoye/events{/privacy}","received_events_url":"https://api.github.com/users/andela-abisoye/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n- It adds changes suggested by Kes. They were: \r\n      - Critical: Use let only when - you are not initializing the variable on the same line\r\nthe value is going to be modified down the line. otherwise, use const.\r\n      - Nitpick: This line is too long, definitely longer that 80 characters as specified by the airbnb spec.\r\n      - Critical: This test case should ONLY test that documents returned are not more than the specified limit. It's not clear what this line seeks to achieve. Simply modify this to check that all results returned match the EXACT date that was specified in the request\r\n      - The test case should employ the limit with documents that contain the defined role does not test that the results are returned in descending order. Also, seeing as the code has been upgraded to ES6 syntax, please employ the standard's method for importing/exporting modules and use Babel to transpile as is required.\r\n","created_at":"2016-11-21T16:21:09Z","updated_at":"2016-11-23T00:12:59Z","closed_at":"2016-11-21T21:23:51Z","merged_at":"2016-11-21T21:23:51Z","merge_commit_sha":"7316ac78682d9f0e71fd0feefdcb1c13143ee8f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22/commits","review_comments_url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22/comments","review_comment_url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/22/comments","statuses_url":"https://api.github.com/repos/andela-abisoye/doc-manager/statuses/2a8a8b436c85e9de383fb51fd457070ac444f63b","head":{"label":"andela-abisoye:develop","ref":"develop","sha":"2a8a8b436c85e9de383fb51fd457070ac444f63b","user":{"login":"andela-abisoye","id":15850770,"avatar_url":"https://avatars.githubusercontent.com/u/15850770?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-abisoye","html_url":"https://github.com/andela-abisoye","followers_url":"https://api.github.com/users/andela-abisoye/followers","following_url":"https://api.github.com/users/andela-abisoye/following{/other_user}","gists_url":"https://api.github.com/users/andela-abisoye/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-abisoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-abisoye/subscriptions","organizations_url":"https://api.github.com/users/andela-abisoye/orgs","repos_url":"https://api.github.com/users/andela-abisoye/repos","events_url":"https://api.github.com/users/andela-abisoye/events{/privacy}","received_events_url":"https://api.github.com/users/andela-abisoye/received_events","type":"User","site_admin":false},"repo":{"id":71772996,"name":"doc-manager","full_name":"andela-abisoye/doc-manager","owner":{"login":"andela-abisoye","id":15850770,"avatar_url":"https://avatars.githubusercontent.com/u/15850770?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-abisoye","html_url":"https://github.com/andela-abisoye","followers_url":"https://api.github.com/users/andela-abisoye/followers","following_url":"https://api.github.com/users/andela-abisoye/following{/other_user}","gists_url":"https://api.github.com/users/andela-abisoye/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-abisoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-abisoye/subscriptions","organizations_url":"https://api.github.com/users/andela-abisoye/orgs","repos_url":"https://api.github.com/users/andela-abisoye/repos","events_url":"https://api.github.com/users/andela-abisoye/events{/privacy}","received_events_url":"https://api.github.com/users/andela-abisoye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andela-abisoye/doc-manager","description":null,"fork":false,"url":"https://api.github.com/repos/andela-abisoye/doc-manager","forks_url":"https://api.github.com/repos/andela-abisoye/doc-manager/forks","keys_url":"https://api.github.com/repos/andela-abisoye/doc-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela-abisoye/doc-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela-abisoye/doc-manager/teams","hooks_url":"https://api.github.com/repos/andela-abisoye/doc-manager/hooks","issue_events_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/events{/number}","events_url":"https://api.github.com/repos/andela-abisoye/doc-manager/events","assignees_url":"https://api.github.com/repos/andela-abisoye/doc-manager/assignees{/user}","branches_url":"https://api.github.com/repos/andela-abisoye/doc-manager/branches{/branch}","tags_url":"https://api.github.com/repos/andela-abisoye/doc-manager/tags","blobs_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela-abisoye/doc-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/andela-abisoye/doc-manager/languages","stargazers_url":"https://api.github.com/repos/andela-abisoye/doc-manager/stargazers","contributors_url":"https://api.github.com/repos/andela-abisoye/doc-manager/contributors","subscribers_url":"https://api.github.com/repos/andela-abisoye/doc-manager/subscribers","subscription_url":"https://api.github.com/repos/andela-abisoye/doc-manager/subscription","commits_url":"https://api.github.com/repos/andela-abisoye/doc-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela-abisoye/doc-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela-abisoye/doc-manager/contents/{+path}","compare_url":"https://api.github.com/repos/andela-abisoye/doc-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela-abisoye/doc-manager/merges","archive_url":"https://api.github.com/repos/andela-abisoye/doc-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela-abisoye/doc-manager/downloads","issues_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues{/number}","pulls_url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/andela-abisoye/doc-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/andela-abisoye/doc-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela-abisoye/doc-manager/labels{/name}","releases_url":"https://api.github.com/repos/andela-abisoye/doc-manager/releases{/id}","deployments_url":"https://api.github.com/repos/andela-abisoye/doc-manager/deployments","created_at":"2016-10-24T09:26:38Z","updated_at":"2016-10-27T21:29:00Z","pushed_at":"2016-11-21T21:23:52Z","git_url":"git://github.com/andela-abisoye/doc-manager.git","ssh_url":"git@github.com:andela-abisoye/doc-manager.git","clone_url":"https://github.com/andela-abisoye/doc-manager.git","svn_url":"https://github.com/andela-abisoye/doc-manager","homepage":null,"size":73,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andela-abisoye:master","ref":"master","sha":"7e4d3e7a05e3d3f5f4d3192bc7ccbb9869e15476","user":{"login":"andela-abisoye","id":15850770,"avatar_url":"https://avatars.githubusercontent.com/u/15850770?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-abisoye","html_url":"https://github.com/andela-abisoye","followers_url":"https://api.github.com/users/andela-abisoye/followers","following_url":"https://api.github.com/users/andela-abisoye/following{/other_user}","gists_url":"https://api.github.com/users/andela-abisoye/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-abisoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-abisoye/subscriptions","organizations_url":"https://api.github.com/users/andela-abisoye/orgs","repos_url":"https://api.github.com/users/andela-abisoye/repos","events_url":"https://api.github.com/users/andela-abisoye/events{/privacy}","received_events_url":"https://api.github.com/users/andela-abisoye/received_events","type":"User","site_admin":false},"repo":{"id":71772996,"name":"doc-manager","full_name":"andela-abisoye/doc-manager","owner":{"login":"andela-abisoye","id":15850770,"avatar_url":"https://avatars.githubusercontent.com/u/15850770?v=3","gravatar_id":"","url":"https://api.github.com/users/andela-abisoye","html_url":"https://github.com/andela-abisoye","followers_url":"https://api.github.com/users/andela-abisoye/followers","following_url":"https://api.github.com/users/andela-abisoye/following{/other_user}","gists_url":"https://api.github.com/users/andela-abisoye/gists{/gist_id}","starred_url":"https://api.github.com/users/andela-abisoye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela-abisoye/subscriptions","organizations_url":"https://api.github.com/users/andela-abisoye/orgs","repos_url":"https://api.github.com/users/andela-abisoye/repos","events_url":"https://api.github.com/users/andela-abisoye/events{/privacy}","received_events_url":"https://api.github.com/users/andela-abisoye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andela-abisoye/doc-manager","description":null,"fork":false,"url":"https://api.github.com/repos/andela-abisoye/doc-manager","forks_url":"https://api.github.com/repos/andela-abisoye/doc-manager/forks","keys_url":"https://api.github.com/repos/andela-abisoye/doc-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela-abisoye/doc-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela-abisoye/doc-manager/teams","hooks_url":"https://api.github.com/repos/andela-abisoye/doc-manager/hooks","issue_events_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/events{/number}","events_url":"https://api.github.com/repos/andela-abisoye/doc-manager/events","assignees_url":"https://api.github.com/repos/andela-abisoye/doc-manager/assignees{/user}","branches_url":"https://api.github.com/repos/andela-abisoye/doc-manager/branches{/branch}","tags_url":"https://api.github.com/repos/andela-abisoye/doc-manager/tags","blobs_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela-abisoye/doc-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/andela-abisoye/doc-manager/languages","stargazers_url":"https://api.github.com/repos/andela-abisoye/doc-manager/stargazers","contributors_url":"https://api.github.com/repos/andela-abisoye/doc-manager/contributors","subscribers_url":"https://api.github.com/repos/andela-abisoye/doc-manager/subscribers","subscription_url":"https://api.github.com/repos/andela-abisoye/doc-manager/subscription","commits_url":"https://api.github.com/repos/andela-abisoye/doc-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela-abisoye/doc-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela-abisoye/doc-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela-abisoye/doc-manager/contents/{+path}","compare_url":"https://api.github.com/repos/andela-abisoye/doc-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela-abisoye/doc-manager/merges","archive_url":"https://api.github.com/repos/andela-abisoye/doc-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela-abisoye/doc-manager/downloads","issues_url":"https://api.github.com/repos/andela-abisoye/doc-manager/issues{/number}","pulls_url":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/andela-abisoye/doc-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/andela-abisoye/doc-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela-abisoye/doc-manager/labels{/name}","releases_url":"https://api.github.com/repos/andela-abisoye/doc-manager/releases{/id}","deployments_url":"https://api.github.com/repos/andela-abisoye/doc-manager/deployments","created_at":"2016-10-24T09:26:38Z","updated_at":"2016-10-27T21:29:00Z","pushed_at":"2016-11-21T21:23:52Z","git_url":"git://github.com/andela-abisoye/doc-manager.git","ssh_url":"git@github.com:andela-abisoye/doc-manager.git","clone_url":"https://github.com/andela-abisoye/doc-manager.git","svn_url":"https://github.com/andela-abisoye/doc-manager","homepage":null,"size":73,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22"},"html":{"href":"https://github.com/andela-abisoye/doc-manager/pull/22"},"issue":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/22"},"comments":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/andela-abisoye/doc-manager/statuses/2a8a8b436c85e9de383fb51fd457070ac444f63b"}}}}
{"actor":{"display_login":"andela-kakpobome"}}