{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9110","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9110/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9110/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9110/events","html_url":"https://github.com/Automattic/wp-calypso/pull/9110","id":187015569,"number":9110,"title":"Remove decended getSelectedSite usage from my-sites/sidebar component","user":{"login":"spentay","id":4335450,"avatar_url":"https://avatars.githubusercontent.com/u/4335450?v=3","gravatar_id":"","url":"https://api.github.com/users/spentay","html_url":"https://github.com/spentay","followers_url":"https://api.github.com/users/spentay/followers","following_url":"https://api.github.com/users/spentay/following{/other_user}","gists_url":"https://api.github.com/users/spentay/gists{/gist_id}","starred_url":"https://api.github.com/users/spentay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spentay/subscriptions","organizations_url":"https://api.github.com/users/spentay/orgs","repos_url":"https://api.github.com/users/spentay/repos","events_url":"https://api.github.com/users/spentay/events{/privacy}","received_events_url":"https://api.github.com/users/spentay/received_events","type":"User","site_admin":false},"labels":[{"id":285009988,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"006b75","default":false},{"id":301697869,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/OSS%20Citizen","name":"OSS Citizen","color":"5319e7","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-03T09:54:53Z","updated_at":"2016-11-03T21:29:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/9110","html_url":"https://github.com/Automattic/wp-calypso/pull/9110","diff_url":"https://github.com/Automattic/wp-calypso/pull/9110.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/9110.patch"},"body":"### Aims\r\nThis PR aims to remove sitesList.getSelectedSite  part of #9054 and ultimately #8726.\r\n\r\nThis seems to be the minimal amount of change to remove reference to getSelectedSite.\r\n\r\n### Test Plan\r\nI'm not entirely sure how to test this as rigorously as I'd like to but I have checked that the sidebar renders each section the same both before and after the changes.\r\nI'm thinking of a solid way to test type of behaviour, perhaps by mocking a sites attributes... possibly through redux dev tools.\r\nJust thinking out loud for now & open to suggestions but when I have something reliable I'll update this PR :D\r\n\r\n### Notes\r\n\r\n- I have another branch that utilizes the `canCurrentUser` selector which handles a lot of the `site.capabilities` related logic in a much cleaner way. I think this was a change intended by @ehg  - PR will be up shortly.\r\n- `site.isCustomizable` is not available on the site when selected in this way so for now I've replicated it's logic.\r\n- This PR doesn't aim to tackle any issues with code style, that's mostly addressed in [another PR](https://github.com/Automattic/wp-calypso/pull/9032) (#9032)"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/258279735","html_url":"https://github.com/Automattic/wp-calypso/pull/9110#issuecomment-258279735","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/9110","id":258279735,"user":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T21:29:22Z","updated_at":"2016-11-03T21:29:22Z","body":"> @gwwar, should this be a concern as part of #8726 or should this be tackled separately?\r\n\r\nIt is part of 8726, but this suggests that we have a few other PRs that we need before this particular usage can be cleaned up. Sorry @spentay! Did you want to choose another section?\r\n\r\n`client/my-sites/upgrade-nudge` for example would be much simpler to port"}}
{"actor":{"display_login":"gwwar"}}