{"action":"created","issue":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/939","repository_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/939/labels{/name}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/939/comments","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/939/events","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/issues/939","id":172539934,"number":939,"title":"-ss not \"finding\" all the spawnpoints -- is it spawnpoint compression?","user":{"login":"averylarry","id":21130007,"avatar_url":"https://avatars.githubusercontent.com/u/21130007?v=3","gravatar_id":"","url":"https://api.github.com/users/averylarry","html_url":"https://github.com/averylarry","followers_url":"https://api.github.com/users/averylarry/followers","following_url":"https://api.github.com/users/averylarry/following{/other_user}","gists_url":"https://api.github.com/users/averylarry/gists{/gist_id}","starred_url":"https://api.github.com/users/averylarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/averylarry/subscriptions","organizations_url":"https://api.github.com/users/averylarry/orgs","repos_url":"https://api.github.com/users/averylarry/repos","events_url":"https://api.github.com/users/averylarry/events{/privacy}","received_events_url":"https://api.github.com/users/averylarry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-22T19:57:34Z","updated_at":"2016-08-25T01:00:48Z","closed_at":null,"body":"<!--\r\n  \r\n  FOR FEATURE REQUESTS GO TO:\r\n  \r\n  http://feathub.com/PokemonGoMap/PokemonGo-Map/\r\n  \r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n  ISSUES ARE NOT FOR SUPPORT!!!\r\n\r\n  Join discord (channel: #help) for support at this link: https://discord.gg/PWp2bAm\r\n\r\n-->\r\n\r\n<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n## Expected Behavior\r\n<!--- If you're describing a bug, tell us what should happen -->\r\n<!--- If you're suggesting a change/improvement, tell us how it should work -->\r\nBeehive scan shows n spawnpoints.  Using -ss should equally find n spawnpoints.\r\n## Current Behavior\r\n<!--- If describing a bug, tell us what happens instead of the expected behavior -->\r\n<!--- If suggesting a change/improvement, explain the difference from current behavior -->\r\nUsing -ss \"finds\" fewer spawnpoints than exist in beehive.\r\n## Possible Solution\r\n<!--- Not obligatory, but suggest a fix/reason for the bug, -->\r\n<!--- or ideas how to implement the addition or change -->\r\n\r\n## Steps to Reproduce (for bugs)\r\n<!--- Provide a link to a live example, or an unambiguous set of steps to -->\r\n<!--- reproduce this bug. Include code to reproduce, if relevant -->\r\nIs spawnpoint scanning compression on by default for -ss scanning?  #765 doesn't seem to have made it into dev branch.\r\nIn a small area, after clearing the database, I ran a -st 2 beehive for 2 hours:\r\nrunserver.py -l \"my location\" -st 2 -j -nk -ng\r\n\r\n\r\n![capture](https://cloud.githubusercontent.com/assets/21130007/17869241/ff7f9fe6-6877-11e6-8f8b-a87c58f4e122.JPG)\r\n\r\nThere are 26 spawnpoints inside the beehive.  If you are conservative with edges, there are still at least 23 spawn points inside the beehive.  (Note the spawnpoints outside the scanned locations are from running -ss for a short period of time.)\r\n\r\nWhen I then start a -ss session (without dumping a .json file), I get 17 spawn points to track:\r\nrunserver.py -l \"my location\" -st 2 -j -nk -ng\r\n. . .\r\n2016-08-22 14:07:18,375 [ search-overseer][        models][    INFO] Finding spawn points 2 steps away\r\n2016-08-22 14:07:18,405 [      db-cleaner][        models][    INFO] Regular database cleaning complete\r\n2016-08-22 14:07:18,469 [ search-overseer][        search][    INFO] Total of 17 spawns to track\r\n\r\nIf I increase to -st 3 (I read somewhere to +1 the steps for edge cases), I still only get 21 spawnpoints:\r\nrunserver.py -l \"my location\" -st 3 -j -nk -ng -ss\r\n. . .\r\n2016-08-22 14:11:52,065 [ search-overseer][        models][    INFO] Finding spawn points 3 steps away\r\n2016-08-22 14:11:52,158 [ search-overseer][        search][    INFO] Total of 21 spawns to track\r\n\r\nIf I dump to a .json file it shows 17 or 21 depending on the step size, matching the above.\r\n\r\nIf not compression, could it be related to jitter?  I don't really know how since increasing to 3 steps should eliminate that as a possibility.  Plus it is consistent.  I always get 17 or 21.  I even tried -st 54 and it still only returned 21.\r\n## Context\r\n<!--- How has this issue affected you? What are you trying to accomplish? -->\r\n<!--- Providing context helps us come up with a solution that is most useful in the real world -->\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment you experienced the bug in -->\r\n* Version used: 0448f93\r\n* Operating System and version (desktop or mobile): win7\r\n"},"comment":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments/242253221","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/issues/939#issuecomment-242253221","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/939","id":242253221,"user":{"login":"averylarry","id":21130007,"avatar_url":"https://avatars.githubusercontent.com/u/21130007?v=3","gravatar_id":"","url":"https://api.github.com/users/averylarry","html_url":"https://github.com/averylarry","followers_url":"https://api.github.com/users/averylarry/followers","following_url":"https://api.github.com/users/averylarry/following{/other_user}","gists_url":"https://api.github.com/users/averylarry/gists{/gist_id}","starred_url":"https://api.github.com/users/averylarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/averylarry/subscriptions","organizations_url":"https://api.github.com/users/averylarry/orgs","repos_url":"https://api.github.com/users/averylarry/repos","events_url":"https://api.github.com/users/averylarry/events{/privacy}","received_events_url":"https://api.github.com/users/averylarry/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T01:00:48Z","updated_at":"2016-08-25T01:00:48Z","body":"Yes, that code will produce duplicates.  The original code messes up because it skips checking the next spawnpoint  everytime a spawnpoint is found because the next spawnpoint gets shifted into the list location (index) just vacated by the spawnpoint found and removed by pop.\r\n\r\nTry this instead:\r\n\r\nfor hl in hex_locations:\r\n            for sp in reversed(s):\r\n                if geopy.distance.distance(hl, (sp['lat'], sp['lng'])).meters <= 70:\r\n                    filtered.append(sp)\r\n                    s.remove(sp)\r\n\r\n"}}
{"actor":{"display_login":"averylarry"}}