{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/78732371","id":78732371,"diff_hunk":"@@ -0,0 +1,209 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.execution.command\n+\n+import scala.collection.mutable\n+\n+import org.apache.spark.sql._\n+import org.apache.spark.sql.catalyst.InternalRow\n+import org.apache.spark.sql.catalyst.analysis.EliminateSubqueryAliases\n+import org.apache.spark.sql.catalyst.catalog.{CatalogRelation, CatalogTable}\n+import org.apache.spark.sql.catalyst.plans.logical.{BasicColStats, Statistics}\n+import org.apache.spark.sql.execution.datasources.LogicalRelation\n+import org.apache.spark.sql.functions._\n+import org.apache.spark.sql.types._\n+\n+\n+/**\n+ * Analyzes the given columns of the given table in the current database to generate statistics,\n+ * which will be used in query optimizations.\n+ */\n+case class AnalyzeColumnCommand(\n+    tableName: String,\n+    columnNames: Seq[String]) extends RunnableCommand {\n+\n+  override def run(sparkSession: SparkSession): Seq[Row] = {\n+    val sessionState = sparkSession.sessionState\n+    val tableIdent = sessionState.sqlParser.parseTableIdentifier(tableName)\n+    val relation = EliminateSubqueryAliases(sessionState.catalog.lookupRelation(tableIdent))\n+\n+    // check correctness for column names\n+    val attributeNames = relation.output.map(_.name.toLowerCase)\n+    val invalidColumns = columnNames.filterNot { col => attributeNames.contains(col.toLowerCase)}\n+    if (invalidColumns.nonEmpty) {\n+      throw new AnalysisException(s\"Invalid columns for table $tableName: $invalidColumns.\")\n+    }\n+\n+    relation match {\n+      case catalogRel: CatalogRelation =>\n+        updateStats(catalogRel.catalogTable,\n+          AnalyzeTableCommand.calculateTotalSize(sparkSession, catalogRel.catalogTable))\n+\n+      case logicalRel: LogicalRelation if logicalRel.catalogTable.isDefined =>\n+        updateStats(logicalRel.catalogTable.get, logicalRel.relation.sizeInBytes)\n+\n+      case otherRelation =>\n+        throw new AnalysisException(s\"ANALYZE TABLE is not supported for \" +\n+          s\"${otherRelation.nodeName}.\")\n+    }\n+\n+    def updateStats(catalogTable: CatalogTable, newTotalSize: Long): Unit = {\n+      val lowerCaseNames = columnNames.map(_.toLowerCase)\n+      val attributes =\n+        relation.output.filter(attr => lowerCaseNames.contains(attr.name.toLowerCase))\n+\n+      // collect column statistics\n+      val aggColumns = mutable.ArrayBuffer[Column](count(Column(\"*\")))\n+      attributes.foreach(entry => aggColumns ++= statsAgg(entry.name, entry.dataType))","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala","position":72,"original_position":72,"commit_id":"027bdcc59b1b01a8dac436dd3a86600c2451c95f","original_commit_id":"027bdcc59b1b01a8dac436dd3a86600c2451c95f","user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars.githubusercontent.com/u/9616802?v=3","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"body":"use flatmap?","created_at":"2016-09-14T11:42:17Z","updated_at":"2016-09-14T11:42:17Z","html_url":"https://github.com/apache/spark/pull/15090#discussion_r78732371","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15090","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/78732371"},"html":{"href":"https://github.com/apache/spark/pull/15090#discussion_r78732371"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15090"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15090","id":85163180,"html_url":"https://github.com/apache/spark/pull/15090","diff_url":"https://github.com/apache/spark/pull/15090.diff","patch_url":"https://github.com/apache/spark/pull/15090.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15090","number":15090,"state":"open","locked":false,"title":"[SPARK-17073] [SQL] generate column-level statistics","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nGenerate basic column statistics for all the atomic types:\r\n- numeric types: max, min, num of nulls, ndv (number of distinct values)\r\n- date/timestamp types: they are also represented as numbers internally, so they have the same stats as above.\r\n- string: avg length, max length, num of nulls, ndv\r\n- binary: avg length, max length, num of nulls\r\n- boolean: num of nulls, num of trues, num of falsies, ndv (must be 2)\r\n\r\nAlso support storing and loading these statistics.\r\n\r\n## How was this patch tested?\r\n\r\nadd unit tests","created_at":"2016-09-14T03:56:14Z","updated_at":"2016-09-14T11:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90f07530a57b57c060d06d998bdec73e74e2f3ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15090/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15090/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15090/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/027bdcc59b1b01a8dac436dd3a86600c2451c95f","head":{"label":"wzhfy:colStats","ref":"colStats","sha":"027bdcc59b1b01a8dac436dd3a86600c2451c95f","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"repo":{"id":66051854,"name":"spark","full_name":"wzhfy/spark","owner":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wzhfy/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wzhfy/spark","forks_url":"https://api.github.com/repos/wzhfy/spark/forks","keys_url":"https://api.github.com/repos/wzhfy/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wzhfy/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wzhfy/spark/teams","hooks_url":"https://api.github.com/repos/wzhfy/spark/hooks","issue_events_url":"https://api.github.com/repos/wzhfy/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wzhfy/spark/events","assignees_url":"https://api.github.com/repos/wzhfy/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wzhfy/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wzhfy/spark/tags","blobs_url":"https://api.github.com/repos/wzhfy/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wzhfy/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wzhfy/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wzhfy/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wzhfy/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wzhfy/spark/languages","stargazers_url":"https://api.github.com/repos/wzhfy/spark/stargazers","contributors_url":"https://api.github.com/repos/wzhfy/spark/contributors","subscribers_url":"https://api.github.com/repos/wzhfy/spark/subscribers","subscription_url":"https://api.github.com/repos/wzhfy/spark/subscription","commits_url":"https://api.github.com/repos/wzhfy/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wzhfy/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wzhfy/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wzhfy/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wzhfy/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wzhfy/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wzhfy/spark/merges","archive_url":"https://api.github.com/repos/wzhfy/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wzhfy/spark/downloads","issues_url":"https://api.github.com/repos/wzhfy/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wzhfy/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wzhfy/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wzhfy/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wzhfy/spark/labels{/name}","releases_url":"https://api.github.com/repos/wzhfy/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wzhfy/spark/deployments","created_at":"2016-08-19T04:11:04Z","updated_at":"2016-08-19T04:11:28Z","pushed_at":"2016-09-14T04:02:23Z","git_url":"git://github.com/wzhfy/spark.git","ssh_url":"git@github.com:wzhfy/spark.git","clone_url":"https://github.com/wzhfy/spark.git","svn_url":"https://github.com/wzhfy/spark","homepage":null,"size":186765,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"37b93f54e89332b6b77bb02c1c2299614338fd7c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-09-14T11:03:42Z","pushed_at":"2016-09-14T11:26:34Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":526028,"stargazers_count":9996,"watchers_count":9996,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9322,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":483,"forks":9322,"open_issues":483,"watchers":9996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15090"},"html":{"href":"https://github.com/apache/spark/pull/15090"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15090"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15090/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15090/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15090/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/027bdcc59b1b01a8dac436dd3a86600c2451c95f"}}}}
{"actor":{"display_login":"hvanhovell"}}