{"action":"created","issue":{"url":"https://api.github.com/repos/disqus/disqus-install-examples/issues/3","repository_url":"https://api.github.com/repos/disqus/disqus-install-examples","labels_url":"https://api.github.com/repos/disqus/disqus-install-examples/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/disqus/disqus-install-examples/issues/3/comments","events_url":"https://api.github.com/repos/disqus/disqus-install-examples/issues/3/events","html_url":"https://github.com/disqus/disqus-install-examples/issues/3","id":177942264,"number":3,"title":"Simpler AMP install - maybe :)","user":{"login":"maxxeight","id":10353183,"avatar_url":"https://avatars.githubusercontent.com/u/10353183?v=3","gravatar_id":"","url":"https://api.github.com/users/maxxeight","html_url":"https://github.com/maxxeight","followers_url":"https://api.github.com/users/maxxeight/followers","following_url":"https://api.github.com/users/maxxeight/following{/other_user}","gists_url":"https://api.github.com/users/maxxeight/gists{/gist_id}","starred_url":"https://api.github.com/users/maxxeight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxxeight/subscriptions","organizations_url":"https://api.github.com/users/maxxeight/orgs","repos_url":"https://api.github.com/users/maxxeight/repos","events_url":"https://api.github.com/users/maxxeight/events{/privacy}","received_events_url":"https://api.github.com/users/maxxeight/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-09-20T01:45:10Z","updated_at":"2016-10-27T09:25:33Z","closed_at":null,"body":"Hi there, \r\n\r\nThanks for your work on making Disqus AMP-friendly. I implemented it on technicalseo.com and here are the issues/suggestions that I have:\r\n\r\n1-- I couldn't make it work without adding an overflow child element. It seems to be required as a fall back if AMP can't automatically load the iframe: https://github.com/ampproject/amphtml/blob/master/extensions/amp-iframe/amp-iframe.md#iframe-resizing\r\nI also added frameborder=0 for design purposes.\r\nMy working code looks as follow:\r\n```\r\n<amp-iframe width=600 height=140\r\n\t\t\tlayout=\"responsive\"\r\n\t\t\tsandbox=\"allow-scripts allow-same-origin allow-modals allow-popups\"\r\n\t\t\tresizable\r\n\t\t\tframeborder=\"0\"\r\n\t\t\tsrc=\"external_html_file\">\r\n<div overflow tabindex=0 role=button aria-label=\"Disqus Comments\">Disqus Comments</div>\r\n</amp-iframe>\r\n```\r\n\r\n2-- As specified in your instructions, the \"external_html_file\" MUST be hosted on a different domain, but it also MUST  be hosted on a secure (HTTPS) domain. This might be challenging for most (having access to another secure domain, buying another SLL certificate, etc.). \r\nI am hosting the file on Github secure CDN: https://cdn.rawgit.com/maxxeight/disqusAMP/master/disqus-amp.html\r\n\r\n3-- I tweaked the scripts within this file (also attached as a .txt) so all variables (shortname and canonical URL - where the comments live) can be passed through parameters in the iframe src URL \r\n`src=\"https://cdn.rawgit.com/maxxeight/disqusAMP/master/disqus-amp.html?shortname=[disqus_shortname]&url=[canonical_url]\"`\r\n\r\n=> this way, the external html file can be the same ALL Disqus users. This leads to my last suggestion: could you guys host the file for all users? :) So nobody is dependant of my Github account? \r\n\r\nNote: I did not have to \"Add the new domain [cdn.rawgit.com] as a Trusted Domain\" in my Disqus settings for this implementation to work.\r\n\r\nHere is a working AMP URL with all of the above in place: https://technicalseo.com/rank-serp/duplicate-content/amp.html\r\n\r\n\r\nThanks again and please let me know if you have any questions!\r\n\r\nMax\r\n\r\n[disqus-amp.txt](https://github.com/disqus/disqus-install-examples/files/481470/disqus-amp.txt)"},"comment":{"url":"https://api.github.com/repos/disqus/disqus-install-examples/issues/comments/256591929","html_url":"https://github.com/disqus/disqus-install-examples/issues/3#issuecomment-256591929","issue_url":"https://api.github.com/repos/disqus/disqus-install-examples/issues/3","id":256591929,"user":{"login":"John-Betong","id":163515,"avatar_url":"https://avatars.githubusercontent.com/u/163515?v=3","gravatar_id":"","url":"https://api.github.com/users/John-Betong","html_url":"https://github.com/John-Betong","followers_url":"https://api.github.com/users/John-Betong/followers","following_url":"https://api.github.com/users/John-Betong/following{/other_user}","gists_url":"https://api.github.com/users/John-Betong/gists{/gist_id}","starred_url":"https://api.github.com/users/John-Betong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/John-Betong/subscriptions","organizations_url":"https://api.github.com/users/John-Betong/orgs","repos_url":"https://api.github.com/users/John-Betong/repos","events_url":"https://api.github.com/users/John-Betong/events{/privacy}","received_events_url":"https://api.github.com/users/John-Betong/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T09:25:33Z","updated_at":"2016-10-27T09:25:33Z","body":"@maxxeight\r\n\r\nWonderful, you did a grand job:\r\n\r\n[**My Test Page**](http://www.johns-jokes.com/assets/tests/amphml-test-page.php)\r\n\r\nThe above link validates OK according to Google Chrome's AmpHtml Extension...\r\n\r\n...also stored in Google's Cache but only three dots showing? So it looks as though the web-page is Google cached and then Disqus is loaded afterwards. Fantastic :)\r\n\r\n[**Google's CDN Cache Check**](https://cdn.ampproject.org/c/www.johns-jokes.com/assets/tests/amphml-test-page.php)\r\nI will wait until I resurrect my HTTPS domain before I implement Disqus on every page.\r\n\r\nThank you!\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"John-Betong"}}