{"action":"created","issue":{"url":"https://api.github.com/repos/citra-emu/citra/issues/1688","repository_url":"https://api.github.com/repos/citra-emu/citra","labels_url":"https://api.github.com/repos/citra-emu/citra/issues/1688/labels{/name}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/1688/comments","events_url":"https://api.github.com/repos/citra-emu/citra/issues/1688/events","html_url":"https://github.com/citra-emu/citra/pull/1688","id":148965755,"number":1688,"title":"Pica: Reduce batching errors","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-17T16:03:16Z","updated_at":"2016-05-02T15:45:24Z","closed_at":"2016-05-02T15:45:24Z","pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/1688","html_url":"https://github.com/citra-emu/citra/pull/1688","diff_url":"https://github.com/citra-emu/citra/pull/1688.diff","patch_url":"https://github.com/citra-emu/citra/pull/1688.patch"},"body":"This ~~gets rid of some damage~~ hides some bugs which were seen after https://github.com/citra-emu/citra/commit/81004211dda74390c02973c37e89215f5ff8829b (bisected and reported by pcmaker - Thanks!)\r\n\r\n~~`master` currently merges way too many triangles into one draw call. In MK7 it usually combines particle effects (smoke, coin glitter, speed effects) and HUD rendering. As one batch can only share the same draw state your kart sometimes spits out menu letters from it's exhause pipe and the smoke will look like the HUD item box.\r\nThis PR fixes that by reverting some changes from the commit mentioned above.~~\r\nCorrection: This might not even be the problem, I'll have to look at the code again\r\n\r\nKeep in mind that this is not a perfect solution. All this does is splitting draw calls into seperate batches (like you'd expect). Immediate mode might still cause bad batching - I didn't check!\r\nThese are 2 seperate issues though, so I'll create an issue (soon) about possible remaining problems to remind us.\r\n\r\n(Also, even if we can batch draw calls for GL we shouldn't do so in debug mode and report each draw call to the debugger)\r\n\r\n---\r\n\r\nFixes bugs in MK7 and NSMB2 (#1681). I didn't test much further than that."},"comment":{"url":"https://api.github.com/repos/citra-emu/citra/issues/comments/216272791","html_url":"https://github.com/citra-emu/citra/pull/1688#issuecomment-216272791","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/1688","id":216272791,"user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T15:45:24Z","updated_at":"2016-05-02T15:45:24Z","body":"I'll close this and probably open a new PR or re-open if I have a better idea (Probably depending on flush when clearing the vertex cache using GPUREG_VTX_FUNC)"}}