{"action":"created","comment":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/comments/69666355","id":69666355,"diff_hunk":"@@ -1,53 +1,476 @@\n-﻿using System;\n-using System.Collections.Generic;\n-using System.Linq;\n-using System.Text;\n-using System.Threading.Tasks;\n-using Octokit;\n-using Octokit.Tests.Integration;\n+﻿using System.Threading.Tasks;\n+using Octokit.Tests.Integration.Helpers;\n using Xunit;\n \n-public class IssueCommentsClientTests\n+namespace Octokit.Tests.Integration.Clients","path":"Octokit.Tests.Integration/Clients/IssueCommentsClientTests.cs","position":13,"original_position":13,"commit_id":"60e9733c91f8923ada9c04d8a7acd3b66ad515c8","original_commit_id":"60e9733c91f8923ada9c04d8a7acd3b66ad515c8","user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"body":"Can we revert this namespace addition to simplify the diff?","created_at":"2016-07-06T02:00:02Z","updated_at":"2016-07-06T02:00:02Z","html_url":"https://github.com/octokit/octokit.net/pull/1379#discussion_r69666355","pull_request_url":"https://api.github.com/repos/octokit/octokit.net/pulls/1379","_links":{"self":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/comments/69666355"},"html":{"href":"https://github.com/octokit/octokit.net/pull/1379#discussion_r69666355"},"pull_request":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1379"}}},"pull_request":{"url":"https://api.github.com/repos/octokit/octokit.net/pulls/1379","id":73714069,"html_url":"https://github.com/octokit/octokit.net/pull/1379","diff_url":"https://github.com/octokit/octokit.net/pull/1379.diff","patch_url":"https://github.com/octokit/octokit.net/pull/1379.patch","issue_url":"https://api.github.com/repos/octokit/octokit.net/issues/1379","number":1379,"state":"open","locked":false,"title":"Add repositoryId overloads to methods on I(Observable)IssueCommentsClient","user":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"body":"As part of my work on #1120 I've added new overloads on I(Observable)IssueCommentsClient to get access by repository id.\r\n\r\n- [x] **Update XML documentation of interface methods of clients (also synchronize XML docs of IIssueCommentsClient and IObservableIssueCommentsClient).**\r\n\r\n\t  There is some divergence between XML documentation of methods in IIssueCommentsClient and IObservableIssueCommentsClient. So I've decided \r\n\t  to sync XML documentation of these classes during my work on #1120.\r\n\r\n- [x] **Add overloads to IIssueCommentsClient.**\r\n\r\n\t  Just add overloads of existing methods that use repositoryId to work with repo.\r\n- [x] **Add overloads to IObservableIssueCommentsClient.**\r\n\r\n\t  Just add overloads of existing methods that use repositoryId to work with repo.\r\n- [x] **Add unit tests.**\r\n\r\n\t  I've added new unit tests that use repositoryId to work with repo that is just a full copy of existing tests that use (owner, name) key.\r\n\t  Also I've found out that not all methods are covered by tests and added them for new and for old methods.\r\n- [x] **Add integration tests.**\r\n\r\n\t  I've added new integration tests that use repositoryId to work with repo that is just a full copy of existing tests that use (owner, name) key.\r\nI've deleted class ObservableIssueCommentsClientTests beacuse it is useless. All test cases are covered in non-reactive IssueCommentsClientTests class.\r\n\r\n/cc @shiftkey, @ryangribble","created_at":"2016-06-14T10:18:00Z","updated_at":"2016-07-06T02:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34a50e475416a9084970962f283adce4e55118b3","assignee":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"assignees":[{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true}],"milestone":{"url":"https://api.github.com/repos/octokit/octokit.net/milestones/7","html_url":"https://github.com/octokit/octokit.net/milestones/RepositoryId%20Support","labels_url":"https://api.github.com/repos/octokit/octokit.net/milestones/7/labels","id":1815480,"number":7,"title":"RepositoryId Support","description":null,"creator":{"login":"ryangribble","id":5425163,"avatar_url":"https://avatars.githubusercontent.com/u/5425163?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble","html_url":"https://github.com/ryangribble","followers_url":"https://api.github.com/users/ryangribble/followers","following_url":"https://api.github.com/users/ryangribble/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble/subscriptions","organizations_url":"https://api.github.com/users/ryangribble/orgs","repos_url":"https://api.github.com/users/ryangribble/repos","events_url":"https://api.github.com/users/ryangribble/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":27,"state":"open","created_at":"2016-06-08T11:57:30Z","updated_at":"2016-07-06T01:39:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/octokit/octokit.net/pulls/1379/commits","review_comments_url":"https://api.github.com/repos/octokit/octokit.net/pulls/1379/comments","review_comment_url":"https://api.github.com/repos/octokit/octokit.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octokit/octokit.net/issues/1379/comments","statuses_url":"https://api.github.com/repos/octokit/octokit.net/statuses/60e9733c91f8923ada9c04d8a7acd3b66ad515c8","head":{"label":"dampir:add-repo-id-issue-comments-client","ref":"add-repo-id-issue-comments-client","sha":"60e9733c91f8923ada9c04d8a7acd3b66ad515c8","user":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"repo":{"id":53028639,"name":"octokit.net","full_name":"dampir/octokit.net","owner":{"login":"dampir","id":3888372,"avatar_url":"https://avatars.githubusercontent.com/u/3888372?v=3","gravatar_id":"","url":"https://api.github.com/users/dampir","html_url":"https://github.com/dampir","followers_url":"https://api.github.com/users/dampir/followers","following_url":"https://api.github.com/users/dampir/following{/other_user}","gists_url":"https://api.github.com/users/dampir/gists{/gist_id}","starred_url":"https://api.github.com/users/dampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dampir/subscriptions","organizations_url":"https://api.github.com/users/dampir/orgs","repos_url":"https://api.github.com/users/dampir/repos","events_url":"https://api.github.com/users/dampir/events{/privacy}","received_events_url":"https://api.github.com/users/dampir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dampir/octokit.net","description":"My contribution in GitHub API client library for .NET ","fork":true,"url":"https://api.github.com/repos/dampir/octokit.net","forks_url":"https://api.github.com/repos/dampir/octokit.net/forks","keys_url":"https://api.github.com/repos/dampir/octokit.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dampir/octokit.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dampir/octokit.net/teams","hooks_url":"https://api.github.com/repos/dampir/octokit.net/hooks","issue_events_url":"https://api.github.com/repos/dampir/octokit.net/issues/events{/number}","events_url":"https://api.github.com/repos/dampir/octokit.net/events","assignees_url":"https://api.github.com/repos/dampir/octokit.net/assignees{/user}","branches_url":"https://api.github.com/repos/dampir/octokit.net/branches{/branch}","tags_url":"https://api.github.com/repos/dampir/octokit.net/tags","blobs_url":"https://api.github.com/repos/dampir/octokit.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dampir/octokit.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dampir/octokit.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/dampir/octokit.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dampir/octokit.net/statuses/{sha}","languages_url":"https://api.github.com/repos/dampir/octokit.net/languages","stargazers_url":"https://api.github.com/repos/dampir/octokit.net/stargazers","contributors_url":"https://api.github.com/repos/dampir/octokit.net/contributors","subscribers_url":"https://api.github.com/repos/dampir/octokit.net/subscribers","subscription_url":"https://api.github.com/repos/dampir/octokit.net/subscription","commits_url":"https://api.github.com/repos/dampir/octokit.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/dampir/octokit.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/dampir/octokit.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/dampir/octokit.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/dampir/octokit.net/contents/{+path}","compare_url":"https://api.github.com/repos/dampir/octokit.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dampir/octokit.net/merges","archive_url":"https://api.github.com/repos/dampir/octokit.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dampir/octokit.net/downloads","issues_url":"https://api.github.com/repos/dampir/octokit.net/issues{/number}","pulls_url":"https://api.github.com/repos/dampir/octokit.net/pulls{/number}","milestones_url":"https://api.github.com/repos/dampir/octokit.net/milestones{/number}","notifications_url":"https://api.github.com/repos/dampir/octokit.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dampir/octokit.net/labels{/name}","releases_url":"https://api.github.com/repos/dampir/octokit.net/releases{/id}","deployments_url":"https://api.github.com/repos/dampir/octokit.net/deployments","created_at":"2016-03-03T07:01:00Z","updated_at":"2016-03-25T06:07:07Z","pushed_at":"2016-07-05T20:06:58Z","git_url":"git://github.com/dampir/octokit.net.git","ssh_url":"git@github.com:dampir/octokit.net.git","clone_url":"https://github.com/dampir/octokit.net.git","svn_url":"https://github.com/dampir/octokit.net","homepage":"","size":84724,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"octokit:master","ref":"master","sha":"27d0077aae9bcc55d88a7bf5a2ec83bc7afb7dcd","user":{"login":"octokit","id":3430433,"avatar_url":"https://avatars.githubusercontent.com/u/3430433?v=3","gravatar_id":"","url":"https://api.github.com/users/octokit","html_url":"https://github.com/octokit","followers_url":"https://api.github.com/users/octokit/followers","following_url":"https://api.github.com/users/octokit/following{/other_user}","gists_url":"https://api.github.com/users/octokit/gists{/gist_id}","starred_url":"https://api.github.com/users/octokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octokit/subscriptions","organizations_url":"https://api.github.com/users/octokit/orgs","repos_url":"https://api.github.com/users/octokit/repos","events_url":"https://api.github.com/users/octokit/events{/privacy}","received_events_url":"https://api.github.com/users/octokit/received_events","type":"Organization","site_admin":false},"repo":{"id":7528679,"name":"octokit.net","full_name":"octokit/octokit.net","owner":{"login":"octokit","id":3430433,"avatar_url":"https://avatars.githubusercontent.com/u/3430433?v=3","gravatar_id":"","url":"https://api.github.com/users/octokit","html_url":"https://github.com/octokit","followers_url":"https://api.github.com/users/octokit/followers","following_url":"https://api.github.com/users/octokit/following{/other_user}","gists_url":"https://api.github.com/users/octokit/gists{/gist_id}","starred_url":"https://api.github.com/users/octokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octokit/subscriptions","organizations_url":"https://api.github.com/users/octokit/orgs","repos_url":"https://api.github.com/users/octokit/repos","events_url":"https://api.github.com/users/octokit/events{/privacy}","received_events_url":"https://api.github.com/users/octokit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octokit/octokit.net","description":"A GitHub API client library for .NET ","fork":false,"url":"https://api.github.com/repos/octokit/octokit.net","forks_url":"https://api.github.com/repos/octokit/octokit.net/forks","keys_url":"https://api.github.com/repos/octokit/octokit.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octokit/octokit.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octokit/octokit.net/teams","hooks_url":"https://api.github.com/repos/octokit/octokit.net/hooks","issue_events_url":"https://api.github.com/repos/octokit/octokit.net/issues/events{/number}","events_url":"https://api.github.com/repos/octokit/octokit.net/events","assignees_url":"https://api.github.com/repos/octokit/octokit.net/assignees{/user}","branches_url":"https://api.github.com/repos/octokit/octokit.net/branches{/branch}","tags_url":"https://api.github.com/repos/octokit/octokit.net/tags","blobs_url":"https://api.github.com/repos/octokit/octokit.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octokit/octokit.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octokit/octokit.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/octokit/octokit.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octokit/octokit.net/statuses/{sha}","languages_url":"https://api.github.com/repos/octokit/octokit.net/languages","stargazers_url":"https://api.github.com/repos/octokit/octokit.net/stargazers","contributors_url":"https://api.github.com/repos/octokit/octokit.net/contributors","subscribers_url":"https://api.github.com/repos/octokit/octokit.net/subscribers","subscription_url":"https://api.github.com/repos/octokit/octokit.net/subscription","commits_url":"https://api.github.com/repos/octokit/octokit.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/octokit/octokit.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/octokit/octokit.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/octokit/octokit.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/octokit/octokit.net/contents/{+path}","compare_url":"https://api.github.com/repos/octokit/octokit.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octokit/octokit.net/merges","archive_url":"https://api.github.com/repos/octokit/octokit.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octokit/octokit.net/downloads","issues_url":"https://api.github.com/repos/octokit/octokit.net/issues{/number}","pulls_url":"https://api.github.com/repos/octokit/octokit.net/pulls{/number}","milestones_url":"https://api.github.com/repos/octokit/octokit.net/milestones{/number}","notifications_url":"https://api.github.com/repos/octokit/octokit.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octokit/octokit.net/labels{/name}","releases_url":"https://api.github.com/repos/octokit/octokit.net/releases{/id}","deployments_url":"https://api.github.com/repos/octokit/octokit.net/deployments","created_at":"2013-01-09T20:48:45Z","updated_at":"2016-07-05T14:30:46Z","pushed_at":"2016-07-06T01:39:13Z","git_url":"git://github.com/octokit/octokit.net.git","ssh_url":"git@github.com:octokit/octokit.net.git","clone_url":"https://github.com/octokit/octokit.net.git","svn_url":"https://github.com/octokit/octokit.net","homepage":null,"size":92313,"stargazers_count":990,"watchers_count":990,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":499,"mirror_url":null,"open_issues_count":123,"forks":499,"open_issues":123,"watchers":990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1379"},"html":{"href":"https://github.com/octokit/octokit.net/pull/1379"},"issue":{"href":"https://api.github.com/repos/octokit/octokit.net/issues/1379"},"comments":{"href":"https://api.github.com/repos/octokit/octokit.net/issues/1379/comments"},"review_comments":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1379/comments"},"review_comment":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octokit/octokit.net/pulls/1379/commits"},"statuses":{"href":"https://api.github.com/repos/octokit/octokit.net/statuses/60e9733c91f8923ada9c04d8a7acd3b66ad515c8"}}}}
{"actor":{"display_login":"shiftkey"}}