{"action":"created","comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments/64994786","id":64994786,"diff_hunk":"@@ -0,0 +1,47 @@\n+[![Travis-CI Build Status](https://travis-ci.org/open-source-economics/Tax-Calculator.svg?branch=master)](https://travis-ci.org/open-source-economics/Tax-Calculator)\n+[![Codecov Status](https://codecov.io/github/open-source-economics/Tax-Calculator/coverage.svg?precision=2)](https://codecov.io/github/open-source-economics/Tax-Calculator)\n+\n+Tax-Calculator Data-Preparation Guidelines\n+==========================================\n+\n+The Tax-Calculator is flexible enough to read almost any kind of\n+CSV-formatted input data on filing units as long as the variable names\n+correspond to those expected by Tax-Calculator.  The only required\n+input variables are `RECID` (a unique filing-unit record identifier)\n+and `MARS` (a positive-valued filing-status indicator as defined in\n+the IRS-SOI Public Use File).  Other variables in the input file must\n+have variable names that are in the `VALID_READ_VARS` set in the\n+[records.py\n+file](https://github.com/open-source-economics/Tax-Calculator/blob/master/taxcalc/records.py).\n+These other variable names are usually the same as those in the\n+IRS-SOI Public Use File.\n+\n+Any variable in the `VALID_READ_VARS` set that is not in an input file\n+is automatically set to a value of zero for every filing unit.\n+\n+However, there are important data-preparation issues related to the\n+fact that the payroll tax is a tax on individuals, not on income-tax\n+filing units.  Tax-Calculator expects that the filing-unit total for\n+each of several earnings-related variables is split between the\n+taxpayer and the spouse.  It is the responsibility of anyone preparing\n+data for Tax-Calculator input to do this earnings splitting.  Here are\n+the relationships between the filing-unit variable and the taxpayer\n+(`p`) and spouse (`s`) variables expected by Tax-Calculator:\n+```\n+e00200 = e00200p + e00200s\n+\n+e00900 = e00900p + e00900s\n+\n+e02100 = e02100p + e02100s\n+```\n+Obviously, when `MARS` is not equal to 2 (married filing jointly), the\n+values of the three `s` variables are zero and the values of the three\n+`p` variables are equal to the value of their corresponding\n+filing-unit variable.  And obviously, the data file can omit any one,\n+or all, of these variables.\n+","path":"DATAPREP.md","position":42,"original_position":42,"commit_id":"fbb90474eda987f8cc1a4bde54ed2239e2e87449","original_commit_id":"fbb90474eda987f8cc1a4bde54ed2239e2e87449","user":{"login":"zrisher","id":1958130,"avatar_url":"https://avatars.githubusercontent.com/u/1958130?v=3","gravatar_id":"","url":"https://api.github.com/users/zrisher","html_url":"https://github.com/zrisher","followers_url":"https://api.github.com/users/zrisher/followers","following_url":"https://api.github.com/users/zrisher/following{/other_user}","gists_url":"https://api.github.com/users/zrisher/gists{/gist_id}","starred_url":"https://api.github.com/users/zrisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrisher/subscriptions","organizations_url":"https://api.github.com/users/zrisher/orgs","repos_url":"https://api.github.com/users/zrisher/repos","events_url":"https://api.github.com/users/zrisher/events{/privacy}","received_events_url":"https://api.github.com/users/zrisher/received_events","type":"User","site_admin":false},"body":"So since the tax calculator expects:\r\n* `e00200s = e00900s = e02100s = 0 if MARS != 2`\r\n* `e00200 = e00200p + e00200s`, `e00900 = e00900p + e00900s`, and `ce02100 = e02100p + e02100s` always\r\n\r\nand if these conditions aren't met we're using an erroneous input set, perhaps we should check for them when the records are loaded and raise an error if they fail?","created_at":"2016-05-28T21:47:57Z","updated_at":"2016-05-28T21:47:57Z","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/754#discussion_r64994786","pull_request_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754","_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments/64994786"},"html":{"href":"https://github.com/open-source-economics/Tax-Calculator/pull/754#discussion_r64994786"},"pull_request":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754"}}},"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754","id":71211088,"html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/754","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/754.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/754.patch","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/754","number":754,"state":"closed","locked":false,"title":"Remove cmbtp-calc and earnings-split logic from Records class","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"body":"The removed logic is now in the taxdata repository's final-preparation script (see [taxdata pull request 28](https://github.com/open-source-economics/taxdata/pull/28)), so it is being executed once, when the `puf.csv` file is created, instead of every time the Tax-Calculator is executed.  These two coordinated pull requests are meant to resolve issue #688.","created_at":"2016-05-24T12:31:26Z","updated_at":"2016-05-28T21:47:57Z","closed_at":"2016-05-27T15:51:58Z","merged_at":"2016-05-27T15:51:58Z","merge_commit_sha":"42b40aed51fdc82cd47e56a8216bcfb97e751009","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754/commits","review_comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754/comments","review_comment_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/754/comments","statuses_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/fbb90474eda987f8cc1a4bde54ed2239e2e87449","head":{"label":"martinholmer:prep-move","ref":"prep-move","sha":"fbb90474eda987f8cc1a4bde54ed2239e2e87449","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"repo":{"id":39093370,"name":"Tax-Calculator","full_name":"martinholmer/Tax-Calculator","owner":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinholmer/Tax-Calculator","description":"Federal Individual Income Tax Microsimulation Model","fork":true,"url":"https://api.github.com/repos/martinholmer/Tax-Calculator","forks_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/forks","keys_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/teams","hooks_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/hooks","issue_events_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/events","assignees_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/tags","blobs_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/languages","stargazers_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/stargazers","contributors_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/contributors","subscribers_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/subscribers","subscription_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/subscription","commits_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/merges","archive_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/downloads","issues_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/martinholmer/Tax-Calculator/deployments","created_at":"2015-07-14T18:36:41Z","updated_at":"2016-01-14T22:47:16Z","pushed_at":"2016-05-28T16:58:56Z","git_url":"git://github.com/martinholmer/Tax-Calculator.git","ssh_url":"git@github.com:martinholmer/Tax-Calculator.git","clone_url":"https://github.com/martinholmer/Tax-Calculator.git","svn_url":"https://github.com/martinholmer/Tax-Calculator","homepage":"","size":293077,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-source-economics:master","ref":"master","sha":"eb07692a15147019eb91b09901ae66938d4e0408","user":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars.githubusercontent.com/u/15148101?v=3","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"repo":{"id":22389485,"name":"Tax-Calculator","full_name":"open-source-economics/Tax-Calculator","owner":{"login":"open-source-economics","id":15148101,"avatar_url":"https://avatars.githubusercontent.com/u/15148101?v=3","gravatar_id":"","url":"https://api.github.com/users/open-source-economics","html_url":"https://github.com/open-source-economics","followers_url":"https://api.github.com/users/open-source-economics/followers","following_url":"https://api.github.com/users/open-source-economics/following{/other_user}","gists_url":"https://api.github.com/users/open-source-economics/gists{/gist_id}","starred_url":"https://api.github.com/users/open-source-economics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-source-economics/subscriptions","organizations_url":"https://api.github.com/users/open-source-economics/orgs","repos_url":"https://api.github.com/users/open-source-economics/repos","events_url":"https://api.github.com/users/open-source-economics/events{/privacy}","received_events_url":"https://api.github.com/users/open-source-economics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-source-economics/Tax-Calculator","description":"Federal Individual Income Tax Microsimulation Model","fork":false,"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator","forks_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/forks","keys_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/teams","hooks_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/hooks","issue_events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/events{/number}","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/events","assignees_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/assignees{/user}","branches_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/branches{/branch}","tags_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/tags","blobs_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/languages","stargazers_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/stargazers","contributors_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/contributors","subscribers_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/subscribers","subscription_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/subscription","commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/contents/{+path}","compare_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/merges","archive_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/downloads","issues_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues{/number}","pulls_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/labels{/name}","releases_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/releases{/id}","deployments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/deployments","created_at":"2014-07-29T17:49:09Z","updated_at":"2016-05-28T21:13:47Z","pushed_at":"2016-05-28T16:51:19Z","git_url":"git://github.com/open-source-economics/Tax-Calculator.git","ssh_url":"git@github.com:open-source-economics/Tax-Calculator.git","clone_url":"https://github.com/open-source-economics/Tax-Calculator.git","svn_url":"https://github.com/open-source-economics/Tax-Calculator","homepage":"","size":362311,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":71,"forks":36,"open_issues":71,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754"},"html":{"href":"https://github.com/open-source-economics/Tax-Calculator/pull/754"},"issue":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/754"},"comments":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/open-source-economics/Tax-Calculator/statuses/fbb90474eda987f8cc1a4bde54ed2239e2e87449"}}}}
{"actor":{"display_login":"zrisher"}}