{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/104","id":73822618,"html_url":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack/pull/104","diff_url":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack/pull/104.diff","patch_url":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack/pull/104.patch","issue_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues/104","number":104,"state":"closed","locked":false,"title":"Add way to restrict assembly names in mapping","user":{"login":"tpetricek","id":485413,"avatar_url":"https://avatars.githubusercontent.com/u/485413?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetricek","html_url":"https://github.com/tpetricek","followers_url":"https://api.github.com/users/tpetricek/followers","following_url":"https://api.github.com/users/tpetricek/following{/other_user}","gists_url":"https://api.github.com/users/tpetricek/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetricek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetricek/subscriptions","organizations_url":"https://api.github.com/users/tpetricek/orgs","repos_url":"https://api.github.com/users/tpetricek/repos","events_url":"https://api.github.com/users/tpetricek/events{/privacy}","received_events_url":"https://api.github.com/users/tpetricek/received_events","type":"User","site_admin":false},"body":"This makes it possible to fix funny bug in F# Data/FsLab.\r\n\r\nWhen replacing one type form `FSharp.Core.DesignTime.dll`, the original code was picking a type from `Deedle.dll` (which inlines CSV parser and contains type with the same name, but not with all the functions). This is just because Deedle appeared earlier in the list of referenced assemblies.\r\n\r\nWith this fix in, we can create the replacer using:\r\n\r\n    let bindingContext = \r\n       ProvidedTypesContext.Create(cfg, \r\n           [ \"FSharp.Data.DesignTime\", \"FSharp.Data\" ])\r\n\r\nThis way, types from `FSharp.Data.DesignTime` will only be mapped to types from assembly with a name starting with `FSharp.Data`. If no `assemblyReplacementMap` is specified, it behaves as before and picks type from first assembly that contains it.\r\n\r\n/cc @dsyme - I'm merging this to fix F# Data bug, but post-merge review would be appreciated!","created_at":"2016-06-14T22:10:10Z","updated_at":"2016-06-14T22:24:15Z","closed_at":"2016-06-14T22:24:15Z","merged_at":"2016-06-14T22:24:15Z","merge_commit_sha":"56cd9eb1399c51ac6f05601cd7010bbe8261ef9a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/104/commits","review_comments_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/104/comments","review_comment_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues/104/comments","statuses_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/statuses/b4c0d4120fd3806c77800c7c692ba5b574af4341","head":{"label":"tpetricek:master","ref":"master","sha":"b4c0d4120fd3806c77800c7c692ba5b574af4341","user":{"login":"tpetricek","id":485413,"avatar_url":"https://avatars.githubusercontent.com/u/485413?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetricek","html_url":"https://github.com/tpetricek","followers_url":"https://api.github.com/users/tpetricek/followers","following_url":"https://api.github.com/users/tpetricek/following{/other_user}","gists_url":"https://api.github.com/users/tpetricek/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetricek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetricek/subscriptions","organizations_url":"https://api.github.com/users/tpetricek/orgs","repos_url":"https://api.github.com/users/tpetricek/repos","events_url":"https://api.github.com/users/tpetricek/events{/privacy}","received_events_url":"https://api.github.com/users/tpetricek/received_events","type":"User","site_admin":false},"repo":{"id":21918766,"name":"FSharp.TypeProviders.StarterPack","full_name":"tpetricek/FSharp.TypeProviders.StarterPack","owner":{"login":"tpetricek","id":485413,"avatar_url":"https://avatars.githubusercontent.com/u/485413?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetricek","html_url":"https://github.com/tpetricek","followers_url":"https://api.github.com/users/tpetricek/followers","following_url":"https://api.github.com/users/tpetricek/following{/other_user}","gists_url":"https://api.github.com/users/tpetricek/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetricek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetricek/subscriptions","organizations_url":"https://api.github.com/users/tpetricek/orgs","repos_url":"https://api.github.com/users/tpetricek/repos","events_url":"https://api.github.com/users/tpetricek/events{/privacy}","received_events_url":"https://api.github.com/users/tpetricek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpetricek/FSharp.TypeProviders.StarterPack","description":"","fork":true,"url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack","forks_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/forks","keys_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/teams","hooks_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/hooks","issue_events_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/issues/events{/number}","events_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/events","assignees_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/assignees{/user}","branches_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/branches{/branch}","tags_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/tags","blobs_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/statuses/{sha}","languages_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/languages","stargazers_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/stargazers","contributors_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/contributors","subscribers_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/subscribers","subscription_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/subscription","commits_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/contents/{+path}","compare_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/merges","archive_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/downloads","issues_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/issues{/number}","pulls_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/pulls{/number}","milestones_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/milestones{/number}","notifications_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/labels{/name}","releases_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/releases{/id}","deployments_url":"https://api.github.com/repos/tpetricek/FSharp.TypeProviders.StarterPack/deployments","created_at":"2014-07-16T21:24:20Z","updated_at":"2016-04-12T14:21:49Z","pushed_at":"2016-06-14T22:02:24Z","git_url":"git://github.com/tpetricek/FSharp.TypeProviders.StarterPack.git","ssh_url":"git@github.com:tpetricek/FSharp.TypeProviders.StarterPack.git","clone_url":"https://github.com/tpetricek/FSharp.TypeProviders.StarterPack.git","svn_url":"https://github.com/tpetricek/FSharp.TypeProviders.StarterPack","homepage":null,"size":1381,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsprojects:master","ref":"master","sha":"fa494d6308c8b22c8a7c7c6a6cd0e771ddf7c701","user":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":15222599,"name":"FSharp.TypeProviders.StarterPack","full_name":"fsprojects/FSharp.TypeProviders.StarterPack","owner":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack","description":"The ProvidedTypes SDK for creating F# type providers","fork":false,"url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack","forks_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/forks","keys_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/teams","hooks_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/hooks","issue_events_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues/events{/number}","events_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/events","assignees_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/assignees{/user}","branches_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/branches{/branch}","tags_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/tags","blobs_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/statuses/{sha}","languages_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/languages","stargazers_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/stargazers","contributors_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/contributors","subscribers_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/subscribers","subscription_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/subscription","commits_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/contents/{+path}","compare_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/merges","archive_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/downloads","issues_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues{/number}","pulls_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls{/number}","milestones_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/milestones{/number}","notifications_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/labels{/name}","releases_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/releases{/id}","deployments_url":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/deployments","created_at":"2013-12-16T10:05:48Z","updated_at":"2016-06-05T08:38:28Z","pushed_at":"2016-06-14T22:24:16Z","git_url":"git://github.com/fsprojects/FSharp.TypeProviders.StarterPack.git","ssh_url":"git@github.com:fsprojects/FSharp.TypeProviders.StarterPack.git","clone_url":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack.git","svn_url":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack","homepage":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack#f-type-provider-starter-pack-","size":1379,"stargazers_count":80,"watchers_count":80,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":21,"forks":33,"open_issues":21,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/104"},"html":{"href":"https://github.com/fsprojects/FSharp.TypeProviders.StarterPack/pull/104"},"issue":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues/104"},"comments":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/fsprojects/FSharp.TypeProviders.StarterPack/statuses/b4c0d4120fd3806c77800c7c692ba5b574af4341"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tpetricek","id":485413,"avatar_url":"https://avatars.githubusercontent.com/u/485413?v=3","gravatar_id":"","url":"https://api.github.com/users/tpetricek","html_url":"https://github.com/tpetricek","followers_url":"https://api.github.com/users/tpetricek/followers","following_url":"https://api.github.com/users/tpetricek/following{/other_user}","gists_url":"https://api.github.com/users/tpetricek/gists{/gist_id}","starred_url":"https://api.github.com/users/tpetricek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpetricek/subscriptions","organizations_url":"https://api.github.com/users/tpetricek/orgs","repos_url":"https://api.github.com/users/tpetricek/repos","events_url":"https://api.github.com/users/tpetricek/events{/privacy}","received_events_url":"https://api.github.com/users/tpetricek/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"tpetricek"}}