{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15938","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15938/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15938/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15938/events","html_url":"https://github.com/cms-sw/cmssw/pull/15938","id":178466567,"number":15938,"title":"Address residual code review for Timing PRs","user":{"login":"lgray","id":1068089,"avatar_url":"https://avatars.githubusercontent.com/u/1068089?v=3","gravatar_id":"","url":"https://api.github.com/users/lgray","html_url":"https://github.com/lgray","followers_url":"https://api.github.com/users/lgray/followers","following_url":"https://api.github.com/users/lgray/following{/other_user}","gists_url":"https://api.github.com/users/lgray/gists{/gist_id}","starred_url":"https://api.github.com/users/lgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgray/subscriptions","organizations_url":"https://api.github.com/users/lgray/orgs","repos_url":"https://api.github.com/users/lgray/repos","events_url":"https://api.github.com/users/lgray/events{/privacy}","received_events_url":"https://api.github.com/users/lgray/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":1513,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-22T12:40:03Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-09-21T21:25:46Z","updated_at":"2016-09-22T12:44:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15938","html_url":"https://github.com/cms-sw/cmssw/pull/15938","diff_url":"https://github.com/cms-sw/cmssw/pull/15938.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15938.patch"},"body":"Follow up code review for #15710."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/248893242","html_url":"https://github.com/cms-sw/cmssw/pull/15938#issuecomment-248893242","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15938","id":248893242,"user":{"login":"lgray","id":1068089,"avatar_url":"https://avatars.githubusercontent.com/u/1068089?v=3","gravatar_id":"","url":"https://api.github.com/users/lgray","html_url":"https://github.com/lgray","followers_url":"https://api.github.com/users/lgray/followers","following_url":"https://api.github.com/users/lgray/following{/other_user}","gists_url":"https://api.github.com/users/lgray/gists{/gist_id}","starred_url":"https://api.github.com/users/lgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgray/subscriptions","organizations_url":"https://api.github.com/users/lgray/orgs","repos_url":"https://api.github.com/users/lgray/repos","events_url":"https://api.github.com/users/lgray/events{/privacy}","received_events_url":"https://api.github.com/users/lgray/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T12:44:58Z","updated_at":"2016-09-22T12:44:58Z","body":"@makortel Actually, since that modification gets used in a few places in different eras that are notionally independent of each other, I think it might be a good idea to write a centralize function to make the changes and then have each era call that function.\r\n\r\ni.e. what if someone wants to run timing era without phase 2 tracker? or hgcal without phase2 tracker?"}}
{"actor":{"display_login":"lgray"}}