{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/78830699","id":78830699,"diff_hunk":"@@ -208,6 +208,11 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) {\n \tfs.DurationVar(&s.OutOfDiskTransitionFrequency.Duration, \"outofdisk-transition-frequency\", s.OutOfDiskTransitionFrequency.Duration, \"Duration for which the kubelet has to wait before transitioning out of out-of-disk node condition status. Default: 5m0s\")\n \tfs.StringVar(&s.NodeIP, \"node-ip\", s.NodeIP, \"IP address of the node. If set, kubelet will use this IP address for the node\")\n \tfs.BoolVar(&s.EnableCustomMetrics, \"enable-custom-metrics\", s.EnableCustomMetrics, \"Support for gathering custom metrics.\")\n+\tfs.StringVar(&s.CAdvisorCollectorClientCertFile, \"cadvisor-collector-client-cert-file\", s.CAdvisorCollectorClientCertFile, \"\"+","path":"cmd/kubelet/app/options/options.go","position":4,"original_position":4,"commit_id":"9c83fbb038133e4e146d4da4ebaa38308059aaf2","original_commit_id":"9c83fbb038133e4e146d4da4ebaa38308059aaf2","user":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars.githubusercontent.com/u/903617?v=3","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"body":"I'm assuming `\"\"` is an acceptable default value for each of these flags. If not, remember to apply the preferred default in `pkg/apis/componentconfig/v1alpha1/defaults.go`.","created_at":"2016-09-14T20:18:36Z","updated_at":"2016-09-14T20:18:36Z","html_url":"https://github.com/kubernetes/kubernetes/pull/32491#discussion_r78830699","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/78830699"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32491#discussion_r78830699"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491","id":84876480,"html_url":"https://github.com/kubernetes/kubernetes/pull/32491","diff_url":"https://github.com/kubernetes/kubernetes/pull/32491.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/32491.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32491","number":32491,"state":"open","locked":false,"title":"Adds in configuration option to set the cAdvisor collector certificates.","user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars.githubusercontent.com/u/691166?v=3","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThe latest version of cAdvisor used in Kubernetes has the option to supply an http.client object to be used by the cAdvisor custom metric collectors. This allows the collectors to be able to expose a client certificate that a custom metric endpoint can use to verify that it is indeed cAdvisor who is requesting access (certificate based authentication).\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\nAdd option to pass certificates to cAdvisor custom metric collectors to allow metric endpoints to use certificate based authentication.\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/32491)\n<!-- Reviewable:end -->\n","created_at":"2016-09-12T14:01:30Z","updated_at":"2016-09-14T20:18:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1327578c9a6bd2a1a7fb11ec7a4f2fca00be9a97","assignee":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"assignees":[{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32491/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9c83fbb038133e4e146d4da4ebaa38308059aaf2","head":{"label":"mwringe:cadvisor_client_certificates","ref":"cadvisor_client_certificates","sha":"9c83fbb038133e4e146d4da4ebaa38308059aaf2","user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars.githubusercontent.com/u/691166?v=3","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"repo":{"id":32348726,"name":"kubernetes","full_name":"mwringe/kubernetes","owner":{"login":"mwringe","id":691166,"avatar_url":"https://avatars.githubusercontent.com/u/691166?v=3","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwringe/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/mwringe/kubernetes","forks_url":"https://api.github.com/repos/mwringe/kubernetes/forks","keys_url":"https://api.github.com/repos/mwringe/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwringe/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwringe/kubernetes/teams","hooks_url":"https://api.github.com/repos/mwringe/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mwringe/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mwringe/kubernetes/events","assignees_url":"https://api.github.com/repos/mwringe/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mwringe/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mwringe/kubernetes/tags","blobs_url":"https://api.github.com/repos/mwringe/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwringe/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwringe/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwringe/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwringe/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mwringe/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mwringe/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mwringe/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mwringe/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mwringe/kubernetes/subscription","commits_url":"https://api.github.com/repos/mwringe/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwringe/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwringe/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwringe/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwringe/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mwringe/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwringe/kubernetes/merges","archive_url":"https://api.github.com/repos/mwringe/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwringe/kubernetes/downloads","issues_url":"https://api.github.com/repos/mwringe/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mwringe/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mwringe/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mwringe/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwringe/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mwringe/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mwringe/kubernetes/deployments","created_at":"2015-03-16T19:45:34Z","updated_at":"2016-05-11T21:20:06Z","pushed_at":"2016-09-12T21:45:24Z","git_url":"git://github.com/mwringe/kubernetes.git","ssh_url":"git@github.com:mwringe/kubernetes.git","clone_url":"https://github.com/mwringe/kubernetes.git","svn_url":"https://github.com/mwringe/kubernetes","homepage":"http://kubernetes.io","size":311417,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"32a32962ee7dcc2fd2fce95f5245168792acdb52","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-14T20:16:49Z","pushed_at":"2016-09-14T20:18:34Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":562469,"stargazers_count":16798,"watchers_count":16798,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5413,"mirror_url":null,"open_issues_count":4436,"forks":5413,"open_issues":4436,"watchers":16798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32491"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32491"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32491/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32491/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/9c83fbb038133e4e146d4da4ebaa38308059aaf2"}}}}
{"actor":{"display_login":"mtaufen"}}