{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/examples/pulls/comments/62473210","id":62473210,"diff_hunk":"@@ -125,7 +117,8 @@ public GenericRecord apply(GenericRecord view, String region) {\n                         return new KeyValue<>((String) viewRegion.get(\"region\"), viewRegion);\n                     }\n                 })\n-                .countByKey(null, longSerializer, null, longDeserializer, \"GeoPageViewsWindow\");\n+            // count views by user, using hopping windows of size 5 minutes that advance every 1 minute\n+            .countByKey(TimeWindows.of(\"GeoPageViewsWindow\", 5 * 60 * 1000L).advanceBy(60 * 1000L));\n \n         // write to the result topic\n         regionCount.to(\"PageViewsByRegion\");","path":"kafka-streams/src/main/java/io/confluent/examples/streams/PageViewRegionExample.java","position":null,"original_position":78,"commit_id":"d5d324094d8b09ef4af899c6ba394b33aa52a703","original_commit_id":"a8ec67626a6d60b0d6578c8f6539392955fdb0c4","user":{"login":"miguno","id":294849,"avatar_url":"https://avatars.githubusercontent.com/u/294849?v=3","gravatar_id":"","url":"https://api.github.com/users/miguno","html_url":"https://github.com/miguno","followers_url":"https://api.github.com/users/miguno/followers","following_url":"https://api.github.com/users/miguno/following{/other_user}","gists_url":"https://api.github.com/users/miguno/gists{/gist_id}","starred_url":"https://api.github.com/users/miguno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguno/subscriptions","organizations_url":"https://api.github.com/users/miguno/orgs","repos_url":"https://api.github.com/users/miguno/repos","events_url":"https://api.github.com/users/miguno/events{/privacy}","received_events_url":"https://api.github.com/users/miguno/received_events","type":"User","site_admin":false},"body":"No, it does not work, you are right.  I didn't spot this because I assumed the code examples to be working -- in this PR I only updated the code to match Kafka 0.10.0.0, i.e. I didn't systematically go through all the code again to spot previous bugs (which, in hindsight, would have been a good idea apparently).","created_at":"2016-05-09T09:43:26Z","updated_at":"2016-05-09T09:43:26Z","html_url":"https://github.com/confluentinc/examples/pull/22#discussion_r62473210","pull_request_url":"https://api.github.com/repos/confluentinc/examples/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/examples/pulls/comments/62473210"},"html":{"href":"https://github.com/confluentinc/examples/pull/22#discussion_r62473210"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/examples/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/examples/pulls/22","id":66198043,"html_url":"https://github.com/confluentinc/examples/pull/22","diff_url":"https://github.com/confluentinc/examples/pull/22.diff","patch_url":"https://github.com/confluentinc/examples/pull/22.patch","issue_url":"https://api.github.com/repos/confluentinc/examples/issues/22","number":22,"state":"open","locked":false,"title":"DO NOT MERGE! Update to Kafka 0.10.0.0-SNAPSHOT (commit e97735f)","user":{"login":"miguno","id":294849,"avatar_url":"https://avatars.githubusercontent.com/u/294849?v=3","gravatar_id":"","url":"https://api.github.com/users/miguno","html_url":"https://github.com/miguno","followers_url":"https://api.github.com/users/miguno/followers","following_url":"https://api.github.com/users/miguno/following{/other_user}","gists_url":"https://api.github.com/users/miguno/gists{/gist_id}","starred_url":"https://api.github.com/users/miguno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguno/subscriptions","organizations_url":"https://api.github.com/users/miguno/orgs","repos_url":"https://api.github.com/users/miguno/repos","events_url":"https://api.github.com/users/miguno/events{/privacy}","received_events_url":"https://api.github.com/users/miguno/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE THIS PR: Its only intent is to facilitate code review (e.g. because Kafka 0.10.0.0 is still undergoing changes and because it's not yet released, which means users of this repo would be forced to build Kafka locally).**\r\n\r\nPing @guozhangwang , @enothereska \r\n\r\nPlease pay special attention to:\r\n\r\n* The serde \"wrappers\" (`GenericAvroSerde`, `SpecificAvroSerde`, `PriorityQueueSerde`, `WindowedSerde`.\r\n* The examples under `src/main/java`.  These examples do compile of course but, since there are no unit/integration tests for these, this doesn't mean they work at runtime, too.  For example, we made changes to `count`, `countByKey`, and `aggregate`;  please double-check whether the serde setup works correctly in combination with these operators.\r\n\r\nWhat I can confirm:\r\n\r\n* All the code compiles.\r\n* The tests (right now we only have integration tests) pass when running `mvn test`.","created_at":"2016-04-12T17:40:42Z","updated_at":"2016-05-09T09:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e907d7dbb94e52644599f864aae626f8c4a196c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/examples/pulls/22/commits","review_comments_url":"https://api.github.com/repos/confluentinc/examples/pulls/22/comments","review_comment_url":"https://api.github.com/repos/confluentinc/examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/examples/issues/22/comments","statuses_url":"https://api.github.com/repos/confluentinc/examples/statuses/d5d324094d8b09ef4af899c6ba394b33aa52a703","head":{"label":"confluentinc:kafka-0.10.0.0","ref":"kafka-0.10.0.0","sha":"d5d324094d8b09ef4af899c6ba394b33aa52a703","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":32839065,"name":"examples","full_name":"confluentinc/examples","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/examples","description":"Example code on running Confluent Platform","fork":false,"url":"https://api.github.com/repos/confluentinc/examples","forks_url":"https://api.github.com/repos/confluentinc/examples/forks","keys_url":"https://api.github.com/repos/confluentinc/examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/examples/teams","hooks_url":"https://api.github.com/repos/confluentinc/examples/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/examples/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/examples/events","assignees_url":"https://api.github.com/repos/confluentinc/examples/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/examples/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/examples/tags","blobs_url":"https://api.github.com/repos/confluentinc/examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/examples/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/examples/languages","stargazers_url":"https://api.github.com/repos/confluentinc/examples/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/examples/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/examples/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/examples/subscription","commits_url":"https://api.github.com/repos/confluentinc/examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/examples/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/examples/merges","archive_url":"https://api.github.com/repos/confluentinc/examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/examples/downloads","issues_url":"https://api.github.com/repos/confluentinc/examples/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/examples/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/examples/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/examples/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/examples/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/examples/deployments","created_at":"2015-03-25T02:57:11Z","updated_at":"2016-05-06T18:52:34Z","pushed_at":"2016-05-09T09:41:45Z","git_url":"git://github.com/confluentinc/examples.git","ssh_url":"git@github.com:confluentinc/examples.git","clone_url":"https://github.com/confluentinc/examples.git","svn_url":"https://github.com/confluentinc/examples","homepage":"","size":361,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":4,"forks":37,"open_issues":4,"watchers":41,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"86707f9875e4538c241f547e264af33ad600f1e6","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":32839065,"name":"examples","full_name":"confluentinc/examples","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/examples","description":"Example code on running Confluent Platform","fork":false,"url":"https://api.github.com/repos/confluentinc/examples","forks_url":"https://api.github.com/repos/confluentinc/examples/forks","keys_url":"https://api.github.com/repos/confluentinc/examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/examples/teams","hooks_url":"https://api.github.com/repos/confluentinc/examples/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/examples/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/examples/events","assignees_url":"https://api.github.com/repos/confluentinc/examples/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/examples/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/examples/tags","blobs_url":"https://api.github.com/repos/confluentinc/examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/examples/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/examples/languages","stargazers_url":"https://api.github.com/repos/confluentinc/examples/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/examples/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/examples/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/examples/subscription","commits_url":"https://api.github.com/repos/confluentinc/examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/examples/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/examples/merges","archive_url":"https://api.github.com/repos/confluentinc/examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/examples/downloads","issues_url":"https://api.github.com/repos/confluentinc/examples/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/examples/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/examples/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/examples/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/examples/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/examples/deployments","created_at":"2015-03-25T02:57:11Z","updated_at":"2016-05-06T18:52:34Z","pushed_at":"2016-05-09T09:41:45Z","git_url":"git://github.com/confluentinc/examples.git","ssh_url":"git@github.com:confluentinc/examples.git","clone_url":"https://github.com/confluentinc/examples.git","svn_url":"https://github.com/confluentinc/examples","homepage":"","size":361,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":4,"forks":37,"open_issues":4,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/examples/pulls/22"},"html":{"href":"https://github.com/confluentinc/examples/pull/22"},"issue":{"href":"https://api.github.com/repos/confluentinc/examples/issues/22"},"comments":{"href":"https://api.github.com/repos/confluentinc/examples/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/examples/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/examples/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/examples/statuses/d5d324094d8b09ef4af899c6ba394b33aa52a703"}}}}