{"action":"closed","number":586,"pull_request":{"url":"https://api.github.com/repos/moezbhatti/qksms/pulls/586","id":80820322,"html_url":"https://github.com/moezbhatti/qksms/pull/586","diff_url":"https://github.com/moezbhatti/qksms/pull/586.diff","patch_url":"https://github.com/moezbhatti/qksms/pull/586.patch","issue_url":"https://api.github.com/repos/moezbhatti/qksms/issues/586","number":586,"state":"closed","locked":false,"title":"Fix crash when backPress from SettingsActivity after Orientation changed","user":{"login":"frogoscar","id":3180748,"avatar_url":"https://avatars.githubusercontent.com/u/3180748?v=3","gravatar_id":"","url":"https://api.github.com/users/frogoscar","html_url":"https://github.com/frogoscar","followers_url":"https://api.github.com/users/frogoscar/followers","following_url":"https://api.github.com/users/frogoscar/following{/other_user}","gists_url":"https://api.github.com/users/frogoscar/gists{/gist_id}","starred_url":"https://api.github.com/users/frogoscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frogoscar/subscriptions","organizations_url":"https://api.github.com/users/frogoscar/orgs","repos_url":"https://api.github.com/users/frogoscar/repos","events_url":"https://api.github.com/users/frogoscar/events{/privacy}","received_events_url":"https://api.github.com/users/frogoscar/received_events","type":"User","site_admin":false},"body":"### Corrects also the bad behavior : After screen rotation, it will return to main Settings screen automatically\r\n\r\n### DESCRIPTION\r\nQKSMS crashes when pressing Back button from Settings Activity after Orientation change.\r\nThis bug happens both in version on Google Play and built from Github.\r\nIt only happens when rotating screen in Category (Appearance, General, Notifications, MMS, QK Reply, etc. ) of Settings.\r\n\r\n### STEPS\r\n1. Start QKSMS\r\n2. Go to Settings by clicking on the OptionMenu -> Settings\r\n3. Click on one Category in the list\r\n4. When you are in the Category (for example, **General**), rotate the screen\r\n5. After screen rotation, it will return to main Settings screen automatically (which is also not good)\r\n6. Click on Back button\r\n\r\n### EXPECTED\r\nReturn to the Conversations Activity which contains the conversation list.\r\n\r\n### OBSERVATIONS\r\nCrashes.\r\n\r\n### Logcat from Android Studio\r\n\r\n    FATAL EXCEPTION: main\r\n    Process: com.moez.QKSMS, PID: 22003\r\n    java.lang.IllegalStateException: Fragment already added: SettingsFragment{1d41d5f0 #0 id=0x7f0e0085 SettingsFragment}\r\n    at android.app.FragmentManagerImpl.addFragment(FragmentManager.java:1153)\r\n    at android.app.BackStackRecord.popFromBackStack(BackStackRecord.java:1547)\r\n\r\n### Please try it and decide what to do about this issue. Maybe you can come out with a better solution.\r\n\r\nThank you very much. I love QKSMS. It is great!","created_at":"2016-08-10T15:57:23Z","updated_at":"2016-08-27T05:18:44Z","closed_at":"2016-08-27T05:18:44Z","merged_at":"2016-08-27T05:18:44Z","merge_commit_sha":"9aae127c0e58f02ad0f3638ed1485f32f508ad7a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/moezbhatti/qksms/pulls/586/commits","review_comments_url":"https://api.github.com/repos/moezbhatti/qksms/pulls/586/comments","review_comment_url":"https://api.github.com/repos/moezbhatti/qksms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moezbhatti/qksms/issues/586/comments","statuses_url":"https://api.github.com/repos/moezbhatti/qksms/statuses/871ba2744211949dffa8240689c851a8be63b2e5","head":{"label":"frogoscar:enmingxie/Fix_crash_when_backPress_from_SettingsActivity_after_Orientation_changed","ref":"enmingxie/Fix_crash_when_backPress_from_SettingsActivity_after_Orientation_changed","sha":"871ba2744211949dffa8240689c851a8be63b2e5","user":{"login":"frogoscar","id":3180748,"avatar_url":"https://avatars.githubusercontent.com/u/3180748?v=3","gravatar_id":"","url":"https://api.github.com/users/frogoscar","html_url":"https://github.com/frogoscar","followers_url":"https://api.github.com/users/frogoscar/followers","following_url":"https://api.github.com/users/frogoscar/following{/other_user}","gists_url":"https://api.github.com/users/frogoscar/gists{/gist_id}","starred_url":"https://api.github.com/users/frogoscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frogoscar/subscriptions","organizations_url":"https://api.github.com/users/frogoscar/orgs","repos_url":"https://api.github.com/users/frogoscar/repos","events_url":"https://api.github.com/users/frogoscar/events{/privacy}","received_events_url":"https://api.github.com/users/frogoscar/received_events","type":"User","site_admin":false},"repo":{"id":65379128,"name":"qksms","full_name":"frogoscar/qksms","owner":{"login":"frogoscar","id":3180748,"avatar_url":"https://avatars.githubusercontent.com/u/3180748?v=3","gravatar_id":"","url":"https://api.github.com/users/frogoscar","html_url":"https://github.com/frogoscar","followers_url":"https://api.github.com/users/frogoscar/followers","following_url":"https://api.github.com/users/frogoscar/following{/other_user}","gists_url":"https://api.github.com/users/frogoscar/gists{/gist_id}","starred_url":"https://api.github.com/users/frogoscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frogoscar/subscriptions","organizations_url":"https://api.github.com/users/frogoscar/orgs","repos_url":"https://api.github.com/users/frogoscar/repos","events_url":"https://api.github.com/users/frogoscar/events{/privacy}","received_events_url":"https://api.github.com/users/frogoscar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frogoscar/qksms","description":"The most beautiful SMS messenger app for Android","fork":true,"url":"https://api.github.com/repos/frogoscar/qksms","forks_url":"https://api.github.com/repos/frogoscar/qksms/forks","keys_url":"https://api.github.com/repos/frogoscar/qksms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frogoscar/qksms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frogoscar/qksms/teams","hooks_url":"https://api.github.com/repos/frogoscar/qksms/hooks","issue_events_url":"https://api.github.com/repos/frogoscar/qksms/issues/events{/number}","events_url":"https://api.github.com/repos/frogoscar/qksms/events","assignees_url":"https://api.github.com/repos/frogoscar/qksms/assignees{/user}","branches_url":"https://api.github.com/repos/frogoscar/qksms/branches{/branch}","tags_url":"https://api.github.com/repos/frogoscar/qksms/tags","blobs_url":"https://api.github.com/repos/frogoscar/qksms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frogoscar/qksms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frogoscar/qksms/git/refs{/sha}","trees_url":"https://api.github.com/repos/frogoscar/qksms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frogoscar/qksms/statuses/{sha}","languages_url":"https://api.github.com/repos/frogoscar/qksms/languages","stargazers_url":"https://api.github.com/repos/frogoscar/qksms/stargazers","contributors_url":"https://api.github.com/repos/frogoscar/qksms/contributors","subscribers_url":"https://api.github.com/repos/frogoscar/qksms/subscribers","subscription_url":"https://api.github.com/repos/frogoscar/qksms/subscription","commits_url":"https://api.github.com/repos/frogoscar/qksms/commits{/sha}","git_commits_url":"https://api.github.com/repos/frogoscar/qksms/git/commits{/sha}","comments_url":"https://api.github.com/repos/frogoscar/qksms/comments{/number}","issue_comment_url":"https://api.github.com/repos/frogoscar/qksms/issues/comments{/number}","contents_url":"https://api.github.com/repos/frogoscar/qksms/contents/{+path}","compare_url":"https://api.github.com/repos/frogoscar/qksms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frogoscar/qksms/merges","archive_url":"https://api.github.com/repos/frogoscar/qksms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frogoscar/qksms/downloads","issues_url":"https://api.github.com/repos/frogoscar/qksms/issues{/number}","pulls_url":"https://api.github.com/repos/frogoscar/qksms/pulls{/number}","milestones_url":"https://api.github.com/repos/frogoscar/qksms/milestones{/number}","notifications_url":"https://api.github.com/repos/frogoscar/qksms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frogoscar/qksms/labels{/name}","releases_url":"https://api.github.com/repos/frogoscar/qksms/releases{/id}","deployments_url":"https://api.github.com/repos/frogoscar/qksms/deployments","created_at":"2016-08-10T12:02:44Z","updated_at":"2016-08-16T17:59:04Z","pushed_at":"2016-08-22T14:17:10Z","git_url":"git://github.com/frogoscar/qksms.git","ssh_url":"git@github.com:frogoscar/qksms.git","clone_url":"https://github.com/frogoscar/qksms.git","svn_url":"https://github.com/frogoscar/qksms","homepage":"https://play.google.com/store/apps/details?id=com.moez.QKSMS","size":7288,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"moezbhatti:master","ref":"master","sha":"0f39237e8e00957827762642b0c19347578ca421","user":{"login":"moezbhatti","id":4358785,"avatar_url":"https://avatars.githubusercontent.com/u/4358785?v=3","gravatar_id":"","url":"https://api.github.com/users/moezbhatti","html_url":"https://github.com/moezbhatti","followers_url":"https://api.github.com/users/moezbhatti/followers","following_url":"https://api.github.com/users/moezbhatti/following{/other_user}","gists_url":"https://api.github.com/users/moezbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/moezbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moezbhatti/subscriptions","organizations_url":"https://api.github.com/users/moezbhatti/orgs","repos_url":"https://api.github.com/users/moezbhatti/repos","events_url":"https://api.github.com/users/moezbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/moezbhatti/received_events","type":"User","site_admin":false},"repo":{"id":31138452,"name":"qksms","full_name":"moezbhatti/qksms","owner":{"login":"moezbhatti","id":4358785,"avatar_url":"https://avatars.githubusercontent.com/u/4358785?v=3","gravatar_id":"","url":"https://api.github.com/users/moezbhatti","html_url":"https://github.com/moezbhatti","followers_url":"https://api.github.com/users/moezbhatti/followers","following_url":"https://api.github.com/users/moezbhatti/following{/other_user}","gists_url":"https://api.github.com/users/moezbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/moezbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moezbhatti/subscriptions","organizations_url":"https://api.github.com/users/moezbhatti/orgs","repos_url":"https://api.github.com/users/moezbhatti/repos","events_url":"https://api.github.com/users/moezbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/moezbhatti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moezbhatti/qksms","description":"The most beautiful SMS messenger app for Android","fork":false,"url":"https://api.github.com/repos/moezbhatti/qksms","forks_url":"https://api.github.com/repos/moezbhatti/qksms/forks","keys_url":"https://api.github.com/repos/moezbhatti/qksms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moezbhatti/qksms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moezbhatti/qksms/teams","hooks_url":"https://api.github.com/repos/moezbhatti/qksms/hooks","issue_events_url":"https://api.github.com/repos/moezbhatti/qksms/issues/events{/number}","events_url":"https://api.github.com/repos/moezbhatti/qksms/events","assignees_url":"https://api.github.com/repos/moezbhatti/qksms/assignees{/user}","branches_url":"https://api.github.com/repos/moezbhatti/qksms/branches{/branch}","tags_url":"https://api.github.com/repos/moezbhatti/qksms/tags","blobs_url":"https://api.github.com/repos/moezbhatti/qksms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moezbhatti/qksms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moezbhatti/qksms/git/refs{/sha}","trees_url":"https://api.github.com/repos/moezbhatti/qksms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moezbhatti/qksms/statuses/{sha}","languages_url":"https://api.github.com/repos/moezbhatti/qksms/languages","stargazers_url":"https://api.github.com/repos/moezbhatti/qksms/stargazers","contributors_url":"https://api.github.com/repos/moezbhatti/qksms/contributors","subscribers_url":"https://api.github.com/repos/moezbhatti/qksms/subscribers","subscription_url":"https://api.github.com/repos/moezbhatti/qksms/subscription","commits_url":"https://api.github.com/repos/moezbhatti/qksms/commits{/sha}","git_commits_url":"https://api.github.com/repos/moezbhatti/qksms/git/commits{/sha}","comments_url":"https://api.github.com/repos/moezbhatti/qksms/comments{/number}","issue_comment_url":"https://api.github.com/repos/moezbhatti/qksms/issues/comments{/number}","contents_url":"https://api.github.com/repos/moezbhatti/qksms/contents/{+path}","compare_url":"https://api.github.com/repos/moezbhatti/qksms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moezbhatti/qksms/merges","archive_url":"https://api.github.com/repos/moezbhatti/qksms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moezbhatti/qksms/downloads","issues_url":"https://api.github.com/repos/moezbhatti/qksms/issues{/number}","pulls_url":"https://api.github.com/repos/moezbhatti/qksms/pulls{/number}","milestones_url":"https://api.github.com/repos/moezbhatti/qksms/milestones{/number}","notifications_url":"https://api.github.com/repos/moezbhatti/qksms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moezbhatti/qksms/labels{/name}","releases_url":"https://api.github.com/repos/moezbhatti/qksms/releases{/id}","deployments_url":"https://api.github.com/repos/moezbhatti/qksms/deployments","created_at":"2015-02-21T19:50:43Z","updated_at":"2016-08-25T17:08:55Z","pushed_at":"2016-08-27T05:18:44Z","git_url":"git://github.com/moezbhatti/qksms.git","ssh_url":"git@github.com:moezbhatti/qksms.git","clone_url":"https://github.com/moezbhatti/qksms.git","svn_url":"https://github.com/moezbhatti/qksms","homepage":"https://play.google.com/store/apps/details?id=com.moez.QKSMS","size":7938,"stargazers_count":1221,"watchers_count":1221,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":313,"mirror_url":null,"open_issues_count":257,"forks":313,"open_issues":257,"watchers":1221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moezbhatti/qksms/pulls/586"},"html":{"href":"https://github.com/moezbhatti/qksms/pull/586"},"issue":{"href":"https://api.github.com/repos/moezbhatti/qksms/issues/586"},"comments":{"href":"https://api.github.com/repos/moezbhatti/qksms/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/moezbhatti/qksms/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/moezbhatti/qksms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moezbhatti/qksms/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/moezbhatti/qksms/statuses/871ba2744211949dffa8240689c851a8be63b2e5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"moezbhatti","id":4358785,"avatar_url":"https://avatars.githubusercontent.com/u/4358785?v=3","gravatar_id":"","url":"https://api.github.com/users/moezbhatti","html_url":"https://github.com/moezbhatti","followers_url":"https://api.github.com/users/moezbhatti/followers","following_url":"https://api.github.com/users/moezbhatti/following{/other_user}","gists_url":"https://api.github.com/users/moezbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/moezbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moezbhatti/subscriptions","organizations_url":"https://api.github.com/users/moezbhatti/orgs","repos_url":"https://api.github.com/users/moezbhatti/repos","events_url":"https://api.github.com/users/moezbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/moezbhatti/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"moezbhatti"}}