{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/57","repository_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2","labels_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/57/comments","events_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/57/events","html_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/57","id":177469972,"number":57,"title":"Feature/support","user":{"login":"poolguy","id":17598928,"avatar_url":"https://avatars.githubusercontent.com/u/17598928?v=3","gravatar_id":"","url":"https://api.github.com/users/poolguy","html_url":"https://github.com/poolguy","followers_url":"https://api.github.com/users/poolguy/followers","following_url":"https://api.github.com/users/poolguy/following{/other_user}","gists_url":"https://api.github.com/users/poolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/poolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolguy/subscriptions","organizations_url":"https://api.github.com/users/poolguy/orgs","repos_url":"https://api.github.com/users/poolguy/repos","events_url":"https://api.github.com/users/poolguy/events{/privacy}","received_events_url":"https://api.github.com/users/poolguy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-16T16:42:34Z","updated_at":"2016-09-23T20:21:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/pulls/57","html_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/57","diff_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/57.diff","patch_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/57.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit-appdev/android-byu-suite-v2/57)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/comments/249292908","html_url":"https://github.com/byu-oit-appdev/android-byu-suite-v2/pull/57#issuecomment-249292908","issue_url":"https://api.github.com/repos/byu-oit-appdev/android-byu-suite-v2/issues/57","id":249292908,"user":{"login":"poolguy","id":17598928,"avatar_url":"https://avatars.githubusercontent.com/u/17598928?v=3","gravatar_id":"","url":"https://api.github.com/users/poolguy","html_url":"https://github.com/poolguy","followers_url":"https://api.github.com/users/poolguy/followers","following_url":"https://api.github.com/users/poolguy/following{/other_user}","gists_url":"https://api.github.com/users/poolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/poolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolguy/subscriptions","organizations_url":"https://api.github.com/users/poolguy/orgs","repos_url":"https://api.github.com/users/poolguy/repos","events_url":"https://api.github.com/users/poolguy/events{/privacy}","received_events_url":"https://api.github.com/users/poolguy/received_events","type":"User","site_admin":false},"created_at":"2016-09-23T20:21:48Z","updated_at":"2016-09-23T20:21:48Z","body":"\n\n\n\nReview status: 13 of 30 files reviewed at latest revision, 15 unresolved discussions.\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/FavoritesUtil.java, line 17 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KS8TjqyfCUm3zSzOje-:-KSCQMf4oWiNGbsVyGDj:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/101f87377631c462aabcc916c796990db8b8c992/app/src/main/java/edu/byu/suite/mainScreen/FavoritesUtil.java#L17)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> Change these back to private\n</details>\nDone.\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/FeatureManager.java, line 21 at r5](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KSExgtbpIySUaOeUZ17:-KSMRMjoKHSa-w4SJUU3:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/fac80378bcf8f0c9253650226f2c0be7f7f70dd5/app/src/main/java/edu/byu/suite/mainScreen/FeatureManager.java#L21)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> These can't be static. They have to be instance variables\n</details>\nDone.\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/FeatureManager.java, line 55 at r5](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KSEvwA1TgUJik2c1LOC:-KSMRnL_1Aa82fbBH4eR:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/fac80378bcf8f0c9253650226f2c0be7f7f70dd5/app/src/main/java/edu/byu/suite/mainScreen/FeatureManager.java#L55)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> Let's add squirrely brackets here\n</details>\nDone.\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/FeatureManager.java, line 59 at r5](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KSEx-WUQGLW8TynB8Th:-KSMRoHkvXXN_jn9FKCk:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/fac80378bcf8f0c9253650226f2c0be7f7f70dd5/app/src/main/java/edu/byu/suite/mainScreen/FeatureManager.java#L59)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> If you only need this once, inline it\n</details>\nDone.\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/controller/FavoritesActivity.java, line 46 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KS8UUF9auG7bos9azkM:-KSCQ206aIk_4y7Zo1jm:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/101f87377631c462aabcc916c796990db8b8c992/app/src/main/java/edu/byu/suite/mainScreen/controller/FavoritesActivity.java#L46)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> Make this private. Actually, don't save this as an instance variable. Just create it when you need it. getInstance() is really fast\n</details>\nDone.\n\n---\n\n*[app/src/main/java/edu/byu/suite/mainScreen/controller/FavoritesActivity.java, line 174 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KS8VTXTDsGChG-X4qbl:-KSCPpMe8CW4qlvQnEkv:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/101f87377631c462aabcc916c796990db8b8c992/app/src/main/java/edu/byu/suite/mainScreen/controller/FavoritesActivity.java#L174)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> Don't need getList() here. Just call get(position)\n</details>\nDone.\n\n---\n\n*[support/src/main/java/edu/byu/support/adapter/ByuRecyclerAdapter.java, line 54 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57#-KS8Vtc7Hs_jdVn7RXat:-KSCQoUJlFQlRROoFWZ4:b-896fix) ([raw file](https://github.com/byu-oit-appdev/android-byu-suite-v2/blob/101f87377631c462aabcc916c796990db8b8c992/support/src/main/java/edu/byu/support/adapter/ByuRecyclerAdapter.java#L54)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary>\n> Rename to moveItem\n</details>\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/byu-oit-appdev/android-byu-suite-v2/57)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"poolguy"}}