{"action":"closed","number":3564,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3564","id":77748812,"html_url":"https://github.com/apple/swift/pull/3564","diff_url":"https://github.com/apple/swift/pull/3564.diff","patch_url":"https://github.com/apple/swift/pull/3564.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/3564","number":3564,"state":"closed","locked":false,"title":"[Sema] fix ParenPattern resolution when subexpression is a NilLiteralExpr","user":{"login":"jtbandes","id":14237,"avatar_url":"https://avatars.githubusercontent.com/u/14237?v=3","gravatar_id":"","url":"https://api.github.com/users/jtbandes","html_url":"https://github.com/jtbandes","followers_url":"https://api.github.com/users/jtbandes/followers","following_url":"https://api.github.com/users/jtbandes/following{/other_user}","gists_url":"https://api.github.com/users/jtbandes/gists{/gist_id}","starred_url":"https://api.github.com/users/jtbandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtbandes/subscriptions","organizations_url":"https://api.github.com/users/jtbandes/orgs","repos_url":"https://api.github.com/users/jtbandes/repos","events_url":"https://api.github.com/users/jtbandes/events{/privacy}","received_events_url":"https://api.github.com/users/jtbandes/received_events","type":"User","site_admin":false},"body":"#### What's in this pull request?\r\nA minor fix to the `ResolvePattern` ASTVisitor used in TypeCheckPattern.cpp.\r\n\r\nPreviously, if a ParenExpr's subexpression returned nullptr when passed to `visit()` (which happens for `nil` literals, since `visitNilLiteralExpr()` isn't defined), then `visitParenExpr()` itself would return nullptr, so the ParenExpr was just wrapped in an ExprPattern. This broke the ability of `coercePatternToType()` to peek at the ExprPattern's expression and convert `NilLiteralExpr` to an `EnumElementPattern`, because instead of finding a NilLiteralExpr, it'd just find the ParenExpr.\r\n\r\nWith this fix, `visitParenExpr()` reuses existing logic from `getSubExprPattern()`, which wraps **the subexpression** in an ExprPattern, even when there's no special visitor for it, rather than wrapping the whole ParenExpr in an ExprPattern.\r\n\r\n#### Resolved bug number: [SR-2066](https://bugs.swift.org/browse/SR-2066)\r\n\r\n*\"Parenthesized nil in a case statement breaks exhaustivity checking\"* filed by @gregomni \r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\n","created_at":"2016-07-17T23:02:51Z","updated_at":"2016-07-18T04:55:46Z","closed_at":"2016-07-18T04:55:46Z","merged_at":"2016-07-18T04:55:46Z","merge_commit_sha":"ce7751cbd06bced8269285f5c9812584edf48f28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/3564/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/3564/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/3564/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/c3126e9f4fd619e4648a604c6fb3addf97ccf637","head":{"label":"jtbandes:jtbandes/fix-nil","ref":"jtbandes/fix-nil","sha":"c3126e9f4fd619e4648a604c6fb3addf97ccf637","user":{"login":"jtbandes","id":14237,"avatar_url":"https://avatars.githubusercontent.com/u/14237?v=3","gravatar_id":"","url":"https://api.github.com/users/jtbandes","html_url":"https://github.com/jtbandes","followers_url":"https://api.github.com/users/jtbandes/followers","following_url":"https://api.github.com/users/jtbandes/following{/other_user}","gists_url":"https://api.github.com/users/jtbandes/gists{/gist_id}","starred_url":"https://api.github.com/users/jtbandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtbandes/subscriptions","organizations_url":"https://api.github.com/users/jtbandes/orgs","repos_url":"https://api.github.com/users/jtbandes/repos","events_url":"https://api.github.com/users/jtbandes/events{/privacy}","received_events_url":"https://api.github.com/users/jtbandes/received_events","type":"User","site_admin":false},"repo":{"id":47395204,"name":"swift","full_name":"jtbandes/swift","owner":{"login":"jtbandes","id":14237,"avatar_url":"https://avatars.githubusercontent.com/u/14237?v=3","gravatar_id":"","url":"https://api.github.com/users/jtbandes","html_url":"https://github.com/jtbandes","followers_url":"https://api.github.com/users/jtbandes/followers","following_url":"https://api.github.com/users/jtbandes/following{/other_user}","gists_url":"https://api.github.com/users/jtbandes/gists{/gist_id}","starred_url":"https://api.github.com/users/jtbandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtbandes/subscriptions","organizations_url":"https://api.github.com/users/jtbandes/orgs","repos_url":"https://api.github.com/users/jtbandes/repos","events_url":"https://api.github.com/users/jtbandes/events{/privacy}","received_events_url":"https://api.github.com/users/jtbandes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtbandes/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/jtbandes/swift","forks_url":"https://api.github.com/repos/jtbandes/swift/forks","keys_url":"https://api.github.com/repos/jtbandes/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtbandes/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtbandes/swift/teams","hooks_url":"https://api.github.com/repos/jtbandes/swift/hooks","issue_events_url":"https://api.github.com/repos/jtbandes/swift/issues/events{/number}","events_url":"https://api.github.com/repos/jtbandes/swift/events","assignees_url":"https://api.github.com/repos/jtbandes/swift/assignees{/user}","branches_url":"https://api.github.com/repos/jtbandes/swift/branches{/branch}","tags_url":"https://api.github.com/repos/jtbandes/swift/tags","blobs_url":"https://api.github.com/repos/jtbandes/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtbandes/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtbandes/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtbandes/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtbandes/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/jtbandes/swift/languages","stargazers_url":"https://api.github.com/repos/jtbandes/swift/stargazers","contributors_url":"https://api.github.com/repos/jtbandes/swift/contributors","subscribers_url":"https://api.github.com/repos/jtbandes/swift/subscribers","subscription_url":"https://api.github.com/repos/jtbandes/swift/subscription","commits_url":"https://api.github.com/repos/jtbandes/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtbandes/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtbandes/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtbandes/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtbandes/swift/contents/{+path}","compare_url":"https://api.github.com/repos/jtbandes/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtbandes/swift/merges","archive_url":"https://api.github.com/repos/jtbandes/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtbandes/swift/downloads","issues_url":"https://api.github.com/repos/jtbandes/swift/issues{/number}","pulls_url":"https://api.github.com/repos/jtbandes/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/jtbandes/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/jtbandes/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtbandes/swift/labels{/name}","releases_url":"https://api.github.com/repos/jtbandes/swift/releases{/id}","deployments_url":"https://api.github.com/repos/jtbandes/swift/deployments","created_at":"2015-12-04T09:44:22Z","updated_at":"2016-02-03T09:01:40Z","pushed_at":"2016-07-17T22:25:33Z","git_url":"git://github.com/jtbandes/swift.git","ssh_url":"git@github.com:jtbandes/swift.git","clone_url":"https://github.com/jtbandes/swift.git","svn_url":"https://github.com/jtbandes/swift","homepage":"","size":102005,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"b4cba583303dd6bae2dc71a77ba9cfd530b6d2cc","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-07-18T04:45:02Z","pushed_at":"2016-07-18T04:55:46Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":160027,"stargazers_count":32381,"watchers_count":32381,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4501,"mirror_url":null,"open_issues_count":94,"forks":4501,"open_issues":94,"watchers":32381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/3564"},"html":{"href":"https://github.com/apple/swift/pull/3564"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/3564"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/3564/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/3564/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/3564/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/c3126e9f4fd619e4648a604c6fb3addf97ccf637"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"swift-ci","id":15467072,"avatar_url":"https://avatars.githubusercontent.com/u/15467072?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-ci","html_url":"https://github.com/swift-ci","followers_url":"https://api.github.com/users/swift-ci/followers","following_url":"https://api.github.com/users/swift-ci/following{/other_user}","gists_url":"https://api.github.com/users/swift-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-ci/subscriptions","organizations_url":"https://api.github.com/users/swift-ci/orgs","repos_url":"https://api.github.com/users/swift-ci/repos","events_url":"https://api.github.com/users/swift-ci/events{/privacy}","received_events_url":"https://api.github.com/users/swift-ci/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":19,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"swift-ci"}}