{"action":"closed","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/1900","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/1900/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/1900/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/1900/events","html_url":"https://github.com/weaveworks/weave/issues/1900","id":126814021,"number":1900,"title":"`weave stop` fails when plugin network is in use; breaks upgrade / config change","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/weaveworks/weave/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/weaveworks/weave/labels/[component/plugin]","name":"[component/plugin]","color":"ccffff"}],"state":"closed","locked":false,"assignee":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/weaveworks/weave/milestones/26","html_url":"https://github.com/weaveworks/weave/milestones/1.4.3","labels_url":"https://api.github.com/repos/weaveworks/weave/milestones/26/labels","id":1506780,"number":26,"title":"1.4.3","description":"","creator":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":5,"state":"open","created_at":"2016-01-14T12:12:41Z","updated_at":"2016-01-21T11:30:19Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-01-15T06:12:49Z","updated_at":"2016-01-21T11:30:19Z","closed_at":"2016-01-21T11:30:19Z","body":"```\r\n$ weave launch\r\n$ docker run --net=weave -dti ubuntu\r\n2e34a65c3e1bc24df246fbc00054736385d0f48f1925a957ab307daf480d770a\r\n$ weave stop\r\nFATA: 2016/01/15 06:00:23.904004 unable to remove network: API error (500): network weave has active endpoints\r\n\r\n$ echo $?\r\n1\r\n$ docker ps\r\nCONTAINER ID        IMAGE                         COMMAND                  CREATED             STATUS              PORTS               NAMES\r\n2e34a65c3e1b        ubuntu                        \"/bin/bash\"              3 minutes ago       Up 3 minutes                            kickass_feynman\r\nb19822b5a301        weaveworks/plugin:latest      \"/home/weave/plugin\"     6 minutes ago       Up 6 minutes                            weaveplugin\r\n88133ccee49f        weaveworks/weaveexec:latest   \"/home/weave/weavepro\"   6 minutes ago       Up 6 minutes                            weaveproxy\r\n2ff055729def        weaveworks/weave:latest       \"/home/weave/weaver -\"   6 minutes ago       Up 6 minutes                            weave\r\n```\r\n\r\nThis breaks our recommended way of performing config changes and upgrades while leaving application containers running.\r\n\r\nIt is also inconsistent with what happens for user-created networks that use the weave plugin. i.e. having any containers attached to these does not prevent stopping weave.\r\n\r\nI know the current behaviour is there for a reason, namely docker becoming very unhappy when the driver for a network isn't there. But we haven't got a proper cure for that. And breaking the weave config change upgrade behaviour is arguably worse.\r\n\r\nSomewhat related to #1897."}}