{"action":"created","comment":{"url":"https://api.github.com/repos/collectd/collectd/pulls/comments/65010302","id":65010302,"diff_hunk":"@@ -2026,13 +2062,19 @@ static void perl_log (int level, const char *msg,\n \n \t/* Lock the base thread if this is not called from one of the read threads\n \t * to avoid race conditions with c_ithread_create(). See\n-\t * https://github.com/collectd/collectd/issues/9 for details. */\n-\tif (aTHX == perl_threads->head->interp)\n+\t * https://github.com/collectd/collectd/issues/9 for details.\n+\t * Additionally check, if we are called from perl interpreter.\n+\t * Maybe PTHREAD_MUTEX_RECURSIVE mutex type will be more appropriate?","path":"src/perl.c","position":134,"original_position":122,"commit_id":"7b30075d321712805b4ac9222f31279a9f6a1c6b","original_commit_id":"7b30075d321712805b4ac9222f31279a9f6a1c6b","user":{"login":"tokkee","id":243914,"avatar_url":"https://avatars.githubusercontent.com/u/243914?v=3","gravatar_id":"","url":"https://api.github.com/users/tokkee","html_url":"https://github.com/tokkee","followers_url":"https://api.github.com/users/tokkee/followers","following_url":"https://api.github.com/users/tokkee/following{/other_user}","gists_url":"https://api.github.com/users/tokkee/gists{/gist_id}","starred_url":"https://api.github.com/users/tokkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokkee/subscriptions","organizations_url":"https://api.github.com/users/tokkee/orgs","repos_url":"https://api.github.com/users/tokkee/repos","events_url":"https://api.github.com/users/tokkee/events{/privacy}","received_events_url":"https://api.github.com/users/tokkee/received_events","type":"User","site_admin":false},"body":"Yeah, I think a recursive mutex would be a better option.","created_at":"2016-05-29T19:35:25Z","updated_at":"2016-05-29T19:35:25Z","html_url":"https://github.com/collectd/collectd/pull/1710#discussion_r65010302","pull_request_url":"https://api.github.com/repos/collectd/collectd/pulls/1710","_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments/65010302"},"html":{"href":"https://github.com/collectd/collectd/pull/1710#discussion_r65010302"},"pull_request":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1710"}}},"pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1710","id":69997445,"html_url":"https://github.com/collectd/collectd/pull/1710","diff_url":"https://github.com/collectd/collectd/pull/1710.diff","patch_url":"https://github.com/collectd/collectd/pull/1710.patch","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1710","number":1710,"state":"open","locked":false,"title":"Perl plugin fixes for #1706","user":{"login":"rpv-tomsk","id":13328211,"avatar_url":"https://avatars.githubusercontent.com/u/13328211?v=3","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"body":"* lock base thread interpreter in perl_init() too, to avoid race conditions with c_ithread_create() called from threads of already-initialized plugins. (with deadlock when perl_log() called from perl_init() detection)\r\n* Fix coredump due to destroying interpreter on thread running perl.\r\n\r\nSee #1706 for comments.","created_at":"2016-05-13T13:42:18Z","updated_at":"2016-05-29T19:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f98c369dc38c67db6151a7d662fe6c5e537b710d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/collectd/collectd/pulls/1710/commits","review_comments_url":"https://api.github.com/repos/collectd/collectd/pulls/1710/comments","review_comment_url":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1710/comments","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/7b30075d321712805b4ac9222f31279a9f6a1c6b","head":{"label":"rpv-tomsk:perl-plugin-fixes","ref":"perl-plugin-fixes","sha":"7b30075d321712805b4ac9222f31279a9f6a1c6b","user":{"login":"rpv-tomsk","id":13328211,"avatar_url":"https://avatars.githubusercontent.com/u/13328211?v=3","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"repo":{"id":52437705,"name":"collectd","full_name":"rpv-tomsk/collectd","owner":{"login":"rpv-tomsk","id":13328211,"avatar_url":"https://avatars.githubusercontent.com/u/13328211?v=3","gravatar_id":"","url":"https://api.github.com/users/rpv-tomsk","html_url":"https://github.com/rpv-tomsk","followers_url":"https://api.github.com/users/rpv-tomsk/followers","following_url":"https://api.github.com/users/rpv-tomsk/following{/other_user}","gists_url":"https://api.github.com/users/rpv-tomsk/gists{/gist_id}","starred_url":"https://api.github.com/users/rpv-tomsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpv-tomsk/subscriptions","organizations_url":"https://api.github.com/users/rpv-tomsk/orgs","repos_url":"https://api.github.com/users/rpv-tomsk/repos","events_url":"https://api.github.com/users/rpv-tomsk/events{/privacy}","received_events_url":"https://api.github.com/users/rpv-tomsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpv-tomsk/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":true,"url":"https://api.github.com/repos/rpv-tomsk/collectd","forks_url":"https://api.github.com/repos/rpv-tomsk/collectd/forks","keys_url":"https://api.github.com/repos/rpv-tomsk/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpv-tomsk/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpv-tomsk/collectd/teams","hooks_url":"https://api.github.com/repos/rpv-tomsk/collectd/hooks","issue_events_url":"https://api.github.com/repos/rpv-tomsk/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/rpv-tomsk/collectd/events","assignees_url":"https://api.github.com/repos/rpv-tomsk/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/rpv-tomsk/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/rpv-tomsk/collectd/tags","blobs_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpv-tomsk/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/rpv-tomsk/collectd/languages","stargazers_url":"https://api.github.com/repos/rpv-tomsk/collectd/stargazers","contributors_url":"https://api.github.com/repos/rpv-tomsk/collectd/contributors","subscribers_url":"https://api.github.com/repos/rpv-tomsk/collectd/subscribers","subscription_url":"https://api.github.com/repos/rpv-tomsk/collectd/subscription","commits_url":"https://api.github.com/repos/rpv-tomsk/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpv-tomsk/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpv-tomsk/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpv-tomsk/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpv-tomsk/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/rpv-tomsk/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpv-tomsk/collectd/merges","archive_url":"https://api.github.com/repos/rpv-tomsk/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpv-tomsk/collectd/downloads","issues_url":"https://api.github.com/repos/rpv-tomsk/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/rpv-tomsk/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/rpv-tomsk/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/rpv-tomsk/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpv-tomsk/collectd/labels{/name}","releases_url":"https://api.github.com/repos/rpv-tomsk/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/rpv-tomsk/collectd/deployments","created_at":"2016-02-24T11:35:57Z","updated_at":"2016-02-24T12:16:00Z","pushed_at":"2016-05-29T19:19:38Z","git_url":"git://github.com/rpv-tomsk/collectd.git","ssh_url":"git@github.com:rpv-tomsk/collectd.git","clone_url":"https://github.com/rpv-tomsk/collectd.git","svn_url":"https://github.com/rpv-tomsk/collectd","homepage":"http://collectd.org/","size":13990,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"collectd:master","ref":"master","sha":"6d01a00ee1fee1a5f8b78d2925d9b4e6979a5c3a","user":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"repo":{"id":3208640,"name":"collectd","full_name":"collectd/collectd","owner":{"login":"collectd","id":1027481,"avatar_url":"https://avatars.githubusercontent.com/u/1027481?v=3","gravatar_id":"","url":"https://api.github.com/users/collectd","html_url":"https://github.com/collectd","followers_url":"https://api.github.com/users/collectd/followers","following_url":"https://api.github.com/users/collectd/following{/other_user}","gists_url":"https://api.github.com/users/collectd/gists{/gist_id}","starred_url":"https://api.github.com/users/collectd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collectd/subscriptions","organizations_url":"https://api.github.com/users/collectd/orgs","repos_url":"https://api.github.com/users/collectd/repos","events_url":"https://api.github.com/users/collectd/events{/privacy}","received_events_url":"https://api.github.com/users/collectd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/collectd/collectd","description":"The system statistics collection daemon. Mirror of the canonical repository (updated automatically). Please send Pull Requests here!","fork":false,"url":"https://api.github.com/repos/collectd/collectd","forks_url":"https://api.github.com/repos/collectd/collectd/forks","keys_url":"https://api.github.com/repos/collectd/collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collectd/collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collectd/collectd/teams","hooks_url":"https://api.github.com/repos/collectd/collectd/hooks","issue_events_url":"https://api.github.com/repos/collectd/collectd/issues/events{/number}","events_url":"https://api.github.com/repos/collectd/collectd/events","assignees_url":"https://api.github.com/repos/collectd/collectd/assignees{/user}","branches_url":"https://api.github.com/repos/collectd/collectd/branches{/branch}","tags_url":"https://api.github.com/repos/collectd/collectd/tags","blobs_url":"https://api.github.com/repos/collectd/collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collectd/collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collectd/collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/collectd/collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collectd/collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/collectd/collectd/languages","stargazers_url":"https://api.github.com/repos/collectd/collectd/stargazers","contributors_url":"https://api.github.com/repos/collectd/collectd/contributors","subscribers_url":"https://api.github.com/repos/collectd/collectd/subscribers","subscription_url":"https://api.github.com/repos/collectd/collectd/subscription","commits_url":"https://api.github.com/repos/collectd/collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/collectd/collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/collectd/collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/collectd/collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/collectd/collectd/contents/{+path}","compare_url":"https://api.github.com/repos/collectd/collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collectd/collectd/merges","archive_url":"https://api.github.com/repos/collectd/collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collectd/collectd/downloads","issues_url":"https://api.github.com/repos/collectd/collectd/issues{/number}","pulls_url":"https://api.github.com/repos/collectd/collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/collectd/collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/collectd/collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collectd/collectd/labels{/name}","releases_url":"https://api.github.com/repos/collectd/collectd/releases{/id}","deployments_url":"https://api.github.com/repos/collectd/collectd/deployments","created_at":"2012-01-18T13:07:51Z","updated_at":"2016-05-29T15:04:07Z","pushed_at":"2016-05-29T19:19:38Z","git_url":"git://github.com/collectd/collectd.git","ssh_url":"git@github.com:collectd/collectd.git","clone_url":"https://github.com/collectd/collectd.git","svn_url":"https://github.com/collectd/collectd","homepage":"http://collectd.org/","size":26372,"stargazers_count":1155,"watchers_count":1155,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":663,"mirror_url":null,"open_issues_count":365,"forks":663,"open_issues":365,"watchers":1155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1710"},"html":{"href":"https://github.com/collectd/collectd/pull/1710"},"issue":{"href":"https://api.github.com/repos/collectd/collectd/issues/1710"},"comments":{"href":"https://api.github.com/repos/collectd/collectd/issues/1710/comments"},"review_comments":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1710/comments"},"review_comment":{"href":"https://api.github.com/repos/collectd/collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/collectd/collectd/pulls/1710/commits"},"statuses":{"href":"https://api.github.com/repos/collectd/collectd/statuses/7b30075d321712805b4ac9222f31279a9f6a1c6b"}}}}
{"actor":{"display_login":"tokkee"}}