{"action":"closed","number":12841,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/12841","id":64048079,"html_url":"https://github.com/laravel/framework/pull/12841","diff_url":"https://github.com/laravel/framework/pull/12841.diff","patch_url":"https://github.com/laravel/framework/pull/12841.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/12841","number":12841,"state":"closed","locked":false,"title":"[5.3] Numerical keys are preserved during validation","user":{"login":"maxwilms","id":708742,"avatar_url":"https://avatars.githubusercontent.com/u/708742?v=3","gravatar_id":"","url":"https://api.github.com/users/maxwilms","html_url":"https://github.com/maxwilms","followers_url":"https://api.github.com/users/maxwilms/followers","following_url":"https://api.github.com/users/maxwilms/following{/other_user}","gists_url":"https://api.github.com/users/maxwilms/gists{/gist_id}","starred_url":"https://api.github.com/users/maxwilms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxwilms/subscriptions","organizations_url":"https://api.github.com/users/maxwilms/orgs","repos_url":"https://api.github.com/users/maxwilms/repos","events_url":"https://api.github.com/users/maxwilms/events{/privacy}","received_events_url":"https://api.github.com/users/maxwilms/received_events","type":"User","site_admin":false},"body":"My controller has the following method which is accessible via `/foo`\r\n\r\n    public function foo(Request $request)\r\n    {\r\n        $this->validate($request, [\r\n            '1' => 'required'\r\n        ]);\r\n\r\n        return \"success!\";\r\n    }\r\n\r\nIf I call `/foo?1=enter` the requests fails. While `/foo?0=enter` works fine.\r\n\r\nThe problem only occurs if the field name can be converted to a numerical value:\r\nPHP silently converts array keys to the corresponding integer if possible, e.g. `['123' => 'bar']` is converted to `[123 => 'bar']`. And the `array_merge()` function does not preserve numerical keys: `array_merge([], [123 => 'bar'])` is converted to `[0 => 'bar']`.","created_at":"2016-03-24T15:11:42Z","updated_at":"2016-03-25T19:29:39Z","closed_at":"2016-03-25T19:29:38Z","merged_at":null,"merge_commit_sha":"0fe245dda39db8f46ce643cfdb9db6da78a03f92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/12841/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/12841/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/12841/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/ce8d61c396e84fd97269ce944d06fba6871ab632","head":{"label":"maxwilms:perserve-numerical-keys","ref":"perserve-numerical-keys","sha":"ce8d61c396e84fd97269ce944d06fba6871ab632","user":{"login":"maxwilms","id":708742,"avatar_url":"https://avatars.githubusercontent.com/u/708742?v=3","gravatar_id":"","url":"https://api.github.com/users/maxwilms","html_url":"https://github.com/maxwilms","followers_url":"https://api.github.com/users/maxwilms/followers","following_url":"https://api.github.com/users/maxwilms/following{/other_user}","gists_url":"https://api.github.com/users/maxwilms/gists{/gist_id}","starred_url":"https://api.github.com/users/maxwilms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxwilms/subscriptions","organizations_url":"https://api.github.com/users/maxwilms/orgs","repos_url":"https://api.github.com/users/maxwilms/repos","events_url":"https://api.github.com/users/maxwilms/events{/privacy}","received_events_url":"https://api.github.com/users/maxwilms/received_events","type":"User","site_admin":false},"repo":{"id":54645390,"name":"framework","full_name":"maxwilms/framework","owner":{"login":"maxwilms","id":708742,"avatar_url":"https://avatars.githubusercontent.com/u/708742?v=3","gravatar_id":"","url":"https://api.github.com/users/maxwilms","html_url":"https://github.com/maxwilms","followers_url":"https://api.github.com/users/maxwilms/followers","following_url":"https://api.github.com/users/maxwilms/following{/other_user}","gists_url":"https://api.github.com/users/maxwilms/gists{/gist_id}","starred_url":"https://api.github.com/users/maxwilms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxwilms/subscriptions","organizations_url":"https://api.github.com/users/maxwilms/orgs","repos_url":"https://api.github.com/users/maxwilms/repos","events_url":"https://api.github.com/users/maxwilms/events{/privacy}","received_events_url":"https://api.github.com/users/maxwilms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxwilms/framework","description":"","fork":true,"url":"https://api.github.com/repos/maxwilms/framework","forks_url":"https://api.github.com/repos/maxwilms/framework/forks","keys_url":"https://api.github.com/repos/maxwilms/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxwilms/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxwilms/framework/teams","hooks_url":"https://api.github.com/repos/maxwilms/framework/hooks","issue_events_url":"https://api.github.com/repos/maxwilms/framework/issues/events{/number}","events_url":"https://api.github.com/repos/maxwilms/framework/events","assignees_url":"https://api.github.com/repos/maxwilms/framework/assignees{/user}","branches_url":"https://api.github.com/repos/maxwilms/framework/branches{/branch}","tags_url":"https://api.github.com/repos/maxwilms/framework/tags","blobs_url":"https://api.github.com/repos/maxwilms/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxwilms/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxwilms/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxwilms/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxwilms/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/maxwilms/framework/languages","stargazers_url":"https://api.github.com/repos/maxwilms/framework/stargazers","contributors_url":"https://api.github.com/repos/maxwilms/framework/contributors","subscribers_url":"https://api.github.com/repos/maxwilms/framework/subscribers","subscription_url":"https://api.github.com/repos/maxwilms/framework/subscription","commits_url":"https://api.github.com/repos/maxwilms/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxwilms/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxwilms/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxwilms/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxwilms/framework/contents/{+path}","compare_url":"https://api.github.com/repos/maxwilms/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxwilms/framework/merges","archive_url":"https://api.github.com/repos/maxwilms/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxwilms/framework/downloads","issues_url":"https://api.github.com/repos/maxwilms/framework/issues{/number}","pulls_url":"https://api.github.com/repos/maxwilms/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/maxwilms/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/maxwilms/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxwilms/framework/labels{/name}","releases_url":"https://api.github.com/repos/maxwilms/framework/releases{/id}","deployments_url":"https://api.github.com/repos/maxwilms/framework/deployments","created_at":"2016-03-24T13:50:46Z","updated_at":"2016-03-24T13:50:50Z","pushed_at":"2016-03-24T14:51:57Z","git_url":"git://github.com/maxwilms/framework.git","ssh_url":"git@github.com:maxwilms/framework.git","clone_url":"https://github.com/maxwilms/framework.git","svn_url":"https://github.com/maxwilms/framework","homepage":"http://laravel.com","size":22154,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:master","ref":"master","sha":"2e125f53bc6237dde0d10e5a3ec0fda7beaeac3c","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-03-25T18:38:20Z","pushed_at":"2016-03-25T19:25:09Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":36179,"stargazers_count":4989,"watchers_count":4989,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2900,"mirror_url":null,"open_issues_count":105,"forks":2900,"open_issues":105,"watchers":4989,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/12841"},"html":{"href":"https://github.com/laravel/framework/pull/12841"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/12841"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/12841/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/12841/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/12841/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/ce8d61c396e84fd97269ce944d06fba6871ab632"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":1,"changed_files":2}}