{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/syntactic-paths/pulls/comments/69614197","id":69614197,"diff_hunk":"@@ -51,54 +45,49 @@\n  */\n public final class Path implements Comparable<Path> {\n \n-    public static final Path ROOT_PATH = new Path(ImmutableList.<String>of(), true, true);\n+    public static final Path ROOT_PATH = new Path(new ArrayList<String>(), true, true);\n     public static final char SEPARATOR_CHAR = '/';\n     public static final String SEPARATOR = \"/\";\n     public static final String BACKWARDS_PATH = \"..\";\n \n-    private static final Splitter PATH_SPLITTER = Splitter.on(SEPARATOR_CHAR).omitEmptyStrings();\n-    static final Joiner PATH_JOINER = Joiner.on(SEPARATOR_CHAR);\n     private static final char[] ILLEGAL_CHARS = new char[] {0};\n-    private static final List<String> ILLEGAL_SEGMENTS = ImmutableList.of(\".\");\n-\n+    private static final List<String> ILLEGAL_SEGMENTS = new ArrayList<String>() {","path":"syntactic-paths/src/main/java/com/palantir/util/syntacticpath/Path.java","position":37,"original_position":37,"commit_id":"2519f39df11bed9af9ff6a0d628c1c8521cba3d8","original_commit_id":"2519f39df11bed9af9ff6a0d628c1c8521cba3d8","user":{"login":"punya","id":277514,"avatar_url":"https://avatars.githubusercontent.com/u/277514?v=3","gravatar_id":"","url":"https://api.github.com/users/punya","html_url":"https://github.com/punya","followers_url":"https://api.github.com/users/punya/followers","following_url":"https://api.github.com/users/punya/following{/other_user}","gists_url":"https://api.github.com/users/punya/gists{/gist_id}","starred_url":"https://api.github.com/users/punya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punya/subscriptions","organizations_url":"https://api.github.com/users/punya/orgs","repos_url":"https://api.github.com/users/punya/repos","events_url":"https://api.github.com/users/punya/events{/privacy}","received_events_url":"https://api.github.com/users/punya/received_events","type":"User","site_admin":false},"body":"Consider using `Arrays.asList` instead of subclassing.","created_at":"2016-07-05T18:30:45Z","updated_at":"2016-07-05T18:30:45Z","html_url":"https://github.com/palantir/syntactic-paths/pull/2#discussion_r69614197","pull_request_url":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/palantir/syntactic-paths/pulls/comments/69614197"},"html":{"href":"https://github.com/palantir/syntactic-paths/pull/2#discussion_r69614197"},"pull_request":{"href":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2","id":76098666,"html_url":"https://github.com/palantir/syntactic-paths/pull/2","diff_url":"https://github.com/palantir/syntactic-paths/pull/2.diff","patch_url":"https://github.com/palantir/syntactic-paths/pull/2.patch","issue_url":"https://api.github.com/repos/palantir/syntactic-paths/issues/2","number":2,"state":"open","locked":false,"title":"Pull out Guava and Apache dependencies","user":{"login":"leeavital","id":1482532,"avatar_url":"https://avatars.githubusercontent.com/u/1482532?v=3","gravatar_id":"","url":"https://api.github.com/users/leeavital","html_url":"https://github.com/leeavital","followers_url":"https://api.github.com/users/leeavital/followers","following_url":"https://api.github.com/users/leeavital/following{/other_user}","gists_url":"https://api.github.com/users/leeavital/gists{/gist_id}","starred_url":"https://api.github.com/users/leeavital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeavital/subscriptions","organizations_url":"https://api.github.com/users/leeavital/orgs","repos_url":"https://api.github.com/users/leeavital/repos","events_url":"https://api.github.com/users/leeavital/events{/privacy}","received_events_url":"https://api.github.com/users/leeavital/received_events","type":"User","site_admin":false},"body":"This is the first step to publishing syntactic-paths as part of an API jar.\r\n","created_at":"2016-07-03T21:15:08Z","updated_at":"2016-07-05T18:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab582474743cb9422d6c5e49b4733f76df27cb91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2/commits","review_comments_url":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2/comments","review_comment_url":"https://api.github.com/repos/palantir/syntactic-paths/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/syntactic-paths/issues/2/comments","statuses_url":"https://api.github.com/repos/palantir/syntactic-paths/statuses/2519f39df11bed9af9ff6a0d628c1c8521cba3d8","head":{"label":"leeavital:la/no_guava","ref":"la/no_guava","sha":"2519f39df11bed9af9ff6a0d628c1c8521cba3d8","user":{"login":"leeavital","id":1482532,"avatar_url":"https://avatars.githubusercontent.com/u/1482532?v=3","gravatar_id":"","url":"https://api.github.com/users/leeavital","html_url":"https://github.com/leeavital","followers_url":"https://api.github.com/users/leeavital/followers","following_url":"https://api.github.com/users/leeavital/following{/other_user}","gists_url":"https://api.github.com/users/leeavital/gists{/gist_id}","starred_url":"https://api.github.com/users/leeavital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeavital/subscriptions","organizations_url":"https://api.github.com/users/leeavital/orgs","repos_url":"https://api.github.com/users/leeavital/repos","events_url":"https://api.github.com/users/leeavital/events{/privacy}","received_events_url":"https://api.github.com/users/leeavital/received_events","type":"User","site_admin":false},"repo":{"id":62515225,"name":"syntactic-paths","full_name":"leeavital/syntactic-paths","owner":{"login":"leeavital","id":1482532,"avatar_url":"https://avatars.githubusercontent.com/u/1482532?v=3","gravatar_id":"","url":"https://api.github.com/users/leeavital","html_url":"https://github.com/leeavital","followers_url":"https://api.github.com/users/leeavital/followers","following_url":"https://api.github.com/users/leeavital/following{/other_user}","gists_url":"https://api.github.com/users/leeavital/gists{/gist_id}","starred_url":"https://api.github.com/users/leeavital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeavital/subscriptions","organizations_url":"https://api.github.com/users/leeavital/orgs","repos_url":"https://api.github.com/users/leeavital/repos","events_url":"https://api.github.com/users/leeavital/events{/privacy}","received_events_url":"https://api.github.com/users/leeavital/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leeavital/syntactic-paths","description":"A simple library for manipulating Unix-style paths in an OS-independent way","fork":true,"url":"https://api.github.com/repos/leeavital/syntactic-paths","forks_url":"https://api.github.com/repos/leeavital/syntactic-paths/forks","keys_url":"https://api.github.com/repos/leeavital/syntactic-paths/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leeavital/syntactic-paths/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leeavital/syntactic-paths/teams","hooks_url":"https://api.github.com/repos/leeavital/syntactic-paths/hooks","issue_events_url":"https://api.github.com/repos/leeavital/syntactic-paths/issues/events{/number}","events_url":"https://api.github.com/repos/leeavital/syntactic-paths/events","assignees_url":"https://api.github.com/repos/leeavital/syntactic-paths/assignees{/user}","branches_url":"https://api.github.com/repos/leeavital/syntactic-paths/branches{/branch}","tags_url":"https://api.github.com/repos/leeavital/syntactic-paths/tags","blobs_url":"https://api.github.com/repos/leeavital/syntactic-paths/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leeavital/syntactic-paths/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leeavital/syntactic-paths/git/refs{/sha}","trees_url":"https://api.github.com/repos/leeavital/syntactic-paths/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leeavital/syntactic-paths/statuses/{sha}","languages_url":"https://api.github.com/repos/leeavital/syntactic-paths/languages","stargazers_url":"https://api.github.com/repos/leeavital/syntactic-paths/stargazers","contributors_url":"https://api.github.com/repos/leeavital/syntactic-paths/contributors","subscribers_url":"https://api.github.com/repos/leeavital/syntactic-paths/subscribers","subscription_url":"https://api.github.com/repos/leeavital/syntactic-paths/subscription","commits_url":"https://api.github.com/repos/leeavital/syntactic-paths/commits{/sha}","git_commits_url":"https://api.github.com/repos/leeavital/syntactic-paths/git/commits{/sha}","comments_url":"https://api.github.com/repos/leeavital/syntactic-paths/comments{/number}","issue_comment_url":"https://api.github.com/repos/leeavital/syntactic-paths/issues/comments{/number}","contents_url":"https://api.github.com/repos/leeavital/syntactic-paths/contents/{+path}","compare_url":"https://api.github.com/repos/leeavital/syntactic-paths/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leeavital/syntactic-paths/merges","archive_url":"https://api.github.com/repos/leeavital/syntactic-paths/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leeavital/syntactic-paths/downloads","issues_url":"https://api.github.com/repos/leeavital/syntactic-paths/issues{/number}","pulls_url":"https://api.github.com/repos/leeavital/syntactic-paths/pulls{/number}","milestones_url":"https://api.github.com/repos/leeavital/syntactic-paths/milestones{/number}","notifications_url":"https://api.github.com/repos/leeavital/syntactic-paths/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leeavital/syntactic-paths/labels{/name}","releases_url":"https://api.github.com/repos/leeavital/syntactic-paths/releases{/id}","deployments_url":"https://api.github.com/repos/leeavital/syntactic-paths/deployments","created_at":"2016-07-03T21:07:21Z","updated_at":"2016-07-03T21:07:22Z","pushed_at":"2016-07-03T21:12:56Z","git_url":"git://github.com/leeavital/syntactic-paths.git","ssh_url":"git@github.com:leeavital/syntactic-paths.git","clone_url":"https://github.com/leeavital/syntactic-paths.git","svn_url":"https://github.com/leeavital/syntactic-paths","homepage":null,"size":95,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"fb7915cd71be94d227b383f8c9e64e2d90eeaf2f","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":48093312,"name":"syntactic-paths","full_name":"palantir/syntactic-paths","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/syntactic-paths","description":"A simple library for manipulating Unix-style paths in an OS-independent way","fork":false,"url":"https://api.github.com/repos/palantir/syntactic-paths","forks_url":"https://api.github.com/repos/palantir/syntactic-paths/forks","keys_url":"https://api.github.com/repos/palantir/syntactic-paths/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/syntactic-paths/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/syntactic-paths/teams","hooks_url":"https://api.github.com/repos/palantir/syntactic-paths/hooks","issue_events_url":"https://api.github.com/repos/palantir/syntactic-paths/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/syntactic-paths/events","assignees_url":"https://api.github.com/repos/palantir/syntactic-paths/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/syntactic-paths/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/syntactic-paths/tags","blobs_url":"https://api.github.com/repos/palantir/syntactic-paths/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/syntactic-paths/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/syntactic-paths/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/syntactic-paths/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/syntactic-paths/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/syntactic-paths/languages","stargazers_url":"https://api.github.com/repos/palantir/syntactic-paths/stargazers","contributors_url":"https://api.github.com/repos/palantir/syntactic-paths/contributors","subscribers_url":"https://api.github.com/repos/palantir/syntactic-paths/subscribers","subscription_url":"https://api.github.com/repos/palantir/syntactic-paths/subscription","commits_url":"https://api.github.com/repos/palantir/syntactic-paths/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/syntactic-paths/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/syntactic-paths/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/syntactic-paths/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/syntactic-paths/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/syntactic-paths/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/syntactic-paths/merges","archive_url":"https://api.github.com/repos/palantir/syntactic-paths/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/syntactic-paths/downloads","issues_url":"https://api.github.com/repos/palantir/syntactic-paths/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/syntactic-paths/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/syntactic-paths/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/syntactic-paths/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/syntactic-paths/labels{/name}","releases_url":"https://api.github.com/repos/palantir/syntactic-paths/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/syntactic-paths/deployments","created_at":"2015-12-16T06:58:11Z","updated_at":"2016-02-24T23:43:33Z","pushed_at":"2016-07-03T21:15:08Z","git_url":"git://github.com/palantir/syntactic-paths.git","ssh_url":"git@github.com:palantir/syntactic-paths.git","clone_url":"https://github.com/palantir/syntactic-paths.git","svn_url":"https://github.com/palantir/syntactic-paths","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2"},"html":{"href":"https://github.com/palantir/syntactic-paths/pull/2"},"issue":{"href":"https://api.github.com/repos/palantir/syntactic-paths/issues/2"},"comments":{"href":"https://api.github.com/repos/palantir/syntactic-paths/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/syntactic-paths/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/syntactic-paths/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/syntactic-paths/statuses/2519f39df11bed9af9ff6a0d628c1c8521cba3d8"}}}}
{"actor":{"display_login":"punya"}}