{"action":"created","issue":{"url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/17","repository_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps","labels_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/17/comments","events_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/17/events","html_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/17","id":158767366,"number":17,"title":"#1755: Ability to configure forward-url on click of Save on Registration visit page","user":{"login":"mogoodrich","id":1163015,"avatar_url":"https://avatars.githubusercontent.com/u/1163015?v=3","gravatar_id":"","url":"https://api.github.com/users/mogoodrich","html_url":"https://github.com/mogoodrich","followers_url":"https://api.github.com/users/mogoodrich/followers","following_url":"https://api.github.com/users/mogoodrich/following{/other_user}","gists_url":"https://api.github.com/users/mogoodrich/gists{/gist_id}","starred_url":"https://api.github.com/users/mogoodrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogoodrich/subscriptions","organizations_url":"https://api.github.com/users/mogoodrich/orgs","repos_url":"https://api.github.com/users/mogoodrich/repos","events_url":"https://api.github.com/users/mogoodrich/events{/privacy}","received_events_url":"https://api.github.com/users/mogoodrich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-06T20:28:51Z","updated_at":"2016-06-08T09:21:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/pulls/17","html_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/17","diff_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/17.diff","patch_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/17.patch"},"body":"\r\nSee:\r\n\r\nhttps://bahmni.mingle.thoughtworks.com/projects/bahmni_emr/cards/1755\r\n\r\nand\r\n\r\n https://talk.openmrs.org/t/save-visit-details-and-forward-url/6340/3\r\n\r\nI've added a new  registration app config parameter \"afterVisitSaveTransitionToState\" where you can specify which state to transition to after saving.  If the parameter is not specified, the current behavior (stay on same page) is maintained."},"comment":{"url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/comments/224535501","html_url":"https://github.com/Bahmni/openmrs-module-bahmniapps/pull/17#issuecomment-224535501","issue_url":"https://api.github.com/repos/Bahmni/openmrs-module-bahmniapps/issues/17","id":224535501,"user":{"login":"sravanthi17","id":8520606,"avatar_url":"https://avatars.githubusercontent.com/u/8520606?v=3","gravatar_id":"","url":"https://api.github.com/users/sravanthi17","html_url":"https://github.com/sravanthi17","followers_url":"https://api.github.com/users/sravanthi17/followers","following_url":"https://api.github.com/users/sravanthi17/following{/other_user}","gists_url":"https://api.github.com/users/sravanthi17/gists{/gist_id}","starred_url":"https://api.github.com/users/sravanthi17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sravanthi17/subscriptions","organizations_url":"https://api.github.com/users/sravanthi17/orgs","repos_url":"https://api.github.com/users/sravanthi17/repos","events_url":"https://api.github.com/users/sravanthi17/events{/privacy}","received_events_url":"https://api.github.com/users/sravanthi17/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T09:21:41Z","updated_at":"2016-06-08T09:21:41Z","body":"The approach you have taken is to always accept \"state\" as a value of \"afterVisitSaveTransitionToState\"\r\n\r\nIn this case,\r\n\r\n1) We expect the implementer to have good knowledge about angular states. We don't really want to expose our states.\r\n\r\n2) The states one can configure are always limited with in the registration app.\r\n\r\nFor example, the implementer want to navigate to patient dashboard which is not possible in the approach followed.\r\n\r\nOtherwise i would suggest asking the implementer to provide **Transition url** or **Forward url** (url to navigate to after save). So we don't need to depend on the states.\r\nAccepting the forward url from the implementer is already followed in Bahmni.\r\n\r\nOne example is https://github.com/Bahmni/openmrs-module-bahmniapps/blob/master/ui/app/registration/directives/patientAction.js#L80\r\n\r\nAlso the configuration should be from \"**extension.json**\" to be consistent across."}}
{"actor":{"display_login":"sravanthi17"}}