{"action":"created","issue":{"url":"https://api.github.com/repos/OPM/opm-output/issues/30","repository_url":"https://api.github.com/repos/OPM/opm-output","labels_url":"https://api.github.com/repos/OPM/opm-output/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/OPM/opm-output/issues/30/comments","events_url":"https://api.github.com/repos/OPM/opm-output/issues/30/events","html_url":"https://github.com/OPM/opm-output/pull/30","id":154443132,"number":30,"title":"Breaking opm-core dependency in opm-output; new summary implementation","user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-12T09:58:00Z","updated_at":"2016-06-07T08:16:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OPM/opm-output/pulls/30","html_url":"https://github.com/OPM/opm-output/pull/30","diff_url":"https://github.com/OPM/opm-output/pull/30.diff","patch_url":"https://github.com/OPM/opm-output/pull/30.patch"},"body":"Hi,\r\n\r\nLet me prefix this patch set which spans several repos by stating the goals:\r\n* We want user-configurable output of summary files etc.\r\n* It would be nice to be able to write eclipse-compatible files outside of the simulator\r\n* We currently have an inverted dependency (output now depends on core, should be the other way around)\r\n* The code itself was rather worn and could use some maintenance. Several features were unused.\r\n\r\nWith that out of the way, a short synopsis of the major changes:\r\n* The old summary support has been ripped out and replaced with the new (not quite complete) implementation.\r\n* The multiplexing output writer has been removed as it was unused. If there is a need for a similar feature I'll take a fresh approach to this.\r\n* The `OutputWriter` interface has gotten rewritten and does no longer depend on `core` data types.\r\n* A (simple) format for Cell data, called `Solution`, is the information exchange specification required for output operations. Clients are expected to properly populate it.\r\n* I have introduced a temporary utility file in core which assists in the transition. The features of that file are largely naïve and intended as a starting point for internal-to-output data conversion.\r\n* WellState has gotten a virtual method `report` that populates a `data::Wells` structure.\r\n* Internal helpers have been rewritten\r\n* VAG grid support has been removed (completely unused).\r\n* writeVTKdata is **disabled**, other VTK output should work as before.\r\n* EclipseWriter no longer inherits from OutputWriter.\r\n\r\nThe PR has a lot of code, and changes ripples through both core and simulators; however, I will make sure that with all three HEADs it will compile and tests will run. I'm trying to keep this set a refactoring first of all, so behavioural changes will come later.\r\n\r\nI would appreciate if most discussion regarding approach, interfaces etc. happens in this PR, and only direct code comments in the other PRs.\r\n\r\nEdit by @joakim-hove:\r\n\r\nopm-common: https://github.com/OPM/opm-common/pull/121\r\nopm-core: https://github.com/OPM/opm-core/pull/1016\r\nopm-simulators: https://github.com/OPM/opm-simulators/pull/688"},"comment":{"url":"https://api.github.com/repos/OPM/opm-output/issues/comments/224211384","html_url":"https://github.com/OPM/opm-output/pull/30#issuecomment-224211384","issue_url":"https://api.github.com/repos/OPM/opm-output/issues/30","id":224211384,"user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T08:16:37Z","updated_at":"2016-06-07T08:16:37Z","body":"![norne-snap-output](https://cloud.githubusercontent.com/assets/8667957/15850550/e7dc27c6-2c98-11e6-8a68-9e28057e4246.png)\r\n"}}
{"actor":{"display_login":"jokva"}}