{"action":"closed","number":235,"pull_request":{"url":"https://api.github.com/repos/OCA/maintainer-tools/pulls/235","id":91823704,"html_url":"https://github.com/OCA/maintainer-tools/pull/235","diff_url":"https://github.com/OCA/maintainer-tools/pull/235.diff","patch_url":"https://github.com/OCA/maintainer-tools/pull/235.patch","issue_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/235","number":235,"state":"closed","locked":false,"title":"[REF] CONTRIBUTING: Grouping external dependencies exception","user":{"login":"moylop260","id":6644187,"avatar_url":"https://avatars.githubusercontent.com/u/6644187?v=3","gravatar_id":"","url":"https://api.github.com/users/moylop260","html_url":"https://github.com/moylop260","followers_url":"https://api.github.com/users/moylop260/followers","following_url":"https://api.github.com/users/moylop260/following{/other_user}","gists_url":"https://api.github.com/users/moylop260/gists{/gist_id}","starred_url":"https://api.github.com/users/moylop260/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moylop260/subscriptions","organizations_url":"https://api.github.com/users/moylop260/orgs","repos_url":"https://api.github.com/users/moylop260/repos","events_url":"https://api.github.com/users/moylop260/events{/privacy}","received_events_url":"https://api.github.com/users/moylop260/received_events","type":"User","site_admin":false},"body":"Currently if we have many external dependencies we are using:\r\n\r\n```python\r\ntry:\r\n     import M2Crypto\r\nexcept ImportError:\r\n    _logger.debug('Can not import M2Crypto.')\r\ntry:\r\n     from OpenSSL import crypto\r\nexcept ImportError:\r\n    _logger.debug('Can not import OpenSSL.')\r\n```\r\n\r\nBut we could use a reduced way:\r\n```python\r\ntry:\r\n     import M2Crypto\r\n     from OpenSSL import crypto\r\nexcept ImportError as err:\r\n    _logger.debug(err)\r\n```\r\n\r\nCurrently we have a logger debug just of external dependencies of python libraries but we don't have a logger debug for external dependencies of binaries, using the same reduced way:\r\n\r\n```python\r\ntry:\r\n     import M2Crypto\r\n     from OpenSSL import crypto\r\n     DIFF3_BIN = tools.find_in_path('diff3')\r\nexcept (ImportError, IOError) as err:\r\n    _logger.debug(err)\r\n```","created_at":"2016-11-01T17:11:57Z","updated_at":"2016-11-11T17:45:04Z","closed_at":"2016-11-11T17:45:04Z","merged_at":"2016-11-11T17:45:04Z","merge_commit_sha":"cec2a73c65d18bcd76a41f4113eb714d18d2df66","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/maintainer-tools/pulls/235/commits","review_comments_url":"https://api.github.com/repos/OCA/maintainer-tools/pulls/235/comments","review_comment_url":"https://api.github.com/repos/OCA/maintainer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/235/comments","statuses_url":"https://api.github.com/repos/OCA/maintainer-tools/statuses/f86bb1329f2dad2eb5068a8b60ea8ddd74c81704","head":{"label":"vauxoo-dev:master-oca-import-error-moy","ref":"master-oca-import-error-moy","sha":"f86bb1329f2dad2eb5068a8b60ea8ddd74c81704","user":{"login":"vauxoo-dev","id":7662790,"avatar_url":"https://avatars.githubusercontent.com/u/7662790?v=3","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":26603185,"name":"maintainer-tools","full_name":"vauxoo-dev/maintainer-tools","owner":{"login":"vauxoo-dev","id":7662790,"avatar_url":"https://avatars.githubusercontent.com/u/7662790?v=3","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vauxoo-dev/maintainer-tools","description":"Mantainers Tools for OCA members which evaluate and mantain repositories.","fork":true,"url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools","forks_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/forks","keys_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/teams","hooks_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/hooks","issue_events_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/events","assignees_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/tags","blobs_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/languages","stargazers_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/stargazers","contributors_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/contributors","subscribers_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/subscribers","subscription_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/subscription","commits_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/merges","archive_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/downloads","issues_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/labels{/name}","releases_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/vauxoo-dev/maintainer-tools/deployments","created_at":"2014-11-13T19:10:05Z","updated_at":"2015-07-16T17:07:32Z","pushed_at":"2016-11-01T17:07:59Z","git_url":"git://github.com/vauxoo-dev/maintainer-tools.git","ssh_url":"git@github.com:vauxoo-dev/maintainer-tools.git","clone_url":"https://github.com/vauxoo-dev/maintainer-tools.git","svn_url":"https://github.com/vauxoo-dev/maintainer-tools","homepage":"http://community.odoo.com","size":563,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OCA:master","ref":"master","sha":"94e73614e8979de7df7162b592e1103d01f8e454","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20999008,"name":"maintainer-tools","full_name":"OCA/maintainer-tools","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/maintainer-tools","description":"Odoo Maintainers Tools for OCA members which evaluate and maintain repositories.","fork":false,"url":"https://api.github.com/repos/OCA/maintainer-tools","forks_url":"https://api.github.com/repos/OCA/maintainer-tools/forks","keys_url":"https://api.github.com/repos/OCA/maintainer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/maintainer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/maintainer-tools/teams","hooks_url":"https://api.github.com/repos/OCA/maintainer-tools/hooks","issue_events_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/maintainer-tools/events","assignees_url":"https://api.github.com/repos/OCA/maintainer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/maintainer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/maintainer-tools/tags","blobs_url":"https://api.github.com/repos/OCA/maintainer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/maintainer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/maintainer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/maintainer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/maintainer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/maintainer-tools/languages","stargazers_url":"https://api.github.com/repos/OCA/maintainer-tools/stargazers","contributors_url":"https://api.github.com/repos/OCA/maintainer-tools/contributors","subscribers_url":"https://api.github.com/repos/OCA/maintainer-tools/subscribers","subscription_url":"https://api.github.com/repos/OCA/maintainer-tools/subscription","commits_url":"https://api.github.com/repos/OCA/maintainer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/maintainer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/maintainer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/maintainer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/maintainer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/maintainer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/maintainer-tools/merges","archive_url":"https://api.github.com/repos/OCA/maintainer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/maintainer-tools/downloads","issues_url":"https://api.github.com/repos/OCA/maintainer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/maintainer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/maintainer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/maintainer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/maintainer-tools/labels{/name}","releases_url":"https://api.github.com/repos/OCA/maintainer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/maintainer-tools/deployments","created_at":"2014-06-19T12:10:40Z","updated_at":"2016-11-10T03:17:12Z","pushed_at":"2016-11-11T17:45:04Z","git_url":"git://github.com/OCA/maintainer-tools.git","ssh_url":"git@github.com:OCA/maintainer-tools.git","clone_url":"https://github.com/OCA/maintainer-tools.git","svn_url":"https://github.com/OCA/maintainer-tools","homepage":"https://odoo-community.org/project/46","size":814,"stargazers_count":42,"watchers_count":42,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":19,"forks":153,"open_issues":19,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/maintainer-tools/pulls/235"},"html":{"href":"https://github.com/OCA/maintainer-tools/pull/235"},"issue":{"href":"https://api.github.com/repos/OCA/maintainer-tools/issues/235"},"comments":{"href":"https://api.github.com/repos/OCA/maintainer-tools/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/maintainer-tools/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/maintainer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/maintainer-tools/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/maintainer-tools/statuses/f86bb1329f2dad2eb5068a8b60ea8ddd74c81704"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"pedrobaeza"}}