{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/91309891","pull_request_review_id":11817803,"id":91309891,"diff_hunk":"@@ -0,0 +1,249 @@\n+import React, {Component} from 'react';\n+import {Tooltip} from 'reactjs-components';\n+\n+import {FormReducer as ContainerReducer} from '../../reducers/serviceForm/Container';\n+import {FormReducer as ContainersReducer} from '../../reducers/serviceForm/Containers';\n+import AdvancedSection from '../../../../../../src/js/components/form/AdvancedSection';\n+import AdvancedSectionContent from '../../../../../../src/js/components/form/AdvancedSectionContent';\n+import AdvancedSectionLabel from '../../../../../../src/js/components/form/AdvancedSectionLabel';\n+import DeleteRowButton from '../../../../../../src/js/components/form/DeleteRowButton';\n+import FieldError from '../../../../../../src/js/components/form/FieldError';\n+import FieldHelp from '../../../../../../src/js/components/form/FieldHelp';\n+import FieldInput from '../../../../../../src/js/components/form/FieldInput';\n+import FieldLabel from '../../../../../../src/js/components/form/FieldLabel';\n+import FieldTextarea from '../../../../../../src/js/components/form/FieldTextarea';\n+import FormGroup from '../../../../../../src/js/components/form/FormGroup';\n+import MetadataStore from '../../../../../../src/js/stores/MetadataStore';\n+import Icon from '../../../../../../src/js/components/Icon';\n+import {findNestedPropertyInObject} from '../../../../../../src/js/utils/Util';\n+\n+class PodContainerServiceFormSection extends Component {\n+  getAdvancedSettings(data = {}, errors = {}) {\n+    let {path} = this.props;\n+\n+    let diskErrors = findNestedPropertyInObject(errors, `${path}.resources.disk`);\n+\n+    let artifacts = findNestedPropertyInObject(data, `${path}.artifacts`) || [];\n+\n+    artifacts = artifacts.map((item, index) => {\n+      let artifactError =\n+        findNestedPropertyInObject(errors, `${path}.artifacts.${index}`);\n+      let label = null;\n+      if (index === 0) {\n+        label = <FieldLabel>Artifact URI</FieldLabel>;\n+      }\n+      return (\n+          <div className=\"flex row\">\n+            <FormGroup className=\"column-10\" showError={Boolean(artifactError)}>\n+              {label}\n+              <FieldInput\n+                  name={`${path}.artifacts.${index}`}\n+                  placeholder=\"http://\"\n+                  value={item} />\n+              <FieldError>{artifactError}</FieldError>\n+            </FormGroup>\n+            <FormGroup className=\"flex flex-item-align-end column-2\">\n+              <DeleteRowButton\n+                onClick={this.props.onRemoveItem.bind(this,\n+                  {value: index, path: `${path}.artifacts`})}/>\n+            </FormGroup>\n+          </div>\n+      );\n+    });\n+\n+    return (\n+      <AdvancedSectionContent>\n+        <div className=\"flex row\">\n+          <FormGroup className=\"column-4\" showError={Boolean(diskErrors)}>\n+            <FieldLabel>Disk (MiB)</FieldLabel>\n+            <FieldInput\n+              name={`${path}.resources.disk`}\n+              type=\"number\"\n+              value={findNestedPropertyInObject(data, `${path}.resources.disk`)} />\n+            <FieldError>{diskErrors}</FieldError>\n+          </FormGroup>\n+        </div>\n+        {artifacts}\n+\n+        <div>\n+          <a className=\"button button-primary-link button-flush\"\n+            onClick={this.props.onAddItem.bind(this, {value: 0, path: `${path}.artifacts`})}>\n+            Add Artifact","path":"plugins/services/src/js/components/forms/PodContainerServiceFormSection.js","position":71,"original_position":71,"commit_id":"4d031c278fc9257eee6bed92e248f3686bc5a481","original_commit_id":"4d031c278fc9257eee6bed92e248f3686bc5a481","user":{"login":"Poltergeist","id":156010,"avatar_url":"https://avatars.githubusercontent.com/u/156010?v=3","gravatar_id":"","url":"https://api.github.com/users/Poltergeist","html_url":"https://github.com/Poltergeist","followers_url":"https://api.github.com/users/Poltergeist/followers","following_url":"https://api.github.com/users/Poltergeist/following{/other_user}","gists_url":"https://api.github.com/users/Poltergeist/gists{/gist_id}","starred_url":"https://api.github.com/users/Poltergeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poltergeist/subscriptions","organizations_url":"https://api.github.com/users/Poltergeist/orgs","repos_url":"https://api.github.com/users/Poltergeist/repos","events_url":"https://api.github.com/users/Poltergeist/events{/privacy}","received_events_url":"https://api.github.com/users/Poltergeist/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2016-12-07T15:01:58Z","updated_at":"2016-12-07T15:01:58Z","html_url":"https://github.com/dcos/dcos-ui/pull/1502#discussion_r91309891","pull_request_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/91309891"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/1502#discussion_r91309891"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502","id":96718376,"html_url":"https://github.com/dcos/dcos-ui/pull/1502","diff_url":"https://github.com/dcos/dcos-ui/pull/1502.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/1502.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1502","number":1502,"state":"open","locked":false,"title":"DCOS-10983: Add multiple containers to the service create form","user":{"login":"Poltergeist","id":156010,"avatar_url":"https://avatars.githubusercontent.com/u/156010?v=3","gravatar_id":"","url":"https://api.github.com/users/Poltergeist","html_url":"https://github.com/Poltergeist","followers_url":"https://api.github.com/users/Poltergeist/followers","following_url":"https://api.github.com/users/Poltergeist/following{/other_user}","gists_url":"https://api.github.com/users/Poltergeist/gists{/gist_id}","starred_url":"https://api.github.com/users/Poltergeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poltergeist/subscriptions","organizations_url":"https://api.github.com/users/Poltergeist/orgs","repos_url":"https://api.github.com/users/Poltergeist/repos","events_url":"https://api.github.com/users/Poltergeist/events{/privacy}","received_events_url":"https://api.github.com/users/Poltergeist/received_events","type":"User","site_admin":false},"body":"As requested by @orlandohohmeier here is a gif:\r\n![giphy](https://cloud.githubusercontent.com/assets/156010/20926246/993c511a-bbbb-11e6-9a41-ffdcd8460c20.gif)\r\n\r\nand here is a screen capture:\r\n\r\n![pods-multi-container mov](https://cloud.githubusercontent.com/assets/156010/20926731/2e7dd1ac-bbbe-11e6-8dd1-0769ae7a168e.gif)\r\n\r\n\r\n","created_at":"2016-12-06T12:52:07Z","updated_at":"2016-12-07T15:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d7ea7dd94d2c9be407155bd6d1431f6fcb68f28","assignee":{"login":"nLight","id":186223,"avatar_url":"https://avatars.githubusercontent.com/u/186223?v=3","gravatar_id":"","url":"https://api.github.com/users/nLight","html_url":"https://github.com/nLight","followers_url":"https://api.github.com/users/nLight/followers","following_url":"https://api.github.com/users/nLight/following{/other_user}","gists_url":"https://api.github.com/users/nLight/gists{/gist_id}","starred_url":"https://api.github.com/users/nLight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nLight/subscriptions","organizations_url":"https://api.github.com/users/nLight/orgs","repos_url":"https://api.github.com/users/nLight/repos","events_url":"https://api.github.com/users/nLight/events{/privacy}","received_events_url":"https://api.github.com/users/nLight/received_events","type":"User","site_admin":false},"assignees":[{"login":"nLight","id":186223,"avatar_url":"https://avatars.githubusercontent.com/u/186223?v=3","gravatar_id":"","url":"https://api.github.com/users/nLight","html_url":"https://github.com/nLight","followers_url":"https://api.github.com/users/nLight/followers","following_url":"https://api.github.com/users/nLight/following{/other_user}","gists_url":"https://api.github.com/users/nLight/gists{/gist_id}","starred_url":"https://api.github.com/users/nLight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nLight/subscriptions","organizations_url":"https://api.github.com/users/nLight/orgs","repos_url":"https://api.github.com/users/nLight/repos","events_url":"https://api.github.com/users/nLight/events{/privacy}","received_events_url":"https://api.github.com/users/nLight/received_events","type":"User","site_admin":false},{"login":"MatApple","id":465022,"avatar_url":"https://avatars.githubusercontent.com/u/465022?v=3","gravatar_id":"","url":"https://api.github.com/users/MatApple","html_url":"https://github.com/MatApple","followers_url":"https://api.github.com/users/MatApple/followers","following_url":"https://api.github.com/users/MatApple/following{/other_user}","gists_url":"https://api.github.com/users/MatApple/gists{/gist_id}","starred_url":"https://api.github.com/users/MatApple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatApple/subscriptions","organizations_url":"https://api.github.com/users/MatApple/orgs","repos_url":"https://api.github.com/users/MatApple/repos","events_url":"https://api.github.com/users/MatApple/events{/privacy}","received_events_url":"https://api.github.com/users/MatApple/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/1502/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/4d031c278fc9257eee6bed92e248f3686bc5a481","head":{"label":"dcos:ph/feature/DCOS-10983-service-create-multiple-containers","ref":"ph/feature/DCOS-10983-service-create-multiple-containers","sha":"4d031c278fc9257eee6bed92e248f3686bc5a481","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2016-12-06T06:47:45Z","pushed_at":"2016-12-07T15:01:39Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":null,"size":24599,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":22,"forks":32,"open_issues":22,"watchers":112,"default_branch":"master"}},"base":{"label":"dcos:feature/multiple-container-form","ref":"feature/multiple-container-form","sha":"053ce35df43bfc7119ae111126e4c32ea09f1173","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"name":"dcos-ui","full_name":"dcos/dcos-ui","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2016-12-06T06:47:45Z","pushed_at":"2016-12-07T15:01:39Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":null,"size":24599,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":22,"forks":32,"open_issues":22,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/1502"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/1502"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/1502/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/1502/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/4d031c278fc9257eee6bed92e248f3686bc5a481"}}}}
{"actor":{"display_login":"Poltergeist"}}