{"action":"created","comment":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/90034370","pull_request_review_id":10559984,"id":90034370,"diff_hunk":"@@ -146,64 +143,66 @@ class AccumuloDataStore(val connector: Connector, override val config: AccumuloD\n     import SimpleFeatureTypes.Configs.{ENABLED_INDEX_OPTS, ENABLED_INDICES}\n     import SimpleFeatureTypes.InternalConfigs.{INDEX_VERSIONS, SCHEMA_VERSION_KEY}\n \n-    var sft = super.getSchema(typeName)\n+    val escapedTypeName = typeName.replace(\"~\", ESCAPE)","path":"geomesa-accumulo/geomesa-accumulo-datastore/src/main/scala/org/locationtech/geomesa/accumulo/data/AccumuloDataStore.scala","position":24,"original_position":24,"commit_id":"1ea7722e76801ae51de980d7e34fec0e7602318e","original_commit_id":"1ea7722e76801ae51de980d7e34fec0e7602318e","user":{"login":"cfkelly","id":12864740,"avatar_url":"https://avatars.githubusercontent.com/u/12864740?v=3","gravatar_id":"","url":"https://api.github.com/users/cfkelly","html_url":"https://github.com/cfkelly","followers_url":"https://api.github.com/users/cfkelly/followers","following_url":"https://api.github.com/users/cfkelly/following{/other_user}","gists_url":"https://api.github.com/users/cfkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/cfkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfkelly/subscriptions","organizations_url":"https://api.github.com/users/cfkelly/orgs","repos_url":"https://api.github.com/users/cfkelly/repos","events_url":"https://api.github.com/users/cfkelly/events{/privacy}","received_events_url":"https://api.github.com/users/cfkelly/received_events","type":"User","site_admin":false},"body":"Yeah. After taking a better look at the metadata implementation, that does seem like the better place to handle the tildes.","created_at":"2016-11-29T15:38:39Z","updated_at":"2016-11-29T15:38:39Z","html_url":"https://github.com/locationtech/geomesa/pull/1242#discussion_r90034370","pull_request_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1242","_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/90034370"},"html":{"href":"https://github.com/locationtech/geomesa/pull/1242#discussion_r90034370"},"pull_request":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1242"}}},"pull_request":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/1242","id":95571069,"html_url":"https://github.com/locationtech/geomesa/pull/1242","diff_url":"https://github.com/locationtech/geomesa/pull/1242.diff","patch_url":"https://github.com/locationtech/geomesa/pull/1242.patch","issue_url":"https://api.github.com/repos/locationtech/geomesa/issues/1242","number":1242,"state":"open","locked":false,"title":"GEOMESA-1322 Handle unsupported tilde in feature name","user":{"login":"cfkelly","id":12864740,"avatar_url":"https://avatars.githubusercontent.com/u/12864740?v=3","gravatar_id":"","url":"https://api.github.com/users/cfkelly","html_url":"https://github.com/cfkelly","followers_url":"https://api.github.com/users/cfkelly/followers","following_url":"https://api.github.com/users/cfkelly/following{/other_user}","gists_url":"https://api.github.com/users/cfkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/cfkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfkelly/subscriptions","organizations_url":"https://api.github.com/users/cfkelly/orgs","repos_url":"https://api.github.com/users/cfkelly/repos","events_url":"https://api.github.com/users/cfkelly/events{/privacy}","received_events_url":"https://api.github.com/users/cfkelly/received_events","type":"User","site_admin":false},"body":"* Escape tilde(s) in feature name with null character per Andrew Hulbert's suggestion\r\n\r\nSigned-off-by: Charles Kelly <charles.kelly@ccri.com>","created_at":"2016-11-28T20:31:08Z","updated_at":"2016-11-29T15:38:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4497d5ad16addb50b9013ef8c2ad15439ad008e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1242/commits","review_comments_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1242/comments","review_comment_url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/locationtech/geomesa/issues/1242/comments","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/1ea7722e76801ae51de980d7e34fec0e7602318e","head":{"label":"ccri:fcr_handle_tilde","ref":"fcr_handle_tilde","sha":"1ea7722e76801ae51de980d7e34fec0e7602318e","user":{"login":"ccri","id":1089783,"avatar_url":"https://avatars.githubusercontent.com/u/1089783?v=3","gravatar_id":"","url":"https://api.github.com/users/ccri","html_url":"https://github.com/ccri","followers_url":"https://api.github.com/users/ccri/followers","following_url":"https://api.github.com/users/ccri/following{/other_user}","gists_url":"https://api.github.com/users/ccri/gists{/gist_id}","starred_url":"https://api.github.com/users/ccri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccri/subscriptions","organizations_url":"https://api.github.com/users/ccri/orgs","repos_url":"https://api.github.com/users/ccri/repos","events_url":"https://api.github.com/users/ccri/events{/privacy}","received_events_url":"https://api.github.com/users/ccri/received_events","type":"Organization","site_admin":false},"repo":{"id":16865543,"name":"geomesa","full_name":"ccri/geomesa","owner":{"login":"ccri","id":1089783,"avatar_url":"https://avatars.githubusercontent.com/u/1089783?v=3","gravatar_id":"","url":"https://api.github.com/users/ccri","html_url":"https://github.com/ccri","followers_url":"https://api.github.com/users/ccri/followers","following_url":"https://api.github.com/users/ccri/following{/other_user}","gists_url":"https://api.github.com/users/ccri/gists{/gist_id}","starred_url":"https://api.github.com/users/ccri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccri/subscriptions","organizations_url":"https://api.github.com/users/ccri/orgs","repos_url":"https://api.github.com/users/ccri/repos","events_url":"https://api.github.com/users/ccri/events{/privacy}","received_events_url":"https://api.github.com/users/ccri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ccri/geomesa","description":"docs","fork":true,"url":"https://api.github.com/repos/ccri/geomesa","forks_url":"https://api.github.com/repos/ccri/geomesa/forks","keys_url":"https://api.github.com/repos/ccri/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccri/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccri/geomesa/teams","hooks_url":"https://api.github.com/repos/ccri/geomesa/hooks","issue_events_url":"https://api.github.com/repos/ccri/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/ccri/geomesa/events","assignees_url":"https://api.github.com/repos/ccri/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/ccri/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/ccri/geomesa/tags","blobs_url":"https://api.github.com/repos/ccri/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccri/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccri/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccri/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccri/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/ccri/geomesa/languages","stargazers_url":"https://api.github.com/repos/ccri/geomesa/stargazers","contributors_url":"https://api.github.com/repos/ccri/geomesa/contributors","subscribers_url":"https://api.github.com/repos/ccri/geomesa/subscribers","subscription_url":"https://api.github.com/repos/ccri/geomesa/subscription","commits_url":"https://api.github.com/repos/ccri/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccri/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccri/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccri/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccri/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/ccri/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccri/geomesa/merges","archive_url":"https://api.github.com/repos/ccri/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccri/geomesa/downloads","issues_url":"https://api.github.com/repos/ccri/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/ccri/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/ccri/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/ccri/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccri/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/ccri/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/ccri/geomesa/deployments","created_at":"2014-02-15T15:39:50Z","updated_at":"2016-02-17T20:03:55Z","pushed_at":"2016-11-28T23:03:44Z","git_url":"git://github.com/ccri/geomesa.git","ssh_url":"git@github.com:ccri/geomesa.git","clone_url":"https://github.com/ccri/geomesa.git","svn_url":"https://github.com/ccri/geomesa","homepage":"","size":58576,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"locationtech:master","ref":"master","sha":"dbe957395b25be4c2466dd25ec2e4f670608fc39","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars.githubusercontent.com/u/1991411?v=3","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geomesa/deployments","created_at":"2013-09-30T20:13:46Z","updated_at":"2016-11-23T17:46:56Z","pushed_at":"2016-11-29T15:34:54Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":63527,"stargazers_count":218,"watchers_count":218,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":17,"forks":108,"open_issues":17,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1242"},"html":{"href":"https://github.com/locationtech/geomesa/pull/1242"},"issue":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/1242"},"comments":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/1242/comments"},"review_comments":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1242/comments"},"review_comment":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1242/commits"},"statuses":{"href":"https://api.github.com/repos/locationtech/geomesa/statuses/1ea7722e76801ae51de980d7e34fec0e7602318e"}}}}
{"actor":{"display_login":"cfkelly"}}