{"action":"created","issue":{"url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29","repository_url":"https://api.github.com/repos/dvidelabs/flatcc","labels_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29/comments","events_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29/events","html_url":"https://github.com/dvidelabs/flatcc/pull/29","id":196245931,"number":29,"title":"Allow to generate scan for all fields as a default option","user":{"login":"skhoroshavin","id":5670522,"avatar_url":"https://avatars.githubusercontent.com/u/5670522?v=3","gravatar_id":"","url":"https://api.github.com/users/skhoroshavin","html_url":"https://github.com/skhoroshavin","followers_url":"https://api.github.com/users/skhoroshavin/followers","following_url":"https://api.github.com/users/skhoroshavin/following{/other_user}","gists_url":"https://api.github.com/users/skhoroshavin/gists{/gist_id}","starred_url":"https://api.github.com/users/skhoroshavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skhoroshavin/subscriptions","organizations_url":"https://api.github.com/users/skhoroshavin/orgs","repos_url":"https://api.github.com/users/skhoroshavin/repos","events_url":"https://api.github.com/users/skhoroshavin/events{/privacy}","received_events_url":"https://api.github.com/users/skhoroshavin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":78,"created_at":"2016-12-17T22:15:39Z","updated_at":"2016-12-22T22:31:31Z","closed_at":"2016-12-22T22:31:31Z","pull_request":{"url":"https://api.github.com/repos/dvidelabs/flatcc/pulls/29","html_url":"https://github.com/dvidelabs/flatcc/pull/29","diff_url":"https://github.com/dvidelabs/flatcc/pull/29.diff","patch_url":"https://github.com/dvidelabs/flatcc/pull/29.patch"},"body":"We discussed possibility of adding scan functions for all fields as a default option and I tried to implement it.  I also tried in my project to remove keys from fields, regenerate headers with new flatcc and measure compilation time on my laptop. After several clean runs of \"time make all\" it became apparent that there is no noticeable effect on compilation time (7.5 sec before and after on average) nor binaries size (514K executable compiled in debug mode). Reader header size became even smaller (21K before, 20K after)."},"comment":{"url":"https://api.github.com/repos/dvidelabs/flatcc/issues/comments/268905246","html_url":"https://github.com/dvidelabs/flatcc/pull/29#issuecomment-268905246","issue_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/29","id":268905246,"user":{"login":"mikkelfj","id":193335,"avatar_url":"https://avatars.githubusercontent.com/u/193335?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkelfj","html_url":"https://github.com/mikkelfj","followers_url":"https://api.github.com/users/mikkelfj/followers","following_url":"https://api.github.com/users/mikkelfj/following{/other_user}","gists_url":"https://api.github.com/users/mikkelfj/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkelfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkelfj/subscriptions","organizations_url":"https://api.github.com/users/mikkelfj/orgs","repos_url":"https://api.github.com/users/mikkelfj/repos","events_url":"https://api.github.com/users/mikkelfj/events{/privacy}","received_events_url":"https://api.github.com/users/mikkelfj/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T22:31:31Z","updated_at":"2016-12-22T22:31:31Z","body":"Field cleanup is better handled in seperate PR, so merging now."}}
{"actor":{"display_login":"mikkelfj"}}