{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/17282","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/17282/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/17282/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/17282/events","html_url":"https://github.com/elastic/elasticsearch/pull/17282","id":142968588,"number":17282,"title":"Remove deprecated reverse option from sorting","user":{"login":"MaineC","id":70953,"avatar_url":"https://avatars.githubusercontent.com/u/70953?v=3","gravatar_id":"","url":"https://api.github.com/users/MaineC","html_url":"https://github.com/MaineC","followers_url":"https://api.github.com/users/MaineC/followers","following_url":"https://api.github.com/users/MaineC/following{/other_user}","gists_url":"https://api.github.com/users/MaineC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaineC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaineC/subscriptions","organizations_url":"https://api.github.com/users/MaineC/orgs","repos_url":"https://api.github.com/users/MaineC/repos","events_url":"https://api.github.com/users/MaineC/events{/privacy}","received_events_url":"https://api.github.com/users/MaineC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search","name":":Search","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/breaking","name":"breaking","color":"ff0000"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.0.0","name":"v5.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":{"login":"MaineC","id":70953,"avatar_url":"https://avatars.githubusercontent.com/u/70953?v=3","gravatar_id":"","url":"https://api.github.com/users/MaineC","html_url":"https://github.com/MaineC","followers_url":"https://api.github.com/users/MaineC/followers","following_url":"https://api.github.com/users/MaineC/following{/other_user}","gists_url":"https://api.github.com/users/MaineC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaineC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaineC/subscriptions","organizations_url":"https://api.github.com/users/MaineC/orgs","repos_url":"https://api.github.com/users/MaineC/repos","events_url":"https://api.github.com/users/MaineC/events{/privacy}","received_events_url":"https://api.github.com/users/MaineC/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-03-23T14:06:55Z","updated_at":"2016-03-29T09:52:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/17282","html_url":"https://github.com/elastic/elasticsearch/pull/17282","diff_url":"https://github.com/elastic/elasticsearch/pull/17282.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/17282.patch"},"body":"This removes the \"reverse\" option for sorting as discussed in #17047 - instead define sort order explicitly like shown here: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-request-sort.html#_sort_order\r\n\r\nRelates to #17047\r\n\r\nPending: PR to deprecate the option removed above in 2.x"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/202810810","html_url":"https://github.com/elastic/elasticsearch/pull/17282#issuecomment-202810810","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/17282","id":202810810,"user":{"login":"cbuescher","id":10398885,"avatar_url":"https://avatars.githubusercontent.com/u/10398885?v=3","gravatar_id":"","url":"https://api.github.com/users/cbuescher","html_url":"https://github.com/cbuescher","followers_url":"https://api.github.com/users/cbuescher/followers","following_url":"https://api.github.com/users/cbuescher/following{/other_user}","gists_url":"https://api.github.com/users/cbuescher/gists{/gist_id}","starred_url":"https://api.github.com/users/cbuescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbuescher/subscriptions","organizations_url":"https://api.github.com/users/cbuescher/orgs","repos_url":"https://api.github.com/users/cbuescher/repos","events_url":"https://api.github.com/users/cbuescher/events{/privacy}","received_events_url":"https://api.github.com/users/cbuescher/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T09:52:10Z","updated_at":"2016-03-29T09:52:10Z","body":"@MaineC I see the problem, but I'm on the fence here with treating \"reverse\" as a special case that cannot be used as a field name for the geo point option. That would require special documentation (all fieldnames allowed except...) and somehow doesn't feel right to me. What if instead to mitigate the problem:\r\n* dissallow setting the field name for the geo points twice and throw an error with the fieldname already set and the different one we are trying to set (that would give errors sth. like `fieldname already set to \"my_point\" but trying to reset to \"reverse\") \r\n* dissallow token value other than VALUE_STRING in the case where we are parsing to geo hash. That would catch the cases where we have `\"reverse\" : true` in the query.\r\n* Add the fieldname to the error message above (I think that gets triggered in build()), so users get a hint that they are using the wrong field when accidentally specifying `\"reverse\" : \"true\"|\"false\"` "}}