{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/88732870","pull_request_review_id":9300360,"id":88732870,"diff_hunk":"@@ -0,0 +1,18 @@\n+# Logging example curator config file","path":"roles/openshift_logging/files/curator.yml","position":1,"original_position":1,"commit_id":"1900cd682539f51a0fd273aa11fc3781e39fae18","original_commit_id":"1900cd682539f51a0fd273aa11fc3781e39fae18","user":{"login":"detiber","id":915544,"avatar_url":"https://avatars.githubusercontent.com/u/915544?v=3","gravatar_id":"","url":"https://api.github.com/users/detiber","html_url":"https://github.com/detiber","followers_url":"https://api.github.com/users/detiber/followers","following_url":"https://api.github.com/users/detiber/following{/other_user}","gists_url":"https://api.github.com/users/detiber/gists{/gist_id}","starred_url":"https://api.github.com/users/detiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/detiber/subscriptions","organizations_url":"https://api.github.com/users/detiber/orgs","repos_url":"https://api.github.com/users/detiber/repos","events_url":"https://api.github.com/users/detiber/events{/privacy}","received_events_url":"https://api.github.com/users/detiber/received_events","type":"User","site_admin":false},"body":"@jcantrill agree on all parts, I might have missed it, but is there a way to override the contents of the file included in the role when creating/updating the config map? If not, there should be. The role should be able to be consumed without modification of the files contained in the role itself.","created_at":"2016-11-18T20:25:27Z","updated_at":"2016-11-18T20:25:27Z","html_url":"https://github.com/openshift/openshift-ansible/pull/2640#discussion_r88732870","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/88732870"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2640#discussion_r88732870"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640","id":90427605,"html_url":"https://github.com/openshift/openshift-ansible/pull/2640","diff_url":"https://github.com/openshift/openshift-ansible/pull/2640.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2640.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2640","number":2640,"state":"open","locked":false,"title":"[WIP] Logging deployer tasks","user":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"body":"WIP for moving logic from within the Aggregated Logging deployer to an Ansible role\n","created_at":"2016-10-21T19:02:01Z","updated_at":"2016-11-18T20:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"370d1b32353271e2d4d7a8199a3cad995a6a3f2b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2640/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/1900cd682539f51a0fd273aa11fc3781e39fae18","head":{"label":"ewolinetz:logging_deployer_tasks","ref":"logging_deployer_tasks","sha":"1900cd682539f51a0fd273aa11fc3781e39fae18","user":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"repo":{"id":69476860,"name":"openshift-ansible","full_name":"ewolinetz/openshift-ansible","owner":{"login":"ewolinetz","id":1427473,"avatar_url":"https://avatars.githubusercontent.com/u/1427473?v=3","gravatar_id":"","url":"https://api.github.com/users/ewolinetz","html_url":"https://github.com/ewolinetz","followers_url":"https://api.github.com/users/ewolinetz/followers","following_url":"https://api.github.com/users/ewolinetz/following{/other_user}","gists_url":"https://api.github.com/users/ewolinetz/gists{/gist_id}","starred_url":"https://api.github.com/users/ewolinetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewolinetz/subscriptions","organizations_url":"https://api.github.com/users/ewolinetz/orgs","repos_url":"https://api.github.com/users/ewolinetz/repos","events_url":"https://api.github.com/users/ewolinetz/events{/privacy}","received_events_url":"https://api.github.com/users/ewolinetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewolinetz/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/ewolinetz/openshift-ansible","forks_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/forks","keys_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/events","assignees_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/merges","archive_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ewolinetz/openshift-ansible/deployments","created_at":"2016-09-28T15:24:44Z","updated_at":"2016-09-28T15:24:50Z","pushed_at":"2016-11-10T14:54:46Z","git_url":"git://github.com/ewolinetz/openshift-ansible.git","ssh_url":"git@github.com:ewolinetz/openshift-ansible.git","clone_url":"https://github.com/ewolinetz/openshift-ansible.git","svn_url":"https://github.com/ewolinetz/openshift-ansible","homepage":"install.openshift.com","size":6513,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"4698b0c696b9d9cf2b8dbff5eaa4fcaa545093cd","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-11-17T21:42:21Z","pushed_at":"2016-11-18T20:11:23Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":11394,"stargazers_count":278,"watchers_count":278,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":456,"mirror_url":null,"open_issues_count":231,"forks":456,"open_issues":231,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2640"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2640"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2640/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2640/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/1900cd682539f51a0fd273aa11fc3781e39fae18"}}}}
{"actor":{"display_login":"detiber"}}