{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/67605688","id":67605688,"diff_hunk":"@@ -20,6 +32,15 @@ def setup_platform(hass, config, add_devices, discovery_info=None):\n \n     node = zwave.NETWORK.nodes[discovery_info[zwave.ATTR_NODE_ID]]\n     value = node.values[discovery_info[zwave.ATTR_VALUE_ID]]\n+    # Make sure that we have values for the key before converting to int\n+    if (value.node.manufacturer_id.strip() and","path":"homeassistant/components/light/zwave.py","position":30,"original_position":30,"commit_id":"7b0c4c97a3bddc056d77a6bd2d75700aef9a363f","original_commit_id":"7b0c4c97a3bddc056d77a6bd2d75700aef9a363f","user":{"login":"turbokongen","id":16622752,"avatar_url":"https://avatars.githubusercontent.com/u/16622752?v=3","gravatar_id":"","url":"https://api.github.com/users/turbokongen","html_url":"https://github.com/turbokongen","followers_url":"https://api.github.com/users/turbokongen/followers","following_url":"https://api.github.com/users/turbokongen/following{/other_user}","gists_url":"https://api.github.com/users/turbokongen/gists{/gist_id}","starred_url":"https://api.github.com/users/turbokongen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbokongen/subscriptions","organizations_url":"https://api.github.com/users/turbokongen/orgs","repos_url":"https://api.github.com/users/turbokongen/repos","events_url":"https://api.github.com/users/turbokongen/events{/privacy}","received_events_url":"https://api.github.com/users/turbokongen/received_events","type":"User","site_admin":false},"body":"Uhm.... Sure. Unsure how to go about that. Because this will eventually be present for virtually all components zwave is loaded on. When things evolve it will get harder to send devices to the correct component. So some routine to recognize the correct is needed, This needs some investegation to get correct.","created_at":"2016-06-18T19:46:55Z","updated_at":"2016-06-18T19:46:55Z","html_url":"https://github.com/home-assistant/home-assistant/pull/2313#discussion_r67605688","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/67605688"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2313#discussion_r67605688"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313","id":74073888,"html_url":"https://github.com/home-assistant/home-assistant/pull/2313","diff_url":"https://github.com/home-assistant/home-assistant/pull/2313.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/2313.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2313","number":2313,"state":"open","locked":false,"title":"Basic implementation of Zwave Rollershutters","user":{"login":"turbokongen","id":16622752,"avatar_url":"https://avatars.githubusercontent.com/u/16622752?v=3","gravatar_id":"","url":"https://api.github.com/users/turbokongen","html_url":"https://github.com/turbokongen","followers_url":"https://api.github.com/users/turbokongen/followers","following_url":"https://api.github.com/users/turbokongen/following{/other_user}","gists_url":"https://api.github.com/users/turbokongen/gists{/gist_id}","starred_url":"https://api.github.com/users/turbokongen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbokongen/subscriptions","organizations_url":"https://api.github.com/users/turbokongen/orgs","repos_url":"https://api.github.com/users/turbokongen/repos","events_url":"https://api.github.com/users/turbokongen/events{/privacy}","received_events_url":"https://api.github.com/users/turbokongen/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nBasic Implementation for Zwave Rollershutter devices.\r\n\r\nThis also blocks tested rollershutter device from switch and light.\r\nThis is only tested with Fibaro FGRM-222 rollershutter device, and should be considered a basic implementation. For the future, other devices may need to be added for blocking.\r\nThank you @nunofgs for providing the information to make this possible, testing and debug. :+1: \r\nThank you @wokar for providing code for better filtering. This will make future filtration easier. :+1: \r\n**Related issue (if applicable):** fixes #\r\n#2053 \r\n\r\n**Checklist:**\r\n\r\nIf code communicates with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n\r\n\r\n\r\n","created_at":"2016-06-16T12:44:18Z","updated_at":"2016-06-18T19:46:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1c25a8f6c071b49b01a4421540288d6729d7c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2313/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/7b0c4c97a3bddc056d77a6bd2d75700aef9a363f","head":{"label":"turbokongen:zwave_rollershutter","ref":"zwave_rollershutter","sha":"7b0c4c97a3bddc056d77a6bd2d75700aef9a363f","user":{"login":"turbokongen","id":16622752,"avatar_url":"https://avatars.githubusercontent.com/u/16622752?v=3","gravatar_id":"","url":"https://api.github.com/users/turbokongen","html_url":"https://github.com/turbokongen","followers_url":"https://api.github.com/users/turbokongen/followers","following_url":"https://api.github.com/users/turbokongen/following{/other_user}","gists_url":"https://api.github.com/users/turbokongen/gists{/gist_id}","starred_url":"https://api.github.com/users/turbokongen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbokongen/subscriptions","organizations_url":"https://api.github.com/users/turbokongen/orgs","repos_url":"https://api.github.com/users/turbokongen/repos","events_url":"https://api.github.com/users/turbokongen/events{/privacy}","received_events_url":"https://api.github.com/users/turbokongen/received_events","type":"User","site_admin":false},"repo":{"id":50231140,"name":"home-assistant","full_name":"turbokongen/home-assistant","owner":{"login":"turbokongen","id":16622752,"avatar_url":"https://avatars.githubusercontent.com/u/16622752?v=3","gravatar_id":"","url":"https://api.github.com/users/turbokongen","html_url":"https://github.com/turbokongen","followers_url":"https://api.github.com/users/turbokongen/followers","following_url":"https://api.github.com/users/turbokongen/following{/other_user}","gists_url":"https://api.github.com/users/turbokongen/gists{/gist_id}","starred_url":"https://api.github.com/users/turbokongen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbokongen/subscriptions","organizations_url":"https://api.github.com/users/turbokongen/orgs","repos_url":"https://api.github.com/users/turbokongen/repos","events_url":"https://api.github.com/users/turbokongen/events{/privacy}","received_events_url":"https://api.github.com/users/turbokongen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/turbokongen/home-assistant","description":"Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/turbokongen/home-assistant","forks_url":"https://api.github.com/repos/turbokongen/home-assistant/forks","keys_url":"https://api.github.com/repos/turbokongen/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turbokongen/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turbokongen/home-assistant/teams","hooks_url":"https://api.github.com/repos/turbokongen/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/turbokongen/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/turbokongen/home-assistant/events","assignees_url":"https://api.github.com/repos/turbokongen/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/turbokongen/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/turbokongen/home-assistant/tags","blobs_url":"https://api.github.com/repos/turbokongen/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turbokongen/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turbokongen/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/turbokongen/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turbokongen/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/turbokongen/home-assistant/languages","stargazers_url":"https://api.github.com/repos/turbokongen/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/turbokongen/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/turbokongen/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/turbokongen/home-assistant/subscription","commits_url":"https://api.github.com/repos/turbokongen/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/turbokongen/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/turbokongen/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/turbokongen/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/turbokongen/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/turbokongen/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turbokongen/home-assistant/merges","archive_url":"https://api.github.com/repos/turbokongen/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turbokongen/home-assistant/downloads","issues_url":"https://api.github.com/repos/turbokongen/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/turbokongen/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/turbokongen/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/turbokongen/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turbokongen/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/turbokongen/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/turbokongen/home-assistant/deployments","created_at":"2016-01-23T08:55:09Z","updated_at":"2016-01-23T08:55:11Z","pushed_at":"2016-06-17T11:13:22Z","git_url":"git://github.com/turbokongen/home-assistant.git","ssh_url":"git@github.com:turbokongen/home-assistant.git","clone_url":"https://github.com/turbokongen/home-assistant.git","svn_url":"https://github.com/turbokongen/home-assistant","homepage":"https://home-assistant.io","size":50996,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"b6fb21edaf536f49af6875c15b88cf2f75d01a7b","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-06-18T12:00:41Z","pushed_at":"2016-06-18T19:34:44Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":80175,"stargazers_count":3575,"watchers_count":3575,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":769,"mirror_url":null,"open_issues_count":167,"forks":769,"open_issues":167,"watchers":3575,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2313"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2313"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2313/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2313/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/7b0c4c97a3bddc056d77a6bd2d75700aef9a363f"}}}}
{"actor":{"display_login":"turbokongen"}}