{"action":"closed","number":1967,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/1967","id":88569766,"html_url":"https://github.com/aframevr/aframe/pull/1967","diff_url":"https://github.com/aframevr/aframe/pull/1967.diff","patch_url":"https://github.com/aframevr/aframe/pull/1967.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/1967","number":1967,"state":"closed","locked":false,"title":"move <a-assets> inside of <a-scene>","user":{"login":"Hongbo-Miao","id":3375461,"avatar_url":"https://avatars.githubusercontent.com/u/3375461?v=3","gravatar_id":"","url":"https://api.github.com/users/Hongbo-Miao","html_url":"https://github.com/Hongbo-Miao","followers_url":"https://api.github.com/users/Hongbo-Miao/followers","following_url":"https://api.github.com/users/Hongbo-Miao/following{/other_user}","gists_url":"https://api.github.com/users/Hongbo-Miao/gists{/gist_id}","starred_url":"https://api.github.com/users/Hongbo-Miao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hongbo-Miao/subscriptions","organizations_url":"https://api.github.com/users/Hongbo-Miao/orgs","repos_url":"https://api.github.com/users/Hongbo-Miao/repos","events_url":"https://api.github.com/users/Hongbo-Miao/events{/privacy}","received_events_url":"https://api.github.com/users/Hongbo-Miao/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n`<a-assets>` should move into `<a-scene>`, or it will show the error:\r\n\r\n> aframe.js:60419Uncaught Error: <a-assets> must be a child of a <a-scene>\r\n\r\noutside of CodePen.\r\n\r\n**Changes proposed:**\r\nmove `<a-assets>` inside of `<a-scene>`, and update the demo link.","created_at":"2016-10-09T05:50:58Z","updated_at":"2016-10-10T23:13:18Z","closed_at":"2016-10-10T23:13:18Z","merged_at":"2016-10-10T23:13:18Z","merge_commit_sha":"330ed2ddf57ebd5424dbe38af060ddf5866a94e9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/1967/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/1967/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/1967/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/79da4e9de3370c8834648d6cf80849c39df0b9fa","head":{"label":"Hongbo-Miao:patch-1","ref":"patch-1","sha":"79da4e9de3370c8834648d6cf80849c39df0b9fa","user":{"login":"Hongbo-Miao","id":3375461,"avatar_url":"https://avatars.githubusercontent.com/u/3375461?v=3","gravatar_id":"","url":"https://api.github.com/users/Hongbo-Miao","html_url":"https://github.com/Hongbo-Miao","followers_url":"https://api.github.com/users/Hongbo-Miao/followers","following_url":"https://api.github.com/users/Hongbo-Miao/following{/other_user}","gists_url":"https://api.github.com/users/Hongbo-Miao/gists{/gist_id}","starred_url":"https://api.github.com/users/Hongbo-Miao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hongbo-Miao/subscriptions","organizations_url":"https://api.github.com/users/Hongbo-Miao/orgs","repos_url":"https://api.github.com/users/Hongbo-Miao/repos","events_url":"https://api.github.com/users/Hongbo-Miao/events{/privacy}","received_events_url":"https://api.github.com/users/Hongbo-Miao/received_events","type":"User","site_admin":false},"repo":{"id":70379844,"name":"aframe","full_name":"Hongbo-Miao/aframe","owner":{"login":"Hongbo-Miao","id":3375461,"avatar_url":"https://avatars.githubusercontent.com/u/3375461?v=3","gravatar_id":"","url":"https://api.github.com/users/Hongbo-Miao","html_url":"https://github.com/Hongbo-Miao","followers_url":"https://api.github.com/users/Hongbo-Miao/followers","following_url":"https://api.github.com/users/Hongbo-Miao/following{/other_user}","gists_url":"https://api.github.com/users/Hongbo-Miao/gists{/gist_id}","starred_url":"https://api.github.com/users/Hongbo-Miao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hongbo-Miao/subscriptions","organizations_url":"https://api.github.com/users/Hongbo-Miao/orgs","repos_url":"https://api.github.com/users/Hongbo-Miao/repos","events_url":"https://api.github.com/users/Hongbo-Miao/events{/privacy}","received_events_url":"https://api.github.com/users/Hongbo-Miao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hongbo-Miao/aframe","description":"A web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/Hongbo-Miao/aframe","forks_url":"https://api.github.com/repos/Hongbo-Miao/aframe/forks","keys_url":"https://api.github.com/repos/Hongbo-Miao/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hongbo-Miao/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hongbo-Miao/aframe/teams","hooks_url":"https://api.github.com/repos/Hongbo-Miao/aframe/hooks","issue_events_url":"https://api.github.com/repos/Hongbo-Miao/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/Hongbo-Miao/aframe/events","assignees_url":"https://api.github.com/repos/Hongbo-Miao/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/Hongbo-Miao/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/Hongbo-Miao/aframe/tags","blobs_url":"https://api.github.com/repos/Hongbo-Miao/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hongbo-Miao/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hongbo-Miao/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hongbo-Miao/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hongbo-Miao/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/Hongbo-Miao/aframe/languages","stargazers_url":"https://api.github.com/repos/Hongbo-Miao/aframe/stargazers","contributors_url":"https://api.github.com/repos/Hongbo-Miao/aframe/contributors","subscribers_url":"https://api.github.com/repos/Hongbo-Miao/aframe/subscribers","subscription_url":"https://api.github.com/repos/Hongbo-Miao/aframe/subscription","commits_url":"https://api.github.com/repos/Hongbo-Miao/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hongbo-Miao/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hongbo-Miao/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hongbo-Miao/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hongbo-Miao/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/Hongbo-Miao/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hongbo-Miao/aframe/merges","archive_url":"https://api.github.com/repos/Hongbo-Miao/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hongbo-Miao/aframe/downloads","issues_url":"https://api.github.com/repos/Hongbo-Miao/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/Hongbo-Miao/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/Hongbo-Miao/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/Hongbo-Miao/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hongbo-Miao/aframe/labels{/name}","releases_url":"https://api.github.com/repos/Hongbo-Miao/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/Hongbo-Miao/aframe/deployments","created_at":"2016-10-09T05:46:35Z","updated_at":"2016-10-09T05:46:36Z","pushed_at":"2016-10-09T05:50:12Z","git_url":"git://github.com/Hongbo-Miao/aframe.git","ssh_url":"git@github.com:Hongbo-Miao/aframe.git","clone_url":"https://github.com/Hongbo-Miao/aframe.git","svn_url":"https://github.com/Hongbo-Miao/aframe","homepage":"https://aframe.io/","size":131732,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"c5aabf65fd54ad2909eda32cb169b09dacf77821","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"A web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-10-10T20:13:53Z","pushed_at":"2016-10-10T23:13:19Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":141869,"stargazers_count":3630,"watchers_count":3630,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":687,"mirror_url":null,"open_issues_count":212,"forks":687,"open_issues":212,"watchers":3630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1967"},"html":{"href":"https://github.com/aframevr/aframe/pull/1967"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1967"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1967/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1967/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1967/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/79da4e9de3370c8834648d6cf80849c39df0b9fa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ngokevin"}}