{"action":"created","comment":{"url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/comments/77958082","id":77958082,"diff_hunk":"@@ -0,0 +1,14 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n+<container xmlns=\"http://symfony.com/schema/dic/services\"\n+    xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+    xsi:schemaLocation=\"http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd\">\n+\n+    <services>\n+        <service id=\"cmf_content.form.extension.ckeditor\"\n+            class=\"Symfony\\Cmf\\Bundle\\ContentBundle\\Form\\Extension\\CKEditorExtension\">","path":"Resources/config/ckeditor.xml","position":8,"original_position":8,"commit_id":"9a1cdb928b214c3cb3c55161aea0f1925b9bd92e","original_commit_id":"9a1cdb928b214c3cb3c55161aea0f1925b9bd92e","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"CKEditorExtension accepts options in the constructor. i think we still have the options in the Configuration.php but should pass them to the extension here.","created_at":"2016-09-08T07:35:00Z","updated_at":"2016-09-08T07:35:00Z","html_url":"https://github.com/symfony-cmf/content-bundle/pull/150#discussion_r77958082","pull_request_url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/comments/77958082"},"html":{"href":"https://github.com/symfony-cmf/content-bundle/pull/150#discussion_r77958082"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150","id":80785969,"html_url":"https://github.com/symfony-cmf/content-bundle/pull/150","diff_url":"https://github.com/symfony-cmf/content-bundle/pull/150.diff","patch_url":"https://github.com/symfony-cmf/content-bundle/pull/150.patch","issue_url":"https://api.github.com/repos/symfony-cmf/content-bundle/issues/150","number":150,"state":"open","locked":false,"title":"Extract StaticContentType from StaticContentAdmin","user":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars.githubusercontent.com/u/1116116?v=3","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"body":"To ease the extraction of sonata admin class, it was decided that the form used to edit staticContent should be extracted from the admin class.\r\n\r\nI also changed a bit options about IvoryCkEditor to allow using IvoryCkEditor with default options.\r\n\r\nThis is still a work in progress.\r\n\r\n## Progress\r\n\r\n### Todo\r\n- [x] parentDocument field\r\n- [x] TreeSelectType assets\r\n- [x] allow to use TreeSelectType browser widget\r\n- [x] fix fields ordering\r\n- [x] tests\r\n- [x] history rewrite\r\n- [ ] write `Form/Extension/CKEditorExtension` tests\r\n- [ ] history rewrite 2\r\n\r\n### Blockers\r\n- [x] https://github.com/symfony-cmf/tree-browser-bundle/pull/112\r\n- [x] https://github.com/sonata-project/SonataAdminBundle/pull/4101","created_at":"2016-08-10T12:35:46Z","updated_at":"2016-09-08T07:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3be3c06282c1524bc13341541b7c8aebb6ab24eb","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony-cmf/content-bundle/milestones/4","html_url":"https://github.com/symfony-cmf/content-bundle/milestones/2.0.0","labels_url":"https://api.github.com/repos/symfony-cmf/content-bundle/milestones/4/labels","id":1555468,"number":4,"title":"2.0.0","description":"","creator":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2016-02-01T12:18:35Z","updated_at":"2016-08-10T12:37:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150/commits","review_comments_url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150/comments","review_comment_url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony-cmf/content-bundle/issues/150/comments","statuses_url":"https://api.github.com/repos/symfony-cmf/content-bundle/statuses/9a1cdb928b214c3cb3c55161aea0f1925b9bd92e","head":{"label":"fbourigault:feature-extract-form-type-from-admin","ref":"feature-extract-form-type-from-admin","sha":"9a1cdb928b214c3cb3c55161aea0f1925b9bd92e","user":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars.githubusercontent.com/u/1116116?v=3","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"repo":{"id":65380245,"name":"content-bundle","full_name":"fbourigault/content-bundle","owner":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars.githubusercontent.com/u/1116116?v=3","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbourigault/content-bundle","description":"Provides some basic document classes and controllers for modeling content","fork":true,"url":"https://api.github.com/repos/fbourigault/content-bundle","forks_url":"https://api.github.com/repos/fbourigault/content-bundle/forks","keys_url":"https://api.github.com/repos/fbourigault/content-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbourigault/content-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbourigault/content-bundle/teams","hooks_url":"https://api.github.com/repos/fbourigault/content-bundle/hooks","issue_events_url":"https://api.github.com/repos/fbourigault/content-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/fbourigault/content-bundle/events","assignees_url":"https://api.github.com/repos/fbourigault/content-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/fbourigault/content-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/fbourigault/content-bundle/tags","blobs_url":"https://api.github.com/repos/fbourigault/content-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbourigault/content-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbourigault/content-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbourigault/content-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbourigault/content-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/fbourigault/content-bundle/languages","stargazers_url":"https://api.github.com/repos/fbourigault/content-bundle/stargazers","contributors_url":"https://api.github.com/repos/fbourigault/content-bundle/contributors","subscribers_url":"https://api.github.com/repos/fbourigault/content-bundle/subscribers","subscription_url":"https://api.github.com/repos/fbourigault/content-bundle/subscription","commits_url":"https://api.github.com/repos/fbourigault/content-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbourigault/content-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbourigault/content-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbourigault/content-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbourigault/content-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/fbourigault/content-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbourigault/content-bundle/merges","archive_url":"https://api.github.com/repos/fbourigault/content-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbourigault/content-bundle/downloads","issues_url":"https://api.github.com/repos/fbourigault/content-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/fbourigault/content-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/fbourigault/content-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/fbourigault/content-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbourigault/content-bundle/labels{/name}","releases_url":"https://api.github.com/repos/fbourigault/content-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/fbourigault/content-bundle/deployments","created_at":"2016-08-10T12:21:29Z","updated_at":"2016-08-10T12:21:30Z","pushed_at":"2016-09-07T12:28:21Z","git_url":"git://github.com/fbourigault/content-bundle.git","ssh_url":"git@github.com:fbourigault/content-bundle.git","clone_url":"https://github.com/fbourigault/content-bundle.git","svn_url":"https://github.com/fbourigault/content-bundle","homepage":"http://cmf.symfony.com","size":309,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony-cmf:master","ref":"master","sha":"ab0dd599e073a245ecc15ad89022c6f1680d9c47","user":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":1864589,"name":"content-bundle","full_name":"symfony-cmf/content-bundle","owner":{"login":"symfony-cmf","id":342045,"avatar_url":"https://avatars.githubusercontent.com/u/342045?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony-cmf","html_url":"https://github.com/symfony-cmf","followers_url":"https://api.github.com/users/symfony-cmf/followers","following_url":"https://api.github.com/users/symfony-cmf/following{/other_user}","gists_url":"https://api.github.com/users/symfony-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony-cmf/subscriptions","organizations_url":"https://api.github.com/users/symfony-cmf/orgs","repos_url":"https://api.github.com/users/symfony-cmf/repos","events_url":"https://api.github.com/users/symfony-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/symfony-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony-cmf/content-bundle","description":"Provides some basic document classes and controllers for modeling content","fork":false,"url":"https://api.github.com/repos/symfony-cmf/content-bundle","forks_url":"https://api.github.com/repos/symfony-cmf/content-bundle/forks","keys_url":"https://api.github.com/repos/symfony-cmf/content-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony-cmf/content-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony-cmf/content-bundle/teams","hooks_url":"https://api.github.com/repos/symfony-cmf/content-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony-cmf/content-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony-cmf/content-bundle/events","assignees_url":"https://api.github.com/repos/symfony-cmf/content-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony-cmf/content-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony-cmf/content-bundle/tags","blobs_url":"https://api.github.com/repos/symfony-cmf/content-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony-cmf/content-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony-cmf/content-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony-cmf/content-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony-cmf/content-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony-cmf/content-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony-cmf/content-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony-cmf/content-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony-cmf/content-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony-cmf/content-bundle/subscription","commits_url":"https://api.github.com/repos/symfony-cmf/content-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony-cmf/content-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony-cmf/content-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony-cmf/content-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony-cmf/content-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony-cmf/content-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony-cmf/content-bundle/merges","archive_url":"https://api.github.com/repos/symfony-cmf/content-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony-cmf/content-bundle/downloads","issues_url":"https://api.github.com/repos/symfony-cmf/content-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony-cmf/content-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony-cmf/content-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony-cmf/content-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony-cmf/content-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony-cmf/content-bundle/deployments","created_at":"2011-06-08T09:47:09Z","updated_at":"2016-04-07T08:03:35Z","pushed_at":"2016-09-07T12:28:21Z","git_url":"git://github.com/symfony-cmf/content-bundle.git","ssh_url":"git@github.com:symfony-cmf/content-bundle.git","clone_url":"https://github.com/symfony-cmf/content-bundle.git","svn_url":"https://github.com/symfony-cmf/content-bundle","homepage":"http://cmf.symfony.com","size":447,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150"},"html":{"href":"https://github.com/symfony-cmf/content-bundle/pull/150"},"issue":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/issues/150"},"comments":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/symfony-cmf/content-bundle/statuses/9a1cdb928b214c3cb3c55161aea0f1925b9bd92e"}}}}
{"actor":{"display_login":"dbu"}}