{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/5796","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/5796/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/5796/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/5796/events","html_url":"https://github.com/facebook/react-native/pull/5796","id":131944508,"number":5796,"title":"Enable strict mode for transform-es2015-modules-commonjs","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars.githubusercontent.com/u/2677334?v=3","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20accepted","name":"GH Review: accepted","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"bestander","id":2121048,"avatar_url":"https://avatars.githubusercontent.com/u/2121048?v=3","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false},"milestone":null,"comments":17,"created_at":"2016-02-07T07:05:47Z","updated_at":"2016-03-21T12:33:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/5796","html_url":"https://github.com/facebook/react-native/pull/5796","diff_url":"https://github.com/facebook/react-native/pull/5796.diff","patch_url":"https://github.com/facebook/react-native/pull/5796.patch"},"body":"Since #5422 react-native works with strict mode modules but the transform was not updated since Facebook has some non strict mode compatible internal modules. Now that #5214 has landed and it is easy to change the babel config I think we should enable it by default to make es2015 modules spec compliant.\r\n\r\nSomeone at Facebook will have to make the internal changes necessary to disable strict mode modules for their projects that use non strict mode compatible modules by including a .babelrc file with \r\n``` json\r\n{\r\n  \"presets\": [\r\n    \"react-native\"\r\n  ],\r\n  \"plugins\": [\r\n    [\"transform-es2015-modules-commonjs\", { \"strict\": false, \"allowTopLevelThis\": true }]\r\n  ]\r\n}\r\n``` \r\nbefore merging this.\r\n\r\nWe might also want to mention this in the breaking change section for the next release."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/199252503","html_url":"https://github.com/facebook/react-native/pull/5796#issuecomment-199252503","issue_url":"https://api.github.com/repos/facebook/react-native/issues/5796","id":199252503,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T12:33:34Z","updated_at":"2016-03-21T12:33:34Z","body":"Thanks for importing. If you are an FB employee go to [Phabricator](https://our.intern.facebook.com/intern/opensource/github/pull_request/1559140124405135/int_phab) to review."}}