{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/imports-loader/issues/21","repository_url":"https://api.github.com/repos/webpack/imports-loader","labels_url":"https://api.github.com/repos/webpack/imports-loader/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/webpack/imports-loader/issues/21/comments","events_url":"https://api.github.com/repos/webpack/imports-loader/issues/21/events","html_url":"https://github.com/webpack/imports-loader/pull/21","id":144724122,"number":21,"title":"Allow setting window values instead of vars","user":{"login":"jgable","id":164497,"avatar_url":"https://avatars.githubusercontent.com/u/164497?v=3","gravatar_id":"","url":"https://api.github.com/users/jgable","html_url":"https://github.com/jgable","followers_url":"https://api.github.com/users/jgable/followers","following_url":"https://api.github.com/users/jgable/following{/other_user}","gists_url":"https://api.github.com/users/jgable/gists{/gist_id}","starred_url":"https://api.github.com/users/jgable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgable/subscriptions","organizations_url":"https://api.github.com/users/jgable/orgs","repos_url":"https://api.github.com/users/jgable/repos","events_url":"https://api.github.com/users/jgable/events{/privacy}","received_events_url":"https://api.github.com/users/jgable/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-03-30T21:25:56Z","updated_at":"2016-11-25T18:32:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webpack/imports-loader/pulls/21","html_url":"https://github.com/webpack/imports-loader/pull/21","diff_url":"https://github.com/webpack/imports-loader/pull/21.diff","patch_url":"https://github.com/webpack/imports-loader/pull/21.patch"},"body":"Proposed fix for #19.\n\nAdds a check if the name begins with \"window.\" and instead of using a `var` declaration it will define a `window` variable and delete it in postfixes.\n\nTo test this I shimmed the `node-mathquill` module which references `window.jQuery` instead of just `jQuery` using the following config.\n\n```\n{\n  test: /mathquill\\.js$/,\n  include: [/node-mathquill/],\n  // Grab the MathQuill export, provide jQuery\n  loaders: ['imports?window.jQuery=jquery', 'exports?MathQuill']\n},\n```\n\nI verified that other var declaration imports worked for my other vendor files as before and I verified that the window.jQuery reference was deleted at the end of that module after exporting.\n"},"comment":{"url":"https://api.github.com/repos/webpack/imports-loader/issues/comments/263008791","html_url":"https://github.com/webpack/imports-loader/pull/21#issuecomment-263008791","issue_url":"https://api.github.com/repos/webpack/imports-loader/issues/21","id":263008791,"user":{"login":"SpaceK33z","id":533616,"avatar_url":"https://avatars.githubusercontent.com/u/533616?v=3","gravatar_id":"","url":"https://api.github.com/users/SpaceK33z","html_url":"https://github.com/SpaceK33z","followers_url":"https://api.github.com/users/SpaceK33z/followers","following_url":"https://api.github.com/users/SpaceK33z/following{/other_user}","gists_url":"https://api.github.com/users/SpaceK33z/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceK33z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceK33z/subscriptions","organizations_url":"https://api.github.com/users/SpaceK33z/orgs","repos_url":"https://api.github.com/users/SpaceK33z/repos","events_url":"https://api.github.com/users/SpaceK33z/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceK33z/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T18:32:09Z","updated_at":"2016-11-25T18:32:09Z","body":"@niksy, take a look at the comment above you. Also the CLA needs to be signed. You could use the changes @jgable made and make a new PR."}}
{"actor":{"display_login":"SpaceK33z"}}