{"action":"created","issue":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6098","repository_url":"https://api.github.com/repos/TEAMMATES/teammates","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6098/labels{/name}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6098/comments","events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6098/events","html_url":"https://github.com/TEAMMATES/teammates/pull/6098","id":181842472,"number":6098,"title":"Response deletion warning message sometimes not shown when question edited #6097","user":{"login":"YongJieYongJie","id":14101781,"avatar_url":"https://avatars.githubusercontent.com/u/14101781?v=3","gravatar_id":"","url":"https://api.github.com/users/YongJieYongJie","html_url":"https://github.com/YongJieYongJie","followers_url":"https://api.github.com/users/YongJieYongJie/followers","following_url":"https://api.github.com/users/YongJieYongJie/following{/other_user}","gists_url":"https://api.github.com/users/YongJieYongJie/gists{/gist_id}","starred_url":"https://api.github.com/users/YongJieYongJie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YongJieYongJie/subscriptions","organizations_url":"https://api.github.com/users/YongJieYongJie/orgs","repos_url":"https://api.github.com/users/YongJieYongJie/repos","events_url":"https://api.github.com/users/YongJieYongJie/events{/privacy}","received_events_url":"https://api.github.com/users/YongJieYongJie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.Ongoing","name":"s.Ongoing","color":"6BC471"}],"state":"open","locked":false,"assignee":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"assignees":[{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-10-08T18:53:28Z","updated_at":"2016-10-09T04:42:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6098","html_url":"https://github.com/TEAMMATES/teammates/pull/6098","diff_url":"https://github.com/TEAMMATES/teammates/pull/6098.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/6098.patch"},"body":"Temporarily fixes #6097\r\n\r\nThe following warning message will always be shown whenever there are existing responses:\r\n(note the change from `will be deleted` to `may be deleted` etc.)\r\n![2016-10-09-025556_1280x800_scrot](https://cloud.githubusercontent.com/assets/14101781/19215280/efdd01cc-8dcb-11e6-81bf-75ce3d295e8a.png)\r\n\r\n\r\n\r\n<!--\r\nPlease follow the naming conventions in the \"guidelines for contributing\" link above or the pull request may be rejected.\r\n\r\nAlso, do consider outlining the solution taken as doing so will likely help in the reviewing process\r\n(e.g., when the pull request involves non-trivial changes)\r\n-->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments/252464417","html_url":"https://github.com/TEAMMATES/teammates/pull/6098#issuecomment-252464417","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6098","id":252464417,"user":{"login":"YongJieYongJie","id":14101781,"avatar_url":"https://avatars.githubusercontent.com/u/14101781?v=3","gravatar_id":"","url":"https://api.github.com/users/YongJieYongJie","html_url":"https://github.com/YongJieYongJie","followers_url":"https://api.github.com/users/YongJieYongJie/followers","following_url":"https://api.github.com/users/YongJieYongJie/following{/other_user}","gists_url":"https://api.github.com/users/YongJieYongJie/gists{/gist_id}","starred_url":"https://api.github.com/users/YongJieYongJie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YongJieYongJie/subscriptions","organizations_url":"https://api.github.com/users/YongJieYongJie/orgs","repos_url":"https://api.github.com/users/YongJieYongJie/repos","events_url":"https://api.github.com/users/YongJieYongJie/events{/privacy}","received_events_url":"https://api.github.com/users/YongJieYongJie/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T04:42:22Z","updated_at":"2016-10-09T04:42:22Z","body":"@damithc I think the suggested fixes requires quite a major change in the underlying system and I will not have the time.\r\n\r\nSpecifically, I can't easily make the page only show responses for changes in visibility options because\r\n - The current approach is apparent broken (i.e., sometimes the message is not shown), hence this PR. So we should fix the current approach before relying on it to show messages only for visibility changes.\r\n - The alternative is to revamp the whole approach for showing warning messages, but this will likely require much more time, and may be more error prone.\r\n\r\nAlso, can you elaborate more on what you mean by \"disable response deletion altogether\"?"}}
{"actor":{"display_login":"YongJieYongJie"}}