{"action":"created","comment":{"url":"https://api.github.com/repos/CometVisu/CometVisu/pulls/comments/67714743","id":67714743,"diff_hunk":"@@ -1,74 +1,82 @@\n-/* Audio.js \n- * \n- * copyright (c) 2010-2016, Christian Mayer and the CometVisu contributers.\n- * \n- * This program is free software; you can redistribute it and/or modify it\n- * under the terms of the GNU General Public License as published by the Free\n- * Software Foundation; either version 3 of the License, or (at your option)\n- * any later version.\n- *\n- * This program is distributed in the hope that it will be useful, but WITHOUT\n- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for\n- * more details.\n- *\n- * You should have received a copy of the GNU General Public License along\n- * with this program; if not, write to the Free Software Foundation, Inc.,\n- * 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA\n- *\n- * @module Audio \n- * @title  CometVisu Audio \n- */\n-\n-\n-/**\n- * @author Markus Damman\n- * @since 2014\n- */\n-define( ['_common'], function( design ) {\n-  \"use strict\";\n-  var basicdesign = design.basicdesign;\n-  \n-  design.basicdesign.addCreator('audio', {\n-  create: function( element, path, flavour, type ) {\n-    var $e = $(element);\n-\n-    // create the main structure\n-    var ret_val = basicdesign.createDefaultWidget( 'audio', $e, path, flavour, type, this.update);\n-    // and fill in widget specific data\n-    var data = templateEngine.widgetDataInsert( path, {\n-      'src'     : $e.attr('src'),\n-      'id'      : $e.attr('id'),\n-      'width'   : $e.attr('width'),\n-      'height'  : $e.attr('height'),\n-      'autoplay': $e.attr('autoplay'),\n-      'loop'    : $e.attr('loop'),\n-      'threshold_value'  : $e.attr('threshold_value' ) || 1\n-    } );\n-\n-    // create the actor\n-    var style = '';\n-    if( data.width  ) style += 'width:'  + data.width  + ';';\n-    if( data.height ) style += 'height:' + data.height + ';';\n-    if( style != '' ) style = 'style=\"' + style + '\"';\n-    var autoplay = (data.autoplay == 'true') ? ' autoplay ' : '';\n-    var loop = (data.loop == 'true') ? ' loop ' : '';\n-    var actor = '<div class=\"actor\"><audio id=\"' + $e.attr('id') + '\" ' + autoplay + loop + style + ' controls> <source src=\"' +$e.attr('src') + '\" > </audio> </div>';\n-    return ret_val + actor + '</div>';\n-  },\n-  \n-  update: function(e,d) {\n-    var element = $(this);\n-    var actor   = element.find('.actor');\n-    var value = basicdesign.defaultUpdate( e, d, element, true, element.parent().attr('id') );\n-    var data  = templateEngine.widgetDataGetByElement( element );\n-    var on = templateEngine.map( data[ 'threshold_value' ], data['mapping'] );\n-    if (value >= on){\n-      var audioWidget = document.getElementById(data['id']);\n-      if (audioWidget.paused == true)\n-        audioWidget.play();\n-    };\n-  }\n-});\n-\n+/* Audio.js \r\n+ * \r\n+ * copyright (c) 2010-2016, Christian Mayer and the CometVisu contributers.\r\n+ * \r\n+ * This program is free software; you can redistribute it and/or modify it\r\n+ * under the terms of the GNU General Public License as published by the Free\r\n+ * Software Foundation; either version 3 of the License, or (at your option)\r\n+ * any later version.\r\n+ *\r\n+ * This program is distributed in the hope that it will be useful, but WITHOUT\r\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\r\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for\r\n+ * more details.\r\n+ *\r\n+ * You should have received a copy of the GNU General Public License along\r\n+ * with this program; if not, write to the Free Software Foundation, Inc.,\r\n+ * 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA\r\n+ *\r\n+ * @module Audio \r\n+ * @title  CometVisu Audio \r\n+ */\r\n+\r\n+\r\n+/**\r\n+ * @author Markus Damman\r\n+ * @since 2014\r\n+ */\r\n+define( ['_common'], function( design ) {\r\n+  \"use strict\";\r\n+  var basicdesign = design.basicdesign;\r\n+  \r\n+  design.basicdesign.addCreator('audio', {\r\n+  create: function( element, path, flavour, type ) {\r\n+    var $e = $(element);\r\n+\r\n+    // create the main structure\r\n+    var ret_val = basicdesign.createDefaultWidget( 'audio', $e, path, flavour, type, this.update);\r\n+    // and fill in widget specific data\r\n+    var data = templateEngine.widgetDataInsert( path, {\r\n+      'src'     : $e.attr('src'),\r\n+      'id'      : $e.attr('id'),\r\n+      'width'   : $e.attr('width'),\r\n+      'height'  : $e.attr('height'),\r\n+      'autoplay': $e.attr('autoplay'),\r\n+      'loop'    : $e.attr('loop'),\r\n+      'allwaysreload' : $e.attr('allwaysreload') ,\r\n+      'threshold_value'  : $e.attr('threshold_value' ) || 1\r\n+    } );\r\n+\r\n+    // create the actor\r\n+    var style = '';\r\n+    if( data.width  ) style += 'width:'  + data.width  + ';';\r\n+    if( data.height ) style += 'height:' + data.height + ';';\r\n+    if( style != '' ) style = 'style=\"' + style + '\"';\r\n+    var autoplay = (data.autoplay == 'true') ? ' autoplay ' : '';\r\n+    var loop = (data.loop == 'true') ? ' loop ' : '';\r\n+    var actor = '<div class=\"actor\"><audio id=\"' + $e.attr('id') + '\" ' + autoplay + loop + style + ' controls> <source src=\"' +$e.attr('src') + '\" > </audio> </div>';\r\n+\r\n+    return ret_val + actor + '</div>';\r\n+  },\r\n+  \r\n+  update: function(e,d) {\r\n+    var element = $(this);\r\n+    var actor   = element.find('.actor');\r\n+    var value = basicdesign.defaultUpdate( e, d, element, true, element.parent().attr('id') );\r\n+    var data  = templateEngine.widgetDataGetByElement( element );\r\n+    var on = templateEngine.map( data[ 'threshold_value' ], data['mapping'] );\r\n+    if (value >= on){\r\n+      var audioWidget = document.getElementById(data['id']);\r\n+      if (data[ 'allwaysreload' ] == 'true'){\r","path":"src/structure/pure/Audio.js","position":143,"original_position":143,"commit_id":"dda3c6e3dac7414f06345f1392be185a2af33495","original_commit_id":"dda3c6e3dac7414f06345f1392be185a2af33495","user":{"login":"peuter","id":5507035,"avatar_url":"https://avatars.githubusercontent.com/u/5507035?v=3","gravatar_id":"","url":"https://api.github.com/users/peuter","html_url":"https://github.com/peuter","followers_url":"https://api.github.com/users/peuter/followers","following_url":"https://api.github.com/users/peuter/following{/other_user}","gists_url":"https://api.github.com/users/peuter/gists{/gist_id}","starred_url":"https://api.github.com/users/peuter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peuter/subscriptions","organizations_url":"https://api.github.com/users/peuter/orgs","repos_url":"https://api.github.com/users/peuter/repos","events_url":"https://api.github.com/users/peuter/events{/privacy}","received_events_url":"https://api.github.com/users/peuter/received_events","type":"User","site_admin":false},"body":"typo: must be alwaysreload","created_at":"2016-06-20T15:53:36Z","updated_at":"2016-06-20T15:53:36Z","html_url":"https://github.com/CometVisu/CometVisu/pull/352#discussion_r67714743","pull_request_url":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352","_links":{"self":{"href":"https://api.github.com/repos/CometVisu/CometVisu/pulls/comments/67714743"},"html":{"href":"https://github.com/CometVisu/CometVisu/pull/352#discussion_r67714743"},"pull_request":{"href":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352","id":74371203,"html_url":"https://github.com/CometVisu/CometVisu/pull/352","diff_url":"https://github.com/CometVisu/CometVisu/pull/352.diff","patch_url":"https://github.com/CometVisu/CometVisu/pull/352.patch","issue_url":"https://api.github.com/repos/CometVisu/CometVisu/issues/352","number":352,"state":"open","locked":false,"title":"Enhance audio widget with allwaysreload","user":{"login":"jensgulow","id":5845040,"avatar_url":"https://avatars.githubusercontent.com/u/5845040?v=3","gravatar_id":"","url":"https://api.github.com/users/jensgulow","html_url":"https://github.com/jensgulow","followers_url":"https://api.github.com/users/jensgulow/followers","following_url":"https://api.github.com/users/jensgulow/following{/other_user}","gists_url":"https://api.github.com/users/jensgulow/gists{/gist_id}","starred_url":"https://api.github.com/users/jensgulow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensgulow/subscriptions","organizations_url":"https://api.github.com/users/jensgulow/orgs","repos_url":"https://api.github.com/users/jensgulow/repos","events_url":"https://api.github.com/users/jensgulow/events{/privacy}","received_events_url":"https://api.github.com/users/jensgulow/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-19T19:01:27Z","updated_at":"2016-06-20T15:53:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6441c9a82b18c0b3a4320e1479d8687c8c10b296","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352/commits","review_comments_url":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352/comments","review_comment_url":"https://api.github.com/repos/CometVisu/CometVisu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CometVisu/CometVisu/issues/352/comments","statuses_url":"https://api.github.com/repos/CometVisu/CometVisu/statuses/dda3c6e3dac7414f06345f1392be185a2af33495","head":{"label":"jensgulow:enhance_audio_widget_with_refresh","ref":"enhance_audio_widget_with_refresh","sha":"dda3c6e3dac7414f06345f1392be185a2af33495","user":{"login":"jensgulow","id":5845040,"avatar_url":"https://avatars.githubusercontent.com/u/5845040?v=3","gravatar_id":"","url":"https://api.github.com/users/jensgulow","html_url":"https://github.com/jensgulow","followers_url":"https://api.github.com/users/jensgulow/followers","following_url":"https://api.github.com/users/jensgulow/following{/other_user}","gists_url":"https://api.github.com/users/jensgulow/gists{/gist_id}","starred_url":"https://api.github.com/users/jensgulow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensgulow/subscriptions","organizations_url":"https://api.github.com/users/jensgulow/orgs","repos_url":"https://api.github.com/users/jensgulow/repos","events_url":"https://api.github.com/users/jensgulow/events{/privacy}","received_events_url":"https://api.github.com/users/jensgulow/received_events","type":"User","site_admin":false},"repo":{"id":33386332,"name":"CometVisu","full_name":"jensgulow/CometVisu","owner":{"login":"jensgulow","id":5845040,"avatar_url":"https://avatars.githubusercontent.com/u/5845040?v=3","gravatar_id":"","url":"https://api.github.com/users/jensgulow","html_url":"https://github.com/jensgulow","followers_url":"https://api.github.com/users/jensgulow/followers","following_url":"https://api.github.com/users/jensgulow/following{/other_user}","gists_url":"https://api.github.com/users/jensgulow/gists{/gist_id}","starred_url":"https://api.github.com/users/jensgulow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jensgulow/subscriptions","organizations_url":"https://api.github.com/users/jensgulow/orgs","repos_url":"https://api.github.com/users/jensgulow/repos","events_url":"https://api.github.com/users/jensgulow/events{/privacy}","received_events_url":"https://api.github.com/users/jensgulow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jensgulow/CometVisu","description":"Repository for the CometVisu building automation visualisation.","fork":true,"url":"https://api.github.com/repos/jensgulow/CometVisu","forks_url":"https://api.github.com/repos/jensgulow/CometVisu/forks","keys_url":"https://api.github.com/repos/jensgulow/CometVisu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jensgulow/CometVisu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jensgulow/CometVisu/teams","hooks_url":"https://api.github.com/repos/jensgulow/CometVisu/hooks","issue_events_url":"https://api.github.com/repos/jensgulow/CometVisu/issues/events{/number}","events_url":"https://api.github.com/repos/jensgulow/CometVisu/events","assignees_url":"https://api.github.com/repos/jensgulow/CometVisu/assignees{/user}","branches_url":"https://api.github.com/repos/jensgulow/CometVisu/branches{/branch}","tags_url":"https://api.github.com/repos/jensgulow/CometVisu/tags","blobs_url":"https://api.github.com/repos/jensgulow/CometVisu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jensgulow/CometVisu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jensgulow/CometVisu/git/refs{/sha}","trees_url":"https://api.github.com/repos/jensgulow/CometVisu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jensgulow/CometVisu/statuses/{sha}","languages_url":"https://api.github.com/repos/jensgulow/CometVisu/languages","stargazers_url":"https://api.github.com/repos/jensgulow/CometVisu/stargazers","contributors_url":"https://api.github.com/repos/jensgulow/CometVisu/contributors","subscribers_url":"https://api.github.com/repos/jensgulow/CometVisu/subscribers","subscription_url":"https://api.github.com/repos/jensgulow/CometVisu/subscription","commits_url":"https://api.github.com/repos/jensgulow/CometVisu/commits{/sha}","git_commits_url":"https://api.github.com/repos/jensgulow/CometVisu/git/commits{/sha}","comments_url":"https://api.github.com/repos/jensgulow/CometVisu/comments{/number}","issue_comment_url":"https://api.github.com/repos/jensgulow/CometVisu/issues/comments{/number}","contents_url":"https://api.github.com/repos/jensgulow/CometVisu/contents/{+path}","compare_url":"https://api.github.com/repos/jensgulow/CometVisu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jensgulow/CometVisu/merges","archive_url":"https://api.github.com/repos/jensgulow/CometVisu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jensgulow/CometVisu/downloads","issues_url":"https://api.github.com/repos/jensgulow/CometVisu/issues{/number}","pulls_url":"https://api.github.com/repos/jensgulow/CometVisu/pulls{/number}","milestones_url":"https://api.github.com/repos/jensgulow/CometVisu/milestones{/number}","notifications_url":"https://api.github.com/repos/jensgulow/CometVisu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jensgulow/CometVisu/labels{/name}","releases_url":"https://api.github.com/repos/jensgulow/CometVisu/releases{/id}","deployments_url":"https://api.github.com/repos/jensgulow/CometVisu/deployments","created_at":"2015-04-03T22:48:25Z","updated_at":"2016-04-23T20:32:30Z","pushed_at":"2016-06-19T18:59:28Z","git_url":"git://github.com/jensgulow/CometVisu.git","ssh_url":"git@github.com:jensgulow/CometVisu.git","clone_url":"https://github.com/jensgulow/CometVisu.git","svn_url":"https://github.com/jensgulow/CometVisu","homepage":"http://www.cometvisu.org/","size":58980,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CometVisu:develop","ref":"develop","sha":"6aefa4dbc147b6e99afced44dbd988e481ced121","user":{"login":"CometVisu","id":10695760,"avatar_url":"https://avatars.githubusercontent.com/u/10695760?v=3","gravatar_id":"","url":"https://api.github.com/users/CometVisu","html_url":"https://github.com/CometVisu","followers_url":"https://api.github.com/users/CometVisu/followers","following_url":"https://api.github.com/users/CometVisu/following{/other_user}","gists_url":"https://api.github.com/users/CometVisu/gists{/gist_id}","starred_url":"https://api.github.com/users/CometVisu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CometVisu/subscriptions","organizations_url":"https://api.github.com/users/CometVisu/orgs","repos_url":"https://api.github.com/users/CometVisu/repos","events_url":"https://api.github.com/users/CometVisu/events{/privacy}","received_events_url":"https://api.github.com/users/CometVisu/received_events","type":"Organization","site_admin":false},"repo":{"id":29815410,"name":"CometVisu","full_name":"CometVisu/CometVisu","owner":{"login":"CometVisu","id":10695760,"avatar_url":"https://avatars.githubusercontent.com/u/10695760?v=3","gravatar_id":"","url":"https://api.github.com/users/CometVisu","html_url":"https://github.com/CometVisu","followers_url":"https://api.github.com/users/CometVisu/followers","following_url":"https://api.github.com/users/CometVisu/following{/other_user}","gists_url":"https://api.github.com/users/CometVisu/gists{/gist_id}","starred_url":"https://api.github.com/users/CometVisu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CometVisu/subscriptions","organizations_url":"https://api.github.com/users/CometVisu/orgs","repos_url":"https://api.github.com/users/CometVisu/repos","events_url":"https://api.github.com/users/CometVisu/events{/privacy}","received_events_url":"https://api.github.com/users/CometVisu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CometVisu/CometVisu","description":"Repository for the CometVisu building automation visualisation.","fork":false,"url":"https://api.github.com/repos/CometVisu/CometVisu","forks_url":"https://api.github.com/repos/CometVisu/CometVisu/forks","keys_url":"https://api.github.com/repos/CometVisu/CometVisu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CometVisu/CometVisu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CometVisu/CometVisu/teams","hooks_url":"https://api.github.com/repos/CometVisu/CometVisu/hooks","issue_events_url":"https://api.github.com/repos/CometVisu/CometVisu/issues/events{/number}","events_url":"https://api.github.com/repos/CometVisu/CometVisu/events","assignees_url":"https://api.github.com/repos/CometVisu/CometVisu/assignees{/user}","branches_url":"https://api.github.com/repos/CometVisu/CometVisu/branches{/branch}","tags_url":"https://api.github.com/repos/CometVisu/CometVisu/tags","blobs_url":"https://api.github.com/repos/CometVisu/CometVisu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CometVisu/CometVisu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CometVisu/CometVisu/git/refs{/sha}","trees_url":"https://api.github.com/repos/CometVisu/CometVisu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CometVisu/CometVisu/statuses/{sha}","languages_url":"https://api.github.com/repos/CometVisu/CometVisu/languages","stargazers_url":"https://api.github.com/repos/CometVisu/CometVisu/stargazers","contributors_url":"https://api.github.com/repos/CometVisu/CometVisu/contributors","subscribers_url":"https://api.github.com/repos/CometVisu/CometVisu/subscribers","subscription_url":"https://api.github.com/repos/CometVisu/CometVisu/subscription","commits_url":"https://api.github.com/repos/CometVisu/CometVisu/commits{/sha}","git_commits_url":"https://api.github.com/repos/CometVisu/CometVisu/git/commits{/sha}","comments_url":"https://api.github.com/repos/CometVisu/CometVisu/comments{/number}","issue_comment_url":"https://api.github.com/repos/CometVisu/CometVisu/issues/comments{/number}","contents_url":"https://api.github.com/repos/CometVisu/CometVisu/contents/{+path}","compare_url":"https://api.github.com/repos/CometVisu/CometVisu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CometVisu/CometVisu/merges","archive_url":"https://api.github.com/repos/CometVisu/CometVisu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CometVisu/CometVisu/downloads","issues_url":"https://api.github.com/repos/CometVisu/CometVisu/issues{/number}","pulls_url":"https://api.github.com/repos/CometVisu/CometVisu/pulls{/number}","milestones_url":"https://api.github.com/repos/CometVisu/CometVisu/milestones{/number}","notifications_url":"https://api.github.com/repos/CometVisu/CometVisu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CometVisu/CometVisu/labels{/name}","releases_url":"https://api.github.com/repos/CometVisu/CometVisu/releases{/id}","deployments_url":"https://api.github.com/repos/CometVisu/CometVisu/deployments","created_at":"2015-01-25T13:46:53Z","updated_at":"2016-02-25T09:09:20Z","pushed_at":"2016-06-20T13:28:41Z","git_url":"git://github.com/CometVisu/CometVisu.git","ssh_url":"git@github.com:CometVisu/CometVisu.git","clone_url":"https://github.com/CometVisu/CometVisu.git","svn_url":"https://github.com/CometVisu/CometVisu","homepage":"http://www.cometvisu.org/","size":88303,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":54,"forks":43,"open_issues":54,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352"},"html":{"href":"https://github.com/CometVisu/CometVisu/pull/352"},"issue":{"href":"https://api.github.com/repos/CometVisu/CometVisu/issues/352"},"comments":{"href":"https://api.github.com/repos/CometVisu/CometVisu/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/CometVisu/CometVisu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CometVisu/CometVisu/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/CometVisu/CometVisu/statuses/dda3c6e3dac7414f06345f1392be185a2af33495"}}}}
{"actor":{"display_login":"peuter"}}