{"action":"created","comment":{"url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments/69900214","id":69900214,"diff_hunk":"@@ -5457,33 +5457,21 @@ void Spell::EffectScriptEffect(SpellEffectIndex eff_idx)\n                     unitTarget->RemoveAurasAtMechanicImmunity(IMMUNE_TO_ROOT_AND_SNARE_MASK, 30918, true);\n                     break;\n                 }\n-                \n-                \n-                case 32027:\t\t\t\t// Expedition Flare\n-\t\t\t{\n-\t\t\t\tif (!unitTarget)\n-\t\t\t\t\treturn;\n-\n-\t\t\t\tuint32 creature_id;\n-\t\t\t\tuint32 rand = urand(0, 99);\n-\n-\t\t\t\t//summon Expedition Preserver or Expedition Scout \n-\t\t\t\tif (rand < 50)\n-\t\t\t\t\tcreature_id = 18194;\n-\t\t\t\telse \n-\t\t\t\t\tcreature_id = 18126;\n-\t\t\n-\t\t\t\tfloat angle = unitTarget->GetOrientation();\n-\t\t\t\n-\t\t\t\tCreature* pCreature = m_caster->SummonCreature(creature_id, 0.0f, 0.0f, 0.0f, angle, TEMPSUMMON_TIMED_OOC_OR_DEAD_DESPAWN, 60000, true);\n-\n-\t\t\t\tif (pCreature->AI())\n-\t\t\t\t\tpCreature->AI()->AttackStart(m_caster->getVictim());\n-\t\t\t\treturn;\n-\n-\t\t\t}\n-                \n-        \n+                case 32027:                                 // Expedition Flare\n+                {\n+                    if (!unitTarget)\n+                        return;\n+\n+                    uint32 creature_id = urand(0, 1)\n+                                         ? 18194    //summon Expedition Preserver\n+                                         : 18126;   //summon Expedition Scout\n+\n+                    Creature* creature = m_caster->SummonCreature(creature_id, 0.0f, 0.0f, 0.0f, unitTarget->GetOrientation(), TEMPSUMMON_TIMED_OOC_OR_DEAD_DESPAWN, 60000);","path":"src/game/SpellEffects.cpp","position":13,"original_position":40,"commit_id":"fbcb1442b6f326bf6272a38aebf02336df4e39ed","original_commit_id":"fbcb1442b6f326bf6272a38aebf02336df4e39ed","user":{"login":"killerwife","id":7995382,"avatar_url":"https://avatars.githubusercontent.com/u/7995382?v=3","gravatar_id":"","url":"https://api.github.com/users/killerwife","html_url":"https://github.com/killerwife","followers_url":"https://api.github.com/users/killerwife/followers","following_url":"https://api.github.com/users/killerwife/following{/other_user}","gists_url":"https://api.github.com/users/killerwife/gists{/gist_id}","starred_url":"https://api.github.com/users/killerwife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerwife/subscriptions","organizations_url":"https://api.github.com/users/killerwife/orgs","repos_url":"https://api.github.com/users/killerwife/repos","events_url":"https://api.github.com/users/killerwife/events{/privacy}","received_events_url":"https://api.github.com/users/killerwife/received_events","type":"User","site_admin":false},"body":"Have you tried using the dummy effect and look at what m_Targets points to? its dynamic_object_front if i remember correctly, which under some circumstances could give proper location for creature summon, rather than in the caster\r\nif it doesnt work, try to change it so that the creature is summoned next to caster","created_at":"2016-07-07T12:52:33Z","updated_at":"2016-07-07T12:52:33Z","html_url":"https://github.com/cmangos/mangos-tbc/pull/73#discussion_r69900214","pull_request_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments/69900214"},"html":{"href":"https://github.com/cmangos/mangos-tbc/pull/73#discussion_r69900214"},"pull_request":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73","id":76514134,"html_url":"https://github.com/cmangos/mangos-tbc/pull/73","diff_url":"https://github.com/cmangos/mangos-tbc/pull/73.diff","patch_url":"https://github.com/cmangos/mangos-tbc/pull/73.patch","issue_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/73","number":73,"state":"open","locked":false,"title":"[ITEM] Expedition flare not working","user":{"login":"Ccaz","id":18302340,"avatar_url":"https://avatars.githubusercontent.com/u/18302340?v=3","gravatar_id":"","url":"https://api.github.com/users/Ccaz","html_url":"https://github.com/Ccaz","followers_url":"https://api.github.com/users/Ccaz/followers","following_url":"https://api.github.com/users/Ccaz/following{/other_user}","gists_url":"https://api.github.com/users/Ccaz/gists{/gist_id}","starred_url":"https://api.github.com/users/Ccaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ccaz/subscriptions","organizations_url":"https://api.github.com/users/Ccaz/orgs","repos_url":"https://api.github.com/users/Ccaz/repos","events_url":"https://api.github.com/users/Ccaz/events{/privacy}","received_events_url":"https://api.github.com/users/Ccaz/received_events","type":"User","site_admin":false},"body":"Item Expedition Flare summons either an Expedition Preserver or Expedition Scout to assist the Player.","created_at":"2016-07-06T22:42:39Z","updated_at":"2016-07-07T12:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcdccae701d9dc5854a4f88d83fafffac26f0dcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73/commits","review_comments_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73/comments","review_comment_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/73/comments","statuses_url":"https://api.github.com/repos/cmangos/mangos-tbc/statuses/fbcb1442b6f326bf6272a38aebf02336df4e39ed","head":{"label":"Ccaz:master","ref":"master","sha":"fbcb1442b6f326bf6272a38aebf02336df4e39ed","user":{"login":"Ccaz","id":18302340,"avatar_url":"https://avatars.githubusercontent.com/u/18302340?v=3","gravatar_id":"","url":"https://api.github.com/users/Ccaz","html_url":"https://github.com/Ccaz","followers_url":"https://api.github.com/users/Ccaz/followers","following_url":"https://api.github.com/users/Ccaz/following{/other_user}","gists_url":"https://api.github.com/users/Ccaz/gists{/gist_id}","starred_url":"https://api.github.com/users/Ccaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ccaz/subscriptions","organizations_url":"https://api.github.com/users/Ccaz/orgs","repos_url":"https://api.github.com/users/Ccaz/repos","events_url":"https://api.github.com/users/Ccaz/events{/privacy}","received_events_url":"https://api.github.com/users/Ccaz/received_events","type":"User","site_admin":false},"repo":{"id":62757817,"name":"mangos-tbc","full_name":"Ccaz/mangos-tbc","owner":{"login":"Ccaz","id":18302340,"avatar_url":"https://avatars.githubusercontent.com/u/18302340?v=3","gravatar_id":"","url":"https://api.github.com/users/Ccaz","html_url":"https://github.com/Ccaz","followers_url":"https://api.github.com/users/Ccaz/followers","following_url":"https://api.github.com/users/Ccaz/following{/other_user}","gists_url":"https://api.github.com/users/Ccaz/gists{/gist_id}","starred_url":"https://api.github.com/users/Ccaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ccaz/subscriptions","organizations_url":"https://api.github.com/users/Ccaz/orgs","repos_url":"https://api.github.com/users/Ccaz/repos","events_url":"https://api.github.com/users/Ccaz/events{/privacy}","received_events_url":"https://api.github.com/users/Ccaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ccaz/mangos-tbc","description":"C(ontinued)-MaNGOS is about: -- Doing WoW-Emulation Right! ","fork":true,"url":"https://api.github.com/repos/Ccaz/mangos-tbc","forks_url":"https://api.github.com/repos/Ccaz/mangos-tbc/forks","keys_url":"https://api.github.com/repos/Ccaz/mangos-tbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ccaz/mangos-tbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ccaz/mangos-tbc/teams","hooks_url":"https://api.github.com/repos/Ccaz/mangos-tbc/hooks","issue_events_url":"https://api.github.com/repos/Ccaz/mangos-tbc/issues/events{/number}","events_url":"https://api.github.com/repos/Ccaz/mangos-tbc/events","assignees_url":"https://api.github.com/repos/Ccaz/mangos-tbc/assignees{/user}","branches_url":"https://api.github.com/repos/Ccaz/mangos-tbc/branches{/branch}","tags_url":"https://api.github.com/repos/Ccaz/mangos-tbc/tags","blobs_url":"https://api.github.com/repos/Ccaz/mangos-tbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ccaz/mangos-tbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ccaz/mangos-tbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ccaz/mangos-tbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ccaz/mangos-tbc/statuses/{sha}","languages_url":"https://api.github.com/repos/Ccaz/mangos-tbc/languages","stargazers_url":"https://api.github.com/repos/Ccaz/mangos-tbc/stargazers","contributors_url":"https://api.github.com/repos/Ccaz/mangos-tbc/contributors","subscribers_url":"https://api.github.com/repos/Ccaz/mangos-tbc/subscribers","subscription_url":"https://api.github.com/repos/Ccaz/mangos-tbc/subscription","commits_url":"https://api.github.com/repos/Ccaz/mangos-tbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ccaz/mangos-tbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ccaz/mangos-tbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ccaz/mangos-tbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ccaz/mangos-tbc/contents/{+path}","compare_url":"https://api.github.com/repos/Ccaz/mangos-tbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ccaz/mangos-tbc/merges","archive_url":"https://api.github.com/repos/Ccaz/mangos-tbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ccaz/mangos-tbc/downloads","issues_url":"https://api.github.com/repos/Ccaz/mangos-tbc/issues{/number}","pulls_url":"https://api.github.com/repos/Ccaz/mangos-tbc/pulls{/number}","milestones_url":"https://api.github.com/repos/Ccaz/mangos-tbc/milestones{/number}","notifications_url":"https://api.github.com/repos/Ccaz/mangos-tbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ccaz/mangos-tbc/labels{/name}","releases_url":"https://api.github.com/repos/Ccaz/mangos-tbc/releases{/id}","deployments_url":"https://api.github.com/repos/Ccaz/mangos-tbc/deployments","created_at":"2016-07-06T22:37:33Z","updated_at":"2016-07-06T22:37:44Z","pushed_at":"2016-07-07T12:35:41Z","git_url":"git://github.com/Ccaz/mangos-tbc.git","ssh_url":"git@github.com:Ccaz/mangos-tbc.git","clone_url":"https://github.com/Ccaz/mangos-tbc.git","svn_url":"https://github.com/Ccaz/mangos-tbc","homepage":"http://cmangos.net","size":53040,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmangos:master","ref":"master","sha":"330851078a1ad134e27715a1bfce57438b9beeb9","user":{"login":"cmangos","id":2212917,"avatar_url":"https://avatars.githubusercontent.com/u/2212917?v=3","gravatar_id":"","url":"https://api.github.com/users/cmangos","html_url":"https://github.com/cmangos","followers_url":"https://api.github.com/users/cmangos/followers","following_url":"https://api.github.com/users/cmangos/following{/other_user}","gists_url":"https://api.github.com/users/cmangos/gists{/gist_id}","starred_url":"https://api.github.com/users/cmangos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmangos/subscriptions","organizations_url":"https://api.github.com/users/cmangos/orgs","repos_url":"https://api.github.com/users/cmangos/repos","events_url":"https://api.github.com/users/cmangos/events{/privacy}","received_events_url":"https://api.github.com/users/cmangos/received_events","type":"Organization","site_admin":false},"repo":{"id":6829204,"name":"mangos-tbc","full_name":"cmangos/mangos-tbc","owner":{"login":"cmangos","id":2212917,"avatar_url":"https://avatars.githubusercontent.com/u/2212917?v=3","gravatar_id":"","url":"https://api.github.com/users/cmangos","html_url":"https://github.com/cmangos","followers_url":"https://api.github.com/users/cmangos/followers","following_url":"https://api.github.com/users/cmangos/following{/other_user}","gists_url":"https://api.github.com/users/cmangos/gists{/gist_id}","starred_url":"https://api.github.com/users/cmangos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmangos/subscriptions","organizations_url":"https://api.github.com/users/cmangos/orgs","repos_url":"https://api.github.com/users/cmangos/repos","events_url":"https://api.github.com/users/cmangos/events{/privacy}","received_events_url":"https://api.github.com/users/cmangos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmangos/mangos-tbc","description":"C(ontinued)-MaNGOS is about: -- Doing WoW-Emulation Right! ","fork":false,"url":"https://api.github.com/repos/cmangos/mangos-tbc","forks_url":"https://api.github.com/repos/cmangos/mangos-tbc/forks","keys_url":"https://api.github.com/repos/cmangos/mangos-tbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmangos/mangos-tbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmangos/mangos-tbc/teams","hooks_url":"https://api.github.com/repos/cmangos/mangos-tbc/hooks","issue_events_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/events{/number}","events_url":"https://api.github.com/repos/cmangos/mangos-tbc/events","assignees_url":"https://api.github.com/repos/cmangos/mangos-tbc/assignees{/user}","branches_url":"https://api.github.com/repos/cmangos/mangos-tbc/branches{/branch}","tags_url":"https://api.github.com/repos/cmangos/mangos-tbc/tags","blobs_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmangos/mangos-tbc/statuses/{sha}","languages_url":"https://api.github.com/repos/cmangos/mangos-tbc/languages","stargazers_url":"https://api.github.com/repos/cmangos/mangos-tbc/stargazers","contributors_url":"https://api.github.com/repos/cmangos/mangos-tbc/contributors","subscribers_url":"https://api.github.com/repos/cmangos/mangos-tbc/subscribers","subscription_url":"https://api.github.com/repos/cmangos/mangos-tbc/subscription","commits_url":"https://api.github.com/repos/cmangos/mangos-tbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmangos/mangos-tbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmangos/mangos-tbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmangos/mangos-tbc/contents/{+path}","compare_url":"https://api.github.com/repos/cmangos/mangos-tbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmangos/mangos-tbc/merges","archive_url":"https://api.github.com/repos/cmangos/mangos-tbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmangos/mangos-tbc/downloads","issues_url":"https://api.github.com/repos/cmangos/mangos-tbc/issues{/number}","pulls_url":"https://api.github.com/repos/cmangos/mangos-tbc/pulls{/number}","milestones_url":"https://api.github.com/repos/cmangos/mangos-tbc/milestones{/number}","notifications_url":"https://api.github.com/repos/cmangos/mangos-tbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmangos/mangos-tbc/labels{/name}","releases_url":"https://api.github.com/repos/cmangos/mangos-tbc/releases{/id}","deployments_url":"https://api.github.com/repos/cmangos/mangos-tbc/deployments","created_at":"2012-11-23T15:18:26Z","updated_at":"2016-06-29T07:04:36Z","pushed_at":"2016-07-07T12:35:41Z","git_url":"git://github.com/cmangos/mangos-tbc.git","ssh_url":"git@github.com:cmangos/mangos-tbc.git","clone_url":"https://github.com/cmangos/mangos-tbc.git","svn_url":"https://github.com/cmangos/mangos-tbc","homepage":"http://cmangos.net","size":58418,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":32,"forks":192,"open_issues":32,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73"},"html":{"href":"https://github.com/cmangos/mangos-tbc/pull/73"},"issue":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/issues/73"},"comments":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/cmangos/mangos-tbc/statuses/fbcb1442b6f326bf6272a38aebf02336df4e39ed"}}}}
{"actor":{"display_login":"killerwife"}}