{"action":"created","comment":{"url":"https://api.github.com/repos/smebberson/docker-alpine/pulls/comments/62656326","id":62656326,"diff_hunk":"@@ -1,16 +1,13 @@\n #!/usr/bin/with-contenv sh\n \n-# Get the IP of the current container. We don't want this container to match itself.\n-HOST_IP=`container-ip`\n+# Get the consul IPs\n+JOIN=`container-ip consul | awk '{ printf \" -retry-join \" $0}'`","path":"alpine-consul/root/usr/bin/consul-join","position":6,"original_position":6,"commit_id":"1b4faf7f9494b615091cb0468fd1a11620c7ba8a","original_commit_id":"1b4faf7f9494b615091cb0468fd1a11620c7ba8a","user":{"login":"smebberson","id":74628,"avatar_url":"https://avatars.githubusercontent.com/u/74628?v=3","gravatar_id":"","url":"https://api.github.com/users/smebberson","html_url":"https://github.com/smebberson","followers_url":"https://api.github.com/users/smebberson/followers","following_url":"https://api.github.com/users/smebberson/following{/other_user}","gists_url":"https://api.github.com/users/smebberson/gists{/gist_id}","starred_url":"https://api.github.com/users/smebberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smebberson/subscriptions","organizations_url":"https://api.github.com/users/smebberson/orgs","repos_url":"https://api.github.com/users/smebberson/repos","events_url":"https://api.github.com/users/smebberson/events{/privacy}","received_events_url":"https://api.github.com/users/smebberson/received_events","type":"User","site_admin":false},"body":"I think `consul-join`:\r\n\r\n```\r\n #!/usr/bin/with-contenv sh\r\n \r\n-# Get the IP of the current container. We don't want this container to match itself.\r\n-HOST_IP=`container-ip`\r\n+# Get the consul IPs\r\n+JOIN=`container-ip consul | awk '{ printf $0}'`\r\n```\r\n\r\nand `run` scripts should have the flag back in-place:\r\n\r\n```\r\ns6-setuidgid consul consul agent -config-dir /etc/consul.d -client $BIND -retry-join $JOIN -retry-interval 5s -ui\r\n```","created_at":"2016-05-10T11:43:38Z","updated_at":"2016-05-10T11:43:38Z","html_url":"https://github.com/smebberson/docker-alpine/pull/47#discussion_r62656326","pull_request_url":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/smebberson/docker-alpine/pulls/comments/62656326"},"html":{"href":"https://github.com/smebberson/docker-alpine/pull/47#discussion_r62656326"},"pull_request":{"href":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47","id":69464217,"html_url":"https://github.com/smebberson/docker-alpine/pull/47","diff_url":"https://github.com/smebberson/docker-alpine/pull/47.diff","patch_url":"https://github.com/smebberson/docker-alpine/pull/47.patch","issue_url":"https://api.github.com/repos/smebberson/docker-alpine/issues/47","number":47,"state":"open","locked":false,"title":"Add more Consul servers to the retry-join connection string.","user":{"login":"ncornag","id":2655142,"avatar_url":"https://avatars.githubusercontent.com/u/2655142?v=3","gravatar_id":"","url":"https://api.github.com/users/ncornag","html_url":"https://github.com/ncornag","followers_url":"https://api.github.com/users/ncornag/followers","following_url":"https://api.github.com/users/ncornag/following{/other_user}","gists_url":"https://api.github.com/users/ncornag/gists{/gist_id}","starred_url":"https://api.github.com/users/ncornag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncornag/subscriptions","organizations_url":"https://api.github.com/users/ncornag/orgs","repos_url":"https://api.github.com/users/ncornag/repos","events_url":"https://api.github.com/users/ncornag/events{/privacy}","received_events_url":"https://api.github.com/users/ncornag/received_events","type":"User","site_admin":false},"body":"Add more Consul servers to the retry-join connection string.","created_at":"2016-05-10T08:07:21Z","updated_at":"2016-05-10T11:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b9ff5c283484a0b28a7bcb0f7f5374bc0452965","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47/commits","review_comments_url":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47/comments","review_comment_url":"https://api.github.com/repos/smebberson/docker-alpine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smebberson/docker-alpine/issues/47/comments","statuses_url":"https://api.github.com/repos/smebberson/docker-alpine/statuses/1b4faf7f9494b615091cb0468fd1a11620c7ba8a","head":{"label":"ncornag:alpine-consul-ui-upgrades","ref":"alpine-consul-ui-upgrades","sha":"1b4faf7f9494b615091cb0468fd1a11620c7ba8a","user":{"login":"ncornag","id":2655142,"avatar_url":"https://avatars.githubusercontent.com/u/2655142?v=3","gravatar_id":"","url":"https://api.github.com/users/ncornag","html_url":"https://github.com/ncornag","followers_url":"https://api.github.com/users/ncornag/followers","following_url":"https://api.github.com/users/ncornag/following{/other_user}","gists_url":"https://api.github.com/users/ncornag/gists{/gist_id}","starred_url":"https://api.github.com/users/ncornag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncornag/subscriptions","organizations_url":"https://api.github.com/users/ncornag/orgs","repos_url":"https://api.github.com/users/ncornag/repos","events_url":"https://api.github.com/users/ncornag/events{/privacy}","received_events_url":"https://api.github.com/users/ncornag/received_events","type":"User","site_admin":false},"repo":{"id":58062686,"name":"docker-alpine","full_name":"ncornag/docker-alpine","owner":{"login":"ncornag","id":2655142,"avatar_url":"https://avatars.githubusercontent.com/u/2655142?v=3","gravatar_id":"","url":"https://api.github.com/users/ncornag","html_url":"https://github.com/ncornag","followers_url":"https://api.github.com/users/ncornag/followers","following_url":"https://api.github.com/users/ncornag/following{/other_user}","gists_url":"https://api.github.com/users/ncornag/gists{/gist_id}","starred_url":"https://api.github.com/users/ncornag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncornag/subscriptions","organizations_url":"https://api.github.com/users/ncornag/orgs","repos_url":"https://api.github.com/users/ncornag/repos","events_url":"https://api.github.com/users/ncornag/events{/privacy}","received_events_url":"https://api.github.com/users/ncornag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncornag/docker-alpine","description":"Docker containers running Alpine linux and s6 for process management. Sold, reliable containers.","fork":true,"url":"https://api.github.com/repos/ncornag/docker-alpine","forks_url":"https://api.github.com/repos/ncornag/docker-alpine/forks","keys_url":"https://api.github.com/repos/ncornag/docker-alpine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncornag/docker-alpine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncornag/docker-alpine/teams","hooks_url":"https://api.github.com/repos/ncornag/docker-alpine/hooks","issue_events_url":"https://api.github.com/repos/ncornag/docker-alpine/issues/events{/number}","events_url":"https://api.github.com/repos/ncornag/docker-alpine/events","assignees_url":"https://api.github.com/repos/ncornag/docker-alpine/assignees{/user}","branches_url":"https://api.github.com/repos/ncornag/docker-alpine/branches{/branch}","tags_url":"https://api.github.com/repos/ncornag/docker-alpine/tags","blobs_url":"https://api.github.com/repos/ncornag/docker-alpine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncornag/docker-alpine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncornag/docker-alpine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncornag/docker-alpine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncornag/docker-alpine/statuses/{sha}","languages_url":"https://api.github.com/repos/ncornag/docker-alpine/languages","stargazers_url":"https://api.github.com/repos/ncornag/docker-alpine/stargazers","contributors_url":"https://api.github.com/repos/ncornag/docker-alpine/contributors","subscribers_url":"https://api.github.com/repos/ncornag/docker-alpine/subscribers","subscription_url":"https://api.github.com/repos/ncornag/docker-alpine/subscription","commits_url":"https://api.github.com/repos/ncornag/docker-alpine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncornag/docker-alpine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncornag/docker-alpine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncornag/docker-alpine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncornag/docker-alpine/contents/{+path}","compare_url":"https://api.github.com/repos/ncornag/docker-alpine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncornag/docker-alpine/merges","archive_url":"https://api.github.com/repos/ncornag/docker-alpine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncornag/docker-alpine/downloads","issues_url":"https://api.github.com/repos/ncornag/docker-alpine/issues{/number}","pulls_url":"https://api.github.com/repos/ncornag/docker-alpine/pulls{/number}","milestones_url":"https://api.github.com/repos/ncornag/docker-alpine/milestones{/number}","notifications_url":"https://api.github.com/repos/ncornag/docker-alpine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncornag/docker-alpine/labels{/name}","releases_url":"https://api.github.com/repos/ncornag/docker-alpine/releases{/id}","deployments_url":"https://api.github.com/repos/ncornag/docker-alpine/deployments","created_at":"2016-05-04T15:22:23Z","updated_at":"2016-05-04T15:22:24Z","pushed_at":"2016-05-10T08:06:43Z","git_url":"git://github.com/ncornag/docker-alpine.git","ssh_url":"git@github.com:ncornag/docker-alpine.git","clone_url":"https://github.com/ncornag/docker-alpine.git","svn_url":"https://github.com/ncornag/docker-alpine","homepage":"","size":316,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smebberson:alpine-consul-ui-upgrades","ref":"alpine-consul-ui-upgrades","sha":"1718e0f2267380305997e0c46276610157f6f7bb","user":{"login":"smebberson","id":74628,"avatar_url":"https://avatars.githubusercontent.com/u/74628?v=3","gravatar_id":"","url":"https://api.github.com/users/smebberson","html_url":"https://github.com/smebberson","followers_url":"https://api.github.com/users/smebberson/followers","following_url":"https://api.github.com/users/smebberson/following{/other_user}","gists_url":"https://api.github.com/users/smebberson/gists{/gist_id}","starred_url":"https://api.github.com/users/smebberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smebberson/subscriptions","organizations_url":"https://api.github.com/users/smebberson/orgs","repos_url":"https://api.github.com/users/smebberson/repos","events_url":"https://api.github.com/users/smebberson/events{/privacy}","received_events_url":"https://api.github.com/users/smebberson/received_events","type":"User","site_admin":false},"repo":{"id":34379480,"name":"docker-alpine","full_name":"smebberson/docker-alpine","owner":{"login":"smebberson","id":74628,"avatar_url":"https://avatars.githubusercontent.com/u/74628?v=3","gravatar_id":"","url":"https://api.github.com/users/smebberson","html_url":"https://github.com/smebberson","followers_url":"https://api.github.com/users/smebberson/followers","following_url":"https://api.github.com/users/smebberson/following{/other_user}","gists_url":"https://api.github.com/users/smebberson/gists{/gist_id}","starred_url":"https://api.github.com/users/smebberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smebberson/subscriptions","organizations_url":"https://api.github.com/users/smebberson/orgs","repos_url":"https://api.github.com/users/smebberson/repos","events_url":"https://api.github.com/users/smebberson/events{/privacy}","received_events_url":"https://api.github.com/users/smebberson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smebberson/docker-alpine","description":"Docker containers running Alpine linux and s6 for process management. Sold, reliable containers.","fork":false,"url":"https://api.github.com/repos/smebberson/docker-alpine","forks_url":"https://api.github.com/repos/smebberson/docker-alpine/forks","keys_url":"https://api.github.com/repos/smebberson/docker-alpine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smebberson/docker-alpine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smebberson/docker-alpine/teams","hooks_url":"https://api.github.com/repos/smebberson/docker-alpine/hooks","issue_events_url":"https://api.github.com/repos/smebberson/docker-alpine/issues/events{/number}","events_url":"https://api.github.com/repos/smebberson/docker-alpine/events","assignees_url":"https://api.github.com/repos/smebberson/docker-alpine/assignees{/user}","branches_url":"https://api.github.com/repos/smebberson/docker-alpine/branches{/branch}","tags_url":"https://api.github.com/repos/smebberson/docker-alpine/tags","blobs_url":"https://api.github.com/repos/smebberson/docker-alpine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smebberson/docker-alpine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smebberson/docker-alpine/git/refs{/sha}","trees_url":"https://api.github.com/repos/smebberson/docker-alpine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smebberson/docker-alpine/statuses/{sha}","languages_url":"https://api.github.com/repos/smebberson/docker-alpine/languages","stargazers_url":"https://api.github.com/repos/smebberson/docker-alpine/stargazers","contributors_url":"https://api.github.com/repos/smebberson/docker-alpine/contributors","subscribers_url":"https://api.github.com/repos/smebberson/docker-alpine/subscribers","subscription_url":"https://api.github.com/repos/smebberson/docker-alpine/subscription","commits_url":"https://api.github.com/repos/smebberson/docker-alpine/commits{/sha}","git_commits_url":"https://api.github.com/repos/smebberson/docker-alpine/git/commits{/sha}","comments_url":"https://api.github.com/repos/smebberson/docker-alpine/comments{/number}","issue_comment_url":"https://api.github.com/repos/smebberson/docker-alpine/issues/comments{/number}","contents_url":"https://api.github.com/repos/smebberson/docker-alpine/contents/{+path}","compare_url":"https://api.github.com/repos/smebberson/docker-alpine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smebberson/docker-alpine/merges","archive_url":"https://api.github.com/repos/smebberson/docker-alpine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smebberson/docker-alpine/downloads","issues_url":"https://api.github.com/repos/smebberson/docker-alpine/issues{/number}","pulls_url":"https://api.github.com/repos/smebberson/docker-alpine/pulls{/number}","milestones_url":"https://api.github.com/repos/smebberson/docker-alpine/milestones{/number}","notifications_url":"https://api.github.com/repos/smebberson/docker-alpine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smebberson/docker-alpine/labels{/name}","releases_url":"https://api.github.com/repos/smebberson/docker-alpine/releases{/id}","deployments_url":"https://api.github.com/repos/smebberson/docker-alpine/deployments","created_at":"2015-04-22T08:49:05Z","updated_at":"2016-05-07T12:20:17Z","pushed_at":"2016-05-10T08:07:22Z","git_url":"git://github.com/smebberson/docker-alpine.git","ssh_url":"git@github.com:smebberson/docker-alpine.git","clone_url":"https://github.com/smebberson/docker-alpine.git","svn_url":"https://github.com/smebberson/docker-alpine","homepage":"","size":430,"stargazers_count":128,"watchers_count":128,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":20,"forks":40,"open_issues":20,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47"},"html":{"href":"https://github.com/smebberson/docker-alpine/pull/47"},"issue":{"href":"https://api.github.com/repos/smebberson/docker-alpine/issues/47"},"comments":{"href":"https://api.github.com/repos/smebberson/docker-alpine/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/smebberson/docker-alpine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smebberson/docker-alpine/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/smebberson/docker-alpine/statuses/1b4faf7f9494b615091cb0468fd1a11620c7ba8a"}}}}