{"action":"created","comment":{"url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/comments/81135355","pull_request_review_id":2137009,"id":81135355,"diff_hunk":"@@ -2868,7 +2875,7 @@ maybe_resume_session(NextState, El, StateData) ->\n do_resume_session(SMID, El, [{_, Pid}], StateData) ->\n     try\n         {ok, OldState} = ?GEN_FSM:sync_send_event(Pid, resume),\n-        SID = {now(), self()},\n+        SID = {os:timestamp(), self()},","path":"apps/ejabberd/src/ejabberd_c2s.erl","position":133,"original_position":133,"commit_id":"ce18e2fd8cd59fe1667a8060cf634e8620ea1ceb","original_commit_id":"ce18e2fd8cd59fe1667a8060cf634e8620ea1ceb","user":{"login":"michalwski","id":705828,"avatar_url":"https://avatars.githubusercontent.com/u/705828?v=3","gravatar_id":"","url":"https://api.github.com/users/michalwski","html_url":"https://github.com/michalwski","followers_url":"https://api.github.com/users/michalwski/followers","following_url":"https://api.github.com/users/michalwski/following{/other_user}","gists_url":"https://api.github.com/users/michalwski/gists{/gist_id}","starred_url":"https://api.github.com/users/michalwski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalwski/subscriptions","organizations_url":"https://api.github.com/users/michalwski/orgs","repos_url":"https://api.github.com/users/michalwski/repos","events_url":"https://api.github.com/users/michalwski/events{/privacy}","received_events_url":"https://api.github.com/users/michalwski/received_events","type":"User","site_admin":false},"body":"From repository perspective and organizing commits in \"small\" and \"atomic\" changes I suggest putting all the `now()` to `os:timestamp()` transitions in a separate commit.","created_at":"2016-09-29T13:27:13Z","updated_at":"2016-09-29T13:27:13Z","html_url":"https://github.com/bartekgorny/MongooseIM/pull/1#discussion_r81135355","pull_request_url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/comments/81135355"},"html":{"href":"https://github.com/bartekgorny/MongooseIM/pull/1#discussion_r81135355"},"pull_request":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1","id":87271596,"html_url":"https://github.com/bartekgorny/MongooseIM/pull/1","diff_url":"https://github.com/bartekgorny/MongooseIM/pull/1.diff","patch_url":"https://github.com/bartekgorny/MongooseIM/pull/1.patch","issue_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/1","number":1,"state":"open","locked":false,"title":"Hooks accumulators","user":{"login":"bartekgorny","id":70064,"avatar_url":"https://avatars.githubusercontent.com/u/70064?v=3","gravatar_id":"","url":"https://api.github.com/users/bartekgorny","html_url":"https://github.com/bartekgorny","followers_url":"https://api.github.com/users/bartekgorny/followers","following_url":"https://api.github.com/users/bartekgorny/following{/other_user}","gists_url":"https://api.github.com/users/bartekgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekgorny/subscriptions","organizations_url":"https://api.github.com/users/bartekgorny/orgs","repos_url":"https://api.github.com/users/bartekgorny/repos","events_url":"https://api.github.com/users/bartekgorny/events{/privacy}","received_events_url":"https://api.github.com/users/bartekgorny/received_events","type":"User","site_admin":false},"body":"This PR addresses #980 and is only for review and discussion\r\n\r\nProposed changes include:\r\n\r\n    change to ejabberd_hooks:run so that it passes an empty map as first arg\r\n    modification to all handlers that are called by :run\r\n    modification of 20 folded hooks so that they accept and return a map\r\n    a new module for encapsulating accumulators\r\n\r\nIt is freshly rebased and passes most tests.\r\n\r\n\r\n","created_at":"2016-09-29T08:58:37Z","updated_at":"2016-09-29T13:27:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d061356bd4f052d979d06c52b9b68c0dc61ed5d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/1/comments","statuses_url":"https://api.github.com/repos/bartekgorny/MongooseIM/statuses/ce18e2fd8cd59fe1667a8060cf634e8620ea1ceb","head":{"label":"bartekgorny:hooks-accumulators","ref":"hooks-accumulators","sha":"ce18e2fd8cd59fe1667a8060cf634e8620ea1ceb","user":{"login":"bartekgorny","id":70064,"avatar_url":"https://avatars.githubusercontent.com/u/70064?v=3","gravatar_id":"","url":"https://api.github.com/users/bartekgorny","html_url":"https://github.com/bartekgorny","followers_url":"https://api.github.com/users/bartekgorny/followers","following_url":"https://api.github.com/users/bartekgorny/following{/other_user}","gists_url":"https://api.github.com/users/bartekgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekgorny/subscriptions","organizations_url":"https://api.github.com/users/bartekgorny/orgs","repos_url":"https://api.github.com/users/bartekgorny/repos","events_url":"https://api.github.com/users/bartekgorny/events{/privacy}","received_events_url":"https://api.github.com/users/bartekgorny/received_events","type":"User","site_admin":false},"repo":{"id":47578970,"name":"MongooseIM","full_name":"bartekgorny/MongooseIM","owner":{"login":"bartekgorny","id":70064,"avatar_url":"https://avatars.githubusercontent.com/u/70064?v=3","gravatar_id":"","url":"https://api.github.com/users/bartekgorny","html_url":"https://github.com/bartekgorny","followers_url":"https://api.github.com/users/bartekgorny/followers","following_url":"https://api.github.com/users/bartekgorny/following{/other_user}","gists_url":"https://api.github.com/users/bartekgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekgorny/subscriptions","organizations_url":"https://api.github.com/users/bartekgorny/orgs","repos_url":"https://api.github.com/users/bartekgorny/repos","events_url":"https://api.github.com/users/bartekgorny/events{/privacy}","received_events_url":"https://api.github.com/users/bartekgorny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartekgorny/MongooseIM","description":"Jabber / XMPP server with focus on performance and scalability, by Erlang Solutions","fork":true,"url":"https://api.github.com/repos/bartekgorny/MongooseIM","forks_url":"https://api.github.com/repos/bartekgorny/MongooseIM/forks","keys_url":"https://api.github.com/repos/bartekgorny/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartekgorny/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartekgorny/MongooseIM/teams","hooks_url":"https://api.github.com/repos/bartekgorny/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/bartekgorny/MongooseIM/events","assignees_url":"https://api.github.com/repos/bartekgorny/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/bartekgorny/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/bartekgorny/MongooseIM/tags","blobs_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartekgorny/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/bartekgorny/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/bartekgorny/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/bartekgorny/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/bartekgorny/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/bartekgorny/MongooseIM/subscription","commits_url":"https://api.github.com/repos/bartekgorny/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartekgorny/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartekgorny/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/bartekgorny/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartekgorny/MongooseIM/merges","archive_url":"https://api.github.com/repos/bartekgorny/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartekgorny/MongooseIM/downloads","issues_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/bartekgorny/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/bartekgorny/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartekgorny/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/bartekgorny/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/bartekgorny/MongooseIM/deployments","created_at":"2015-12-07T21:01:48Z","updated_at":"2016-02-22T13:16:47Z","pushed_at":"2016-09-29T08:58:38Z","git_url":"git://github.com/bartekgorny/MongooseIM.git","ssh_url":"git@github.com:bartekgorny/MongooseIM.git","clone_url":"https://github.com/bartekgorny/MongooseIM.git","svn_url":"https://github.com/bartekgorny/MongooseIM","homepage":"https://www.erlang-solutions.com/products/mongooseim.html","size":18696,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bartekgorny:master","ref":"master","sha":"abcd1b0fed12f19d01123dcef3b4eed0c46931ea","user":{"login":"bartekgorny","id":70064,"avatar_url":"https://avatars.githubusercontent.com/u/70064?v=3","gravatar_id":"","url":"https://api.github.com/users/bartekgorny","html_url":"https://github.com/bartekgorny","followers_url":"https://api.github.com/users/bartekgorny/followers","following_url":"https://api.github.com/users/bartekgorny/following{/other_user}","gists_url":"https://api.github.com/users/bartekgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekgorny/subscriptions","organizations_url":"https://api.github.com/users/bartekgorny/orgs","repos_url":"https://api.github.com/users/bartekgorny/repos","events_url":"https://api.github.com/users/bartekgorny/events{/privacy}","received_events_url":"https://api.github.com/users/bartekgorny/received_events","type":"User","site_admin":false},"repo":{"id":47578970,"name":"MongooseIM","full_name":"bartekgorny/MongooseIM","owner":{"login":"bartekgorny","id":70064,"avatar_url":"https://avatars.githubusercontent.com/u/70064?v=3","gravatar_id":"","url":"https://api.github.com/users/bartekgorny","html_url":"https://github.com/bartekgorny","followers_url":"https://api.github.com/users/bartekgorny/followers","following_url":"https://api.github.com/users/bartekgorny/following{/other_user}","gists_url":"https://api.github.com/users/bartekgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekgorny/subscriptions","organizations_url":"https://api.github.com/users/bartekgorny/orgs","repos_url":"https://api.github.com/users/bartekgorny/repos","events_url":"https://api.github.com/users/bartekgorny/events{/privacy}","received_events_url":"https://api.github.com/users/bartekgorny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartekgorny/MongooseIM","description":"Jabber / XMPP server with focus on performance and scalability, by Erlang Solutions","fork":true,"url":"https://api.github.com/repos/bartekgorny/MongooseIM","forks_url":"https://api.github.com/repos/bartekgorny/MongooseIM/forks","keys_url":"https://api.github.com/repos/bartekgorny/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartekgorny/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartekgorny/MongooseIM/teams","hooks_url":"https://api.github.com/repos/bartekgorny/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/bartekgorny/MongooseIM/events","assignees_url":"https://api.github.com/repos/bartekgorny/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/bartekgorny/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/bartekgorny/MongooseIM/tags","blobs_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartekgorny/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/bartekgorny/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/bartekgorny/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/bartekgorny/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/bartekgorny/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/bartekgorny/MongooseIM/subscription","commits_url":"https://api.github.com/repos/bartekgorny/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartekgorny/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartekgorny/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartekgorny/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/bartekgorny/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartekgorny/MongooseIM/merges","archive_url":"https://api.github.com/repos/bartekgorny/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartekgorny/MongooseIM/downloads","issues_url":"https://api.github.com/repos/bartekgorny/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/bartekgorny/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/bartekgorny/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartekgorny/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/bartekgorny/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/bartekgorny/MongooseIM/deployments","created_at":"2015-12-07T21:01:48Z","updated_at":"2016-02-22T13:16:47Z","pushed_at":"2016-09-29T08:58:38Z","git_url":"git://github.com/bartekgorny/MongooseIM.git","ssh_url":"git@github.com:bartekgorny/MongooseIM.git","clone_url":"https://github.com/bartekgorny/MongooseIM.git","svn_url":"https://github.com/bartekgorny/MongooseIM","homepage":"https://www.erlang-solutions.com/products/mongooseim.html","size":18696,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1"},"html":{"href":"https://github.com/bartekgorny/MongooseIM/pull/1"},"issue":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/1"},"comments":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bartekgorny/MongooseIM/statuses/ce18e2fd8cd59fe1667a8060cf634e8620ea1ceb"}}}}
{"actor":{"display_login":"michalwski"}}