{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/comments/88987119","pull_request_review_id":9541556,"id":88987119,"diff_hunk":"@@ -11,60 +11,58 @@\n  * A sample test case, testing {@link java.util.ArrayList}.\n  */\n public class ListTest extends TestCase {\n-    protected List<Integer> fEmpty;\n-    protected List<Integer> fFull;\n+    private List<Integer> emptyList;\n+\n+    private List<Integer> fullList;\n \n-    public static void main(String[] args) {\n-        junit.textui.TestRunner.run(suite());\n-    }\n \n     @Override\n     protected void setUp() {\n-        fEmpty = new ArrayList<Integer>();\n-        fFull = new ArrayList<Integer>();\n-        fFull.add(1);\n-        fFull.add(2);\n-        fFull.add(3);\n+        emptyList = new ArrayList<Integer>();\n+        fullList = new ArrayList<Integer>();\n+        fullList.add(1);\n+        fullList.add(2);\n+        fullList.add(3);\n     }\n \n     public static Test suite() {\n         return new TestSuite(ListTest.class);\n     }\n \n     public void testCapacity() {\n-        int size = fFull.size();\n+        int size = fullList.size();\n         for (int i = 0; i < 100; i++) {\n-            fFull.add(i);\n+            fullList.add(i);\n         }\n-        assertTrue(fFull.size() == 100 + size);\n+        assertTrue(fullList.size() == 100 + size);\n     }\n \n     public void testContains() {\n-        assertTrue(fFull.contains(1));\n-        assertTrue(!fEmpty.contains(1));\n+        assertTrue(fullList.contains(1));\n+        assertTrue(!emptyList.contains(1));\n     }\n \n     public void testElementAt() {\n-        int i = fFull.get(0);\n+        int i = fullList.get(0);\n         assertTrue(i == 1);","path":"src/test/java/junit/samples/ListTest.java","position":53,"original_position":53,"commit_id":"902432fc8c15ad2494b5c2391a13ee6830e365ed","original_commit_id":"902432fc8c15ad2494b5c2391a13ee6830e365ed","user":{"login":"AxelMonroyX","id":10134378,"avatar_url":"https://avatars.githubusercontent.com/u/10134378?v=3","gravatar_id":"","url":"https://api.github.com/users/AxelMonroyX","html_url":"https://github.com/AxelMonroyX","followers_url":"https://api.github.com/users/AxelMonroyX/followers","following_url":"https://api.github.com/users/AxelMonroyX/following{/other_user}","gists_url":"https://api.github.com/users/AxelMonroyX/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelMonroyX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelMonroyX/subscriptions","organizations_url":"https://api.github.com/users/AxelMonroyX/orgs","repos_url":"https://api.github.com/users/AxelMonroyX/repos","events_url":"https://api.github.com/users/AxelMonroyX/events{/privacy}","received_events_url":"https://api.github.com/users/AxelMonroyX/received_events","type":"User","site_admin":false},"body":"Yes is more readable :+1: ","created_at":"2016-11-21T21:03:38Z","updated_at":"2016-11-21T21:03:38Z","html_url":"https://github.com/junit-team/junit4/pull/1389#discussion_r88987119","pull_request_url":"https://api.github.com/repos/junit-team/junit4/pulls/1389","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments/88987119"},"html":{"href":"https://github.com/junit-team/junit4/pull/1389#discussion_r88987119"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1389"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/1389","id":94663046,"html_url":"https://github.com/junit-team/junit4/pull/1389","diff_url":"https://github.com/junit-team/junit4/pull/1389.diff","patch_url":"https://github.com/junit-team/junit4/pull/1389.patch","issue_url":"https://api.github.com/repos/junit-team/junit4/issues/1389","number":1389,"state":"open","locked":false,"title":"Set private the lists fEmpty, fFull and remove unnecessary boxing on ListTest","user":{"login":"AxelMonroyX","id":10134378,"avatar_url":"https://avatars.githubusercontent.com/u/10134378?v=3","gravatar_id":"","url":"https://api.github.com/users/AxelMonroyX","html_url":"https://github.com/AxelMonroyX","followers_url":"https://api.github.com/users/AxelMonroyX/followers","following_url":"https://api.github.com/users/AxelMonroyX/following{/other_user}","gists_url":"https://api.github.com/users/AxelMonroyX/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelMonroyX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelMonroyX/subscriptions","organizations_url":"https://api.github.com/users/AxelMonroyX/orgs","repos_url":"https://api.github.com/users/AxelMonroyX/repos","events_url":"https://api.github.com/users/AxelMonroyX/events{/privacy}","received_events_url":"https://api.github.com/users/AxelMonroyX/received_events","type":"User","site_admin":false},"body":"##### Description of change\r\n- Change from protected to private `fEmpty` and `fFull` lists, because there is no need to keep accessible from the package and subclass\r\n- Remove unnecessary boxing on `fFull.remove()` because Java creates an Integer object from `i` and adds to the object `fFull`\r\n\r\n##### Requested Changes\r\n- Remove main method from ListTest.java\r\n- Rename `fEmpty` to `emptyList`\r\n- Rename `fFull` to `fullList`\r\n\r\n##### Checklist\r\n- [x] Run `mvn verify`\r\n- [x] All tests are passing\r\n\r\n##### References:\r\n[Controlling Access to Members of a Class](https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html)\r\n[Autoboxing and Unboxing](https://docs.oracle.com/javase/tutorial/java/data/autoboxing.html)","created_at":"2016-11-21T17:44:41Z","updated_at":"2016-11-21T21:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e48474cb7f5ade20133969c50126ad4ea5b2cdbe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit4/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit4/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit4/issues/1389/comments","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/902432fc8c15ad2494b5c2391a13ee6830e365ed","head":{"label":"AxelMonroyX:change-modifiers-autounboxing-on-listtest","ref":"change-modifiers-autounboxing-on-listtest","sha":"902432fc8c15ad2494b5c2391a13ee6830e365ed","user":{"login":"AxelMonroyX","id":10134378,"avatar_url":"https://avatars.githubusercontent.com/u/10134378?v=3","gravatar_id":"","url":"https://api.github.com/users/AxelMonroyX","html_url":"https://github.com/AxelMonroyX","followers_url":"https://api.github.com/users/AxelMonroyX/followers","following_url":"https://api.github.com/users/AxelMonroyX/following{/other_user}","gists_url":"https://api.github.com/users/AxelMonroyX/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelMonroyX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelMonroyX/subscriptions","organizations_url":"https://api.github.com/users/AxelMonroyX/orgs","repos_url":"https://api.github.com/users/AxelMonroyX/repos","events_url":"https://api.github.com/users/AxelMonroyX/events{/privacy}","received_events_url":"https://api.github.com/users/AxelMonroyX/received_events","type":"User","site_admin":false},"repo":{"id":73102933,"name":"junit4","full_name":"AxelMonroyX/junit4","owner":{"login":"AxelMonroyX","id":10134378,"avatar_url":"https://avatars.githubusercontent.com/u/10134378?v=3","gravatar_id":"","url":"https://api.github.com/users/AxelMonroyX","html_url":"https://github.com/AxelMonroyX","followers_url":"https://api.github.com/users/AxelMonroyX/followers","following_url":"https://api.github.com/users/AxelMonroyX/following{/other_user}","gists_url":"https://api.github.com/users/AxelMonroyX/gists{/gist_id}","starred_url":"https://api.github.com/users/AxelMonroyX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AxelMonroyX/subscriptions","organizations_url":"https://api.github.com/users/AxelMonroyX/orgs","repos_url":"https://api.github.com/users/AxelMonroyX/repos","events_url":"https://api.github.com/users/AxelMonroyX/events{/privacy}","received_events_url":"https://api.github.com/users/AxelMonroyX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AxelMonroyX/junit4","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/AxelMonroyX/junit4","forks_url":"https://api.github.com/repos/AxelMonroyX/junit4/forks","keys_url":"https://api.github.com/repos/AxelMonroyX/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AxelMonroyX/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AxelMonroyX/junit4/teams","hooks_url":"https://api.github.com/repos/AxelMonroyX/junit4/hooks","issue_events_url":"https://api.github.com/repos/AxelMonroyX/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/AxelMonroyX/junit4/events","assignees_url":"https://api.github.com/repos/AxelMonroyX/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/AxelMonroyX/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/AxelMonroyX/junit4/tags","blobs_url":"https://api.github.com/repos/AxelMonroyX/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AxelMonroyX/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AxelMonroyX/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/AxelMonroyX/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AxelMonroyX/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/AxelMonroyX/junit4/languages","stargazers_url":"https://api.github.com/repos/AxelMonroyX/junit4/stargazers","contributors_url":"https://api.github.com/repos/AxelMonroyX/junit4/contributors","subscribers_url":"https://api.github.com/repos/AxelMonroyX/junit4/subscribers","subscription_url":"https://api.github.com/repos/AxelMonroyX/junit4/subscription","commits_url":"https://api.github.com/repos/AxelMonroyX/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/AxelMonroyX/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/AxelMonroyX/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/AxelMonroyX/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/AxelMonroyX/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/AxelMonroyX/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AxelMonroyX/junit4/merges","archive_url":"https://api.github.com/repos/AxelMonroyX/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AxelMonroyX/junit4/downloads","issues_url":"https://api.github.com/repos/AxelMonroyX/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/AxelMonroyX/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/AxelMonroyX/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/AxelMonroyX/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AxelMonroyX/junit4/labels{/name}","releases_url":"https://api.github.com/repos/AxelMonroyX/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/AxelMonroyX/junit4/deployments","created_at":"2016-11-07T17:20:28Z","updated_at":"2016-11-07T17:20:31Z","pushed_at":"2016-11-21T18:28:50Z","git_url":"git://github.com/AxelMonroyX/junit4.git","ssh_url":"git@github.com:AxelMonroyX/junit4.git","clone_url":"https://github.com/AxelMonroyX/junit4.git","svn_url":"https://github.com/AxelMonroyX/junit4","homepage":"http://junit.org/junit4/","size":21927,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"1887122f99b3c7bf417ee4172aa662a70d55077b","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit4","full_name":"junit-team/junit4","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit4","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit4","forks_url":"https://api.github.com/repos/junit-team/junit4/forks","keys_url":"https://api.github.com/repos/junit-team/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit4/teams","hooks_url":"https://api.github.com/repos/junit-team/junit4/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit4/events","assignees_url":"https://api.github.com/repos/junit-team/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit4/tags","blobs_url":"https://api.github.com/repos/junit-team/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit4/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit4/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit4/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit4/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit4/subscription","commits_url":"https://api.github.com/repos/junit-team/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit4/merges","archive_url":"https://api.github.com/repos/junit-team/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit4/downloads","issues_url":"https://api.github.com/repos/junit-team/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit4/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit4/deployments","created_at":"2009-01-13T03:41:26Z","updated_at":"2016-11-21T17:41:13Z","pushed_at":"2016-11-21T19:25:45Z","git_url":"git://github.com/junit-team/junit4.git","ssh_url":"git@github.com:junit-team/junit4.git","clone_url":"https://github.com/junit-team/junit4.git","svn_url":"https://github.com/junit-team/junit4","homepage":"http://junit.org/junit4/","size":37115,"stargazers_count":5455,"watchers_count":5455,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2132,"mirror_url":null,"open_issues_count":157,"forks":2132,"open_issues":157,"watchers":5455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1389"},"html":{"href":"https://github.com/junit-team/junit4/pull/1389"},"issue":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1389"},"comments":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit4/statuses/902432fc8c15ad2494b5c2391a13ee6830e365ed"}}}}
{"actor":{"display_login":"AxelMonroyX"}}