{"action":"created","comment":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments/87706351","pull_request_review_id":8309924,"id":87706351,"diff_hunk":"@@ -18,7 +18,66 @@ UserAgentSearch = Kodi\n UpnpDetailsSearch = Kodi\n RemoveTagsFromSRTSubtitles = false\n \n-# Include all settings from this parent configuration:\n-# Note: this must come last for the overrides above to maintain priority\n-include = XBMC.conf\n+MediaInfo = true\n+TranscodeAudio = WAV\n+DefaultVBVBufSize = true\n+MuxDTSToMpeg = true\n+H264Level41Limited = false\n+StreamExtensions = mkv,hdmov,hdm,flac,fla,dts,ogg,asf,asx,m2v,avi\n+SubtitleHttpHeader = CaptionInfo.sec\n+TranscodeFastStart = true\n+StreamSubsForTranscodedVideo = true\n \n+Supported = f:3gp             v:divx|h263|h264|h265|vc1|mjpeg|mp4|mpeg1|mpeg2|wmv|cvid   a:aac|aac-he|ac3|dts|dtshd|lpcm|mpa|mp2|mp3|wma|truehd        m:video/3gpp","path":"src/main/external-resources/renderers/Kodi.conf","position":17,"original_position":17,"commit_id":"678bd645f0a67387cd6e9b1894105550b1379090","original_commit_id":"678bd645f0a67387cd6e9b1894105550b1379090","user":{"login":"SubJunk","id":584228,"avatar_url":"https://avatars.githubusercontent.com/u/584228?v=3","gravatar_id":"","url":"https://api.github.com/users/SubJunk","html_url":"https://github.com/SubJunk","followers_url":"https://api.github.com/users/SubJunk/followers","following_url":"https://api.github.com/users/SubJunk/following{/other_user}","gists_url":"https://api.github.com/users/SubJunk/gists{/gist_id}","starred_url":"https://api.github.com/users/SubJunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SubJunk/subscriptions","organizations_url":"https://api.github.com/users/SubJunk/orgs","repos_url":"https://api.github.com/users/SubJunk/repos","events_url":"https://api.github.com/users/SubJunk/events{/privacy}","received_events_url":"https://api.github.com/users/SubJunk/received_events","type":"User","site_admin":false},"body":"This looks good but I usually try to keep the parameters in alphabetical order. Not that important just a note.","created_at":"2016-11-13T06:03:48Z","updated_at":"2016-11-13T06:03:53Z","html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1094#discussion_r87706351","pull_request_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094","_links":{"self":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments/87706351"},"html":{"href":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1094#discussion_r87706351"},"pull_request":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094"}}},"pull_request":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094","id":93461146,"html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1094","diff_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1094.diff","patch_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1094.patch","issue_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1094","number":1094,"state":"open","locked":false,"title":"Updated/Created new renderer profile for Kodi","user":{"login":"Nadahar","id":12900583,"avatar_url":"https://avatars.githubusercontent.com/u/12900583?v=3","gravatar_id":"","url":"https://api.github.com/users/Nadahar","html_url":"https://github.com/Nadahar","followers_url":"https://api.github.com/users/Nadahar/followers","following_url":"https://api.github.com/users/Nadahar/following{/other_user}","gists_url":"https://api.github.com/users/Nadahar/gists{/gist_id}","starred_url":"https://api.github.com/users/Nadahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nadahar/subscriptions","organizations_url":"https://api.github.com/users/Nadahar/orgs","repos_url":"https://api.github.com/users/Nadahar/repos","events_url":"https://api.github.com/users/Nadahar/events{/privacy}","received_events_url":"https://api.github.com/users/Nadahar/received_events","type":"User","site_admin":false},"body":"This isn't perfect, trying to configure ```Supported``` lines correctly looking up file format and codec combinations and how they are interpreted by UMS makes me loose the will to live, so I'm simply uploading it as it is now. It's certainly a whole lot better than the current Kodi profile, which to be honest, doesn't work very well at all.\r\n\r\nKodi is brilliant for testing in my opinion, but the severely lacking renderer profiles always drive me crazy and introduces issues whenever I am to do that. This will remedy that situation a lot I'd think.\r\n\r\nI've tested this on quite a few audio and video formats, most seem to work well. I haven't tested all the subtitle formats since I don't have test files for them, and there are some problems with a few of the audio formats (some M4A files aren't correctly recognized, but that is a UMS bug that's been there a long time). Generally it will play most audio well. \r\n\r\nWhen it comes to images I haven't really managed to get it to show JPG at all - it just displays a black screen. I don't quite understand how that could be UMS' fault so I'm assuming that is a bug with Kodi and haven't pursued it any further.\r\n\r\nFeel free to make corrections to this PR if you see anything that could be improved, and I hope this can be merged relatively quickly so that all the issues I have when testing other stuff can be a little less frustrating.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/universalmediaserver/universalmediaserver/1094)\n<!-- Reviewable:end -->\n","created_at":"2016-11-13T03:44:37Z","updated_at":"2016-11-13T06:03:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a759d5b2368f80815fbb45157cbbecb29713b92c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1094/comments","statuses_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/678bd645f0a67387cd6e9b1894105550b1379090","head":{"label":"UniversalMediaServer:Kodi","ref":"Kodi","sha":"678bd645f0a67387cd6e9b1894105550b1379090","user":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"repo":{"id":4591214,"name":"UniversalMediaServer","full_name":"UniversalMediaServer/UniversalMediaServer","owner":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","description":"A DLNA-compliant UPnP Media Server.","fork":false,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer","forks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/forks","keys_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/teams","hooks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/hooks","issue_events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/events{/number}","events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/events","assignees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/assignees{/user}","branches_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/branches{/branch}","tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/tags","blobs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/languages","stargazers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/stargazers","contributors_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contributors","subscribers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscribers","subscription_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscription","commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contents/{+path}","compare_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/merges","archive_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/downloads","issues_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues{/number}","pulls_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels{/name}","releases_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/releases{/id}","deployments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/deployments","created_at":"2012-06-07T22:23:22Z","updated_at":"2016-11-11T18:51:04Z","pushed_at":"2016-11-13T03:45:37Z","git_url":"git://github.com/UniversalMediaServer/UniversalMediaServer.git","ssh_url":"git@github.com:UniversalMediaServer/UniversalMediaServer.git","clone_url":"https://github.com/UniversalMediaServer/UniversalMediaServer.git","svn_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","homepage":null,"size":58511,"stargazers_count":438,"watchers_count":438,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":268,"forks":170,"open_issues":268,"watchers":438,"default_branch":"master"}},"base":{"label":"UniversalMediaServer:master","ref":"master","sha":"5c15af0ab75f28785abd1e3f249bc7507bfcc28d","user":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"repo":{"id":4591214,"name":"UniversalMediaServer","full_name":"UniversalMediaServer/UniversalMediaServer","owner":{"login":"UniversalMediaServer","id":1840565,"avatar_url":"https://avatars.githubusercontent.com/u/1840565?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalMediaServer","html_url":"https://github.com/UniversalMediaServer","followers_url":"https://api.github.com/users/UniversalMediaServer/followers","following_url":"https://api.github.com/users/UniversalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/UniversalMediaServer/orgs","repos_url":"https://api.github.com/users/UniversalMediaServer/repos","events_url":"https://api.github.com/users/UniversalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalMediaServer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","description":"A DLNA-compliant UPnP Media Server.","fork":false,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer","forks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/forks","keys_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/teams","hooks_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/hooks","issue_events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/events{/number}","events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/events","assignees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/assignees{/user}","branches_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/branches{/branch}","tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/tags","blobs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/languages","stargazers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/stargazers","contributors_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contributors","subscribers_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscribers","subscription_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/subscription","commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/contents/{+path}","compare_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/merges","archive_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/downloads","issues_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues{/number}","pulls_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels{/name}","releases_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/releases{/id}","deployments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/deployments","created_at":"2012-06-07T22:23:22Z","updated_at":"2016-11-11T18:51:04Z","pushed_at":"2016-11-13T03:45:37Z","git_url":"git://github.com/UniversalMediaServer/UniversalMediaServer.git","ssh_url":"git@github.com:UniversalMediaServer/UniversalMediaServer.git","clone_url":"https://github.com/UniversalMediaServer/UniversalMediaServer.git","svn_url":"https://github.com/UniversalMediaServer/UniversalMediaServer","homepage":null,"size":58511,"stargazers_count":438,"watchers_count":438,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":268,"forks":170,"open_issues":268,"watchers":438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094"},"html":{"href":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1094"},"issue":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1094"},"comments":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/statuses/678bd645f0a67387cd6e9b1894105550b1379090"}}}}
{"actor":{"display_login":"SubJunk"}}