{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2880","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2880/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2880/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2880/events","html_url":"https://github.com/RobotLocomotion/drake/pull/2880","id":166841561,"number":2880,"title":"Toward #2852: enforce -Werror=shadow in solvers/.","user":{"login":"rpoyner-tri","id":17582368,"avatar_url":"https://avatars.githubusercontent.com/u/17582368?v=3","gravatar_id":"","url":"https://api.github.com/users/rpoyner-tri","html_url":"https://github.com/rpoyner-tri","followers_url":"https://api.github.com/users/rpoyner-tri/followers","following_url":"https://api.github.com/users/rpoyner-tri/following{/other_user}","gists_url":"https://api.github.com/users/rpoyner-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/rpoyner-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpoyner-tri/subscriptions","organizations_url":"https://api.github.com/users/rpoyner-tri/orgs","repos_url":"https://api.github.com/users/rpoyner-tri/repos","events_url":"https://api.github.com/users/rpoyner-tri/events{/privacy}","received_events_url":"https://api.github.com/users/rpoyner-tri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"naveenoid","id":3089530,"avatar_url":"https://avatars.githubusercontent.com/u/3089530?v=3","gravatar_id":"","url":"https://api.github.com/users/naveenoid","html_url":"https://github.com/naveenoid","followers_url":"https://api.github.com/users/naveenoid/followers","following_url":"https://api.github.com/users/naveenoid/following{/other_user}","gists_url":"https://api.github.com/users/naveenoid/gists{/gist_id}","starred_url":"https://api.github.com/users/naveenoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveenoid/subscriptions","organizations_url":"https://api.github.com/users/naveenoid/orgs","repos_url":"https://api.github.com/users/naveenoid/repos","events_url":"https://api.github.com/users/naveenoid/events{/privacy}","received_events_url":"https://api.github.com/users/naveenoid/received_events","type":"User","site_admin":false},"assignees":[{"login":"naveenoid","id":3089530,"avatar_url":"https://avatars.githubusercontent.com/u/3089530?v=3","gravatar_id":"","url":"https://api.github.com/users/naveenoid","html_url":"https://github.com/naveenoid","followers_url":"https://api.github.com/users/naveenoid/followers","following_url":"https://api.github.com/users/naveenoid/following{/other_user}","gists_url":"https://api.github.com/users/naveenoid/gists{/gist_id}","starred_url":"https://api.github.com/users/naveenoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naveenoid/subscriptions","organizations_url":"https://api.github.com/users/naveenoid/orgs","repos_url":"https://api.github.com/users/naveenoid/repos","events_url":"https://api.github.com/users/naveenoid/events{/privacy}","received_events_url":"https://api.github.com/users/naveenoid/received_events","type":"User","site_admin":false},{"login":"sammy-tri","id":17596504,"avatar_url":"https://avatars.githubusercontent.com/u/17596504?v=3","gravatar_id":"","url":"https://api.github.com/users/sammy-tri","html_url":"https://github.com/sammy-tri","followers_url":"https://api.github.com/users/sammy-tri/followers","following_url":"https://api.github.com/users/sammy-tri/following{/other_user}","gists_url":"https://api.github.com/users/sammy-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/sammy-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammy-tri/subscriptions","organizations_url":"https://api.github.com/users/sammy-tri/orgs","repos_url":"https://api.github.com/users/sammy-tri/repos","events_url":"https://api.github.com/users/sammy-tri/events{/privacy}","received_events_url":"https://api.github.com/users/sammy-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-07-21T15:01:32Z","updated_at":"2016-07-21T19:32:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/2880","html_url":"https://github.com/RobotLocomotion/drake/pull/2880","diff_url":"https://github.com/RobotLocomotion/drake/pull/2880.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/2880.patch"},"body":" * Remove the excuse from the build rules.\r\n * Fix the shadowing cases found.\r\n * Fix a few other easy style guide violations;\r\n   * numerous others remain unfixed.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/2880)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/234359052","html_url":"https://github.com/RobotLocomotion/drake/pull/2880#issuecomment-234359052","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/2880","id":234359052,"user":{"login":"rpoyner-tri","id":17582368,"avatar_url":"https://avatars.githubusercontent.com/u/17582368?v=3","gravatar_id":"","url":"https://api.github.com/users/rpoyner-tri","html_url":"https://github.com/rpoyner-tri","followers_url":"https://api.github.com/users/rpoyner-tri/followers","following_url":"https://api.github.com/users/rpoyner-tri/following{/other_user}","gists_url":"https://api.github.com/users/rpoyner-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/rpoyner-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpoyner-tri/subscriptions","organizations_url":"https://api.github.com/users/rpoyner-tri/orgs","repos_url":"https://api.github.com/users/rpoyner-tri/repos","events_url":"https://api.github.com/users/rpoyner-tri/events{/privacy}","received_events_url":"https://api.github.com/users/rpoyner-tri/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T19:32:07Z","updated_at":"2016-07-21T19:32:07Z","body":"\n\n\n\nReview status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[drake/solvers/QP.cpp, line 146 \\[r2\\]](https://reviewable.io:443/reviews/robotlocomotion/drake/2880#-KNDsBvXARtMBcq1NV9M:-KNDwIZz7tCOJNZmu2oc:-2047746956) ([raw file](https://github.com/robotlocomotion/drake/blob/ba1940bb9fad182044f8cf87f243bae13bdf284d/drake/solvers/QP.cpp#L146)):*\n<details><summary><i>Previously, rpoyner-tri (Rick Poyner (rico)) wrote…</i></summary>\n> I would have felt a little more confident about doing that if I could run the test locally</gurobi-license>. I'll take another look.\n</details>\nTesting a new version now...\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/2880)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"rpoyner-tri"}}