{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments/54450331","id":54450331,"diff_hunk":"@@ -0,0 +1,142 @@\n+/*\n+ * Loop through the custom contexts that exist when the app starts\n+ * and grab their names.\n+ *\n+ * To change the environment we're testing against, specify it in site.json.\n+ * This should align with what the app is built against, which is declared in\n+ * app/environment.js hostUrl\n+ */\n+\n+var Site = require('../site.json');\n+\n+var Setup = {};\n+\n+var selectors = {\n+    previewButton: '#authorize',\n+    registeredAuctionList: '.js-auction-lists'\n+};\n+\n+var expected = {\n+    //EXAMPLE Webviews constructed for project.\n+    'noInternet': /no-internet\\.html/i,\n+    'couldNotLoad': /could-not-load\\.html/i\n+};\n+\n+Setup.appPreview = function(browser) {\n+    browser.contexts(function(result) {\n+        browser\n+            .session(function(type) {\n+                browser\n+                    .log('Running on platform - ' + type.value.platformName);\n+                if (type.value.platformName === 'Android') {","path":"app/tests/system/setup/setup.js","position":32,"original_position":31,"commit_id":"046a2f2ace43af0862d8235dd946391b45837a25","original_commit_id":"c5a73fac43a62d0a8bb7c79271d0918cf9375d00","user":{"login":"lilyzh","id":15114790,"avatar_url":"https://avatars.githubusercontent.com/u/15114790?v=3","gravatar_id":"","url":"https://api.github.com/users/lilyzh","html_url":"https://github.com/lilyzh","followers_url":"https://api.github.com/users/lilyzh/followers","following_url":"https://api.github.com/users/lilyzh/following{/other_user}","gists_url":"https://api.github.com/users/lilyzh/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyzh/subscriptions","organizations_url":"https://api.github.com/users/lilyzh/orgs","repos_url":"https://api.github.com/users/lilyzh/repos","events_url":"https://api.github.com/users/lilyzh/events{/privacy}","received_events_url":"https://api.github.com/users/lilyzh/received_events","type":"User","site_admin":false},"body":"Currently in some situation, it is \"platform\", but sometimes it is \"platformName\", and the value is \"ANDROID\" or \"Android\", and I haven't figure out the pattern. If later we figure out the pattern, we could create a new PR for it. ","created_at":"2016-02-29T18:06:52Z","updated_at":"2016-02-29T18:06:52Z","html_url":"https://github.com/mobify/astro-scaffold/pull/67#discussion_r54450331","pull_request_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments/54450331"},"html":{"href":"https://github.com/mobify/astro-scaffold/pull/67#discussion_r54450331"},"pull_request":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67","id":59894933,"html_url":"https://github.com/mobify/astro-scaffold/pull/67","diff_url":"https://github.com/mobify/astro-scaffold/pull/67.diff","patch_url":"https://github.com/mobify/astro-scaffold/pull/67.patch","issue_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/67","number":67,"state":"open","locked":false,"title":"Abstract Common WebView Actions into a pageObjects Library","user":{"login":"lilyzh","id":15114790,"avatar_url":"https://avatars.githubusercontent.com/u/15114790?v=3","gravatar_id":"","url":"https://api.github.com/users/lilyzh","html_url":"https://github.com/lilyzh","followers_url":"https://api.github.com/users/lilyzh/followers","following_url":"https://api.github.com/users/lilyzh/following{/other_user}","gists_url":"https://api.github.com/users/lilyzh/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyzh/subscriptions","organizations_url":"https://api.github.com/users/lilyzh/orgs","repos_url":"https://api.github.com/users/lilyzh/repos","events_url":"https://api.github.com/users/lilyzh/events{/privacy}","received_events_url":"https://api.github.com/users/lilyzh/received_events","type":"User","site_admin":false},"body":"Abstract Common WebView Actions into a pageObjects Library\r\n\r\nJIRA: \r\nhttps://mobify.atlassian.net/browse/CSOG-21\r\n\r\n## Changes\r\nAdded setup.js file under setup folder, including:\r\n\r\n- Include the setup functions that are present in RBA and Thinkgeek\r\n\r\n## How to test-drive this PR\r\n- Update the Appium to the latest version\r\n- Clone https://github.com/mobify/generator-astro\r\n- Change `generator.sh`:\r\n```\r\nSCAFFOLD_VERSION=\"CSOG-3_common_webview_action\"\r\nSCAFFOLD_URL=\"https://github.com/mobify/astro-scaffold/archive/CSOG-3_common_webview_action.zip\"\r\n```\r\n- Run `./generator.sh`\r\n- `cd` into generated project and run `./scripts/ios-appium.sh`\r\n\r\n## TODOS:\r\n- [x] Tests are passing on your machine.\r\n- [x] Change works in both Android and iOS. (Tested with iOS build and test script. Not sure if there's an equivalent for Android). \r\n- [x] CHANGELOG.md has been updated.\r\n- [x] Scaffold is working. If a new feature was added, it was added to the Scaffold app.\r\n- [x] Run the generator to make sure it still functions correctly.\r\n- [ ] QA +1\r\n- [ ] +1 from an engineer on the Astro team. @jeremywiebe ","created_at":"2016-02-19T02:07:10Z","updated_at":"2016-02-29T18:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1551d837398b404598f7af730282fe07ccc0fdef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67/commits","review_comments_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67/comments","review_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/67/comments","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/046a2f2ace43af0862d8235dd946391b45837a25","head":{"label":"mobify:CSOG-3_common_webview_action","ref":"CSOG-3_common_webview_action","sha":"046a2f2ace43af0862d8235dd946391b45837a25","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":34024647,"name":"astro-scaffold","full_name":"mobify/astro-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/astro-scaffold","description":"Starting point for building Astro applications","fork":false,"url":"https://api.github.com/repos/mobify/astro-scaffold","forks_url":"https://api.github.com/repos/mobify/astro-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/astro-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/astro-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/astro-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/astro-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/astro-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/astro-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/astro-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/astro-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/astro-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/astro-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/astro-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/astro-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/astro-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/astro-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/astro-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/astro-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/astro-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/astro-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/astro-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/astro-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/astro-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/astro-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/astro-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/astro-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/astro-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/astro-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/astro-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/astro-scaffold/deployments","created_at":"2015-04-15T23:56:36Z","updated_at":"2016-01-30T07:16:17Z","pushed_at":"2016-02-29T17:55:46Z","git_url":"git://github.com/mobify/astro-scaffold.git","ssh_url":"git@github.com:mobify/astro-scaffold.git","clone_url":"https://github.com/mobify/astro-scaffold.git","svn_url":"https://github.com/mobify/astro-scaffold","homepage":null,"size":622,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"d30c9d90fe8a8a8ea7a98dfcf6539e1185a059f1","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":34024647,"name":"astro-scaffold","full_name":"mobify/astro-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/astro-scaffold","description":"Starting point for building Astro applications","fork":false,"url":"https://api.github.com/repos/mobify/astro-scaffold","forks_url":"https://api.github.com/repos/mobify/astro-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/astro-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/astro-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/astro-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/astro-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/astro-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/astro-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/astro-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/astro-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/astro-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/astro-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/astro-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/astro-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/astro-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/astro-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/astro-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/astro-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/astro-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/astro-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/astro-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/astro-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/astro-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/astro-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/astro-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/astro-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/astro-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/astro-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/astro-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/astro-scaffold/deployments","created_at":"2015-04-15T23:56:36Z","updated_at":"2016-01-30T07:16:17Z","pushed_at":"2016-02-29T17:55:46Z","git_url":"git://github.com/mobify/astro-scaffold.git","ssh_url":"git@github.com:mobify/astro-scaffold.git","clone_url":"https://github.com/mobify/astro-scaffold.git","svn_url":"https://github.com/mobify/astro-scaffold","homepage":null,"size":622,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67"},"html":{"href":"https://github.com/mobify/astro-scaffold/pull/67"},"issue":{"href":"https://api.github.com/repos/mobify/astro-scaffold/issues/67"},"comments":{"href":"https://api.github.com/repos/mobify/astro-scaffold/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/astro-scaffold/statuses/046a2f2ace43af0862d8235dd946391b45837a25"}}}}