{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/73360517","id":73360517,"diff_hunk":"@@ -402,16 +411,16 @@ void CalculatePaalmanPings::addShapeSpecificSampleOptions(IAlgorithm_sptr alg,\n void CalculatePaalmanPings::addShapeSpecificCanOptions(IAlgorithm_sptr alg,\n                                                        QString shape) {\n   if (shape == \"FlatPlate\") {\n-    double canFrontThickness = m_uiForm.spFlatCanFrontThickness->value();\n+    const auto canFrontThickness = m_uiForm.spFlatCanFrontThickness->value();\n     alg->setProperty(\"CanFrontThickness\", canFrontThickness);\n \n-    double canBackThickness = m_uiForm.spFlatCanBackThickness->value();\n+    const auto canBackThickness = m_uiForm.spFlatCanBackThickness->value();\n     alg->setProperty(\"SampleThickness\", canBackThickness);\n   } else if (shape == \"Cylinder\") {\n-    double canOuterRadius = m_uiForm.spCylCanOuterRadius->value();\n+    const auto canOuterRadius = m_uiForm.spCylCanOuterRadius->value();\n     alg->setProperty(\"CanOuterRadius\", canOuterRadius);\n   } else if (shape == \"Annulus\") {\n-    double canOuterRadius = m_uiForm.spAnnCanOuterRadius->value();\n+    const auto canOuterRadius = m_uiForm.spAnnCanOuterRadius->value();","path":"MantidQt/CustomInterfaces/src/Indirect/CalculatePaalmanPings.cpp","position":322,"original_position":322,"commit_id":"3e2d4e27e7ac01bf7c60a84673b4153d6b3d977f","original_commit_id":"3e2d4e27e7ac01bf7c60a84673b4153d6b3d977f","user":{"login":"FedeMPouzols","id":5257172,"avatar_url":"https://avatars.githubusercontent.com/u/5257172?v=3","gravatar_id":"","url":"https://api.github.com/users/FedeMPouzols","html_url":"https://github.com/FedeMPouzols","followers_url":"https://api.github.com/users/FedeMPouzols/followers","following_url":"https://api.github.com/users/FedeMPouzols/following{/other_user}","gists_url":"https://api.github.com/users/FedeMPouzols/gists{/gist_id}","starred_url":"https://api.github.com/users/FedeMPouzols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedeMPouzols/subscriptions","organizations_url":"https://api.github.com/users/FedeMPouzols/orgs","repos_url":"https://api.github.com/users/FedeMPouzols/repos","events_url":"https://api.github.com/users/FedeMPouzols/events{/privacy}","received_events_url":"https://api.github.com/users/FedeMPouzols/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-08-03T15:33:20Z","updated_at":"2016-08-03T15:33:20Z","html_url":"https://github.com/mantidproject/mantid/pull/17104#discussion_r73360517","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17104","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/73360517"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17104#discussion_r73360517"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17104"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/17104","id":79699745,"html_url":"https://github.com/mantidproject/mantid/pull/17104","diff_url":"https://github.com/mantidproject/mantid/pull/17104.diff","patch_url":"https://github.com/mantidproject/mantid/pull/17104.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/17104","number":17104,"state":"open","locked":false,"title":"Indirect Corrections Calculate Paalman Pings - Validate chemical formula","user":{"login":"ElliotAOram","id":13132128,"avatar_url":"https://avatars.githubusercontent.com/u/13132128?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliotAOram","html_url":"https://github.com/ElliotAOram","followers_url":"https://api.github.com/users/ElliotAOram/followers","following_url":"https://api.github.com/users/ElliotAOram/following{/other_user}","gists_url":"https://api.github.com/users/ElliotAOram/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliotAOram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliotAOram/subscriptions","organizations_url":"https://api.github.com/users/ElliotAOram/orgs","repos_url":"https://api.github.com/users/ElliotAOram/repos","events_url":"https://api.github.com/users/ElliotAOram/events{/privacy}","received_events_url":"https://api.github.com/users/ElliotAOram/received_events","type":"User","site_admin":false},"body":"The Chemical Formula input fields for Sample and Container in the Calculate Paalman Pings interface now checks that the Chemical formula is valid when text is edited.\r\nAdditional update to use `const auto` where applicable\r\n\r\n**To test:**\r\n\r\n* Open Calculate Paalman Pings (Interfaces > Indirect > Corrections > Calculate Paalman Pings)\r\n* Check the `Use Can` option\r\n* Using the sample: `IRS26176_graphite002_red` and container: `IRS26174_graphite002_red` (available from `\\\\olympic\\Babylon5\\Public\\ElliotOram\\Corrections\\CalculatePaalmanPings\\IRIS\\correction_set`) make the interface match the image below\r\n* ![image](https://cloud.githubusercontent.com/assets/13132128/17323006/1a1587de-5898-11e6-977c-8f542dffa7fc.png)\r\n* Try to enter a valid chemical for sample and container (the `*` should be removed in each case)\r\n* Remove those or enter an invalid chemical formula (the `*` should return)\r\n* Ensure that the interface runs when all chemical formula are valid\r\n* Ensure a descriptive error message is produced when chemicals are missing/invalid\r\n\r\n\r\nFixes #13970 \r\n\r\nChanges only affect the way the user sees the validation (update to the red `*`) hence does not need to be in the release notes.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [x] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2016-08-02T09:05:30Z","updated_at":"2016-08-03T15:33:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"941a74c539147c109d89915acdb05402d8853fab","assignee":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"assignees":[{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars.githubusercontent.com/u/1133249?v=3","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/58","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.8","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/58/labels","id":1505614,"number":58,"title":"Release 3.8","description":"","creator":{"login":"granrothge","id":5910574,"avatar_url":"https://avatars.githubusercontent.com/u/5910574?v=3","gravatar_id":"","url":"https://api.github.com/users/granrothge","html_url":"https://github.com/granrothge","followers_url":"https://api.github.com/users/granrothge/followers","following_url":"https://api.github.com/users/granrothge/following{/other_user}","gists_url":"https://api.github.com/users/granrothge/gists{/gist_id}","starred_url":"https://api.github.com/users/granrothge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granrothge/subscriptions","organizations_url":"https://api.github.com/users/granrothge/orgs","repos_url":"https://api.github.com/users/granrothge/repos","events_url":"https://api.github.com/users/granrothge/events{/privacy}","received_events_url":"https://api.github.com/users/granrothge/received_events","type":"User","site_admin":false},"open_issues":704,"closed_issues":504,"state":"open","created_at":"2016-01-13T20:00:53Z","updated_at":"2016-08-03T15:29:16Z","due_on":"2016-10-09T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17104/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/17104/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/17104/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/3e2d4e27e7ac01bf7c60a84673b4153d6b3d977f","head":{"label":"mantidproject:13970_Indirect_Corr_chemical_formula_required","ref":"13970_Indirect_Corr_chemical_formula_required","sha":"3e2d4e27e7ac01bf7c60a84673b4153d6b3d977f","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-07-15T19:42:24Z","pushed_at":"2016-08-03T15:29:18Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":431466,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":1628,"forks":34,"open_issues":1628,"watchers":46,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"aa4d6b45a5c3357b7bc9a05fc79e88a360b4436a","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars.githubusercontent.com/u/671496?v=3","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2016-07-15T19:42:24Z","pushed_at":"2016-08-03T15:29:18Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":431466,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":1628,"forks":34,"open_issues":1628,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17104"},"html":{"href":"https://github.com/mantidproject/mantid/pull/17104"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17104"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/17104/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17104/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/17104/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/3e2d4e27e7ac01bf7c60a84673b4153d6b3d977f"}}}}
{"actor":{"display_login":"FedeMPouzols"}}