{"action":"created","comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments/64034913","id":64034913,"diff_hunk":"@@ -705,6 +716,66 @@ def td_waveform_to_fd_waveform(waveform, out=None, length=None,\n     htilde.chirp_length = tChirp\n     return htilde\n \n+def get_two_pol_waveform_filter(outplus, outcross, template, **kwargs):\n+    \"\"\"Return a frequency domain waveform filter for the specified approximant\n+    \"\"\"","path":"pycbc/waveform/waveform.py","position":null,"original_position":31,"commit_id":"56e3a7672944dd6c40b6c8173adb6c9678f614af","original_commit_id":"8f8ea2ca78e9349c0e9cd7af6b57023ffd9e594f","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"body":"Doc string updated","created_at":"2016-05-20T12:44:31Z","updated_at":"2016-05-20T12:44:31Z","html_url":"https://github.com/ligo-cbc/pycbc/pull/836#discussion_r64034913","pull_request_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836","_links":{"self":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments/64034913"},"html":{"href":"https://github.com/ligo-cbc/pycbc/pull/836#discussion_r64034913"},"pull_request":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836"}}},"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836","id":69973997,"html_url":"https://github.com/ligo-cbc/pycbc/pull/836","diff_url":"https://github.com/ligo-cbc/pycbc/pull/836.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/836.patch","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/836","number":836,"state":"open","locked":false,"title":"Waveform module changes for precessing search","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"body":"These are the changes to the waveform module needed for the precessing search:\r\n\r\n * We add a two-polarization waveform generation routine, allowing a template to return both h+ and hx (using the same ideas and methods as the single-polarization call)\r\n * We add in length estimates for IMRPhenomPv2 and SpinTaylorF2. Currently this is not great (as it uses an aligned-spin estimator), but can be improved in the future.\r\n * We add a fall-back hack for SpinTaylorF2, such that if the system is aligned-spin, *and* spin2z is non-zero the approximant will fall back to TaylorF2. This allows us to have a template bank containing aligned-spin spin2!=0 waveforms and precessing spin2=0 waveforms with the [Spin]TaylorF2 approximant.","created_at":"2016-05-13T10:23:21Z","updated_at":"2016-05-20T12:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50f377a7d59381f05d6f5130f6b9550b5d7217c6","assignee":{"login":"cdcapano","id":8258446,"avatar_url":"https://avatars.githubusercontent.com/u/8258446?v=3","gravatar_id":"","url":"https://api.github.com/users/cdcapano","html_url":"https://github.com/cdcapano","followers_url":"https://api.github.com/users/cdcapano/followers","following_url":"https://api.github.com/users/cdcapano/following{/other_user}","gists_url":"https://api.github.com/users/cdcapano/gists{/gist_id}","starred_url":"https://api.github.com/users/cdcapano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdcapano/subscriptions","organizations_url":"https://api.github.com/users/cdcapano/orgs","repos_url":"https://api.github.com/users/cdcapano/repos","events_url":"https://api.github.com/users/cdcapano/events{/privacy}","received_events_url":"https://api.github.com/users/cdcapano/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836/commits","review_comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836/comments","review_comment_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/836/comments","statuses_url":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/56e3a7672944dd6c40b6c8173adb6c9678f614af","head":{"label":"spxiwh:precessing_waveform_changes","ref":"precessing_waveform_changes","sha":"56e3a7672944dd6c40b6c8173adb6c9678f614af","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"repo":{"id":36366656,"name":"pycbc","full_name":"spxiwh/pycbc","owner":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spxiwh/pycbc","description":"Python CBC Tools","fork":true,"url":"https://api.github.com/repos/spxiwh/pycbc","forks_url":"https://api.github.com/repos/spxiwh/pycbc/forks","keys_url":"https://api.github.com/repos/spxiwh/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spxiwh/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spxiwh/pycbc/teams","hooks_url":"https://api.github.com/repos/spxiwh/pycbc/hooks","issue_events_url":"https://api.github.com/repos/spxiwh/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/spxiwh/pycbc/events","assignees_url":"https://api.github.com/repos/spxiwh/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/spxiwh/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/spxiwh/pycbc/tags","blobs_url":"https://api.github.com/repos/spxiwh/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spxiwh/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spxiwh/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/spxiwh/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spxiwh/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/spxiwh/pycbc/languages","stargazers_url":"https://api.github.com/repos/spxiwh/pycbc/stargazers","contributors_url":"https://api.github.com/repos/spxiwh/pycbc/contributors","subscribers_url":"https://api.github.com/repos/spxiwh/pycbc/subscribers","subscription_url":"https://api.github.com/repos/spxiwh/pycbc/subscription","commits_url":"https://api.github.com/repos/spxiwh/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/spxiwh/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/spxiwh/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/spxiwh/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/spxiwh/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/spxiwh/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spxiwh/pycbc/merges","archive_url":"https://api.github.com/repos/spxiwh/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spxiwh/pycbc/downloads","issues_url":"https://api.github.com/repos/spxiwh/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/spxiwh/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/spxiwh/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/spxiwh/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spxiwh/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/spxiwh/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/spxiwh/pycbc/deployments","created_at":"2015-05-27T12:53:55Z","updated_at":"2016-03-03T18:20:21Z","pushed_at":"2016-05-20T12:43:54Z","git_url":"git://github.com/spxiwh/pycbc.git","ssh_url":"git@github.com:spxiwh/pycbc.git","clone_url":"https://github.com/spxiwh/pycbc.git","svn_url":"https://github.com/spxiwh/pycbc","homepage":null,"size":26331,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"nr_precessing_devel"}},"base":{"label":"ligo-cbc:master","ref":"master","sha":"89e6cb159caa1a716c00ebda7c14322bd205b3b0","user":{"login":"ligo-cbc","id":11262917,"avatar_url":"https://avatars.githubusercontent.com/u/11262917?v=3","gravatar_id":"","url":"https://api.github.com/users/ligo-cbc","html_url":"https://github.com/ligo-cbc","followers_url":"https://api.github.com/users/ligo-cbc/followers","following_url":"https://api.github.com/users/ligo-cbc/following{/other_user}","gists_url":"https://api.github.com/users/ligo-cbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ligo-cbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligo-cbc/subscriptions","organizations_url":"https://api.github.com/users/ligo-cbc/orgs","repos_url":"https://api.github.com/users/ligo-cbc/repos","events_url":"https://api.github.com/users/ligo-cbc/events{/privacy}","received_events_url":"https://api.github.com/users/ligo-cbc/received_events","type":"Organization","site_admin":false},"repo":{"id":31596861,"name":"pycbc","full_name":"ligo-cbc/pycbc","owner":{"login":"ligo-cbc","id":11262917,"avatar_url":"https://avatars.githubusercontent.com/u/11262917?v=3","gravatar_id":"","url":"https://api.github.com/users/ligo-cbc","html_url":"https://github.com/ligo-cbc","followers_url":"https://api.github.com/users/ligo-cbc/followers","following_url":"https://api.github.com/users/ligo-cbc/following{/other_user}","gists_url":"https://api.github.com/users/ligo-cbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ligo-cbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligo-cbc/subscriptions","organizations_url":"https://api.github.com/users/ligo-cbc/orgs","repos_url":"https://api.github.com/users/ligo-cbc/repos","events_url":"https://api.github.com/users/ligo-cbc/events{/privacy}","received_events_url":"https://api.github.com/users/ligo-cbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ligo-cbc/pycbc","description":"Python CBC Tools","fork":false,"url":"https://api.github.com/repos/ligo-cbc/pycbc","forks_url":"https://api.github.com/repos/ligo-cbc/pycbc/forks","keys_url":"https://api.github.com/repos/ligo-cbc/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligo-cbc/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligo-cbc/pycbc/teams","hooks_url":"https://api.github.com/repos/ligo-cbc/pycbc/hooks","issue_events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/events","assignees_url":"https://api.github.com/repos/ligo-cbc/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/ligo-cbc/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/ligo-cbc/pycbc/tags","blobs_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/ligo-cbc/pycbc/languages","stargazers_url":"https://api.github.com/repos/ligo-cbc/pycbc/stargazers","contributors_url":"https://api.github.com/repos/ligo-cbc/pycbc/contributors","subscribers_url":"https://api.github.com/repos/ligo-cbc/pycbc/subscribers","subscription_url":"https://api.github.com/repos/ligo-cbc/pycbc/subscription","commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligo-cbc/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/ligo-cbc/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligo-cbc/pycbc/merges","archive_url":"https://api.github.com/repos/ligo-cbc/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligo-cbc/pycbc/downloads","issues_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/ligo-cbc/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/ligo-cbc/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/ligo-cbc/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/ligo-cbc/pycbc/deployments","created_at":"2015-03-03T12:19:19Z","updated_at":"2016-05-12T15:48:56Z","pushed_at":"2016-05-20T12:43:54Z","git_url":"git://github.com/ligo-cbc/pycbc.git","ssh_url":"git@github.com:ligo-cbc/pycbc.git","clone_url":"https://github.com/ligo-cbc/pycbc.git","svn_url":"https://github.com/ligo-cbc/pycbc","homepage":null,"size":135367,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":68,"mirror_url":null,"open_issues_count":53,"forks":68,"open_issues":53,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836"},"html":{"href":"https://github.com/ligo-cbc/pycbc/pull/836"},"issue":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/issues/836"},"comments":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/56e3a7672944dd6c40b6c8173adb6c9678f614af"}}}}
{"actor":{"display_login":"spxiwh"}}