{"action":"created","comment":{"url":"https://api.github.com/repos/atk4/data/pulls/comments/72067691","id":72067691,"diff_hunk":"@@ -912,12 +1173,18 @@ public function join($foreign_table, $defaults = [])\n         return $this->add(new $c($defaults));\n     }\n \n+    /**\n+     * Left Join support.\n+     *\n+     * @see join()\n+     *\n+     * @param string $foreign_table\n+     * @param array  $defaults\n+     *\n+     * @return Join\n+     */\n     public function leftJoin($foreign_table, $defaults = [])\n     {\n-        if (!is_array($defaults)) {\n-            $defaults = ['master_field' => $defaults];\n-        }\n-","path":"src/Model.php","position":651,"original_position":651,"commit_id":"5e615401e952393beab36049da6614894f92a793","original_commit_id":"5e615401e952393beab36049da6614894f92a793","user":{"login":"DarkSide666","id":1969119,"avatar_url":"https://avatars.githubusercontent.com/u/1969119?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkSide666","html_url":"https://github.com/DarkSide666","followers_url":"https://api.github.com/users/DarkSide666/followers","following_url":"https://api.github.com/users/DarkSide666/following{/other_user}","gists_url":"https://api.github.com/users/DarkSide666/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkSide666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkSide666/subscriptions","organizations_url":"https://api.github.com/users/DarkSide666/orgs","repos_url":"https://api.github.com/users/DarkSide666/repos","events_url":"https://api.github.com/users/DarkSide666/events{/privacy}","received_events_url":"https://api.github.com/users/DarkSide666/received_events","type":"User","site_admin":false},"body":"Yes, that's my mistake.\r\nIt looked that `join()` have same checking so I removed this \"duplicated\" one, but I didn't notice, that `$defaults['weak'] = true;` line which changes situation :(","created_at":"2016-07-25T13:58:44Z","updated_at":"2016-07-25T13:58:44Z","html_url":"https://github.com/atk4/data/pull/70#discussion_r72067691","pull_request_url":"https://api.github.com/repos/atk4/data/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/atk4/data/pulls/comments/72067691"},"html":{"href":"https://github.com/atk4/data/pull/70#discussion_r72067691"},"pull_request":{"href":"https://api.github.com/repos/atk4/data/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/atk4/data/pulls/70","id":78551156,"html_url":"https://github.com/atk4/data/pull/70","diff_url":"https://github.com/atk4/data/pull/70.diff","patch_url":"https://github.com/atk4/data/pull/70.patch","issue_url":"https://api.github.com/repos/atk4/data/issues/70","number":70,"state":"closed","locked":false,"title":"Add descriptions and few fixes","user":{"login":"DarkSide666","id":1969119,"avatar_url":"https://avatars.githubusercontent.com/u/1969119?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkSide666","html_url":"https://github.com/DarkSide666","followers_url":"https://api.github.com/users/DarkSide666/followers","following_url":"https://api.github.com/users/DarkSide666/following{/other_user}","gists_url":"https://api.github.com/users/DarkSide666/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkSide666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkSide666/subscriptions","organizations_url":"https://api.github.com/users/DarkSide666/orgs","repos_url":"https://api.github.com/users/DarkSide666/repos","events_url":"https://api.github.com/users/DarkSide666/events{/privacy}","received_events_url":"https://api.github.com/users/DarkSide666/received_events","type":"User","site_admin":false},"body":"Mostly descriptions for methods and properties are added.\r\nBut there are a few fixes too - not much, but still.\r\n","created_at":"2016-07-22T22:54:21Z","updated_at":"2016-07-25T13:58:44Z","closed_at":"2016-07-23T23:24:47Z","merged_at":"2016-07-23T23:24:47Z","merge_commit_sha":"80c8441f24206be62199b4bf142a1be5b47dcfc6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atk4/data/pulls/70/commits","review_comments_url":"https://api.github.com/repos/atk4/data/pulls/70/comments","review_comment_url":"https://api.github.com/repos/atk4/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atk4/data/issues/70/comments","statuses_url":"https://api.github.com/repos/atk4/data/statuses/5e615401e952393beab36049da6614894f92a793","head":{"label":"atk4:feature/add-descriptions","ref":"feature/add-descriptions","sha":"5e615401e952393beab36049da6614894f92a793","user":{"login":"atk4","id":454075,"avatar_url":"https://avatars.githubusercontent.com/u/454075?v=3","gravatar_id":"","url":"https://api.github.com/users/atk4","html_url":"https://github.com/atk4","followers_url":"https://api.github.com/users/atk4/followers","following_url":"https://api.github.com/users/atk4/following{/other_user}","gists_url":"https://api.github.com/users/atk4/gists{/gist_id}","starred_url":"https://api.github.com/users/atk4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atk4/subscriptions","organizations_url":"https://api.github.com/users/atk4/orgs","repos_url":"https://api.github.com/users/atk4/repos","events_url":"https://api.github.com/users/atk4/events{/privacy}","received_events_url":"https://api.github.com/users/atk4/received_events","type":"Organization","site_admin":false},"repo":{"id":56442737,"name":"data","full_name":"atk4/data","owner":{"login":"atk4","id":454075,"avatar_url":"https://avatars.githubusercontent.com/u/454075?v=3","gravatar_id":"","url":"https://api.github.com/users/atk4","html_url":"https://github.com/atk4","followers_url":"https://api.github.com/users/atk4/followers","following_url":"https://api.github.com/users/atk4/following{/other_user}","gists_url":"https://api.github.com/users/atk4/gists{/gist_id}","starred_url":"https://api.github.com/users/atk4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atk4/subscriptions","organizations_url":"https://api.github.com/users/atk4/orgs","repos_url":"https://api.github.com/users/atk4/repos","events_url":"https://api.github.com/users/atk4/events{/privacy}","received_events_url":"https://api.github.com/users/atk4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atk4/data","description":"Agile Data - PHP Framework for better Business Logic design and scalable database access.","fork":false,"url":"https://api.github.com/repos/atk4/data","forks_url":"https://api.github.com/repos/atk4/data/forks","keys_url":"https://api.github.com/repos/atk4/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atk4/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atk4/data/teams","hooks_url":"https://api.github.com/repos/atk4/data/hooks","issue_events_url":"https://api.github.com/repos/atk4/data/issues/events{/number}","events_url":"https://api.github.com/repos/atk4/data/events","assignees_url":"https://api.github.com/repos/atk4/data/assignees{/user}","branches_url":"https://api.github.com/repos/atk4/data/branches{/branch}","tags_url":"https://api.github.com/repos/atk4/data/tags","blobs_url":"https://api.github.com/repos/atk4/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atk4/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atk4/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/atk4/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atk4/data/statuses/{sha}","languages_url":"https://api.github.com/repos/atk4/data/languages","stargazers_url":"https://api.github.com/repos/atk4/data/stargazers","contributors_url":"https://api.github.com/repos/atk4/data/contributors","subscribers_url":"https://api.github.com/repos/atk4/data/subscribers","subscription_url":"https://api.github.com/repos/atk4/data/subscription","commits_url":"https://api.github.com/repos/atk4/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/atk4/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/atk4/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/atk4/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/atk4/data/contents/{+path}","compare_url":"https://api.github.com/repos/atk4/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atk4/data/merges","archive_url":"https://api.github.com/repos/atk4/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atk4/data/downloads","issues_url":"https://api.github.com/repos/atk4/data/issues{/number}","pulls_url":"https://api.github.com/repos/atk4/data/pulls{/number}","milestones_url":"https://api.github.com/repos/atk4/data/milestones{/number}","notifications_url":"https://api.github.com/repos/atk4/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atk4/data/labels{/name}","releases_url":"https://api.github.com/repos/atk4/data/releases{/id}","deployments_url":"https://api.github.com/repos/atk4/data/deployments","created_at":"2016-04-17T15:09:18Z","updated_at":"2016-07-19T13:02:14Z","pushed_at":"2016-07-25T13:22:36Z","git_url":"git://github.com/atk4/data.git","ssh_url":"git@github.com:atk4/data.git","clone_url":"https://github.com/atk4/data.git","svn_url":"https://github.com/atk4/data","homepage":"","size":2429,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":5,"default_branch":"develop"}},"base":{"label":"atk4:develop","ref":"develop","sha":"93e5d6673c1c5bad12d84e3468cd096b06d25307","user":{"login":"atk4","id":454075,"avatar_url":"https://avatars.githubusercontent.com/u/454075?v=3","gravatar_id":"","url":"https://api.github.com/users/atk4","html_url":"https://github.com/atk4","followers_url":"https://api.github.com/users/atk4/followers","following_url":"https://api.github.com/users/atk4/following{/other_user}","gists_url":"https://api.github.com/users/atk4/gists{/gist_id}","starred_url":"https://api.github.com/users/atk4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atk4/subscriptions","organizations_url":"https://api.github.com/users/atk4/orgs","repos_url":"https://api.github.com/users/atk4/repos","events_url":"https://api.github.com/users/atk4/events{/privacy}","received_events_url":"https://api.github.com/users/atk4/received_events","type":"Organization","site_admin":false},"repo":{"id":56442737,"name":"data","full_name":"atk4/data","owner":{"login":"atk4","id":454075,"avatar_url":"https://avatars.githubusercontent.com/u/454075?v=3","gravatar_id":"","url":"https://api.github.com/users/atk4","html_url":"https://github.com/atk4","followers_url":"https://api.github.com/users/atk4/followers","following_url":"https://api.github.com/users/atk4/following{/other_user}","gists_url":"https://api.github.com/users/atk4/gists{/gist_id}","starred_url":"https://api.github.com/users/atk4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atk4/subscriptions","organizations_url":"https://api.github.com/users/atk4/orgs","repos_url":"https://api.github.com/users/atk4/repos","events_url":"https://api.github.com/users/atk4/events{/privacy}","received_events_url":"https://api.github.com/users/atk4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atk4/data","description":"Agile Data - PHP Framework for better Business Logic design and scalable database access.","fork":false,"url":"https://api.github.com/repos/atk4/data","forks_url":"https://api.github.com/repos/atk4/data/forks","keys_url":"https://api.github.com/repos/atk4/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atk4/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atk4/data/teams","hooks_url":"https://api.github.com/repos/atk4/data/hooks","issue_events_url":"https://api.github.com/repos/atk4/data/issues/events{/number}","events_url":"https://api.github.com/repos/atk4/data/events","assignees_url":"https://api.github.com/repos/atk4/data/assignees{/user}","branches_url":"https://api.github.com/repos/atk4/data/branches{/branch}","tags_url":"https://api.github.com/repos/atk4/data/tags","blobs_url":"https://api.github.com/repos/atk4/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atk4/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atk4/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/atk4/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atk4/data/statuses/{sha}","languages_url":"https://api.github.com/repos/atk4/data/languages","stargazers_url":"https://api.github.com/repos/atk4/data/stargazers","contributors_url":"https://api.github.com/repos/atk4/data/contributors","subscribers_url":"https://api.github.com/repos/atk4/data/subscribers","subscription_url":"https://api.github.com/repos/atk4/data/subscription","commits_url":"https://api.github.com/repos/atk4/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/atk4/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/atk4/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/atk4/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/atk4/data/contents/{+path}","compare_url":"https://api.github.com/repos/atk4/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atk4/data/merges","archive_url":"https://api.github.com/repos/atk4/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atk4/data/downloads","issues_url":"https://api.github.com/repos/atk4/data/issues{/number}","pulls_url":"https://api.github.com/repos/atk4/data/pulls{/number}","milestones_url":"https://api.github.com/repos/atk4/data/milestones{/number}","notifications_url":"https://api.github.com/repos/atk4/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atk4/data/labels{/name}","releases_url":"https://api.github.com/repos/atk4/data/releases{/id}","deployments_url":"https://api.github.com/repos/atk4/data/deployments","created_at":"2016-04-17T15:09:18Z","updated_at":"2016-07-19T13:02:14Z","pushed_at":"2016-07-25T13:22:36Z","git_url":"git://github.com/atk4/data.git","ssh_url":"git@github.com:atk4/data.git","clone_url":"https://github.com/atk4/data.git","svn_url":"https://github.com/atk4/data","homepage":"","size":2429,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/atk4/data/pulls/70"},"html":{"href":"https://github.com/atk4/data/pull/70"},"issue":{"href":"https://api.github.com/repos/atk4/data/issues/70"},"comments":{"href":"https://api.github.com/repos/atk4/data/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/atk4/data/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/atk4/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atk4/data/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/atk4/data/statuses/5e615401e952393beab36049da6614894f92a793"}}}}
{"actor":{"display_login":"DarkSide666"}}