{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10377","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10377/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10377/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10377/events","html_url":"https://github.com/servo/servo/pull/10377","id":145428735,"number":10377,"title":"geckolib: All bindings aligning properly!","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-merge","name":"S-awaiting-merge","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"bholley","id":377435,"avatar_url":"https://avatars.githubusercontent.com/u/377435?v=3","gravatar_id":"","url":"https://api.github.com/users/bholley","html_url":"https://github.com/bholley","followers_url":"https://api.github.com/users/bholley/followers","following_url":"https://api.github.com/users/bholley/following{/other_user}","gists_url":"https://api.github.com/users/bholley/gists{/gist_id}","starred_url":"https://api.github.com/users/bholley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bholley/subscriptions","organizations_url":"https://api.github.com/users/bholley/orgs","repos_url":"https://api.github.com/users/bholley/repos","events_url":"https://api.github.com/users/bholley/events{/privacy}","received_events_url":"https://api.github.com/users/bholley/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2016-04-02T23:15:07Z","updated_at":"2016-04-04T20:07:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/10377","html_url":"https://github.com/servo/servo/pull/10377","diff_url":"https://github.com/servo/servo/pull/10377.diff","patch_url":"https://github.com/servo/servo/pull/10377.patch"},"body":"So the following PR includes bitfield support and correct `#[repr(..)]` for enum declarations (even though I was forced to add a dummy variant in order for `rustc` to be happy).\r\n\r\nSo... **That makes all of our style structs align correctly**!\r\n\r\nThe only failing test is `nsDataHashTable`, but you know, that test is ill-formed because of it being an opaque type with type parameters.\r\n\r\nBTW, just landed on bindgen https://github.com/emilio/rust-bindgen/commit/7ee7bae7887899642f9c07f9c02ee841e9f06556, so you can add `-raw-line \"use gecko_style_structs::*;\"` in `regen_bindings.sh` and stop relying on manual hacks.\r\n\r\nr? @bholley\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/10377)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/205472977","html_url":"https://github.com/servo/servo/pull/10377#issuecomment-205472977","issue_url":"https://api.github.com/repos/servo/servo/issues/10377","id":205472977,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T20:07:53Z","updated_at":"2016-04-04T20:07:53Z","body":":sunny: Test successful - [android](http://build.servo.org/builders/android/builds/88), [arm32](http://build.servo.org/builders/arm32/builds/97), [linux-dev](http://build.servo.org/builders/linux-dev/builds/94), [linux-rel](http://build.servo.org/builders/linux-rel/builds/97), [mac-dev-unit](http://build.servo.org/builders/mac-dev-unit/builds/98), [mac-rel-css](http://build.servo.org/builders/mac-rel-css/builds/93), [mac-rel-wpt](http://build.servo.org/builders/mac-rel-wpt/builds/95), [status-appveyor](https://ci.appveyor.com/project/servo/servo/build/1.0.1974)"}}