{"action":"created","comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/51326618","id":51326618,"diff_hunk":"@@ -31,7 +31,7 @@ LT_INIT([pic-only])\n AC_SUBST([LIBTOOL_DEPS])\n \n AC_PROG_CC(cc gcc)\n-# AC_PROG_CXX(c++ g++)\n+AC_PROG_CXX(c++ g++)","path":"build_posix/configure.ac.in","position":5,"original_position":5,"commit_id":"a679c103fcbb7473ae8a4f83f0cdd6023ddff651","original_commit_id":"a679c103fcbb7473ae8a4f83f0cdd6023ddff651","user":{"login":"keithbostic","id":1393186,"avatar_url":"https://avatars.githubusercontent.com/u/1393186?v=3","gravatar_id":"","url":"https://api.github.com/users/keithbostic","html_url":"https://github.com/keithbostic","followers_url":"https://api.github.com/users/keithbostic/followers","following_url":"https://api.github.com/users/keithbostic/following{/other_user}","gists_url":"https://api.github.com/users/keithbostic/gists{/gist_id}","starred_url":"https://api.github.com/users/keithbostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithbostic/subscriptions","organizations_url":"https://api.github.com/users/keithbostic/orgs","repos_url":"https://api.github.com/users/keithbostic/repos","events_url":"https://api.github.com/users/keithbostic/events{/privacy}","received_events_url":"https://api.github.com/users/keithbostic/received_events","type":"User","site_admin":false},"body":"@markbenvenuto, I understand the rest, but why did this line change?","created_at":"2016-01-29T22:45:49Z","updated_at":"2016-01-29T22:45:49Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/2468#discussion_r51326618","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/51326618"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/2468#discussion_r51326618"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468"}}},"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468","id":57710795,"html_url":"https://github.com/wiredtiger/wiredtiger/pull/2468","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/2468.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/2468.patch","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2468","number":2468,"state":"open","locked":false,"title":"WT-2369 Use C compiler to detect headers instead of C++ compiler","user":{"login":"markbenvenuto","id":6145346,"avatar_url":"https://avatars.githubusercontent.com/u/6145346?v=3","gravatar_id":"","url":"https://api.github.com/users/markbenvenuto","html_url":"https://github.com/markbenvenuto","followers_url":"https://api.github.com/users/markbenvenuto/followers","following_url":"https://api.github.com/users/markbenvenuto/following{/other_user}","gists_url":"https://api.github.com/users/markbenvenuto/gists{/gist_id}","starred_url":"https://api.github.com/users/markbenvenuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbenvenuto/subscriptions","organizations_url":"https://api.github.com/users/markbenvenuto/orgs","repos_url":"https://api.github.com/users/markbenvenuto/repos","events_url":"https://api.github.com/users/markbenvenuto/events{/privacy}","received_events_url":"https://api.github.com/users/markbenvenuto/received_events","type":"User","site_admin":false},"body":"WiredTiger's options.m4 uses the C++ compiler instead of the C compiler to check for several C headers:\r\n* snappy.h\r\n* lz4.h\r\n* gperftools/tcmalloc.h\r\n\r\n`snappy.h` is a C++ header while `snappy-c.h` is the C equivalent, and the one included by `snappy_compress.c`.\r\n\r\nBy only using the C compiler for both header file checking and compilation, a user only needs to specify `CCFLAGS` instead of both `CCFLAGS` and `CXXFLAGS` during configure.\r\n\r\nIn order to support the `api/leveldb` directory, we need the C++ compiler. Previously the `AC_LANG_PUSH` macro was adding a dependency on it and now we need to be explicit the C++ compiler.","created_at":"2016-01-29T22:18:09Z","updated_at":"2016-01-29T22:45:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ddd064346792d519f7f183b15ff1f37277694b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468/commits","review_comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468/comments","review_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2468/comments","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/a679c103fcbb7473ae8a4f83f0cdd6023ddff651","head":{"label":"wiredtiger:wt-2369-improve-options-m4","ref":"wt-2369-improve-options-m4","sha":"a679c103fcbb7473ae8a4f83f0cdd6023ddff651","user":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2016-01-28T15:32:18Z","pushed_at":"2016-01-29T22:36:32Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":81605,"stargazers_count":668,"watchers_count":668,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":12,"forks":117,"open_issues":12,"watchers":668,"default_branch":"master"}},"base":{"label":"wiredtiger:develop","ref":"develop","sha":"dea25e13b8e15a8528f374656ce2e8432a66c9f4","user":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"name":"wiredtiger","full_name":"wiredtiger/wiredtiger","owner":{"login":"wiredtiger","id":1251095,"avatar_url":"https://avatars.githubusercontent.com/u/1251095?v=3","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2016-01-28T15:32:18Z","pushed_at":"2016-01-29T22:36:32Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":81605,"stargazers_count":668,"watchers_count":668,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":12,"forks":117,"open_issues":12,"watchers":668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/2468"},"issue":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2468"},"comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/2468/comments"},"review_comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468/comments"},"review_comment":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/2468/commits"},"statuses":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/a679c103fcbb7473ae8a4f83f0cdd6023ddff651"}}}}