{"action":"closed","number":1298,"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1298","id":92030014,"html_url":"https://github.com/Microsoft/WinObjC/pull/1298","diff_url":"https://github.com/Microsoft/WinObjC/pull/1298.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/1298.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1298","number":1298,"state":"closed","locked":false,"title":"Support kCTParagraphStyleSpecifierLineHeightMultiple","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"body":"Adds support for kCTParagraphStyleSpecifierLineHeightMultiple.  DWrite only allows line height multiples if the line height is kept constant through the frame, which is not guaranteed, so we need to manually manipulate the line origins.  Also removes the redundant line origin variable in _CTLine.\r\n\r\nFixes #1090\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/microsoft/winobjc/1298)\n<!-- Reviewable:end -->\n","created_at":"2016-11-02T18:34:47Z","updated_at":"2016-11-04T19:00:18Z","closed_at":"2016-11-04T19:00:18Z","merged_at":"2016-11-04T19:00:18Z","merge_commit_sha":"b73f8ce14af31627c527ed660ad05602d6d4c596","assignee":{"login":"rajsesh-msft","id":15148713,"avatar_url":"https://avatars.githubusercontent.com/u/15148713?v=3","gravatar_id":"","url":"https://api.github.com/users/rajsesh-msft","html_url":"https://github.com/rajsesh-msft","followers_url":"https://api.github.com/users/rajsesh-msft/followers","following_url":"https://api.github.com/users/rajsesh-msft/following{/other_user}","gists_url":"https://api.github.com/users/rajsesh-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/rajsesh-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajsesh-msft/subscriptions","organizations_url":"https://api.github.com/users/rajsesh-msft/orgs","repos_url":"https://api.github.com/users/rajsesh-msft/repos","events_url":"https://api.github.com/users/rajsesh-msft/events{/privacy}","received_events_url":"https://api.github.com/users/rajsesh-msft/received_events","type":"User","site_admin":false},"assignees":[{"login":"rajsesh-msft","id":15148713,"avatar_url":"https://avatars.githubusercontent.com/u/15148713?v=3","gravatar_id":"","url":"https://api.github.com/users/rajsesh-msft","html_url":"https://github.com/rajsesh-msft","followers_url":"https://api.github.com/users/rajsesh-msft/followers","following_url":"https://api.github.com/users/rajsesh-msft/following{/other_user}","gists_url":"https://api.github.com/users/rajsesh-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/rajsesh-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajsesh-msft/subscriptions","organizations_url":"https://api.github.com/users/rajsesh-msft/orgs","repos_url":"https://api.github.com/users/rajsesh-msft/repos","events_url":"https://api.github.com/users/rajsesh-msft/events{/privacy}","received_events_url":"https://api.github.com/users/rajsesh-msft/received_events","type":"User","site_admin":false},{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1298/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1298/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1298/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/2e6e0465886713b6fd57bbd78b803edfc65c9901","head":{"label":"aballway:develop","ref":"develop","sha":"2e6e0465886713b6fd57bbd78b803edfc65c9901","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"repo":{"id":62087158,"name":"WinObjC","full_name":"aballway/WinObjC","owner":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aballway/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/aballway/WinObjC","forks_url":"https://api.github.com/repos/aballway/WinObjC/forks","keys_url":"https://api.github.com/repos/aballway/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aballway/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aballway/WinObjC/teams","hooks_url":"https://api.github.com/repos/aballway/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/aballway/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/aballway/WinObjC/events","assignees_url":"https://api.github.com/repos/aballway/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/aballway/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/aballway/WinObjC/tags","blobs_url":"https://api.github.com/repos/aballway/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aballway/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aballway/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/aballway/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aballway/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/aballway/WinObjC/languages","stargazers_url":"https://api.github.com/repos/aballway/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/aballway/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/aballway/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/aballway/WinObjC/subscription","commits_url":"https://api.github.com/repos/aballway/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/aballway/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/aballway/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/aballway/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/aballway/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/aballway/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aballway/WinObjC/merges","archive_url":"https://api.github.com/repos/aballway/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aballway/WinObjC/downloads","issues_url":"https://api.github.com/repos/aballway/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/aballway/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/aballway/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/aballway/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aballway/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/aballway/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/aballway/WinObjC/deployments","created_at":"2016-06-27T20:48:04Z","updated_at":"2016-06-28T17:00:56Z","pushed_at":"2016-11-04T17:43:10Z","git_url":"git://github.com/aballway/WinObjC.git","ssh_url":"git@github.com:aballway/WinObjC.git","clone_url":"https://github.com/aballway/WinObjC.git","svn_url":"https://github.com/aballway/WinObjC","homepage":"","size":332106,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"5eed89515ee50ef9a3c8f5aac7cae1658d4f5083","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-11-04T16:39:04Z","pushed_at":"2016-11-04T19:00:19Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":364990,"stargazers_count":5507,"watchers_count":5507,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":719,"mirror_url":null,"open_issues_count":269,"forks":719,"open_issues":269,"watchers":5507,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1298"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1298"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1298"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1298/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1298/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1298/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/2e6e0465886713b6fd57bbd78b803edfc65c9901"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"comments":3,"review_comments":13,"commits":4,"additions":103,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"aballway"}}