{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments/70357198","id":70357198,"diff_hunk":"@@ -46,6 +46,25 @@ public override bool SupportsFrameFormatting\n             }\n         }\n \n+        protected override StringBuilder BuildBreakInsert(string condition)\n+        {\n+            // LLDB's use of the pending flag requires an optional parameter or else it fails.\n+            // We will use \"on\" for now. \n+            // TODO: Fix this on LLDB-MI's side\n+            string pendingFlag = \"-f on \";","path":"src/MICore/CommandFactories/lldb.cs","position":9,"original_position":9,"commit_id":"9272fab2595913bd5334d9db90e92ad46706ba0a","original_commit_id":"9272fab2595913bd5334d9db90e92ad46706ba0a","user":{"login":"edumunoz","id":637952,"avatar_url":"https://avatars.githubusercontent.com/u/637952?v=3","gravatar_id":"","url":"https://api.github.com/users/edumunoz","html_url":"https://github.com/edumunoz","followers_url":"https://api.github.com/users/edumunoz/followers","following_url":"https://api.github.com/users/edumunoz/following{/other_user}","gists_url":"https://api.github.com/users/edumunoz/gists{/gist_id}","starred_url":"https://api.github.com/users/edumunoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edumunoz/subscriptions","organizations_url":"https://api.github.com/users/edumunoz/orgs","repos_url":"https://api.github.com/users/edumunoz/repos","events_url":"https://api.github.com/users/edumunoz/events{/privacy}","received_events_url":"https://api.github.com/users/edumunoz/received_events","type":"User","site_admin":false},"body":"Move `pendingFlag` as part of ` cmd` like it's done in `MICommandFactory`?","created_at":"2016-07-11T23:46:35Z","updated_at":"2016-07-11T23:46:35Z","html_url":"https://github.com/Microsoft/MIEngine/pull/386#discussion_r70357198","pull_request_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments/70357198"},"html":{"href":"https://github.com/Microsoft/MIEngine/pull/386#discussion_r70357198"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386","id":77036024,"html_url":"https://github.com/Microsoft/MIEngine/pull/386","diff_url":"https://github.com/Microsoft/MIEngine/pull/386.diff","patch_url":"https://github.com/Microsoft/MIEngine/pull/386.patch","issue_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/386","number":386,"state":"open","locked":false,"title":"Allow lldb-mi's conditional breakpoint -break-insert to work with -f","user":{"login":"pieandcakes","id":17558378,"avatar_url":"https://avatars.githubusercontent.com/u/17558378?v=3","gravatar_id":"","url":"https://api.github.com/users/pieandcakes","html_url":"https://github.com/pieandcakes","followers_url":"https://api.github.com/users/pieandcakes/followers","following_url":"https://api.github.com/users/pieandcakes/following{/other_user}","gists_url":"https://api.github.com/users/pieandcakes/gists{/gist_id}","starred_url":"https://api.github.com/users/pieandcakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieandcakes/subscriptions","organizations_url":"https://api.github.com/users/pieandcakes/orgs","repos_url":"https://api.github.com/users/pieandcakes/repos","events_url":"https://api.github.com/users/pieandcakes/events{/privacy}","received_events_url":"https://api.github.com/users/pieandcakes/received_events","type":"User","site_admin":false},"body":"-break-insert's -f on lldb-mi requires a parameter.\r\n\r\n@faxue-msft @chuckries ","created_at":"2016-07-11T22:48:09Z","updated_at":"2016-07-11T23:46:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"844ba5fbad26c71a5e6a11ff43c360e149043a3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/386/comments","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/9272fab2595913bd5334d9db90e92ad46706ba0a","head":{"label":"Microsoft:users/piel/breakinsert","ref":"users/piel/breakinsert","sha":"9272fab2595913bd5334d9db90e92ad46706ba0a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36405087,"name":"MIEngine","full_name":"Microsoft/MIEngine","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MIEngine","description":"The Visual Studio MI Debug Engine (\"MIEngine\") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb, lldb, and clrdbg. ","fork":false,"url":"https://api.github.com/repos/Microsoft/MIEngine","forks_url":"https://api.github.com/repos/Microsoft/MIEngine/forks","keys_url":"https://api.github.com/repos/Microsoft/MIEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MIEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MIEngine/teams","hooks_url":"https://api.github.com/repos/Microsoft/MIEngine/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MIEngine/events","assignees_url":"https://api.github.com/repos/Microsoft/MIEngine/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MIEngine/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MIEngine/tags","blobs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MIEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MIEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MIEngine/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MIEngine/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MIEngine/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MIEngine/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MIEngine/subscription","commits_url":"https://api.github.com/repos/Microsoft/MIEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MIEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MIEngine/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MIEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MIEngine/merges","archive_url":"https://api.github.com/repos/Microsoft/MIEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MIEngine/downloads","issues_url":"https://api.github.com/repos/Microsoft/MIEngine/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MIEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MIEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MIEngine/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MIEngine/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MIEngine/deployments","created_at":"2015-05-28T00:44:08Z","updated_at":"2016-06-30T12:24:50Z","pushed_at":"2016-07-11T23:20:41Z","git_url":"git://github.com/Microsoft/MIEngine.git","ssh_url":"git@github.com:Microsoft/MIEngine.git","clone_url":"https://github.com/Microsoft/MIEngine.git","svn_url":"https://github.com/Microsoft/MIEngine","homepage":null,"size":5122,"stargazers_count":328,"watchers_count":328,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":36,"forks":95,"open_issues":36,"watchers":328,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"70c88886bc9a741c7a3f91012fdb1b2cf3b185a7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36405087,"name":"MIEngine","full_name":"Microsoft/MIEngine","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MIEngine","description":"The Visual Studio MI Debug Engine (\"MIEngine\") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb, lldb, and clrdbg. ","fork":false,"url":"https://api.github.com/repos/Microsoft/MIEngine","forks_url":"https://api.github.com/repos/Microsoft/MIEngine/forks","keys_url":"https://api.github.com/repos/Microsoft/MIEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MIEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MIEngine/teams","hooks_url":"https://api.github.com/repos/Microsoft/MIEngine/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MIEngine/events","assignees_url":"https://api.github.com/repos/Microsoft/MIEngine/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MIEngine/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MIEngine/tags","blobs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MIEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MIEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MIEngine/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MIEngine/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MIEngine/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MIEngine/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MIEngine/subscription","commits_url":"https://api.github.com/repos/Microsoft/MIEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MIEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MIEngine/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MIEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MIEngine/merges","archive_url":"https://api.github.com/repos/Microsoft/MIEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MIEngine/downloads","issues_url":"https://api.github.com/repos/Microsoft/MIEngine/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MIEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MIEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MIEngine/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MIEngine/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MIEngine/deployments","created_at":"2015-05-28T00:44:08Z","updated_at":"2016-06-30T12:24:50Z","pushed_at":"2016-07-11T23:20:41Z","git_url":"git://github.com/Microsoft/MIEngine.git","ssh_url":"git@github.com:Microsoft/MIEngine.git","clone_url":"https://github.com/Microsoft/MIEngine.git","svn_url":"https://github.com/Microsoft/MIEngine","homepage":null,"size":5122,"stargazers_count":328,"watchers_count":328,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":36,"forks":95,"open_issues":36,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386"},"html":{"href":"https://github.com/Microsoft/MIEngine/pull/386"},"issue":{"href":"https://api.github.com/repos/Microsoft/MIEngine/issues/386"},"comments":{"href":"https://api.github.com/repos/Microsoft/MIEngine/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MIEngine/statuses/9272fab2595913bd5334d9db90e92ad46706ba0a"}}}}
{"actor":{"display_login":"edumunoz"}}