{"action":"created","issue":{"url":"https://api.github.com/repos/airbnb/react-native-maps/issues/625","repository_url":"https://api.github.com/repos/airbnb/react-native-maps","labels_url":"https://api.github.com/repos/airbnb/react-native-maps/issues/625/labels{/name}","comments_url":"https://api.github.com/repos/airbnb/react-native-maps/issues/625/comments","events_url":"https://api.github.com/repos/airbnb/react-native-maps/issues/625/events","html_url":"https://github.com/airbnb/react-native-maps/pull/625","id":179893268,"number":625,"title":"Added support for taking snapshots on Android","user":{"login":"IjzerenHein","id":6184593,"avatar_url":"https://avatars.githubusercontent.com/u/6184593?v=3","gravatar_id":"","url":"https://api.github.com/users/IjzerenHein","html_url":"https://github.com/IjzerenHein","followers_url":"https://api.github.com/users/IjzerenHein/followers","following_url":"https://api.github.com/users/IjzerenHein/following{/other_user}","gists_url":"https://api.github.com/users/IjzerenHein/gists{/gist_id}","starred_url":"https://api.github.com/users/IjzerenHein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IjzerenHein/subscriptions","organizations_url":"https://api.github.com/users/IjzerenHein/orgs","repos_url":"https://api.github.com/users/IjzerenHein/repos","events_url":"https://api.github.com/users/IjzerenHein/events{/privacy}","received_events_url":"https://api.github.com/users/IjzerenHein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-09-28T21:19:42Z","updated_at":"2016-11-12T09:39:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/airbnb/react-native-maps/pulls/625","html_url":"https://github.com/airbnb/react-native-maps/pull/625","diff_url":"https://github.com/airbnb/react-native-maps/pull/625.diff","patch_url":"https://github.com/airbnb/react-native-maps/pull/625.patch"},"body":"This pull request adds support for `takeSnapshot` on Android.\n\nThe takeSnapshot function was purposefully implemented on the AirMapModule class and not as a command on AirMapManager. The reason was that with using commands it is not possible to call the callback that is provided. The callback cannot be extracted from `ReadableMap`. This made it unsuitable for this specific function. I've taking inspiration from `react-native-view-shot` and was able to implement the functionality on the AirMapModule instead.\n\nThe region argument is not used on Android and the width and height are interpreted differently. This is because the `GoogleMaps.snapshot` doesn't take the size or region as input. This creates a feature difference with the iOS version.\n\nAdditionally, I've made `takeSnapshot` promise aware. This means it now returns a promise with the resulting snapshot value (the uri) (or rejects the promise in case of an error).\n\nAndroid screenshot:\n![image](https://cloud.githubusercontent.com/assets/6184593/18932647/a78c06a4-85d1-11e6-8906-29de8d0d46eb.png)\n"},"comment":{"url":"https://api.github.com/repos/airbnb/react-native-maps/issues/comments/260112173","html_url":"https://github.com/airbnb/react-native-maps/pull/625#issuecomment-260112173","issue_url":"https://api.github.com/repos/airbnb/react-native-maps/issues/625","id":260112173,"user":{"login":"IjzerenHein","id":6184593,"avatar_url":"https://avatars.githubusercontent.com/u/6184593?v=3","gravatar_id":"","url":"https://api.github.com/users/IjzerenHein","html_url":"https://github.com/IjzerenHein","followers_url":"https://api.github.com/users/IjzerenHein/followers","following_url":"https://api.github.com/users/IjzerenHein/following{/other_user}","gists_url":"https://api.github.com/users/IjzerenHein/gists{/gist_id}","starred_url":"https://api.github.com/users/IjzerenHein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IjzerenHein/subscriptions","organizations_url":"https://api.github.com/users/IjzerenHein/orgs","repos_url":"https://api.github.com/users/IjzerenHein/repos","events_url":"https://api.github.com/users/IjzerenHein/events{/privacy}","received_events_url":"https://api.github.com/users/IjzerenHein/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T09:39:11Z","updated_at":"2016-11-12T09:39:11Z","body":"Awesome, thanks @spikebrehm "}}
{"actor":{"display_login":"IjzerenHein"}}