{"action":"closed","number":1520,"pull_request":{"url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1520","id":99611016,"html_url":"https://github.com/KeepSafe/aiohttp/pull/1520","diff_url":"https://github.com/KeepSafe/aiohttp/pull/1520.diff","patch_url":"https://github.com/KeepSafe/aiohttp/pull/1520.patch","issue_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1520","number":1520,"state":"closed","locked":false,"title":"Simplify waiter in streams.py","user":{"login":"AraHaan","id":15173749,"avatar_url":"https://avatars.githubusercontent.com/u/15173749?v=3","gravatar_id":"","url":"https://api.github.com/users/AraHaan","html_url":"https://github.com/AraHaan","followers_url":"https://api.github.com/users/AraHaan/followers","following_url":"https://api.github.com/users/AraHaan/following{/other_user}","gists_url":"https://api.github.com/users/AraHaan/gists{/gist_id}","starred_url":"https://api.github.com/users/AraHaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AraHaan/subscriptions","organizations_url":"https://api.github.com/users/AraHaan/orgs","repos_url":"https://api.github.com/users/AraHaan/repos","events_url":"https://api.github.com/users/AraHaan/events{/privacy}","received_events_url":"https://api.github.com/users/AraHaan/received_events","type":"User","site_admin":false},"body":"This should reduce some uneeded branches and lines of code that are\r\npartials because the fact that there is no case where waiter is canceled\r\nbefore the if statement in the tests. This should also simplify it a bit\r\nas well.\r\n\r\n<!-- Thank you for your contribution!\r\n\r\n     Before submit your Pull Request, make sure you picked\r\n     the right branch:\r\n\r\n     - If you propose a new feature or improvement, select \"master\"\r\n       as a target branch;\r\n     - If this is a bug fix or documentation amendment, select\r\n       the latest release branch (which looks like \"0.xx\") -->\r\n\r\n## What do these changes do?\r\n\r\n<!-- Please give a short brief about these changes. -->\r\nSimplifies the waiter and helps reduce the amount of partial lines on the coverage as well as reduces some branches on it.\r\n\r\n## Are there changes in behavior for the user?\r\n\r\n<!-- Outline any notable behaviour for the end users. -->\r\nThere should not really be any noticed changes in behavior for the user.\r\n\r\n## Related issue number\r\n\r\n<!-- Are there any issues opened that will be resolved by merging this change? -->\r\nNone.\r\n\r\n## Checklist\r\n\r\n- [x] I think the code is well written\r\n- [x] Unit tests for the changes exist\r\n","created_at":"2016-12-29T01:58:16Z","updated_at":"2016-12-29T02:41:36Z","closed_at":"2016-12-29T02:41:36Z","merged_at":null,"merge_commit_sha":"abf3bc52badd276efbd13867a00a238b6dd7e928","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1520/commits","review_comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1520/comments","review_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1520/comments","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/4733fd9617d7a2e75b25120cbbb7c53148a2a89b","head":{"label":"AraHaanOrg:streams_patch","ref":"streams_patch","sha":"4733fd9617d7a2e75b25120cbbb7c53148a2a89b","user":{"login":"AraHaanOrg","id":22422921,"avatar_url":"https://avatars.githubusercontent.com/u/22422921?v=3","gravatar_id":"","url":"https://api.github.com/users/AraHaanOrg","html_url":"https://github.com/AraHaanOrg","followers_url":"https://api.github.com/users/AraHaanOrg/followers","following_url":"https://api.github.com/users/AraHaanOrg/following{/other_user}","gists_url":"https://api.github.com/users/AraHaanOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/AraHaanOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AraHaanOrg/subscriptions","organizations_url":"https://api.github.com/users/AraHaanOrg/orgs","repos_url":"https://api.github.com/users/AraHaanOrg/repos","events_url":"https://api.github.com/users/AraHaanOrg/events{/privacy}","received_events_url":"https://api.github.com/users/AraHaanOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":77256312,"name":"aiohttp","full_name":"AraHaanOrg/aiohttp","owner":{"login":"AraHaanOrg","id":22422921,"avatar_url":"https://avatars.githubusercontent.com/u/22422921?v=3","gravatar_id":"","url":"https://api.github.com/users/AraHaanOrg","html_url":"https://github.com/AraHaanOrg","followers_url":"https://api.github.com/users/AraHaanOrg/followers","following_url":"https://api.github.com/users/AraHaanOrg/following{/other_user}","gists_url":"https://api.github.com/users/AraHaanOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/AraHaanOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AraHaanOrg/subscriptions","organizations_url":"https://api.github.com/users/AraHaanOrg/orgs","repos_url":"https://api.github.com/users/AraHaanOrg/repos","events_url":"https://api.github.com/users/AraHaanOrg/events{/privacy}","received_events_url":"https://api.github.com/users/AraHaanOrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AraHaanOrg/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":true,"url":"https://api.github.com/repos/AraHaanOrg/aiohttp","forks_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/forks","keys_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/teams","hooks_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/events","assignees_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/tags","blobs_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/languages","stargazers_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/subscription","commits_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/merges","archive_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/downloads","issues_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/AraHaanOrg/aiohttp/deployments","created_at":"2016-12-23T23:44:03Z","updated_at":"2016-12-24T07:56:27Z","pushed_at":"2016-12-29T02:31:03Z","git_url":"git://github.com/AraHaanOrg/aiohttp.git","ssh_url":"git@github.com:AraHaanOrg/aiohttp.git","clone_url":"https://github.com/AraHaanOrg/aiohttp.git","svn_url":"https://github.com/AraHaanOrg/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":8016,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KeepSafe:master","ref":"master","sha":"8469b6dea75c17732fd4de5ef3a1846cadf220cb","user":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"name":"aiohttp","full_name":"KeepSafe/aiohttp","owner":{"login":"KeepSafe","id":1377248,"avatar_url":"https://avatars.githubusercontent.com/u/1377248?v=3","gravatar_id":"","url":"https://api.github.com/users/KeepSafe","html_url":"https://github.com/KeepSafe","followers_url":"https://api.github.com/users/KeepSafe/followers","following_url":"https://api.github.com/users/KeepSafe/following{/other_user}","gists_url":"https://api.github.com/users/KeepSafe/gists{/gist_id}","starred_url":"https://api.github.com/users/KeepSafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KeepSafe/subscriptions","organizations_url":"https://api.github.com/users/KeepSafe/orgs","repos_url":"https://api.github.com/users/KeepSafe/repos","events_url":"https://api.github.com/users/KeepSafe/events{/privacy}","received_events_url":"https://api.github.com/users/KeepSafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KeepSafe/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":false,"url":"https://api.github.com/repos/KeepSafe/aiohttp","forks_url":"https://api.github.com/repos/KeepSafe/aiohttp/forks","keys_url":"https://api.github.com/repos/KeepSafe/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KeepSafe/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KeepSafe/aiohttp/teams","hooks_url":"https://api.github.com/repos/KeepSafe/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/KeepSafe/aiohttp/events","assignees_url":"https://api.github.com/repos/KeepSafe/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/KeepSafe/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/tags","blobs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/KeepSafe/aiohttp/languages","stargazers_url":"https://api.github.com/repos/KeepSafe/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/KeepSafe/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/KeepSafe/aiohttp/subscription","commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KeepSafe/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KeepSafe/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KeepSafe/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/KeepSafe/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KeepSafe/aiohttp/merges","archive_url":"https://api.github.com/repos/KeepSafe/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KeepSafe/aiohttp/downloads","issues_url":"https://api.github.com/repos/KeepSafe/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/KeepSafe/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/KeepSafe/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/KeepSafe/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KeepSafe/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/KeepSafe/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/KeepSafe/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2016-12-29T02:15:43Z","pushed_at":"2016-12-29T02:31:04Z","git_url":"git://github.com/KeepSafe/aiohttp.git","ssh_url":"git@github.com:KeepSafe/aiohttp.git","clone_url":"https://github.com/KeepSafe/aiohttp.git","svn_url":"https://github.com/KeepSafe/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":8016,"stargazers_count":2639,"watchers_count":2639,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":478,"mirror_url":null,"open_issues_count":91,"forks":478,"open_issues":91,"watchers":2639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1520"},"html":{"href":"https://github.com/KeepSafe/aiohttp/pull/1520"},"issue":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1520"},"comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/issues/1520/comments"},"review_comments":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1520/comments"},"review_comment":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/pulls/1520/commits"},"statuses":{"href":"https://api.github.com/repos/KeepSafe/aiohttp/statuses/4733fd9617d7a2e75b25120cbbb7c53148a2a89b"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":36,"deletions":32,"changed_files":1}}
{"actor":{"display_login":"AraHaan"}}