{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/loader/issues/47","repository_url":"https://api.github.com/repos/dojo/loader","labels_url":"https://api.github.com/repos/dojo/loader/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/dojo/loader/issues/47/comments","events_url":"https://api.github.com/repos/dojo/loader/issues/47/events","html_url":"https://github.com/dojo/loader/pull/47","id":136488773,"number":47,"title":"Issue 34: config object is not passed to plugin load function as per AMD spec","user":{"login":"Tomdye","id":814453,"avatar_url":"https://avatars.githubusercontent.com/u/814453?v=3","gravatar_id":"","url":"https://api.github.com/users/Tomdye","html_url":"https://github.com/Tomdye","followers_url":"https://api.github.com/users/Tomdye/followers","following_url":"https://api.github.com/users/Tomdye/following{/other_user}","gists_url":"https://api.github.com/users/Tomdye/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomdye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomdye/subscriptions","organizations_url":"https://api.github.com/users/Tomdye/orgs","repos_url":"https://api.github.com/users/Tomdye/repos","events_url":"https://api.github.com/users/Tomdye/events{/privacy}","received_events_url":"https://api.github.com/users/Tomdye/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dojo/loader/labels/awaiting-review","name":"awaiting-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-25T19:39:13Z","updated_at":"2016-02-26T14:29:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dojo/loader/pulls/47","html_url":"https://github.com/dojo/loader/pull/47","diff_url":"https://github.com/dojo/loader/pull/47.diff","patch_url":"https://github.com/dojo/loader/pull/47.patch"},"body":"Fixes: https://github.com/dojo/loader/issues/34\r\n\r\n- Saves the `config` object so it can be passed to the plugin `load` function.\r\n- Adds tests for `plugin load` and `plugin config` both functional and unit\r\n- Sets configuration to `undefined` in case where config is NOT passed as first argument to the `require` function. The ability to pass config to the `require` function outside of `require.config` is found to be out of line with AMD spec and `requireJS` so will be raising follow up PR to fix."},"comment":{"url":"https://api.github.com/repos/dojo/loader/issues/comments/189303224","html_url":"https://github.com/dojo/loader/pull/47#issuecomment-189303224","issue_url":"https://api.github.com/repos/dojo/loader/issues/47","id":189303224,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T14:29:15Z","updated_at":"2016-02-26T14:29:15Z","body":"## [Current coverage][1] is `93.59%`\n> Merging **#47** into **master** will increase coverage by **+8.08%** as of [`6d716ef`][3]\n\n\n```diff\n@@            master     #47   diff @@\n======================================\n  Files            1       1       \n  Stmts          435     437     +2\n  Branches       105     105       \n  Methods         64      64       \n======================================\n+ Hit            372     409    +37\n  Partial          3       3       \n+ Missed          60      25    -35\n```\n\n> Review entire [Coverage Diff][4] as of [`6d716ef`][3]\n\n\n[1]: https://codecov.io/github/dojo/loader?ref=6d716efb0375aea7f82c6ad510d51d1d85405c9c\n[2]: https://codecov.io/github/dojo/loader/features/suggestions?ref=6d716efb0375aea7f82c6ad510d51d1d85405c9c\n[3]: https://codecov.io/github/dojo/loader/commit/6d716efb0375aea7f82c6ad510d51d1d85405c9c\n[4]: https://codecov.io/github/dojo/loader/compare/f3379b3f7b1344d712b9d8bed3da6f17a9779e70...6d716efb0375aea7f82c6ad510d51d1d85405c9c\n\n> Powered by [Codecov](https://codecov.io). Updated on successful CI builds."}}