{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62609637","id":62609637,"diff_hunk":"@@ -89,6 +89,8 @@ git init > /dev/null 2>&1\n \n # Recreate the Godeps using the nice clean set we just downloaded\n \"${GODEP}\" save ./...","path":"hack/verify-godeps.sh","position":22,"original_position":3,"commit_id":"96676abbd69f7031ba2009305042a96cc032c88a","original_commit_id":"e5e9ac12792b77afdb02f58c33cc92e7356f5786","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"don't you want to remove line 90-91 ?","created_at":"2016-05-10T04:05:40Z","updated_at":"2016-05-10T04:05:40Z","html_url":"https://github.com/kubernetes/kubernetes/pull/22807#discussion_r62609637","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62609637"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22807#discussion_r62609637"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807","id":62434388,"html_url":"https://github.com/kubernetes/kubernetes/pull/22807","diff_url":"https://github.com/kubernetes/kubernetes/pull/22807.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/22807.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22807","number":22807,"state":"open","locked":false,"title":"Update to support latest godep","user":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"body":"godep v53 and earlier included all subdirs of includes in ./...\r\ngodep v54 and later only includes the exact packages required.\r\n\r\nSo all of the 'extra' packages which were subdirs but were dead code are removed.\r\n\r\nThat bit us because both codecgen and ginkgo are binaries which we got by chance in Godeps. When godep started tracking exactly what was needed instead of just grabbing entire subdirs we lost those binaries. To solve that problem godeps now have to be built with `godep save ginko codecgen ./...` so that that it explicitly pulls in those two packages. Because no one will ever remember that, I created a script in hack which lists those deps explicitly.\r\n\r\nThe better import tacking also means that it lists every single package included (transitively) in Godeps.json. Which I believe makes the godep license concatenator from @karlkfi explode in size.\r\n\r\nBut from an actual 'code that was built' PoV, and easy way to test is to see if a build with and without this PR have any difference. They should be identical.","created_at":"2016-03-10T18:32:04Z","updated_at":"2016-05-10T04:05:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d0091c4fe3029779d9b309ac057a14ce0661fb2","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22807/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/96676abbd69f7031ba2009305042a96cc032c88a","head":{"label":"eparis:godep-v57","ref":"godep-v57","sha":"96676abbd69f7031ba2009305042a96cc032c88a","user":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"repo":{"id":21580815,"name":"kubernetes","full_name":"eparis/kubernetes","owner":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eparis/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/eparis/kubernetes","forks_url":"https://api.github.com/repos/eparis/kubernetes/forks","keys_url":"https://api.github.com/repos/eparis/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eparis/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eparis/kubernetes/teams","hooks_url":"https://api.github.com/repos/eparis/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/eparis/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/eparis/kubernetes/events","assignees_url":"https://api.github.com/repos/eparis/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/eparis/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/eparis/kubernetes/tags","blobs_url":"https://api.github.com/repos/eparis/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eparis/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eparis/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/eparis/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eparis/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/eparis/kubernetes/languages","stargazers_url":"https://api.github.com/repos/eparis/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/eparis/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/eparis/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/eparis/kubernetes/subscription","commits_url":"https://api.github.com/repos/eparis/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/eparis/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/eparis/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/eparis/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/eparis/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/eparis/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eparis/kubernetes/merges","archive_url":"https://api.github.com/repos/eparis/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eparis/kubernetes/downloads","issues_url":"https://api.github.com/repos/eparis/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/eparis/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/eparis/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/eparis/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eparis/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/eparis/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/eparis/kubernetes/deployments","created_at":"2014-07-07T17:57:31Z","updated_at":"2016-03-07T14:23:26Z","pushed_at":"2016-05-09T17:10:01Z","git_url":"git://github.com/eparis/kubernetes.git","ssh_url":"git@github.com:eparis/kubernetes.git","clone_url":"https://github.com/eparis/kubernetes.git","svn_url":"https://github.com/eparis/kubernetes","homepage":null,"size":186809,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e973b5d27a5fb3d0bfd41f94ac99f0e6d1c99df1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-10T03:37:44Z","pushed_at":"2016-05-10T04:02:58Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":391039,"stargazers_count":14288,"watchers_count":14288,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4281,"mirror_url":null,"open_issues_count":3578,"forks":4281,"open_issues":3578,"watchers":14288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22807"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22807"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22807/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22807/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/96676abbd69f7031ba2009305042a96cc032c88a"}}}}