{"action":"created","issue":{"url":"https://api.github.com/repos/klarna/ui/issues/98","repository_url":"https://api.github.com/repos/klarna/ui","labels_url":"https://api.github.com/repos/klarna/ui/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/klarna/ui/issues/98/comments","events_url":"https://api.github.com/repos/klarna/ui/issues/98/events","html_url":"https://github.com/klarna/ui/pull/98","id":182258648,"number":98,"title":"Make all components themeable by default","user":{"login":"xaviervia","id":381614,"avatar_url":"https://avatars.githubusercontent.com/u/381614?v=3","gravatar_id":"","url":"https://api.github.com/users/xaviervia","html_url":"https://github.com/xaviervia","followers_url":"https://api.github.com/users/xaviervia/followers","following_url":"https://api.github.com/users/xaviervia/following{/other_user}","gists_url":"https://api.github.com/users/xaviervia/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviervia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviervia/subscriptions","organizations_url":"https://api.github.com/users/xaviervia/orgs","repos_url":"https://api.github.com/users/xaviervia/repos","events_url":"https://api.github.com/users/xaviervia/events{/privacy}","received_events_url":"https://api.github.com/users/xaviervia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-11T13:05:37Z","updated_at":"2016-10-11T13:57:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/klarna/ui/pulls/98","html_url":"https://github.com/klarna/ui/pull/98","diff_url":"https://github.com/klarna/ui/pull/98.diff","patch_url":"https://github.com/klarna/ui/pull/98.patch"},"body":"This is a small API change that will make all the components that support dynamic styling to be themeable by default. _Themeable_ means that, given a `<Theme>` component that set _customizations_ somewhere up in the tree, they will pick up those customizations from the React.context and use them to theme themselves.\r\n\r\nA couple of observations:\r\n\r\n- The only change visible in the Showroom will be that the Theme demo will require simple components, not the `Themeable` versions\r\n- Uncontrolled components will become themeable as well\r\n- This change is backwards compatible\r\n- But it will also mean that the versions in the `themeable` folder are deprecated and should be removed in v2."},"comment":{"url":"https://api.github.com/repos/klarna/ui/issues/comments/252924257","html_url":"https://github.com/klarna/ui/pull/98#issuecomment-252924257","issue_url":"https://api.github.com/repos/klarna/ui/issues/98","id":252924257,"user":{"login":"xaviervia","id":381614,"avatar_url":"https://avatars.githubusercontent.com/u/381614?v=3","gravatar_id":"","url":"https://api.github.com/users/xaviervia","html_url":"https://github.com/xaviervia","followers_url":"https://api.github.com/users/xaviervia/followers","following_url":"https://api.github.com/users/xaviervia/following{/other_user}","gists_url":"https://api.github.com/users/xaviervia/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviervia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviervia/subscriptions","organizations_url":"https://api.github.com/users/xaviervia/orgs","repos_url":"https://api.github.com/users/xaviervia/repos","events_url":"https://api.github.com/users/xaviervia/events{/privacy}","received_events_url":"https://api.github.com/users/xaviervia/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T13:57:20Z","updated_at":"2016-10-11T13:57:20Z","body":"As said, the visible difference is that the Theme example in the Showroom now shows that the plain components will work with it directly.\r\n\r\n<img width=\"966\" alt=\"screen shot 2016-10-11 at 15 55 01\" src=\"https://cloud.githubusercontent.com/assets/381614/19273004/2681b8c0-8fcb-11e6-813f-054aadf53476.png\">\r\n\r\nPing @Deschtex wdyt? For your app this will mean that you don't need to use the `themeable` version in consumption, but even if you keep doing, until v2 it should be OK, nothing changed."}}
{"actor":{"display_login":"xaviervia"}}