{"push_id":923178837,"size":282,"distinct_size":282,"ref":"refs/heads/master","head":"1ef6af5ac2493a93bcaee42f2af79df39b98cf6c","before":"f0cf1be7b4ee64f0f3cd65d27df6af998d6e4b26","commits":[{"sha":"c7d1786bc27f92186b41bafdd85bcd5cccdd783a","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Updated README","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/c7d1786bc27f92186b41bafdd85bcd5cccdd783a"},{"sha":"e96147381b170b701a2f82203214a3392ed88358","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Adding initial support for SMB2 (SMB 2.002) dialect. If not explicitly specified, it should all work still the same (SMB1).\nIt can be tested running the smbserver.py example with the -smb2support parameter. Looks like it's working from\nWindows clients and Samba clients (Samba 4.2.x).\nA lot of testing needed!","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/e96147381b170b701a2f82203214a3392ed88358"},{"sha":"809b2c89208d204bc6daf68500afebc665a33548","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Merge branch 'master' of https://github.com/CoreSecurity/impacket","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/809b2c89208d204bc6daf68500afebc665a33548"},{"sha":"dc1b6487edb3a35284ce50ea6a9c47bd55aad69b","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Adding SMB2 support for karmaSMB\n\n   The SMB2 support works with a caveat. If two different\n   filenames at the same share are requested, the first\n   one will work and the second one will not work if the request\n   is performed right away. This seems related to the\n   QUERY_DIRECTORY request, where we return the files available.\n   In the first try, we return the file that was asked to open.\n   In the second try, the client will NOT ask for another\n   QUERY_DIRECTORY but will use the cached one. This time the new file\n   is not there, so the client assumes it doesn't exist.\n   After a few seconds, looks like the client cache is cleared and\n   the operation works again. Further research is needed trying\n   to avoid this from happening.","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/dc1b6487edb3a35284ce50ea6a9c47bd55aad69b"},{"sha":"73fdb533dd2835c2996e4d392384bde053a459c2","author":{"email":"b0af4b4b84755b770f90c6df6c4e6313a9af3475@gmail.com","name":"byt3bl33d3r"},"message":"added option to set smb challenge in smbserver.py","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/73fdb533dd2835c2996e4d392384bde053a459c2"},{"sha":"7d532eef967666b4e11024efd7a74a12e809303a","author":{"email":"b0af4b4b84755b770f90c6df6c4e6313a9af3475@gmail.com","name":"byt3bl33d3r"},"message":"removed debug print statements","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/7d532eef967666b4e11024efd7a74a12e809303a"},{"sha":"9c7b50e34f5276332e632d5534da0a852b21e887","author":{"email":"b0af4b4b84755b770f90c6df6c4e6313a9af3475@gmail.com","name":"byt3bl33d3r"},"message":"corrected a comment","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/9c7b50e34f5276332e632d5534da0a852b21e887"},{"sha":"028dcdb90cdcd78747d47a94ecdca86546e97867","author":{"email":"b0af4b4b84755b770f90c6df6c4e6313a9af3475@gmail.com","name":"byt3bl33d3r"},"message":"have no idea what i was thinking at the time","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/028dcdb90cdcd78747d47a94ecdca86546e97867"},{"sha":"4a54672034cc9a8ae1dec124d803292b6b6b67a9","author":{"email":"b0af4b4b84755b770f90c6df6c4e6313a9af3475@gmail.com","name":"byt3bl33d3r"},"message":"modified comment","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/4a54672034cc9a8ae1dec124d803292b6b6b67a9"},{"sha":"3352733f434bff1f929f3bcc5135bdab9a769f60","author":{"email":"b0af4b4b84755b770f90c6df6c4e6313a9af3475@gmail.com","name":"byt3bl33d3r"},"message":"added missing )","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/3352733f434bff1f929f3bcc5135bdab9a769f60"},{"sha":"8b359e16252c59caec093e13cd76e906fd6f5c0f","author":{"email":"25fe1b23b2e178745c244e3f4b1bddcc1b9e4b78@users.noreply.github.com","name":"Alberto Solino"},"message":"Merge pull request #57 from byt3bl33d3r/master\n\nAdded option to set custom SMB challenge in smbserver.py","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/8b359e16252c59caec093e13cd76e906fd6f5c0f"},{"sha":"10c54429c22e0277934108b520684b24f3f60bc7","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Fix SMBSERVER error when no challenge was set in config file.\n\nhttps://github.com/CoreSecurity/impacket/pull/57 added option for setting\na custom challenge in SimpleSMBServer class. However, those modules that\nwould instantiate an SMBSERVER directly (e.g. karmaSMB) would fail if the\nchallenge option wasn't set.\nI've added a the default challenge to be 'A'*8 at the SMBSERVER class level.","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/10c54429c22e0277934108b520684b24f3f60bc7"},{"sha":"c2b47d34365d81c8d7de1e445da3999ea2e8a342","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Playing with logging, trying to get to something useful to finally have a decent logging inside impacket.\n\n1) We basically define a logger called 'impacket' at the library's __init__, set out a NullHandler for it, and assign a global variable LOG that will need to be imported from all the library modules. From now on, ALL library modules LOG through that variable. All modules should have 'from impacket import LOG'\n\n2) All the logging stuff in version.py removed\n\nWith this we have a single logger called 'impacket' for the library.\n\nNow.. what about the example scripts?\n\n1) Move the impacket/logger.py to impacket/examples/logger.py, since this is something that is used just by the example modules (yeah, shouldn't be inside the library itself, but oh well). Inside logger.py, we modify the root logger and change the format of the messages (as set by @lanjelot). The root logger is held in a global variable called SLOG (scripts log?.. another ideas welcomed).\n\n2) Example scripts should import that file in order for the library logs to be shown right (from impacket.examples.logger import SLOG). Plus if they want to log themselves, they can use SLOG.\n\nFor third-party developers that want to disable or change the logs generated by the library:\n\n1) They could, inside the scripts, logging.getLogger('impacket').disabled = True, or add handlers, or whatever.\n\nTesting needed..","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/c2b47d34365d81c8d7de1e445da3999ea2e8a342"},{"sha":"0730a3428af8bd1625a205420dbdc5e2af892bda","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"    Playing with logging, trying to get to something useful to finally have a decent logging inside impacket.\n\n    1) We basically define a logger called 'impacket' at the library's __init__, set out a NullHandler for it, and\n\n    2) All the logging stuff in version.py removed\n\n    With this we have a single logger called 'impacket' for the library.\n\n    Now.. what about the example scripts?\n\n    1) Move the impacket/logger.py to impacket/examples/logger.py, since this is something that is used just by the\n\n    2) Example scripts should import that file in order for the library logs to be shown right (from impacket.examp\n\n    For third-party developers that want to disable or change the logs generated by the library:\n\n    1) They could, inside the scripts, logging.getLogger('impacket').disabled = True, or add handlers, or whatever.\n\n    Testing needed..","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/0730a3428af8bd1625a205420dbdc5e2af892bda"},{"sha":"119e4438dd8227a138d5ecc2052646c3a81b9e4e","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Changing logging mechanisms everywhere.\nFull details coming soon","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/119e4438dd8227a138d5ecc2052646c3a81b9e4e"},{"sha":"7e99da87f92244fce5caa659bb122dfe2c4f4991","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Adding debug parameter","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/7e99da87f92244fce5caa659bb122dfe2c4f4991"},{"sha":"4c2e64ad3add7e40609834a7a8f046ca86304e56","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Second round of logging change.\nNow there should be a single logger called 'impacket' the library uses.\nBy default is has a NullHandler so nothing is printed, but messages are\nforwarded to the upstream logger.\n\nIf you are a script using the library and want to set the root logger\nwith a custom formatter, you can import impacket.examples.logger.\n\nAfter some testing I'll merge it into master","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/4c2e64ad3add7e40609834a7a8f046ca86304e56"},{"sha":"94b141881bc076303ff6b7e635a807b37851b163","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Added SMBSERVER() support for renaming files/folders through SMB2_SET_INFO.\n\nThis is what explorer uses when renaming files/folders.","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/94b141881bc076303ff6b7e635a807b37851b163"},{"sha":"53306c9c8926cc67ebeb620dd27701ee85d4a80e","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Updates to SMB2 Server\n\n1) Dummy SMB2_LOCK, SMB2_CANCEL added\n2) SMB2_FLUSH added\n3) SMB2_FILE_INTERNAL_INFO level added\n4) Getting fileID from previous compound request for all functions that apply\n5) Fixed path calculation when renaming a file outside the root tree dir\n\nLooks like it's working OK from Linux/Windows and OSX (guest login)","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/53306c9c8926cc67ebeb620dd27701ee85d4a80e"},{"sha":"816a950b2a94e66596fd1396cdf4ee9f6b6b0442","author":{"email":"b9a6b8aee0c3c075bc9001ddbae8ca32628c1f75@gmail.com","name":"asolino"},"message":"Updates to SMB2 Server\n\n1) We need to store the new filename inside the connData['OpenedFiles'] dictionary\nwhen renaming a file\n2) SMB2Lock wasn't unpacking correctly, producing an error.\n\nBTW, OSx SMB client implementation sucks.","distinct":true,"url":"https://api.github.com/repos/mubix/impacket/commits/816a950b2a94e66596fd1396cdf4ee9f6b6b0442"}]}