{"action":"created","comment":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments/68626161","id":68626161,"diff_hunk":"@@ -242,10 +242,12 @@ bool AMDatamanAppController::startup() {\n \t\t\treturn AMErrorMon::errorAndReturn(this, AMDATAMANAPPCONTROLLER_STARTUP_ERROR_HANDING_NON_FIRST_TIME_USER, \"Problem with Acquaman startup: handling non-first-time user.\");\n \t}\n \n-\n \tif(!startupRegisterDatabases())\n \t\treturn AMErrorMon::errorAndReturn(this, AMDATAMANAPPCONTROLLER_STARTUP_ERROR_REGISTERING_DATABASES, \"Problem with Acquaman startup: registering databases.\");\n \n+\tif(!startupDatabaseUpgrades())","path":"source/application/AMDatamanAppController.cpp","position":8,"original_position":8,"commit_id":"6c3901946ffe3db6686059fb5d3cde763e2b8051","original_commit_id":"6c3901946ffe3db6686059fb5d3cde763e2b8051","user":{"login":"XuetaoLiu-CLS","id":8292610,"avatar_url":"https://avatars.githubusercontent.com/u/8292610?v=3","gravatar_id":"","url":"https://api.github.com/users/XuetaoLiu-CLS","html_url":"https://github.com/XuetaoLiu-CLS","followers_url":"https://api.github.com/users/XuetaoLiu-CLS/followers","following_url":"https://api.github.com/users/XuetaoLiu-CLS/following{/other_user}","gists_url":"https://api.github.com/users/XuetaoLiu-CLS/gists{/gist_id}","starred_url":"https://api.github.com/users/XuetaoLiu-CLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuetaoLiu-CLS/subscriptions","organizations_url":"https://api.github.com/users/XuetaoLiu-CLS/orgs","repos_url":"https://api.github.com/users/XuetaoLiu-CLS/repos","events_url":"https://api.github.com/users/XuetaoLiu-CLS/events{/privacy}","received_events_url":"https://api.github.com/users/XuetaoLiu-CLS/received_events","type":"User","site_admin":false},"body":"- yes, it covers both first time and every time cases.\r\n- As you pointed below as well, the reason I put this is after `startUpRegisterDatabases()` is that I want to use method `if (!facility->storeToDb(databaseToUpgrade_))`, which can save the thumbnail at the same time.","created_at":"2016-06-27T18:07:01Z","updated_at":"2016-06-27T18:07:01Z","html_url":"https://github.com/acquaman/acquaman/pull/2408#discussion_r68626161","pull_request_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2408","_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments/68626161"},"html":{"href":"https://github.com/acquaman/acquaman/pull/2408#discussion_r68626161"},"pull_request":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2408"}}},"pull_request":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/2408","id":74269993,"html_url":"https://github.com/acquaman/acquaman/pull/2408","diff_url":"https://github.com/acquaman/acquaman/pull/2408.diff","patch_url":"https://github.com/acquaman/acquaman/pull/2408.patch","issue_url":"https://api.github.com/repos/acquaman/acquaman/issues/2408","number":2408,"state":"open","locked":false,"title":"PullRequest for Issue2345: fix the bug in AMDbObjectThumbnail table of the AMFacility data","user":{"login":"XuetaoLiu-CLS","id":8292610,"avatar_url":"https://avatars.githubusercontent.com/u/8292610?v=3","gravatar_id":"","url":"https://api.github.com/users/XuetaoLiu-CLS","html_url":"https://github.com/XuetaoLiu-CLS","followers_url":"https://api.github.com/users/XuetaoLiu-CLS/followers","following_url":"https://api.github.com/users/XuetaoLiu-CLS/following{/other_user}","gists_url":"https://api.github.com/users/XuetaoLiu-CLS/gists{/gist_id}","starred_url":"https://api.github.com/users/XuetaoLiu-CLS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XuetaoLiu-CLS/subscriptions","organizations_url":"https://api.github.com/users/XuetaoLiu-CLS/orgs","repos_url":"https://api.github.com/users/XuetaoLiu-CLS/repos","events_url":"https://api.github.com/users/XuetaoLiu-CLS/events{/privacy}","received_events_url":"https://api.github.com/users/XuetaoLiu-CLS/received_events","type":"User","site_admin":false},"body":"- add CLSDbUpgrade1.2 to fix  a bug in CLSDbUpgrade1.1, which doesn't take care of the upgrade of AMDbObjectThumbnail_table for AMFacility thumbnails\r\n- fix the bug of CLSDbUpgrade1.1 to generate the thumbnail for the new\r\nfacility is required\r\n\r\n#2345 ","created_at":"2016-06-17T16:30:09Z","updated_at":"2016-06-27T18:07:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd40c73f4632b8f90911111e2f38174fe8b45088","assignee":{"login":"helfrij","id":5216607,"avatar_url":"https://avatars.githubusercontent.com/u/5216607?v=3","gravatar_id":"","url":"https://api.github.com/users/helfrij","html_url":"https://github.com/helfrij","followers_url":"https://api.github.com/users/helfrij/followers","following_url":"https://api.github.com/users/helfrij/following{/other_user}","gists_url":"https://api.github.com/users/helfrij/gists{/gist_id}","starred_url":"https://api.github.com/users/helfrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfrij/subscriptions","organizations_url":"https://api.github.com/users/helfrij/orgs","repos_url":"https://api.github.com/users/helfrij/repos","events_url":"https://api.github.com/users/helfrij/events{/privacy}","received_events_url":"https://api.github.com/users/helfrij/received_events","type":"User","site_admin":false},"assignees":[{"login":"helfrij","id":5216607,"avatar_url":"https://avatars.githubusercontent.com/u/5216607?v=3","gravatar_id":"","url":"https://api.github.com/users/helfrij","html_url":"https://github.com/helfrij","followers_url":"https://api.github.com/users/helfrij/followers","following_url":"https://api.github.com/users/helfrij/following{/other_user}","gists_url":"https://api.github.com/users/helfrij/gists{/gist_id}","starred_url":"https://api.github.com/users/helfrij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helfrij/subscriptions","organizations_url":"https://api.github.com/users/helfrij/orgs","repos_url":"https://api.github.com/users/helfrij/repos","events_url":"https://api.github.com/users/helfrij/events{/privacy}","received_events_url":"https://api.github.com/users/helfrij/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2408/commits","review_comments_url":"https://api.github.com/repos/acquaman/acquaman/pulls/2408/comments","review_comment_url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquaman/acquaman/issues/2408/comments","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/6c3901946ffe3db6686059fb5d3cde763e2b8051","head":{"label":"acquaman:Issue2345","ref":"Issue2345","sha":"6c3901946ffe3db6686059fb5d3cde763e2b8051","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","deployments_url":"https://api.github.com/repos/acquaman/acquaman/deployments","created_at":"2011-02-06T02:19:01Z","updated_at":"2016-05-02T21:52:12Z","pushed_at":"2016-06-27T17:58:41Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":145385,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":182,"forks":2,"open_issues":182,"watchers":10,"default_branch":"master"}},"base":{"label":"acquaman:master","ref":"master","sha":"2d08b82e1bb803cb6586164485f8b528f37ce619","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","deployments_url":"https://api.github.com/repos/acquaman/acquaman/deployments","created_at":"2011-02-06T02:19:01Z","updated_at":"2016-05-02T21:52:12Z","pushed_at":"2016-06-27T17:58:41Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":145385,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":182,"forks":2,"open_issues":182,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2408"},"html":{"href":"https://github.com/acquaman/acquaman/pull/2408"},"issue":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/2408"},"comments":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/2408/comments"},"review_comments":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2408/comments"},"review_comment":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/2408/commits"},"statuses":{"href":"https://api.github.com/repos/acquaman/acquaman/statuses/6c3901946ffe3db6686059fb5d3cde763e2b8051"}}}}
{"actor":{"display_login":"XuetaoLiu-CLS"}}