{"action":"created","issue":{"url":"https://api.github.com/repos/quilljs/quill/issues/769","repository_url":"https://api.github.com/repos/quilljs/quill","labels_url":"https://api.github.com/repos/quilljs/quill/issues/769/labels{/name}","comments_url":"https://api.github.com/repos/quilljs/quill/issues/769/comments","events_url":"https://api.github.com/repos/quilljs/quill/issues/769/events","html_url":"https://github.com/quilljs/quill/issues/769","id":162030511,"number":769,"title":"Selector string when updating a select input is incorrect","user":{"login":"clemmy","id":3696934,"avatar_url":"https://avatars.githubusercontent.com/u/3696934?v=3","gravatar_id":"","url":"https://api.github.com/users/clemmy","html_url":"https://github.com/clemmy","followers_url":"https://api.github.com/users/clemmy/followers","following_url":"https://api.github.com/users/clemmy/following{/other_user}","gists_url":"https://api.github.com/users/clemmy/gists{/gist_id}","starred_url":"https://api.github.com/users/clemmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemmy/subscriptions","organizations_url":"https://api.github.com/users/clemmy/orgs","repos_url":"https://api.github.com/users/clemmy/repos","events_url":"https://api.github.com/users/clemmy/events{/privacy}","received_events_url":"https://api.github.com/users/clemmy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-23T21:43:57Z","updated_at":"2016-07-08T18:57:17Z","closed_at":null,"body":"The problem is that when using the font-family format\r\n```\r\nvar FontFamilyStyle = new Parchment.Attributor.Style('font', 'font-family', { scope: Parchment.Scope.INLINE });\r\nquill.register(FontFamilyStyle, true);\r\n```\r\nThen if an option on a select on the toolbar has a value of, say, `'Arial Black, Arial, Helvetica Neue, Helvetica, sans-serif'`, we would run into an error in the update function.\r\n\r\n```\r\nUncaught SyntaxError: Failed to execute 'querySelector' on 'Element': 'option[value=\"\"Arial Black\", Arial, \"Helvetica Neue\", Helvetica, sans-serif\"]' is not a valid selector.\r\n```\r\nNotice how there are two double quotes in a row.\r\n\r\n**Platforms**: [Chrome 48, Firefox 46 on Mac 10.11]\r\n\r\n**Version**: [1.0.6.Beta]\r\n"},"comment":{"url":"https://api.github.com/repos/quilljs/quill/issues/comments/231444143","html_url":"https://github.com/quilljs/quill/issues/769#issuecomment-231444143","issue_url":"https://api.github.com/repos/quilljs/quill/issues/769","id":231444143,"user":{"login":"jhchen","id":192974,"avatar_url":"https://avatars.githubusercontent.com/u/192974?v=3","gravatar_id":"","url":"https://api.github.com/users/jhchen","html_url":"https://github.com/jhchen","followers_url":"https://api.github.com/users/jhchen/followers","following_url":"https://api.github.com/users/jhchen/following{/other_user}","gists_url":"https://api.github.com/users/jhchen/gists{/gist_id}","starred_url":"https://api.github.com/users/jhchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhchen/subscriptions","organizations_url":"https://api.github.com/users/jhchen/orgs","repos_url":"https://api.github.com/users/jhchen/repos","events_url":"https://api.github.com/users/jhchen/events{/privacy}","received_events_url":"https://api.github.com/users/jhchen/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T18:57:17Z","updated_at":"2016-07-08T18:57:17Z","body":"It seems brittle to just switch to single quotes. Do all browsers add double quotes? Do some add single or leave them unquoted? If multiple fonts are specified like \"Arial Black\", Arial, \"Helvetica Neue\", Helvetica, sans-serif, is the spacing between fonts and commas respected or potentially normalized?"}}
{"actor":{"display_login":"jhchen"}}