{"action":"created","issue":{"url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/issues/529","labels_url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/issues/529/labels{/name}","comments_url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/issues/529/comments","events_url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/issues/529/events","html_url":"https://github.com/SVProgressHUD/SVProgressHUD/pull/529","id":122646240,"number":529,"title":"dismiss duration 0.15 maybe lead to a bug","user":{"login":"maquannene","id":8757564,"avatar_url":"https://avatars.githubusercontent.com/u/8757564?v=3","gravatar_id":"","url":"https://api.github.com/users/maquannene","html_url":"https://github.com/maquannene","followers_url":"https://api.github.com/users/maquannene/followers","following_url":"https://api.github.com/users/maquannene/following{/other_user}","gists_url":"https://api.github.com/users/maquannene/gists{/gist_id}","starred_url":"https://api.github.com/users/maquannene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maquannene/subscriptions","organizations_url":"https://api.github.com/users/maquannene/orgs","repos_url":"https://api.github.com/users/maquannene/repos","events_url":"https://api.github.com/users/maquannene/events{/privacy}","received_events_url":"https://api.github.com/users/maquannene/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-17T02:14:35Z","updated_at":"2016-01-18T12:45:36Z","closed_at":"2016-01-17T19:45:00Z","pull_request":{"url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/pulls/529","html_url":"https://github.com/SVProgressHUD/SVProgressHUD/pull/529","diff_url":"https://github.com/SVProgressHUD/SVProgressHUD/pull/529.diff","patch_url":"https://github.com/SVProgressHUD/SVProgressHUD/pull/529.patch"},"body":"1. [SVProgress show…] // self.overlayView.superview is window1\r\n2. [SVProgress dismiss] // it dismiss progress duration 0.15s to\r\ncompletion, completion called by async.\r\n3. new a window2 immediately。\r\n4. [SVProgress show] // it is a bug, it is show in window1 rather than\r\nwindow2. but we often like it show in window.\r\n\r\n1.I change dimiss method interface \r\n `- (void)dismissWithDelay:(NSTimeInterval)delay`\r\n to\r\n `- (void)dismissWithDuration:(NSTimeInterval)duration delay:(NSTimeInterval)delay`,\r\n and add a class method\r\n `+ (void)dismissWithDuration:(NSTimeInterval)duration delay:(NSTimeInterval)delay`\r\n2. I change dimiss method implemention\r\nif duration == 0，sync call `animationBlock` and `completionBlock`,\r\n if use `animateWithDuration:0\r\n                          delay:delay\r\n                        options:…`\r\nthe completion will call async。it maybe lead to a bug"},"comment":{"url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/issues/comments/172518762","html_url":"https://github.com/SVProgressHUD/SVProgressHUD/pull/529#issuecomment-172518762","issue_url":"https://api.github.com/repos/SVProgressHUD/SVProgressHUD/issues/529","id":172518762,"user":{"login":"honkmaster","id":1380397,"avatar_url":"https://avatars.githubusercontent.com/u/1380397?v=3","gravatar_id":"","url":"https://api.github.com/users/honkmaster","html_url":"https://github.com/honkmaster","followers_url":"https://api.github.com/users/honkmaster/followers","following_url":"https://api.github.com/users/honkmaster/following{/other_user}","gists_url":"https://api.github.com/users/honkmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/honkmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honkmaster/subscriptions","organizations_url":"https://api.github.com/users/honkmaster/orgs","repos_url":"https://api.github.com/users/honkmaster/repos","events_url":"https://api.github.com/users/honkmaster/events{/privacy}","received_events_url":"https://api.github.com/users/honkmaster/received_events","type":"User","site_admin":false},"created_at":"2016-01-18T12:45:36Z","updated_at":"2016-01-18T12:45:36Z","body":"If you do me a favour. Can you update this PR to the  recent changes, will merge immediatly."}}