{"action":"created","issue":{"url":"https://api.github.com/repos/ishkawa/APIKit/issues/194","repository_url":"https://api.github.com/repos/ishkawa/APIKit","labels_url":"https://api.github.com/repos/ishkawa/APIKit/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/ishkawa/APIKit/issues/194/comments","events_url":"https://api.github.com/repos/ishkawa/APIKit/issues/194/events","html_url":"https://github.com/ishkawa/APIKit/pull/194","id":169927954,"number":194,"title":"[WIP] Initial Swift 3 support","user":{"login":"ikesyo","id":909674,"avatar_url":"https://avatars.githubusercontent.com/u/909674?v=3","gravatar_id":"","url":"https://api.github.com/users/ikesyo","html_url":"https://github.com/ikesyo","followers_url":"https://api.github.com/users/ikesyo/followers","following_url":"https://api.github.com/users/ikesyo/following{/other_user}","gists_url":"https://api.github.com/users/ikesyo/gists{/gist_id}","starred_url":"https://api.github.com/users/ikesyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikesyo/subscriptions","organizations_url":"https://api.github.com/users/ikesyo/orgs","repos_url":"https://api.github.com/users/ikesyo/repos","events_url":"https://api.github.com/users/ikesyo/events{/privacy}","received_events_url":"https://api.github.com/users/ikesyo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-08T13:49:27Z","updated_at":"2016-09-15T17:14:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ishkawa/APIKit/pulls/194","html_url":"https://github.com/ishkawa/APIKit/pull/194","diff_url":"https://github.com/ishkawa/APIKit/pull/194.diff","patch_url":"https://github.com/ishkawa/APIKit/pull/194.patch"},"body":"~~Depends on #193.~~ ✅ \r\n\r\nWe should audit the APIs to match with Swift 3 API Design Guidelines."},"comment":{"url":"https://api.github.com/repos/ishkawa/APIKit/issues/comments/247391627","html_url":"https://github.com/ishkawa/APIKit/pull/194#issuecomment-247391627","issue_url":"https://api.github.com/repos/ishkawa/APIKit/issues/194","id":247391627,"user":{"login":"ishkawa","id":966856,"avatar_url":"https://avatars.githubusercontent.com/u/966856?v=3","gravatar_id":"","url":"https://api.github.com/users/ishkawa","html_url":"https://github.com/ishkawa","followers_url":"https://api.github.com/users/ishkawa/followers","following_url":"https://api.github.com/users/ishkawa/following{/other_user}","gists_url":"https://api.github.com/users/ishkawa/gists{/gist_id}","starred_url":"https://api.github.com/users/ishkawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishkawa/subscriptions","organizations_url":"https://api.github.com/users/ishkawa/orgs","repos_url":"https://api.github.com/users/ishkawa/repos","events_url":"https://api.github.com/users/ishkawa/events{/privacy}","received_events_url":"https://api.github.com/users/ishkawa/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T17:14:30Z","updated_at":"2016-09-15T17:14:30Z","body":"@ikesyo Thank you for the great work 👍 👍 👍 \r\n\r\nI have some suggestions that would improve smoothness with Swift 3 APIs.\r\n\r\n### Omit `Type` suffix of some protocols\r\n\r\nAccording to the [API Design Guidelines](https://swift.org/documentation/api-design-guidelines/), \"Protocols that describe what something is should read as nouns (e.g. Collection).\" `RequestType`, `BodyParametersType`, `DataParserType` and `SessionAdapterType` seem to satisfy this condition.\r\n\r\n### Rename `sendRequest(_:handler:)` to `send(_:handler:)`\r\n\r\nIMO, the word \"request\" can be omitted because it is implied when we send something from Session.\r\n\r\n### Rename `cancelRequest(_:passingTest:)` to `cancelRequests(withType:passingTest:)`\r\n\r\nUnlike the sending method, canceling method treats multiple requests. I think we should imply we may cancel multiple requests, so the word \"requests\" should be exposed in method name. In addition, `withType` label is necessary because the type of the first parameter is not explicit in this context."}}
{"actor":{"display_login":"ishkawa"}}