{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/75781156","id":75781156,"diff_hunk":"@@ -0,0 +1,17 @@\n+# reddit-mobile Dockerfile for deploying on staging\n+\n+FROM reddit/reddit-nodejs:latest\n+\n+# TODO: Do these make sense for staging?\n+ENV MINIFY_ASSETS \"false\"","path":"Dockerfile.staging","position":null,"original_position":6,"commit_id":"00b7cfcd61aba99eddd760fd4e34faa1e3451703","original_commit_id":"8a0a3829bfb598c5b38a12e5129e7cd6fd9c73a7","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"body":"`MINIFY_ASSETS` is a legacy option from 1X, if this is running `npm run build` minification will happen anyway","created_at":"2016-08-22T23:53:46Z","updated_at":"2016-08-22T23:53:46Z","html_url":"https://github.com/reddit/reddit-mobile/pull/693#discussion_r75781156","pull_request_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/75781156"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/693#discussion_r75781156"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693","id":82281458,"html_url":"https://github.com/reddit/reddit-mobile/pull/693","diff_url":"https://github.com/reddit/reddit-mobile/pull/693.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/693.patch","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/693","number":693,"state":"open","locked":false,"title":"Add Docker image building via Drone.","user":{"login":"gtaylor","id":75556,"avatar_url":"https://avatars.githubusercontent.com/u/75556?v=3","gravatar_id":"","url":"https://api.github.com/users/gtaylor","html_url":"https://github.com/gtaylor","followers_url":"https://api.github.com/users/gtaylor/followers","following_url":"https://api.github.com/users/gtaylor/following{/other_user}","gists_url":"https://api.github.com/users/gtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/gtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtaylor/subscriptions","organizations_url":"https://api.github.com/users/gtaylor/orgs","repos_url":"https://api.github.com/users/gtaylor/repos","events_url":"https://api.github.com/users/gtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/gtaylor/received_events","type":"User","site_admin":false},"body":"This pull request has a `.drone.yml` for automatically building Docker images, and a `Dockerfile.staging` to determine the nature of the Docker image that gets built. These will be used with the upcoming Kubernetes-based staging environment.\r\n\r\nHere's the run-down of a typical build:\r\n\r\n* Developer pushes to a branch on the canonical reddit/reddit-mobile repo.\r\n* Github sends a webhook request to Drone.\r\n* Drone clones the source, restores `node_modules` from a local cache, then runs through a full build/lint/test cycle.\r\n* If the build passes, a Dockerfile is built. We more or less `cp` the stuff that we tested in the previous step, which becomes our staging image.\r\n* If all goes well, we push the resulting image to Docker Hub under [reddit/reddit-mobile](https://hub.docker.com/r/reddit/reddit-mobile/tags/). The tag will be the branch name.\r\n\r\n:eyeglasses: @nramadas @phil303 @schwers \r\n\r\nOf particular emphasis for review are the env vars in `Dockerfile.staging`. I'm not sure what we want to default to. Also, some of these appear to be build-time vars, while others seem to be runtime vars. We'll want to move the former to `.drone.yml` and the latter to the Kubernetes ConfigMaps. I'd appreciate guidance on where the stuff currently in `Dockerfile.staging` should end up.","created_at":"2016-08-22T23:36:58Z","updated_at":"2016-08-22T23:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed870a359ec84493d3c7e37035563fc19071031f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/693/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/00b7cfcd61aba99eddd760fd4e34faa1e3451703","head":{"label":"reddit:2X-drone-images","ref":"2X-drone-images","sha":"00b7cfcd61aba99eddd760fd4e34faa1e3451703","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":"","fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/reddit-mobile/deployments","created_at":"2014-08-18T21:42:05Z","updated_at":"2016-08-22T20:10:36Z","pushed_at":"2016-08-22T23:48:09Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":10291,"stargazers_count":835,"watchers_count":835,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":20,"forks":132,"open_issues":20,"watchers":835,"default_branch":"master"}},"base":{"label":"reddit:2X","ref":"2X","sha":"fdc1c6ff1bc629abb64227d829fe01f8096d48f2","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":"","fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/reddit-mobile/deployments","created_at":"2014-08-18T21:42:05Z","updated_at":"2016-08-22T20:10:36Z","pushed_at":"2016-08-22T23:48:09Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":10291,"stargazers_count":835,"watchers_count":835,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":20,"forks":132,"open_issues":20,"watchers":835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/693"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/693"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-mobile/statuses/00b7cfcd61aba99eddd760fd4e34faa1e3451703"}}}}
{"actor":{"display_login":"schwers"}}