{"push_id":1027652603,"size":25,"distinct_size":1,"ref":"refs/heads/develop","head":"bb8eb94db9d10840f504373d3102f36e3d99dbd7","before":"62a6dc124a7e922c3443f5e516f753c126ee6afb","commits":[{"sha":"d1df85e71595a95dc3ed06b2a1f943358bdf7eea","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part I\n\nReturn an HTTP 303 for PUT/POST request on a ReST API is a bad practice.\n\nAll the Response objects returned by all the ReST end points have been\nupdated according with the following rules:\n\n1) For Requisitions Only:\n   PUT/POST will always return an HTTP 202 with a Location header,\n   instead of 303.\n   DELETE will always return a plain HTTP 202\n   The reason for this is because, all the operations related with\n   requisitions are non-blocking.\n\n2) For all the POST requests that are only creating resources, an HTTP\n   201 is returned. Otherwise, an HTTP 200 is returned.\n\n3) For all the PUT/DELETE requests an HTTP 200 is returned. It doesn't\n   make sense to return a 303 considering that the resource information\n   is already on the URL.\n\n4) All the existing JUnit tests have been updated.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/d1df85e71595a95dc3ed06b2a1f943358bdf7eea"},{"sha":"10c434e4d5e1b1e0e2972f66c593ad4081b249ef","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part II\n\nFor PUT/DELETE (and POST where 202 doesn't apply), we decided to return\na 204 (No Content), because there is no data returned to the client on\nthose cases.\n\nAlso, the GET requests have been improved to return NOT_FOUND (when the\nfinal resource doesn't exist), or BAD_REQUEST (when an intermediate\nresource doesn't exist, like the node for a given IP).\n\nAll the JUnit tests have been updated, and they are passing.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/10c434e4d5e1b1e0e2972f66c593ad4081b249ef"},{"sha":"6d72c14692c1bce55c62f13c77cdfe9d049838a2","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Removing the TODO. I verified that the call in question is necessary.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/6d72c14692c1bce55c62f13c77cdfe9d049838a2"},{"sha":"aab7c3d2c795e39665f91670dfc9e9816de1fd1c","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part III\n\nFixing failing tests.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/aab7c3d2c795e39665f91670dfc9e9816de1fd1c"},{"sha":"f424297b188b5ddd368a901c9bc94f4d262d7d1d","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part IV\n\nFixing missing behavior non ForeignSourceRestService.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/f424297b188b5ddd368a901c9bc94f4d262d7d1d"},{"sha":"a12aa1fa8b8712b145ae25276b61b1851ad147d9","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Merge remote-tracking branch 'origin/foundation-2016' into jira/NMS-8194","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/a12aa1fa8b8712b145ae25276b61b1851ad147d9"},{"sha":"a51db268f3ca64211e3a852c5431e9b4a38ab4f4","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fixing CasperJS tests to be consistent with the new HTTP responses for the Requisitions ReST end-point.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/a51db268f3ca64211e3a852c5431e9b4a38ab4f4"},{"sha":"0aa95208efd20ed486a9438e6180b7f8b6594cea","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Be sure that a non-related test won't fail again.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/0aa95208efd20ed486a9438e6180b7f8b6594cea"},{"sha":"f7315a8c1105d000ec9079ae33b6380a508222c2","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Merge remote-tracking branch 'origin/foundation-2016' into jira/NMS-8194","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/f7315a8c1105d000ec9079ae33b6380a508222c2"},{"sha":"164f82409b25aac973dc2cacfb5142c7d14417c3","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fixing requisitions/add-node.js.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/164f82409b25aac973dc2cacfb5142c7d14417c3"},{"sha":"4751b37df4d0117325d81b5da7c04f065330d26c","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Merge remote-tracking branch 'origin/foundation-2016' into jira/NMS-8194","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/4751b37df4d0117325d81b5da7c04f065330d26c"},{"sha":"147cbe3d4ce38c59c8472695f16ed0fa7bebfd66","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part IV\n\nMaking final improvements to all the end points.\nAll JUnit tests are passing locally.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/147cbe3d4ce38c59c8472695f16ed0fa7bebfd66"},{"sha":"945971b119f33d4b473c78e8a70e72014d3c722a","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fixing createEvent method on CasperJS's helper class.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/945971b119f33d4b473c78e8a70e72014d3c722a"},{"sha":"2a8b80fe03beb9097bd3f8bcceb2990a46c5b24b","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Merge remote-tracking branch 'origin/foundation-2016' into jira/NMS-8194","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/2a8b80fe03beb9097bd3f8bcceb2990a46c5b24b"},{"sha":"5ff275ec6633aa7a372449bc8f5090edab96233f","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part V\n\nMaking all PUT/POST/DELETE requests against /rest/foreignSources to\nreturn ACCEPTED (202) instead of NO_CONTENT, because it seems like there\nis some background work after a request is executed against the selected\nForeignSourceRepository implementation.\n\nAlso, because of this, I introduced a small delay on the JUnit test that\nis failing in Bamboo to ensure that all the background work is done\nprior validating the content against the ReST API.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/5ff275ec6633aa7a372449bc8f5090edab96233f"},{"sha":"560861d1e6ffe782ee38f4da42d7aa75699b960c","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part VI\n\nOn Bamboo machines, the state of the temporary WebUI used on\nForeignSourceRestServiceIT shows more than one foreign source\ndefinition. For this reason, before creating the testing definition,\nI added some code to delete all the existing definitions, to ensure\na clean state. This should fix the failing test.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/560861d1e6ffe782ee38f4da42d7aa75699b960c"},{"sha":"5f4bcc13dc51a79c4b30da3efcb114a033fe6823","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part VII\n\nAdding documentation for the rules about the HTTP return codes used on\nthe ReST API.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/5f4bcc13dc51a79c4b30da3efcb114a033fe6823"},{"sha":"d5786b7831a4302e9af21159f30c0078b91393b1","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part VIII\n\nFixing NCS ReST end-point.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/d5786b7831a4302e9af21159f30c0078b91393b1"},{"sha":"d4f7859ffa406482a04a1a9e101b473bd22c20b9","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Fix for Bug NMS-8194 - Part IX\n\nNormalizing the \"Event Source\" for all the events generated through the\nReST API.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/d4f7859ffa406482a04a1a9e101b473bd22c20b9"},{"sha":"9722e2e5757d2179a4e5d3194cbd7860b40bd3fa","author":{"email":"5a25ac1897fdccb1d7aaa4b6fa8c9282df7ee7ca@opennms.org","name":"Alejandro Galue"},"message":"Be more verbose when creating the sample foreign source definition to discard potential Bamboo issues.","distinct":false,"url":"https://api.github.com/repos/OpenNMS/opennms/commits/9722e2e5757d2179a4e5d3194cbd7860b40bd3fa"}]}