{"action":"created","comment":{"url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments/82849570","pull_request_review_id":3727775,"id":82849570,"diff_hunk":"@@ -54,12 +54,16 @@\n \n \n #ifdef PICO_SUPPORT_TCP\n-#define tcp_dbg_nagle(...) do {} while(0)\n-#define tcp_dbg_options(...) do {} while(0)\n-\n \n-#define tcp_dbg(...) do {} while(0)\n-/* #define tcp_dbg dbg */\n+#ifdef DEBUG_TCP\n+#define tcp_dbg_nagle        dbg\n+#define tcp_dbg_options      dbg\n+#define tcp_dbg              dbg","path":"modules/pico_tcp.c","position":13,"original_position":13,"commit_id":"efd03eb3bdf0df1eba9ac15384292269e621d5ec","original_commit_id":"efd03eb3bdf0df1eba9ac15384292269e621d5ec","user":{"login":"phalox","id":3983738,"avatar_url":"https://avatars.githubusercontent.com/u/3983738?v=3","gravatar_id":"","url":"https://api.github.com/users/phalox","html_url":"https://github.com/phalox","followers_url":"https://api.github.com/users/phalox/followers","following_url":"https://api.github.com/users/phalox/following{/other_user}","gists_url":"https://api.github.com/users/phalox/gists{/gist_id}","starred_url":"https://api.github.com/users/phalox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalox/subscriptions","organizations_url":"https://api.github.com/users/phalox/orgs","repos_url":"https://api.github.com/users/phalox/repos","events_url":"https://api.github.com/users/phalox/events{/privacy}","received_events_url":"https://api.github.com/users/phalox/received_events","type":"User","site_admin":false},"body":"or something like\r\n\r\nDEBUG_TCP_ALL\r\nDEBUG_TCP_NAGLE\r\nDEBUG_TCP_OPTIOSN\r\nDEBUG_TCP_GENERAL\r\n ?","created_at":"2016-10-11T17:47:22Z","updated_at":"2016-10-11T17:47:23Z","html_url":"https://github.com/tass-belgium/picotcp/pull/417#discussion_r82849570","pull_request_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417","_links":{"self":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments/82849570"},"html":{"href":"https://github.com/tass-belgium/picotcp/pull/417#discussion_r82849570"},"pull_request":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417"}}},"pull_request":{"url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417","id":87192225,"html_url":"https://github.com/tass-belgium/picotcp/pull/417","diff_url":"https://github.com/tass-belgium/picotcp/pull/417.diff","patch_url":"https://github.com/tass-belgium/picotcp/pull/417.patch","issue_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/417","number":417,"state":"open","locked":false,"title":"Issue 412","user":{"login":"laurensmiers","id":8750023,"avatar_url":"https://avatars.githubusercontent.com/u/8750023?v=3","gravatar_id":"","url":"https://api.github.com/users/laurensmiers","html_url":"https://github.com/laurensmiers","followers_url":"https://api.github.com/users/laurensmiers/followers","following_url":"https://api.github.com/users/laurensmiers/following{/other_user}","gists_url":"https://api.github.com/users/laurensmiers/gists{/gist_id}","starred_url":"https://api.github.com/users/laurensmiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurensmiers/subscriptions","organizations_url":"https://api.github.com/users/laurensmiers/orgs","repos_url":"https://api.github.com/users/laurensmiers/repos","events_url":"https://api.github.com/users/laurensmiers/events{/privacy}","received_events_url":"https://api.github.com/users/laurensmiers/received_events","type":"User","site_admin":false},"body":"Separate compile flags for enabling debug prints of specific modules / all modules.\r\n\r\nThis increases the size of the Makefile (which we are trying to avoid if I understand correctly), but I think the damage is minimized by putting it in a separate file.\r\nOne thing I am not sure about is when we have debug prints of different modules in the same file. For example, in pico_ipv6.c, we have ipv6_dbg and ipv6_mcast_dbg. ipv6_mcast_dbg is now only enabled when we enabled mcast and debug_mcast (but it is actually the same code as in pico_mcast.c). I was thinking of putting the debug print definitions in the header files of the modules to reduce this duplication, but I don't want to pollute them with this.\r\n\r\nPlease review, suggestions/comments/remarks are welcome.","created_at":"2016-09-28T20:13:11Z","updated_at":"2016-10-11T17:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d1f0a7ad5936b73a9813dc76ec1a4c5798c4493","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417/commits","review_comments_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417/comments","review_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/417/comments","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/efd03eb3bdf0df1eba9ac15384292269e621d5ec","head":{"label":"tass-belgium:issue_412","ref":"issue_412","sha":"efd03eb3bdf0df1eba9ac15384292269e621d5ec","user":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"repo":{"id":8309253,"name":"picotcp","full_name":"tass-belgium/picotcp","owner":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tass-belgium/picotcp","description":"PicoTCP is a free TCP/IP stack implementation","fork":false,"url":"https://api.github.com/repos/tass-belgium/picotcp","forks_url":"https://api.github.com/repos/tass-belgium/picotcp/forks","keys_url":"https://api.github.com/repos/tass-belgium/picotcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tass-belgium/picotcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tass-belgium/picotcp/teams","hooks_url":"https://api.github.com/repos/tass-belgium/picotcp/hooks","issue_events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/events{/number}","events_url":"https://api.github.com/repos/tass-belgium/picotcp/events","assignees_url":"https://api.github.com/repos/tass-belgium/picotcp/assignees{/user}","branches_url":"https://api.github.com/repos/tass-belgium/picotcp/branches{/branch}","tags_url":"https://api.github.com/repos/tass-belgium/picotcp/tags","blobs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tass-belgium/picotcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tass-belgium/picotcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/{sha}","languages_url":"https://api.github.com/repos/tass-belgium/picotcp/languages","stargazers_url":"https://api.github.com/repos/tass-belgium/picotcp/stargazers","contributors_url":"https://api.github.com/repos/tass-belgium/picotcp/contributors","subscribers_url":"https://api.github.com/repos/tass-belgium/picotcp/subscribers","subscription_url":"https://api.github.com/repos/tass-belgium/picotcp/subscription","commits_url":"https://api.github.com/repos/tass-belgium/picotcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tass-belgium/picotcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tass-belgium/picotcp/contents/{+path}","compare_url":"https://api.github.com/repos/tass-belgium/picotcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tass-belgium/picotcp/merges","archive_url":"https://api.github.com/repos/tass-belgium/picotcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tass-belgium/picotcp/downloads","issues_url":"https://api.github.com/repos/tass-belgium/picotcp/issues{/number}","pulls_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls{/number}","milestones_url":"https://api.github.com/repos/tass-belgium/picotcp/milestones{/number}","notifications_url":"https://api.github.com/repos/tass-belgium/picotcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/labels{/name}","releases_url":"https://api.github.com/repos/tass-belgium/picotcp/releases{/id}","deployments_url":"https://api.github.com/repos/tass-belgium/picotcp/deployments","created_at":"2013-02-20T08:43:50Z","updated_at":"2016-10-04T21:45:05Z","pushed_at":"2016-10-09T12:28:28Z","git_url":"git://github.com/tass-belgium/picotcp.git","ssh_url":"git@github.com:tass-belgium/picotcp.git","clone_url":"https://github.com/tass-belgium/picotcp.git","svn_url":"https://github.com/tass-belgium/picotcp","homepage":null,"size":13193,"stargazers_count":270,"watchers_count":270,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":96,"forks":61,"open_issues":96,"watchers":270,"default_branch":"master"}},"base":{"label":"tass-belgium:development","ref":"development","sha":"ac70e9cb72ead788f9cf09d1a9fe5779c54e7916","user":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"repo":{"id":8309253,"name":"picotcp","full_name":"tass-belgium/picotcp","owner":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tass-belgium/picotcp","description":"PicoTCP is a free TCP/IP stack implementation","fork":false,"url":"https://api.github.com/repos/tass-belgium/picotcp","forks_url":"https://api.github.com/repos/tass-belgium/picotcp/forks","keys_url":"https://api.github.com/repos/tass-belgium/picotcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tass-belgium/picotcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tass-belgium/picotcp/teams","hooks_url":"https://api.github.com/repos/tass-belgium/picotcp/hooks","issue_events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/events{/number}","events_url":"https://api.github.com/repos/tass-belgium/picotcp/events","assignees_url":"https://api.github.com/repos/tass-belgium/picotcp/assignees{/user}","branches_url":"https://api.github.com/repos/tass-belgium/picotcp/branches{/branch}","tags_url":"https://api.github.com/repos/tass-belgium/picotcp/tags","blobs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tass-belgium/picotcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tass-belgium/picotcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/{sha}","languages_url":"https://api.github.com/repos/tass-belgium/picotcp/languages","stargazers_url":"https://api.github.com/repos/tass-belgium/picotcp/stargazers","contributors_url":"https://api.github.com/repos/tass-belgium/picotcp/contributors","subscribers_url":"https://api.github.com/repos/tass-belgium/picotcp/subscribers","subscription_url":"https://api.github.com/repos/tass-belgium/picotcp/subscription","commits_url":"https://api.github.com/repos/tass-belgium/picotcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tass-belgium/picotcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tass-belgium/picotcp/contents/{+path}","compare_url":"https://api.github.com/repos/tass-belgium/picotcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tass-belgium/picotcp/merges","archive_url":"https://api.github.com/repos/tass-belgium/picotcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tass-belgium/picotcp/downloads","issues_url":"https://api.github.com/repos/tass-belgium/picotcp/issues{/number}","pulls_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls{/number}","milestones_url":"https://api.github.com/repos/tass-belgium/picotcp/milestones{/number}","notifications_url":"https://api.github.com/repos/tass-belgium/picotcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/labels{/name}","releases_url":"https://api.github.com/repos/tass-belgium/picotcp/releases{/id}","deployments_url":"https://api.github.com/repos/tass-belgium/picotcp/deployments","created_at":"2013-02-20T08:43:50Z","updated_at":"2016-10-04T21:45:05Z","pushed_at":"2016-10-09T12:28:28Z","git_url":"git://github.com/tass-belgium/picotcp.git","ssh_url":"git@github.com:tass-belgium/picotcp.git","clone_url":"https://github.com/tass-belgium/picotcp.git","svn_url":"https://github.com/tass-belgium/picotcp","homepage":null,"size":13193,"stargazers_count":270,"watchers_count":270,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":96,"forks":61,"open_issues":96,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417"},"html":{"href":"https://github.com/tass-belgium/picotcp/pull/417"},"issue":{"href":"https://api.github.com/repos/tass-belgium/picotcp/issues/417"},"comments":{"href":"https://api.github.com/repos/tass-belgium/picotcp/issues/417/comments"},"review_comments":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417/comments"},"review_comment":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/417/commits"},"statuses":{"href":"https://api.github.com/repos/tass-belgium/picotcp/statuses/efd03eb3bdf0df1eba9ac15384292269e621d5ec"}}}}
{"actor":{"display_login":"phalox"}}