{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/static/pulls/comments/49588500","id":49588500,"diff_hunk":"@@ -0,0 +1,34 @@\n+<%\n+  sections ||= []\n+%>\n+<aside class=\"govuk-related-items\" role=\"complementary\">\n+  <% sections.each do |section| %>\n+    <% section_title = section[:title] || \"Elsewhere on GOV.UK\" %>","path":"app/views/govuk_component/related_items.raw.html.erb","position":6,"original_position":6,"commit_id":"edd2e45bf885fe78e2415f1bba60b220d77d73af","original_commit_id":"edd2e45bf885fe78e2415f1bba60b220d77d73af","user":{"login":"dsingleton","id":63201,"avatar_url":"https://avatars.githubusercontent.com/u/63201?v=3","gravatar_id":"","url":"https://api.github.com/users/dsingleton","html_url":"https://github.com/dsingleton","followers_url":"https://api.github.com/users/dsingleton/followers","following_url":"https://api.github.com/users/dsingleton/following{/other_user}","gists_url":"https://api.github.com/users/dsingleton/gists{/gist_id}","starred_url":"https://api.github.com/users/dsingleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsingleton/subscriptions","organizations_url":"https://api.github.com/users/dsingleton/orgs","repos_url":"https://api.github.com/users/dsingleton/repos","events_url":"https://api.github.com/users/dsingleton/events{/privacy}","received_events_url":"https://api.github.com/users/dsingleton/received_events","type":"User","site_admin":false},"body":"Is that a [regression vs the old behaviour](https://github.com/alphagov/static/blob/master/app/views/root/related.raw.html.erb#L7-L34)? If not, then I think it's not a blocker, unless fixing it required a significant API change - like passing \"Elsewhere\" (internal, and [external](https://github.com/alphagov/static/blob/master/app/views/root/related.raw.html.erb#L37-L51) links as a separate arg?","created_at":"2016-01-13T13:21:21Z","updated_at":"2016-01-13T13:21:21Z","html_url":"https://github.com/alphagov/static/pull/704#discussion_r49588500","pull_request_url":"https://api.github.com/repos/alphagov/static/pulls/704","_links":{"self":{"href":"https://api.github.com/repos/alphagov/static/pulls/comments/49588500"},"html":{"href":"https://github.com/alphagov/static/pull/704#discussion_r49588500"},"pull_request":{"href":"https://api.github.com/repos/alphagov/static/pulls/704"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/static/pulls/704","id":55645864,"html_url":"https://github.com/alphagov/static/pull/704","diff_url":"https://github.com/alphagov/static/pull/704.diff","patch_url":"https://github.com/alphagov/static/pull/704.patch","issue_url":"https://api.github.com/repos/alphagov/static/issues/704","number":704,"state":"open","locked":false,"title":"Related items component","user":{"login":"binaryberry","id":8225167,"avatar_url":"https://avatars.githubusercontent.com/u/8225167?v=3","gravatar_id":"","url":"https://api.github.com/users/binaryberry","html_url":"https://github.com/binaryberry","followers_url":"https://api.github.com/users/binaryberry/followers","following_url":"https://api.github.com/users/binaryberry/following{/other_user}","gists_url":"https://api.github.com/users/binaryberry/gists{/gist_id}","starred_url":"https://api.github.com/users/binaryberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaryberry/subscriptions","organizations_url":"https://api.github.com/users/binaryberry/orgs","repos_url":"https://api.github.com/users/binaryberry/repos","events_url":"https://api.github.com/users/binaryberry/events{/privacy}","received_events_url":"https://api.github.com/users/binaryberry/received_events","type":"User","site_admin":false},"body":"> __Headed sections of related items.__\r\n> Accepts an array of sections. Each section can have a title, url, id and a list of related items.\r\n> Each item is a hash with a title and url. If the url is external, a rel value can also be provided.\r\n\r\nCreate a related-items component based on188e526 and on [core stylesheets](https://github.com/alphagov/static/blob/master/app/assets/stylesheets/helpers/_core.scss#L56-L147)\r\n\r\nCare must be taken when using the component so that navigation is always\r\ncorrectly labelled (pattern based on http://tink.uk/screen-readers-aria-roles-html5-support/). When passing in a section id, use this to add an id attribute and a labelledby attribute. This is in favour of generating an id (eg. by parameterising the title) so that the component isn't using rails specific\r\nfeatures.\r\n\r\n![screen shot 2016-01-11 at 16 37 44](https://cloud.githubusercontent.com/assets/8225167/12239655/baf297b2-b881-11e5-8a95-eafe8822634a.png)\r\n\r\n[Trello](https://trello.com/c/gRHBCfVy/236-component-creation-related-links-medium)\r\n\r\npaired with @fofr \r\ncc @dsingleton","created_at":"2016-01-11T16:42:08Z","updated_at":"2016-01-13T13:21:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29e2a3accfe575c88002b6cb14d07eb536375e88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/static/pulls/704/commits","review_comments_url":"https://api.github.com/repos/alphagov/static/pulls/704/comments","review_comment_url":"https://api.github.com/repos/alphagov/static/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/static/issues/704/comments","statuses_url":"https://api.github.com/repos/alphagov/static/statuses/edd2e45bf885fe78e2415f1bba60b220d77d73af","head":{"label":"alphagov:related-items-component","ref":"related-items-component","sha":"edd2e45bf885fe78e2415f1bba60b220d77d73af","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":1599151,"name":"static","full_name":"alphagov/static","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/static","description":"GOV.UK static files/resources","fork":false,"url":"https://api.github.com/repos/alphagov/static","forks_url":"https://api.github.com/repos/alphagov/static/forks","keys_url":"https://api.github.com/repos/alphagov/static/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/static/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/static/teams","hooks_url":"https://api.github.com/repos/alphagov/static/hooks","issue_events_url":"https://api.github.com/repos/alphagov/static/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/static/events","assignees_url":"https://api.github.com/repos/alphagov/static/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/static/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/static/tags","blobs_url":"https://api.github.com/repos/alphagov/static/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/static/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/static/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/static/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/static/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/static/languages","stargazers_url":"https://api.github.com/repos/alphagov/static/stargazers","contributors_url":"https://api.github.com/repos/alphagov/static/contributors","subscribers_url":"https://api.github.com/repos/alphagov/static/subscribers","subscription_url":"https://api.github.com/repos/alphagov/static/subscription","commits_url":"https://api.github.com/repos/alphagov/static/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/static/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/static/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/static/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/static/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/static/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/static/merges","archive_url":"https://api.github.com/repos/alphagov/static/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/static/downloads","issues_url":"https://api.github.com/repos/alphagov/static/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/static/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/static/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/static/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/static/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/static/releases{/id}","created_at":"2011-04-11T13:42:56Z","updated_at":"2015-12-05T14:05:16Z","pushed_at":"2016-01-13T12:13:31Z","git_url":"git://github.com/alphagov/static.git","ssh_url":"git@github.com:alphagov/static.git","clone_url":"https://github.com/alphagov/static.git","svn_url":"https://github.com/alphagov/static","homepage":"","size":21471,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":11,"forks":31,"open_issues":11,"watchers":79,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"44a031d42076a4d429b8de7d155b6690c346ac53","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":1599151,"name":"static","full_name":"alphagov/static","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/static","description":"GOV.UK static files/resources","fork":false,"url":"https://api.github.com/repos/alphagov/static","forks_url":"https://api.github.com/repos/alphagov/static/forks","keys_url":"https://api.github.com/repos/alphagov/static/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/static/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/static/teams","hooks_url":"https://api.github.com/repos/alphagov/static/hooks","issue_events_url":"https://api.github.com/repos/alphagov/static/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/static/events","assignees_url":"https://api.github.com/repos/alphagov/static/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/static/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/static/tags","blobs_url":"https://api.github.com/repos/alphagov/static/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/static/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/static/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/static/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/static/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/static/languages","stargazers_url":"https://api.github.com/repos/alphagov/static/stargazers","contributors_url":"https://api.github.com/repos/alphagov/static/contributors","subscribers_url":"https://api.github.com/repos/alphagov/static/subscribers","subscription_url":"https://api.github.com/repos/alphagov/static/subscription","commits_url":"https://api.github.com/repos/alphagov/static/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/static/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/static/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/static/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/static/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/static/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/static/merges","archive_url":"https://api.github.com/repos/alphagov/static/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/static/downloads","issues_url":"https://api.github.com/repos/alphagov/static/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/static/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/static/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/static/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/static/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/static/releases{/id}","created_at":"2011-04-11T13:42:56Z","updated_at":"2015-12-05T14:05:16Z","pushed_at":"2016-01-13T12:13:31Z","git_url":"git://github.com/alphagov/static.git","ssh_url":"git@github.com:alphagov/static.git","clone_url":"https://github.com/alphagov/static.git","svn_url":"https://github.com/alphagov/static","homepage":"","size":21471,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":11,"forks":31,"open_issues":11,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/static/pulls/704"},"html":{"href":"https://github.com/alphagov/static/pull/704"},"issue":{"href":"https://api.github.com/repos/alphagov/static/issues/704"},"comments":{"href":"https://api.github.com/repos/alphagov/static/issues/704/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/static/pulls/704/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/static/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/static/pulls/704/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/static/statuses/edd2e45bf885fe78e2415f1bba60b220d77d73af"}}}}