{"action":"closed","number":116,"pull_request":{"url":"https://api.github.com/repos/basisjs/basisjs/pulls/116","id":87280734,"html_url":"https://github.com/basisjs/basisjs/pull/116","diff_url":"https://github.com/basisjs/basisjs/pull/116.diff","patch_url":"https://github.com/basisjs/basisjs/pull/116.patch","issue_url":"https://api.github.com/repos/basisjs/basisjs/issues/116","number":116,"state":"closed","locked":false,"title":"basis.data.dataset: flush dataset on destroy and prevent further itemsChanged events","user":{"login":"istrel","id":5306643,"avatar_url":"https://avatars.githubusercontent.com/u/5306643?v=3","gravatar_id":"","url":"https://api.github.com/users/istrel","html_url":"https://github.com/istrel","followers_url":"https://api.github.com/users/istrel/followers","following_url":"https://api.github.com/users/istrel/following{/other_user}","gists_url":"https://api.github.com/users/istrel/gists{/gist_id}","starred_url":"https://api.github.com/users/istrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istrel/subscriptions","organizations_url":"https://api.github.com/users/istrel/orgs","repos_url":"https://api.github.com/users/istrel/repos","events_url":"https://api.github.com/users/istrel/events{/privacy}","received_events_url":"https://api.github.com/users/istrel/received_events","type":"User","site_admin":false},"body":"If dataset with items gets destroyed in accumulate state, it calls `this.clear()` which fires an `itemsChanged` event.\r\nBecause of accumulate state it gets destroyed first, and after `setAccumulateState(false)` - fired. In `emit_itemsChanged` it tries to remove deleted items from `this.items_` map, which became `null` after destroy. \r\nTherefore `delete this.items_[object.basisObjectId]` fires error","created_at":"2016-09-29T09:56:42Z","updated_at":"2016-10-11T13:59:48Z","closed_at":"2016-10-11T13:59:48Z","merged_at":"2016-10-11T13:59:48Z","merge_commit_sha":"3a62c5be63f22c1373696079866ff33538ffee6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/basisjs/basisjs/pulls/116/commits","review_comments_url":"https://api.github.com/repos/basisjs/basisjs/pulls/116/comments","review_comment_url":"https://api.github.com/repos/basisjs/basisjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basisjs/basisjs/issues/116/comments","statuses_url":"https://api.github.com/repos/basisjs/basisjs/statuses/9925a893979b7a38d6dc787aae500585268e8df7","head":{"label":"istrel:accumulate-state-destroy","ref":"accumulate-state-destroy","sha":"9925a893979b7a38d6dc787aae500585268e8df7","user":{"login":"istrel","id":5306643,"avatar_url":"https://avatars.githubusercontent.com/u/5306643?v=3","gravatar_id":"","url":"https://api.github.com/users/istrel","html_url":"https://github.com/istrel","followers_url":"https://api.github.com/users/istrel/followers","following_url":"https://api.github.com/users/istrel/following{/other_user}","gists_url":"https://api.github.com/users/istrel/gists{/gist_id}","starred_url":"https://api.github.com/users/istrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istrel/subscriptions","organizations_url":"https://api.github.com/users/istrel/orgs","repos_url":"https://api.github.com/users/istrel/repos","events_url":"https://api.github.com/users/istrel/events{/privacy}","received_events_url":"https://api.github.com/users/istrel/received_events","type":"User","site_admin":false},"repo":{"id":58117052,"name":"basisjs","full_name":"istrel/basisjs","owner":{"login":"istrel","id":5306643,"avatar_url":"https://avatars.githubusercontent.com/u/5306643?v=3","gravatar_id":"","url":"https://api.github.com/users/istrel","html_url":"https://github.com/istrel","followers_url":"https://api.github.com/users/istrel/followers","following_url":"https://api.github.com/users/istrel/following{/other_user}","gists_url":"https://api.github.com/users/istrel/gists{/gist_id}","starred_url":"https://api.github.com/users/istrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istrel/subscriptions","organizations_url":"https://api.github.com/users/istrel/orgs","repos_url":"https://api.github.com/users/istrel/repos","events_url":"https://api.github.com/users/istrel/events{/privacy}","received_events_url":"https://api.github.com/users/istrel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/istrel/basisjs","description":"JavaScript framework to build single-page applications","fork":true,"url":"https://api.github.com/repos/istrel/basisjs","forks_url":"https://api.github.com/repos/istrel/basisjs/forks","keys_url":"https://api.github.com/repos/istrel/basisjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istrel/basisjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istrel/basisjs/teams","hooks_url":"https://api.github.com/repos/istrel/basisjs/hooks","issue_events_url":"https://api.github.com/repos/istrel/basisjs/issues/events{/number}","events_url":"https://api.github.com/repos/istrel/basisjs/events","assignees_url":"https://api.github.com/repos/istrel/basisjs/assignees{/user}","branches_url":"https://api.github.com/repos/istrel/basisjs/branches{/branch}","tags_url":"https://api.github.com/repos/istrel/basisjs/tags","blobs_url":"https://api.github.com/repos/istrel/basisjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istrel/basisjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istrel/basisjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/istrel/basisjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istrel/basisjs/statuses/{sha}","languages_url":"https://api.github.com/repos/istrel/basisjs/languages","stargazers_url":"https://api.github.com/repos/istrel/basisjs/stargazers","contributors_url":"https://api.github.com/repos/istrel/basisjs/contributors","subscribers_url":"https://api.github.com/repos/istrel/basisjs/subscribers","subscription_url":"https://api.github.com/repos/istrel/basisjs/subscription","commits_url":"https://api.github.com/repos/istrel/basisjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/istrel/basisjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/istrel/basisjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/istrel/basisjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/istrel/basisjs/contents/{+path}","compare_url":"https://api.github.com/repos/istrel/basisjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istrel/basisjs/merges","archive_url":"https://api.github.com/repos/istrel/basisjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istrel/basisjs/downloads","issues_url":"https://api.github.com/repos/istrel/basisjs/issues{/number}","pulls_url":"https://api.github.com/repos/istrel/basisjs/pulls{/number}","milestones_url":"https://api.github.com/repos/istrel/basisjs/milestones{/number}","notifications_url":"https://api.github.com/repos/istrel/basisjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istrel/basisjs/labels{/name}","releases_url":"https://api.github.com/repos/istrel/basisjs/releases{/id}","deployments_url":"https://api.github.com/repos/istrel/basisjs/deployments","created_at":"2016-05-05T08:42:06Z","updated_at":"2016-05-05T08:42:08Z","pushed_at":"2016-10-11T13:50:31Z","git_url":"git://github.com/istrel/basisjs.git","ssh_url":"git@github.com:istrel/basisjs.git","clone_url":"https://github.com/istrel/basisjs.git","svn_url":"https://github.com/istrel/basisjs","homepage":"http://basisjs.com","size":17440,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"basisjs:master","ref":"master","sha":"157418ec237452960903f6bab469d8042ae444e2","user":{"login":"basisjs","id":3409558,"avatar_url":"https://avatars.githubusercontent.com/u/3409558?v=3","gravatar_id":"","url":"https://api.github.com/users/basisjs","html_url":"https://github.com/basisjs","followers_url":"https://api.github.com/users/basisjs/followers","following_url":"https://api.github.com/users/basisjs/following{/other_user}","gists_url":"https://api.github.com/users/basisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/basisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basisjs/subscriptions","organizations_url":"https://api.github.com/users/basisjs/orgs","repos_url":"https://api.github.com/users/basisjs/repos","events_url":"https://api.github.com/users/basisjs/events{/privacy}","received_events_url":"https://api.github.com/users/basisjs/received_events","type":"Organization","site_admin":false},"repo":{"id":4582701,"name":"basisjs","full_name":"basisjs/basisjs","owner":{"login":"basisjs","id":3409558,"avatar_url":"https://avatars.githubusercontent.com/u/3409558?v=3","gravatar_id":"","url":"https://api.github.com/users/basisjs","html_url":"https://github.com/basisjs","followers_url":"https://api.github.com/users/basisjs/followers","following_url":"https://api.github.com/users/basisjs/following{/other_user}","gists_url":"https://api.github.com/users/basisjs/gists{/gist_id}","starred_url":"https://api.github.com/users/basisjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basisjs/subscriptions","organizations_url":"https://api.github.com/users/basisjs/orgs","repos_url":"https://api.github.com/users/basisjs/repos","events_url":"https://api.github.com/users/basisjs/events{/privacy}","received_events_url":"https://api.github.com/users/basisjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basisjs/basisjs","description":"JavaScript framework to build single page applications","fork":false,"url":"https://api.github.com/repos/basisjs/basisjs","forks_url":"https://api.github.com/repos/basisjs/basisjs/forks","keys_url":"https://api.github.com/repos/basisjs/basisjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basisjs/basisjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basisjs/basisjs/teams","hooks_url":"https://api.github.com/repos/basisjs/basisjs/hooks","issue_events_url":"https://api.github.com/repos/basisjs/basisjs/issues/events{/number}","events_url":"https://api.github.com/repos/basisjs/basisjs/events","assignees_url":"https://api.github.com/repos/basisjs/basisjs/assignees{/user}","branches_url":"https://api.github.com/repos/basisjs/basisjs/branches{/branch}","tags_url":"https://api.github.com/repos/basisjs/basisjs/tags","blobs_url":"https://api.github.com/repos/basisjs/basisjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basisjs/basisjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basisjs/basisjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basisjs/basisjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basisjs/basisjs/statuses/{sha}","languages_url":"https://api.github.com/repos/basisjs/basisjs/languages","stargazers_url":"https://api.github.com/repos/basisjs/basisjs/stargazers","contributors_url":"https://api.github.com/repos/basisjs/basisjs/contributors","subscribers_url":"https://api.github.com/repos/basisjs/basisjs/subscribers","subscription_url":"https://api.github.com/repos/basisjs/basisjs/subscription","commits_url":"https://api.github.com/repos/basisjs/basisjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basisjs/basisjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basisjs/basisjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basisjs/basisjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/basisjs/basisjs/contents/{+path}","compare_url":"https://api.github.com/repos/basisjs/basisjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basisjs/basisjs/merges","archive_url":"https://api.github.com/repos/basisjs/basisjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basisjs/basisjs/downloads","issues_url":"https://api.github.com/repos/basisjs/basisjs/issues{/number}","pulls_url":"https://api.github.com/repos/basisjs/basisjs/pulls{/number}","milestones_url":"https://api.github.com/repos/basisjs/basisjs/milestones{/number}","notifications_url":"https://api.github.com/repos/basisjs/basisjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basisjs/basisjs/labels{/name}","releases_url":"https://api.github.com/repos/basisjs/basisjs/releases{/id}","deployments_url":"https://api.github.com/repos/basisjs/basisjs/deployments","created_at":"2012-06-07T08:05:47Z","updated_at":"2016-10-11T04:09:07Z","pushed_at":"2016-10-11T13:59:48Z","git_url":"git://github.com/basisjs/basisjs.git","ssh_url":"git@github.com:basisjs/basisjs.git","clone_url":"https://github.com/basisjs/basisjs.git","svn_url":"https://github.com/basisjs/basisjs","homepage":"http://basisjs.com","size":17559,"stargazers_count":333,"watchers_count":333,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":25,"forks":37,"open_issues":25,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basisjs/basisjs/pulls/116"},"html":{"href":"https://github.com/basisjs/basisjs/pull/116"},"issue":{"href":"https://api.github.com/repos/basisjs/basisjs/issues/116"},"comments":{"href":"https://api.github.com/repos/basisjs/basisjs/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/basisjs/basisjs/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/basisjs/basisjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basisjs/basisjs/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/basisjs/basisjs/statuses/9925a893979b7a38d6dc787aae500585268e8df7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lahmatiy","id":270491,"avatar_url":"https://avatars.githubusercontent.com/u/270491?v=3","gravatar_id":"","url":"https://api.github.com/users/lahmatiy","html_url":"https://github.com/lahmatiy","followers_url":"https://api.github.com/users/lahmatiy/followers","following_url":"https://api.github.com/users/lahmatiy/following{/other_user}","gists_url":"https://api.github.com/users/lahmatiy/gists{/gist_id}","starred_url":"https://api.github.com/users/lahmatiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lahmatiy/subscriptions","organizations_url":"https://api.github.com/users/lahmatiy/orgs","repos_url":"https://api.github.com/users/lahmatiy/repos","events_url":"https://api.github.com/users/lahmatiy/events{/privacy}","received_events_url":"https://api.github.com/users/lahmatiy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":12,"commits":11,"additions":100,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"lahmatiy"}}