{"action":"created","comment":{"url":"https://api.github.com/repos/bsinno/hawkbit/pulls/comments/51265754","id":51265754,"diff_hunk":"@@ -274,49 +292,73 @@ public void rolloutStartsGroupAfterGroupAndGetsFinished() {\n     @Description(\"Verify that the targets have the right status during the rollout.\")\n     public void countCorrectStatusForEachTargetDuringRollout() {\n \n+        // setup\n         final int amountTargetsForRollout = 8;\n         final int amountOtherTargets = 15;\n         final int amountGroups = 4;\n-        final Rollout createdRollout = createTestRollout(amountTargetsForRollout, amountOtherTargets, amountGroups);\n+        final Rollout createdRollout = createTestRolloutWithDistributionSet(amountTargetsForRollout,\n+                amountOtherTargets, amountGroups, \"50\", \"80\");\n \n-        // test that the 8 targets have not started\n-        validateRolloutDetailedStatus(createdRollout.getId(), new Long(8), new Long(0), new Long(0), new Long(0),\n-                new Long(0));\n+        // verify\n+        // targets have not started\n+        Map<TotalTargetCountStatus.Status, Long> validationMap = createInitStatusMap();\n+        validationMap.put(TotalTargetCountStatus.Status.NOTSTARTED, 8L);\n+        validateRolloutActionStatus(createdRollout.getId(), validationMap);\n \n-        // start the rollout\n+        // test 1\n         rolloutManagement.startRollout(createdRollout);\n \n-        // test that the 6 targets are ready and 2 are running\n-        validateRolloutDetailedStatus(createdRollout.getId(), new Long(0), new Long(6), new Long(2), new Long(0),\n-                new Long(0));\n+        // verify\n+        // 6 targets are ready and 2 are running\n+        validationMap = createInitStatusMap();\n+        validationMap.put(TotalTargetCountStatus.Status.READY, 6L);\n+        validationMap.put(TotalTargetCountStatus.Status.RUNNING, 2L);\n+        validateRolloutActionStatus(createdRollout.getId(), validationMap);\n \n-        changeStatusForRunningActions(createdRollout, Status.FINISHED);\n+        // test 2","path":"hawkbit-repository/src/test/java/org/eclipse/hawkbit/repository/RolloutManagementTest.java","position":144,"original_position":144,"commit_id":"f6ac47c2951c85c60066674c52158f312e0b4509","original_commit_id":"f6ac47c2951c85c60066674c52158f312e0b4509","user":{"login":"SirWayne","id":6340898,"avatar_url":"https://avatars.githubusercontent.com/u/6340898?v=3","gravatar_id":"","url":"https://api.github.com/users/SirWayne","html_url":"https://github.com/SirWayne","followers_url":"https://api.github.com/users/SirWayne/followers","following_url":"https://api.github.com/users/SirWayne/following{/other_user}","gists_url":"https://api.github.com/users/SirWayne/gists{/gist_id}","starred_url":"https://api.github.com/users/SirWayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirWayne/subscriptions","organizations_url":"https://api.github.com/users/SirWayne/orgs","repos_url":"https://api.github.com/users/SirWayne/repos","events_url":"https://api.github.com/users/SirWayne/events{/privacy}","received_events_url":"https://api.github.com/users/SirWayne/received_events","type":"User","site_admin":false},"body":"auch unöttig","created_at":"2016-01-29T14:29:02Z","updated_at":"2016-01-29T14:29:02Z","html_url":"https://github.com/bsinno/hawkbit/pull/1#discussion_r51265754","pull_request_url":"https://api.github.com/repos/bsinno/hawkbit/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/bsinno/hawkbit/pulls/comments/51265754"},"html":{"href":"https://github.com/bsinno/hawkbit/pull/1#discussion_r51265754"},"pull_request":{"href":"https://api.github.com/repos/bsinno/hawkbit/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bsinno/hawkbit/pulls/1","id":57630391,"html_url":"https://github.com/bsinno/hawkbit/pull/1","diff_url":"https://github.com/bsinno/hawkbit/pull/1.diff","patch_url":"https://github.com/bsinno/hawkbit/pull/1.patch","issue_url":"https://api.github.com/repos/bsinno/hawkbit/issues/1","number":1,"state":"closed","locked":false,"title":"Mecs 1239 unit testing of rollout","user":{"login":"Jonkno","id":14817818,"avatar_url":"https://avatars.githubusercontent.com/u/14817818?v=3","gravatar_id":"","url":"https://api.github.com/users/Jonkno","html_url":"https://github.com/Jonkno","followers_url":"https://api.github.com/users/Jonkno/followers","following_url":"https://api.github.com/users/Jonkno/following{/other_user}","gists_url":"https://api.github.com/users/Jonkno/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonkno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonkno/subscriptions","organizations_url":"https://api.github.com/users/Jonkno/orgs","repos_url":"https://api.github.com/users/Jonkno/repos","events_url":"https://api.github.com/users/Jonkno/events{/privacy}","received_events_url":"https://api.github.com/users/Jonkno/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-29T10:31:48Z","updated_at":"2016-01-29T14:29:03Z","closed_at":"2016-01-29T10:32:22Z","merged_at":"2016-01-29T10:32:22Z","merge_commit_sha":"046cf0f93332781956f4d62ed332f438a674031c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bsinno/hawkbit/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bsinno/hawkbit/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bsinno/hawkbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bsinno/hawkbit/issues/1/comments","statuses_url":"https://api.github.com/repos/bsinno/hawkbit/statuses/f6ac47c2951c85c60066674c52158f312e0b4509","head":{"label":"bsinno:MECS-1239-Unit-testing-of-rollout","ref":"MECS-1239-Unit-testing-of-rollout","sha":"f6ac47c2951c85c60066674c52158f312e0b4509","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":50108079,"name":"hawkbit","full_name":"bsinno/hawkbit","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/hawkbit","description":"","fork":true,"url":"https://api.github.com/repos/bsinno/hawkbit","forks_url":"https://api.github.com/repos/bsinno/hawkbit/forks","keys_url":"https://api.github.com/repos/bsinno/hawkbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hawkbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hawkbit/teams","hooks_url":"https://api.github.com/repos/bsinno/hawkbit/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hawkbit/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hawkbit/events","assignees_url":"https://api.github.com/repos/bsinno/hawkbit/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hawkbit/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hawkbit/tags","blobs_url":"https://api.github.com/repos/bsinno/hawkbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hawkbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hawkbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hawkbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hawkbit/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hawkbit/languages","stargazers_url":"https://api.github.com/repos/bsinno/hawkbit/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hawkbit/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hawkbit/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hawkbit/subscription","commits_url":"https://api.github.com/repos/bsinno/hawkbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hawkbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hawkbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hawkbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hawkbit/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hawkbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hawkbit/merges","archive_url":"https://api.github.com/repos/bsinno/hawkbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hawkbit/downloads","issues_url":"https://api.github.com/repos/bsinno/hawkbit/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hawkbit/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hawkbit/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hawkbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hawkbit/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hawkbit/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hawkbit/deployments","created_at":"2016-01-21T13:05:15Z","updated_at":"2016-01-21T16:24:07Z","pushed_at":"2016-01-29T14:26:36Z","git_url":"git://github.com/bsinno/hawkbit.git","ssh_url":"git@github.com:bsinno/hawkbit.git","clone_url":"https://github.com/bsinno/hawkbit.git","svn_url":"https://github.com/bsinno/hawkbit","homepage":null,"size":1820,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bsinno:rollout_management","ref":"rollout_management","sha":"edb8de5b3e1804c1dfd2a151423f4bb2198f1fc1","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":50108079,"name":"hawkbit","full_name":"bsinno/hawkbit","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/hawkbit","description":"","fork":true,"url":"https://api.github.com/repos/bsinno/hawkbit","forks_url":"https://api.github.com/repos/bsinno/hawkbit/forks","keys_url":"https://api.github.com/repos/bsinno/hawkbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hawkbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hawkbit/teams","hooks_url":"https://api.github.com/repos/bsinno/hawkbit/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hawkbit/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hawkbit/events","assignees_url":"https://api.github.com/repos/bsinno/hawkbit/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hawkbit/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hawkbit/tags","blobs_url":"https://api.github.com/repos/bsinno/hawkbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hawkbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hawkbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hawkbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hawkbit/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hawkbit/languages","stargazers_url":"https://api.github.com/repos/bsinno/hawkbit/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hawkbit/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hawkbit/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hawkbit/subscription","commits_url":"https://api.github.com/repos/bsinno/hawkbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hawkbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hawkbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hawkbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hawkbit/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hawkbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hawkbit/merges","archive_url":"https://api.github.com/repos/bsinno/hawkbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hawkbit/downloads","issues_url":"https://api.github.com/repos/bsinno/hawkbit/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hawkbit/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hawkbit/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hawkbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hawkbit/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hawkbit/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hawkbit/deployments","created_at":"2016-01-21T13:05:15Z","updated_at":"2016-01-21T16:24:07Z","pushed_at":"2016-01-29T14:26:36Z","git_url":"git://github.com/bsinno/hawkbit.git","ssh_url":"git@github.com:bsinno/hawkbit.git","clone_url":"https://github.com/bsinno/hawkbit.git","svn_url":"https://github.com/bsinno/hawkbit","homepage":null,"size":1820,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bsinno/hawkbit/pulls/1"},"html":{"href":"https://github.com/bsinno/hawkbit/pull/1"},"issue":{"href":"https://api.github.com/repos/bsinno/hawkbit/issues/1"},"comments":{"href":"https://api.github.com/repos/bsinno/hawkbit/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bsinno/hawkbit/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bsinno/hawkbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bsinno/hawkbit/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bsinno/hawkbit/statuses/f6ac47c2951c85c60066674c52158f312e0b4509"}}}}