{"action":"created","comment":{"url":"https://api.github.com/repos/libuv/libuv/pulls/comments/80432940","id":80432940,"diff_hunk":"@@ -409,6 +409,37 @@ struct uv_shutdown_s {\n   } u;                                                                        \\\n   UV_HANDLE_PRIVATE_FIELDS                                                    \\\n \n+#define UV_TIMER_PRIVATE_FIELDS                                               \\","path":"include/uv.h","position":4,"original_position":4,"commit_id":"49bd7a547f9b620cb54085bf8ac7e8e44ef3d23b","original_commit_id":"49bd7a547f9b620cb54085bf8ac7e8e44ef3d23b","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"On some handles we have some fields directly in their struct definition which are marked as private with a comment.  Check if there are repetitions please.\r\n\r\nAlso, ignore the first part of my message, I think it looks better with the define, for now.","created_at":"2016-09-26T09:01:55Z","updated_at":"2016-09-26T09:01:55Z","html_url":"https://github.com/libuv/libuv/pull/1067#discussion_r80432940","pull_request_url":"https://api.github.com/repos/libuv/libuv/pulls/1067","_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments/80432940"},"html":{"href":"https://github.com/libuv/libuv/pull/1067#discussion_r80432940"},"pull_request":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1067"}}},"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/1067","id":86492274,"html_url":"https://github.com/libuv/libuv/pull/1067","diff_url":"https://github.com/libuv/libuv/pull/1067.diff","patch_url":"https://github.com/libuv/libuv/pull/1067.patch","issue_url":"https://api.github.com/repos/libuv/libuv/issues/1067","number":1067,"state":"open","locked":false,"title":"win, unix: extract common fields out of the loop fields.","user":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=3","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"body":"only -11 lines though in total.","created_at":"2016-09-23T10:52:47Z","updated_at":"2016-09-26T09:01:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00d0d8e22022abfa2617c5f1be3286ade4739629","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libuv/libuv/pulls/1067/commits","review_comments_url":"https://api.github.com/repos/libuv/libuv/pulls/1067/comments","review_comment_url":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/1067/comments","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/49bd7a547f9b620cb54085bf8ac7e8e44ef3d23b","head":{"label":"txdv:diet-loop-struct","ref":"diet-loop-struct","sha":"49bd7a547f9b620cb54085bf8ac7e8e44ef3d23b","user":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=3","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"repo":{"id":29731861,"name":"libuv","full_name":"txdv/libuv","owner":{"login":"txdv","id":116642,"avatar_url":"https://avatars.githubusercontent.com/u/116642?v=3","gravatar_id":"","url":"https://api.github.com/users/txdv","html_url":"https://github.com/txdv","followers_url":"https://api.github.com/users/txdv/followers","following_url":"https://api.github.com/users/txdv/following{/other_user}","gists_url":"https://api.github.com/users/txdv/gists{/gist_id}","starred_url":"https://api.github.com/users/txdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txdv/subscriptions","organizations_url":"https://api.github.com/users/txdv/orgs","repos_url":"https://api.github.com/users/txdv/repos","events_url":"https://api.github.com/users/txdv/events{/privacy}","received_events_url":"https://api.github.com/users/txdv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/txdv/libuv","description":"Cross-platform asychronous I/O","fork":true,"url":"https://api.github.com/repos/txdv/libuv","forks_url":"https://api.github.com/repos/txdv/libuv/forks","keys_url":"https://api.github.com/repos/txdv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/txdv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/txdv/libuv/teams","hooks_url":"https://api.github.com/repos/txdv/libuv/hooks","issue_events_url":"https://api.github.com/repos/txdv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/txdv/libuv/events","assignees_url":"https://api.github.com/repos/txdv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/txdv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/txdv/libuv/tags","blobs_url":"https://api.github.com/repos/txdv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/txdv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/txdv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/txdv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/txdv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/txdv/libuv/languages","stargazers_url":"https://api.github.com/repos/txdv/libuv/stargazers","contributors_url":"https://api.github.com/repos/txdv/libuv/contributors","subscribers_url":"https://api.github.com/repos/txdv/libuv/subscribers","subscription_url":"https://api.github.com/repos/txdv/libuv/subscription","commits_url":"https://api.github.com/repos/txdv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/txdv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/txdv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/txdv/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/txdv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/txdv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/txdv/libuv/merges","archive_url":"https://api.github.com/repos/txdv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/txdv/libuv/downloads","issues_url":"https://api.github.com/repos/txdv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/txdv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/txdv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/txdv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/txdv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/txdv/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/txdv/libuv/deployments","created_at":"2015-01-23T12:37:00Z","updated_at":"2015-02-25T16:33:27Z","pushed_at":"2016-09-23T14:39:48Z","git_url":"git://github.com/txdv/libuv.git","ssh_url":"git@github.com:txdv/libuv.git","clone_url":"https://github.com/txdv/libuv.git","svn_url":"https://github.com/txdv/libuv","homepage":"http://libuv.org/","size":11111,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"libuv:master","ref":"master","sha":"912d42b7285fc29869472106d1c736f34ac91521","user":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"repo":{"id":14812739,"name":"libuv","full_name":"libuv/libuv","owner":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libuv/libuv","description":"Cross-platform asynchronous I/O","fork":false,"url":"https://api.github.com/repos/libuv/libuv","forks_url":"https://api.github.com/repos/libuv/libuv/forks","keys_url":"https://api.github.com/repos/libuv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libuv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libuv/libuv/teams","hooks_url":"https://api.github.com/repos/libuv/libuv/hooks","issue_events_url":"https://api.github.com/repos/libuv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/libuv/libuv/events","assignees_url":"https://api.github.com/repos/libuv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/libuv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/libuv/libuv/tags","blobs_url":"https://api.github.com/repos/libuv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libuv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libuv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/libuv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/libuv/libuv/languages","stargazers_url":"https://api.github.com/repos/libuv/libuv/stargazers","contributors_url":"https://api.github.com/repos/libuv/libuv/contributors","subscribers_url":"https://api.github.com/repos/libuv/libuv/subscribers","subscription_url":"https://api.github.com/repos/libuv/libuv/subscription","commits_url":"https://api.github.com/repos/libuv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/libuv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/libuv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/libuv/libuv/issues/comments{/number}","contents_url":"https://api.github.com/repos/libuv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/libuv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libuv/libuv/merges","archive_url":"https://api.github.com/repos/libuv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libuv/libuv/downloads","issues_url":"https://api.github.com/repos/libuv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/libuv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/libuv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/libuv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libuv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/libuv/libuv/releases{/id}","deployments_url":"https://api.github.com/repos/libuv/libuv/deployments","created_at":"2013-11-30T00:29:56Z","updated_at":"2016-09-26T08:45:49Z","pushed_at":"2016-09-25T18:51:28Z","git_url":"git://github.com/libuv/libuv.git","ssh_url":"git@github.com:libuv/libuv.git","clone_url":"https://github.com/libuv/libuv.git","svn_url":"https://github.com/libuv/libuv","homepage":"http://libuv.org/","size":18163,"stargazers_count":4793,"watchers_count":4793,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":824,"mirror_url":null,"open_issues_count":107,"forks":824,"open_issues":107,"watchers":4793,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1067"},"html":{"href":"https://github.com/libuv/libuv/pull/1067"},"issue":{"href":"https://api.github.com/repos/libuv/libuv/issues/1067"},"comments":{"href":"https://api.github.com/repos/libuv/libuv/issues/1067/comments"},"review_comments":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1067/comments"},"review_comment":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libuv/libuv/pulls/1067/commits"},"statuses":{"href":"https://api.github.com/repos/libuv/libuv/statuses/49bd7a547f9b620cb54085bf8ac7e8e44ef3d23b"}}}}
{"actor":{"display_login":"saghul"}}