{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/blueflood/issues/646","repository_url":"https://api.github.com/repos/rackerlabs/blueflood","labels_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/646/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/646/comments","events_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/646/events","html_url":"https://github.com/rackerlabs/blueflood/pull/646","id":139066213,"number":646,"title":"initial clean up of Astyanax ColumnFamily","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-07T19:15:56Z","updated_at":"2016-03-08T16:07:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/646","html_url":"https://github.com/rackerlabs/blueflood/pull/646","diff_url":"https://github.com/rackerlabs/blueflood/pull/646.diff","patch_url":"https://github.com/rackerlabs/blueflood/pull/646.patch"},"body":"**Why**\r\nEventually, we will be moving to using Datastax driver and removing Astyanax, in preparation to upgrading to Cassandra 2.1.13. \r\n\r\nThis PR removes some unnecessary use of Astyanax's ColumnFamily model class. Blueflood already provides a wrapper class called ```MetricColumnFamily```, which extends the Astyanax ColumnFamily class. But for some reasons some code are written to return Astyanax ColumnFamily directly, propagating the use of this class in more places than necessary.\r\n\r\n**How**\r\n* Change the CassandraModel.getColumnFamily() method to return MetricColumnFamily. \r\n* Change all consumer of this method accordingly.\r\n\r\nA small other clean up I did was to move the class ```IntegrationBaseTest.java``` from ```src/main``` to ```src/integration-test```. To make this move successful, I have to also change ```.travis.yml```. Before the PR, we were calling ```mvn package``` before running the tests. I think that is incorrect. We should package *after* tests are running successfully.\r\n\r\nI have run the unit & integration tests and they all have passed."},"comment":{"url":"https://api.github.com/repos/rackerlabs/blueflood/issues/comments/193841502","html_url":"https://github.com/rackerlabs/blueflood/pull/646#issuecomment-193841502","issue_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/646","id":193841502,"user":{"login":"ChandraAddala","id":1525859,"avatar_url":"https://avatars.githubusercontent.com/u/1525859?v=3","gravatar_id":"","url":"https://api.github.com/users/ChandraAddala","html_url":"https://github.com/ChandraAddala","followers_url":"https://api.github.com/users/ChandraAddala/followers","following_url":"https://api.github.com/users/ChandraAddala/following{/other_user}","gists_url":"https://api.github.com/users/ChandraAddala/gists{/gist_id}","starred_url":"https://api.github.com/users/ChandraAddala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChandraAddala/subscriptions","organizations_url":"https://api.github.com/users/ChandraAddala/orgs","repos_url":"https://api.github.com/users/ChandraAddala/repos","events_url":"https://api.github.com/users/ChandraAddala/events{/privacy}","received_events_url":"https://api.github.com/users/ChandraAddala/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T16:07:44Z","updated_at":"2016-03-08T16:07:44Z","body":"Looks good."}}