{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments/61443593","id":61443593,"diff_hunk":"@@ -742,6 +742,18 @@\n         <version>${version.com.github.detro}</version>\n       </dependency>\n \n+      <dependency>\n+        <groupId>com.github.detro</groupId>\n+        <artifactId>phantomjsdriver</artifactId>\n+        <version>${version.com.github.detro}</version>\n+      </dependency>\n+\n+      <dependency>\n+        <groupId>simple-jndi</groupId>\n+        <artifactId>simple-jndi</artifactId>\n+        <version>0.11.4.1</version>","path":"kie-third-party-bom/pom.xml","position":13,"original_position":13,"commit_id":"2690b9a924bca26573fd8b62f656b15788dd985f","original_commit_id":"2690b9a924bca26573fd8b62f656b15788dd985f","user":{"login":"psiroky","id":670547,"avatar_url":"https://avatars.githubusercontent.com/u/670547?v=3","gravatar_id":"","url":"https://api.github.com/users/psiroky","html_url":"https://github.com/psiroky","followers_url":"https://api.github.com/users/psiroky/followers","following_url":"https://api.github.com/users/psiroky/following{/other_user}","gists_url":"https://api.github.com/users/psiroky/gists{/gist_id}","starred_url":"https://api.github.com/users/psiroky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psiroky/subscriptions","organizations_url":"https://api.github.com/users/psiroky/orgs","repos_url":"https://api.github.com/users/psiroky/repos","events_url":"https://api.github.com/users/psiroky/events{/privacy}","received_events_url":"https://api.github.com/users/psiroky/received_events","type":"User","site_admin":false},"body":"I guess this got forgotten -- it should use the version property.","created_at":"2016-04-28T15:01:16Z","updated_at":"2016-04-28T15:01:16Z","html_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/189#discussion_r61443593","pull_request_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments/61443593"},"html":{"href":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/189#discussion_r61443593"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189","id":68228082,"html_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/189","diff_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/189.diff","patch_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/189.patch","issue_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/189","number":189,"state":"open","locked":false,"title":"- avoiding JNDI errors when testing with uberfire code","user":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"body":"[This use](https://github.com/uberfire/uberfire/blob/master/uberfire-commons/src/main/java/org/uberfire/commons/async/SimpleAsyncExecutorService.java#L75) of the `InitialContext` is causing errors in my tests, and `simple-jndi` (scope:test) fixes them. :) \r\n\r\nSee for more info: http://fandry.blogspot.nl/2011/03/junit-based-integration-testing-with.html","created_at":"2016-04-28T14:17:37Z","updated_at":"2016-04-28T15:01:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ddae4c1dfb47b8f6c4fa3e438496b0c3bc2666f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/189/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/statuses/2690b9a924bca26573fd8b62f656b15788dd985f","head":{"label":"mrietveld:pr-jndi-testing-errors","ref":"pr-jndi-testing-errors","sha":"2690b9a924bca26573fd8b62f656b15788dd985f","user":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"repo":{"id":28164023,"name":"droolsjbpm-build-bootstrap","full_name":"mrietveld/droolsjbpm-build-bootstrap","owner":{"login":"mrietveld","id":783550,"avatar_url":"https://avatars.githubusercontent.com/u/783550?v=3","gravatar_id":"","url":"https://api.github.com/users/mrietveld","html_url":"https://github.com/mrietveld","followers_url":"https://api.github.com/users/mrietveld/followers","following_url":"https://api.github.com/users/mrietveld/following{/other_user}","gists_url":"https://api.github.com/users/mrietveld/gists{/gist_id}","starred_url":"https://api.github.com/users/mrietveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrietveld/subscriptions","organizations_url":"https://api.github.com/users/mrietveld/orgs","repos_url":"https://api.github.com/users/mrietveld/repos","events_url":"https://api.github.com/users/mrietveld/events{/privacy}","received_events_url":"https://api.github.com/users/mrietveld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrietveld/droolsjbpm-build-bootstrap","description":"The build bootstrap contains the parent pom, guidelines and scripts for Drools and jBPM.","fork":true,"url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap","forks_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/forks","keys_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/teams","hooks_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/events","assignees_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/tags","blobs_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/languages","stargazers_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/subscription","commits_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/merges","archive_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/downloads","issues_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/mrietveld/droolsjbpm-build-bootstrap/deployments","created_at":"2014-12-18T01:56:29Z","updated_at":"2015-04-13T09:01:34Z","pushed_at":"2016-04-28T14:02:48Z","git_url":"git://github.com/mrietveld/droolsjbpm-build-bootstrap.git","ssh_url":"git@github.com:mrietveld/droolsjbpm-build-bootstrap.git","clone_url":"https://github.com/mrietveld/droolsjbpm-build-bootstrap.git","svn_url":"https://github.com/mrietveld/droolsjbpm-build-bootstrap","homepage":"http://www.drools.org","size":3839,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"3d63efbc7b24ddc32bf46ff22056ccc4c574b3ce","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1382478,"name":"droolsjbpm-build-bootstrap","full_name":"droolsjbpm/droolsjbpm-build-bootstrap","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap","description":"The build bootstrap contains the parent pom, guidelines and scripts for Drools, jBPM and OptaPlanner.","fork":false,"url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap","forks_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/forks","keys_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/events","assignees_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/merges","archive_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/deployments","created_at":"2011-02-18T13:12:01Z","updated_at":"2016-04-04T03:56:57Z","pushed_at":"2016-04-28T14:17:37Z","git_url":"git://github.com/droolsjbpm/droolsjbpm-build-bootstrap.git","ssh_url":"git@github.com:droolsjbpm/droolsjbpm-build-bootstrap.git","clone_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap.git","svn_url":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap","homepage":"http://www.kiegroup.org","size":5643,"stargazers_count":96,"watchers_count":96,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":3,"forks":202,"open_issues":3,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189"},"html":{"href":"https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/189"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/189"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/droolsjbpm-build-bootstrap/statuses/2690b9a924bca26573fd8b62f656b15788dd985f"}}}}