{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-android-driver/pulls/comments/52332072","id":52332072,"diff_hunk":"@@ -77,12 +77,8 @@ commands.toggleFlightMode = async function () {\n };\n \n commands.setGeoLocation = async function (location) {\n-  /*\n-   * TODO: Implement isRealDevice(). This method fails on\n-   * real devices, it should throw a NotYetImplementedError\n-   */\n-  let cmd = `geo fix ${location.longitude} ${location.latitude}`;\n-  return await this.adb.sendTelnetCommand(cmd);\n+  let cmd = 'am startservice -e longitude ' + '\"' + location.longitude + '\"' + ' -e latitude ' + '\"' + location.latitude + '\"' + ' io.appium.settings/.LocationService';\t","path":"lib/commands/network.js","position":10,"original_position":10,"commit_id":"1e02c8ed54f058475bbc052728dc678dd81d3f94","original_commit_id":"1e02c8ed54f058475bbc052728dc678dd81d3f94","user":{"login":"imurchie","id":2614354,"avatar_url":"https://avatars.githubusercontent.com/u/2614354?v=3","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false},"body":"I don't think this is how `adb.shell` works anymore. It should be taking an array. See https://github.com/appium/appium-android-driver/blob/master/lib/commands/general.js#L59-L63","created_at":"2016-02-09T16:25:41Z","updated_at":"2016-02-09T16:25:41Z","html_url":"https://github.com/appium/appium-android-driver/pull/95#discussion_r52332072","pull_request_url":"https://api.github.com/repos/appium/appium-android-driver/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-android-driver/pulls/comments/52332072"},"html":{"href":"https://github.com/appium/appium-android-driver/pull/95#discussion_r52332072"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-android-driver/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-android-driver/pulls/95","id":58747623,"html_url":"https://github.com/appium/appium-android-driver/pull/95","diff_url":"https://github.com/appium/appium-android-driver/pull/95.diff","patch_url":"https://github.com/appium/appium-android-driver/pull/95.patch","issue_url":"https://api.github.com/repos/appium/appium-android-driver/issues/95","number":95,"state":"open","locked":false,"title":"setting the mock location on the device and android emulator.","user":{"login":"anandsadu","id":13962113,"avatar_url":"https://avatars.githubusercontent.com/u/13962113?v=3","gravatar_id":"","url":"https://api.github.com/users/anandsadu","html_url":"https://github.com/anandsadu","followers_url":"https://api.github.com/users/anandsadu/followers","following_url":"https://api.github.com/users/anandsadu/following{/other_user}","gists_url":"https://api.github.com/users/anandsadu/gists{/gist_id}","starred_url":"https://api.github.com/users/anandsadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandsadu/subscriptions","organizations_url":"https://api.github.com/users/anandsadu/orgs","repos_url":"https://api.github.com/users/anandsadu/repos","events_url":"https://api.github.com/users/anandsadu/events{/privacy}","received_events_url":"https://api.github.com/users/anandsadu/received_events","type":"User","site_admin":false},"body":"#### Fix: ####\r\nThe code fix addresses the issue [https://github.com/appium/appium/issues/4309] on **appium 1.5** to set the Location on the Android Devices and Android Emulators.It is linked with the [appium/io.appium.settings#6] .This feature will work once the settings apk is published to npm.\r\n\r\n#### Commit summary: ####\r\n\r\nset Location uses Android Service (in the settings apk )is invoked in the case of device.","created_at":"2016-02-09T13:35:45Z","updated_at":"2016-02-09T16:25:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd9d7493bab740d24aad37ee3a3cd0a088a798bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-android-driver/pulls/95/commits","review_comments_url":"https://api.github.com/repos/appium/appium-android-driver/pulls/95/comments","review_comment_url":"https://api.github.com/repos/appium/appium-android-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-android-driver/issues/95/comments","statuses_url":"https://api.github.com/repos/appium/appium-android-driver/statuses/1e02c8ed54f058475bbc052728dc678dd81d3f94","head":{"label":"anandsadu:master","ref":"master","sha":"1e02c8ed54f058475bbc052728dc678dd81d3f94","user":{"login":"anandsadu","id":13962113,"avatar_url":"https://avatars.githubusercontent.com/u/13962113?v=3","gravatar_id":"","url":"https://api.github.com/users/anandsadu","html_url":"https://github.com/anandsadu","followers_url":"https://api.github.com/users/anandsadu/followers","following_url":"https://api.github.com/users/anandsadu/following{/other_user}","gists_url":"https://api.github.com/users/anandsadu/gists{/gist_id}","starred_url":"https://api.github.com/users/anandsadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandsadu/subscriptions","organizations_url":"https://api.github.com/users/anandsadu/orgs","repos_url":"https://api.github.com/users/anandsadu/repos","events_url":"https://api.github.com/users/anandsadu/events{/privacy}","received_events_url":"https://api.github.com/users/anandsadu/received_events","type":"User","site_admin":false},"repo":{"id":51366780,"name":"appium-android-driver","full_name":"anandsadu/appium-android-driver","owner":{"login":"anandsadu","id":13962113,"avatar_url":"https://avatars.githubusercontent.com/u/13962113?v=3","gravatar_id":"","url":"https://api.github.com/users/anandsadu","html_url":"https://github.com/anandsadu","followers_url":"https://api.github.com/users/anandsadu/followers","following_url":"https://api.github.com/users/anandsadu/following{/other_user}","gists_url":"https://api.github.com/users/anandsadu/gists{/gist_id}","starred_url":"https://api.github.com/users/anandsadu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anandsadu/subscriptions","organizations_url":"https://api.github.com/users/anandsadu/orgs","repos_url":"https://api.github.com/users/anandsadu/repos","events_url":"https://api.github.com/users/anandsadu/events{/privacy}","received_events_url":"https://api.github.com/users/anandsadu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anandsadu/appium-android-driver","description":"Android Driver for Appium","fork":true,"url":"https://api.github.com/repos/anandsadu/appium-android-driver","forks_url":"https://api.github.com/repos/anandsadu/appium-android-driver/forks","keys_url":"https://api.github.com/repos/anandsadu/appium-android-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anandsadu/appium-android-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anandsadu/appium-android-driver/teams","hooks_url":"https://api.github.com/repos/anandsadu/appium-android-driver/hooks","issue_events_url":"https://api.github.com/repos/anandsadu/appium-android-driver/issues/events{/number}","events_url":"https://api.github.com/repos/anandsadu/appium-android-driver/events","assignees_url":"https://api.github.com/repos/anandsadu/appium-android-driver/assignees{/user}","branches_url":"https://api.github.com/repos/anandsadu/appium-android-driver/branches{/branch}","tags_url":"https://api.github.com/repos/anandsadu/appium-android-driver/tags","blobs_url":"https://api.github.com/repos/anandsadu/appium-android-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anandsadu/appium-android-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anandsadu/appium-android-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/anandsadu/appium-android-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anandsadu/appium-android-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/anandsadu/appium-android-driver/languages","stargazers_url":"https://api.github.com/repos/anandsadu/appium-android-driver/stargazers","contributors_url":"https://api.github.com/repos/anandsadu/appium-android-driver/contributors","subscribers_url":"https://api.github.com/repos/anandsadu/appium-android-driver/subscribers","subscription_url":"https://api.github.com/repos/anandsadu/appium-android-driver/subscription","commits_url":"https://api.github.com/repos/anandsadu/appium-android-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/anandsadu/appium-android-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/anandsadu/appium-android-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/anandsadu/appium-android-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/anandsadu/appium-android-driver/contents/{+path}","compare_url":"https://api.github.com/repos/anandsadu/appium-android-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anandsadu/appium-android-driver/merges","archive_url":"https://api.github.com/repos/anandsadu/appium-android-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anandsadu/appium-android-driver/downloads","issues_url":"https://api.github.com/repos/anandsadu/appium-android-driver/issues{/number}","pulls_url":"https://api.github.com/repos/anandsadu/appium-android-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/anandsadu/appium-android-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/anandsadu/appium-android-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anandsadu/appium-android-driver/labels{/name}","releases_url":"https://api.github.com/repos/anandsadu/appium-android-driver/releases{/id}","deployments_url":"https://api.github.com/repos/anandsadu/appium-android-driver/deployments","created_at":"2016-02-09T12:57:32Z","updated_at":"2016-02-09T12:57:33Z","pushed_at":"2016-02-09T13:27:41Z","git_url":"git://github.com/anandsadu/appium-android-driver.git","ssh_url":"git@github.com:anandsadu/appium-android-driver.git","clone_url":"https://github.com/anandsadu/appium-android-driver.git","svn_url":"https://github.com/anandsadu/appium-android-driver","homepage":null,"size":2420,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"e4ef65d5d799d932e72e8d2cb2b1b0d5d1103e58","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":39916403,"name":"appium-android-driver","full_name":"appium/appium-android-driver","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-android-driver","description":"Android Driver for Appium","fork":false,"url":"https://api.github.com/repos/appium/appium-android-driver","forks_url":"https://api.github.com/repos/appium/appium-android-driver/forks","keys_url":"https://api.github.com/repos/appium/appium-android-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-android-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-android-driver/teams","hooks_url":"https://api.github.com/repos/appium/appium-android-driver/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-android-driver/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-android-driver/events","assignees_url":"https://api.github.com/repos/appium/appium-android-driver/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-android-driver/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-android-driver/tags","blobs_url":"https://api.github.com/repos/appium/appium-android-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-android-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-android-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-android-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-android-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-android-driver/languages","stargazers_url":"https://api.github.com/repos/appium/appium-android-driver/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-android-driver/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-android-driver/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-android-driver/subscription","commits_url":"https://api.github.com/repos/appium/appium-android-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-android-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-android-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-android-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-android-driver/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-android-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-android-driver/merges","archive_url":"https://api.github.com/repos/appium/appium-android-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-android-driver/downloads","issues_url":"https://api.github.com/repos/appium/appium-android-driver/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-android-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-android-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-android-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-android-driver/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-android-driver/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-android-driver/deployments","created_at":"2015-07-29T21:07:42Z","updated_at":"2016-01-22T17:16:47Z","pushed_at":"2016-02-09T13:35:46Z","git_url":"git://github.com/appium/appium-android-driver.git","ssh_url":"git@github.com:appium/appium-android-driver.git","clone_url":"https://github.com/appium/appium-android-driver.git","svn_url":"https://github.com/appium/appium-android-driver","homepage":null,"size":2427,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-android-driver/pulls/95"},"html":{"href":"https://github.com/appium/appium-android-driver/pull/95"},"issue":{"href":"https://api.github.com/repos/appium/appium-android-driver/issues/95"},"comments":{"href":"https://api.github.com/repos/appium/appium-android-driver/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-android-driver/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-android-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-android-driver/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-android-driver/statuses/1e02c8ed54f058475bbc052728dc678dd81d3f94"}}}}