{"action":"created","issue":{"url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/13","repository_url":"https://api.github.com/repos/TechFortress/GriefPrevention","labels_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/13/comments","events_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/13/events","html_url":"https://github.com/TechFortress/GriefPrevention/issues/13","id":180179959,"number":13,"title":"Failures of portal trap rescue system wasting players' time","user":{"login":"Jikoo","id":1353270,"avatar_url":"https://avatars.githubusercontent.com/u/1353270?v=3","gravatar_id":"","url":"https://api.github.com/users/Jikoo","html_url":"https://github.com/Jikoo","followers_url":"https://api.github.com/users/Jikoo/followers","following_url":"https://api.github.com/users/Jikoo/following{/other_user}","gists_url":"https://api.github.com/users/Jikoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jikoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jikoo/subscriptions","organizations_url":"https://api.github.com/users/Jikoo/orgs","repos_url":"https://api.github.com/users/Jikoo/repos","events_url":"https://api.github.com/users/Jikoo/events{/privacy}","received_events_url":"https://api.github.com/users/Jikoo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TechFortress/GriefPrevention/labels/Improvement","name":"Improvement","color":"b60205"}],"state":"open","locked":false,"assignee":{"login":"RoboMWM","id":4625696,"avatar_url":"https://avatars.githubusercontent.com/u/4625696?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboMWM","html_url":"https://github.com/RoboMWM","followers_url":"https://api.github.com/users/RoboMWM/followers","following_url":"https://api.github.com/users/RoboMWM/following{/other_user}","gists_url":"https://api.github.com/users/RoboMWM/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboMWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboMWM/subscriptions","organizations_url":"https://api.github.com/users/RoboMWM/orgs","repos_url":"https://api.github.com/users/RoboMWM/repos","events_url":"https://api.github.com/users/RoboMWM/events{/privacy}","received_events_url":"https://api.github.com/users/RoboMWM/received_events","type":"User","site_admin":false},"assignees":[{"login":"RoboMWM","id":4625696,"avatar_url":"https://avatars.githubusercontent.com/u/4625696?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboMWM","html_url":"https://github.com/RoboMWM","followers_url":"https://api.github.com/users/RoboMWM/followers","following_url":"https://api.github.com/users/RoboMWM/following{/other_user}","gists_url":"https://api.github.com/users/RoboMWM/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboMWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboMWM/subscriptions","organizations_url":"https://api.github.com/users/RoboMWM/orgs","repos_url":"https://api.github.com/users/RoboMWM/repos","events_url":"https://api.github.com/users/RoboMWM/events{/privacy}","received_events_url":"https://api.github.com/users/RoboMWM/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/TechFortress/GriefPrevention/milestones/1","html_url":"https://github.com/TechFortress/GriefPrevention/milestones/15.3","labels_url":"https://api.github.com/repos/TechFortress/GriefPrevention/milestones/1/labels","id":2039018,"number":1,"title":"15.3","description":null,"creator":{"login":"RoboMWM","id":4625696,"avatar_url":"https://avatars.githubusercontent.com/u/4625696?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboMWM","html_url":"https://github.com/RoboMWM","followers_url":"https://api.github.com/users/RoboMWM/followers","following_url":"https://api.github.com/users/RoboMWM/following{/other_user}","gists_url":"https://api.github.com/users/RoboMWM/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboMWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboMWM/subscriptions","organizations_url":"https://api.github.com/users/RoboMWM/orgs","repos_url":"https://api.github.com/users/RoboMWM/repos","events_url":"https://api.github.com/users/RoboMWM/events{/privacy}","received_events_url":"https://api.github.com/users/RoboMWM/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-09-30T00:21:56Z","updated_at":"2016-09-30T00:25:51Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2016-09-29T22:33:08Z","updated_at":"2016-10-01T18:50:56Z","closed_at":null,"body":"The portal trap feature, while very nice, is causing my players a bit of grief by considering them trapped and \"rescuing\" when they're attempting to enter a different portal.\r\nEx.: Player enters the nether from a portal at 100, 50, 100 and walks to a portal at 100, 50, -100. This takes a minute, so while they wait in the next portal to be teleported, they are rescued back to their original entry point.\r\n\r\nAt first, I was going to propose that you use a method to find the center of the portal from the block used to teleport. Then, simply compare the current portal's center to the original portal's center, rescuing if it matches. Unfortunately, it would not properly handle hallways built of portals - build 2 or more portals staggered or of different sizes next to each other, and the functionality potentially breaks down.\r\n\r\nInstead, I propose that GP's portal trap rescue be converted to a 2-task system:\r\n\r\n1. First task is started when a player passes through a portal.\r\n2. Original task completes. If player is not in a portal, return.\r\n3. Warn the player that they will be rescued if they are in a portal in 5 seconds.\r\n4. Start a new timer to do the actual rescuing.\r\n\r\nIn addition, either task, if scheduled, should be cancelled if the player travels through a portal - I've been rescued back to the overworld in a different location when attempting to re-enter the nether.\r\n\r\nI'm very hesitant to fiddle with GP as it's always been riddled with practice I dislike, but if I need to do it to make this happen I'd be willing to open a PR."},"comment":{"url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/comments/250929937","html_url":"https://github.com/TechFortress/GriefPrevention/issues/13#issuecomment-250929937","issue_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/13","id":250929937,"user":{"login":"RoboMWM","id":4625696,"avatar_url":"https://avatars.githubusercontent.com/u/4625696?v=3","gravatar_id":"","url":"https://api.github.com/users/RoboMWM","html_url":"https://github.com/RoboMWM","followers_url":"https://api.github.com/users/RoboMWM/followers","following_url":"https://api.github.com/users/RoboMWM/following{/other_user}","gists_url":"https://api.github.com/users/RoboMWM/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboMWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboMWM/subscriptions","organizations_url":"https://api.github.com/users/RoboMWM/orgs","repos_url":"https://api.github.com/users/RoboMWM/repos","events_url":"https://api.github.com/users/RoboMWM/events{/privacy}","received_events_url":"https://api.github.com/users/RoboMWM/received_events","type":"User","site_admin":false},"created_at":"2016-10-01T18:50:55Z","updated_at":"2016-10-01T18:50:55Z","body":"Hmm, should be canceled here: https://github.com/TechFortress/GriefPrevention/blob/master/src/me/ryanhamshire/GriefPrevention/GriefPrevention.java#L3674\r\n\r\nOtherwise wouldn't it be trying to rescue you twice? I also wonder if it has anything to do with you being in creative... I only tested in survival gamemode.\r\n\r\nUnless the hashmap `put` method doesn't override an existing entry (I'm under the assumption it does)..."}}
{"actor":{"display_login":"RoboMWM"}}