{"action":"closed","issue":{"url":"https://api.github.com/repos/omeka/omeka-s/issues/771","repository_url":"https://api.github.com/repos/omeka/omeka-s","labels_url":"https://api.github.com/repos/omeka/omeka-s/issues/771/labels{/name}","comments_url":"https://api.github.com/repos/omeka/omeka-s/issues/771/comments","events_url":"https://api.github.com/repos/omeka/omeka-s/issues/771/events","html_url":"https://github.com/omeka/omeka-s/issues/771","id":183150861,"number":771,"title":"Form error flashes need to give more information","user":{"login":"zerocrates","id":298975,"avatar_url":"https://avatars.githubusercontent.com/u/298975?v=3","gravatar_id":"","url":"https://api.github.com/users/zerocrates","html_url":"https://github.com/zerocrates","followers_url":"https://api.github.com/users/zerocrates/followers","following_url":"https://api.github.com/users/zerocrates/following{/other_user}","gists_url":"https://api.github.com/users/zerocrates/gists{/gist_id}","starred_url":"https://api.github.com/users/zerocrates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerocrates/subscriptions","organizations_url":"https://api.github.com/users/zerocrates/orgs","repos_url":"https://api.github.com/users/zerocrates/repos","events_url":"https://api.github.com/users/zerocrates/events{/privacy}","received_events_url":"https://api.github.com/users/zerocrates/received_events","type":"User","site_admin":false},"labels":[{"id":193941571,"url":"https://api.github.com/repos/omeka/omeka-s/labels/bug","name":"bug","color":"e11d21","default":true}],"state":"closed","locked":false,"assignee":{"login":"jimsafley","id":141955,"avatar_url":"https://avatars.githubusercontent.com/u/141955?v=3","gravatar_id":"","url":"https://api.github.com/users/jimsafley","html_url":"https://github.com/jimsafley","followers_url":"https://api.github.com/users/jimsafley/followers","following_url":"https://api.github.com/users/jimsafley/following{/other_user}","gists_url":"https://api.github.com/users/jimsafley/gists{/gist_id}","starred_url":"https://api.github.com/users/jimsafley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimsafley/subscriptions","organizations_url":"https://api.github.com/users/jimsafley/orgs","repos_url":"https://api.github.com/users/jimsafley/repos","events_url":"https://api.github.com/users/jimsafley/events{/privacy}","received_events_url":"https://api.github.com/users/jimsafley/received_events","type":"User","site_admin":false},"assignees":[{"login":"jimsafley","id":141955,"avatar_url":"https://avatars.githubusercontent.com/u/141955?v=3","gravatar_id":"","url":"https://api.github.com/users/jimsafley","html_url":"https://github.com/jimsafley","followers_url":"https://api.github.com/users/jimsafley/followers","following_url":"https://api.github.com/users/jimsafley/following{/other_user}","gists_url":"https://api.github.com/users/jimsafley/gists{/gist_id}","starred_url":"https://api.github.com/users/jimsafley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimsafley/subscriptions","organizations_url":"https://api.github.com/users/jimsafley/orgs","repos_url":"https://api.github.com/users/jimsafley/repos","events_url":"https://api.github.com/users/jimsafley/events{/privacy}","received_events_url":"https://api.github.com/users/jimsafley/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/omeka/omeka-s/milestones/38","html_url":"https://github.com/omeka/omeka-s/milestones/November%207","labels_url":"https://api.github.com/repos/omeka/omeka-s/milestones/38/labels","id":2090187,"number":38,"title":"November 7","description":"","creator":{"login":"zerocrates","id":298975,"avatar_url":"https://avatars.githubusercontent.com/u/298975?v=3","gravatar_id":"","url":"https://api.github.com/users/zerocrates","html_url":"https://github.com/zerocrates","followers_url":"https://api.github.com/users/zerocrates/followers","following_url":"https://api.github.com/users/zerocrates/following{/other_user}","gists_url":"https://api.github.com/users/zerocrates/gists{/gist_id}","starred_url":"https://api.github.com/users/zerocrates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerocrates/subscriptions","organizations_url":"https://api.github.com/users/zerocrates/orgs","repos_url":"https://api.github.com/users/zerocrates/repos","events_url":"https://api.github.com/users/zerocrates/events{/privacy}","received_events_url":"https://api.github.com/users/zerocrates/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":17,"state":"open","created_at":"2016-10-24T18:06:49Z","updated_at":"2016-11-01T17:16:12Z","due_on":"2016-11-07T00:00:00Z","closed_at":null},"comments":0,"created_at":"2016-10-14T21:08:49Z","updated_at":"2016-11-01T17:16:12Z","closed_at":"2016-11-01T17:16:12Z","body":"If the CSRF is missing from a form, the flashed error is just \"Value is required and can't be empty\", with no reference to what it refers to.\n\nThis is a step up from before when we improved the error printing, because at least the message is visible in the first place, but we should probably try to use the context provided in the form error messages (in this case, the keys) to make the flashed error better.\n\nWhere the form element is visible it's not as big of a deal because we can also show the error next to the appropriate element, but for hidden elements it's a fairly big problem, not just for users but also for quick diagnosis of problems.\n\nIf we wanted to get really fancy, we could try to rig up something where we actually look up the element in the form and use its configured label in the flash message. Otherwise we're stuck with trying to capitalize and \"niceify\" a non-user-readable ID string.\n"}}
{"actor":{"display_login":"zerocrates"}}