{"action":"opened","number":841,"pull_request":{"url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/841","id":92740006,"html_url":"https://github.com/OfficeDev/PnP-Sites-Core/pull/841","diff_url":"https://github.com/OfficeDev/PnP-Sites-Core/pull/841.diff","patch_url":"https://github.com/OfficeDev/PnP-Sites-Core/pull/841.patch","issue_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues/841","number":841,"state":"open","locked":false,"title":"Possible fix to issue #754","user":{"login":"luismanez","id":9392197,"avatar_url":"https://avatars.githubusercontent.com/u/9392197?v=3","gravatar_id":"","url":"https://api.github.com/users/luismanez","html_url":"https://github.com/luismanez","followers_url":"https://api.github.com/users/luismanez/followers","following_url":"https://api.github.com/users/luismanez/following{/other_user}","gists_url":"https://api.github.com/users/luismanez/gists{/gist_id}","starred_url":"https://api.github.com/users/luismanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luismanez/subscriptions","organizations_url":"https://api.github.com/users/luismanez/orgs","repos_url":"https://api.github.com/users/luismanez/repos","events_url":"https://api.github.com/users/luismanez/events{/privacy}","received_events_url":"https://api.github.com/users/luismanez/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| New sample?      | no\r\n| Related issues?  | fixes #754 \r\n\r\n#### What's in this Pull Request?\r\n\r\nThis PR adds a possible fix to issue #754 \r\nHowever, there is a use case that the Engine cannot cover regarding export/import of Content Query WebParts: \r\nWhen the CQWP is in the root site, and is pointing to a subsite web, the property would be:\r\n\r\n```xml\r\n<property name=\"WebUrl\" type=\"string\">~sitecollection/subsite</property>\r\n```\r\n\r\nAs we are exporting the root site, and the CQWP is pointing to a subsite that won't exist when importing the template to the new site, this fix won't work (current code without this fix won't work either). I'm afraid we can't cover that use case anyway, as it depends on a subsite.\r\n\r\nHowever, if we are exporting a CQWP in a subsite, that is pointing to the same subsite, this fix will work, as it will replace:\r\n\r\n```xml\r\n<property name=\"WebUrl\" type=\"string\">~sitecollection/subsite</property>\r\n```\r\n\r\nby\r\n\r\n```xml\r\n<property name=\"WebUrl\" type=\"string\">{site}</property>\r\n```\r\n\r\nand it will be pointing to the same subsite, when the template is imported to a new subsite.\r\n\r\nHope it makes sense. Leave any question here.\r\n\r\n/cc @PieterVeenstra @VesaJuvonen ","created_at":"2016-11-08T09:15:13Z","updated_at":"2016-11-08T09:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/841/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/841/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues/841/comments","statuses_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/statuses/e45e3e08dce79d116966bd7c5be07e7821a37f02","head":{"label":"luismanez:luismanez","ref":"luismanez","sha":"e45e3e08dce79d116966bd7c5be07e7821a37f02","user":{"login":"luismanez","id":9392197,"avatar_url":"https://avatars.githubusercontent.com/u/9392197?v=3","gravatar_id":"","url":"https://api.github.com/users/luismanez","html_url":"https://github.com/luismanez","followers_url":"https://api.github.com/users/luismanez/followers","following_url":"https://api.github.com/users/luismanez/following{/other_user}","gists_url":"https://api.github.com/users/luismanez/gists{/gist_id}","starred_url":"https://api.github.com/users/luismanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luismanez/subscriptions","organizations_url":"https://api.github.com/users/luismanez/orgs","repos_url":"https://api.github.com/users/luismanez/repos","events_url":"https://api.github.com/users/luismanez/events{/privacy}","received_events_url":"https://api.github.com/users/luismanez/received_events","type":"User","site_admin":false},"repo":{"id":45542445,"name":"PnP-Sites-Core","full_name":"luismanez/PnP-Sites-Core","owner":{"login":"luismanez","id":9392197,"avatar_url":"https://avatars.githubusercontent.com/u/9392197?v=3","gravatar_id":"","url":"https://api.github.com/users/luismanez","html_url":"https://github.com/luismanez","followers_url":"https://api.github.com/users/luismanez/followers","following_url":"https://api.github.com/users/luismanez/following{/other_user}","gists_url":"https://api.github.com/users/luismanez/gists{/gist_id}","starred_url":"https://api.github.com/users/luismanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luismanez/subscriptions","organizations_url":"https://api.github.com/users/luismanez/orgs","repos_url":"https://api.github.com/users/luismanez/repos","events_url":"https://api.github.com/users/luismanez/events{/privacy}","received_events_url":"https://api.github.com/users/luismanez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luismanez/PnP-Sites-Core","description":"New location for the Office 365 Dev PnP Core component. ","fork":true,"url":"https://api.github.com/repos/luismanez/PnP-Sites-Core","forks_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/forks","keys_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/teams","hooks_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/hooks","issue_events_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/issues/events{/number}","events_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/events","assignees_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/assignees{/user}","branches_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/branches{/branch}","tags_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/tags","blobs_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/languages","stargazers_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/stargazers","contributors_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/contributors","subscribers_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/subscribers","subscription_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/subscription","commits_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/contents/{+path}","compare_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/merges","archive_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/downloads","issues_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/issues{/number}","pulls_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/labels{/name}","releases_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/releases{/id}","deployments_url":"https://api.github.com/repos/luismanez/PnP-Sites-Core/deployments","created_at":"2015-11-04T14:00:10Z","updated_at":"2016-02-11T07:19:16Z","pushed_at":"2016-11-08T09:00:11Z","git_url":"git://github.com/luismanez/PnP-Sites-Core.git","ssh_url":"git@github.com:luismanez/PnP-Sites-Core.git","clone_url":"https://github.com/luismanez/PnP-Sites-Core.git","svn_url":"https://github.com/luismanez/PnP-Sites-Core","homepage":"","size":23500,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:dev","ref":"dev","sha":"8567ee7addfabb93e489a513a8f111118df9afe8","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":39578237,"name":"PnP-Sites-Core","full_name":"OfficeDev/PnP-Sites-Core","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/PnP-Sites-Core","description":"Office 365 Dev PnP Core component (.NET) targeted for increasing developer productivity with CSOM based solutions.","fork":false,"url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core","forks_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/forks","keys_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/teams","hooks_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/events","assignees_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/tags","blobs_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/subscription","commits_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/merges","archive_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/downloads","issues_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/deployments","created_at":"2015-07-23T16:23:48Z","updated_at":"2016-11-05T00:17:27Z","pushed_at":"2016-11-08T09:15:13Z","git_url":"git://github.com/OfficeDev/PnP-Sites-Core.git","ssh_url":"git@github.com:OfficeDev/PnP-Sites-Core.git","clone_url":"https://github.com/OfficeDev/PnP-Sites-Core.git","svn_url":"https://github.com/OfficeDev/PnP-Sites-Core","homepage":"","size":27564,"stargazers_count":89,"watchers_count":89,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":182,"forks":292,"open_issues":182,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/841"},"html":{"href":"https://github.com/OfficeDev/PnP-Sites-Core/pull/841"},"issue":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues/841"},"comments":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/PnP-Sites-Core/statuses/e45e3e08dce79d116966bd7c5be07e7821a37f02"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"luismanez"}}