{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/comments/71068891","id":71068891,"diff_hunk":"@@ -44,11 +48,20 @@ private Statement statement(final Statement base) {\n             @Override\n             public void evaluate() throws Throwable {\n                 before();\n+\n+                List<Throwable> errors = new ArrayList<Throwable>();\n                 try {\n                     base.evaluate();\n+                } catch(Throwable t) {\n+                    errors.add(t);\n                 } finally {\n-                    after();\n+                    try {\n+                        after();\n+                    } catch(Throwable t) {","path":"src/main/java/org/junit/rules/ExternalResource.java","position":25,"original_position":25,"commit_id":"ddda99c0396a6f011dc27250ad60836c0c520d7e","original_commit_id":"ddda99c0396a6f011dc27250ad60836c0c520d7e","user":{"login":"kcooney","id":478190,"avatar_url":"https://avatars.githubusercontent.com/u/478190?v=3","gravatar_id":"","url":"https://api.github.com/users/kcooney","html_url":"https://github.com/kcooney","followers_url":"https://api.github.com/users/kcooney/followers","following_url":"https://api.github.com/users/kcooney/following{/other_user}","gists_url":"https://api.github.com/users/kcooney/gists{/gist_id}","starred_url":"https://api.github.com/users/kcooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcooney/subscriptions","organizations_url":"https://api.github.com/users/kcooney/orgs","repos_url":"https://api.github.com/users/kcooney/repos","events_url":"https://api.github.com/users/kcooney/events{/privacy}","received_events_url":"https://api.github.com/users/kcooney/received_events","type":"User","site_admin":false},"body":"same issue here, too","created_at":"2016-07-16T17:02:49Z","updated_at":"2016-07-16T17:02:49Z","html_url":"https://github.com/junit-team/junit4/pull/1335#discussion_r71068891","pull_request_url":"https://api.github.com/repos/junit-team/junit4/pulls/1335","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments/71068891"},"html":{"href":"https://github.com/junit-team/junit4/pull/1335#discussion_r71068891"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1335"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/1335","id":75531289,"html_url":"https://github.com/junit-team/junit4/pull/1335","diff_url":"https://github.com/junit-team/junit4/pull/1335.diff","patch_url":"https://github.com/junit-team/junit4/pull/1335.patch","issue_url":"https://api.github.com/repos/junit-team/junit4/issues/1335","number":1335,"state":"open","locked":false,"title":"Fix ExternalResource: the test failure was lost..","user":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"body":".. when the test failed *and* closing the resource failed:\r\nonly the exception coming from the after() method was propagated, as per semantics of the try-finally\r\n(see http://docs.oracle.com/javase/specs/jls/se8/html/jls-14.html#jls-14.20.2).\r\n\r\nFinally, the new behavior is compatible with `@After` method semantics (see class RunAfters).\r\n\r\nFixes #1334, point 1.","created_at":"2016-06-28T18:58:13Z","updated_at":"2016-07-16T17:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b30df5599227a52700cbb73de2ea55f4a0acbc2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit4/pulls/1335/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit4/pulls/1335/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit4/issues/1335/comments","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/ddda99c0396a6f011dc27250ad60836c0c520d7e","head":{"label":"alb-i986:fix-ExternalResource-test-failure-lost","ref":"fix-ExternalResource-test-failure-lost","sha":"ddda99c0396a6f011dc27250ad60836c0c520d7e","user":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"repo":{"id":25947132,"name":"junit","full_name":"alb-i986/junit","owner":{"login":"alb-i986","id":2717169,"avatar_url":"https://avatars.githubusercontent.com/u/2717169?v=3","gravatar_id":"","url":"https://api.github.com/users/alb-i986","html_url":"https://github.com/alb-i986","followers_url":"https://api.github.com/users/alb-i986/followers","following_url":"https://api.github.com/users/alb-i986/following{/other_user}","gists_url":"https://api.github.com/users/alb-i986/gists{/gist_id}","starred_url":"https://api.github.com/users/alb-i986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alb-i986/subscriptions","organizations_url":"https://api.github.com/users/alb-i986/orgs","repos_url":"https://api.github.com/users/alb-i986/repos","events_url":"https://api.github.com/users/alb-i986/events{/privacy}","received_events_url":"https://api.github.com/users/alb-i986/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alb-i986/junit","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/alb-i986/junit","forks_url":"https://api.github.com/repos/alb-i986/junit/forks","keys_url":"https://api.github.com/repos/alb-i986/junit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alb-i986/junit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alb-i986/junit/teams","hooks_url":"https://api.github.com/repos/alb-i986/junit/hooks","issue_events_url":"https://api.github.com/repos/alb-i986/junit/issues/events{/number}","events_url":"https://api.github.com/repos/alb-i986/junit/events","assignees_url":"https://api.github.com/repos/alb-i986/junit/assignees{/user}","branches_url":"https://api.github.com/repos/alb-i986/junit/branches{/branch}","tags_url":"https://api.github.com/repos/alb-i986/junit/tags","blobs_url":"https://api.github.com/repos/alb-i986/junit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alb-i986/junit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alb-i986/junit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alb-i986/junit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alb-i986/junit/statuses/{sha}","languages_url":"https://api.github.com/repos/alb-i986/junit/languages","stargazers_url":"https://api.github.com/repos/alb-i986/junit/stargazers","contributors_url":"https://api.github.com/repos/alb-i986/junit/contributors","subscribers_url":"https://api.github.com/repos/alb-i986/junit/subscribers","subscription_url":"https://api.github.com/repos/alb-i986/junit/subscription","commits_url":"https://api.github.com/repos/alb-i986/junit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alb-i986/junit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alb-i986/junit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alb-i986/junit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alb-i986/junit/contents/{+path}","compare_url":"https://api.github.com/repos/alb-i986/junit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alb-i986/junit/merges","archive_url":"https://api.github.com/repos/alb-i986/junit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alb-i986/junit/downloads","issues_url":"https://api.github.com/repos/alb-i986/junit/issues{/number}","pulls_url":"https://api.github.com/repos/alb-i986/junit/pulls{/number}","milestones_url":"https://api.github.com/repos/alb-i986/junit/milestones{/number}","notifications_url":"https://api.github.com/repos/alb-i986/junit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alb-i986/junit/labels{/name}","releases_url":"https://api.github.com/repos/alb-i986/junit/releases{/id}","deployments_url":"https://api.github.com/repos/alb-i986/junit/deployments","created_at":"2014-10-30T00:07:33Z","updated_at":"2016-02-10T13:08:04Z","pushed_at":"2016-07-12T21:11:50Z","git_url":"git://github.com/alb-i986/junit.git","ssh_url":"git@github.com:alb-i986/junit.git","clone_url":"https://github.com/alb-i986/junit.git","svn_url":"https://github.com/alb-i986/junit","homepage":"","size":8062,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"4c0c7876d8b1010e949a885702721e30300eb56e","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit4","full_name":"junit-team/junit4","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit4","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit4","forks_url":"https://api.github.com/repos/junit-team/junit4/forks","keys_url":"https://api.github.com/repos/junit-team/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit4/teams","hooks_url":"https://api.github.com/repos/junit-team/junit4/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit4/events","assignees_url":"https://api.github.com/repos/junit-team/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit4/tags","blobs_url":"https://api.github.com/repos/junit-team/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit4/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit4/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit4/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit4/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit4/subscription","commits_url":"https://api.github.com/repos/junit-team/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit4/merges","archive_url":"https://api.github.com/repos/junit-team/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit4/downloads","issues_url":"https://api.github.com/repos/junit-team/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit4/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit4/deployments","created_at":"2009-01-13T03:41:26Z","updated_at":"2016-07-16T13:07:59Z","pushed_at":"2016-07-16T14:30:59Z","git_url":"git://github.com/junit-team/junit4.git","ssh_url":"git@github.com:junit-team/junit4.git","clone_url":"https://github.com/junit-team/junit4.git","svn_url":"https://github.com/junit-team/junit4","homepage":"http://junit.org/junit4/","size":36809,"stargazers_count":5050,"watchers_count":5050,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1989,"mirror_url":null,"open_issues_count":180,"forks":1989,"open_issues":180,"watchers":5050,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1335"},"html":{"href":"https://github.com/junit-team/junit4/pull/1335"},"issue":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1335"},"comments":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1335/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1335/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1335/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit4/statuses/ddda99c0396a6f011dc27250ad60836c0c520d7e"}}}}
{"actor":{"display_login":"kcooney"}}