{"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/82454439","pull_request_review_id":3363771,"id":82454439,"diff_hunk":"@@ -0,0 +1,15 @@\n+#ifndef __MESON_EXPORTS__","path":"test cases/common/62 exe static shared/subdir/exports.h","position":1,"original_position":1,"commit_id":"336172f8b6ec57d68aa482443b026263d5d56941","original_commit_id":"336172f8b6ec57d68aa482443b026263d5d56941","user":{"login":"jpakkane","id":4079821,"avatar_url":"https://avatars.githubusercontent.com/u/4079821?v=3","gravatar_id":"","url":"https://api.github.com/users/jpakkane","html_url":"https://github.com/jpakkane","followers_url":"https://api.github.com/users/jpakkane/followers","following_url":"https://api.github.com/users/jpakkane/following{/other_user}","gists_url":"https://api.github.com/users/jpakkane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpakkane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpakkane/subscriptions","organizations_url":"https://api.github.com/users/jpakkane/orgs","repos_url":"https://api.github.com/users/jpakkane/repos","events_url":"https://api.github.com/users/jpakkane/events{/privacy}","received_events_url":"https://api.github.com/users/jpakkane/received_events","type":"User","site_admin":false},"body":"The C and C++ standards reserve all preprocessor tokens that start with one or two underscores to the stdlib, so this is undefined behaviour. Please rename or, better yet, use `pragma once`.","created_at":"2016-10-07T19:25:27Z","updated_at":"2016-10-07T19:25:27Z","html_url":"https://github.com/mesonbuild/meson/pull/856#discussion_r82454439","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/856","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/82454439"},"html":{"href":"https://github.com/mesonbuild/meson/pull/856#discussion_r82454439"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/856","id":88053721,"html_url":"https://github.com/mesonbuild/meson/pull/856","diff_url":"https://github.com/mesonbuild/meson/pull/856.diff","patch_url":"https://github.com/mesonbuild/meson/pull/856.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/856","number":856,"state":"open","locked":false,"title":"Add cross-platform PIC support for static libraries","user":{"login":"nirbheek","id":75801,"avatar_url":"https://avatars.githubusercontent.com/u/75801?v=3","gravatar_id":"","url":"https://api.github.com/users/nirbheek","html_url":"https://github.com/nirbheek","followers_url":"https://api.github.com/users/nirbheek/followers","following_url":"https://api.github.com/users/nirbheek/following{/other_user}","gists_url":"https://api.github.com/users/nirbheek/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbheek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbheek/subscriptions","organizations_url":"https://api.github.com/users/nirbheek/orgs","repos_url":"https://api.github.com/users/nirbheek/repos","events_url":"https://api.github.com/users/nirbheek/events{/privacy}","received_events_url":"https://api.github.com/users/nirbheek/received_events","type":"User","site_admin":false},"body":"With C/C++, on Windows you don't need to pass any arguments for a static library to be PIC. On UNIX platforms you need to pass `-fPIC`.\r\n\r\nOther languages such as D have compiler-specific PIC arguments required for PIC support in static libraries on UNIX platforms.\r\n\r\nThis kwarg allows people to specify which static libraries should be built with PIC support. This is usually used for static libraries that will be linked into shared libraries.","created_at":"2016-10-05T10:38:06Z","updated_at":"2016-10-07T19:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d33c617ef8fd69a3826f8f9b0ad1b07487d8e4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/856/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/856/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/856/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/336172f8b6ec57d68aa482443b026263d5d56941","head":{"label":"centricular:static_library_pic","ref":"static_library_pic","sha":"336172f8b6ec57d68aa482443b026263d5d56941","user":{"login":"centricular","id":16556870,"avatar_url":"https://avatars.githubusercontent.com/u/16556870?v=3","gravatar_id":"","url":"https://api.github.com/users/centricular","html_url":"https://github.com/centricular","followers_url":"https://api.github.com/users/centricular/followers","following_url":"https://api.github.com/users/centricular/following{/other_user}","gists_url":"https://api.github.com/users/centricular/gists{/gist_id}","starred_url":"https://api.github.com/users/centricular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centricular/subscriptions","organizations_url":"https://api.github.com/users/centricular/orgs","repos_url":"https://api.github.com/users/centricular/repos","events_url":"https://api.github.com/users/centricular/events{/privacy}","received_events_url":"https://api.github.com/users/centricular/received_events","type":"Organization","site_admin":false},"repo":{"id":54555921,"name":"meson","full_name":"centricular/meson","owner":{"login":"centricular","id":16556870,"avatar_url":"https://avatars.githubusercontent.com/u/16556870?v=3","gravatar_id":"","url":"https://api.github.com/users/centricular","html_url":"https://github.com/centricular","followers_url":"https://api.github.com/users/centricular/followers","following_url":"https://api.github.com/users/centricular/following{/other_user}","gists_url":"https://api.github.com/users/centricular/gists{/gist_id}","starred_url":"https://api.github.com/users/centricular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centricular/subscriptions","organizations_url":"https://api.github.com/users/centricular/orgs","repos_url":"https://api.github.com/users/centricular/repos","events_url":"https://api.github.com/users/centricular/events{/privacy}","received_events_url":"https://api.github.com/users/centricular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/centricular/meson","description":"The Meson Build System forked to bugfix MSVC support for GStreamer","fork":true,"url":"https://api.github.com/repos/centricular/meson","forks_url":"https://api.github.com/repos/centricular/meson/forks","keys_url":"https://api.github.com/repos/centricular/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/centricular/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/centricular/meson/teams","hooks_url":"https://api.github.com/repos/centricular/meson/hooks","issue_events_url":"https://api.github.com/repos/centricular/meson/issues/events{/number}","events_url":"https://api.github.com/repos/centricular/meson/events","assignees_url":"https://api.github.com/repos/centricular/meson/assignees{/user}","branches_url":"https://api.github.com/repos/centricular/meson/branches{/branch}","tags_url":"https://api.github.com/repos/centricular/meson/tags","blobs_url":"https://api.github.com/repos/centricular/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/centricular/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/centricular/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/centricular/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/centricular/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/centricular/meson/languages","stargazers_url":"https://api.github.com/repos/centricular/meson/stargazers","contributors_url":"https://api.github.com/repos/centricular/meson/contributors","subscribers_url":"https://api.github.com/repos/centricular/meson/subscribers","subscription_url":"https://api.github.com/repos/centricular/meson/subscription","commits_url":"https://api.github.com/repos/centricular/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/centricular/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/centricular/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/centricular/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/centricular/meson/contents/{+path}","compare_url":"https://api.github.com/repos/centricular/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/centricular/meson/merges","archive_url":"https://api.github.com/repos/centricular/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/centricular/meson/downloads","issues_url":"https://api.github.com/repos/centricular/meson/issues{/number}","pulls_url":"https://api.github.com/repos/centricular/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/centricular/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/centricular/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/centricular/meson/labels{/name}","releases_url":"https://api.github.com/repos/centricular/meson/releases{/id}","deployments_url":"https://api.github.com/repos/centricular/meson/deployments","created_at":"2016-03-23T11:53:48Z","updated_at":"2016-03-23T11:58:26Z","pushed_at":"2016-10-07T18:06:27Z","git_url":"git://github.com/centricular/meson.git","ssh_url":"git@github.com:centricular/meson.git","clone_url":"https://github.com/centricular/meson.git","svn_url":"https://github.com/centricular/meson","homepage":"","size":3959,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gst-msvc"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"3a12b7ef52083d6f5bd18b4dfcf56b8d3480a508","user":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2016-10-07T12:55:35Z","pushed_at":"2016-10-07T18:49:34Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":null,"size":4338,"stargazers_count":535,"watchers_count":535,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"open_issues_count":140,"forks":80,"open_issues":140,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/856"},"html":{"href":"https://github.com/mesonbuild/meson/pull/856"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/856"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/336172f8b6ec57d68aa482443b026263d5d56941"}}}}
{"actor":{"display_login":"jpakkane"}}