{"action":"created","issue":{"url":"https://api.github.com/repos/18F/openFEC-web-app/issues/1029","labels_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/1029/labels{/name}","comments_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/1029/comments","events_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/1029/events","html_url":"https://github.com/18F/openFEC-web-app/issues/1029","id":126240874,"number":1029,"title":"Make filter tags work for ranges","user":{"login":"noahmanger","id":1696495,"avatar_url":"https://avatars.githubusercontent.com/u/1696495?v=3","gravatar_id":"","url":"https://api.github.com/users/noahmanger","html_url":"https://github.com/noahmanger","followers_url":"https://api.github.com/users/noahmanger/followers","following_url":"https://api.github.com/users/noahmanger/following{/other_user}","gists_url":"https://api.github.com/users/noahmanger/gists{/gist_id}","starred_url":"https://api.github.com/users/noahmanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noahmanger/subscriptions","organizations_url":"https://api.github.com/users/noahmanger/orgs","repos_url":"https://api.github.com/users/noahmanger/repos","events_url":"https://api.github.com/users/noahmanger/events{/privacy}","received_events_url":"https://api.github.com/users/noahmanger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/18F/openFEC-web-app/labels/current-sprint","name":"current-sprint","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"jmcarp","id":1633460,"avatar_url":"https://avatars.githubusercontent.com/u/1633460?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-01-12T18:17:50Z","updated_at":"2016-01-13T00:33:07Z","closed_at":null,"body":"Filter tags need to show up correctly for range inputs. Currently, we have two types: money and time. \r\n\r\nHere's a proposal for how it would work for both:\r\n\r\n![tags](https://cloud.githubusercontent.com/assets/1696495/12272459/7154037c-b915-11e5-87db-fcceab3514a2.png)\r\n\r\nThe thing that I'm least sure about is how to handle an undefined min value, especially for date ranges. Do we set it to the min date we have in the data? The min date based on real world constraints (like when the FEC first started getting the data)? Or do we come up with a language solution that doesn't require defining a value? Looking to @jenniferthibault and @emileighoutlaw on this.\r\n\r\nAlso, in the case of the time filter where there's also radios, I think we should only generate tags for the actual dates, so that you don't see \"Current year\" as well as \"1/1/2016 - 12/31/2016\"."},"comment":{"url":"https://api.github.com/repos/18F/openFEC-web-app/issues/comments/171110980","html_url":"https://github.com/18F/openFEC-web-app/issues/1029#issuecomment-171110980","issue_url":"https://api.github.com/repos/18F/openFEC-web-app/issues/1029","id":171110980,"user":{"login":"jmcarp","id":1633460,"avatar_url":"https://avatars.githubusercontent.com/u/1633460?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T00:33:06Z","updated_at":"2016-01-13T00:33:06Z","body":"One issue that came up while talking to @noahmanger is how to handle the \"X\" button on filter tags with multiple values. Does closing the tag clear both fields? Do we allow users to clear one value or the other separately?\r\n\r\nI'm wondering if we might consider a simpler approach, such that each filter field gets its own closable filter tag:\r\n\r\nMin only: \">= $500\"\r\nMax only: \"<= $1000\"\r\nMin and max (two filters): \">= $500\" \"<= $1000\""}}