{"action":"created","comment":{"url":"https://api.github.com/repos/skippbox/kompose/pulls/comments/83237220","pull_request_review_id":4092448,"id":83237220,"diff_hunk":"@@ -36,14 +36,27 @@ type Compose struct {\n }\n \n // load environment variables from compose file\n-func loadEnvVars(e map[string]string) []kobject.EnvVar {\n+func loadEnvVars(envars []string) []kobject.EnvVar {\n \tenvs := []kobject.EnvVar{}\n-\tfor k, v := range e {\n+\tvar character string\n+\tfor _, e := range envars {\n+\t\t//FIXME:(tuna) if envvar string contains both = and :, then = will be first pick up. Consider the case: URL=http://examples.com\n+\t\tif strings.Contains(e, \"=\") {\n+\t\t\tcharacter = \"=\"\n+\t\t} else if strings.Contains(e, \":\") {\n+\t\t\tcharacter = \":\"\n+\t\t} else {\n+\t\t\tlogrus.Errorf(\"Invalid environment variable format, only : and = separators are supported\")","path":"pkg/loader/compose/compose.go","position":16,"original_position":16,"commit_id":"551df5f91b2c896fcaccd596ad562e7083b2a705","original_commit_id":"551df5f91b2c896fcaccd596ad562e7083b2a705","user":{"login":"kadel","id":57206,"avatar_url":"https://avatars.githubusercontent.com/u/57206?v=3","gravatar_id":"","url":"https://api.github.com/users/kadel","html_url":"https://github.com/kadel","followers_url":"https://api.github.com/users/kadel/followers","following_url":"https://api.github.com/users/kadel/following{/other_user}","gists_url":"https://api.github.com/users/kadel/gists{/gist_id}","starred_url":"https://api.github.com/users/kadel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadel/subscriptions","organizations_url":"https://api.github.com/users/kadel/orgs","repos_url":"https://api.github.com/users/kadel/repos","events_url":"https://api.github.com/users/kadel/events{/privacy}","received_events_url":"https://api.github.com/users/kadel/received_events","type":"User","site_admin":false},"body":"just variable name without `:` or `;` is also valid see: https://docs.docker.com/compose/compose-file/#/environment \r\nThis is something that we should also consider.","created_at":"2016-10-13T15:02:20Z","updated_at":"2016-10-13T15:15:47Z","html_url":"https://github.com/skippbox/kompose/pull/197#discussion_r83237220","pull_request_url":"https://api.github.com/repos/skippbox/kompose/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/skippbox/kompose/pulls/comments/83237220"},"html":{"href":"https://github.com/skippbox/kompose/pull/197#discussion_r83237220"},"pull_request":{"href":"https://api.github.com/repos/skippbox/kompose/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/skippbox/kompose/pulls/197","id":88685791,"html_url":"https://github.com/skippbox/kompose/pull/197","diff_url":"https://github.com/skippbox/kompose/pull/197.diff","patch_url":"https://github.com/skippbox/kompose/pull/197.patch","issue_url":"https://api.github.com/repos/skippbox/kompose/issues/197","number":197,"state":"open","locked":false,"title":"support both : and = as compose envvar separators","user":{"login":"ngtuna","id":1963463,"avatar_url":"https://avatars.githubusercontent.com/u/1963463?v=3","gravatar_id":"","url":"https://api.github.com/users/ngtuna","html_url":"https://github.com/ngtuna","followers_url":"https://api.github.com/users/ngtuna/followers","following_url":"https://api.github.com/users/ngtuna/following{/other_user}","gists_url":"https://api.github.com/users/ngtuna/gists{/gist_id}","starred_url":"https://api.github.com/users/ngtuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngtuna/subscriptions","organizations_url":"https://api.github.com/users/ngtuna/orgs","repos_url":"https://api.github.com/users/ngtuna/repos","events_url":"https://api.github.com/users/ngtuna/events{/privacy}","received_events_url":"https://api.github.com/users/ngtuna/received_events","type":"User","site_admin":false},"body":"fix #196 #173 ","created_at":"2016-10-10T15:43:38Z","updated_at":"2016-10-13T15:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9704eddd66387b429f2a7ca454e377ed9bcc1e18","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/skippbox/kompose/pulls/197/commits","review_comments_url":"https://api.github.com/repos/skippbox/kompose/pulls/197/comments","review_comment_url":"https://api.github.com/repos/skippbox/kompose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skippbox/kompose/issues/197/comments","statuses_url":"https://api.github.com/repos/skippbox/kompose/statuses/551df5f91b2c896fcaccd596ad562e7083b2a705","head":{"label":"ngtuna:envvar_colon","ref":"envvar_colon","sha":"551df5f91b2c896fcaccd596ad562e7083b2a705","user":{"login":"ngtuna","id":1963463,"avatar_url":"https://avatars.githubusercontent.com/u/1963463?v=3","gravatar_id":"","url":"https://api.github.com/users/ngtuna","html_url":"https://github.com/ngtuna","followers_url":"https://api.github.com/users/ngtuna/followers","following_url":"https://api.github.com/users/ngtuna/following{/other_user}","gists_url":"https://api.github.com/users/ngtuna/gists{/gist_id}","starred_url":"https://api.github.com/users/ngtuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngtuna/subscriptions","organizations_url":"https://api.github.com/users/ngtuna/orgs","repos_url":"https://api.github.com/users/ngtuna/repos","events_url":"https://api.github.com/users/ngtuna/events{/privacy}","received_events_url":"https://api.github.com/users/ngtuna/received_events","type":"User","site_admin":false},"repo":{"id":62289223,"name":"kompose","full_name":"ngtuna/kompose","owner":{"login":"ngtuna","id":1963463,"avatar_url":"https://avatars.githubusercontent.com/u/1963463?v=3","gravatar_id":"","url":"https://api.github.com/users/ngtuna","html_url":"https://github.com/ngtuna","followers_url":"https://api.github.com/users/ngtuna/followers","following_url":"https://api.github.com/users/ngtuna/following{/other_user}","gists_url":"https://api.github.com/users/ngtuna/gists{/gist_id}","starred_url":"https://api.github.com/users/ngtuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngtuna/subscriptions","organizations_url":"https://api.github.com/users/ngtuna/orgs","repos_url":"https://api.github.com/users/ngtuna/repos","events_url":"https://api.github.com/users/ngtuna/events{/privacy}","received_events_url":"https://api.github.com/users/ngtuna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngtuna/kompose","description":"Tool to move from `docker-compose` to Kubernetes","fork":true,"url":"https://api.github.com/repos/ngtuna/kompose","forks_url":"https://api.github.com/repos/ngtuna/kompose/forks","keys_url":"https://api.github.com/repos/ngtuna/kompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngtuna/kompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngtuna/kompose/teams","hooks_url":"https://api.github.com/repos/ngtuna/kompose/hooks","issue_events_url":"https://api.github.com/repos/ngtuna/kompose/issues/events{/number}","events_url":"https://api.github.com/repos/ngtuna/kompose/events","assignees_url":"https://api.github.com/repos/ngtuna/kompose/assignees{/user}","branches_url":"https://api.github.com/repos/ngtuna/kompose/branches{/branch}","tags_url":"https://api.github.com/repos/ngtuna/kompose/tags","blobs_url":"https://api.github.com/repos/ngtuna/kompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngtuna/kompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngtuna/kompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngtuna/kompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngtuna/kompose/statuses/{sha}","languages_url":"https://api.github.com/repos/ngtuna/kompose/languages","stargazers_url":"https://api.github.com/repos/ngtuna/kompose/stargazers","contributors_url":"https://api.github.com/repos/ngtuna/kompose/contributors","subscribers_url":"https://api.github.com/repos/ngtuna/kompose/subscribers","subscription_url":"https://api.github.com/repos/ngtuna/kompose/subscription","commits_url":"https://api.github.com/repos/ngtuna/kompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngtuna/kompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngtuna/kompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngtuna/kompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngtuna/kompose/contents/{+path}","compare_url":"https://api.github.com/repos/ngtuna/kompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngtuna/kompose/merges","archive_url":"https://api.github.com/repos/ngtuna/kompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngtuna/kompose/downloads","issues_url":"https://api.github.com/repos/ngtuna/kompose/issues{/number}","pulls_url":"https://api.github.com/repos/ngtuna/kompose/pulls{/number}","milestones_url":"https://api.github.com/repos/ngtuna/kompose/milestones{/number}","notifications_url":"https://api.github.com/repos/ngtuna/kompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngtuna/kompose/labels{/name}","releases_url":"https://api.github.com/repos/ngtuna/kompose/releases{/id}","deployments_url":"https://api.github.com/repos/ngtuna/kompose/deployments","created_at":"2016-06-30T07:26:43Z","updated_at":"2016-07-28T12:22:11Z","pushed_at":"2016-10-10T15:49:17Z","git_url":"git://github.com/ngtuna/kompose.git","ssh_url":"git@github.com:ngtuna/kompose.git","clone_url":"https://github.com/ngtuna/kompose.git","svn_url":"https://github.com/ngtuna/kompose","homepage":"","size":4624,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skippbox:master","ref":"master","sha":"d5a2952880690153392d48600ca55fe76edf494a","user":{"login":"skippbox","id":14835670,"avatar_url":"https://avatars.githubusercontent.com/u/14835670?v=3","gravatar_id":"","url":"https://api.github.com/users/skippbox","html_url":"https://github.com/skippbox","followers_url":"https://api.github.com/users/skippbox/followers","following_url":"https://api.github.com/users/skippbox/following{/other_user}","gists_url":"https://api.github.com/users/skippbox/gists{/gist_id}","starred_url":"https://api.github.com/users/skippbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skippbox/subscriptions","organizations_url":"https://api.github.com/users/skippbox/orgs","repos_url":"https://api.github.com/users/skippbox/repos","events_url":"https://api.github.com/users/skippbox/events{/privacy}","received_events_url":"https://api.github.com/users/skippbox/received_events","type":"Organization","site_admin":false},"repo":{"id":62088377,"name":"kompose","full_name":"skippbox/kompose","owner":{"login":"skippbox","id":14835670,"avatar_url":"https://avatars.githubusercontent.com/u/14835670?v=3","gravatar_id":"","url":"https://api.github.com/users/skippbox","html_url":"https://github.com/skippbox","followers_url":"https://api.github.com/users/skippbox/followers","following_url":"https://api.github.com/users/skippbox/following{/other_user}","gists_url":"https://api.github.com/users/skippbox/gists{/gist_id}","starred_url":"https://api.github.com/users/skippbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skippbox/subscriptions","organizations_url":"https://api.github.com/users/skippbox/orgs","repos_url":"https://api.github.com/users/skippbox/repos","events_url":"https://api.github.com/users/skippbox/events{/privacy}","received_events_url":"https://api.github.com/users/skippbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skippbox/kompose","description":"Tool to move from `docker-compose` to Kubernetes","fork":false,"url":"https://api.github.com/repos/skippbox/kompose","forks_url":"https://api.github.com/repos/skippbox/kompose/forks","keys_url":"https://api.github.com/repos/skippbox/kompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skippbox/kompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skippbox/kompose/teams","hooks_url":"https://api.github.com/repos/skippbox/kompose/hooks","issue_events_url":"https://api.github.com/repos/skippbox/kompose/issues/events{/number}","events_url":"https://api.github.com/repos/skippbox/kompose/events","assignees_url":"https://api.github.com/repos/skippbox/kompose/assignees{/user}","branches_url":"https://api.github.com/repos/skippbox/kompose/branches{/branch}","tags_url":"https://api.github.com/repos/skippbox/kompose/tags","blobs_url":"https://api.github.com/repos/skippbox/kompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skippbox/kompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skippbox/kompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/skippbox/kompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skippbox/kompose/statuses/{sha}","languages_url":"https://api.github.com/repos/skippbox/kompose/languages","stargazers_url":"https://api.github.com/repos/skippbox/kompose/stargazers","contributors_url":"https://api.github.com/repos/skippbox/kompose/contributors","subscribers_url":"https://api.github.com/repos/skippbox/kompose/subscribers","subscription_url":"https://api.github.com/repos/skippbox/kompose/subscription","commits_url":"https://api.github.com/repos/skippbox/kompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/skippbox/kompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/skippbox/kompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/skippbox/kompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/skippbox/kompose/contents/{+path}","compare_url":"https://api.github.com/repos/skippbox/kompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skippbox/kompose/merges","archive_url":"https://api.github.com/repos/skippbox/kompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skippbox/kompose/downloads","issues_url":"https://api.github.com/repos/skippbox/kompose/issues{/number}","pulls_url":"https://api.github.com/repos/skippbox/kompose/pulls{/number}","milestones_url":"https://api.github.com/repos/skippbox/kompose/milestones{/number}","notifications_url":"https://api.github.com/repos/skippbox/kompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skippbox/kompose/labels{/name}","releases_url":"https://api.github.com/repos/skippbox/kompose/releases{/id}","deployments_url":"https://api.github.com/repos/skippbox/kompose/deployments","created_at":"2016-06-27T21:08:18Z","updated_at":"2016-10-12T21:49:35Z","pushed_at":"2016-10-13T13:27:26Z","git_url":"git://github.com/skippbox/kompose.git","ssh_url":"git@github.com:skippbox/kompose.git","clone_url":"https://github.com/skippbox/kompose.git","svn_url":"https://github.com/skippbox/kompose","homepage":"","size":6755,"stargazers_count":137,"watchers_count":137,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":47,"forks":23,"open_issues":47,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skippbox/kompose/pulls/197"},"html":{"href":"https://github.com/skippbox/kompose/pull/197"},"issue":{"href":"https://api.github.com/repos/skippbox/kompose/issues/197"},"comments":{"href":"https://api.github.com/repos/skippbox/kompose/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/skippbox/kompose/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/skippbox/kompose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skippbox/kompose/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/skippbox/kompose/statuses/551df5f91b2c896fcaccd596ad562e7083b2a705"}}}}
{"actor":{"display_login":"kadel"}}