{"push_id":1091238276,"size":6,"distinct_size":1,"ref":"refs/heads/stable","head":"6d175516f54818d02b5fa7d4bc2b290123c3d27f","before":"789aff85dbf96248c903376c7d6704ada31f294b","commits":[{"sha":"9b07d1c480f447fea5f0cd9adeb2e7fc838778cc","author":{"email":"44f878afe53efc66b76772bd845eb65944ed8232@pinterest.com","name":"Jon Parise"},"message":"Recognize error codes from Flake8 extensions\n\nSummary:\nFlake8 extensions are allowed to use their own letter-prefixed codes. For\nexample, the flake8-debugger extension emits 'T002'-tagged messages.\n\nThis change relaxes getLintCodeFromLinterConfigurationKey() to also recognize\nextension codes. Otherwise, attempting to configure message severities for\ne.g. 'T002' would result in an exception.\n\nMessages from extensions continue to default to ERROR severity, as they did\nbefore this change.\n\nTest Plan:\nSuccessfully reduced the severity of 'T002' to a warning via .arclint:\n\n    \"severity\": {\n        \"T002\": \"warning\"\n    }\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15810","distinct":false,"url":"https://api.github.com/repos/phacility/arcanist/commits/9b07d1c480f447fea5f0cd9adeb2e7fc838778cc"},{"sha":"ea6fc7789295fc090ed2dd35dc19bfa464478024","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@freelancer.com","name":"Joshua Spence"},"message":"Fix incorrect variable for linter standards\n\nSummary: It is currently not possible to apply multiple linter standards because `$value` was used instead of `$standard`.\n\nTest Plan: Was able to apply multiple linter standards.\n\nReviewers: epriestley, #blessed_reviewers\n\nReviewed By: epriestley, #blessed_reviewers\n\nSubscribers: eadler, thaiphv, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15212","distinct":false,"url":"https://api.github.com/repos/phacility/arcanist/commits/ea6fc7789295fc090ed2dd35dc19bfa464478024"},{"sha":"3ffed59bd7fb19e8d712aca9b86bf5ce55b7d8ca","author":{"email":"3d0bee04b38b2b7b45329c581f51e08dadfe230d@experty.com","name":"Richard van Velzen"},"message":"Update xhpast linter rules for new function AST format\n\nSummary: See D15678. A node containing a return type hint is added right before the statement body node. This updates all relevant linter rules to now retrieve the body from the correct index.\n\nTest Plan: Ran `arc unit --everything`, inspected every single message to make sure all xhpast test cases succeeded. Also grepped for `getChildByIndex(5` and `getChildOfType(5`.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15814","distinct":false,"url":"https://api.github.com/repos/phacility/arcanist/commits/3ffed59bd7fb19e8d712aca9b86bf5ce55b7d8ca"},{"sha":"768e1a56bc5f73c0e15610c74b7d0c023beee4e0","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"When running XHPAST unit tests, include the \"syntax error\" lint rule\n\nSummary:\nSee rARC3ffed59bd7. Currently, when a unit test includes a syntax error, it is raised in an unclear way (\"error at line 10, char 1: XHP1 Unknown lint message!\").\n\nThis is because each test case only activates rules it wants to test, so we lose the ID/name for the syntax message. However, we always want to test this and the lint engine can always raise it.\n\nTo get a better error message, include it unconditionally. So a test for rule `X` really tests two rules: syntax, and `X`.\n\nTest Plan:\nRan `arc unit` at HEAD, got a better test failure:\n\n```\n   FAIL  ArcanistCallTimePassByReferenceXHPASTLinterRuleTestCase::testLinter\nIn 'call-time-pass-by-reference.lint-test', expected lint to raise error on line 10 at char 8, but no error was raised. Actually raised:\n  error at line 10, char 1: XHP1 PHP Syntax Error!\n```\n\nNOTE: This doesn't pass tests yet, it just makes the test failure easier to understand. I'll see about fixing the test in the next change.\n\nReviewers: chad, richardvanvelzen\n\nReviewed By: richardvanvelzen\n\nDifferential Revision: https://secure.phabricator.com/D15819","distinct":false,"url":"https://api.github.com/repos/phacility/arcanist/commits/768e1a56bc5f73c0e15610c74b7d0c023beee4e0"},{"sha":"c58f1b9a2507488b2152473dd1f0bbc7e99c09c1","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"Prefer pip to easy_install\n\nSummary:\nPrefer pip to easy_install\nalso fixes incorrect install instructions for closure linters\n\nFixes T10892\nRef T10038\n\nTest Plan: inspection\n\nReviewers: avivey, #blessed_reviewers, epriestley, tjstum\n\nReviewed By: avivey, #blessed_reviewers, epriestley, tjstum\n\nSubscribers: avivey, Korvin\n\nManiphest Tasks: T10038, T10892\n\nDifferential Revision: https://secure.phabricator.com/D15818","distinct":false,"url":"https://api.github.com/repos/phacility/arcanist/commits/c58f1b9a2507488b2152473dd1f0bbc7e99c09c1"},{"sha":"6d175516f54818d02b5fa7d4bc2b290123c3d27f","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"(stable) Promote 2016 Week 18","distinct":true,"url":"https://api.github.com/repos/phacility/arcanist/commits/6d175516f54818d02b5fa7d4bc2b290123c3d27f"}]}