{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/76430051","id":76430051,"diff_hunk":"@@ -49,6 +49,9 @@ var (\n func NewCmdRolloutHistory(f *cmdutil.Factory, out io.Writer) *cobra.Command {\n \toptions := &HistoryOptions{}\n \n+\tvalidArgs := []string{\"deployment\"}","path":"pkg/kubectl/cmd/rollout/rollout_history.go","position":4,"original_position":4,"commit_id":"c3961bd77ee9826426e765d331ae3663df3b4dd4","original_commit_id":"c3961bd77ee9826426e765d331ae3663df3b4dd4","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"> Just noticed it, thanks. Are we going to end up with a factory method that needs to separate between commands?\r\n\r\nMaybe.  I see what's been done here as strictly better than the current state of affairs.  I'd let this go in and @fabianofranz and team can fix it up in the 1.5 timeframe.","created_at":"2016-08-26T14:42:44Z","updated_at":"2016-08-26T14:42:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/31333#discussion_r76430051","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/76430051"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/31333#discussion_r76430051"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333","id":82499768,"html_url":"https://github.com/kubernetes/kubernetes/pull/31333","diff_url":"https://github.com/kubernetes/kubernetes/pull/31333.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/31333.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31333","number":31333,"state":"open","locked":false,"title":"Fixed incomplete kubectl bash completion.","user":{"login":"xingzhou","id":5344440,"avatar_url":"https://avatars.githubusercontent.com/u/5344440?v=3","gravatar_id":"","url":"https://api.github.com/users/xingzhou","html_url":"https://github.com/xingzhou","followers_url":"https://api.github.com/users/xingzhou/followers","following_url":"https://api.github.com/users/xingzhou/following{/other_user}","gists_url":"https://api.github.com/users/xingzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xingzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xingzhou/subscriptions","organizations_url":"https://api.github.com/users/xingzhou/orgs","repos_url":"https://api.github.com/users/xingzhou/repos","events_url":"https://api.github.com/users/xingzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xingzhou/received_events","type":"User","site_admin":false},"body":"Added bash completion for several kubectl commands.\r\n\r\nFixes #25287\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/31333)\n<!-- Reviewable:end -->\n","created_at":"2016-08-24T08:18:07Z","updated_at":"2016-08-26T14:42:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea9698991f81356ccf8183ef5fe314fa56ddeae5","assignee":{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"assignees":[{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/31333/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c3961bd77ee9826426e765d331ae3663df3b4dd4","head":{"label":"xingzhou:kube-25287","ref":"kube-25287","sha":"c3961bd77ee9826426e765d331ae3663df3b4dd4","user":{"login":"xingzhou","id":5344440,"avatar_url":"https://avatars.githubusercontent.com/u/5344440?v=3","gravatar_id":"","url":"https://api.github.com/users/xingzhou","html_url":"https://github.com/xingzhou","followers_url":"https://api.github.com/users/xingzhou/followers","following_url":"https://api.github.com/users/xingzhou/following{/other_user}","gists_url":"https://api.github.com/users/xingzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xingzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xingzhou/subscriptions","organizations_url":"https://api.github.com/users/xingzhou/orgs","repos_url":"https://api.github.com/users/xingzhou/repos","events_url":"https://api.github.com/users/xingzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xingzhou/received_events","type":"User","site_admin":false},"repo":{"id":64464580,"name":"kubernetes","full_name":"xingzhou/kubernetes","owner":{"login":"xingzhou","id":5344440,"avatar_url":"https://avatars.githubusercontent.com/u/5344440?v=3","gravatar_id":"","url":"https://api.github.com/users/xingzhou","html_url":"https://github.com/xingzhou","followers_url":"https://api.github.com/users/xingzhou/followers","following_url":"https://api.github.com/users/xingzhou/following{/other_user}","gists_url":"https://api.github.com/users/xingzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/xingzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xingzhou/subscriptions","organizations_url":"https://api.github.com/users/xingzhou/orgs","repos_url":"https://api.github.com/users/xingzhou/repos","events_url":"https://api.github.com/users/xingzhou/events{/privacy}","received_events_url":"https://api.github.com/users/xingzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xingzhou/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/xingzhou/kubernetes","forks_url":"https://api.github.com/repos/xingzhou/kubernetes/forks","keys_url":"https://api.github.com/repos/xingzhou/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xingzhou/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xingzhou/kubernetes/teams","hooks_url":"https://api.github.com/repos/xingzhou/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/xingzhou/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/xingzhou/kubernetes/events","assignees_url":"https://api.github.com/repos/xingzhou/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/xingzhou/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/xingzhou/kubernetes/tags","blobs_url":"https://api.github.com/repos/xingzhou/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xingzhou/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xingzhou/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/xingzhou/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xingzhou/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/xingzhou/kubernetes/languages","stargazers_url":"https://api.github.com/repos/xingzhou/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/xingzhou/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/xingzhou/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/xingzhou/kubernetes/subscription","commits_url":"https://api.github.com/repos/xingzhou/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/xingzhou/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/xingzhou/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/xingzhou/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/xingzhou/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/xingzhou/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xingzhou/kubernetes/merges","archive_url":"https://api.github.com/repos/xingzhou/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xingzhou/kubernetes/downloads","issues_url":"https://api.github.com/repos/xingzhou/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/xingzhou/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/xingzhou/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/xingzhou/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xingzhou/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/xingzhou/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/xingzhou/kubernetes/deployments","created_at":"2016-07-29T08:30:52Z","updated_at":"2016-07-29T08:31:36Z","pushed_at":"2016-08-24T05:59:23Z","git_url":"git://github.com/xingzhou/kubernetes.git","ssh_url":"git@github.com:xingzhou/kubernetes.git","clone_url":"https://github.com/xingzhou/kubernetes.git","svn_url":"https://github.com/xingzhou/kubernetes","homepage":"http://kubernetes.io","size":314212,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d84dcaf3fb5b9e02ce1979860b9dda42d1ec59d4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-26T09:51:34Z","pushed_at":"2016-08-26T13:49:12Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":546005,"stargazers_count":16326,"watchers_count":16326,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5268,"mirror_url":null,"open_issues_count":4304,"forks":5268,"open_issues":4304,"watchers":16326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/31333"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/31333"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/31333/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/31333/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c3961bd77ee9826426e765d331ae3663df3b4dd4"}}}}
{"actor":{"display_login":"deads2k"}}