{"action":"created","comment":{"url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/comments/50622547","id":50622547,"diff_hunk":"@@ -1,2 +1,66 @@\n # AddressValidation\n AddressValidation for Magento 2\n+\n+Introduction\n+------------\n+Goal is to make an extension that can both lookup and validate customer addresses\n+This extension should solve the problem that orders are shipped to non-existing addresses\n+The extension will be a bridge between various address lookup services and magento\n+\n+Approach\n+--------\n+- We do the assumption that if an address can be looked up it must be a valid address\n+- We do not use a special \"housenumber\" address attribute but make usage of the different address lines (configurable)\n+\n+Address lookup service interface parameters\n+-------------------------------------------\n+Fields needed for looking up address (multiselect)\n+- Country (always needed)\n+- State (optional)\n+- Address (optional\n+- Housenumber (optional)\n+- postcode (optional)\n+\n+List of countries that are allowed/supported by the service (multiselect)\n+\n+Is the user allowed to order without a valid address (dropdown)\n+- No (not allowed to order)\n+- Yes (enter address manually)\n+\n+Address Validation (and formatting)\n+-----------------------------------\n+Optional reg-ex validation can be added for the following fields\n+- address\n+- housenumber\n+- postcode\n+Optional there could be autocorrection (like removing or adding spaces from dutch postcodes etc)\n+\n+Backend configuration\n+---------------------\n+In the admin, per country you can enble \"lookup/validation\" by setting the following parameters","path":"README.md","position":40,"original_position":40,"commit_id":"9cc6bc9b79fd317d5c376a6535cafd6ed31827b0","original_commit_id":"9cc6bc9b79fd317d5c376a6535cafd6ed31827b0","user":{"login":"johmanx10","id":642417,"avatar_url":"https://avatars.githubusercontent.com/u/642417?v=3","gravatar_id":"","url":"https://api.github.com/users/johmanx10","html_url":"https://github.com/johmanx10","followers_url":"https://api.github.com/users/johmanx10/followers","following_url":"https://api.github.com/users/johmanx10/following{/other_user}","gists_url":"https://api.github.com/users/johmanx10/gists{/gist_id}","starred_url":"https://api.github.com/users/johmanx10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johmanx10/subscriptions","organizations_url":"https://api.github.com/users/johmanx10/orgs","repos_url":"https://api.github.com/users/johmanx10/repos","events_url":"https://api.github.com/users/johmanx10/events{/privacy}","received_events_url":"https://api.github.com/users/johmanx10/received_events","type":"User","site_admin":false},"body":"English grammar order is different from Dutch grammar order.\r\n\r\nSuggestion:\r\n```\r\nIn the admin, you can enable \"lookup/validation\", per country, by setting the following parameters:\r\n```","created_at":"2016-01-23T17:16:04Z","updated_at":"2016-01-23T17:16:04Z","html_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation/pull/3#discussion_r50622547","pull_request_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/comments/50622547"},"html":{"href":"https://github.com/magento-hackathon/Hackathon_AddressValidation/pull/3#discussion_r50622547"},"pull_request":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3","id":56980632,"html_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation/pull/3","diff_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation/pull/3.diff","patch_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation/pull/3.patch","issue_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues/3","number":3,"state":"open","locked":false,"title":"clarify goals and approach","user":{"login":"rutgerrademaker","id":912316,"avatar_url":"https://avatars.githubusercontent.com/u/912316?v=3","gravatar_id":"","url":"https://api.github.com/users/rutgerrademaker","html_url":"https://github.com/rutgerrademaker","followers_url":"https://api.github.com/users/rutgerrademaker/followers","following_url":"https://api.github.com/users/rutgerrademaker/following{/other_user}","gists_url":"https://api.github.com/users/rutgerrademaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rutgerrademaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rutgerrademaker/subscriptions","organizations_url":"https://api.github.com/users/rutgerrademaker/orgs","repos_url":"https://api.github.com/users/rutgerrademaker/repos","events_url":"https://api.github.com/users/rutgerrademaker/events{/privacy}","received_events_url":"https://api.github.com/users/rutgerrademaker/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-23T17:03:47Z","updated_at":"2016-01-23T17:16:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dcbbae57c4bcb460faa0a37ae134f31a48cfa41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3/commits","review_comments_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3/comments","review_comment_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues/3/comments","statuses_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/statuses/9cc6bc9b79fd317d5c376a6535cafd6ed31827b0","head":{"label":"rutgerrademaker:master","ref":"master","sha":"9cc6bc9b79fd317d5c376a6535cafd6ed31827b0","user":{"login":"rutgerrademaker","id":912316,"avatar_url":"https://avatars.githubusercontent.com/u/912316?v=3","gravatar_id":"","url":"https://api.github.com/users/rutgerrademaker","html_url":"https://github.com/rutgerrademaker","followers_url":"https://api.github.com/users/rutgerrademaker/followers","following_url":"https://api.github.com/users/rutgerrademaker/following{/other_user}","gists_url":"https://api.github.com/users/rutgerrademaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rutgerrademaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rutgerrademaker/subscriptions","organizations_url":"https://api.github.com/users/rutgerrademaker/orgs","repos_url":"https://api.github.com/users/rutgerrademaker/repos","events_url":"https://api.github.com/users/rutgerrademaker/events{/privacy}","received_events_url":"https://api.github.com/users/rutgerrademaker/received_events","type":"User","site_admin":false},"repo":{"id":50238149,"name":"Hackathon_AddressValidation","full_name":"rutgerrademaker/Hackathon_AddressValidation","owner":{"login":"rutgerrademaker","id":912316,"avatar_url":"https://avatars.githubusercontent.com/u/912316?v=3","gravatar_id":"","url":"https://api.github.com/users/rutgerrademaker","html_url":"https://github.com/rutgerrademaker","followers_url":"https://api.github.com/users/rutgerrademaker/followers","following_url":"https://api.github.com/users/rutgerrademaker/following{/other_user}","gists_url":"https://api.github.com/users/rutgerrademaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rutgerrademaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rutgerrademaker/subscriptions","organizations_url":"https://api.github.com/users/rutgerrademaker/orgs","repos_url":"https://api.github.com/users/rutgerrademaker/repos","events_url":"https://api.github.com/users/rutgerrademaker/events{/privacy}","received_events_url":"https://api.github.com/users/rutgerrademaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rutgerrademaker/Hackathon_AddressValidation","description":"","fork":true,"url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation","forks_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/forks","keys_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/teams","hooks_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/hooks","issue_events_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/issues/events{/number}","events_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/events","assignees_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/assignees{/user}","branches_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/branches{/branch}","tags_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/tags","blobs_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/git/refs{/sha}","trees_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/statuses/{sha}","languages_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/languages","stargazers_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/stargazers","contributors_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/contributors","subscribers_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/subscribers","subscription_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/subscription","commits_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/commits{/sha}","git_commits_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/git/commits{/sha}","comments_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/comments{/number}","issue_comment_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/issues/comments{/number}","contents_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/contents/{+path}","compare_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/merges","archive_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/downloads","issues_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/issues{/number}","pulls_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/pulls{/number}","milestones_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/milestones{/number}","notifications_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/labels{/name}","releases_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/releases{/id}","deployments_url":"https://api.github.com/repos/rutgerrademaker/Hackathon_AddressValidation/deployments","created_at":"2016-01-23T12:50:55Z","updated_at":"2016-01-23T12:50:56Z","pushed_at":"2016-01-23T17:02:56Z","git_url":"git://github.com/rutgerrademaker/Hackathon_AddressValidation.git","ssh_url":"git@github.com:rutgerrademaker/Hackathon_AddressValidation.git","clone_url":"https://github.com/rutgerrademaker/Hackathon_AddressValidation.git","svn_url":"https://github.com/rutgerrademaker/Hackathon_AddressValidation","homepage":null,"size":3,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magento-hackathon:master","ref":"master","sha":"be6944bfaef48b92aab4fc51499e6c9b9069cb9b","user":{"login":"magento-hackathon","id":1586526,"avatar_url":"https://avatars.githubusercontent.com/u/1586526?v=3","gravatar_id":"","url":"https://api.github.com/users/magento-hackathon","html_url":"https://github.com/magento-hackathon","followers_url":"https://api.github.com/users/magento-hackathon/followers","following_url":"https://api.github.com/users/magento-hackathon/following{/other_user}","gists_url":"https://api.github.com/users/magento-hackathon/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-hackathon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-hackathon/subscriptions","organizations_url":"https://api.github.com/users/magento-hackathon/orgs","repos_url":"https://api.github.com/users/magento-hackathon/repos","events_url":"https://api.github.com/users/magento-hackathon/events{/privacy}","received_events_url":"https://api.github.com/users/magento-hackathon/received_events","type":"Organization","site_admin":false},"repo":{"id":50232938,"name":"Hackathon_AddressValidation","full_name":"magento-hackathon/Hackathon_AddressValidation","owner":{"login":"magento-hackathon","id":1586526,"avatar_url":"https://avatars.githubusercontent.com/u/1586526?v=3","gravatar_id":"","url":"https://api.github.com/users/magento-hackathon","html_url":"https://github.com/magento-hackathon","followers_url":"https://api.github.com/users/magento-hackathon/followers","following_url":"https://api.github.com/users/magento-hackathon/following{/other_user}","gists_url":"https://api.github.com/users/magento-hackathon/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-hackathon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-hackathon/subscriptions","organizations_url":"https://api.github.com/users/magento-hackathon/orgs","repos_url":"https://api.github.com/users/magento-hackathon/repos","events_url":"https://api.github.com/users/magento-hackathon/events{/privacy}","received_events_url":"https://api.github.com/users/magento-hackathon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation","description":"","fork":false,"url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation","forks_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/forks","keys_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/teams","hooks_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/hooks","issue_events_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues/events{/number}","events_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/events","assignees_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/assignees{/user}","branches_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/branches{/branch}","tags_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/tags","blobs_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/statuses/{sha}","languages_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/languages","stargazers_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/stargazers","contributors_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/contributors","subscribers_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/subscribers","subscription_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/subscription","commits_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/contents/{+path}","compare_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/merges","archive_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/downloads","issues_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues{/number}","pulls_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls{/number}","milestones_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/milestones{/number}","notifications_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/labels{/name}","releases_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/releases{/id}","deployments_url":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/deployments","created_at":"2016-01-23T09:56:01Z","updated_at":"2016-01-23T12:28:32Z","pushed_at":"2016-01-23T17:04:47Z","git_url":"git://github.com/magento-hackathon/Hackathon_AddressValidation.git","ssh_url":"git@github.com:magento-hackathon/Hackathon_AddressValidation.git","clone_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation.git","svn_url":"https://github.com/magento-hackathon/Hackathon_AddressValidation","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3"},"html":{"href":"https://github.com/magento-hackathon/Hackathon_AddressValidation/pull/3"},"issue":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues/3"},"comments":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/magento-hackathon/Hackathon_AddressValidation/statuses/9cc6bc9b79fd317d5c376a6535cafd6ed31827b0"}}}}