{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/51833212","id":51833212,"diff_hunk":"@@ -85,7 +85,7 @@\n                   \"generic\": {\n                     \"type\": \"map\", \"mapping\": {\n                       \"service_instance_user\": { \"type\": \"str\", \"required\": true },\n-                      \"service_instance_password\": { \"type\": \"str\", \"required\": false },\n+                      \"service_instance_password\": { \"type\": \"str\", \"required\": true },","path":"chef/data_bags/crowbar/template-manila.schema","position":5,"original_position":5,"commit_id":"95ea7e290db59ae1d26407c4b7e21daf647f21b3","original_commit_id":"95ea7e290db59ae1d26407c4b7e21daf647f21b3","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"body":"Another thing - don't we need a migration now to always add the key if it isn't already there? (sorry for the fragmented review style)","created_at":"2016-02-04T06:04:37Z","updated_at":"2016-02-04T06:04:37Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/246#discussion_r51833212","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/51833212"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/246#discussion_r51833212"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246","id":57830394,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/246","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/246.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/246.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/246","number":246,"state":"open","locked":false,"title":"manila: Fix default proposal for generic backend","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"The default proposal has a generic backend with no password nor key;\r\nhowever, the UI makes you believe that a password is set (it actually\r\ndisplays \"undefined\").\r\n\r\nTo have this work, we need to change the validation to not check that\r\nthere's one attribute between password and key, but also to check that\r\nthere's one non-empty attribute.\r\n\r\ncc @toabctl ","created_at":"2016-02-01T12:01:45Z","updated_at":"2016-02-04T06:04:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb9ff76ad38a96d798f558c0bdf51e9a10eed8d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/246/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/95ea7e290db59ae1d26407c4b7e21daf647f21b3","head":{"label":"vuntz:manila-default-password","ref":"manila-default-password","sha":"95ea7e290db59ae1d26407c4b7e21daf647f21b3","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":41142183,"name":"crowbar-openstack","full_name":"vuntz/crowbar-openstack","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/vuntz/crowbar-openstack","forks_url":"https://api.github.com/repos/vuntz/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/vuntz/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/vuntz/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/vuntz/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/vuntz/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/vuntz/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/vuntz/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/vuntz/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/vuntz/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/vuntz/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/vuntz/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/vuntz/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/vuntz/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/vuntz/crowbar-openstack/deployments","created_at":"2015-08-21T07:34:22Z","updated_at":"2015-08-21T07:34:23Z","pushed_at":"2016-02-03T19:40:45Z","git_url":"git://github.com/vuntz/crowbar-openstack.git","ssh_url":"git@github.com:vuntz/crowbar-openstack.git","clone_url":"https://github.com/vuntz/crowbar-openstack.git","svn_url":"https://github.com/vuntz/crowbar-openstack","homepage":null,"size":16270,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"4ce0c3e4d62337faad106fdbe52cd5ee8be721da","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-02-03T19:40:46Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":16416,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":27,"forks":21,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/246"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/246"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/95ea7e290db59ae1d26407c4b7e21daf647f21b3"}}}}