{"action":"created","issue":{"url":"https://api.github.com/repos/python/mypy/issues/1952","repository_url":"https://api.github.com/repos/python/mypy","labels_url":"https://api.github.com/repos/python/mypy/issues/1952/labels{/name}","comments_url":"https://api.github.com/repos/python/mypy/issues/1952/comments","events_url":"https://api.github.com/repos/python/mypy/issues/1952/events","html_url":"https://github.com/python/mypy/pull/1952","id":168201053,"number":1952,"title":"Reset cache on mypy change","user":{"login":"Michael0x2a","id":1424628,"avatar_url":"https://avatars.githubusercontent.com/u/1424628?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael0x2a","html_url":"https://github.com/Michael0x2a","followers_url":"https://api.github.com/users/Michael0x2a/followers","following_url":"https://api.github.com/users/Michael0x2a/following{/other_user}","gists_url":"https://api.github.com/users/Michael0x2a/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael0x2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael0x2a/subscriptions","organizations_url":"https://api.github.com/users/Michael0x2a/orgs","repos_url":"https://api.github.com/users/Michael0x2a/repos","events_url":"https://api.github.com/users/Michael0x2a/events{/privacy}","received_events_url":"https://api.github.com/users/Michael0x2a/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-28T21:27:39Z","updated_at":"2016-07-29T22:17:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/1952","html_url":"https://github.com/python/mypy/pull/1952","diff_url":"https://github.com/python/mypy/pull/1952.diff","patch_url":"https://github.com/python/mypy/pull/1952.patch"},"body":"This pull request modifies `build.py` to add an extra \"version_id\" attribute to the cache metadata. If the version id specified in `mypy/version.py` differs from the id stored in the cached data, mypy will automatically invalidate that cached data.\r\n\r\nThis pull request will also modify `setup.py` to automatically edit the installed `mypy/version.py` file during installation to include the git hash if applicable.\r\n\r\nIf `setup.py` is not being run from a git repo, or if a git executable can't be found in the system, mypy will default to using the original version id.\r\n\r\nThe net effect should be that...\r\n\r\n- Developers who directly run mypy from a git repo will still need to manually delete their cache when the cache format changes.\r\n- Users who install mypy from PyPi will not have their `version.py` files edited during installation to include the git commit hash. However, their cache will still be invalidated based on the `__version__` variable we manually update per each release.\r\n- Users who pip-install mypy directly from the git repo _will_ have their `version.py` files edited during installation to include the git commit hash. That means their cache will be automatically invalidated even if `__version__` is the same as before.\r\n\r\nThis pull request hopefully fixes https://github.com/python/mypy/issues/1354, although I know very little about distutils/setup.py/releasing packages on PyPi so am not entirely confident this works in all cases."},"comment":{"url":"https://api.github.com/repos/python/mypy/issues/comments/236307726","html_url":"https://github.com/python/mypy/pull/1952#issuecomment-236307726","issue_url":"https://api.github.com/repos/python/mypy/issues/1952","id":236307726,"user":{"login":"gvanrossum","id":2894642,"avatar_url":"https://avatars.githubusercontent.com/u/2894642?v=3","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T22:17:18Z","updated_at":"2016-07-29T22:17:18Z","body":"That's all I've got. And the \".\" works fine, so no worries about that. So really, just two trailing commas. :-)"}}
{"actor":{"display_login":"gvanrossum"}}