{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-network/pulls/comments/80657430","pull_request_review_id":1699224,"id":80657430,"diff_hunk":"@@ -60,6 +87,21 @@ def configure_as_bridge_port(device)\n \n       NetworkInterfaces.Commit\n       NetworkInterfaces.Add\n+\n+      NetworkInterfaces.Current = selected_interface\n+    end\n+\n+    # Asks the user about adapt the current bridge port config in case that it\n+    # is configured in the old way (BOOTPROTO == static) & (IPADDR == 0.0.0.0).\n+    def fix_bridge_port_config?(ports)","path":"src/include/network/lan/bridge.rb","position":null,"original_position":55,"commit_id":"6f3fab4d5ce0edd6e49358799c54e862b4a2108b","original_commit_id":"b48eba931d5d54c104d7e2e635821b2f53077d7a","user":{"login":"mchf","id":1579239,"avatar_url":"https://avatars.githubusercontent.com/u/1579239?v=3","gravatar_id":"","url":"https://api.github.com/users/mchf","html_url":"https://github.com/mchf","followers_url":"https://api.github.com/users/mchf/followers","following_url":"https://api.github.com/users/mchf/following{/other_user}","gists_url":"https://api.github.com/users/mchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchf/subscriptions","organizations_url":"https://api.github.com/users/mchf/orgs","repos_url":"https://api.github.com/users/mchf/repos","events_url":"https://api.github.com/users/mchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchf/received_events","type":"User","site_admin":false},"body":"well it better describes current use case, but i don't see any benefit in having such one purpose method. So do you have any other pros? ;-)","created_at":"2016-09-27T09:55:09Z","updated_at":"2016-09-27T09:55:09Z","html_url":"https://github.com/yast/yast-network/pull/441#discussion_r80657430","pull_request_url":"https://api.github.com/repos/yast/yast-network/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments/80657430"},"html":{"href":"https://github.com/yast/yast-network/pull/441#discussion_r80657430"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-network/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-network/pulls/441","id":86149851,"html_url":"https://github.com/yast/yast-network/pull/441","diff_url":"https://github.com/yast/yast-network/pull/441.diff","patch_url":"https://github.com/yast/yast-network/pull/441.patch","issue_url":"https://api.github.com/repos/yast/yast-network/issues/441","number":441,"state":"open","locked":false,"title":"Bridge handling improved (bsc#962824)","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"body":"I have unified the configuration overview with bridges involved with the bonding one as you can see in the screenshots. There have been fixed also some small issue.\r\n\r\n## Bond overview\r\n![enslavedbond](https://cloud.githubusercontent.com/assets/7056681/18710258/398a800c-7ffc-11e6-889f-b610fd6a079a.png)\r\n\r\n## Bridge overview\r\n![enslavedbridge](https://cloud.githubusercontent.com/assets/7056681/18710260/3b4b556a-7ffc-11e6-808f-ba87199a063a.png)\r\n\r\n## Old bridge configuration\r\n![old_bridge](https://cloud.githubusercontent.com/assets/7056681/18710212/db44211a-7ffb-11e6-97ae-8c521094c0e0.gif)\r\n\r\n## New bridge configuration\r\n![new_bridge](https://cloud.githubusercontent.com/assets/7056681/18710206/d311fb0c-7ffb-11e6-9ef6-dc71c960c6b7.gif)","created_at":"2016-09-21T12:08:50Z","updated_at":"2016-09-27T09:55:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd4bf7b080e01893deb30db882a0a521b60bee9f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-network/pulls/441/commits","review_comments_url":"https://api.github.com/repos/yast/yast-network/pulls/441/comments","review_comment_url":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-network/issues/441/comments","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/6f3fab4d5ce0edd6e49358799c54e862b4a2108b","head":{"label":"teclator:bridge_overview_improvement","ref":"bridge_overview_improvement","sha":"6f3fab4d5ce0edd6e49358799c54e862b4a2108b","user":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"repo":{"id":46275383,"name":"yast-network","full_name":"teclator/yast-network","owner":{"login":"teclator","id":7056681,"avatar_url":"https://avatars.githubusercontent.com/u/7056681?v=3","gravatar_id":"","url":"https://api.github.com/users/teclator","html_url":"https://github.com/teclator","followers_url":"https://api.github.com/users/teclator/followers","following_url":"https://api.github.com/users/teclator/following{/other_user}","gists_url":"https://api.github.com/users/teclator/gists{/gist_id}","starred_url":"https://api.github.com/users/teclator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teclator/subscriptions","organizations_url":"https://api.github.com/users/teclator/orgs","repos_url":"https://api.github.com/users/teclator/repos","events_url":"https://api.github.com/users/teclator/events{/privacy}","received_events_url":"https://api.github.com/users/teclator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teclator/yast-network","description":"YaST module network","fork":true,"url":"https://api.github.com/repos/teclator/yast-network","forks_url":"https://api.github.com/repos/teclator/yast-network/forks","keys_url":"https://api.github.com/repos/teclator/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teclator/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teclator/yast-network/teams","hooks_url":"https://api.github.com/repos/teclator/yast-network/hooks","issue_events_url":"https://api.github.com/repos/teclator/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/teclator/yast-network/events","assignees_url":"https://api.github.com/repos/teclator/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/teclator/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/teclator/yast-network/tags","blobs_url":"https://api.github.com/repos/teclator/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teclator/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teclator/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/teclator/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teclator/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/teclator/yast-network/languages","stargazers_url":"https://api.github.com/repos/teclator/yast-network/stargazers","contributors_url":"https://api.github.com/repos/teclator/yast-network/contributors","subscribers_url":"https://api.github.com/repos/teclator/yast-network/subscribers","subscription_url":"https://api.github.com/repos/teclator/yast-network/subscription","commits_url":"https://api.github.com/repos/teclator/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/teclator/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/teclator/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/teclator/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/teclator/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/teclator/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teclator/yast-network/merges","archive_url":"https://api.github.com/repos/teclator/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teclator/yast-network/downloads","issues_url":"https://api.github.com/repos/teclator/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/teclator/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/teclator/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/teclator/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teclator/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/teclator/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/teclator/yast-network/deployments","created_at":"2015-11-16T13:13:08Z","updated_at":"2016-01-12T15:28:25Z","pushed_at":"2016-09-27T09:27:42Z","git_url":"git://github.com/teclator/yast-network.git","ssh_url":"git@github.com:teclator/yast-network.git","clone_url":"https://github.com/teclator/yast-network.git","svn_url":"https://github.com/teclator/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24480,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:SLE-12-SP2","ref":"SLE-12-SP2","sha":"825b7af704d3d5d01b1615ed620511d4a9ec8388","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368160,"name":"yast-network","full_name":"yast/yast-network","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-network","description":"YaST module network","fork":false,"url":"https://api.github.com/repos/yast/yast-network","forks_url":"https://api.github.com/repos/yast/yast-network/forks","keys_url":"https://api.github.com/repos/yast/yast-network/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-network/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-network/teams","hooks_url":"https://api.github.com/repos/yast/yast-network/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-network/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-network/events","assignees_url":"https://api.github.com/repos/yast/yast-network/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-network/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-network/tags","blobs_url":"https://api.github.com/repos/yast/yast-network/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-network/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-network/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-network/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-network/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-network/languages","stargazers_url":"https://api.github.com/repos/yast/yast-network/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-network/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-network/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-network/subscription","commits_url":"https://api.github.com/repos/yast/yast-network/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-network/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-network/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-network/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-network/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-network/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-network/merges","archive_url":"https://api.github.com/repos/yast/yast-network/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-network/downloads","issues_url":"https://api.github.com/repos/yast/yast-network/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-network/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-network/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-network/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-network/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-network/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-network/deployments","created_at":"2012-05-18T10:24:50Z","updated_at":"2016-08-23T07:35:16Z","pushed_at":"2016-09-27T09:27:43Z","git_url":"git://github.com/yast/yast-network.git","ssh_url":"git@github.com:yast/yast-network.git","clone_url":"https://github.com/yast/yast-network.git","svn_url":"https://github.com/yast/yast-network","homepage":"http://en.opensuse.org/Portal:YaST","size":24687,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":3,"forks":20,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-network/pulls/441"},"html":{"href":"https://github.com/yast/yast-network/pull/441"},"issue":{"href":"https://api.github.com/repos/yast/yast-network/issues/441"},"comments":{"href":"https://api.github.com/repos/yast/yast-network/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-network/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-network/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-network/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-network/statuses/6f3fab4d5ce0edd6e49358799c54e862b4a2108b"}}}}
{"actor":{"display_login":"mchf"}}