{"action":"closed","number":1577,"pull_request":{"url":"https://api.github.com/repos/processing/p5.js/pulls/1577","id":83545583,"html_url":"https://github.com/processing/p5.js/pull/1577","diff_url":"https://github.com/processing/p5.js/pull/1577.diff","patch_url":"https://github.com/processing/p5.js/pull/1577.patch","issue_url":"https://api.github.com/repos/processing/p5.js/issues/1577","number":1577,"state":"closed","locked":false,"title":"Canvas Resizing (Fix windowWidth and windowHeight)","user":{"login":"craftoid","id":720669,"avatar_url":"https://avatars.githubusercontent.com/u/720669?v=3","gravatar_id":"","url":"https://api.github.com/users/craftoid","html_url":"https://github.com/craftoid","followers_url":"https://api.github.com/users/craftoid/followers","following_url":"https://api.github.com/users/craftoid/following{/other_user}","gists_url":"https://api.github.com/users/craftoid/gists{/gist_id}","starred_url":"https://api.github.com/users/craftoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftoid/subscriptions","organizations_url":"https://api.github.com/users/craftoid/orgs","repos_url":"https://api.github.com/users/craftoid/repos","events_url":"https://api.github.com/users/craftoid/events{/privacy}","received_events_url":"https://api.github.com/users/craftoid/received_events","type":"User","site_admin":false},"body":"The implementation for assigning window dimensions to `windowWidth` and `windowHeight` introduced in #1494 does not work as expected.  As a result down-resizing the browser window to a smaller size will not resize the canvas appropriately, when using this snippet of code:\r\n\r\n```js\r\nfunction windowResized() {\r\n  resizeCanvas(windowWidth, windowHeight);\r\n}\r\n```\r\n\r\nThe `windowWidth` and `windowHeight` variables should refer to the size of the viewport.\r\nSo we must use `window.innerWidth` and `window.innerHeight`.\r\n\r\nBoth `document.documentElement.clientWidth` and `document.body.clientHeight`\r\nmay be used as polyfill, but they refer to the dimensions of the body and the html element,\r\nwhich may be greater than those of the actual viewport (!).\r\n","created_at":"2016-08-31T23:11:28Z","updated_at":"2016-08-31T23:30:46Z","closed_at":"2016-08-31T23:30:46Z","merged_at":null,"merge_commit_sha":"0c07c3708b7932f2ea52eac18424d72192a5f249","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/processing/p5.js/pulls/1577/commits","review_comments_url":"https://api.github.com/repos/processing/p5.js/pulls/1577/comments","review_comment_url":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/processing/p5.js/issues/1577/comments","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/bfd38fdc3ca04a8107e6412f3a1eef6a772ca1f4","head":{"label":"craftoid:master","ref":"master","sha":"bfd38fdc3ca04a8107e6412f3a1eef6a772ca1f4","user":{"login":"craftoid","id":720669,"avatar_url":"https://avatars.githubusercontent.com/u/720669?v=3","gravatar_id":"","url":"https://api.github.com/users/craftoid","html_url":"https://github.com/craftoid","followers_url":"https://api.github.com/users/craftoid/followers","following_url":"https://api.github.com/users/craftoid/following{/other_user}","gists_url":"https://api.github.com/users/craftoid/gists{/gist_id}","starred_url":"https://api.github.com/users/craftoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftoid/subscriptions","organizations_url":"https://api.github.com/users/craftoid/orgs","repos_url":"https://api.github.com/users/craftoid/repos","events_url":"https://api.github.com/users/craftoid/events{/privacy}","received_events_url":"https://api.github.com/users/craftoid/received_events","type":"User","site_admin":false},"repo":{"id":67076217,"name":"p5.js","full_name":"craftoid/p5.js","owner":{"login":"craftoid","id":720669,"avatar_url":"https://avatars.githubusercontent.com/u/720669?v=3","gravatar_id":"","url":"https://api.github.com/users/craftoid","html_url":"https://github.com/craftoid","followers_url":"https://api.github.com/users/craftoid/followers","following_url":"https://api.github.com/users/craftoid/following{/other_user}","gists_url":"https://api.github.com/users/craftoid/gists{/gist_id}","starred_url":"https://api.github.com/users/craftoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craftoid/subscriptions","organizations_url":"https://api.github.com/users/craftoid/orgs","repos_url":"https://api.github.com/users/craftoid/repos","events_url":"https://api.github.com/users/craftoid/events{/privacy}","received_events_url":"https://api.github.com/users/craftoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craftoid/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":true,"url":"https://api.github.com/repos/craftoid/p5.js","forks_url":"https://api.github.com/repos/craftoid/p5.js/forks","keys_url":"https://api.github.com/repos/craftoid/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craftoid/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craftoid/p5.js/teams","hooks_url":"https://api.github.com/repos/craftoid/p5.js/hooks","issue_events_url":"https://api.github.com/repos/craftoid/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/craftoid/p5.js/events","assignees_url":"https://api.github.com/repos/craftoid/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/craftoid/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/craftoid/p5.js/tags","blobs_url":"https://api.github.com/repos/craftoid/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craftoid/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craftoid/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/craftoid/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craftoid/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/craftoid/p5.js/languages","stargazers_url":"https://api.github.com/repos/craftoid/p5.js/stargazers","contributors_url":"https://api.github.com/repos/craftoid/p5.js/contributors","subscribers_url":"https://api.github.com/repos/craftoid/p5.js/subscribers","subscription_url":"https://api.github.com/repos/craftoid/p5.js/subscription","commits_url":"https://api.github.com/repos/craftoid/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/craftoid/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/craftoid/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/craftoid/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/craftoid/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/craftoid/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craftoid/p5.js/merges","archive_url":"https://api.github.com/repos/craftoid/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craftoid/p5.js/downloads","issues_url":"https://api.github.com/repos/craftoid/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/craftoid/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/craftoid/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/craftoid/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craftoid/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/craftoid/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/craftoid/p5.js/deployments","created_at":"2016-08-31T21:54:01Z","updated_at":"2016-08-31T21:54:04Z","pushed_at":"2016-08-31T22:39:35Z","git_url":"git://github.com/craftoid/p5.js.git","ssh_url":"git@github.com:craftoid/p5.js.git","clone_url":"https://github.com/craftoid/p5.js.git","svn_url":"https://github.com/craftoid/p5.js","homepage":"http://p5js.org/","size":64998,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"processing:master","ref":"master","sha":"6e1a672c04c6149bc92767e96b258786cbe5c710","user":{"login":"processing","id":1617169,"avatar_url":"https://avatars.githubusercontent.com/u/1617169?v=3","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"repo":{"id":8424040,"name":"p5.js","full_name":"processing/p5.js","owner":{"login":"processing","id":1617169,"avatar_url":"https://avatars.githubusercontent.com/u/1617169?v=3","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/processing/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":false,"url":"https://api.github.com/repos/processing/p5.js","forks_url":"https://api.github.com/repos/processing/p5.js/forks","keys_url":"https://api.github.com/repos/processing/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/processing/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/processing/p5.js/teams","hooks_url":"https://api.github.com/repos/processing/p5.js/hooks","issue_events_url":"https://api.github.com/repos/processing/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/processing/p5.js/events","assignees_url":"https://api.github.com/repos/processing/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/processing/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/processing/p5.js/tags","blobs_url":"https://api.github.com/repos/processing/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/processing/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/processing/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/processing/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/processing/p5.js/languages","stargazers_url":"https://api.github.com/repos/processing/p5.js/stargazers","contributors_url":"https://api.github.com/repos/processing/p5.js/contributors","subscribers_url":"https://api.github.com/repos/processing/p5.js/subscribers","subscription_url":"https://api.github.com/repos/processing/p5.js/subscription","commits_url":"https://api.github.com/repos/processing/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/processing/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/processing/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/processing/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/processing/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/processing/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/processing/p5.js/merges","archive_url":"https://api.github.com/repos/processing/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/processing/p5.js/downloads","issues_url":"https://api.github.com/repos/processing/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/processing/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/processing/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/processing/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/processing/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/processing/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/processing/p5.js/deployments","created_at":"2013-02-26T03:14:47Z","updated_at":"2016-08-31T22:40:00Z","pushed_at":"2016-08-31T23:11:28Z","git_url":"git://github.com/processing/p5.js.git","ssh_url":"git@github.com:processing/p5.js.git","clone_url":"https://github.com/processing/p5.js.git","svn_url":"https://github.com/processing/p5.js","homepage":"http://p5js.org/","size":64998,"stargazers_count":4256,"watchers_count":4256,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":584,"mirror_url":null,"open_issues_count":75,"forks":584,"open_issues":75,"watchers":4256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1577"},"html":{"href":"https://github.com/processing/p5.js/pull/1577"},"issue":{"href":"https://api.github.com/repos/processing/p5.js/issues/1577"},"comments":{"href":"https://api.github.com/repos/processing/p5.js/issues/1577/comments"},"review_comments":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1577/comments"},"review_comment":{"href":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/processing/p5.js/pulls/1577/commits"},"statuses":{"href":"https://api.github.com/repos/processing/p5.js/statuses/bfd38fdc3ca04a8107e6412f3a1eef6a772ca1f4"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"craftoid"}}