{"action":"created","issue":{"url":"https://api.github.com/repos/japgolly/scalajs-react/issues/320","repository_url":"https://api.github.com/repos/japgolly/scalajs-react","labels_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/320/comments","events_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/320/events","html_url":"https://github.com/japgolly/scalajs-react/pull/320","id":193127949,"number":320,"title":"Migrate to scalajs-bundler","user":{"login":"julienrf","id":332812,"avatar_url":"https://avatars.githubusercontent.com/u/332812?v=3","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-02T14:24:32Z","updated_at":"2016-12-05T09:00:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/japgolly/scalajs-react/pulls/320","html_url":"https://github.com/japgolly/scalajs-react/pull/320","diff_url":"https://github.com/japgolly/scalajs-react/pull/320.diff","patch_url":"https://github.com/japgolly/scalajs-react/pull/320.patch"},"body":"I wanted to play with scalajs-bundler in the context of a large Scala.js facade, so I naturally went to scalajs-react, which is one of the most used facades.\r\n\r\nIt turns out that it works well with scalajs-bundler. In my opinion the builds of projects that use scalajs-react become simpler with this PR. I will highlight some parts of the PR by commenting in the diff.\r\n\r\nA drawback of scalajs-bundler is that a concrete facade can not be compatible with both `npmDependencies` and `jsDependencies`, so existing users will be forced to move to scalajs-bundler. A solution to this problem could be to isolate the facade interfaces into separate, small sbt sub-projects, and then have two different concrete facades (one that would work with `npmDependencies` and the other with `jsDependencies`)."},"comment":{"url":"https://api.github.com/repos/japgolly/scalajs-react/issues/comments/264799476","html_url":"https://github.com/japgolly/scalajs-react/pull/320#issuecomment-264799476","issue_url":"https://api.github.com/repos/japgolly/scalajs-react/issues/320","id":264799476,"user":{"login":"julienrf","id":332812,"avatar_url":"https://avatars.githubusercontent.com/u/332812?v=3","gravatar_id":"","url":"https://api.github.com/users/julienrf","html_url":"https://github.com/julienrf","followers_url":"https://api.github.com/users/julienrf/followers","following_url":"https://api.github.com/users/julienrf/following{/other_user}","gists_url":"https://api.github.com/users/julienrf/gists{/gist_id}","starred_url":"https://api.github.com/users/julienrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienrf/subscriptions","organizations_url":"https://api.github.com/users/julienrf/orgs","repos_url":"https://api.github.com/users/julienrf/repos","events_url":"https://api.github.com/users/julienrf/events{/privacy}","received_events_url":"https://api.github.com/users/julienrf/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T09:00:00Z","updated_at":"2016-12-05T09:00:00Z","body":"@japgolly I added a commit that makes React.js dependencies “provided”."}}
{"actor":{"display_login":"julienrf"}}