{"action":"created","comment":{"url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/comments/88892948","pull_request_review_id":9449898,"id":88892948,"diff_hunk":"@@ -721,11 +722,34 @@ public void onClick(View v) {\n                     }\n                 });\n \n+                //ViewGroup\n+                FrameLayout fullscreenLayout = new FrameLayout(cordova.getActivity());\n+                RelativeLayout.LayoutParams frameLayoutParams = new RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);\n+                fullscreenLayout.setLayoutParams(frameLayoutParams);\n+                fullscreenLayout.setId(Integer.valueOf(6));\n+                fullscreenLayout.setVisibility(View.GONE);\n+\n                 // WebView\n                 inAppWebView = new WebView(cordova.getActivity());\n                 inAppWebView.setLayoutParams(new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));\n                 inAppWebView.setId(Integer.valueOf(6));\n-                inAppWebView.setWebChromeClient(new InAppChromeClient(thatWebView));\n+                InAppChromeClient chromeClient = new InAppChromeClient(thatWebView, fullscreenLayout){","path":"src/android/InAppBrowser.java","position":24,"original_position":24,"commit_id":"278f7e5317416d232c4cc84173d30f0c42e5818e","original_commit_id":"278f7e5317416d232c4cc84173d30f0c42e5818e","user":{"login":"tgalal","id":895331,"avatar_url":"https://avatars.githubusercontent.com/u/895331?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalal","html_url":"https://github.com/tgalal","followers_url":"https://api.github.com/users/tgalal/followers","following_url":"https://api.github.com/users/tgalal/following{/other_user}","gists_url":"https://api.github.com/users/tgalal/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalal/subscriptions","organizations_url":"https://api.github.com/users/tgalal/orgs","repos_url":"https://api.github.com/users/tgalal/repos","events_url":"https://api.github.com/users/tgalal/events{/privacy}","received_events_url":"https://api.github.com/users/tgalal/received_events","type":"User","site_admin":false},"body":"there is no point in passing the layout to the chrome client. We already override the onShowCustomView here and have access to the view. It should be added to the fullScreenLayout in this overriden method instead of doing it in the chrome client","created_at":"2016-11-21T13:26:58Z","updated_at":"2016-11-21T13:29:47Z","html_url":"https://github.com/tgalal/cordova-plugin-inappbrowser/pull/8#discussion_r88892948","pull_request_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/comments/88892948"},"html":{"href":"https://github.com/tgalal/cordova-plugin-inappbrowser/pull/8#discussion_r88892948"},"pull_request":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8","id":94589296,"html_url":"https://github.com/tgalal/cordova-plugin-inappbrowser/pull/8","diff_url":"https://github.com/tgalal/cordova-plugin-inappbrowser/pull/8.diff","patch_url":"https://github.com/tgalal/cordova-plugin-inappbrowser/pull/8.patch","issue_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues/8","number":8,"state":"open","locked":false,"title":"enabling fullScreen mode","user":{"login":"ateek","id":6179699,"avatar_url":"https://avatars.githubusercontent.com/u/6179699?v=3","gravatar_id":"","url":"https://api.github.com/users/ateek","html_url":"https://github.com/ateek","followers_url":"https://api.github.com/users/ateek/followers","following_url":"https://api.github.com/users/ateek/following{/other_user}","gists_url":"https://api.github.com/users/ateek/gists{/gist_id}","starred_url":"https://api.github.com/users/ateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ateek/subscriptions","organizations_url":"https://api.github.com/users/ateek/orgs","repos_url":"https://api.github.com/users/ateek/repos","events_url":"https://api.github.com/users/ateek/events{/privacy}","received_events_url":"https://api.github.com/users/ateek/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-21T10:33:31Z","updated_at":"2016-11-21T13:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05be4a521d7c4a6f570b7b185ac8a71cdcf88a69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8/commits","review_comments_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8/comments","review_comment_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues/8/comments","statuses_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/statuses/278f7e5317416d232c4cc84173d30f0c42e5818e","head":{"label":"ateek:FullScreen","ref":"FullScreen","sha":"278f7e5317416d232c4cc84173d30f0c42e5818e","user":{"login":"ateek","id":6179699,"avatar_url":"https://avatars.githubusercontent.com/u/6179699?v=3","gravatar_id":"","url":"https://api.github.com/users/ateek","html_url":"https://github.com/ateek","followers_url":"https://api.github.com/users/ateek/followers","following_url":"https://api.github.com/users/ateek/following{/other_user}","gists_url":"https://api.github.com/users/ateek/gists{/gist_id}","starred_url":"https://api.github.com/users/ateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ateek/subscriptions","organizations_url":"https://api.github.com/users/ateek/orgs","repos_url":"https://api.github.com/users/ateek/repos","events_url":"https://api.github.com/users/ateek/events{/privacy}","received_events_url":"https://api.github.com/users/ateek/received_events","type":"User","site_admin":false},"repo":{"id":71223582,"name":"cordova-plugin-inappbrowser","full_name":"ateek/cordova-plugin-inappbrowser","owner":{"login":"ateek","id":6179699,"avatar_url":"https://avatars.githubusercontent.com/u/6179699?v=3","gravatar_id":"","url":"https://api.github.com/users/ateek","html_url":"https://github.com/ateek","followers_url":"https://api.github.com/users/ateek/followers","following_url":"https://api.github.com/users/ateek/following{/other_user}","gists_url":"https://api.github.com/users/ateek/gists{/gist_id}","starred_url":"https://api.github.com/users/ateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ateek/subscriptions","organizations_url":"https://api.github.com/users/ateek/orgs","repos_url":"https://api.github.com/users/ateek/repos","events_url":"https://api.github.com/users/ateek/events{/privacy}","received_events_url":"https://api.github.com/users/ateek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ateek/cordova-plugin-inappbrowser","description":"Mirror of Apache Cordova Plugin inappbrowser","fork":true,"url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser","forks_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/forks","keys_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/teams","hooks_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/hooks","issue_events_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/issues/events{/number}","events_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/events","assignees_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/assignees{/user}","branches_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/branches{/branch}","tags_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/tags","blobs_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/languages","stargazers_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/stargazers","contributors_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/contributors","subscribers_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/subscribers","subscription_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/subscription","commits_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/contents/{+path}","compare_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/merges","archive_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/downloads","issues_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/issues{/number}","pulls_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/labels{/name}","releases_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/releases{/id}","deployments_url":"https://api.github.com/repos/ateek/cordova-plugin-inappbrowser/deployments","created_at":"2016-10-18T08:02:08Z","updated_at":"2016-10-18T08:02:09Z","pushed_at":"2016-11-19T17:47:11Z","git_url":"git://github.com/ateek/cordova-plugin-inappbrowser.git","ssh_url":"git@github.com:ateek/cordova-plugin-inappbrowser.git","clone_url":"https://github.com/ateek/cordova-plugin-inappbrowser.git","svn_url":"https://github.com/ateek/cordova-plugin-inappbrowser","homepage":null,"size":711,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgalal:master","ref":"master","sha":"027c24d529ebfef8236f3b1e87875179acf40afd","user":{"login":"tgalal","id":895331,"avatar_url":"https://avatars.githubusercontent.com/u/895331?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalal","html_url":"https://github.com/tgalal","followers_url":"https://api.github.com/users/tgalal/followers","following_url":"https://api.github.com/users/tgalal/following{/other_user}","gists_url":"https://api.github.com/users/tgalal/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalal/subscriptions","organizations_url":"https://api.github.com/users/tgalal/orgs","repos_url":"https://api.github.com/users/tgalal/repos","events_url":"https://api.github.com/users/tgalal/events{/privacy}","received_events_url":"https://api.github.com/users/tgalal/received_events","type":"User","site_admin":false},"repo":{"id":27865761,"name":"cordova-plugin-inappbrowser","full_name":"tgalal/cordova-plugin-inappbrowser","owner":{"login":"tgalal","id":895331,"avatar_url":"https://avatars.githubusercontent.com/u/895331?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalal","html_url":"https://github.com/tgalal","followers_url":"https://api.github.com/users/tgalal/followers","following_url":"https://api.github.com/users/tgalal/following{/other_user}","gists_url":"https://api.github.com/users/tgalal/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalal/subscriptions","organizations_url":"https://api.github.com/users/tgalal/orgs","repos_url":"https://api.github.com/users/tgalal/repos","events_url":"https://api.github.com/users/tgalal/events{/privacy}","received_events_url":"https://api.github.com/users/tgalal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgalal/cordova-plugin-inappbrowser","description":"Mirror of Apache Cordova Plugin inappbrowser","fork":true,"url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser","forks_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/forks","keys_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/teams","hooks_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/hooks","issue_events_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues/events{/number}","events_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/events","assignees_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/assignees{/user}","branches_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/branches{/branch}","tags_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/tags","blobs_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/languages","stargazers_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/stargazers","contributors_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/contributors","subscribers_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/subscribers","subscription_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/subscription","commits_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/contents/{+path}","compare_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/merges","archive_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/downloads","issues_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues{/number}","pulls_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/labels{/name}","releases_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/releases{/id}","deployments_url":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/deployments","created_at":"2014-12-11T10:22:35Z","updated_at":"2016-04-07T10:09:17Z","pushed_at":"2016-11-21T10:33:31Z","git_url":"git://github.com/tgalal/cordova-plugin-inappbrowser.git","ssh_url":"git@github.com:tgalal/cordova-plugin-inappbrowser.git","clone_url":"https://github.com/tgalal/cordova-plugin-inappbrowser.git","svn_url":"https://github.com/tgalal/cordova-plugin-inappbrowser","homepage":null,"size":706,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8"},"html":{"href":"https://github.com/tgalal/cordova-plugin-inappbrowser/pull/8"},"issue":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues/8"},"comments":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/tgalal/cordova-plugin-inappbrowser/statuses/278f7e5317416d232c4cc84173d30f0c42e5818e"}}}}
{"actor":{"display_login":"tgalal"}}