{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/3101","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/3101/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/3101/comments","events_url":"https://api.github.com/repos/apple/swift/issues/3101/events","html_url":"https://github.com/apple/swift/pull/3101","id":161423408,"number":3101,"title":"[SourceKit] Remove dependency of SwiftLang on Core","user":{"login":"briancroom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?v=3","gravatar_id":"","url":"https://api.github.com/users/briancroom","html_url":"https://github.com/briancroom","followers_url":"https://api.github.com/users/briancroom/followers","following_url":"https://api.github.com/users/briancroom/following{/other_user}","gists_url":"https://api.github.com/users/briancroom/gists{/gist_id}","starred_url":"https://api.github.com/users/briancroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancroom/subscriptions","organizations_url":"https://api.github.com/users/briancroom/orgs","repos_url":"https://api.github.com/users/briancroom/repos","events_url":"https://api.github.com/users/briancroom/events{/privacy}","received_events_url":"https://api.github.com/users/briancroom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-21T12:26:55Z","updated_at":"2016-06-22T15:38:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3101","html_url":"https://github.com/apple/swift/pull/3101","diff_url":"https://github.com/apple/swift/pull/3101.diff","patch_url":"https://github.com/apple/swift/pull/3101.patch"},"body":"<!-- Please complete this template before creating pull request. -->\r\n#### What's in this pull request?\r\nSourceKit's `SwiftLang` (`SwiftLangSupport` class) and `Core` (`Context` class) libraries currently depend on each other. At @jrose-apple's suggestion, I have broken this coupling by requiring `SwiftLangSupport` to be injected into `Context`.\r\n\r\nSee also: https://github.com/apple/swift/pull/3080\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [ ] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/227784450","html_url":"https://github.com/apple/swift/pull/3101#issuecomment-227784450","issue_url":"https://api.github.com/repos/apple/swift/issues/3101","id":227784450,"user":{"login":"briancroom","id":1062518,"avatar_url":"https://avatars.githubusercontent.com/u/1062518?v=3","gravatar_id":"","url":"https://api.github.com/users/briancroom","html_url":"https://github.com/briancroom","followers_url":"https://api.github.com/users/briancroom/followers","following_url":"https://api.github.com/users/briancroom/following{/other_user}","gists_url":"https://api.github.com/users/briancroom/gists{/gist_id}","starred_url":"https://api.github.com/users/briancroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancroom/subscriptions","organizations_url":"https://api.github.com/users/briancroom/orgs","repos_url":"https://api.github.com/users/briancroom/repos","events_url":"https://api.github.com/users/briancroom/events{/privacy}","received_events_url":"https://api.github.com/users/briancroom/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T15:38:59Z","updated_at":"2016-06-22T15:38:59Z","body":"Ok, I've pushed a simplified version now based on @akyrtzi's suggestion. Note that I opted to keep the new `Factory.h` header, because the `SwiftLang` module had no public headers at all previously, and I wanted to avoid requiring clients to depend on the entire `SwiftLangSupport.h` header. Does that seem sensible?"}}
{"actor":{"display_login":"briancroom"}}