{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/cyrilis/epub-gen/pulls/28","id":81532468,"html_url":"https://github.com/cyrilis/epub-gen/pull/28","diff_url":"https://github.com/cyrilis/epub-gen/pull/28.diff","patch_url":"https://github.com/cyrilis/epub-gen/pull/28.patch","issue_url":"https://api.github.com/repos/cyrilis/epub-gen/issues/28","number":28,"state":"closed","locked":false,"title":"Encode HTML entities on content title","user":{"login":"pedrosanta","id":2737,"avatar_url":"https://avatars.githubusercontent.com/u/2737?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosanta","html_url":"https://github.com/pedrosanta","followers_url":"https://api.github.com/users/pedrosanta/followers","following_url":"https://api.github.com/users/pedrosanta/following{/other_user}","gists_url":"https://api.github.com/users/pedrosanta/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosanta/subscriptions","organizations_url":"https://api.github.com/users/pedrosanta/orgs","repos_url":"https://api.github.com/users/pedrosanta/repos","events_url":"https://api.github.com/users/pedrosanta/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosanta/received_events","type":"User","site_admin":false},"body":"Characters such as a simple `&` on a content title, weren't being properly encoded into its HTML entity `&amp;` and were making EPUB to fail validation.\n\nI've used the package `entities`, that's the same used by cheerio, to encode content titles (and authors) to prevent this.\n\nCan you give this a quick review @cyrilis? Thanks in advance, cheers! 😉 \n","created_at":"2016-08-16T19:46:18Z","updated_at":"2016-11-08T15:53:46Z","closed_at":"2016-11-08T15:53:46Z","merged_at":"2016-11-08T15:53:46Z","merge_commit_sha":"4342557a06e2c11e2b53c82b61b0020e4bd7848a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyrilis/epub-gen/pulls/28/commits","review_comments_url":"https://api.github.com/repos/cyrilis/epub-gen/pulls/28/comments","review_comment_url":"https://api.github.com/repos/cyrilis/epub-gen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyrilis/epub-gen/issues/28/comments","statuses_url":"https://api.github.com/repos/cyrilis/epub-gen/statuses/9c4e5437077ed9c3916c2513e79ae1aca7254702","head":{"label":"cyrilis:encode-content-title","ref":"encode-content-title","sha":"9c4e5437077ed9c3916c2513e79ae1aca7254702","user":{"login":"cyrilis","id":1834189,"avatar_url":"https://avatars.githubusercontent.com/u/1834189?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilis","html_url":"https://github.com/cyrilis","followers_url":"https://api.github.com/users/cyrilis/followers","following_url":"https://api.github.com/users/cyrilis/following{/other_user}","gists_url":"https://api.github.com/users/cyrilis/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilis/subscriptions","organizations_url":"https://api.github.com/users/cyrilis/orgs","repos_url":"https://api.github.com/users/cyrilis/repos","events_url":"https://api.github.com/users/cyrilis/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilis/received_events","type":"User","site_admin":false},"repo":{"id":30480615,"name":"epub-gen","full_name":"cyrilis/epub-gen","owner":{"login":"cyrilis","id":1834189,"avatar_url":"https://avatars.githubusercontent.com/u/1834189?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilis","html_url":"https://github.com/cyrilis","followers_url":"https://api.github.com/users/cyrilis/followers","following_url":"https://api.github.com/users/cyrilis/following{/other_user}","gists_url":"https://api.github.com/users/cyrilis/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilis/subscriptions","organizations_url":"https://api.github.com/users/cyrilis/orgs","repos_url":"https://api.github.com/users/cyrilis/repos","events_url":"https://api.github.com/users/cyrilis/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyrilis/epub-gen","description":"Generate EPUB books from HTML with simple API in Node.js.","fork":false,"url":"https://api.github.com/repos/cyrilis/epub-gen","forks_url":"https://api.github.com/repos/cyrilis/epub-gen/forks","keys_url":"https://api.github.com/repos/cyrilis/epub-gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrilis/epub-gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrilis/epub-gen/teams","hooks_url":"https://api.github.com/repos/cyrilis/epub-gen/hooks","issue_events_url":"https://api.github.com/repos/cyrilis/epub-gen/issues/events{/number}","events_url":"https://api.github.com/repos/cyrilis/epub-gen/events","assignees_url":"https://api.github.com/repos/cyrilis/epub-gen/assignees{/user}","branches_url":"https://api.github.com/repos/cyrilis/epub-gen/branches{/branch}","tags_url":"https://api.github.com/repos/cyrilis/epub-gen/tags","blobs_url":"https://api.github.com/repos/cyrilis/epub-gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrilis/epub-gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrilis/epub-gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrilis/epub-gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrilis/epub-gen/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrilis/epub-gen/languages","stargazers_url":"https://api.github.com/repos/cyrilis/epub-gen/stargazers","contributors_url":"https://api.github.com/repos/cyrilis/epub-gen/contributors","subscribers_url":"https://api.github.com/repos/cyrilis/epub-gen/subscribers","subscription_url":"https://api.github.com/repos/cyrilis/epub-gen/subscription","commits_url":"https://api.github.com/repos/cyrilis/epub-gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrilis/epub-gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrilis/epub-gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrilis/epub-gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrilis/epub-gen/contents/{+path}","compare_url":"https://api.github.com/repos/cyrilis/epub-gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrilis/epub-gen/merges","archive_url":"https://api.github.com/repos/cyrilis/epub-gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrilis/epub-gen/downloads","issues_url":"https://api.github.com/repos/cyrilis/epub-gen/issues{/number}","pulls_url":"https://api.github.com/repos/cyrilis/epub-gen/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrilis/epub-gen/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrilis/epub-gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrilis/epub-gen/labels{/name}","releases_url":"https://api.github.com/repos/cyrilis/epub-gen/releases{/id}","deployments_url":"https://api.github.com/repos/cyrilis/epub-gen/deployments","created_at":"2015-02-08T04:25:00Z","updated_at":"2016-11-05T00:36:32Z","pushed_at":"2016-11-08T15:53:46Z","git_url":"git://github.com/cyrilis/epub-gen.git","ssh_url":"git@github.com:cyrilis/epub-gen.git","clone_url":"https://github.com/cyrilis/epub-gen.git","svn_url":"https://github.com/cyrilis/epub-gen","homepage":"","size":933,"stargazers_count":51,"watchers_count":51,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":14,"forks":15,"open_issues":14,"watchers":51,"default_branch":"master"}},"base":{"label":"cyrilis:master","ref":"master","sha":"79f313f2b6eb05cc439b1a9d6886a188ac7316f5","user":{"login":"cyrilis","id":1834189,"avatar_url":"https://avatars.githubusercontent.com/u/1834189?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilis","html_url":"https://github.com/cyrilis","followers_url":"https://api.github.com/users/cyrilis/followers","following_url":"https://api.github.com/users/cyrilis/following{/other_user}","gists_url":"https://api.github.com/users/cyrilis/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilis/subscriptions","organizations_url":"https://api.github.com/users/cyrilis/orgs","repos_url":"https://api.github.com/users/cyrilis/repos","events_url":"https://api.github.com/users/cyrilis/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilis/received_events","type":"User","site_admin":false},"repo":{"id":30480615,"name":"epub-gen","full_name":"cyrilis/epub-gen","owner":{"login":"cyrilis","id":1834189,"avatar_url":"https://avatars.githubusercontent.com/u/1834189?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilis","html_url":"https://github.com/cyrilis","followers_url":"https://api.github.com/users/cyrilis/followers","following_url":"https://api.github.com/users/cyrilis/following{/other_user}","gists_url":"https://api.github.com/users/cyrilis/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilis/subscriptions","organizations_url":"https://api.github.com/users/cyrilis/orgs","repos_url":"https://api.github.com/users/cyrilis/repos","events_url":"https://api.github.com/users/cyrilis/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyrilis/epub-gen","description":"Generate EPUB books from HTML with simple API in Node.js.","fork":false,"url":"https://api.github.com/repos/cyrilis/epub-gen","forks_url":"https://api.github.com/repos/cyrilis/epub-gen/forks","keys_url":"https://api.github.com/repos/cyrilis/epub-gen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyrilis/epub-gen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyrilis/epub-gen/teams","hooks_url":"https://api.github.com/repos/cyrilis/epub-gen/hooks","issue_events_url":"https://api.github.com/repos/cyrilis/epub-gen/issues/events{/number}","events_url":"https://api.github.com/repos/cyrilis/epub-gen/events","assignees_url":"https://api.github.com/repos/cyrilis/epub-gen/assignees{/user}","branches_url":"https://api.github.com/repos/cyrilis/epub-gen/branches{/branch}","tags_url":"https://api.github.com/repos/cyrilis/epub-gen/tags","blobs_url":"https://api.github.com/repos/cyrilis/epub-gen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyrilis/epub-gen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyrilis/epub-gen/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyrilis/epub-gen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyrilis/epub-gen/statuses/{sha}","languages_url":"https://api.github.com/repos/cyrilis/epub-gen/languages","stargazers_url":"https://api.github.com/repos/cyrilis/epub-gen/stargazers","contributors_url":"https://api.github.com/repos/cyrilis/epub-gen/contributors","subscribers_url":"https://api.github.com/repos/cyrilis/epub-gen/subscribers","subscription_url":"https://api.github.com/repos/cyrilis/epub-gen/subscription","commits_url":"https://api.github.com/repos/cyrilis/epub-gen/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyrilis/epub-gen/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyrilis/epub-gen/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyrilis/epub-gen/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyrilis/epub-gen/contents/{+path}","compare_url":"https://api.github.com/repos/cyrilis/epub-gen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyrilis/epub-gen/merges","archive_url":"https://api.github.com/repos/cyrilis/epub-gen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyrilis/epub-gen/downloads","issues_url":"https://api.github.com/repos/cyrilis/epub-gen/issues{/number}","pulls_url":"https://api.github.com/repos/cyrilis/epub-gen/pulls{/number}","milestones_url":"https://api.github.com/repos/cyrilis/epub-gen/milestones{/number}","notifications_url":"https://api.github.com/repos/cyrilis/epub-gen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyrilis/epub-gen/labels{/name}","releases_url":"https://api.github.com/repos/cyrilis/epub-gen/releases{/id}","deployments_url":"https://api.github.com/repos/cyrilis/epub-gen/deployments","created_at":"2015-02-08T04:25:00Z","updated_at":"2016-11-05T00:36:32Z","pushed_at":"2016-11-08T15:53:46Z","git_url":"git://github.com/cyrilis/epub-gen.git","ssh_url":"git@github.com:cyrilis/epub-gen.git","clone_url":"https://github.com/cyrilis/epub-gen.git","svn_url":"https://github.com/cyrilis/epub-gen","homepage":"","size":933,"stargazers_count":51,"watchers_count":51,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":14,"forks":15,"open_issues":14,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyrilis/epub-gen/pulls/28"},"html":{"href":"https://github.com/cyrilis/epub-gen/pull/28"},"issue":{"href":"https://api.github.com/repos/cyrilis/epub-gen/issues/28"},"comments":{"href":"https://api.github.com/repos/cyrilis/epub-gen/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/cyrilis/epub-gen/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/cyrilis/epub-gen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyrilis/epub-gen/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/cyrilis/epub-gen/statuses/9c4e5437077ed9c3916c2513e79ae1aca7254702"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cyrilis","id":1834189,"avatar_url":"https://avatars.githubusercontent.com/u/1834189?v=3","gravatar_id":"","url":"https://api.github.com/users/cyrilis","html_url":"https://github.com/cyrilis","followers_url":"https://api.github.com/users/cyrilis/followers","following_url":"https://api.github.com/users/cyrilis/following{/other_user}","gists_url":"https://api.github.com/users/cyrilis/gists{/gist_id}","starred_url":"https://api.github.com/users/cyrilis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyrilis/subscriptions","organizations_url":"https://api.github.com/users/cyrilis/orgs","repos_url":"https://api.github.com/users/cyrilis/repos","events_url":"https://api.github.com/users/cyrilis/events{/privacy}","received_events_url":"https://api.github.com/users/cyrilis/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":13,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"cyrilis"}}