{"action":"created","issue":{"url":"https://api.github.com/repos/mafintosh/playback/issues/86","repository_url":"https://api.github.com/repos/mafintosh/playback","labels_url":"https://api.github.com/repos/mafintosh/playback/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/mafintosh/playback/issues/86/comments","events_url":"https://api.github.com/repos/mafintosh/playback/issues/86/events","html_url":"https://github.com/mafintosh/playback/pull/86","id":134678433,"number":86,"title":"Split out server/controller process from renderer process (and more)","user":{"login":"bmathews","id":848347,"avatar_url":"https://avatars.githubusercontent.com/u/848347?v=3","gravatar_id":"","url":"https://api.github.com/users/bmathews","html_url":"https://github.com/bmathews","followers_url":"https://api.github.com/users/bmathews/followers","following_url":"https://api.github.com/users/bmathews/following{/other_user}","gists_url":"https://api.github.com/users/bmathews/gists{/gist_id}","starred_url":"https://api.github.com/users/bmathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmathews/subscriptions","organizations_url":"https://api.github.com/users/bmathews/orgs","repos_url":"https://api.github.com/users/bmathews/repos","events_url":"https://api.github.com/users/bmathews/events{/privacy}","received_events_url":"https://api.github.com/users/bmathews/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-18T19:52:04Z","updated_at":"2016-03-09T21:12:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mafintosh/playback/pulls/86","html_url":"https://github.com/mafintosh/playback/pull/86","diff_url":"https://github.com/mafintosh/playback/pull/86.diff","patch_url":"https://github.com/mafintosh/playback/pull/86.patch"},"body":"There's a lot here, but I'd like to get some feedback and have people test this out. This improves code quality, manageability, and stability/behavior of the app. Browse the code here: https://github.com/bmathews/playback/tree/refactor-rebase/app\r\n\r\nThe new command to run things is `npm run dev`\r\n\r\n__Changes:__\r\n- Split out server/controller process from renderer process #58\r\n  - Communication is done via IPC\r\n- Split out loaders\r\n- Split out 'players' into swappable interface\r\n  - Have webchimera working in a different branch, but I haven't been able to get webchimera to package into a .app properly. #75\r\n- Use React for UI\r\n- Adds eslint for code style/quality consistency\r\n- Various UI/UX improvements\r\n- Added media hotkey support\r\n- Improved styling of titlebar to better match Yosemite.\r\n- Improved responsive/wrapping behavior of controls #30\r\n- Added 'loading' and 'buffering' indicators for various actions #18\r\n- Added buffer progress to timeline #49\r\n- Change how drag is done #74\r\n- Change how youtube videos are loaded, choosing a higher resolution codec when possible.\r\n- Gets us _really_ close to a mobile/desktop remote web UI, since the UI has basically no knowledge of electron #37\r\n\r\n![image](https://cloud.githubusercontent.com/assets/848347/13156037/61aa5916-d635-11e5-9c12-552a4bd7a9f3.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/848347/13156101/b4753c24-d635-11e5-8b35-2d36798d7602.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/848347/13155955/11e6162c-d635-11e5-9f42-17b16fab1b69.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/848347/13156051/6faf43c8-d635-11e5-8327-cae483eb7172.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/848347/13156066/8453bc14-d635-11e5-857c-1f95bc15bc67.png)"},"comment":{"url":"https://api.github.com/repos/mafintosh/playback/issues/comments/194508638","html_url":"https://github.com/mafintosh/playback/pull/86#issuecomment-194508638","issue_url":"https://api.github.com/repos/mafintosh/playback/issues/86","id":194508638,"user":{"login":"freeall","id":376654,"avatar_url":"https://avatars.githubusercontent.com/u/376654?v=3","gravatar_id":"","url":"https://api.github.com/users/freeall","html_url":"https://github.com/freeall","followers_url":"https://api.github.com/users/freeall/followers","following_url":"https://api.github.com/users/freeall/following{/other_user}","gists_url":"https://api.github.com/users/freeall/gists{/gist_id}","starred_url":"https://api.github.com/users/freeall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeall/subscriptions","organizations_url":"https://api.github.com/users/freeall/orgs","repos_url":"https://api.github.com/users/freeall/repos","events_url":"https://api.github.com/users/freeall/events{/privacy}","received_events_url":"https://api.github.com/users/freeall/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T21:12:13Z","updated_at":"2016-03-09T21:12:13Z","body":"I'm a little conflicted on this one. It's really good to see some activity on the project, and I love the fact that it's rewritten to React. On the other hand I don't like that in the same PR the code's been rewritten to ES6 and we now use Babel.\r\n\r\nIf I were to comment on just the style it's more frontend javascript than node which is probably fine in itself, but it changes the whole codebase and I would rather have that discussion in a PR for itself.\r\n\r\nJust to get more activity on this I'd say we should merge it, though. Thoughts?"}}