{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/socorro/issues/3451","repository_url":"https://api.github.com/repos/mozilla/socorro","labels_url":"https://api.github.com/repos/mozilla/socorro/issues/3451/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/socorro/issues/3451/comments","events_url":"https://api.github.com/repos/mozilla/socorro/issues/3451/events","html_url":"https://github.com/mozilla/socorro/pull/3451","id":173930789,"number":3451,"title":"fixes bug 1298969","user":{"login":"lonnen","id":21467,"avatar_url":"https://avatars.githubusercontent.com/u/21467?v=3","gravatar_id":"","url":"https://api.github.com/users/lonnen","html_url":"https://github.com/lonnen","followers_url":"https://api.github.com/users/lonnen/followers","following_url":"https://api.github.com/users/lonnen/following{/other_user}","gists_url":"https://api.github.com/users/lonnen/gists{/gist_id}","starred_url":"https://api.github.com/users/lonnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonnen/subscriptions","organizations_url":"https://api.github.com/users/lonnen/orgs","repos_url":"https://api.github.com/users/lonnen/repos","events_url":"https://api.github.com/users/lonnen/events{/privacy}","received_events_url":"https://api.github.com/users/lonnen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-30T05:06:15Z","updated_at":"2016-08-30T21:28:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/socorro/pulls/3451","html_url":"https://github.com/mozilla/socorro/pull/3451","diff_url":"https://github.com/mozilla/socorro/pull/3451.diff","patch_url":"https://github.com/mozilla/socorro/pull/3451.patch"},"body":"removes the earlier attempt to use min-height and replaces it with a flexbox based approach that ensures the footer appears either below the content or at the bottom of the page\r\n\r\nMy local env is hosed so this needs a little extra testing. I've checked this change against the main page and search page using dev tools. If something is broken it will not be subtle -- after landing, load the main page, search, topcrasher, daily, report list, and report index to check. You may want to use devtools to remove a div panel or two in order to make room.\r\n\r\nBefore:\r\n<img width=\"852\" alt=\"screenshot 2016-08-29 15 05 03-2\" src=\"https://cloud.githubusercontent.com/assets/21467/18076667/be6bcbde-6e34-11e6-82de-02027dfea1a4.png\">\r\n\r\n\r\nAfter:\r\n<img width=\"950\" alt=\"screenshot 2016-08-29 15 09 52\" src=\"https://cloud.githubusercontent.com/assets/21467/18076618/7165538c-6e34-11e6-9d7e-310884b3a3cf.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/socorro/issues/comments/243587195","html_url":"https://github.com/mozilla/socorro/pull/3451#issuecomment-243587195","issue_url":"https://api.github.com/repos/mozilla/socorro/issues/3451","id":243587195,"user":{"login":"lonnen","id":21467,"avatar_url":"https://avatars.githubusercontent.com/u/21467?v=3","gravatar_id":"","url":"https://api.github.com/users/lonnen","html_url":"https://github.com/lonnen","followers_url":"https://api.github.com/users/lonnen/followers","following_url":"https://api.github.com/users/lonnen/following{/other_user}","gists_url":"https://api.github.com/users/lonnen/gists{/gist_id}","starred_url":"https://api.github.com/users/lonnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonnen/subscriptions","organizations_url":"https://api.github.com/users/lonnen/orgs","repos_url":"https://api.github.com/users/lonnen/repos","events_url":"https://api.github.com/users/lonnen/events{/privacy}","received_events_url":"https://api.github.com/users/lonnen/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T21:28:48Z","updated_at":"2016-08-30T21:28:48Z","body":"Good catch! See my commit message on the second commit. This should resolve it.\r\n\r\nI initially wrote this between meetings during the workday, noticed an issue on search with the `height: 100%` approach, and then forgot about it in my hustle to make a patch before bed at the end of the day."}}
{"actor":{"display_login":"lonnen"}}