{"action":"closed","number":339,"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/339","id":74107711,"html_url":"https://github.com/apache/tinkerpop/pull/339","diff_url":"https://github.com/apache/tinkerpop/pull/339.diff","patch_url":"https://github.com/apache/tinkerpop/pull/339.patch","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/339","number":339,"state":"closed","locked":false,"title":"TINKERPOP-939 Added docs for Neo4j HA configuration.","user":{"login":"spmallette","id":384249,"avatar_url":"https://avatars.githubusercontent.com/u/384249?v=3","gravatar_id":"","url":"https://api.github.com/users/spmallette","html_url":"https://github.com/spmallette","followers_url":"https://api.github.com/users/spmallette/followers","following_url":"https://api.github.com/users/spmallette/following{/other_user}","gists_url":"https://api.github.com/users/spmallette/gists{/gist_id}","starred_url":"https://api.github.com/users/spmallette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spmallette/subscriptions","organizations_url":"https://api.github.com/users/spmallette/orgs","repos_url":"https://api.github.com/users/spmallette/repos","events_url":"https://api.github.com/users/spmallette/events{/privacy}","received_events_url":"https://api.github.com/users/spmallette/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/TINKERPOP-939\r\n\r\nI manually tested this with a local 3 node cluster both in Gremlin Console and in Gremlin Server. Everything seems to work fine. I basically just wrote some basic docs for how to setup but since TinkerPop is really just a pass through for configuration options, most of the docs for \"how\" are on the Neo4j side.\r\n\r\nI don't know that there is a way to do testing for this on our current framework or if there is a ton of value to doing so as this is all pass through - we don't even use a separate \"HA Graph instance\" like we did in Blueprints. Thoughts welcome on that matter....\r\n\r\nPersonally, I think the docs are enough for now to close this old issue. If we really want tests we could open a new issue to write some \"integration\" tests that do some basic checks and would stand apart from the standard framework. So based on that....\r\n\r\nVOTE +1","created_at":"2016-06-16T16:03:29Z","updated_at":"2016-06-17T10:25:21Z","closed_at":"2016-06-17T10:25:21Z","merged_at":"2016-06-17T10:25:21Z","merge_commit_sha":"6220653868fc0c00a397456f9b7cceae82c3cb4a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/tinkerpop/pulls/339/commits","review_comments_url":"https://api.github.com/repos/apache/tinkerpop/pulls/339/comments","review_comment_url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/339/comments","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/6220653868fc0c00a397456f9b7cceae82c3cb4a","head":{"label":"apache:TINKERPOP-939","ref":"TINKERPOP-939","sha":"6220653868fc0c00a397456f9b7cceae82c3cb4a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2016-06-13T06:08:39Z","pushed_at":"2016-06-17T10:25:20Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":113145,"stargazers_count":172,"watchers_count":172,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":"git://git.apache.org/incubator-tinkerpop.git","open_issues_count":8,"forks":123,"open_issues":8,"watchers":172,"default_branch":"master"}},"base":{"label":"apache:tp31","ref":"tp31","sha":"84f2d63d7b758c21bb22a6d771d57479fce3d06b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2016-06-13T06:08:39Z","pushed_at":"2016-06-17T10:25:20Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":113145,"stargazers_count":172,"watchers_count":172,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":"git://git.apache.org/incubator-tinkerpop.git","open_issues_count":8,"forks":123,"open_issues":8,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/339"},"html":{"href":"https://github.com/apache/tinkerpop/pull/339"},"issue":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/339"},"comments":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tinkerpop/statuses/6220653868fc0c00a397456f9b7cceae82c3cb4a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"asfgit","id":1341245,"avatar_url":"https://avatars.githubusercontent.com/u/1341245?v=3","gravatar_id":"","url":"https://api.github.com/users/asfgit","html_url":"https://github.com/asfgit","followers_url":"https://api.github.com/users/asfgit/followers","following_url":"https://api.github.com/users/asfgit/following{/other_user}","gists_url":"https://api.github.com/users/asfgit/gists{/gist_id}","starred_url":"https://api.github.com/users/asfgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfgit/subscriptions","organizations_url":"https://api.github.com/users/asfgit/orgs","repos_url":"https://api.github.com/users/asfgit/repos","events_url":"https://api.github.com/users/asfgit/events{/privacy}","received_events_url":"https://api.github.com/users/asfgit/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":74,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"asfgit"}}