{"action":"created","issue":{"url":"https://api.github.com/repos/govCMS/govCMS/issues/47","repository_url":"https://api.github.com/repos/govCMS/govCMS","labels_url":"https://api.github.com/repos/govCMS/govCMS/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/govCMS/govCMS/issues/47/comments","events_url":"https://api.github.com/repos/govCMS/govCMS/issues/47/events","html_url":"https://github.com/govCMS/govCMS/pull/47","id":104835018,"number":47,"title":"Remove conditional classes","user":{"login":"MadeByMike","id":1320567,"avatar_url":"https://avatars.githubusercontent.com/u/1320567?v=3","gravatar_id":"","url":"https://api.github.com/users/MadeByMike","html_url":"https://github.com/MadeByMike","followers_url":"https://api.github.com/users/MadeByMike/followers","following_url":"https://api.github.com/users/MadeByMike/following{/other_user}","gists_url":"https://api.github.com/users/MadeByMike/gists{/gist_id}","starred_url":"https://api.github.com/users/MadeByMike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadeByMike/subscriptions","organizations_url":"https://api.github.com/users/MadeByMike/orgs","repos_url":"https://api.github.com/users/MadeByMike/repos","events_url":"https://api.github.com/users/MadeByMike/events{/privacy}","received_events_url":"https://api.github.com/users/MadeByMike/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/govCMS/govCMS/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/govCMS/govCMS/labels/good-idea","name":"good-idea","color":"5319e7"},{"url":"https://api.github.com/repos/govCMS/govCMS/labels/ux","name":"ux","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-09-04T05:59:08Z","updated_at":"2016-02-09T00:06:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/govCMS/govCMS/pulls/47","html_url":"https://github.com/govCMS/govCMS/pull/47","diff_url":"https://github.com/govCMS/govCMS/pull/47.diff","patch_url":"https://github.com/govCMS/govCMS/pull/47.patch"},"body":"I think you should strongly consider removing conditional classes all together with feature detection being a strong preference over browser targeting. See reasons here: http://www.impressivewebs.com/conditional-comments-classes-ie/\r\n\r\nThe only class name required by the stylesheets appears to be \"lt-ie9\". You could add a few others if you intended these to be hooks for further development so feel free to modify this PR but there is no situation where IE7Mobile or ie6 should need to be accounted for."},"comment":{"url":"https://api.github.com/repos/govCMS/govCMS/issues/comments/181633729","html_url":"https://github.com/govCMS/govCMS/pull/47#issuecomment-181633729","issue_url":"https://api.github.com/repos/govCMS/govCMS/issues/47","id":181633729,"user":{"login":"jozhao","id":1326673,"avatar_url":"https://avatars.githubusercontent.com/u/1326673?v=3","gravatar_id":"","url":"https://api.github.com/users/jozhao","html_url":"https://github.com/jozhao","followers_url":"https://api.github.com/users/jozhao/followers","following_url":"https://api.github.com/users/jozhao/following{/other_user}","gists_url":"https://api.github.com/users/jozhao/gists{/gist_id}","starred_url":"https://api.github.com/users/jozhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jozhao/subscriptions","organizations_url":"https://api.github.com/users/jozhao/orgs","repos_url":"https://api.github.com/users/jozhao/repos","events_url":"https://api.github.com/users/jozhao/events{/privacy}","received_events_url":"https://api.github.com/users/jozhao/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T00:06:33Z","updated_at":"2016-02-09T00:06:33Z","body":"It is an interesting post from Louis Lazaris http://www.impressivewebs.com/conditional-comments-classes-ie/ \r\n\r\nPaul Irish (who is from Google Chrome team) also has a blog post that lists full discussions and thoughts regarding \"conditional stylesheets and CSS hacks\" http://www.paulirish.com/2008/conditional-stylesheets-vs-css-hacks-answer-neither/\r\n\r\nWe are using \"Zen\" as a base theme for govCMS starter kit, and notes in the \"Zen\" starterkit.info.txt file\r\n\r\n> ; Built-in conditional stylesheet support has been removed from Zen 7.x-5.x.\r\n; Instead, Zen now adds conditional-comment-included classes to the html\r\n; element, such as .lt-ie9, .lt-ie8, .lt-ie7. \r\n\r\nI would like to suggest that we follows the guidelines in our offical themes while Zen is used as a base theme. In another word, designers and developers can always alter them in custom theme template (html.tpl.php)."}}