{"action":"opened","number":587,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/587","id":61857730,"html_url":"https://github.com/grpc/grpc-go/pull/587","diff_url":"https://github.com/grpc/grpc-go/pull/587.diff","patch_url":"https://github.com/grpc/grpc-go/pull/587.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/587","number":587,"state":"open","locked":false,"title":"transport: performance improvements","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"Some naive optimizations.\r\n\r\nBenchmarked using https://github.com/cockroachdb/rpc-bench.\r\n\r\n```\r\nname                 old time/op    new time/op    delta\r\nGRPCServeHTTP_1K-4      181µs ± 3%     177µs ± 1%     ~     (p=0.095 n=5+5)\r\nGRPCServeHTTP_64K-4    1.31ms ± 4%    1.09ms ± 4%  -16.97%  (p=0.008 n=5+5)\r\n\r\nname                 old speed      new speed      delta\r\nGRPCServeHTTP_1K-4   11.3MB/s ± 3%  11.6MB/s ± 1%     ~     (p=0.095 n=5+5)\r\nGRPCServeHTTP_64K-4   100MB/s ± 4%   121MB/s ± 4%  +20.46%  (p=0.008 n=5+5)\r\n\r\nname                 old alloc/op   new alloc/op   delta\r\nGRPCServeHTTP_1K-4     88.5kB ± 0%    93.9kB ± 0%   +6.07%  (p=0.008 n=5+5)\r\nGRPCServeHTTP_64K-4     801kB ± 0%     791kB ± 0%   -1.21%  (p=0.008 n=5+5)\r\n\r\nname                 old allocs/op  new allocs/op  delta\r\nGRPCServeHTTP_1K-4        167 ± 0%       156 ± 0%   -6.59%  (p=0.008 n=5+5)\r\nGRPCServeHTTP_64K-4       672 ± 0%       284 ± 0%  -57.75%  (p=0.016 n=5+4)\r\n```\r\n\r\n@iamqizhao @bradfitz ","created_at":"2016-03-06T22:37:09Z","updated_at":"2016-03-06T22:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/587/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/587/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/587/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/95df9dcccf0651b00a065eb53dcd2cd149bc1d7c","head":{"label":"tamird:perf","ref":"perf","sha":"95df9dcccf0651b00a065eb53dcd2cd149bc1d7c","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":42019024,"name":"grpc-go","full_name":"tamird/grpc-go","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/tamird/grpc-go","forks_url":"https://api.github.com/repos/tamird/grpc-go/forks","keys_url":"https://api.github.com/repos/tamird/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/grpc-go/teams","hooks_url":"https://api.github.com/repos/tamird/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/tamird/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/grpc-go/events","assignees_url":"https://api.github.com/repos/tamird/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/grpc-go/tags","blobs_url":"https://api.github.com/repos/tamird/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/grpc-go/languages","stargazers_url":"https://api.github.com/repos/tamird/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/tamird/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/tamird/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/tamird/grpc-go/subscription","commits_url":"https://api.github.com/repos/tamird/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/grpc-go/merges","archive_url":"https://api.github.com/repos/tamird/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/grpc-go/downloads","issues_url":"https://api.github.com/repos/tamird/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/tamird/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/tamird/grpc-go/deployments","created_at":"2015-09-06T21:12:47Z","updated_at":"2016-02-04T22:34:08Z","pushed_at":"2016-03-06T22:30:56Z","git_url":"git://github.com/tamird/grpc-go.git","ssh_url":"git@github.com:tamird/grpc-go.git","clone_url":"https://github.com/tamird/grpc-go.git","svn_url":"https://github.com/tamird/grpc-go","homepage":"","size":1541,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"fea7689493da00c4590150b3534c256a962259d3","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-03-06T05:50:57Z","pushed_at":"2016-03-06T22:37:09Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":2111,"stargazers_count":1534,"watchers_count":1534,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":205,"mirror_url":null,"open_issues_count":52,"forks":205,"open_issues":52,"watchers":1534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/587"},"html":{"href":"https://github.com/grpc/grpc-go/pull/587"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/587"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/95df9dcccf0651b00a065eb53dcd2cd149bc1d7c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":22,"deletions":26,"changed_files":3}}