{"action":"closed","number":172,"pull_request":{"url":"https://api.github.com/repos/kwsch/PKHeX/pulls/172","id":80809446,"html_url":"https://github.com/kwsch/PKHeX/pull/172","diff_url":"https://github.com/kwsch/PKHeX/pull/172.diff","patch_url":"https://github.com/kwsch/PKHeX/pull/172.patch","issue_url":"https://api.github.com/repos/kwsch/PKHeX/issues/172","number":172,"state":"closed","locked":false,"title":"Refactoring: Met Date Property & Tests","user":{"login":"evandixon","id":2699524,"avatar_url":"https://avatars.githubusercontent.com/u/2699524?v=3","gravatar_id":"","url":"https://api.github.com/users/evandixon","html_url":"https://github.com/evandixon","followers_url":"https://api.github.com/users/evandixon/followers","following_url":"https://api.github.com/users/evandixon/following{/other_user}","gists_url":"https://api.github.com/users/evandixon/gists{/gist_id}","starred_url":"https://api.github.com/users/evandixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evandixon/subscriptions","organizations_url":"https://api.github.com/users/evandixon/orgs","repos_url":"https://api.github.com/users/evandixon/repos","events_url":"https://api.github.com/users/evandixon/events{/privacy}","received_events_url":"https://api.github.com/users/evandixon/received_events","type":"User","site_admin":false},"body":"This is a seemingly big change, but I don't think it's as bad as it looks.\r\n\r\nAlso addresses Issue #171\r\n## Changes\r\n### Moves PKHeX project to its own directory\r\nInstead of having the solution and project in the root, the project is now in a sub-directory.  This makes it easy to add more projects, like unit tests.\r\n### MetDate\r\nThe UI can now have a higher-level knowledge of the met date, not having to manually interact with year, month, and date components.  The components are now protected, since it's the class's job to do low-level data access.  Outside the class, there's now a single property of type `DateTime?`.  Just set that to your target date, and this new property will take care of everything.  Setting it to null will zero out the components, previously done in the main forms when a Pokémon is still an egg.\r\n\r\nThis change affects `PKM`, `PGF`, and `WC6`.\r\n### Tests\r\nI've added tests for my new code, to help ensure things don't break.  Now that there's a test project, it may be easier for others to write new tests too.  (Yes, I know they're annoying to write, but they help prevent bugs and regression.)\r\n\r\nI didn't add tests for the new property in `PGF` and `WC6`, since the property does the same thing.  If anyone *wants* a test for that property, I can write one before this PR is completed.","created_at":"2016-08-10T14:58:07Z","updated_at":"2016-08-10T15:58:02Z","closed_at":"2016-08-10T15:58:02Z","merged_at":"2016-08-10T15:58:02Z","merge_commit_sha":"43cf2370f2e32f059a9f8e5840fed20bad9749d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/172/commits","review_comments_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/172/comments","review_comment_url":"https://api.github.com/repos/kwsch/PKHeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kwsch/PKHeX/issues/172/comments","statuses_url":"https://api.github.com/repos/kwsch/PKHeX/statuses/98c86ddb7acf9208d4917502ac7f02a5be403519","head":{"label":"kwsch:f/refactoring","ref":"f/refactoring","sha":"98c86ddb7acf9208d4917502ac7f02a5be403519","user":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"repo":{"id":21311240,"name":"PKHeX","full_name":"kwsch/PKHeX","owner":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwsch/PKHeX","description":"Pokémon GBA/NDS/3DS Save Editor","fork":false,"url":"https://api.github.com/repos/kwsch/PKHeX","forks_url":"https://api.github.com/repos/kwsch/PKHeX/forks","keys_url":"https://api.github.com/repos/kwsch/PKHeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwsch/PKHeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwsch/PKHeX/teams","hooks_url":"https://api.github.com/repos/kwsch/PKHeX/hooks","issue_events_url":"https://api.github.com/repos/kwsch/PKHeX/issues/events{/number}","events_url":"https://api.github.com/repos/kwsch/PKHeX/events","assignees_url":"https://api.github.com/repos/kwsch/PKHeX/assignees{/user}","branches_url":"https://api.github.com/repos/kwsch/PKHeX/branches{/branch}","tags_url":"https://api.github.com/repos/kwsch/PKHeX/tags","blobs_url":"https://api.github.com/repos/kwsch/PKHeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwsch/PKHeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwsch/PKHeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwsch/PKHeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwsch/PKHeX/statuses/{sha}","languages_url":"https://api.github.com/repos/kwsch/PKHeX/languages","stargazers_url":"https://api.github.com/repos/kwsch/PKHeX/stargazers","contributors_url":"https://api.github.com/repos/kwsch/PKHeX/contributors","subscribers_url":"https://api.github.com/repos/kwsch/PKHeX/subscribers","subscription_url":"https://api.github.com/repos/kwsch/PKHeX/subscription","commits_url":"https://api.github.com/repos/kwsch/PKHeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwsch/PKHeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwsch/PKHeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwsch/PKHeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwsch/PKHeX/contents/{+path}","compare_url":"https://api.github.com/repos/kwsch/PKHeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwsch/PKHeX/merges","archive_url":"https://api.github.com/repos/kwsch/PKHeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwsch/PKHeX/downloads","issues_url":"https://api.github.com/repos/kwsch/PKHeX/issues{/number}","pulls_url":"https://api.github.com/repos/kwsch/PKHeX/pulls{/number}","milestones_url":"https://api.github.com/repos/kwsch/PKHeX/milestones{/number}","notifications_url":"https://api.github.com/repos/kwsch/PKHeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwsch/PKHeX/labels{/name}","releases_url":"https://api.github.com/repos/kwsch/PKHeX/releases{/id}","deployments_url":"https://api.github.com/repos/kwsch/PKHeX/deployments","created_at":"2014-06-28T21:20:30Z","updated_at":"2016-08-07T16:57:14Z","pushed_at":"2016-08-10T15:58:01Z","git_url":"git://github.com/kwsch/PKHeX.git","ssh_url":"git@github.com:kwsch/PKHeX.git","clone_url":"https://github.com/kwsch/PKHeX.git","svn_url":"https://github.com/kwsch/PKHeX","homepage":"http://projectpokemon.org/forums/showthread.php?36986","size":11053,"stargazers_count":152,"watchers_count":152,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":9,"forks":82,"open_issues":9,"watchers":152,"default_branch":"master"}},"base":{"label":"kwsch:master","ref":"master","sha":"ef904c889f3f672573e3e09da18011fd923ff549","user":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"repo":{"id":21311240,"name":"PKHeX","full_name":"kwsch/PKHeX","owner":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwsch/PKHeX","description":"Pokémon GBA/NDS/3DS Save Editor","fork":false,"url":"https://api.github.com/repos/kwsch/PKHeX","forks_url":"https://api.github.com/repos/kwsch/PKHeX/forks","keys_url":"https://api.github.com/repos/kwsch/PKHeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwsch/PKHeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwsch/PKHeX/teams","hooks_url":"https://api.github.com/repos/kwsch/PKHeX/hooks","issue_events_url":"https://api.github.com/repos/kwsch/PKHeX/issues/events{/number}","events_url":"https://api.github.com/repos/kwsch/PKHeX/events","assignees_url":"https://api.github.com/repos/kwsch/PKHeX/assignees{/user}","branches_url":"https://api.github.com/repos/kwsch/PKHeX/branches{/branch}","tags_url":"https://api.github.com/repos/kwsch/PKHeX/tags","blobs_url":"https://api.github.com/repos/kwsch/PKHeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwsch/PKHeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwsch/PKHeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwsch/PKHeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwsch/PKHeX/statuses/{sha}","languages_url":"https://api.github.com/repos/kwsch/PKHeX/languages","stargazers_url":"https://api.github.com/repos/kwsch/PKHeX/stargazers","contributors_url":"https://api.github.com/repos/kwsch/PKHeX/contributors","subscribers_url":"https://api.github.com/repos/kwsch/PKHeX/subscribers","subscription_url":"https://api.github.com/repos/kwsch/PKHeX/subscription","commits_url":"https://api.github.com/repos/kwsch/PKHeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwsch/PKHeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwsch/PKHeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwsch/PKHeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwsch/PKHeX/contents/{+path}","compare_url":"https://api.github.com/repos/kwsch/PKHeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwsch/PKHeX/merges","archive_url":"https://api.github.com/repos/kwsch/PKHeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwsch/PKHeX/downloads","issues_url":"https://api.github.com/repos/kwsch/PKHeX/issues{/number}","pulls_url":"https://api.github.com/repos/kwsch/PKHeX/pulls{/number}","milestones_url":"https://api.github.com/repos/kwsch/PKHeX/milestones{/number}","notifications_url":"https://api.github.com/repos/kwsch/PKHeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwsch/PKHeX/labels{/name}","releases_url":"https://api.github.com/repos/kwsch/PKHeX/releases{/id}","deployments_url":"https://api.github.com/repos/kwsch/PKHeX/deployments","created_at":"2014-06-28T21:20:30Z","updated_at":"2016-08-07T16:57:14Z","pushed_at":"2016-08-10T15:58:01Z","git_url":"git://github.com/kwsch/PKHeX.git","ssh_url":"git@github.com:kwsch/PKHeX.git","clone_url":"https://github.com/kwsch/PKHeX.git","svn_url":"https://github.com/kwsch/PKHeX","homepage":"http://projectpokemon.org/forums/showthread.php?36986","size":11053,"stargazers_count":152,"watchers_count":152,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":9,"forks":82,"open_issues":9,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/172"},"html":{"href":"https://github.com/kwsch/PKHeX/pull/172"},"issue":{"href":"https://api.github.com/repos/kwsch/PKHeX/issues/172"},"comments":{"href":"https://api.github.com/repos/kwsch/PKHeX/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kwsch/PKHeX/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/kwsch/PKHeX/statuses/98c86ddb7acf9208d4917502ac7f02a5be403519"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kwsch","id":6393368,"avatar_url":"https://avatars.githubusercontent.com/u/6393368?v=3","gravatar_id":"","url":"https://api.github.com/users/kwsch","html_url":"https://github.com/kwsch","followers_url":"https://api.github.com/users/kwsch/followers","following_url":"https://api.github.com/users/kwsch/following{/other_user}","gists_url":"https://api.github.com/users/kwsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kwsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwsch/subscriptions","organizations_url":"https://api.github.com/users/kwsch/orgs","repos_url":"https://api.github.com/users/kwsch/repos","events_url":"https://api.github.com/users/kwsch/events{/privacy}","received_events_url":"https://api.github.com/users/kwsch/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":8,"additions":293,"deletions":134,"changed_files":4206}}
{"actor":{"display_login":"kwsch"}}