{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/51097981","id":51097981,"diff_hunk":"@@ -35,6 +36,22 @@ def tenant=(name)\n       attrs[:tenant] = name\n     end\n \n+    def allow_ext_net?\n+      !(attrs[:allow_ext_net] == 0)\n+    end\n+\n+    def allow_ext_net\n+      attrs[:allow_ext_net]\n+    end\n+\n+    def allow_ext_net=(enabled)\n+      if ['true', true, '1', 1].include?(enabled)","path":"app/models/compute_resources/foreman/model/openstack.rb","position":25,"original_position":25,"commit_id":"2812ff2f606c24fd6211f5231e42f608d143bb8a","original_commit_id":"2812ff2f606c24fd6211f5231e42f608d143bb8a","user":{"login":"ohadlevy","id":20167,"avatar_url":"https://avatars.githubusercontent.com/u/20167?v=3","gravatar_id":"","url":"https://api.github.com/users/ohadlevy","html_url":"https://github.com/ohadlevy","followers_url":"https://api.github.com/users/ohadlevy/followers","following_url":"https://api.github.com/users/ohadlevy/following{/other_user}","gists_url":"https://api.github.com/users/ohadlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/ohadlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohadlevy/subscriptions","organizations_url":"https://api.github.com/users/ohadlevy/orgs","repos_url":"https://api.github.com/users/ohadlevy/repos","events_url":"https://api.github.com/users/ohadlevy/events{/privacy}","received_events_url":"https://api.github.com/users/ohadlevy/received_events","type":"User","site_admin":false},"body":"afair rails converts 0/1/t/f to true / false accordingly when its a\nparameter.\n","created_at":"2016-01-28T09:28:59Z","updated_at":"2016-01-28T09:28:59Z","html_url":"https://github.com/theforeman/foreman/pull/3007#discussion_r51097981","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3007","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/51097981"},"html":{"href":"https://github.com/theforeman/foreman/pull/3007#discussion_r51097981"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3007"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3007","id":54655999,"html_url":"https://github.com/theforeman/foreman/pull/3007","diff_url":"https://github.com/theforeman/foreman/pull/3007.diff","patch_url":"https://github.com/theforeman/foreman/pull/3007.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3007","number":3007,"state":"open","locked":false,"title":"Fixes #12949 - In Openstack, external networks should be allowed to be selected for the main network of an instance","user":{"login":"imriz","id":5706843,"avatar_url":"https://avatars.githubusercontent.com/u/5706843?v=3","gravatar_id":"","url":"https://api.github.com/users/imriz","html_url":"https://github.com/imriz","followers_url":"https://api.github.com/users/imriz/followers","following_url":"https://api.github.com/users/imriz/following{/other_user}","gists_url":"https://api.github.com/users/imriz/gists{/gist_id}","starred_url":"https://api.github.com/users/imriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imriz/subscriptions","organizations_url":"https://api.github.com/users/imriz/orgs","repos_url":"https://api.github.com/users/imriz/repos","events_url":"https://api.github.com/users/imriz/events{/privacy}","received_events_url":"https://api.github.com/users/imriz/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-28T13:44:52Z","updated_at":"2016-01-28T09:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d3b474867b0b4af416219c8070c48e402115cb1","assignee":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3007/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3007/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3007/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/2812ff2f606c24fd6211f5231e42f608d143bb8a","head":{"label":"myheritage:12949","ref":"12949","sha":"2812ff2f606c24fd6211f5231e42f608d143bb8a","user":{"login":"myheritage","id":964079,"avatar_url":"https://avatars.githubusercontent.com/u/964079?v=3","gravatar_id":"","url":"https://api.github.com/users/myheritage","html_url":"https://github.com/myheritage","followers_url":"https://api.github.com/users/myheritage/followers","following_url":"https://api.github.com/users/myheritage/following{/other_user}","gists_url":"https://api.github.com/users/myheritage/gists{/gist_id}","starred_url":"https://api.github.com/users/myheritage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myheritage/subscriptions","organizations_url":"https://api.github.com/users/myheritage/orgs","repos_url":"https://api.github.com/users/myheritage/repos","events_url":"https://api.github.com/users/myheritage/events{/privacy}","received_events_url":"https://api.github.com/users/myheritage/received_events","type":"Organization","site_admin":false},"repo":{"id":30724498,"name":"foreman","full_name":"myheritage/foreman","owner":{"login":"myheritage","id":964079,"avatar_url":"https://avatars.githubusercontent.com/u/964079?v=3","gravatar_id":"","url":"https://api.github.com/users/myheritage","html_url":"https://github.com/myheritage","followers_url":"https://api.github.com/users/myheritage/followers","following_url":"https://api.github.com/users/myheritage/following{/other_user}","gists_url":"https://api.github.com/users/myheritage/gists{/gist_id}","starred_url":"https://api.github.com/users/myheritage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myheritage/subscriptions","organizations_url":"https://api.github.com/users/myheritage/orgs","repos_url":"https://api.github.com/users/myheritage/repos","events_url":"https://api.github.com/users/myheritage/events{/privacy}","received_events_url":"https://api.github.com/users/myheritage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/myheritage/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/myheritage/foreman","forks_url":"https://api.github.com/repos/myheritage/foreman/forks","keys_url":"https://api.github.com/repos/myheritage/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myheritage/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myheritage/foreman/teams","hooks_url":"https://api.github.com/repos/myheritage/foreman/hooks","issue_events_url":"https://api.github.com/repos/myheritage/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/myheritage/foreman/events","assignees_url":"https://api.github.com/repos/myheritage/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/myheritage/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/myheritage/foreman/tags","blobs_url":"https://api.github.com/repos/myheritage/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myheritage/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myheritage/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/myheritage/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myheritage/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/myheritage/foreman/languages","stargazers_url":"https://api.github.com/repos/myheritage/foreman/stargazers","contributors_url":"https://api.github.com/repos/myheritage/foreman/contributors","subscribers_url":"https://api.github.com/repos/myheritage/foreman/subscribers","subscription_url":"https://api.github.com/repos/myheritage/foreman/subscription","commits_url":"https://api.github.com/repos/myheritage/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/myheritage/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/myheritage/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/myheritage/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/myheritage/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/myheritage/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myheritage/foreman/merges","archive_url":"https://api.github.com/repos/myheritage/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myheritage/foreman/downloads","issues_url":"https://api.github.com/repos/myheritage/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/myheritage/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/myheritage/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/myheritage/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myheritage/foreman/labels{/name}","releases_url":"https://api.github.com/repos/myheritage/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/myheritage/foreman/deployments","created_at":"2015-02-12T21:21:19Z","updated_at":"2015-02-12T21:21:22Z","pushed_at":"2016-01-11T15:21:41Z","git_url":"git://github.com/myheritage/foreman.git","ssh_url":"git@github.com:myheritage/foreman.git","clone_url":"https://github.com/myheritage/foreman.git","svn_url":"https://github.com/myheritage/foreman","homepage":"http://theforeman.org","size":36097,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"fa2a0c76d093fcfcf313097fd3eb5098ad0c3e7b","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-01-28T08:13:27Z","pushed_at":"2016-01-28T08:31:38Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":56269,"stargazers_count":933,"watchers_count":933,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":472,"mirror_url":null,"open_issues_count":86,"forks":472,"open_issues":86,"watchers":933,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3007"},"html":{"href":"https://github.com/theforeman/foreman/pull/3007"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3007"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3007/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3007/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3007/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/2812ff2f606c24fd6211f5231e42f608d143bb8a"}}}}