{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/83546704","pull_request_review_id":4385225,"id":83546704,"diff_hunk":"@@ -626,9 +626,6 @@ case $host in\n      ARCH=\"aarch64\"\n      use_arch=\"aarch64\"\n      use_neon=yes\n-     use_gles=yes","path":"configure.ac","position":4,"original_position":4,"commit_id":"cefe858f853a08c233f24454ce9cffa3d41a42d7","original_commit_id":"cefe858f853a08c233f24454ce9cffa3d41a42d7","user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?v=3","gravatar_id":"","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"body":"can you please add a test that keeps this as default, if the user didn't specify --enable-gles or --enable-gl?","created_at":"2016-10-16T07:23:26Z","updated_at":"2016-10-16T07:25:39Z","html_url":"https://github.com/xbmc/xbmc/pull/10713#discussion_r83546704","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10713","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/83546704"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10713#discussion_r83546704"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10713"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10713","id":89517009,"html_url":"https://github.com/xbmc/xbmc/pull/10713","diff_url":"https://github.com/xbmc/xbmc/pull/10713.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10713.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10713","number":10713,"state":"open","locked":false,"title":"configure: fix aarch64 builds","user":{"login":"koenkooi","id":259525,"avatar_url":"https://avatars.githubusercontent.com/u/259525?v=3","gravatar_id":"","url":"https://api.github.com/users/koenkooi","html_url":"https://github.com/koenkooi","followers_url":"https://api.github.com/users/koenkooi/followers","following_url":"https://api.github.com/users/koenkooi/following{/other_user}","gists_url":"https://api.github.com/users/koenkooi/gists{/gist_id}","starred_url":"https://api.github.com/users/koenkooi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenkooi/subscriptions","organizations_url":"https://api.github.com/users/koenkooi/orgs","repos_url":"https://api.github.com/users/koenkooi/repos","events_url":"https://api.github.com/users/koenkooi/events{/privacy}","received_events_url":"https://api.github.com/users/koenkooi/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\nJust like x86* aarch64 has platforms that can be full openGL and/or full openGLES. In the case of mesa/freedreno on Qualcomm SoCs, building against GLES will fail, but full GL works.\r\n\r\nSo stop hardcoding GL/GLES/Wayland and let honour the --enable-gl flags passed to configure.\r\n\r\n## Motivation and Context\r\nAfter running into Keith and @MartijnKaijser last week I wanted to switch from Jarvis to Krypton on my Dragonboard-410c to test the ffmpeg-v4l2 patches. It didn't build, so I tracked the failure down to the point where I replaced the aarch64 patch I wrote with the upstream one.\r\n\r\n## How Has This Been Tested?\r\nConfigure now does the right thing now:\r\n```\r\n------------------------\r\n  Kodi Configuration:\r\n------------------------\r\n  Kodi Version:\t17.0-BETA4\r\n  git Rev.:\t20161015-2f143a8\r\n  Debugging:\tYes\r\n  Profiling:\tNo\r\n  Optimization:\tYes\r\n  SWIG Available:\tYes\r\n  JRE Available:\tYes\r\n  Doxygen Available:\tNo\r\n  Crosscomp.:\tYes\r\n  target ARCH:\taarch64\r\n  target CPU:\t\r\n  OpenGL:\tYes\r\n```\r\nCompilation succeeds, and it runs, see screenshot below.\r\n\r\n## Screenshots (if appropriate):\r\n![img_7394](https://cloud.githubusercontent.com/assets/259525/19415599/06b851ea-9375-11e6-9360-24be9a0597e9.JPG)\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\nI'm not 100% sure this is non-breaking change, but Libreelec always sets the appropriate --enable-opengl/gles, so they won't see breakage.\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n","created_at":"2016-10-16T05:55:48Z","updated_at":"2016-10-16T07:25:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4c2280bf9858bf22aa0bed1926e8819981ea02c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10713/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10713/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10713/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/cefe858f853a08c233f24454ce9cffa3d41a42d7","head":{"label":"koenkooi:aarch64-opengl","ref":"aarch64-opengl","sha":"cefe858f853a08c233f24454ce9cffa3d41a42d7","user":{"login":"koenkooi","id":259525,"avatar_url":"https://avatars.githubusercontent.com/u/259525?v=3","gravatar_id":"","url":"https://api.github.com/users/koenkooi","html_url":"https://github.com/koenkooi","followers_url":"https://api.github.com/users/koenkooi/followers","following_url":"https://api.github.com/users/koenkooi/following{/other_user}","gists_url":"https://api.github.com/users/koenkooi/gists{/gist_id}","starred_url":"https://api.github.com/users/koenkooi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenkooi/subscriptions","organizations_url":"https://api.github.com/users/koenkooi/orgs","repos_url":"https://api.github.com/users/koenkooi/repos","events_url":"https://api.github.com/users/koenkooi/events{/privacy}","received_events_url":"https://api.github.com/users/koenkooi/received_events","type":"User","site_admin":false},"repo":{"id":3238966,"name":"xbmc","full_name":"koenkooi/xbmc","owner":{"login":"koenkooi","id":259525,"avatar_url":"https://avatars.githubusercontent.com/u/259525?v=3","gravatar_id":"","url":"https://api.github.com/users/koenkooi","html_url":"https://github.com/koenkooi","followers_url":"https://api.github.com/users/koenkooi/followers","following_url":"https://api.github.com/users/koenkooi/following{/other_user}","gists_url":"https://api.github.com/users/koenkooi/gists{/gist_id}","starred_url":"https://api.github.com/users/koenkooi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenkooi/subscriptions","organizations_url":"https://api.github.com/users/koenkooi/orgs","repos_url":"https://api.github.com/users/koenkooi/repos","events_url":"https://api.github.com/users/koenkooi/events{/privacy}","received_events_url":"https://api.github.com/users/koenkooi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koenkooi/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/koenkooi/xbmc","forks_url":"https://api.github.com/repos/koenkooi/xbmc/forks","keys_url":"https://api.github.com/repos/koenkooi/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koenkooi/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koenkooi/xbmc/teams","hooks_url":"https://api.github.com/repos/koenkooi/xbmc/hooks","issue_events_url":"https://api.github.com/repos/koenkooi/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/koenkooi/xbmc/events","assignees_url":"https://api.github.com/repos/koenkooi/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/koenkooi/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/koenkooi/xbmc/tags","blobs_url":"https://api.github.com/repos/koenkooi/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koenkooi/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koenkooi/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/koenkooi/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koenkooi/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/koenkooi/xbmc/languages","stargazers_url":"https://api.github.com/repos/koenkooi/xbmc/stargazers","contributors_url":"https://api.github.com/repos/koenkooi/xbmc/contributors","subscribers_url":"https://api.github.com/repos/koenkooi/xbmc/subscribers","subscription_url":"https://api.github.com/repos/koenkooi/xbmc/subscription","commits_url":"https://api.github.com/repos/koenkooi/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/koenkooi/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/koenkooi/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/koenkooi/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/koenkooi/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/koenkooi/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koenkooi/xbmc/merges","archive_url":"https://api.github.com/repos/koenkooi/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koenkooi/xbmc/downloads","issues_url":"https://api.github.com/repos/koenkooi/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/koenkooi/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/koenkooi/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/koenkooi/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koenkooi/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/koenkooi/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/koenkooi/xbmc/deployments","created_at":"2012-01-22T09:52:26Z","updated_at":"2016-10-15T10:13:43Z","pushed_at":"2016-10-15T14:53:24Z","git_url":"git://github.com/koenkooi/xbmc.git","ssh_url":"git@github.com:koenkooi/xbmc.git","clone_url":"https://github.com/koenkooi/xbmc.git","svn_url":"https://github.com/koenkooi/xbmc","homepage":"http://xbmc.org","size":542310,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"63b8843acae8273c0ed46a9486e594ac12c49006","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-10-16T03:04:59Z","pushed_at":"2016-10-16T06:43:45Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1764172,"stargazers_count":5122,"watchers_count":5122,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3719,"mirror_url":null,"open_issues_count":181,"forks":3719,"open_issues":181,"watchers":5122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10713"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10713"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10713"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10713/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10713/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10713/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/cefe858f853a08c233f24454ce9cffa3d41a42d7"}}}}
{"actor":{"display_login":"wsnipex"}}