{"action":"created","issue":{"url":"https://api.github.com/repos/bumptech/glide/issues/874","labels_url":"https://api.github.com/repos/bumptech/glide/issues/874/labels{/name}","comments_url":"https://api.github.com/repos/bumptech/glide/issues/874/comments","events_url":"https://api.github.com/repos/bumptech/glide/issues/874/events","html_url":"https://github.com/bumptech/glide/pull/874","id":125499509,"number":874,"title":"Introduce AAR publish for :library and stop publishing :glide","user":{"login":"TWiStErRob","id":2906988,"avatar_url":"https://avatars.githubusercontent.com/u/2906988?v=3","gravatar_id":"","url":"https://api.github.com/users/TWiStErRob","html_url":"https://github.com/TWiStErRob","followers_url":"https://api.github.com/users/TWiStErRob/followers","following_url":"https://api.github.com/users/TWiStErRob/following{/other_user}","gists_url":"https://api.github.com/users/TWiStErRob/gists{/gist_id}","starred_url":"https://api.github.com/users/TWiStErRob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWiStErRob/subscriptions","organizations_url":"https://api.github.com/users/TWiStErRob/orgs","repos_url":"https://api.github.com/users/TWiStErRob/repos","events_url":"https://api.github.com/users/TWiStErRob/events{/privacy}","received_events_url":"https://api.github.com/users/TWiStErRob/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bumptech/glide/labels/enhancement","name":"enhancement","color":"207de5"},{"url":"https://api.github.com/repos/bumptech/glide/labels/non-library","name":"non-library","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bumptech/glide/milestones/5","html_url":"https://github.com/bumptech/glide/milestones/4.0","labels_url":"https://api.github.com/repos/bumptech/glide/milestones/5/labels","id":812599,"number":5,"title":"4.0","description":"Features/bugs that can only be fixed with breaking changes.","creator":{"login":"sjudd","id":1627211,"avatar_url":"https://avatars.githubusercontent.com/u/1627211?v=3","gravatar_id":"","url":"https://api.github.com/users/sjudd","html_url":"https://github.com/sjudd","followers_url":"https://api.github.com/users/sjudd/followers","following_url":"https://api.github.com/users/sjudd/following{/other_user}","gists_url":"https://api.github.com/users/sjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjudd/subscriptions","organizations_url":"https://api.github.com/users/sjudd/orgs","repos_url":"https://api.github.com/users/sjudd/repos","events_url":"https://api.github.com/users/sjudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjudd/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":44,"state":"open","created_at":"2014-10-03T13:30:57Z","updated_at":"2016-01-07T22:31:18Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-01-07T22:29:21Z","updated_at":"2016-01-11T16:16:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bumptech/glide/pulls/874","html_url":"https://github.com/bumptech/glide/pull/874","diff_url":"https://github.com/bumptech/glide/pull/874.diff","patch_url":"https://github.com/bumptech/glide/pull/874.patch"},"body":"Replacing PR #855.\r\n\r\nIn this PR (from commit message):\r\n* Don't publish `:glide` as anything to Maven repos\r\n* Build `:glide` as 'glide-full' to have a flat jar to be published on GitHub/releases\r\n* Publish `:library` as 'group:glide' as AAR and JAR to Maven repos\r\n* Make `:third_party:gif_decoder` and `:third_party:disklrucache` first-class published gradle dependencies\r\n* Remove duplicated `repositories`, `JAR_PREFIX`, `JAR_POSTFIX` declarations  \r\n(pull latter two up to `:integration` and `:third_party` level)\r\n* Fix JavaDoc generation (Error reading file: `${androidSdkDirectory}\\docs\\reference\\package-list`)  \r\n* Move JAR generation to `upload.gradle` (from `integration/build.gradle`) so it's used by `:library` as well\r\n* Add javadoc and sources JAR generation to upload.gradle for non-android `projects as well\r\n\r\nThis PR depends on sjudd/disklrucache#3\r\n\r\nBefore commit I tried with:\r\n\r\n```\r\ngradlew clean build assemble check buildArchives uploadArchives \\\r\n-PSNAPSHOT_REPOSITORY_URL=file://p:\\projects\\contrib\\github-glide\\repo-snapshot \\\r\n-PRELEASE_REPOSITORY_URL=file://p:\\projects\\contrib\\github-glide\\repo-release\r\n```\r\n\r\nand it compiled fine.\r\n\r\nI got the following artifacts in repo-snapshot local Maven repository:\r\n```java\r\ncom.github.bumptech.glide:glide:4.0.0-SNAPSHOT + aar (from :library)\r\ncom.github.bumptech.glide:disklrucache:1.0.0-SNAPSHOT (from :third_party)\r\ncom.github.bumptech.glide:gifdecoder:1.0.0-SNAPSHOT + aar (from :third_party)\r\n\r\ncom.github.bumptech.glide:volley-integration:2.0.0-SNAPSHOT + aar\r\ncom.github.bumptech.glide:okhttp-integration:2.0.0-SNAPSHOT + aar\r\ncom.github.bumptech.glide:okhttp3-integration:1.0.0-SNAPSHOT + aar\r\ncom.github.bumptech.glide:recyclerview-integration:2.0.0-SNAPSHOT + aar\r\ncom.github.bumptech.glide:gifencoder-integration:1.0.0-SNAPSHOT + aar\r\n```\r\n\r\nand `gradlew :glide:jar` gave the following artifacts:\r\n```gradle\r\nglide/build/libs/glide-full-4.0.0-SNAPSHOT.jar\r\n```\r\n\r\nEverything above includes the `-sources` and `-javadoc` classified JARs as well."},"comment":{"url":"https://api.github.com/repos/bumptech/glide/issues/comments/170601008","html_url":"https://github.com/bumptech/glide/pull/874#issuecomment-170601008","issue_url":"https://api.github.com/repos/bumptech/glide/issues/874","id":170601008,"user":{"login":"sjudd","id":1627211,"avatar_url":"https://avatars.githubusercontent.com/u/1627211?v=3","gravatar_id":"","url":"https://api.github.com/users/sjudd","html_url":"https://github.com/sjudd","followers_url":"https://api.github.com/users/sjudd/followers","following_url":"https://api.github.com/users/sjudd/following{/other_user}","gists_url":"https://api.github.com/users/sjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjudd/subscriptions","organizations_url":"https://api.github.com/users/sjudd/orgs","repos_url":"https://api.github.com/users/sjudd/repos","events_url":"https://api.github.com/users/sjudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjudd/received_events","type":"User","site_admin":false},"created_at":"2016-01-11T16:16:14Z","updated_at":"2016-01-11T16:16:14Z","body":"Ah right, thanks for reminding me about gifencoder. The file is in a separate folder to meet Google's standards for open source code (all third party code goes into a folder called third_party). That said, it really ought to be a separate library project, just like the other two third_party projects. It's fine to leave as is for now, that's my mess I can clean up later.\r\n\r\nAs for versioning, there isn't really any reason why those integration libraries shouldn't just match Glide's. I can imagine a scenario in which someone put up a PR for one of the libraries and I might want to release just the library without releasing Glide and would be unable to do so because of the current versioning scheme, but that hasn't happened yet. I agree the right solution is to either switch them all to match Glide's or keep them all independent. You don't need to do that here either."}}