{"push_id":1125293730,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"5bca243ee86f5ba6685bea02bacc495f65ca4a6f","before":"18e8d65b2741bb8f3e5207a72a37e3174bc19a0e","commits":[{"sha":"5bca243ee86f5ba6685bea02bacc495f65ca4a6f","author":{"email":"a557a764e6b765d33420cbd0f8c697842167d152@gmail.com","name":"jyriand"},"message":"Refactor code\n\nCLOCK: [2016-05-24 Tue 00:33]--[2016-05-24 Tue 01:04] =>  0:31\n   :PROPERTIES:\n   :Estimated Effort:   0:20\n   :END:\n\n- Move keybindigs to separate namespace <2016-05-24 Tue 00:33>\n  Created namespace for player\n  #+BEGIN_SRC lisp\n(ns ecman.player\n  (:require\n   [keybind.core :as keys]))\n\n(defn move-forward [state]\n  (swap! state update-in [:board :player :row] inc))\n\n(defn init-moving! [state]\n  (keys/bind! \"ctrl-f\" ::move-f #(move-forward state)))\n  #+END_SRC\n\n  and called `init-moving!` from views.cljs\n\n  #+BEGIN_SRC lisp\n(player/init-moving! state)\n  #+END_SRC\n\n  This is not ideal, because I need to pass state around. Eventually I have to start using some event passing library, `core.async` for example, and pass the channel around, instead of state.\n\n  - Inline gen-key as it is used only in one place <2016-05-24 Tue 00:50>\n\n  - Add white border to tiles, instead of 1px gap between tiles<2016-05-24 Tue 00:52>\n    Search: 'html svg rect border\n    1. http://www.w3schools.com/svg/svg_rect.asp gives the answer\n\n  - Remove magic numbers associated with rectangle size <2016-05-24 Tue 00:55>","distinct":true,"url":"https://api.github.com/repos/jyriand/ecman/commits/5bca243ee86f5ba6685bea02bacc495f65ca4a6f"}]}
{"actor":{"display_login":"jyriand"}}