{"action":"created","issue":{"url":"https://api.github.com/repos/makojs/core/issues/28","repository_url":"https://api.github.com/repos/makojs/core","labels_url":"https://api.github.com/repos/makojs/core/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/makojs/core/issues/28/comments","events_url":"https://api.github.com/repos/makojs/core/issues/28/events","html_url":"https://github.com/makojs/core/pull/28","id":159096238,"number":28,"title":"Update mako-tree","user":{"login":"dominicbarnes","id":160197,"avatar_url":"https://avatars.githubusercontent.com/u/160197?v=3","gravatar_id":"","url":"https://api.github.com/users/dominicbarnes","html_url":"https://github.com/dominicbarnes","followers_url":"https://api.github.com/users/dominicbarnes/followers","following_url":"https://api.github.com/users/dominicbarnes/following{/other_user}","gists_url":"https://api.github.com/users/dominicbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicbarnes/subscriptions","organizations_url":"https://api.github.com/users/dominicbarnes/orgs","repos_url":"https://api.github.com/users/dominicbarnes/repos","events_url":"https://api.github.com/users/dominicbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/dominicbarnes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-08T07:23:32Z","updated_at":"2016-06-08T10:18:00Z","closed_at":"2016-06-08T07:49:30Z","pull_request":{"url":"https://api.github.com/repos/makojs/core/pulls/28","html_url":"https://github.com/makojs/core/pull/28","diff_url":"https://github.com/makojs/core/pull/28.diff","patch_url":"https://github.com/makojs/core/pull/28.patch"},"body":"This updates core to use the changes in the latest mako-tree. Changes of note:\r\n\r\n - \"entry\" is no longer tracked internally in the tree (though we do still track the input entries on the `Build` object)\r\n - using the new Vinyl-based files (and all the related changes in tree manipulation/traversal)\r\n - methods like `.analyze()`, `.assemble()` and `.build()` accept vinyl-like file objects (instead of just string paths)\r\n - the entire event emitter mechanism has been stripped out (I plan on rewriting mako-cli to leverage hooks instead)\r\n\r\n(note to self: squash these commits)\r\n\r\ncc @darsain @matthewmueller "},"comment":{"url":"https://api.github.com/repos/makojs/core/issues/comments/224548377","html_url":"https://github.com/makojs/core/pull/28#issuecomment-224548377","issue_url":"https://api.github.com/repos/makojs/core/issues/28","id":224548377,"user":{"login":"darsain","id":538801,"avatar_url":"https://avatars.githubusercontent.com/u/538801?v=3","gravatar_id":"","url":"https://api.github.com/users/darsain","html_url":"https://github.com/darsain","followers_url":"https://api.github.com/users/darsain/followers","following_url":"https://api.github.com/users/darsain/following{/other_user}","gists_url":"https://api.github.com/users/darsain/gists{/gist_id}","starred_url":"https://api.github.com/users/darsain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darsain/subscriptions","organizations_url":"https://api.github.com/users/darsain/orgs","repos_url":"https://api.github.com/users/darsain/repos","events_url":"https://api.github.com/users/darsain/events{/privacy}","received_events_url":"https://api.github.com/users/darsain/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T10:18:00Z","updated_at":"2016-06-08T10:18:00Z","body":"Actually, thinking about `file.base` as a perfect substitute for `option.root`, how about moving all file related plugin options into the `file` object? `sourceRoot` would be the perfect example.\r\n\r\nYou could still define it in plugin options object, but it would be overridden by `file.optionName`."}}
{"actor":{"display_login":"darsain"}}