{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/57680358","id":57680358,"diff_hunk":"@@ -56,43 +56,33 @@ type windowUpdate struct {\n \tincrement uint32\n }\n \n-func (windowUpdate) isItem() bool {\n-\treturn true\n-}\n+func (*windowUpdate) isItem() {}\n \n type settings struct {\n \tack bool\n \tss  []http2.Setting\n }\n \n-func (settings) isItem() bool {\n-\treturn true\n-}\n+func (*settings) isItem() {}\n \n type resetStream struct {\n \tstreamID uint32\n \tcode     http2.ErrCode\n }\n \n-func (resetStream) isItem() bool {\n-\treturn true\n-}\n+func (*resetStream) isItem() {}\n \n type flushIO struct {\n }","path":"transport/control.go","position":30,"original_position":30,"commit_id":"27c1c446d89d2e3f1e86424b9b02a79e7d8899f6","original_commit_id":"27c1c446d89d2e3f1e86424b9b02a79e7d8899f6","user":{"login":"iamqizhao","id":10121772,"avatar_url":"https://avatars.githubusercontent.com/u/10121772?v=3","gravatar_id":"","url":"https://api.github.com/users/iamqizhao","html_url":"https://github.com/iamqizhao","followers_url":"https://api.github.com/users/iamqizhao/followers","following_url":"https://api.github.com/users/iamqizhao/following{/other_user}","gists_url":"https://api.github.com/users/iamqizhao/gists{/gist_id}","starred_url":"https://api.github.com/users/iamqizhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamqizhao/subscriptions","organizations_url":"https://api.github.com/users/iamqizhao/orgs","repos_url":"https://api.github.com/users/iamqizhao/repos","events_url":"https://api.github.com/users/iamqizhao/events{/privacy}","received_events_url":"https://api.github.com/users/iamqizhao/received_events","type":"User","site_admin":false},"body":"this is an empty struct so that the value receiver does have advantage here.","created_at":"2016-03-29T07:10:17Z","updated_at":"2016-03-29T07:10:17Z","html_url":"https://github.com/grpc/grpc-go/pull/615#discussion_r57680358","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/615","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/57680358"},"html":{"href":"https://github.com/grpc/grpc-go/pull/615#discussion_r57680358"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/615"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/615","id":64401312,"html_url":"https://github.com/grpc/grpc-go/pull/615","diff_url":"https://github.com/grpc/grpc-go/pull/615.diff","patch_url":"https://github.com/grpc/grpc-go/pull/615.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/615","number":615,"state":"open","locked":false,"title":"transport: isItem is a marker method","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"Changes the receivers to pointers because:\r\n- Implementing an interface using value receivers causes both pointers\r\nand values to implement that interface; implementing an interface using\r\npointer receivers causes only pointers to implement the interface,\r\nthereby providing better type safety.\r\n- Wrapping any value other than an empty struct in an interface causes\r\nthe value to be heap-allocated; no additional allocations are therefore\r\ncaused by this change.","created_at":"2016-03-29T01:27:07Z","updated_at":"2016-03-29T07:10:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0eaca1f0fbeb26bdb5058e552c9f7a68cbfab65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/615/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/615/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/615/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/27c1c446d89d2e3f1e86424b9b02a79e7d8899f6","head":{"label":"tamird:marker-method","ref":"marker-method","sha":"27c1c446d89d2e3f1e86424b9b02a79e7d8899f6","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":42019024,"name":"grpc-go","full_name":"tamird/grpc-go","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/tamird/grpc-go","forks_url":"https://api.github.com/repos/tamird/grpc-go/forks","keys_url":"https://api.github.com/repos/tamird/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/grpc-go/teams","hooks_url":"https://api.github.com/repos/tamird/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/tamird/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/grpc-go/events","assignees_url":"https://api.github.com/repos/tamird/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/grpc-go/tags","blobs_url":"https://api.github.com/repos/tamird/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/grpc-go/languages","stargazers_url":"https://api.github.com/repos/tamird/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/tamird/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/tamird/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/tamird/grpc-go/subscription","commits_url":"https://api.github.com/repos/tamird/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/grpc-go/merges","archive_url":"https://api.github.com/repos/tamird/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/grpc-go/downloads","issues_url":"https://api.github.com/repos/tamird/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/tamird/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/tamird/grpc-go/deployments","created_at":"2015-09-06T21:12:47Z","updated_at":"2016-02-04T22:34:08Z","pushed_at":"2016-03-29T01:26:41Z","git_url":"git://github.com/tamird/grpc-go.git","ssh_url":"git@github.com:tamird/grpc-go.git","clone_url":"https://github.com/tamird/grpc-go.git","svn_url":"https://github.com/tamird/grpc-go","homepage":"","size":1517,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"5309b8314a606dba2e2e9c4f782073445eea1c5d","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-03-28T16:45:44Z","pushed_at":"2016-03-29T06:31:14Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":2156,"stargazers_count":1601,"watchers_count":1601,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":216,"mirror_url":null,"open_issues_count":60,"forks":216,"open_issues":60,"watchers":1601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/615"},"html":{"href":"https://github.com/grpc/grpc-go/pull/615"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/615"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/27c1c446d89d2e3f1e86424b9b02a79e7d8899f6"}}}}