{"action":"created","issue":{"url":"https://api.github.com/repos/CryptonZylog/carbonator/issues/6","repository_url":"https://api.github.com/repos/CryptonZylog/carbonator","labels_url":"https://api.github.com/repos/CryptonZylog/carbonator/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/CryptonZylog/carbonator/issues/6/comments","events_url":"https://api.github.com/repos/CryptonZylog/carbonator/issues/6/events","html_url":"https://github.com/CryptonZylog/carbonator/issues/6","id":124222930,"number":6,"title":"Adding support for domain name.","user":{"login":"GriffReborn","id":11091780,"avatar_url":"https://avatars.githubusercontent.com/u/11091780?v=3","gravatar_id":"","url":"https://api.github.com/users/GriffReborn","html_url":"https://github.com/GriffReborn","followers_url":"https://api.github.com/users/GriffReborn/followers","following_url":"https://api.github.com/users/GriffReborn/following{/other_user}","gists_url":"https://api.github.com/users/GriffReborn/gists{/gist_id}","starred_url":"https://api.github.com/users/GriffReborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GriffReborn/subscriptions","organizations_url":"https://api.github.com/users/GriffReborn/orgs","repos_url":"https://api.github.com/users/GriffReborn/repos","events_url":"https://api.github.com/users/GriffReborn/events{/privacy}","received_events_url":"https://api.github.com/users/GriffReborn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CryptonZylog/carbonator/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"CryptonZylog","id":1175100,"avatar_url":"https://avatars.githubusercontent.com/u/1175100?v=3","gravatar_id":"","url":"https://api.github.com/users/CryptonZylog","html_url":"https://github.com/CryptonZylog","followers_url":"https://api.github.com/users/CryptonZylog/followers","following_url":"https://api.github.com/users/CryptonZylog/following{/other_user}","gists_url":"https://api.github.com/users/CryptonZylog/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptonZylog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptonZylog/subscriptions","organizations_url":"https://api.github.com/users/CryptonZylog/orgs","repos_url":"https://api.github.com/users/CryptonZylog/repos","events_url":"https://api.github.com/users/CryptonZylog/events{/privacy}","received_events_url":"https://api.github.com/users/CryptonZylog/received_events","type":"User","site_admin":false},"assignees":[{"login":"CryptonZylog","id":1175100,"avatar_url":"https://avatars.githubusercontent.com/u/1175100?v=3","gravatar_id":"","url":"https://api.github.com/users/CryptonZylog","html_url":"https://github.com/CryptonZylog","followers_url":"https://api.github.com/users/CryptonZylog/followers","following_url":"https://api.github.com/users/CryptonZylog/following{/other_user}","gists_url":"https://api.github.com/users/CryptonZylog/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptonZylog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptonZylog/subscriptions","organizations_url":"https://api.github.com/users/CryptonZylog/orgs","repos_url":"https://api.github.com/users/CryptonZylog/repos","events_url":"https://api.github.com/users/CryptonZylog/events{/privacy}","received_events_url":"https://api.github.com/users/CryptonZylog/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2015-12-29T15:07:16Z","updated_at":"2016-07-06T16:40:09Z","closed_at":"2016-03-03T23:53:06Z","body":"Firstly, just wanted to say what a fantastic project this is. I'm finding it very useful in our production environment.\r\n\r\nSecondly, that I'm totally new to C# and GitHub, so bear with me!\r\n\r\nWe have multiple domains, often with same hostnames, so I added simple support for domains:\r\n\r\nInserted line 10\r\nusing System.DirectoryServices.ActiveDirectory;\r\n\r\nAltered line 187 (188 after insert)\r\n                    .Replace(\"%HOST%\", Environment.MachineName).Replace(\"%DOMAIN%\", Domain.GetComputerDomain().Name);\r\n\r\nWhile this addition works perfectly, replacing %DOMAIN% with the name of the computers domain, it breaks when a server is not domain joined. So some exception handling is required which is currently beyond my skill level.\r\n\r\nAny suggestions? (should I \"pull\" this?)"},"comment":{"url":"https://api.github.com/repos/CryptonZylog/carbonator/issues/comments/230831392","html_url":"https://github.com/CryptonZylog/carbonator/issues/6#issuecomment-230831392","issue_url":"https://api.github.com/repos/CryptonZylog/carbonator/issues/6","id":230831392,"user":{"login":"CryptonZylog","id":1175100,"avatar_url":"https://avatars.githubusercontent.com/u/1175100?v=3","gravatar_id":"","url":"https://api.github.com/users/CryptonZylog","html_url":"https://github.com/CryptonZylog","followers_url":"https://api.github.com/users/CryptonZylog/followers","following_url":"https://api.github.com/users/CryptonZylog/following{/other_user}","gists_url":"https://api.github.com/users/CryptonZylog/gists{/gist_id}","starred_url":"https://api.github.com/users/CryptonZylog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CryptonZylog/subscriptions","organizations_url":"https://api.github.com/users/CryptonZylog/orgs","repos_url":"https://api.github.com/users/CryptonZylog/repos","events_url":"https://api.github.com/users/CryptonZylog/events{/privacy}","received_events_url":"https://api.github.com/users/CryptonZylog/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T16:40:09Z","updated_at":"2016-07-06T16:40:09Z","body":"[This](https://github.com/CryptonZylog/carbonator/blob/master/Carbonator/CounterWatcher.cs#L225) method resolves the Windows domain when you specify a %DOMAIN% variable in the metric path. Does it not work for you?"}}
{"actor":{"display_login":"CryptonZylog"}}