{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-http/pulls/comments/79575045","id":79575045,"diff_hunk":"@@ -37,16 +37,29 @@ object ExceptionHandler {\n         if (!knownToBeSealed) ExceptionHandler(knownToBeSealed = true)(this orElse default(settings)) else this\n     }\n \n+  private def log(verbosity: ErrorLoggingVerbosity, simple: ⇒ Unit, full: ⇒ Unit) =\n+    verbosity match {\n+      case ParserSettings.ErrorLoggingVerbosity.Off    ⇒\n+      case ParserSettings.ErrorLoggingVerbosity.Simple ⇒ simple\n+      case ParserSettings.ErrorLoggingVerbosity.Full   ⇒ full\n+    }\n+\n   def default(settings: RoutingSettings): ExceptionHandler =\n     apply(knownToBeSealed = true) {\n       case IllegalRequestException(info, status) ⇒ ctx ⇒ {\n-        ctx.log.warning(\n-          \"Illegal request {}\\n\\t{}\\n\\tCompleting with '{}' response\",\n-          ctx.request, info.formatPretty, status)\n+        log(\n+          settings.errorLoggingVerbosity,\n+          ctx.log.warning(\"Illegal request completing with '{}' response\", status),\n+          ctx.log.warning(\"Illegal request {}\\n\\t{}\\n\\tCompleting with '{}' response\", ctx.request, info.formatPretty, status))\n+\n         ctx.complete((status, info.format(settings.verboseErrorMessages)))\n       }\n       case NonFatal(e) ⇒ ctx ⇒ {\n-        ctx.log.error(e, \"Error during processing of request {}\", ctx.request)\n+        log(\n+          settings.errorLoggingVerbosity,\n+          ctx.log.error(\"Error during processing one of requests occurred due to '{}'\", e.getMessage),","path":"akka-http/src/main/scala/akka/http/scaladsl/server/ExceptionHandler.scala","position":44,"original_position":44,"commit_id":"00bb4f830afaa00e5a2ec502a5720c10985aca7b","original_commit_id":"00bb4f830afaa00e5a2ec502a5720c10985aca7b","user":{"login":"rbudzko","id":8142729,"avatar_url":"https://avatars.githubusercontent.com/u/8142729?v=3","gravatar_id":"","url":"https://api.github.com/users/rbudzko","html_url":"https://github.com/rbudzko","followers_url":"https://api.github.com/users/rbudzko/followers","following_url":"https://api.github.com/users/rbudzko/following{/other_user}","gists_url":"https://api.github.com/users/rbudzko/gists{/gist_id}","starred_url":"https://api.github.com/users/rbudzko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbudzko/subscriptions","organizations_url":"https://api.github.com/users/rbudzko/orgs","repos_url":"https://api.github.com/users/rbudzko/repos","events_url":"https://api.github.com/users/rbudzko/events{/privacy}","received_events_url":"https://api.github.com/users/rbudzko/received_events","type":"User","site_admin":false},"body":"Again, Simple is meant to be one liner. Are you unhappy with e.getMessage? How do we replace it for one liner?","created_at":"2016-09-20T10:00:28Z","updated_at":"2016-09-20T10:00:47Z","html_url":"https://github.com/akka/akka-http/pull/321#discussion_r79575045","pull_request_url":"https://api.github.com/repos/akka/akka-http/pulls/321","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments/79575045"},"html":{"href":"https://github.com/akka/akka-http/pull/321#discussion_r79575045"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-http/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka-http/pulls/321","id":85538741,"html_url":"https://github.com/akka/akka-http/pull/321","diff_url":"https://github.com/akka/akka-http/pull/321.diff","patch_url":"https://github.com/akka/akka-http/pull/321.patch","issue_url":"https://api.github.com/repos/akka/akka-http/issues/321","number":321,"state":"open","locked":false,"title":"Error logging verbosity is not configurable for routing and used to determine log content of ErrorHandler (#16).","user":{"login":"rbudzko","id":8142729,"avatar_url":"https://avatars.githubusercontent.com/u/8142729?v=3","gravatar_id":"","url":"https://api.github.com/users/rbudzko","html_url":"https://github.com/rbudzko","followers_url":"https://api.github.com/users/rbudzko/followers","following_url":"https://api.github.com/users/rbudzko/following{/other_user}","gists_url":"https://api.github.com/users/rbudzko/gists{/gist_id}","starred_url":"https://api.github.com/users/rbudzko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbudzko/subscriptions","organizations_url":"https://api.github.com/users/rbudzko/orgs","repos_url":"https://api.github.com/users/rbudzko/repos","events_url":"https://api.github.com/users/rbudzko/events{/privacy}","received_events_url":"https://api.github.com/users/rbudzko/received_events","type":"User","site_admin":false},"body":"Reused already existing property type. Set to full logging in tests as event filters asserts on that.","created_at":"2016-09-16T08:56:47Z","updated_at":"2016-09-20T10:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab434500bbaf8e5d9eeb521e825625617f50647c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-http/pulls/321/commits","review_comments_url":"https://api.github.com/repos/akka/akka-http/pulls/321/comments","review_comment_url":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-http/issues/321/comments","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/00bb4f830afaa00e5a2ec502a5720c10985aca7b","head":{"label":"rbudzko:http-exception-logging","ref":"http-exception-logging","sha":"00bb4f830afaa00e5a2ec502a5720c10985aca7b","user":{"login":"rbudzko","id":8142729,"avatar_url":"https://avatars.githubusercontent.com/u/8142729?v=3","gravatar_id":"","url":"https://api.github.com/users/rbudzko","html_url":"https://github.com/rbudzko","followers_url":"https://api.github.com/users/rbudzko/followers","following_url":"https://api.github.com/users/rbudzko/following{/other_user}","gists_url":"https://api.github.com/users/rbudzko/gists{/gist_id}","starred_url":"https://api.github.com/users/rbudzko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbudzko/subscriptions","organizations_url":"https://api.github.com/users/rbudzko/orgs","repos_url":"https://api.github.com/users/rbudzko/repos","events_url":"https://api.github.com/users/rbudzko/events{/privacy}","received_events_url":"https://api.github.com/users/rbudzko/received_events","type":"User","site_admin":false},"repo":{"id":68223415,"name":"akka-http","full_name":"rbudzko/akka-http","owner":{"login":"rbudzko","id":8142729,"avatar_url":"https://avatars.githubusercontent.com/u/8142729?v=3","gravatar_id":"","url":"https://api.github.com/users/rbudzko","html_url":"https://github.com/rbudzko","followers_url":"https://api.github.com/users/rbudzko/followers","following_url":"https://api.github.com/users/rbudzko/following{/other_user}","gists_url":"https://api.github.com/users/rbudzko/gists{/gist_id}","starred_url":"https://api.github.com/users/rbudzko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbudzko/subscriptions","organizations_url":"https://api.github.com/users/rbudzko/orgs","repos_url":"https://api.github.com/users/rbudzko/repos","events_url":"https://api.github.com/users/rbudzko/events{/privacy}","received_events_url":"https://api.github.com/users/rbudzko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rbudzko/akka-http","description":null,"fork":true,"url":"https://api.github.com/repos/rbudzko/akka-http","forks_url":"https://api.github.com/repos/rbudzko/akka-http/forks","keys_url":"https://api.github.com/repos/rbudzko/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbudzko/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbudzko/akka-http/teams","hooks_url":"https://api.github.com/repos/rbudzko/akka-http/hooks","issue_events_url":"https://api.github.com/repos/rbudzko/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/rbudzko/akka-http/events","assignees_url":"https://api.github.com/repos/rbudzko/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/rbudzko/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/rbudzko/akka-http/tags","blobs_url":"https://api.github.com/repos/rbudzko/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbudzko/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbudzko/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbudzko/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbudzko/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/rbudzko/akka-http/languages","stargazers_url":"https://api.github.com/repos/rbudzko/akka-http/stargazers","contributors_url":"https://api.github.com/repos/rbudzko/akka-http/contributors","subscribers_url":"https://api.github.com/repos/rbudzko/akka-http/subscribers","subscription_url":"https://api.github.com/repos/rbudzko/akka-http/subscription","commits_url":"https://api.github.com/repos/rbudzko/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbudzko/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbudzko/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbudzko/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbudzko/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/rbudzko/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbudzko/akka-http/merges","archive_url":"https://api.github.com/repos/rbudzko/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbudzko/akka-http/downloads","issues_url":"https://api.github.com/repos/rbudzko/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/rbudzko/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/rbudzko/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/rbudzko/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbudzko/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/rbudzko/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/rbudzko/akka-http/deployments","created_at":"2016-09-14T16:30:17Z","updated_at":"2016-09-14T16:30:19Z","pushed_at":"2016-09-20T07:53:20Z","git_url":"git://github.com/rbudzko/akka-http.git","ssh_url":"git@github.com:rbudzko/akka-http.git","clone_url":"https://github.com/rbudzko/akka-http.git","svn_url":"https://github.com/rbudzko/akka-http","homepage":null,"size":6058,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"7e982d562286572b8c3b91be3d1eddf79cc41a57","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":66077955,"name":"akka-http","full_name":"akka/akka-http","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka-http","description":"The Streaming-first HTTP server/module of Akka","fork":false,"url":"https://api.github.com/repos/akka/akka-http","forks_url":"https://api.github.com/repos/akka/akka-http/forks","keys_url":"https://api.github.com/repos/akka/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-http/teams","hooks_url":"https://api.github.com/repos/akka/akka-http/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-http/events","assignees_url":"https://api.github.com/repos/akka/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-http/tags","blobs_url":"https://api.github.com/repos/akka/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-http/languages","stargazers_url":"https://api.github.com/repos/akka/akka-http/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-http/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-http/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-http/subscription","commits_url":"https://api.github.com/repos/akka/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-http/merges","archive_url":"https://api.github.com/repos/akka/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-http/downloads","issues_url":"https://api.github.com/repos/akka/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-http/deployments","created_at":"2016-08-19T11:33:36Z","updated_at":"2016-09-19T21:48:35Z","pushed_at":"2016-09-20T08:19:49Z","git_url":"git://github.com/akka/akka-http.git","ssh_url":"git@github.com:akka/akka-http.git","clone_url":"https://github.com/akka/akka-http.git","svn_url":"https://github.com/akka/akka-http","homepage":"http://akka.io","size":17630,"stargazers_count":53,"watchers_count":53,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":264,"forks":11,"open_issues":264,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/321"},"html":{"href":"https://github.com/akka/akka-http/pull/321"},"issue":{"href":"https://api.github.com/repos/akka/akka-http/issues/321"},"comments":{"href":"https://api.github.com/repos/akka/akka-http/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-http/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-http/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-http/statuses/00bb4f830afaa00e5a2ec502a5720c10985aca7b"}}}}
{"actor":{"display_login":"rbudzko"}}