{"action":"created","issue":{"url":"https://api.github.com/repos/hack4impact/flask-base/issues/39","repository_url":"https://api.github.com/repos/hack4impact/flask-base","labels_url":"https://api.github.com/repos/hack4impact/flask-base/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/hack4impact/flask-base/issues/39/comments","events_url":"https://api.github.com/repos/hack4impact/flask-base/issues/39/events","html_url":"https://github.com/hack4impact/flask-base/pull/39","id":149018707,"number":39,"title":"Generalize SCSS bundle to track all SCSS files","user":{"login":"anniemeng","id":5404536,"avatar_url":"https://avatars.githubusercontent.com/u/5404536?v=3","gravatar_id":"","url":"https://api.github.com/users/anniemeng","html_url":"https://github.com/anniemeng","followers_url":"https://api.github.com/users/anniemeng/followers","following_url":"https://api.github.com/users/anniemeng/following{/other_user}","gists_url":"https://api.github.com/users/anniemeng/gists{/gist_id}","starred_url":"https://api.github.com/users/anniemeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anniemeng/subscriptions","organizations_url":"https://api.github.com/users/anniemeng/orgs","repos_url":"https://api.github.com/users/anniemeng/repos","events_url":"https://api.github.com/users/anniemeng/events{/privacy}","received_events_url":"https://api.github.com/users/anniemeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hack4impact/flask-base/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-18T01:50:20Z","updated_at":"2016-04-18T04:05:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hack4impact/flask-base/pulls/39","html_url":"https://github.com/hack4impact/flask-base/pull/39","diff_url":"https://github.com/hack4impact/flask-base/pull/39.diff","patch_url":"https://github.com/hack4impact/flask-base/pull/39.patch"},"body":"Initially the SCSS bundle only checked for ``app.scss`` and compiled it to ``app.css``.\r\nThere are two ways of adding more SCSS files to the bundle: \r\n1) Explicitly including the name of all SCSS files in the bundle to track \r\n```\r\napp_css = Bundle(\r\n  'file1.scss',\r\n  'file2.scss',\r\n  'file3.scss'\r\n  filters='scss',\r\n  output='styles/app.css'\r\n)\r\n```\r\n2) Tracking all SCSS files in ``assets/styles/``\r\n```\r\napp_css = Bundle(\r\n  '*.scss',\r\n  filters='scss',\r\n  output='styles/app.css'\r\n)\r\n```\r\n\r\nUsing the second option prevents forgetting to explicitly state each newly added SCSS file and modifying it if the SCSS filename changes. Also, when making more style changes over the entire app, it can be better to create many different SCSS files referring to different templates/areas of the app for better organization, to make it easier to understand and to modify vs. having one large SCSS file. However, since all these SCSS files will compile to one CSS file: ``app.css`` it can still be easily imported through ``partials/_head.html``"},"comment":{"url":"https://api.github.com/repos/hack4impact/flask-base/issues/comments/211189892","html_url":"https://github.com/hack4impact/flask-base/pull/39#issuecomment-211189892","issue_url":"https://api.github.com/repos/hack4impact/flask-base/issues/39","id":211189892,"user":{"login":"maxmcc","id":6675933,"avatar_url":"https://avatars.githubusercontent.com/u/6675933?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmcc","html_url":"https://github.com/maxmcc","followers_url":"https://api.github.com/users/maxmcc/followers","following_url":"https://api.github.com/users/maxmcc/following{/other_user}","gists_url":"https://api.github.com/users/maxmcc/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmcc/subscriptions","organizations_url":"https://api.github.com/users/maxmcc/orgs","repos_url":"https://api.github.com/users/maxmcc/repos","events_url":"https://api.github.com/users/maxmcc/events{/privacy}","received_events_url":"https://api.github.com/users/maxmcc/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T04:05:59Z","updated_at":"2016-04-18T04:05:59Z","body":"@anniemeng and I discussed this already (I suggested the PR). LGTM."}}