{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/130","id":9526497,"html_url":"https://github.com/SeleniumHQ/selenium/pull/130","diff_url":"https://github.com/SeleniumHQ/selenium/pull/130.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/130.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/130","number":130,"state":"closed","locked":false,"title":"Fixed incorrect behavior DefaultToFIFOPriorityTest (Issue 6504)","user":{"login":"nataliakoval","id":1820535,"avatar_url":"https://avatars.githubusercontent.com/u/1820535?v=3","gravatar_id":"","url":"https://api.github.com/users/nataliakoval","html_url":"https://github.com/nataliakoval","followers_url":"https://api.github.com/users/nataliakoval/followers","following_url":"https://api.github.com/users/nataliakoval/following{/other_user}","gists_url":"https://api.github.com/users/nataliakoval/gists{/gist_id}","starred_url":"https://api.github.com/users/nataliakoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nataliakoval/subscriptions","organizations_url":"https://api.github.com/users/nataliakoval/orgs","repos_url":"https://api.github.com/users/nataliakoval/repos","events_url":"https://api.github.com/users/nataliakoval/events{/privacy}","received_events_url":"https://api.github.com/users/nataliakoval/received_events","type":"User","site_admin":false},"body":"DefaultToFIFOPriorityTest fills the queue with MAX requests at loop: \r\n\r\n    for (MockedRequestHandler h : requests) {\r\n      final MockedRequestHandler req = h;\r\n      new Thread(new Runnable() {  // Thread safety reviewed\r\n        public void run() {\r\n          req.process();\r\n        }\r\n      }).start();\r\n    }\r\n\r\nand expects that  the order in the queue (NewSessionRequestQueue newSessionQueue in Registry class) will match to order of the list (List<MockedRequestHandler> requests). But this isn't always true, because the order running threads is not defined. \r\n\r\nThe test expects that first element in the queue will be same that in the list:\r\n    while (cpt < 8) {\r\n      try {\r\n        requests.get(0).getSession();\r\n        break;\r\n      } catch (Throwable e) {\r\n        // ignore.\r\n      }\r\n      Thread.sleep(250);\r\n    }\r\n\r\nif this not true, we get an infinite loop.\r\n\r\nI propose to switch next request when previous already added to queue.","created_at":"2013-10-30T14:23:10Z","updated_at":"2016-08-25T19:45:57Z","closed_at":"2016-08-25T19:45:57Z","merged_at":null,"merge_commit_sha":"80b58897e269f39e4e89d0ea29ed0ffbc46f519d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/130/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/130/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/130/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/11b656284038c887e986620a6e42ab9cfe2f1569","head":{"label":"nataliakoval:master","ref":"master","sha":"11b656284038c887e986620a6e42ab9cfe2f1569","user":{"login":"nataliakoval","id":1820535,"avatar_url":"https://avatars.githubusercontent.com/u/1820535?v=3","gravatar_id":"","url":"https://api.github.com/users/nataliakoval","html_url":"https://github.com/nataliakoval","followers_url":"https://api.github.com/users/nataliakoval/followers","following_url":"https://api.github.com/users/nataliakoval/following{/other_user}","gists_url":"https://api.github.com/users/nataliakoval/gists{/gist_id}","starred_url":"https://api.github.com/users/nataliakoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nataliakoval/subscriptions","organizations_url":"https://api.github.com/users/nataliakoval/orgs","repos_url":"https://api.github.com/users/nataliakoval/repos","events_url":"https://api.github.com/users/nataliakoval/events{/privacy}","received_events_url":"https://api.github.com/users/nataliakoval/received_events","type":"User","site_admin":false},"repo":{"id":13987616,"name":"selenium","full_name":"nataliakoval/selenium","owner":{"login":"nataliakoval","id":1820535,"avatar_url":"https://avatars.githubusercontent.com/u/1820535?v=3","gravatar_id":"","url":"https://api.github.com/users/nataliakoval","html_url":"https://github.com/nataliakoval","followers_url":"https://api.github.com/users/nataliakoval/followers","following_url":"https://api.github.com/users/nataliakoval/following{/other_user}","gists_url":"https://api.github.com/users/nataliakoval/gists{/gist_id}","starred_url":"https://api.github.com/users/nataliakoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nataliakoval/subscriptions","organizations_url":"https://api.github.com/users/nataliakoval/orgs","repos_url":"https://api.github.com/users/nataliakoval/repos","events_url":"https://api.github.com/users/nataliakoval/events{/privacy}","received_events_url":"https://api.github.com/users/nataliakoval/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nataliakoval/selenium","description":"A mirror of the Selenium source. Please log Issues in Google Code. Also confirm you have signed the CLA http://goo.gl/qC50R when making a Pull Request","fork":true,"url":"https://api.github.com/repos/nataliakoval/selenium","forks_url":"https://api.github.com/repos/nataliakoval/selenium/forks","keys_url":"https://api.github.com/repos/nataliakoval/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nataliakoval/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nataliakoval/selenium/teams","hooks_url":"https://api.github.com/repos/nataliakoval/selenium/hooks","issue_events_url":"https://api.github.com/repos/nataliakoval/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/nataliakoval/selenium/events","assignees_url":"https://api.github.com/repos/nataliakoval/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/nataliakoval/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/nataliakoval/selenium/tags","blobs_url":"https://api.github.com/repos/nataliakoval/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nataliakoval/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nataliakoval/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/nataliakoval/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nataliakoval/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/nataliakoval/selenium/languages","stargazers_url":"https://api.github.com/repos/nataliakoval/selenium/stargazers","contributors_url":"https://api.github.com/repos/nataliakoval/selenium/contributors","subscribers_url":"https://api.github.com/repos/nataliakoval/selenium/subscribers","subscription_url":"https://api.github.com/repos/nataliakoval/selenium/subscription","commits_url":"https://api.github.com/repos/nataliakoval/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/nataliakoval/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/nataliakoval/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/nataliakoval/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/nataliakoval/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/nataliakoval/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nataliakoval/selenium/merges","archive_url":"https://api.github.com/repos/nataliakoval/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nataliakoval/selenium/downloads","issues_url":"https://api.github.com/repos/nataliakoval/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/nataliakoval/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/nataliakoval/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/nataliakoval/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nataliakoval/selenium/labels{/name}","releases_url":"https://api.github.com/repos/nataliakoval/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/nataliakoval/selenium/deployments","created_at":"2013-10-30T13:42:52Z","updated_at":"2014-01-03T19:45:19Z","pushed_at":"2013-10-30T14:21:32Z","git_url":"git://github.com/nataliakoval/selenium.git","ssh_url":"git@github.com:nataliakoval/selenium.git","clone_url":"https://github.com/nataliakoval/selenium.git","svn_url":"https://github.com/nataliakoval/selenium","homepage":"https://code.google.com/p/selenium/","size":963484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"a38c7f6eb6a491662590a66dace74295df6f5c2d","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A browser automation framework and ecosystem.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/selenium/deployments","created_at":"2013-01-14T21:40:56Z","updated_at":"2016-08-25T19:24:46Z","pushed_at":"2016-08-25T16:04:37Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"http://seleniumhq.org/","size":1410266,"stargazers_count":4200,"watchers_count":4200,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2087,"mirror_url":null,"open_issues_count":484,"forks":2087,"open_issues":484,"watchers":4200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/130"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/130"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/130"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/11b656284038c887e986620a6e42ab9cfe2f1569"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":10,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"lukeis"}}