{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/67889096","id":67889096,"diff_hunk":"@@ -50,7 +50,7 @@\n             </li>\n         <% } else { %>\n             <li class=\"action action-delete wrapper-delete-button\" data-tooltip=\"<%- gettext('Cannot delete when in use by an experiment') %>\">\n-                <button class=\"delete action-icon is-disabled\" aria-disabled=\"true\" aria-hidden=\"true\" title=\"<%- gettext('Delete') %>\"><span class=\"icon fa fa-trash-o\"></span></button>\n+                <button class=\"delete action-icon is-disabled\" disabled=\"true\" title=\"<%- gettext('Delete') %>\"><span class=\"icon fa fa-trash-o\" aria-hidden=\"true\"></span></button>","path":"cms/templates/js/group-configuration-details.underscore","position":5,"original_position":5,"commit_id":"766690bef52ea9a5e620d9ad53fbc380200ac834","original_commit_id":"766690bef52ea9a5e620d9ad53fbc380200ac834","user":{"login":"ssemenova","id":6182097,"avatar_url":"https://avatars.githubusercontent.com/u/6182097?v=3","gravatar_id":"","url":"https://api.github.com/users/ssemenova","html_url":"https://github.com/ssemenova","followers_url":"https://api.github.com/users/ssemenova/followers","following_url":"https://api.github.com/users/ssemenova/following{/other_user}","gists_url":"https://api.github.com/users/ssemenova/gists{/gist_id}","starred_url":"https://api.github.com/users/ssemenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssemenova/subscriptions","organizations_url":"https://api.github.com/users/ssemenova/orgs","repos_url":"https://api.github.com/users/ssemenova/repos","events_url":"https://api.github.com/users/ssemenova/events{/privacy}","received_events_url":"https://api.github.com/users/ssemenova/received_events","type":"User","site_admin":false},"body":"Is it disabled=\"disabled\"???? I just thought I made a typo last time.\r\n\r\nWhat about the is-disabled class? Is just that sufficient?","created_at":"2016-06-21T15:18:14Z","updated_at":"2016-06-21T15:18:14Z","html_url":"https://github.com/edx/edx-platform/pull/12803#discussion_r67889096","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/12803","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/67889096"},"html":{"href":"https://github.com/edx/edx-platform/pull/12803#discussion_r67889096"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12803"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/12803","id":74455404,"html_url":"https://github.com/edx/edx-platform/pull/12803","diff_url":"https://github.com/edx/edx-platform/pull/12803.diff","patch_url":"https://github.com/edx/edx-platform/pull/12803.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/12803","number":12803,"state":"open","locked":false,"title":"Got rid of aria-disabled states ","user":{"login":"ssemenova","id":6182097,"avatar_url":"https://avatars.githubusercontent.com/u/6182097?v=3","gravatar_id":"","url":"https://api.github.com/users/ssemenova","html_url":"https://github.com/ssemenova","followers_url":"https://api.github.com/users/ssemenova/followers","following_url":"https://api.github.com/users/ssemenova/following{/other_user}","gists_url":"https://api.github.com/users/ssemenova/gists{/gist_id}","starred_url":"https://api.github.com/users/ssemenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssemenova/subscriptions","organizations_url":"https://api.github.com/users/ssemenova/orgs","repos_url":"https://api.github.com/users/ssemenova/repos","events_url":"https://api.github.com/users/ssemenova/events{/privacy}","received_events_url":"https://api.github.com/users/ssemenova/received_events","type":"User","site_admin":false},"body":"### Description\r\n \r\n[TNL-4805](https://openedx.atlassian.net/browse/TNL-4805)\r\n\r\nRemoved aria-disabled in a few places, based on [this PR](https://github.com/edx/edx-platform/pull/12747)\r\n\r\n### Sandbox\r\n- [ ] ssemenovadisabledstates.sandbox.edx.org\r\n\r\n### Testing\r\n- [ ] i18n\r\n- [ ] RTL\r\n- [ ] safecommit shows 0 violations\r\n- [ ] Unit, integration, acceptance tests as appropriate\r\n- [ ] Analytics\r\n- [ ] Performance\r\n- [ ] Database migrations are backwards-compatible\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @clrux \r\n- [x] Code review: @cahrens \r\n\r\n### Post-review\r\n- [ ] Squash commits\r\n","created_at":"2016-06-20T14:46:07Z","updated_at":"2016-06-21T15:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d1a2e649b8dac6940764bf25456978354c6dd8e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/12803/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/12803/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/12803/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/766690bef52ea9a5e620d9ad53fbc380200ac834","head":{"label":"edx:ssemenova/disabledstates","ref":"ssemenova/disabledstates","sha":"766690bef52ea9a5e620d9ad53fbc380200ac834","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-21T05:33:38Z","pushed_at":"2016-06-21T15:16:28Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":767072,"stargazers_count":2634,"watchers_count":2634,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1598,"mirror_url":null,"open_issues_count":175,"forks":1598,"open_issues":175,"watchers":2634,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"cae69f96007d90c4ebdce20939a19634a441d59e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-06-21T05:33:38Z","pushed_at":"2016-06-21T15:16:28Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":767072,"stargazers_count":2634,"watchers_count":2634,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1598,"mirror_url":null,"open_issues_count":175,"forks":1598,"open_issues":175,"watchers":2634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12803"},"html":{"href":"https://github.com/edx/edx-platform/pull/12803"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12803"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/12803/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12803/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/12803/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/766690bef52ea9a5e620d9ad53fbc380200ac834"}}}}
{"actor":{"display_login":"ssemenova"}}