{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/50323222","id":50323222,"diff_hunk":"@@ -80,6 +89,27 @@ func defaultPredicates() sets.String {\n \t\t),\n \t\t// Fit is determined by the presence of the Host parameter and a string match\n \t\tfactory.RegisterFitPredicate(\"HostName\", predicates.PodFitsHost),\n+\n+\t\t// Fit is determined by whether or not there would be too many AWS EBS volumes attached to the node\n+\t\tfactory.RegisterFitPredicateFactory(\n+\t\t\t\"MaxEBSVolumeCount\",\n+\t\t\tfunc(args factory.PluginFactoryArgs) algorithm.FitPredicate {\n+\t\t\t\t// According to Amazon, attaching more than 40 volumes can cause boot failures\n+\t\t\t\t// TODO: allow for generically parameterized scheduler predicates, because this is a bit ugly\n+\t\t\t\tvar maxEBSVols uint = DefaultMaxEBSVolumes\n+\t\t\t\tif rawMaxEBSVols := os.Getenv(\"KUBE_MAX_EBS_VOLS\"); rawMaxEBSVols != \"\" {","path":"plugin/pkg/scheduler/algorithmprovider/defaults/defaults.go","position":36,"original_position":36,"commit_id":"4230c5437715ec057b698238cd8ee24281341b67","original_commit_id":"4230c5437715ec057b698238cd8ee24281341b67","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"We don't know if the OpenShift Operations team (or other organizations' cluster administrators) want or plan to attach a fixed number of volumes to nodes. This is a way to allow the admins to reserve a fixed number of volumes outside of the scope of the pods.\r\n\r\nWe really don't like this approach for the long term, but it seems like a decent short term compromise. The scheduler predicate configuration mechanism is not generic at the moment, and I'd like to open a discussion with the community about how it should be designed going forward, but I don't want that to hold up this PR if we can avoid it.","created_at":"2016-01-20T21:37:30Z","updated_at":"2016-01-20T21:37:30Z","html_url":"https://github.com/kubernetes/kubernetes/pull/19880#discussion_r50323222","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/50323222"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19880#discussion_r50323222"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880","id":56657639,"html_url":"https://github.com/kubernetes/kubernetes/pull/19880","diff_url":"https://github.com/kubernetes/kubernetes/pull/19880.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19880.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19880","number":19880,"state":"open","locked":false,"title":"Scheduler predicate to cap AWS EBS volumes mounted on nodes","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"body":"According to Amazon (see http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/volume_limits.html#linux-specific-volume-limits), AWS instances with more AWS 40 volumes can cause boot issues (and there is also a hard cap on EBS volumes that's larger).  At least one of these 40 is the root volumes, and the rest can be other attached EBS volumes.\r\n\r\nThis PR introduces a scheduler predicate that allows administrators to cap the number of EBS volumes that kubelet would try to mount onto a given node.  The predicate would reject pods as not fitting if they would cause the total number of EBS volumes on the node to go over this limit.","created_at":"2016-01-20T19:49:17Z","updated_at":"2016-01-20T21:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac0c90965b3c55cf40867296e05d1a872a266222","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19880/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4230c5437715ec057b698238cd8ee24281341b67","head":{"label":"DirectXMan12:feature/limit-ebs-scheduler-predicate","ref":"feature/limit-ebs-scheduler-predicate","sha":"4230c5437715ec057b698238cd8ee24281341b67","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"repo":{"id":39400877,"name":"kubernetes","full_name":"DirectXMan12/kubernetes","owner":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DirectXMan12/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/DirectXMan12/kubernetes","forks_url":"https://api.github.com/repos/DirectXMan12/kubernetes/forks","keys_url":"https://api.github.com/repos/DirectXMan12/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectXMan12/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectXMan12/kubernetes/teams","hooks_url":"https://api.github.com/repos/DirectXMan12/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/DirectXMan12/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/DirectXMan12/kubernetes/events","assignees_url":"https://api.github.com/repos/DirectXMan12/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/DirectXMan12/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/DirectXMan12/kubernetes/tags","blobs_url":"https://api.github.com/repos/DirectXMan12/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectXMan12/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectXMan12/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectXMan12/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectXMan12/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectXMan12/kubernetes/languages","stargazers_url":"https://api.github.com/repos/DirectXMan12/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/DirectXMan12/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/DirectXMan12/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/DirectXMan12/kubernetes/subscription","commits_url":"https://api.github.com/repos/DirectXMan12/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectXMan12/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectXMan12/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectXMan12/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectXMan12/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/DirectXMan12/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectXMan12/kubernetes/merges","archive_url":"https://api.github.com/repos/DirectXMan12/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectXMan12/kubernetes/downloads","issues_url":"https://api.github.com/repos/DirectXMan12/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/DirectXMan12/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectXMan12/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectXMan12/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectXMan12/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/DirectXMan12/kubernetes/releases{/id}","created_at":"2015-07-20T18:22:30Z","updated_at":"2015-07-20T18:22:36Z","pushed_at":"2016-01-20T21:21:48Z","git_url":"git://github.com/DirectXMan12/kubernetes.git","ssh_url":"git@github.com:DirectXMan12/kubernetes.git","clone_url":"https://github.com/DirectXMan12/kubernetes.git","svn_url":"https://github.com/DirectXMan12/kubernetes","homepage":"http://kubernetes.io","size":146666,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a5d2c1b0fb23a145c47935f041a036d8546cd01f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-20T21:35:41Z","pushed_at":"2016-01-20T21:35:03Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":307100,"stargazers_count":12247,"watchers_count":12247,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3445,"mirror_url":null,"open_issues_count":2849,"forks":3445,"open_issues":2849,"watchers":12247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19880"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19880"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19880/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19880/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4230c5437715ec057b698238cd8ee24281341b67"}}}}