{"action":"closed","number":357,"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357","id":82723063,"html_url":"https://github.com/FormidableLabs/victory-chart/pull/357","diff_url":"https://github.com/FormidableLabs/victory-chart/pull/357.diff","patch_url":"https://github.com/FormidableLabs/victory-chart/pull/357.patch","issue_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357","number":357,"state":"closed","locked":false,"title":"Feature/Fix label overlap issue.","user":{"login":"nightwolfdu","id":5007467,"avatar_url":"https://avatars.githubusercontent.com/u/5007467?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwolfdu","html_url":"https://github.com/nightwolfdu","followers_url":"https://api.github.com/users/nightwolfdu/followers","following_url":"https://api.github.com/users/nightwolfdu/following{/other_user}","gists_url":"https://api.github.com/users/nightwolfdu/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwolfdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwolfdu/subscriptions","organizations_url":"https://api.github.com/users/nightwolfdu/orgs","repos_url":"https://api.github.com/users/nightwolfdu/repos","events_url":"https://api.github.com/users/nightwolfdu/events{/privacy}","received_events_url":"https://api.github.com/users/nightwolfdu/received_events","type":"User","site_admin":false},"body":"Hello! \r\nIt's partial fix 'label overlapping' , in situation when axis.size < sum(labels.size).\r\nAnd 'text size' helper, that predict VictoryLabel size based on text and font-style.\r\nI take out filtering code from \"renderGridAndTicks\" into individual function \"fixLabelOverlap\", that filter \r\n\"renderGridAndTicks\" result.\r\n\r\nWe discuss about it in Gitter, recently.\r\n\r\n> Lauren @boygirl авг. 11 20:05\r\n@deathmandu we could maybe approximate the size of the text based on length, number of lines, font size, padding etc. and filter it in renderGridAndTicks, but it wouldn't be exact. If we went this route, I would want to add a static method to VictoryLabel like getLabelDimensions, and call it in renderGridAndTicks. Option 2 is not viable for us since we use the same code base for victory-native\r\n@traverspinkerton you should style axis stuff on VictoryAxis like...\r\n","created_at":"2016-08-25T13:50:35Z","updated_at":"2016-09-02T15:46:16Z","closed_at":"2016-09-02T15:46:16Z","merged_at":"2016-09-02T15:46:16Z","merge_commit_sha":"d12a67e543bc5a00bdf757867f92793822b90ebc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357/commits","review_comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357/comments","review_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357/comments","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/c840aefd89b4b1a0fa0931fd6ccbb89c2ddc4871","head":{"label":"nightwolfdu:smart-tick-labels-merge","ref":"smart-tick-labels-merge","sha":"c840aefd89b4b1a0fa0931fd6ccbb89c2ddc4871","user":{"login":"nightwolfdu","id":5007467,"avatar_url":"https://avatars.githubusercontent.com/u/5007467?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwolfdu","html_url":"https://github.com/nightwolfdu","followers_url":"https://api.github.com/users/nightwolfdu/followers","following_url":"https://api.github.com/users/nightwolfdu/following{/other_user}","gists_url":"https://api.github.com/users/nightwolfdu/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwolfdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwolfdu/subscriptions","organizations_url":"https://api.github.com/users/nightwolfdu/orgs","repos_url":"https://api.github.com/users/nightwolfdu/repos","events_url":"https://api.github.com/users/nightwolfdu/events{/privacy}","received_events_url":"https://api.github.com/users/nightwolfdu/received_events","type":"User","site_admin":false},"repo":{"id":66558043,"name":"victory-chart","full_name":"nightwolfdu/victory-chart","owner":{"login":"nightwolfdu","id":5007467,"avatar_url":"https://avatars.githubusercontent.com/u/5007467?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwolfdu","html_url":"https://github.com/nightwolfdu","followers_url":"https://api.github.com/users/nightwolfdu/followers","following_url":"https://api.github.com/users/nightwolfdu/following{/other_user}","gists_url":"https://api.github.com/users/nightwolfdu/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwolfdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwolfdu/subscriptions","organizations_url":"https://api.github.com/users/nightwolfdu/orgs","repos_url":"https://api.github.com/users/nightwolfdu/repos","events_url":"https://api.github.com/users/nightwolfdu/events{/privacy}","received_events_url":"https://api.github.com/users/nightwolfdu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nightwolfdu/victory-chart","description":"Chart Component for Victory","fork":true,"url":"https://api.github.com/repos/nightwolfdu/victory-chart","forks_url":"https://api.github.com/repos/nightwolfdu/victory-chart/forks","keys_url":"https://api.github.com/repos/nightwolfdu/victory-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nightwolfdu/victory-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nightwolfdu/victory-chart/teams","hooks_url":"https://api.github.com/repos/nightwolfdu/victory-chart/hooks","issue_events_url":"https://api.github.com/repos/nightwolfdu/victory-chart/issues/events{/number}","events_url":"https://api.github.com/repos/nightwolfdu/victory-chart/events","assignees_url":"https://api.github.com/repos/nightwolfdu/victory-chart/assignees{/user}","branches_url":"https://api.github.com/repos/nightwolfdu/victory-chart/branches{/branch}","tags_url":"https://api.github.com/repos/nightwolfdu/victory-chart/tags","blobs_url":"https://api.github.com/repos/nightwolfdu/victory-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nightwolfdu/victory-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nightwolfdu/victory-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/nightwolfdu/victory-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nightwolfdu/victory-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/nightwolfdu/victory-chart/languages","stargazers_url":"https://api.github.com/repos/nightwolfdu/victory-chart/stargazers","contributors_url":"https://api.github.com/repos/nightwolfdu/victory-chart/contributors","subscribers_url":"https://api.github.com/repos/nightwolfdu/victory-chart/subscribers","subscription_url":"https://api.github.com/repos/nightwolfdu/victory-chart/subscription","commits_url":"https://api.github.com/repos/nightwolfdu/victory-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/nightwolfdu/victory-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/nightwolfdu/victory-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/nightwolfdu/victory-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/nightwolfdu/victory-chart/contents/{+path}","compare_url":"https://api.github.com/repos/nightwolfdu/victory-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nightwolfdu/victory-chart/merges","archive_url":"https://api.github.com/repos/nightwolfdu/victory-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nightwolfdu/victory-chart/downloads","issues_url":"https://api.github.com/repos/nightwolfdu/victory-chart/issues{/number}","pulls_url":"https://api.github.com/repos/nightwolfdu/victory-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/nightwolfdu/victory-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/nightwolfdu/victory-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nightwolfdu/victory-chart/labels{/name}","releases_url":"https://api.github.com/repos/nightwolfdu/victory-chart/releases{/id}","deployments_url":"https://api.github.com/repos/nightwolfdu/victory-chart/deployments","created_at":"2016-08-25T12:59:45Z","updated_at":"2016-08-25T12:59:47Z","pushed_at":"2016-09-02T15:34:00Z","git_url":"git://github.com/nightwolfdu/victory-chart.git","ssh_url":"git@github.com:nightwolfdu/victory-chart.git","clone_url":"https://github.com/nightwolfdu/victory-chart.git","svn_url":"https://github.com/nightwolfdu/victory-chart","homepage":"http://formidable.com/open-source/victory/docs/victory-chart/","size":14514,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"FormidableLabs:master","ref":"master","sha":"8418e7650fde8757b37fd608d22292b1e0131a7a","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40037231,"name":"victory-chart","full_name":"FormidableLabs/victory-chart","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars.githubusercontent.com/u/5078602?v=3","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/victory-chart","description":"Chart Component for Victory","fork":false,"url":"https://api.github.com/repos/FormidableLabs/victory-chart","forks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/forks","keys_url":"https://api.github.com/repos/FormidableLabs/victory-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/victory-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/victory-chart/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/victory-chart/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/events","assignees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/victory-chart/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/victory-chart/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/victory-chart/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/victory-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/victory-chart/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/victory-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/victory-chart/merges","archive_url":"https://api.github.com/repos/FormidableLabs/victory-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/victory-chart/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/victory-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/victory-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/victory-chart/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/victory-chart/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/deployments","created_at":"2015-08-01T06:05:36Z","updated_at":"2016-09-01T07:21:53Z","pushed_at":"2016-09-02T15:46:16Z","git_url":"git://github.com/FormidableLabs/victory-chart.git","ssh_url":"git@github.com:FormidableLabs/victory-chart.git","clone_url":"https://github.com/FormidableLabs/victory-chart.git","svn_url":"https://github.com/FormidableLabs/victory-chart","homepage":"http://formidable.com/open-source/victory/docs/victory-chart/","size":14819,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":20,"forks":35,"open_issues":20,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357"},"html":{"href":"https://github.com/FormidableLabs/victory-chart/pull/357"},"issue":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357"},"comments":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/FormidableLabs/victory-chart/statuses/c840aefd89b4b1a0fa0931fd6ccbb89c2ddc4871"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"boygirl","id":3719995,"avatar_url":"https://avatars.githubusercontent.com/u/3719995?v=3","gravatar_id":"","url":"https://api.github.com/users/boygirl","html_url":"https://github.com/boygirl","followers_url":"https://api.github.com/users/boygirl/followers","following_url":"https://api.github.com/users/boygirl/following{/other_user}","gists_url":"https://api.github.com/users/boygirl/gists{/gist_id}","starred_url":"https://api.github.com/users/boygirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boygirl/subscriptions","organizations_url":"https://api.github.com/users/boygirl/orgs","repos_url":"https://api.github.com/users/boygirl/repos","events_url":"https://api.github.com/users/boygirl/events{/privacy}","received_events_url":"https://api.github.com/users/boygirl/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":135,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"boygirl"}}