{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/9","id":75213529,"html_url":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pull/9","diff_url":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pull/9.diff","patch_url":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pull/9.patch","issue_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues/9","number":9,"state":"closed","locked":false,"title":"Update to Ionic2 beta.9, rework state","user":{"login":"brainlid","id":808984,"avatar_url":"https://avatars.githubusercontent.com/u/808984?v=3","gravatar_id":"","url":"https://api.github.com/users/brainlid","html_url":"https://github.com/brainlid","followers_url":"https://api.github.com/users/brainlid/followers","following_url":"https://api.github.com/users/brainlid/following{/other_user}","gists_url":"https://api.github.com/users/brainlid/gists{/gist_id}","starred_url":"https://api.github.com/users/brainlid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainlid/subscriptions","organizations_url":"https://api.github.com/users/brainlid/orgs","repos_url":"https://api.github.com/users/brainlid/repos","events_url":"https://api.github.com/users/brainlid/events{/privacy}","received_events_url":"https://api.github.com/users/brainlid/received_events","type":"User","site_admin":false},"body":"Update instructions:\r\n\r\n- remove the node_modules folder\r\n- `npm install -g typings@1.3.0`\r\n- `rm -rf typings` folder\r\n- `npm install`\r\n- `typings install`\r\n- `ionic serve` should work\r\n\r\nChange notes:\r\n\r\n- remove package \"keymirror\" and usage\r\n  - Had problems with it working (new typescript version issues?). Removed the package and reworked the usage to basic constants. Follows examples I've seen elsewhere like in ng2-redux.\r\n- fixed all typescript errors\r\n- removed redux-immutable (out of date and reworked to not need it)\r\n- cleans up page usage of state\r\n- makes state more explicitly typed\r\n- fixed accidental bad action constant values\r\n- removed \"typings\" folder and files from git\r\n\r\nAlso, I was getting everything updated before experimenting with adding jasmine unit tests. If you are interested in the testing version, I though it might be best to keep it as a separate branch. So there is a simpler \"see it work\" version (master) and then a branch that adds testing support and sample tests. \r\n\r\nWhat do you think?","created_at":"2016-06-25T20:18:59Z","updated_at":"2016-07-27T10:18:01Z","closed_at":"2016-07-27T10:18:01Z","merged_at":"2016-07-27T10:18:01Z","merge_commit_sha":"1092d9e02de92dbc303fef949d7c5bac4fd514d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/9/commits","review_comments_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/9/comments","review_comment_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues/9/comments","statuses_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/statuses/4ce6ef2b3173ecf31b8776f435a68dd7445f1106","head":{"label":"brainlid:state-rework","ref":"state-rework","sha":"4ce6ef2b3173ecf31b8776f435a68dd7445f1106","user":{"login":"brainlid","id":808984,"avatar_url":"https://avatars.githubusercontent.com/u/808984?v=3","gravatar_id":"","url":"https://api.github.com/users/brainlid","html_url":"https://github.com/brainlid","followers_url":"https://api.github.com/users/brainlid/followers","following_url":"https://api.github.com/users/brainlid/following{/other_user}","gists_url":"https://api.github.com/users/brainlid/gists{/gist_id}","starred_url":"https://api.github.com/users/brainlid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainlid/subscriptions","organizations_url":"https://api.github.com/users/brainlid/orgs","repos_url":"https://api.github.com/users/brainlid/repos","events_url":"https://api.github.com/users/brainlid/events{/privacy}","received_events_url":"https://api.github.com/users/brainlid/received_events","type":"User","site_admin":false},"repo":{"id":59749863,"name":"ionic2-angular2-ts-redux-boilerplate","full_name":"brainlid/ionic2-angular2-ts-redux-boilerplate","owner":{"login":"brainlid","id":808984,"avatar_url":"https://avatars.githubusercontent.com/u/808984?v=3","gravatar_id":"","url":"https://api.github.com/users/brainlid","html_url":"https://github.com/brainlid","followers_url":"https://api.github.com/users/brainlid/followers","following_url":"https://api.github.com/users/brainlid/following{/other_user}","gists_url":"https://api.github.com/users/brainlid/gists{/gist_id}","starred_url":"https://api.github.com/users/brainlid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainlid/subscriptions","organizations_url":"https://api.github.com/users/brainlid/orgs","repos_url":"https://api.github.com/users/brainlid/repos","events_url":"https://api.github.com/users/brainlid/events{/privacy}","received_events_url":"https://api.github.com/users/brainlid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brainlid/ionic2-angular2-ts-redux-boilerplate","description":"","fork":true,"url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate","forks_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/forks","keys_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/teams","hooks_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/events","assignees_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/tags","blobs_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/languages","stargazers_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/subscription","commits_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/merges","archive_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/downloads","issues_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/brainlid/ionic2-angular2-ts-redux-boilerplate/deployments","created_at":"2016-05-26T12:50:30Z","updated_at":"2016-05-26T12:50:31Z","pushed_at":"2016-06-26T02:42:37Z","git_url":"git://github.com/brainlid/ionic2-angular2-ts-redux-boilerplate.git","ssh_url":"git@github.com:brainlid/ionic2-angular2-ts-redux-boilerplate.git","clone_url":"https://github.com/brainlid/ionic2-angular2-ts-redux-boilerplate.git","svn_url":"https://github.com/brainlid/ionic2-angular2-ts-redux-boilerplate","homepage":null,"size":1055,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"janjarfalk:master","ref":"master","sha":"4b8af000720415402e2106c8d258337993672193","user":{"login":"janjarfalk","id":111975,"avatar_url":"https://avatars.githubusercontent.com/u/111975?v=3","gravatar_id":"","url":"https://api.github.com/users/janjarfalk","html_url":"https://github.com/janjarfalk","followers_url":"https://api.github.com/users/janjarfalk/followers","following_url":"https://api.github.com/users/janjarfalk/following{/other_user}","gists_url":"https://api.github.com/users/janjarfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/janjarfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janjarfalk/subscriptions","organizations_url":"https://api.github.com/users/janjarfalk/orgs","repos_url":"https://api.github.com/users/janjarfalk/repos","events_url":"https://api.github.com/users/janjarfalk/events{/privacy}","received_events_url":"https://api.github.com/users/janjarfalk/received_events","type":"User","site_admin":false},"repo":{"id":50750004,"name":"ionic2-angular2-ts-redux-boilerplate","full_name":"janjarfalk/ionic2-angular2-ts-redux-boilerplate","owner":{"login":"janjarfalk","id":111975,"avatar_url":"https://avatars.githubusercontent.com/u/111975?v=3","gravatar_id":"","url":"https://api.github.com/users/janjarfalk","html_url":"https://github.com/janjarfalk","followers_url":"https://api.github.com/users/janjarfalk/followers","following_url":"https://api.github.com/users/janjarfalk/following{/other_user}","gists_url":"https://api.github.com/users/janjarfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/janjarfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janjarfalk/subscriptions","organizations_url":"https://api.github.com/users/janjarfalk/orgs","repos_url":"https://api.github.com/users/janjarfalk/repos","events_url":"https://api.github.com/users/janjarfalk/events{/privacy}","received_events_url":"https://api.github.com/users/janjarfalk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate","description":"Ionic2 Typescript boilerplate with WKWebView, Redux, Immutablejs.","fork":false,"url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate","forks_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/forks","keys_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/teams","hooks_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/events","assignees_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/tags","blobs_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/languages","stargazers_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/subscription","commits_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/merges","archive_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/downloads","issues_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/deployments","created_at":"2016-01-30T23:25:46Z","updated_at":"2016-07-27T03:45:08Z","pushed_at":"2016-07-27T10:18:02Z","git_url":"git://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate.git","ssh_url":"git@github.com:janjarfalk/ionic2-angular2-ts-redux-boilerplate.git","clone_url":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate.git","svn_url":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate","homepage":"","size":1051,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/9"},"html":{"href":"https://github.com/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pull/9"},"issue":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues/9"},"comments":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/janjarfalk/ionic2-angular2-ts-redux-boilerplate/statuses/4ce6ef2b3173ecf31b8776f435a68dd7445f1106"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"janjarfalk","id":111975,"avatar_url":"https://avatars.githubusercontent.com/u/111975?v=3","gravatar_id":"","url":"https://api.github.com/users/janjarfalk","html_url":"https://github.com/janjarfalk","followers_url":"https://api.github.com/users/janjarfalk/followers","following_url":"https://api.github.com/users/janjarfalk/following{/other_user}","gists_url":"https://api.github.com/users/janjarfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/janjarfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janjarfalk/subscriptions","organizations_url":"https://api.github.com/users/janjarfalk/orgs","repos_url":"https://api.github.com/users/janjarfalk/repos","events_url":"https://api.github.com/users/janjarfalk/events{/privacy}","received_events_url":"https://api.github.com/users/janjarfalk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":8,"additions":129,"deletions":2275,"changed_files":25}}
{"actor":{"display_login":"janjarfalk"}}