{"action":"created","issue":{"url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner/issues/2374","repository_url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner","labels_url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner/issues/2374/labels{/name}","comments_url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner/issues/2374/comments","events_url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner/issues/2374/events","html_url":"https://github.com/opentripplanner/OpenTripPlanner/issues/2374","id":193828594,"number":2374,"title":"OSM Tag Combination \"highway=living_street\" and \"bicycle=designated\" prevent Drive routing.","user":{"login":"robludwig","id":7698940,"avatar_url":"https://avatars.githubusercontent.com/u/7698940?v=3","gravatar_id":"","url":"https://api.github.com/users/robludwig","html_url":"https://github.com/robludwig","followers_url":"https://api.github.com/users/robludwig/followers","following_url":"https://api.github.com/users/robludwig/following{/other_user}","gists_url":"https://api.github.com/users/robludwig/gists{/gist_id}","starred_url":"https://api.github.com/users/robludwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robludwig/subscriptions","organizations_url":"https://api.github.com/users/robludwig/orgs","repos_url":"https://api.github.com/users/robludwig/repos","events_url":"https://api.github.com/users/robludwig/events{/privacy}","received_events_url":"https://api.github.com/users/robludwig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-06T17:04:51Z","updated_at":"2016-12-07T08:08:12Z","closed_at":null,"body":"As [mentioned](https://groups.google.com/forum/#!topic/opentripplanner-users/IezGgeyQ8_E) in the Google Group I had a problem routing Drive Only trips on an OSM street tagged \"living_street\" in the Palo Alto area (steps to reproduce are in the linked thread).\r\n\r\nI found that the specific combination of tags \"highway=living_street\" and \"bicycle=designated\" made the edge bike/walk only. Thanks to input from Nawak Khurshid, I found that I could edit DefaultWayPropertySource to add an entry for that specific combination:\r\n`setProperties(props, \"highway=living_street;bicycle=designated\",\r\n                StreetTraversalPermission.BICYCLE_AND_CAR, 2, 2);` and routing worked. \r\n\r\nI know car routing is not a priority of the project, but is this the preferred way to make this edit or is there a better place to put the change that I'm not seeing?"},"comment":{"url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner/issues/comments/265382535","html_url":"https://github.com/opentripplanner/OpenTripPlanner/issues/2374#issuecomment-265382535","issue_url":"https://api.github.com/repos/opentripplanner/OpenTripPlanner/issues/2374","id":265382535,"user":{"login":"abyrd","id":112871,"avatar_url":"https://avatars.githubusercontent.com/u/112871?v=3","gravatar_id":"","url":"https://api.github.com/users/abyrd","html_url":"https://github.com/abyrd","followers_url":"https://api.github.com/users/abyrd/followers","following_url":"https://api.github.com/users/abyrd/following{/other_user}","gists_url":"https://api.github.com/users/abyrd/gists{/gist_id}","starred_url":"https://api.github.com/users/abyrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abyrd/subscriptions","organizations_url":"https://api.github.com/users/abyrd/orgs","repos_url":"https://api.github.com/users/abyrd/repos","events_url":"https://api.github.com/users/abyrd/events{/privacy}","received_events_url":"https://api.github.com/users/abyrd/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T08:08:12Z","updated_at":"2016-12-07T08:08:12Z","body":"Hi @robludwig, that file is indeed the right place to derive permissions from OSM tags. Adding a rule for a really specific set of tags, as you have done, fixes the problem. But the root of the problem may be the more general rule here:\r\nhttps://github.com/opentripplanner/OpenTripPlanner/blob/master/src/main/java/org/opentripplanner/graph_builder/module/osm/DefaultWayPropertySetSource.java#L343\r\n\r\n```Java\r\n/* bicycle=designated, but no bike infrastructure is present */\r\n        setProperties(props, \"highway=*;bicycle=designated\",\r\n                StreetTraversalPermission.PEDESTRIAN_AND_BICYCLE, 0.97, 0.97);\r\n```\r\n\r\nThis makes all roads with `bicycle=designated` default to pedestrian and bicycle only (no car), then adds permissions for all other modes for specific `highway=*` types in subsequent rules. Perhaps the general rule for `highway=*` should also use `StreetTraversalPermission.ALL`."}}
{"actor":{"display_login":"abyrd"}}