{"action":"created","issue":{"url":"https://api.github.com/repos/elixir-lang/elixir/issues/5508","repository_url":"https://api.github.com/repos/elixir-lang/elixir","labels_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5508/labels{/name}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5508/comments","events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5508/events","html_url":"https://github.com/elixir-lang/elixir/pull/5508","id":192629250,"number":5508,"title":"Hard-deprecate String.*strip/1,2 functions","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-30T17:30:12Z","updated_at":"2016-12-01T07:48:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/5508","html_url":"https://github.com/elixir-lang/elixir/pull/5508","diff_url":"https://github.com/elixir-lang/elixir/pull/5508.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/5508.patch"},"body":"First in a set of deprecations to be implemented for 1.5. I'd love to take care of all of them if no one argues against that :)\r\n\r\nAlso, I am not 100% sure we should keep the implementation in both `elixir_rewrite` as well as `String`, but it seems to be what we do for other rewrites. Suggestions?"},"comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments/264101728","html_url":"https://github.com/elixir-lang/elixir/pull/5508#issuecomment-264101728","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/5508","id":264101728,"user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T07:48:24Z","updated_at":"2016-12-01T07:48:24Z","body":"@josevalim I pushed a new commit that emits these deprecations in `elixir_dispatch` instead of when rewriting in `elixir_rewrite`. As far as I can tell, the final effect is the same but this seems to be much cleaner as there is no duplicated logic and we already handle deprecation of `Hash*` modules and some other stuff there anyways. Let me know how it looks :)"}}
{"actor":{"display_login":"whatyouhide"}}