{"comment":{"url":"https://api.github.com/repos/nagisa/rust/comments/15311672","html_url":"https://github.com/nagisa/rust/commit/8d3c613dd2976ed0e07940fd9e678e8c0b5ff6fe#commitcomment-15311672","id":15311672,"user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"8d3c613dd2976ed0e07940fd9e678e8c0b5ff6fe","created_at":"2016-01-07T09:42:40Z","updated_at":"2016-01-07T09:42:40Z","body":"> To expand about harm, I had to remove the implementation just to discover that return and else might be sharing the same problem which blocks had. \r\n\r\nYeah, that's what I meant by \"too non-obvious\". We might consider a helper fn in that case, but maybe it's fine to just inline the logic in those 3 cases."}}