{"action":"created","comment":{"url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments/64678659","id":64678659,"diff_hunk":"@@ -490,23 +492,23 @@ static void solution_thread(void *arg)\n     dops_t dops;\n     /* Calculate the SPP position\n      * disable_raim controlled by external setting. Defaults to false. */\n-    s8 ret = calc_PVT(n_ready_tdcp, nav_meas_tdcp, disable_raim,\n-                      &position_solution, &dops);\n-    if (ret < 0) {\n+    s8 pvt_ret = calc_PVT(n_ready_tdcp, nav_meas_tdcp, disable_raim,\n+                          &position_solution, &dops);\n+    if (pvt_ret < 0) {\n       /* An error occurred with calc_PVT! */\n       /* TODO: Make this based on time since last error instead of a simple\n        * count. */\n       /* pvt_err_msg defined in libswiftnav/pvt.c */\n       DO_EVERY((u32)soln_freq,\n-        log_warn(\"PVT solver: %s (code %d)\", pvt_err_msg[-ret-1], ret);\n+        log_warn(\"PVT solver: %s (code %d)\", pvt_err_msg[-pvt_ret-1], pvt_ret);","path":"src/solution.c","position":48,"original_position":48,"commit_id":"a770be2d14b1282ec17508efd2cb29a25e9af106","original_commit_id":"a770be2d14b1282ec17508efd2cb29a25e9af106","user":{"login":"ljbade","id":1215089,"avatar_url":"https://avatars.githubusercontent.com/u/1215089?v=3","gravatar_id":"","url":"https://api.github.com/users/ljbade","html_url":"https://github.com/ljbade","followers_url":"https://api.github.com/users/ljbade/followers","following_url":"https://api.github.com/users/ljbade/following{/other_user}","gists_url":"https://api.github.com/users/ljbade/gists{/gist_id}","starred_url":"https://api.github.com/users/ljbade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljbade/subscriptions","organizations_url":"https://api.github.com/users/ljbade/orgs","repos_url":"https://api.github.com/users/ljbade/repos","events_url":"https://api.github.com/users/ljbade/events{/privacy}","received_events_url":"https://api.github.com/users/ljbade/received_events","type":"User","site_admin":false},"body":"At some stage it would be nice to have a similar error message lookup for the dgnss_* functions instead of returning numbers.","created_at":"2016-05-26T01:11:40Z","updated_at":"2016-05-26T01:11:40Z","html_url":"https://github.com/swift-nav/piksi_firmware/pull/695#discussion_r64678659","pull_request_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695","_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments/64678659"},"html":{"href":"https://github.com/swift-nav/piksi_firmware/pull/695#discussion_r64678659"},"pull_request":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695"}}},"pull_request":{"url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695","id":70932094,"html_url":"https://github.com/swift-nav/piksi_firmware/pull/695","diff_url":"https://github.com/swift-nav/piksi_firmware/pull/695.diff","patch_url":"https://github.com/swift-nav/piksi_firmware/pull/695.patch","issue_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/695","number":695,"state":"open","locked":false,"title":"Fix calc_sat_state() and calc_nav_meas() error checking and locking","user":{"login":"jacobmcnamee","id":4461703,"avatar_url":"https://avatars.githubusercontent.com/u/4461703?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobmcnamee","html_url":"https://github.com/jacobmcnamee","followers_url":"https://api.github.com/users/jacobmcnamee/followers","following_url":"https://api.github.com/users/jacobmcnamee/following{/other_user}","gists_url":"https://api.github.com/users/jacobmcnamee/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobmcnamee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobmcnamee/subscriptions","organizations_url":"https://api.github.com/users/jacobmcnamee/orgs","repos_url":"https://api.github.com/users/jacobmcnamee/repos","events_url":"https://api.github.com/users/jacobmcnamee/events{/privacy}","received_events_url":"https://api.github.com/users/jacobmcnamee/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-20T23:59:45Z","updated_at":"2016-05-26T01:11:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27a62a071078875987bd03d9fc8c350ef957d8da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695/commits","review_comments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695/comments","review_comment_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/695/comments","statuses_url":"https://api.github.com/repos/swift-nav/piksi_firmware/statuses/a770be2d14b1282ec17508efd2cb29a25e9af106","head":{"label":"jacobmcnamee:eph_unlock","ref":"eph_unlock","sha":"a770be2d14b1282ec17508efd2cb29a25e9af106","user":{"login":"jacobmcnamee","id":4461703,"avatar_url":"https://avatars.githubusercontent.com/u/4461703?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobmcnamee","html_url":"https://github.com/jacobmcnamee","followers_url":"https://api.github.com/users/jacobmcnamee/followers","following_url":"https://api.github.com/users/jacobmcnamee/following{/other_user}","gists_url":"https://api.github.com/users/jacobmcnamee/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobmcnamee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobmcnamee/subscriptions","organizations_url":"https://api.github.com/users/jacobmcnamee/orgs","repos_url":"https://api.github.com/users/jacobmcnamee/repos","events_url":"https://api.github.com/users/jacobmcnamee/events{/privacy}","received_events_url":"https://api.github.com/users/jacobmcnamee/received_events","type":"User","site_admin":false},"repo":{"id":44843578,"name":"piksi_firmware","full_name":"jacobmcnamee/piksi_firmware","owner":{"login":"jacobmcnamee","id":4461703,"avatar_url":"https://avatars.githubusercontent.com/u/4461703?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobmcnamee","html_url":"https://github.com/jacobmcnamee","followers_url":"https://api.github.com/users/jacobmcnamee/followers","following_url":"https://api.github.com/users/jacobmcnamee/following{/other_user}","gists_url":"https://api.github.com/users/jacobmcnamee/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobmcnamee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobmcnamee/subscriptions","organizations_url":"https://api.github.com/users/jacobmcnamee/orgs","repos_url":"https://api.github.com/users/jacobmcnamee/repos","events_url":"https://api.github.com/users/jacobmcnamee/events{/privacy}","received_events_url":"https://api.github.com/users/jacobmcnamee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacobmcnamee/piksi_firmware","description":"Firmware for the Piksi GNSS receiver.","fork":true,"url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware","forks_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/forks","keys_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/teams","hooks_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/hooks","issue_events_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/events","assignees_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/tags","blobs_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/languages","stargazers_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/stargazers","contributors_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/contributors","subscribers_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/subscribers","subscription_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/subscription","commits_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/merges","archive_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/downloads","issues_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/labels{/name}","releases_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/jacobmcnamee/piksi_firmware/deployments","created_at":"2015-10-23T23:21:30Z","updated_at":"2015-10-23T23:21:32Z","pushed_at":"2016-05-25T02:13:35Z","git_url":"git://github.com/jacobmcnamee/piksi_firmware.git","ssh_url":"git@github.com:jacobmcnamee/piksi_firmware.git","clone_url":"https://github.com/jacobmcnamee/piksi_firmware.git","svn_url":"https://github.com/jacobmcnamee/piksi_firmware","homepage":"swift-nav.com","size":4629,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swift-nav:master","ref":"master","sha":"af5f9313b4c1145757ee8a4a9f4f73e22a93d530","user":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars.githubusercontent.com/u/1069835?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":2464156,"name":"piksi_firmware","full_name":"swift-nav/piksi_firmware","owner":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars.githubusercontent.com/u/1069835?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swift-nav/piksi_firmware","description":"Firmware for the Piksi GNSS receiver.","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_firmware","forks_url":"https://api.github.com/repos/swift-nav/piksi_firmware/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_firmware/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_firmware/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_firmware/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_firmware/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_firmware/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_firmware/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_firmware/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_firmware/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_firmware/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_firmware/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_firmware/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_firmware/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/deployments","created_at":"2011-09-26T23:35:50Z","updated_at":"2016-05-19T05:31:52Z","pushed_at":"2016-05-26T00:57:48Z","git_url":"git://github.com/swift-nav/piksi_firmware.git","ssh_url":"git@github.com:swift-nav/piksi_firmware.git","clone_url":"https://github.com/swift-nav/piksi_firmware.git","svn_url":"https://github.com/swift-nav/piksi_firmware","homepage":"swift-nav.com","size":6190,"stargazers_count":71,"watchers_count":71,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":139,"forks":86,"open_issues":139,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695"},"html":{"href":"https://github.com/swift-nav/piksi_firmware/pull/695"},"issue":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/695"},"comments":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/statuses/a770be2d14b1282ec17508efd2cb29a25e9af106"}}}}
{"actor":{"display_login":"ljbade"}}