{"action":"created","issue":{"url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/issues/95","repository_url":"https://api.github.com/repos/auraphp/Aura.SqlQuery","labels_url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/issues/95/comments","events_url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/issues/95/events","html_url":"https://github.com/auraphp/Aura.SqlQuery/pull/95","id":155787002,"number":95,"title":"Add reset functionality on the Select class","user":{"login":"pmjones","id":25754,"avatar_url":"https://avatars.githubusercontent.com/u/25754?v=3","gravatar_id":"","url":"https://api.github.com/users/pmjones","html_url":"https://github.com/pmjones","followers_url":"https://api.github.com/users/pmjones/followers","following_url":"https://api.github.com/users/pmjones/following{/other_user}","gists_url":"https://api.github.com/users/pmjones/gists{/gist_id}","starred_url":"https://api.github.com/users/pmjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmjones/subscriptions","organizations_url":"https://api.github.com/users/pmjones/orgs","repos_url":"https://api.github.com/users/pmjones/repos","events_url":"https://api.github.com/users/pmjones/events{/privacy}","received_events_url":"https://api.github.com/users/pmjones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-05-19T17:03:21Z","updated_at":"2016-08-02T21:36:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/pulls/95","html_url":"https://github.com/auraphp/Aura.SqlQuery/pull/95","diff_url":"https://github.com/auraphp/Aura.SqlQuery/pull/95.diff","patch_url":"https://github.com/auraphp/Aura.SqlQuery/pull/95.patch"},"body":"@yespire @golgote @gauthier @harikt --\r\n\r\nThis PR is based on #84 from @yespire. It combines the resetFrom(), resetFromKey(), and resetTableRefs() into a single resetTables() method, and adds resetBindValues() and resetUnions(). It removes resetLimit(), resetOffset(), resetPage(), because those values are accessible through existing limit(), offset(), and page() methods. Finally, the resetFlags() method is made public instead of protected, and now returns $this.\r\n\r\nIn summary, the newly-public reset methods are:\r\n\r\n- resetBindValues()\r\n- resetFlags()\r\n- resetCols()\r\n- resetTables()\r\n- resetWhere()\r\n- resetGroupBy()\r\n- resetHaving\r\n- resetOrderBy()\r\n- resetUnions()\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/issues/comments/237052567","html_url":"https://github.com/auraphp/Aura.SqlQuery/pull/95#issuecomment-237052567","issue_url":"https://api.github.com/repos/auraphp/Aura.SqlQuery/issues/95","id":237052567,"user":{"login":"compwright","id":138688,"avatar_url":"https://avatars.githubusercontent.com/u/138688?v=3","gravatar_id":"","url":"https://api.github.com/users/compwright","html_url":"https://github.com/compwright","followers_url":"https://api.github.com/users/compwright/followers","following_url":"https://api.github.com/users/compwright/following{/other_user}","gists_url":"https://api.github.com/users/compwright/gists{/gist_id}","starred_url":"https://api.github.com/users/compwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compwright/subscriptions","organizations_url":"https://api.github.com/users/compwright/orgs","repos_url":"https://api.github.com/users/compwright/repos","events_url":"https://api.github.com/users/compwright/events{/privacy}","received_events_url":"https://api.github.com/users/compwright/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T21:36:09Z","updated_at":"2016-08-02T21:36:09Z","body":"@harikt I was responding to @pmjones observation that some of these may not be needed. I would err on the side of flexibility because you can't really predict the ways queries may need to morph at runtime."}}
{"actor":{"display_login":"compwright"}}