{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/69972661","id":69972661,"diff_hunk":"@@ -9,6 +9,7 @@ done\n # Conda Python is in use, do not use virtualenv\n if python -V 2>&1 | grep -q -e 'Anaconda' -e 'Continuum Analytics' ; then\n     SET_VENV=0\n+    CONDA_ALREADY_INSTALLED=1","path":"scripts/common_startup.sh","position":4,"original_position":4,"commit_id":"b53a9275d54d8ed0373a11a4e95c500619a3d5b0","original_commit_id":"b53a9275d54d8ed0373a11a4e95c500619a3d5b0","user":{"login":"remimarenco","id":2152858,"avatar_url":"https://avatars.githubusercontent.com/u/2152858?v=3","gravatar_id":"","url":"https://api.github.com/users/remimarenco","html_url":"https://github.com/remimarenco","followers_url":"https://api.github.com/users/remimarenco/followers","following_url":"https://api.github.com/users/remimarenco/following{/other_user}","gists_url":"https://api.github.com/users/remimarenco/gists{/gist_id}","starred_url":"https://api.github.com/users/remimarenco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remimarenco/subscriptions","organizations_url":"https://api.github.com/users/remimarenco/orgs","repos_url":"https://api.github.com/users/remimarenco/repos","events_url":"https://api.github.com/users/remimarenco/events{/privacy}","received_events_url":"https://api.github.com/users/remimarenco/received_events","type":"User","site_admin":false},"body":"Nicola, thanks for taking the time to review this :).\r\n\r\nYes I hesitated, and I first did put in there. But then I saw the verbosity and thought it would be nice to put this as far as possible in the logs to have more chances for people to see it. Plus, I thought that it could be an open way for people to add more stuff to handle the case of Conda being already installed.\r\n\r\nIf you think it is not useful, and others too, I can totally move it back there and remove the extra variable.","created_at":"2016-07-07T19:39:18Z","updated_at":"2016-07-07T19:39:18Z","html_url":"https://github.com/galaxyproject/galaxy/pull/2596#discussion_r69972661","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/69972661"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/2596#discussion_r69972661"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596","id":76644996,"html_url":"https://github.com/galaxyproject/galaxy/pull/2596","diff_url":"https://github.com/galaxyproject/galaxy/pull/2596.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/2596.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/2596","number":2596,"state":"open","locked":false,"title":"Add Warning when Conda is installed ","user":{"login":"remimarenco","id":2152858,"avatar_url":"https://avatars.githubusercontent.com/u/2152858?v=3","gravatar_id":"","url":"https://api.github.com/users/remimarenco","html_url":"https://github.com/remimarenco","followers_url":"https://api.github.com/users/remimarenco/followers","following_url":"https://api.github.com/users/remimarenco/following{/other_user}","gists_url":"https://api.github.com/users/remimarenco/gists{/gist_id}","starred_url":"https://api.github.com/users/remimarenco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remimarenco/subscriptions","organizations_url":"https://api.github.com/users/remimarenco/orgs","repos_url":"https://api.github.com/users/remimarenco/repos","events_url":"https://api.github.com/users/remimarenco/events{/privacy}","received_events_url":"https://api.github.com/users/remimarenco/received_events","type":"User","site_admin":false},"body":"because we skip the virtualenv creation\r\n\r\nHere is a potential help for people having Conda installed, but then have issues because of missing dependencies (https://github.com/galaxyproject/galaxy/issues/1633).\r\n\r\nA few problematics still exist:\r\n\r\n- Is it normal to have failed dependencies? Do we expect people to have them because they installed Conda?\r\n- Do people will be able to see the Warning? The `run.sh` / `common_startup.sh` are pretty verbose. I don't expect everybody to check every line of code trying to find a Warning. So what can we do to help people find this errors, do you think?\r\n\r\nxref: https://github.com/galaxyproject/galaxy/issues/1633#issuecomment-231082404","created_at":"2016-07-07T18:42:09Z","updated_at":"2016-07-07T19:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e151259da6b1e069006cff92cf3b31508a2a30f","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/4","html_url":"https://github.com/galaxyproject/galaxy/milestones/16.07","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/4/labels","id":1682545,"number":4,"title":"16.07","description":"Tentative freeze date for Galaxy 16.07","creator":{"login":"martenson","id":1814954,"avatar_url":"https://avatars.githubusercontent.com/u/1814954?v=3","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":176,"state":"open","created_at":"2016-04-04T17:04:06Z","updated_at":"2016-07-07T19:01:46Z","due_on":"2016-07-11T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/2596/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/b53a9275d54d8ed0373a11a4e95c500619a3d5b0","head":{"label":"remimarenco:conda_virtualenv_warning","ref":"conda_virtualenv_warning","sha":"b53a9275d54d8ed0373a11a4e95c500619a3d5b0","user":{"login":"remimarenco","id":2152858,"avatar_url":"https://avatars.githubusercontent.com/u/2152858?v=3","gravatar_id":"","url":"https://api.github.com/users/remimarenco","html_url":"https://github.com/remimarenco","followers_url":"https://api.github.com/users/remimarenco/followers","following_url":"https://api.github.com/users/remimarenco/following{/other_user}","gists_url":"https://api.github.com/users/remimarenco/gists{/gist_id}","starred_url":"https://api.github.com/users/remimarenco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remimarenco/subscriptions","organizations_url":"https://api.github.com/users/remimarenco/orgs","repos_url":"https://api.github.com/users/remimarenco/repos","events_url":"https://api.github.com/users/remimarenco/events{/privacy}","received_events_url":"https://api.github.com/users/remimarenco/received_events","type":"User","site_admin":false},"repo":{"id":35874730,"name":"galaxy","full_name":"remimarenco/galaxy","owner":{"login":"remimarenco","id":2152858,"avatar_url":"https://avatars.githubusercontent.com/u/2152858?v=3","gravatar_id":"","url":"https://api.github.com/users/remimarenco","html_url":"https://github.com/remimarenco","followers_url":"https://api.github.com/users/remimarenco/followers","following_url":"https://api.github.com/users/remimarenco/following{/other_user}","gists_url":"https://api.github.com/users/remimarenco/gists{/gist_id}","starred_url":"https://api.github.com/users/remimarenco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remimarenco/subscriptions","organizations_url":"https://api.github.com/users/remimarenco/orgs","repos_url":"https://api.github.com/users/remimarenco/repos","events_url":"https://api.github.com/users/remimarenco/events{/privacy}","received_events_url":"https://api.github.com/users/remimarenco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remimarenco/galaxy","description":"Data intensive biology for everyone.","fork":true,"url":"https://api.github.com/repos/remimarenco/galaxy","forks_url":"https://api.github.com/repos/remimarenco/galaxy/forks","keys_url":"https://api.github.com/repos/remimarenco/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remimarenco/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remimarenco/galaxy/teams","hooks_url":"https://api.github.com/repos/remimarenco/galaxy/hooks","issue_events_url":"https://api.github.com/repos/remimarenco/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/remimarenco/galaxy/events","assignees_url":"https://api.github.com/repos/remimarenco/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/remimarenco/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/remimarenco/galaxy/tags","blobs_url":"https://api.github.com/repos/remimarenco/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remimarenco/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remimarenco/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/remimarenco/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remimarenco/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/remimarenco/galaxy/languages","stargazers_url":"https://api.github.com/repos/remimarenco/galaxy/stargazers","contributors_url":"https://api.github.com/repos/remimarenco/galaxy/contributors","subscribers_url":"https://api.github.com/repos/remimarenco/galaxy/subscribers","subscription_url":"https://api.github.com/repos/remimarenco/galaxy/subscription","commits_url":"https://api.github.com/repos/remimarenco/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/remimarenco/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/remimarenco/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/remimarenco/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/remimarenco/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/remimarenco/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remimarenco/galaxy/merges","archive_url":"https://api.github.com/repos/remimarenco/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remimarenco/galaxy/downloads","issues_url":"https://api.github.com/repos/remimarenco/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/remimarenco/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/remimarenco/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/remimarenco/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remimarenco/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/remimarenco/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/remimarenco/galaxy/deployments","created_at":"2015-05-19T10:10:19Z","updated_at":"2016-02-18T16:17:05Z","pushed_at":"2016-07-07T18:37:24Z","git_url":"git://github.com/remimarenco/galaxy.git","ssh_url":"git@github.com:remimarenco/galaxy.git","clone_url":"https://github.com/remimarenco/galaxy.git","svn_url":"https://github.com/remimarenco/galaxy","homepage":"http://galaxyproject.org/","size":122157,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"834c97a81da6cef6cfab0a14e86318fcc7cb38fe","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2016-07-05T07:48:29Z","pushed_at":"2016-07-07T18:42:10Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":161478,"stargazers_count":154,"watchers_count":154,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":501,"forks":225,"open_issues":501,"watchers":154,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/2596"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/2596"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/2596/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/2596/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/b53a9275d54d8ed0373a11a4e95c500619a3d5b0"}}}}
{"actor":{"display_login":"remimarenco"}}