{"action":"created","issue":{"url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/issues/45","repository_url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails","labels_url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/issues/45/comments","events_url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/issues/45/events","html_url":"https://github.com/sul-dlss/digital_stacks_rails/pull/45","id":152490311,"number":45,"title":"Media stream token management","user":{"login":"jmartin-sul","id":7741604,"avatar_url":"https://avatars.githubusercontent.com/u/7741604?v=3","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-02T06:38:23Z","updated_at":"2016-05-04T23:25:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/pulls/45","html_url":"https://github.com/sul-dlss/digital_stacks_rails/pull/45","diff_url":"https://github.com/sul-dlss/digital_stacks_rails/pull/45.diff","patch_url":"https://github.com/sul-dlss/digital_stacks_rails/pull/45.patch"},"body":"PR #44 should probably be merged first, then this should get rebased on top of that.\r\n\r\n* add a StacksMediaToken class for ephemeral authorization of access by a user to a StacksMediaStream.\r\n* have MediaController#stream include an encrypted token string in its redirects.\r\n* add MediaController#verify_token method (and route to it) to allow other services to verify tokens.\r\n\r\nresolve #28"},"comment":{"url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/issues/comments/217037356","html_url":"https://github.com/sul-dlss/digital_stacks_rails/pull/45#issuecomment-217037356","issue_url":"https://api.github.com/repos/sul-dlss/digital_stacks_rails/issues/45","id":217037356,"user":{"login":"jmartin-sul","id":7741604,"avatar_url":"https://avatars.githubusercontent.com/u/7741604?v=3","gravatar_id":"","url":"https://api.github.com/users/jmartin-sul","html_url":"https://github.com/jmartin-sul","followers_url":"https://api.github.com/users/jmartin-sul/followers","following_url":"https://api.github.com/users/jmartin-sul/following{/other_user}","gists_url":"https://api.github.com/users/jmartin-sul/gists{/gist_id}","starred_url":"https://api.github.com/users/jmartin-sul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmartin-sul/subscriptions","organizations_url":"https://api.github.com/users/jmartin-sul/orgs","repos_url":"https://api.github.com/users/jmartin-sul/repos","events_url":"https://api.github.com/users/jmartin-sul/events{/privacy}","received_events_url":"https://api.github.com/users/jmartin-sul/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T23:25:18Z","updated_at":"2016-05-04T23:25:18Z","body":"chatted w/ @jkeck a bit just now, sounds like he has no strong pref and is :ok_hand: with usage of `private_class_method` when the list of methods to be delineated as public/private is short (and it's just three short methods in this PR):\r\n\r\nfrom jessie:\r\n> I don’t have a super strong preference, I typically make a judgement call based on the code in the class (e.g. If I’m organizing lots of class methods into public and private, sometimes a clear delineation of them w/ a private is nice, and not having the duplicated private_class_method calls).  When just trying to make a few class methods private (that doesn’t necessarily fit into a good organizational context), I typically go w/ private_class_method."}}