{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/framework8-demo/issues/8","repository_url":"https://api.github.com/repos/vaadin/framework8-demo","labels_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/8/comments","events_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/8/events","html_url":"https://github.com/vaadin/framework8-demo/pull/8","id":171891174,"number":8,"title":"Registration form demo (#13)","user":{"login":"denis-anisimov","id":11425472,"avatar_url":"https://avatars.githubusercontent.com/u/11425472?v=3","gravatar_id":"","url":"https://api.github.com/users/denis-anisimov","html_url":"https://github.com/denis-anisimov","followers_url":"https://api.github.com/users/denis-anisimov/followers","following_url":"https://api.github.com/users/denis-anisimov/following{/other_user}","gists_url":"https://api.github.com/users/denis-anisimov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-anisimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-anisimov/subscriptions","organizations_url":"https://api.github.com/users/denis-anisimov/orgs","repos_url":"https://api.github.com/users/denis-anisimov/repos","events_url":"https://api.github.com/users/denis-anisimov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-anisimov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Artur-","id":260340,"avatar_url":"https://avatars.githubusercontent.com/u/260340?v=3","gravatar_id":"","url":"https://api.github.com/users/Artur-","html_url":"https://github.com/Artur-","followers_url":"https://api.github.com/users/Artur-/followers","following_url":"https://api.github.com/users/Artur-/following{/other_user}","gists_url":"https://api.github.com/users/Artur-/gists{/gist_id}","starred_url":"https://api.github.com/users/Artur-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artur-/subscriptions","organizations_url":"https://api.github.com/users/Artur-/orgs","repos_url":"https://api.github.com/users/Artur-/repos","events_url":"https://api.github.com/users/Artur-/events{/privacy}","received_events_url":"https://api.github.com/users/Artur-/received_events","type":"User","site_admin":false},"assignees":[{"login":"Artur-","id":260340,"avatar_url":"https://avatars.githubusercontent.com/u/260340?v=3","gravatar_id":"","url":"https://api.github.com/users/Artur-","html_url":"https://github.com/Artur-","followers_url":"https://api.github.com/users/Artur-/followers","following_url":"https://api.github.com/users/Artur-/following{/other_user}","gists_url":"https://api.github.com/users/Artur-/gists{/gist_id}","starred_url":"https://api.github.com/users/Artur-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Artur-/subscriptions","organizations_url":"https://api.github.com/users/Artur-/orgs","repos_url":"https://api.github.com/users/Artur-/repos","events_url":"https://api.github.com/users/Artur-/events{/privacy}","received_events_url":"https://api.github.com/users/Artur-/received_events","type":"User","site_admin":false},{"login":"hesara","id":1335918,"avatar_url":"https://avatars.githubusercontent.com/u/1335918?v=3","gravatar_id":"","url":"https://api.github.com/users/hesara","html_url":"https://github.com/hesara","followers_url":"https://api.github.com/users/hesara/followers","following_url":"https://api.github.com/users/hesara/following{/other_user}","gists_url":"https://api.github.com/users/hesara/gists{/gist_id}","starred_url":"https://api.github.com/users/hesara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesara/subscriptions","organizations_url":"https://api.github.com/users/hesara/orgs","repos_url":"https://api.github.com/users/hesara/repos","events_url":"https://api.github.com/users/hesara/events{/privacy}","received_events_url":"https://api.github.com/users/hesara/received_events","type":"User","site_admin":false},{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2016-08-18T12:39:48Z","updated_at":"2016-08-26T12:04:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/framework8-demo/pulls/8","html_url":"https://github.com/vaadin/framework8-demo/pull/8","diff_url":"https://github.com/vaadin/framework8-demo/pull/8.diff","patch_url":"https://github.com/vaadin/framework8-demo/pull/8.patch"},"body":"This requires #52 to be integrated along with corrections for the value change event for empty value bug.\r\n\r\nRight now it is not even compilable.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/framework8-demo/8)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/framework8-demo/issues/comments/242717115","html_url":"https://github.com/vaadin/framework8-demo/pull/8#issuecomment-242717115","issue_url":"https://api.github.com/repos/vaadin/framework8-demo/issues/8","id":242717115,"user":{"login":"elmot","id":5366945,"avatar_url":"https://avatars.githubusercontent.com/u/5366945?v=3","gravatar_id":"","url":"https://api.github.com/users/elmot","html_url":"https://github.com/elmot","followers_url":"https://api.github.com/users/elmot/followers","following_url":"https://api.github.com/users/elmot/following{/other_user}","gists_url":"https://api.github.com/users/elmot/gists{/gist_id}","starred_url":"https://api.github.com/users/elmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmot/subscriptions","organizations_url":"https://api.github.com/users/elmot/orgs","repos_url":"https://api.github.com/users/elmot/repos","events_url":"https://api.github.com/users/elmot/events{/privacy}","received_events_url":"https://api.github.com/users/elmot/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T12:04:14Z","updated_at":"2016-08-26T12:04:14Z","body":"\n\n\n\nReview status: 9 of 10 files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[registration-form/src/main/java/com/vaadin/demo/registration/EmailOrPhoneValidator.java, line 46 \\[r3\\]](https://reviewable.io:443/reviews/vaadin/framework8-demo/8#-KPY95RJz1K_wBhtHqT3:-KPYRgRhkW-nI38xkALq:b-ubu54z) ([raw file](https://github.com/vaadin/framework8-demo/blob/89fc0bbfed6dcd9f2418ca8732cfc2cd4ce71deb/registration-form/src/main/java/com/vaadin/demo/registration/EmailOrPhoneValidator.java#L46)):*\n<details><summary><i>Previously, denis-anisimov wrote…</i></summary>\n> Don't know what you mean.\n> Which messages ?\n> If you are talking about this one and message below in \"else\" then this is because different checks.\n> Read the code.\n</details>\nI see they are for different checks. Nevertheless, message should be the same, with full password requirements, and failure code needs to be deduplicated.\n\n---\n\n*[registration-form/src/main/java/com/vaadin/demo/registration/RegistrationFormUI.java, line 212 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/framework8-demo/8#-KPTDUEbCuoQP7dMHvGR:-KQ5j3CR1mbpBZO-mZzF:btp540x) ([raw file](https://github.com/vaadin/framework8-demo/blob/a1fc1b7c8befde55292ea1aafb3eb2654ff1912b/registration-form/src/main/java/com/vaadin/demo/registration/RegistrationFormUI.java#L212)):*\n<details><summary><i>Previously, denis-anisimov wrote…</i></summary>\n> Not constructive. \n> Suggest better solution.\n</details>\nhttps://github.com/vaadin/framework8-demo/blob/registration-from-linearized/registration-form/src/main/java/com/vaadin/demo/registration/RegistrationFormUI.java\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/framework8-demo/8)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"elmot"}}