{"action":"created","comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/49642179","id":49642179,"diff_hunk":"@@ -20,39 +20,17 @@ private NativeUtils() {\n     }\n \n     /**\n-     * This will read from /proc/version to attempt to find the Linux distribution.\n-     * @return The Linux distribution or null if the version cannot be found.\n-     * @throws IOException If an I/O error occurs\n-     */\n-    public static String getDistroName() throws IOException {\n-        Pattern distroRegex = Pattern.compile(\"[^(]+\\\\([^(]+\\\\([^(]+\\\\(([A-Za-z\\\\s]+).*\");\n-        BufferedReader reader = new BufferedReader(new FileReader(\"/proc/version\"));\n-        String distro;\n-        try {\n-            Matcher line = distroRegex.matcher(reader.readLine());\n-            distro = line.matches() ? line.group(1) : null;\n-        }\n-        finally {\n-            reader.close();\n-        }\n-        return distro;\n-    }\n-\n-    /**\n-     * This will attempt to find the Linux version by making use of {@code lsb_release -r}","path":"java/src/main/java/vw/jni/NativeUtils.java","position":23,"original_position":23,"commit_id":"5fcc2192d0444f8beafb906d1fb6706e97805e12","original_commit_id":"a47c1eb80fc840bbc9f1df202b18ecc5fb0d2218","user":{"login":"jmorra","id":117275,"avatar_url":"https://avatars.githubusercontent.com/u/117275?v=3","gravatar_id":"","url":"https://api.github.com/users/jmorra","html_url":"https://github.com/jmorra","followers_url":"https://api.github.com/users/jmorra/followers","following_url":"https://api.github.com/users/jmorra/following{/other_user}","gists_url":"https://api.github.com/users/jmorra/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorra/subscriptions","organizations_url":"https://api.github.com/users/jmorra/orgs","repos_url":"https://api.github.com/users/jmorra/repos","events_url":"https://api.github.com/users/jmorra/events{/privacy}","received_events_url":"https://api.github.com/users/jmorra/received_events","type":"User","site_admin":false},"body":"JavaDoc requires \\@param for the arguments here.","created_at":"2016-01-13T19:57:41Z","updated_at":"2016-01-13T19:57:41Z","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/904#discussion_r49642179","pull_request_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904","_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments/49642179"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/904#discussion_r49642179"},"pull_request":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904","id":55392940,"html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/904","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/904.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/904.patch","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/904","number":904,"state":"open","locked":false,"title":"java NativeUtils: lsb_release to get linux distro and version","user":{"login":"adgaudio","id":860369,"avatar_url":"https://avatars.githubusercontent.com/u/860369?v=3","gravatar_id":"","url":"https://api.github.com/users/adgaudio","html_url":"https://github.com/adgaudio","followers_url":"https://api.github.com/users/adgaudio/followers","following_url":"https://api.github.com/users/adgaudio/following{/other_user}","gists_url":"https://api.github.com/users/adgaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/adgaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adgaudio/subscriptions","organizations_url":"https://api.github.com/users/adgaudio/orgs","repos_url":"https://api.github.com/users/adgaudio/repos","events_url":"https://api.github.com/users/adgaudio/events{/privacy}","received_events_url":"https://api.github.com/users/adgaudio/received_events","type":"User","site_admin":false},"body":"closes #894 \r\nrelated:  #807 #780 #822\r\n\r\na change to java NativeUtils class to attempt more standardized access to linux distro and version\r\nfixes a couple bugs in build.sh\r\nupdates readme\r\n\r\n\r\n@jmorra Build.sh passes up to the last 3 lines, where I have issues (unrelated to this PR) compiling the C code on my mac.  After some bug fixes to build.sh, VW appears to compile correctly in the linux docker images.   Could you check out this branch and try to compile it on your mac?  Or if you happen to know what's wrong in the traceback below, that would be helpful.  I wouldn't think this change should prevent VW java from working on mac, as the changes relate to linux issues, but it probably makes sense to check.\r\n\r\n---\r\n\r\nSome error msgs (unrelated to this PR) that I get when trying to manually compile VW on my mac (10.11.2):\r\n```\r\n./../explore/cpp/utility.h:241:24: note: candidate function not viable: no known conversion from\r\n      'size_t' (aka 'unsigned long') to 'u32 &' (aka 'unsigned int &') for 1st argument\r\n  static inline string to_string(u32& n)\r\n                       ^\r\ncbify.cc:277:78: error: no matching function for call to 'to_string'\r\n  ...= data.mwt_explorer->Choose_Action(*data.generic_explorer, StringUtils::to_string(ec.exa...\r\n              ```","created_at":"2016-01-07T21:30:44Z","updated_at":"2016-01-13T19:57:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbdc3cfd1d8abcb9ea6bbb21021797a4cdc381ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904/commits","review_comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904/comments","review_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/904/comments","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/5fcc2192d0444f8beafb906d1fb6706e97805e12","head":{"label":"adgaudio:use_lsb_release","ref":"use_lsb_release","sha":"5fcc2192d0444f8beafb906d1fb6706e97805e12","user":{"login":"adgaudio","id":860369,"avatar_url":"https://avatars.githubusercontent.com/u/860369?v=3","gravatar_id":"","url":"https://api.github.com/users/adgaudio","html_url":"https://github.com/adgaudio","followers_url":"https://api.github.com/users/adgaudio/followers","following_url":"https://api.github.com/users/adgaudio/following{/other_user}","gists_url":"https://api.github.com/users/adgaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/adgaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adgaudio/subscriptions","organizations_url":"https://api.github.com/users/adgaudio/orgs","repos_url":"https://api.github.com/users/adgaudio/repos","events_url":"https://api.github.com/users/adgaudio/events{/privacy}","received_events_url":"https://api.github.com/users/adgaudio/received_events","type":"User","site_admin":false},"repo":{"id":49169297,"name":"vowpal_wabbit","full_name":"adgaudio/vowpal_wabbit","owner":{"login":"adgaudio","id":860369,"avatar_url":"https://avatars.githubusercontent.com/u/860369?v=3","gravatar_id":"","url":"https://api.github.com/users/adgaudio","html_url":"https://github.com/adgaudio","followers_url":"https://api.github.com/users/adgaudio/followers","following_url":"https://api.github.com/users/adgaudio/following{/other_user}","gists_url":"https://api.github.com/users/adgaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/adgaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adgaudio/subscriptions","organizations_url":"https://api.github.com/users/adgaudio/orgs","repos_url":"https://api.github.com/users/adgaudio/repos","events_url":"https://api.github.com/users/adgaudio/events{/privacy}","received_events_url":"https://api.github.com/users/adgaudio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adgaudio/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":true,"url":"https://api.github.com/repos/adgaudio/vowpal_wabbit","forks_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/adgaudio/vowpal_wabbit/releases{/id}","created_at":"2016-01-07T00:00:07Z","updated_at":"2016-01-07T00:00:11Z","pushed_at":"2016-01-12T18:56:58Z","git_url":"git://github.com/adgaudio/vowpal_wabbit.git","ssh_url":"git@github.com:adgaudio/vowpal_wabbit.git","clone_url":"https://github.com/adgaudio/vowpal_wabbit.git","svn_url":"https://github.com/adgaudio/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":99057,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JohnLangford:master","ref":"master","sha":"84cc08f3287303ee689638a1ecd2514a14cb82d9","user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"repo":{"id":265995,"name":"vowpal_wabbit","full_name":"JohnLangford/vowpal_wabbit","owner":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnLangford/vowpal_wabbit","description":"Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.","fork":false,"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","forks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/forks","keys_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/teams","hooks_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/hooks","issue_events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/events{/number}","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/events","assignees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/assignees{/user}","branches_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/branches{/branch}","tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/tags","blobs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/languages","stargazers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/stargazers","contributors_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contributors","subscribers_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscribers","subscription_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/subscription","commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/contents/{+path}","compare_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/merges","archive_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/downloads","issues_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues{/number}","pulls_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/labels{/name}","releases_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/releases{/id}","created_at":"2009-07-31T19:36:58Z","updated_at":"2016-01-13T17:30:35Z","pushed_at":"2016-01-12T21:31:38Z","git_url":"git://github.com/JohnLangford/vowpal_wabbit.git","ssh_url":"git@github.com:JohnLangford/vowpal_wabbit.git","clone_url":"https://github.com/JohnLangford/vowpal_wabbit.git","svn_url":"https://github.com/JohnLangford/vowpal_wabbit","homepage":"http://hunch.net/~vw/","size":102277,"stargazers_count":3069,"watchers_count":3069,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":862,"mirror_url":null,"open_issues_count":37,"forks":862,"open_issues":37,"watchers":3069,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904"},"html":{"href":"https://github.com/JohnLangford/vowpal_wabbit/pull/904"},"issue":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/904"},"comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/statuses/5fcc2192d0444f8beafb906d1fb6706e97805e12"}}}}