{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/94254764","pull_request_review_id":14786085,"id":94254764,"diff_hunk":"@@ -253,6 +253,11 @@ void WorldSession::HandleAutoEquipItemOpcode(WorldPacket& recvData)\n             _player->EquipItem(eSrc, pDstItem, true);\n \n         _player->AutoUnequipOffhandIfNeed();\n+\n+        // if inventory item was moved, check if we can remove dependent auras, because they were not removed in Player::RemoveItem (update was set to false)\n+        // do this after swaps are done, we pass nullptr because both weapons could be swapped and none of them should be ignored\n+        if ((srcbag == INVENTORY_SLOT_BAG_0 && srcslot < INVENTORY_SLOT_BAG_END) || (dstbag == INVENTORY_SLOT_BAG_0 && dstslot < INVENTORY_SLOT_BAG_END))\n+            _player->ApplyItemDependentAuras((Item*)nullptr, false);","path":"src/server/game/Handlers/ItemHandler.cpp","position":8,"original_position":8,"commit_id":"b639f34ca8227702368769bbb5ec0be5a2ca2eaa","original_commit_id":"b639f34ca8227702368769bbb5ec0be5a2ca2eaa","user":{"login":"xinef1","id":2781353,"avatar_url":"https://avatars.githubusercontent.com/u/2781353?v=3","gravatar_id":"","url":"https://api.github.com/users/xinef1","html_url":"https://github.com/xinef1","followers_url":"https://api.github.com/users/xinef1/followers","following_url":"https://api.github.com/users/xinef1/following{/other_user}","gists_url":"https://api.github.com/users/xinef1/gists{/gist_id}","starred_url":"https://api.github.com/users/xinef1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinef1/subscriptions","organizations_url":"https://api.github.com/users/xinef1/orgs","repos_url":"https://api.github.com/users/xinef1/repos","events_url":"https://api.github.com/users/xinef1/events{/privacy}","received_events_url":"https://api.github.com/users/xinef1/received_events","type":"User","site_admin":false},"body":"There can be only one intention of nullptr cast, but I agree that we should use c++ casts.","created_at":"2016-12-30T20:06:42Z","updated_at":"2016-12-30T20:06:42Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/18592#discussion_r94254764","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/94254764"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18592#discussion_r94254764"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592","id":99332175,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/18592","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/18592.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/18592.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18592","number":18592,"state":"closed","locked":false,"title":"Fixed problem where item dependent auras are not properly updated","user":{"login":"xinef1","id":2781353,"avatar_url":"https://avatars.githubusercontent.com/u/2781353?v=3","gravatar_id":"","url":"https://api.github.com/users/xinef1","html_url":"https://github.com/xinef1","followers_url":"https://api.github.com/users/xinef1/followers","following_url":"https://api.github.com/users/xinef1/following{/other_user}","gists_url":"https://api.github.com/users/xinef1/gists{/gist_id}","starred_url":"https://api.github.com/users/xinef1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinef1/subscriptions","organizations_url":"https://api.github.com/users/xinef1/orgs","repos_url":"https://api.github.com/users/xinef1/repos","events_url":"https://api.github.com/users/xinef1/events{/privacy}","received_events_url":"https://api.github.com/users/xinef1/received_events","type":"User","site_admin":false},"body":"**Target branch(es):** 3.3.5\r\n\r\n- [x] 3.3.5\r\n\r\n**Issues addressed:** Closes #18506\r\n\r\n**Tests performed:** Compiles and fixes the problem\r\n","created_at":"2016-12-26T00:39:11Z","updated_at":"2016-12-30T20:06:42Z","closed_at":"2016-12-30T19:38:55Z","merged_at":"2016-12-30T19:38:55Z","merge_commit_sha":"90a330c910804f9cb770681ff646a2362c8c0efa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18592/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/b639f34ca8227702368769bbb5ec0be5a2ca2eaa","head":{"label":"xinef1:3.3.5.items","ref":"3.3.5.items","sha":"b639f34ca8227702368769bbb5ec0be5a2ca2eaa","user":{"login":"xinef1","id":2781353,"avatar_url":"https://avatars.githubusercontent.com/u/2781353?v=3","gravatar_id":"","url":"https://api.github.com/users/xinef1","html_url":"https://github.com/xinef1","followers_url":"https://api.github.com/users/xinef1/followers","following_url":"https://api.github.com/users/xinef1/following{/other_user}","gists_url":"https://api.github.com/users/xinef1/gists{/gist_id}","starred_url":"https://api.github.com/users/xinef1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinef1/subscriptions","organizations_url":"https://api.github.com/users/xinef1/orgs","repos_url":"https://api.github.com/users/xinef1/repos","events_url":"https://api.github.com/users/xinef1/events{/privacy}","received_events_url":"https://api.github.com/users/xinef1/received_events","type":"User","site_admin":false},"repo":{"id":77341514,"name":"TrinityCore","full_name":"xinef1/TrinityCore","owner":{"login":"xinef1","id":2781353,"avatar_url":"https://avatars.githubusercontent.com/u/2781353?v=3","gravatar_id":"","url":"https://api.github.com/users/xinef1","html_url":"https://github.com/xinef1","followers_url":"https://api.github.com/users/xinef1/followers","following_url":"https://api.github.com/users/xinef1/following{/other_user}","gists_url":"https://api.github.com/users/xinef1/gists{/gist_id}","starred_url":"https://api.github.com/users/xinef1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinef1/subscriptions","organizations_url":"https://api.github.com/users/xinef1/orgs","repos_url":"https://api.github.com/users/xinef1/repos","events_url":"https://api.github.com/users/xinef1/events{/privacy}","received_events_url":"https://api.github.com/users/xinef1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xinef1/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/xinef1/TrinityCore","forks_url":"https://api.github.com/repos/xinef1/TrinityCore/forks","keys_url":"https://api.github.com/repos/xinef1/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xinef1/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xinef1/TrinityCore/teams","hooks_url":"https://api.github.com/repos/xinef1/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/xinef1/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/xinef1/TrinityCore/events","assignees_url":"https://api.github.com/repos/xinef1/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/xinef1/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/xinef1/TrinityCore/tags","blobs_url":"https://api.github.com/repos/xinef1/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xinef1/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xinef1/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/xinef1/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xinef1/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/xinef1/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/xinef1/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/xinef1/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/xinef1/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/xinef1/TrinityCore/subscription","commits_url":"https://api.github.com/repos/xinef1/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/xinef1/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/xinef1/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/xinef1/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/xinef1/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/xinef1/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xinef1/TrinityCore/merges","archive_url":"https://api.github.com/repos/xinef1/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xinef1/TrinityCore/downloads","issues_url":"https://api.github.com/repos/xinef1/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/xinef1/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/xinef1/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/xinef1/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xinef1/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/xinef1/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/xinef1/TrinityCore/deployments","created_at":"2016-12-25T20:20:13Z","updated_at":"2016-12-25T20:20:30Z","pushed_at":"2016-12-30T18:17:10Z","git_url":"git://github.com/xinef1/TrinityCore.git","ssh_url":"git@github.com:xinef1/TrinityCore.git","clone_url":"https://github.com/xinef1/TrinityCore.git","svn_url":"https://github.com/xinef1/TrinityCore","homepage":"http://www.trinitycore.org","size":397451,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"87092140740b7d6e30687345f8df1984222c2946","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-12-30T13:23:12Z","pushed_at":"2016-12-30T19:38:55Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":398244,"stargazers_count":3580,"watchers_count":3580,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3625,"mirror_url":null,"open_issues_count":1292,"forks":3625,"open_issues":1292,"watchers":3580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/18592"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18592"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18592/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/18592/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/b639f34ca8227702368769bbb5ec0be5a2ca2eaa"}}}}
{"actor":{"display_login":"xinef1"}}