{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/ros1_bridge/issues/42","repository_url":"https://api.github.com/repos/ros2/ros1_bridge","labels_url":"https://api.github.com/repos/ros2/ros1_bridge/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/ros2/ros1_bridge/issues/42/comments","events_url":"https://api.github.com/repos/ros2/ros1_bridge/issues/42/events","html_url":"https://github.com/ros2/ros1_bridge/pull/42","id":193651372,"number":42,"title":"Add option for bridging all topics","user":{"login":"dhood","id":5618076,"avatar_url":"https://avatars.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"labels":[{"id":225825347,"url":"https://api.github.com/repos/ros2/ros1_bridge/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"dhood","id":5618076,"avatar_url":"https://avatars.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"assignees":[{"login":"dhood","id":5618076,"avatar_url":"https://avatars.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-06T00:34:40Z","updated_at":"2016-12-07T17:31:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros2/ros1_bridge/pulls/42","html_url":"https://github.com/ros2/ros1_bridge/pull/42","diff_url":"https://github.com/ros2/ros1_bridge/pull/42.diff","patch_url":"https://github.com/ros2/ros1_bridge/pull/42.patch"},"body":"without this, getting a topic to be bridged requires starting up temporary subscribers on the other side. introspection tools e.g. `rostopic list` can't see ROS 2 publishers, and tools such as `rosbag record --all` aren't very usable.\r\n\r\nWith this, bridges will be made for any topic that has a known mapping, whether subscribers are on the other side or not.\r\n\r\nright now it is trying to make a bridge for a topic even if it doesn't have a known mapping, so you get e.g. `failed to create 1to2 bridge for topic 'rosout_agg' with ROS 1 type 'rosgraph_msgs/Log' and ROS 2 type '': No template specialization for the pair` printed out. I will fix it by adding a function that check if a factory exists for the type before forcibly creating the mapping."},"comment":{"url":"https://api.github.com/repos/ros2/ros1_bridge/issues/comments/265514229","html_url":"https://github.com/ros2/ros1_bridge/pull/42#issuecomment-265514229","issue_url":"https://api.github.com/repos/ros2/ros1_bridge/issues/42","id":265514229,"user":{"login":"dhood","id":5618076,"avatar_url":"https://avatars.githubusercontent.com/u/5618076?v=3","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T17:31:22Z","updated_at":"2016-12-07T17:31:22Z","body":"Thanks for the point about the non-1:1 mappings. it doesn't seem like it will be much effort to make [this new method](https://github.com/ros2/ros1_bridge/pull/42/commits/8485326b578cc65c77380f75cf59f7fbaa05ed17#diff-ee525d02c311b44f9fefa22ad669d365R50) return all possible mappings and forcing them all - what do you think?\r\n\r\nAlso, what do you think is best for this signature https://github.com/ros2/ros1_bridge/pull/42/commits/8485326b578cc65c77380f75cf59f7fbaa05ed17#diff-ee525d02c311b44f9fefa22ad669d365R56 : how it is now, where outputs are listed after inputs, or switching them so that `ros1_type_name` comes before `ros2_type_name` (for consistency with `get_1to2_mapping`)"}}
{"actor":{"display_login":"dhood"}}