{"action":"created","issue":{"url":"https://api.github.com/repos/cmangos/issues/issues/894","repository_url":"https://api.github.com/repos/cmangos/issues","labels_url":"https://api.github.com/repos/cmangos/issues/issues/894/labels{/name}","comments_url":"https://api.github.com/repos/cmangos/issues/issues/894/comments","events_url":"https://api.github.com/repos/cmangos/issues/issues/894/events","html_url":"https://github.com/cmangos/issues/issues/894","id":147525404,"number":894,"title":"[classic] fishing broken in some areas","user":{"login":"RichardGe","id":2279126,"avatar_url":"https://avatars.githubusercontent.com/u/2279126?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardGe","html_url":"https://github.com/RichardGe","followers_url":"https://api.github.com/users/RichardGe/followers","following_url":"https://api.github.com/users/RichardGe/following{/other_user}","gists_url":"https://api.github.com/users/RichardGe/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardGe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardGe/subscriptions","organizations_url":"https://api.github.com/users/RichardGe/orgs","repos_url":"https://api.github.com/users/RichardGe/repos","events_url":"https://api.github.com/users/RichardGe/events{/privacy}","received_events_url":"https://api.github.com/users/RichardGe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-11T19:14:52Z","updated_at":"2016-04-13T17:53:19Z","closed_at":null,"body":"**Current behavior**: \r\n\r\nin some areas, it's impossible to catch something.\r\n\r\nI have done the investigation :\r\nFor example, if you are in The Savage Coast (Zone 33 - Area 301), \r\nthis will call the loot  entry :  fishing_loot_template , entry 301\r\nin this entry, you have only 1 fish:  item=16969  (for the Nat Paggle Quest : 6607 - \"Nat Pagle, Angler Extreme\")\r\nIf you don't have this quest, you will never have a single fish in this area, no matter how many time you try to fish.\r\n\r\n\r\n**Expected behavior**: \r\n\r\nIn the Loot::Loot function , in the LOOT_FISHING case there are 2 tries of FillLoot.\r\nthe 1st one is for the subzone, and the second one is for the zone.\r\nIn the current version, we only execute the second try of FillLoot if the first try FillLoot of the subzone has no data.\r\nimo, if we want to solve this issue, we should also do the 2nd try of FillLoot if the first try of FillLoot has returned an empty loot.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cmangos/issues/issues/comments/209566077","html_url":"https://github.com/cmangos/issues/issues/894#issuecomment-209566077","issue_url":"https://api.github.com/repos/cmangos/issues/issues/894","id":209566077,"user":{"login":"TarasHots","id":2003618,"avatar_url":"https://avatars.githubusercontent.com/u/2003618?v=3","gravatar_id":"","url":"https://api.github.com/users/TarasHots","html_url":"https://github.com/TarasHots","followers_url":"https://api.github.com/users/TarasHots/followers","following_url":"https://api.github.com/users/TarasHots/following{/other_user}","gists_url":"https://api.github.com/users/TarasHots/gists{/gist_id}","starred_url":"https://api.github.com/users/TarasHots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TarasHots/subscriptions","organizations_url":"https://api.github.com/users/TarasHots/orgs","repos_url":"https://api.github.com/users/TarasHots/repos","events_url":"https://api.github.com/users/TarasHots/events{/privacy}","received_events_url":"https://api.github.com/users/TarasHots/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T17:53:19Z","updated_at":"2016-04-13T17:53:19Z","body":"Sources are telling me that 'Savage Coast Blue Sailfin' fish is the only fishing loot there...\r\n\r\nFrom the other side, adding more logic won't add more fish. That logic is completely legit, I guess. So if we even want to change fishing loot there we need to fill it into DB\r\n"}}