{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/20951","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/20951/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20951/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/20951/events","html_url":"https://github.com/symfony/symfony/pull/20951","id":196018457,"number":20951,"title":"Redesigned the exception pages","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"labels":[{"id":100378,"url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false},{"id":10786590,"url":"https://api.github.com/repos/symfony/symfony/labels/TwigBundle","name":"TwigBundle","color":"DDDDDD","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-16T09:44:51Z","updated_at":"2016-12-19T03:09:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20951","html_url":"https://github.com/symfony/symfony/pull/20951","diff_url":"https://github.com/symfony/symfony/pull/20951.diff","patch_url":"https://github.com/symfony/symfony/pull/20951.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #20620\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nHere are some before/after screenshots:\r\n\r\n| Before | After\r\n| --- | ---\r\n| ![exception-before-1](https://cloud.githubusercontent.com/assets/73419/21258148/f8fd6482-c37b-11e6-9efe-1bcf7b323c0f.png) | ![exception-after-1](https://cloud.githubusercontent.com/assets/73419/21258156/016059cc-c37c-11e6-8bab-80456189d614.png)\r\n\r\n| Before | After\r\n| --- | ---\r\n| ![exception-before-2](https://cloud.githubusercontent.com/assets/73419/21258171/11198a46-c37c-11e6-8a28-ae45e19e3eaf.png) | ![exception-after-2](https://cloud.githubusercontent.com/assets/73419/21258223/4cb9ac66-c37c-11e6-93db-0db2c204dc0b.png)\r\n\r\n| Before | After\r\n| --- | ---\r\n| ![exception-before-3](https://cloud.githubusercontent.com/assets/73419/21258239/5a0747ac-c37c-11e6-923e-564322e862a6.png) | ![exception-after-3](https://cloud.githubusercontent.com/assets/73419/21258246/62ad8b00-c37c-11e6-8838-3c1824c18287.png)\r\n\r\n---\r\n\r\nAnd here is the new design in action because everything is very dynamic and you can click anywhere to reveal/collapse things:\r\n\r\n![exception-in-action](https://cloud.githubusercontent.com/assets/73419/21258261/7445f140-c37c-11e6-9318-f3807fe38689.gif)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/267872586","html_url":"https://github.com/symfony/symfony/pull/20951#issuecomment-267872586","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20951","id":267872586,"user":{"login":"robfrawley","id":3967713,"avatar_url":"https://avatars.githubusercontent.com/u/3967713?v=3","gravatar_id":"","url":"https://api.github.com/users/robfrawley","html_url":"https://github.com/robfrawley","followers_url":"https://api.github.com/users/robfrawley/followers","following_url":"https://api.github.com/users/robfrawley/following{/other_user}","gists_url":"https://api.github.com/users/robfrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/robfrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfrawley/subscriptions","organizations_url":"https://api.github.com/users/robfrawley/orgs","repos_url":"https://api.github.com/users/robfrawley/repos","events_url":"https://api.github.com/users/robfrawley/events{/privacy}","received_events_url":"https://api.github.com/users/robfrawley/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T03:09:45Z","updated_at":"2016-12-19T03:09:45Z","body":"@javiereguiluz \r\n\r\nFirst off: amazing work. Love the direction. Think this should absolutely be the basis for whatever eventually makes it into `master`. I'll be adding some more comments (re: the code itself) but as for the design:\r\n\r\n\r\n- The top section needs some additional vertical space. The first row (black) is fine, but the two below it should have more verticle space.\r\n- Second row order (with left chevron) seems \"off\" to me, would prefer the items were reverse with right chevron.\r\n- Syntax highlighting has too much red: there is enough red elsewhere and that makes it overpowering. Can we use a colorful syntax highlighting?\r\n- *Very strongly* think the stack trace should remain intact (include parameters). The information provided there can be very important to understand context and provide a valuable resolution. Someone posting sensitive information should be their own responsibility.\r\n- On \"Exceptions\" tab, the InvalidArgumentException doesn't have the message under it as Twig_Error_Loader does; what happens if there are more than two exceptions with the sub-text (the exception message)?"}}
{"actor":{"display_login":"robfrawley"}}