{"action":"created","comment":{"url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/comments/77005737","id":77005737,"diff_hunk":"@@ -6,7 +6,7 @@ import play.routes.compiler.Parameter\n \n import scala.reflect.runtime.universe._\n \n-final case class DefinitionGenerator(modelQualifier: DomainModelQualifier = PrefixDomainModelQualifier())(implicit cl: ClassLoader) {\n+final case class DefinitionGenerator(modelQualifier: DomainModelQualifier = PrefixDomainModelQualifier())(implicit cl: ClassLoader, mappings: Seq[SwaggerMapping]) {","path":"core/src/main/scala/com/iheart/playSwagger/DefinitionGenerator.scala","position":5,"original_position":5,"commit_id":"5debca39740f35bae6c69ac8010b81cc68a5320f","original_commit_id":"5debca39740f35bae6c69ac8010b81cc68a5320f","user":{"login":"kbedel","id":7980302,"avatar_url":"https://avatars.githubusercontent.com/u/7980302?v=3","gravatar_id":"","url":"https://api.github.com/users/kbedel","html_url":"https://github.com/kbedel","followers_url":"https://api.github.com/users/kbedel/followers","following_url":"https://api.github.com/users/kbedel/following{/other_user}","gists_url":"https://api.github.com/users/kbedel/gists{/gist_id}","starred_url":"https://api.github.com/users/kbedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbedel/subscriptions","organizations_url":"https://api.github.com/users/kbedel/orgs","repos_url":"https://api.github.com/users/kbedel/repos","events_url":"https://api.github.com/users/kbedel/events{/privacy}","received_events_url":"https://api.github.com/users/kbedel/received_events","type":"User","site_admin":false},"body":"Since my change will be removed based on your other suggestion, do you still want me to implement this breaking change?","created_at":"2016-08-31T15:08:37Z","updated_at":"2016-08-31T15:08:37Z","html_url":"https://github.com/iheartradio/play-swagger/pull/112#discussion_r77005737","pull_request_url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/iheartradio/play-swagger/pulls/comments/77005737"},"html":{"href":"https://github.com/iheartradio/play-swagger/pull/112#discussion_r77005737"},"pull_request":{"href":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112","id":83366071,"html_url":"https://github.com/iheartradio/play-swagger/pull/112","diff_url":"https://github.com/iheartradio/play-swagger/pull/112.diff","patch_url":"https://github.com/iheartradio/play-swagger/pull/112.patch","issue_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/112","number":112,"state":"open","locked":false,"title":"Configurable mappings","user":{"login":"kbedel","id":7980302,"avatar_url":"https://avatars.githubusercontent.com/u/7980302?v=3","gravatar_id":"","url":"https://api.github.com/users/kbedel","html_url":"https://github.com/kbedel","followers_url":"https://api.github.com/users/kbedel/followers","following_url":"https://api.github.com/users/kbedel/following{/other_user}","gists_url":"https://api.github.com/users/kbedel/gists{/gist_id}","starred_url":"https://api.github.com/users/kbedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbedel/subscriptions","organizations_url":"https://api.github.com/users/kbedel/orgs","repos_url":"https://api.github.com/users/kbedel/repos","events_url":"https://api.github.com/users/kbedel/events{/privacy}","received_events_url":"https://api.github.com/users/kbedel/received_events","type":"User","site_admin":false},"body":"Allow overriding of type mappings.\r\n\r\nI'm not overly happy with the manual JSON serialization used to pass the configured overrides from the plugin to core, but I didn't want to introduce any library dependencies. If anyone has a suggestion for another approach, I'd be happy to change it. Related to this is the need to duplicate the definition of the SwaggerMapping case class in both projects since there is no dependency on core from the plugin.\r\n\r\nI'd also appreciate any feedback on the updates to the Readme. I just put the documentation for this in the FAQ, but not sure that is the best place.","created_at":"2016-08-30T23:38:28Z","updated_at":"2016-08-31T15:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04bcc7f0f8f44a0578c247ac4c6d324eb33ba904","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112/commits","review_comments_url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112/comments","review_comment_url":"https://api.github.com/repos/iheartradio/play-swagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/112/comments","statuses_url":"https://api.github.com/repos/iheartradio/play-swagger/statuses/5debca39740f35bae6c69ac8010b81cc68a5320f","head":{"label":"kbedel:master","ref":"master","sha":"5debca39740f35bae6c69ac8010b81cc68a5320f","user":{"login":"kbedel","id":7980302,"avatar_url":"https://avatars.githubusercontent.com/u/7980302?v=3","gravatar_id":"","url":"https://api.github.com/users/kbedel","html_url":"https://github.com/kbedel","followers_url":"https://api.github.com/users/kbedel/followers","following_url":"https://api.github.com/users/kbedel/following{/other_user}","gists_url":"https://api.github.com/users/kbedel/gists{/gist_id}","starred_url":"https://api.github.com/users/kbedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbedel/subscriptions","organizations_url":"https://api.github.com/users/kbedel/orgs","repos_url":"https://api.github.com/users/kbedel/repos","events_url":"https://api.github.com/users/kbedel/events{/privacy}","received_events_url":"https://api.github.com/users/kbedel/received_events","type":"User","site_admin":false},"repo":{"id":66851021,"name":"play-swagger","full_name":"kbedel/play-swagger","owner":{"login":"kbedel","id":7980302,"avatar_url":"https://avatars.githubusercontent.com/u/7980302?v=3","gravatar_id":"","url":"https://api.github.com/users/kbedel","html_url":"https://github.com/kbedel","followers_url":"https://api.github.com/users/kbedel/followers","following_url":"https://api.github.com/users/kbedel/following{/other_user}","gists_url":"https://api.github.com/users/kbedel/gists{/gist_id}","starred_url":"https://api.github.com/users/kbedel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbedel/subscriptions","organizations_url":"https://api.github.com/users/kbedel/orgs","repos_url":"https://api.github.com/users/kbedel/repos","events_url":"https://api.github.com/users/kbedel/events{/privacy}","received_events_url":"https://api.github.com/users/kbedel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbedel/play-swagger","description":"Swagger spec generator for play framework","fork":true,"url":"https://api.github.com/repos/kbedel/play-swagger","forks_url":"https://api.github.com/repos/kbedel/play-swagger/forks","keys_url":"https://api.github.com/repos/kbedel/play-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbedel/play-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbedel/play-swagger/teams","hooks_url":"https://api.github.com/repos/kbedel/play-swagger/hooks","issue_events_url":"https://api.github.com/repos/kbedel/play-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/kbedel/play-swagger/events","assignees_url":"https://api.github.com/repos/kbedel/play-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/kbedel/play-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/kbedel/play-swagger/tags","blobs_url":"https://api.github.com/repos/kbedel/play-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbedel/play-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbedel/play-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbedel/play-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbedel/play-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/kbedel/play-swagger/languages","stargazers_url":"https://api.github.com/repos/kbedel/play-swagger/stargazers","contributors_url":"https://api.github.com/repos/kbedel/play-swagger/contributors","subscribers_url":"https://api.github.com/repos/kbedel/play-swagger/subscribers","subscription_url":"https://api.github.com/repos/kbedel/play-swagger/subscription","commits_url":"https://api.github.com/repos/kbedel/play-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbedel/play-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbedel/play-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbedel/play-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbedel/play-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/kbedel/play-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbedel/play-swagger/merges","archive_url":"https://api.github.com/repos/kbedel/play-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbedel/play-swagger/downloads","issues_url":"https://api.github.com/repos/kbedel/play-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/kbedel/play-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/kbedel/play-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/kbedel/play-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbedel/play-swagger/labels{/name}","releases_url":"https://api.github.com/repos/kbedel/play-swagger/releases{/id}","deployments_url":"https://api.github.com/repos/kbedel/play-swagger/deployments","created_at":"2016-08-29T14:27:56Z","updated_at":"2016-08-29T14:27:58Z","pushed_at":"2016-08-31T14:19:15Z","git_url":"git://github.com/kbedel/play-swagger.git","ssh_url":"git@github.com:kbedel/play-swagger.git","clone_url":"https://github.com/kbedel/play-swagger.git","svn_url":"https://github.com/kbedel/play-swagger","homepage":"","size":253,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iheartradio:master","ref":"master","sha":"88c1456b8a36a13fdba530ed6a198b1912c50504","user":{"login":"iheartradio","id":993737,"avatar_url":"https://avatars.githubusercontent.com/u/993737?v=3","gravatar_id":"","url":"https://api.github.com/users/iheartradio","html_url":"https://github.com/iheartradio","followers_url":"https://api.github.com/users/iheartradio/followers","following_url":"https://api.github.com/users/iheartradio/following{/other_user}","gists_url":"https://api.github.com/users/iheartradio/gists{/gist_id}","starred_url":"https://api.github.com/users/iheartradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iheartradio/subscriptions","organizations_url":"https://api.github.com/users/iheartradio/orgs","repos_url":"https://api.github.com/users/iheartradio/repos","events_url":"https://api.github.com/users/iheartradio/events{/privacy}","received_events_url":"https://api.github.com/users/iheartradio/received_events","type":"Organization","site_admin":false},"repo":{"id":42681499,"name":"play-swagger","full_name":"iheartradio/play-swagger","owner":{"login":"iheartradio","id":993737,"avatar_url":"https://avatars.githubusercontent.com/u/993737?v=3","gravatar_id":"","url":"https://api.github.com/users/iheartradio","html_url":"https://github.com/iheartradio","followers_url":"https://api.github.com/users/iheartradio/followers","following_url":"https://api.github.com/users/iheartradio/following{/other_user}","gists_url":"https://api.github.com/users/iheartradio/gists{/gist_id}","starred_url":"https://api.github.com/users/iheartradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iheartradio/subscriptions","organizations_url":"https://api.github.com/users/iheartradio/orgs","repos_url":"https://api.github.com/users/iheartradio/repos","events_url":"https://api.github.com/users/iheartradio/events{/privacy}","received_events_url":"https://api.github.com/users/iheartradio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iheartradio/play-swagger","description":"Swagger spec generator for play framework","fork":false,"url":"https://api.github.com/repos/iheartradio/play-swagger","forks_url":"https://api.github.com/repos/iheartradio/play-swagger/forks","keys_url":"https://api.github.com/repos/iheartradio/play-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iheartradio/play-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iheartradio/play-swagger/teams","hooks_url":"https://api.github.com/repos/iheartradio/play-swagger/hooks","issue_events_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/iheartradio/play-swagger/events","assignees_url":"https://api.github.com/repos/iheartradio/play-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/iheartradio/play-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/iheartradio/play-swagger/tags","blobs_url":"https://api.github.com/repos/iheartradio/play-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iheartradio/play-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iheartradio/play-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/iheartradio/play-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iheartradio/play-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/iheartradio/play-swagger/languages","stargazers_url":"https://api.github.com/repos/iheartradio/play-swagger/stargazers","contributors_url":"https://api.github.com/repos/iheartradio/play-swagger/contributors","subscribers_url":"https://api.github.com/repos/iheartradio/play-swagger/subscribers","subscription_url":"https://api.github.com/repos/iheartradio/play-swagger/subscription","commits_url":"https://api.github.com/repos/iheartradio/play-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/iheartradio/play-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/iheartradio/play-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/iheartradio/play-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/iheartradio/play-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/iheartradio/play-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iheartradio/play-swagger/merges","archive_url":"https://api.github.com/repos/iheartradio/play-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iheartradio/play-swagger/downloads","issues_url":"https://api.github.com/repos/iheartradio/play-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/iheartradio/play-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/iheartradio/play-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/iheartradio/play-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iheartradio/play-swagger/labels{/name}","releases_url":"https://api.github.com/repos/iheartradio/play-swagger/releases{/id}","deployments_url":"https://api.github.com/repos/iheartradio/play-swagger/deployments","created_at":"2015-09-17T20:56:52Z","updated_at":"2016-08-29T17:11:57Z","pushed_at":"2016-08-31T14:18:38Z","git_url":"git://github.com/iheartradio/play-swagger.git","ssh_url":"git@github.com:iheartradio/play-swagger.git","clone_url":"https://github.com/iheartradio/play-swagger.git","svn_url":"https://github.com/iheartradio/play-swagger","homepage":"","size":270,"stargazers_count":116,"watchers_count":116,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":26,"forks":29,"open_issues":26,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112"},"html":{"href":"https://github.com/iheartradio/play-swagger/pull/112"},"issue":{"href":"https://api.github.com/repos/iheartradio/play-swagger/issues/112"},"comments":{"href":"https://api.github.com/repos/iheartradio/play-swagger/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/iheartradio/play-swagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iheartradio/play-swagger/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/iheartradio/play-swagger/statuses/5debca39740f35bae6c69ac8010b81cc68a5320f"}}}}
{"actor":{"display_login":"kbedel"}}