{"action":"created","comment":{"url":"https://api.github.com/repos/fdiogo/bityn/pulls/comments/85029492","pull_request_review_id":5769690,"id":85029492,"diff_hunk":"@@ -0,0 +1,28 @@\n+const {app, BrowserWindow, dialog} = require('electron');\n+const Configfile = require('electron-config');\n+const configfile = new Configfile();\n+const path = require('path');\n+\n+/**\n+ * Handles the selection of the directories.\n+ * @param {Object} current_window            - The window object of which to start the dialog from\n+ * @param {Boolean} startup                  - To determinate wheather\n+ * @return {folder}                          - Returns the folder\n+ */\n+function selectFolders(current_window, startup) {","path":"lib/config.js","position":12,"original_position":12,"commit_id":"816a36f7a9a0f92fab877a0c9f3644f317c9f14d","original_commit_id":"816a36f7a9a0f92fab877a0c9f3644f317c9f14d","user":{"login":"fdiogo","id":5558761,"avatar_url":"https://avatars.githubusercontent.com/u/5558761?v=3","gravatar_id":"","url":"https://api.github.com/users/fdiogo","html_url":"https://github.com/fdiogo","followers_url":"https://api.github.com/users/fdiogo/followers","following_url":"https://api.github.com/users/fdiogo/following{/other_user}","gists_url":"https://api.github.com/users/fdiogo/gists{/gist_id}","starred_url":"https://api.github.com/users/fdiogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdiogo/subscriptions","organizations_url":"https://api.github.com/users/fdiogo/orgs","repos_url":"https://api.github.com/users/fdiogo/repos","events_url":"https://api.github.com/users/fdiogo/events{/privacy}","received_events_url":"https://api.github.com/users/fdiogo/received_events","type":"User","site_admin":false},"body":"This should be in window-settings. There is no need to create a new module to wrap electron-config. In this specific case, the window-settings is the one that has to worry about the interface of selecting the folders and to use electron-config to store those values.","created_at":"2016-10-26T00:21:08Z","updated_at":"2016-10-26T00:38:48Z","html_url":"https://github.com/fdiogo/bityn/pull/21#discussion_r85029492","pull_request_url":"https://api.github.com/repos/fdiogo/bityn/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/fdiogo/bityn/pulls/comments/85029492"},"html":{"href":"https://github.com/fdiogo/bityn/pull/21#discussion_r85029492"},"pull_request":{"href":"https://api.github.com/repos/fdiogo/bityn/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/fdiogo/bityn/pulls/21","id":90882706,"html_url":"https://github.com/fdiogo/bityn/pull/21","diff_url":"https://github.com/fdiogo/bityn/pull/21.diff","patch_url":"https://github.com/fdiogo/bityn/pull/21.patch","issue_url":"https://api.github.com/repos/fdiogo/bityn/issues/21","number":21,"state":"open","locked":false,"title":"Implemented user settings","user":{"login":"ikarulus","id":20602537,"avatar_url":"https://avatars.githubusercontent.com/u/20602537?v=3","gravatar_id":"","url":"https://api.github.com/users/ikarulus","html_url":"https://github.com/ikarulus","followers_url":"https://api.github.com/users/ikarulus/followers","following_url":"https://api.github.com/users/ikarulus/following{/other_user}","gists_url":"https://api.github.com/users/ikarulus/gists{/gist_id}","starred_url":"https://api.github.com/users/ikarulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikarulus/subscriptions","organizations_url":"https://api.github.com/users/ikarulus/orgs","repos_url":"https://api.github.com/users/ikarulus/repos","events_url":"https://api.github.com/users/ikarulus/events{/privacy}","received_events_url":"https://api.github.com/users/ikarulus/received_events","type":"User","site_admin":false},"body":"I implemented user settings functionality.\r\nThe only configuration point until now is the music directory.\r\nI used [electron-config](https://github.com/sindresorhus/electron-config) to save configuration permanently.\r\nOn startup, the application now checks wheather folders are already specified.","created_at":"2016-10-25T20:13:52Z","updated_at":"2016-10-26T00:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f84d89192553de99b8d68ac8a50707616c23930","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fdiogo/bityn/pulls/21/commits","review_comments_url":"https://api.github.com/repos/fdiogo/bityn/pulls/21/comments","review_comment_url":"https://api.github.com/repos/fdiogo/bityn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fdiogo/bityn/issues/21/comments","statuses_url":"https://api.github.com/repos/fdiogo/bityn/statuses/816a36f7a9a0f92fab877a0c9f3644f317c9f14d","head":{"label":"ikarulus:settings","ref":"settings","sha":"816a36f7a9a0f92fab877a0c9f3644f317c9f14d","user":{"login":"ikarulus","id":20602537,"avatar_url":"https://avatars.githubusercontent.com/u/20602537?v=3","gravatar_id":"","url":"https://api.github.com/users/ikarulus","html_url":"https://github.com/ikarulus","followers_url":"https://api.github.com/users/ikarulus/followers","following_url":"https://api.github.com/users/ikarulus/following{/other_user}","gists_url":"https://api.github.com/users/ikarulus/gists{/gist_id}","starred_url":"https://api.github.com/users/ikarulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikarulus/subscriptions","organizations_url":"https://api.github.com/users/ikarulus/orgs","repos_url":"https://api.github.com/users/ikarulus/repos","events_url":"https://api.github.com/users/ikarulus/events{/privacy}","received_events_url":"https://api.github.com/users/ikarulus/received_events","type":"User","site_admin":false},"repo":{"id":71688428,"name":"bityn","full_name":"ikarulus/bityn","owner":{"login":"ikarulus","id":20602537,"avatar_url":"https://avatars.githubusercontent.com/u/20602537?v=3","gravatar_id":"","url":"https://api.github.com/users/ikarulus","html_url":"https://github.com/ikarulus","followers_url":"https://api.github.com/users/ikarulus/followers","following_url":"https://api.github.com/users/ikarulus/following{/other_user}","gists_url":"https://api.github.com/users/ikarulus/gists{/gist_id}","starred_url":"https://api.github.com/users/ikarulus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikarulus/subscriptions","organizations_url":"https://api.github.com/users/ikarulus/orgs","repos_url":"https://api.github.com/users/ikarulus/repos","events_url":"https://api.github.com/users/ikarulus/events{/privacy}","received_events_url":"https://api.github.com/users/ikarulus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikarulus/bityn","description":null,"fork":true,"url":"https://api.github.com/repos/ikarulus/bityn","forks_url":"https://api.github.com/repos/ikarulus/bityn/forks","keys_url":"https://api.github.com/repos/ikarulus/bityn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikarulus/bityn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikarulus/bityn/teams","hooks_url":"https://api.github.com/repos/ikarulus/bityn/hooks","issue_events_url":"https://api.github.com/repos/ikarulus/bityn/issues/events{/number}","events_url":"https://api.github.com/repos/ikarulus/bityn/events","assignees_url":"https://api.github.com/repos/ikarulus/bityn/assignees{/user}","branches_url":"https://api.github.com/repos/ikarulus/bityn/branches{/branch}","tags_url":"https://api.github.com/repos/ikarulus/bityn/tags","blobs_url":"https://api.github.com/repos/ikarulus/bityn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikarulus/bityn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikarulus/bityn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikarulus/bityn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikarulus/bityn/statuses/{sha}","languages_url":"https://api.github.com/repos/ikarulus/bityn/languages","stargazers_url":"https://api.github.com/repos/ikarulus/bityn/stargazers","contributors_url":"https://api.github.com/repos/ikarulus/bityn/contributors","subscribers_url":"https://api.github.com/repos/ikarulus/bityn/subscribers","subscription_url":"https://api.github.com/repos/ikarulus/bityn/subscription","commits_url":"https://api.github.com/repos/ikarulus/bityn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikarulus/bityn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikarulus/bityn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikarulus/bityn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikarulus/bityn/contents/{+path}","compare_url":"https://api.github.com/repos/ikarulus/bityn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikarulus/bityn/merges","archive_url":"https://api.github.com/repos/ikarulus/bityn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikarulus/bityn/downloads","issues_url":"https://api.github.com/repos/ikarulus/bityn/issues{/number}","pulls_url":"https://api.github.com/repos/ikarulus/bityn/pulls{/number}","milestones_url":"https://api.github.com/repos/ikarulus/bityn/milestones{/number}","notifications_url":"https://api.github.com/repos/ikarulus/bityn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikarulus/bityn/labels{/name}","releases_url":"https://api.github.com/repos/ikarulus/bityn/releases{/id}","deployments_url":"https://api.github.com/repos/ikarulus/bityn/deployments","created_at":"2016-10-23T07:33:29Z","updated_at":"2016-10-25T16:34:13Z","pushed_at":"2016-10-25T19:37:44Z","git_url":"git://github.com/ikarulus/bityn.git","ssh_url":"git@github.com:ikarulus/bityn.git","clone_url":"https://github.com/ikarulus/bityn.git","svn_url":"https://github.com/ikarulus/bityn","homepage":null,"size":206,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fdiogo:master","ref":"master","sha":"dd1c77f2e1c7ecaa700b91a5c9d24f0045f1d1b5","user":{"login":"fdiogo","id":5558761,"avatar_url":"https://avatars.githubusercontent.com/u/5558761?v=3","gravatar_id":"","url":"https://api.github.com/users/fdiogo","html_url":"https://github.com/fdiogo","followers_url":"https://api.github.com/users/fdiogo/followers","following_url":"https://api.github.com/users/fdiogo/following{/other_user}","gists_url":"https://api.github.com/users/fdiogo/gists{/gist_id}","starred_url":"https://api.github.com/users/fdiogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdiogo/subscriptions","organizations_url":"https://api.github.com/users/fdiogo/orgs","repos_url":"https://api.github.com/users/fdiogo/repos","events_url":"https://api.github.com/users/fdiogo/events{/privacy}","received_events_url":"https://api.github.com/users/fdiogo/received_events","type":"User","site_admin":false},"repo":{"id":71482897,"name":"bityn","full_name":"fdiogo/bityn","owner":{"login":"fdiogo","id":5558761,"avatar_url":"https://avatars.githubusercontent.com/u/5558761?v=3","gravatar_id":"","url":"https://api.github.com/users/fdiogo","html_url":"https://github.com/fdiogo","followers_url":"https://api.github.com/users/fdiogo/followers","following_url":"https://api.github.com/users/fdiogo/following{/other_user}","gists_url":"https://api.github.com/users/fdiogo/gists{/gist_id}","starred_url":"https://api.github.com/users/fdiogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdiogo/subscriptions","organizations_url":"https://api.github.com/users/fdiogo/orgs","repos_url":"https://api.github.com/users/fdiogo/repos","events_url":"https://api.github.com/users/fdiogo/events{/privacy}","received_events_url":"https://api.github.com/users/fdiogo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fdiogo/bityn","description":null,"fork":false,"url":"https://api.github.com/repos/fdiogo/bityn","forks_url":"https://api.github.com/repos/fdiogo/bityn/forks","keys_url":"https://api.github.com/repos/fdiogo/bityn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fdiogo/bityn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fdiogo/bityn/teams","hooks_url":"https://api.github.com/repos/fdiogo/bityn/hooks","issue_events_url":"https://api.github.com/repos/fdiogo/bityn/issues/events{/number}","events_url":"https://api.github.com/repos/fdiogo/bityn/events","assignees_url":"https://api.github.com/repos/fdiogo/bityn/assignees{/user}","branches_url":"https://api.github.com/repos/fdiogo/bityn/branches{/branch}","tags_url":"https://api.github.com/repos/fdiogo/bityn/tags","blobs_url":"https://api.github.com/repos/fdiogo/bityn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fdiogo/bityn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fdiogo/bityn/git/refs{/sha}","trees_url":"https://api.github.com/repos/fdiogo/bityn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fdiogo/bityn/statuses/{sha}","languages_url":"https://api.github.com/repos/fdiogo/bityn/languages","stargazers_url":"https://api.github.com/repos/fdiogo/bityn/stargazers","contributors_url":"https://api.github.com/repos/fdiogo/bityn/contributors","subscribers_url":"https://api.github.com/repos/fdiogo/bityn/subscribers","subscription_url":"https://api.github.com/repos/fdiogo/bityn/subscription","commits_url":"https://api.github.com/repos/fdiogo/bityn/commits{/sha}","git_commits_url":"https://api.github.com/repos/fdiogo/bityn/git/commits{/sha}","comments_url":"https://api.github.com/repos/fdiogo/bityn/comments{/number}","issue_comment_url":"https://api.github.com/repos/fdiogo/bityn/issues/comments{/number}","contents_url":"https://api.github.com/repos/fdiogo/bityn/contents/{+path}","compare_url":"https://api.github.com/repos/fdiogo/bityn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fdiogo/bityn/merges","archive_url":"https://api.github.com/repos/fdiogo/bityn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fdiogo/bityn/downloads","issues_url":"https://api.github.com/repos/fdiogo/bityn/issues{/number}","pulls_url":"https://api.github.com/repos/fdiogo/bityn/pulls{/number}","milestones_url":"https://api.github.com/repos/fdiogo/bityn/milestones{/number}","notifications_url":"https://api.github.com/repos/fdiogo/bityn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fdiogo/bityn/labels{/name}","releases_url":"https://api.github.com/repos/fdiogo/bityn/releases{/id}","deployments_url":"https://api.github.com/repos/fdiogo/bityn/deployments","created_at":"2016-10-20T16:33:44Z","updated_at":"2016-10-23T07:33:16Z","pushed_at":"2016-10-25T20:13:52Z","git_url":"git://github.com/fdiogo/bityn.git","ssh_url":"git@github.com:fdiogo/bityn.git","clone_url":"https://github.com/fdiogo/bityn.git","svn_url":"https://github.com/fdiogo/bityn","homepage":null,"size":213,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fdiogo/bityn/pulls/21"},"html":{"href":"https://github.com/fdiogo/bityn/pull/21"},"issue":{"href":"https://api.github.com/repos/fdiogo/bityn/issues/21"},"comments":{"href":"https://api.github.com/repos/fdiogo/bityn/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/fdiogo/bityn/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/fdiogo/bityn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fdiogo/bityn/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/fdiogo/bityn/statuses/816a36f7a9a0f92fab877a0c9f3644f317c9f14d"}}}}
{"actor":{"display_login":"fdiogo"}}