{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2808","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2808/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2808/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2808/events","html_url":"https://github.com/fish-shell/fish-shell/pull/2808","id":139980743,"number":2808,"title":"Update pcre2 to 10.21 release and track as a git submodule instead of hosting a copy in version control","user":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-10T19:04:40Z","updated_at":"2016-03-10T19:35:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2808","html_url":"https://github.com/fish-shell/fish-shell/pull/2808","diff_url":"https://github.com/fish-shell/fish-shell/pull/2808.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/2808.patch"},"body":"It'd be nice if fish could include pcre2 10.21 when when 2.3.0 comes out. This PR updates pcre2 and further tracks it as a git submodule (GitHub mirror of svn). See https://gist.github.com/gitaarik/8735255 on how to work with these.\r\n\r\nThis will make maintenance easier in the future and permit easy bisecting should a  future release break something in fish, while keeping the actual files and their histories out of the the fish tree. Only the metadata regarding the commit and repo we we want is stored. On clone you get the pcre2 tree inside your working directory like before and it won't try to update itself to their HEAD. It's pointing at exactly the the commit corresponding to the 10.21 release right now.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/195012632","html_url":"https://github.com/fish-shell/fish-shell/pull/2808#issuecomment-195012632","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2808","id":195012632,"user":{"login":"floam","id":291142,"avatar_url":"https://avatars.githubusercontent.com/u/291142?v=3","gravatar_id":"","url":"https://api.github.com/users/floam","html_url":"https://github.com/floam","followers_url":"https://api.github.com/users/floam/followers","following_url":"https://api.github.com/users/floam/following{/other_user}","gists_url":"https://api.github.com/users/floam/gists{/gist_id}","starred_url":"https://api.github.com/users/floam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floam/subscriptions","organizations_url":"https://api.github.com/users/floam/orgs","repos_url":"https://api.github.com/users/floam/repos","events_url":"https://api.github.com/users/floam/events{/privacy}","received_events_url":"https://api.github.com/users/floam/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T19:35:50Z","updated_at":"2016-03-10T19:35:50Z","body":"Yes, it's broken and I need to fix it."}}