{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/56345328","id":56345328,"diff_hunk":"@@ -0,0 +1,46 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sylius package.\n+ *\n+ * (c) Paweł Jędrzejewski\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Sylius\\Component\\Attribute\\AttributeType;\n+\n+use Sylius\\Component\\Attribute\\Model\\AttributeValueInterface;\n+use Symfony\\Component\\Validator\\Context\\ExecutionContextInterface;\n+\n+/**\n+ * @author Laurent Paganin-Gioanni <l.paganin@algo-factory.com>\n+ */\n+class SelectAttributeType implements AttributeTypeInterface\n+{\n+    const TYPE = 'select';\n+\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function getStorageType()\n+    {\n+        return AttributeValueInterface::STORAGE_JSON;\n+    }\n+\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function getType()\n+    {\n+        return static::TYPE;\n+    }\n+\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function validate(AttributeValueInterface $attributeValue, ExecutionContextInterface $context, array $configuration)","path":"src/Sylius/Component/Attribute/AttributeType/SelectAttributeType.php","position":43,"original_position":43,"commit_id":"2a4d2888509a924c5f30eedb7276764391dedb11","original_commit_id":"2a4d2888509a924c5f30eedb7276764391dedb11","user":{"login":"lchrusciel","id":6213903,"avatar_url":"https://avatars.githubusercontent.com/u/6213903?v=3","gravatar_id":"","url":"https://api.github.com/users/lchrusciel","html_url":"https://github.com/lchrusciel","followers_url":"https://api.github.com/users/lchrusciel/followers","following_url":"https://api.github.com/users/lchrusciel/following{/other_user}","gists_url":"https://api.github.com/users/lchrusciel/gists{/gist_id}","starred_url":"https://api.github.com/users/lchrusciel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lchrusciel/subscriptions","organizations_url":"https://api.github.com/users/lchrusciel/orgs","repos_url":"https://api.github.com/users/lchrusciel/repos","events_url":"https://api.github.com/users/lchrusciel/events{/privacy}","received_events_url":"https://api.github.com/users/lchrusciel/received_events","type":"User","site_admin":false},"body":"Why do you have empty function? You have missed something here or violated one of SOLID principles here","created_at":"2016-03-16T14:44:24Z","updated_at":"2016-03-16T14:44:24Z","html_url":"https://github.com/Sylius/Sylius/pull/4397#discussion_r56345328","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4397","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/56345328"},"html":{"href":"https://github.com/Sylius/Sylius/pull/4397#discussion_r56345328"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4397"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/4397","id":61787205,"html_url":"https://github.com/Sylius/Sylius/pull/4397","diff_url":"https://github.com/Sylius/Sylius/pull/4397.diff","patch_url":"https://github.com/Sylius/Sylius/pull/4397.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/4397","number":4397,"state":"open","locked":false,"title":"[WIP][RFC][Attribute] add attribute type select","user":{"login":"Lowlo","id":399094,"avatar_url":"https://avatars.githubusercontent.com/u/399094?v=3","gravatar_id":"","url":"https://api.github.com/users/Lowlo","html_url":"https://github.com/Lowlo","followers_url":"https://api.github.com/users/Lowlo/followers","following_url":"https://api.github.com/users/Lowlo/following{/other_user}","gists_url":"https://api.github.com/users/Lowlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Lowlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lowlo/subscriptions","organizations_url":"https://api.github.com/users/Lowlo/orgs","repos_url":"https://api.github.com/users/Lowlo/repos","events_url":"https://api.github.com/users/Lowlo/events{/privacy}","received_events_url":"https://api.github.com/users/Lowlo/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no\r\n| New feature?    | yes\r\n| BC breaks?      | yes\r\n| Deprecations?   | no\r\n| License         | MIT","created_at":"2016-03-04T23:29:55Z","updated_at":"2016-03-16T14:44:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dae28e1ee5e2bce8a37487403cfe2d7ae0b9acd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4397/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/4397/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/4397/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/2a4d2888509a924c5f30eedb7276764391dedb11","head":{"label":"Lowlo:attribute_select","ref":"attribute_select","sha":"2a4d2888509a924c5f30eedb7276764391dedb11","user":{"login":"Lowlo","id":399094,"avatar_url":"https://avatars.githubusercontent.com/u/399094?v=3","gravatar_id":"","url":"https://api.github.com/users/Lowlo","html_url":"https://github.com/Lowlo","followers_url":"https://api.github.com/users/Lowlo/followers","following_url":"https://api.github.com/users/Lowlo/following{/other_user}","gists_url":"https://api.github.com/users/Lowlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Lowlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lowlo/subscriptions","organizations_url":"https://api.github.com/users/Lowlo/orgs","repos_url":"https://api.github.com/users/Lowlo/repos","events_url":"https://api.github.com/users/Lowlo/events{/privacy}","received_events_url":"https://api.github.com/users/Lowlo/received_events","type":"User","site_admin":false},"repo":{"id":52507292,"name":"Sylius","full_name":"Lowlo/Sylius","owner":{"login":"Lowlo","id":399094,"avatar_url":"https://avatars.githubusercontent.com/u/399094?v=3","gravatar_id":"","url":"https://api.github.com/users/Lowlo","html_url":"https://github.com/Lowlo","followers_url":"https://api.github.com/users/Lowlo/followers","following_url":"https://api.github.com/users/Lowlo/following{/other_user}","gists_url":"https://api.github.com/users/Lowlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Lowlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lowlo/subscriptions","organizations_url":"https://api.github.com/users/Lowlo/orgs","repos_url":"https://api.github.com/users/Lowlo/repos","events_url":"https://api.github.com/users/Lowlo/events{/privacy}","received_events_url":"https://api.github.com/users/Lowlo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lowlo/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":true,"url":"https://api.github.com/repos/Lowlo/Sylius","forks_url":"https://api.github.com/repos/Lowlo/Sylius/forks","keys_url":"https://api.github.com/repos/Lowlo/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lowlo/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lowlo/Sylius/teams","hooks_url":"https://api.github.com/repos/Lowlo/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Lowlo/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Lowlo/Sylius/events","assignees_url":"https://api.github.com/repos/Lowlo/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Lowlo/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Lowlo/Sylius/tags","blobs_url":"https://api.github.com/repos/Lowlo/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lowlo/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lowlo/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lowlo/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lowlo/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Lowlo/Sylius/languages","stargazers_url":"https://api.github.com/repos/Lowlo/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Lowlo/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Lowlo/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Lowlo/Sylius/subscription","commits_url":"https://api.github.com/repos/Lowlo/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lowlo/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lowlo/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lowlo/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lowlo/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Lowlo/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lowlo/Sylius/merges","archive_url":"https://api.github.com/repos/Lowlo/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lowlo/Sylius/downloads","issues_url":"https://api.github.com/repos/Lowlo/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Lowlo/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Lowlo/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Lowlo/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lowlo/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Lowlo/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Lowlo/Sylius/deployments","created_at":"2016-02-25T08:00:15Z","updated_at":"2016-02-25T08:00:28Z","pushed_at":"2016-03-14T15:20:51Z","git_url":"git://github.com/Lowlo/Sylius.git","ssh_url":"git@github.com:Lowlo/Sylius.git","clone_url":"https://github.com/Lowlo/Sylius.git","svn_url":"https://github.com/Lowlo/Sylius","homepage":"http://Sylius.org","size":26221,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"4c004ca1c6b5b380fe10237a6215363d4bbe4a3e","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-03-16T08:31:49Z","pushed_at":"2016-03-16T14:00:27Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":58175,"stargazers_count":2212,"watchers_count":2212,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":805,"mirror_url":null,"open_issues_count":582,"forks":805,"open_issues":582,"watchers":2212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4397"},"html":{"href":"https://github.com/Sylius/Sylius/pull/4397"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/4397"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/4397/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4397/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/4397/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/2a4d2888509a924c5f30eedb7276764391dedb11"}}}}