{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/69507678","id":69507678,"diff_hunk":"@@ -245,68 +412,232 @@ var/list/global/tank_gauge_cache = list()\n \r\n \tlast_gauge_pressure = gauge_pressure\r\n \toverlays.Cut()\r\n+\tadd_bomb_overlay()\r\n \tvar/indicator = \"[gauge_icon][(gauge_pressure == -1) ? \"overload\" : gauge_pressure]\"\r\n \tif(!tank_gauge_cache[indicator])\r\n \t\ttank_gauge_cache[indicator] = image(icon, indicator)\r\n \toverlays += tank_gauge_cache[indicator]\r\n \r\n+\r\n+\r\n+\r\n+\r\n+\r\n /obj/item/weapon/tank/proc/check_status()\r\n \t//Handle exploding, leaking, and rupturing of the tank\r\n \r\n \tif(!air_contents)\r\n \t\treturn 0\r\n \r\n \tvar/pressure = air_contents.return_pressure()\r\n+\r\n+\r\n+\tif(pressure > TANK_LEAK_PRESSURE || air_contents.temperature - T0C > failure_temp)\r\n+\r\n+\t\tif((integrity <= 19 || src.leaking) && !valve_welded)\r\n+\t\t\tvar/turf/simulated/T = get_turf(src)\r\n+\t\t\tif(!T)\r\n+\t\t\t\treturn\r\n+\t\t\tvar/datum/gas_mixture/environment = loc.return_air()\r\n+\t\t\tvar/env_pressure = environment.return_pressure()\r\n+\t\t\tvar/tank_pressure = src.air_contents.return_pressure()\r\n+\r\n+\t\t\tvar/release_ratio = Clamp(0.02, sqrt((tank_pressure-env_pressure)/tank_pressure),1)\r\n+\t\t\tvar/datum/gas_mixture/leaked_gas = air_contents.remove_ratio(release_ratio)\r\n+\t\t\t//dynamic air release based on ambient pressure\r\n+\r\n+\t\t\tT.assume_air(leaked_gas)\r\n+\t\t\tif(!leaking)\r\n+\t\t\t\tvisible_message(\"\\icon[src] <span class='warning'>\\The [src] relief valve flips open with a hiss!</span>\", \"You hear hissing.\")\r\n+\t\t\t\tplaysound(src.loc, 'sound/effects/spray.ogg', 10, 1, -3)\r\n+\t\t\t\tleaking = 1\r\n+\t\t\t\t#ifdef FIREDBG\r\n+\t\t\t\tlog_debug(\"<span class='warning'>[x],[y] tank is leaking: [pressure] kPa, integrity [integrity]</span>\")\r\n+\t\t\t\t#endif\r\n+\r\n+\r\n+\t\telse\r\n+\t\t\tintegrity-= 2\r\n+\r\n+\r\n \tif(pressure > TANK_FRAGMENT_PRESSURE)\r\n-\t\tif(!istype(src.loc,/obj/item/device/transfer_valve))\r\n-\t\t\tmessage_admins(\"Explosive tank rupture! last key to touch the tank was [src.fingerprintslast].\")\r\n-\t\t\tlog_game(\"Explosive tank rupture! last key to touch the tank was [src.fingerprintslast].\")\r\n-\r\n-\t\t//Give the gas a chance to build up more pressure through reacting\r\n-\t\tair_contents.react()\r\n-\t\tair_contents.react()\r\n-\t\tair_contents.react()\r\n-\r\n-\t\tpressure = air_contents.return_pressure()\r\n-\t\tvar/range = (pressure-TANK_FRAGMENT_PRESSURE)/TANK_FRAGMENT_SCALE\r\n-\r\n-\t\texplosion(\r\n-\t\t\tget_turf(loc),\r\n-\t\t\tround(min(BOMBCAP_DVSTN_RADIUS, range*0.25)),\r\n-\t\t\tround(min(BOMBCAP_HEAVY_RADIUS, range*0.50)),\r\n-\t\t\tround(min(BOMBCAP_LIGHT_RADIUS, range*1.00)),\r\n-\t\t\tround(min(BOMBCAP_FLASH_RADIUS, range*1.50)),\r\n-\t\t\t)\r\n-\t\tqdel(src)\r\n-\r\n-\telse if(pressure > TANK_RUPTURE_PRESSURE)\r\n-\t\t#ifdef FIREDBG\r\n-\t\tlog_debug(\"<span class='warning'>[x],[y] tank is rupturing: [pressure] kPa, integrity [integrity]</span>\")\r\n-\t\t#endif\r\n+\t\tif(integrity <= 7)\r\n+\t\t\tif(!istype(src.loc,/obj/item/device/transfer_valve))\r\n+\t\t\t\tmessage_admins(\"Explosive tank rupture! last key to touch the tank was [src.fingerprintslast].\")\r\n+\t\t\t\tlog_game(\"Explosive tank rupture! last key to touch the tank was [src.fingerprintslast].\")\r\n+\r\n+\t\t\t//Give the gas a chance to build up more pressure through reacting\r\n+\t\t\tair_contents.react()\r\n+\t\t\tair_contents.react()\r\n+\t\t\tair_contents.react()\r\n+\r\n+\t\t\tpressure = air_contents.return_pressure()\r\n+\t\t\tvar/strength = ((pressure-TANK_FRAGMENT_PRESSURE)/TANK_FRAGMENT_SCALE)\r\n+\t\t\tvar/mult = max(0.2,1 + log(2.6, (air_contents.total_moles/29)) ) //1 + log base 2 of standard sized full (room temperature) tanks\r\n \r\n-\t\tif(integrity <= 0)\r\n \t\t\tvar/turf/simulated/T = get_turf(src)\r\n+\t\t\tT.hotspot_expose(src.air_contents.temperature, 70, 1)\r\n \t\t\tif(!T)\r\n \t\t\t\treturn\r\n \t\t\tT.assume_air(air_contents)\r\n-\t\t\tplaysound(src.loc, 'sound/effects/spray.ogg', 10, 1, -3)\r\n-\t\t\tqdel(src)\r\n+\r\n+\t\t\texplosion(\r\n+\t\t\t\tget_turf(loc),\r\n+\t\t\t\tround(min(BOMBCAP_DVSTN_RADIUS, ((mult)*strength)*0.20)),\r\n+\t\t\t\tround(min(BOMBCAP_HEAVY_RADIUS, ((mult)*strength)*0.40)),\r\n+\t\t\t\tround(min(BOMBCAP_LIGHT_RADIUS, ((mult)*strength)*0.85)),\r\n+\t\t\t\tround(min(BOMBCAP_FLASH_RADIUS, ((mult)*strength)*1.20)),\r","path":"code/game/objects/items/weapons/tanks/tanks.dm","position":364,"original_position":364,"commit_id":"58a0fa64d0d15af8f3f9b2af098123feebb41637","original_commit_id":"58a0fa64d0d15af8f3f9b2af098123feebb41637","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"body":"Bomb cap preserved, while the scalar, multiplier and sizing allows for the scaling of the bombs size to be tied to moles (which corresponds directly to volume as stated in prior conversation), these scalings roughly preserve TTVs damage while single tank bombs are less powerful and significantly less likely to breach. ","created_at":"2016-07-05T04:54:51Z","updated_at":"2016-07-05T04:54:51Z","html_url":"https://github.com/Baystation12/Baystation12/pull/13488#discussion_r69507678","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/69507678"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13488#discussion_r69507678"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488","id":75058093,"html_url":"https://github.com/Baystation12/Baystation12/pull/13488","diff_url":"https://github.com/Baystation12/Baystation12/pull/13488.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/13488.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13488","number":13488,"state":"open","locked":false,"title":"Single tank tweaks","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"body":"Changes the way single tank bombs (and even TTVs) now function, including their construction, a safety relief valve, having explosions scale with gas amount and the addition of shrapnel.\r\n\r\nThanks to Daranz for helping me make my first PR, and @Asanadas for getting the idea on paper in the first place.\r\n","created_at":"2016-06-24T03:00:02Z","updated_at":"2016-07-05T04:54:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"618d340a75b6b1d0957fd2e1c9c6c38dd3b72198","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/13488/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/58a0fa64d0d15af8f3f9b2af098123feebb41637","head":{"label":"LorenLuke:Single-tank-tweaks","ref":"Single-tank-tweaks","sha":"58a0fa64d0d15af8f3f9b2af098123feebb41637","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"repo":{"id":26836894,"name":"Baystation12","full_name":"LorenLuke/Baystation12","owner":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LorenLuke/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/LorenLuke/Baystation12","forks_url":"https://api.github.com/repos/LorenLuke/Baystation12/forks","keys_url":"https://api.github.com/repos/LorenLuke/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LorenLuke/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LorenLuke/Baystation12/teams","hooks_url":"https://api.github.com/repos/LorenLuke/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/LorenLuke/Baystation12/events","assignees_url":"https://api.github.com/repos/LorenLuke/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/LorenLuke/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/LorenLuke/Baystation12/tags","blobs_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LorenLuke/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/LorenLuke/Baystation12/languages","stargazers_url":"https://api.github.com/repos/LorenLuke/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/LorenLuke/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/LorenLuke/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/LorenLuke/Baystation12/subscription","commits_url":"https://api.github.com/repos/LorenLuke/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/LorenLuke/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/LorenLuke/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/LorenLuke/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LorenLuke/Baystation12/merges","archive_url":"https://api.github.com/repos/LorenLuke/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LorenLuke/Baystation12/downloads","issues_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/LorenLuke/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/LorenLuke/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/LorenLuke/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LorenLuke/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/LorenLuke/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/LorenLuke/Baystation12/deployments","created_at":"2014-11-19T00:30:53Z","updated_at":"2014-11-19T00:31:03Z","pushed_at":"2016-07-04T23:52:22Z","git_url":"git://github.com/LorenLuke/Baystation12.git","ssh_url":"git@github.com:LorenLuke/Baystation12.git","clone_url":"https://github.com/LorenLuke/Baystation12.git","svn_url":"https://github.com/LorenLuke/Baystation12","homepage":"http://baystation12.net/","size":594016,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"663cd290aa372316e790f871dbbdfc8739361544","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2016-06-28T16:54:39Z","pushed_at":"2016-07-05T02:02:46Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1681468,"stargazers_count":218,"watchers_count":218,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":978,"mirror_url":null,"open_issues_count":428,"forks":978,"open_issues":428,"watchers":218,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/13488"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13488"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/13488/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/13488/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/58a0fa64d0d15af8f3f9b2af098123feebb41637"}}}}
{"actor":{"display_login":"LorenLuke"}}