{"action":"created","comment":{"url":"https://api.github.com/repos/Normation/ncf/pulls/comments/80497892","id":80497892,"diff_hunk":"@@ -89,6 +89,9 @@ app.directive('constraint', function($http, $q, $timeout) {\n     },\n     require: 'ngModel',\n     link: function(scope, elm, attrs, ctrl) {\n+    if((scope.parameter.constraints.allow_empty_string)&&(scope.parameter.value==null)){","path":"builder/js/ncf.js","position":null,"original_position":4,"commit_id":"ad47c8c60ee676393bdd34bd39628c3b4ec32880","original_commit_id":"f103cc1c801f79ae109a5d89306c779d655a068a","user":{"login":"RaphaelGauthier","id":9928447,"avatar_url":"https://avatars.githubusercontent.com/u/9928447?v=3","gravatar_id":"","url":"https://api.github.com/users/RaphaelGauthier","html_url":"https://github.com/RaphaelGauthier","followers_url":"https://api.github.com/users/RaphaelGauthier/followers","following_url":"https://api.github.com/users/RaphaelGauthier/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelGauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelGauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelGauthier/subscriptions","organizations_url":"https://api.github.com/users/RaphaelGauthier/orgs","repos_url":"https://api.github.com/users/RaphaelGauthier/repos","events_url":"https://api.github.com/users/RaphaelGauthier/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelGauthier/received_events","type":"User","site_admin":false},"body":"I thought it was better to check both cases, null and undefined. But ok, it's done!","created_at":"2016-09-26T15:12:10Z","updated_at":"2016-09-26T15:12:12Z","html_url":"https://github.com/Normation/ncf/pull/445#discussion_r80497892","pull_request_url":"https://api.github.com/repos/Normation/ncf/pulls/445","_links":{"self":{"href":"https://api.github.com/repos/Normation/ncf/pulls/comments/80497892"},"html":{"href":"https://github.com/Normation/ncf/pull/445#discussion_r80497892"},"pull_request":{"href":"https://api.github.com/repos/Normation/ncf/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/Normation/ncf/pulls/445","id":86335816,"html_url":"https://github.com/Normation/ncf/pull/445","diff_url":"https://github.com/Normation/ncf/pull/445.diff","patch_url":"https://github.com/Normation/ncf/pull/445.patch","issue_url":"https://api.github.com/repos/Normation/ncf/issues/445","number":445,"state":"open","locked":false,"title":"Fixes #8981: Cannot save new generic method with some contraints","user":{"login":"RaphaelGauthier","id":9928447,"avatar_url":"https://avatars.githubusercontent.com/u/9928447?v=3","gravatar_id":"","url":"https://api.github.com/users/RaphaelGauthier","html_url":"https://github.com/RaphaelGauthier","followers_url":"https://api.github.com/users/RaphaelGauthier/followers","following_url":"https://api.github.com/users/RaphaelGauthier/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelGauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelGauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelGauthier/subscriptions","organizations_url":"https://api.github.com/users/RaphaelGauthier/orgs","repos_url":"https://api.github.com/users/RaphaelGauthier/repos","events_url":"https://api.github.com/users/RaphaelGauthier/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelGauthier/received_events","type":"User","site_admin":false},"body":"https://www.rudder-project.org/redmine/issues/8981","created_at":"2016-09-22T13:20:48Z","updated_at":"2016-09-26T15:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc4b5fcd49f0510584ded5d71521bac719915fca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Normation/ncf/pulls/445/commits","review_comments_url":"https://api.github.com/repos/Normation/ncf/pulls/445/comments","review_comment_url":"https://api.github.com/repos/Normation/ncf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Normation/ncf/issues/445/comments","statuses_url":"https://api.github.com/repos/Normation/ncf/statuses/ad47c8c60ee676393bdd34bd39628c3b4ec32880","head":{"label":"RaphaelGauthier:bug_8981/cannot_save_new_generic_method_with_some_contraints","ref":"bug_8981/cannot_save_new_generic_method_with_some_contraints","sha":"ad47c8c60ee676393bdd34bd39628c3b4ec32880","user":{"login":"RaphaelGauthier","id":9928447,"avatar_url":"https://avatars.githubusercontent.com/u/9928447?v=3","gravatar_id":"","url":"https://api.github.com/users/RaphaelGauthier","html_url":"https://github.com/RaphaelGauthier","followers_url":"https://api.github.com/users/RaphaelGauthier/followers","following_url":"https://api.github.com/users/RaphaelGauthier/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelGauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelGauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelGauthier/subscriptions","organizations_url":"https://api.github.com/users/RaphaelGauthier/orgs","repos_url":"https://api.github.com/users/RaphaelGauthier/repos","events_url":"https://api.github.com/users/RaphaelGauthier/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelGauthier/received_events","type":"User","site_admin":false},"repo":{"id":58062972,"name":"ncf","full_name":"RaphaelGauthier/ncf","owner":{"login":"RaphaelGauthier","id":9928447,"avatar_url":"https://avatars.githubusercontent.com/u/9928447?v=3","gravatar_id":"","url":"https://api.github.com/users/RaphaelGauthier","html_url":"https://github.com/RaphaelGauthier","followers_url":"https://api.github.com/users/RaphaelGauthier/followers","following_url":"https://api.github.com/users/RaphaelGauthier/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelGauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelGauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelGauthier/subscriptions","organizations_url":"https://api.github.com/users/RaphaelGauthier/orgs","repos_url":"https://api.github.com/users/RaphaelGauthier/repos","events_url":"https://api.github.com/users/RaphaelGauthier/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelGauthier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaphaelGauthier/ncf","description":"ncf is a framework that runs in pure CFEngine language, to help structure your CFEngine policy and provide reusable, single purpose components distributed under the GPLv3 license.","fork":true,"url":"https://api.github.com/repos/RaphaelGauthier/ncf","forks_url":"https://api.github.com/repos/RaphaelGauthier/ncf/forks","keys_url":"https://api.github.com/repos/RaphaelGauthier/ncf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaphaelGauthier/ncf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaphaelGauthier/ncf/teams","hooks_url":"https://api.github.com/repos/RaphaelGauthier/ncf/hooks","issue_events_url":"https://api.github.com/repos/RaphaelGauthier/ncf/issues/events{/number}","events_url":"https://api.github.com/repos/RaphaelGauthier/ncf/events","assignees_url":"https://api.github.com/repos/RaphaelGauthier/ncf/assignees{/user}","branches_url":"https://api.github.com/repos/RaphaelGauthier/ncf/branches{/branch}","tags_url":"https://api.github.com/repos/RaphaelGauthier/ncf/tags","blobs_url":"https://api.github.com/repos/RaphaelGauthier/ncf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaphaelGauthier/ncf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaphaelGauthier/ncf/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaphaelGauthier/ncf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaphaelGauthier/ncf/statuses/{sha}","languages_url":"https://api.github.com/repos/RaphaelGauthier/ncf/languages","stargazers_url":"https://api.github.com/repos/RaphaelGauthier/ncf/stargazers","contributors_url":"https://api.github.com/repos/RaphaelGauthier/ncf/contributors","subscribers_url":"https://api.github.com/repos/RaphaelGauthier/ncf/subscribers","subscription_url":"https://api.github.com/repos/RaphaelGauthier/ncf/subscription","commits_url":"https://api.github.com/repos/RaphaelGauthier/ncf/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaphaelGauthier/ncf/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaphaelGauthier/ncf/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaphaelGauthier/ncf/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaphaelGauthier/ncf/contents/{+path}","compare_url":"https://api.github.com/repos/RaphaelGauthier/ncf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaphaelGauthier/ncf/merges","archive_url":"https://api.github.com/repos/RaphaelGauthier/ncf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaphaelGauthier/ncf/downloads","issues_url":"https://api.github.com/repos/RaphaelGauthier/ncf/issues{/number}","pulls_url":"https://api.github.com/repos/RaphaelGauthier/ncf/pulls{/number}","milestones_url":"https://api.github.com/repos/RaphaelGauthier/ncf/milestones{/number}","notifications_url":"https://api.github.com/repos/RaphaelGauthier/ncf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaphaelGauthier/ncf/labels{/name}","releases_url":"https://api.github.com/repos/RaphaelGauthier/ncf/releases{/id}","deployments_url":"https://api.github.com/repos/RaphaelGauthier/ncf/deployments","created_at":"2016-05-04T15:26:33Z","updated_at":"2016-05-04T15:26:35Z","pushed_at":"2016-09-26T15:12:11Z","git_url":"git://github.com/RaphaelGauthier/ncf.git","ssh_url":"git@github.com:RaphaelGauthier/ncf.git","clone_url":"https://github.com/RaphaelGauthier/ncf.git","svn_url":"https://github.com/RaphaelGauthier/ncf","homepage":"http://www.ncf.io","size":2711,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Normation:v0.x","ref":"v0.x","sha":"850d199aab18b9d493631d30c0072188f5c5fdc6","user":{"login":"Normation","id":695105,"avatar_url":"https://avatars.githubusercontent.com/u/695105?v=3","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"repo":{"id":12734168,"name":"ncf","full_name":"Normation/ncf","owner":{"login":"Normation","id":695105,"avatar_url":"https://avatars.githubusercontent.com/u/695105?v=3","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Normation/ncf","description":"ncf is a framework that runs in pure CFEngine language, to help structure your CFEngine policy and provide reusable, single purpose components distributed under the GPLv3 license.","fork":false,"url":"https://api.github.com/repos/Normation/ncf","forks_url":"https://api.github.com/repos/Normation/ncf/forks","keys_url":"https://api.github.com/repos/Normation/ncf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Normation/ncf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Normation/ncf/teams","hooks_url":"https://api.github.com/repos/Normation/ncf/hooks","issue_events_url":"https://api.github.com/repos/Normation/ncf/issues/events{/number}","events_url":"https://api.github.com/repos/Normation/ncf/events","assignees_url":"https://api.github.com/repos/Normation/ncf/assignees{/user}","branches_url":"https://api.github.com/repos/Normation/ncf/branches{/branch}","tags_url":"https://api.github.com/repos/Normation/ncf/tags","blobs_url":"https://api.github.com/repos/Normation/ncf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Normation/ncf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Normation/ncf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Normation/ncf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Normation/ncf/statuses/{sha}","languages_url":"https://api.github.com/repos/Normation/ncf/languages","stargazers_url":"https://api.github.com/repos/Normation/ncf/stargazers","contributors_url":"https://api.github.com/repos/Normation/ncf/contributors","subscribers_url":"https://api.github.com/repos/Normation/ncf/subscribers","subscription_url":"https://api.github.com/repos/Normation/ncf/subscription","commits_url":"https://api.github.com/repos/Normation/ncf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Normation/ncf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Normation/ncf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Normation/ncf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Normation/ncf/contents/{+path}","compare_url":"https://api.github.com/repos/Normation/ncf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Normation/ncf/merges","archive_url":"https://api.github.com/repos/Normation/ncf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Normation/ncf/downloads","issues_url":"https://api.github.com/repos/Normation/ncf/issues{/number}","pulls_url":"https://api.github.com/repos/Normation/ncf/pulls{/number}","milestones_url":"https://api.github.com/repos/Normation/ncf/milestones{/number}","notifications_url":"https://api.github.com/repos/Normation/ncf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Normation/ncf/labels{/name}","releases_url":"https://api.github.com/repos/Normation/ncf/releases{/id}","deployments_url":"https://api.github.com/repos/Normation/ncf/deployments","created_at":"2013-09-10T16:02:33Z","updated_at":"2016-07-04T20:03:12Z","pushed_at":"2016-09-26T15:12:12Z","git_url":"git://github.com/Normation/ncf.git","ssh_url":"git@github.com:Normation/ncf.git","clone_url":"https://github.com/Normation/ncf.git","svn_url":"https://github.com/Normation/ncf","homepage":"http://www.ncf.io","size":3138,"stargazers_count":34,"watchers_count":34,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":16,"forks":25,"open_issues":16,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Normation/ncf/pulls/445"},"html":{"href":"https://github.com/Normation/ncf/pull/445"},"issue":{"href":"https://api.github.com/repos/Normation/ncf/issues/445"},"comments":{"href":"https://api.github.com/repos/Normation/ncf/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/Normation/ncf/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/Normation/ncf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Normation/ncf/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/Normation/ncf/statuses/ad47c8c60ee676393bdd34bd39628c3b4ec32880"}}}}
{"actor":{"display_login":"RaphaelGauthier"}}