{"action":"created","issue":{"url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/issues/39","repository_url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin","labels_url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/issues/39/comments","events_url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/issues/39/events","html_url":"https://github.com/yp-engineering/rbd-docker-plugin/pull/39","id":160807584,"number":39,"title":"Remove size definition in image name","user":{"login":"ohmystack","id":2697228,"avatar_url":"https://avatars.githubusercontent.com/u/2697228?v=3","gravatar_id":"","url":"https://api.github.com/users/ohmystack","html_url":"https://github.com/ohmystack","followers_url":"https://api.github.com/users/ohmystack/followers","following_url":"https://api.github.com/users/ohmystack/following{/other_user}","gists_url":"https://api.github.com/users/ohmystack/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmystack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmystack/subscriptions","organizations_url":"https://api.github.com/users/ohmystack/orgs","repos_url":"https://api.github.com/users/ohmystack/repos","events_url":"https://api.github.com/users/ohmystack/events{/privacy}","received_events_url":"https://api.github.com/users/ohmystack/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-17T03:57:01Z","updated_at":"2016-06-25T19:28:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/pulls/39","html_url":"https://github.com/yp-engineering/rbd-docker-plugin/pull/39","diff_url":"https://github.com/yp-engineering/rbd-docker-plugin/pull/39.diff","patch_url":"https://github.com/yp-engineering/rbd-docker-plugin/pull/39.patch"},"body":"> There is one related PR #37 , please review that first.\r\n\r\nIf we put `@<size>` at the end of the image name, Docker won't recognize\r\nit, and Docker will save `<image-name>@<size>` as the volume name.\r\nHowever, this image is actually the same one as `<image-name>`, without\r\nsuffix. We should make Docker treating them as the same image, instead\r\nof two different ones. This is important because Docker caches the\r\nvolume info, the volume has been referenced by which container, by\r\nimage name.\r\n\r\n> see the code of `setNamed(v volume.Volume, ref string)` in\r\n> [github.com/docker/docker/volume/store/store.go](https://github.com/docker/docker/blob/v1.11.2/volume/store/store.go#L84-L91)\r\n\r\nAfter this change, when creating images at `docker run`, plugin will statically\r\nuse the default value. When creating images by `docker volume create`,\r\nuser can pass size in opts to declare a customized value."},"comment":{"url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/issues/comments/228566377","html_url":"https://github.com/yp-engineering/rbd-docker-plugin/pull/39#issuecomment-228566377","issue_url":"https://api.github.com/repos/yp-engineering/rbd-docker-plugin/issues/39","id":228566377,"user":{"login":"ohmystack","id":2697228,"avatar_url":"https://avatars.githubusercontent.com/u/2697228?v=3","gravatar_id":"","url":"https://api.github.com/users/ohmystack","html_url":"https://github.com/ohmystack","followers_url":"https://api.github.com/users/ohmystack/followers","following_url":"https://api.github.com/users/ohmystack/following{/other_user}","gists_url":"https://api.github.com/users/ohmystack/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmystack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmystack/subscriptions","organizations_url":"https://api.github.com/users/ohmystack/orgs","repos_url":"https://api.github.com/users/ohmystack/repos","events_url":"https://api.github.com/users/ohmystack/events{/privacy}","received_events_url":"https://api.github.com/users/ohmystack/received_events","type":"User","site_admin":false},"created_at":"2016-06-25T19:28:11Z","updated_at":"2016-06-25T19:28:11Z","body":"Oh... I miss the tests."}}
{"actor":{"display_login":"ohmystack"}}