{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/6839","labels_url":"https://api.github.com/repos/openshift/origin/issues/6839/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6839/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/6839/events","html_url":"https://github.com/openshift/origin/pull/6839","id":128918648,"number":6839,"title":"Add buildconfig proxy admission controller","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-01-26T19:31:16Z","updated_at":"2016-01-27T03:39:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6839","html_url":"https://github.com/openshift/origin/pull/6839","diff_url":"https://github.com/openshift/origin/pull/6839.diff","patch_url":"https://github.com/openshift/origin/pull/6839.patch"},"body":"@bparees @pweil- I needed a break from the rebase, built a quick admission controller that can conditionally set the http proxy env vars and updated the git source to take a pointer to a string and do the same.  If you want it, I can add the integration tests to prove the config works too.\r\n\r\n@csrwng you're the natural reviewer if Ben wants to move forward."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/175373790","html_url":"https://github.com/openshift/origin/pull/6839#issuecomment-175373790","issue_url":"https://api.github.com/repos/openshift/origin/issues/6839","id":175373790,"user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"created_at":"2016-01-27T03:39:12Z","updated_at":"2016-01-27T03:39:12Z","body":"> But don't we still need to properly quota builds on creation time?\r\n\r\nyes, but not seeing how that's related to this?  we already put a quota on the build pod and we're going to put the cgroup on the container we launch.  but that's a separate effort.\r\n"}}