{"action":"created","issue":{"url":"https://api.github.com/repos/scrogson/romeo/issues/4","repository_url":"https://api.github.com/repos/scrogson/romeo","labels_url":"https://api.github.com/repos/scrogson/romeo/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/scrogson/romeo/issues/4/comments","events_url":"https://api.github.com/repos/scrogson/romeo/issues/4/events","html_url":"https://github.com/scrogson/romeo/pull/4","id":135507485,"number":4,"title":"Support XEP-0114: Jabber Component Protocol","user":{"login":"tsharju","id":41751,"avatar_url":"https://avatars.githubusercontent.com/u/41751?v=3","gravatar_id":"","url":"https://api.github.com/users/tsharju","html_url":"https://github.com/tsharju","followers_url":"https://api.github.com/users/tsharju/followers","following_url":"https://api.github.com/users/tsharju/following{/other_user}","gists_url":"https://api.github.com/users/tsharju/gists{/gist_id}","starred_url":"https://api.github.com/users/tsharju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsharju/subscriptions","organizations_url":"https://api.github.com/users/tsharju/orgs","repos_url":"https://api.github.com/users/tsharju/repos","events_url":"https://api.github.com/users/tsharju/events{/privacy}","received_events_url":"https://api.github.com/users/tsharju/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-22T18:54:18Z","updated_at":"2016-05-15T04:53:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scrogson/romeo/pulls/4","html_url":"https://github.com/scrogson/romeo/pull/4","diff_url":"https://github.com/scrogson/romeo/pull/4.diff","patch_url":"https://github.com/scrogson/romeo/pull/4.patch"},"body":"Hi,\r\n\r\nThanks for the awesome XMPP lib for Elixir. I'd need support for XEP-0114 and I though I'd send pull request your way.\r\n\r\nDidn't add tests since it would need e.g., `ejabberd.yml` that would have the component connection configured. Are you planning to add one to the repo to be used with tests?"},"comment":{"url":"https://api.github.com/repos/scrogson/romeo/issues/comments/219266305","html_url":"https://github.com/scrogson/romeo/pull/4#issuecomment-219266305","issue_url":"https://api.github.com/repos/scrogson/romeo/issues/4","id":219266305,"user":{"login":"tsharju","id":41751,"avatar_url":"https://avatars.githubusercontent.com/u/41751?v=3","gravatar_id":"","url":"https://api.github.com/users/tsharju","html_url":"https://github.com/tsharju","followers_url":"https://api.github.com/users/tsharju/followers","following_url":"https://api.github.com/users/tsharju/following{/other_user}","gists_url":"https://api.github.com/users/tsharju/gists{/gist_id}","starred_url":"https://api.github.com/users/tsharju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsharju/subscriptions","organizations_url":"https://api.github.com/users/tsharju/orgs","repos_url":"https://api.github.com/users/tsharju/repos","events_url":"https://api.github.com/users/tsharju/events{/privacy}","received_events_url":"https://api.github.com/users/tsharju/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T04:53:14Z","updated_at":"2016-05-15T04:53:14Z","body":"Thanks for the feedback @scrogson. I've been rather busy lately. Yeah. I also thought about splitting it to different files but the component protocol is so very simple. It is basically starting a stream with certain namespace and then doing the handshake for authentication. And then you can basically start sending anything you want to the stream.\r\n\r\nSo that is basically what I did here. I added option to specify namespace for the `Romeo.Connection` and added handling for that namespace in `start_stream`. But yeah, definitely up for discussion how it could be done better. I'm currently using my own XMPP component implementation at https://github.com/futureflynet/jabber, but definitely would like to combine the efforts since it feels silly to write same stuff twice."}}