{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/66589529","id":66589529,"diff_hunk":"@@ -354,7 +354,7 @@ void * Connection::redisCommand(const char * format, ...)\n }\n int Connection::setTimeout(unsigned _timeout)\n {\n-    struct timeval to = { _timeout/1000, (_timeout%1000)*1000 };\n+    struct timeval to = { (int) _timeout/1000, (int) (_timeout%1000)*1000 };","path":"plugins/redis/redis.cpp","position":14,"original_position":14,"commit_id":"a69c6387074536110908a4decb2190bee76c6ef7","original_commit_id":"a69c6387074536110908a4decb2190bee76c6ef7","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"I think this should really be\r\n\r\n{ (time_t)(_timeout/1000), (suseconds_t)((_timeout%1000)*1000) };\r\n\r\nsomething similar above (and don't change the type of timeStillLeft)\r\n","created_at":"2016-06-10T10:01:32Z","updated_at":"2016-06-10T10:01:32Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8768#discussion_r66589529","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/66589529"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8768#discussion_r66589529"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768","id":73348297,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8768","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8768.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8768.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8768","number":8768,"state":"open","locked":false,"title":"HPCC-14405 Redis Plugin - cache all subscription connections","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"Fix build error on CLang\r\n\r\nSigned-off-by: Richard Chapman <rchapman@hpccsystems.com>","created_at":"2016-06-10T09:55:22Z","updated_at":"2016-06-10T10:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9995d5eef4016a112440e6fe471127d6b38c4f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8768/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/a69c6387074536110908a4decb2190bee76c6ef7","head":{"label":"richardkchapman:redis-build-error","ref":"redis-build-error","sha":"a69c6387074536110908a4decb2190bee76c6ef7","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"repo":{"id":2031005,"name":"HPCC-Platform","full_name":"richardkchapman/HPCC-Platform","owner":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardkchapman/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/richardkchapman/HPCC-Platform","forks_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/deployments","created_at":"2011-07-11T15:22:03Z","updated_at":"2015-02-12T17:31:52Z","pushed_at":"2016-06-10T09:55:15Z","git_url":"git://github.com/richardkchapman/HPCC-Platform.git","ssh_url":"git@github.com:richardkchapman/HPCC-Platform.git","clone_url":"https://github.com/richardkchapman/HPCC-Platform.git","svn_url":"https://github.com/richardkchapman/HPCC-Platform","homepage":"www.hpccsystems.com","size":168690,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"220c327694a046a378cd1c148ad85c97718bcb43","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-06-09T17:42:33Z","pushed_at":"2016-06-10T09:55:53Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":196987,"stargazers_count":280,"watchers_count":280,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":422,"forks":149,"open_issues":422,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8768"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8768"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8768/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8768/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/a69c6387074536110908a4decb2190bee76c6ef7"}}}}
{"actor":{"display_login":"ghalliday"}}