{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/83936817","pull_request_review_id":4747024,"id":83936817,"diff_hunk":"@@ -113,6 +114,29 @@ class Tabs extends Component {\n     this.setState(newState);\n   }\n \n+  calculateTabWidthAndInkbarPosition(tabs, selectedIndex, defaultWidth) {","path":"src/Tabs/Tabs.js","position":12,"original_position":12,"commit_id":"0f29f70ea0aa298c7989579f97a3ff31f2387e58","original_commit_id":"0f29f70ea0aa298c7989579f97a3ff31f2387e58","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"We don't rely on the instance, it would be better to have this function as a module function.","created_at":"2016-10-18T19:54:39Z","updated_at":"2016-10-18T19:57:45Z","html_url":"https://github.com/callemall/material-ui/pull/5415#discussion_r83936817","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/5415","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/83936817"},"html":{"href":"https://github.com/callemall/material-ui/pull/5415#discussion_r83936817"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5415"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/5415","id":89723169,"html_url":"https://github.com/callemall/material-ui/pull/5415","diff_url":"https://github.com/callemall/material-ui/pull/5415.diff","patch_url":"https://github.com/callemall/material-ui/pull/5415.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/5415","number":5415,"state":"open","locked":false,"title":"[Tabs] Let each tab set its own width","user":{"login":"GAumala","id":5729175,"avatar_url":"https://avatars.githubusercontent.com/u/5729175?v=3","gravatar_id":"","url":"https://api.github.com/users/GAumala","html_url":"https://github.com/GAumala","followers_url":"https://api.github.com/users/GAumala/followers","following_url":"https://api.github.com/users/GAumala/following{/other_user}","gists_url":"https://api.github.com/users/GAumala/gists{/gist_id}","starred_url":"https://api.github.com/users/GAumala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAumala/subscriptions","organizations_url":"https://api.github.com/users/GAumala/orgs","repos_url":"https://api.github.com/users/GAumala/repos","events_url":"https://api.github.com/users/GAumala/events{/privacy}","received_events_url":"https://api.github.com/users/GAumala/received_events","type":"User","site_admin":false},"body":"<!-- Thanks so much for your PR, your contribution is appreciated! -->\r\n\r\n- [ ] PR has tests / docs demo, and is linted.\r\n- [ ] Commit and PR titles begin with [ComponentName], and are in imperative form: \"[Component] Fix leaky abstraction\".\r\n- [ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).\r\n\r\n\r\nThe Tab component has a new prop of type number: labelWidth. This number\r\nis the width of the label in pixels. The user must either set this prop\r\nto every tab or none. If this condition is not met, the ink bar is not\r\ndrawn, and a warning is displayed in the console.\r\n\r\nThe docs have also been updated with information and an example for this\r\nprop.\r\n\r\nThis solves issue #4420. This approach was suggested in #5301.","created_at":"2016-10-17T23:39:30Z","updated_at":"2016-10-18T19:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97bbdf5eb71961a79a19ebf90c266b4f3a703527","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/5415/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/5415/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/5415/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/0f29f70ea0aa298c7989579f97a3ff31f2387e58","head":{"label":"GAumala:tab-label-width","ref":"tab-label-width","sha":"0f29f70ea0aa298c7989579f97a3ff31f2387e58","user":{"login":"GAumala","id":5729175,"avatar_url":"https://avatars.githubusercontent.com/u/5729175?v=3","gravatar_id":"","url":"https://api.github.com/users/GAumala","html_url":"https://github.com/GAumala","followers_url":"https://api.github.com/users/GAumala/followers","following_url":"https://api.github.com/users/GAumala/following{/other_user}","gists_url":"https://api.github.com/users/GAumala/gists{/gist_id}","starred_url":"https://api.github.com/users/GAumala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAumala/subscriptions","organizations_url":"https://api.github.com/users/GAumala/orgs","repos_url":"https://api.github.com/users/GAumala/repos","events_url":"https://api.github.com/users/GAumala/events{/privacy}","received_events_url":"https://api.github.com/users/GAumala/received_events","type":"User","site_admin":false},"repo":{"id":65629755,"name":"material-ui","full_name":"GAumala/material-ui","owner":{"login":"GAumala","id":5729175,"avatar_url":"https://avatars.githubusercontent.com/u/5729175?v=3","gravatar_id":"","url":"https://api.github.com/users/GAumala","html_url":"https://github.com/GAumala","followers_url":"https://api.github.com/users/GAumala/followers","following_url":"https://api.github.com/users/GAumala/following{/other_user}","gists_url":"https://api.github.com/users/GAumala/gists{/gist_id}","starred_url":"https://api.github.com/users/GAumala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GAumala/subscriptions","organizations_url":"https://api.github.com/users/GAumala/orgs","repos_url":"https://api.github.com/users/GAumala/repos","events_url":"https://api.github.com/users/GAumala/events{/privacy}","received_events_url":"https://api.github.com/users/GAumala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GAumala/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/GAumala/material-ui","forks_url":"https://api.github.com/repos/GAumala/material-ui/forks","keys_url":"https://api.github.com/repos/GAumala/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GAumala/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GAumala/material-ui/teams","hooks_url":"https://api.github.com/repos/GAumala/material-ui/hooks","issue_events_url":"https://api.github.com/repos/GAumala/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/GAumala/material-ui/events","assignees_url":"https://api.github.com/repos/GAumala/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/GAumala/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/GAumala/material-ui/tags","blobs_url":"https://api.github.com/repos/GAumala/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GAumala/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GAumala/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/GAumala/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GAumala/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/GAumala/material-ui/languages","stargazers_url":"https://api.github.com/repos/GAumala/material-ui/stargazers","contributors_url":"https://api.github.com/repos/GAumala/material-ui/contributors","subscribers_url":"https://api.github.com/repos/GAumala/material-ui/subscribers","subscription_url":"https://api.github.com/repos/GAumala/material-ui/subscription","commits_url":"https://api.github.com/repos/GAumala/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/GAumala/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/GAumala/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/GAumala/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/GAumala/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/GAumala/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GAumala/material-ui/merges","archive_url":"https://api.github.com/repos/GAumala/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GAumala/material-ui/downloads","issues_url":"https://api.github.com/repos/GAumala/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/GAumala/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/GAumala/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/GAumala/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GAumala/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/GAumala/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/GAumala/material-ui/deployments","created_at":"2016-08-13T17:51:47Z","updated_at":"2016-08-13T17:51:50Z","pushed_at":"2016-10-17T23:35:39Z","git_url":"git://github.com/GAumala/material-ui.git","ssh_url":"git@github.com:GAumala/material-ui.git","clone_url":"https://github.com/GAumala/material-ui.git","svn_url":"https://github.com/GAumala/material-ui","homepage":"http://www.material-ui.com","size":72997,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"4efc03e0cd19c8489095799ed23076200da18f9b","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-10-18T19:15:50Z","pushed_at":"2016-10-18T19:49:30Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":82090,"stargazers_count":20288,"watchers_count":20288,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3648,"mirror_url":null,"open_issues_count":630,"forks":3648,"open_issues":630,"watchers":20288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5415"},"html":{"href":"https://github.com/callemall/material-ui/pull/5415"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5415"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/5415/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5415/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/5415/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/0f29f70ea0aa298c7989579f97a3ff31f2387e58"}}}}
{"actor":{"display_login":"oliviertassinari"}}