{"action":"created","issue":{"url":"https://api.github.com/repos/snapcore/snapd/issues/2268","repository_url":"https://api.github.com/repos/snapcore/snapd","labels_url":"https://api.github.com/repos/snapcore/snapd/issues/2268/labels{/name}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/2268/comments","events_url":"https://api.github.com/repos/snapcore/snapd/issues/2268/events","html_url":"https://github.com/snapcore/snapd/pull/2268","id":187714452,"number":2268,"title":"many: merge snap-confine into snapd","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-11-07T13:41:45Z","updated_at":"2016-11-30T14:32:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/2268","html_url":"https://github.com/snapcore/snapd/pull/2268","diff_url":"https://github.com/snapcore/snapd/pull/2268.diff","patch_url":"https://github.com/snapcore/snapd/pull/2268.patch"},"body":"This branch commences the process of merging snap-confine into snapd.\r\n\r\nSubsequent branches will make the code more in line with snapd. This includes support for merged packaging, for spread tests and for nice layout of cmd/* commands."},"comment":{"url":"https://api.github.com/repos/snapcore/snapd/issues/comments/263887653","html_url":"https://github.com/snapcore/snapd/pull/2268#issuecomment-263887653","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/2268","id":263887653,"user":{"login":"niemeyer","id":378683,"avatar_url":"https://avatars.githubusercontent.com/u/378683?v=3","gravatar_id":"","url":"https://api.github.com/users/niemeyer","html_url":"https://github.com/niemeyer","followers_url":"https://api.github.com/users/niemeyer/followers","following_url":"https://api.github.com/users/niemeyer/following{/other_user}","gists_url":"https://api.github.com/users/niemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/niemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niemeyer/subscriptions","organizations_url":"https://api.github.com/users/niemeyer/orgs","repos_url":"https://api.github.com/users/niemeyer/repos","events_url":"https://api.github.com/users/niemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/niemeyer/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T14:32:42Z","updated_at":"2016-11-30T14:32:42Z","body":"@tyhicks @jdstrand It seems unnecessary to add a label to every single PR that touches snap-confine. A relevant portion of the code in snapd is just as sensitive, and we haven't been doing that. Even when we touch interfaces, not every single review go through (or needs to go through) the security team.\r\n\r\nMy proposal, instead, is that we keep doing what we've been doing: when we touch areas of the code where we benefit from expertise from particular parties, we should invite them to have a look. We have good evidence that we've been doing that effectively, as @jdstrand will probably agree, being regularly invited to provide a final review on sensitive interface code that would benefit from his input (highly appreciated, in fact).\r\n\r\n"}}
{"actor":{"display_login":"niemeyer"}}