{"action":"created","comment":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/comments/61333766","id":61333766,"diff_hunk":"@@ -117,11 +170,9 @@ class ResourceEmailViewSet(EmailViewSet):\n     required_keys = [\"quota\", \"reason\"]\n \n     def _email(self, user, data):\n-        quota = data.pop('quota')\n-        reason = data.pop('reason')\n         email_response = resource_request_email(\n-            self.request, user.username, quota, reason)\n-        if not email_response.get('email_sent', False):\n-            return Response(email_response, status=status.HTTP_400_BAD_REQUEST)\n-        else:\n+            self.request, user.username, data[\"quota\"], data[\"reason\"])\n+        if email_response.get('email_sent', False):","path":"api/v2/views/email.py","position":128,"original_position":128,"commit_id":"85c41180d66acf257c8c14fd26211460509f472f","original_commit_id":"85c41180d66acf257c8c14fd26211460509f472f","user":{"login":"steve-gregory","id":2889930,"avatar_url":"https://avatars.githubusercontent.com/u/2889930?v=3","gravatar_id":"","url":"https://api.github.com/users/steve-gregory","html_url":"https://github.com/steve-gregory","followers_url":"https://api.github.com/users/steve-gregory/followers","following_url":"https://api.github.com/users/steve-gregory/following{/other_user}","gists_url":"https://api.github.com/users/steve-gregory/gists{/gist_id}","starred_url":"https://api.github.com/users/steve-gregory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steve-gregory/subscriptions","organizations_url":"https://api.github.com/users/steve-gregory/orgs","repos_url":"https://api.github.com/users/steve-gregory/repos","events_url":"https://api.github.com/users/steve-gregory/events{/privacy}","received_events_url":"https://api.github.com/users/steve-gregory/received_events","type":"User","site_admin":false},"body":"ensure the resource request email is sent to request_tracker","created_at":"2016-04-27T20:52:17Z","updated_at":"2016-04-27T20:52:17Z","html_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere/pull/135#discussion_r61333766","pull_request_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/comments/61333766"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/atmosphere/pull/135#discussion_r61333766"},"pull_request":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135","id":67771955,"html_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere/pull/135","diff_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere/pull/135.diff","patch_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere/pull/135.patch","issue_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues/135","number":135,"state":"open","locked":false,"title":"[ATMO-991] fix email","user":{"login":"cdosborn","id":3847314,"avatar_url":"https://avatars.githubusercontent.com/u/3847314?v=3","gravatar_id":"","url":"https://api.github.com/users/cdosborn","html_url":"https://github.com/cdosborn","followers_url":"https://api.github.com/users/cdosborn/followers","following_url":"https://api.github.com/users/cdosborn/following{/other_user}","gists_url":"https://api.github.com/users/cdosborn/gists{/gist_id}","starred_url":"https://api.github.com/users/cdosborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdosborn/subscriptions","organizations_url":"https://api.github.com/users/cdosborn/orgs","repos_url":"https://api.github.com/users/cdosborn/repos","events_url":"https://api.github.com/users/cdosborn/events{/privacy}","received_events_url":"https://api.github.com/users/cdosborn/received_events","type":"User","site_admin":false},"body":"There's a corresponding tropo PR, which i need to link. But i'm grabbing :pizza: \r\n\r\n[Tropo PR](https://github.com/iPlantCollaborativeOpenSource/troposphere/pull/348)\r\n[ATMO-991](https://pods.iplantcollaborative.org/jira/browse/ATMO-991)","created_at":"2016-04-25T19:10:18Z","updated_at":"2016-04-27T20:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"218f52f203667ab0814637afb9191988a08ecb16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135/commits","review_comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135/comments","review_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues/135/comments","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/statuses/85c41180d66acf257c8c14fd26211460509f472f","head":{"label":"cdosborn:ATMO-991-fix-email","ref":"ATMO-991-fix-email","sha":"85c41180d66acf257c8c14fd26211460509f472f","user":{"login":"cdosborn","id":3847314,"avatar_url":"https://avatars.githubusercontent.com/u/3847314?v=3","gravatar_id":"","url":"https://api.github.com/users/cdosborn","html_url":"https://github.com/cdosborn","followers_url":"https://api.github.com/users/cdosborn/followers","following_url":"https://api.github.com/users/cdosborn/following{/other_user}","gists_url":"https://api.github.com/users/cdosborn/gists{/gist_id}","starred_url":"https://api.github.com/users/cdosborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdosborn/subscriptions","organizations_url":"https://api.github.com/users/cdosborn/orgs","repos_url":"https://api.github.com/users/cdosborn/repos","events_url":"https://api.github.com/users/cdosborn/events{/privacy}","received_events_url":"https://api.github.com/users/cdosborn/received_events","type":"User","site_admin":false},"repo":{"id":44635999,"name":"atmosphere","full_name":"cdosborn/atmosphere","owner":{"login":"cdosborn","id":3847314,"avatar_url":"https://avatars.githubusercontent.com/u/3847314?v=3","gravatar_id":"","url":"https://api.github.com/users/cdosborn","html_url":"https://github.com/cdosborn","followers_url":"https://api.github.com/users/cdosborn/followers","following_url":"https://api.github.com/users/cdosborn/following{/other_user}","gists_url":"https://api.github.com/users/cdosborn/gists{/gist_id}","starred_url":"https://api.github.com/users/cdosborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdosborn/subscriptions","organizations_url":"https://api.github.com/users/cdosborn/orgs","repos_url":"https://api.github.com/users/cdosborn/repos","events_url":"https://api.github.com/users/cdosborn/events{/privacy}","received_events_url":"https://api.github.com/users/cdosborn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdosborn/atmosphere","description":"Where cloud lives.","fork":true,"url":"https://api.github.com/repos/cdosborn/atmosphere","forks_url":"https://api.github.com/repos/cdosborn/atmosphere/forks","keys_url":"https://api.github.com/repos/cdosborn/atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdosborn/atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdosborn/atmosphere/teams","hooks_url":"https://api.github.com/repos/cdosborn/atmosphere/hooks","issue_events_url":"https://api.github.com/repos/cdosborn/atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/cdosborn/atmosphere/events","assignees_url":"https://api.github.com/repos/cdosborn/atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/cdosborn/atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/cdosborn/atmosphere/tags","blobs_url":"https://api.github.com/repos/cdosborn/atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdosborn/atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdosborn/atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdosborn/atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdosborn/atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/cdosborn/atmosphere/languages","stargazers_url":"https://api.github.com/repos/cdosborn/atmosphere/stargazers","contributors_url":"https://api.github.com/repos/cdosborn/atmosphere/contributors","subscribers_url":"https://api.github.com/repos/cdosborn/atmosphere/subscribers","subscription_url":"https://api.github.com/repos/cdosborn/atmosphere/subscription","commits_url":"https://api.github.com/repos/cdosborn/atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdosborn/atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdosborn/atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdosborn/atmosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdosborn/atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/cdosborn/atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdosborn/atmosphere/merges","archive_url":"https://api.github.com/repos/cdosborn/atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdosborn/atmosphere/downloads","issues_url":"https://api.github.com/repos/cdosborn/atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/cdosborn/atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/cdosborn/atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/cdosborn/atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdosborn/atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/cdosborn/atmosphere/releases{/id}","deployments_url":"https://api.github.com/repos/cdosborn/atmosphere/deployments","created_at":"2015-10-20T21:29:42Z","updated_at":"2016-03-15T18:54:57Z","pushed_at":"2016-04-25T19:08:25Z","git_url":"git://github.com/cdosborn/atmosphere.git","ssh_url":"git@github.com:cdosborn/atmosphere.git","clone_url":"https://github.com/cdosborn/atmosphere.git","svn_url":"https://github.com/cdosborn/atmosphere","homepage":"https://atmo.iplantcollaborative.org","size":177203,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iPlantCollaborativeOpenSource:nautical-nighthawk","ref":"nautical-nighthawk","sha":"cbfd407ba08836ea465b6fd21a8435e87e37603a","user":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"repo":{"id":8279795,"name":"atmosphere","full_name":"iPlantCollaborativeOpenSource/atmosphere","owner":{"login":"iPlantCollaborativeOpenSource","id":669032,"avatar_url":"https://avatars.githubusercontent.com/u/669032?v=3","gravatar_id":"","url":"https://api.github.com/users/iPlantCollaborativeOpenSource","html_url":"https://github.com/iPlantCollaborativeOpenSource","followers_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/followers","following_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/subscriptions","organizations_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/orgs","repos_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/repos","events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/iPlantCollaborativeOpenSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere","description":"Where cloud lives.","fork":false,"url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere","forks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/forks","keys_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/teams","hooks_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/hooks","issue_events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/events","assignees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/tags","blobs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/languages","stargazers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/stargazers","contributors_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/contributors","subscribers_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/subscribers","subscription_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/subscription","commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/merges","archive_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/downloads","issues_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/releases{/id}","deployments_url":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/deployments","created_at":"2013-02-18T23:54:07Z","updated_at":"2016-04-26T12:08:07Z","pushed_at":"2016-04-27T18:13:56Z","git_url":"git://github.com/iPlantCollaborativeOpenSource/atmosphere.git","ssh_url":"git@github.com:iPlantCollaborativeOpenSource/atmosphere.git","clone_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere.git","svn_url":"https://github.com/iPlantCollaborativeOpenSource/atmosphere","homepage":"https://atmo.iplantcollaborative.org","size":177300,"stargazers_count":118,"watchers_count":118,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":4,"forks":59,"open_issues":4,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135"},"html":{"href":"https://github.com/iPlantCollaborativeOpenSource/atmosphere/pull/135"},"issue":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues/135"},"comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/iPlantCollaborativeOpenSource/atmosphere/statuses/85c41180d66acf257c8c14fd26211460509f472f"}}}}