{"action":"created","comment":{"url":"https://api.github.com/repos/zoofIO/flexx/pulls/comments/91957577","pull_request_review_id":12466455,"id":91957577,"diff_hunk":"@@ -9,4 +9,6 @@\n                          'it is closed.'),\n     ssl_certfile=('', str, 'cert file for https server.'),\n     ssl_keyfile=('', str, 'key file for https server.'),\n+    hosts_whitelist=('', str, 'Comma separated list of allowed <host>:<port> '\n+                              'values to pass cross-origin checks.'),","path":"flexx/_config.py","position":5,"original_position":5,"commit_id":"fb669f29db903a025d1cec2838add0aff07d079a","original_commit_id":"fb669f29db903a025d1cec2838add0aff07d079a","user":{"login":"almarklein","id":3015475,"avatar_url":"https://avatars.githubusercontent.com/u/3015475?v=3","gravatar_id":"","url":"https://api.github.com/users/almarklein","html_url":"https://github.com/almarklein","followers_url":"https://api.github.com/users/almarklein/followers","following_url":"https://api.github.com/users/almarklein/following{/other_user}","gists_url":"https://api.github.com/users/almarklein/gists{/gist_id}","starred_url":"https://api.github.com/users/almarklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almarklein/subscriptions","organizations_url":"https://api.github.com/users/almarklein/orgs","repos_url":"https://api.github.com/users/almarklein/repos","events_url":"https://api.github.com/users/almarklein/events{/privacy}","received_events_url":"https://api.github.com/users/almarklein/received_events","type":"User","site_admin":false},"body":"Nitpicking, but I'd prefer `host_whitelist`, because \"list\" already implied plural, and googling it seems to suggests a few projects also using that name.","created_at":"2016-12-12T14:35:32Z","updated_at":"2016-12-12T14:35:35Z","html_url":"https://github.com/zoofIO/flexx/pull/317#discussion_r91957577","pull_request_url":"https://api.github.com/repos/zoofIO/flexx/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/zoofIO/flexx/pulls/comments/91957577"},"html":{"href":"https://github.com/zoofIO/flexx/pull/317#discussion_r91957577"},"pull_request":{"href":"https://api.github.com/repos/zoofIO/flexx/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/zoofIO/flexx/pulls/317","id":97457147,"html_url":"https://github.com/zoofIO/flexx/pull/317","diff_url":"https://github.com/zoofIO/flexx/pull/317.diff","patch_url":"https://github.com/zoofIO/flexx/pull/317.patch","issue_url":"https://api.github.com/repos/zoofIO/flexx/issues/317","number":317,"state":"open","locked":false,"title":"SSL support for remotely running Jupyter notebooks","user":{"login":"alexveden","id":18488560,"avatar_url":"https://avatars.githubusercontent.com/u/18488560?v=3","gravatar_id":"","url":"https://api.github.com/users/alexveden","html_url":"https://github.com/alexveden","followers_url":"https://api.github.com/users/alexveden/followers","following_url":"https://api.github.com/users/alexveden/following{/other_user}","gists_url":"https://api.github.com/users/alexveden/gists{/gist_id}","starred_url":"https://api.github.com/users/alexveden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexveden/subscriptions","organizations_url":"https://api.github.com/users/alexveden/orgs","repos_url":"https://api.github.com/users/alexveden/repos","events_url":"https://api.github.com/users/alexveden/events{/privacy}","received_events_url":"https://api.github.com/users/alexveden/received_events","type":"User","site_admin":false},"body":"* app.init_notebook() fix added WSS to url\r\n* TornadoServer  Comparing hostnames in case of Jupyter notebooks connecting_host and serving_host have same host names but different ports","created_at":"2016-12-11T12:17:16Z","updated_at":"2016-12-12T14:35:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36898efbba21f77852510929e291031f366e4f32","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zoofIO/flexx/pulls/317/commits","review_comments_url":"https://api.github.com/repos/zoofIO/flexx/pulls/317/comments","review_comment_url":"https://api.github.com/repos/zoofIO/flexx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zoofIO/flexx/issues/317/comments","statuses_url":"https://api.github.com/repos/zoofIO/flexx/statuses/fb669f29db903a025d1cec2838add0aff07d079a","head":{"label":"alexveden:ssl_notebook_fix","ref":"ssl_notebook_fix","sha":"fb669f29db903a025d1cec2838add0aff07d079a","user":{"login":"alexveden","id":18488560,"avatar_url":"https://avatars.githubusercontent.com/u/18488560?v=3","gravatar_id":"","url":"https://api.github.com/users/alexveden","html_url":"https://github.com/alexveden","followers_url":"https://api.github.com/users/alexveden/followers","following_url":"https://api.github.com/users/alexveden/following{/other_user}","gists_url":"https://api.github.com/users/alexveden/gists{/gist_id}","starred_url":"https://api.github.com/users/alexveden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexveden/subscriptions","organizations_url":"https://api.github.com/users/alexveden/orgs","repos_url":"https://api.github.com/users/alexveden/repos","events_url":"https://api.github.com/users/alexveden/events{/privacy}","received_events_url":"https://api.github.com/users/alexveden/received_events","type":"User","site_admin":false},"repo":{"id":76172080,"name":"flexx","full_name":"alexveden/flexx","owner":{"login":"alexveden","id":18488560,"avatar_url":"https://avatars.githubusercontent.com/u/18488560?v=3","gravatar_id":"","url":"https://api.github.com/users/alexveden","html_url":"https://github.com/alexveden","followers_url":"https://api.github.com/users/alexveden/followers","following_url":"https://api.github.com/users/alexveden/following{/other_user}","gists_url":"https://api.github.com/users/alexveden/gists{/gist_id}","starred_url":"https://api.github.com/users/alexveden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexveden/subscriptions","organizations_url":"https://api.github.com/users/alexveden/orgs","repos_url":"https://api.github.com/users/alexveden/repos","events_url":"https://api.github.com/users/alexveden/events{/privacy}","received_events_url":"https://api.github.com/users/alexveden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexveden/flexx","description":"Write desktop and web apps in pure Python","fork":true,"url":"https://api.github.com/repos/alexveden/flexx","forks_url":"https://api.github.com/repos/alexveden/flexx/forks","keys_url":"https://api.github.com/repos/alexveden/flexx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexveden/flexx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexveden/flexx/teams","hooks_url":"https://api.github.com/repos/alexveden/flexx/hooks","issue_events_url":"https://api.github.com/repos/alexveden/flexx/issues/events{/number}","events_url":"https://api.github.com/repos/alexveden/flexx/events","assignees_url":"https://api.github.com/repos/alexveden/flexx/assignees{/user}","branches_url":"https://api.github.com/repos/alexveden/flexx/branches{/branch}","tags_url":"https://api.github.com/repos/alexveden/flexx/tags","blobs_url":"https://api.github.com/repos/alexveden/flexx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexveden/flexx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexveden/flexx/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexveden/flexx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexveden/flexx/statuses/{sha}","languages_url":"https://api.github.com/repos/alexveden/flexx/languages","stargazers_url":"https://api.github.com/repos/alexveden/flexx/stargazers","contributors_url":"https://api.github.com/repos/alexveden/flexx/contributors","subscribers_url":"https://api.github.com/repos/alexveden/flexx/subscribers","subscription_url":"https://api.github.com/repos/alexveden/flexx/subscription","commits_url":"https://api.github.com/repos/alexveden/flexx/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexveden/flexx/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexveden/flexx/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexveden/flexx/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexveden/flexx/contents/{+path}","compare_url":"https://api.github.com/repos/alexveden/flexx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexveden/flexx/merges","archive_url":"https://api.github.com/repos/alexveden/flexx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexveden/flexx/downloads","issues_url":"https://api.github.com/repos/alexveden/flexx/issues{/number}","pulls_url":"https://api.github.com/repos/alexveden/flexx/pulls{/number}","milestones_url":"https://api.github.com/repos/alexveden/flexx/milestones{/number}","notifications_url":"https://api.github.com/repos/alexveden/flexx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexveden/flexx/labels{/name}","releases_url":"https://api.github.com/repos/alexveden/flexx/releases{/id}","deployments_url":"https://api.github.com/repos/alexveden/flexx/deployments","created_at":"2016-12-11T12:09:27Z","updated_at":"2016-12-11T12:09:28Z","pushed_at":"2016-12-12T13:18:15Z","git_url":"git://github.com/alexveden/flexx.git","ssh_url":"git@github.com:alexveden/flexx.git","clone_url":"https://github.com/alexveden/flexx.git","svn_url":"https://github.com/alexveden/flexx","homepage":"http://flexx.readthedocs.io","size":2919,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zoofIO:master","ref":"master","sha":"1fa5b58616ae898e80461c54ebdd0b3bc2d1acdc","user":{"login":"zoofIO","id":8639587,"avatar_url":"https://avatars.githubusercontent.com/u/8639587?v=3","gravatar_id":"","url":"https://api.github.com/users/zoofIO","html_url":"https://github.com/zoofIO","followers_url":"https://api.github.com/users/zoofIO/followers","following_url":"https://api.github.com/users/zoofIO/following{/other_user}","gists_url":"https://api.github.com/users/zoofIO/gists{/gist_id}","starred_url":"https://api.github.com/users/zoofIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoofIO/subscriptions","organizations_url":"https://api.github.com/users/zoofIO/orgs","repos_url":"https://api.github.com/users/zoofIO/repos","events_url":"https://api.github.com/users/zoofIO/events{/privacy}","received_events_url":"https://api.github.com/users/zoofIO/received_events","type":"Organization","site_admin":false},"repo":{"id":23612831,"name":"flexx","full_name":"zoofIO/flexx","owner":{"login":"zoofIO","id":8639587,"avatar_url":"https://avatars.githubusercontent.com/u/8639587?v=3","gravatar_id":"","url":"https://api.github.com/users/zoofIO","html_url":"https://github.com/zoofIO","followers_url":"https://api.github.com/users/zoofIO/followers","following_url":"https://api.github.com/users/zoofIO/following{/other_user}","gists_url":"https://api.github.com/users/zoofIO/gists{/gist_id}","starred_url":"https://api.github.com/users/zoofIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoofIO/subscriptions","organizations_url":"https://api.github.com/users/zoofIO/orgs","repos_url":"https://api.github.com/users/zoofIO/repos","events_url":"https://api.github.com/users/zoofIO/events{/privacy}","received_events_url":"https://api.github.com/users/zoofIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zoofIO/flexx","description":"Write desktop and web apps in pure Python","fork":false,"url":"https://api.github.com/repos/zoofIO/flexx","forks_url":"https://api.github.com/repos/zoofIO/flexx/forks","keys_url":"https://api.github.com/repos/zoofIO/flexx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoofIO/flexx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoofIO/flexx/teams","hooks_url":"https://api.github.com/repos/zoofIO/flexx/hooks","issue_events_url":"https://api.github.com/repos/zoofIO/flexx/issues/events{/number}","events_url":"https://api.github.com/repos/zoofIO/flexx/events","assignees_url":"https://api.github.com/repos/zoofIO/flexx/assignees{/user}","branches_url":"https://api.github.com/repos/zoofIO/flexx/branches{/branch}","tags_url":"https://api.github.com/repos/zoofIO/flexx/tags","blobs_url":"https://api.github.com/repos/zoofIO/flexx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoofIO/flexx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoofIO/flexx/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoofIO/flexx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoofIO/flexx/statuses/{sha}","languages_url":"https://api.github.com/repos/zoofIO/flexx/languages","stargazers_url":"https://api.github.com/repos/zoofIO/flexx/stargazers","contributors_url":"https://api.github.com/repos/zoofIO/flexx/contributors","subscribers_url":"https://api.github.com/repos/zoofIO/flexx/subscribers","subscription_url":"https://api.github.com/repos/zoofIO/flexx/subscription","commits_url":"https://api.github.com/repos/zoofIO/flexx/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoofIO/flexx/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoofIO/flexx/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoofIO/flexx/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoofIO/flexx/contents/{+path}","compare_url":"https://api.github.com/repos/zoofIO/flexx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoofIO/flexx/merges","archive_url":"https://api.github.com/repos/zoofIO/flexx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoofIO/flexx/downloads","issues_url":"https://api.github.com/repos/zoofIO/flexx/issues{/number}","pulls_url":"https://api.github.com/repos/zoofIO/flexx/pulls{/number}","milestones_url":"https://api.github.com/repos/zoofIO/flexx/milestones{/number}","notifications_url":"https://api.github.com/repos/zoofIO/flexx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoofIO/flexx/labels{/name}","releases_url":"https://api.github.com/repos/zoofIO/flexx/releases{/id}","deployments_url":"https://api.github.com/repos/zoofIO/flexx/deployments","created_at":"2014-09-03T08:38:00Z","updated_at":"2016-12-10T11:08:13Z","pushed_at":"2016-12-12T13:18:15Z","git_url":"git://github.com/zoofIO/flexx.git","ssh_url":"git@github.com:zoofIO/flexx.git","clone_url":"https://github.com/zoofIO/flexx.git","svn_url":"https://github.com/zoofIO/flexx","homepage":"http://flexx.readthedocs.io","size":3049,"stargazers_count":1094,"watchers_count":1094,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":81,"forks":115,"open_issues":81,"watchers":1094,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zoofIO/flexx/pulls/317"},"html":{"href":"https://github.com/zoofIO/flexx/pull/317"},"issue":{"href":"https://api.github.com/repos/zoofIO/flexx/issues/317"},"comments":{"href":"https://api.github.com/repos/zoofIO/flexx/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/zoofIO/flexx/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/zoofIO/flexx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zoofIO/flexx/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/zoofIO/flexx/statuses/fb669f29db903a025d1cec2838add0aff07d079a"}}}}
{"actor":{"display_login":"almarklein"}}