{"action":"created","issue":{"url":"https://api.github.com/repos/davidmarkclements/0x/issues/58","repository_url":"https://api.github.com/repos/davidmarkclements/0x","labels_url":"https://api.github.com/repos/davidmarkclements/0x/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/davidmarkclements/0x/issues/58/comments","events_url":"https://api.github.com/repos/davidmarkclements/0x/issues/58/events","html_url":"https://github.com/davidmarkclements/0x/issues/58","id":192962573,"number":58,"title":"Optimzed and Not Optimized","user":{"login":"mattbajorek","id":17235301,"avatar_url":"https://avatars.githubusercontent.com/u/17235301?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbajorek","html_url":"https://github.com/mattbajorek","followers_url":"https://api.github.com/users/mattbajorek/followers","following_url":"https://api.github.com/users/mattbajorek/following{/other_user}","gists_url":"https://api.github.com/users/mattbajorek/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbajorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbajorek/subscriptions","organizations_url":"https://api.github.com/users/mattbajorek/orgs","repos_url":"https://api.github.com/users/mattbajorek/repos","events_url":"https://api.github.com/users/mattbajorek/events{/privacy}","received_events_url":"https://api.github.com/users/mattbajorek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T21:08:06Z","updated_at":"2016-12-01T21:17:14Z","closed_at":null,"body":"I have been reading the description and can not find any information explaining optimized and not optimized.  Would anybody be able to provide some helpful information or direction to information.  Thanks!"},"comment":{"url":"https://api.github.com/repos/davidmarkclements/0x/issues/comments/264297836","html_url":"https://github.com/davidmarkclements/0x/issues/58#issuecomment-264297836","issue_url":"https://api.github.com/repos/davidmarkclements/0x/issues/58","id":264297836,"user":{"login":"davidmarkclements","id":1190716,"avatar_url":"https://avatars.githubusercontent.com/u/1190716?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmarkclements","html_url":"https://github.com/davidmarkclements","followers_url":"https://api.github.com/users/davidmarkclements/followers","following_url":"https://api.github.com/users/davidmarkclements/following{/other_user}","gists_url":"https://api.github.com/users/davidmarkclements/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmarkclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmarkclements/subscriptions","organizations_url":"https://api.github.com/users/davidmarkclements/orgs","repos_url":"https://api.github.com/users/davidmarkclements/repos","events_url":"https://api.github.com/users/davidmarkclements/events{/privacy}","received_events_url":"https://api.github.com/users/davidmarkclements/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T21:17:14Z","updated_at":"2016-12-01T21:17:14Z","body":"hey @mattbajorek - that's a fair point\r\n\r\nit relates to v8 internals, you have optimized functions (which is different to inlined), and then you have non-optimizable, and also deoptimized. \r\n\r\nOn the flamegraph we can show optimized and not optimized (which is either deopted or not possible to opt)\r\n\r\nv8 has various optimizations it may apply to a function\r\n\r\na simple one is if you're passing numbers into a function v8 assumes that the numbers are 32bit integers - so uses smi's (small integers) - the moment a number that surpasses 32bit capacity is passed to the function, the function will deoptimize (and may possibly reopt if all subsequent numbers are 64bit) \r\n\r\nanother example is polymorphism, v8 watches for function inputs, and if the type of input is consistent it can optimize the function in a certain way - however if the type keeps changing, the function will not be optimizable \r\n\r\nYou can use the `--trace-opt` and `--trace-deopt` flags with node to get detailed trace output"}}
{"actor":{"display_login":"davidmarkclements"}}