{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments/66289655","id":66289655,"diff_hunk":"@@ -275,6 +275,17 @@ protected Credential constructCredentialsFromRequest(final RequestContext contex\n \n             return credential;\n         }\n+        // Construct credential if presented with (username, verification_key)\n+        // This is used when:\n+        //      1. User creates an account\n+        //      2. User resets the password through forgot_password\n+        //      3. User sets password when added as an unregistered contributor\n+        //      4. Other situations\n+        else if (request.getParameter(\"verification_key\") != null) {","path":"cas-server-support-osf/src/main/java/io/cos/cas/authentication/handler/support/OpenScienceFrameworkPrincipalFromRequestRemoteUserNonInteractiveCredentialsAction.java","position":10,"original_position":10,"commit_id":"8ab5b8454790af11a04c66979321c0edcb79f8b6","original_commit_id":"8ab5b8454790af11a04c66979321c0edcb79f8b6","user":{"login":"icereval","id":3111541,"avatar_url":"https://avatars.githubusercontent.com/u/3111541?v=3","gravatar_id":"","url":"https://api.github.com/users/icereval","html_url":"https://github.com/icereval","followers_url":"https://api.github.com/users/icereval/followers","following_url":"https://api.github.com/users/icereval/following{/other_user}","gists_url":"https://api.github.com/users/icereval/gists{/gist_id}","starred_url":"https://api.github.com/users/icereval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icereval/subscriptions","organizations_url":"https://api.github.com/users/icereval/orgs","repos_url":"https://api.github.com/users/icereval/repos","events_url":"https://api.github.com/users/icereval/events{/privacy}","received_events_url":"https://api.github.com/users/icereval/received_events","type":"User","site_admin":false},"body":"Should also add a check for username here.","created_at":"2016-06-08T16:26:29Z","updated_at":"2016-06-08T16:26:29Z","html_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/18#discussion_r66289655","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments/66289655"},"html":{"href":"https://github.com/CenterForOpenScience/cas-overlay/pull/18#discussion_r66289655"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18","id":72903347,"html_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/18","diff_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/18.diff","patch_url":"https://github.com/CenterForOpenScience/cas-overlay/pull/18.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/18","number":18,"state":"open","locked":false,"title":"[Feature] Use CAS for All Authentication","user":{"login":"cslzchen","id":3750414,"avatar_url":"https://avatars.githubusercontent.com/u/3750414?v=3","gravatar_id":"","url":"https://api.github.com/users/cslzchen","html_url":"https://github.com/cslzchen","followers_url":"https://api.github.com/users/cslzchen/followers","following_url":"https://api.github.com/users/cslzchen/following{/other_user}","gists_url":"https://api.github.com/users/cslzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/cslzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslzchen/subscriptions","organizations_url":"https://api.github.com/users/cslzchen/orgs","repos_url":"https://api.github.com/users/cslzchen/repos","events_url":"https://api.github.com/users/cslzchen/events{/privacy}","received_events_url":"https://api.github.com/users/cslzchen/received_events","type":"User","site_admin":false},"body":"### Ticket:\r\nhttps://openscience.atlassian.net/browse/OSF-6438\r\nhttps://openscience.atlassian.net/browse/SEC-26\r\nhttps://openscience.atlassian.net/browse/OSF-6450\r\n\r\n### Changes:\r\n\r\n- Remove auto login from OSF form submission\r\n- Generate credentials from `(username, verification_key)` to log user back in OSF after:\r\n    - reset password through \"forgot password\"\r\n    - set password when added as an unregistered contributor\r\n    - create account\r\n- Improve CAS Login Page\r\n\r\n### Side Effects:\r\n\r\nMust be deployed together with the OSF PR (Coming Soon)","created_at":"2016-06-07T16:05:10Z","updated_at":"2016-06-08T16:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b73fca52957c43b4d3b69d4fd00b1d5097161e94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/18/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/statuses/8ab5b8454790af11a04c66979321c0edcb79f8b6","head":{"label":"cslzchen:fix/cas-for-all","ref":"fix/cas-for-all","sha":"8ab5b8454790af11a04c66979321c0edcb79f8b6","user":{"login":"cslzchen","id":3750414,"avatar_url":"https://avatars.githubusercontent.com/u/3750414?v=3","gravatar_id":"","url":"https://api.github.com/users/cslzchen","html_url":"https://github.com/cslzchen","followers_url":"https://api.github.com/users/cslzchen/followers","following_url":"https://api.github.com/users/cslzchen/following{/other_user}","gists_url":"https://api.github.com/users/cslzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/cslzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslzchen/subscriptions","organizations_url":"https://api.github.com/users/cslzchen/orgs","repos_url":"https://api.github.com/users/cslzchen/repos","events_url":"https://api.github.com/users/cslzchen/events{/privacy}","received_events_url":"https://api.github.com/users/cslzchen/received_events","type":"User","site_admin":false},"repo":{"id":58220600,"name":"cas-overlay","full_name":"cslzchen/cas-overlay","owner":{"login":"cslzchen","id":3750414,"avatar_url":"https://avatars.githubusercontent.com/u/3750414?v=3","gravatar_id":"","url":"https://api.github.com/users/cslzchen","html_url":"https://github.com/cslzchen","followers_url":"https://api.github.com/users/cslzchen/followers","following_url":"https://api.github.com/users/cslzchen/following{/other_user}","gists_url":"https://api.github.com/users/cslzchen/gists{/gist_id}","starred_url":"https://api.github.com/users/cslzchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslzchen/subscriptions","organizations_url":"https://api.github.com/users/cslzchen/orgs","repos_url":"https://api.github.com/users/cslzchen/repos","events_url":"https://api.github.com/users/cslzchen/events{/privacy}","received_events_url":"https://api.github.com/users/cslzchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cslzchen/cas-overlay","description":"Center for Open Science CAS Overlay","fork":true,"url":"https://api.github.com/repos/cslzchen/cas-overlay","forks_url":"https://api.github.com/repos/cslzchen/cas-overlay/forks","keys_url":"https://api.github.com/repos/cslzchen/cas-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cslzchen/cas-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cslzchen/cas-overlay/teams","hooks_url":"https://api.github.com/repos/cslzchen/cas-overlay/hooks","issue_events_url":"https://api.github.com/repos/cslzchen/cas-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/cslzchen/cas-overlay/events","assignees_url":"https://api.github.com/repos/cslzchen/cas-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/cslzchen/cas-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/cslzchen/cas-overlay/tags","blobs_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cslzchen/cas-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/cslzchen/cas-overlay/languages","stargazers_url":"https://api.github.com/repos/cslzchen/cas-overlay/stargazers","contributors_url":"https://api.github.com/repos/cslzchen/cas-overlay/contributors","subscribers_url":"https://api.github.com/repos/cslzchen/cas-overlay/subscribers","subscription_url":"https://api.github.com/repos/cslzchen/cas-overlay/subscription","commits_url":"https://api.github.com/repos/cslzchen/cas-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/cslzchen/cas-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/cslzchen/cas-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/cslzchen/cas-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/cslzchen/cas-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/cslzchen/cas-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cslzchen/cas-overlay/merges","archive_url":"https://api.github.com/repos/cslzchen/cas-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cslzchen/cas-overlay/downloads","issues_url":"https://api.github.com/repos/cslzchen/cas-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/cslzchen/cas-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/cslzchen/cas-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/cslzchen/cas-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cslzchen/cas-overlay/labels{/name}","releases_url":"https://api.github.com/repos/cslzchen/cas-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/cslzchen/cas-overlay/deployments","created_at":"2016-05-06T16:32:49Z","updated_at":"2016-05-06T16:32:51Z","pushed_at":"2016-06-07T15:51:35Z","git_url":"git://github.com/cslzchen/cas-overlay.git","ssh_url":"git@github.com:cslzchen/cas-overlay.git","clone_url":"https://github.com/cslzchen/cas-overlay.git","svn_url":"https://github.com/cslzchen/cas-overlay","homepage":"","size":751,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"8de7ecffedd6160405208786b0e6485de0a371ec","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":33820054,"name":"cas-overlay","full_name":"CenterForOpenScience/cas-overlay","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/cas-overlay","description":"Center for Open Science CAS Overlay","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay","forks_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/deployments","created_at":"2015-04-12T14:29:46Z","updated_at":"2016-03-08T23:01:16Z","pushed_at":"2016-06-07T16:05:10Z","git_url":"git://github.com/CenterForOpenScience/cas-overlay.git","ssh_url":"git@github.com:CenterForOpenScience/cas-overlay.git","clone_url":"https://github.com/CenterForOpenScience/cas-overlay.git","svn_url":"https://github.com/CenterForOpenScience/cas-overlay","homepage":"","size":733,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18"},"html":{"href":"https://github.com/CenterForOpenScience/cas-overlay/pull/18"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/18"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/cas-overlay/statuses/8ab5b8454790af11a04c66979321c0edcb79f8b6"}}}}
{"actor":{"display_login":"icereval"}}