{"action":"created","issue":{"url":"https://api.github.com/repos/impactlab/eemeter/issues/133","repository_url":"https://api.github.com/repos/impactlab/eemeter","labels_url":"https://api.github.com/repos/impactlab/eemeter/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/impactlab/eemeter/issues/133/comments","events_url":"https://api.github.com/repos/impactlab/eemeter/issues/133/events","html_url":"https://github.com/impactlab/eemeter/pull/133","id":160799564,"number":133,"title":"Add flake8","user":{"login":"crolfe","id":2155576,"avatar_url":"https://avatars.githubusercontent.com/u/2155576?v=3","gravatar_id":"","url":"https://api.github.com/users/crolfe","html_url":"https://github.com/crolfe","followers_url":"https://api.github.com/users/crolfe/followers","following_url":"https://api.github.com/users/crolfe/following{/other_user}","gists_url":"https://api.github.com/users/crolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/crolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crolfe/subscriptions","organizations_url":"https://api.github.com/users/crolfe/orgs","repos_url":"https://api.github.com/users/crolfe/repos","events_url":"https://api.github.com/users/crolfe/events{/privacy}","received_events_url":"https://api.github.com/users/crolfe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-17T02:21:53Z","updated_at":"2016-06-17T20:30:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/impactlab/eemeter/pulls/133","html_url":"https://github.com/impactlab/eemeter/pull/133","diff_url":"https://github.com/impactlab/eemeter/pull/133.diff","patch_url":"https://github.com/impactlab/eemeter/pull/133.patch"},"body":"This change adds `pytest-flake8` as a dev dependency, which integrates with pytest and checks the code for pep8 issues every time the tests are run.  There are two config files that have been added:\r\n\r\n- `.flake8` is a config file for `flake8` itself, which can be run on its own by running `flake8 <path>`\r\n- `pytest.ini` is a config file for pytest, which contains configuration for `pytest-flake8`\r\n\r\nIn addition to adding this plugin, I have gone through the repo and fixed all of the issues reported by flake8, which makes up the bulk of this pull request.  Note: I used `autopep8` to fix a lot of the whitespace issues, which in some cases resulted in some funky formatting.  I tried to fix these as I came across them, but there could be a few more still lurking, so let me know if there's anything that looks odd.\r\n\r\nAnother thing I did that doesn't appear to be caught by `flake8` is import ordering.  I can't remember if it is a PEP8 thing or just a convention, but best practice for import ordering usually looks something like this:\r\n\r\n`import <standard library package>`\r\n`from <standard library> import <module>`\r\n\r\n`import <third party library>`\r\n`from <third party library> import <module>`\r\n\r\n`import <project package>`\r\n`from <project> import <module>`"},"comment":{"url":"https://api.github.com/repos/impactlab/eemeter/issues/comments/226874012","html_url":"https://github.com/impactlab/eemeter/pull/133#issuecomment-226874012","issue_url":"https://api.github.com/repos/impactlab/eemeter/issues/133","id":226874012,"user":{"login":"philngo","id":2687443,"avatar_url":"https://avatars.githubusercontent.com/u/2687443?v=3","gravatar_id":"","url":"https://api.github.com/users/philngo","html_url":"https://github.com/philngo","followers_url":"https://api.github.com/users/philngo/followers","following_url":"https://api.github.com/users/philngo/following{/other_user}","gists_url":"https://api.github.com/users/philngo/gists{/gist_id}","starred_url":"https://api.github.com/users/philngo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philngo/subscriptions","organizations_url":"https://api.github.com/users/philngo/orgs","repos_url":"https://api.github.com/users/philngo/repos","events_url":"https://api.github.com/users/philngo/events{/privacy}","received_events_url":"https://api.github.com/users/philngo/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T20:30:40Z","updated_at":"2016-06-17T20:30:40Z","body":"Nice! This is a greatly helpful set of changes. A couple of thoughts:\r\n1) It appears that the tests are broken on travis, so we should get those working before we can merge this in. Appears to have something to do with test fixtures.\r\n2) I noticed that you did a bit of refactoring with large fixture and yaml files. Those are good changes, but see my line note.\r\n3) autopep8 did some funky stuff on a couple of lines, pointed out in a line note.\r\n4) All that ^^ said, the v0.4 release in the next couple of weeks will have enough breaking and merge-conflict type changes that I'm reluctant to have you spend much more time on this in the immediate future, for fear that the vast majority of work will be made somewhat irrelevant by the big upcoming changes. So out of respect for your valuable time, let's hold off on further changes and the above fixes until things on that front stabilize a bit."}}
{"actor":{"display_login":"philngo"}}