{"action":"created","issue":{"url":"https://api.github.com/repos/numenta/nupic.core/issues/1036","repository_url":"https://api.github.com/repos/numenta/nupic.core","labels_url":"https://api.github.com/repos/numenta/nupic.core/issues/1036/labels{/name}","comments_url":"https://api.github.com/repos/numenta/nupic.core/issues/1036/comments","events_url":"https://api.github.com/repos/numenta/nupic.core/issues/1036/events","html_url":"https://github.com/numenta/nupic.core/issues/1036","id":170360590,"number":1036,"title":"SP test for compute/ overall functionality is missing! ","user":{"login":"breznak","id":2166111,"avatar_url":"https://avatars.githubusercontent.com/u/2166111?v=3","gravatar_id":"","url":"https://api.github.com/users/breznak","html_url":"https://github.com/breznak","followers_url":"https://api.github.com/users/breznak/followers","following_url":"https://api.github.com/users/breznak/following{/other_user}","gists_url":"https://api.github.com/users/breznak/gists{/gist_id}","starred_url":"https://api.github.com/users/breznak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breznak/subscriptions","organizations_url":"https://api.github.com/users/breznak/orgs","repos_url":"https://api.github.com/users/breznak/repos","events_url":"https://api.github.com/users/breznak/events{/privacy}","received_events_url":"https://api.github.com/users/breznak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/numenta/nupic.core/labels/subject:algorithms","name":"subject:algorithms","color":"c7def8"},{"url":"https://api.github.com/repos/numenta/nupic.core/labels/type:tests","name":"type:tests","color":"006b75"},{"url":"https://api.github.com/repos/numenta/nupic.core/labels/under-review","name":"under-review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-10T08:27:57Z","updated_at":"2016-08-10T14:38:22Z","closed_at":null,"body":"In a local branch I managed to break SP's functionality with all unit-tests passing! \r\nThe tests check individual methods, but we should also verify that, the most important functionality, complex `compute()` is correct. \r\n\r\nI don't know if a simple, artificial test should be written, or the functionality of `Hello_SP_TP` , or AD in #890 can be turned into a test-case?\r\n\r\nDesired: SP.compute() is tested"},"comment":{"url":"https://api.github.com/repos/numenta/nupic.core/issues/comments/238887268","html_url":"https://github.com/numenta/nupic.core/issues/1036#issuecomment-238887268","issue_url":"https://api.github.com/repos/numenta/nupic.core/issues/1036","id":238887268,"user":{"login":"rhyolight","id":15566,"avatar_url":"https://avatars.githubusercontent.com/u/15566?v=3","gravatar_id":"","url":"https://api.github.com/users/rhyolight","html_url":"https://github.com/rhyolight","followers_url":"https://api.github.com/users/rhyolight/followers","following_url":"https://api.github.com/users/rhyolight/following{/other_user}","gists_url":"https://api.github.com/users/rhyolight/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyolight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyolight/subscriptions","organizations_url":"https://api.github.com/users/rhyolight/orgs","repos_url":"https://api.github.com/users/rhyolight/repos","events_url":"https://api.github.com/users/rhyolight/events{/privacy}","received_events_url":"https://api.github.com/users/rhyolight/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T14:38:22Z","updated_at":"2016-08-10T14:38:22Z","body":"Seems like a legit proposal to ensure that the `compute` method is directly covered by unit tests. I marked as under-review because I want @scottpurdy or @mrcslws to confirm. I believe sometimes core functional is tested in nupic python tests. "}}
{"actor":{"display_login":"rhyolight"}}