{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/79288025","id":79288025,"diff_hunk":"@@ -13,6 +13,10 @@ Watchdog::Watchdog(v8::Isolate* isolate, uint64_t ms) : isolate_(isolate),\n   loop_ = new uv_loop_t;\n   CHECK(loop_);\n   rc = uv_loop_init(loop_);\n+  if (rc != 0) {\n+       FatalError(\"node::Watchdog::Watchdog()\",\n+               \"Failed to initialize loop. Maybe the file limit is reached?\");","path":"src/node_watchdog.cc","position":null,"original_position":6,"commit_id":"738323309828a8fd2fdb98cd37bee48924b323c5","original_commit_id":"33e05fae22e44b754f16db1bb051d2e6651f27ca","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"body":"Maybe we could then check if the file limit was actually reached?","created_at":"2016-09-17T17:14:25Z","updated_at":"2016-09-17T17:14:25Z","html_url":"https://github.com/nodejs/node/pull/8634#discussion_r79288025","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/8634","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/79288025"},"html":{"href":"https://github.com/nodejs/node/pull/8634#discussion_r79288025"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/8634"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8634","id":85679985,"html_url":"https://github.com/nodejs/node/pull/8634","diff_url":"https://github.com/nodejs/node/pull/8634.diff","patch_url":"https://github.com/nodejs/node/pull/8634.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8634","number":8634,"state":"open","locked":false,"title":"Watchdog: add error message if we abort","user":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars.githubusercontent.com/u/101553?v=3","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nwatchdog\r\n\r\n##### Description of change\r\nAdd an error message if we abort because uv_init_loop fails.\r\n\r\nFixes https://github.com/nodejs/node/issues/8555","created_at":"2016-09-17T17:02:06Z","updated_at":"2016-09-17T17:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64fa458ff5b17b88941c2382df45255275913a47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8634/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8634/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8634/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/738323309828a8fd2fdb98cd37bee48924b323c5","head":{"label":"fhinkel:i8555","ref":"i8555","sha":"738323309828a8fd2fdb98cd37bee48924b323c5","user":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars.githubusercontent.com/u/101553?v=3","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"repo":{"id":44396185,"name":"node","full_name":"fhinkel/node","owner":{"login":"fhinkel","id":101553,"avatar_url":"https://avatars.githubusercontent.com/u/101553?v=3","gravatar_id":"","url":"https://api.github.com/users/fhinkel","html_url":"https://github.com/fhinkel","followers_url":"https://api.github.com/users/fhinkel/followers","following_url":"https://api.github.com/users/fhinkel/following{/other_user}","gists_url":"https://api.github.com/users/fhinkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fhinkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhinkel/subscriptions","organizations_url":"https://api.github.com/users/fhinkel/orgs","repos_url":"https://api.github.com/users/fhinkel/repos","events_url":"https://api.github.com/users/fhinkel/events{/privacy}","received_events_url":"https://api.github.com/users/fhinkel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhinkel/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/fhinkel/node","forks_url":"https://api.github.com/repos/fhinkel/node/forks","keys_url":"https://api.github.com/repos/fhinkel/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhinkel/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhinkel/node/teams","hooks_url":"https://api.github.com/repos/fhinkel/node/hooks","issue_events_url":"https://api.github.com/repos/fhinkel/node/issues/events{/number}","events_url":"https://api.github.com/repos/fhinkel/node/events","assignees_url":"https://api.github.com/repos/fhinkel/node/assignees{/user}","branches_url":"https://api.github.com/repos/fhinkel/node/branches{/branch}","tags_url":"https://api.github.com/repos/fhinkel/node/tags","blobs_url":"https://api.github.com/repos/fhinkel/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhinkel/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhinkel/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhinkel/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhinkel/node/statuses/{sha}","languages_url":"https://api.github.com/repos/fhinkel/node/languages","stargazers_url":"https://api.github.com/repos/fhinkel/node/stargazers","contributors_url":"https://api.github.com/repos/fhinkel/node/contributors","subscribers_url":"https://api.github.com/repos/fhinkel/node/subscribers","subscription_url":"https://api.github.com/repos/fhinkel/node/subscription","commits_url":"https://api.github.com/repos/fhinkel/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhinkel/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhinkel/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhinkel/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhinkel/node/contents/{+path}","compare_url":"https://api.github.com/repos/fhinkel/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhinkel/node/merges","archive_url":"https://api.github.com/repos/fhinkel/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhinkel/node/downloads","issues_url":"https://api.github.com/repos/fhinkel/node/issues{/number}","pulls_url":"https://api.github.com/repos/fhinkel/node/pulls{/number}","milestones_url":"https://api.github.com/repos/fhinkel/node/milestones{/number}","notifications_url":"https://api.github.com/repos/fhinkel/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhinkel/node/labels{/name}","releases_url":"https://api.github.com/repos/fhinkel/node/releases{/id}","deployments_url":"https://api.github.com/repos/fhinkel/node/deployments","created_at":"2015-10-16T16:08:10Z","updated_at":"2016-05-06T08:49:54Z","pushed_at":"2016-09-17T17:09:08Z","git_url":"git://github.com/fhinkel/node.git","ssh_url":"git@github.com:fhinkel/node.git","clone_url":"https://github.com/fhinkel/node.git","svn_url":"https://github.com/fhinkel/node","homepage":"https://nodejs.org","size":219516,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"2a2ec9dbc3375cd1b8be58fb2ed522247474bc20","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-17T16:33:36Z","pushed_at":"2016-09-17T17:09:09Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":303414,"stargazers_count":26768,"watchers_count":26768,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4282,"mirror_url":null,"open_issues_count":842,"forks":4282,"open_issues":842,"watchers":26768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8634"},"html":{"href":"https://github.com/nodejs/node/pull/8634"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8634"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8634/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8634/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8634/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/738323309828a8fd2fdb98cd37bee48924b323c5"}}}}
{"actor":{"display_login":"Fishrock123"}}