{"action":"created","issue":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/24","repository_url":"https://api.github.com/repos/openjournals/joss-reviews","labels_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/24/comments","events_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/24/events","html_url":"https://github.com/openjournals/joss-reviews/issues/24","id":157118569,"number":24,"title":"Submission: corner.py: Scatterplot matrices in Python","user":{"login":"whedon","id":18508068,"avatar_url":"https://avatars.githubusercontent.com/u/18508068?v=3","gravatar_id":"","url":"https://api.github.com/users/whedon","html_url":"https://github.com/whedon","followers_url":"https://api.github.com/users/whedon/followers","following_url":"https://api.github.com/users/whedon/following{/other_user}","gists_url":"https://api.github.com/users/whedon/gists{/gist_id}","starred_url":"https://api.github.com/users/whedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whedon/subscriptions","organizations_url":"https://api.github.com/users/whedon/orgs","repos_url":"https://api.github.com/users/whedon/repos","events_url":"https://api.github.com/users/whedon/events{/privacy}","received_events_url":"https://api.github.com/users/whedon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openjournals/joss-reviews/labels/review","name":"review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-27T02:39:45Z","updated_at":"2016-06-08T13:42:18Z","closed_at":null,"body":"**Submitting author:** @dfm (<a href=\"http://orcid.org/0000-0002-9328-5652\">Daniel Foreman-Mackey</a>)\r\n**Repository:** <a href=\"https://github.com/dfm/corner.py\" target =\"_blank\">https://github.com/dfm/corner.py</a>\r\n**Version:** v2.0.0\r\n**Archive:** <a href=\"http://dx.doi.org/10.5281/zenodo.53155\" target =\"_blank\">http://dx.doi.org/10.5281/zenodo.53155</a>\r\n\r\n## Status\r\n\r\n[![status](http://joss.theoj.org/papers/960cad70e806f6fc9760888d64dc2c72/status.svg)](http://joss.theoj.org/papers/960cad70e806f6fc9760888d64dc2c72)\r\n\r\nStatus badge code:\r\n\r\n```\r\nHTML: <a href=\"http://joss.theoj.org/papers/960cad70e806f6fc9760888d64dc2c72\"><img src=\"http://joss.theoj.org/papers/960cad70e806f6fc9760888d64dc2c72/status.svg\"></a>\r\nMarkdown: [![status](http://joss.theoj.org/papers/960cad70e806f6fc9760888d64dc2c72/status.svg)](http://joss.theoj.org/papers/960cad70e806f6fc9760888d64dc2c72)\r\n```\r\n\r\n## Reviewer questions\r\n\r\n### General checks\r\n\r\n- [x] **Repository:** Is the source code for this software available at the <a target=\"_blank\" href=\"https://github.com/dfm/corner.py\">repository url</a>?\r\n- [x] **License:** Does the repository contain a plain-text LICENSE file with the contents of an [OSI approved](https://opensource.org/licenses/alphabetical) software license?\r\n- [x] **Version:** Does the release version given match the GitHub release (v2.0.0)?\r\n- [x] **Archive:** Does the <a target=\"_blank\" href=\"http://dx.doi.org/10.5281/zenodo.53155\">software archive</a> resolve?\r\n\r\n### Functionality\r\n\r\n- [x] **Installation:** Does installation proceed as outlined in the documentation?\r\n- [x] **Functionality:** Have the functional claims of the software been confirmed?\r\n- [ ] **Performance:** Have the performance claims of the software been confirmed?\r\n\r\n### Documentation\r\n\r\n- [x] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [x] **Installation instructions:** Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.\r\n- [x] **Example usage:** Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).\r\n- [x] **Functionality documentation:** Is the functionality of the software documented to a satisfactory level (e.g. API method documentation)?\r\n- [x] **Automated tests:** Are there automated tests or manual steps described so that the function of the software can be verified?\r\n- [x] **Community guidelines:** Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support\r\n\r\n### Software paper\r\n\r\nPaper PDF: [10.21105.joss.00024.pdf](https://github.com/openjournals/joss-reviews/files/285677/10.21105.joss.00024.pdf)\r\n\r\n- [x] **Authors:** Does the `paper.md` file include a list of authors with their affiliations?\r\n- [ ] **A statement of need:** Do the authors clearly state what problems the software is designed to solve and who the target audience is?\r\n- [ ] **References:** Do all archival references that should have a DOI list one (e.g. papers, datasets, software)?\r\n"},"comment":{"url":"https://api.github.com/repos/openjournals/joss-reviews/issues/comments/224592344","html_url":"https://github.com/openjournals/joss-reviews/issues/24#issuecomment-224592344","issue_url":"https://api.github.com/repos/openjournals/joss-reviews/issues/24","id":224592344,"user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T13:42:18Z","updated_at":"2016-06-08T13:42:18Z","body":"@dfm `quantile` is exported in the `__all__`, but is not in the built docs nor is it's docstring numpydoc format.  Was this intended to be part of the public API?\r\n\r\nThis paper makes no performance claims, how does that get handled?\r\n\r\nThe mpl paper has a DOI http://dx.doi.org/10.1109/MCSE.2007.55\r\n\r\nThe citation to the ADS search results seems strange to me, I think it is ok to assert an 'also known as' with out citation.\r\n\r\n"}}
{"actor":{"display_login":"tacaswell"}}