{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/comments/62126527","id":62126527,"diff_hunk":"@@ -86,13 +89,28 @@ module.exports = function (url, version, dest, cb) {\n       }\n     });\n \n-    src.pipe(gunzip).pipe(tar.Extract({ path: dest }))\n-      .on('end',function () {\n+    src.pipe(gunzip).pipe(tar.Extract({path: dest}))\n+      .on('end', function() {\n         console.log(url + ' is now extracted to ' + dest);\n-        cb && cb();\n-      }).on('error', function (error) {\n-        cb && cb(error);\n-      });\n+        var err;\n+        var home = homedir();\n+        var icDir = path.join(home, 'oracle-instant-client');\n+        if (!fs.existsSync(icDir)) {\n+          try {\n+            fse.copySync(path.join(dest, 'instantclient'), icDir,","path":"lib/download.js","position":35,"original_position":35,"commit_id":"dbe79679d12e0956855d8c48547be68ff94b7e03","original_commit_id":"dbe79679d12e0956855d8c48547be68ff94b7e03","user":{"login":"rmg","id":17978,"avatar_url":"https://avatars.githubusercontent.com/u/17978?v=3","gravatar_id":"","url":"https://api.github.com/users/rmg","html_url":"https://github.com/rmg","followers_url":"https://api.github.com/users/rmg/followers","following_url":"https://api.github.com/users/rmg/following{/other_user}","gists_url":"https://api.github.com/users/rmg/gists{/gist_id}","starred_url":"https://api.github.com/users/rmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmg/subscriptions","organizations_url":"https://api.github.com/users/rmg/orgs","repos_url":"https://api.github.com/users/rmg/repos","events_url":"https://api.github.com/users/rmg/events{/privacy}","received_events_url":"https://api.github.com/users/rmg/received_events","type":"User","site_admin":false},"body":"Is there a reason not to do this check before downloading and just extracting the tar stream directly into the destination if it doesn't already exist?","created_at":"2016-05-04T22:35:36Z","updated_at":"2016-05-04T22:35:36Z","html_url":"https://github.com/strongloop/loopback-oracle-installer/pull/11#discussion_r62126527","pull_request_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/comments/62126527"},"html":{"href":"https://github.com/strongloop/loopback-oracle-installer/pull/11#discussion_r62126527"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11","id":67971561,"html_url":"https://github.com/strongloop/loopback-oracle-installer/pull/11","diff_url":"https://github.com/strongloop/loopback-oracle-installer/pull/11.diff","patch_url":"https://github.com/strongloop/loopback-oracle-installer/pull/11.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/11","number":11,"state":"open","locked":false,"title":"[SEMVER-MAJOR] Switch to oracledb","user":{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars.githubusercontent.com/u/540892?v=3","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},"body":"Connect to strongloop/loopback-connector-oracle#62","created_at":"2016-04-26T22:56:13Z","updated_at":"2016-05-04T22:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0066facf3db8e966a332e98a104bb2204efbd2e","assignee":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars.githubusercontent.com/u/1140553?v=3","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/11/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/statuses/dbe79679d12e0956855d8c48547be68ff94b7e03","head":{"label":"strongloop:feature/switch-to-oracledb","ref":"feature/switch-to-oracledb","sha":"dbe79679d12e0956855d8c48547be68ff94b7e03","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":11030765,"name":"loopback-oracle-installer","full_name":"strongloop/loopback-oracle-installer","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-oracle-installer","description":"Loopback Oracle Installer","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-oracle-installer","forks_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/deployments","created_at":"2013-06-28T15:57:21Z","updated_at":"2016-01-24T17:45:57Z","pushed_at":"2016-05-04T21:57:15Z","git_url":"git://github.com/strongloop/loopback-oracle-installer.git","ssh_url":"git@github.com:strongloop/loopback-oracle-installer.git","clone_url":"https://github.com/strongloop/loopback-oracle-installer.git","svn_url":"https://github.com/strongloop/loopback-oracle-installer","homepage":"","size":82,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"ae5aa1ec16c1f6ab81b4ee82998c4151ec5b0564","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":11030765,"name":"loopback-oracle-installer","full_name":"strongloop/loopback-oracle-installer","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-oracle-installer","description":"Loopback Oracle Installer","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-oracle-installer","forks_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-oracle-installer/deployments","created_at":"2013-06-28T15:57:21Z","updated_at":"2016-01-24T17:45:57Z","pushed_at":"2016-05-04T21:57:15Z","git_url":"git://github.com/strongloop/loopback-oracle-installer.git","ssh_url":"git@github.com:strongloop/loopback-oracle-installer.git","clone_url":"https://github.com/strongloop/loopback-oracle-installer.git","svn_url":"https://github.com/strongloop/loopback-oracle-installer","homepage":"","size":82,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11"},"html":{"href":"https://github.com/strongloop/loopback-oracle-installer/pull/11"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/11"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-oracle-installer/statuses/dbe79679d12e0956855d8c48547be68ff94b7e03"}}}}