{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/676","repository_url":"https://api.github.com/repos/square/p2","labels_url":"https://api.github.com/repos/square/p2/issues/676/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/676/comments","events_url":"https://api.github.com/repos/square/p2/issues/676/events","html_url":"https://github.com/square/p2/pull/676","id":182643903,"number":676,"title":"preparer: disable HTTP/2 by setting TLSNextProto to empty map","user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-12T21:53:50Z","updated_at":"2016-10-12T22:47:15Z","closed_at":"2016-10-12T22:28:14Z","pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/676","html_url":"https://github.com/square/p2/pull/676","diff_url":"https://github.com/square/p2/pull/676.diff","patch_url":"https://github.com/square/p2/pull/676.patch"},"body":"As noted in https://golang.org/doc/go1.6#http2.\r\n\r\nIt would appear from https://golang.org/pkg/net/http/#Transport that we\r\nwere inadvertently enabling HTTP/2 when we did not want to."},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/253361702","html_url":"https://github.com/square/p2/pull/676#issuecomment-253361702","issue_url":"https://api.github.com/repos/square/p2/issues/676","id":253361702,"user":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T22:47:15Z","updated_at":"2016-10-12T22:47:15Z","body":"While this change does add the documented way to disable HTTP/2, I don't think the preparer was using it due to the [undocumented ways](https://go.googlesource.com/go/+/go1.7/src/net/http/transport.go#191) in which it would be disabled, namely by setting a custom `Dial` and `TLSClientConfig`."}}
{"actor":{"display_login":"bwester"}}