{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10521","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10521/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10521/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10521/events","html_url":"https://github.com/joomla/joomla-cms/pull/10521","id":155141227,"number":10521,"title":"[js message system] Correct js messages class","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-16T22:59:28Z","updated_at":"2016-05-17T09:53:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10521","html_url":"https://github.com/joomla/joomla-cms/pull/10521","diff_url":"https://github.com/joomla/joomla-cms/pull/10521.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10521.patch"},"body":"#### Summary of Changes\r\n\r\nSimple PR to correct the colors and titles of the js messages.\r\n\r\n##### Before\r\n![image](https://cloud.githubusercontent.com/assets/9630530/15306281/1bd7cafa-1bc1-11e6-8b4b-b52d533e3c7f.png)\r\n\r\n##### After\r\n![image](https://cloud.githubusercontent.com/assets/9630530/15306280/196281a2-1bc1-11e6-9ceb-3d30d7e4c44f.png)\r\n\r\n#### Testing Instructions\r\n\r\n- Go to isis/protostar index.php and add this code\r\n```php\r\n// JS Messages\r\nJText::script('MESSAGE');\r\nJText::script('ERROR');\r\nJText::script('NOTICE');\r\nJText::script('WARNING');\r\n\r\nJFactory::getDocument()->addScriptDeclaration(\"\r\njQuery(document).ready(function() {\r\n\tvar messages = {\r\n\t\t'message': ['JS Success Message 1', 'JS Success Message 2'],\r\n\t\t'error': ['JS Error Message 1', 'JS Error Message 2'],\r\n\t\t'notice': ['JS Notice Message 1', 'JS Notice Message 2'],\r\n\t\t'warning': ['JS Warning Message 1', 'JS Warning Message 2']\r\n\t};\r\n\tJoomla.renderMessages(messages);\r\n});\");\r\n```\r\n- Now run any isis/protostar page. You'll see the \"Before\" scenario\r\n- Apply patch\r\n- Repeat step 2 (clear browser cache). You will see the \"After\" scenario.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/219671691","html_url":"https://github.com/joomla/joomla-cms/pull/10521#issuecomment-219671691","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10521","id":219671691,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T09:53:42Z","updated_at":"2016-05-17T09:53:42Z","body":"thanks for testing @brianteeman @infograf768 !"}}