{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/blktap/pulls/comments/83595633","pull_request_review_id":4428608,"id":83595633,"diff_hunk":"@@ -196,5 +232,15 @@ tap_ctl_spawn(void)\n \tif (id < 0)\n \t\tEPRINTF(\"get_id failed, child %d err %d\\n\", child, errno);\n \n+\t/* Put the tapdisk in a cgroup slice (best-effort) */\n+\tif (!slice) {\n+#ifdef TAP_CTL_USE_DEFAULT_CGROUP_SLICE","path":"control/tap-ctl-spawn.c","position":59,"original_position":59,"commit_id":"48bf92e99aea35305ef87b43d5d8cd6bc641ca9d","original_commit_id":"48bf92e99aea35305ef87b43d5d8cd6bc641ca9d","user":{"login":"jjd27","id":623641,"avatar_url":"https://avatars.githubusercontent.com/u/623641?v=3","gravatar_id":"","url":"https://api.github.com/users/jjd27","html_url":"https://github.com/jjd27","followers_url":"https://api.github.com/users/jjd27/followers","following_url":"https://api.github.com/users/jjd27/following{/other_user}","gists_url":"https://api.github.com/users/jjd27/gists{/gist_id}","starred_url":"https://api.github.com/users/jjd27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjd27/subscriptions","organizations_url":"https://api.github.com/users/jjd27/orgs","repos_url":"https://api.github.com/users/jjd27/repos","events_url":"https://api.github.com/users/jjd27/events{/privacy}","received_events_url":"https://api.github.com/users/jjd27/received_events","type":"User","site_admin":false},"body":"Yes, the intention was for it to be a compile-time switch. So if some people don't like the \"move to the default slice\" being the default behaviour they can easily disable it in one place. I felt this was more appropriate for now than adding another command-line option, especially as there are no users that will use that at present.","created_at":"2016-10-17T08:25:23Z","updated_at":"2016-10-17T08:25:23Z","html_url":"https://github.com/xapi-project/blktap/pull/230#discussion_r83595633","pull_request_url":"https://api.github.com/repos/xapi-project/blktap/pulls/230","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/blktap/pulls/comments/83595633"},"html":{"href":"https://github.com/xapi-project/blktap/pull/230#discussion_r83595633"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/blktap/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/blktap/pulls/230","id":89224229,"html_url":"https://github.com/xapi-project/blktap/pull/230","diff_url":"https://github.com/xapi-project/blktap/pull/230.diff","patch_url":"https://github.com/xapi-project/blktap/pull/230.patch","issue_url":"https://api.github.com/repos/xapi-project/blktap/issues/230","number":230,"state":"open","locked":false,"title":"CA-225067: tap_ctl_{spawn,create}: move tapdisk to cgroup slice","user":{"login":"jjd27","id":623641,"avatar_url":"https://avatars.githubusercontent.com/u/623641?v=3","gravatar_id":"","url":"https://api.github.com/users/jjd27","html_url":"https://github.com/jjd27","followers_url":"https://api.github.com/users/jjd27/followers","following_url":"https://api.github.com/users/jjd27/following{/other_user}","gists_url":"https://api.github.com/users/jjd27/gists{/gist_id}","starred_url":"https://api.github.com/users/jjd27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjd27/subscriptions","organizations_url":"https://api.github.com/users/jjd27/orgs","repos_url":"https://api.github.com/users/jjd27/repos","events_url":"https://api.github.com/users/jjd27/events{/privacy}","received_events_url":"https://api.github.com/users/jjd27/received_events","type":"User","site_admin":false},"body":"The '-c' option allows the user to specify which cgroup slice the new tapdisk\r\nprocess should be put in. If unspecified, it is moved to the default cgroup\r\nslice.\r\n\r\nThis avoids the need to rely on the cgrulesengd daemon which fails to do its job\r\nif the time it takes to write to the tasks file exceeds the lifespan of the\r\nparent tapdisk (before it forks and exits). On a 4.4 kernel, it can take several\r\nmilliseconds to write to this file, so that kind of failure is very likely.\r\n\r\nSigned-off-by: Jonathan Davies <jonathan.davies@citrix.com>","created_at":"2016-10-13T15:21:10Z","updated_at":"2016-10-17T08:25:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbd6d59ce1a9292bc13ab5867a075315818ea994","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/blktap/pulls/230/commits","review_comments_url":"https://api.github.com/repos/xapi-project/blktap/pulls/230/comments","review_comment_url":"https://api.github.com/repos/xapi-project/blktap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/blktap/issues/230/comments","statuses_url":"https://api.github.com/repos/xapi-project/blktap/statuses/48bf92e99aea35305ef87b43d5d8cd6bc641ca9d","head":{"label":"jjd27:ca225067","ref":"ca225067","sha":"48bf92e99aea35305ef87b43d5d8cd6bc641ca9d","user":{"login":"jjd27","id":623641,"avatar_url":"https://avatars.githubusercontent.com/u/623641?v=3","gravatar_id":"","url":"https://api.github.com/users/jjd27","html_url":"https://github.com/jjd27","followers_url":"https://api.github.com/users/jjd27/followers","following_url":"https://api.github.com/users/jjd27/following{/other_user}","gists_url":"https://api.github.com/users/jjd27/gists{/gist_id}","starred_url":"https://api.github.com/users/jjd27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjd27/subscriptions","organizations_url":"https://api.github.com/users/jjd27/orgs","repos_url":"https://api.github.com/users/jjd27/repos","events_url":"https://api.github.com/users/jjd27/events{/privacy}","received_events_url":"https://api.github.com/users/jjd27/received_events","type":"User","site_admin":false},"repo":{"id":30651434,"name":"blktap","full_name":"jjd27/blktap","owner":{"login":"jjd27","id":623641,"avatar_url":"https://avatars.githubusercontent.com/u/623641?v=3","gravatar_id":"","url":"https://api.github.com/users/jjd27","html_url":"https://github.com/jjd27","followers_url":"https://api.github.com/users/jjd27/followers","following_url":"https://api.github.com/users/jjd27/following{/other_user}","gists_url":"https://api.github.com/users/jjd27/gists{/gist_id}","starred_url":"https://api.github.com/users/jjd27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjd27/subscriptions","organizations_url":"https://api.github.com/users/jjd27/orgs","repos_url":"https://api.github.com/users/jjd27/repos","events_url":"https://api.github.com/users/jjd27/events{/privacy}","received_events_url":"https://api.github.com/users/jjd27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjd27/blktap","description":"blktap, vhd stuff","fork":true,"url":"https://api.github.com/repos/jjd27/blktap","forks_url":"https://api.github.com/repos/jjd27/blktap/forks","keys_url":"https://api.github.com/repos/jjd27/blktap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjd27/blktap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjd27/blktap/teams","hooks_url":"https://api.github.com/repos/jjd27/blktap/hooks","issue_events_url":"https://api.github.com/repos/jjd27/blktap/issues/events{/number}","events_url":"https://api.github.com/repos/jjd27/blktap/events","assignees_url":"https://api.github.com/repos/jjd27/blktap/assignees{/user}","branches_url":"https://api.github.com/repos/jjd27/blktap/branches{/branch}","tags_url":"https://api.github.com/repos/jjd27/blktap/tags","blobs_url":"https://api.github.com/repos/jjd27/blktap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjd27/blktap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjd27/blktap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjd27/blktap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjd27/blktap/statuses/{sha}","languages_url":"https://api.github.com/repos/jjd27/blktap/languages","stargazers_url":"https://api.github.com/repos/jjd27/blktap/stargazers","contributors_url":"https://api.github.com/repos/jjd27/blktap/contributors","subscribers_url":"https://api.github.com/repos/jjd27/blktap/subscribers","subscription_url":"https://api.github.com/repos/jjd27/blktap/subscription","commits_url":"https://api.github.com/repos/jjd27/blktap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjd27/blktap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjd27/blktap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjd27/blktap/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjd27/blktap/contents/{+path}","compare_url":"https://api.github.com/repos/jjd27/blktap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjd27/blktap/merges","archive_url":"https://api.github.com/repos/jjd27/blktap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjd27/blktap/downloads","issues_url":"https://api.github.com/repos/jjd27/blktap/issues{/number}","pulls_url":"https://api.github.com/repos/jjd27/blktap/pulls{/number}","milestones_url":"https://api.github.com/repos/jjd27/blktap/milestones{/number}","notifications_url":"https://api.github.com/repos/jjd27/blktap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjd27/blktap/labels{/name}","releases_url":"https://api.github.com/repos/jjd27/blktap/releases{/id}","deployments_url":"https://api.github.com/repos/jjd27/blktap/deployments","created_at":"2015-02-11T14:27:23Z","updated_at":"2015-02-11T14:31:02Z","pushed_at":"2016-10-13T15:20:23Z","git_url":"git://github.com/jjd27/blktap.git","ssh_url":"git@github.com:jjd27/blktap.git","clone_url":"https://github.com/jjd27/blktap.git","svn_url":"https://github.com/jjd27/blktap","homepage":"","size":3714,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"a8aef5c31598a49dfad8bbe2bff89554a92fe2b8","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":2273467,"name":"blktap","full_name":"xapi-project/blktap","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/blktap","description":"blktap, vhd stuff","fork":false,"url":"https://api.github.com/repos/xapi-project/blktap","forks_url":"https://api.github.com/repos/xapi-project/blktap/forks","keys_url":"https://api.github.com/repos/xapi-project/blktap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/blktap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/blktap/teams","hooks_url":"https://api.github.com/repos/xapi-project/blktap/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/blktap/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/blktap/events","assignees_url":"https://api.github.com/repos/xapi-project/blktap/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/blktap/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/blktap/tags","blobs_url":"https://api.github.com/repos/xapi-project/blktap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/blktap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/blktap/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/blktap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/blktap/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/blktap/languages","stargazers_url":"https://api.github.com/repos/xapi-project/blktap/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/blktap/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/blktap/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/blktap/subscription","commits_url":"https://api.github.com/repos/xapi-project/blktap/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/blktap/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/blktap/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/blktap/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/blktap/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/blktap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/blktap/merges","archive_url":"https://api.github.com/repos/xapi-project/blktap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/blktap/downloads","issues_url":"https://api.github.com/repos/xapi-project/blktap/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/blktap/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/blktap/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/blktap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/blktap/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/blktap/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/blktap/deployments","created_at":"2011-08-26T10:15:05Z","updated_at":"2016-10-04T13:50:53Z","pushed_at":"2016-10-13T15:21:10Z","git_url":"git://github.com/xapi-project/blktap.git","ssh_url":"git@github.com:xapi-project/blktap.git","clone_url":"https://github.com/xapi-project/blktap.git","svn_url":"https://github.com/xapi-project/blktap","homepage":"","size":4478,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":73,"forks":54,"open_issues":73,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/blktap/pulls/230"},"html":{"href":"https://github.com/xapi-project/blktap/pull/230"},"issue":{"href":"https://api.github.com/repos/xapi-project/blktap/issues/230"},"comments":{"href":"https://api.github.com/repos/xapi-project/blktap/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/blktap/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/blktap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/blktap/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/blktap/statuses/48bf92e99aea35305ef87b43d5d8cd6bc641ca9d"}}}}
{"actor":{"display_login":"jjd27"}}