{"action":"created","issue":{"url":"https://api.github.com/repos/pfsense/pfsense/issues/2902","repository_url":"https://api.github.com/repos/pfsense/pfsense","labels_url":"https://api.github.com/repos/pfsense/pfsense/issues/2902/labels{/name}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/2902/comments","events_url":"https://api.github.com/repos/pfsense/pfsense/issues/2902/events","html_url":"https://github.com/pfsense/pfsense/pull/2902","id":150525634,"number":2902,"title":"RAM Disk Management","user":{"login":"NOYB","id":1977521,"avatar_url":"https://avatars.githubusercontent.com/u/1977521?v=3","gravatar_id":"","url":"https://api.github.com/users/NOYB","html_url":"https://github.com/NOYB","followers_url":"https://api.github.com/users/NOYB/followers","following_url":"https://api.github.com/users/NOYB/following{/other_user}","gists_url":"https://api.github.com/users/NOYB/gists{/gist_id}","starred_url":"https://api.github.com/users/NOYB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NOYB/subscriptions","organizations_url":"https://api.github.com/users/NOYB/orgs","repos_url":"https://api.github.com/users/NOYB/repos","events_url":"https://api.github.com/users/NOYB/events{/privacy}","received_events_url":"https://api.github.com/users/NOYB/received_events","type":"User","site_admin":false},"labels":[{"id":264533790,"url":"https://api.github.com/repos/pfsense/pfsense/labels/CLA","name":"CLA","color":"009800","default":false},{"id":343835390,"url":"https://api.github.com/repos/pfsense/pfsense/labels/Pending%20review/testing","name":"Pending review/testing","color":"207de5","default":false}],"state":"open","locked":false,"assignee":{"login":"rbgarga","id":149872,"avatar_url":"https://avatars.githubusercontent.com/u/149872?v=3","gravatar_id":"","url":"https://api.github.com/users/rbgarga","html_url":"https://github.com/rbgarga","followers_url":"https://api.github.com/users/rbgarga/followers","following_url":"https://api.github.com/users/rbgarga/following{/other_user}","gists_url":"https://api.github.com/users/rbgarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rbgarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbgarga/subscriptions","organizations_url":"https://api.github.com/users/rbgarga/orgs","repos_url":"https://api.github.com/users/rbgarga/repos","events_url":"https://api.github.com/users/rbgarga/events{/privacy}","received_events_url":"https://api.github.com/users/rbgarga/received_events","type":"User","site_admin":false},"assignees":[{"login":"rbgarga","id":149872,"avatar_url":"https://avatars.githubusercontent.com/u/149872?v=3","gravatar_id":"","url":"https://api.github.com/users/rbgarga","html_url":"https://github.com/rbgarga","followers_url":"https://api.github.com/users/rbgarga/followers","following_url":"https://api.github.com/users/rbgarga/following{/other_user}","gists_url":"https://api.github.com/users/rbgarga/gists{/gist_id}","starred_url":"https://api.github.com/users/rbgarga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbgarga/subscriptions","organizations_url":"https://api.github.com/users/rbgarga/orgs","repos_url":"https://api.github.com/users/rbgarga/repos","events_url":"https://api.github.com/users/rbgarga/events{/privacy}","received_events_url":"https://api.github.com/users/rbgarga/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-04-23T07:04:44Z","updated_at":"2016-12-27T21:53:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/2902","html_url":"https://github.com/pfsense/pfsense/pull/2902","diff_url":"https://github.com/pfsense/pfsense/pull/2902.diff","patch_url":"https://github.com/pfsense/pfsense/pull/2902.patch"},"body":"1) Treat the RAM disk more like a permanent storage device with content managed/restored by the system and made available at boot up, before needed by any services.\n a) Handle saving and restoring RAM disk content at reboot/shutdown/boot centrally in more of a system manged fashion.\n b) If it's in the RAM disk store it gets restored early in the pfSense startup so it's available for whatever needs to use it.\n c) Services utilizing RAM disk don't need to be aware that their content is on a RAM disk, and handling content restore individually.\n\n2) Has the benefit of eliminating some issues with the previous code as well.  Such as...\n a) Restoring RRD multiple times during boot, potentially at least 3 times, by rc.newwanip, rc.newwanipv6, and rc.boot.  Some even overlapping.\n b) Not removing the backups if/when not being utilized.  Such as on a full install with the RAM disk option not enabled.\n c) Eliminate some duplicate code.\n\n3) Looking forward.\n a) The more centrally system managed approach may crack the door open to making it easier to include some of the logs in the RAM disk store.  As well as anything else that may be useful/desirable to retain in the RAM disk across reboots.\n"},"comment":{"url":"https://api.github.com/repos/pfsense/pfsense/issues/comments/269387880","html_url":"https://github.com/pfsense/pfsense/pull/2902#issuecomment-269387880","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/2902","id":269387880,"user":{"login":"NOYB","id":1977521,"avatar_url":"https://avatars.githubusercontent.com/u/1977521?v=3","gravatar_id":"","url":"https://api.github.com/users/NOYB","html_url":"https://github.com/NOYB","followers_url":"https://api.github.com/users/NOYB/followers","following_url":"https://api.github.com/users/NOYB/following{/other_user}","gists_url":"https://api.github.com/users/NOYB/gists{/gist_id}","starred_url":"https://api.github.com/users/NOYB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NOYB/subscriptions","organizations_url":"https://api.github.com/users/NOYB/orgs","repos_url":"https://api.github.com/users/NOYB/repos","events_url":"https://api.github.com/users/NOYB/events{/privacy}","received_events_url":"https://api.github.com/users/NOYB/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T21:53:09Z","updated_at":"2016-12-27T21:53:09Z","body":"> I haven't tested it yet, but it seems OK from a quick read-through, aside from the items I have noted.\r\n\r\nMade the requested changes."}}
{"actor":{"display_login":"NOYB"}}