{"action":"created","comment":{"url":"https://api.github.com/repos/Southern/node-x509/pulls/comments/78330633","id":78330633,"diff_hunk":"@@ -45,6 +45,85 @@ std::string parse_args(const Nan::FunctionCallbackInfo<v8::Value>& info) {\n   return *String::Utf8Value(info[0]->ToString());\n }\n \n+\n+\n+NAN_METHOD(verify) {\n+  Nan::HandleScope scope;\n+  OpenSSL_add_all_algorithms();","path":"src/x509.cc","position":17,"original_position":17,"commit_id":"0353b2b4e9d464638a5c7e1a2c264d559a483bdb","original_commit_id":"0353b2b4e9d464638a5c7e1a2c264d559a483bdb","user":{"login":"lambrojos","id":1526036,"avatar_url":"https://avatars.githubusercontent.com/u/1526036?v=3","gravatar_id":"","url":"https://api.github.com/users/lambrojos","html_url":"https://github.com/lambrojos","followers_url":"https://api.github.com/users/lambrojos/followers","following_url":"https://api.github.com/users/lambrojos/following{/other_user}","gists_url":"https://api.github.com/users/lambrojos/gists{/gist_id}","starred_url":"https://api.github.com/users/lambrojos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambrojos/subscriptions","organizations_url":"https://api.github.com/users/lambrojos/orgs","repos_url":"https://api.github.com/users/lambrojos/repos","events_url":"https://api.github.com/users/lambrojos/events{/privacy}","received_events_url":"https://api.github.com/users/lambrojos/received_events","type":"User","site_admin":false},"body":"Ok, I'll remove the line and add a warning in the docs","created_at":"2016-09-12T08:17:56Z","updated_at":"2016-09-12T08:17:56Z","html_url":"https://github.com/Southern/node-x509/pull/38#discussion_r78330633","pull_request_url":"https://api.github.com/repos/Southern/node-x509/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/Southern/node-x509/pulls/comments/78330633"},"html":{"href":"https://github.com/Southern/node-x509/pull/38#discussion_r78330633"},"pull_request":{"href":"https://api.github.com/repos/Southern/node-x509/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/Southern/node-x509/pulls/38","id":81689218,"html_url":"https://github.com/Southern/node-x509/pull/38","diff_url":"https://github.com/Southern/node-x509/pull/38.diff","patch_url":"https://github.com/Southern/node-x509/pull/38.patch","issue_url":"https://api.github.com/repos/Southern/node-x509/issues/38","number":38,"state":"open","locked":false,"title":"Basic validation against certificate authority","user":{"login":"lambrojos","id":1526036,"avatar_url":"https://avatars.githubusercontent.com/u/1526036?v=3","gravatar_id":"","url":"https://api.github.com/users/lambrojos","html_url":"https://github.com/lambrojos","followers_url":"https://api.github.com/users/lambrojos/followers","following_url":"https://api.github.com/users/lambrojos/following{/other_user}","gists_url":"https://api.github.com/users/lambrojos/gists{/gist_id}","starred_url":"https://api.github.com/users/lambrojos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambrojos/subscriptions","organizations_url":"https://api.github.com/users/lambrojos/orgs","repos_url":"https://api.github.com/users/lambrojos/repos","events_url":"https://api.github.com/users/lambrojos/events{/privacy}","received_events_url":"https://api.github.com/users/lambrojos/received_events","type":"User","site_admin":false},"body":"Hello, \r\nI needed to verify a certificate against a chain of CA certificates, I adapted code from http://fm4dd.com/openssl/certverify.htm, and now I am trying to contribute back, I think that verification of a certificate is an operation that goes well alongside parsing.\r\n\r\nI also threw  in some basic typings for typescript.. should I have done another PR?","created_at":"2016-08-17T18:06:41Z","updated_at":"2016-09-12T08:17:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75c0c9e6a6d4d280a15a0b826b8bfb3415d8b71b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Southern/node-x509/pulls/38/commits","review_comments_url":"https://api.github.com/repos/Southern/node-x509/pulls/38/comments","review_comment_url":"https://api.github.com/repos/Southern/node-x509/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Southern/node-x509/issues/38/comments","statuses_url":"https://api.github.com/repos/Southern/node-x509/statuses/0353b2b4e9d464638a5c7e1a2c264d559a483bdb","head":{"label":"linkmesrl:verify","ref":"verify","sha":"0353b2b4e9d464638a5c7e1a2c264d559a483bdb","user":{"login":"linkmesrl","id":4397094,"avatar_url":"https://avatars.githubusercontent.com/u/4397094?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmesrl","html_url":"https://github.com/linkmesrl","followers_url":"https://api.github.com/users/linkmesrl/followers","following_url":"https://api.github.com/users/linkmesrl/following{/other_user}","gists_url":"https://api.github.com/users/linkmesrl/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmesrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmesrl/subscriptions","organizations_url":"https://api.github.com/users/linkmesrl/orgs","repos_url":"https://api.github.com/users/linkmesrl/repos","events_url":"https://api.github.com/users/linkmesrl/events{/privacy}","received_events_url":"https://api.github.com/users/linkmesrl/received_events","type":"Organization","site_admin":false},"repo":{"id":64849792,"name":"node-x509","full_name":"linkmesrl/node-x509","owner":{"login":"linkmesrl","id":4397094,"avatar_url":"https://avatars.githubusercontent.com/u/4397094?v=3","gravatar_id":"","url":"https://api.github.com/users/linkmesrl","html_url":"https://github.com/linkmesrl","followers_url":"https://api.github.com/users/linkmesrl/followers","following_url":"https://api.github.com/users/linkmesrl/following{/other_user}","gists_url":"https://api.github.com/users/linkmesrl/gists{/gist_id}","starred_url":"https://api.github.com/users/linkmesrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkmesrl/subscriptions","organizations_url":"https://api.github.com/users/linkmesrl/orgs","repos_url":"https://api.github.com/users/linkmesrl/repos","events_url":"https://api.github.com/users/linkmesrl/events{/privacy}","received_events_url":"https://api.github.com/users/linkmesrl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkmesrl/node-x509","description":"Simple X509 certificate parser.","fork":true,"url":"https://api.github.com/repos/linkmesrl/node-x509","forks_url":"https://api.github.com/repos/linkmesrl/node-x509/forks","keys_url":"https://api.github.com/repos/linkmesrl/node-x509/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkmesrl/node-x509/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkmesrl/node-x509/teams","hooks_url":"https://api.github.com/repos/linkmesrl/node-x509/hooks","issue_events_url":"https://api.github.com/repos/linkmesrl/node-x509/issues/events{/number}","events_url":"https://api.github.com/repos/linkmesrl/node-x509/events","assignees_url":"https://api.github.com/repos/linkmesrl/node-x509/assignees{/user}","branches_url":"https://api.github.com/repos/linkmesrl/node-x509/branches{/branch}","tags_url":"https://api.github.com/repos/linkmesrl/node-x509/tags","blobs_url":"https://api.github.com/repos/linkmesrl/node-x509/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkmesrl/node-x509/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkmesrl/node-x509/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkmesrl/node-x509/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkmesrl/node-x509/statuses/{sha}","languages_url":"https://api.github.com/repos/linkmesrl/node-x509/languages","stargazers_url":"https://api.github.com/repos/linkmesrl/node-x509/stargazers","contributors_url":"https://api.github.com/repos/linkmesrl/node-x509/contributors","subscribers_url":"https://api.github.com/repos/linkmesrl/node-x509/subscribers","subscription_url":"https://api.github.com/repos/linkmesrl/node-x509/subscription","commits_url":"https://api.github.com/repos/linkmesrl/node-x509/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkmesrl/node-x509/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkmesrl/node-x509/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkmesrl/node-x509/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkmesrl/node-x509/contents/{+path}","compare_url":"https://api.github.com/repos/linkmesrl/node-x509/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkmesrl/node-x509/merges","archive_url":"https://api.github.com/repos/linkmesrl/node-x509/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkmesrl/node-x509/downloads","issues_url":"https://api.github.com/repos/linkmesrl/node-x509/issues{/number}","pulls_url":"https://api.github.com/repos/linkmesrl/node-x509/pulls{/number}","milestones_url":"https://api.github.com/repos/linkmesrl/node-x509/milestones{/number}","notifications_url":"https://api.github.com/repos/linkmesrl/node-x509/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkmesrl/node-x509/labels{/name}","releases_url":"https://api.github.com/repos/linkmesrl/node-x509/releases{/id}","deployments_url":"https://api.github.com/repos/linkmesrl/node-x509/deployments","created_at":"2016-08-03T13:50:52Z","updated_at":"2016-08-03T13:50:53Z","pushed_at":"2016-09-04T15:05:46Z","git_url":"git://github.com/linkmesrl/node-x509.git","ssh_url":"git@github.com:linkmesrl/node-x509.git","clone_url":"https://github.com/linkmesrl/node-x509.git","svn_url":"https://github.com/linkmesrl/node-x509","homepage":"","size":103,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Southern:master","ref":"master","sha":"a4acc34df751a6ad396e67e29e94002e68d64b3c","user":{"login":"Southern","id":887133,"avatar_url":"https://avatars.githubusercontent.com/u/887133?v=3","gravatar_id":"","url":"https://api.github.com/users/Southern","html_url":"https://github.com/Southern","followers_url":"https://api.github.com/users/Southern/followers","following_url":"https://api.github.com/users/Southern/following{/other_user}","gists_url":"https://api.github.com/users/Southern/gists{/gist_id}","starred_url":"https://api.github.com/users/Southern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Southern/subscriptions","organizations_url":"https://api.github.com/users/Southern/orgs","repos_url":"https://api.github.com/users/Southern/repos","events_url":"https://api.github.com/users/Southern/events{/privacy}","received_events_url":"https://api.github.com/users/Southern/received_events","type":"User","site_admin":false},"repo":{"id":11107995,"name":"node-x509","full_name":"Southern/node-x509","owner":{"login":"Southern","id":887133,"avatar_url":"https://avatars.githubusercontent.com/u/887133?v=3","gravatar_id":"","url":"https://api.github.com/users/Southern","html_url":"https://github.com/Southern","followers_url":"https://api.github.com/users/Southern/followers","following_url":"https://api.github.com/users/Southern/following{/other_user}","gists_url":"https://api.github.com/users/Southern/gists{/gist_id}","starred_url":"https://api.github.com/users/Southern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Southern/subscriptions","organizations_url":"https://api.github.com/users/Southern/orgs","repos_url":"https://api.github.com/users/Southern/repos","events_url":"https://api.github.com/users/Southern/events{/privacy}","received_events_url":"https://api.github.com/users/Southern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Southern/node-x509","description":"Simple X509 certificate parser.","fork":false,"url":"https://api.github.com/repos/Southern/node-x509","forks_url":"https://api.github.com/repos/Southern/node-x509/forks","keys_url":"https://api.github.com/repos/Southern/node-x509/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Southern/node-x509/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Southern/node-x509/teams","hooks_url":"https://api.github.com/repos/Southern/node-x509/hooks","issue_events_url":"https://api.github.com/repos/Southern/node-x509/issues/events{/number}","events_url":"https://api.github.com/repos/Southern/node-x509/events","assignees_url":"https://api.github.com/repos/Southern/node-x509/assignees{/user}","branches_url":"https://api.github.com/repos/Southern/node-x509/branches{/branch}","tags_url":"https://api.github.com/repos/Southern/node-x509/tags","blobs_url":"https://api.github.com/repos/Southern/node-x509/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Southern/node-x509/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Southern/node-x509/git/refs{/sha}","trees_url":"https://api.github.com/repos/Southern/node-x509/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Southern/node-x509/statuses/{sha}","languages_url":"https://api.github.com/repos/Southern/node-x509/languages","stargazers_url":"https://api.github.com/repos/Southern/node-x509/stargazers","contributors_url":"https://api.github.com/repos/Southern/node-x509/contributors","subscribers_url":"https://api.github.com/repos/Southern/node-x509/subscribers","subscription_url":"https://api.github.com/repos/Southern/node-x509/subscription","commits_url":"https://api.github.com/repos/Southern/node-x509/commits{/sha}","git_commits_url":"https://api.github.com/repos/Southern/node-x509/git/commits{/sha}","comments_url":"https://api.github.com/repos/Southern/node-x509/comments{/number}","issue_comment_url":"https://api.github.com/repos/Southern/node-x509/issues/comments{/number}","contents_url":"https://api.github.com/repos/Southern/node-x509/contents/{+path}","compare_url":"https://api.github.com/repos/Southern/node-x509/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Southern/node-x509/merges","archive_url":"https://api.github.com/repos/Southern/node-x509/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Southern/node-x509/downloads","issues_url":"https://api.github.com/repos/Southern/node-x509/issues{/number}","pulls_url":"https://api.github.com/repos/Southern/node-x509/pulls{/number}","milestones_url":"https://api.github.com/repos/Southern/node-x509/milestones{/number}","notifications_url":"https://api.github.com/repos/Southern/node-x509/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Southern/node-x509/labels{/name}","releases_url":"https://api.github.com/repos/Southern/node-x509/releases{/id}","deployments_url":"https://api.github.com/repos/Southern/node-x509/deployments","created_at":"2013-07-01T21:44:26Z","updated_at":"2016-08-29T18:44:43Z","pushed_at":"2016-09-04T15:05:46Z","git_url":"git://github.com/Southern/node-x509.git","ssh_url":"git@github.com:Southern/node-x509.git","clone_url":"https://github.com/Southern/node-x509.git","svn_url":"https://github.com/Southern/node-x509","homepage":"","size":125,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":4,"forks":20,"open_issues":4,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Southern/node-x509/pulls/38"},"html":{"href":"https://github.com/Southern/node-x509/pull/38"},"issue":{"href":"https://api.github.com/repos/Southern/node-x509/issues/38"},"comments":{"href":"https://api.github.com/repos/Southern/node-x509/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/Southern/node-x509/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/Southern/node-x509/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Southern/node-x509/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/Southern/node-x509/statuses/0353b2b4e9d464638a5c7e1a2c264d559a483bdb"}}}}
{"actor":{"display_login":"lambrojos"}}