{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/354","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/354/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/354/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/354/events","html_url":"https://github.com/vufind-org/vufind/pull/354","id":71372005,"number":354,"title":"Improved author indexing","user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-04-27T19:01:12Z","updated_at":"2016-03-16T16:35:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/354","html_url":"https://github.com/vufind-org/vufind/pull/354","diff_url":"https://github.com/vufind-org/vufind/pull/354.diff","patch_url":"https://github.com/vufind-org/vufind/pull/354.patch"},"body":"This PR ports (and improves) the patches from https://vufind.org/jira/browse/VUFIND-542 to VuFind 2.\r\n\r\nTODO list:\r\n- [x] Adjust Solr schema\r\n- [x] Implement custom BeanShell indexing\r\n- [x] Port BeanShell into SolrMarc core\r\n- [x] Update PHP code to correctly handle values in new schema\r\n  - [x] Improve getDeduplicatedAuthors()\r\n  - [x] Update record drivers to use getPrimaryAuthors() instead of getPrimaryAuthor().\r\n  - [x] Solve issues related to getHighlightedAuthor()\r\n  - [x] Eliminate as many getPrimaryAuthor() calls as possible\r\n- [x] Update XSLT indexing to account for new/changed fields\r\n- [x] Resolve implications of renaming authorStr to author_facet (URL integrity, etc.)\r\n- [x] Allow .ini setting to be overridden by parameter in author-modification.bsh.\r\n- [x] Deal with author initials BeanShell patch\r\n- [x] Prevent deduplication of authors / relators due to Set vs. List issues.\r\n- [x] Add PHP code for dealing with author relators.\r\n- [x] Finish translation of relator text domain.\r\n- [ ] Arrange for SolrMarc release containing new custom code (now merged to SolrMarc's master and simply awaiting release)."},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/197413845","html_url":"https://github.com/vufind-org/vufind/pull/354#issuecomment-197413845","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/354","id":197413845,"user":{"login":"lahmann","id":7081217,"avatar_url":"https://avatars.githubusercontent.com/u/7081217?v=3","gravatar_id":"","url":"https://api.github.com/users/lahmann","html_url":"https://github.com/lahmann","followers_url":"https://api.github.com/users/lahmann/followers","following_url":"https://api.github.com/users/lahmann/following{/other_user}","gists_url":"https://api.github.com/users/lahmann/gists{/gist_id}","starred_url":"https://api.github.com/users/lahmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lahmann/subscriptions","organizations_url":"https://api.github.com/users/lahmann/orgs","repos_url":"https://api.github.com/users/lahmann/repos","events_url":"https://api.github.com/users/lahmann/events{/privacy}","received_events_url":"https://api.github.com/users/lahmann/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T16:35:47Z","updated_at":"2016-03-16T16:35:47Z","body":"Demian, thanks for checking the translations and correcting the cases of some terms, I have no objections so far.\r\n\r\nRegarding the upper/lowercase terms, unfortunately this is somehow critical - if we go with normalizing all the relator terms/codes it implies that the terms need to be normalized when being indexed. When using the beanshell script this should not be an issue, but if relator terms are read from the Marc fields in VuFind one would have to normalize those as well in order to translate them appropriately. Maybe that's too hypothetical but I would rather leave those case-differing relator terms in the language files just to make sure every known code variation is covered (not implying any specific preprocessing). \r\n\r\nRegarding the differing translations for case-differing relator term \"Beiträger\" this is definitely wrong - I will talk to my colleague tomorrow which of the translations is the correct one (although I'm pretty sure it's \"Contributor\" - but better be sure that sorry :)). Thanks for spotting this one though!"}}