{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/228","repository_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration","labels_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/228/comments","events_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/228/events","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/228","id":161715330,"number":228,"title":"send thurloe notification to user upon account creation","user":{"login":"MatthewBemis","id":7257391,"avatar_url":"https://avatars.githubusercontent.com/u/7257391?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewBemis","html_url":"https://github.com/MatthewBemis","followers_url":"https://api.github.com/users/MatthewBemis/followers","following_url":"https://api.github.com/users/MatthewBemis/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBemis/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBemis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBemis/subscriptions","organizations_url":"https://api.github.com/users/MatthewBemis/orgs","repos_url":"https://api.github.com/users/MatthewBemis/repos","events_url":"https://api.github.com/users/MatthewBemis/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBemis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"MatthewBemis","id":7257391,"avatar_url":"https://avatars.githubusercontent.com/u/7257391?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewBemis","html_url":"https://github.com/MatthewBemis","followers_url":"https://api.github.com/users/MatthewBemis/followers","following_url":"https://api.github.com/users/MatthewBemis/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBemis/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBemis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBemis/subscriptions","organizations_url":"https://api.github.com/users/MatthewBemis/orgs","repos_url":"https://api.github.com/users/MatthewBemis/repos","events_url":"https://api.github.com/users/MatthewBemis/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBemis/received_events","type":"User","site_admin":false},"assignees":[{"login":"MatthewBemis","id":7257391,"avatar_url":"https://avatars.githubusercontent.com/u/7257391?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewBemis","html_url":"https://github.com/MatthewBemis","followers_url":"https://api.github.com/users/MatthewBemis/followers","following_url":"https://api.github.com/users/MatthewBemis/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBemis/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBemis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBemis/subscriptions","organizations_url":"https://api.github.com/users/MatthewBemis/orgs","repos_url":"https://api.github.com/users/MatthewBemis/repos","events_url":"https://api.github.com/users/MatthewBemis/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBemis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-06-22T15:35:00Z","updated_at":"2016-07-01T17:33:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/pulls/228","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/228","diff_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/228.diff","patch_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/228.patch"},"body":"This relates to the following PRs:\r\n\r\nrawls: https://github.com/broadinstitute/rawls/pull/459 (approved)\r\nthurloe: https://github.com/broadinstitute/thurloe/pull/31 (approved)\r\nfirecloud-develop: https://github.com/broadinstitute/firecloud-develop/pull/93 and https://github.com/broadinstitute/firecloud-develop/pull/94\r\n\r\n- [x] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [x] **Submitter**: Make sure Swagger is updated if API changes\r\n- [x] **Submitter**: Make sure documentation for code is complete\r\n- [x] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [x] **Submitter**: Include the JIRA issue number in the PR description\r\n- [x] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [x] **Submitter**: Tell tech lead that the PR exists if s/he wants to look at it\r\n- [x] **Submitter**: Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [x] **LR**: Initial review by LR and others.\r\n- [x] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [ ] **Tech lead**:  sign off\r\n- [ ] **LR**: sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev server still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/comments/230004763","html_url":"https://github.com/broadinstitute/firecloud-orchestration/pull/228#issuecomment-230004763","issue_url":"https://api.github.com/repos/broadinstitute/firecloud-orchestration/issues/228","id":230004763,"user":{"login":"davidangb","id":6041577,"avatar_url":"https://avatars.githubusercontent.com/u/6041577?v=3","gravatar_id":"","url":"https://api.github.com/users/davidangb","html_url":"https://github.com/davidangb","followers_url":"https://api.github.com/users/davidangb/followers","following_url":"https://api.github.com/users/davidangb/following{/other_user}","gists_url":"https://api.github.com/users/davidangb/gists{/gist_id}","starred_url":"https://api.github.com/users/davidangb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidangb/subscriptions","organizations_url":"https://api.github.com/users/davidangb/orgs","repos_url":"https://api.github.com/users/davidangb/repos","events_url":"https://api.github.com/users/davidangb/events{/privacy}","received_events_url":"https://api.github.com/users/davidangb/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T17:33:01Z","updated_at":"2016-07-01T17:33:01Z","body":"I like the notification handling. Potentially set the value in application.conf to null instead of the empty string? Either way is fine.\r\n\r\nAs you said, next step is to use a test.conf file. I don't think you'll need all of Play - probably going to be something like this: http://stackoverflow.com/questions/15399161/how-do-i-specify-a-config-file-with-sbt-0-12-2-for-sbt-test"}}
{"actor":{"display_login":"davidangb"}}