{"action":"created","comment":{"url":"https://api.github.com/repos/Kinto/kinto/pulls/comments/82869965","pull_request_review_id":3746874,"id":82869965,"diff_hunk":"@@ -2,6 +2,7 @@\n from __future__ import unicode_literals\n import unittest\n import os\n+import pytest","path":"tests/core/test_utils.py","position":4,"original_position":4,"commit_id":"bb7ee855b7fa5e887d9df521e471ace206ec5c09","original_commit_id":"11a73dca1a7f9370e468efcddba70db491bb2e1b","user":{"login":"gabisurita","id":4023375,"avatar_url":"https://avatars.githubusercontent.com/u/4023375?v=3","gravatar_id":"","url":"https://api.github.com/users/gabisurita","html_url":"https://github.com/gabisurita","followers_url":"https://api.github.com/users/gabisurita/followers","following_url":"https://api.github.com/users/gabisurita/following{/other_user}","gists_url":"https://api.github.com/users/gabisurita/gists{/gist_id}","starred_url":"https://api.github.com/users/gabisurita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabisurita/subscriptions","organizations_url":"https://api.github.com/users/gabisurita/orgs","repos_url":"https://api.github.com/users/gabisurita/repos","events_url":"https://api.github.com/users/gabisurita/events{/privacy}","received_events_url":"https://api.github.com/users/gabisurita/received_events","type":"User","site_admin":false},"body":"Just a small tip: you shouldn't include pytest here.\r\n\r\nYou can run tests using:\r\n- ``pytest tests/path/to/my/test`` under the virtualenv to run a single test. \r\n- ``pytest tests/`` under the virtualenv to run all the tests.\r\n- ``make tests`` to run all the tests for all python versions, like travis do.\r\n\r\nHope this helps! :)","created_at":"2016-10-11T19:27:14Z","updated_at":"2016-10-11T19:27:44Z","html_url":"https://github.com/Kinto/kinto/pull/860#discussion_r82869965","pull_request_url":"https://api.github.com/repos/Kinto/kinto/pulls/860","_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/comments/82869965"},"html":{"href":"https://github.com/Kinto/kinto/pull/860#discussion_r82869965"},"pull_request":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/860"}}},"pull_request":{"url":"https://api.github.com/repos/Kinto/kinto/pulls/860","id":88784079,"html_url":"https://github.com/Kinto/kinto/pull/860","diff_url":"https://github.com/Kinto/kinto/pull/860.diff","patch_url":"https://github.com/Kinto/kinto/pull/860.patch","issue_url":"https://api.github.com/repos/Kinto/kinto/issues/860","number":860,"state":"open","locked":false,"title":"added a new utils.py to kinto/plugins/ directory, with the parse_reso…","user":{"login":"oronsan","id":19194059,"avatar_url":"https://avatars.githubusercontent.com/u/19194059?v=3","gravatar_id":"","url":"https://api.github.com/users/oronsan","html_url":"https://github.com/oronsan","followers_url":"https://api.github.com/users/oronsan/followers","following_url":"https://api.github.com/users/oronsan/following{/other_user}","gists_url":"https://api.github.com/users/oronsan/gists{/gist_id}","starred_url":"https://api.github.com/users/oronsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oronsan/subscriptions","organizations_url":"https://api.github.com/users/oronsan/orgs","repos_url":"https://api.github.com/users/oronsan/repos","events_url":"https://api.github.com/users/oronsan/events{/privacy}","received_events_url":"https://api.github.com/users/oronsan/received_events","type":"User","site_admin":false},"body":"Fixes #577 \r\n\r\nas per your guidelines, I submitted a pull request, but my contribution is not yet complete\r\nI'll work on all the requirements later today\r\n\r\n- [x] Add documentation.\r\n- [x] Add tests.\r\n- [x] Add a changelog entry.\r\n- [x] Add your name in the contributors file.\r\n- [x] If you changed the HTTP API, update the [API_VERSION](https://github.com/Kinto/kinto/blob/master/kinto/__init__.py#L15) constant and add an API changelog entry [in the docs](https://github.com/Kinto/kinto/blob/master/docs/api/index.rst)\r\n\r\nr? @\r\n\r\n…urce function","created_at":"2016-10-11T07:34:54Z","updated_at":"2016-10-11T19:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16dc2027d0898f5d3202bee9901fe60254667a3f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kinto/kinto/pulls/860/commits","review_comments_url":"https://api.github.com/repos/Kinto/kinto/pulls/860/comments","review_comment_url":"https://api.github.com/repos/Kinto/kinto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinto/kinto/issues/860/comments","statuses_url":"https://api.github.com/repos/Kinto/kinto/statuses/bb7ee855b7fa5e887d9df521e471ace206ec5c09","head":{"label":"oronsan:parse_resource","ref":"parse_resource","sha":"bb7ee855b7fa5e887d9df521e471ace206ec5c09","user":{"login":"oronsan","id":19194059,"avatar_url":"https://avatars.githubusercontent.com/u/19194059?v=3","gravatar_id":"","url":"https://api.github.com/users/oronsan","html_url":"https://github.com/oronsan","followers_url":"https://api.github.com/users/oronsan/followers","following_url":"https://api.github.com/users/oronsan/following{/other_user}","gists_url":"https://api.github.com/users/oronsan/gists{/gist_id}","starred_url":"https://api.github.com/users/oronsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oronsan/subscriptions","organizations_url":"https://api.github.com/users/oronsan/orgs","repos_url":"https://api.github.com/users/oronsan/repos","events_url":"https://api.github.com/users/oronsan/events{/privacy}","received_events_url":"https://api.github.com/users/oronsan/received_events","type":"User","site_admin":false},"repo":{"id":70564634,"name":"kinto","full_name":"oronsan/kinto","owner":{"login":"oronsan","id":19194059,"avatar_url":"https://avatars.githubusercontent.com/u/19194059?v=3","gravatar_id":"","url":"https://api.github.com/users/oronsan","html_url":"https://github.com/oronsan","followers_url":"https://api.github.com/users/oronsan/followers","following_url":"https://api.github.com/users/oronsan/following{/other_user}","gists_url":"https://api.github.com/users/oronsan/gists{/gist_id}","starred_url":"https://api.github.com/users/oronsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oronsan/subscriptions","organizations_url":"https://api.github.com/users/oronsan/orgs","repos_url":"https://api.github.com/users/oronsan/repos","events_url":"https://api.github.com/users/oronsan/events{/privacy}","received_events_url":"https://api.github.com/users/oronsan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oronsan/kinto","description":"A minimalist JSON storage service with synchronisation and sharing abilities.","fork":true,"url":"https://api.github.com/repos/oronsan/kinto","forks_url":"https://api.github.com/repos/oronsan/kinto/forks","keys_url":"https://api.github.com/repos/oronsan/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oronsan/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oronsan/kinto/teams","hooks_url":"https://api.github.com/repos/oronsan/kinto/hooks","issue_events_url":"https://api.github.com/repos/oronsan/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/oronsan/kinto/events","assignees_url":"https://api.github.com/repos/oronsan/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/oronsan/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/oronsan/kinto/tags","blobs_url":"https://api.github.com/repos/oronsan/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oronsan/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oronsan/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/oronsan/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oronsan/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/oronsan/kinto/languages","stargazers_url":"https://api.github.com/repos/oronsan/kinto/stargazers","contributors_url":"https://api.github.com/repos/oronsan/kinto/contributors","subscribers_url":"https://api.github.com/repos/oronsan/kinto/subscribers","subscription_url":"https://api.github.com/repos/oronsan/kinto/subscription","commits_url":"https://api.github.com/repos/oronsan/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/oronsan/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/oronsan/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/oronsan/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/oronsan/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/oronsan/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oronsan/kinto/merges","archive_url":"https://api.github.com/repos/oronsan/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oronsan/kinto/downloads","issues_url":"https://api.github.com/repos/oronsan/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/oronsan/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/oronsan/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/oronsan/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oronsan/kinto/labels{/name}","releases_url":"https://api.github.com/repos/oronsan/kinto/releases{/id}","deployments_url":"https://api.github.com/repos/oronsan/kinto/deployments","created_at":"2016-10-11T06:49:48Z","updated_at":"2016-10-11T06:49:50Z","pushed_at":"2016-10-11T19:20:49Z","git_url":"git://github.com/oronsan/kinto.git","ssh_url":"git@github.com:oronsan/kinto.git","clone_url":"https://github.com/oronsan/kinto.git","svn_url":"https://github.com/oronsan/kinto","homepage":"https://kinto.readthedocs.io","size":8019,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kinto:master","ref":"master","sha":"5d65d61a70cd52da246bf560a4de53e9f3bc29de","user":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"repo":{"id":31315021,"name":"kinto","full_name":"Kinto/kinto","owner":{"login":"Kinto","id":13413813,"avatar_url":"https://avatars.githubusercontent.com/u/13413813?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinto","html_url":"https://github.com/Kinto","followers_url":"https://api.github.com/users/Kinto/followers","following_url":"https://api.github.com/users/Kinto/following{/other_user}","gists_url":"https://api.github.com/users/Kinto/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinto/subscriptions","organizations_url":"https://api.github.com/users/Kinto/orgs","repos_url":"https://api.github.com/users/Kinto/repos","events_url":"https://api.github.com/users/Kinto/events{/privacy}","received_events_url":"https://api.github.com/users/Kinto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinto/kinto","description":"A minimalist JSON storage service with synchronisation and sharing abilities.","fork":false,"url":"https://api.github.com/repos/Kinto/kinto","forks_url":"https://api.github.com/repos/Kinto/kinto/forks","keys_url":"https://api.github.com/repos/Kinto/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinto/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinto/kinto/teams","hooks_url":"https://api.github.com/repos/Kinto/kinto/hooks","issue_events_url":"https://api.github.com/repos/Kinto/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/Kinto/kinto/events","assignees_url":"https://api.github.com/repos/Kinto/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/Kinto/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/Kinto/kinto/tags","blobs_url":"https://api.github.com/repos/Kinto/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinto/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinto/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinto/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinto/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinto/kinto/languages","stargazers_url":"https://api.github.com/repos/Kinto/kinto/stargazers","contributors_url":"https://api.github.com/repos/Kinto/kinto/contributors","subscribers_url":"https://api.github.com/repos/Kinto/kinto/subscribers","subscription_url":"https://api.github.com/repos/Kinto/kinto/subscription","commits_url":"https://api.github.com/repos/Kinto/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinto/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinto/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinto/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinto/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/Kinto/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinto/kinto/merges","archive_url":"https://api.github.com/repos/Kinto/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinto/kinto/downloads","issues_url":"https://api.github.com/repos/Kinto/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/Kinto/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinto/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinto/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinto/kinto/labels{/name}","releases_url":"https://api.github.com/repos/Kinto/kinto/releases{/id}","deployments_url":"https://api.github.com/repos/Kinto/kinto/deployments","created_at":"2015-02-25T13:34:23Z","updated_at":"2016-10-11T16:20:03Z","pushed_at":"2016-10-11T19:20:50Z","git_url":"git://github.com/Kinto/kinto.git","ssh_url":"git@github.com:Kinto/kinto.git","clone_url":"https://github.com/Kinto/kinto.git","svn_url":"https://github.com/Kinto/kinto","homepage":"https://kinto.readthedocs.io","size":13202,"stargazers_count":2894,"watchers_count":2894,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":66,"forks":174,"open_issues":66,"watchers":2894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/860"},"html":{"href":"https://github.com/Kinto/kinto/pull/860"},"issue":{"href":"https://api.github.com/repos/Kinto/kinto/issues/860"},"comments":{"href":"https://api.github.com/repos/Kinto/kinto/issues/860/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/860/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinto/kinto/pulls/860/commits"},"statuses":{"href":"https://api.github.com/repos/Kinto/kinto/statuses/bb7ee855b7fa5e887d9df521e471ace206ec5c09"}}}}
{"actor":{"display_login":"gabisurita"}}