{"action":"created","comment":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/53480150","id":53480150,"diff_hunk":"@@ -99,6 +100,8 @@ def start(webdriver_name=None, base_url=None, **kwargs):\n         webdriver_name = browser_conf.get('webdriver', 'Firefox')\n     webdriver_class = getattr(webdriver, webdriver_name)\n \n+    webdriver_class.file_detector = UselessFileDetector()","path":"utils/browser.py","position":12,"original_position":12,"commit_id":"bf916a310a37d6c048dc942b74c27cffafc91b15","original_commit_id":"bf916a310a37d6c048dc942b74c27cffafc91b15","user":{"login":"mfalesni","id":2163040,"avatar_url":"https://avatars.githubusercontent.com/u/2163040?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalesni","html_url":"https://github.com/mfalesni","followers_url":"https://api.github.com/users/mfalesni/followers","following_url":"https://api.github.com/users/mfalesni/following{/other_user}","gists_url":"https://api.github.com/users/mfalesni/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalesni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalesni/subscriptions","organizations_url":"https://api.github.com/users/mfalesni/orgs","repos_url":"https://api.github.com/users/mfalesni/repos","events_url":"https://api.github.com/users/mfalesni/events{/privacy}","received_events_url":"https://api.github.com/users/mfalesni/received_events","type":"User","site_admin":false},"body":"So, this cannot work because this assigns the detector to the class, but the webdriver sets its own upon instantiating, so it is necessary to move this to line 152 to assign this to the `browser` variable.\r\n\r\nHowever, by doing this you will paralyze all tests that utilize file uploading, so this is a double edged sword :)","created_at":"2016-02-19T16:11:45Z","updated_at":"2016-02-19T16:11:45Z","html_url":"https://github.com/RedHatQE/cfme_tests/pull/2684#discussion_r53480150","pull_request_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684","_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/53480150"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/2684#discussion_r53480150"},"pull_request":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684"}}},"pull_request":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684","id":59791437,"html_url":"https://github.com/RedHatQE/cfme_tests/pull/2684","diff_url":"https://github.com/RedHatQE/cfme_tests/pull/2684.diff","patch_url":"https://github.com/RedHatQE/cfme_tests/pull/2684.patch","issue_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2684","number":2684,"state":"open","locked":false,"title":"Guard against Selenium trick to replace a string with an uploaded filename","user":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"body":"{{pytest: -v -m smoke}}","created_at":"2016-02-18T12:25:53Z","updated_at":"2016-02-19T16:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed595590a5cd21a0c0469d1845f353970b376324","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684/commits","review_comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684/comments","review_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2684/comments","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/bf916a310a37d6c048dc942b74c27cffafc91b15","head":{"label":"vrutkovs:selenium_file_paths","ref":"selenium_file_paths","sha":"bf916a310a37d6c048dc942b74c27cffafc91b15","user":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"repo":{"id":45546124,"name":"cfme_tests","full_name":"vrutkovs/cfme_tests","owner":{"login":"vrutkovs","id":114501,"avatar_url":"https://avatars.githubusercontent.com/u/114501?v=3","gravatar_id":"","url":"https://api.github.com/users/vrutkovs","html_url":"https://github.com/vrutkovs","followers_url":"https://api.github.com/users/vrutkovs/followers","following_url":"https://api.github.com/users/vrutkovs/following{/other_user}","gists_url":"https://api.github.com/users/vrutkovs/gists{/gist_id}","starred_url":"https://api.github.com/users/vrutkovs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrutkovs/subscriptions","organizations_url":"https://api.github.com/users/vrutkovs/orgs","repos_url":"https://api.github.com/users/vrutkovs/repos","events_url":"https://api.github.com/users/vrutkovs/events{/privacy}","received_events_url":"https://api.github.com/users/vrutkovs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrutkovs/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/vrutkovs/cfme_tests","forks_url":"https://api.github.com/repos/vrutkovs/cfme_tests/forks","keys_url":"https://api.github.com/repos/vrutkovs/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrutkovs/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrutkovs/cfme_tests/teams","hooks_url":"https://api.github.com/repos/vrutkovs/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/vrutkovs/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/vrutkovs/cfme_tests/events","assignees_url":"https://api.github.com/repos/vrutkovs/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/vrutkovs/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/vrutkovs/cfme_tests/tags","blobs_url":"https://api.github.com/repos/vrutkovs/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrutkovs/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrutkovs/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrutkovs/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrutkovs/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/vrutkovs/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/vrutkovs/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/vrutkovs/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/vrutkovs/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/vrutkovs/cfme_tests/subscription","commits_url":"https://api.github.com/repos/vrutkovs/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrutkovs/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrutkovs/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrutkovs/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrutkovs/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/vrutkovs/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrutkovs/cfme_tests/merges","archive_url":"https://api.github.com/repos/vrutkovs/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrutkovs/cfme_tests/downloads","issues_url":"https://api.github.com/repos/vrutkovs/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/vrutkovs/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/vrutkovs/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/vrutkovs/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrutkovs/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/vrutkovs/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/vrutkovs/cfme_tests/deployments","created_at":"2015-11-04T14:59:07Z","updated_at":"2015-11-04T14:59:10Z","pushed_at":"2016-02-19T15:08:05Z","git_url":"git://github.com/vrutkovs/cfme_tests.git","ssh_url":"git@github.com:vrutkovs/cfme_tests.git","clone_url":"https://github.com/vrutkovs/cfme_tests.git","svn_url":"https://github.com/vrutkovs/cfme_tests","homepage":"","size":8484,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatQE:master","ref":"master","sha":"f91a1b1b21a09b0c2b610d42c33fe6e65f2abe99","user":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"cfme_tests","full_name":"RedHatQE/cfme_tests","owner":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatQE/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":false,"url":"https://api.github.com/repos/RedHatQE/cfme_tests","forks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/forks","keys_url":"https://api.github.com/repos/RedHatQE/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatQE/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatQE/cfme_tests/teams","hooks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/events","assignees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatQE/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/tags","blobs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatQE/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscription","commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatQE/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatQE/cfme_tests/merges","archive_url":"https://api.github.com/repos/RedHatQE/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatQE/cfme_tests/downloads","issues_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatQE/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatQE/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatQE/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/RedHatQE/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2016-01-13T15:22:13Z","pushed_at":"2016-02-19T15:52:53Z","git_url":"git://github.com/RedHatQE/cfme_tests.git","ssh_url":"git@github.com:RedHatQE/cfme_tests.git","clone_url":"https://github.com/RedHatQE/cfme_tests.git","svn_url":"https://github.com/RedHatQE/cfme_tests","homepage":"","size":10242,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":87,"forks":42,"open_issues":87,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/2684"},"issue":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2684"},"comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2684/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2684/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/bf916a310a37d6c048dc942b74c27cffafc91b15"}}}}