{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/57996682","id":57996682,"diff_hunk":"@@ -130,21 +134,34 @@ i.e. valid for all architectures (s390, see below)\n - order: /boot, swap, /\n - ext4\n \n-x86-legacy\n-----------\n-- grub boot.img (stage 1) in MBR\n-- install core.img (stage 1.5) in free space between partition table and 1. partition\n-- if there isn't enough free space -> create additional partition\n-- install all grub parts on same disk\n-\n-x86-efi\n--------\n-if system efi partition is already there -> reuse it\n-if not create:\n-- /boot/efi\n-- fat32\n-- size: 33 MB, 200MB\n-- limit: below 2TB\n+## x86-legacy\n+\n+*[this assumes grub will be installed into mbr]*\n+\n+- required size for grub embedding (currently): 84 kB; to be safe, check for >= 256 kB\n+- if dos partition table\n+    - embed in unused space before 1st partition","path":"doc/boot-partition.md","position":67,"original_position":67,"commit_id":"cc5502ecb1d520efbabe68ed15cbd61a104c2135","original_commit_id":"cc5502ecb1d520efbabe68ed15cbd61a104c2135","user":{"login":"WenhuaChang","id":806649,"avatar_url":"https://avatars.githubusercontent.com/u/806649?v=3","gravatar_id":"","url":"https://api.github.com/users/WenhuaChang","html_url":"https://github.com/WenhuaChang","followers_url":"https://api.github.com/users/WenhuaChang/followers","following_url":"https://api.github.com/users/WenhuaChang/following{/other_user}","gists_url":"https://api.github.com/users/WenhuaChang/gists{/gist_id}","starred_url":"https://api.github.com/users/WenhuaChang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WenhuaChang/subscriptions","organizations_url":"https://api.github.com/users/WenhuaChang/orgs","repos_url":"https://api.github.com/users/WenhuaChang/repos","events_url":"https://api.github.com/users/WenhuaChang/events{/privacy}","received_events_url":"https://api.github.com/users/WenhuaChang/received_events","type":"User","site_admin":false},"body":"I think in upstream doc they used the term \"mbr gap\" to that unused space between mbr and 1st partition.","created_at":"2016-03-31T03:22:19Z","updated_at":"2016-03-31T03:22:19Z","html_url":"https://github.com/yast/yast-storage-ng/pull/37#discussion_r57996682","pull_request_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/57996682"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/37#discussion_r57996682"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37","id":64626407,"html_url":"https://github.com/yast/yast-storage-ng/pull/37","diff_url":"https://github.com/yast/yast-storage-ng/pull/37.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/37.patch","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/37","number":37,"state":"open","locked":false,"title":"finalzied x86 boot partition setup doc","user":{"login":"wfeldt","id":927244,"avatar_url":"https://avatars.githubusercontent.com/u/927244?v=3","gravatar_id":"","url":"https://api.github.com/users/wfeldt","html_url":"https://github.com/wfeldt","followers_url":"https://api.github.com/users/wfeldt/followers","following_url":"https://api.github.com/users/wfeldt/following{/other_user}","gists_url":"https://api.github.com/users/wfeldt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfeldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfeldt/subscriptions","organizations_url":"https://api.github.com/users/wfeldt/orgs","repos_url":"https://api.github.com/users/wfeldt/repos","events_url":"https://api.github.com/users/wfeldt/events{/privacy}","received_events_url":"https://api.github.com/users/wfeldt/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-30T13:25:04Z","updated_at":"2016-03-31T03:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5582a4b3f26a9882531e8cfd0a39e3b3ac52db8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37/commits","review_comments_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37/comments","review_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/37/comments","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/cc5502ecb1d520efbabe68ed15cbd61a104c2135","head":{"label":"yast:boot_part_3","ref":"boot_part_3","sha":"cc5502ecb1d520efbabe68ed15cbd61a104c2135","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2016-03-08T15:33:19Z","pushed_at":"2016-03-30T13:25:05Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":365,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"62e9a146e0bc056fea163d95a7472a990850375c","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2016-03-08T15:33:19Z","pushed_at":"2016-03-30T13:25:05Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":365,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/37"},"issue":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/37"},"comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-storage-ng/statuses/cc5502ecb1d520efbabe68ed15cbd61a104c2135"}}}}