{"action":"closed","number":82,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/canon-react/pulls/82","id":62451884,"html_url":"https://github.com/rackerlabs/canon-react/pull/82","diff_url":"https://github.com/rackerlabs/canon-react/pull/82.diff","patch_url":"https://github.com/rackerlabs/canon-react/pull/82.patch","issue_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/82","number":82,"state":"closed","locked":false,"title":"fix(Button): Fix HTML type of Button","user":{"login":"ashimaathri","id":2386539,"avatar_url":"https://avatars.githubusercontent.com/u/2386539?v=3","gravatar_id":"","url":"https://api.github.com/users/ashimaathri","html_url":"https://github.com/ashimaathri","followers_url":"https://api.github.com/users/ashimaathri/followers","following_url":"https://api.github.com/users/ashimaathri/following{/other_user}","gists_url":"https://api.github.com/users/ashimaathri/gists{/gist_id}","starred_url":"https://api.github.com/users/ashimaathri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashimaathri/subscriptions","organizations_url":"https://api.github.com/users/ashimaathri/orgs","repos_url":"https://api.github.com/users/ashimaathri/repos","events_url":"https://api.github.com/users/ashimaathri/events{/privacy}","received_events_url":"https://api.github.com/users/ashimaathri/received_events","type":"User","site_admin":false},"body":"There are only three permissible types for an html button - 'submit',\r\n'reset' and 'button'. Any other type is treated as a 'submit' type. This\r\nleads to unexpected behavior when using a non-submit button inside a\r\nform (Hitting enter triggers the onClick handler of the non-submit\r\nbutton). The correct behavior would be to set the type to 'button' in\r\nthis case and to 'submit' only when the button is intended as the\r\nprimary button of a form.\r\n\r\nThis fixes #81","created_at":"2016-03-10T20:37:36Z","updated_at":"2016-03-10T21:43:38Z","closed_at":"2016-03-10T21:43:38Z","merged_at":null,"merge_commit_sha":"e9a5acec5ada4e3435b0e698f1439dba45a6edd5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/canon-react/pulls/82/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/canon-react/pulls/82/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/canon-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/82/comments","statuses_url":"https://api.github.com/repos/rackerlabs/canon-react/statuses/0e57f74a29d292aa8b738696286ee0afea0e6ba7","head":{"label":"ashimaathri:fix-Button-type","ref":"fix-Button-type","sha":"0e57f74a29d292aa8b738696286ee0afea0e6ba7","user":{"login":"ashimaathri","id":2386539,"avatar_url":"https://avatars.githubusercontent.com/u/2386539?v=3","gravatar_id":"","url":"https://api.github.com/users/ashimaathri","html_url":"https://github.com/ashimaathri","followers_url":"https://api.github.com/users/ashimaathri/followers","following_url":"https://api.github.com/users/ashimaathri/following{/other_user}","gists_url":"https://api.github.com/users/ashimaathri/gists{/gist_id}","starred_url":"https://api.github.com/users/ashimaathri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashimaathri/subscriptions","organizations_url":"https://api.github.com/users/ashimaathri/orgs","repos_url":"https://api.github.com/users/ashimaathri/repos","events_url":"https://api.github.com/users/ashimaathri/events{/privacy}","received_events_url":"https://api.github.com/users/ashimaathri/received_events","type":"User","site_admin":false},"repo":{"id":53613243,"name":"canon-react","full_name":"ashimaathri/canon-react","owner":{"login":"ashimaathri","id":2386539,"avatar_url":"https://avatars.githubusercontent.com/u/2386539?v=3","gravatar_id":"","url":"https://api.github.com/users/ashimaathri","html_url":"https://github.com/ashimaathri","followers_url":"https://api.github.com/users/ashimaathri/followers","following_url":"https://api.github.com/users/ashimaathri/following{/other_user}","gists_url":"https://api.github.com/users/ashimaathri/gists{/gist_id}","starred_url":"https://api.github.com/users/ashimaathri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashimaathri/subscriptions","organizations_url":"https://api.github.com/users/ashimaathri/orgs","repos_url":"https://api.github.com/users/ashimaathri/repos","events_url":"https://api.github.com/users/ashimaathri/events{/privacy}","received_events_url":"https://api.github.com/users/ashimaathri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashimaathri/canon-react","description":"React components for Rackspace's Canon framework","fork":true,"url":"https://api.github.com/repos/ashimaathri/canon-react","forks_url":"https://api.github.com/repos/ashimaathri/canon-react/forks","keys_url":"https://api.github.com/repos/ashimaathri/canon-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashimaathri/canon-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashimaathri/canon-react/teams","hooks_url":"https://api.github.com/repos/ashimaathri/canon-react/hooks","issue_events_url":"https://api.github.com/repos/ashimaathri/canon-react/issues/events{/number}","events_url":"https://api.github.com/repos/ashimaathri/canon-react/events","assignees_url":"https://api.github.com/repos/ashimaathri/canon-react/assignees{/user}","branches_url":"https://api.github.com/repos/ashimaathri/canon-react/branches{/branch}","tags_url":"https://api.github.com/repos/ashimaathri/canon-react/tags","blobs_url":"https://api.github.com/repos/ashimaathri/canon-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashimaathri/canon-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashimaathri/canon-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashimaathri/canon-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashimaathri/canon-react/statuses/{sha}","languages_url":"https://api.github.com/repos/ashimaathri/canon-react/languages","stargazers_url":"https://api.github.com/repos/ashimaathri/canon-react/stargazers","contributors_url":"https://api.github.com/repos/ashimaathri/canon-react/contributors","subscribers_url":"https://api.github.com/repos/ashimaathri/canon-react/subscribers","subscription_url":"https://api.github.com/repos/ashimaathri/canon-react/subscription","commits_url":"https://api.github.com/repos/ashimaathri/canon-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashimaathri/canon-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashimaathri/canon-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashimaathri/canon-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashimaathri/canon-react/contents/{+path}","compare_url":"https://api.github.com/repos/ashimaathri/canon-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashimaathri/canon-react/merges","archive_url":"https://api.github.com/repos/ashimaathri/canon-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashimaathri/canon-react/downloads","issues_url":"https://api.github.com/repos/ashimaathri/canon-react/issues{/number}","pulls_url":"https://api.github.com/repos/ashimaathri/canon-react/pulls{/number}","milestones_url":"https://api.github.com/repos/ashimaathri/canon-react/milestones{/number}","notifications_url":"https://api.github.com/repos/ashimaathri/canon-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashimaathri/canon-react/labels{/name}","releases_url":"https://api.github.com/repos/ashimaathri/canon-react/releases{/id}","deployments_url":"https://api.github.com/repos/ashimaathri/canon-react/deployments","created_at":"2016-03-10T20:02:44Z","updated_at":"2016-03-10T20:02:46Z","pushed_at":"2016-03-10T20:36:26Z","git_url":"git://github.com/ashimaathri/canon-react.git","ssh_url":"git@github.com:ashimaathri/canon-react.git","clone_url":"https://github.com/ashimaathri/canon-react.git","svn_url":"https://github.com/ashimaathri/canon-react","homepage":"http://rackerlabs.github.io/canon-react/","size":610,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"92c68a11ad0291075cc7e52457a38efc7fbf007b","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":31282707,"name":"canon-react","full_name":"rackerlabs/canon-react","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/canon-react","description":"React components for Rackspace's Canon framework","fork":false,"url":"https://api.github.com/repos/rackerlabs/canon-react","forks_url":"https://api.github.com/repos/rackerlabs/canon-react/forks","keys_url":"https://api.github.com/repos/rackerlabs/canon-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/canon-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/canon-react/teams","hooks_url":"https://api.github.com/repos/rackerlabs/canon-react/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/canon-react/events","assignees_url":"https://api.github.com/repos/rackerlabs/canon-react/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/canon-react/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/canon-react/tags","blobs_url":"https://api.github.com/repos/rackerlabs/canon-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/canon-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/canon-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/canon-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/canon-react/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/canon-react/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/canon-react/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/canon-react/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/canon-react/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/canon-react/subscription","commits_url":"https://api.github.com/repos/rackerlabs/canon-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/canon-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/canon-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/canon-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/canon-react/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/canon-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/canon-react/merges","archive_url":"https://api.github.com/repos/rackerlabs/canon-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/canon-react/downloads","issues_url":"https://api.github.com/repos/rackerlabs/canon-react/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/canon-react/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/canon-react/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/canon-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/canon-react/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/canon-react/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/canon-react/deployments","created_at":"2015-02-24T21:23:09Z","updated_at":"2016-01-13T21:10:54Z","pushed_at":"2016-03-10T20:37:36Z","git_url":"git://github.com/rackerlabs/canon-react.git","ssh_url":"git@github.com:rackerlabs/canon-react.git","clone_url":"https://github.com/rackerlabs/canon-react.git","svn_url":"https://github.com/rackerlabs/canon-react","homepage":"http://rackerlabs.github.io/canon-react/","size":615,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/canon-react/pulls/82"},"html":{"href":"https://github.com/rackerlabs/canon-react/pull/82"},"issue":{"href":"https://api.github.com/repos/rackerlabs/canon-react/issues/82"},"comments":{"href":"https://api.github.com/repos/rackerlabs/canon-react/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/canon-react/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/canon-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/canon-react/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/canon-react/statuses/0e57f74a29d292aa8b738696286ee0afea0e6ba7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":1,"commits":1,"additions":19,"deletions":3,"changed_files":2}}