{"action":"closed","number":1885,"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1885","id":54258439,"html_url":"https://github.com/SciTools/iris/pull/1885","diff_url":"https://github.com/SciTools/iris/pull/1885.diff","patch_url":"https://github.com/SciTools/iris/pull/1885.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1885","number":1885,"state":"closed","locked":false,"title":"Deprecate the whole pp 'custom save rules' api.","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"body":"Replaces #1869\r\nNote the proof-of-principle for replacing the pp-save-rules with a Python equivalent\r\n - https://github.com/pp-mo/iris/pull/18\r\n\r\nIssues from there, remaining to address :\r\n  * [x] @rhattersley \"You've listed as_pairs twice.\" : https://github.com/SciTools/iris/pull/1869#discussion_r46388252\r\n  * [x] @rhattersley \"should also deprecate some of the contents of the iris.fileformats.rules module\" : https://github.com/SciTools/iris/pull/1869#issuecomment-161602582\r\n\r\nNote: to make this useful, we may want to cut an intermediate release including these deprecations, so we can then remove the functions (ideally, in Iris 2.0).\r\nSee : [@rhattersley on releases](https://github.com/SciTools/iris/pull/1869#issuecomment-163568785)\r\n","created_at":"2015-12-21T13:54:17Z","updated_at":"2016-02-29T09:24:22Z","closed_at":"2016-02-29T09:24:22Z","merged_at":"2016-02-29T09:24:22Z","merge_commit_sha":"8261426d0adfb19f6e6153604f1705923524822d","assignee":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/SciTools/iris/milestones/14","html_url":"https://github.com/SciTools/iris/milestones/v1.10","labels_url":"https://api.github.com/repos/SciTools/iris/milestones/14/labels","id":1426195,"number":14,"title":"v1.10","description":"","creator":{"login":"QuLogic","id":302469,"avatar_url":"https://avatars.githubusercontent.com/u/302469?v=3","gravatar_id":"","url":"https://api.github.com/users/QuLogic","html_url":"https://github.com/QuLogic","followers_url":"https://api.github.com/users/QuLogic/followers","following_url":"https://api.github.com/users/QuLogic/following{/other_user}","gists_url":"https://api.github.com/users/QuLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/QuLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuLogic/subscriptions","organizations_url":"https://api.github.com/users/QuLogic/orgs","repos_url":"https://api.github.com/users/QuLogic/repos","events_url":"https://api.github.com/users/QuLogic/events{/privacy}","received_events_url":"https://api.github.com/users/QuLogic/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":36,"state":"open","created_at":"2015-11-23T22:23:19Z","updated_at":"2016-02-29T09:24:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/1885/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/1885/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1885/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/3b3dd792f14d700cd1eda7c6a1ab24102f82fe30","head":{"label":"pp-mo:no_text_rules_2","ref":"no_text_rules_2","sha":"3b3dd792f14d700cd1eda7c6a1ab24102f82fe30","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"repo":{"id":5701421,"name":"iris","full_name":"pp-mo/iris","owner":{"login":"pp-mo","id":2089069,"avatar_url":"https://avatars.githubusercontent.com/u/2089069?v=3","gravatar_id":"","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pp-mo/iris","description":"","fork":true,"url":"https://api.github.com/repos/pp-mo/iris","forks_url":"https://api.github.com/repos/pp-mo/iris/forks","keys_url":"https://api.github.com/repos/pp-mo/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pp-mo/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pp-mo/iris/teams","hooks_url":"https://api.github.com/repos/pp-mo/iris/hooks","issue_events_url":"https://api.github.com/repos/pp-mo/iris/issues/events{/number}","events_url":"https://api.github.com/repos/pp-mo/iris/events","assignees_url":"https://api.github.com/repos/pp-mo/iris/assignees{/user}","branches_url":"https://api.github.com/repos/pp-mo/iris/branches{/branch}","tags_url":"https://api.github.com/repos/pp-mo/iris/tags","blobs_url":"https://api.github.com/repos/pp-mo/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pp-mo/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pp-mo/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/pp-mo/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pp-mo/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/pp-mo/iris/languages","stargazers_url":"https://api.github.com/repos/pp-mo/iris/stargazers","contributors_url":"https://api.github.com/repos/pp-mo/iris/contributors","subscribers_url":"https://api.github.com/repos/pp-mo/iris/subscribers","subscription_url":"https://api.github.com/repos/pp-mo/iris/subscription","commits_url":"https://api.github.com/repos/pp-mo/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/pp-mo/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/pp-mo/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/pp-mo/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/pp-mo/iris/contents/{+path}","compare_url":"https://api.github.com/repos/pp-mo/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pp-mo/iris/merges","archive_url":"https://api.github.com/repos/pp-mo/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pp-mo/iris/downloads","issues_url":"https://api.github.com/repos/pp-mo/iris/issues{/number}","pulls_url":"https://api.github.com/repos/pp-mo/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/pp-mo/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/pp-mo/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pp-mo/iris/labels{/name}","releases_url":"https://api.github.com/repos/pp-mo/iris/releases{/id}","deployments_url":"https://api.github.com/repos/pp-mo/iris/deployments","created_at":"2012-09-06T11:45:58Z","updated_at":"2015-04-25T22:15:43Z","pushed_at":"2016-02-29T08:53:55Z","git_url":"git://github.com/pp-mo/iris.git","ssh_url":"git@github.com:pp-mo/iris.git","clone_url":"https://github.com/pp-mo/iris.git","svn_url":"https://github.com/pp-mo/iris","homepage":"http://scitools.github.com/iris","size":109074,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"243e21bee2d403ba746e3dcc7e1b9e27d02c8588","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/iris/deployments","created_at":"2012-08-06T10:09:14Z","updated_at":"2016-02-22T17:02:41Z","pushed_at":"2016-02-29T09:24:22Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":142190,"stargazers_count":119,"watchers_count":119,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":196,"forks":89,"open_issues":196,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1885"},"html":{"href":"https://github.com/SciTools/iris/pull/1885"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/1885"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/1885/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1885/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1885/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/3b3dd792f14d700cd1eda7c6a1ab24102f82fe30"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rhattersley","id":917914,"avatar_url":"https://avatars.githubusercontent.com/u/917914?v=3","gravatar_id":"","url":"https://api.github.com/users/rhattersley","html_url":"https://github.com/rhattersley","followers_url":"https://api.github.com/users/rhattersley/followers","following_url":"https://api.github.com/users/rhattersley/following{/other_user}","gists_url":"https://api.github.com/users/rhattersley/gists{/gist_id}","starred_url":"https://api.github.com/users/rhattersley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhattersley/subscriptions","organizations_url":"https://api.github.com/users/rhattersley/orgs","repos_url":"https://api.github.com/users/rhattersley/repos","events_url":"https://api.github.com/users/rhattersley/events{/privacy}","received_events_url":"https://api.github.com/users/rhattersley/received_events","type":"User","site_admin":false},"comments":7,"review_comments":13,"commits":1,"additions":146,"deletions":15,"changed_files":7}}