{"action":"created","comment":{"url":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments/73860484","id":73860484,"diff_hunk":"@@ -56,7 +56,7 @@ std::string readLink(const std::string& pathname)\n \n     if (readlink(pathname.c_str(), buffer, PATH_MAX) == -1)\n     {\n-        throw except::Exception(Ctxt(strerror(errno)));\n+        return \"\";\n     }","path":"modules/c++/sys/source/OSUnix.cpp","position":6,"original_position":6,"commit_id":"46a349f1a9a099c8421c62fcc78efc9f60a23646","original_commit_id":"46a349f1a9a099c8421c62fcc78efc9f60a23646","user":{"login":"JonathanMeans","id":5521504,"avatar_url":"https://avatars.githubusercontent.com/u/5521504?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanMeans","html_url":"https://github.com/JonathanMeans","followers_url":"https://api.github.com/users/JonathanMeans/followers","following_url":"https://api.github.com/users/JonathanMeans/following{/other_user}","gists_url":"https://api.github.com/users/JonathanMeans/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanMeans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanMeans/subscriptions","organizations_url":"https://api.github.com/users/JonathanMeans/orgs","repos_url":"https://api.github.com/users/JonathanMeans/repos","events_url":"https://api.github.com/users/JonathanMeans/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanMeans/received_events","type":"User","site_admin":false},"body":"I've changed it so it checks if the path exists before calling readlink. The issue I was encountering was that on Solaris the symlink is just elsewhere. Though a StackOverflow user did say that his system required root to follow the symlink in `/proc/self/exe`.","created_at":"2016-08-08T11:33:31Z","updated_at":"2016-08-08T11:33:31Z","html_url":"https://github.com/mdaus/coda-oss/pull/155#discussion_r73860484","pull_request_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments/73860484"},"html":{"href":"https://github.com/mdaus/coda-oss/pull/155#discussion_r73860484"},"pull_request":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/mdaus/coda-oss/pulls/155","id":80278510,"html_url":"https://github.com/mdaus/coda-oss/pull/155","diff_url":"https://github.com/mdaus/coda-oss/pull/155.diff","patch_url":"https://github.com/mdaus/coda-oss/pull/155.patch","issue_url":"https://api.github.com/repos/mdaus/coda-oss/issues/155","number":155,"state":"open","locked":false,"title":"getCurrentExecutable() works by trying a number of different things o…","user":{"login":"JonathanMeans","id":5521504,"avatar_url":"https://avatars.githubusercontent.com/u/5521504?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanMeans","html_url":"https://github.com/JonathanMeans","followers_url":"https://api.github.com/users/JonathanMeans/followers","following_url":"https://api.github.com/users/JonathanMeans/following{/other_user}","gists_url":"https://api.github.com/users/JonathanMeans/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanMeans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanMeans/subscriptions","organizations_url":"https://api.github.com/users/JonathanMeans/orgs","repos_url":"https://api.github.com/users/JonathanMeans/repos","events_url":"https://api.github.com/users/JonathanMeans/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanMeans/received_events","type":"User","site_admin":false},"body":"…n Unix machines, so it doesn't work to throw if readLink fails","created_at":"2016-08-05T17:27:08Z","updated_at":"2016-08-08T11:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"335a40b1d8db478d9c786b2ba2390c807ee14b77","assignee":{"login":"asylvest","id":11707082,"avatar_url":"https://avatars.githubusercontent.com/u/11707082?v=3","gravatar_id":"","url":"https://api.github.com/users/asylvest","html_url":"https://github.com/asylvest","followers_url":"https://api.github.com/users/asylvest/followers","following_url":"https://api.github.com/users/asylvest/following{/other_user}","gists_url":"https://api.github.com/users/asylvest/gists{/gist_id}","starred_url":"https://api.github.com/users/asylvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asylvest/subscriptions","organizations_url":"https://api.github.com/users/asylvest/orgs","repos_url":"https://api.github.com/users/asylvest/repos","events_url":"https://api.github.com/users/asylvest/events{/privacy}","received_events_url":"https://api.github.com/users/asylvest/received_events","type":"User","site_admin":false},"assignees":[{"login":"asylvest","id":11707082,"avatar_url":"https://avatars.githubusercontent.com/u/11707082?v=3","gravatar_id":"","url":"https://api.github.com/users/asylvest","html_url":"https://github.com/asylvest","followers_url":"https://api.github.com/users/asylvest/followers","following_url":"https://api.github.com/users/asylvest/following{/other_user}","gists_url":"https://api.github.com/users/asylvest/gists{/gist_id}","starred_url":"https://api.github.com/users/asylvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asylvest/subscriptions","organizations_url":"https://api.github.com/users/asylvest/orgs","repos_url":"https://api.github.com/users/asylvest/repos","events_url":"https://api.github.com/users/asylvest/events{/privacy}","received_events_url":"https://api.github.com/users/asylvest/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mdaus/coda-oss/milestones/2","html_url":"https://github.com/mdaus/coda-oss/milestones/CODA%2016.10","labels_url":"https://api.github.com/repos/mdaus/coda-oss/milestones/2/labels","id":1863257,"number":2,"title":"CODA 16.10","description":"","creator":{"login":"asylvest","id":11707082,"avatar_url":"https://avatars.githubusercontent.com/u/11707082?v=3","gravatar_id":"","url":"https://api.github.com/users/asylvest","html_url":"https://github.com/asylvest","followers_url":"https://api.github.com/users/asylvest/followers","following_url":"https://api.github.com/users/asylvest/following{/other_user}","gists_url":"https://api.github.com/users/asylvest/gists{/gist_id}","starred_url":"https://api.github.com/users/asylvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asylvest/subscriptions","organizations_url":"https://api.github.com/users/asylvest/orgs","repos_url":"https://api.github.com/users/asylvest/repos","events_url":"https://api.github.com/users/asylvest/events{/privacy}","received_events_url":"https://api.github.com/users/asylvest/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":12,"state":"open","created_at":"2016-07-04T13:41:16Z","updated_at":"2016-08-05T17:27:23Z","due_on":"2016-10-04T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/155/commits","review_comments_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/155/comments","review_comment_url":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/issues/155/comments","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/46a349f1a9a099c8421c62fcc78efc9f60a23646","head":{"label":"mdaus:fixFindExecSolaris","ref":"fixFindExecSolaris","sha":"46a349f1a9a099c8421c62fcc78efc9f60a23646","user":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"repo":{"id":33076757,"name":"coda-oss","full_name":"mdaus/coda-oss","owner":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdaus/coda-oss","description":"The Common Open Development Archive (CODA-OSS) is a set of open source, modular components developed by MDA Information Systems LLC, primarily as a portable runtime for C++ processing.","fork":false,"url":"https://api.github.com/repos/mdaus/coda-oss","forks_url":"https://api.github.com/repos/mdaus/coda-oss/forks","keys_url":"https://api.github.com/repos/mdaus/coda-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaus/coda-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaus/coda-oss/teams","hooks_url":"https://api.github.com/repos/mdaus/coda-oss/hooks","issue_events_url":"https://api.github.com/repos/mdaus/coda-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mdaus/coda-oss/events","assignees_url":"https://api.github.com/repos/mdaus/coda-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mdaus/coda-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mdaus/coda-oss/tags","blobs_url":"https://api.github.com/repos/mdaus/coda-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaus/coda-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaus/coda-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaus/coda-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaus/coda-oss/languages","stargazers_url":"https://api.github.com/repos/mdaus/coda-oss/stargazers","contributors_url":"https://api.github.com/repos/mdaus/coda-oss/contributors","subscribers_url":"https://api.github.com/repos/mdaus/coda-oss/subscribers","subscription_url":"https://api.github.com/repos/mdaus/coda-oss/subscription","commits_url":"https://api.github.com/repos/mdaus/coda-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaus/coda-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaus/coda-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdaus/coda-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mdaus/coda-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaus/coda-oss/merges","archive_url":"https://api.github.com/repos/mdaus/coda-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaus/coda-oss/downloads","issues_url":"https://api.github.com/repos/mdaus/coda-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mdaus/coda-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaus/coda-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaus/coda-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaus/coda-oss/labels{/name}","releases_url":"https://api.github.com/repos/mdaus/coda-oss/releases{/id}","deployments_url":"https://api.github.com/repos/mdaus/coda-oss/deployments","created_at":"2015-03-29T14:48:12Z","updated_at":"2016-06-30T14:38:08Z","pushed_at":"2016-08-05T17:27:08Z","git_url":"git://github.com/mdaus/coda-oss.git","ssh_url":"git@github.com:mdaus/coda-oss.git","clone_url":"https://github.com/mdaus/coda-oss.git","svn_url":"https://github.com/mdaus/coda-oss","homepage":null,"size":123711,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":6,"default_branch":"master"}},"base":{"label":"mdaus:master","ref":"master","sha":"6ce19a08c714c4843fdaeee9212c6f71b21725e2","user":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"repo":{"id":33076757,"name":"coda-oss","full_name":"mdaus/coda-oss","owner":{"login":"mdaus","id":11707119,"avatar_url":"https://avatars.githubusercontent.com/u/11707119?v=3","gravatar_id":"","url":"https://api.github.com/users/mdaus","html_url":"https://github.com/mdaus","followers_url":"https://api.github.com/users/mdaus/followers","following_url":"https://api.github.com/users/mdaus/following{/other_user}","gists_url":"https://api.github.com/users/mdaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mdaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdaus/subscriptions","organizations_url":"https://api.github.com/users/mdaus/orgs","repos_url":"https://api.github.com/users/mdaus/repos","events_url":"https://api.github.com/users/mdaus/events{/privacy}","received_events_url":"https://api.github.com/users/mdaus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mdaus/coda-oss","description":"The Common Open Development Archive (CODA-OSS) is a set of open source, modular components developed by MDA Information Systems LLC, primarily as a portable runtime for C++ processing.","fork":false,"url":"https://api.github.com/repos/mdaus/coda-oss","forks_url":"https://api.github.com/repos/mdaus/coda-oss/forks","keys_url":"https://api.github.com/repos/mdaus/coda-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdaus/coda-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdaus/coda-oss/teams","hooks_url":"https://api.github.com/repos/mdaus/coda-oss/hooks","issue_events_url":"https://api.github.com/repos/mdaus/coda-oss/issues/events{/number}","events_url":"https://api.github.com/repos/mdaus/coda-oss/events","assignees_url":"https://api.github.com/repos/mdaus/coda-oss/assignees{/user}","branches_url":"https://api.github.com/repos/mdaus/coda-oss/branches{/branch}","tags_url":"https://api.github.com/repos/mdaus/coda-oss/tags","blobs_url":"https://api.github.com/repos/mdaus/coda-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdaus/coda-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdaus/coda-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdaus/coda-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdaus/coda-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/mdaus/coda-oss/languages","stargazers_url":"https://api.github.com/repos/mdaus/coda-oss/stargazers","contributors_url":"https://api.github.com/repos/mdaus/coda-oss/contributors","subscribers_url":"https://api.github.com/repos/mdaus/coda-oss/subscribers","subscription_url":"https://api.github.com/repos/mdaus/coda-oss/subscription","commits_url":"https://api.github.com/repos/mdaus/coda-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdaus/coda-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdaus/coda-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdaus/coda-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdaus/coda-oss/contents/{+path}","compare_url":"https://api.github.com/repos/mdaus/coda-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdaus/coda-oss/merges","archive_url":"https://api.github.com/repos/mdaus/coda-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdaus/coda-oss/downloads","issues_url":"https://api.github.com/repos/mdaus/coda-oss/issues{/number}","pulls_url":"https://api.github.com/repos/mdaus/coda-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/mdaus/coda-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/mdaus/coda-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdaus/coda-oss/labels{/name}","releases_url":"https://api.github.com/repos/mdaus/coda-oss/releases{/id}","deployments_url":"https://api.github.com/repos/mdaus/coda-oss/deployments","created_at":"2015-03-29T14:48:12Z","updated_at":"2016-06-30T14:38:08Z","pushed_at":"2016-08-05T17:27:08Z","git_url":"git://github.com/mdaus/coda-oss.git","ssh_url":"git@github.com:mdaus/coda-oss.git","clone_url":"https://github.com/mdaus/coda-oss.git","svn_url":"https://github.com/mdaus/coda-oss","homepage":null,"size":123711,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/155"},"html":{"href":"https://github.com/mdaus/coda-oss/pull/155"},"issue":{"href":"https://api.github.com/repos/mdaus/coda-oss/issues/155"},"comments":{"href":"https://api.github.com/repos/mdaus/coda-oss/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdaus/coda-oss/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/mdaus/coda-oss/statuses/46a349f1a9a099c8421c62fcc78efc9f60a23646"}}}}
{"actor":{"display_login":"JonathanMeans"}}