{"action":"closed","number":1701,"pull_request":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1701","id":56715270,"html_url":"https://github.com/angular-ui/angular-google-maps/pull/1701","diff_url":"https://github.com/angular-ui/angular-google-maps/pull/1701.diff","patch_url":"https://github.com/angular-ui/angular-google-maps/pull/1701.patch","issue_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1701","number":1701,"state":"closed","locked":false,"title":"spec tests bad?","user":{"login":"armyofda12mnkeys","id":410112,"avatar_url":"https://avatars.githubusercontent.com/u/410112?v=3","gravatar_id":"","url":"https://api.github.com/users/armyofda12mnkeys","html_url":"https://github.com/armyofda12mnkeys","followers_url":"https://api.github.com/users/armyofda12mnkeys/followers","following_url":"https://api.github.com/users/armyofda12mnkeys/following{/other_user}","gists_url":"https://api.github.com/users/armyofda12mnkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/armyofda12mnkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armyofda12mnkeys/subscriptions","organizations_url":"https://api.github.com/users/armyofda12mnkeys/orgs","repos_url":"https://api.github.com/users/armyofda12mnkeys/repos","events_url":"https://api.github.com/users/armyofda12mnkeys/events{/privacy}","received_events_url":"https://api.github.com/users/armyofda12mnkeys/received_events","type":"User","site_admin":false},"body":"Simplified the 'should add markers for each object in model' spec tests and at least 2 of them pass now (still 3 errors left, will look at those tomorrow).\r\n\r\nI'm not big on coffeescript, so may want to review. I create the items array more like the 3rd 'should add markers for each object in model' test in the previous two tests.\r\n\r\nlike:\r\n```\r\n        toPush = {}\r\n        toPush.id = 0\r\n        toPush.latitude = 47\r\n        toPush.longitude = -27\r\n        @scope.items = [toPush]\r\n```\r\ninstead of:\r\n```\r\n        toPush = {}\r\n        toPush.id = 0\r\n        toPush.latitude = 47\r\n        toPush.longitude = -27\r\n        @scope.items =\r\n          0: toPush\r\n          length: 1\r\n```\r\n\r\nand\r\nlike:\r\n```\r\n        items = []\r\n        numarray = _.range(2) //wasnt sure if array was a protected var ame when converted to JS\r\n        numarray.forEach (num) ->\r\n          toPush = { id: num, latitude: 47, longitude: -27 }\r\n          items[num] = toPush\r\n\r\n        @scope.items = items\r\n```\r\ninstead of:\r\n```\r\n        items  = {}\r\n        array = _.range(2)\r\n        items.length = array.length\r\n        array.forEach (num) ->\r\n          toPush =\r\n            id: num\r\n            latitude: 47\r\n            longitude: -27\r\n\r\n          items[num] = toPush\r\n\r\n        @scope.items = items\r\n```","created_at":"2016-01-21T07:50:01Z","updated_at":"2016-01-22T07:54:23Z","closed_at":"2016-01-22T07:54:23Z","merged_at":null,"merge_commit_sha":"f3919e03189c3beb54addb6f641a862ba0590807","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1701/commits","review_comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1701/comments","review_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1701/comments","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/6a653ff946b4e11e8e6a7bee430b5437f5bba0c2","head":{"label":"armyofda12mnkeys:dev/nmccready/tryingToMakeLodash4Wurk","ref":"dev/nmccready/tryingToMakeLodash4Wurk","sha":"6a653ff946b4e11e8e6a7bee430b5437f5bba0c2","user":{"login":"armyofda12mnkeys","id":410112,"avatar_url":"https://avatars.githubusercontent.com/u/410112?v=3","gravatar_id":"","url":"https://api.github.com/users/armyofda12mnkeys","html_url":"https://github.com/armyofda12mnkeys","followers_url":"https://api.github.com/users/armyofda12mnkeys/followers","following_url":"https://api.github.com/users/armyofda12mnkeys/following{/other_user}","gists_url":"https://api.github.com/users/armyofda12mnkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/armyofda12mnkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armyofda12mnkeys/subscriptions","organizations_url":"https://api.github.com/users/armyofda12mnkeys/orgs","repos_url":"https://api.github.com/users/armyofda12mnkeys/repos","events_url":"https://api.github.com/users/armyofda12mnkeys/events{/privacy}","received_events_url":"https://api.github.com/users/armyofda12mnkeys/received_events","type":"User","site_admin":false},"repo":{"id":50080717,"name":"angular-google-maps","full_name":"armyofda12mnkeys/angular-google-maps","owner":{"login":"armyofda12mnkeys","id":410112,"avatar_url":"https://avatars.githubusercontent.com/u/410112?v=3","gravatar_id":"","url":"https://api.github.com/users/armyofda12mnkeys","html_url":"https://github.com/armyofda12mnkeys","followers_url":"https://api.github.com/users/armyofda12mnkeys/followers","following_url":"https://api.github.com/users/armyofda12mnkeys/following{/other_user}","gists_url":"https://api.github.com/users/armyofda12mnkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/armyofda12mnkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armyofda12mnkeys/subscriptions","organizations_url":"https://api.github.com/users/armyofda12mnkeys/orgs","repos_url":"https://api.github.com/users/armyofda12mnkeys/repos","events_url":"https://api.github.com/users/armyofda12mnkeys/events{/privacy}","received_events_url":"https://api.github.com/users/armyofda12mnkeys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/armyofda12mnkeys/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":true,"url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps","forks_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/forks","keys_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/events","assignees_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/merges","archive_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/releases{/id}","deployments_url":"https://api.github.com/repos/armyofda12mnkeys/angular-google-maps/deployments","created_at":"2016-01-21T03:55:15Z","updated_at":"2016-01-21T03:55:17Z","pushed_at":"2016-01-21T07:42:45Z","git_url":"git://github.com/armyofda12mnkeys/angular-google-maps.git","ssh_url":"git@github.com:armyofda12mnkeys/angular-google-maps.git","clone_url":"https://github.com/armyofda12mnkeys/angular-google-maps.git","svn_url":"https://github.com/armyofda12mnkeys/angular-google-maps","homepage":"http://angular-ui.github.io/angular-google-maps","size":79539,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"aecba46d6cd6aa43f46b2ea8480ae6b5e90c4209","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":5438867,"name":"angular-google-maps","full_name":"angular-ui/angular-google-maps","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":false,"url":"https://api.github.com/repos/angular-ui/angular-google-maps","forks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/forks","keys_url":"https://api.github.com/repos/angular-ui/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/events","assignees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/angular-google-maps/merges","archive_url":"https://api.github.com/repos/angular-ui/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/angular-google-maps/releases{/id}","deployments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/deployments","created_at":"2012-08-16T12:50:47Z","updated_at":"2016-01-22T00:56:41Z","pushed_at":"2016-01-22T02:57:09Z","git_url":"git://github.com/angular-ui/angular-google-maps.git","ssh_url":"git@github.com:angular-ui/angular-google-maps.git","clone_url":"https://github.com/angular-ui/angular-google-maps.git","svn_url":"https://github.com/angular-ui/angular-google-maps","homepage":"http://angular-ui.github.io/angular-google-maps","size":89190,"stargazers_count":2119,"watchers_count":2119,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":864,"mirror_url":null,"open_issues_count":190,"forks":864,"open_issues":190,"watchers":2119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1701"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/1701"},"issue":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1701"},"comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1701/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1701/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1701/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/6a653ff946b4e11e8e6a7bee430b5437f5bba0c2"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":97,"deletions":4024,"changed_files":48}}