{"action":"closed","number":165,"pull_request":{"url":"https://api.github.com/repos/niwinz/django-jinja/pulls/165","id":58253950,"html_url":"https://github.com/niwinz/django-jinja/pull/165","diff_url":"https://github.com/niwinz/django-jinja/pull/165.diff","patch_url":"https://github.com/niwinz/django-jinja/pull/165.patch","issue_url":"https://api.github.com/repos/niwinz/django-jinja/issues/165","number":165,"state":"closed","locked":false,"title":"Allow to provide a custom loader class as string, backward compatible","user":{"login":"hartym","id":30586,"avatar_url":"https://avatars.githubusercontent.com/u/30586?v=3","gravatar_id":"","url":"https://api.github.com/users/hartym","html_url":"https://github.com/hartym","followers_url":"https://api.github.com/users/hartym/followers","following_url":"https://api.github.com/users/hartym/following{/other_user}","gists_url":"https://api.github.com/users/hartym/gists{/gist_id}","starred_url":"https://api.github.com/users/hartym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartym/subscriptions","organizations_url":"https://api.github.com/users/hartym/orgs","repos_url":"https://api.github.com/users/hartym/repos","events_url":"https://api.github.com/users/hartym/events{/privacy}","received_events_url":"https://api.github.com/users/hartym/received_events","type":"User","site_admin":false},"body":"Apparently, some work has been done in older verions of django_jinja about this (see #47 and #48) but this feature is not available anymore in 2.x (see https://github.com/niwinz/django-jinja/blob/master/django_jinja/backend.py#L175). In fact, it is possible to specify a loader option, but only as a Loader instance and not using a string notation. This is a problem because self.template_dirs won't be available outside of the constructor.\r\n\r\nI did a small patch about this that should be backward compatible, let me know what you think (whether or not this kind of PR is ok for django-jinja, if I need to add more stuff around, etc.).\r\n","created_at":"2016-02-04T08:21:24Z","updated_at":"2016-02-09T06:42:35Z","closed_at":"2016-02-09T06:42:35Z","merged_at":"2016-02-09T06:42:35Z","merge_commit_sha":"0617807178c7aa78561dec160563622a68b37dcd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/niwinz/django-jinja/pulls/165/commits","review_comments_url":"https://api.github.com/repos/niwinz/django-jinja/pulls/165/comments","review_comment_url":"https://api.github.com/repos/niwinz/django-jinja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/niwinz/django-jinja/issues/165/comments","statuses_url":"https://api.github.com/repos/niwinz/django-jinja/statuses/b014e88a728e92ffd193ebba25921807fc239ce4","head":{"label":"oilab:2.1.x","ref":"2.1.x","sha":"b014e88a728e92ffd193ebba25921807fc239ce4","user":{"login":"oilab","id":11888088,"avatar_url":"https://avatars.githubusercontent.com/u/11888088?v=3","gravatar_id":"","url":"https://api.github.com/users/oilab","html_url":"https://github.com/oilab","followers_url":"https://api.github.com/users/oilab/followers","following_url":"https://api.github.com/users/oilab/following{/other_user}","gists_url":"https://api.github.com/users/oilab/gists{/gist_id}","starred_url":"https://api.github.com/users/oilab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oilab/subscriptions","organizations_url":"https://api.github.com/users/oilab/orgs","repos_url":"https://api.github.com/users/oilab/repos","events_url":"https://api.github.com/users/oilab/events{/privacy}","received_events_url":"https://api.github.com/users/oilab/received_events","type":"Organization","site_admin":false},"repo":{"id":50925215,"name":"django-jinja","full_name":"oilab/django-jinja","owner":{"login":"oilab","id":11888088,"avatar_url":"https://avatars.githubusercontent.com/u/11888088?v=3","gravatar_id":"","url":"https://api.github.com/users/oilab","html_url":"https://github.com/oilab","followers_url":"https://api.github.com/users/oilab/followers","following_url":"https://api.github.com/users/oilab/following{/other_user}","gists_url":"https://api.github.com/users/oilab/gists{/gist_id}","starred_url":"https://api.github.com/users/oilab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oilab/subscriptions","organizations_url":"https://api.github.com/users/oilab/orgs","repos_url":"https://api.github.com/users/oilab/repos","events_url":"https://api.github.com/users/oilab/events{/privacy}","received_events_url":"https://api.github.com/users/oilab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oilab/django-jinja","description":"Simple and nonobstructive jinja2 integration with Django.","fork":true,"url":"https://api.github.com/repos/oilab/django-jinja","forks_url":"https://api.github.com/repos/oilab/django-jinja/forks","keys_url":"https://api.github.com/repos/oilab/django-jinja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oilab/django-jinja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oilab/django-jinja/teams","hooks_url":"https://api.github.com/repos/oilab/django-jinja/hooks","issue_events_url":"https://api.github.com/repos/oilab/django-jinja/issues/events{/number}","events_url":"https://api.github.com/repos/oilab/django-jinja/events","assignees_url":"https://api.github.com/repos/oilab/django-jinja/assignees{/user}","branches_url":"https://api.github.com/repos/oilab/django-jinja/branches{/branch}","tags_url":"https://api.github.com/repos/oilab/django-jinja/tags","blobs_url":"https://api.github.com/repos/oilab/django-jinja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oilab/django-jinja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oilab/django-jinja/git/refs{/sha}","trees_url":"https://api.github.com/repos/oilab/django-jinja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oilab/django-jinja/statuses/{sha}","languages_url":"https://api.github.com/repos/oilab/django-jinja/languages","stargazers_url":"https://api.github.com/repos/oilab/django-jinja/stargazers","contributors_url":"https://api.github.com/repos/oilab/django-jinja/contributors","subscribers_url":"https://api.github.com/repos/oilab/django-jinja/subscribers","subscription_url":"https://api.github.com/repos/oilab/django-jinja/subscription","commits_url":"https://api.github.com/repos/oilab/django-jinja/commits{/sha}","git_commits_url":"https://api.github.com/repos/oilab/django-jinja/git/commits{/sha}","comments_url":"https://api.github.com/repos/oilab/django-jinja/comments{/number}","issue_comment_url":"https://api.github.com/repos/oilab/django-jinja/issues/comments{/number}","contents_url":"https://api.github.com/repos/oilab/django-jinja/contents/{+path}","compare_url":"https://api.github.com/repos/oilab/django-jinja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oilab/django-jinja/merges","archive_url":"https://api.github.com/repos/oilab/django-jinja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oilab/django-jinja/downloads","issues_url":"https://api.github.com/repos/oilab/django-jinja/issues{/number}","pulls_url":"https://api.github.com/repos/oilab/django-jinja/pulls{/number}","milestones_url":"https://api.github.com/repos/oilab/django-jinja/milestones{/number}","notifications_url":"https://api.github.com/repos/oilab/django-jinja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oilab/django-jinja/labels{/name}","releases_url":"https://api.github.com/repos/oilab/django-jinja/releases{/id}","deployments_url":"https://api.github.com/repos/oilab/django-jinja/deployments","created_at":"2016-02-02T14:15:24Z","updated_at":"2016-02-02T14:15:25Z","pushed_at":"2016-02-02T14:28:46Z","git_url":"git://github.com/oilab/django-jinja.git","ssh_url":"git@github.com:oilab/django-jinja.git","clone_url":"https://github.com/oilab/django-jinja.git","svn_url":"https://github.com/oilab/django-jinja","homepage":"http://niwinz.github.io/django-jinja/latest/","size":454,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"niwinz:master","ref":"master","sha":"5f3e4ce6c3098cf4c0341488a03a021b32f5f0c7","user":{"login":"niwinz","id":843689,"avatar_url":"https://avatars.githubusercontent.com/u/843689?v=3","gravatar_id":"","url":"https://api.github.com/users/niwinz","html_url":"https://github.com/niwinz","followers_url":"https://api.github.com/users/niwinz/followers","following_url":"https://api.github.com/users/niwinz/following{/other_user}","gists_url":"https://api.github.com/users/niwinz/gists{/gist_id}","starred_url":"https://api.github.com/users/niwinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niwinz/subscriptions","organizations_url":"https://api.github.com/users/niwinz/orgs","repos_url":"https://api.github.com/users/niwinz/repos","events_url":"https://api.github.com/users/niwinz/events{/privacy}","received_events_url":"https://api.github.com/users/niwinz/received_events","type":"User","site_admin":false},"repo":{"id":3247274,"name":"django-jinja","full_name":"niwinz/django-jinja","owner":{"login":"niwinz","id":843689,"avatar_url":"https://avatars.githubusercontent.com/u/843689?v=3","gravatar_id":"","url":"https://api.github.com/users/niwinz","html_url":"https://github.com/niwinz","followers_url":"https://api.github.com/users/niwinz/followers","following_url":"https://api.github.com/users/niwinz/following{/other_user}","gists_url":"https://api.github.com/users/niwinz/gists{/gist_id}","starred_url":"https://api.github.com/users/niwinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niwinz/subscriptions","organizations_url":"https://api.github.com/users/niwinz/orgs","repos_url":"https://api.github.com/users/niwinz/repos","events_url":"https://api.github.com/users/niwinz/events{/privacy}","received_events_url":"https://api.github.com/users/niwinz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niwinz/django-jinja","description":"Simple and nonobstructive jinja2 integration with Django.","fork":false,"url":"https://api.github.com/repos/niwinz/django-jinja","forks_url":"https://api.github.com/repos/niwinz/django-jinja/forks","keys_url":"https://api.github.com/repos/niwinz/django-jinja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niwinz/django-jinja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niwinz/django-jinja/teams","hooks_url":"https://api.github.com/repos/niwinz/django-jinja/hooks","issue_events_url":"https://api.github.com/repos/niwinz/django-jinja/issues/events{/number}","events_url":"https://api.github.com/repos/niwinz/django-jinja/events","assignees_url":"https://api.github.com/repos/niwinz/django-jinja/assignees{/user}","branches_url":"https://api.github.com/repos/niwinz/django-jinja/branches{/branch}","tags_url":"https://api.github.com/repos/niwinz/django-jinja/tags","blobs_url":"https://api.github.com/repos/niwinz/django-jinja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niwinz/django-jinja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niwinz/django-jinja/git/refs{/sha}","trees_url":"https://api.github.com/repos/niwinz/django-jinja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niwinz/django-jinja/statuses/{sha}","languages_url":"https://api.github.com/repos/niwinz/django-jinja/languages","stargazers_url":"https://api.github.com/repos/niwinz/django-jinja/stargazers","contributors_url":"https://api.github.com/repos/niwinz/django-jinja/contributors","subscribers_url":"https://api.github.com/repos/niwinz/django-jinja/subscribers","subscription_url":"https://api.github.com/repos/niwinz/django-jinja/subscription","commits_url":"https://api.github.com/repos/niwinz/django-jinja/commits{/sha}","git_commits_url":"https://api.github.com/repos/niwinz/django-jinja/git/commits{/sha}","comments_url":"https://api.github.com/repos/niwinz/django-jinja/comments{/number}","issue_comment_url":"https://api.github.com/repos/niwinz/django-jinja/issues/comments{/number}","contents_url":"https://api.github.com/repos/niwinz/django-jinja/contents/{+path}","compare_url":"https://api.github.com/repos/niwinz/django-jinja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niwinz/django-jinja/merges","archive_url":"https://api.github.com/repos/niwinz/django-jinja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niwinz/django-jinja/downloads","issues_url":"https://api.github.com/repos/niwinz/django-jinja/issues{/number}","pulls_url":"https://api.github.com/repos/niwinz/django-jinja/pulls{/number}","milestones_url":"https://api.github.com/repos/niwinz/django-jinja/milestones{/number}","notifications_url":"https://api.github.com/repos/niwinz/django-jinja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niwinz/django-jinja/labels{/name}","releases_url":"https://api.github.com/repos/niwinz/django-jinja/releases{/id}","deployments_url":"https://api.github.com/repos/niwinz/django-jinja/deployments","created_at":"2012-01-23T14:34:36Z","updated_at":"2016-02-08T23:55:12Z","pushed_at":"2016-02-09T06:42:36Z","git_url":"git://github.com/niwinz/django-jinja.git","ssh_url":"git@github.com:niwinz/django-jinja.git","clone_url":"https://github.com/niwinz/django-jinja.git","svn_url":"https://github.com/niwinz/django-jinja","homepage":"http://niwinz.github.io/django-jinja/latest/","size":662,"stargazers_count":207,"watchers_count":207,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":4,"forks":65,"open_issues":4,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/niwinz/django-jinja/pulls/165"},"html":{"href":"https://github.com/niwinz/django-jinja/pull/165"},"issue":{"href":"https://api.github.com/repos/niwinz/django-jinja/issues/165"},"comments":{"href":"https://api.github.com/repos/niwinz/django-jinja/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/niwinz/django-jinja/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/niwinz/django-jinja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/niwinz/django-jinja/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/niwinz/django-jinja/statuses/b014e88a728e92ffd193ebba25921807fc239ce4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"niwinz","id":843689,"avatar_url":"https://avatars.githubusercontent.com/u/843689?v=3","gravatar_id":"","url":"https://api.github.com/users/niwinz","html_url":"https://github.com/niwinz","followers_url":"https://api.github.com/users/niwinz/followers","following_url":"https://api.github.com/users/niwinz/following{/other_user}","gists_url":"https://api.github.com/users/niwinz/gists{/gist_id}","starred_url":"https://api.github.com/users/niwinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niwinz/subscriptions","organizations_url":"https://api.github.com/users/niwinz/orgs","repos_url":"https://api.github.com/users/niwinz/repos","events_url":"https://api.github.com/users/niwinz/events{/privacy}","received_events_url":"https://api.github.com/users/niwinz/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":8,"deletions":1,"changed_files":1}}