{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/demo/pulls/comments/53664130","id":53664130,"diff_hunk":"@@ -0,0 +1,17 @@\n+# This is the configuration for baremetal used for testing aci installer\n+# XXX: for now we have one setup so hardcoding the details, we need to\n+# revisit this when we add more aci test setups\n+\n+CONNECTION_INFO:\n+      contiv-aci-server4:\n+        control: eth3\n+        data: eth7\n+      contiv-aci-server5:\n+        control: eth3\n+        data: eth7\n+APIC_URL: \"https://contiv-aci-ifc1:443\"\n+APIC_USERNAME: \"admin\"\n+APIC_PASSWORD: \"ins3965!\"","path":"net/test/testdata/aci_cfg.yml","position":14,"original_position":14,"commit_id":"ab93e246e88c2fe015062fe7cf82c26daaea80e4","original_commit_id":"ab93e246e88c2fe015062fe7cf82c26daaea80e4","user":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"body":"yeah, I think they can be take from environment but I don't have a way to generate this file...note that the credentials are specific to the private setup in our lab network.\r\n\r\nI intentionally let this entire file be a static yml for now given a single test setup. May be for now we can replace them with some more dumb/fake values as the installer doesn't really cares?","created_at":"2016-02-22T17:58:21Z","updated_at":"2016-02-22T17:58:21Z","html_url":"https://github.com/contiv/demo/pull/23#discussion_r53664130","pull_request_url":"https://api.github.com/repos/contiv/demo/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/contiv/demo/pulls/comments/53664130"},"html":{"href":"https://github.com/contiv/demo/pull/23#discussion_r53664130"},"pull_request":{"href":"https://api.github.com/repos/contiv/demo/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/demo/pulls/23","id":60028897,"html_url":"https://github.com/contiv/demo/pull/23","diff_url":"https://github.com/contiv/demo/pull/23.diff","patch_url":"https://github.com/contiv/demo/pull/23.patch","issue_url":"https://api.github.com/repos/contiv/demo/issues/23","number":23,"state":"open","locked":false,"title":"add initial test for netplugin installer in aci mode","user":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"body":"This PR brings in a test target for netplugin installer in aci mode. Following are high level changes:\r\n\r\n- vendor in bats in `vendor/bats` dir. We use `bats` for testing as installer being a bash script it is really quick to add tests for it\r\n  - this is 90% of this PR and might be skipped for review.\r\n- Added the installer test for aci mode in `net/test/aci_installer.bats`\r\n  - test install mode (-a flag)\r\n  - test cleanup + install (-ar flag)\r\n  - the aci-config yml file right now tailored to the `contiv-aci-server4` and `contiv-aci-server5` servers, but can made configurable later once we have more test setups\r\n- net installer was enhanced for following to aid testing, without changing the behavior as much as possible:\r\n  - the config yml can be set in environment\r\n  - the interactive mode (yes/no prompts) can be turned on/off. Right now when non-interactive mode is set, the behavior is to fail whenever a warning is detected\r\n - the ansible sha1 to use can be set in environment, which shall allow testing with a latest ansible\r\n\r\n/cc @jainvipin @DivyaVavili ","created_at":"2016-02-20T00:46:18Z","updated_at":"2016-02-22T17:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2106eccbf10a10855e7f6abe051a21754259b357","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/demo/pulls/23/commits","review_comments_url":"https://api.github.com/repos/contiv/demo/pulls/23/comments","review_comment_url":"https://api.github.com/repos/contiv/demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/demo/issues/23/comments","statuses_url":"https://api.github.com/repos/contiv/demo/statuses/ab93e246e88c2fe015062fe7cf82c26daaea80e4","head":{"label":"mapuri:test","ref":"test","sha":"ab93e246e88c2fe015062fe7cf82c26daaea80e4","user":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"repo":{"id":52029649,"name":"demo","full_name":"mapuri/demo","owner":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mapuri/demo","description":"Easy cut demos to try contiv","fork":true,"url":"https://api.github.com/repos/mapuri/demo","forks_url":"https://api.github.com/repos/mapuri/demo/forks","keys_url":"https://api.github.com/repos/mapuri/demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapuri/demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapuri/demo/teams","hooks_url":"https://api.github.com/repos/mapuri/demo/hooks","issue_events_url":"https://api.github.com/repos/mapuri/demo/issues/events{/number}","events_url":"https://api.github.com/repos/mapuri/demo/events","assignees_url":"https://api.github.com/repos/mapuri/demo/assignees{/user}","branches_url":"https://api.github.com/repos/mapuri/demo/branches{/branch}","tags_url":"https://api.github.com/repos/mapuri/demo/tags","blobs_url":"https://api.github.com/repos/mapuri/demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapuri/demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapuri/demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapuri/demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapuri/demo/statuses/{sha}","languages_url":"https://api.github.com/repos/mapuri/demo/languages","stargazers_url":"https://api.github.com/repos/mapuri/demo/stargazers","contributors_url":"https://api.github.com/repos/mapuri/demo/contributors","subscribers_url":"https://api.github.com/repos/mapuri/demo/subscribers","subscription_url":"https://api.github.com/repos/mapuri/demo/subscription","commits_url":"https://api.github.com/repos/mapuri/demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapuri/demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapuri/demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapuri/demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapuri/demo/contents/{+path}","compare_url":"https://api.github.com/repos/mapuri/demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapuri/demo/merges","archive_url":"https://api.github.com/repos/mapuri/demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapuri/demo/downloads","issues_url":"https://api.github.com/repos/mapuri/demo/issues{/number}","pulls_url":"https://api.github.com/repos/mapuri/demo/pulls{/number}","milestones_url":"https://api.github.com/repos/mapuri/demo/milestones{/number}","notifications_url":"https://api.github.com/repos/mapuri/demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapuri/demo/labels{/name}","releases_url":"https://api.github.com/repos/mapuri/demo/releases{/id}","deployments_url":"https://api.github.com/repos/mapuri/demo/deployments","created_at":"2016-02-18T18:39:54Z","updated_at":"2016-02-18T18:39:55Z","pushed_at":"2016-02-20T00:34:12Z","git_url":"git://github.com/mapuri/demo.git","ssh_url":"git@github.com:mapuri/demo.git","clone_url":"https://github.com/mapuri/demo.git","svn_url":"https://github.com/mapuri/demo","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"8c6b80ccf7c5be4b7cbf852e2e535d3df679da15","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":47722348,"name":"demo","full_name":"contiv/demo","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/demo","description":"Easy cut demos to try contiv","fork":false,"url":"https://api.github.com/repos/contiv/demo","forks_url":"https://api.github.com/repos/contiv/demo/forks","keys_url":"https://api.github.com/repos/contiv/demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/demo/teams","hooks_url":"https://api.github.com/repos/contiv/demo/hooks","issue_events_url":"https://api.github.com/repos/contiv/demo/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/demo/events","assignees_url":"https://api.github.com/repos/contiv/demo/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/demo/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/demo/tags","blobs_url":"https://api.github.com/repos/contiv/demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/demo/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/demo/languages","stargazers_url":"https://api.github.com/repos/contiv/demo/stargazers","contributors_url":"https://api.github.com/repos/contiv/demo/contributors","subscribers_url":"https://api.github.com/repos/contiv/demo/subscribers","subscription_url":"https://api.github.com/repos/contiv/demo/subscription","commits_url":"https://api.github.com/repos/contiv/demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/demo/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/demo/merges","archive_url":"https://api.github.com/repos/contiv/demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/demo/downloads","issues_url":"https://api.github.com/repos/contiv/demo/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/demo/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/demo/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/demo/labels{/name}","releases_url":"https://api.github.com/repos/contiv/demo/releases{/id}","deployments_url":"https://api.github.com/repos/contiv/demo/deployments","created_at":"2015-12-09T22:13:00Z","updated_at":"2016-01-14T21:57:03Z","pushed_at":"2016-02-20T00:46:18Z","git_url":"git://github.com/contiv/demo.git","ssh_url":"git@github.com:contiv/demo.git","clone_url":"https://github.com/contiv/demo.git","svn_url":"https://github.com/contiv/demo","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/demo/pulls/23"},"html":{"href":"https://github.com/contiv/demo/pull/23"},"issue":{"href":"https://api.github.com/repos/contiv/demo/issues/23"},"comments":{"href":"https://api.github.com/repos/contiv/demo/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/demo/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/demo/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/demo/statuses/ab93e246e88c2fe015062fe7cf82c26daaea80e4"}}}}