{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/89394333","pull_request_review_id":9940167,"id":89394333,"diff_hunk":"@@ -0,0 +1,25 @@\n+﻿import virtualColumn = require(\"widgets/virtualGrid/virtualColumn\");\n+\n+/**\n+ * Virtual grid column that renders text in its cells.\n+ */\n+class textColumn implements virtualColumn {\n+    readonly cellClass = \"text-cell\";\n+\n+    constructor(\n+        public dataMemberName: string,\n+        public display: string,\n+        public width: string) {\n+    }\n+\n+    renderCell(item: Object, isSelected: boolean): string {\n+        const cellValue = (item as any)[this.dataMemberName];\n+        if (cellValue != null) {","path":"src/Raven.Studio/typescript/widgets/virtualGrid/textColumn.ts","position":17,"original_position":17,"commit_id":"2a5f80a69c33f6b8b9ec391cfc5f7bdeeb888b82","original_commit_id":"2a5f80a69c33f6b8b9ec391cfc5f7bdeeb888b82","user":{"login":"JudahGabriel","id":312936,"avatar_url":"https://avatars.githubusercontent.com/u/312936?v=3","gravatar_id":"","url":"https://api.github.com/users/JudahGabriel","html_url":"https://github.com/JudahGabriel","followers_url":"https://api.github.com/users/JudahGabriel/followers","following_url":"https://api.github.com/users/JudahGabriel/following{/other_user}","gists_url":"https://api.github.com/users/JudahGabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/JudahGabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudahGabriel/subscriptions","organizations_url":"https://api.github.com/users/JudahGabriel/orgs","repos_url":"https://api.github.com/users/JudahGabriel/repos","events_url":"https://api.github.com/users/JudahGabriel/events{/privacy}","received_events_url":"https://api.github.com/users/JudahGabriel/received_events","type":"User","site_admin":false},"body":"I thought that at first, too. But on closer inspection, we actually want the null check: consider if the value is false-y (e.g. zero), we still want to display it.","created_at":"2016-11-23T20:30:36Z","updated_at":"2016-11-23T20:30:36Z","html_url":"https://github.com/ravendb/ravendb/pull/918#discussion_r89394333","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/918","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/89394333"},"html":{"href":"https://github.com/ravendb/ravendb/pull/918#discussion_r89394333"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/918"}}},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/918","id":95057561,"html_url":"https://github.com/ravendb/ravendb/pull/918","diff_url":"https://github.com/ravendb/ravendb/pull/918.diff","patch_url":"https://github.com/ravendb/ravendb/pull/918.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/918","number":918,"state":"open","locked":false,"title":"RavenDB-5039 First stab at using new virtual grid in edit doc page.","user":{"login":"JudahGabriel","id":312936,"avatar_url":"https://avatars.githubusercontent.com/u/312936?v=3","gravatar_id":"","url":"https://api.github.com/users/JudahGabriel","html_url":"https://github.com/JudahGabriel","followers_url":"https://api.github.com/users/JudahGabriel/followers","following_url":"https://api.github.com/users/JudahGabriel/following{/other_user}","gists_url":"https://api.github.com/users/JudahGabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/JudahGabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudahGabriel/subscriptions","organizations_url":"https://api.github.com/users/JudahGabriel/orgs","repos_url":"https://api.github.com/users/JudahGabriel/repos","events_url":"https://api.github.com/users/JudahGabriel/events{/privacy}","received_events_url":"https://api.github.com/users/JudahGabriel/received_events","type":"User","site_admin":false},"body":"Related docs now display, links are navigable. Remaining: filtering with search, changing from related to collection/recent/starred.","created_at":"2016-11-23T18:31:52Z","updated_at":"2016-11-23T20:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baa8126d8bb04a4c514386144e3ea4855f27b8b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/918/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/918/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/918/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/2a5f80a69c33f6b8b9ec391cfc5f7bdeeb888b82","head":{"label":"JudahGabriel:v4.0","ref":"v4.0","sha":"2a5f80a69c33f6b8b9ec391cfc5f7bdeeb888b82","user":{"login":"JudahGabriel","id":312936,"avatar_url":"https://avatars.githubusercontent.com/u/312936?v=3","gravatar_id":"","url":"https://api.github.com/users/JudahGabriel","html_url":"https://github.com/JudahGabriel","followers_url":"https://api.github.com/users/JudahGabriel/followers","following_url":"https://api.github.com/users/JudahGabriel/following{/other_user}","gists_url":"https://api.github.com/users/JudahGabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/JudahGabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudahGabriel/subscriptions","organizations_url":"https://api.github.com/users/JudahGabriel/orgs","repos_url":"https://api.github.com/users/JudahGabriel/repos","events_url":"https://api.github.com/users/JudahGabriel/events{/privacy}","received_events_url":"https://api.github.com/users/JudahGabriel/received_events","type":"User","site_admin":false},"repo":{"id":10657781,"name":"ravendb","full_name":"JudahGabriel/ravendb","owner":{"login":"JudahGabriel","id":312936,"avatar_url":"https://avatars.githubusercontent.com/u/312936?v=3","gravatar_id":"","url":"https://api.github.com/users/JudahGabriel","html_url":"https://github.com/JudahGabriel","followers_url":"https://api.github.com/users/JudahGabriel/followers","following_url":"https://api.github.com/users/JudahGabriel/following{/other_user}","gists_url":"https://api.github.com/users/JudahGabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/JudahGabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JudahGabriel/subscriptions","organizations_url":"https://api.github.com/users/JudahGabriel/orgs","repos_url":"https://api.github.com/users/JudahGabriel/repos","events_url":"https://api.github.com/users/JudahGabriel/events{/privacy}","received_events_url":"https://api.github.com/users/JudahGabriel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JudahGabriel/ravendb","description":"A linq enabled document database for .NET","fork":true,"url":"https://api.github.com/repos/JudahGabriel/ravendb","forks_url":"https://api.github.com/repos/JudahGabriel/ravendb/forks","keys_url":"https://api.github.com/repos/JudahGabriel/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JudahGabriel/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JudahGabriel/ravendb/teams","hooks_url":"https://api.github.com/repos/JudahGabriel/ravendb/hooks","issue_events_url":"https://api.github.com/repos/JudahGabriel/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/JudahGabriel/ravendb/events","assignees_url":"https://api.github.com/repos/JudahGabriel/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/JudahGabriel/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/JudahGabriel/ravendb/tags","blobs_url":"https://api.github.com/repos/JudahGabriel/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JudahGabriel/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JudahGabriel/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/JudahGabriel/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JudahGabriel/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/JudahGabriel/ravendb/languages","stargazers_url":"https://api.github.com/repos/JudahGabriel/ravendb/stargazers","contributors_url":"https://api.github.com/repos/JudahGabriel/ravendb/contributors","subscribers_url":"https://api.github.com/repos/JudahGabriel/ravendb/subscribers","subscription_url":"https://api.github.com/repos/JudahGabriel/ravendb/subscription","commits_url":"https://api.github.com/repos/JudahGabriel/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/JudahGabriel/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/JudahGabriel/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/JudahGabriel/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/JudahGabriel/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/JudahGabriel/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JudahGabriel/ravendb/merges","archive_url":"https://api.github.com/repos/JudahGabriel/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JudahGabriel/ravendb/downloads","issues_url":"https://api.github.com/repos/JudahGabriel/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/JudahGabriel/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/JudahGabriel/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/JudahGabriel/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JudahGabriel/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/JudahGabriel/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/JudahGabriel/ravendb/deployments","created_at":"2013-06-13T03:15:50Z","updated_at":"2016-09-11T21:21:30Z","pushed_at":"2016-11-23T18:29:13Z","git_url":"git://github.com/JudahGabriel/ravendb.git","ssh_url":"git@github.com:JudahGabriel/ravendb.git","clone_url":"https://github.com/JudahGabriel/ravendb.git","svn_url":"https://github.com/JudahGabriel/ravendb","homepage":"http://ayende.com/Blog/","size":381034,"stargazers_count":37,"watchers_count":37,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":0,"forks":18,"open_issues":0,"watchers":37,"default_branch":"master"}},"base":{"label":"ravendb:v4.0","ref":"v4.0","sha":"f8c0271e1b2116d13dfc1ca1774f7834184d59e1","user":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"name":"ravendb","full_name":"ravendb/ravendb","owner":{"login":"ravendb","id":213792,"avatar_url":"https://avatars.githubusercontent.com/u/213792?v=3","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ravendb/ravendb","description":"A linq enabled document database for .NET","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2016-11-22T09:28:40Z","pushed_at":"2016-11-23T20:02:00Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"http://ravendb.net","size":410178,"stargazers_count":1591,"watchers_count":1591,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":5,"forks":641,"open_issues":5,"watchers":1591,"default_branch":"v3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/918"},"html":{"href":"https://github.com/ravendb/ravendb/pull/918"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/918"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/918/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/918/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/918/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/2a5f80a69c33f6b8b9ec391cfc5f7bdeeb888b82"}}}}
{"actor":{"display_login":"JudahGabriel"}}