{"action":"opened","issue":{"url":"https://api.github.com/repos/Fluorohydride/ygopro-pre-script/issues/16","repository_url":"https://api.github.com/repos/Fluorohydride/ygopro-pre-script","labels_url":"https://api.github.com/repos/Fluorohydride/ygopro-pre-script/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/Fluorohydride/ygopro-pre-script/issues/16/comments","events_url":"https://api.github.com/repos/Fluorohydride/ygopro-pre-script/issues/16/events","html_url":"https://github.com/Fluorohydride/ygopro-pre-script/issues/16","id":139206996,"number":16,"title":"set code fixes?","user":{"login":"YGO5upp0r73r","id":13621768,"avatar_url":"https://avatars.githubusercontent.com/u/13621768?v=3","gravatar_id":"","url":"https://api.github.com/users/YGO5upp0r73r","html_url":"https://github.com/YGO5upp0r73r","followers_url":"https://api.github.com/users/YGO5upp0r73r/followers","following_url":"https://api.github.com/users/YGO5upp0r73r/following{/other_user}","gists_url":"https://api.github.com/users/YGO5upp0r73r/gists{/gist_id}","starred_url":"https://api.github.com/users/YGO5upp0r73r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YGO5upp0r73r/subscriptions","organizations_url":"https://api.github.com/users/YGO5upp0r73r/orgs","repos_url":"https://api.github.com/users/YGO5upp0r73r/repos","events_url":"https://api.github.com/users/YGO5upp0r73r/events{/privacy}","received_events_url":"https://api.github.com/users/YGO5upp0r73r/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-08T07:59:06Z","updated_at":"2016-03-08T07:59:06Z","closed_at":null,"body":"I could be wrong but inside strings.conf there's a set code list and Steelswarm is listed as** 0x100a Steelswarm.**\r\n\r\n**Correct me if I'm wrong, but I believe it should look like this:**\r\n!setcode 0xa lswarm\r\n!setcode 0x10a Steelswarm\r\n!setcode 0x100a Evilswarm\r\n\r\nAlso, shouldn't these should be renamed?\r\n- !setcode 0x307b Galaxy-Eyes Tachyon -> !setcode 0x307b Galaxy-Eyes Tachyon _Dragon_\r\nhttp://yugioh.wikia.com/wiki/Galaxy-Eyes_Tachyon_Dragon\r\n- !setcode 0x100 Synchron Synchos -> !setcode 0x100 Synchron _Synchros_\r\n_(spelling)_\r\n- !setcode 0x102 Evil Hero Fusions -> !setcode 0x102 Evil _HERO_ Fusions\r\n_(PSCT)_\r\n- !setcode 0x85 Super-Defense -> !setcode 0x85 Super _Defense Robot_\r\n_(TCG updated)_\r\n- !setcode 0x87 Umbrals -> !setcode 0x87 Umbral _Horror_\r\n_(TCG updated)_\r\n- !setcode 0x8b Malicvorous -> !setcode 0x8b Malic_e_vorous\r\n(spelling)\r\n- !setcode 0x95 Rank-Up Magic -> !setcode 0x95 Rank-_Up-Magic_\r\n_(grammar)_\r\n- !setcode 0x98 Magician Pendulum Monster -> !setcode 0x98 _Magician_\r\n_Not limited to Pendulums:_ http://yugioh.wikia.com/wiki/Magician_%28archetype%29\r\n!setcode 0xa6 Sprout -> !setcode 0xa6 _sprout_\r\n_(grammar):_ http://yugioh.wikia.com/wiki/Sprout\r\n- !setcode 0xc9 Aromage -> !setcode 0xc9 _Aroma_\r\n_(TCG updated)_\r\n- !setcode 0xdb Phantom- -> !setcode 0xdb _Phantom Knights_\r\n_(TCG updated)_\r\n- !setcode 0xdc Super Quantum -> !setcode 0xdc Super _Quant_\r\n_(TCG updated)_\r\n- !setcode 0x10dc Super Quantum Mecha Pilot -> !setcode 0x10dc _Super Quantum_\r\n_(TCG updated)_\r\n- !setcode 0x20dc Super Quantum Mecha Beast -> !setcode 0x20dc Super _Quantal_ Mecha Beast\r\n_(TCG updated)_\r\n\r\n*I could be wrong with these two:*\r\n- !setcode 0x8a Fascinating ->!setcode 0x8a _Hole_\r\nhttp://yugioh.wikia.com/wiki/Hole\r\n- !setcode 0x89 Hole -> !setcode 0x89 _Trap_ Hole\r\n\r\nAlso, since these [*] are sub-archetypes, why not list them under the parent, like this:\r\n!setcode 0x1b Phantom Beast\r\n!setcode 0x101b Mecha Phantom Beast [*]\r\n!setcode 0x48 Number\r\n!setcode 0x1048 Number C [*]\r\n!setcode 0x6f Heroic\r\n!setcode 0x106f Heroic Challenger\r\n!setcode 0x206f Heroic Champion [*]\r\n!setcode 0x73 Xyz\r\n!setcode 0x1073 CXyz\r\n\r\nFinally, shouldn't this set code: **!setcode 0x4f _Buster_**\r\nbe renamed to: **!setcode 0x4f _/Assault_**\r\n\r\nI think \"Buster\" is the Japanese translated term for the /Assault Mode set code, therefore,\r\nthe parent set code should be /Assault\r\nand it's sub set code /Assault Mode, right?\r\n\r\nThanks, keep up this Github!"}}