{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-cni/pulls/comments/68117371","id":68117371,"diff_hunk":"@@ -131,6 +131,14 @@ def generate_tags(self):\n         \"\"\"\n         return []\n \n+class MesosPolicyDriver(DefaultPolicyDriver):\n+    def generate_rules(self):\n+        allow = Rule(action=\"allow\")\n+        rules = Rules(id=self.profile_name,\n+                      inbound_rules=[allow],","path":"calico_cni/policy_drivers.py","position":8,"original_position":8,"commit_id":"81697e933c4b0bcb9bd77540e1d46c313e1215bf","original_commit_id":"81697e933c4b0bcb9bd77540e1d46c313e1215bf","user":{"login":"caseydavenport","id":1944093,"avatar_url":"https://avatars.githubusercontent.com/u/1944093?v=3","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"I don't think this is correct - Mesos supports multiple CNI networks that need to be isolated from each other by default, so they shouldn't allow all inbound by default.","created_at":"2016-06-22T19:19:00Z","updated_at":"2016-06-22T19:19:00Z","html_url":"https://github.com/projectcalico/calico-cni/pull/99#discussion_r68117371","pull_request_url":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-cni/pulls/comments/68117371"},"html":{"href":"https://github.com/projectcalico/calico-cni/pull/99#discussion_r68117371"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99","id":71631391,"html_url":"https://github.com/projectcalico/calico-cni/pull/99","diff_url":"https://github.com/projectcalico/calico-cni/pull/99.diff","patch_url":"https://github.com/projectcalico/calico-cni/pull/99.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-cni/issues/99","number":99,"state":"open","locked":false,"title":"Added labels","user":{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-26T21:57:35Z","updated_at":"2016-06-22T19:19:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bd73a036fbc45be26bfb53b211ef1903ec9419f","assignee":{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-cni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-cni/issues/99/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-cni/statuses/81697e933c4b0bcb9bd77540e1d46c313e1215bf","head":{"label":"djosborne:labels","ref":"labels","sha":"81697e933c4b0bcb9bd77540e1d46c313e1215bf","user":{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false},"repo":{"id":59245660,"name":"calico-cni","full_name":"djosborne/calico-cni","owner":{"login":"djosborne","id":3444362,"avatar_url":"https://avatars.githubusercontent.com/u/3444362?v=3","gravatar_id":"","url":"https://api.github.com/users/djosborne","html_url":"https://github.com/djosborne","followers_url":"https://api.github.com/users/djosborne/followers","following_url":"https://api.github.com/users/djosborne/following{/other_user}","gists_url":"https://api.github.com/users/djosborne/gists{/gist_id}","starred_url":"https://api.github.com/users/djosborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djosborne/subscriptions","organizations_url":"https://api.github.com/users/djosborne/orgs","repos_url":"https://api.github.com/users/djosborne/repos","events_url":"https://api.github.com/users/djosborne/events{/privacy}","received_events_url":"https://api.github.com/users/djosborne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djosborne/calico-cni","description":"Calico CNI plugin","fork":true,"url":"https://api.github.com/repos/djosborne/calico-cni","forks_url":"https://api.github.com/repos/djosborne/calico-cni/forks","keys_url":"https://api.github.com/repos/djosborne/calico-cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djosborne/calico-cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djosborne/calico-cni/teams","hooks_url":"https://api.github.com/repos/djosborne/calico-cni/hooks","issue_events_url":"https://api.github.com/repos/djosborne/calico-cni/issues/events{/number}","events_url":"https://api.github.com/repos/djosborne/calico-cni/events","assignees_url":"https://api.github.com/repos/djosborne/calico-cni/assignees{/user}","branches_url":"https://api.github.com/repos/djosborne/calico-cni/branches{/branch}","tags_url":"https://api.github.com/repos/djosborne/calico-cni/tags","blobs_url":"https://api.github.com/repos/djosborne/calico-cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djosborne/calico-cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djosborne/calico-cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/djosborne/calico-cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djosborne/calico-cni/statuses/{sha}","languages_url":"https://api.github.com/repos/djosborne/calico-cni/languages","stargazers_url":"https://api.github.com/repos/djosborne/calico-cni/stargazers","contributors_url":"https://api.github.com/repos/djosborne/calico-cni/contributors","subscribers_url":"https://api.github.com/repos/djosborne/calico-cni/subscribers","subscription_url":"https://api.github.com/repos/djosborne/calico-cni/subscription","commits_url":"https://api.github.com/repos/djosborne/calico-cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/djosborne/calico-cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/djosborne/calico-cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/djosborne/calico-cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/djosborne/calico-cni/contents/{+path}","compare_url":"https://api.github.com/repos/djosborne/calico-cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djosborne/calico-cni/merges","archive_url":"https://api.github.com/repos/djosborne/calico-cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djosborne/calico-cni/downloads","issues_url":"https://api.github.com/repos/djosborne/calico-cni/issues{/number}","pulls_url":"https://api.github.com/repos/djosborne/calico-cni/pulls{/number}","milestones_url":"https://api.github.com/repos/djosborne/calico-cni/milestones{/number}","notifications_url":"https://api.github.com/repos/djosborne/calico-cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djosborne/calico-cni/labels{/name}","releases_url":"https://api.github.com/repos/djosborne/calico-cni/releases{/id}","deployments_url":"https://api.github.com/repos/djosborne/calico-cni/deployments","created_at":"2016-05-19T21:59:53Z","updated_at":"2016-05-19T21:59:55Z","pushed_at":"2016-06-21T20:51:48Z","git_url":"git://github.com/djosborne/calico-cni.git","ssh_url":"git@github.com:djosborne/calico-cni.git","clone_url":"https://github.com/djosborne/calico-cni.git","svn_url":"https://github.com/djosborne/calico-cni","homepage":"http://www.projectcalico.org/","size":265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"4ff31be9546b1f8adb9c5adee0d3e5495c5ad82b","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":39909298,"name":"calico-cni","full_name":"projectcalico/calico-cni","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-cni","description":"Calico CNI plugin","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-cni","forks_url":"https://api.github.com/repos/projectcalico/calico-cni/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-cni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-cni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-cni/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-cni/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-cni/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-cni/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-cni/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-cni/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-cni/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-cni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-cni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-cni/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-cni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-cni/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-cni/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-cni/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-cni/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-cni/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-cni/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-cni/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-cni/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-cni/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-cni/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-cni/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-cni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-cni/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-cni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-cni/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-cni/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-cni/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-cni/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-cni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-cni/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-cni/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calico-cni/deployments","created_at":"2015-07-29T18:23:48Z","updated_at":"2016-06-18T18:30:00Z","pushed_at":"2016-06-21T20:42:59Z","git_url":"git://github.com/projectcalico/calico-cni.git","ssh_url":"git@github.com:projectcalico/calico-cni.git","clone_url":"https://github.com/projectcalico/calico-cni.git","svn_url":"https://github.com/projectcalico/calico-cni","homepage":"http://www.projectcalico.org/","size":5203,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":17,"forks":13,"open_issues":17,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99"},"html":{"href":"https://github.com/projectcalico/calico-cni/pull/99"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-cni/issues/99"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-cni/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-cni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-cni/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-cni/statuses/81697e933c4b0bcb9bd77540e1d46c313e1215bf"}}}}
{"actor":{"display_login":"caseydavenport"}}