{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/60409422","id":60409422,"diff_hunk":"@@ -118,6 +130,11 @@ public Response cypher(String body,\n                 includePlan = result.getQueryExecutionType().requestedExecutionPlanDescription();\n             }\n \n+            if ( periodicCommitQuery )\n+            {\n+                handler.setTransaction( database.beginTx() );","path":"community/server/src/main/java/org/neo4j/server/rest/web/CypherService.java","position":56,"original_position":56,"commit_id":"d34de48cf7e20ebaf7673571063792d5cb3c1f40","original_commit_id":"d34de48cf7e20ebaf7673571063792d5cb3c1f40","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"Yes we should","created_at":"2016-04-20T13:46:19Z","updated_at":"2016-04-20T13:46:19Z","html_url":"https://github.com/neo4j/neo4j/pull/6995#discussion_r60409422","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6995","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/60409422"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6995#discussion_r60409422"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6995"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/6995","id":67176058,"html_url":"https://github.com/neo4j/neo4j/pull/6995","diff_url":"https://github.com/neo4j/neo4j/pull/6995.diff","patch_url":"https://github.com/neo4j/neo4j/pull/6995.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/6995","number":6995,"state":"open","locked":false,"title":"Fix periodic commit in server","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"Periodic commit wasn't working in server due to the fact of nesting a\r\nplacebo transaction for executing the Cypher statement. This placebo\r\ntransaction was preventing periodic commit to actually commit in the\r\nmiddle of the query.  This commit fixes that behaviour by executing\r\nperiodic commit in a toplevel transaction.","created_at":"2016-04-20T12:15:37Z","updated_at":"2016-04-20T13:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6417fea0d875a2968a8d19cd8bfb3cb0f7895695","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6995/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/6995/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/6995/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/d34de48cf7e20ebaf7673571063792d5cb3c1f40","head":{"label":"davidegrohmann:3.0-fix-periodic-commit-server","ref":"3.0-fix-periodic-commit-server","sha":"d34de48cf7e20ebaf7673571063792d5cb3c1f40","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"repo":{"id":16693960,"name":"neo4j","full_name":"davidegrohmann/neo4j","owner":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidegrohmann/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/davidegrohmann/neo4j","forks_url":"https://api.github.com/repos/davidegrohmann/neo4j/forks","keys_url":"https://api.github.com/repos/davidegrohmann/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidegrohmann/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidegrohmann/neo4j/teams","hooks_url":"https://api.github.com/repos/davidegrohmann/neo4j/hooks","issue_events_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/davidegrohmann/neo4j/events","assignees_url":"https://api.github.com/repos/davidegrohmann/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/davidegrohmann/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/tags","blobs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidegrohmann/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/davidegrohmann/neo4j/languages","stargazers_url":"https://api.github.com/repos/davidegrohmann/neo4j/stargazers","contributors_url":"https://api.github.com/repos/davidegrohmann/neo4j/contributors","subscribers_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscribers","subscription_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscription","commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidegrohmann/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidegrohmann/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/davidegrohmann/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidegrohmann/neo4j/merges","archive_url":"https://api.github.com/repos/davidegrohmann/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidegrohmann/neo4j/downloads","issues_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/davidegrohmann/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/davidegrohmann/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/davidegrohmann/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidegrohmann/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/davidegrohmann/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/davidegrohmann/neo4j/deployments","created_at":"2014-02-10T11:59:43Z","updated_at":"2015-10-01T08:40:18Z","pushed_at":"2016-04-20T12:13:46Z","git_url":"git://github.com/davidegrohmann/neo4j.git","ssh_url":"git@github.com:davidegrohmann/neo4j.git","clone_url":"https://github.com/davidegrohmann/neo4j.git","svn_url":"https://github.com/davidegrohmann/neo4j","homepage":"http://neo4j.org","size":289921,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.0","ref":"3.0","sha":"9e2aa8d6f906a8085ea7ed7e99d45f7fc0733d10","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-04-20T07:26:15Z","pushed_at":"2016-04-20T12:49:53Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":357582,"stargazers_count":2533,"watchers_count":2533,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":894,"mirror_url":null,"open_issues_count":410,"forks":894,"open_issues":410,"watchers":2533,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6995"},"html":{"href":"https://github.com/neo4j/neo4j/pull/6995"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6995"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/6995/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6995/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/6995/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/d34de48cf7e20ebaf7673571063792d5cb3c1f40"}}}}