{"action":"opened","number":22,"pull_request":{"url":"https://api.github.com/repos/v00d00/mediatomb/pulls/22","id":99390736,"html_url":"https://github.com/v00d00/mediatomb/pull/22","diff_url":"https://github.com/v00d00/mediatomb/pull/22.diff","patch_url":"https://github.com/v00d00/mediatomb/pull/22.patch","issue_url":"https://api.github.com/repos/v00d00/mediatomb/issues/22","number":22,"state":"open","locked":false,"title":"Re-Fix Solaris, Further Fix for 1.8 LibUPNP","user":{"login":"whorfin","id":1237590,"avatar_url":"https://avatars.githubusercontent.com/u/1237590?v=3","gravatar_id":"","url":"https://api.github.com/users/whorfin","html_url":"https://github.com/whorfin","followers_url":"https://api.github.com/users/whorfin/followers","following_url":"https://api.github.com/users/whorfin/following{/other_user}","gists_url":"https://api.github.com/users/whorfin/gists{/gist_id}","starred_url":"https://api.github.com/users/whorfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whorfin/subscriptions","organizations_url":"https://api.github.com/users/whorfin/orgs","repos_url":"https://api.github.com/users/whorfin/repos","events_url":"https://api.github.com/users/whorfin/events{/privacy}","received_events_url":"https://api.github.com/users/whorfin/received_events","type":"User","site_admin":false},"body":"Re: 7310ef10a0989711da7bf35fefebea51c9bab1df, we can't totally remove OS detection, because there are #ifdef SOLARIS references in the code, required for proper compilation, and for safety with the LD_PRELOAD trick for Posix semantics on NULL printfs.\r\nHence, detection and insertion of -DSOLARIS is still required.\r\n\r\nIf you'd prefer trimming the non-solaroid os portions of detection, we can do that, but since there\r\nis one dependency, it made sense to me to have a nice clear \"here is where we detect the various OSs\" section, distinct from \"here is where we do something based upon this\"\r\n\r\nAlso for bonus points, when I did a full merge, that required re-pulling pupnp for the 1.8 named directories.\r\nRe-building didn't clear the old ones, which I did to ensure cleanliness.\r\n...and promptly found a few places in mediatomb referencing non-1.8 paths; surely this is a bad idea.\r\nFixed.\r\n\r\nCheers\r\n","created_at":"2016-12-26T21:08:33Z","updated_at":"2016-12-26T21:08:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/v00d00/mediatomb/pulls/22/commits","review_comments_url":"https://api.github.com/repos/v00d00/mediatomb/pulls/22/comments","review_comment_url":"https://api.github.com/repos/v00d00/mediatomb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/v00d00/mediatomb/issues/22/comments","statuses_url":"https://api.github.com/repos/v00d00/mediatomb/statuses/e186429d9fa9d75cfddc63f8ad7d7f69c2ad6b45","head":{"label":"whorfin:master","ref":"master","sha":"e186429d9fa9d75cfddc63f8ad7d7f69c2ad6b45","user":{"login":"whorfin","id":1237590,"avatar_url":"https://avatars.githubusercontent.com/u/1237590?v=3","gravatar_id":"","url":"https://api.github.com/users/whorfin","html_url":"https://github.com/whorfin","followers_url":"https://api.github.com/users/whorfin/followers","following_url":"https://api.github.com/users/whorfin/following{/other_user}","gists_url":"https://api.github.com/users/whorfin/gists{/gist_id}","starred_url":"https://api.github.com/users/whorfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whorfin/subscriptions","organizations_url":"https://api.github.com/users/whorfin/orgs","repos_url":"https://api.github.com/users/whorfin/repos","events_url":"https://api.github.com/users/whorfin/events{/privacy}","received_events_url":"https://api.github.com/users/whorfin/received_events","type":"User","site_admin":false},"repo":{"id":76220748,"name":"mediatomb","full_name":"whorfin/mediatomb","owner":{"login":"whorfin","id":1237590,"avatar_url":"https://avatars.githubusercontent.com/u/1237590?v=3","gravatar_id":"","url":"https://api.github.com/users/whorfin","html_url":"https://github.com/whorfin","followers_url":"https://api.github.com/users/whorfin/followers","following_url":"https://api.github.com/users/whorfin/following{/other_user}","gists_url":"https://api.github.com/users/whorfin/gists{/gist_id}","starred_url":"https://api.github.com/users/whorfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whorfin/subscriptions","organizations_url":"https://api.github.com/users/whorfin/orgs","repos_url":"https://api.github.com/users/whorfin/repos","events_url":"https://api.github.com/users/whorfin/events{/privacy}","received_events_url":"https://api.github.com/users/whorfin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whorfin/mediatomb","description":"MediaTomb for 2016","fork":true,"url":"https://api.github.com/repos/whorfin/mediatomb","forks_url":"https://api.github.com/repos/whorfin/mediatomb/forks","keys_url":"https://api.github.com/repos/whorfin/mediatomb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whorfin/mediatomb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whorfin/mediatomb/teams","hooks_url":"https://api.github.com/repos/whorfin/mediatomb/hooks","issue_events_url":"https://api.github.com/repos/whorfin/mediatomb/issues/events{/number}","events_url":"https://api.github.com/repos/whorfin/mediatomb/events","assignees_url":"https://api.github.com/repos/whorfin/mediatomb/assignees{/user}","branches_url":"https://api.github.com/repos/whorfin/mediatomb/branches{/branch}","tags_url":"https://api.github.com/repos/whorfin/mediatomb/tags","blobs_url":"https://api.github.com/repos/whorfin/mediatomb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whorfin/mediatomb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whorfin/mediatomb/git/refs{/sha}","trees_url":"https://api.github.com/repos/whorfin/mediatomb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whorfin/mediatomb/statuses/{sha}","languages_url":"https://api.github.com/repos/whorfin/mediatomb/languages","stargazers_url":"https://api.github.com/repos/whorfin/mediatomb/stargazers","contributors_url":"https://api.github.com/repos/whorfin/mediatomb/contributors","subscribers_url":"https://api.github.com/repos/whorfin/mediatomb/subscribers","subscription_url":"https://api.github.com/repos/whorfin/mediatomb/subscription","commits_url":"https://api.github.com/repos/whorfin/mediatomb/commits{/sha}","git_commits_url":"https://api.github.com/repos/whorfin/mediatomb/git/commits{/sha}","comments_url":"https://api.github.com/repos/whorfin/mediatomb/comments{/number}","issue_comment_url":"https://api.github.com/repos/whorfin/mediatomb/issues/comments{/number}","contents_url":"https://api.github.com/repos/whorfin/mediatomb/contents/{+path}","compare_url":"https://api.github.com/repos/whorfin/mediatomb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whorfin/mediatomb/merges","archive_url":"https://api.github.com/repos/whorfin/mediatomb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whorfin/mediatomb/downloads","issues_url":"https://api.github.com/repos/whorfin/mediatomb/issues{/number}","pulls_url":"https://api.github.com/repos/whorfin/mediatomb/pulls{/number}","milestones_url":"https://api.github.com/repos/whorfin/mediatomb/milestones{/number}","notifications_url":"https://api.github.com/repos/whorfin/mediatomb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whorfin/mediatomb/labels{/name}","releases_url":"https://api.github.com/repos/whorfin/mediatomb/releases{/id}","deployments_url":"https://api.github.com/repos/whorfin/mediatomb/deployments","created_at":"2016-12-12T04:01:23Z","updated_at":"2016-12-12T04:01:25Z","pushed_at":"2016-12-26T21:02:26Z","git_url":"git://github.com/whorfin/mediatomb.git","ssh_url":"git@github.com:whorfin/mediatomb.git","clone_url":"https://github.com/whorfin/mediatomb.git","svn_url":"https://github.com/whorfin/mediatomb","homepage":"http://sourceforge.net/projects/mediatomb/","size":7734,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"v00d00:master","ref":"master","sha":"3296debf36432b173660a2f29311d6677c2d0772","user":{"login":"v00d00","id":345034,"avatar_url":"https://avatars.githubusercontent.com/u/345034?v=3","gravatar_id":"","url":"https://api.github.com/users/v00d00","html_url":"https://github.com/v00d00","followers_url":"https://api.github.com/users/v00d00/followers","following_url":"https://api.github.com/users/v00d00/following{/other_user}","gists_url":"https://api.github.com/users/v00d00/gists{/gist_id}","starred_url":"https://api.github.com/users/v00d00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v00d00/subscriptions","organizations_url":"https://api.github.com/users/v00d00/orgs","repos_url":"https://api.github.com/users/v00d00/repos","events_url":"https://api.github.com/users/v00d00/events{/privacy}","received_events_url":"https://api.github.com/users/v00d00/received_events","type":"User","site_admin":false},"repo":{"id":22786524,"name":"mediatomb","full_name":"v00d00/mediatomb","owner":{"login":"v00d00","id":345034,"avatar_url":"https://avatars.githubusercontent.com/u/345034?v=3","gravatar_id":"","url":"https://api.github.com/users/v00d00","html_url":"https://github.com/v00d00","followers_url":"https://api.github.com/users/v00d00/followers","following_url":"https://api.github.com/users/v00d00/following{/other_user}","gists_url":"https://api.github.com/users/v00d00/gists{/gist_id}","starred_url":"https://api.github.com/users/v00d00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v00d00/subscriptions","organizations_url":"https://api.github.com/users/v00d00/orgs","repos_url":"https://api.github.com/users/v00d00/repos","events_url":"https://api.github.com/users/v00d00/events{/privacy}","received_events_url":"https://api.github.com/users/v00d00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/v00d00/mediatomb","description":"MediaTomb for 2016","fork":false,"url":"https://api.github.com/repos/v00d00/mediatomb","forks_url":"https://api.github.com/repos/v00d00/mediatomb/forks","keys_url":"https://api.github.com/repos/v00d00/mediatomb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v00d00/mediatomb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v00d00/mediatomb/teams","hooks_url":"https://api.github.com/repos/v00d00/mediatomb/hooks","issue_events_url":"https://api.github.com/repos/v00d00/mediatomb/issues/events{/number}","events_url":"https://api.github.com/repos/v00d00/mediatomb/events","assignees_url":"https://api.github.com/repos/v00d00/mediatomb/assignees{/user}","branches_url":"https://api.github.com/repos/v00d00/mediatomb/branches{/branch}","tags_url":"https://api.github.com/repos/v00d00/mediatomb/tags","blobs_url":"https://api.github.com/repos/v00d00/mediatomb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v00d00/mediatomb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v00d00/mediatomb/git/refs{/sha}","trees_url":"https://api.github.com/repos/v00d00/mediatomb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v00d00/mediatomb/statuses/{sha}","languages_url":"https://api.github.com/repos/v00d00/mediatomb/languages","stargazers_url":"https://api.github.com/repos/v00d00/mediatomb/stargazers","contributors_url":"https://api.github.com/repos/v00d00/mediatomb/contributors","subscribers_url":"https://api.github.com/repos/v00d00/mediatomb/subscribers","subscription_url":"https://api.github.com/repos/v00d00/mediatomb/subscription","commits_url":"https://api.github.com/repos/v00d00/mediatomb/commits{/sha}","git_commits_url":"https://api.github.com/repos/v00d00/mediatomb/git/commits{/sha}","comments_url":"https://api.github.com/repos/v00d00/mediatomb/comments{/number}","issue_comment_url":"https://api.github.com/repos/v00d00/mediatomb/issues/comments{/number}","contents_url":"https://api.github.com/repos/v00d00/mediatomb/contents/{+path}","compare_url":"https://api.github.com/repos/v00d00/mediatomb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v00d00/mediatomb/merges","archive_url":"https://api.github.com/repos/v00d00/mediatomb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v00d00/mediatomb/downloads","issues_url":"https://api.github.com/repos/v00d00/mediatomb/issues{/number}","pulls_url":"https://api.github.com/repos/v00d00/mediatomb/pulls{/number}","milestones_url":"https://api.github.com/repos/v00d00/mediatomb/milestones{/number}","notifications_url":"https://api.github.com/repos/v00d00/mediatomb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v00d00/mediatomb/labels{/name}","releases_url":"https://api.github.com/repos/v00d00/mediatomb/releases{/id}","deployments_url":"https://api.github.com/repos/v00d00/mediatomb/deployments","created_at":"2014-08-09T13:17:53Z","updated_at":"2016-12-25T23:20:54Z","pushed_at":"2016-12-26T18:27:17Z","git_url":"git://github.com/v00d00/mediatomb.git","ssh_url":"git@github.com:v00d00/mediatomb.git","clone_url":"https://github.com/v00d00/mediatomb.git","svn_url":"https://github.com/v00d00/mediatomb","homepage":"http://sourceforge.net/projects/mediatomb/","size":7696,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/v00d00/mediatomb/pulls/22"},"html":{"href":"https://github.com/v00d00/mediatomb/pull/22"},"issue":{"href":"https://api.github.com/repos/v00d00/mediatomb/issues/22"},"comments":{"href":"https://api.github.com/repos/v00d00/mediatomb/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/v00d00/mediatomb/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/v00d00/mediatomb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/v00d00/mediatomb/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/v00d00/mediatomb/statuses/e186429d9fa9d75cfddc63f8ad7d7f69c2ad6b45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":11,"additions":26,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"whorfin"}}