{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/comments/68988317","id":68988317,"diff_hunk":"@@ -0,0 +1,87 @@\n+package com.gu.contentapi.firehose.kinesis\n+\n+import com.amazonaws.services.kinesis.model.Record\n+import com.amazonaws.services.kinesis.clientlibrary.interfaces.{ IRecordProcessor, IRecordProcessorCheckpointer }\n+import com.amazonaws.services.kinesis.clientlibrary.types.ShutdownReason\n+import com.typesafe.scalalogging.LazyLogging\n+import com.twitter.scrooge.ThriftStruct\n+import java.util.concurrent.atomic.{ AtomicInteger, AtomicLong }\n+import java.util.{ List => JList }\n+import scala.collection.JavaConverters._\n+import scala.concurrent.duration._\n+import scala.util.{ Failure, Success }\n+\n+abstract class EventProcessor[EventT <: ThriftStruct](\n+  checkpointInterval: Duration = 30.seconds,","path":"src/main/scala/com/gu/contentapi/firehose/kinesis/SingleEventProcessor.scala","position":15,"original_position":15,"commit_id":"c6c226d927f13df484c837b8629b0eaf6075fe5f","original_commit_id":"c6c226d927f13df484c837b8629b0eaf6075fe5f","user":{"login":"cb372","id":106760,"avatar_url":"https://avatars.githubusercontent.com/u/106760?v=3","gravatar_id":"","url":"https://api.github.com/users/cb372","html_url":"https://github.com/cb372","followers_url":"https://api.github.com/users/cb372/followers","following_url":"https://api.github.com/users/cb372/following{/other_user}","gists_url":"https://api.github.com/users/cb372/gists{/gist_id}","starred_url":"https://api.github.com/users/cb372/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb372/subscriptions","organizations_url":"https://api.github.com/users/cb372/orgs","repos_url":"https://api.github.com/users/cb372/repos","events_url":"https://api.github.com/users/cb372/events{/privacy}","received_events_url":"https://api.github.com/users/cb372/received_events","type":"User","site_admin":false},"body":"I'd remove the defaults from here, as you already have defaults for these values elsewhere. Multiple levels of default argument can get pretty confusing.","created_at":"2016-06-29T17:15:15Z","updated_at":"2016-06-29T17:15:16Z","html_url":"https://github.com/guardian/content-api-firehose-client/pull/1#discussion_r68988317","pull_request_url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/comments/68988317"},"html":{"href":"https://github.com/guardian/content-api-firehose-client/pull/1#discussion_r68988317"},"pull_request":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1","id":75487813,"html_url":"https://github.com/guardian/content-api-firehose-client/pull/1","diff_url":"https://github.com/guardian/content-api-firehose-client/pull/1.diff","patch_url":"https://github.com/guardian/content-api-firehose-client/pull/1.patch","issue_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/1","number":1,"state":"open","locked":false,"title":"Move Kinesis stream logic into library.","user":{"login":"LATaylor-guardian","id":8861681,"avatar_url":"https://avatars.githubusercontent.com/u/8861681?v=3","gravatar_id":"","url":"https://api.github.com/users/LATaylor-guardian","html_url":"https://github.com/LATaylor-guardian","followers_url":"https://api.github.com/users/LATaylor-guardian/followers","following_url":"https://api.github.com/users/LATaylor-guardian/following{/other_user}","gists_url":"https://api.github.com/users/LATaylor-guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/LATaylor-guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LATaylor-guardian/subscriptions","organizations_url":"https://api.github.com/users/LATaylor-guardian/orgs","repos_url":"https://api.github.com/users/LATaylor-guardian/repos","events_url":"https://api.github.com/users/LATaylor-guardian/events{/privacy}","received_events_url":"https://api.github.com/users/LATaylor-guardian/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-28T14:32:25Z","updated_at":"2016-06-29T17:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f83871efc6fcd76c2c429ae1116ff5d8ed2dc8c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1/commits","review_comments_url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1/comments","review_comment_url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/1/comments","statuses_url":"https://api.github.com/repos/guardian/content-api-firehose-client/statuses/c6c226d927f13df484c837b8629b0eaf6075fe5f","head":{"label":"guardian:move-code-into-library","ref":"move-code-into-library","sha":"c6c226d927f13df484c837b8629b0eaf6075fe5f","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":62135150,"name":"content-api-firehose-client","full_name":"guardian/content-api-firehose-client","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/content-api-firehose-client","description":"A client for the Guardian's Content API firehose - an events stream for all updates and deletes of Guardian content.","fork":false,"url":"https://api.github.com/repos/guardian/content-api-firehose-client","forks_url":"https://api.github.com/repos/guardian/content-api-firehose-client/forks","keys_url":"https://api.github.com/repos/guardian/content-api-firehose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/content-api-firehose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/content-api-firehose-client/teams","hooks_url":"https://api.github.com/repos/guardian/content-api-firehose-client/hooks","issue_events_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/content-api-firehose-client/events","assignees_url":"https://api.github.com/repos/guardian/content-api-firehose-client/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/content-api-firehose-client/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/content-api-firehose-client/tags","blobs_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/content-api-firehose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/content-api-firehose-client/languages","stargazers_url":"https://api.github.com/repos/guardian/content-api-firehose-client/stargazers","contributors_url":"https://api.github.com/repos/guardian/content-api-firehose-client/contributors","subscribers_url":"https://api.github.com/repos/guardian/content-api-firehose-client/subscribers","subscription_url":"https://api.github.com/repos/guardian/content-api-firehose-client/subscription","commits_url":"https://api.github.com/repos/guardian/content-api-firehose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/content-api-firehose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/content-api-firehose-client/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/content-api-firehose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/content-api-firehose-client/merges","archive_url":"https://api.github.com/repos/guardian/content-api-firehose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/content-api-firehose-client/downloads","issues_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/content-api-firehose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/content-api-firehose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/content-api-firehose-client/labels{/name}","releases_url":"https://api.github.com/repos/guardian/content-api-firehose-client/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/content-api-firehose-client/deployments","created_at":"2016-06-28T11:21:28Z","updated_at":"2016-06-29T12:04:13Z","pushed_at":"2016-06-29T14:59:16Z","git_url":"git://github.com/guardian/content-api-firehose-client.git","ssh_url":"git@github.com:guardian/content-api-firehose-client.git","clone_url":"https://github.com/guardian/content-api-firehose-client.git","svn_url":"https://github.com/guardian/content-api-firehose-client","homepage":"","size":17,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"a45d09ec7b4c1c9dfe3f0eaf88bfa5598b79eb85","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":62135150,"name":"content-api-firehose-client","full_name":"guardian/content-api-firehose-client","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/content-api-firehose-client","description":"A client for the Guardian's Content API firehose - an events stream for all updates and deletes of Guardian content.","fork":false,"url":"https://api.github.com/repos/guardian/content-api-firehose-client","forks_url":"https://api.github.com/repos/guardian/content-api-firehose-client/forks","keys_url":"https://api.github.com/repos/guardian/content-api-firehose-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/content-api-firehose-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/content-api-firehose-client/teams","hooks_url":"https://api.github.com/repos/guardian/content-api-firehose-client/hooks","issue_events_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/content-api-firehose-client/events","assignees_url":"https://api.github.com/repos/guardian/content-api-firehose-client/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/content-api-firehose-client/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/content-api-firehose-client/tags","blobs_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/content-api-firehose-client/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/content-api-firehose-client/languages","stargazers_url":"https://api.github.com/repos/guardian/content-api-firehose-client/stargazers","contributors_url":"https://api.github.com/repos/guardian/content-api-firehose-client/contributors","subscribers_url":"https://api.github.com/repos/guardian/content-api-firehose-client/subscribers","subscription_url":"https://api.github.com/repos/guardian/content-api-firehose-client/subscription","commits_url":"https://api.github.com/repos/guardian/content-api-firehose-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/content-api-firehose-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/content-api-firehose-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/content-api-firehose-client/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/content-api-firehose-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/content-api-firehose-client/merges","archive_url":"https://api.github.com/repos/guardian/content-api-firehose-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/content-api-firehose-client/downloads","issues_url":"https://api.github.com/repos/guardian/content-api-firehose-client/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/content-api-firehose-client/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/content-api-firehose-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/content-api-firehose-client/labels{/name}","releases_url":"https://api.github.com/repos/guardian/content-api-firehose-client/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/content-api-firehose-client/deployments","created_at":"2016-06-28T11:21:28Z","updated_at":"2016-06-29T12:04:13Z","pushed_at":"2016-06-29T14:59:16Z","git_url":"git://github.com/guardian/content-api-firehose-client.git","ssh_url":"git@github.com:guardian/content-api-firehose-client.git","clone_url":"https://github.com/guardian/content-api-firehose-client.git","svn_url":"https://github.com/guardian/content-api-firehose-client","homepage":"","size":17,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1"},"html":{"href":"https://github.com/guardian/content-api-firehose-client/pull/1"},"issue":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/1"},"comments":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/content-api-firehose-client/statuses/c6c226d927f13df484c837b8629b0eaf6075fe5f"}}}}
{"actor":{"display_login":"cb372"}}