{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/commissaire/pulls/comments/72831486","id":72831486,"diff_hunk":"@@ -46,3 +48,15 @@ class TestCase(TestBase):\n     Parent class for all unittests.\n     \"\"\"\n     pass\n+\n+\n+class TestModel(Model):","path":"test/__init__.py","position":15,"original_position":15,"commit_id":"8c8f7c74a17f82077a7e76df636ed58eb9d4a369","original_commit_id":"c43daff9dcb3394d0c9b19633ccedbb444fa0146","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"body":"Great idea!","created_at":"2016-07-29T17:40:46Z","updated_at":"2016-07-29T17:40:46Z","html_url":"https://github.com/projectatomic/commissaire/pull/170#discussion_r72831486","pull_request_url":"https://api.github.com/repos/projectatomic/commissaire/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/commissaire/pulls/comments/72831486"},"html":{"href":"https://github.com/projectatomic/commissaire/pull/170#discussion_r72831486"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/commissaire/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/commissaire/pulls/170","id":77676695,"html_url":"https://github.com/projectatomic/commissaire/pull/170","diff_url":"https://github.com/projectatomic/commissaire/pull/170.diff","patch_url":"https://github.com/projectatomic/commissaire/pull/170.patch","issue_url":"https://api.github.com/repos/projectatomic/commissaire/issues/170","number":170,"state":"open","locked":false,"title":"[WIP] Cpd 126 config","user":{"login":"mbarnes","id":56718,"avatar_url":"https://avatars.githubusercontent.com/u/56718?v=3","gravatar_id":"","url":"https://api.github.com/users/mbarnes","html_url":"https://github.com/mbarnes","followers_url":"https://api.github.com/users/mbarnes/followers","following_url":"https://api.github.com/users/mbarnes/following{/other_user}","gists_url":"https://api.github.com/users/mbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarnes/subscriptions","organizations_url":"https://api.github.com/users/mbarnes/orgs","repos_url":"https://api.github.com/users/mbarnes/repos","events_url":"https://api.github.com/users/mbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/mbarnes/received_events","type":"User","site_admin":false},"body":"Current status:\r\n * CLI parsing is more or less done.\r\n * Bootstrap playbook integration is duct taped together well enough I think to preserve current functionality and near-term expected usage patterns, but further discussion and rework necessary.  We're allowing for more configuration flexibility than we support.\r\n * Next to-do is come up with a new model class for all the stuff we fetch through `cli_etcd_or_default` and integrate it into the storage handler framework.\r\n * Still need tests and docs for all this.\r\n\r\nWe should also define the `register_store_handler` kwargs a little better.  It doesn't have to be (and probably shouldn't be) a straight pass-through to the kube or etcd client API.  For instance, would it be better for the UX to take a URI string for the remote storage address or keep arguments split into host/port/protocol components?","created_at":"2016-07-15T20:52:21Z","updated_at":"2016-07-29T17:40:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27a358958515a0d4dbd9fe223f984a423edf3024","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/commissaire/pulls/170/commits","review_comments_url":"https://api.github.com/repos/projectatomic/commissaire/pulls/170/comments","review_comment_url":"https://api.github.com/repos/projectatomic/commissaire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/commissaire/issues/170/comments","statuses_url":"https://api.github.com/repos/projectatomic/commissaire/statuses/8c8f7c74a17f82077a7e76df636ed58eb9d4a369","head":{"label":"mbarnes:cpd-126-config","ref":"cpd-126-config","sha":"8c8f7c74a17f82077a7e76df636ed58eb9d4a369","user":{"login":"mbarnes","id":56718,"avatar_url":"https://avatars.githubusercontent.com/u/56718?v=3","gravatar_id":"","url":"https://api.github.com/users/mbarnes","html_url":"https://github.com/mbarnes","followers_url":"https://api.github.com/users/mbarnes/followers","following_url":"https://api.github.com/users/mbarnes/following{/other_user}","gists_url":"https://api.github.com/users/mbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarnes/subscriptions","organizations_url":"https://api.github.com/users/mbarnes/orgs","repos_url":"https://api.github.com/users/mbarnes/repos","events_url":"https://api.github.com/users/mbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/mbarnes/received_events","type":"User","site_admin":false},"repo":{"id":49898131,"name":"commissaire","full_name":"mbarnes/commissaire","owner":{"login":"mbarnes","id":56718,"avatar_url":"https://avatars.githubusercontent.com/u/56718?v=3","gravatar_id":"","url":"https://api.github.com/users/mbarnes","html_url":"https://github.com/mbarnes","followers_url":"https://api.github.com/users/mbarnes/followers","following_url":"https://api.github.com/users/mbarnes/following{/other_user}","gists_url":"https://api.github.com/users/mbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarnes/subscriptions","organizations_url":"https://api.github.com/users/mbarnes/orgs","repos_url":"https://api.github.com/users/mbarnes/repos","events_url":"https://api.github.com/users/mbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/mbarnes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbarnes/commissaire","description":"A REST based cluster manager.","fork":true,"url":"https://api.github.com/repos/mbarnes/commissaire","forks_url":"https://api.github.com/repos/mbarnes/commissaire/forks","keys_url":"https://api.github.com/repos/mbarnes/commissaire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbarnes/commissaire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbarnes/commissaire/teams","hooks_url":"https://api.github.com/repos/mbarnes/commissaire/hooks","issue_events_url":"https://api.github.com/repos/mbarnes/commissaire/issues/events{/number}","events_url":"https://api.github.com/repos/mbarnes/commissaire/events","assignees_url":"https://api.github.com/repos/mbarnes/commissaire/assignees{/user}","branches_url":"https://api.github.com/repos/mbarnes/commissaire/branches{/branch}","tags_url":"https://api.github.com/repos/mbarnes/commissaire/tags","blobs_url":"https://api.github.com/repos/mbarnes/commissaire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbarnes/commissaire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbarnes/commissaire/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbarnes/commissaire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbarnes/commissaire/statuses/{sha}","languages_url":"https://api.github.com/repos/mbarnes/commissaire/languages","stargazers_url":"https://api.github.com/repos/mbarnes/commissaire/stargazers","contributors_url":"https://api.github.com/repos/mbarnes/commissaire/contributors","subscribers_url":"https://api.github.com/repos/mbarnes/commissaire/subscribers","subscription_url":"https://api.github.com/repos/mbarnes/commissaire/subscription","commits_url":"https://api.github.com/repos/mbarnes/commissaire/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbarnes/commissaire/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbarnes/commissaire/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbarnes/commissaire/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbarnes/commissaire/contents/{+path}","compare_url":"https://api.github.com/repos/mbarnes/commissaire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbarnes/commissaire/merges","archive_url":"https://api.github.com/repos/mbarnes/commissaire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbarnes/commissaire/downloads","issues_url":"https://api.github.com/repos/mbarnes/commissaire/issues{/number}","pulls_url":"https://api.github.com/repos/mbarnes/commissaire/pulls{/number}","milestones_url":"https://api.github.com/repos/mbarnes/commissaire/milestones{/number}","notifications_url":"https://api.github.com/repos/mbarnes/commissaire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbarnes/commissaire/labels{/name}","releases_url":"https://api.github.com/repos/mbarnes/commissaire/releases{/id}","deployments_url":"https://api.github.com/repos/mbarnes/commissaire/deployments","created_at":"2016-01-18T18:59:43Z","updated_at":"2016-01-18T18:59:44Z","pushed_at":"2016-07-29T17:40:16Z","git_url":"git://github.com/mbarnes/commissaire.git","ssh_url":"git@github.com:mbarnes/commissaire.git","clone_url":"https://github.com/mbarnes/commissaire.git","svn_url":"https://github.com/mbarnes/commissaire","homepage":"","size":1864,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"49d9c699a40a97ff86e73d72938234cf328e8599","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":49139596,"name":"commissaire","full_name":"projectatomic/commissaire","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/commissaire","description":"A lightweight REST interface for upgrading, restarting, and bootstrapping new hosts into an existing Container Management cluster.","fork":false,"url":"https://api.github.com/repos/projectatomic/commissaire","forks_url":"https://api.github.com/repos/projectatomic/commissaire/forks","keys_url":"https://api.github.com/repos/projectatomic/commissaire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/commissaire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/commissaire/teams","hooks_url":"https://api.github.com/repos/projectatomic/commissaire/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/commissaire/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/commissaire/events","assignees_url":"https://api.github.com/repos/projectatomic/commissaire/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/commissaire/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/commissaire/tags","blobs_url":"https://api.github.com/repos/projectatomic/commissaire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/commissaire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/commissaire/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/commissaire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/commissaire/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/commissaire/languages","stargazers_url":"https://api.github.com/repos/projectatomic/commissaire/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/commissaire/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/commissaire/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/commissaire/subscription","commits_url":"https://api.github.com/repos/projectatomic/commissaire/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/commissaire/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/commissaire/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/commissaire/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/commissaire/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/commissaire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/commissaire/merges","archive_url":"https://api.github.com/repos/projectatomic/commissaire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/commissaire/downloads","issues_url":"https://api.github.com/repos/projectatomic/commissaire/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/commissaire/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/commissaire/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/commissaire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/commissaire/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/commissaire/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/commissaire/deployments","created_at":"2016-01-06T14:21:29Z","updated_at":"2016-07-01T17:37:46Z","pushed_at":"2016-07-29T17:40:16Z","git_url":"git://github.com/projectatomic/commissaire.git","ssh_url":"git@github.com:projectatomic/commissaire.git","clone_url":"https://github.com/projectatomic/commissaire.git","svn_url":"https://github.com/projectatomic/commissaire","homepage":"http://commissaire.readthedocs.org/en/latest/","size":1989,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/commissaire/pulls/170"},"html":{"href":"https://github.com/projectatomic/commissaire/pull/170"},"issue":{"href":"https://api.github.com/repos/projectatomic/commissaire/issues/170"},"comments":{"href":"https://api.github.com/repos/projectatomic/commissaire/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/commissaire/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/commissaire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/commissaire/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/commissaire/statuses/8c8f7c74a17f82077a7e76df636ed58eb9d4a369"}}}}
{"actor":{"display_login":"ashcrow"}}