{"action":"opened","issue":{"url":"https://api.github.com/repos/cakephp/cakephp/issues/9728","repository_url":"https://api.github.com/repos/cakephp/cakephp","labels_url":"https://api.github.com/repos/cakephp/cakephp/issues/9728/labels{/name}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/9728/comments","events_url":"https://api.github.com/repos/cakephp/cakephp/issues/9728/events","html_url":"https://github.com/cakephp/cakephp/issues/9728","id":188260914,"number":9728,"title":"Potential false positive shell command conflicts","user":{"login":"luke83","id":77144,"avatar_url":"https://avatars.githubusercontent.com/u/77144?v=3","gravatar_id":"","url":"https://api.github.com/users/luke83","html_url":"https://github.com/luke83","followers_url":"https://api.github.com/users/luke83/followers","following_url":"https://api.github.com/users/luke83/following{/other_user}","gists_url":"https://api.github.com/users/luke83/gists{/gist_id}","starred_url":"https://api.github.com/users/luke83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luke83/subscriptions","organizations_url":"https://api.github.com/users/luke83/orgs","repos_url":"https://api.github.com/users/luke83/repos","events_url":"https://api.github.com/users/luke83/events{/privacy}","received_events_url":"https://api.github.com/users/luke83/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-09T14:31:10Z","updated_at":"2016-11-09T14:31:10Z","closed_at":null,"body":"This is a (multiple allowed):\r\n\r\n* [x] bug\r\n* [ ] enhancement\r\n* [ ] feature-discussion (RFC)\r\n\r\n* CakePHP Version: 3.3.8\r\n* Platform and Target: irrilevant\r\n\r\n### What you did\r\napp with basic [core] plugins installed: bake, debug_kit, migrations\r\n\r\n### What happened\r\nLot of fixable debug logs:\r\n\r\n```\r\n2016-11-08 18:08:14 Debug: command 'bake' in plugin 'Bake' was not aliased, conflicts with 'Bake'\r\n2016-11-08 18:08:14 Debug: command 'benchmark' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-08 18:08:14 Debug: command 'whitespace' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-08 18:08:14 Debug: command 'migrations' in plugin 'Migrations' was not aliased, conflicts with 'Migrations'\r\n2016-11-08 18:14:58 Debug: command 'bake' in plugin 'Bake' was not aliased, conflicts with 'Bake'\r\n2016-11-08 18:14:58 Debug: command 'benchmark' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-08 18:14:58 Debug: command 'whitespace' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-08 18:14:58 Debug: command 'migrations' in plugin 'Migrations' was not aliased, conflicts with 'Migrations'\r\n2016-11-09 11:16:40 Debug: command 'bake' in plugin 'Bake' was not aliased, conflicts with 'Bake'\r\n2016-11-09 11:16:40 Debug: command 'benchmark' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-09 11:16:40 Debug: command 'whitespace' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-09 11:16:40 Debug: command 'migrations' in plugin 'Migrations' was not aliased, conflicts with 'Migrations'\r\n2016-11-09 13:53:13 Debug: command 'bake' in plugin 'Bake' was not aliased, conflicts with 'Bake'\r\n2016-11-09 13:53:13 Debug: command 'benchmark' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-09 13:53:13 Debug: command 'whitespace' in plugin 'DebugKit' was not aliased, conflicts with 'DebugKit'\r\n2016-11-09 13:53:13 Debug: command 'migrations' in plugin 'Migrations' was not aliased, conflicts with 'Migrations'\r\n```\r\n\r\n### What you expected to happen\r\nUsing \"core\" plugins should not produce this kind of logs; in any case reporting that commands in \"PluginName\" conflicts with \"PluginName\" is quite \"normal\", they should be filtered by default reporting only command conflicts between different plugins.\r\n\r\nI can make a pull request checking round https://github.com/cakephp/cakephp/blob/master/src/Console/ShellDispatcher.php#L272 that `$other` !== `$plugin`:\r\n\r\n```php\r\n            $other = static::alias($shell);\r\n            if ($other) {\r\n                $other = $aliases[$shell];\r\n                if ($other != $plugin) {\r\n                    Log::write(\r\n                        'debug',\r\n                        \"command '$shell' in plugin '$plugin' was not aliased, conflicts with '$other'\",\r\n                        ['shell-dispatcher']\r\n                    );\r\n                continue;\r\n                }\r\n            }\r\n```"}}
{"actor":{"display_login":"luke83"}}