{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/71968941","id":71968941,"diff_hunk":"@@ -95,20 +103,24 @@ def setup(hass, config):\n \n     # Override which cmd's in /&listen packets will fire events\n     # By default only buttons of type [TOGGLE,SCENE EXE,LEVEL]\n-    cmd_buttons = config[DOMAIN].get('button_events', ','.join(CMD_BUTTONS))\n+    cmd_buttons = config[DOMAIN][0].get('button_events', ','.join(CMD_BUTTONS))\n     cmd_buttons = cmd_buttons.split(',')\n \n-    try:\n-        url = config[DOMAIN].get('url', 'http://127.0.0.1:2020')\n-        dimmer_adjust = float(config[DOMAIN].get('dimmer_adjust', '1'))\n-        qsusb = QSUsb(url, _LOGGER, dimmer_adjust)\n+    url = config[DOMAIN][0]['url']\n+    dimmer_adjust = config[DOMAIN][0]['dimmer_adjust']\n \n-        # Ensure qsusb terminates threads correctly\n-        hass.bus.listen_once(EVENT_HOMEASSISTANT_STOP,\n-                             lambda event: qsusb.stop())\n-    except ValueError as val_err:\n-        _LOGGER.error(str(val_err))\n-        return False\n+    qsusb = QSUsb(url, _LOGGER, dimmer_adjust)\n+\n+    def _stop(event):\n+        \"\"\"Stop the listener queue and clen up.\"\"\"\n+        qsusb.stop()\n+        _LOGGER.info(\"Waiting for long poll to QSUSB to time out\")\n+        nonlocal qsusb\n+        qsusb = None","path":"homeassistant/components/qwikswitch.py","position":57,"original_position":57,"commit_id":"85a70e882b00b833cf8934b8c464ddfbf94e98bc","original_commit_id":"85a70e882b00b833cf8934b8c464ddfbf94e98bc","user":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"body":"`QSUSB = {}` is global and `qsusb` is one scope up. Think it's ok?","created_at":"2016-07-23T07:29:38Z","updated_at":"2016-07-23T07:29:38Z","html_url":"https://github.com/home-assistant/home-assistant/pull/2603#discussion_r71968941","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/71968941"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2603#discussion_r71968941"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603","id":78554243,"html_url":"https://github.com/home-assistant/home-assistant/pull/2603","diff_url":"https://github.com/home-assistant/home-assistant/pull/2603.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/2603.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2603","number":2603,"state":"open","locked":false,"title":"Update Qwikswitch: fix typing, add validation, shutdown","user":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nQwikswitch update:\r\n\r\n- add `PLATFORM_VALIDATION`\r\n- fix`typing`\r\n- Shutdown message","created_at":"2016-07-22T23:37:45Z","updated_at":"2016-07-23T07:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e839e4f39332afc18266e6069225b0bf6606322e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2603/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/85a70e882b00b833cf8934b8c464ddfbf94e98bc","head":{"label":"kellerza:qwikswitch","ref":"qwikswitch","sha":"85a70e882b00b833cf8934b8c464ddfbf94e98bc","user":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"repo":{"id":57890671,"name":"home-assistant","full_name":"kellerza/home-assistant","owner":{"login":"kellerza","id":6756881,"avatar_url":"https://avatars.githubusercontent.com/u/6756881?v=3","gravatar_id":"","url":"https://api.github.com/users/kellerza","html_url":"https://github.com/kellerza","followers_url":"https://api.github.com/users/kellerza/followers","following_url":"https://api.github.com/users/kellerza/following{/other_user}","gists_url":"https://api.github.com/users/kellerza/gists{/gist_id}","starred_url":"https://api.github.com/users/kellerza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellerza/subscriptions","organizations_url":"https://api.github.com/users/kellerza/orgs","repos_url":"https://api.github.com/users/kellerza/repos","events_url":"https://api.github.com/users/kellerza/events{/privacy}","received_events_url":"https://api.github.com/users/kellerza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kellerza/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/kellerza/home-assistant","forks_url":"https://api.github.com/repos/kellerza/home-assistant/forks","keys_url":"https://api.github.com/repos/kellerza/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kellerza/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kellerza/home-assistant/teams","hooks_url":"https://api.github.com/repos/kellerza/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/kellerza/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/kellerza/home-assistant/events","assignees_url":"https://api.github.com/repos/kellerza/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/kellerza/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/kellerza/home-assistant/tags","blobs_url":"https://api.github.com/repos/kellerza/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kellerza/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kellerza/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/kellerza/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kellerza/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/kellerza/home-assistant/languages","stargazers_url":"https://api.github.com/repos/kellerza/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/kellerza/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/kellerza/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/kellerza/home-assistant/subscription","commits_url":"https://api.github.com/repos/kellerza/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/kellerza/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/kellerza/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/kellerza/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/kellerza/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/kellerza/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kellerza/home-assistant/merges","archive_url":"https://api.github.com/repos/kellerza/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kellerza/home-assistant/downloads","issues_url":"https://api.github.com/repos/kellerza/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/kellerza/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/kellerza/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/kellerza/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kellerza/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/kellerza/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/kellerza/home-assistant/deployments","created_at":"2016-05-02T13:03:22Z","updated_at":"2016-05-02T13:03:25Z","pushed_at":"2016-07-23T07:29:19Z","git_url":"git://github.com/kellerza/home-assistant.git","ssh_url":"git@github.com:kellerza/home-assistant.git","clone_url":"https://github.com/kellerza/home-assistant.git","svn_url":"https://github.com/kellerza/home-assistant","homepage":"https://home-assistant.io","size":67913,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"8389a0abe33ce7552d8327428a26948adca13c60","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-07-22T22:48:46Z","pushed_at":"2016-07-23T02:47:44Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":93997,"stargazers_count":3746,"watchers_count":3746,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":839,"mirror_url":null,"open_issues_count":169,"forks":839,"open_issues":169,"watchers":3746,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2603"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2603"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2603/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2603/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/85a70e882b00b833cf8934b8c464ddfbf94e98bc"}}}}
{"actor":{"display_login":"kellerza"}}