{"action":"opened","number":137,"pull_request":{"url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/137","id":96748512,"html_url":"https://github.com/dailymotion/vast-client-js/pull/137","diff_url":"https://github.com/dailymotion/vast-client-js/pull/137.diff","patch_url":"https://github.com/dailymotion/vast-client-js/pull/137.patch","issue_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/137","number":137,"state":"open","locked":false,"title":"Fix parser error tracking","user":{"login":"michaelvial","id":4097282,"avatar_url":"https://avatars.githubusercontent.com/u/4097282?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelvial","html_url":"https://github.com/michaelvial","followers_url":"https://api.github.com/users/michaelvial/followers","following_url":"https://api.github.com/users/michaelvial/following{/other_user}","gists_url":"https://api.github.com/users/michaelvial/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelvial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelvial/subscriptions","organizations_url":"https://api.github.com/users/michaelvial/orgs","repos_url":"https://api.github.com/users/michaelvial/repos","events_url":"https://api.github.com/users/michaelvial/events{/privacy}","received_events_url":"https://api.github.com/users/michaelvial/received_events","type":"User","site_admin":false},"body":"Currently, the VAST parser has some issues with no-ad/no creatives files:\r\n- When parsing a no-ad VAST (a VAST element with perhaps a top level `<Error>`), the `response` uses to be `null`. It now returns an empty `ads` array. \r\n- When a file contains an `<Inline>` ad but with no creatives data,  the VAST parser uses to add it into the `response.ads` as if it was a valid ad. It's not added anymore.\r\n- After parsing succesfully a `<Wrapper>` ad, if the `<AdTagURI>` resource wasn't a valid XML file, it uses to call the callback function with a JS `Error` - `Invalid VAST XMLDocument`. While it makes sense to return such an error, we lose all others ads the VATS file might had have. We now don't trigger an error and continue the parsing. The invalid ad is removed from the result.\r\n\r\n (while calling `<Error>` URIs with the correct [`ERRORCODE]`).\r\n\r\n- Move VAST test files to `/test/vastfiles/`\r\n- Add unit tests to check error scenarios that can happen while parsing VAST files\r\n- Add a new data `extensions` to `VAST-error` events emitted by the parser.","created_at":"2016-12-06T15:45:19Z","updated_at":"2016-12-06T15:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/137/commits","review_comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/137/comments","review_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/137/comments","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/ac1fad9ba8620f2867aa41e77134108600c02f7e","head":{"label":"dailymotion:fix_parser_error-tracking","ref":"fix_parser_error-tracking","sha":"ac1fad9ba8620f2867aa41e77134108600c02f7e","user":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars.githubusercontent.com/u/115313?v=3","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"repo":{"id":8641521,"name":"vast-client-js","full_name":"dailymotion/vast-client-js","owner":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars.githubusercontent.com/u/115313?v=3","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dailymotion/vast-client-js","description":"VAST 3.0 client library for JavaScript","fork":false,"url":"https://api.github.com/repos/dailymotion/vast-client-js","forks_url":"https://api.github.com/repos/dailymotion/vast-client-js/forks","keys_url":"https://api.github.com/repos/dailymotion/vast-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dailymotion/vast-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dailymotion/vast-client-js/teams","hooks_url":"https://api.github.com/repos/dailymotion/vast-client-js/hooks","issue_events_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/dailymotion/vast-client-js/events","assignees_url":"https://api.github.com/repos/dailymotion/vast-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/dailymotion/vast-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/tags","blobs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dailymotion/vast-client-js/languages","stargazers_url":"https://api.github.com/repos/dailymotion/vast-client-js/stargazers","contributors_url":"https://api.github.com/repos/dailymotion/vast-client-js/contributors","subscribers_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscribers","subscription_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscription","commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dailymotion/vast-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/dailymotion/vast-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dailymotion/vast-client-js/merges","archive_url":"https://api.github.com/repos/dailymotion/vast-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dailymotion/vast-client-js/downloads","issues_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dailymotion/vast-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dailymotion/vast-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dailymotion/vast-client-js/labels{/name}","releases_url":"https://api.github.com/repos/dailymotion/vast-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/dailymotion/vast-client-js/deployments","created_at":"2013-03-08T02:37:23Z","updated_at":"2016-12-05T10:16:49Z","pushed_at":"2016-12-06T15:45:19Z","git_url":"git://github.com/dailymotion/vast-client-js.git","ssh_url":"git@github.com:dailymotion/vast-client-js.git","clone_url":"https://github.com/dailymotion/vast-client-js.git","svn_url":"https://github.com/dailymotion/vast-client-js","homepage":"http://www.iab.net/media/file/VASTv3.0.pdf","size":2516,"stargazers_count":134,"watchers_count":134,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":10,"forks":101,"open_issues":10,"watchers":134,"default_branch":"master"}},"base":{"label":"dailymotion:master","ref":"master","sha":"2efd400b9b3dd6fb3e1925bd3e88da438d65869c","user":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars.githubusercontent.com/u/115313?v=3","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"repo":{"id":8641521,"name":"vast-client-js","full_name":"dailymotion/vast-client-js","owner":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars.githubusercontent.com/u/115313?v=3","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dailymotion/vast-client-js","description":"VAST 3.0 client library for JavaScript","fork":false,"url":"https://api.github.com/repos/dailymotion/vast-client-js","forks_url":"https://api.github.com/repos/dailymotion/vast-client-js/forks","keys_url":"https://api.github.com/repos/dailymotion/vast-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dailymotion/vast-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dailymotion/vast-client-js/teams","hooks_url":"https://api.github.com/repos/dailymotion/vast-client-js/hooks","issue_events_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/dailymotion/vast-client-js/events","assignees_url":"https://api.github.com/repos/dailymotion/vast-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/dailymotion/vast-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/tags","blobs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dailymotion/vast-client-js/languages","stargazers_url":"https://api.github.com/repos/dailymotion/vast-client-js/stargazers","contributors_url":"https://api.github.com/repos/dailymotion/vast-client-js/contributors","subscribers_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscribers","subscription_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscription","commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dailymotion/vast-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/dailymotion/vast-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dailymotion/vast-client-js/merges","archive_url":"https://api.github.com/repos/dailymotion/vast-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dailymotion/vast-client-js/downloads","issues_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dailymotion/vast-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dailymotion/vast-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dailymotion/vast-client-js/labels{/name}","releases_url":"https://api.github.com/repos/dailymotion/vast-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/dailymotion/vast-client-js/deployments","created_at":"2013-03-08T02:37:23Z","updated_at":"2016-12-05T10:16:49Z","pushed_at":"2016-12-06T15:45:19Z","git_url":"git://github.com/dailymotion/vast-client-js.git","ssh_url":"git@github.com:dailymotion/vast-client-js.git","clone_url":"https://github.com/dailymotion/vast-client-js.git","svn_url":"https://github.com/dailymotion/vast-client-js","homepage":"http://www.iab.net/media/file/VASTv3.0.pdf","size":2516,"stargazers_count":134,"watchers_count":134,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":101,"mirror_url":null,"open_issues_count":10,"forks":101,"open_issues":10,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/137"},"html":{"href":"https://github.com/dailymotion/vast-client-js/pull/137"},"issue":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/issues/137"},"comments":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/ac1fad9ba8620f2867aa41e77134108600c02f7e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":299,"deletions":172,"changed_files":20}}
{"actor":{"display_login":"michaelvial"}}