{"action":"created","issue":{"url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/issues/66","repository_url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga","labels_url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/issues/66/comments","events_url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/issues/66/events","html_url":"https://github.com/SaladaDeFrutas/Pitanga/pull/66","id":194228980,"number":66,"title":"Adiciona correções do sonar ao branch Refatorar-sessao-ingresso-atracao","user":{"login":"clebersa","id":7107733,"avatar_url":"https://avatars.githubusercontent.com/u/7107733?v=3","gravatar_id":"","url":"https://api.github.com/users/clebersa","html_url":"https://github.com/clebersa","followers_url":"https://api.github.com/users/clebersa/followers","following_url":"https://api.github.com/users/clebersa/following{/other_user}","gists_url":"https://api.github.com/users/clebersa/gists{/gist_id}","starred_url":"https://api.github.com/users/clebersa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebersa/subscriptions","organizations_url":"https://api.github.com/users/clebersa/orgs","repos_url":"https://api.github.com/users/clebersa/repos","events_url":"https://api.github.com/users/clebersa/events{/privacy}","received_events_url":"https://api.github.com/users/clebersa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-08T02:10:29Z","updated_at":"2016-12-08T04:28:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/pulls/66","html_url":"https://github.com/SaladaDeFrutas/Pitanga/pull/66","diff_url":"https://github.com/SaladaDeFrutas/Pitanga/pull/66.diff","patch_url":"https://github.com/SaladaDeFrutas/Pitanga/pull/66.patch"},"body":"Este PR tem por objetivo adicionar as correções sugeridas pelo sonar para o branch #60 que foi mergido e deletado antes das mudanças serem adicionadas ao repositório."},"comment":{"url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/issues/comments/265650280","html_url":"https://github.com/SaladaDeFrutas/Pitanga/pull/66#issuecomment-265650280","issue_url":"https://api.github.com/repos/SaladaDeFrutas/Pitanga/issues/66","id":265650280,"user":{"login":"Yuri-M-Dias","id":6656296,"avatar_url":"https://avatars.githubusercontent.com/u/6656296?v=3","gravatar_id":"","url":"https://api.github.com/users/Yuri-M-Dias","html_url":"https://github.com/Yuri-M-Dias","followers_url":"https://api.github.com/users/Yuri-M-Dias/followers","following_url":"https://api.github.com/users/Yuri-M-Dias/following{/other_user}","gists_url":"https://api.github.com/users/Yuri-M-Dias/gists{/gist_id}","starred_url":"https://api.github.com/users/Yuri-M-Dias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yuri-M-Dias/subscriptions","organizations_url":"https://api.github.com/users/Yuri-M-Dias/orgs","repos_url":"https://api.github.com/users/Yuri-M-Dias/repos","events_url":"https://api.github.com/users/Yuri-M-Dias/events{/privacy}","received_events_url":"https://api.github.com/users/Yuri-M-Dias/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T04:28:42Z","updated_at":"2016-12-08T04:28:42Z","body":"SonarQube analysis reported 30 issues\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 9 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 21 minor\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FuncionarioController.java#L486](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/FuncionarioController.java#L486): Remove this useless assignment to local variable \"assentosInvalidos\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1854)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [SistemaController.java#L32](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/SistemaController.java#L32): This block of commented-out lines of code should be removed. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3ACommentedOutCodeLine)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [SistemaController.java#L41](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/SistemaController.java#L41): This block of commented-out lines of code should be removed. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3ACommentedOutCodeLine)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [SistemaController.java#L333](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/SistemaController.java#L333): Replace this usage of System.out or System.err by a logger. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS106)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [SistemaController.java#L440](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/SistemaController.java#L440): Remove this useless assignment to local variable \"status\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1854)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [SistemaController.java#L489](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/SistemaController.java#L489): Either log or rethrow this exception. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1166)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [SistemaController.java#L490](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/SistemaController.java#L490): Define and throw a dedicated exception instead of using a generic one. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS00112)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [FuncionarioController.java#L218](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/FuncionarioController.java#L218): Introduce a new variable instead of reusing the parameter \"sessao\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1226)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [FuncionarioController.java#L232](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/FuncionarioController.java#L232): Introduce a new variable instead of reusing the parameter \"sessao\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1226)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [FuncionarioController.java#L247](https://github.com/SaladaDeFrutas/Pitanga/blob/e49e38689b5bfbdc563c6c64cf36cdc3101b6485/src/main/java/br/ufg/inf/pitanga/controller/FuncionarioController.java#L247): Introduce a new variable instead of reusing the parameter \"umTipoIngresso\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.com/coding_rules#rule_key=squid%3AS1226)\n"}}
{"actor":{"display_login":"Yuri-M-Dias"}}