{"action":"created","comment":{"url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/comments/51103688","id":51103688,"diff_hunk":"@@ -33,7 +33,8 @@\n     #ELECTRON VETOS\n     #eVetoMVAIsoVtx = 'vetoElectrons(0.4, \"pt > 10 & abs(eta) < 2.5 & userInt(\\'mvaidwp\\') > 0.5 & ((userIso(0) + max(userIso(1) + neutralHadronIso - 0.5*userIso(2), 0))/pt) < 0.3 & userFloat(\\'dz\\') < 0.2\").size()',\n     #eVetoMVAIso = 'vetoElectrons(0.4, \"pt > 10 & abs(eta) < 2.5 & userInt(\\'mvaidwp\\') > 0.5 & (userIso(0) + max(userIso(1) + neutralHadronIso - 0.5*userIso(2), 0))/pt < 0.3\").size()',\n-    \n+    eVetoMVAIsoVtx = 'vetoElectrons(0.4, \"pt > 10 & abs(eta) < 2.5 & userFloat(\\'MVANonTrigWP90\\') > 0.5 & ((userIso(0) + max(userIso(1) + neutralHadronIso - 0.5*userIso(2), 0))/pt) < 0.3 & userFloat(\\'dz\\') < 0.2\").size()',","path":"NtupleTools/python/templates/cleaning.py","position":5,"original_position":5,"commit_id":"0ec5e2097012c303023d3f82b33f35c9b60f8f31","original_commit_id":"0ec5e2097012c303023d3f82b33f35c9b60f8f31","user":{"login":"nwoods","id":4604751,"avatar_url":"https://avatars.githubusercontent.com/u/4604751?v=3","gravatar_id":"","url":"https://api.github.com/users/nwoods","html_url":"https://github.com/nwoods","followers_url":"https://api.github.com/users/nwoods/followers","following_url":"https://api.github.com/users/nwoods/following{/other_user}","gists_url":"https://api.github.com/users/nwoods/gists{/gist_id}","starred_url":"https://api.github.com/users/nwoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwoods/subscriptions","organizations_url":"https://api.github.com/users/nwoods/orgs","repos_url":"https://api.github.com/users/nwoods/repos","events_url":"https://api.github.com/users/nwoods/events{/privacy}","received_events_url":"https://api.github.com/users/nwoods/received_events","type":"User","site_admin":false},"body":"In my opinion, this kind of thing should be moved to an analysis-specific parameter file. An example may be found [here](https://github.com/uwcms/FinalStateAnalysis/blob/miniAOD_dev_76X/NtupleTools/python/parameters/wz.py#L66).","created_at":"2016-01-28T10:22:01Z","updated_at":"2016-01-28T10:22:01Z","html_url":"https://github.com/uwcms/FinalStateAnalysis/pull/487#discussion_r51103688","pull_request_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487","_links":{"self":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/comments/51103688"},"html":{"href":"https://github.com/uwcms/FinalStateAnalysis/pull/487#discussion_r51103688"},"pull_request":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487","id":57479887,"html_url":"https://github.com/uwcms/FinalStateAnalysis/pull/487","diff_url":"https://github.com/uwcms/FinalStateAnalysis/pull/487.diff","patch_url":"https://github.com/uwcms/FinalStateAnalysis/pull/487.patch","issue_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues/487","number":487,"state":"open","locked":false,"title":"Mini aod dev 76 x","user":{"login":"Nabarun21","id":8339863,"avatar_url":"https://avatars.githubusercontent.com/u/8339863?v=3","gravatar_id":"","url":"https://api.github.com/users/Nabarun21","html_url":"https://github.com/Nabarun21","followers_url":"https://api.github.com/users/Nabarun21/followers","following_url":"https://api.github.com/users/Nabarun21/following{/other_user}","gists_url":"https://api.github.com/users/Nabarun21/gists{/gist_id}","starred_url":"https://api.github.com/users/Nabarun21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nabarun21/subscriptions","organizations_url":"https://api.github.com/users/Nabarun21/orgs","repos_url":"https://api.github.com/users/Nabarun21/repos","events_url":"https://api.github.com/users/Nabarun21/events{/privacy}","received_events_url":"https://api.github.com/users/Nabarun21/received_events","type":"User","site_admin":false},"body":"Re-Add the eVetoMVAIsoVtx and eVetoMVAIso branches with the ID changed .\r\nhttps://github.com/uwcms/FinalStateAnalysis/issues/478\r\nAdd unsigned long to variable types in cython proxy maker. make_cython_proxy\r\nhttps://github.com/uwcms/FinalStateAnalysis/issues/483","created_at":"2016-01-28T10:05:48Z","updated_at":"2016-01-28T10:22:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23cd0fb07b02623c1e449e214628e2ab5863c028","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487/commits","review_comments_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487/comments","review_comment_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues/487/comments","statuses_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/statuses/0ec5e2097012c303023d3f82b33f35c9b60f8f31","head":{"label":"Nabarun21:miniAOD_dev_76X","ref":"miniAOD_dev_76X","sha":"0ec5e2097012c303023d3f82b33f35c9b60f8f31","user":{"login":"Nabarun21","id":8339863,"avatar_url":"https://avatars.githubusercontent.com/u/8339863?v=3","gravatar_id":"","url":"https://api.github.com/users/Nabarun21","html_url":"https://github.com/Nabarun21","followers_url":"https://api.github.com/users/Nabarun21/followers","following_url":"https://api.github.com/users/Nabarun21/following{/other_user}","gists_url":"https://api.github.com/users/Nabarun21/gists{/gist_id}","starred_url":"https://api.github.com/users/Nabarun21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nabarun21/subscriptions","organizations_url":"https://api.github.com/users/Nabarun21/orgs","repos_url":"https://api.github.com/users/Nabarun21/repos","events_url":"https://api.github.com/users/Nabarun21/events{/privacy}","received_events_url":"https://api.github.com/users/Nabarun21/received_events","type":"User","site_admin":false},"repo":{"id":45853610,"name":"FinalStateAnalysis","full_name":"Nabarun21/FinalStateAnalysis","owner":{"login":"Nabarun21","id":8339863,"avatar_url":"https://avatars.githubusercontent.com/u/8339863?v=3","gravatar_id":"","url":"https://api.github.com/users/Nabarun21","html_url":"https://github.com/Nabarun21","followers_url":"https://api.github.com/users/Nabarun21/followers","following_url":"https://api.github.com/users/Nabarun21/following{/other_user}","gists_url":"https://api.github.com/users/Nabarun21/gists{/gist_id}","starred_url":"https://api.github.com/users/Nabarun21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nabarun21/subscriptions","organizations_url":"https://api.github.com/users/Nabarun21/orgs","repos_url":"https://api.github.com/users/Nabarun21/repos","events_url":"https://api.github.com/users/Nabarun21/events{/privacy}","received_events_url":"https://api.github.com/users/Nabarun21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nabarun21/FinalStateAnalysis","description":"An analysis framework for the Compact Muon Solenoid","fork":true,"url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis","forks_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/forks","keys_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/teams","hooks_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/hooks","issue_events_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/issues/events{/number}","events_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/events","assignees_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/assignees{/user}","branches_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/branches{/branch}","tags_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/tags","blobs_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/languages","stargazers_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/stargazers","contributors_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/contributors","subscribers_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/subscribers","subscription_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/subscription","commits_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/contents/{+path}","compare_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/merges","archive_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/downloads","issues_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/issues{/number}","pulls_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/labels{/name}","releases_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/releases{/id}","deployments_url":"https://api.github.com/repos/Nabarun21/FinalStateAnalysis/deployments","created_at":"2015-11-09T17:13:17Z","updated_at":"2015-11-09T17:13:21Z","pushed_at":"2016-01-27T10:17:36Z","git_url":"git://github.com/Nabarun21/FinalStateAnalysis.git","ssh_url":"git@github.com:Nabarun21/FinalStateAnalysis.git","clone_url":"https://github.com/Nabarun21/FinalStateAnalysis.git","svn_url":"https://github.com/Nabarun21/FinalStateAnalysis","homepage":"","size":113238,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uwcms:miniAOD_dev_76X","ref":"miniAOD_dev_76X","sha":"8decab49d26e1303506a07c01745f2b0a1186f23","user":{"login":"uwcms","id":2050799,"avatar_url":"https://avatars.githubusercontent.com/u/2050799?v=3","gravatar_id":"","url":"https://api.github.com/users/uwcms","html_url":"https://github.com/uwcms","followers_url":"https://api.github.com/users/uwcms/followers","following_url":"https://api.github.com/users/uwcms/following{/other_user}","gists_url":"https://api.github.com/users/uwcms/gists{/gist_id}","starred_url":"https://api.github.com/users/uwcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwcms/subscriptions","organizations_url":"https://api.github.com/users/uwcms/orgs","repos_url":"https://api.github.com/users/uwcms/repos","events_url":"https://api.github.com/users/uwcms/events{/privacy}","received_events_url":"https://api.github.com/users/uwcms/received_events","type":"Organization","site_admin":false},"repo":{"id":5201989,"name":"FinalStateAnalysis","full_name":"uwcms/FinalStateAnalysis","owner":{"login":"uwcms","id":2050799,"avatar_url":"https://avatars.githubusercontent.com/u/2050799?v=3","gravatar_id":"","url":"https://api.github.com/users/uwcms","html_url":"https://github.com/uwcms","followers_url":"https://api.github.com/users/uwcms/followers","following_url":"https://api.github.com/users/uwcms/following{/other_user}","gists_url":"https://api.github.com/users/uwcms/gists{/gist_id}","starred_url":"https://api.github.com/users/uwcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwcms/subscriptions","organizations_url":"https://api.github.com/users/uwcms/orgs","repos_url":"https://api.github.com/users/uwcms/repos","events_url":"https://api.github.com/users/uwcms/events{/privacy}","received_events_url":"https://api.github.com/users/uwcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwcms/FinalStateAnalysis","description":"An analysis framework for the Compact Muon Solenoid","fork":false,"url":"https://api.github.com/repos/uwcms/FinalStateAnalysis","forks_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/forks","keys_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/teams","hooks_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/hooks","issue_events_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues/events{/number}","events_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/events","assignees_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/assignees{/user}","branches_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/branches{/branch}","tags_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/tags","blobs_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/languages","stargazers_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/stargazers","contributors_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/contributors","subscribers_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/subscribers","subscription_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/subscription","commits_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/contents/{+path}","compare_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/merges","archive_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/downloads","issues_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues{/number}","pulls_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/labels{/name}","releases_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/releases{/id}","deployments_url":"https://api.github.com/repos/uwcms/FinalStateAnalysis/deployments","created_at":"2012-07-27T07:51:18Z","updated_at":"2016-01-15T01:03:58Z","pushed_at":"2016-01-28T10:05:48Z","git_url":"git://github.com/uwcms/FinalStateAnalysis.git","ssh_url":"git@github.com:uwcms/FinalStateAnalysis.git","clone_url":"https://github.com/uwcms/FinalStateAnalysis.git","svn_url":"https://github.com/uwcms/FinalStateAnalysis","homepage":"","size":113419,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":8,"forks":25,"open_issues":8,"watchers":2,"default_branch":"miniAOD_dev_74X"}},"_links":{"self":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487"},"html":{"href":"https://github.com/uwcms/FinalStateAnalysis/pull/487"},"issue":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues/487"},"comments":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/uwcms/FinalStateAnalysis/statuses/0ec5e2097012c303023d3f82b33f35c9b60f8f31"}}}}