{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/vic/issues/2342","repository_url":"https://api.github.com/repos/vmware/vic","labels_url":"https://api.github.com/repos/vmware/vic/issues/2342/labels{/name}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2342/comments","events_url":"https://api.github.com/repos/vmware/vic/issues/2342/events","html_url":"https://github.com/vmware/vic/issues/2342","id":177242364,"number":2342,"title":"vic-admin: add authentication/authorization check to vic-admin for log collection","user":{"login":"hickeng","id":3923729,"avatar_url":"https://avatars.githubusercontent.com/u/3923729?v=3","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vmware/vic/labels/area/security","name":"area/security","color":"fbca04"},{"url":"https://api.github.com/repos/vmware/vic/labels/component/vicadmin","name":"component/vicadmin","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"assignees":[{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vmware/vic/milestones/37","html_url":"https://github.com/vmware/vic/milestones/VIC%20GA%20Release","labels_url":"https://api.github.com/repos/vmware/vic/milestones/37/labels","id":1799354,"number":37,"title":"VIC GA Release","description":"Milestone for tracking all work towards the GA goal","creator":{"login":"mdubya66","id":15821624,"avatar_url":"https://avatars.githubusercontent.com/u/15821624?v=3","gravatar_id":"","url":"https://api.github.com/users/mdubya66","html_url":"https://github.com/mdubya66","followers_url":"https://api.github.com/users/mdubya66/followers","following_url":"https://api.github.com/users/mdubya66/following{/other_user}","gists_url":"https://api.github.com/users/mdubya66/gists{/gist_id}","starred_url":"https://api.github.com/users/mdubya66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdubya66/subscriptions","organizations_url":"https://api.github.com/users/mdubya66/orgs","repos_url":"https://api.github.com/users/mdubya66/repos","events_url":"https://api.github.com/users/mdubya66/events{/privacy}","received_events_url":"https://api.github.com/users/mdubya66/received_events","type":"User","site_admin":false},"open_issues":124,"closed_issues":390,"state":"open","created_at":"2016-05-31T17:50:00Z","updated_at":"2016-10-12T22:16:18Z","due_on":"2016-11-07T00:00:00Z","closed_at":null},"comments":2,"created_at":"2016-09-15T17:50:51Z","updated_at":"2016-10-13T00:48:27Z","closed_at":null,"body":"Currently vic-admin allows un-authenticated users to download log bundles.\r\n\r\nAt a minimum we should be adding authentication (and preferably authorization) for log access. We *might* want to provide some of the health status to unauthenticated users.\r\n\r\nvic-admin should try authZ in the following manner:\r\n1. use an http form (http basic auth is strongly discouraged) for user/pass\r\n2. if a connection to vsphere is available, request vsphere creds:\r\n  a. authenticate against vsphere with supplied credentials.\r\n  b. confirm access permissions to the vch appliance VM for those credentials.\r\n3. if no connection to vsphere is available, fall back to authenticating with the VCH OS\r\n  a. this is *not* a fallback for auth failure against vSphere, only for if no net connection is available\r\n  b. no user will be enabled for login on the appliance unless --enable-ssh=<password> has been supplied as in #1218 \r\n\r\nAddresses: https://bugzilla.eng.vmware.com/show_bug.cgi?id=1727628"},"comment":{"url":"https://api.github.com/repos/vmware/vic/issues/comments/253380363","html_url":"https://github.com/vmware/vic/issues/2342#issuecomment-253380363","issue_url":"https://api.github.com/repos/vmware/vic/issues/2342","id":253380363,"user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T00:48:26Z","updated_at":"2016-10-13T00:48:26Z","body":"Breaking this into two tasks, as referenced by @hickeng above. This issue now only applies to 1), certificate authentication, which will be present in `master` when #2691 is merged. The issue representing 2) above is #2705"}}
{"actor":{"display_login":"gigawhitlocks"}}