{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/61187215","id":61187215,"diff_hunk":"@@ -583,6 +583,38 @@ class TextPosition {\n   }\n }\n \n+/// Layout constraints for [Paragraph] objects.\n+///\n+/// Instances of this class are typically used with [Paragraph.layout].\n+class ParagraphConstraints {\n+  /// Creates constraints for laying out a pargraph.\n+  ///\n+  /// The [width] argument must not be null.\n+  ParagraphConstraints({ this.width }) {\n+    assert(width != null);\n+  }\n+\n+  /// The width the paragraph should use whey computing the positions of glyphs.","path":"sky/engine/core/dart/text.dart","position":15,"original_position":15,"commit_id":"07af9c4d75f03ea8da8a75740957c26cfd4412a7","original_commit_id":"07af9c4d75f03ea8da8a75740957c26cfd4412a7","user":{"login":"krisgiesing","id":13855787,"avatar_url":"https://avatars.githubusercontent.com/u/13855787?v=3","gravatar_id":"","url":"https://api.github.com/users/krisgiesing","html_url":"https://github.com/krisgiesing","followers_url":"https://api.github.com/users/krisgiesing/followers","following_url":"https://api.github.com/users/krisgiesing/following{/other_user}","gists_url":"https://api.github.com/users/krisgiesing/gists{/gist_id}","starred_url":"https://api.github.com/users/krisgiesing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisgiesing/subscriptions","organizations_url":"https://api.github.com/users/krisgiesing/orgs","repos_url":"https://api.github.com/users/krisgiesing/repos","events_url":"https://api.github.com/users/krisgiesing/events{/privacy}","received_events_url":"https://api.github.com/users/krisgiesing/received_events","type":"User","site_admin":false},"body":"Nit: typo \"whey\" => \"when\"","created_at":"2016-04-27T00:26:26Z","updated_at":"2016-04-27T00:26:26Z","html_url":"https://github.com/flutter/engine/pull/2622#discussion_r61187215","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/2622","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/61187215"},"html":{"href":"https://github.com/flutter/engine/pull/2622#discussion_r61187215"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/2622"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/2622","id":67979046,"html_url":"https://github.com/flutter/engine/pull/2622","diff_url":"https://github.com/flutter/engine/pull/2622.diff","patch_url":"https://github.com/flutter/engine/pull/2622.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/2622","number":2622,"state":"open","locked":false,"title":"Add ParagraphConstraints","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"This patch begins to update the Paragraph interface to something sensible. It\nintroduces a ParagraphConstraints object that is passed to layout() to control\nthe layout of the paragraph. Once clients are migrated over, the argument will\nbecome required.","created_at":"2016-04-27T00:23:00Z","updated_at":"2016-04-27T00:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4da63d93d084a46af5ca75ba085bd619e7fcb83f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/2622/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/2622/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/2622/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/07af9c4d75f03ea8da8a75740957c26cfd4412a7","head":{"label":"abarth:paragraph_constraints","ref":"paragraph_constraints","sha":"07af9c4d75f03ea8da8a75740957c26cfd4412a7","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"repo":{"id":39215675,"name":"engine","full_name":"abarth/engine","owner":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abarth/engine","description":"The Flutter engine","fork":true,"url":"https://api.github.com/repos/abarth/engine","forks_url":"https://api.github.com/repos/abarth/engine/forks","keys_url":"https://api.github.com/repos/abarth/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abarth/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abarth/engine/teams","hooks_url":"https://api.github.com/repos/abarth/engine/hooks","issue_events_url":"https://api.github.com/repos/abarth/engine/issues/events{/number}","events_url":"https://api.github.com/repos/abarth/engine/events","assignees_url":"https://api.github.com/repos/abarth/engine/assignees{/user}","branches_url":"https://api.github.com/repos/abarth/engine/branches{/branch}","tags_url":"https://api.github.com/repos/abarth/engine/tags","blobs_url":"https://api.github.com/repos/abarth/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abarth/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abarth/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/abarth/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abarth/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/abarth/engine/languages","stargazers_url":"https://api.github.com/repos/abarth/engine/stargazers","contributors_url":"https://api.github.com/repos/abarth/engine/contributors","subscribers_url":"https://api.github.com/repos/abarth/engine/subscribers","subscription_url":"https://api.github.com/repos/abarth/engine/subscription","commits_url":"https://api.github.com/repos/abarth/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/abarth/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/abarth/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/abarth/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/abarth/engine/contents/{+path}","compare_url":"https://api.github.com/repos/abarth/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abarth/engine/merges","archive_url":"https://api.github.com/repos/abarth/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abarth/engine/downloads","issues_url":"https://api.github.com/repos/abarth/engine/issues{/number}","pulls_url":"https://api.github.com/repos/abarth/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/abarth/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/abarth/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abarth/engine/labels{/name}","releases_url":"https://api.github.com/repos/abarth/engine/releases{/id}","deployments_url":"https://api.github.com/repos/abarth/engine/deployments","created_at":"2015-07-16T19:18:24Z","updated_at":"2015-12-30T17:43:29Z","pushed_at":"2016-04-27T00:22:57Z","git_url":"git://github.com/abarth/engine.git","ssh_url":"git@github.com:abarth/engine.git","clone_url":"https://github.com/abarth/engine.git","svn_url":"https://github.com/abarth/engine","homepage":"http://flutter.io","size":101134,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"1143592b1d0cb215e1e90e735ca93a44b3dfd4ff","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/engine/deployments","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-04-14T03:35:23Z","pushed_at":"2016-04-27T00:23:00Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":103908,"stargazers_count":871,"watchers_count":871,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":4,"forks":143,"open_issues":4,"watchers":871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/2622"},"html":{"href":"https://github.com/flutter/engine/pull/2622"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/2622"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/2622/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/2622/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/2622/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/07af9c4d75f03ea8da8a75740957c26cfd4412a7"}}}}