{"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/77502954","id":77502954,"diff_hunk":"@@ -0,0 +1,82 @@\n+/*\n+ * (C) Copyright 2012-2013 Nuxeo SA (http://nuxeo.com/) and others.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ *\n+ */\n+package org.nuxeo.launcher.config;\n+\n+import java.text.ParseException;\n+import java.util.regex.Matcher;\n+import java.util.regex.Pattern;\n+\n+public class JVMVersion implements Comparable<JVMVersion> {\n+\n+    public final int major;\n+\n+    public final int update;\n+\n+    public enum UpTo {\n+        MAJOR, UPDATE;\n+    }\n+\n+    public JVMVersion(int major, int minor) {\n+        this.major = major;\n+        update = minor;\n+    }\n+\n+    public int compareTo(JVMVersion o, UpTo upTo) {","path":"nuxeo-runtime/nuxeo-launcher-commons/src/main/java/org/nuxeo/launcher/config/JVMVersion.java","position":38,"original_position":38,"commit_id":"e02b8daf561fbfc678aeceabf7d5e9b3c58dd955","original_commit_id":"e02b8daf561fbfc678aeceabf7d5e9b3c58dd955","user":{"login":"efge","id":592810,"avatar_url":"https://avatars.githubusercontent.com/u/592810?v=3","gravatar_id":"","url":"https://api.github.com/users/efge","html_url":"https://github.com/efge","followers_url":"https://api.github.com/users/efge/followers","following_url":"https://api.github.com/users/efge/following{/other_user}","gists_url":"https://api.github.com/users/efge/gists{/gist_id}","starred_url":"https://api.github.com/users/efge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efge/subscriptions","organizations_url":"https://api.github.com/users/efge/orgs","repos_url":"https://api.github.com/users/efge/repos","events_url":"https://api.github.com/users/efge/events{/privacy}","received_events_url":"https://api.github.com/users/efge/received_events","type":"User","site_admin":false},"body":"Passing a boolean rather than an enum would have been enough.","created_at":"2016-09-05T10:39:38Z","updated_at":"2016-09-05T10:39:38Z","html_url":"https://github.com/nuxeo/nuxeo/pull/208#discussion_r77502954","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/77502954"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/208#discussion_r77502954"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208","id":83641912,"html_url":"https://github.com/nuxeo/nuxeo/pull/208","diff_url":"https://github.com/nuxeo/nuxeo/pull/208.diff","patch_url":"https://github.com/nuxeo/nuxeo/pull/208.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/208","number":208,"state":"open","locked":false,"title":"fix-NXP-20340-fix-version-parsing-in-configuration-generator-710","user":{"login":"nuxeojenkins","id":925456,"avatar_url":"https://avatars.githubusercontent.com/u/925456?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeojenkins","html_url":"https://github.com/nuxeojenkins","followers_url":"https://api.github.com/users/nuxeojenkins/followers","following_url":"https://api.github.com/users/nuxeojenkins/following{/other_user}","gists_url":"https://api.github.com/users/nuxeojenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeojenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeojenkins/subscriptions","organizations_url":"https://api.github.com/users/nuxeojenkins/orgs","repos_url":"https://api.github.com/users/nuxeojenkins/repos","events_url":"https://api.github.com/users/nuxeojenkins/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeojenkins/received_events","type":"User","site_admin":false},"body":"PR created from https://qa.nuxeo.org/jenkins/job/TestAndPush/job/ondemand-testandpush-slacoin/47/","created_at":"2016-09-01T14:22:12Z","updated_at":"2016-09-05T10:39:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486a4c7dd2183aec97c40de79e3eb65c9b9f8eee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/208/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/e02b8daf561fbfc678aeceabf7d5e9b3c58dd955","head":{"label":"nuxeo:fix-NXP-20340-fix-version-parsing-in-configuration-generator-710","ref":"fix-NXP-20340-fix-version-parsing-in-configuration-generator-710","sha":"e02b8daf561fbfc678aeceabf7d5e9b3c58dd955","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"name":"nuxeo","full_name":"nuxeo/nuxeo","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2016-08-31T18:17:15Z","pushed_at":"2016-09-05T10:32:05Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":244476,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":23,"forks":86,"open_issues":23,"watchers":116,"default_branch":"master"}},"base":{"label":"nuxeo:7.10","ref":"7.10","sha":"71cfea6b099d8bf99d584a60451b1ac0fc7eae7f","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"name":"nuxeo","full_name":"nuxeo/nuxeo","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2016-08-31T18:17:15Z","pushed_at":"2016-09-05T10:32:05Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":244476,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":23,"forks":86,"open_issues":23,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/208"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/208"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo/statuses/e02b8daf561fbfc678aeceabf7d5e9b3c58dd955"}}}}
{"actor":{"display_login":"efge"}}