{"action":"created","comment":{"url":"https://api.github.com/repos/ten24/slatwall/pulls/comments/74446971","id":74446971,"diff_hunk":"@@ -49,6 +49,21 @@ Notes:\n <cfcomponent accessors=\"true\" extends=\"HibachiDAO\">\n \t\n \t<cfscript>\n+\t\tpublic void function setSkusAsInactiveByProduct(required any product){\n+\t\t\tsetSkusAsInactiveByProductID(arguments.product.getProductID());\n+\t\t}\n+\t\t\n+\t\tpublic void function setSkusAsInactiveByProductID(required string productID){\n+\t\t\tvar updateQuery = new Query();\n+\t\t\tvar sql = '\n+\t\t\t\tUPDATE SwSku s\n+\t\t\t\tSET s.activeFlag=0,publishedFlag=0","path":"model/dao/ProductDAO.cfc","position":12,"original_position":12,"commit_id":"e0d536ca60bb13c6c23ed4e36697882445043458","original_commit_id":"e0d536ca60bb13c6c23ed4e36697882445043458","user":{"login":"sumitverma","id":464667,"avatar_url":"https://avatars.githubusercontent.com/u/464667?v=3","gravatar_id":"","url":"https://api.github.com/users/sumitverma","html_url":"https://github.com/sumitverma","followers_url":"https://api.github.com/users/sumitverma/followers","following_url":"https://api.github.com/users/sumitverma/following{/other_user}","gists_url":"https://api.github.com/users/sumitverma/gists{/gist_id}","starred_url":"https://api.github.com/users/sumitverma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumitverma/subscriptions","organizations_url":"https://api.github.com/users/sumitverma/orgs","repos_url":"https://api.github.com/users/sumitverma/repos","events_url":"https://api.github.com/users/sumitverma/events{/privacy}","received_events_url":"https://api.github.com/users/sumitverma/received_events","type":"User","site_admin":false},"body":"sku doesn't have publishedFlag","created_at":"2016-08-11T15:41:03Z","updated_at":"2016-08-11T15:41:03Z","html_url":"https://github.com/ten24/slatwall/pull/4727#discussion_r74446971","pull_request_url":"https://api.github.com/repos/ten24/slatwall/pulls/4727","_links":{"self":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/comments/74446971"},"html":{"href":"https://github.com/ten24/slatwall/pull/4727#discussion_r74446971"},"pull_request":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4727"}}},"pull_request":{"url":"https://api.github.com/repos/ten24/slatwall/pulls/4727","id":80979690,"html_url":"https://github.com/ten24/slatwall/pull/4727","diff_url":"https://github.com/ten24/slatwall/pull/4727.diff","patch_url":"https://github.com/ten24/slatwall/pull/4727.patch","issue_url":"https://api.github.com/repos/ten24/slatwall/issues/4727","number":4727,"state":"open","locked":false,"title":"if a product is marked inactive when it used to be active then set all","user":{"login":"rmarchandTen24","id":7649963,"avatar_url":"https://avatars.githubusercontent.com/u/7649963?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarchandTen24","html_url":"https://github.com/rmarchandTen24","followers_url":"https://api.github.com/users/rmarchandTen24/followers","following_url":"https://api.github.com/users/rmarchandTen24/following{/other_user}","gists_url":"https://api.github.com/users/rmarchandTen24/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarchandTen24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarchandTen24/subscriptions","organizations_url":"https://api.github.com/users/rmarchandTen24/orgs","repos_url":"https://api.github.com/users/rmarchandTen24/repos","events_url":"https://api.github.com/users/rmarchandTen24/events{/privacy}","received_events_url":"https://api.github.com/users/rmarchandTen24/received_events","type":"User","site_admin":false},"body":"skus inactive and published false\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/ten24/slatwall/4727)\n<!-- Reviewable:end -->\n","created_at":"2016-08-11T15:35:45Z","updated_at":"2016-08-11T15:41:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e5b050bc074878463a955cf812d7241bd89da4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ten24/slatwall/pulls/4727/commits","review_comments_url":"https://api.github.com/repos/ten24/slatwall/pulls/4727/comments","review_comment_url":"https://api.github.com/repos/ten24/slatwall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ten24/slatwall/issues/4727/comments","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/e0d536ca60bb13c6c23ed4e36697882445043458","head":{"label":"ten24:develop-rm-productinactivemakesskusinavtive","ref":"develop-rm-productinactivemakesskusinavtive","sha":"e0d536ca60bb13c6c23ed4e36697882445043458","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"slatwall","full_name":"ten24/slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/slatwall","forks_url":"https://api.github.com/repos/ten24/slatwall/forks","keys_url":"https://api.github.com/repos/ten24/slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/slatwall/events","assignees_url":"https://api.github.com/repos/ten24/slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/slatwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/ten24/slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/slatwall/merges","archive_url":"https://api.github.com/repos/ten24/slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/slatwall/releases{/id}","deployments_url":"https://api.github.com/repos/ten24/slatwall/deployments","created_at":"2011-03-15T16:58:28Z","updated_at":"2016-07-28T15:54:27Z","pushed_at":"2016-08-11T15:37:42Z","git_url":"git://github.com/ten24/slatwall.git","ssh_url":"git@github.com:ten24/slatwall.git","clone_url":"https://github.com/ten24/slatwall.git","svn_url":"https://github.com/ten24/slatwall","homepage":"http://www.slatwallcommerce.com","size":152925,"stargazers_count":103,"watchers_count":103,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":308,"forks":67,"open_issues":308,"watchers":103,"default_branch":"master"}},"base":{"label":"ten24:develop","ref":"develop","sha":"82d4149040c7d3eca1fa9576721b2c0079bff7a2","user":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"repo":{"id":1483572,"name":"slatwall","full_name":"ten24/slatwall","owner":{"login":"ten24","id":615272,"avatar_url":"https://avatars.githubusercontent.com/u/615272?v=3","gravatar_id":"","url":"https://api.github.com/users/ten24","html_url":"https://github.com/ten24","followers_url":"https://api.github.com/users/ten24/followers","following_url":"https://api.github.com/users/ten24/following{/other_user}","gists_url":"https://api.github.com/users/ten24/gists{/gist_id}","starred_url":"https://api.github.com/users/ten24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ten24/subscriptions","organizations_url":"https://api.github.com/users/ten24/orgs","repos_url":"https://api.github.com/users/ten24/repos","events_url":"https://api.github.com/users/ten24/events{/privacy}","received_events_url":"https://api.github.com/users/ten24/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ten24/slatwall","description":"Slatwall - An Open Source Commerce Platform","fork":false,"url":"https://api.github.com/repos/ten24/slatwall","forks_url":"https://api.github.com/repos/ten24/slatwall/forks","keys_url":"https://api.github.com/repos/ten24/slatwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ten24/slatwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ten24/slatwall/teams","hooks_url":"https://api.github.com/repos/ten24/slatwall/hooks","issue_events_url":"https://api.github.com/repos/ten24/slatwall/issues/events{/number}","events_url":"https://api.github.com/repos/ten24/slatwall/events","assignees_url":"https://api.github.com/repos/ten24/slatwall/assignees{/user}","branches_url":"https://api.github.com/repos/ten24/slatwall/branches{/branch}","tags_url":"https://api.github.com/repos/ten24/slatwall/tags","blobs_url":"https://api.github.com/repos/ten24/slatwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ten24/slatwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ten24/slatwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/ten24/slatwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ten24/slatwall/statuses/{sha}","languages_url":"https://api.github.com/repos/ten24/slatwall/languages","stargazers_url":"https://api.github.com/repos/ten24/slatwall/stargazers","contributors_url":"https://api.github.com/repos/ten24/slatwall/contributors","subscribers_url":"https://api.github.com/repos/ten24/slatwall/subscribers","subscription_url":"https://api.github.com/repos/ten24/slatwall/subscription","commits_url":"https://api.github.com/repos/ten24/slatwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/ten24/slatwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/ten24/slatwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/ten24/slatwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/ten24/slatwall/contents/{+path}","compare_url":"https://api.github.com/repos/ten24/slatwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ten24/slatwall/merges","archive_url":"https://api.github.com/repos/ten24/slatwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ten24/slatwall/downloads","issues_url":"https://api.github.com/repos/ten24/slatwall/issues{/number}","pulls_url":"https://api.github.com/repos/ten24/slatwall/pulls{/number}","milestones_url":"https://api.github.com/repos/ten24/slatwall/milestones{/number}","notifications_url":"https://api.github.com/repos/ten24/slatwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ten24/slatwall/labels{/name}","releases_url":"https://api.github.com/repos/ten24/slatwall/releases{/id}","deployments_url":"https://api.github.com/repos/ten24/slatwall/deployments","created_at":"2011-03-15T16:58:28Z","updated_at":"2016-07-28T15:54:27Z","pushed_at":"2016-08-11T15:37:42Z","git_url":"git://github.com/ten24/slatwall.git","ssh_url":"git@github.com:ten24/slatwall.git","clone_url":"https://github.com/ten24/slatwall.git","svn_url":"https://github.com/ten24/slatwall","homepage":"http://www.slatwallcommerce.com","size":152925,"stargazers_count":103,"watchers_count":103,"language":"ColdFusion","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":308,"forks":67,"open_issues":308,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4727"},"html":{"href":"https://github.com/ten24/slatwall/pull/4727"},"issue":{"href":"https://api.github.com/repos/ten24/slatwall/issues/4727"},"comments":{"href":"https://api.github.com/repos/ten24/slatwall/issues/4727/comments"},"review_comments":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4727/comments"},"review_comment":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ten24/slatwall/pulls/4727/commits"},"statuses":{"href":"https://api.github.com/repos/ten24/slatwall/statuses/e0d536ca60bb13c6c23ed4e36697882445043458"}}}}
{"actor":{"display_login":"sumitverma"}}