{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7603","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7603/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7603/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7603/events","html_url":"https://github.com/bitcoin/bitcoin/pull/7603","id":136559084,"number":7603,"title":"Build System: Use PACKAGE_TARNAME in NSIS script","user":{"login":"JeremyRand","id":244188,"avatar_url":"https://avatars.githubusercontent.com/u/244188?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyRand","html_url":"https://github.com/JeremyRand","followers_url":"https://api.github.com/users/JeremyRand/followers","following_url":"https://api.github.com/users/JeremyRand/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRand/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRand/subscriptions","organizations_url":"https://api.github.com/users/JeremyRand/orgs","repos_url":"https://api.github.com/users/JeremyRand/repos","events_url":"https://api.github.com/users/JeremyRand/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRand/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Build%20system","name":"Build system","color":"5319e7"},{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Windows","name":"Windows","color":"884400"}],"state":"open","locked":false,"assignee":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-02-26T00:44:12Z","updated_at":"2016-04-01T22:10:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7603","html_url":"https://github.com/bitcoin/bitcoin/pull/7603","diff_url":"https://github.com/bitcoin/bitcoin/pull/7603.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7603.patch"},"body":"This PR replaces the hardcoded string \"bitcoin\" in the NSIS script with the autoconf variable PACKAGE_TARNAME; fixes https://github.com/bitcoin/bitcoin/issues/7265 .\r\n\r\nPlaces where I chose not to replace:\r\n\r\n1. bitcoin.ico wasn't replaced because it doesn't seem to be relevant to the build system and its filename never affects the end user.\r\n2. InstallDir wasn't replaced because the current text has an uppercase B, and I'm not sure of a good way to capitalize the result of PACKAGE_TARNAME.\r\n3. A comment in the Main Installer section wasn't replaced because comments don't ever face the end user.\r\n4. The registry value \"URL:Bitcoin\" wasn't replaced for the same reason as InstallDir.\r\n5. Startup shortcut wasn't replaced for the same reason as InstallDir.\r\n\r\nAll other appearances of \"bitcoin\" in the NSIS script were replaced."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/204587676","html_url":"https://github.com/bitcoin/bitcoin/pull/7603#issuecomment-204587676","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7603","id":204587676,"user":{"login":"JeremyRand","id":244188,"avatar_url":"https://avatars.githubusercontent.com/u/244188?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyRand","html_url":"https://github.com/JeremyRand","followers_url":"https://api.github.com/users/JeremyRand/followers","following_url":"https://api.github.com/users/JeremyRand/following{/other_user}","gists_url":"https://api.github.com/users/JeremyRand/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyRand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyRand/subscriptions","organizations_url":"https://api.github.com/users/JeremyRand/orgs","repos_url":"https://api.github.com/users/JeremyRand/repos","events_url":"https://api.github.com/users/JeremyRand/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyRand/received_events","type":"User","site_admin":false},"created_at":"2016-04-01T22:10:43Z","updated_at":"2016-04-01T22:10:43Z","body":"@theuni Is it okay if I modify the 4 lines at https://github.com/theuni/bitcoin/commit/411a71f57e075c7d0a7c79bf1f7c7d249d5145da#diff-67e997bcfdac55191033d57a16d1408aR17 to use PACKAGE_TARNAME instead of hardcoding the \"bitcoin\" substring on those lines?"}}