{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/13963","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13963/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13963/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13963/events","html_url":"https://github.com/cms-sw/cmssw/pull/13963","id":146341387,"number":13963,"title":"Split up GEM and ME0 customizations","user":{"login":"dildick","id":4134786,"avatar_url":"https://avatars.githubusercontent.com/u/4134786?v=3","gravatar_id":"","url":"https://api.github.com/users/dildick","html_url":"https://github.com/dildick","followers_url":"https://api.github.com/users/dildick/followers","following_url":"https://api.github.com/users/dildick/following{/other_user}","gists_url":"https://api.github.com/users/dildick/gists{/gist_id}","starred_url":"https://api.github.com/users/dildick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dildick/subscriptions","organizations_url":"https://api.github.com/users/dildick/orgs","repos_url":"https://api.github.com/users/dildick/repos","events_url":"https://api.github.com/users/dildick/events{/privacy}","received_events_url":"https://api.github.com/users/dildick/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-pending","name":"core-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":412,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-04-21T14:50:36Z","due_on":null,"closed_at":null},"comments":53,"created_at":"2016-04-06T14:59:12Z","updated_at":"2016-04-21T15:07:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13963","html_url":"https://github.com/cms-sw/cmssw/pull/13963","diff_url":"https://github.com/cms-sw/cmssw/pull/13963.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/13963.patch"},"body":"As requested by @slava77 in https://github.com/cms-sw/cmssw/pull/13880#issuecomment-204594636 this PR splits up the GEM and ME0 customizations. GEMs will be enabled starting Run3 (GE1/1), with (possibly) an extension in Phase2 (GE2/1). ME0 will only be enabled starting Phase2. Including GEMs in the Run2_2017 era may be done in the future if the GE1/1 slice test goes well. \r\n\r\nThis PR affects Phase2, Phase2_dev and Run3. The baseline or other eras should not be affected. \r\n\r\nHGCal and DT fail at the DIGI and L1 step respectively in the simulation unfortunately. However, the simple cmsDriver command below does produce a syntactically correct configuration (see https://github.com/cms-sw/cmssw/pull/13880#issuecomment-204279041)\r\n\r\n<PRE>\r\ncmsDriver.py SingleMuPt100_cfi  \\\r\n--conditions auto:upgradePLS3 \\\r\n-n 10 \\\r\n--eventcontent FEVTDEBUGHLT \\\r\n-s GEN,SIM,DIGI:pdigi_valid,L1,DIGI2RAW,RAW2DIGI,L1Reco,RECO,VALIDATION \\\r\n--datatier GEN-SIM-RECO-RAW-VALIDATION \\\r\n--geometry Extended2023Muon,Extended2023MuonReco \\\r\n--era Phase2 \\\r\n--magField 38T_PostLS1 \\\r\n--no_exec \\\r\n--fileout file:out_all.root\r\n</PRE>\r\n\r\n@calabria, @jshlee"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/212963591","html_url":"https://github.com/cms-sw/cmssw/pull/13963#issuecomment-212963591","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13963","id":212963591,"user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T15:07:44Z","updated_at":"2016-04-21T15:07:44Z","body":"I prefer the `toModify` using `dict` over `toReplaceWith`. The reason is if you have two eras both doing `toReplaceWith` then the last one wins, while if they both use `toModify` but change different parameters then the co-exist. So the change would look like\r\n```python\r\n eras.phase2_muon.toModify( standAloneMuons, STATrajBuilderParameters = dict(\r\n   FilterParameters = dict( EnableGEMMeasurement = cms.bool(True)),\r\n   BWFilterParameters = dict( EnableGEMMeasurement = cms.bool(True)) ) )\r\n```\r\nThis could be shortened by doing\r\n```python\r\n_enableGEMMeasurement = dict( EnableGEMMeasurement = cms.bool(True) )\r\n eras.phase2_muon.toModify( standAloneMuons, STATrajBuilderParameters = dict(\r\n   FilterParameters = _enableGEMMeasurement,\r\n   BWFilterParameters = _enableGEMMeasurement ) )\r\n```"}}