{"action":"created","issue":{"url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/issues/141","repository_url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray","labels_url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/issues/141/comments","events_url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/issues/141/events","html_url":"https://github.com/bil-elmoussaoui/Hardcode-Tray/issues/141","id":128365135,"number":141,"title":"Update chrome script","user":{"login":"bil-elmoussaoui","id":7660997,"avatar_url":"https://avatars.githubusercontent.com/u/7660997?v=3","gravatar_id":"","url":"https://api.github.com/users/bil-elmoussaoui","html_url":"https://github.com/bil-elmoussaoui","followers_url":"https://api.github.com/users/bil-elmoussaoui/followers","following_url":"https://api.github.com/users/bil-elmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bil-elmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bil-elmoussaoui/orgs","repos_url":"https://api.github.com/users/bil-elmoussaoui/repos","events_url":"https://api.github.com/users/bil-elmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bil-elmoussaoui/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/labels/help%20wanted","name":"help wanted","color":"159818"}],"state":"open","locked":false,"assignee":{"login":"bil-elmoussaoui","id":7660997,"avatar_url":"https://avatars.githubusercontent.com/u/7660997?v=3","gravatar_id":"","url":"https://api.github.com/users/bil-elmoussaoui","html_url":"https://github.com/bil-elmoussaoui","followers_url":"https://api.github.com/users/bil-elmoussaoui/followers","following_url":"https://api.github.com/users/bil-elmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bil-elmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bil-elmoussaoui/orgs","repos_url":"https://api.github.com/users/bil-elmoussaoui/repos","events_url":"https://api.github.com/users/bil-elmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bil-elmoussaoui/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/milestones/1","html_url":"https://github.com/bil-elmoussaoui/Hardcode-Tray/milestones/v2.3","labels_url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/milestones/1/labels","id":1458557,"number":1,"title":"v2.3","description":"","creator":{"login":"bil-elmoussaoui","id":7660997,"avatar_url":"https://avatars.githubusercontent.com/u/7660997?v=3","gravatar_id":"","url":"https://api.github.com/users/bil-elmoussaoui","html_url":"https://github.com/bil-elmoussaoui","followers_url":"https://api.github.com/users/bil-elmoussaoui/followers","following_url":"https://api.github.com/users/bil-elmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bil-elmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bil-elmoussaoui/orgs","repos_url":"https://api.github.com/users/bil-elmoussaoui/repos","events_url":"https://api.github.com/users/bil-elmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bil-elmoussaoui/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2015-12-14T07:33:13Z","updated_at":"2016-03-25T07:37:18Z","due_on":"2015-12-30T23:00:00Z","closed_at":null},"comments":55,"created_at":"2016-01-24T01:23:20Z","updated_at":"2016-05-07T21:56:13Z","closed_at":null,"body":"In order to fix this issue #138 I updated the code we have been using to fix Google chrome/Chromuim icons. \r\nEverything works fine. The only issue is now it's possible to fix icons from different pak files. \r\nThose lines [#L504-L509](https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/script.py#L504-L509) need to be updated in order to change counter `do` if the pak file of the next icon is different from the current one(remove the extracted file and the move the pak file) or if the pak file of the current icon is different from the previous one(copy the new pak file and unpack it to the extract  folder).\r\nWe will need to modify the [chrome](https://github.com/bil-elmoussaoui/Hardcode-Tray/blob/master/database/scripts/chrome) script file too i guess."},"comment":{"url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/issues/comments/217671033","html_url":"https://github.com/bil-elmoussaoui/Hardcode-Tray/issues/141#issuecomment-217671033","issue_url":"https://api.github.com/repos/bil-elmoussaoui/Hardcode-Tray/issues/141","id":217671033,"user":{"login":"bil-elmoussaoui","id":7660997,"avatar_url":"https://avatars.githubusercontent.com/u/7660997?v=3","gravatar_id":"","url":"https://api.github.com/users/bil-elmoussaoui","html_url":"https://github.com/bil-elmoussaoui","followers_url":"https://api.github.com/users/bil-elmoussaoui/followers","following_url":"https://api.github.com/users/bil-elmoussaoui/following{/other_user}","gists_url":"https://api.github.com/users/bil-elmoussaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bil-elmoussaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bil-elmoussaoui/subscriptions","organizations_url":"https://api.github.com/users/bil-elmoussaoui/orgs","repos_url":"https://api.github.com/users/bil-elmoussaoui/repos","events_url":"https://api.github.com/users/bil-elmoussaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bil-elmoussaoui/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T21:56:13Z","updated_at":"2016-05-07T21:56:13Z","body":"There was some missing stuff on the chrome script, this is the new version, but i still have an issue \r\n```python\r\n#!/usr/bin/python3\r\n\r\nimport struct\r\nimport json\r\nimport sys\r\nimport data_pack\r\nimport os\r\nfrom imp import load_source\r\n\r\nfilename = sys.argv[3]+sys.argv[5]\r\nicon_to_repl = sys.argv[2]\r\nicon_for_repl = sys.argv[1]\r\n\r\nsvgtopng = load_source('svgtopng', './database/scripts/svgtopng.py')\r\n\r\nfilename_svg, file_extension = os.path.splitext(icon_for_repl)\r\nif file_extension == '.svg':\r\n    pngbytes = svgtopng.convert_svg2bin(icon_for_repl)\r\nelse:\r\n    with open(icon_for_repl, 'rb') as pngfile:\r\n        pngbytes = pngfile.read()\r\n\r\ndataPack = data_pack.ReadDataPack(filename)\r\ndataPack.resources[int(icon_to_repl)] = pngbytes\r\n\r\ndata_pack.WriteDataPack(dataPack.resources, filename, BINARY)\r\n\r\n```\r\n\r\nthe error message is \r\n```\r\nfixing failed with error:\r\n\tTraceback (most recent call last):\r\n\t  File \"./database/scripts/chrome\", line 26, in <module>\r\n\t    data_pack.WriteDataPack(dataPack.resources, filename, BINARY)\r\n\tNameError: name 'BINARY' is not defined\r\n\t\r\n\r\n```"}}