{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/50198081","id":50198081,"diff_hunk":"@@ -0,0 +1,105 @@\n+/*\n+ * Copyright (C) 2015 LinkedIn Corp. All rights reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use\n+ * this file except in compliance with the License. You may obtain a copy of the\n+ * License at  http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed\n+ * under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+ * CONDITIONS OF ANY KIND, either express or implied.\n+ */\n+\n+package gobblin.config.common.impl;\n+\n+import java.util.List;\n+\n+import com.typesafe.config.Config;\n+\n+import gobblin.config.store.api.ConfigKeyPath;\n+import gobblin.config.store.api.ConfigStore;\n+import gobblin.config.store.api.ConfigStoreWithResolution;\n+\n+/**\n+ * ConfigStoreBackedValueInspector always query the underline {@link ConfigStore} to get the freshest \n+ * {@link com.typesafe.config.Config}\n+ * @author mitu\n+ *\n+ */\n+public class ConfigStoreBackedValueInspector implements ConfigStoreValueInspector{\n+\n+  private final ConfigStore cs;\n+  private final String version;\n+  private final ConfigStoreTopologyInspector topology;\n+\n+  /**\n+   * @param cs       - internal {@link ConfigStore} to retrieve configuration \n+   * @param version  - version of the {@link ConfigStore}\n+   * @param topology - corresponding {@link ConfigStoreTopologyInspector} for the input {@link ConfigStore}\n+   */\n+  public ConfigStoreBackedValueInspector(ConfigStore cs, String version, ConfigStoreTopologyInspector topology) {\n+    this.cs = cs;\n+    this.version = version;\n+    this.topology = topology;\n+  }\n+\n+  public ConfigStore getConfigStore() {\n+    return this.cs;\n+  }\n+\n+  public String getVersion() {\n+    return this.version;\n+  }\n+  \n+  /**\n+   * {@inheritDoc}.\n+   *\n+   * <p>\n+   *   This implementation simply delegate the functionality to the internal {@link ConfigStore}/version\n+   * </p>\n+   */\n+  @Override\n+  public Config getOwnConfig(ConfigKeyPath configKey) {\n+    return this.cs.getOwnConfig(configKey, version);\n+  }\n+\n+  /**\n+   * {@inheritDoc}.\n+   *\n+   * <p>\n+   *   This implementation simply delegate the functionality to the internal {@link ConfigStore}/version if\n+   *   the internal {@link ConfigStore} is {@link ConfigStoreWithResolution}, otherwise based on {@link ConfigStoreTopologyInspector}\n+   *   \n+   *   1. find out all the imports recursively\n+   *   2. resolved the config on the fly\n+   * </p>\n+   */\n+  @Override\n+  public Config getResolvedConfig(ConfigKeyPath configKey) {\n+    if (this.cs instanceof ConfigStoreWithResolution) {\n+      return ((ConfigStoreWithResolution) this.cs).getResolvedConfig(configKey, this.version);\n+    }\n+\n+    List<ConfigKeyPath> recursiveImports = this.topology.getImportsRecursively(configKey);\n+    Config initialConfig = this.getOwnConfig(configKey);\n+    \n+    // merge with other configs from imports\n+    for(ConfigKeyPath p: recursiveImports){\n+      initialConfig = initialConfig.withFallback(this.getConfigInSelfChain(p));\n+    }\n+    \n+    // merge with configs from parent\n+    initialConfig = initialConfig.withFallback(this.getConfigInSelfChain(configKey.getParent()));\n+    \n+    return initialConfig;\n+  }\n+  \n+  // return resolved config from self -> parent .. -> root\n+  private Config getConfigInSelfChain(ConfigKeyPath configKey){\n+    Config result = this.getOwnConfig(configKey);\n+    if(configKey.isRootPath())\n+      return result;\n+    \n+    return result.withFallback(getConfigInSelfChain(configKey.getParent()));","path":"gobblin-config-management/gobblin-config-core/src/main/java/gobblin/config/common/impl/ConfigStoreBackedValueInspector.java","position":103,"original_position":103,"commit_id":"1fd0c1671dba093931e14d2dcd1153a7cad3437f","original_commit_id":"1fd0c1671dba093931e14d2dcd1153a7cad3437f","user":{"login":"ibuenros","id":1364112,"avatar_url":"https://avatars.githubusercontent.com/u/1364112?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuenros","html_url":"https://github.com/ibuenros","followers_url":"https://api.github.com/users/ibuenros/followers","following_url":"https://api.github.com/users/ibuenros/following{/other_user}","gists_url":"https://api.github.com/users/ibuenros/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuenros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuenros/subscriptions","organizations_url":"https://api.github.com/users/ibuenros/orgs","repos_url":"https://api.github.com/users/ibuenros/repos","events_url":"https://api.github.com/users/ibuenros/events{/privacy}","received_events_url":"https://api.github.com/users/ibuenros/received_events","type":"User","site_admin":false},"body":"It seems to me this will not load parent imports. Am I wrong?","created_at":"2016-01-20T00:22:45Z","updated_at":"2016-01-20T00:22:45Z","html_url":"https://github.com/linkedin/gobblin/pull/605#discussion_r50198081","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/605","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/50198081"},"html":{"href":"https://github.com/linkedin/gobblin/pull/605#discussion_r50198081"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/605"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/605","id":55936699,"html_url":"https://github.com/linkedin/gobblin/pull/605","diff_url":"https://github.com/linkedin/gobblin/pull/605.diff","patch_url":"https://github.com/linkedin/gobblin/pull/605.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/605","number":605,"state":"open","locked":false,"title":"caching layer for ConfigStore.getConfig()","user":{"login":"tuGithub","id":9965624,"avatar_url":"https://avatars.githubusercontent.com/u/9965624?v=3","gravatar_id":"","url":"https://api.github.com/users/tuGithub","html_url":"https://github.com/tuGithub","followers_url":"https://api.github.com/users/tuGithub/followers","following_url":"https://api.github.com/users/tuGithub/following{/other_user}","gists_url":"https://api.github.com/users/tuGithub/gists{/gist_id}","starred_url":"https://api.github.com/users/tuGithub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuGithub/subscriptions","organizations_url":"https://api.github.com/users/tuGithub/orgs","repos_url":"https://api.github.com/users/tuGithub/repos","events_url":"https://api.github.com/users/tuGithub/events{/privacy}","received_events_url":"https://api.github.com/users/tuGithub/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-13T18:32:04Z","updated_at":"2016-01-20T00:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26b6b76cf42f788a2d48a6d3e16c6343834b4a92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/605/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/605/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/605/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/1fd0c1671dba093931e14d2dcd1153a7cad3437f","head":{"label":"tuGithub:configManagement1_6","ref":"configManagement1_6","sha":"1fd0c1671dba093931e14d2dcd1153a7cad3437f","user":{"login":"tuGithub","id":9965624,"avatar_url":"https://avatars.githubusercontent.com/u/9965624?v=3","gravatar_id":"","url":"https://api.github.com/users/tuGithub","html_url":"https://github.com/tuGithub","followers_url":"https://api.github.com/users/tuGithub/followers","following_url":"https://api.github.com/users/tuGithub/following{/other_user}","gists_url":"https://api.github.com/users/tuGithub/gists{/gist_id}","starred_url":"https://api.github.com/users/tuGithub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuGithub/subscriptions","organizations_url":"https://api.github.com/users/tuGithub/orgs","repos_url":"https://api.github.com/users/tuGithub/repos","events_url":"https://api.github.com/users/tuGithub/events{/privacy}","received_events_url":"https://api.github.com/users/tuGithub/received_events","type":"User","site_admin":false},"repo":{"id":34822460,"name":"gobblin-1","full_name":"tuGithub/gobblin-1","owner":{"login":"tuGithub","id":9965624,"avatar_url":"https://avatars.githubusercontent.com/u/9965624?v=3","gravatar_id":"","url":"https://api.github.com/users/tuGithub","html_url":"https://github.com/tuGithub","followers_url":"https://api.github.com/users/tuGithub/followers","following_url":"https://api.github.com/users/tuGithub/following{/other_user}","gists_url":"https://api.github.com/users/tuGithub/gists{/gist_id}","starred_url":"https://api.github.com/users/tuGithub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuGithub/subscriptions","organizations_url":"https://api.github.com/users/tuGithub/orgs","repos_url":"https://api.github.com/users/tuGithub/repos","events_url":"https://api.github.com/users/tuGithub/events{/privacy}","received_events_url":"https://api.github.com/users/tuGithub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuGithub/gobblin-1","description":"","fork":true,"url":"https://api.github.com/repos/tuGithub/gobblin-1","forks_url":"https://api.github.com/repos/tuGithub/gobblin-1/forks","keys_url":"https://api.github.com/repos/tuGithub/gobblin-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuGithub/gobblin-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuGithub/gobblin-1/teams","hooks_url":"https://api.github.com/repos/tuGithub/gobblin-1/hooks","issue_events_url":"https://api.github.com/repos/tuGithub/gobblin-1/issues/events{/number}","events_url":"https://api.github.com/repos/tuGithub/gobblin-1/events","assignees_url":"https://api.github.com/repos/tuGithub/gobblin-1/assignees{/user}","branches_url":"https://api.github.com/repos/tuGithub/gobblin-1/branches{/branch}","tags_url":"https://api.github.com/repos/tuGithub/gobblin-1/tags","blobs_url":"https://api.github.com/repos/tuGithub/gobblin-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuGithub/gobblin-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuGithub/gobblin-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuGithub/gobblin-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuGithub/gobblin-1/statuses/{sha}","languages_url":"https://api.github.com/repos/tuGithub/gobblin-1/languages","stargazers_url":"https://api.github.com/repos/tuGithub/gobblin-1/stargazers","contributors_url":"https://api.github.com/repos/tuGithub/gobblin-1/contributors","subscribers_url":"https://api.github.com/repos/tuGithub/gobblin-1/subscribers","subscription_url":"https://api.github.com/repos/tuGithub/gobblin-1/subscription","commits_url":"https://api.github.com/repos/tuGithub/gobblin-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuGithub/gobblin-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuGithub/gobblin-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuGithub/gobblin-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuGithub/gobblin-1/contents/{+path}","compare_url":"https://api.github.com/repos/tuGithub/gobblin-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuGithub/gobblin-1/merges","archive_url":"https://api.github.com/repos/tuGithub/gobblin-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuGithub/gobblin-1/downloads","issues_url":"https://api.github.com/repos/tuGithub/gobblin-1/issues{/number}","pulls_url":"https://api.github.com/repos/tuGithub/gobblin-1/pulls{/number}","milestones_url":"https://api.github.com/repos/tuGithub/gobblin-1/milestones{/number}","notifications_url":"https://api.github.com/repos/tuGithub/gobblin-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuGithub/gobblin-1/labels{/name}","releases_url":"https://api.github.com/repos/tuGithub/gobblin-1/releases{/id}","created_at":"2015-04-29T22:53:44Z","updated_at":"2015-04-29T22:53:45Z","pushed_at":"2016-01-15T22:04:05Z","git_url":"git://github.com/tuGithub/gobblin-1.git","ssh_url":"git@github.com:tuGithub/gobblin-1.git","clone_url":"https://github.com/tuGithub/gobblin-1.git","svn_url":"https://github.com/tuGithub/gobblin-1","homepage":null,"size":81961,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"27341edaf174a9d54214ce68cd384cf6f8e86779","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"Universal data ingestion framework for Hadoop.","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","created_at":"2014-12-01T18:10:50Z","updated_at":"2016-01-19T20:23:12Z","pushed_at":"2016-01-19T23:33:33Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":"https://github.com/linkedin/gobblin/wiki","size":160637,"stargazers_count":385,"watchers_count":385,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"open_issues_count":38,"forks":150,"open_issues":38,"watchers":385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/605"},"html":{"href":"https://github.com/linkedin/gobblin/pull/605"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/605"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/605/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/605/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/605/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/1fd0c1671dba093931e14d2dcd1153a7cad3437f"}}}}