{"action":"created","comment":{"url":"https://api.github.com/repos/twsouthwick/corefx/pulls/comments/62252766","id":62252766,"diff_hunk":"@@ -301,48 +321,60 @@ public abstract class MemberDescriptor {\n         ///       NOTE: If you make a change here, you likely need to change GetHashCode() as well.\n         ///    </para>\n         /// </devdoc>\n-        public override bool Equals(object obj) {\n-            if (this == obj) {\n+        public override bool Equals(object obj)\n+        {\n+            if (this == obj)\n+            {\n                 return true;\n             }\n-            if (obj == null) {\n+            if (obj == null)\n+            {\n                 return false;\n             }\n \n-            if (obj.GetType() != GetType()) {\n+            if (obj.GetType() != GetType())\n+            {\n                 return false;\n             }\n \n             MemberDescriptor mdObj = (MemberDescriptor)obj;\n             FilterAttributesIfNeeded();\n             mdObj.FilterAttributesIfNeeded();\n \n-            if (mdObj.nameHash != nameHash) {\n+            if (mdObj._nameHash != _nameHash)\n+            {\n                 return false;\n             }\n \n-            if ((mdObj.category == null) != (category == null) ||\n-                (category != null && !mdObj.category.Equals(category))) {\n+            if ((mdObj._category == null) != (_category == null) ||\n+                (_category != null && !mdObj._category.Equals(_category)))\n+            {\n                 return false;\n             }\n \n-            if ((mdObj.description == null) != (description == null) ||\n-                (description != null && !mdObj.category.Equals(description))) {\n+            if ((mdObj._description == null) != (_description == null) ||\n+                (_description != null && !mdObj._category.Equals(_description)))","path":"src/System.ComponentModel.TypeConverter/src/System/ComponentModel/MemberDescriptor.cs","position":474,"original_position":474,"commit_id":"bf40bc944580107cfe81055a8f6e3710d9785bcf","original_commit_id":"bf40bc944580107cfe81055a8f6e3710d9785bcf","user":{"login":"Tanya-Solyanik","id":15823268,"avatar_url":"https://avatars.githubusercontent.com/u/15823268?v=3","gravatar_id":"","url":"https://api.github.com/users/Tanya-Solyanik","html_url":"https://github.com/Tanya-Solyanik","followers_url":"https://api.github.com/users/Tanya-Solyanik/followers","following_url":"https://api.github.com/users/Tanya-Solyanik/following{/other_user}","gists_url":"https://api.github.com/users/Tanya-Solyanik/gists{/gist_id}","starred_url":"https://api.github.com/users/Tanya-Solyanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tanya-Solyanik/subscriptions","organizations_url":"https://api.github.com/users/Tanya-Solyanik/orgs","repos_url":"https://api.github.com/users/Tanya-Solyanik/repos","events_url":"https://api.github.com/users/Tanya-Solyanik/events{/privacy}","received_events_url":"https://api.github.com/users/Tanya-Solyanik/received_events","type":"User","site_admin":false},"body":"Consider diffing reference source against NetfxDev1 source, This is the only change that I know of in this namespace in 4.6.2, but maybe my records are incomplete...","created_at":"2016-05-05T20:49:35Z","updated_at":"2016-05-05T20:49:36Z","html_url":"https://github.com/twsouthwick/corefx/pull/1#discussion_r62252766","pull_request_url":"https://api.github.com/repos/twsouthwick/corefx/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/twsouthwick/corefx/pulls/comments/62252766"},"html":{"href":"https://github.com/twsouthwick/corefx/pull/1#discussion_r62252766"},"pull_request":{"href":"https://api.github.com/repos/twsouthwick/corefx/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/twsouthwick/corefx/pulls/1","id":69048888,"html_url":"https://github.com/twsouthwick/corefx/pull/1","diff_url":"https://github.com/twsouthwick/corefx/pull/1.diff","patch_url":"https://github.com/twsouthwick/corefx/pull/1.patch","issue_url":"https://api.github.com/repos/twsouthwick/corefx/issues/1","number":1,"state":"open","locked":false,"title":"PR of just changes from desktop","user":{"login":"twsouthwick","id":583206,"avatar_url":"https://avatars.githubusercontent.com/u/583206?v=3","gravatar_id":"","url":"https://api.github.com/users/twsouthwick","html_url":"https://github.com/twsouthwick","followers_url":"https://api.github.com/users/twsouthwick/followers","following_url":"https://api.github.com/users/twsouthwick/following{/other_user}","gists_url":"https://api.github.com/users/twsouthwick/gists{/gist_id}","starred_url":"https://api.github.com/users/twsouthwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twsouthwick/subscriptions","organizations_url":"https://api.github.com/users/twsouthwick/orgs","repos_url":"https://api.github.com/users/twsouthwick/repos","events_url":"https://api.github.com/users/twsouthwick/events{/privacy}","received_events_url":"https://api.github.com/users/twsouthwick/received_events","type":"User","site_admin":false},"body":"This reverts commit a34c2022ff373bb4eb08211f45ae1471793cfd61.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/twsouthwick/corefx/1)\n<!-- Reviewable:end -->\n","created_at":"2016-05-05T18:33:09Z","updated_at":"2016-05-05T20:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e24bff7a4e37cc43bddcbcfe4822d30770f8c07d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twsouthwick/corefx/pulls/1/commits","review_comments_url":"https://api.github.com/repos/twsouthwick/corefx/pulls/1/comments","review_comment_url":"https://api.github.com/repos/twsouthwick/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twsouthwick/corefx/issues/1/comments","statuses_url":"https://api.github.com/repos/twsouthwick/corefx/statuses/bf40bc944580107cfe81055a8f6e3710d9785bcf","head":{"label":"twsouthwick:typedescriptor-for-comparison","ref":"typedescriptor-for-comparison","sha":"bf40bc944580107cfe81055a8f6e3710d9785bcf","user":{"login":"twsouthwick","id":583206,"avatar_url":"https://avatars.githubusercontent.com/u/583206?v=3","gravatar_id":"","url":"https://api.github.com/users/twsouthwick","html_url":"https://github.com/twsouthwick","followers_url":"https://api.github.com/users/twsouthwick/followers","following_url":"https://api.github.com/users/twsouthwick/following{/other_user}","gists_url":"https://api.github.com/users/twsouthwick/gists{/gist_id}","starred_url":"https://api.github.com/users/twsouthwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twsouthwick/subscriptions","organizations_url":"https://api.github.com/users/twsouthwick/orgs","repos_url":"https://api.github.com/users/twsouthwick/repos","events_url":"https://api.github.com/users/twsouthwick/events{/privacy}","received_events_url":"https://api.github.com/users/twsouthwick/received_events","type":"User","site_admin":false},"repo":{"id":34358088,"name":"corefx","full_name":"twsouthwick/corefx","owner":{"login":"twsouthwick","id":583206,"avatar_url":"https://avatars.githubusercontent.com/u/583206?v=3","gravatar_id":"","url":"https://api.github.com/users/twsouthwick","html_url":"https://github.com/twsouthwick","followers_url":"https://api.github.com/users/twsouthwick/followers","following_url":"https://api.github.com/users/twsouthwick/following{/other_user}","gists_url":"https://api.github.com/users/twsouthwick/gists{/gist_id}","starred_url":"https://api.github.com/users/twsouthwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twsouthwick/subscriptions","organizations_url":"https://api.github.com/users/twsouthwick/orgs","repos_url":"https://api.github.com/users/twsouthwick/repos","events_url":"https://api.github.com/users/twsouthwick/events{/privacy}","received_events_url":"https://api.github.com/users/twsouthwick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twsouthwick/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/twsouthwick/corefx","forks_url":"https://api.github.com/repos/twsouthwick/corefx/forks","keys_url":"https://api.github.com/repos/twsouthwick/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twsouthwick/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twsouthwick/corefx/teams","hooks_url":"https://api.github.com/repos/twsouthwick/corefx/hooks","issue_events_url":"https://api.github.com/repos/twsouthwick/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/twsouthwick/corefx/events","assignees_url":"https://api.github.com/repos/twsouthwick/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/twsouthwick/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/twsouthwick/corefx/tags","blobs_url":"https://api.github.com/repos/twsouthwick/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twsouthwick/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twsouthwick/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/twsouthwick/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twsouthwick/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/twsouthwick/corefx/languages","stargazers_url":"https://api.github.com/repos/twsouthwick/corefx/stargazers","contributors_url":"https://api.github.com/repos/twsouthwick/corefx/contributors","subscribers_url":"https://api.github.com/repos/twsouthwick/corefx/subscribers","subscription_url":"https://api.github.com/repos/twsouthwick/corefx/subscription","commits_url":"https://api.github.com/repos/twsouthwick/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/twsouthwick/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/twsouthwick/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/twsouthwick/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/twsouthwick/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/twsouthwick/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twsouthwick/corefx/merges","archive_url":"https://api.github.com/repos/twsouthwick/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twsouthwick/corefx/downloads","issues_url":"https://api.github.com/repos/twsouthwick/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/twsouthwick/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/twsouthwick/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/twsouthwick/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twsouthwick/corefx/labels{/name}","releases_url":"https://api.github.com/repos/twsouthwick/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/twsouthwick/corefx/deployments","created_at":"2015-04-21T23:46:13Z","updated_at":"2016-04-04T15:36:41Z","pushed_at":"2016-05-05T18:33:24Z","git_url":"git://github.com/twsouthwick/corefx.git","ssh_url":"git@github.com:twsouthwick/corefx.git","clone_url":"https://github.com/twsouthwick/corefx.git","svn_url":"https://github.com/twsouthwick/corefx","homepage":"","size":67255,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"twsouthwick:typedescriptor-just-desktop","ref":"typedescriptor-just-desktop","sha":"a34c2022ff373bb4eb08211f45ae1471793cfd61","user":{"login":"twsouthwick","id":583206,"avatar_url":"https://avatars.githubusercontent.com/u/583206?v=3","gravatar_id":"","url":"https://api.github.com/users/twsouthwick","html_url":"https://github.com/twsouthwick","followers_url":"https://api.github.com/users/twsouthwick/followers","following_url":"https://api.github.com/users/twsouthwick/following{/other_user}","gists_url":"https://api.github.com/users/twsouthwick/gists{/gist_id}","starred_url":"https://api.github.com/users/twsouthwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twsouthwick/subscriptions","organizations_url":"https://api.github.com/users/twsouthwick/orgs","repos_url":"https://api.github.com/users/twsouthwick/repos","events_url":"https://api.github.com/users/twsouthwick/events{/privacy}","received_events_url":"https://api.github.com/users/twsouthwick/received_events","type":"User","site_admin":false},"repo":{"id":34358088,"name":"corefx","full_name":"twsouthwick/corefx","owner":{"login":"twsouthwick","id":583206,"avatar_url":"https://avatars.githubusercontent.com/u/583206?v=3","gravatar_id":"","url":"https://api.github.com/users/twsouthwick","html_url":"https://github.com/twsouthwick","followers_url":"https://api.github.com/users/twsouthwick/followers","following_url":"https://api.github.com/users/twsouthwick/following{/other_user}","gists_url":"https://api.github.com/users/twsouthwick/gists{/gist_id}","starred_url":"https://api.github.com/users/twsouthwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twsouthwick/subscriptions","organizations_url":"https://api.github.com/users/twsouthwick/orgs","repos_url":"https://api.github.com/users/twsouthwick/repos","events_url":"https://api.github.com/users/twsouthwick/events{/privacy}","received_events_url":"https://api.github.com/users/twsouthwick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twsouthwick/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/twsouthwick/corefx","forks_url":"https://api.github.com/repos/twsouthwick/corefx/forks","keys_url":"https://api.github.com/repos/twsouthwick/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twsouthwick/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twsouthwick/corefx/teams","hooks_url":"https://api.github.com/repos/twsouthwick/corefx/hooks","issue_events_url":"https://api.github.com/repos/twsouthwick/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/twsouthwick/corefx/events","assignees_url":"https://api.github.com/repos/twsouthwick/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/twsouthwick/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/twsouthwick/corefx/tags","blobs_url":"https://api.github.com/repos/twsouthwick/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twsouthwick/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twsouthwick/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/twsouthwick/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twsouthwick/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/twsouthwick/corefx/languages","stargazers_url":"https://api.github.com/repos/twsouthwick/corefx/stargazers","contributors_url":"https://api.github.com/repos/twsouthwick/corefx/contributors","subscribers_url":"https://api.github.com/repos/twsouthwick/corefx/subscribers","subscription_url":"https://api.github.com/repos/twsouthwick/corefx/subscription","commits_url":"https://api.github.com/repos/twsouthwick/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/twsouthwick/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/twsouthwick/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/twsouthwick/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/twsouthwick/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/twsouthwick/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twsouthwick/corefx/merges","archive_url":"https://api.github.com/repos/twsouthwick/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twsouthwick/corefx/downloads","issues_url":"https://api.github.com/repos/twsouthwick/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/twsouthwick/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/twsouthwick/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/twsouthwick/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twsouthwick/corefx/labels{/name}","releases_url":"https://api.github.com/repos/twsouthwick/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/twsouthwick/corefx/deployments","created_at":"2015-04-21T23:46:13Z","updated_at":"2016-04-04T15:36:41Z","pushed_at":"2016-05-05T18:33:24Z","git_url":"git://github.com/twsouthwick/corefx.git","ssh_url":"git@github.com:twsouthwick/corefx.git","clone_url":"https://github.com/twsouthwick/corefx.git","svn_url":"https://github.com/twsouthwick/corefx","homepage":"","size":67255,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twsouthwick/corefx/pulls/1"},"html":{"href":"https://github.com/twsouthwick/corefx/pull/1"},"issue":{"href":"https://api.github.com/repos/twsouthwick/corefx/issues/1"},"comments":{"href":"https://api.github.com/repos/twsouthwick/corefx/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/twsouthwick/corefx/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/twsouthwick/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twsouthwick/corefx/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/twsouthwick/corefx/statuses/bf40bc944580107cfe81055a8f6e3710d9785bcf"}}}}