{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments/59846525","id":59846525,"diff_hunk":"@@ -59,16 +59,16 @@ def ask_brief_clarification_question(brief_id):\n \n @main.route('/opportunities/<int:brief_id>/responses/create', methods=['GET'])\n @login_required\n-def submit_brief_response(brief_id):\n+def brief_response(brief_id):","path":"app/main/views/briefs.py","position":14,"original_position":14,"commit_id":"7f9c837d6f7b2f4f2f11b2de5b65056035c491b6","original_commit_id":"7f9c837d6f7b2f4f2f11b2de5b65056035c491b6","user":{"login":"TheDoubleK","id":6525554,"avatar_url":"https://avatars.githubusercontent.com/u/6525554?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDoubleK","html_url":"https://github.com/TheDoubleK","followers_url":"https://api.github.com/users/TheDoubleK/followers","following_url":"https://api.github.com/users/TheDoubleK/following{/other_user}","gists_url":"https://api.github.com/users/TheDoubleK/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDoubleK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDoubleK/subscriptions","organizations_url":"https://api.github.com/users/TheDoubleK/orgs","repos_url":"https://api.github.com/users/TheDoubleK/repos","events_url":"https://api.github.com/users/TheDoubleK/events{/privacy}","received_events_url":"https://api.github.com/users/TheDoubleK/received_events","type":"User","site_admin":false},"body":"I started with `create_` but then checked our code elsewhere and our most usual pattern, e.g. in https://github.com/alphagov/digitalmarketplace-supplier-frontend/blob/master/app/main/views/suppliers.py, seems to be to have the `name_of_the_thing()` on the GET route and `submit_name_of_the_thing()` on the POST route everywhere:\r\n","created_at":"2016-04-15T09:07:13Z","updated_at":"2016-04-15T09:07:13Z","html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/449#discussion_r59846525","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments/59846525"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/449#discussion_r59846525"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449","id":66020662,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/449","diff_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/449.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/449.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/449","number":449,"state":"open","locked":false,"title":"Validate supplier responses","user":{"login":"TheDoubleK","id":6525554,"avatar_url":"https://avatars.githubusercontent.com/u/6525554?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDoubleK","html_url":"https://github.com/TheDoubleK","followers_url":"https://api.github.com/users/TheDoubleK/followers","following_url":"https://api.github.com/users/TheDoubleK/following{/other_user}","gists_url":"https://api.github.com/users/TheDoubleK/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDoubleK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDoubleK/subscriptions","organizations_url":"https://api.github.com/users/TheDoubleK/orgs","repos_url":"https://api.github.com/users/TheDoubleK/repos","events_url":"https://api.github.com/users/TheDoubleK/events{/privacy}","received_events_url":"https://api.github.com/users/TheDoubleK/received_events","type":"User","site_admin":false},"body":"Completes this story: https://www.pivotaltracker.com/story/show/112337127\r\nAnd addresses this bug: https://www.pivotaltracker.com/story/show/117143511\r\n\r\nContent updates and revisions needed and welcomed in comments\r\n\r\nFor the bug-fix: when suppliers try to create a second response to a brief instead of a 404 page they are now taken to their dashboard with the following flashed message:\r\n\r\n![screen shot 2016-04-11 at 17 06 37](https://cloud.githubusercontent.com/assets/6525554/14433881/10e6ae2e-0008-11e6-9972-5614d89fbf95.png)\r\n\r\nFor the story, if suppliers submit a response which does not have \"Yes\" to all the essential requirements they are taken to a response result page `/opportunities/<brief_id>/responses/result` that looks like this (more words to come in future):\r\n\r\n![screen shot 2016-04-11 at 17 05 45](https://cloud.githubusercontent.com/assets/6525554/14433942/46d081cc-0008-11e6-8c44-e66151d2ef1e.png)\r\n\r\nThe page has another two modes, neither of which are currently linked to, but which will make sense if users try to hack URLs:\r\n 1. If they haven't yet submitted a response to the brief:\r\n![screen shot 2016-04-11 at 17 05 24](https://cloud.githubusercontent.com/assets/6525554/14433982/843da288-0008-11e6-8e3f-d21ad7bde2a7.png)\r\n\r\n 2. If they already submitted a response with all \"Yes\" to essentials:\r\n![screen shot 2016-04-11 at 17 04 49](https://cloud.githubusercontent.com/assets/6525554/14433991/902769bc-0008-11e6-82e8-10e56bb072b2.png)\r\n","created_at":"2016-04-11T16:12:40Z","updated_at":"2016-04-15T09:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13de5dcd2345bd57912944c0de62d0b4c2ce9887","assignee":{"login":"allait","id":246664,"avatar_url":"https://avatars.githubusercontent.com/u/246664?v=3","gravatar_id":"","url":"https://api.github.com/users/allait","html_url":"https://github.com/allait","followers_url":"https://api.github.com/users/allait/followers","following_url":"https://api.github.com/users/allait/following{/other_user}","gists_url":"https://api.github.com/users/allait/gists{/gist_id}","starred_url":"https://api.github.com/users/allait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allait/subscriptions","organizations_url":"https://api.github.com/users/allait/orgs","repos_url":"https://api.github.com/users/allait/repos","events_url":"https://api.github.com/users/allait/events{/privacy}","received_events_url":"https://api.github.com/users/allait/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/449/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/7f9c837d6f7b2f4f2f11b2de5b65056035c491b6","head":{"label":"alphagov:validate-supplier-responses","ref":"validate-supplier-responses","sha":"7f9c837d6f7b2f4f2f11b2de5b65056035c491b6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31256533,"name":"digitalmarketplace-supplier-frontend","full_name":"alphagov/digitalmarketplace-supplier-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","description":"Frontend supplier application for the digital marketplace.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/deployments","created_at":"2015-02-24T11:10:47Z","updated_at":"2016-01-12T12:56:48Z","pushed_at":"2016-04-14T16:25:40Z","git_url":"git://github.com/alphagov/digitalmarketplace-supplier-frontend.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-supplier-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","homepage":null,"size":1876,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"3baf0d509a33be912374a66481f61a26ba13d196","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":31256533,"name":"digitalmarketplace-supplier-frontend","full_name":"alphagov/digitalmarketplace-supplier-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","description":"Frontend supplier application for the digital marketplace.","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/deployments","created_at":"2015-02-24T11:10:47Z","updated_at":"2016-01-12T12:56:48Z","pushed_at":"2016-04-14T16:25:40Z","git_url":"git://github.com/alphagov/digitalmarketplace-supplier-frontend.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-supplier-frontend.git","clone_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend.git","svn_url":"https://github.com/alphagov/digitalmarketplace-supplier-frontend","homepage":null,"size":1876,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-supplier-frontend/pull/449"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/449"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-supplier-frontend/statuses/7f9c837d6f7b2f4f2f11b2de5b65056035c491b6"}}}}