{"action":"closed","number":197,"pull_request":{"url":"https://api.github.com/repos/dtan4/terraforming/pulls/197","id":66731098,"html_url":"https://github.com/dtan4/terraforming/pull/197","diff_url":"https://github.com/dtan4/terraforming/pull/197.diff","patch_url":"https://github.com/dtan4/terraforming/pull/197.patch","issue_url":"https://api.github.com/repos/dtan4/terraforming/issues/197","number":197,"state":"closed","locked":false,"title":"[route53 records] Default weight should be \"-1\"","user":{"login":"woohgit","id":327714,"avatar_url":"https://avatars.githubusercontent.com/u/327714?v=3","gravatar_id":"","url":"https://api.github.com/users/woohgit","html_url":"https://github.com/woohgit","followers_url":"https://api.github.com/users/woohgit/followers","following_url":"https://api.github.com/users/woohgit/following{/other_user}","gists_url":"https://api.github.com/users/woohgit/gists{/gist_id}","starred_url":"https://api.github.com/users/woohgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woohgit/subscriptions","organizations_url":"https://api.github.com/users/woohgit/orgs","repos_url":"https://api.github.com/users/woohgit/repos","events_url":"https://api.github.com/users/woohgit/events{/privacy}","received_events_url":"https://api.github.com/users/woohgit/received_events","type":"User","site_admin":false},"body":"Otherwise terraform wants to change all weight \"\" => \"-1\" which is a noop, it just changes the terraform.tfstate actually.\r\n\r\nThe official documentation says\r\n\r\nhttps://www.terraform.io/docs/providers/aws/r/route53_record.html\r\n\r\n```\r\nNote: The weight attribute uses a special sentinel value of -1 for a default in\r\nTerraform. This allows Terraform to distinquish between a 0 value and an empty\r\nvalue in the configuration (none specified). As a result, a weight of -1 will\r\nbe present in the statefile if weight is omitted in the configuration.\r\n```","created_at":"2016-04-16T07:44:34Z","updated_at":"2016-04-18T01:40:22Z","closed_at":"2016-04-18T01:40:22Z","merged_at":"2016-04-18T01:40:22Z","merge_commit_sha":"bdbda01c45a39cc4fc8d9d9c1758aed1069ce8b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dtan4/terraforming/pulls/197/commits","review_comments_url":"https://api.github.com/repos/dtan4/terraforming/pulls/197/comments","review_comment_url":"https://api.github.com/repos/dtan4/terraforming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dtan4/terraforming/issues/197/comments","statuses_url":"https://api.github.com/repos/dtan4/terraforming/statuses/b59e9402ff8b001760d19b7c4a4c94edcfc25250","head":{"label":"woohgit:r53r_default_weight_fix","ref":"r53r_default_weight_fix","sha":"b59e9402ff8b001760d19b7c4a4c94edcfc25250","user":{"login":"woohgit","id":327714,"avatar_url":"https://avatars.githubusercontent.com/u/327714?v=3","gravatar_id":"","url":"https://api.github.com/users/woohgit","html_url":"https://github.com/woohgit","followers_url":"https://api.github.com/users/woohgit/followers","following_url":"https://api.github.com/users/woohgit/following{/other_user}","gists_url":"https://api.github.com/users/woohgit/gists{/gist_id}","starred_url":"https://api.github.com/users/woohgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woohgit/subscriptions","organizations_url":"https://api.github.com/users/woohgit/orgs","repos_url":"https://api.github.com/users/woohgit/repos","events_url":"https://api.github.com/users/woohgit/events{/privacy}","received_events_url":"https://api.github.com/users/woohgit/received_events","type":"User","site_admin":false},"repo":{"id":56370427,"name":"terraforming","full_name":"woohgit/terraforming","owner":{"login":"woohgit","id":327714,"avatar_url":"https://avatars.githubusercontent.com/u/327714?v=3","gravatar_id":"","url":"https://api.github.com/users/woohgit","html_url":"https://github.com/woohgit","followers_url":"https://api.github.com/users/woohgit/followers","following_url":"https://api.github.com/users/woohgit/following{/other_user}","gists_url":"https://api.github.com/users/woohgit/gists{/gist_id}","starred_url":"https://api.github.com/users/woohgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woohgit/subscriptions","organizations_url":"https://api.github.com/users/woohgit/orgs","repos_url":"https://api.github.com/users/woohgit/repos","events_url":"https://api.github.com/users/woohgit/events{/privacy}","received_events_url":"https://api.github.com/users/woohgit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woohgit/terraforming","description":"Export existing AWS resources to Terraform style (tf, tfstate)","fork":true,"url":"https://api.github.com/repos/woohgit/terraforming","forks_url":"https://api.github.com/repos/woohgit/terraforming/forks","keys_url":"https://api.github.com/repos/woohgit/terraforming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woohgit/terraforming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woohgit/terraforming/teams","hooks_url":"https://api.github.com/repos/woohgit/terraforming/hooks","issue_events_url":"https://api.github.com/repos/woohgit/terraforming/issues/events{/number}","events_url":"https://api.github.com/repos/woohgit/terraforming/events","assignees_url":"https://api.github.com/repos/woohgit/terraforming/assignees{/user}","branches_url":"https://api.github.com/repos/woohgit/terraforming/branches{/branch}","tags_url":"https://api.github.com/repos/woohgit/terraforming/tags","blobs_url":"https://api.github.com/repos/woohgit/terraforming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woohgit/terraforming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woohgit/terraforming/git/refs{/sha}","trees_url":"https://api.github.com/repos/woohgit/terraforming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woohgit/terraforming/statuses/{sha}","languages_url":"https://api.github.com/repos/woohgit/terraforming/languages","stargazers_url":"https://api.github.com/repos/woohgit/terraforming/stargazers","contributors_url":"https://api.github.com/repos/woohgit/terraforming/contributors","subscribers_url":"https://api.github.com/repos/woohgit/terraforming/subscribers","subscription_url":"https://api.github.com/repos/woohgit/terraforming/subscription","commits_url":"https://api.github.com/repos/woohgit/terraforming/commits{/sha}","git_commits_url":"https://api.github.com/repos/woohgit/terraforming/git/commits{/sha}","comments_url":"https://api.github.com/repos/woohgit/terraforming/comments{/number}","issue_comment_url":"https://api.github.com/repos/woohgit/terraforming/issues/comments{/number}","contents_url":"https://api.github.com/repos/woohgit/terraforming/contents/{+path}","compare_url":"https://api.github.com/repos/woohgit/terraforming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woohgit/terraforming/merges","archive_url":"https://api.github.com/repos/woohgit/terraforming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woohgit/terraforming/downloads","issues_url":"https://api.github.com/repos/woohgit/terraforming/issues{/number}","pulls_url":"https://api.github.com/repos/woohgit/terraforming/pulls{/number}","milestones_url":"https://api.github.com/repos/woohgit/terraforming/milestones{/number}","notifications_url":"https://api.github.com/repos/woohgit/terraforming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woohgit/terraforming/labels{/name}","releases_url":"https://api.github.com/repos/woohgit/terraforming/releases{/id}","deployments_url":"https://api.github.com/repos/woohgit/terraforming/deployments","created_at":"2016-04-16T07:03:07Z","updated_at":"2016-04-16T07:03:08Z","pushed_at":"2016-04-16T07:55:08Z","git_url":"git://github.com/woohgit/terraforming.git","ssh_url":"git@github.com:woohgit/terraforming.git","clone_url":"https://github.com/woohgit/terraforming.git","svn_url":"https://github.com/woohgit/terraforming","homepage":"http://terraforming.dtan4.net/","size":664,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dtan4:master","ref":"master","sha":"a957d01e44fdbcd6a338e8ebb0555770362ffc44","user":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"repo":{"id":32841259,"name":"terraforming","full_name":"dtan4/terraforming","owner":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtan4/terraforming","description":"Export existing AWS resources to Terraform style (tf, tfstate)","fork":false,"url":"https://api.github.com/repos/dtan4/terraforming","forks_url":"https://api.github.com/repos/dtan4/terraforming/forks","keys_url":"https://api.github.com/repos/dtan4/terraforming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtan4/terraforming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtan4/terraforming/teams","hooks_url":"https://api.github.com/repos/dtan4/terraforming/hooks","issue_events_url":"https://api.github.com/repos/dtan4/terraforming/issues/events{/number}","events_url":"https://api.github.com/repos/dtan4/terraforming/events","assignees_url":"https://api.github.com/repos/dtan4/terraforming/assignees{/user}","branches_url":"https://api.github.com/repos/dtan4/terraforming/branches{/branch}","tags_url":"https://api.github.com/repos/dtan4/terraforming/tags","blobs_url":"https://api.github.com/repos/dtan4/terraforming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtan4/terraforming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtan4/terraforming/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtan4/terraforming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtan4/terraforming/statuses/{sha}","languages_url":"https://api.github.com/repos/dtan4/terraforming/languages","stargazers_url":"https://api.github.com/repos/dtan4/terraforming/stargazers","contributors_url":"https://api.github.com/repos/dtan4/terraforming/contributors","subscribers_url":"https://api.github.com/repos/dtan4/terraforming/subscribers","subscription_url":"https://api.github.com/repos/dtan4/terraforming/subscription","commits_url":"https://api.github.com/repos/dtan4/terraforming/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtan4/terraforming/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtan4/terraforming/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtan4/terraforming/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtan4/terraforming/contents/{+path}","compare_url":"https://api.github.com/repos/dtan4/terraforming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtan4/terraforming/merges","archive_url":"https://api.github.com/repos/dtan4/terraforming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtan4/terraforming/downloads","issues_url":"https://api.github.com/repos/dtan4/terraforming/issues{/number}","pulls_url":"https://api.github.com/repos/dtan4/terraforming/pulls{/number}","milestones_url":"https://api.github.com/repos/dtan4/terraforming/milestones{/number}","notifications_url":"https://api.github.com/repos/dtan4/terraforming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtan4/terraforming/labels{/name}","releases_url":"https://api.github.com/repos/dtan4/terraforming/releases{/id}","deployments_url":"https://api.github.com/repos/dtan4/terraforming/deployments","created_at":"2015-03-25T03:50:06Z","updated_at":"2016-04-18T00:22:10Z","pushed_at":"2016-04-18T01:40:22Z","git_url":"git://github.com/dtan4/terraforming.git","ssh_url":"git@github.com:dtan4/terraforming.git","clone_url":"https://github.com/dtan4/terraforming.git","svn_url":"https://github.com/dtan4/terraforming","homepage":"http://terraforming.dtan4.net/","size":706,"stargazers_count":464,"watchers_count":464,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":74,"mirror_url":null,"open_issues_count":26,"forks":74,"open_issues":26,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/197"},"html":{"href":"https://github.com/dtan4/terraforming/pull/197"},"issue":{"href":"https://api.github.com/repos/dtan4/terraforming/issues/197"},"comments":{"href":"https://api.github.com/repos/dtan4/terraforming/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dtan4/terraforming/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/dtan4/terraforming/statuses/b59e9402ff8b001760d19b7c4a4c94edcfc25250"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dtan4","id":680124,"avatar_url":"https://avatars.githubusercontent.com/u/680124?v=3","gravatar_id":"","url":"https://api.github.com/users/dtan4","html_url":"https://github.com/dtan4","followers_url":"https://api.github.com/users/dtan4/followers","following_url":"https://api.github.com/users/dtan4/following{/other_user}","gists_url":"https://api.github.com/users/dtan4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtan4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtan4/subscriptions","organizations_url":"https://api.github.com/users/dtan4/orgs","repos_url":"https://api.github.com/users/dtan4/repos","events_url":"https://api.github.com/users/dtan4/events{/privacy}","received_events_url":"https://api.github.com/users/dtan4/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":3,"deletions":1,"changed_files":2}}