{"action":"created","issue":{"url":"https://api.github.com/repos/mxe/mxe/issues/1219","repository_url":"https://api.github.com/repos/mxe/mxe","labels_url":"https://api.github.com/repos/mxe/mxe/issues/1219/labels{/name}","comments_url":"https://api.github.com/repos/mxe/mxe/issues/1219/comments","events_url":"https://api.github.com/repos/mxe/mxe/issues/1219/events","html_url":"https://github.com/mxe/mxe/issues/1219","id":133720516,"number":1219,"title":"ffmpeg version ends up as MXE's HEAD hash","user":{"login":"avih","id":2164962,"avatar_url":"https://avatars.githubusercontent.com/u/2164962?v=3","gravatar_id":"","url":"https://api.github.com/users/avih","html_url":"https://github.com/avih","followers_url":"https://api.github.com/users/avih/followers","following_url":"https://api.github.com/users/avih/following{/other_user}","gists_url":"https://api.github.com/users/avih/gists{/gist_id}","starred_url":"https://api.github.com/users/avih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avih/subscriptions","organizations_url":"https://api.github.com/users/avih/orgs","repos_url":"https://api.github.com/users/avih/repos","events_url":"https://api.github.com/users/avih/events{/privacy}","received_events_url":"https://api.github.com/users/avih/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-15T14:04:49Z","updated_at":"2016-02-15T17:15:21Z","closed_at":null,"body":"Not sure if a bug, so for now let it just be a question.\r\n\r\nI patched `src/ffmpeg.mk` to use git-master instead of 2.8.4 like so:\r\n\r\n```shell\r\n$(PKG)_VERSION  := a655bc834479024ff4d60d0b8ecca290e73eb96c\r\n$(PKG)_CHECKSUM := 430eaca969898e2428a3901d5923abb1683ae200bf149e6ac24a4528b0c5fa27\r\n$(PKG)_SUBDIR   := FFmpeg-$($(PKG)_VERSION)\r\n$(PKG)_FILE     := FFmpeg-$($(PKG)_VERSION).tar.gz\r\n$(PKG)_URL      := https://github.com/FFmpeg/FFmpeg/archive/$($(PKG)_VERSION).tar.gz\r\n```\r\n\r\n(and also removed `libvo-aacenc` which was removed in ffmpeg 2.9), and it builds an works fine, but the revision which ffmpeg reports is of MXE HEAD hash (which is the commit which contains this change to `ffmpeg.mk`), instead of something which starts with `a655bc..` - which is the revision it downloads.\r\n\r\nAny idea what I might be doing wrong or how to make it use an ffmpeg version rather than an MXE version?\r\n\r\nFWIW, I checked how ffmpeg generates its version - it's in `version.sh` which checks git HEAD and then I _think_ writes it to `ffversion.h` at build time. And apparently this ends up finding the MXE HEAD hash.\r\n\r\nAlso, as far as I can tell, the downloaded archive does not contain the hash in any of its files. So I guess getting MXE's hash is better than nothing, but still, I think it would have been better, if possible, to use the version from `$(PKG)_VERSION`."},"comment":{"url":"https://api.github.com/repos/mxe/mxe/issues/comments/184308799","html_url":"https://github.com/mxe/mxe/issues/1219#issuecomment-184308799","issue_url":"https://api.github.com/repos/mxe/mxe/issues/1219","id":184308799,"user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars.githubusercontent.com/u/1538624?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"created_at":"2016-02-15T17:15:21Z","updated_at":"2016-02-15T17:15:21Z","body":"The reason why I didn't use this approach is because I wanted to be consistent with the official format, which is 2.8.6.git-1234567.\r\n\r\nWe use GMSL (GNU Make Standard Library), which has a substring function:\r\n\r\n```make\r\nREV = $(call substr,$($(PKG)_VERSION),1,7)\r\n```"}}