{"action":"opened","issue":{"url":"https://api.github.com/repos/pobri19/sqlboiler/issues/14","repository_url":"https://api.github.com/repos/pobri19/sqlboiler","labels_url":"https://api.github.com/repos/pobri19/sqlboiler/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/pobri19/sqlboiler/issues/14/comments","events_url":"https://api.github.com/repos/pobri19/sqlboiler/issues/14/events","html_url":"https://github.com/pobri19/sqlboiler/issues/14","id":152761707,"number":14,"title":"update","user":{"login":"pobri19","id":721274,"avatar_url":"https://avatars.githubusercontent.com/u/721274?v=3","gravatar_id":"","url":"https://api.github.com/users/pobri19","html_url":"https://github.com/pobri19","followers_url":"https://api.github.com/users/pobri19/followers","following_url":"https://api.github.com/users/pobri19/following{/other_user}","gists_url":"https://api.github.com/users/pobri19/gists{/gist_id}","starred_url":"https://api.github.com/users/pobri19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pobri19/subscriptions","organizations_url":"https://api.github.com/users/pobri19/orgs","repos_url":"https://api.github.com/users/pobri19/repos","events_url":"https://api.github.com/users/pobri19/events{/privacy}","received_events_url":"https://api.github.com/users/pobri19/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-03T12:28:48Z","updated_at":"2016-05-03T12:28:48Z","closed_at":null,"body":"(22:00:36) Patrick O'Brien: base case: table with autoincrement primary key column, random primary keys (non autoincrement), some default value cols, regular nullable cols\r\n\r\nUpdate called with no params should ignore the following in its SET clause:\r\n\r\nautoincrement cols of all types (primary key or otherwise)\r\nzero value cols (ONLY IF THEY HAVE DEFAULT VALUES), otherwise include zero value cols\r\n\r\n\r\n(22:02:01) Patrick O'Brien: sound about right to you? but then theres the thing of, how do we find the col in the db it wants to update, i.e. WHERE x=Y. ideally it would use the autoinc primary key col if thats set in the object, but maybe it isnt? i wonder if we need extra params at the start to specify the WHERE clause?\r\n(22:02:10) Patrick O'Brien: like, function sig params\r\n(22:02:11) Patrick O'Brien: like in the find\r\n(22:02:31) Patrick O'Brien: func {{$tableNameSingular}}Find({{primaryKeyFuncSig .Table.Columns .Table.PKey.Columns}}, selectCols ...string)\r\n(22:28:00) Patrick O'Brien: otherwise its kinda ambigious as to which field should be used to specify the where\r\n(22:28:03) Patrick O'Brien: if its a param, it makes it very clear\r\n(22:28:08) Patrick O'Brien: but it also makes it slightly more annoying to call\r\n(22:28:10) Patrick O'Brien: what do you think?"}}