{"action":"created","comment":{"url":"https://api.github.com/repos/translate/pootle/pulls/comments/58373818","id":58373818,"diff_hunk":"@@ -595,11 +600,21 @@ def invalidate_accessible_projects_cache(sender, instance, **kwargs):\n \n     # FIXME: use Redis directly to clear these caches effectively\n \n-    cache.delete_many([\n-        make_method_key('Project', 'cached_dict', {'is_admin': False}),\n-        make_method_key('Project', 'cached_dict', {'is_admin': True}),\n-    ])\n-\n     User = get_user_model()\n-    users_list = User.objects.values_list('username', flat=True)\n+    users_list = User.objects.filter(is_superuser=False) \\\n+                             .values_list('username', flat=True)\n+    cache.delete_many(","path":"pootle/apps/pootle_project/models.py","position":114,"original_position":114,"commit_id":"7c7530c90f8f38a0834ad2504bbaca35a2179895","original_commit_id":"7c7530c90f8f38a0834ad2504bbaca35a2179895","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"body":"Thanks @julen. Cool. I thought that it would use [KEYS](http://redis.io/commands/keys) (which can be inefficient), but it' will use [SCAN](http://redis.io/commands/scan).","created_at":"2016-04-04T13:21:25Z","updated_at":"2016-04-04T13:21:25Z","html_url":"https://github.com/translate/pootle/pull/4616#discussion_r58373818","pull_request_url":"https://api.github.com/repos/translate/pootle/pulls/4616","_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments/58373818"},"html":{"href":"https://github.com/translate/pootle/pull/4616#discussion_r58373818"},"pull_request":{"href":"https://api.github.com/repos/translate/pootle/pulls/4616"}}},"pull_request":{"url":"https://api.github.com/repos/translate/pootle/pulls/4616","id":64919009,"html_url":"https://github.com/translate/pootle/pull/4616","diff_url":"https://github.com/translate/pootle/pull/4616.diff","patch_url":"https://github.com/translate/pootle/pull/4616.patch","issue_url":"https://api.github.com/repos/translate/pootle/issues/4616","number":4616,"state":"open","locked":false,"title":"Always filter by accessible projects for user","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"body":"We had filter enabled projects for regular users and shown all projects for admin users. So we didn't handle permissions which didn't make sense. This PR will address all these concerns and check accessible projects for getting TP, Stores, Units in accessible projects only.\r\nThanks to @francescortiz who raised this question in #4596. ","created_at":"2016-04-01T09:39:33Z","updated_at":"2016-04-04T13:21:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"789fdec587713322c3f8ca6b4033969123a5d170","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/translate/pootle/pulls/4616/commits","review_comments_url":"https://api.github.com/repos/translate/pootle/pulls/4616/comments","review_comment_url":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/translate/pootle/issues/4616/comments","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/7c7530c90f8f38a0834ad2504bbaca35a2179895","head":{"label":"ta2-1:access_for_user","ref":"access_for_user","sha":"7c7530c90f8f38a0834ad2504bbaca35a2179895","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"repo":{"id":8358664,"name":"pootle","full_name":"ta2-1/pootle","owner":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ta2-1/pootle","description":"Online translation tool","fork":true,"url":"https://api.github.com/repos/ta2-1/pootle","forks_url":"https://api.github.com/repos/ta2-1/pootle/forks","keys_url":"https://api.github.com/repos/ta2-1/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ta2-1/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ta2-1/pootle/teams","hooks_url":"https://api.github.com/repos/ta2-1/pootle/hooks","issue_events_url":"https://api.github.com/repos/ta2-1/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/ta2-1/pootle/events","assignees_url":"https://api.github.com/repos/ta2-1/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/ta2-1/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/ta2-1/pootle/tags","blobs_url":"https://api.github.com/repos/ta2-1/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ta2-1/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ta2-1/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ta2-1/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ta2-1/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/ta2-1/pootle/languages","stargazers_url":"https://api.github.com/repos/ta2-1/pootle/stargazers","contributors_url":"https://api.github.com/repos/ta2-1/pootle/contributors","subscribers_url":"https://api.github.com/repos/ta2-1/pootle/subscribers","subscription_url":"https://api.github.com/repos/ta2-1/pootle/subscription","commits_url":"https://api.github.com/repos/ta2-1/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ta2-1/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ta2-1/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ta2-1/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ta2-1/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/ta2-1/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ta2-1/pootle/merges","archive_url":"https://api.github.com/repos/ta2-1/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ta2-1/pootle/downloads","issues_url":"https://api.github.com/repos/ta2-1/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/ta2-1/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/ta2-1/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/ta2-1/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ta2-1/pootle/labels{/name}","releases_url":"https://api.github.com/repos/ta2-1/pootle/releases{/id}","deployments_url":"https://api.github.com/repos/ta2-1/pootle/deployments","created_at":"2013-02-22T14:19:00Z","updated_at":"2015-02-04T13:34:18Z","pushed_at":"2016-04-04T12:11:56Z","git_url":"git://github.com/ta2-1/pootle.git","ssh_url":"git@github.com:ta2-1/pootle.git","clone_url":"https://github.com/ta2-1/pootle.git","svn_url":"https://github.com/ta2-1/pootle","homepage":"http://pootle.translatehouse.org","size":76956,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"translate:master","ref":"master","sha":"6b265e8b0564c18c1af429fac607ca297eafdc40","user":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"repo":{"id":3769702,"name":"pootle","full_name":"translate/pootle","owner":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/translate/pootle","description":"Online translation tool","fork":false,"url":"https://api.github.com/repos/translate/pootle","forks_url":"https://api.github.com/repos/translate/pootle/forks","keys_url":"https://api.github.com/repos/translate/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/translate/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/translate/pootle/teams","hooks_url":"https://api.github.com/repos/translate/pootle/hooks","issue_events_url":"https://api.github.com/repos/translate/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/translate/pootle/events","assignees_url":"https://api.github.com/repos/translate/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/translate/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/translate/pootle/tags","blobs_url":"https://api.github.com/repos/translate/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/translate/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/translate/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/translate/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/translate/pootle/languages","stargazers_url":"https://api.github.com/repos/translate/pootle/stargazers","contributors_url":"https://api.github.com/repos/translate/pootle/contributors","subscribers_url":"https://api.github.com/repos/translate/pootle/subscribers","subscription_url":"https://api.github.com/repos/translate/pootle/subscription","commits_url":"https://api.github.com/repos/translate/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/translate/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/translate/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/translate/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/translate/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/translate/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/translate/pootle/merges","archive_url":"https://api.github.com/repos/translate/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/translate/pootle/downloads","issues_url":"https://api.github.com/repos/translate/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/translate/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/translate/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/translate/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/translate/pootle/labels{/name}","releases_url":"https://api.github.com/repos/translate/pootle/releases{/id}","deployments_url":"https://api.github.com/repos/translate/pootle/deployments","created_at":"2012-03-19T23:06:03Z","updated_at":"2016-04-03T20:35:19Z","pushed_at":"2016-04-04T12:48:39Z","git_url":"git://github.com/translate/pootle.git","ssh_url":"git@github.com:translate/pootle.git","clone_url":"https://github.com/translate/pootle.git","svn_url":"https://github.com/translate/pootle","homepage":"http://pootle.translatehouse.org","size":87069,"stargazers_count":610,"watchers_count":610,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":179,"mirror_url":null,"open_issues_count":299,"forks":179,"open_issues":299,"watchers":610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/4616"},"html":{"href":"https://github.com/translate/pootle/pull/4616"},"issue":{"href":"https://api.github.com/repos/translate/pootle/issues/4616"},"comments":{"href":"https://api.github.com/repos/translate/pootle/issues/4616/comments"},"review_comments":{"href":"https://api.github.com/repos/translate/pootle/pulls/4616/comments"},"review_comment":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/translate/pootle/pulls/4616/commits"},"statuses":{"href":"https://api.github.com/repos/translate/pootle/statuses/7c7530c90f8f38a0834ad2504bbaca35a2179895"}}}}