{"action":"closed","number":289,"pull_request":{"url":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/289","id":97169808,"html_url":"https://github.com/recurly/recurly-client-ruby/pull/289","diff_url":"https://github.com/recurly/recurly-client-ruby/pull/289.diff","patch_url":"https://github.com/recurly/recurly-client-ruby/pull/289.patch","issue_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/289","number":289,"state":"closed","locked":false,"title":"Implement fields for Vertex integration","user":{"login":"bhelx","id":185919,"avatar_url":"https://avatars.githubusercontent.com/u/185919?v=3","gravatar_id":"","url":"https://api.github.com/users/bhelx","html_url":"https://github.com/bhelx","followers_url":"https://api.github.com/users/bhelx/followers","following_url":"https://api.github.com/users/bhelx/following{/other_user}","gists_url":"https://api.github.com/users/bhelx/gists{/gist_id}","starred_url":"https://api.github.com/users/bhelx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhelx/subscriptions","organizations_url":"https://api.github.com/users/bhelx/orgs","repos_url":"https://api.github.com/users/bhelx/repos","events_url":"https://api.github.com/users/bhelx/events{/privacy}","received_events_url":"https://api.github.com/users/bhelx/received_events","type":"User","site_admin":false},"body":"This will need a couple follow up PRs as I discovered some things.\r\n\r\n1. The parser tries to guess the type of a field by name. This can cause a conflict if a field with one name may have two different types. In this case there is `tax_type` which is a String on the invoice, and `tax_type` which is of the new type `TaxType`. We are going to need to fix this but I added a shortterm workaround for now. The `from_xml` method is way too hairy for me to tackle in this PR.\r\n2. Another issue is the parser assuming anything ending with \"_in_cents\" should be parsed as Money. I thought it respected the `type=integer` declaration but apparently it does not. It also defaults to the site default currency, which may be wrong in some cases. I need to address this in another PR and it will probably result in a breaking change. This can be written up in the 2.8.0 release notes.\r\n\r\nFurthermore, jruby with Nokogiri parser had to be ignored in the test. We will need a follow up to fix this problem.","created_at":"2016-12-08T17:53:48Z","updated_at":"2016-12-13T20:09:58Z","closed_at":"2016-12-13T20:09:58Z","merged_at":"2016-12-13T20:09:58Z","merge_commit_sha":"9ef182c2cf304f98f9253a95aba96023e3e3cb5c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/289/commits","review_comments_url":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/289/comments","review_comment_url":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/289/comments","statuses_url":"https://api.github.com/repos/recurly/recurly-client-ruby/statuses/fffeb3cfaaf268f98109f1d485c0bcf576c2f119","head":{"label":"recurly:implement_vertex_integration","ref":"implement_vertex_integration","sha":"fffeb3cfaaf268f98109f1d485c0bcf576c2f119","user":{"login":"recurly","id":144605,"avatar_url":"https://avatars.githubusercontent.com/u/144605?v=3","gravatar_id":"","url":"https://api.github.com/users/recurly","html_url":"https://github.com/recurly","followers_url":"https://api.github.com/users/recurly/followers","following_url":"https://api.github.com/users/recurly/following{/other_user}","gists_url":"https://api.github.com/users/recurly/gists{/gist_id}","starred_url":"https://api.github.com/users/recurly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recurly/subscriptions","organizations_url":"https://api.github.com/users/recurly/orgs","repos_url":"https://api.github.com/users/recurly/repos","events_url":"https://api.github.com/users/recurly/events{/privacy}","received_events_url":"https://api.github.com/users/recurly/received_events","type":"Organization","site_admin":false},"repo":{"id":381812,"name":"recurly-client-ruby","full_name":"recurly/recurly-client-ruby","owner":{"login":"recurly","id":144605,"avatar_url":"https://avatars.githubusercontent.com/u/144605?v=3","gravatar_id":"","url":"https://api.github.com/users/recurly","html_url":"https://github.com/recurly","followers_url":"https://api.github.com/users/recurly/followers","following_url":"https://api.github.com/users/recurly/following{/other_user}","gists_url":"https://api.github.com/users/recurly/gists{/gist_id}","starred_url":"https://api.github.com/users/recurly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recurly/subscriptions","organizations_url":"https://api.github.com/users/recurly/orgs","repos_url":"https://api.github.com/users/recurly/repos","events_url":"https://api.github.com/users/recurly/events{/privacy}","received_events_url":"https://api.github.com/users/recurly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/recurly/recurly-client-ruby","description":"A Ruby API wrapper for Recurly. Super Simple Subscription billing.","fork":false,"url":"https://api.github.com/repos/recurly/recurly-client-ruby","forks_url":"https://api.github.com/repos/recurly/recurly-client-ruby/forks","keys_url":"https://api.github.com/repos/recurly/recurly-client-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/recurly/recurly-client-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/recurly/recurly-client-ruby/teams","hooks_url":"https://api.github.com/repos/recurly/recurly-client-ruby/hooks","issue_events_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/recurly/recurly-client-ruby/events","assignees_url":"https://api.github.com/repos/recurly/recurly-client-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/recurly/recurly-client-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/recurly/recurly-client-ruby/tags","blobs_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/recurly/recurly-client-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/recurly/recurly-client-ruby/languages","stargazers_url":"https://api.github.com/repos/recurly/recurly-client-ruby/stargazers","contributors_url":"https://api.github.com/repos/recurly/recurly-client-ruby/contributors","subscribers_url":"https://api.github.com/repos/recurly/recurly-client-ruby/subscribers","subscription_url":"https://api.github.com/repos/recurly/recurly-client-ruby/subscription","commits_url":"https://api.github.com/repos/recurly/recurly-client-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/recurly/recurly-client-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/recurly/recurly-client-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/recurly/recurly-client-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/recurly/recurly-client-ruby/merges","archive_url":"https://api.github.com/repos/recurly/recurly-client-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/recurly/recurly-client-ruby/downloads","issues_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/recurly/recurly-client-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/recurly/recurly-client-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/recurly/recurly-client-ruby/labels{/name}","releases_url":"https://api.github.com/repos/recurly/recurly-client-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/recurly/recurly-client-ruby/deployments","created_at":"2009-11-22T19:32:14Z","updated_at":"2016-11-29T14:00:17Z","pushed_at":"2016-12-13T20:09:58Z","git_url":"git://github.com/recurly/recurly-client-ruby.git","ssh_url":"git@github.com:recurly/recurly-client-ruby.git","clone_url":"https://github.com/recurly/recurly-client-ruby.git","svn_url":"https://github.com/recurly/recurly-client-ruby","homepage":"http://recurly.com","size":953,"stargazers_count":136,"watchers_count":136,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":8,"forks":94,"open_issues":8,"watchers":136,"default_branch":"master"}},"base":{"label":"recurly:release_2_8_0","ref":"release_2_8_0","sha":"8ab76e42b5a1c8293971559abf12f1da06933dd1","user":{"login":"recurly","id":144605,"avatar_url":"https://avatars.githubusercontent.com/u/144605?v=3","gravatar_id":"","url":"https://api.github.com/users/recurly","html_url":"https://github.com/recurly","followers_url":"https://api.github.com/users/recurly/followers","following_url":"https://api.github.com/users/recurly/following{/other_user}","gists_url":"https://api.github.com/users/recurly/gists{/gist_id}","starred_url":"https://api.github.com/users/recurly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recurly/subscriptions","organizations_url":"https://api.github.com/users/recurly/orgs","repos_url":"https://api.github.com/users/recurly/repos","events_url":"https://api.github.com/users/recurly/events{/privacy}","received_events_url":"https://api.github.com/users/recurly/received_events","type":"Organization","site_admin":false},"repo":{"id":381812,"name":"recurly-client-ruby","full_name":"recurly/recurly-client-ruby","owner":{"login":"recurly","id":144605,"avatar_url":"https://avatars.githubusercontent.com/u/144605?v=3","gravatar_id":"","url":"https://api.github.com/users/recurly","html_url":"https://github.com/recurly","followers_url":"https://api.github.com/users/recurly/followers","following_url":"https://api.github.com/users/recurly/following{/other_user}","gists_url":"https://api.github.com/users/recurly/gists{/gist_id}","starred_url":"https://api.github.com/users/recurly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recurly/subscriptions","organizations_url":"https://api.github.com/users/recurly/orgs","repos_url":"https://api.github.com/users/recurly/repos","events_url":"https://api.github.com/users/recurly/events{/privacy}","received_events_url":"https://api.github.com/users/recurly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/recurly/recurly-client-ruby","description":"A Ruby API wrapper for Recurly. Super Simple Subscription billing.","fork":false,"url":"https://api.github.com/repos/recurly/recurly-client-ruby","forks_url":"https://api.github.com/repos/recurly/recurly-client-ruby/forks","keys_url":"https://api.github.com/repos/recurly/recurly-client-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/recurly/recurly-client-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/recurly/recurly-client-ruby/teams","hooks_url":"https://api.github.com/repos/recurly/recurly-client-ruby/hooks","issue_events_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/recurly/recurly-client-ruby/events","assignees_url":"https://api.github.com/repos/recurly/recurly-client-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/recurly/recurly-client-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/recurly/recurly-client-ruby/tags","blobs_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/recurly/recurly-client-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/recurly/recurly-client-ruby/languages","stargazers_url":"https://api.github.com/repos/recurly/recurly-client-ruby/stargazers","contributors_url":"https://api.github.com/repos/recurly/recurly-client-ruby/contributors","subscribers_url":"https://api.github.com/repos/recurly/recurly-client-ruby/subscribers","subscription_url":"https://api.github.com/repos/recurly/recurly-client-ruby/subscription","commits_url":"https://api.github.com/repos/recurly/recurly-client-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/recurly/recurly-client-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/recurly/recurly-client-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/recurly/recurly-client-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/recurly/recurly-client-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/recurly/recurly-client-ruby/merges","archive_url":"https://api.github.com/repos/recurly/recurly-client-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/recurly/recurly-client-ruby/downloads","issues_url":"https://api.github.com/repos/recurly/recurly-client-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/recurly/recurly-client-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/recurly/recurly-client-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/recurly/recurly-client-ruby/labels{/name}","releases_url":"https://api.github.com/repos/recurly/recurly-client-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/recurly/recurly-client-ruby/deployments","created_at":"2009-11-22T19:32:14Z","updated_at":"2016-11-29T14:00:17Z","pushed_at":"2016-12-13T20:09:58Z","git_url":"git://github.com/recurly/recurly-client-ruby.git","ssh_url":"git@github.com:recurly/recurly-client-ruby.git","clone_url":"https://github.com/recurly/recurly-client-ruby.git","svn_url":"https://github.com/recurly/recurly-client-ruby","homepage":"http://recurly.com","size":953,"stargazers_count":136,"watchers_count":136,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":8,"forks":94,"open_issues":8,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/289"},"html":{"href":"https://github.com/recurly/recurly-client-ruby/pull/289"},"issue":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/289"},"comments":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/recurly/recurly-client-ruby/statuses/fffeb3cfaaf268f98109f1d485c0bcf576c2f119"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lmnleaf","id":8958150,"avatar_url":"https://avatars.githubusercontent.com/u/8958150?v=3","gravatar_id":"","url":"https://api.github.com/users/lmnleaf","html_url":"https://github.com/lmnleaf","followers_url":"https://api.github.com/users/lmnleaf/followers","following_url":"https://api.github.com/users/lmnleaf/following{/other_user}","gists_url":"https://api.github.com/users/lmnleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/lmnleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmnleaf/subscriptions","organizations_url":"https://api.github.com/users/lmnleaf/orgs","repos_url":"https://api.github.com/users/lmnleaf/repos","events_url":"https://api.github.com/users/lmnleaf/events{/privacy}","received_events_url":"https://api.github.com/users/lmnleaf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":149,"deletions":14,"changed_files":11}}
{"actor":{"display_login":"lmnleaf"}}