{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/56282809","id":56282809,"diff_hunk":"@@ -195,6 +198,16 @@ var WebView = React.createClass({\n       console.warn('WebView: `source.body` is not supported when using GET.');\n     }\n \n+    var onShouldOverrideUrlLoading = this.props.shouldOverrideUrlLoading && ((event: Event) => {\n+      var shouldOverride = this.props.shouldOverrideUrlLoading &&\n+          this.props.shouldOverrideUrlLoading(event.nativeEvent);\n+      UIManager.dispatchViewManagerCommandSync(\n+        this.getWebViewHandle(),\n+        UIManager.RCTWebView.Commands.shouldOverrideWithResult,\n+        [shouldOverride]","path":"Libraries/Components/WebView/WebView.android.js","position":27,"original_position":27,"commit_id":"d9e336ba3b75289687aacaeabaf5d6859c03672d","original_commit_id":"d9e336ba3b75289687aacaeabaf5d6859c03672d","user":{"login":"eslint-bot","id":16061708,"avatar_url":"https://avatars.githubusercontent.com/u/16061708?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint-bot","html_url":"https://github.com/eslint-bot","followers_url":"https://api.github.com/users/eslint-bot/followers","following_url":"https://api.github.com/users/eslint-bot/following{/other_user}","gists_url":"https://api.github.com/users/eslint-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint-bot/subscriptions","organizations_url":"https://api.github.com/users/eslint-bot/orgs","repos_url":"https://api.github.com/users/eslint-bot/repos","events_url":"https://api.github.com/users/eslint-bot/events{/privacy}","received_events_url":"https://api.github.com/users/eslint-bot/received_events","type":"User","site_admin":false},"body":"no-extra-bind: The function binding is unnecessary.","created_at":"2016-03-16T05:11:57Z","updated_at":"2016-03-16T05:11:57Z","html_url":"https://github.com/facebook/react-native/pull/6478#discussion_r56282809","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/6478","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/56282809"},"html":{"href":"https://github.com/facebook/react-native/pull/6478#discussion_r56282809"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6478"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/6478","id":63008498,"html_url":"https://github.com/facebook/react-native/pull/6478","diff_url":"https://github.com/facebook/react-native/pull/6478.diff","patch_url":"https://github.com/facebook/react-native/pull/6478.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/6478","number":6478,"state":"open","locked":false,"title":"[Android][WebView] shouldOverrideUrlLoading callback","user":{"login":"pglotov","id":1294313,"avatar_url":"https://avatars.githubusercontent.com/u/1294313?v=3","gravatar_id":"","url":"https://api.github.com/users/pglotov","html_url":"https://github.com/pglotov","followers_url":"https://api.github.com/users/pglotov/followers","following_url":"https://api.github.com/users/pglotov/following{/other_user}","gists_url":"https://api.github.com/users/pglotov/gists{/gist_id}","starred_url":"https://api.github.com/users/pglotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pglotov/subscriptions","organizations_url":"https://api.github.com/users/pglotov/orgs","repos_url":"https://api.github.com/users/pglotov/repos","events_url":"https://api.github.com/users/pglotov/events{/privacy}","received_events_url":"https://api.github.com/users/pglotov/received_events","type":"User","site_admin":false},"body":"This PR implements `shouldOverrideUrlLoading` callback for WebView on Android.","created_at":"2016-03-16T03:11:43Z","updated_at":"2016-03-16T05:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f96200ce0147d3ff2beb20279b39e524068b2c6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/6478/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/6478/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/6478/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/d9e336ba3b75289687aacaeabaf5d6859c03672d","head":{"label":"pglotov:android-shouldOverrideUrlLoading","ref":"android-shouldOverrideUrlLoading","sha":"d9e336ba3b75289687aacaeabaf5d6859c03672d","user":{"login":"pglotov","id":1294313,"avatar_url":"https://avatars.githubusercontent.com/u/1294313?v=3","gravatar_id":"","url":"https://api.github.com/users/pglotov","html_url":"https://github.com/pglotov","followers_url":"https://api.github.com/users/pglotov/followers","following_url":"https://api.github.com/users/pglotov/following{/other_user}","gists_url":"https://api.github.com/users/pglotov/gists{/gist_id}","starred_url":"https://api.github.com/users/pglotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pglotov/subscriptions","organizations_url":"https://api.github.com/users/pglotov/orgs","repos_url":"https://api.github.com/users/pglotov/repos","events_url":"https://api.github.com/users/pglotov/events{/privacy}","received_events_url":"https://api.github.com/users/pglotov/received_events","type":"User","site_admin":false},"repo":{"id":50945865,"name":"react-native","full_name":"pglotov/react-native","owner":{"login":"pglotov","id":1294313,"avatar_url":"https://avatars.githubusercontent.com/u/1294313?v=3","gravatar_id":"","url":"https://api.github.com/users/pglotov","html_url":"https://github.com/pglotov","followers_url":"https://api.github.com/users/pglotov/followers","following_url":"https://api.github.com/users/pglotov/following{/other_user}","gists_url":"https://api.github.com/users/pglotov/gists{/gist_id}","starred_url":"https://api.github.com/users/pglotov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pglotov/subscriptions","organizations_url":"https://api.github.com/users/pglotov/orgs","repos_url":"https://api.github.com/users/pglotov/repos","events_url":"https://api.github.com/users/pglotov/events{/privacy}","received_events_url":"https://api.github.com/users/pglotov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pglotov/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/pglotov/react-native","forks_url":"https://api.github.com/repos/pglotov/react-native/forks","keys_url":"https://api.github.com/repos/pglotov/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pglotov/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pglotov/react-native/teams","hooks_url":"https://api.github.com/repos/pglotov/react-native/hooks","issue_events_url":"https://api.github.com/repos/pglotov/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/pglotov/react-native/events","assignees_url":"https://api.github.com/repos/pglotov/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/pglotov/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/pglotov/react-native/tags","blobs_url":"https://api.github.com/repos/pglotov/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pglotov/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pglotov/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/pglotov/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pglotov/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/pglotov/react-native/languages","stargazers_url":"https://api.github.com/repos/pglotov/react-native/stargazers","contributors_url":"https://api.github.com/repos/pglotov/react-native/contributors","subscribers_url":"https://api.github.com/repos/pglotov/react-native/subscribers","subscription_url":"https://api.github.com/repos/pglotov/react-native/subscription","commits_url":"https://api.github.com/repos/pglotov/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/pglotov/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/pglotov/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/pglotov/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/pglotov/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/pglotov/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pglotov/react-native/merges","archive_url":"https://api.github.com/repos/pglotov/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pglotov/react-native/downloads","issues_url":"https://api.github.com/repos/pglotov/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/pglotov/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/pglotov/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/pglotov/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pglotov/react-native/labels{/name}","releases_url":"https://api.github.com/repos/pglotov/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/pglotov/react-native/deployments","created_at":"2016-02-02T19:26:11Z","updated_at":"2016-03-15T04:56:13Z","pushed_at":"2016-03-16T03:15:38Z","git_url":"git://github.com/pglotov/react-native.git","ssh_url":"git@github.com:pglotov/react-native.git","clone_url":"https://github.com/pglotov/react-native.git","svn_url":"https://github.com/pglotov/react-native","homepage":"http://facebook.github.io/react-native/","size":43665,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a97127b7bb2b0bc78387ceea1c6b9d3221ee937f","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-03-16T04:59:38Z","pushed_at":"2016-03-16T03:59:23Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":83200,"stargazers_count":28738,"watchers_count":28738,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5458,"mirror_url":null,"open_issues_count":1144,"forks":5458,"open_issues":1144,"watchers":28738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6478"},"html":{"href":"https://github.com/facebook/react-native/pull/6478"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/6478"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/6478/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6478/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/6478/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/d9e336ba3b75289687aacaeabaf5d6859c03672d"}}}}