{"action":"created","comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/61671337","id":61671337,"diff_hunk":"@@ -124,7 +235,13 @@ static u32 WRITERING_DMA(u32 *pMem, u32 qwc) {\n \t\telse\n \t\t\tqwc = std::min(qwc, 8u);\n \t}\n-\tuint size = gifUnit.TransferGSPacketData(GIF_TRANS_DMA, (u8*)pMem, qwc*16) / 16;\n+\tuint size;\n+\tif (CHECK_GIFFIFOHACK) {\n+\t\tsize = gif_fifo.write(pMem, qwc);\n+\t}\n+\telse {\n+\t\tsize = gifUnit.TransferGSPacketData(GIF_TRANS_DMA, (u8*)pMem, qwc * 16) / 16;\n+\t}","path":"pcsx2/Gif.cpp","position":194,"original_position":194,"commit_id":"4ad4b7ad833c1b70f61e76e01fcb3ab31b0e3432","original_commit_id":"d62e6f5947b2edc3ca8a00599efc3324f7957de4","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"body":"I think it'd be much cleaner/simpler to just initialize ``size``  using a ternary operator based on the status of ``CHECK_GIFFIFOHACK``","created_at":"2016-04-30T15:57:00Z","updated_at":"2016-04-30T15:57:00Z","html_url":"https://github.com/PCSX2/pcsx2/pull/1331#discussion_r61671337","pull_request_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331","_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/61671337"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1331#discussion_r61671337"},"pull_request":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331"}}},"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331","id":68470762,"html_url":"https://github.com/PCSX2/pcsx2/pull/1331","diff_url":"https://github.com/PCSX2/pcsx2/pull/1331.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1331.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1331","number":1331,"state":"open","locked":false,"title":"PCSX2: Implement GIF FIFO","user":{"login":"refractionpcsx2","id":6278726,"avatar_url":"https://avatars.githubusercontent.com/u/6278726?v=3","gravatar_id":"","url":"https://api.github.com/users/refractionpcsx2","html_url":"https://github.com/refractionpcsx2","followers_url":"https://api.github.com/users/refractionpcsx2/followers","following_url":"https://api.github.com/users/refractionpcsx2/following{/other_user}","gists_url":"https://api.github.com/users/refractionpcsx2/gists{/gist_id}","starred_url":"https://api.github.com/users/refractionpcsx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refractionpcsx2/subscriptions","organizations_url":"https://api.github.com/users/refractionpcsx2/orgs","repos_url":"https://api.github.com/users/refractionpcsx2/repos","events_url":"https://api.github.com/users/refractionpcsx2/events{/privacy}","received_events_url":"https://api.github.com/users/refractionpcsx2/received_events","type":"User","site_admin":false},"body":"Spent the last couple of days playing with this to see if I could get it to work. so far it seems to be working.\r\n\r\nWhat this PR brings:\r\n- Fixes DJ Hero (so it now boots and with right colours)\r\n- Removes an always on hack for Wallace & Gromit which could have interfered with other games\r\n- Removes a hack from the Gamefixes section for Hot Wheels World Race, this is no longer required\r\n- Added the appropriate entries in the GameDB for the games mentined.\r\n- Savestate version bump - Your old savestates will not work from here on. Sorry, not sorry :P \r\n\r\nThis FIFO is not always on, it is enabled in the Gamefixes tab as people will moan about the speed loss (anywhere from 5-10fps) so it can be used for certain games which refuse to boot, there might be others out there which need this and that's why they don't boot, but I can't remember what games don't boot :P If you find one that still doesn't boot with it on, please don't report it, that was just a passing thought.\r\n\r\nWhat needs testing? Well, everything you can, with the option on and off to make sure compatibility hasn't been compromised.","created_at":"2016-04-30T15:35:05Z","updated_at":"2016-04-30T15:57:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15a8cf2da223b0daf4ac2bf74178acc7ef35b3b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1331/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/4ad4b7ad833c1b70f61e76e01fcb3ab31b0e3432","head":{"label":"PCSX2:pcsx2-gif-fifo","ref":"pcsx2-gif-fifo","sha":"4ad4b7ad833c1b70f61e76e01fcb3ab31b0e3432","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2/pcsx2/deployments","created_at":"2013-12-22T17:56:48Z","updated_at":"2016-04-30T03:44:35Z","pushed_at":"2016-04-30T15:35:05Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":92135,"stargazers_count":1213,"watchers_count":1213,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":256,"forks":289,"open_issues":256,"watchers":1213,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"2160d7da81cd163f12bc97d538a919f2c1cad679","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2/pcsx2/deployments","created_at":"2013-12-22T17:56:48Z","updated_at":"2016-04-30T03:44:35Z","pushed_at":"2016-04-30T15:35:05Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":92135,"stargazers_count":1213,"watchers_count":1213,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":256,"forks":289,"open_issues":256,"watchers":1213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1331"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1331"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1331/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1331/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/4ad4b7ad833c1b70f61e76e01fcb3ab31b0e3432"}}}}