{"action":"created","comment":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments/77522394","id":77522394,"diff_hunk":"@@ -20,10 +20,28 @@ enum ElektraCryptoHeaderFlags\n \tELEKTRA_CRYPTO_FLAG_NULL = 2\n };\n \n-#define ELEKTRA_CRYPTO_PARAM_KEY_PATH (\"/crypto/key\")\n-#define ELEKTRA_CRYPTO_PARAM_IV_PATH (\"/crypto/iv\")\n-#define ELEKTRA_CRYPTO_PARAM_SHUTDOWN (\"/shutdown\")\n-#define ELEKTRA_CRYPTO_META_ENCRYPT (\"crypto/encrypt\")\n+enum ElektraCryptoOperation\n+{\n+\tELEKTRA_CRYPTO_ENCRYPT = 0,\n+\tELEKTRA_CRYPTO_DECRYPT = 1\n+};\n+\n+// plugin defaults\n+#define ELEKTRA_CRYPTO_DEFAULT_MASTER_PWD_LENGTH (30)\n+#define ELEKTRA_CRYPTO_DEFAULT_ITERATION_COUNT (15000)\n+#define ELEKTRA_CRYPTO_DEFAULT_SALT_LEN (17)\n+\n+// plugin configuration parameters\n+#define ELEKTRA_CRYPTO_PARAM_MASTER_PWD_LEN \"/crypto/masterpasswordlength\"\n+#define ELEKTRA_CRYPTO_PARAM_MASTER_PWD \"/crypto/masterpassword\"\n+#define ELEKTRA_CRYPTO_PARAM_KEY_PATH \"/crypto/key\"\n+#define ELEKTRA_CRYPTO_PARAM_IV_PATH \"/crypto/iv\"\n+#define ELEKTRA_CRYPTO_PARAM_SHUTDOWN \"/shutdown\"\n+#define ELEKTRA_CRYPTO_PARAM_ITERATION_COUNT \"/crypto/iterations\"","path":"src/plugins/crypto/crypto.h","position":25,"original_position":25,"commit_id":"2e0b9d518a22a65ef3713db67d9f2eeac1580a4c","original_commit_id":"2e0b9d518a22a65ef3713db67d9f2eeac1580a4c","user":{"login":"markus2330","id":7949075,"avatar_url":"https://avatars.githubusercontent.com/u/7949075?v=3","gravatar_id":"","url":"https://api.github.com/users/markus2330","html_url":"https://github.com/markus2330","followers_url":"https://api.github.com/users/markus2330/followers","following_url":"https://api.github.com/users/markus2330/following{/other_user}","gists_url":"https://api.github.com/users/markus2330/gists{/gist_id}","starred_url":"https://api.github.com/users/markus2330/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markus2330/subscriptions","organizations_url":"https://api.github.com/users/markus2330/orgs","repos_url":"https://api.github.com/users/markus2330/repos","events_url":"https://api.github.com/users/markus2330/events{/privacy}","received_events_url":"https://api.github.com/users/markus2330/received_events","type":"User","site_admin":false},"body":"They should be validated in checkconf.","created_at":"2016-09-05T13:31:37Z","updated_at":"2016-09-05T13:31:37Z","html_url":"https://github.com/ElektraInitiative/libelektra/pull/892#discussion_r77522394","pull_request_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892","_links":{"self":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments/77522394"},"html":{"href":"https://github.com/ElektraInitiative/libelektra/pull/892#discussion_r77522394"},"pull_request":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892"}}},"pull_request":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892","id":83009346,"html_url":"https://github.com/ElektraInitiative/libelektra/pull/892","diff_url":"https://github.com/ElektraInitiative/libelektra/pull/892.diff","patch_url":"https://github.com/ElektraInitiative/libelektra/pull/892.patch","issue_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/892","number":892,"state":"open","locked":false,"title":"Add GPG-Interface","user":{"login":"petermax2","id":2538677,"avatar_url":"https://avatars.githubusercontent.com/u/2538677?v=3","gravatar_id":"","url":"https://api.github.com/users/petermax2","html_url":"https://github.com/petermax2","followers_url":"https://api.github.com/users/petermax2/followers","following_url":"https://api.github.com/users/petermax2/following{/other_user}","gists_url":"https://api.github.com/users/petermax2/gists{/gist_id}","starred_url":"https://api.github.com/users/petermax2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermax2/subscriptions","organizations_url":"https://api.github.com/users/petermax2/orgs","repos_url":"https://api.github.com/users/petermax2/repos","events_url":"https://api.github.com/users/petermax2/events{/privacy}","received_events_url":"https://api.github.com/users/petermax2/received_events","type":"User","site_admin":false},"body":"# Purpose\r\n\r\nImplement GPG interface as described in #475 .\r\n\r\nReplaces PR #889 (which has a messed up history because of faulty git rebase).\r\n\r\nCloses #475 .\r\n\r\n# Checklist\r\n\r\nPlease only check relevant points.\r\nFor docu fixes, spell checking and similar nothing\r\nneeds to be checked.\r\n\r\n- [x] commit messages are fine (with references to issues)\r\n- [x] I ran all tests and everything went fine\r\n- [x] I added unit tests\r\n- [x] affected documentation is fixed\r\n- [x] I added code comments, logging, and assertions\r\n- [x] meta data is updated (e.g. README.md of plugins)\r\n\r\n# TODO\r\n\r\n- [x] Fix unit tests\r\n- [x] lookup gpg binary in PATH\r\n- [x] FIX segfault in gcrypt and OpenSSL variant\r\n- [x] resolve merge conflict\r\n- [x] fix messed up git history\r\n- [ ] remove salt from meta-data\r\n- [ ] encode salt into crypto payload\r\n- [x] exclude `/spec` from encryption and decryption\r\n\r\n@markus2330 please review my pull request\r\n","created_at":"2016-08-28T08:05:54Z","updated_at":"2016-09-05T13:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f48fff358a955fc96d356190fd04dc907bd338a","assignee":{"login":"markus2330","id":7949075,"avatar_url":"https://avatars.githubusercontent.com/u/7949075?v=3","gravatar_id":"","url":"https://api.github.com/users/markus2330","html_url":"https://github.com/markus2330","followers_url":"https://api.github.com/users/markus2330/followers","following_url":"https://api.github.com/users/markus2330/following{/other_user}","gists_url":"https://api.github.com/users/markus2330/gists{/gist_id}","starred_url":"https://api.github.com/users/markus2330/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markus2330/subscriptions","organizations_url":"https://api.github.com/users/markus2330/orgs","repos_url":"https://api.github.com/users/markus2330/repos","events_url":"https://api.github.com/users/markus2330/events{/privacy}","received_events_url":"https://api.github.com/users/markus2330/received_events","type":"User","site_admin":false},"assignees":[{"login":"markus2330","id":7949075,"avatar_url":"https://avatars.githubusercontent.com/u/7949075?v=3","gravatar_id":"","url":"https://api.github.com/users/markus2330","html_url":"https://github.com/markus2330","followers_url":"https://api.github.com/users/markus2330/followers","following_url":"https://api.github.com/users/markus2330/following{/other_user}","gists_url":"https://api.github.com/users/markus2330/gists{/gist_id}","starred_url":"https://api.github.com/users/markus2330/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markus2330/subscriptions","organizations_url":"https://api.github.com/users/markus2330/orgs","repos_url":"https://api.github.com/users/markus2330/repos","events_url":"https://api.github.com/users/markus2330/events{/privacy}","received_events_url":"https://api.github.com/users/markus2330/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892/commits","review_comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892/comments","review_comment_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/892/comments","statuses_url":"https://api.github.com/repos/ElektraInitiative/libelektra/statuses/2e0b9d518a22a65ef3713db67d9f2eeac1580a4c","head":{"label":"petermax2:gpg-PR","ref":"gpg-PR","sha":"2e0b9d518a22a65ef3713db67d9f2eeac1580a4c","user":{"login":"petermax2","id":2538677,"avatar_url":"https://avatars.githubusercontent.com/u/2538677?v=3","gravatar_id":"","url":"https://api.github.com/users/petermax2","html_url":"https://github.com/petermax2","followers_url":"https://api.github.com/users/petermax2/followers","following_url":"https://api.github.com/users/petermax2/following{/other_user}","gists_url":"https://api.github.com/users/petermax2/gists{/gist_id}","starred_url":"https://api.github.com/users/petermax2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermax2/subscriptions","organizations_url":"https://api.github.com/users/petermax2/orgs","repos_url":"https://api.github.com/users/petermax2/repos","events_url":"https://api.github.com/users/petermax2/events{/privacy}","received_events_url":"https://api.github.com/users/petermax2/received_events","type":"User","site_admin":false},"repo":{"id":30610180,"name":"libelektra","full_name":"petermax2/libelektra","owner":{"login":"petermax2","id":2538677,"avatar_url":"https://avatars.githubusercontent.com/u/2538677?v=3","gravatar_id":"","url":"https://api.github.com/users/petermax2","html_url":"https://github.com/petermax2","followers_url":"https://api.github.com/users/petermax2/followers","following_url":"https://api.github.com/users/petermax2/following{/other_user}","gists_url":"https://api.github.com/users/petermax2/gists{/gist_id}","starred_url":"https://api.github.com/users/petermax2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermax2/subscriptions","organizations_url":"https://api.github.com/users/petermax2/orgs","repos_url":"https://api.github.com/users/petermax2/repos","events_url":"https://api.github.com/users/petermax2/events{/privacy}","received_events_url":"https://api.github.com/users/petermax2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petermax2/libelektra","description":"Elektra provides a universal and secure framework to store configuration parameters in a global, hierarchical key database.","fork":true,"url":"https://api.github.com/repos/petermax2/libelektra","forks_url":"https://api.github.com/repos/petermax2/libelektra/forks","keys_url":"https://api.github.com/repos/petermax2/libelektra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petermax2/libelektra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petermax2/libelektra/teams","hooks_url":"https://api.github.com/repos/petermax2/libelektra/hooks","issue_events_url":"https://api.github.com/repos/petermax2/libelektra/issues/events{/number}","events_url":"https://api.github.com/repos/petermax2/libelektra/events","assignees_url":"https://api.github.com/repos/petermax2/libelektra/assignees{/user}","branches_url":"https://api.github.com/repos/petermax2/libelektra/branches{/branch}","tags_url":"https://api.github.com/repos/petermax2/libelektra/tags","blobs_url":"https://api.github.com/repos/petermax2/libelektra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petermax2/libelektra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petermax2/libelektra/git/refs{/sha}","trees_url":"https://api.github.com/repos/petermax2/libelektra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petermax2/libelektra/statuses/{sha}","languages_url":"https://api.github.com/repos/petermax2/libelektra/languages","stargazers_url":"https://api.github.com/repos/petermax2/libelektra/stargazers","contributors_url":"https://api.github.com/repos/petermax2/libelektra/contributors","subscribers_url":"https://api.github.com/repos/petermax2/libelektra/subscribers","subscription_url":"https://api.github.com/repos/petermax2/libelektra/subscription","commits_url":"https://api.github.com/repos/petermax2/libelektra/commits{/sha}","git_commits_url":"https://api.github.com/repos/petermax2/libelektra/git/commits{/sha}","comments_url":"https://api.github.com/repos/petermax2/libelektra/comments{/number}","issue_comment_url":"https://api.github.com/repos/petermax2/libelektra/issues/comments{/number}","contents_url":"https://api.github.com/repos/petermax2/libelektra/contents/{+path}","compare_url":"https://api.github.com/repos/petermax2/libelektra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petermax2/libelektra/merges","archive_url":"https://api.github.com/repos/petermax2/libelektra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petermax2/libelektra/downloads","issues_url":"https://api.github.com/repos/petermax2/libelektra/issues{/number}","pulls_url":"https://api.github.com/repos/petermax2/libelektra/pulls{/number}","milestones_url":"https://api.github.com/repos/petermax2/libelektra/milestones{/number}","notifications_url":"https://api.github.com/repos/petermax2/libelektra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petermax2/libelektra/labels{/name}","releases_url":"https://api.github.com/repos/petermax2/libelektra/releases{/id}","deployments_url":"https://api.github.com/repos/petermax2/libelektra/deployments","created_at":"2015-02-10T19:27:08Z","updated_at":"2016-03-17T18:11:49Z","pushed_at":"2016-09-03T20:27:52Z","git_url":"git://github.com/petermax2/libelektra.git","ssh_url":"git@github.com:petermax2/libelektra.git","clone_url":"https://github.com/petermax2/libelektra.git","svn_url":"https://github.com/petermax2/libelektra","homepage":"","size":33523,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ElektraInitiative:master","ref":"master","sha":"6db2dd4d0cf890873b24e108d50073fa18d27920","user":{"login":"ElektraInitiative","id":7949092,"avatar_url":"https://avatars.githubusercontent.com/u/7949092?v=3","gravatar_id":"","url":"https://api.github.com/users/ElektraInitiative","html_url":"https://github.com/ElektraInitiative","followers_url":"https://api.github.com/users/ElektraInitiative/followers","following_url":"https://api.github.com/users/ElektraInitiative/following{/other_user}","gists_url":"https://api.github.com/users/ElektraInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/ElektraInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElektraInitiative/subscriptions","organizations_url":"https://api.github.com/users/ElektraInitiative/orgs","repos_url":"https://api.github.com/users/ElektraInitiative/repos","events_url":"https://api.github.com/users/ElektraInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/ElektraInitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":21063580,"name":"libelektra","full_name":"ElektraInitiative/libelektra","owner":{"login":"ElektraInitiative","id":7949092,"avatar_url":"https://avatars.githubusercontent.com/u/7949092?v=3","gravatar_id":"","url":"https://api.github.com/users/ElektraInitiative","html_url":"https://github.com/ElektraInitiative","followers_url":"https://api.github.com/users/ElektraInitiative/followers","following_url":"https://api.github.com/users/ElektraInitiative/following{/other_user}","gists_url":"https://api.github.com/users/ElektraInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/ElektraInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElektraInitiative/subscriptions","organizations_url":"https://api.github.com/users/ElektraInitiative/orgs","repos_url":"https://api.github.com/users/ElektraInitiative/repos","events_url":"https://api.github.com/users/ElektraInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/ElektraInitiative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElektraInitiative/libelektra","description":"Elektra serves as a universal and secure framework to access configuration parameters in a global, hierarchical key database.","fork":false,"url":"https://api.github.com/repos/ElektraInitiative/libelektra","forks_url":"https://api.github.com/repos/ElektraInitiative/libelektra/forks","keys_url":"https://api.github.com/repos/ElektraInitiative/libelektra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElektraInitiative/libelektra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElektraInitiative/libelektra/teams","hooks_url":"https://api.github.com/repos/ElektraInitiative/libelektra/hooks","issue_events_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/events{/number}","events_url":"https://api.github.com/repos/ElektraInitiative/libelektra/events","assignees_url":"https://api.github.com/repos/ElektraInitiative/libelektra/assignees{/user}","branches_url":"https://api.github.com/repos/ElektraInitiative/libelektra/branches{/branch}","tags_url":"https://api.github.com/repos/ElektraInitiative/libelektra/tags","blobs_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElektraInitiative/libelektra/statuses/{sha}","languages_url":"https://api.github.com/repos/ElektraInitiative/libelektra/languages","stargazers_url":"https://api.github.com/repos/ElektraInitiative/libelektra/stargazers","contributors_url":"https://api.github.com/repos/ElektraInitiative/libelektra/contributors","subscribers_url":"https://api.github.com/repos/ElektraInitiative/libelektra/subscribers","subscription_url":"https://api.github.com/repos/ElektraInitiative/libelektra/subscription","commits_url":"https://api.github.com/repos/ElektraInitiative/libelektra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElektraInitiative/libelektra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElektraInitiative/libelektra/contents/{+path}","compare_url":"https://api.github.com/repos/ElektraInitiative/libelektra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElektraInitiative/libelektra/merges","archive_url":"https://api.github.com/repos/ElektraInitiative/libelektra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElektraInitiative/libelektra/downloads","issues_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues{/number}","pulls_url":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls{/number}","milestones_url":"https://api.github.com/repos/ElektraInitiative/libelektra/milestones{/number}","notifications_url":"https://api.github.com/repos/ElektraInitiative/libelektra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElektraInitiative/libelektra/labels{/name}","releases_url":"https://api.github.com/repos/ElektraInitiative/libelektra/releases{/id}","deployments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/deployments","created_at":"2014-06-21T08:01:04Z","updated_at":"2016-07-18T18:38:12Z","pushed_at":"2016-09-05T13:04:56Z","git_url":"git://github.com/ElektraInitiative/libelektra.git","ssh_url":"git@github.com:ElektraInitiative/libelektra.git","clone_url":"https://github.com/ElektraInitiative/libelektra.git","svn_url":"https://github.com/ElektraInitiative/libelektra","homepage":"http://libelektra.org","size":34143,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":163,"forks":26,"open_issues":163,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892"},"html":{"href":"https://github.com/ElektraInitiative/libelektra/pull/892"},"issue":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/892"},"comments":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/ElektraInitiative/libelektra/statuses/2e0b9d518a22a65ef3713db67d9f2eeac1580a4c"}}}}
{"actor":{"display_login":"markus2330"}}