{"action":"created","issue":{"url":"https://api.github.com/repos/hercules-390/hyperion/issues/104","repository_url":"https://api.github.com/repos/hercules-390/hyperion","labels_url":"https://api.github.com/repos/hercules-390/hyperion/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/hercules-390/hyperion/issues/104/comments","events_url":"https://api.github.com/repos/hercules-390/hyperion/issues/104/events","html_url":"https://github.com/hercules-390/hyperion/issues/104","id":151375962,"number":104,"title":"Enhance build to include commit count, SHA, and modified in version string","user":{"login":"srorso","id":17149494,"avatar_url":"https://avatars.githubusercontent.com/u/17149494?v=3","gravatar_id":"","url":"https://api.github.com/users/srorso","html_url":"https://github.com/srorso","followers_url":"https://api.github.com/users/srorso/followers","following_url":"https://api.github.com/users/srorso/following{/other_user}","gists_url":"https://api.github.com/users/srorso/gists{/gist_id}","starred_url":"https://api.github.com/users/srorso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srorso/subscriptions","organizations_url":"https://api.github.com/users/srorso/orgs","repos_url":"https://api.github.com/users/srorso/repos","events_url":"https://api.github.com/users/srorso/events{/privacy}","received_events_url":"https://api.github.com/users/srorso/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/Enhancement","name":"Enhancement","color":"0099FF"},{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/In%20progress...","name":"In progress...","color":"FF9933"},{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/More%20work%20remains","name":"More work remains","color":"FF4848"},{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/Question","name":"Question","color":"00B85C"},{"url":"https://api.github.com/repos/hercules-390/hyperion/labels/Researching...","name":"Researching...","color":"FFCC99"}],"state":"open","locked":false,"assignee":{"login":"Fish-Git","id":1486786,"avatar_url":"https://avatars.githubusercontent.com/u/1486786?v=3","gravatar_id":"","url":"https://api.github.com/users/Fish-Git","html_url":"https://github.com/Fish-Git","followers_url":"https://api.github.com/users/Fish-Git/followers","following_url":"https://api.github.com/users/Fish-Git/following{/other_user}","gists_url":"https://api.github.com/users/Fish-Git/gists{/gist_id}","starred_url":"https://api.github.com/users/Fish-Git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fish-Git/subscriptions","organizations_url":"https://api.github.com/users/Fish-Git/orgs","repos_url":"https://api.github.com/users/Fish-Git/repos","events_url":"https://api.github.com/users/Fish-Git/events{/privacy}","received_events_url":"https://api.github.com/users/Fish-Git/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2016-04-27T12:45:10Z","updated_at":"2016-05-13T21:29:36Z","closed_at":null,"body":"When building Hercules in a Windows environment from a Git repository, the Version string includes the count of commits included in the build, the SHA of the last commit, and the word \"modified\" if the build includes changes beyond the last commit, in the form:\r\n\r\n   v.m.dot.count-Gxxxxxxx-modified    (_e.g._, 4.0.0.8473-gfe2c24f)\r\n\r\nIt would be helpful to include the same information for non-windows builds.  \r\n\r\nIt would be ideal if the implementation of this enhancement did not require a re-run of autogen.sh or configure to pick up updates to the version string.  The version string value should be updated by something done in make prior to the first c compiler invocation.  "},"comment":{"url":"https://api.github.com/repos/hercules-390/hyperion/issues/comments/219164033","html_url":"https://github.com/hercules-390/hyperion/issues/104#issuecomment-219164033","issue_url":"https://api.github.com/repos/hercules-390/hyperion/issues/104","id":219164033,"user":{"login":"srorso","id":17149494,"avatar_url":"https://avatars.githubusercontent.com/u/17149494?v=3","gravatar_id":"","url":"https://api.github.com/users/srorso","html_url":"https://github.com/srorso","followers_url":"https://api.github.com/users/srorso/followers","following_url":"https://api.github.com/users/srorso/following{/other_user}","gists_url":"https://api.github.com/users/srorso/gists{/gist_id}","starred_url":"https://api.github.com/users/srorso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srorso/subscriptions","organizations_url":"https://api.github.com/users/srorso/orgs","repos_url":"https://api.github.com/users/srorso/repos","events_url":"https://api.github.com/users/srorso/events{/privacy}","received_events_url":"https://api.github.com/users/srorso/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T21:29:36Z","updated_at":"2016-05-13T21:29:36Z","body":"Hi Fish:\r\n\r\nTried the tests again:\r\n\r\nVirgin Clone (sounds like racy sci-fi): 1-3 and 5-9 reported no modifications.  Technique four could not be found \"The system cannot find the batch label specified - technique_4\"\r\n\r\nRemoved \"@\" from the first line of _build.bat: 1-2 and 5-8 reported \"-modified\"  Three and nine reported no modifications.  Four still missing.\r\n\r\nRe-ran the script:same results.\r\n\r\nRan the script with 3 9 1 2 5 6 7 8: same results in a different order.  \r\n\r\nRestored the \"@\" to the first line of _build.bat using an editor:  Test one still reports modified, test four still missing, and the remainder report unmodified.  \r\n\r\nReran the script: Tests 1-3 and 5-9 report unmodified; test 4 still missing [ :-) ]\r\n\r\nSo where did test four go?\r\n\r\nAs downloaded, gitmodtest.cmd has NL rather than CRLF line ends.  I ran it through the following command:\r\n\r\n`type gitmodtest.cmd | find /v \"\" > gitmodtest1.cmd`\r\n\r\nso I could look at it.  No visible issues.  Ran gitmodtest1.cmd, and it worked.  Re-ran the original, four is still missing.  Go figure....\r\n\r\nFor what it's worth, technique four correctly reported the status of the repository...\r\n\r\nBest Regards,\r\nSteve Orso"}}