{"action":"created","issue":{"url":"https://api.github.com/repos/Spritetm/libesphttpd/issues/16","repository_url":"https://api.github.com/repos/Spritetm/libesphttpd","labels_url":"https://api.github.com/repos/Spritetm/libesphttpd/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/Spritetm/libesphttpd/issues/16/comments","events_url":"https://api.github.com/repos/Spritetm/libesphttpd/issues/16/events","html_url":"https://github.com/Spritetm/libesphttpd/issues/16","id":152518563,"number":16,"title":"mkupgimg not working on windows","user":{"login":"valkuc","id":6421082,"avatar_url":"https://avatars.githubusercontent.com/u/6421082?v=3","gravatar_id":"","url":"https://api.github.com/users/valkuc","html_url":"https://github.com/valkuc","followers_url":"https://api.github.com/users/valkuc/followers","following_url":"https://api.github.com/users/valkuc/following{/other_user}","gists_url":"https://api.github.com/users/valkuc/gists{/gist_id}","starred_url":"https://api.github.com/users/valkuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valkuc/subscriptions","organizations_url":"https://api.github.com/users/valkuc/orgs","repos_url":"https://api.github.com/users/valkuc/repos","events_url":"https://api.github.com/users/valkuc/events{/privacy}","received_events_url":"https://api.github.com/users/valkuc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-02T09:35:45Z","updated_at":"2016-05-03T02:36:28Z","closed_at":"2016-05-03T02:36:28Z","body":"Hi!\r\nIn mkupgimg.c need to add O_BINARY option in openFile methdod. Otherwise on windows mkupgimg utility returns \"build/app.user1.bin: No error\" error and exit.\r\nHere is fixed function:\r\n```\r\nint openFile(char *file) {\r\n\tint r=open(file, O_BINARY | O_RDONLY);\r\n\tif (r<=0) {\r\n\t\tperror(file);\r\n\t\texit(1);\r\n\t}\r\n\treturn r;\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/Spritetm/libesphttpd/issues/comments/216422192","html_url":"https://github.com/Spritetm/libesphttpd/issues/16#issuecomment-216422192","issue_url":"https://api.github.com/repos/Spritetm/libesphttpd/issues/16","id":216422192,"user":{"login":"Spritetm","id":8977247,"avatar_url":"https://avatars.githubusercontent.com/u/8977247?v=3","gravatar_id":"","url":"https://api.github.com/users/Spritetm","html_url":"https://github.com/Spritetm","followers_url":"https://api.github.com/users/Spritetm/followers","following_url":"https://api.github.com/users/Spritetm/following{/other_user}","gists_url":"https://api.github.com/users/Spritetm/gists{/gist_id}","starred_url":"https://api.github.com/users/Spritetm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spritetm/subscriptions","organizations_url":"https://api.github.com/users/Spritetm/orgs","repos_url":"https://api.github.com/users/Spritetm/repos","events_url":"https://api.github.com/users/Spritetm/events{/privacy}","received_events_url":"https://api.github.com/users/Spritetm/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T02:36:28Z","updated_at":"2016-05-03T02:36:28Z","body":"Fixed in c1d3c14e6e56ca6c860485324feafa866648d2ea . Sorry, I keep forgetting about Windows users whenever I write open() statements. Thanks for reporting!"}}