{"action":"created","issue":{"url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/issues/34","repository_url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg","labels_url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/issues/34/comments","events_url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/issues/34/events","html_url":"https://github.com/KhaosT/homebridge-camera-ffmpeg/pull/34","id":196325770,"number":34,"title":"Fix video resolution selection","user":{"login":"ay","id":749915,"avatar_url":"https://avatars.githubusercontent.com/u/749915?v=3","gravatar_id":"","url":"https://api.github.com/users/ay","html_url":"https://github.com/ay","followers_url":"https://api.github.com/users/ay/followers","following_url":"https://api.github.com/users/ay/following{/other_user}","gists_url":"https://api.github.com/users/ay/gists{/gist_id}","starred_url":"https://api.github.com/users/ay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ay/subscriptions","organizations_url":"https://api.github.com/users/ay/orgs","repos_url":"https://api.github.com/users/ay/repos","events_url":"https://api.github.com/users/ay/events{/privacy}","received_events_url":"https://api.github.com/users/ay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-19T03:47:34Z","updated_at":"2016-12-19T04:02:47Z","closed_at":"2016-12-19T04:01:37Z","pull_request":{"url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/pulls/34","html_url":"https://github.com/KhaosT/homebridge-camera-ffmpeg/pull/34","diff_url":"https://github.com/KhaosT/homebridge-camera-ffmpeg/pull/34.diff","patch_url":"https://github.com/KhaosT/homebridge-camera-ffmpeg/pull/34.patch"},"body":"Looks like all the comparison operators for video resolution selection are backwards. Lower resolutions should be selected when `maxWidth`/`maxHeight` are *greater than* or equal to the resolution to include.\r\n\r\nThis bug was causing resolutions higher than `maxWidth`/`maxHeight` to be selected so if you chose for example 1280x720 as max resolution, it would also include 1920x1080 and none of the lower resolutions. For me at least, that mean't the live stream wouldn't work on Apple Watch or iPhone on LTE."},"comment":{"url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/issues/comments/267877459","html_url":"https://github.com/KhaosT/homebridge-camera-ffmpeg/pull/34#issuecomment-267877459","issue_url":"https://api.github.com/repos/KhaosT/homebridge-camera-ffmpeg/issues/34","id":267877459,"user":{"login":"KhaosT","id":1725664,"avatar_url":"https://avatars.githubusercontent.com/u/1725664?v=3","gravatar_id":"","url":"https://api.github.com/users/KhaosT","html_url":"https://github.com/KhaosT","followers_url":"https://api.github.com/users/KhaosT/followers","following_url":"https://api.github.com/users/KhaosT/following{/other_user}","gists_url":"https://api.github.com/users/KhaosT/gists{/gist_id}","starred_url":"https://api.github.com/users/KhaosT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhaosT/subscriptions","organizations_url":"https://api.github.com/users/KhaosT/orgs","repos_url":"https://api.github.com/users/KhaosT/repos","events_url":"https://api.github.com/users/KhaosT/events{/privacy}","received_events_url":"https://api.github.com/users/KhaosT/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T04:02:47Z","updated_at":"2016-12-19T04:02:47Z","body":"Thanks ;)"}}
{"actor":{"display_login":"KhaosT"}}