{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3457","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3457/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3457/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3457/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3457","id":125193220,"number":3457,"title":"[RFC] SI: Base SI sampling on VSync & horiz lines","user":{"login":"booto","id":55764,"avatar_url":"https://avatars.githubusercontent.com/u/55764?v=3","gravatar_id":"","url":"https://api.github.com/users/booto","html_url":"https://github.com/booto","followers_url":"https://api.github.com/users/booto/followers","following_url":"https://api.github.com/users/booto/following{/other_user}","gists_url":"https://api.github.com/users/booto/gists{/gist_id}","starred_url":"https://api.github.com/users/booto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booto/subscriptions","organizations_url":"https://api.github.com/users/booto/orgs","repos_url":"https://api.github.com/users/booto/repos","events_url":"https://api.github.com/users/booto/events{/privacy}","received_events_url":"https://api.github.com/users/booto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-06T15:06:52Z","updated_at":"2016-01-06T17:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3457","html_url":"https://github.com/dolphin-emu/dolphin/pull/3457","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3457.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3457.patch"},"body":"The rate at which SI is polled is specified in terms of horizontal video lines (see SIPOLL at 0xCC006430). While dolphin tries to use this to calculate the interval between SI samplings, no attention is paid to sampling in the correct phase wrt vsync. This needs testing, and changes behaviour of movies and netplay - I'm not sure why they were special cased... see the removed function in SI.cpp \"GetTicksToNextSIPoll\".\r\n\r\nThis seems to address https://bugs.dolphin-emu.org/issues/960"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/169400502","html_url":"https://github.com/dolphin-emu/dolphin/pull/3457#issuecomment-169400502","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3457","id":169400502,"user":{"login":"dolphin-emu-bot","id":6899296,"avatar_url":"https://avatars.githubusercontent.com/u/6899296?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu-bot","html_url":"https://github.com/dolphin-emu-bot","followers_url":"https://api.github.com/users/dolphin-emu-bot/followers","following_url":"https://api.github.com/users/dolphin-emu-bot/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu-bot/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu-bot/orgs","repos_url":"https://api.github.com/users/dolphin-emu-bot/repos","events_url":"https://api.github.com/users/dolphin-emu-bot/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu-bot/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T17:43:13Z","updated_at":"2016-01-06T17:43:13Z","body":"[FifoCI](https://fifoci.dolphin-emu.org/about/) detected that this change impacts graphical             rendering. Here are the [behavior differences](https://fifoci.dolphin-emu.org/version/9a2a46eb2137c177fa451cb064a570cad20e609a/)             detected by the system:\n\n* `medabots-crash` on `ogl-lin-nouveau`: [diff](https://fifoci.dolphin-emu.org/compare/1071295-1068674/)\n\n<sub><sup>automated-fifoci-reporter</sup></sub>"}}