{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/liquid/pulls/comments/59935419","id":59935419,"diff_hunk":"@@ -39,10 +39,16 @@ module Liquid\n   SpacelessFilter             = /^(?:'[^']+'|\"[^\"]+\"|[^'\"])*#{FilterSeparator}(?:#{StrictQuotedFragment})(?:#{FirstFilterArgument}(?:#{OtherFilterArgument})*)?/o\n   Expression                  = /(?:#{QuotedFragment}(?:#{SpacelessFilter})*)/o\n   TagAttributes               = /(\\w+)\\s*\\:\\s*(#{QuotedFragment})/o\n-  AnyStartingTag              = /\\{\\{|\\{\\%/\n+  AnyStartingTag              = /#{TagStart}|#{VariableStart}/o\n   PartialTemplateParser       = /#{TagStart}.*?#{TagEnd}|#{VariableStart}.*?#{VariableIncompleteEnd}/o\n   TemplateParser              = /(#{PartialTemplateParser}|#{AnyStartingTag})/o\n   VariableParser              = /\\[[^\\]]+\\]|#{VariableSegment}+\\??/o\n+  WhiteSpaceControl           = /-/\n+  WhiteSpaceTrimCheck         = /(#{TagStart}|#{VariableStart})#{WhiteSpaceControl}|#{WhiteSpaceControl}(#{TagEnd}|#{VariableEnd})/o\n+  WhiteSpaceTagStart          = /[ \\t]*\\r?\\n?[ \\t]*(#{TagStart}|#{VariableStart})#{WhiteSpaceControl}/o\n+  WhiteSpaceTagEnd            = /#{WhiteSpaceControl}(#{TagEnd}|#{VariableEnd})[ \\t]*\\r?\\n?[ \\t]*/o","path":"lib/liquid.rb","position":12,"original_position":12,"commit_id":"a01ac62c891a653692a950e804fc453ded7ebd78","original_commit_id":"a01ac62c891a653692a950e804fc453ded7ebd78","user":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"body":"I think from a developer point of view the full space clear provides the best expected results. With your issue tag I think its just a matter of developers to know the expected result which is all white space on the current line and the line above/below. If you wanted to nice output on the example provided I would just be dropping inner white space and not outer\r\n\r\n```\r\n<p>\r\n  Some starting sentence.\r\n  {% if condition -%}\r\n    Some conditional sentences\r\n    that may span multiple lines.\r\n  {%- endif %}\r\n  Some following sentence.\r\n</p>\r\n```\r\n\r\n```\r\nWhich gives the below\r\n```\r\n<p>\r\n  Some starting sentence.\r\n  Some conditional sentences\r\n    that may span multiple lines.\r\n  Some following sentence.\r\n</p>\r\n```","created_at":"2016-04-15T20:22:01Z","updated_at":"2016-04-15T20:22:01Z","html_url":"https://github.com/Shopify/liquid/pull/743#discussion_r59935419","pull_request_url":"https://api.github.com/repos/Shopify/liquid/pulls/743","_links":{"self":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/comments/59935419"},"html":{"href":"https://github.com/Shopify/liquid/pull/743#discussion_r59935419"},"pull_request":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/743"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/liquid/pulls/743","id":66353728,"html_url":"https://github.com/Shopify/liquid/pull/743","diff_url":"https://github.com/Shopify/liquid/pull/743.diff","patch_url":"https://github.com/Shopify/liquid/pull/743.patch","issue_url":"https://api.github.com/repos/Shopify/liquid/issues/743","number":743,"state":"open","locked":false,"title":"Add support for whitespace control character allowing for ERB like syntax","user":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"body":"This is a continuation of #215 and #216 . It contains all PR changes that were needed for @nickpearson to complete his PR. @fw42 ","created_at":"2016-04-13T16:43:40Z","updated_at":"2016-04-15T20:22:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/liquid/pulls/743/commits","review_comments_url":"https://api.github.com/repos/Shopify/liquid/pulls/743/comments","review_comment_url":"https://api.github.com/repos/Shopify/liquid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/liquid/issues/743/comments","statuses_url":"https://api.github.com/repos/Shopify/liquid/statuses/a01ac62c891a653692a950e804fc453ded7ebd78","head":{"label":"evulse:whitespace-dash-feature","ref":"whitespace-dash-feature","sha":"a01ac62c891a653692a950e804fc453ded7ebd78","user":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"repo":{"id":11943249,"name":"liquid","full_name":"evulse/liquid","owner":{"login":"evulse","id":1631174,"avatar_url":"https://avatars.githubusercontent.com/u/1631174?v=3","gravatar_id":"","url":"https://api.github.com/users/evulse","html_url":"https://github.com/evulse","followers_url":"https://api.github.com/users/evulse/followers","following_url":"https://api.github.com/users/evulse/following{/other_user}","gists_url":"https://api.github.com/users/evulse/gists{/gist_id}","starred_url":"https://api.github.com/users/evulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evulse/subscriptions","organizations_url":"https://api.github.com/users/evulse/orgs","repos_url":"https://api.github.com/users/evulse/repos","events_url":"https://api.github.com/users/evulse/events{/privacy}","received_events_url":"https://api.github.com/users/evulse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evulse/liquid","description":"Liquid markup language. Safe, customer facing template language for flexible web apps. ","fork":true,"url":"https://api.github.com/repos/evulse/liquid","forks_url":"https://api.github.com/repos/evulse/liquid/forks","keys_url":"https://api.github.com/repos/evulse/liquid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evulse/liquid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evulse/liquid/teams","hooks_url":"https://api.github.com/repos/evulse/liquid/hooks","issue_events_url":"https://api.github.com/repos/evulse/liquid/issues/events{/number}","events_url":"https://api.github.com/repos/evulse/liquid/events","assignees_url":"https://api.github.com/repos/evulse/liquid/assignees{/user}","branches_url":"https://api.github.com/repos/evulse/liquid/branches{/branch}","tags_url":"https://api.github.com/repos/evulse/liquid/tags","blobs_url":"https://api.github.com/repos/evulse/liquid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evulse/liquid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evulse/liquid/git/refs{/sha}","trees_url":"https://api.github.com/repos/evulse/liquid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evulse/liquid/statuses/{sha}","languages_url":"https://api.github.com/repos/evulse/liquid/languages","stargazers_url":"https://api.github.com/repos/evulse/liquid/stargazers","contributors_url":"https://api.github.com/repos/evulse/liquid/contributors","subscribers_url":"https://api.github.com/repos/evulse/liquid/subscribers","subscription_url":"https://api.github.com/repos/evulse/liquid/subscription","commits_url":"https://api.github.com/repos/evulse/liquid/commits{/sha}","git_commits_url":"https://api.github.com/repos/evulse/liquid/git/commits{/sha}","comments_url":"https://api.github.com/repos/evulse/liquid/comments{/number}","issue_comment_url":"https://api.github.com/repos/evulse/liquid/issues/comments{/number}","contents_url":"https://api.github.com/repos/evulse/liquid/contents/{+path}","compare_url":"https://api.github.com/repos/evulse/liquid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evulse/liquid/merges","archive_url":"https://api.github.com/repos/evulse/liquid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evulse/liquid/downloads","issues_url":"https://api.github.com/repos/evulse/liquid/issues{/number}","pulls_url":"https://api.github.com/repos/evulse/liquid/pulls{/number}","milestones_url":"https://api.github.com/repos/evulse/liquid/milestones{/number}","notifications_url":"https://api.github.com/repos/evulse/liquid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evulse/liquid/labels{/name}","releases_url":"https://api.github.com/repos/evulse/liquid/releases{/id}","deployments_url":"https://api.github.com/repos/evulse/liquid/deployments","created_at":"2013-08-07T06:40:40Z","updated_at":"2013-08-07T06:40:42Z","pushed_at":"2016-04-15T10:48:21Z","git_url":"git://github.com/evulse/liquid.git","ssh_url":"git@github.com:evulse/liquid.git","clone_url":"https://github.com/evulse/liquid.git","svn_url":"https://github.com/evulse/liquid","homepage":"","size":741,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"361c6952642826b10e6db641e1d1860591ac58a9","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":15435,"name":"liquid","full_name":"Shopify/liquid","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/liquid","description":"Liquid markup language. Safe, customer facing template language for flexible web apps. ","fork":false,"url":"https://api.github.com/repos/Shopify/liquid","forks_url":"https://api.github.com/repos/Shopify/liquid/forks","keys_url":"https://api.github.com/repos/Shopify/liquid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/liquid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/liquid/teams","hooks_url":"https://api.github.com/repos/Shopify/liquid/hooks","issue_events_url":"https://api.github.com/repos/Shopify/liquid/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/liquid/events","assignees_url":"https://api.github.com/repos/Shopify/liquid/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/liquid/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/liquid/tags","blobs_url":"https://api.github.com/repos/Shopify/liquid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/liquid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/liquid/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/liquid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/liquid/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/liquid/languages","stargazers_url":"https://api.github.com/repos/Shopify/liquid/stargazers","contributors_url":"https://api.github.com/repos/Shopify/liquid/contributors","subscribers_url":"https://api.github.com/repos/Shopify/liquid/subscribers","subscription_url":"https://api.github.com/repos/Shopify/liquid/subscription","commits_url":"https://api.github.com/repos/Shopify/liquid/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/liquid/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/liquid/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/liquid/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/liquid/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/liquid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/liquid/merges","archive_url":"https://api.github.com/repos/Shopify/liquid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/liquid/downloads","issues_url":"https://api.github.com/repos/Shopify/liquid/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/liquid/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/liquid/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/liquid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/liquid/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/liquid/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/liquid/deployments","created_at":"2008-05-08T15:27:26Z","updated_at":"2016-04-15T13:57:46Z","pushed_at":"2016-04-15T10:48:23Z","git_url":"git://github.com/Shopify/liquid.git","ssh_url":"git@github.com:Shopify/liquid.git","clone_url":"https://github.com/Shopify/liquid.git","svn_url":"https://github.com/Shopify/liquid","homepage":"http://liquidmarkup.org/","size":4961,"stargazers_count":4368,"watchers_count":4368,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":569,"mirror_url":null,"open_issues_count":51,"forks":569,"open_issues":51,"watchers":4368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/743"},"html":{"href":"https://github.com/Shopify/liquid/pull/743"},"issue":{"href":"https://api.github.com/repos/Shopify/liquid/issues/743"},"comments":{"href":"https://api.github.com/repos/Shopify/liquid/issues/743/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/743/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/liquid/pulls/743/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/liquid/statuses/a01ac62c891a653692a950e804fc453ded7ebd78"}}}}