{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments/51657853","id":51657853,"diff_hunk":"@@ -1735,43 +1710,42 @@ public function getLiveURLSegment() {\n \t}\n \t\n \t/**\n-\t * Rewrites any linked images on this page.\n+\t * Rewrites any linked images on this page without creating a new version record.\n \t * Non-image files should be linked via shortcodes\n \t * Triggers the onRenameLinkedAsset action on extensions.\n-\t * TODO: This doesn't work for HTMLText fields on other tables.\n+\t *\n+\t * @todo Implement image shortcodes and remove this feature\n \t */\n \tpublic function rewriteFileLinks() {\n+\t\t// Skip live stage\n+\t\tif(\\Versioned::current_stage() === \\Versioned::get_live_stage()) {","path":"code/model/SiteTree.php","position":108,"original_position":108,"commit_id":"14a672735314b18b6f19284ac22b2a0a5444a5a8","original_commit_id":"14a672735314b18b6f19284ac22b2a0a5444a5a8","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"When we shortcode images we won't need this method at all. ;D","created_at":"2016-02-02T23:57:57Z","updated_at":"2016-02-02T23:57:57Z","html_url":"https://github.com/silverstripe/silverstripe-cms/pull/1381#discussion_r51657853","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments/51657853"},"html":{"href":"https://github.com/silverstripe/silverstripe-cms/pull/1381#discussion_r51657853"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381","id":57602651,"html_url":"https://github.com/silverstripe/silverstripe-cms/pull/1381","diff_url":"https://github.com/silverstripe/silverstripe-cms/pull/1381.diff","patch_url":"https://github.com/silverstripe/silverstripe-cms/pull/1381.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1381","number":1381,"state":"open","locked":false,"title":"API Support versioned File management","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"API Decouple FIle and ErrorPage\r\nAPI Refactor versioned API methods out of SiteTree and into Versioned\r\n\r\nRequires https://github.com/silverstripe/silverstripe-framework/pull/5001 to be merged first.","created_at":"2016-01-29T03:40:07Z","updated_at":"2016-02-02T23:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b1d891dad11120baa1eaf9bd8d6725018b8483b","assignee":null,"milestone":{"url":"https://api.github.com/repos/silverstripe/silverstripe-cms/milestones/29","html_url":"https://github.com/silverstripe/silverstripe-cms/milestones/4.0.0-alpha1","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/milestones/29/labels","id":1550486,"number":29,"title":"4.0.0-alpha1","description":"","creator":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-01-29T03:42:37Z","updated_at":"2016-01-29T03:42:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1381/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/statuses/14a672735314b18b6f19284ac22b2a0a5444a5a8","head":{"label":"open-sausages:pulls/4.0/versioned-asset-control","ref":"pulls/4.0/versioned-asset-control","sha":"14a672735314b18b6f19284ac22b2a0a5444a5a8","user":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars.githubusercontent.com/u/12824172?v=3","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"repo":{"id":38219589,"name":"silverstripe-cms","full_name":"open-sausages/silverstripe-cms","owner":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars.githubusercontent.com/u/12824172?v=3","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-sausages/silverstripe-cms","description":"SilverStripe CMS - this is a module for SilverStripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.","fork":true,"url":"https://api.github.com/repos/open-sausages/silverstripe-cms","forks_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/forks","keys_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/teams","hooks_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/hooks","issue_events_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/issues/events{/number}","events_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/events","assignees_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/assignees{/user}","branches_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/branches{/branch}","tags_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/tags","blobs_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/languages","stargazers_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/stargazers","contributors_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/contributors","subscribers_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/subscribers","subscription_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/subscription","commits_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/contents/{+path}","compare_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/merges","archive_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/downloads","issues_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/issues{/number}","pulls_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/labels{/name}","releases_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/releases{/id}","deployments_url":"https://api.github.com/repos/open-sausages/silverstripe-cms/deployments","created_at":"2015-06-29T00:26:16Z","updated_at":"2015-06-29T00:26:18Z","pushed_at":"2016-02-02T23:52:59Z","git_url":"git://github.com/open-sausages/silverstripe-cms.git","ssh_url":"git@github.com:open-sausages/silverstripe-cms.git","clone_url":"https://github.com/open-sausages/silverstripe-cms.git","svn_url":"https://github.com/open-sausages/silverstripe-cms","homepage":"http://silverstripe.org/","size":16632,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.2"}},"base":{"label":"silverstripe:master","ref":"master","sha":"3d99ee07b7dc07203ac5716fd3bed6fc1b61a2c5","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1319183,"name":"silverstripe-cms","full_name":"silverstripe/silverstripe-cms","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-cms","description":"SilverStripe CMS - this is a module for SilverStripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-cms","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/deployments","created_at":"2011-02-02T04:01:36Z","updated_at":"2016-01-29T09:17:19Z","pushed_at":"2016-02-02T23:52:59Z","git_url":"git://github.com/silverstripe/silverstripe-cms.git","ssh_url":"git@github.com:silverstripe/silverstripe-cms.git","clone_url":"https://github.com/silverstripe/silverstripe-cms.git","svn_url":"https://github.com/silverstripe/silverstripe-cms","homepage":"http://silverstripe.org/","size":18501,"stargazers_count":378,"watchers_count":378,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":326,"forks":262,"open_issues":326,"watchers":378,"default_branch":"3"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381"},"html":{"href":"https://github.com/silverstripe/silverstripe-cms/pull/1381"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1381"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1381/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1381/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/statuses/14a672735314b18b6f19284ac22b2a0a5444a5a8"}}}}