{"action":"created","issue":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/938","repository_url":"https://api.github.com/repos/wikimedia/wikipedia-ios","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/938/labels{/name}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/938/comments","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/938/events","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/938","id":180432420,"number":938,"title":"Fix for \"Adding a new primary language on iOS 9 doesn't set that language as the search language\"","user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-10-01T02:09:18Z","updated_at":"2016-10-05T02:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/938","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/938","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/938.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/938.patch"},"body":"https://phabricator.wikimedia.org/T146403\r\n\r\nThe reported issue was really hard to repro consistently, but I noticed some of the search lang bar layout/configuration bits were being called multiple times (iirc 3 times on first display of the search interface). \r\n\r\nI ended up pulling *all* of the search lang bar button logic out of the `WMFSearchViewController` and into its own controller - `WMFSearchLanguagesBarViewController`. I also switched it to use normal view containment to get the new controller's view into `WMFSearchViewController`'s view.\r\n\r\n* haven't seen the iOS 9 issue again\r\n* no more repeated calls\r\n* methods in the new controller are explicit about what they do\r\n* explicit delegate protocol for being notified when search lang changes"},"comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments/251564574","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/938#issuecomment-251564574","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/938","id":251564574,"user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T02:10:59Z","updated_at":"2016-10-05T02:10:59Z","body":"@coreyfloyd ok seems pretty solid now... tested quite a bit... fingers crossed..."}}
{"actor":{"display_login":"montehurd"}}