{"action":"created","comment":{"url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/comments/65626888","id":65626888,"diff_hunk":"@@ -0,0 +1,17 @@\n+class Api::V1::Demographics::DistrictsController < Api::ApiController\n+  respond_to :json\n+\n+  def show","path":"app/controllers/api/v1/demographics/districts_controller.rb","position":4,"original_position":4,"commit_id":"01fbe3ce8dbd9afc1d60545892ce5413b5e6d7da","original_commit_id":"01fbe3ce8dbd9afc1d60545892ce5413b5e6d7da","user":{"login":"adriennedomingus","id":10178677,"avatar_url":"https://avatars.githubusercontent.com/u/10178677?v=3","gravatar_id":"","url":"https://api.github.com/users/adriennedomingus","html_url":"https://github.com/adriennedomingus","followers_url":"https://api.github.com/users/adriennedomingus/followers","following_url":"https://api.github.com/users/adriennedomingus/following{/other_user}","gists_url":"https://api.github.com/users/adriennedomingus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriennedomingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriennedomingus/subscriptions","organizations_url":"https://api.github.com/users/adriennedomingus/orgs","repos_url":"https://api.github.com/users/adriennedomingus/repos","events_url":"https://api.github.com/users/adriennedomingus/events{/privacy}","received_events_url":"https://api.github.com/users/adriennedomingus/received_events","type":"User","site_admin":false},"body":"This is on my radar, but I think how I handle errors will change as I learn more about best practices, so I'm putting this aside until I lock in my implementation","created_at":"2016-06-02T22:02:51Z","updated_at":"2016-06-02T22:02:51Z","html_url":"https://github.com/adriennedomingus/wadoe_api/pull/12#discussion_r65626888","pull_request_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/comments/65626888"},"html":{"href":"https://github.com/adriennedomingus/wadoe_api/pull/12#discussion_r65626888"},"pull_request":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12","id":72399876,"html_url":"https://github.com/adriennedomingus/wadoe_api/pull/12","diff_url":"https://github.com/adriennedomingus/wadoe_api/pull/12.diff","patch_url":"https://github.com/adriennedomingus/wadoe_api/pull/12.patch","issue_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/12","number":12,"state":"closed","locked":false,"title":"District demographic endpoint","user":{"login":"adriennedomingus","id":10178677,"avatar_url":"https://avatars.githubusercontent.com/u/10178677?v=3","gravatar_id":"","url":"https://api.github.com/users/adriennedomingus","html_url":"https://github.com/adriennedomingus","followers_url":"https://api.github.com/users/adriennedomingus/followers","following_url":"https://api.github.com/users/adriennedomingus/following{/other_user}","gists_url":"https://api.github.com/users/adriennedomingus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriennedomingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriennedomingus/subscriptions","organizations_url":"https://api.github.com/users/adriennedomingus/orgs","repos_url":"https://api.github.com/users/adriennedomingus/repos","events_url":"https://api.github.com/users/adriennedomingus/events{/privacy}","received_events_url":"https://api.github.com/users/adriennedomingus/received_events","type":"User","site_admin":false},"body":"Creates new endpoint to retrieve demographic data for a specified school district in a given school year, adds endpoint documentation to swagger.json (includes error handling, parameters). Uses several new serializers for formatting data. \r\n\r\nError handling may not currently meet best practices; we will have a class on this next week, so may update that then\r\n\r\nSwagger documentation does not work properly in development because it expects https for the \"try it out\" functionality\r\n\r\n@geopet\r\n\r\nI'm going to go ahead and merge this in so I can work off of it, but nothing is so set in stone that additional feedback won't help!\r\n\r\nBackground: \r\nThis: https://github.com/adriennedomingus/wadoe_api/pull/4 PR includes an image of the schema\r\n\r\n","created_at":"2016-06-02T19:03:34Z","updated_at":"2016-06-02T22:02:51Z","closed_at":"2016-06-02T21:09:17Z","merged_at":"2016-06-02T21:09:17Z","merge_commit_sha":"b16bf4b8db974b196c245f6d1ade38008fbb9ffe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12/commits","review_comments_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12/comments","review_comment_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/12/comments","statuses_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/statuses/01fbe3ce8dbd9afc1d60545892ce5413b5e6d7da","head":{"label":"adriennedomingus:district-demographic-endpoint","ref":"district-demographic-endpoint","sha":"01fbe3ce8dbd9afc1d60545892ce5413b5e6d7da","user":{"login":"adriennedomingus","id":10178677,"avatar_url":"https://avatars.githubusercontent.com/u/10178677?v=3","gravatar_id":"","url":"https://api.github.com/users/adriennedomingus","html_url":"https://github.com/adriennedomingus","followers_url":"https://api.github.com/users/adriennedomingus/followers","following_url":"https://api.github.com/users/adriennedomingus/following{/other_user}","gists_url":"https://api.github.com/users/adriennedomingus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriennedomingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriennedomingus/subscriptions","organizations_url":"https://api.github.com/users/adriennedomingus/orgs","repos_url":"https://api.github.com/users/adriennedomingus/repos","events_url":"https://api.github.com/users/adriennedomingus/events{/privacy}","received_events_url":"https://api.github.com/users/adriennedomingus/received_events","type":"User","site_admin":false},"repo":{"id":60034080,"name":"wadoe_api","full_name":"adriennedomingus/wadoe_api","owner":{"login":"adriennedomingus","id":10178677,"avatar_url":"https://avatars.githubusercontent.com/u/10178677?v=3","gravatar_id":"","url":"https://api.github.com/users/adriennedomingus","html_url":"https://github.com/adriennedomingus","followers_url":"https://api.github.com/users/adriennedomingus/followers","following_url":"https://api.github.com/users/adriennedomingus/following{/other_user}","gists_url":"https://api.github.com/users/adriennedomingus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriennedomingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriennedomingus/subscriptions","organizations_url":"https://api.github.com/users/adriennedomingus/orgs","repos_url":"https://api.github.com/users/adriennedomingus/repos","events_url":"https://api.github.com/users/adriennedomingus/events{/privacy}","received_events_url":"https://api.github.com/users/adriennedomingus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adriennedomingus/wadoe_api","description":"An API for the WA Department of Education","fork":false,"url":"https://api.github.com/repos/adriennedomingus/wadoe_api","forks_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/forks","keys_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/teams","hooks_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/hooks","issue_events_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/events{/number}","events_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/events","assignees_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/assignees{/user}","branches_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/branches{/branch}","tags_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/tags","blobs_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/statuses/{sha}","languages_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/languages","stargazers_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/stargazers","contributors_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/contributors","subscribers_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/subscribers","subscription_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/subscription","commits_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/contents/{+path}","compare_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/merges","archive_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/downloads","issues_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues{/number}","pulls_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls{/number}","milestones_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/milestones{/number}","notifications_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/labels{/name}","releases_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/releases{/id}","deployments_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/deployments","created_at":"2016-05-30T19:30:09Z","updated_at":"2016-06-02T00:24:08Z","pushed_at":"2016-06-02T21:24:13Z","git_url":"git://github.com/adriennedomingus/wadoe_api.git","ssh_url":"git@github.com:adriennedomingus/wadoe_api.git","clone_url":"https://github.com/adriennedomingus/wadoe_api.git","svn_url":"https://github.com/adriennedomingus/wadoe_api","homepage":"https://wadoe-api.herokuapp.com","size":238,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"adriennedomingus:master","ref":"master","sha":"e8f8a1359f9d39613e24d9f60490b8dd719484af","user":{"login":"adriennedomingus","id":10178677,"avatar_url":"https://avatars.githubusercontent.com/u/10178677?v=3","gravatar_id":"","url":"https://api.github.com/users/adriennedomingus","html_url":"https://github.com/adriennedomingus","followers_url":"https://api.github.com/users/adriennedomingus/followers","following_url":"https://api.github.com/users/adriennedomingus/following{/other_user}","gists_url":"https://api.github.com/users/adriennedomingus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriennedomingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriennedomingus/subscriptions","organizations_url":"https://api.github.com/users/adriennedomingus/orgs","repos_url":"https://api.github.com/users/adriennedomingus/repos","events_url":"https://api.github.com/users/adriennedomingus/events{/privacy}","received_events_url":"https://api.github.com/users/adriennedomingus/received_events","type":"User","site_admin":false},"repo":{"id":60034080,"name":"wadoe_api","full_name":"adriennedomingus/wadoe_api","owner":{"login":"adriennedomingus","id":10178677,"avatar_url":"https://avatars.githubusercontent.com/u/10178677?v=3","gravatar_id":"","url":"https://api.github.com/users/adriennedomingus","html_url":"https://github.com/adriennedomingus","followers_url":"https://api.github.com/users/adriennedomingus/followers","following_url":"https://api.github.com/users/adriennedomingus/following{/other_user}","gists_url":"https://api.github.com/users/adriennedomingus/gists{/gist_id}","starred_url":"https://api.github.com/users/adriennedomingus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriennedomingus/subscriptions","organizations_url":"https://api.github.com/users/adriennedomingus/orgs","repos_url":"https://api.github.com/users/adriennedomingus/repos","events_url":"https://api.github.com/users/adriennedomingus/events{/privacy}","received_events_url":"https://api.github.com/users/adriennedomingus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adriennedomingus/wadoe_api","description":"An API for the WA Department of Education","fork":false,"url":"https://api.github.com/repos/adriennedomingus/wadoe_api","forks_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/forks","keys_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/teams","hooks_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/hooks","issue_events_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/events{/number}","events_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/events","assignees_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/assignees{/user}","branches_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/branches{/branch}","tags_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/tags","blobs_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/statuses/{sha}","languages_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/languages","stargazers_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/stargazers","contributors_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/contributors","subscribers_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/subscribers","subscription_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/subscription","commits_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/contents/{+path}","compare_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/merges","archive_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/downloads","issues_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues{/number}","pulls_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls{/number}","milestones_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/milestones{/number}","notifications_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/labels{/name}","releases_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/releases{/id}","deployments_url":"https://api.github.com/repos/adriennedomingus/wadoe_api/deployments","created_at":"2016-05-30T19:30:09Z","updated_at":"2016-06-02T00:24:08Z","pushed_at":"2016-06-02T21:24:13Z","git_url":"git://github.com/adriennedomingus/wadoe_api.git","ssh_url":"git@github.com:adriennedomingus/wadoe_api.git","clone_url":"https://github.com/adriennedomingus/wadoe_api.git","svn_url":"https://github.com/adriennedomingus/wadoe_api","homepage":"https://wadoe-api.herokuapp.com","size":238,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12"},"html":{"href":"https://github.com/adriennedomingus/wadoe_api/pull/12"},"issue":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/12"},"comments":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/adriennedomingus/wadoe_api/statuses/01fbe3ce8dbd9afc1d60545892ce5413b5e6d7da"}}}}
{"actor":{"display_login":"adriennedomingus"}}