{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-standard/pulls/comments/56789754","id":56789754,"diff_hunk":"@@ -0,0 +1,31 @@\n+<?php\n+\n+namespace AppBundle\\Action;\n+\n+use Sensio\\Bundle\\FrameworkExtraBundle\\Configuration\\Route;\n+use Symfony\\Bundle\\FrameworkBundle\\Controller\\ControllerTrait;\n+use Symfony\\Component\\DependencyInjection\\ContainerInterface;\n+use Symfony\\Component\\HttpFoundation\\Request;\n+\n+class DefaultAction\n+{\n+    use ControllerTrait;\n+\n+    private $container;","path":"src/AppBundle/Action/DefaultAction.php","position":14,"original_position":14,"commit_id":"bcf4726c9a74d4a9df618c7e18cd6bf7816996e7","original_commit_id":"bcf4726c9a74d4a9df618c7e18cd6bf7816996e7","user":{"login":"vincentchalamon","id":407859,"avatar_url":"https://avatars.githubusercontent.com/u/407859?v=3","gravatar_id":"","url":"https://api.github.com/users/vincentchalamon","html_url":"https://github.com/vincentchalamon","followers_url":"https://api.github.com/users/vincentchalamon/followers","following_url":"https://api.github.com/users/vincentchalamon/following{/other_user}","gists_url":"https://api.github.com/users/vincentchalamon/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentchalamon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentchalamon/subscriptions","organizations_url":"https://api.github.com/users/vincentchalamon/orgs","repos_url":"https://api.github.com/users/vincentchalamon/repos","events_url":"https://api.github.com/users/vincentchalamon/events{/privacy}","received_events_url":"https://api.github.com/users/vincentchalamon/received_events","type":"User","site_admin":false},"body":"```php\r\n/**\r\n * @var ContainerInterface\r\n */\r\nprivate $container;\r\n```","created_at":"2016-03-21T08:06:37Z","updated_at":"2016-03-21T08:06:37Z","html_url":"https://github.com/symfony/symfony-standard/pull/959#discussion_r56789754","pull_request_url":"https://api.github.com/repos/symfony/symfony-standard/pulls/959","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-standard/pulls/comments/56789754"},"html":{"href":"https://github.com/symfony/symfony-standard/pull/959#discussion_r56789754"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-standard/pulls/959"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-standard/pulls/959","id":63507261,"html_url":"https://github.com/symfony/symfony-standard/pull/959","diff_url":"https://github.com/symfony/symfony-standard/pull/959.diff","patch_url":"https://github.com/symfony/symfony-standard/pull/959.patch","issue_url":"https://api.github.com/repos/symfony/symfony-standard/issues/959","number":959,"state":"open","locked":false,"title":"[WIP] Support for controller autoregistration and autowiring","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"* Integrates [DunglasActionBundle](https://github.com/dunglas/DunglasActionBundle)\r\n* Automatically register \"actions\" as services and enable autowiring\r\n\r\nI've updated the Symfony demo application to show the benefits of this new system: symfony/symfony-demo#315\r\n\r\n(edited) Features:\r\n\r\n* In most cases, this is not necessary anymore to declare services (they are automatically constructed by the autowiring system - DX, RAD)\r\n* Dependencies are explicit (DX, testability)\r\n* The container is not injected in controllers anymore\r\n* It's possible (but not mandatory) to create framework agnostic controllers (especially when using the PSR-7 Bridge)\r\n* It's possible and recommended (but not mandatory) to use invokable actions (it's not what I've done in my PR on the demo to explicit the upgrade path)\r\n* It's 100% BC with the traditional controller system, 0 app will be broken, and people preferring the old way can still use it\r\n* It's 100% compatible with `@Route` and `@Template` annotations\r\n\r\nSee symfony/symfony#18193 and symfony/symfony#18193 for the history and the rationale behind this feature.\r\n\r\nTODO:\r\n\r\n* [ ] Merge symfony/symfony#18193\r\n* [ ] Merge symfony/symfony#18193\r\n* [ ] Merge symfony/symfony#17608\r\n* [x] Fix dunglas/DunglasActionBundle#18\r\n\r\n/cc @Ener-Getick","created_at":"2016-03-20T21:01:17Z","updated_at":"2016-03-21T08:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"500d1ae7ed1b206ef2af0541547a9ad734b27eb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-standard/pulls/959/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-standard/pulls/959/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-standard/issues/959/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-standard/statuses/bcf4726c9a74d4a9df618c7e18cd6bf7816996e7","head":{"label":"dunglas:action","ref":"action","sha":"bcf4726c9a74d4a9df618c7e18cd6bf7816996e7","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"repo":{"id":25604346,"name":"symfony-standard","full_name":"dunglas/symfony-standard","owner":{"login":"dunglas","id":57224,"avatar_url":"https://avatars.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dunglas/symfony-standard","description":"The \"Symfony Standard Edition\" distribution","fork":true,"url":"https://api.github.com/repos/dunglas/symfony-standard","forks_url":"https://api.github.com/repos/dunglas/symfony-standard/forks","keys_url":"https://api.github.com/repos/dunglas/symfony-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dunglas/symfony-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dunglas/symfony-standard/teams","hooks_url":"https://api.github.com/repos/dunglas/symfony-standard/hooks","issue_events_url":"https://api.github.com/repos/dunglas/symfony-standard/issues/events{/number}","events_url":"https://api.github.com/repos/dunglas/symfony-standard/events","assignees_url":"https://api.github.com/repos/dunglas/symfony-standard/assignees{/user}","branches_url":"https://api.github.com/repos/dunglas/symfony-standard/branches{/branch}","tags_url":"https://api.github.com/repos/dunglas/symfony-standard/tags","blobs_url":"https://api.github.com/repos/dunglas/symfony-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dunglas/symfony-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dunglas/symfony-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/dunglas/symfony-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dunglas/symfony-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/dunglas/symfony-standard/languages","stargazers_url":"https://api.github.com/repos/dunglas/symfony-standard/stargazers","contributors_url":"https://api.github.com/repos/dunglas/symfony-standard/contributors","subscribers_url":"https://api.github.com/repos/dunglas/symfony-standard/subscribers","subscription_url":"https://api.github.com/repos/dunglas/symfony-standard/subscription","commits_url":"https://api.github.com/repos/dunglas/symfony-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/dunglas/symfony-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/dunglas/symfony-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/dunglas/symfony-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/dunglas/symfony-standard/contents/{+path}","compare_url":"https://api.github.com/repos/dunglas/symfony-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dunglas/symfony-standard/merges","archive_url":"https://api.github.com/repos/dunglas/symfony-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dunglas/symfony-standard/downloads","issues_url":"https://api.github.com/repos/dunglas/symfony-standard/issues{/number}","pulls_url":"https://api.github.com/repos/dunglas/symfony-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/dunglas/symfony-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/dunglas/symfony-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dunglas/symfony-standard/labels{/name}","releases_url":"https://api.github.com/repos/dunglas/symfony-standard/releases{/id}","deployments_url":"https://api.github.com/repos/dunglas/symfony-standard/deployments","created_at":"2014-10-22T21:04:37Z","updated_at":"2016-03-20T20:54:50Z","pushed_at":"2016-03-20T22:05:19Z","git_url":"git://github.com/dunglas/symfony-standard.git","ssh_url":"git@github.com:dunglas/symfony-standard.git","clone_url":"https://github.com/dunglas/symfony-standard.git","svn_url":"https://github.com/dunglas/symfony-standard","homepage":"symfony.com","size":1216,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"05bca699ef631d03d4b114b4366ad0c180b55ecb","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":1447039,"name":"symfony-standard","full_name":"symfony/symfony-standard","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-standard","description":"The \"Symfony Standard Edition\" distribution","fork":false,"url":"https://api.github.com/repos/symfony/symfony-standard","forks_url":"https://api.github.com/repos/symfony/symfony-standard/forks","keys_url":"https://api.github.com/repos/symfony/symfony-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-standard/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-standard/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-standard/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-standard/events","assignees_url":"https://api.github.com/repos/symfony/symfony-standard/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-standard/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-standard/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-standard/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-standard/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-standard/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-standard/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-standard/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-standard/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-standard/merges","archive_url":"https://api.github.com/repos/symfony/symfony-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-standard/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-standard/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-standard/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-standard/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony-standard/deployments","created_at":"2011-03-06T17:58:20Z","updated_at":"2016-03-20T19:51:53Z","pushed_at":"2016-03-20T22:05:21Z","git_url":"git://github.com/symfony/symfony-standard.git","ssh_url":"git@github.com:symfony/symfony-standard.git","clone_url":"https://github.com/symfony/symfony-standard.git","svn_url":"https://github.com/symfony/symfony-standard","homepage":"symfony.com","size":4044,"stargazers_count":1306,"watchers_count":1306,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1125,"mirror_url":null,"open_issues_count":14,"forks":1125,"open_issues":14,"watchers":1306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-standard/pulls/959"},"html":{"href":"https://github.com/symfony/symfony-standard/pull/959"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-standard/issues/959"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-standard/issues/959/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-standard/pulls/959/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-standard/pulls/959/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-standard/statuses/bcf4726c9a74d4a9df618c7e18cd6bf7816996e7"}}}}