{"action":"created","comment":{"url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/comments/84551004","pull_request_review_id":5325796,"id":84551004,"diff_hunk":"@@ -16,62 +16,65 @@ FROM       centos:centos7\n \n MAINTAINER Sonatype <cloud-ops@sonatype.com>\n \n-LABEL vendor=Sonatype \\\n-  com.sonatype.license=\"Apache License, Version 2.0\" \\\n-  com.sonatype.name=\"Nexus Repository Manager base image\"\n+LABEL vendor=\"Sonatype\" \\\n+      com.sonatype.license=\"Apache License, Version 2.0\" \\\n+      com.sonatype.name=\"Nexus Repository Manager base image\"\n \n-RUN yum install -y \\\n-  curl tar \\\n-  && yum clean all\n+RUN yum install -y --setopt=tsflags=nodocs curl tar && \\\n+    yum clean all\n \n # install Oracle JRE\n ENV JAVA_HOME=/opt/java \\\n-  JAVA_VERSION_MAJOR=8 \\\n-  JAVA_VERSION_MINOR=102 \\\n-  JAVA_VERSION_BUILD=14\n+    JAVA_VERSION_MAJOR=8 \\\n+    JAVA_VERSION_MINOR=102 \\\n+    JAVA_VERSION_BUILD=14\n \n-RUN mkdir -p /opt \\\n-  && curl --fail --silent --location --retry 3 \\\n-  --header \"Cookie: oraclelicense=accept-securebackup-cookie; \" \\\n-  http://download.oracle.com/otn-pub/java/jdk/${JAVA_VERSION_MAJOR}u${JAVA_VERSION_MINOR}-b${JAVA_VERSION_BUILD}/server-jre-${JAVA_VERSION_MAJOR}u${JAVA_VERSION_MINOR}-linux-x64.tar.gz \\\n-  | gunzip \\\n-  | tar -x -C /opt \\\n-  && ln -s /opt/jdk1.${JAVA_VERSION_MAJOR}.0_${JAVA_VERSION_MINOR} ${JAVA_HOME}\n+RUN curl --remote-name --fail --silent --location --retry 3 \\\n+        --header \"Cookie: oraclelicense=accept-securebackup-cookie; \" \\\n+        http://download.oracle.com/otn-pub/java/jdk/${JAVA_VERSION_MAJOR}u${JAVA_VERSION_MINOR}-b${JAVA_VERSION_BUILD}/jdk-${JAVA_VERSION_MAJOR}u${JAVA_VERSION_MINOR}-linux-x64.rpm && \\\n+    yum localinstall -y jdk-${JAVA_VERSION_MAJOR}u${JAVA_VERSION_MINOR}-linux-x64.rpm && \\\n+    yum clean all && \\\n+    rm jdk-${JAVA_VERSION_MAJOR}u${JAVA_VERSION_MINOR}-linux-x64.rpm\n \n # install nexus\n-ENV NEXUS_VERSION=3.0.2-02\n-RUN mkdir -p /opt/sonatype/nexus \\\n-  && curl --fail --silent --location --retry 3 \\\n-    https://download.sonatype.com/nexus/3/nexus-${NEXUS_VERSION}-unix.tar.gz \\\n-  | gunzip \\\n-  | tar x -C /opt/sonatype/nexus --strip-components=1 nexus-${NEXUS_VERSION} \\\n-  && chown -R root:root /opt/sonatype/nexus ","path":"Dockerfile","position":47,"original_position":47,"commit_id":"5fa1713ff586dc17697e2a66ddb78dc4b7b762f6","original_commit_id":"5fa1713ff586dc17697e2a66ddb78dc4b7b762f6","user":{"login":"whyjustin","id":643156,"avatar_url":"https://avatars.githubusercontent.com/u/643156?v=3","gravatar_id":"","url":"https://api.github.com/users/whyjustin","html_url":"https://github.com/whyjustin","followers_url":"https://api.github.com/users/whyjustin/followers","following_url":"https://api.github.com/users/whyjustin/following{/other_user}","gists_url":"https://api.github.com/users/whyjustin/gists{/gist_id}","starred_url":"https://api.github.com/users/whyjustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyjustin/subscriptions","organizations_url":"https://api.github.com/users/whyjustin/orgs","repos_url":"https://api.github.com/users/whyjustin/repos","events_url":"https://api.github.com/users/whyjustin/events{/privacy}","received_events_url":"https://api.github.com/users/whyjustin/received_events","type":"User","site_admin":false},"body":"This change is hidden but chown is removed as mkdir is running as root and *I believe* this is unnecessary.","created_at":"2016-10-21T21:53:49Z","updated_at":"2016-10-21T21:53:49Z","html_url":"https://github.com/sonatype/docker-nexus3/pull/46#discussion_r84551004","pull_request_url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/comments/84551004"},"html":{"href":"https://github.com/sonatype/docker-nexus3/pull/46#discussion_r84551004"},"pull_request":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46","id":90450109,"html_url":"https://github.com/sonatype/docker-nexus3/pull/46","diff_url":"https://github.com/sonatype/docker-nexus3/pull/46.diff","patch_url":"https://github.com/sonatype/docker-nexus3/pull/46.patch","issue_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues/46","number":46,"state":"open","locked":false,"title":"Opinionated install, formatting, variable changes","user":{"login":"whyjustin","id":643156,"avatar_url":"https://avatars.githubusercontent.com/u/643156?v=3","gravatar_id":"","url":"https://api.github.com/users/whyjustin","html_url":"https://github.com/whyjustin","followers_url":"https://api.github.com/users/whyjustin/followers","following_url":"https://api.github.com/users/whyjustin/following{/other_user}","gists_url":"https://api.github.com/users/whyjustin/gists{/gist_id}","starred_url":"https://api.github.com/users/whyjustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyjustin/subscriptions","organizations_url":"https://api.github.com/users/whyjustin/orgs","repos_url":"https://api.github.com/users/whyjustin/repos","events_url":"https://api.github.com/users/whyjustin/events{/privacy}","received_events_url":"https://api.github.com/users/whyjustin/received_events","type":"User","site_admin":false},"body":"From your local Integrations team.\r\n\r\n* Use yum to manage Oracle JDK install\r\n* Use env variables where appropriate\r\n* Opinionated formatting and style changes\r\n\r\nAddresses #44","created_at":"2016-10-21T21:52:31Z","updated_at":"2016-10-21T21:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0e09d36ba824de696ba9e4c8d8d4e3462c7fd0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46/commits","review_comments_url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46/comments","review_comment_url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues/46/comments","statuses_url":"https://api.github.com/repos/sonatype/docker-nexus3/statuses/5fa1713ff586dc17697e2a66ddb78dc4b7b762f6","head":{"label":"sonatype:Opinionated_Formatting_And_Install_Changes","ref":"Opinionated_Formatting_And_Install_Changes","sha":"5fa1713ff586dc17697e2a66ddb78dc4b7b762f6","user":{"login":"sonatype","id":44938,"avatar_url":"https://avatars.githubusercontent.com/u/44938?v=3","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"repo":{"id":55541650,"name":"docker-nexus3","full_name":"sonatype/docker-nexus3","owner":{"login":"sonatype","id":44938,"avatar_url":"https://avatars.githubusercontent.com/u/44938?v=3","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonatype/docker-nexus3","description":"Dockerized version of Nexus Repo Manager 3","fork":false,"url":"https://api.github.com/repos/sonatype/docker-nexus3","forks_url":"https://api.github.com/repos/sonatype/docker-nexus3/forks","keys_url":"https://api.github.com/repos/sonatype/docker-nexus3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonatype/docker-nexus3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonatype/docker-nexus3/teams","hooks_url":"https://api.github.com/repos/sonatype/docker-nexus3/hooks","issue_events_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues/events{/number}","events_url":"https://api.github.com/repos/sonatype/docker-nexus3/events","assignees_url":"https://api.github.com/repos/sonatype/docker-nexus3/assignees{/user}","branches_url":"https://api.github.com/repos/sonatype/docker-nexus3/branches{/branch}","tags_url":"https://api.github.com/repos/sonatype/docker-nexus3/tags","blobs_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonatype/docker-nexus3/statuses/{sha}","languages_url":"https://api.github.com/repos/sonatype/docker-nexus3/languages","stargazers_url":"https://api.github.com/repos/sonatype/docker-nexus3/stargazers","contributors_url":"https://api.github.com/repos/sonatype/docker-nexus3/contributors","subscribers_url":"https://api.github.com/repos/sonatype/docker-nexus3/subscribers","subscription_url":"https://api.github.com/repos/sonatype/docker-nexus3/subscription","commits_url":"https://api.github.com/repos/sonatype/docker-nexus3/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonatype/docker-nexus3/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonatype/docker-nexus3/contents/{+path}","compare_url":"https://api.github.com/repos/sonatype/docker-nexus3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonatype/docker-nexus3/merges","archive_url":"https://api.github.com/repos/sonatype/docker-nexus3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonatype/docker-nexus3/downloads","issues_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues{/number}","pulls_url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls{/number}","milestones_url":"https://api.github.com/repos/sonatype/docker-nexus3/milestones{/number}","notifications_url":"https://api.github.com/repos/sonatype/docker-nexus3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonatype/docker-nexus3/labels{/name}","releases_url":"https://api.github.com/repos/sonatype/docker-nexus3/releases{/id}","deployments_url":"https://api.github.com/repos/sonatype/docker-nexus3/deployments","created_at":"2016-04-05T20:04:37Z","updated_at":"2016-10-21T09:51:47Z","pushed_at":"2016-10-21T21:52:31Z","git_url":"git://github.com/sonatype/docker-nexus3.git","ssh_url":"git@github.com:sonatype/docker-nexus3.git","clone_url":"https://github.com/sonatype/docker-nexus3.git","svn_url":"https://github.com/sonatype/docker-nexus3","homepage":null,"size":41,"stargazers_count":92,"watchers_count":92,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":9,"forks":61,"open_issues":9,"watchers":92,"default_branch":"master"}},"base":{"label":"sonatype:master","ref":"master","sha":"222feb87e9502dc2f46e94b8fb706a77f784a8fe","user":{"login":"sonatype","id":44938,"avatar_url":"https://avatars.githubusercontent.com/u/44938?v=3","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"repo":{"id":55541650,"name":"docker-nexus3","full_name":"sonatype/docker-nexus3","owner":{"login":"sonatype","id":44938,"avatar_url":"https://avatars.githubusercontent.com/u/44938?v=3","gravatar_id":"","url":"https://api.github.com/users/sonatype","html_url":"https://github.com/sonatype","followers_url":"https://api.github.com/users/sonatype/followers","following_url":"https://api.github.com/users/sonatype/following{/other_user}","gists_url":"https://api.github.com/users/sonatype/gists{/gist_id}","starred_url":"https://api.github.com/users/sonatype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonatype/subscriptions","organizations_url":"https://api.github.com/users/sonatype/orgs","repos_url":"https://api.github.com/users/sonatype/repos","events_url":"https://api.github.com/users/sonatype/events{/privacy}","received_events_url":"https://api.github.com/users/sonatype/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonatype/docker-nexus3","description":"Dockerized version of Nexus Repo Manager 3","fork":false,"url":"https://api.github.com/repos/sonatype/docker-nexus3","forks_url":"https://api.github.com/repos/sonatype/docker-nexus3/forks","keys_url":"https://api.github.com/repos/sonatype/docker-nexus3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonatype/docker-nexus3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonatype/docker-nexus3/teams","hooks_url":"https://api.github.com/repos/sonatype/docker-nexus3/hooks","issue_events_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues/events{/number}","events_url":"https://api.github.com/repos/sonatype/docker-nexus3/events","assignees_url":"https://api.github.com/repos/sonatype/docker-nexus3/assignees{/user}","branches_url":"https://api.github.com/repos/sonatype/docker-nexus3/branches{/branch}","tags_url":"https://api.github.com/repos/sonatype/docker-nexus3/tags","blobs_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonatype/docker-nexus3/statuses/{sha}","languages_url":"https://api.github.com/repos/sonatype/docker-nexus3/languages","stargazers_url":"https://api.github.com/repos/sonatype/docker-nexus3/stargazers","contributors_url":"https://api.github.com/repos/sonatype/docker-nexus3/contributors","subscribers_url":"https://api.github.com/repos/sonatype/docker-nexus3/subscribers","subscription_url":"https://api.github.com/repos/sonatype/docker-nexus3/subscription","commits_url":"https://api.github.com/repos/sonatype/docker-nexus3/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonatype/docker-nexus3/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonatype/docker-nexus3/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonatype/docker-nexus3/contents/{+path}","compare_url":"https://api.github.com/repos/sonatype/docker-nexus3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonatype/docker-nexus3/merges","archive_url":"https://api.github.com/repos/sonatype/docker-nexus3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonatype/docker-nexus3/downloads","issues_url":"https://api.github.com/repos/sonatype/docker-nexus3/issues{/number}","pulls_url":"https://api.github.com/repos/sonatype/docker-nexus3/pulls{/number}","milestones_url":"https://api.github.com/repos/sonatype/docker-nexus3/milestones{/number}","notifications_url":"https://api.github.com/repos/sonatype/docker-nexus3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonatype/docker-nexus3/labels{/name}","releases_url":"https://api.github.com/repos/sonatype/docker-nexus3/releases{/id}","deployments_url":"https://api.github.com/repos/sonatype/docker-nexus3/deployments","created_at":"2016-04-05T20:04:37Z","updated_at":"2016-10-21T09:51:47Z","pushed_at":"2016-10-21T21:52:31Z","git_url":"git://github.com/sonatype/docker-nexus3.git","ssh_url":"git@github.com:sonatype/docker-nexus3.git","clone_url":"https://github.com/sonatype/docker-nexus3.git","svn_url":"https://github.com/sonatype/docker-nexus3","homepage":null,"size":41,"stargazers_count":92,"watchers_count":92,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":9,"forks":61,"open_issues":9,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46"},"html":{"href":"https://github.com/sonatype/docker-nexus3/pull/46"},"issue":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/issues/46"},"comments":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/sonatype/docker-nexus3/statuses/5fa1713ff586dc17697e2a66ddb78dc4b7b762f6"}}}}
{"actor":{"display_login":"whyjustin"}}