{"action":"created","comment":{"url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments/78592713","id":78592713,"diff_hunk":"@@ -339,10 +352,14 @@ export module Constants {\n \t}\n \n \texport module Settings {\n-\t\texport var timeBetweenTooltips = 1000 * 60 * 60 * 24 * 7 * 3; // 21 days\n-\t\texport var noOpTrackerTimeoutDuration = 20 * 1000; // 20 seconds\n+\t\texport var fontSizeStep = 2;\n+\t\texport var maxClipSuccessForRatingsPrompt = 12; // TODO waiting for consensus on this value\n+\t\texport var maximumJSTimeValue = 8640000000000000; // http://ecma-international.org/ecma-262/5.1/#sec-15.9.1.1","path":"src/scripts/constants.ts","position":43,"original_position":43,"commit_id":"58f25040ff69d5b93578905fb3e3c3d203056c9d","original_commit_id":"58f25040ff69d5b93578905fb3e3c3d203056c9d","user":{"login":"VishaalK","id":3259870,"avatar_url":"https://avatars.githubusercontent.com/u/3259870?v=3","gravatar_id":"","url":"https://api.github.com/users/VishaalK","html_url":"https://github.com/VishaalK","followers_url":"https://api.github.com/users/VishaalK/followers","following_url":"https://api.github.com/users/VishaalK/following{/other_user}","gists_url":"https://api.github.com/users/VishaalK/gists{/gist_id}","starred_url":"https://api.github.com/users/VishaalK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VishaalK/subscriptions","organizations_url":"https://api.github.com/users/VishaalK/orgs","repos_url":"https://api.github.com/users/VishaalK/repos","events_url":"https://api.github.com/users/VishaalK/events{/privacy}","received_events_url":"https://api.github.com/users/VishaalK/received_events","type":"User","site_admin":false},"body":"can you make this multiplied out like the others?","created_at":"2016-09-13T16:15:15Z","updated_at":"2016-09-13T16:15:15Z","html_url":"https://github.com/OneNoteDev/WebClipper/pull/22#discussion_r78592713","pull_request_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments/78592713"},"html":{"href":"https://github.com/OneNoteDev/WebClipper/pull/22#discussion_r78592713"},"pull_request":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22","id":84941839,"html_url":"https://github.com/OneNoteDev/WebClipper/pull/22","diff_url":"https://github.com/OneNoteDev/WebClipper/pull/22.diff","patch_url":"https://github.com/OneNoteDev/WebClipper/pull/22.patch","issue_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/22","number":22,"state":"open","locked":false,"title":"[Feature] Ratings prompt","user":{"login":"iconix","id":1144401,"avatar_url":"https://avatars.githubusercontent.com/u/1144401?v=3","gravatar_id":"","url":"https://api.github.com/users/iconix","html_url":"https://github.com/iconix","followers_url":"https://api.github.com/users/iconix/followers","following_url":"https://api.github.com/users/iconix/following{/other_user}","gists_url":"https://api.github.com/users/iconix/gists{/gist_id}","starred_url":"https://api.github.com/users/iconix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iconix/subscriptions","organizations_url":"https://api.github.com/users/iconix/orgs","repos_url":"https://api.github.com/users/iconix/repos","events_url":"https://api.github.com/users/iconix/events{/privacy}","received_events_url":"https://api.github.com/users/iconix/received_events","type":"User","site_admin":false},"body":"This feature enables the Web Clipper to receive positive and negative feedback from \"active\" users.\r\n\r\nWhen a user's engagement with the Web Clipper qualifies them, we will show an additional sub-panel after a successful clip, which asks: \"Enjoying the Web Clipper?\" We will then log their response (\"Yes, it's great!\" vs \"Not really...\") depending on button clicked.\r\n\r\nAdditionally, if rate and feedback URLs are provided in Web Clipper settings, we will show the user additional prompts that will direct them to places where they can leave further feedback.\r\n\r\nThe \"when to show\" logic for this ratings sub-panel is where things get a little complicated. In broad strokes, the checks break down as follows:\r\n\r\n1. Is this feature enabled for the client being used (e.g., ChromeExtension, EdgeExtension, Bookmarklet, etc.)?\r\n2. Is the user \"active\" (dependent on # successful clips)?\r\n3. Have we shown this ratings panel to the user before? If so, what kind of response did we get (no response, positive response, negative response)?\r\n\r\n_Please see method descriptions in `RatingsHelper.ts` for further breakdown of the \"when to show\" logic._\r\n\r\n**PENDING TO-DOs as of initial PR publish:**\r\n\r\n1. Animations, as spec'd by the design team\r\n2. Fix commented-out tests in `ratingsHelper_tests.tsx`\r\n3. Finalize logic on 1) how to handle users who never interact with the ratings prompt, and 2) how to determine enough time has passed after negative feedback to re-prompt users? (_email discussion ongoing_)\r\n","created_at":"2016-09-12T20:47:58Z","updated_at":"2016-09-13T16:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1769befe16bb3d339330796531af252665449da7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22/commits","review_comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22/comments","review_comment_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/22/comments","statuses_url":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/58f25040ff69d5b93578905fb3e3c3d203056c9d","head":{"label":"OneNoteDev:feature/ratings-prompt","ref":"feature/ratings-prompt","sha":"58f25040ff69d5b93578905fb3e3c3d203056c9d","user":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars.githubusercontent.com/u/6225732?v=3","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"repo":{"id":66974243,"name":"WebClipper","full_name":"OneNoteDev/WebClipper","owner":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars.githubusercontent.com/u/6225732?v=3","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneNoteDev/WebClipper","description":"The OneNote Web Clipper extension","fork":false,"url":"https://api.github.com/repos/OneNoteDev/WebClipper","forks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/forks","keys_url":"https://api.github.com/repos/OneNoteDev/WebClipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneNoteDev/WebClipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneNoteDev/WebClipper/teams","hooks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/hooks","issue_events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/events{/number}","events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/events","assignees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/assignees{/user}","branches_url":"https://api.github.com/repos/OneNoteDev/WebClipper/branches{/branch}","tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/tags","blobs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/{sha}","languages_url":"https://api.github.com/repos/OneNoteDev/WebClipper/languages","stargazers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/stargazers","contributors_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contributors","subscribers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscribers","subscription_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscription","commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contents/{+path}","compare_url":"https://api.github.com/repos/OneNoteDev/WebClipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneNoteDev/WebClipper/merges","archive_url":"https://api.github.com/repos/OneNoteDev/WebClipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneNoteDev/WebClipper/downloads","issues_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues{/number}","pulls_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls{/number}","milestones_url":"https://api.github.com/repos/OneNoteDev/WebClipper/milestones{/number}","notifications_url":"https://api.github.com/repos/OneNoteDev/WebClipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneNoteDev/WebClipper/labels{/name}","releases_url":"https://api.github.com/repos/OneNoteDev/WebClipper/releases{/id}","deployments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/deployments","created_at":"2016-08-30T20:11:15Z","updated_at":"2016-09-13T08:19:23Z","pushed_at":"2016-09-12T20:47:58Z","git_url":"git://github.com/OneNoteDev/WebClipper.git","ssh_url":"git@github.com:OneNoteDev/WebClipper.git","clone_url":"https://github.com/OneNoteDev/WebClipper.git","svn_url":"https://github.com/OneNoteDev/WebClipper","homepage":"https://www.onenote.com/clipper","size":3843,"stargazers_count":17,"watchers_count":17,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":17,"default_branch":"master"}},"base":{"label":"OneNoteDev:master","ref":"master","sha":"fb45028029e0a36f0d4a07b54858faaed3bb5821","user":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars.githubusercontent.com/u/6225732?v=3","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"repo":{"id":66974243,"name":"WebClipper","full_name":"OneNoteDev/WebClipper","owner":{"login":"OneNoteDev","id":6225732,"avatar_url":"https://avatars.githubusercontent.com/u/6225732?v=3","gravatar_id":"","url":"https://api.github.com/users/OneNoteDev","html_url":"https://github.com/OneNoteDev","followers_url":"https://api.github.com/users/OneNoteDev/followers","following_url":"https://api.github.com/users/OneNoteDev/following{/other_user}","gists_url":"https://api.github.com/users/OneNoteDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OneNoteDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OneNoteDev/subscriptions","organizations_url":"https://api.github.com/users/OneNoteDev/orgs","repos_url":"https://api.github.com/users/OneNoteDev/repos","events_url":"https://api.github.com/users/OneNoteDev/events{/privacy}","received_events_url":"https://api.github.com/users/OneNoteDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OneNoteDev/WebClipper","description":"The OneNote Web Clipper extension","fork":false,"url":"https://api.github.com/repos/OneNoteDev/WebClipper","forks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/forks","keys_url":"https://api.github.com/repos/OneNoteDev/WebClipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OneNoteDev/WebClipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OneNoteDev/WebClipper/teams","hooks_url":"https://api.github.com/repos/OneNoteDev/WebClipper/hooks","issue_events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/events{/number}","events_url":"https://api.github.com/repos/OneNoteDev/WebClipper/events","assignees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/assignees{/user}","branches_url":"https://api.github.com/repos/OneNoteDev/WebClipper/branches{/branch}","tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/tags","blobs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/{sha}","languages_url":"https://api.github.com/repos/OneNoteDev/WebClipper/languages","stargazers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/stargazers","contributors_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contributors","subscribers_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscribers","subscription_url":"https://api.github.com/repos/OneNoteDev/WebClipper/subscription","commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/OneNoteDev/WebClipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/OneNoteDev/WebClipper/contents/{+path}","compare_url":"https://api.github.com/repos/OneNoteDev/WebClipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OneNoteDev/WebClipper/merges","archive_url":"https://api.github.com/repos/OneNoteDev/WebClipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OneNoteDev/WebClipper/downloads","issues_url":"https://api.github.com/repos/OneNoteDev/WebClipper/issues{/number}","pulls_url":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls{/number}","milestones_url":"https://api.github.com/repos/OneNoteDev/WebClipper/milestones{/number}","notifications_url":"https://api.github.com/repos/OneNoteDev/WebClipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OneNoteDev/WebClipper/labels{/name}","releases_url":"https://api.github.com/repos/OneNoteDev/WebClipper/releases{/id}","deployments_url":"https://api.github.com/repos/OneNoteDev/WebClipper/deployments","created_at":"2016-08-30T20:11:15Z","updated_at":"2016-09-13T08:19:23Z","pushed_at":"2016-09-12T20:47:58Z","git_url":"git://github.com/OneNoteDev/WebClipper.git","ssh_url":"git@github.com:OneNoteDev/WebClipper.git","clone_url":"https://github.com/OneNoteDev/WebClipper.git","svn_url":"https://github.com/OneNoteDev/WebClipper","homepage":"https://www.onenote.com/clipper","size":3843,"stargazers_count":17,"watchers_count":17,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22"},"html":{"href":"https://github.com/OneNoteDev/WebClipper/pull/22"},"issue":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/22"},"comments":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/OneNoteDev/WebClipper/statuses/58f25040ff69d5b93578905fb3e3c3d203056c9d"}}}}
{"actor":{"display_login":"VishaalK"}}