{"action":"created","issue":{"url":"https://api.github.com/repos/TokTok/c-toxcore/issues/361","repository_url":"https://api.github.com/repos/TokTok/c-toxcore","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/361/labels{/name}","comments_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/361/comments","events_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/361/events","html_url":"https://github.com/TokTok/c-toxcore/pull/361","id":197772202,"number":361,"title":"Simplify integration as a third-party lib in cmake projects","user":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-27T23:36:20Z","updated_at":"2016-12-28T16:37:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/361","html_url":"https://github.com/TokTok/c-toxcore/pull/361","diff_url":"https://github.com/TokTok/c-toxcore/pull/361.diff","patch_url":"https://github.com/TokTok/c-toxcore/pull/361.patch"},"body":"The CMAKE_SOURCE_DIR variable points to the top-level directory of a (parent) project while we want to point to the top-level (source) directory of the lib. This change simplifies the integration as a third-party lib. We can use CMAKE_CURRENT_SOURCE_DIR or simply \"nothing\" ('.') to point to the directory where the CMakeLists.txt file resides.\r\n\r\n**Note:**\r\nI am unsure about [the tox-spectest line](https://github.com/TokTok/c-toxcore/blob/master/CMakeLists.txt#L362) and left it out for now -> should definitely live somwhere inside the build directory.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/toktok/c-toxcore/361)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/TokTok/c-toxcore/issues/comments/269502703","html_url":"https://github.com/TokTok/c-toxcore/pull/361#issuecomment-269502703","issue_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/361","id":269502703,"user":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"created_at":"2016-12-28T16:37:40Z","updated_at":"2016-12-28T16:37:40Z","body":"You can delete that spectest line. We can assume it's in `$PATH`."}}
{"actor":{"display_login":"iphydf"}}