{"action":"created","comment":{"url":"https://api.github.com/repos/cbeck88/visit_struct/pulls/comments/88080396","pull_request_review_id":8665048,"id":88080396,"diff_hunk":"@@ -141,8 +252,7 @@ struct visitable<STRUCT_NAME, void> {\n     using self_type = STRUCT_NAME;                                                                 \\\n     VISIT_STRUCT_PP_MAP(VISIT_STRUCT_MEMBER_HELPER_TYPE, __VA_ARGS__)                              \\\n   }                                                                                                \\\n-                                                                                                   \\\n-  static constexpr bool value = true;                                                              \\\n+  static VISIT_STRUCT_CONSTEXPR const bool value = true;                                           \\","path":"include/visit_struct/visit_struct.hpp","position":131,"original_position":131,"commit_id":"75c48167e4c0c2e892cdd5148f374cfc141fe485","original_commit_id":"75c48167e4c0c2e892cdd5148f374cfc141fe485","user":{"login":"Jarod42","id":418006,"avatar_url":"https://avatars.githubusercontent.com/u/418006?v=3","gravatar_id":"","url":"https://api.github.com/users/Jarod42","html_url":"https://github.com/Jarod42","followers_url":"https://api.github.com/users/Jarod42/followers","following_url":"https://api.github.com/users/Jarod42/following{/other_user}","gists_url":"https://api.github.com/users/Jarod42/gists{/gist_id}","starred_url":"https://api.github.com/users/Jarod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jarod42/subscriptions","organizations_url":"https://api.github.com/users/Jarod42/orgs","repos_url":"https://api.github.com/users/Jarod42/repos","events_url":"https://api.github.com/users/Jarod42/events{/privacy}","received_events_url":"https://api.github.com/users/Jarod42/received_events","type":"User","site_admin":false},"body":"I tested your version, and with fixes for `constexpr` it's working for msvc2013 :-)\r\nNote that I had also used python to generated the macro :).\r\n`VISIT_STRUCT_CXX11_CONSTEXPR` or similar might be good to support msvc2013.\r\n\r\nYou may close the PR.\r\n","created_at":"2016-11-15T18:25:20Z","updated_at":"2016-11-15T18:25:20Z","html_url":"https://github.com/cbeck88/visit_struct/pull/5#discussion_r88080396","pull_request_url":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/cbeck88/visit_struct/pulls/comments/88080396"},"html":{"href":"https://github.com/cbeck88/visit_struct/pull/5#discussion_r88080396"},"pull_request":{"href":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5","id":93628410,"html_url":"https://github.com/cbeck88/visit_struct/pull/5","diff_url":"https://github.com/cbeck88/visit_struct/pull/5.diff","patch_url":"https://github.com/cbeck88/visit_struct/pull/5.patch","issue_url":"https://api.github.com/repos/cbeck88/visit_struct/issues/5","number":5,"state":"open","locked":false,"title":"Work-around for msvc (up to 69 args)","user":{"login":"Jarod42","id":418006,"avatar_url":"https://avatars.githubusercontent.com/u/418006?v=3","gravatar_id":"","url":"https://api.github.com/users/Jarod42","html_url":"https://github.com/Jarod42","followers_url":"https://api.github.com/users/Jarod42/followers","following_url":"https://api.github.com/users/Jarod42/following{/other_user}","gists_url":"https://api.github.com/users/Jarod42/gists{/gist_id}","starred_url":"https://api.github.com/users/Jarod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jarod42/subscriptions","organizations_url":"https://api.github.com/users/Jarod42/orgs","repos_url":"https://api.github.com/users/Jarod42/repos","events_url":"https://api.github.com/users/Jarod42/events{/privacy}","received_events_url":"https://api.github.com/users/Jarod42/received_events","type":"User","site_admin":false},"body":"Work around for VISIT_STRUCT_PP_MAP with msvc.","created_at":"2016-11-14T19:15:41Z","updated_at":"2016-11-15T18:25:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfab0e6bdd8f0bd75efff809f81cc47d16e39845","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5/commits","review_comments_url":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5/comments","review_comment_url":"https://api.github.com/repos/cbeck88/visit_struct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbeck88/visit_struct/issues/5/comments","statuses_url":"https://api.github.com/repos/cbeck88/visit_struct/statuses/75c48167e4c0c2e892cdd5148f374cfc141fe485","head":{"label":"Jarod42:MsvcFix","ref":"MsvcFix","sha":"75c48167e4c0c2e892cdd5148f374cfc141fe485","user":{"login":"Jarod42","id":418006,"avatar_url":"https://avatars.githubusercontent.com/u/418006?v=3","gravatar_id":"","url":"https://api.github.com/users/Jarod42","html_url":"https://github.com/Jarod42","followers_url":"https://api.github.com/users/Jarod42/followers","following_url":"https://api.github.com/users/Jarod42/following{/other_user}","gists_url":"https://api.github.com/users/Jarod42/gists{/gist_id}","starred_url":"https://api.github.com/users/Jarod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jarod42/subscriptions","organizations_url":"https://api.github.com/users/Jarod42/orgs","repos_url":"https://api.github.com/users/Jarod42/repos","events_url":"https://api.github.com/users/Jarod42/events{/privacy}","received_events_url":"https://api.github.com/users/Jarod42/received_events","type":"User","site_admin":false},"repo":{"id":73115243,"name":"visit_struct","full_name":"Jarod42/visit_struct","owner":{"login":"Jarod42","id":418006,"avatar_url":"https://avatars.githubusercontent.com/u/418006?v=3","gravatar_id":"","url":"https://api.github.com/users/Jarod42","html_url":"https://github.com/Jarod42","followers_url":"https://api.github.com/users/Jarod42/followers","following_url":"https://api.github.com/users/Jarod42/following{/other_user}","gists_url":"https://api.github.com/users/Jarod42/gists{/gist_id}","starred_url":"https://api.github.com/users/Jarod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jarod42/subscriptions","organizations_url":"https://api.github.com/users/Jarod42/orgs","repos_url":"https://api.github.com/users/Jarod42/repos","events_url":"https://api.github.com/users/Jarod42/events{/privacy}","received_events_url":"https://api.github.com/users/Jarod42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jarod42/visit_struct","description":"A miniature reflection library for C++11","fork":true,"url":"https://api.github.com/repos/Jarod42/visit_struct","forks_url":"https://api.github.com/repos/Jarod42/visit_struct/forks","keys_url":"https://api.github.com/repos/Jarod42/visit_struct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jarod42/visit_struct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jarod42/visit_struct/teams","hooks_url":"https://api.github.com/repos/Jarod42/visit_struct/hooks","issue_events_url":"https://api.github.com/repos/Jarod42/visit_struct/issues/events{/number}","events_url":"https://api.github.com/repos/Jarod42/visit_struct/events","assignees_url":"https://api.github.com/repos/Jarod42/visit_struct/assignees{/user}","branches_url":"https://api.github.com/repos/Jarod42/visit_struct/branches{/branch}","tags_url":"https://api.github.com/repos/Jarod42/visit_struct/tags","blobs_url":"https://api.github.com/repos/Jarod42/visit_struct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jarod42/visit_struct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jarod42/visit_struct/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jarod42/visit_struct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jarod42/visit_struct/statuses/{sha}","languages_url":"https://api.github.com/repos/Jarod42/visit_struct/languages","stargazers_url":"https://api.github.com/repos/Jarod42/visit_struct/stargazers","contributors_url":"https://api.github.com/repos/Jarod42/visit_struct/contributors","subscribers_url":"https://api.github.com/repos/Jarod42/visit_struct/subscribers","subscription_url":"https://api.github.com/repos/Jarod42/visit_struct/subscription","commits_url":"https://api.github.com/repos/Jarod42/visit_struct/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jarod42/visit_struct/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jarod42/visit_struct/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jarod42/visit_struct/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jarod42/visit_struct/contents/{+path}","compare_url":"https://api.github.com/repos/Jarod42/visit_struct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jarod42/visit_struct/merges","archive_url":"https://api.github.com/repos/Jarod42/visit_struct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jarod42/visit_struct/downloads","issues_url":"https://api.github.com/repos/Jarod42/visit_struct/issues{/number}","pulls_url":"https://api.github.com/repos/Jarod42/visit_struct/pulls{/number}","milestones_url":"https://api.github.com/repos/Jarod42/visit_struct/milestones{/number}","notifications_url":"https://api.github.com/repos/Jarod42/visit_struct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jarod42/visit_struct/labels{/name}","releases_url":"https://api.github.com/repos/Jarod42/visit_struct/releases{/id}","deployments_url":"https://api.github.com/repos/Jarod42/visit_struct/deployments","created_at":"2016-11-07T19:54:28Z","updated_at":"2016-11-07T19:54:30Z","pushed_at":"2016-11-14T19:11:43Z","git_url":"git://github.com/Jarod42/visit_struct.git","ssh_url":"git@github.com:Jarod42/visit_struct.git","clone_url":"https://github.com/Jarod42/visit_struct.git","svn_url":"https://github.com/Jarod42/visit_struct","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbeck88:master","ref":"master","sha":"ed287ad435cb91c0be0d4d822323a923cf3799ae","user":{"login":"cbeck88","id":5683852,"avatar_url":"https://avatars.githubusercontent.com/u/5683852?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeck88","html_url":"https://github.com/cbeck88","followers_url":"https://api.github.com/users/cbeck88/followers","following_url":"https://api.github.com/users/cbeck88/following{/other_user}","gists_url":"https://api.github.com/users/cbeck88/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeck88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeck88/subscriptions","organizations_url":"https://api.github.com/users/cbeck88/orgs","repos_url":"https://api.github.com/users/cbeck88/repos","events_url":"https://api.github.com/users/cbeck88/events{/privacy}","received_events_url":"https://api.github.com/users/cbeck88/received_events","type":"User","site_admin":false},"repo":{"id":61765239,"name":"visit_struct","full_name":"cbeck88/visit_struct","owner":{"login":"cbeck88","id":5683852,"avatar_url":"https://avatars.githubusercontent.com/u/5683852?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeck88","html_url":"https://github.com/cbeck88","followers_url":"https://api.github.com/users/cbeck88/followers","following_url":"https://api.github.com/users/cbeck88/following{/other_user}","gists_url":"https://api.github.com/users/cbeck88/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeck88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeck88/subscriptions","organizations_url":"https://api.github.com/users/cbeck88/orgs","repos_url":"https://api.github.com/users/cbeck88/repos","events_url":"https://api.github.com/users/cbeck88/events{/privacy}","received_events_url":"https://api.github.com/users/cbeck88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbeck88/visit_struct","description":"A miniature reflection library for C++11","fork":false,"url":"https://api.github.com/repos/cbeck88/visit_struct","forks_url":"https://api.github.com/repos/cbeck88/visit_struct/forks","keys_url":"https://api.github.com/repos/cbeck88/visit_struct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeck88/visit_struct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeck88/visit_struct/teams","hooks_url":"https://api.github.com/repos/cbeck88/visit_struct/hooks","issue_events_url":"https://api.github.com/repos/cbeck88/visit_struct/issues/events{/number}","events_url":"https://api.github.com/repos/cbeck88/visit_struct/events","assignees_url":"https://api.github.com/repos/cbeck88/visit_struct/assignees{/user}","branches_url":"https://api.github.com/repos/cbeck88/visit_struct/branches{/branch}","tags_url":"https://api.github.com/repos/cbeck88/visit_struct/tags","blobs_url":"https://api.github.com/repos/cbeck88/visit_struct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeck88/visit_struct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeck88/visit_struct/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeck88/visit_struct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeck88/visit_struct/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeck88/visit_struct/languages","stargazers_url":"https://api.github.com/repos/cbeck88/visit_struct/stargazers","contributors_url":"https://api.github.com/repos/cbeck88/visit_struct/contributors","subscribers_url":"https://api.github.com/repos/cbeck88/visit_struct/subscribers","subscription_url":"https://api.github.com/repos/cbeck88/visit_struct/subscription","commits_url":"https://api.github.com/repos/cbeck88/visit_struct/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeck88/visit_struct/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeck88/visit_struct/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeck88/visit_struct/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeck88/visit_struct/contents/{+path}","compare_url":"https://api.github.com/repos/cbeck88/visit_struct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeck88/visit_struct/merges","archive_url":"https://api.github.com/repos/cbeck88/visit_struct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeck88/visit_struct/downloads","issues_url":"https://api.github.com/repos/cbeck88/visit_struct/issues{/number}","pulls_url":"https://api.github.com/repos/cbeck88/visit_struct/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeck88/visit_struct/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeck88/visit_struct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeck88/visit_struct/labels{/name}","releases_url":"https://api.github.com/repos/cbeck88/visit_struct/releases{/id}","deployments_url":"https://api.github.com/repos/cbeck88/visit_struct/deployments","created_at":"2016-06-23T02:03:02Z","updated_at":"2016-10-31T09:43:56Z","pushed_at":"2016-11-15T13:12:50Z","git_url":"git://github.com/cbeck88/visit_struct.git","ssh_url":"git@github.com:cbeck88/visit_struct.git","clone_url":"https://github.com/cbeck88/visit_struct.git","svn_url":"https://github.com/cbeck88/visit_struct","homepage":null,"size":83,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5"},"html":{"href":"https://github.com/cbeck88/visit_struct/pull/5"},"issue":{"href":"https://api.github.com/repos/cbeck88/visit_struct/issues/5"},"comments":{"href":"https://api.github.com/repos/cbeck88/visit_struct/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/cbeck88/visit_struct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbeck88/visit_struct/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/cbeck88/visit_struct/statuses/75c48167e4c0c2e892cdd5148f374cfc141fe485"}}}}
{"actor":{"display_login":"Jarod42"}}