{"action":"created","comment":{"url":"https://api.github.com/repos/cs50/lib50-cpp/pulls/comments/92495971","pull_request_review_id":13012962,"id":92495971,"diff_hunk":"@@ -45,28 +111,90 @@ float get_float(void)\n int get_int(void)\n {\n     // TODO\n-    return 0;\n+    while (true)\n+\t{\n+\t\tconst char* local = get_string();\n+\t\tstatic long tmp; // long, since stoi in not c++99 compatib","path":"src/cs50.cpp","position":116,"original_position":116,"commit_id":"25828a587deaf2bddb9848023d8dc133762d58e5","original_commit_id":"25828a587deaf2bddb9848023d8dc133762d58e5","user":{"login":"AndrejPetelin","id":6455997,"avatar_url":"https://avatars.githubusercontent.com/u/6455997?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrejPetelin","html_url":"https://github.com/AndrejPetelin","followers_url":"https://api.github.com/users/AndrejPetelin/followers","following_url":"https://api.github.com/users/AndrejPetelin/following{/other_user}","gists_url":"https://api.github.com/users/AndrejPetelin/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrejPetelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrejPetelin/subscriptions","organizations_url":"https://api.github.com/users/AndrejPetelin/orgs","repos_url":"https://api.github.com/users/AndrejPetelin/repos","events_url":"https://api.github.com/users/AndrejPetelin/events{/privacy}","received_events_url":"https://api.github.com/users/AndrejPetelin/received_events","type":"User","site_admin":false},"body":"My proposal is here: #4 ","created_at":"2016-12-14T21:44:03Z","updated_at":"2016-12-14T21:44:03Z","html_url":"https://github.com/cs50/lib50-cpp/pull/10#discussion_r92495971","pull_request_url":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/cs50/lib50-cpp/pulls/comments/92495971"},"html":{"href":"https://github.com/cs50/lib50-cpp/pull/10#discussion_r92495971"},"pull_request":{"href":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10","id":97878466,"html_url":"https://github.com/cs50/lib50-cpp/pull/10","diff_url":"https://github.com/cs50/lib50-cpp/pull/10.diff","patch_url":"https://github.com/cs50/lib50-cpp/pull/10.patch","issue_url":"https://api.github.com/repos/cs50/lib50-cpp/issues/10","number":10,"state":"open","locked":false,"title":"Proposal","user":{"login":"IvanJasenov","id":7082127,"avatar_url":"https://avatars.githubusercontent.com/u/7082127?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanJasenov","html_url":"https://github.com/IvanJasenov","followers_url":"https://api.github.com/users/IvanJasenov/followers","following_url":"https://api.github.com/users/IvanJasenov/following{/other_user}","gists_url":"https://api.github.com/users/IvanJasenov/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanJasenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanJasenov/subscriptions","organizations_url":"https://api.github.com/users/IvanJasenov/orgs","repos_url":"https://api.github.com/users/IvanJasenov/repos","events_url":"https://api.github.com/users/IvanJasenov/events{/privacy}","received_events_url":"https://api.github.com/users/IvanJasenov/received_events","type":"User","site_admin":false},"body":"Here I didn't go with reinventing the wheel, relied on lib50-c as the backbone.\r\nWhitespace cut-off is carried in get_string method.\r\nI've had in mind the restriction of C++99 all the time.\r\nWant to hear if this design passes the bar. If so, GC and some other features which will improve the robustness can be easily added later on. \r\n\r\n-Ivan","created_at":"2016-12-14T02:55:34Z","updated_at":"2016-12-14T21:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51ef27329d615b91aac220e0594acec811173946","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10/commits","review_comments_url":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10/comments","review_comment_url":"https://api.github.com/repos/cs50/lib50-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cs50/lib50-cpp/issues/10/comments","statuses_url":"https://api.github.com/repos/cs50/lib50-cpp/statuses/25828a587deaf2bddb9848023d8dc133762d58e5","head":{"label":"IvanJasenov:patch-2","ref":"patch-2","sha":"25828a587deaf2bddb9848023d8dc133762d58e5","user":{"login":"IvanJasenov","id":7082127,"avatar_url":"https://avatars.githubusercontent.com/u/7082127?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanJasenov","html_url":"https://github.com/IvanJasenov","followers_url":"https://api.github.com/users/IvanJasenov/followers","following_url":"https://api.github.com/users/IvanJasenov/following{/other_user}","gists_url":"https://api.github.com/users/IvanJasenov/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanJasenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanJasenov/subscriptions","organizations_url":"https://api.github.com/users/IvanJasenov/orgs","repos_url":"https://api.github.com/users/IvanJasenov/repos","events_url":"https://api.github.com/users/IvanJasenov/events{/privacy}","received_events_url":"https://api.github.com/users/IvanJasenov/received_events","type":"User","site_admin":false},"repo":{"id":75245881,"name":"lib50-cpp","full_name":"IvanJasenov/lib50-cpp","owner":{"login":"IvanJasenov","id":7082127,"avatar_url":"https://avatars.githubusercontent.com/u/7082127?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanJasenov","html_url":"https://github.com/IvanJasenov","followers_url":"https://api.github.com/users/IvanJasenov/followers","following_url":"https://api.github.com/users/IvanJasenov/following{/other_user}","gists_url":"https://api.github.com/users/IvanJasenov/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanJasenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanJasenov/subscriptions","organizations_url":"https://api.github.com/users/IvanJasenov/orgs","repos_url":"https://api.github.com/users/IvanJasenov/repos","events_url":"https://api.github.com/users/IvanJasenov/events{/privacy}","received_events_url":"https://api.github.com/users/IvanJasenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IvanJasenov/lib50-cpp","description":"This is CS50's library for C++.","fork":true,"url":"https://api.github.com/repos/IvanJasenov/lib50-cpp","forks_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/forks","keys_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/teams","hooks_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/hooks","issue_events_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/events","assignees_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/tags","blobs_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/languages","stargazers_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/stargazers","contributors_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/contributors","subscribers_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/subscribers","subscription_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/subscription","commits_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/merges","archive_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/downloads","issues_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/labels{/name}","releases_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/IvanJasenov/lib50-cpp/deployments","created_at":"2016-12-01T02:11:11Z","updated_at":"2016-12-01T02:11:12Z","pushed_at":"2016-12-14T20:54:14Z","git_url":"git://github.com/IvanJasenov/lib50-cpp.git","ssh_url":"git@github.com:IvanJasenov/lib50-cpp.git","clone_url":"https://github.com/IvanJasenov/lib50-cpp.git","svn_url":"https://github.com/IvanJasenov/lib50-cpp","homepage":"https://cs50.harvard.edu/","size":5,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cs50:master","ref":"master","sha":"bfc39c90f9e9fb1f0544a4ce183a33d86d69ca59","user":{"login":"cs50","id":788676,"avatar_url":"https://avatars.githubusercontent.com/u/788676?v=3","gravatar_id":"","url":"https://api.github.com/users/cs50","html_url":"https://github.com/cs50","followers_url":"https://api.github.com/users/cs50/followers","following_url":"https://api.github.com/users/cs50/following{/other_user}","gists_url":"https://api.github.com/users/cs50/gists{/gist_id}","starred_url":"https://api.github.com/users/cs50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs50/subscriptions","organizations_url":"https://api.github.com/users/cs50/orgs","repos_url":"https://api.github.com/users/cs50/repos","events_url":"https://api.github.com/users/cs50/events{/privacy}","received_events_url":"https://api.github.com/users/cs50/received_events","type":"Organization","site_admin":false},"repo":{"id":69903183,"name":"lib50-cpp","full_name":"cs50/lib50-cpp","owner":{"login":"cs50","id":788676,"avatar_url":"https://avatars.githubusercontent.com/u/788676?v=3","gravatar_id":"","url":"https://api.github.com/users/cs50","html_url":"https://github.com/cs50","followers_url":"https://api.github.com/users/cs50/followers","following_url":"https://api.github.com/users/cs50/following{/other_user}","gists_url":"https://api.github.com/users/cs50/gists{/gist_id}","starred_url":"https://api.github.com/users/cs50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs50/subscriptions","organizations_url":"https://api.github.com/users/cs50/orgs","repos_url":"https://api.github.com/users/cs50/repos","events_url":"https://api.github.com/users/cs50/events{/privacy}","received_events_url":"https://api.github.com/users/cs50/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cs50/lib50-cpp","description":"This is CS50's library for C++.","fork":false,"url":"https://api.github.com/repos/cs50/lib50-cpp","forks_url":"https://api.github.com/repos/cs50/lib50-cpp/forks","keys_url":"https://api.github.com/repos/cs50/lib50-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs50/lib50-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs50/lib50-cpp/teams","hooks_url":"https://api.github.com/repos/cs50/lib50-cpp/hooks","issue_events_url":"https://api.github.com/repos/cs50/lib50-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/cs50/lib50-cpp/events","assignees_url":"https://api.github.com/repos/cs50/lib50-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/cs50/lib50-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/cs50/lib50-cpp/tags","blobs_url":"https://api.github.com/repos/cs50/lib50-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs50/lib50-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs50/lib50-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs50/lib50-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs50/lib50-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/cs50/lib50-cpp/languages","stargazers_url":"https://api.github.com/repos/cs50/lib50-cpp/stargazers","contributors_url":"https://api.github.com/repos/cs50/lib50-cpp/contributors","subscribers_url":"https://api.github.com/repos/cs50/lib50-cpp/subscribers","subscription_url":"https://api.github.com/repos/cs50/lib50-cpp/subscription","commits_url":"https://api.github.com/repos/cs50/lib50-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs50/lib50-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs50/lib50-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs50/lib50-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cs50/lib50-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/cs50/lib50-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs50/lib50-cpp/merges","archive_url":"https://api.github.com/repos/cs50/lib50-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs50/lib50-cpp/downloads","issues_url":"https://api.github.com/repos/cs50/lib50-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/cs50/lib50-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/cs50/lib50-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/cs50/lib50-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs50/lib50-cpp/labels{/name}","releases_url":"https://api.github.com/repos/cs50/lib50-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/cs50/lib50-cpp/deployments","created_at":"2016-10-03T19:25:19Z","updated_at":"2016-10-06T22:44:02Z","pushed_at":"2016-12-14T20:54:14Z","git_url":"git://github.com/cs50/lib50-cpp.git","ssh_url":"git@github.com:cs50/lib50-cpp.git","clone_url":"https://github.com/cs50/lib50-cpp.git","svn_url":"https://github.com/cs50/lib50-cpp","homepage":"https://cs50.harvard.edu/","size":1,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10"},"html":{"href":"https://github.com/cs50/lib50-cpp/pull/10"},"issue":{"href":"https://api.github.com/repos/cs50/lib50-cpp/issues/10"},"comments":{"href":"https://api.github.com/repos/cs50/lib50-cpp/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/cs50/lib50-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cs50/lib50-cpp/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/cs50/lib50-cpp/statuses/25828a587deaf2bddb9848023d8dc133762d58e5"}}}}
{"actor":{"display_login":"AndrejPetelin"}}