{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/79287204","id":79287204,"diff_hunk":"@@ -259,9 +259,9 @@ zfs_is_mountable(zfs_handle_t *zhp, char *buf, size_t buflen,\n \n /*\n  * The filesystem is mounted by invoking the system mount utility rather\n- * than by the system call mount(2).  This ensures that the /etc/mtab\n+ * than by the system call mount(2).  This ensures that the /proc/self/mounts","path":"lib/libzfs/libzfs_mount.c","position":5,"original_position":5,"commit_id":"dc40597948925586e51cf17374ac08aec017d817","original_commit_id":"dc40597948925586e51cf17374ac08aec017d817","user":{"login":"rlaager","id":113383,"avatar_url":"https://avatars.githubusercontent.com/u/113383?v=3","gravatar_id":"","url":"https://api.github.com/users/rlaager","html_url":"https://github.com/rlaager","followers_url":"https://api.github.com/users/rlaager/followers","following_url":"https://api.github.com/users/rlaager/following{/other_user}","gists_url":"https://api.github.com/users/rlaager/gists{/gist_id}","starred_url":"https://api.github.com/users/rlaager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlaager/subscriptions","organizations_url":"https://api.github.com/users/rlaager/orgs","repos_url":"https://api.github.com/users/rlaager/repos","events_url":"https://api.github.com/users/rlaager/events{/privacy}","received_events_url":"https://api.github.com/users/rlaager/received_events","type":"User","site_admin":false},"body":"This comment is now wrong. We do not lock /proc/self/mounts for an update.","created_at":"2016-09-17T16:27:01Z","updated_at":"2016-09-17T16:27:01Z","html_url":"https://github.com/zfsonlinux/zfs/pull/5029#discussion_r79287204","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/79287204"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5029#discussion_r79287204"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029","id":82921579,"html_url":"https://github.com/zfsonlinux/zfs/pull/5029","diff_url":"https://github.com/zfsonlinux/zfs/pull/5029.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/5029.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5029","number":5029,"state":"open","locked":false,"title":"Change /etc/mtab to /proc/self/mounts","user":{"login":"slashdd","id":20820594,"avatar_url":"https://avatars.githubusercontent.com/u/20820594?v=3","gravatar_id":"","url":"https://api.github.com/users/slashdd","html_url":"https://github.com/slashdd","followers_url":"https://api.github.com/users/slashdd/followers","following_url":"https://api.github.com/users/slashdd/following{/other_user}","gists_url":"https://api.github.com/users/slashdd/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdd/subscriptions","organizations_url":"https://api.github.com/users/slashdd/orgs","repos_url":"https://api.github.com/users/slashdd/repos","events_url":"https://api.github.com/users/slashdd/events{/privacy}","received_events_url":"https://api.github.com/users/slashdd/received_events","type":"User","site_admin":false},"body":"Misleading error message \"The /dev/zfs device is missing and must be created.\", if /etc/mtab is missing.\r\n\r\nSigned-off-by: Eric Desrochers <eric.desrochers@canonical.com>\r\nCloses #4680","created_at":"2016-08-26T17:06:04Z","updated_at":"2016-09-17T16:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"526f4e44ac6bdeb9c6fe18d4a726994bc1479449","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zfsonlinux/zfs/milestones/11","html_url":"https://github.com/zfsonlinux/zfs/milestones/0.7.0","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones/11/labels","id":7013,"number":11,"title":"0.7.0","description":"ZFS on Linux v0.7.0 - Memory management\r\n\r\n","creator":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":292,"state":"open","created_at":"2011-05-03T17:38:46Z","updated_at":"2016-09-17T09:45:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/5029/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/dc40597948925586e51cf17374ac08aec017d817","head":{"label":"slashdd:openzfs-4680","ref":"openzfs-4680","sha":"dc40597948925586e51cf17374ac08aec017d817","user":{"login":"slashdd","id":20820594,"avatar_url":"https://avatars.githubusercontent.com/u/20820594?v=3","gravatar_id":"","url":"https://api.github.com/users/slashdd","html_url":"https://github.com/slashdd","followers_url":"https://api.github.com/users/slashdd/followers","following_url":"https://api.github.com/users/slashdd/following{/other_user}","gists_url":"https://api.github.com/users/slashdd/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdd/subscriptions","organizations_url":"https://api.github.com/users/slashdd/orgs","repos_url":"https://api.github.com/users/slashdd/repos","events_url":"https://api.github.com/users/slashdd/events{/privacy}","received_events_url":"https://api.github.com/users/slashdd/received_events","type":"User","site_admin":false},"repo":{"id":66656057,"name":"zfs","full_name":"slashdd/zfs","owner":{"login":"slashdd","id":20820594,"avatar_url":"https://avatars.githubusercontent.com/u/20820594?v=3","gravatar_id":"","url":"https://api.github.com/users/slashdd","html_url":"https://github.com/slashdd","followers_url":"https://api.github.com/users/slashdd/followers","following_url":"https://api.github.com/users/slashdd/following{/other_user}","gists_url":"https://api.github.com/users/slashdd/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdd/subscriptions","organizations_url":"https://api.github.com/users/slashdd/orgs","repos_url":"https://api.github.com/users/slashdd/repos","events_url":"https://api.github.com/users/slashdd/events{/privacy}","received_events_url":"https://api.github.com/users/slashdd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slashdd/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/slashdd/zfs","forks_url":"https://api.github.com/repos/slashdd/zfs/forks","keys_url":"https://api.github.com/repos/slashdd/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slashdd/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slashdd/zfs/teams","hooks_url":"https://api.github.com/repos/slashdd/zfs/hooks","issue_events_url":"https://api.github.com/repos/slashdd/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/slashdd/zfs/events","assignees_url":"https://api.github.com/repos/slashdd/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/slashdd/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/slashdd/zfs/tags","blobs_url":"https://api.github.com/repos/slashdd/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slashdd/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slashdd/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/slashdd/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slashdd/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/slashdd/zfs/languages","stargazers_url":"https://api.github.com/repos/slashdd/zfs/stargazers","contributors_url":"https://api.github.com/repos/slashdd/zfs/contributors","subscribers_url":"https://api.github.com/repos/slashdd/zfs/subscribers","subscription_url":"https://api.github.com/repos/slashdd/zfs/subscription","commits_url":"https://api.github.com/repos/slashdd/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/slashdd/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/slashdd/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/slashdd/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/slashdd/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/slashdd/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slashdd/zfs/merges","archive_url":"https://api.github.com/repos/slashdd/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slashdd/zfs/downloads","issues_url":"https://api.github.com/repos/slashdd/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/slashdd/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/slashdd/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/slashdd/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slashdd/zfs/labels{/name}","releases_url":"https://api.github.com/repos/slashdd/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/slashdd/zfs/deployments","created_at":"2016-08-26T14:54:54Z","updated_at":"2016-08-26T14:55:02Z","pushed_at":"2016-09-13T19:29:16Z","git_url":"git://github.com/slashdd/zfs.git","ssh_url":"git@github.com:slashdd/zfs.git","clone_url":"https://github.com/slashdd/zfs.git","svn_url":"https://github.com/slashdd/zfs","homepage":"http://zfsonlinux.org/","size":32498,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"87f9371aefca857e7091dfdee3ec2d36b0de54c4","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-09-17T12:37:42Z","pushed_at":"2016-09-17T06:23:23Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":59770,"stargazers_count":2054,"watchers_count":2054,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":509,"mirror_url":null,"open_issues_count":1052,"forks":509,"open_issues":1052,"watchers":2054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/5029"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5029"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/5029/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/5029/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/dc40597948925586e51cf17374ac08aec017d817"}}}}
{"actor":{"display_login":"rlaager"}}