{"action":"created","issue":{"url":"https://api.github.com/repos/CottageLabs/api/issues/14","repository_url":"https://api.github.com/repos/CottageLabs/api","labels_url":"https://api.github.com/repos/CottageLabs/api/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/CottageLabs/api/issues/14/comments","events_url":"https://api.github.com/repos/CottageLabs/api/issues/14/events","html_url":"https://github.com/CottageLabs/api/pull/14","id":177252297,"number":14,"title":"stop using xml2txt until an alternative is found, it is affecting too many licences","user":{"login":"emanuil-tolev","id":1190172,"avatar_url":"https://avatars.githubusercontent.com/u/1190172?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuil-tolev","html_url":"https://github.com/emanuil-tolev","followers_url":"https://api.github.com/users/emanuil-tolev/followers","following_url":"https://api.github.com/users/emanuil-tolev/following{/other_user}","gists_url":"https://api.github.com/users/emanuil-tolev/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuil-tolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuil-tolev/subscriptions","organizations_url":"https://api.github.com/users/emanuil-tolev/orgs","repos_url":"https://api.github.com/users/emanuil-tolev/repos","events_url":"https://api.github.com/users/emanuil-tolev/events{/privacy}","received_events_url":"https://api.github.com/users/emanuil-tolev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-15T18:26:41Z","updated_at":"2016-09-15T18:27:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CottageLabs/api/pulls/14","html_url":"https://github.com/CottageLabs/api/pull/14","diff_url":"https://github.com/CottageLabs/api/pull/14.diff","patch_url":"https://github.com/CottageLabs/api/pull/14.patch"},"body":"See http://github.com/CottageLabs/LanternPM/issues/114 for details (and now the extra detail that xml2txt appears to just silently swallow all the content on occasion - though appears to be doing it quite a lot on live).\r\n\r\nThis is a really simplistic approach, but on the other hand it should be quite good at detecting licences. I also don't think leaving the XML tags in will result in an increase in false positives - licence statements are rarely similar to XML tags. I can't see any significant drawbacks to doing this simple approach.\r\n\r\nNote this is affecting HTML licence detection as well, since xml2txt is invoked for HTML too. In previous cases it appeared to leave the HTML untouched while munging the XML. But now for this article (and others):\r\n\r\n```\r\nPMCID,PMID\r\nPMC4936516,27398388\r\n```\r\n\r\nit actually just returns `null` when both XML and HTML pass through it, effectively disabling all licence detection.\r\n\r\nI've been getting grilled by Wellcome all week about it and thought the recent EPMC downtime might be responsible, but it isn't, this reproducibly doesn't work for a large number of articles while EPMC is up and has the right data."},"comment":{"url":"https://api.github.com/repos/CottageLabs/api/issues/comments/247410768","html_url":"https://github.com/CottageLabs/api/pull/14#issuecomment-247410768","issue_url":"https://api.github.com/repos/CottageLabs/api/issues/14","id":247410768,"user":{"login":"emanuil-tolev","id":1190172,"avatar_url":"https://avatars.githubusercontent.com/u/1190172?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuil-tolev","html_url":"https://github.com/emanuil-tolev","followers_url":"https://api.github.com/users/emanuil-tolev/followers","following_url":"https://api.github.com/users/emanuil-tolev/following{/other_user}","gists_url":"https://api.github.com/users/emanuil-tolev/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuil-tolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuil-tolev/subscriptions","organizations_url":"https://api.github.com/users/emanuil-tolev/orgs","repos_url":"https://api.github.com/users/emanuil-tolev/repos","events_url":"https://api.github.com/users/emanuil-tolev/events{/privacy}","received_events_url":"https://api.github.com/users/emanuil-tolev/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T18:27:39Z","updated_at":"2016-09-15T18:27:39Z","body":"Minor correction: https://github.com/CottageLabs/LanternPM/issues/114 "}}
{"actor":{"display_login":"emanuil-tolev"}}