{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/comments/53611982","id":53611982,"diff_hunk":"@@ -0,0 +1,103 @@\n+/*\n+ * Copyright 2016 HM Revenue & Customs\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package unit.connectors\n+\n+import java.net.SocketException\n+\n+import com.codahale.metrics.{Counter, MetricRegistry}\n+import connectors.{CardPaymentHistoryConnector, Commission}\n+import metrics.ConnectorMetrics\n+import org.mockito.Matchers\n+import org.mockito.Mockito._\n+import org.scalatest.concurrent.ScalaFutures\n+import org.scalatest.mock.MockitoSugar\n+import uk.gov.hmrc.play.http.{BadRequestException, HeaderCarrier, HttpGet}\n+import uk.gov.hmrc.play.test.UnitSpec\n+\n+import scala.concurrent.{Await, Future}\n+\n+class CardPaymentHistoryConnectorSpec extends UnitSpec  with MockitoSugar {","path":"test/unit/connectors/CardPaymentHistoryConnectorSpec.scala","position":33,"original_position":33,"commit_id":"cec115d782a92f6aeca0acc57628a6505c5ac1f2","original_commit_id":"cec115d782a92f6aeca0acc57628a6505c5ac1f2","user":{"login":"anshulbajpai","id":291429,"avatar_url":"https://avatars.githubusercontent.com/u/291429?v=3","gravatar_id":"","url":"https://api.github.com/users/anshulbajpai","html_url":"https://github.com/anshulbajpai","followers_url":"https://api.github.com/users/anshulbajpai/followers","following_url":"https://api.github.com/users/anshulbajpai/following{/other_user}","gists_url":"https://api.github.com/users/anshulbajpai/gists{/gist_id}","starred_url":"https://api.github.com/users/anshulbajpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshulbajpai/subscriptions","organizations_url":"https://api.github.com/users/anshulbajpai/orgs","repos_url":"https://api.github.com/users/anshulbajpai/repos","events_url":"https://api.github.com/users/anshulbajpai/events{/privacy}","received_events_url":"https://api.github.com/users/anshulbajpai/received_events","type":"User","site_admin":false},"body":"I don't see assertions around returned value from this method.","created_at":"2016-02-22T11:14:49Z","updated_at":"2016-02-22T11:14:49Z","html_url":"https://github.com/hmrc/worldpay-downloader/pull/9#discussion_r53611982","pull_request_url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/comments/53611982"},"html":{"href":"https://github.com/hmrc/worldpay-downloader/pull/9#discussion_r53611982"},"pull_request":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9","id":59943481,"html_url":"https://github.com/hmrc/worldpay-downloader/pull/9","diff_url":"https://github.com/hmrc/worldpay-downloader/pull/9.diff","patch_url":"https://github.com/hmrc/worldpay-downloader/pull/9.patch","issue_url":"https://api.github.com/repos/hmrc/worldpay-downloader/issues/9","number":9,"state":"open","locked":false,"title":"[YTA-1637] Initial integration with card-payment-history. With @nigel-perkins.","user":{"login":"erasmos","id":4642370,"avatar_url":"https://avatars.githubusercontent.com/u/4642370?v=3","gravatar_id":"","url":"https://api.github.com/users/erasmos","html_url":"https://github.com/erasmos","followers_url":"https://api.github.com/users/erasmos/followers","following_url":"https://api.github.com/users/erasmos/following{/other_user}","gists_url":"https://api.github.com/users/erasmos/gists{/gist_id}","starred_url":"https://api.github.com/users/erasmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasmos/subscriptions","organizations_url":"https://api.github.com/users/erasmos/orgs","repos_url":"https://api.github.com/users/erasmos/repos","events_url":"https://api.github.com/users/erasmos/events{/privacy}","received_events_url":"https://api.github.com/users/erasmos/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-19T12:32:37Z","updated_at":"2016-02-22T11:14:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94d0d82075291d46d2e4231ac4bd3a05455c2e25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9/commits","review_comments_url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9/comments","review_comment_url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/worldpay-downloader/issues/9/comments","statuses_url":"https://api.github.com/repos/hmrc/worldpay-downloader/statuses/cec115d782a92f6aeca0acc57628a6505c5ac1f2","head":{"label":"erasmos:YTA-1637","ref":"YTA-1637","sha":"cec115d782a92f6aeca0acc57628a6505c5ac1f2","user":{"login":"erasmos","id":4642370,"avatar_url":"https://avatars.githubusercontent.com/u/4642370?v=3","gravatar_id":"","url":"https://api.github.com/users/erasmos","html_url":"https://github.com/erasmos","followers_url":"https://api.github.com/users/erasmos/followers","following_url":"https://api.github.com/users/erasmos/following{/other_user}","gists_url":"https://api.github.com/users/erasmos/gists{/gist_id}","starred_url":"https://api.github.com/users/erasmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasmos/subscriptions","organizations_url":"https://api.github.com/users/erasmos/orgs","repos_url":"https://api.github.com/users/erasmos/repos","events_url":"https://api.github.com/users/erasmos/events{/privacy}","received_events_url":"https://api.github.com/users/erasmos/received_events","type":"User","site_admin":false},"repo":{"id":51937277,"name":"worldpay-downloader","full_name":"erasmos/worldpay-downloader","owner":{"login":"erasmos","id":4642370,"avatar_url":"https://avatars.githubusercontent.com/u/4642370?v=3","gravatar_id":"","url":"https://api.github.com/users/erasmos","html_url":"https://github.com/erasmos","followers_url":"https://api.github.com/users/erasmos/followers","following_url":"https://api.github.com/users/erasmos/following{/other_user}","gists_url":"https://api.github.com/users/erasmos/gists{/gist_id}","starred_url":"https://api.github.com/users/erasmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasmos/subscriptions","organizations_url":"https://api.github.com/users/erasmos/orgs","repos_url":"https://api.github.com/users/erasmos/repos","events_url":"https://api.github.com/users/erasmos/events{/privacy}","received_events_url":"https://api.github.com/users/erasmos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erasmos/worldpay-downloader","description":"","fork":true,"url":"https://api.github.com/repos/erasmos/worldpay-downloader","forks_url":"https://api.github.com/repos/erasmos/worldpay-downloader/forks","keys_url":"https://api.github.com/repos/erasmos/worldpay-downloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erasmos/worldpay-downloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erasmos/worldpay-downloader/teams","hooks_url":"https://api.github.com/repos/erasmos/worldpay-downloader/hooks","issue_events_url":"https://api.github.com/repos/erasmos/worldpay-downloader/issues/events{/number}","events_url":"https://api.github.com/repos/erasmos/worldpay-downloader/events","assignees_url":"https://api.github.com/repos/erasmos/worldpay-downloader/assignees{/user}","branches_url":"https://api.github.com/repos/erasmos/worldpay-downloader/branches{/branch}","tags_url":"https://api.github.com/repos/erasmos/worldpay-downloader/tags","blobs_url":"https://api.github.com/repos/erasmos/worldpay-downloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erasmos/worldpay-downloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erasmos/worldpay-downloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/erasmos/worldpay-downloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erasmos/worldpay-downloader/statuses/{sha}","languages_url":"https://api.github.com/repos/erasmos/worldpay-downloader/languages","stargazers_url":"https://api.github.com/repos/erasmos/worldpay-downloader/stargazers","contributors_url":"https://api.github.com/repos/erasmos/worldpay-downloader/contributors","subscribers_url":"https://api.github.com/repos/erasmos/worldpay-downloader/subscribers","subscription_url":"https://api.github.com/repos/erasmos/worldpay-downloader/subscription","commits_url":"https://api.github.com/repos/erasmos/worldpay-downloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/erasmos/worldpay-downloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/erasmos/worldpay-downloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/erasmos/worldpay-downloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/erasmos/worldpay-downloader/contents/{+path}","compare_url":"https://api.github.com/repos/erasmos/worldpay-downloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erasmos/worldpay-downloader/merges","archive_url":"https://api.github.com/repos/erasmos/worldpay-downloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erasmos/worldpay-downloader/downloads","issues_url":"https://api.github.com/repos/erasmos/worldpay-downloader/issues{/number}","pulls_url":"https://api.github.com/repos/erasmos/worldpay-downloader/pulls{/number}","milestones_url":"https://api.github.com/repos/erasmos/worldpay-downloader/milestones{/number}","notifications_url":"https://api.github.com/repos/erasmos/worldpay-downloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erasmos/worldpay-downloader/labels{/name}","releases_url":"https://api.github.com/repos/erasmos/worldpay-downloader/releases{/id}","deployments_url":"https://api.github.com/repos/erasmos/worldpay-downloader/deployments","created_at":"2016-02-17T16:30:48Z","updated_at":"2016-02-17T16:30:48Z","pushed_at":"2016-02-19T12:32:02Z","git_url":"git://github.com/erasmos/worldpay-downloader.git","ssh_url":"git@github.com:erasmos/worldpay-downloader.git","clone_url":"https://github.com/erasmos/worldpay-downloader.git","svn_url":"https://github.com/erasmos/worldpay-downloader","homepage":null,"size":133,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"793d1600680417774cc52833ea35689a160ceadd","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":42119955,"name":"worldpay-downloader","full_name":"hmrc/worldpay-downloader","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/worldpay-downloader","description":"","fork":false,"url":"https://api.github.com/repos/hmrc/worldpay-downloader","forks_url":"https://api.github.com/repos/hmrc/worldpay-downloader/forks","keys_url":"https://api.github.com/repos/hmrc/worldpay-downloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/worldpay-downloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/worldpay-downloader/teams","hooks_url":"https://api.github.com/repos/hmrc/worldpay-downloader/hooks","issue_events_url":"https://api.github.com/repos/hmrc/worldpay-downloader/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/worldpay-downloader/events","assignees_url":"https://api.github.com/repos/hmrc/worldpay-downloader/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/worldpay-downloader/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/worldpay-downloader/tags","blobs_url":"https://api.github.com/repos/hmrc/worldpay-downloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/worldpay-downloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/worldpay-downloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/worldpay-downloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/worldpay-downloader/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/worldpay-downloader/languages","stargazers_url":"https://api.github.com/repos/hmrc/worldpay-downloader/stargazers","contributors_url":"https://api.github.com/repos/hmrc/worldpay-downloader/contributors","subscribers_url":"https://api.github.com/repos/hmrc/worldpay-downloader/subscribers","subscription_url":"https://api.github.com/repos/hmrc/worldpay-downloader/subscription","commits_url":"https://api.github.com/repos/hmrc/worldpay-downloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/worldpay-downloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/worldpay-downloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/worldpay-downloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/worldpay-downloader/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/worldpay-downloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/worldpay-downloader/merges","archive_url":"https://api.github.com/repos/hmrc/worldpay-downloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/worldpay-downloader/downloads","issues_url":"https://api.github.com/repos/hmrc/worldpay-downloader/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/worldpay-downloader/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/worldpay-downloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/worldpay-downloader/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/worldpay-downloader/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/worldpay-downloader/deployments","created_at":"2015-09-08T15:05:30Z","updated_at":"2016-02-13T08:37:54Z","pushed_at":"2016-02-19T12:32:37Z","git_url":"git://github.com/hmrc/worldpay-downloader.git","ssh_url":"git@github.com:hmrc/worldpay-downloader.git","clone_url":"https://github.com/hmrc/worldpay-downloader.git","svn_url":"https://github.com/hmrc/worldpay-downloader","homepage":null,"size":123,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9"},"html":{"href":"https://github.com/hmrc/worldpay-downloader/pull/9"},"issue":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/issues/9"},"comments":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/worldpay-downloader/statuses/cec115d782a92f6aeca0acc57628a6505c5ac1f2"}}}}