{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/18","id":55556868,"html_url":"https://github.com/defaultnamehere/defaultnamehere.github.io/pull/18","diff_url":"https://github.com/defaultnamehere/defaultnamehere.github.io/pull/18.diff","patch_url":"https://github.com/defaultnamehere/defaultnamehere.github.io/pull/18.patch","issue_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues/18","number":18,"state":"closed","locked":false,"title":"Update index.htm to fix \"a lot\" of things","user":{"login":"tvman-123","id":13202658,"avatar_url":"https://avatars.githubusercontent.com/u/13202658?v=3","gravatar_id":"","url":"https://api.github.com/users/tvman-123","html_url":"https://github.com/tvman-123","followers_url":"https://api.github.com/users/tvman-123/followers","following_url":"https://api.github.com/users/tvman-123/following{/other_user}","gists_url":"https://api.github.com/users/tvman-123/gists{/gist_id}","starred_url":"https://api.github.com/users/tvman-123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvman-123/subscriptions","organizations_url":"https://api.github.com/users/tvman-123/orgs","repos_url":"https://api.github.com/users/tvman-123/repos","events_url":"https://api.github.com/users/tvman-123/events{/privacy}","received_events_url":"https://api.github.com/users/tvman-123/received_events","type":"User","site_admin":false},"body":"--------------------------------Explaing the audio changes-------------------------------------------------\r\n\r\n\r\nIn mobile browsers autoplay doesn't work for the audio and video tag due to mobile charges. The only way to start playing audio is if the user initiates it either through a button click or something like that.\r\n\r\nRead more here: http://stackoverflow.com/a/26066844\r\n\r\nSo I made some changes that detect the user agent to see if its a mobile browser or not (see script afunction(); on line 152). If it detects that the user is using a mobile browser, it replaces the inner html with material design lite (Google's version of material design for the web), and two button, and text that states, \"Prepare Your Wallet\". One button (the one that uses material design) says \"KKKK\" which, onclick, goes to a function called WalletPrepared() (line 62). That function starts playing the audio and makes an attribute that says, onload of a random picture (line 75) to initiate WalletPrepared2() (line 109). The reason I chose, onload of a random picture, is because, I don't know how to execute another Javascript from another Javascript (I'm a newb). Anyway, what WalletPrepared2() does is, replace all of the inner html with your code. Thus, seeing lord Gaben making a bunch of deals on Steam.\r\n\r\nBut, if the user clicks the No button, on the prompt, it will goto WalletNotPrepared() (line 42). That replace the text, \"Prepare your wallet\" with \"Um, I don't think you heard me. I said, Prepare Your Wallet!!!!!!!!!!!!!\". It also removes the No button. And when the user clicks KKKK it will goto the script on line 62 and I just explained what it does above.\r\n\r\n\r\nBut if the user is on a computer, it makes a random img, onload, to go to function WalletPrepared3() (line 67). WalletPrepared3() (line 86) is the same as WalletPrepared2(). WalletPrepared3 executes WalletPrepared2 to replace the html code except on WalletPrepared3() is that it doesn't start playing, Are You Ready For A Miracle, right away.\r\n\r\n\r\nI only used secure sources (https) so that, not only will the Steam iframe load, but users can also access \"gabegaming.com\". Using \"https://gabegaming.com\", which prevents malicious stuff being loaded on old web browsers.\r\n\r\nSpeaking of older browsers, I added a fallback option between the <source tag and <audio, which uses <embed, to start playing the audio in html4 instead of html5.\r\n\r\nHTML4 ignores the <audio and <source tag, but cares about the stuff in the middle.\r\nHTML5 ignores everything in the <audio tag except <source.\r\n\r\n// Note: If the user clicks a button. The button better pointing to a JS which runs it immediately (And then that starts playing the sound if the user //is on mobile). I tried just the button pointing to a JS which replaces all of the inner html with your old version of it. But the audio still didn't work.\r\n\r\nJust some note: If the mobile user clicks the, \"KKKK\" button. The button better pointing to a JS which runs it immediately (And then that starts playing the sound if the user is on mobile). I tried just the button pointing to a JS which replaces all of the inner html with your old version of it. But the audio still didn't work.\r\n\r\n\r\n---------Explaining changes to the Steam iFrame which makes the iFrame work (well, sort of [if the user clicks some of the links while in https mode the iFrame goes blank})\r\n\r\nSO, apparently you can attack people using iFrames.\r\n\r\nRead more: http://javascript.info/tutorial/clickjacking\r\n\r\nSo they thought, hey, instead of somehow implementing a system that can detect css and iFrame attacks, lets just add an option so people who don't want their website displayed in an iFrame, they can add an html header (X-Frames-Options), which loads wayyyyy, before Javascript is downloaded and interpreted. Anyway, Steam put the X-Frames-Options to DENY and that means you can't put Steam in an iFrame. All XMLHttpRequests are blocked, except there is a flaw in the system. JsonP is not effected by XMLHttpRequest. So by Googling for about 3 hours (not exaggerating), I found a workaround.\r\n\r\nRead More: http://stackoverflow.com/a/25587483/5195963\r\n\r\nThe problem with this solution was that it requires opening an iFrame. When doing that, Chrome and other browsers error out and say you need to put the allow-same-origins flag to bypass the sandbox. I put that flag but it still didn't work. I think I read somewhere that you can set the domain to something else so it would still work, but the solution wouldn't work in Firefox, so I dismissed it. After 2 days of thinking I came up with document.write, but the problem with that, after DOM loads the page you need to use document.open to access a page. Which erases the whole html pages when running document.write with whatever content. But I still tried it, what I got was Steam in full screen. After seeing if I can somehow use the document.write api to  just add code I gave up (I can't use innerHTML because for some reason it won't recognize the \"algorithm\". So after being stuck on that for 1 day, I just gave up and said, Shrek this, I'll just create a seperate html page which gets erased with document.write to Steam and then reference that iFrame to gabegaming.com so it'll work. Also, I tried using a slow page down service which slows the page down so DOM won't finish loading, but that just leaved an empty page.\r\n\r\n\r\nOutcome=Everything Works as expected.\r\n\r\nYou can scroll and everything, but there is another problem, there isn't an unlimited page scroll like if you visited the webpage, but its better than a screenshot or just a picture. Main Point is, you can see the sales on Steam.\r\n\r\n\r\n=========================Bottom line====================\r\n\r\nI added https support, Steam iFrame, and fixed some audio issues, including html4 and on mobile.\r\n\r\nNote: I didn't use an html4 browser but when I get a chance I'll test it.\r\n\r\n\r\n\r\n\r\nP.S. If you look OGre the code, you can see all my comments explaining what it does\r\n\r\nP.P.S. Also, I tested this on my computer using the horrible browser (Microsoft Edge), Chrome, and Firefox, on my phone using Chrome, and I sent my friend a link to the sample page I uploaded to github to see if the http/https fix would work. Everything works as expected. So please except this file change because it took me about 2 months.\r\n\r\nP.P.P.S. The audio loops on both mobile and desktop.\r\n\r\nP.P.P.P.S. I used detectmobilebrowsers.com and Stackoverflow. I don't have a tablet. But this should work on it to.\r\n\r\n\r\nExample page I uploaded: http://rawgit.com/tvman-123/defaultnamehere.github.io/master/Gabegaming_With_HTML.html and the crappy https version because Steam wasn't met to be displayed that way\r\n\r\n https://rawgit.com/tvman-123/defaultnamehere.github.io/master/Gabegaming_With_HTML.html\r\n\r\n\r\nP.P.P.P.P.S.: If you can see deleted commants on GIthub, lol, I'm sorry I said that adding https to store.steampowered will fix it. The only reason I said that as I downloaded a plugin that removed the X-Frames-Option header, but at the same time I added the s to htp and it worked. Sooooooo sad....","created_at":"2016-01-10T03:21:02Z","updated_at":"2016-01-13T06:15:46Z","closed_at":"2016-01-13T06:15:46Z","merged_at":"2016-01-13T06:15:46Z","merge_commit_sha":"1b2c7b45ab7e15339ea9c1e1e37bb099d189b805","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/18/commits","review_comments_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/18/comments","review_comment_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues/18/comments","statuses_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/statuses/de9ddf1522e3ca35b92ed3ca9389339b74ffa7ec","head":{"label":"tvman-123:patch-1","ref":"patch-1","sha":"de9ddf1522e3ca35b92ed3ca9389339b74ffa7ec","user":{"login":"tvman-123","id":13202658,"avatar_url":"https://avatars.githubusercontent.com/u/13202658?v=3","gravatar_id":"","url":"https://api.github.com/users/tvman-123","html_url":"https://github.com/tvman-123","followers_url":"https://api.github.com/users/tvman-123/followers","following_url":"https://api.github.com/users/tvman-123/following{/other_user}","gists_url":"https://api.github.com/users/tvman-123/gists{/gist_id}","starred_url":"https://api.github.com/users/tvman-123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvman-123/subscriptions","organizations_url":"https://api.github.com/users/tvman-123/orgs","repos_url":"https://api.github.com/users/tvman-123/repos","events_url":"https://api.github.com/users/tvman-123/events{/privacy}","received_events_url":"https://api.github.com/users/tvman-123/received_events","type":"User","site_admin":false},"repo":{"id":47017397,"name":"defaultnamehere.github.io","full_name":"tvman-123/defaultnamehere.github.io","owner":{"login":"tvman-123","id":13202658,"avatar_url":"https://avatars.githubusercontent.com/u/13202658?v=3","gravatar_id":"","url":"https://api.github.com/users/tvman-123","html_url":"https://github.com/tvman-123","followers_url":"https://api.github.com/users/tvman-123/followers","following_url":"https://api.github.com/users/tvman-123/following{/other_user}","gists_url":"https://api.github.com/users/tvman-123/gists{/gist_id}","starred_url":"https://api.github.com/users/tvman-123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvman-123/subscriptions","organizations_url":"https://api.github.com/users/tvman-123/orgs","repos_url":"https://api.github.com/users/tvman-123/repos","events_url":"https://api.github.com/users/tvman-123/events{/privacy}","received_events_url":"https://api.github.com/users/tvman-123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tvman-123/defaultnamehere.github.io","description":"Are you ready for a miracle?","fork":true,"url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io","forks_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/forks","keys_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/teams","hooks_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/hooks","issue_events_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/events","assignees_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/tags","blobs_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/languages","stargazers_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/stargazers","contributors_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/contributors","subscribers_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/subscribers","subscription_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/subscription","commits_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/merges","archive_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/downloads","issues_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/labels{/name}","releases_url":"https://api.github.com/repos/tvman-123/defaultnamehere.github.io/releases{/id}","created_at":"2015-11-28T09:14:29Z","updated_at":"2016-01-10T01:32:30Z","pushed_at":"2016-01-10T03:19:50Z","git_url":"git://github.com/tvman-123/defaultnamehere.github.io.git","ssh_url":"git@github.com:tvman-123/defaultnamehere.github.io.git","clone_url":"https://github.com/tvman-123/defaultnamehere.github.io.git","svn_url":"https://github.com/tvman-123/defaultnamehere.github.io","homepage":"http://gabegaming.com","size":5806,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"defaultnamehere:master","ref":"master","sha":"88b184218672537519449642cd2638e5e7153c20","user":{"login":"defaultnamehere","id":2187165,"avatar_url":"https://avatars.githubusercontent.com/u/2187165?v=3","gravatar_id":"","url":"https://api.github.com/users/defaultnamehere","html_url":"https://github.com/defaultnamehere","followers_url":"https://api.github.com/users/defaultnamehere/followers","following_url":"https://api.github.com/users/defaultnamehere/following{/other_user}","gists_url":"https://api.github.com/users/defaultnamehere/gists{/gist_id}","starred_url":"https://api.github.com/users/defaultnamehere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defaultnamehere/subscriptions","organizations_url":"https://api.github.com/users/defaultnamehere/orgs","repos_url":"https://api.github.com/users/defaultnamehere/repos","events_url":"https://api.github.com/users/defaultnamehere/events{/privacy}","received_events_url":"https://api.github.com/users/defaultnamehere/received_events","type":"User","site_admin":false},"repo":{"id":15727979,"name":"defaultnamehere.github.io","full_name":"defaultnamehere/defaultnamehere.github.io","owner":{"login":"defaultnamehere","id":2187165,"avatar_url":"https://avatars.githubusercontent.com/u/2187165?v=3","gravatar_id":"","url":"https://api.github.com/users/defaultnamehere","html_url":"https://github.com/defaultnamehere","followers_url":"https://api.github.com/users/defaultnamehere/followers","following_url":"https://api.github.com/users/defaultnamehere/following{/other_user}","gists_url":"https://api.github.com/users/defaultnamehere/gists{/gist_id}","starred_url":"https://api.github.com/users/defaultnamehere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defaultnamehere/subscriptions","organizations_url":"https://api.github.com/users/defaultnamehere/orgs","repos_url":"https://api.github.com/users/defaultnamehere/repos","events_url":"https://api.github.com/users/defaultnamehere/events{/privacy}","received_events_url":"https://api.github.com/users/defaultnamehere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/defaultnamehere/defaultnamehere.github.io","description":"Are you ready for a miracle?","fork":false,"url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io","forks_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/forks","keys_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/teams","hooks_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/hooks","issue_events_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/events","assignees_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/tags","blobs_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/languages","stargazers_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/stargazers","contributors_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/contributors","subscribers_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/subscribers","subscription_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/subscription","commits_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/merges","archive_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/downloads","issues_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/labels{/name}","releases_url":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/releases{/id}","created_at":"2014-01-08T06:52:00Z","updated_at":"2016-01-06T15:52:46Z","pushed_at":"2016-01-13T06:15:46Z","git_url":"git://github.com/defaultnamehere/defaultnamehere.github.io.git","ssh_url":"git@github.com:defaultnamehere/defaultnamehere.github.io.git","clone_url":"https://github.com/defaultnamehere/defaultnamehere.github.io.git","svn_url":"https://github.com/defaultnamehere/defaultnamehere.github.io","homepage":"http://gabegaming.com","size":5911,"stargazers_count":126,"watchers_count":126,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":6,"forks":29,"open_issues":6,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/18"},"html":{"href":"https://github.com/defaultnamehere/defaultnamehere.github.io/pull/18"},"issue":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues/18"},"comments":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/defaultnamehere/defaultnamehere.github.io/statuses/de9ddf1522e3ca35b92ed3ca9389339b74ffa7ec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"defaultnamehere","id":2187165,"avatar_url":"https://avatars.githubusercontent.com/u/2187165?v=3","gravatar_id":"","url":"https://api.github.com/users/defaultnamehere","html_url":"https://github.com/defaultnamehere","followers_url":"https://api.github.com/users/defaultnamehere/followers","following_url":"https://api.github.com/users/defaultnamehere/following{/other_user}","gists_url":"https://api.github.com/users/defaultnamehere/gists{/gist_id}","starred_url":"https://api.github.com/users/defaultnamehere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defaultnamehere/subscriptions","organizations_url":"https://api.github.com/users/defaultnamehere/orgs","repos_url":"https://api.github.com/users/defaultnamehere/repos","events_url":"https://api.github.com/users/defaultnamehere/events{/privacy}","received_events_url":"https://api.github.com/users/defaultnamehere/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":216,"deletions":60,"changed_files":1}}