{"action":"created","comment":{"url":"https://api.github.com/repos/quilljs/quill/pulls/comments/84605826","pull_request_review_id":5372563,"id":84605826,"diff_hunk":"@@ -229,9 +229,9 @@ var delta = [{\n }];\n ```\n \n-The only special case is when we want to remove formatting. We will use `null` for this purpose, so `{ bold: null }` would mean remove the bold format. We could have specified any falsy value, but there may be legitimate use cases for an attribute value to be `0` or the empty string.\n+The exceptional case is when we want to remove formatting. We will use `null` for this purpose, so `{ bold: null }` would mean remove the bold format. We could have specified any falsy value, but there may be legitimate use cases for an attribute value to be `0` or an empty string (i.e. `'  '`).","path":"docs/guides/designing-the-delta-format.md","position":115,"original_position":115,"commit_id":"20986c52ca0166e53f6a652d0b96c679a69edc08","original_commit_id":"20986c52ca0166e53f6a652d0b96c679a69edc08","user":{"login":"jhchen","id":192974,"avatar_url":"https://avatars.githubusercontent.com/u/192974?v=3","gravatar_id":"","url":"https://api.github.com/users/jhchen","html_url":"https://github.com/jhchen","followers_url":"https://api.github.com/users/jhchen/followers","following_url":"https://api.github.com/users/jhchen/following{/other_user}","gists_url":"https://api.github.com/users/jhchen/gists{/gist_id}","starred_url":"https://api.github.com/users/jhchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhchen/subscriptions","organizations_url":"https://api.github.com/users/jhchen/orgs","repos_url":"https://api.github.com/users/jhchen/repos","events_url":"https://api.github.com/users/jhchen/events{/privacy}","received_events_url":"https://api.github.com/users/jhchen/received_events","type":"User","site_admin":false},"body":"I think \"special case\" and \"the empty string\" is more idiomatic.","created_at":"2016-10-23T21:48:16Z","updated_at":"2016-10-23T21:56:43Z","html_url":"https://github.com/quilljs/quill/pull/1069#discussion_r84605826","pull_request_url":"https://api.github.com/repos/quilljs/quill/pulls/1069","_links":{"self":{"href":"https://api.github.com/repos/quilljs/quill/pulls/comments/84605826"},"html":{"href":"https://github.com/quilljs/quill/pull/1069#discussion_r84605826"},"pull_request":{"href":"https://api.github.com/repos/quilljs/quill/pulls/1069"}}},"pull_request":{"url":"https://api.github.com/repos/quilljs/quill/pulls/1069","id":90489009,"html_url":"https://github.com/quilljs/quill/pull/1069","diff_url":"https://github.com/quilljs/quill/pull/1069.diff","patch_url":"https://github.com/quilljs/quill/pull/1069.patch","issue_url":"https://api.github.com/repos/quilljs/quill/issues/1069","number":1069,"state":"open","locked":false,"title":"Minor stylistic changes","user":{"login":"hallaathrad","id":2107110,"avatar_url":"https://avatars.githubusercontent.com/u/2107110?v=3","gravatar_id":"","url":"https://api.github.com/users/hallaathrad","html_url":"https://github.com/hallaathrad","followers_url":"https://api.github.com/users/hallaathrad/followers","following_url":"https://api.github.com/users/hallaathrad/following{/other_user}","gists_url":"https://api.github.com/users/hallaathrad/gists{/gist_id}","starred_url":"https://api.github.com/users/hallaathrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallaathrad/subscriptions","organizations_url":"https://api.github.com/users/hallaathrad/orgs","repos_url":"https://api.github.com/users/hallaathrad/repos","events_url":"https://api.github.com/users/hallaathrad/events{/privacy}","received_events_url":"https://api.github.com/users/hallaathrad/received_events","type":"User","site_admin":false},"body":"Improving readability and adjusting some typos.\r\n\r\nI've had soooooo much fun learning about Deltas! Thank you. Truly mindblowing.","created_at":"2016-10-22T17:26:29Z","updated_at":"2016-10-23T21:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60d16d52cc03635fb1c0cb3b41ce10bdf510293f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/quilljs/quill/pulls/1069/commits","review_comments_url":"https://api.github.com/repos/quilljs/quill/pulls/1069/comments","review_comment_url":"https://api.github.com/repos/quilljs/quill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quilljs/quill/issues/1069/comments","statuses_url":"https://api.github.com/repos/quilljs/quill/statuses/20986c52ca0166e53f6a652d0b96c679a69edc08","head":{"label":"hallaathrad:patch-1","ref":"patch-1","sha":"20986c52ca0166e53f6a652d0b96c679a69edc08","user":{"login":"hallaathrad","id":2107110,"avatar_url":"https://avatars.githubusercontent.com/u/2107110?v=3","gravatar_id":"","url":"https://api.github.com/users/hallaathrad","html_url":"https://github.com/hallaathrad","followers_url":"https://api.github.com/users/hallaathrad/followers","following_url":"https://api.github.com/users/hallaathrad/following{/other_user}","gists_url":"https://api.github.com/users/hallaathrad/gists{/gist_id}","starred_url":"https://api.github.com/users/hallaathrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallaathrad/subscriptions","organizations_url":"https://api.github.com/users/hallaathrad/orgs","repos_url":"https://api.github.com/users/hallaathrad/repos","events_url":"https://api.github.com/users/hallaathrad/events{/privacy}","received_events_url":"https://api.github.com/users/hallaathrad/received_events","type":"User","site_admin":false},"repo":{"id":68631286,"name":"quill","full_name":"hallaathrad/quill","owner":{"login":"hallaathrad","id":2107110,"avatar_url":"https://avatars.githubusercontent.com/u/2107110?v=3","gravatar_id":"","url":"https://api.github.com/users/hallaathrad","html_url":"https://github.com/hallaathrad","followers_url":"https://api.github.com/users/hallaathrad/followers","following_url":"https://api.github.com/users/hallaathrad/following{/other_user}","gists_url":"https://api.github.com/users/hallaathrad/gists{/gist_id}","starred_url":"https://api.github.com/users/hallaathrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hallaathrad/subscriptions","organizations_url":"https://api.github.com/users/hallaathrad/orgs","repos_url":"https://api.github.com/users/hallaathrad/repos","events_url":"https://api.github.com/users/hallaathrad/events{/privacy}","received_events_url":"https://api.github.com/users/hallaathrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hallaathrad/quill","description":"Your powerful, rich text editor","fork":true,"url":"https://api.github.com/repos/hallaathrad/quill","forks_url":"https://api.github.com/repos/hallaathrad/quill/forks","keys_url":"https://api.github.com/repos/hallaathrad/quill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hallaathrad/quill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hallaathrad/quill/teams","hooks_url":"https://api.github.com/repos/hallaathrad/quill/hooks","issue_events_url":"https://api.github.com/repos/hallaathrad/quill/issues/events{/number}","events_url":"https://api.github.com/repos/hallaathrad/quill/events","assignees_url":"https://api.github.com/repos/hallaathrad/quill/assignees{/user}","branches_url":"https://api.github.com/repos/hallaathrad/quill/branches{/branch}","tags_url":"https://api.github.com/repos/hallaathrad/quill/tags","blobs_url":"https://api.github.com/repos/hallaathrad/quill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hallaathrad/quill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hallaathrad/quill/git/refs{/sha}","trees_url":"https://api.github.com/repos/hallaathrad/quill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hallaathrad/quill/statuses/{sha}","languages_url":"https://api.github.com/repos/hallaathrad/quill/languages","stargazers_url":"https://api.github.com/repos/hallaathrad/quill/stargazers","contributors_url":"https://api.github.com/repos/hallaathrad/quill/contributors","subscribers_url":"https://api.github.com/repos/hallaathrad/quill/subscribers","subscription_url":"https://api.github.com/repos/hallaathrad/quill/subscription","commits_url":"https://api.github.com/repos/hallaathrad/quill/commits{/sha}","git_commits_url":"https://api.github.com/repos/hallaathrad/quill/git/commits{/sha}","comments_url":"https://api.github.com/repos/hallaathrad/quill/comments{/number}","issue_comment_url":"https://api.github.com/repos/hallaathrad/quill/issues/comments{/number}","contents_url":"https://api.github.com/repos/hallaathrad/quill/contents/{+path}","compare_url":"https://api.github.com/repos/hallaathrad/quill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hallaathrad/quill/merges","archive_url":"https://api.github.com/repos/hallaathrad/quill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hallaathrad/quill/downloads","issues_url":"https://api.github.com/repos/hallaathrad/quill/issues{/number}","pulls_url":"https://api.github.com/repos/hallaathrad/quill/pulls{/number}","milestones_url":"https://api.github.com/repos/hallaathrad/quill/milestones{/number}","notifications_url":"https://api.github.com/repos/hallaathrad/quill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hallaathrad/quill/labels{/name}","releases_url":"https://api.github.com/repos/hallaathrad/quill/releases{/id}","deployments_url":"https://api.github.com/repos/hallaathrad/quill/deployments","created_at":"2016-09-19T17:52:47Z","updated_at":"2016-09-19T17:52:49Z","pushed_at":"2016-10-23T01:40:35Z","git_url":"git://github.com/hallaathrad/quill.git","ssh_url":"git@github.com:hallaathrad/quill.git","clone_url":"https://github.com/hallaathrad/quill.git","svn_url":"https://github.com/hallaathrad/quill","homepage":"http://quilljs.com","size":11712,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"quilljs:develop","ref":"develop","sha":"e465dbe5c7847baa29e93dfae9f8f9990765e767","user":{"login":"quilljs","id":7089101,"avatar_url":"https://avatars.githubusercontent.com/u/7089101?v=3","gravatar_id":"","url":"https://api.github.com/users/quilljs","html_url":"https://github.com/quilljs","followers_url":"https://api.github.com/users/quilljs/followers","following_url":"https://api.github.com/users/quilljs/following{/other_user}","gists_url":"https://api.github.com/users/quilljs/gists{/gist_id}","starred_url":"https://api.github.com/users/quilljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quilljs/subscriptions","organizations_url":"https://api.github.com/users/quilljs/orgs","repos_url":"https://api.github.com/users/quilljs/repos","events_url":"https://api.github.com/users/quilljs/events{/privacy}","received_events_url":"https://api.github.com/users/quilljs/received_events","type":"Organization","site_admin":false},"repo":{"id":5239185,"name":"quill","full_name":"quilljs/quill","owner":{"login":"quilljs","id":7089101,"avatar_url":"https://avatars.githubusercontent.com/u/7089101?v=3","gravatar_id":"","url":"https://api.github.com/users/quilljs","html_url":"https://github.com/quilljs","followers_url":"https://api.github.com/users/quilljs/followers","following_url":"https://api.github.com/users/quilljs/following{/other_user}","gists_url":"https://api.github.com/users/quilljs/gists{/gist_id}","starred_url":"https://api.github.com/users/quilljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quilljs/subscriptions","organizations_url":"https://api.github.com/users/quilljs/orgs","repos_url":"https://api.github.com/users/quilljs/repos","events_url":"https://api.github.com/users/quilljs/events{/privacy}","received_events_url":"https://api.github.com/users/quilljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quilljs/quill","description":"Your powerful, rich text editor","fork":false,"url":"https://api.github.com/repos/quilljs/quill","forks_url":"https://api.github.com/repos/quilljs/quill/forks","keys_url":"https://api.github.com/repos/quilljs/quill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quilljs/quill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quilljs/quill/teams","hooks_url":"https://api.github.com/repos/quilljs/quill/hooks","issue_events_url":"https://api.github.com/repos/quilljs/quill/issues/events{/number}","events_url":"https://api.github.com/repos/quilljs/quill/events","assignees_url":"https://api.github.com/repos/quilljs/quill/assignees{/user}","branches_url":"https://api.github.com/repos/quilljs/quill/branches{/branch}","tags_url":"https://api.github.com/repos/quilljs/quill/tags","blobs_url":"https://api.github.com/repos/quilljs/quill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quilljs/quill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quilljs/quill/git/refs{/sha}","trees_url":"https://api.github.com/repos/quilljs/quill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quilljs/quill/statuses/{sha}","languages_url":"https://api.github.com/repos/quilljs/quill/languages","stargazers_url":"https://api.github.com/repos/quilljs/quill/stargazers","contributors_url":"https://api.github.com/repos/quilljs/quill/contributors","subscribers_url":"https://api.github.com/repos/quilljs/quill/subscribers","subscription_url":"https://api.github.com/repos/quilljs/quill/subscription","commits_url":"https://api.github.com/repos/quilljs/quill/commits{/sha}","git_commits_url":"https://api.github.com/repos/quilljs/quill/git/commits{/sha}","comments_url":"https://api.github.com/repos/quilljs/quill/comments{/number}","issue_comment_url":"https://api.github.com/repos/quilljs/quill/issues/comments{/number}","contents_url":"https://api.github.com/repos/quilljs/quill/contents/{+path}","compare_url":"https://api.github.com/repos/quilljs/quill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quilljs/quill/merges","archive_url":"https://api.github.com/repos/quilljs/quill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quilljs/quill/downloads","issues_url":"https://api.github.com/repos/quilljs/quill/issues{/number}","pulls_url":"https://api.github.com/repos/quilljs/quill/pulls{/number}","milestones_url":"https://api.github.com/repos/quilljs/quill/milestones{/number}","notifications_url":"https://api.github.com/repos/quilljs/quill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quilljs/quill/labels{/name}","releases_url":"https://api.github.com/repos/quilljs/quill/releases{/id}","deployments_url":"https://api.github.com/repos/quilljs/quill/deployments","created_at":"2012-07-30T23:23:18Z","updated_at":"2016-10-23T21:08:28Z","pushed_at":"2016-10-23T21:23:34Z","git_url":"git://github.com/quilljs/quill.git","ssh_url":"git@github.com:quilljs/quill.git","clone_url":"https://github.com/quilljs/quill.git","svn_url":"https://github.com/quilljs/quill","homepage":"http://quilljs.com","size":15065,"stargazers_count":11223,"watchers_count":11223,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":634,"mirror_url":null,"open_issues_count":72,"forks":634,"open_issues":72,"watchers":11223,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/quilljs/quill/pulls/1069"},"html":{"href":"https://github.com/quilljs/quill/pull/1069"},"issue":{"href":"https://api.github.com/repos/quilljs/quill/issues/1069"},"comments":{"href":"https://api.github.com/repos/quilljs/quill/issues/1069/comments"},"review_comments":{"href":"https://api.github.com/repos/quilljs/quill/pulls/1069/comments"},"review_comment":{"href":"https://api.github.com/repos/quilljs/quill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quilljs/quill/pulls/1069/commits"},"statuses":{"href":"https://api.github.com/repos/quilljs/quill/statuses/20986c52ca0166e53f6a652d0b96c679a69edc08"}}}}
{"actor":{"display_login":"jhchen"}}