{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/chpladmin/chpl-website/pulls/44","id":91808569,"html_url":"https://github.com/chpladmin/chpl-website/pull/44","diff_url":"https://github.com/chpladmin/chpl-website/pull/44.diff","patch_url":"https://github.com/chpladmin/chpl-website/pull/44.patch","issue_url":"https://api.github.com/repos/chpladmin/chpl-website/issues/44","number":44,"state":"closed","locked":false,"title":"Jserrors","user":{"login":"dlucas1","id":4240975,"avatar_url":"https://avatars.githubusercontent.com/u/4240975?v=3","gravatar_id":"","url":"https://api.github.com/users/dlucas1","html_url":"https://github.com/dlucas1","followers_url":"https://api.github.com/users/dlucas1/followers","following_url":"https://api.github.com/users/dlucas1/following{/other_user}","gists_url":"https://api.github.com/users/dlucas1/gists{/gist_id}","starred_url":"https://api.github.com/users/dlucas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlucas1/subscriptions","organizations_url":"https://api.github.com/users/dlucas1/orgs","repos_url":"https://api.github.com/users/dlucas1/repos","events_url":"https://api.github.com/users/dlucas1/events{/privacy}","received_events_url":"https://api.github.com/users/dlucas1/received_events","type":"User","site_admin":false},"body":"- Fixes favicon.ico not found error with update to index.html for the \"shortcut icon\"\r\n- Fixes javascript console errors which allows for full angular compatibility\r\n- Since I verified that angular 1.4.14 (latest version) now works, I updated the bower.json to reflect this.\r\n\r\n- Tested the CMS widget and list of products/developers/edition/version:\r\na. Adding Cert IDs populates CMS EHR Certification ID as expected and updates criteria\r\nb. Adding multiple Cert IDs populates CMR EHR Certification ID as expected and updates criteria\r\nc. Removing a single Cert ID from the widget updates the widget and criteria\r\nd. Selecting 'Remove all products' in the widget removes all products and displays \"No products selected\", disables the 'Remove all products' button, and updates Base Criteria to 0%\r\ne. The list of products/developer/edition/Version shows \"No result found\" if the API key is invalid in the search_options API call header\r\nf. Compared all changes on local vs dev to verify that there are no behavior changes are found\r\ng. Reviewed console throughout all testing to ensure that no javascript errors occur","created_at":"2016-11-01T15:50:59Z","updated_at":"2016-11-02T13:42:32Z","closed_at":"2016-11-02T13:42:31Z","merged_at":null,"merge_commit_sha":"18a47d69e783ac4818ab1a9c6ca8f2184cba76f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chpladmin/chpl-website/pulls/44/commits","review_comments_url":"https://api.github.com/repos/chpladmin/chpl-website/pulls/44/comments","review_comment_url":"https://api.github.com/repos/chpladmin/chpl-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chpladmin/chpl-website/issues/44/comments","statuses_url":"https://api.github.com/repos/chpladmin/chpl-website/statuses/9617c8f581be8e0417db0452e6f47a00f5f92a84","head":{"label":"dlucas1:jserrors","ref":"jserrors","sha":"9617c8f581be8e0417db0452e6f47a00f5f92a84","user":{"login":"dlucas1","id":4240975,"avatar_url":"https://avatars.githubusercontent.com/u/4240975?v=3","gravatar_id":"","url":"https://api.github.com/users/dlucas1","html_url":"https://github.com/dlucas1","followers_url":"https://api.github.com/users/dlucas1/followers","following_url":"https://api.github.com/users/dlucas1/following{/other_user}","gists_url":"https://api.github.com/users/dlucas1/gists{/gist_id}","starred_url":"https://api.github.com/users/dlucas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlucas1/subscriptions","organizations_url":"https://api.github.com/users/dlucas1/orgs","repos_url":"https://api.github.com/users/dlucas1/repos","events_url":"https://api.github.com/users/dlucas1/events{/privacy}","received_events_url":"https://api.github.com/users/dlucas1/received_events","type":"User","site_admin":false},"repo":{"id":63893116,"name":"chpl-website","full_name":"dlucas1/chpl-website","owner":{"login":"dlucas1","id":4240975,"avatar_url":"https://avatars.githubusercontent.com/u/4240975?v=3","gravatar_id":"","url":"https://api.github.com/users/dlucas1","html_url":"https://github.com/dlucas1","followers_url":"https://api.github.com/users/dlucas1/followers","following_url":"https://api.github.com/users/dlucas1/following{/other_user}","gists_url":"https://api.github.com/users/dlucas1/gists{/gist_id}","starred_url":"https://api.github.com/users/dlucas1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlucas1/subscriptions","organizations_url":"https://api.github.com/users/dlucas1/orgs","repos_url":"https://api.github.com/users/dlucas1/repos","events_url":"https://api.github.com/users/dlucas1/events{/privacy}","received_events_url":"https://api.github.com/users/dlucas1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlucas1/chpl-website","description":"The web UI for chpl","fork":true,"url":"https://api.github.com/repos/dlucas1/chpl-website","forks_url":"https://api.github.com/repos/dlucas1/chpl-website/forks","keys_url":"https://api.github.com/repos/dlucas1/chpl-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlucas1/chpl-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlucas1/chpl-website/teams","hooks_url":"https://api.github.com/repos/dlucas1/chpl-website/hooks","issue_events_url":"https://api.github.com/repos/dlucas1/chpl-website/issues/events{/number}","events_url":"https://api.github.com/repos/dlucas1/chpl-website/events","assignees_url":"https://api.github.com/repos/dlucas1/chpl-website/assignees{/user}","branches_url":"https://api.github.com/repos/dlucas1/chpl-website/branches{/branch}","tags_url":"https://api.github.com/repos/dlucas1/chpl-website/tags","blobs_url":"https://api.github.com/repos/dlucas1/chpl-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlucas1/chpl-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlucas1/chpl-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlucas1/chpl-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlucas1/chpl-website/statuses/{sha}","languages_url":"https://api.github.com/repos/dlucas1/chpl-website/languages","stargazers_url":"https://api.github.com/repos/dlucas1/chpl-website/stargazers","contributors_url":"https://api.github.com/repos/dlucas1/chpl-website/contributors","subscribers_url":"https://api.github.com/repos/dlucas1/chpl-website/subscribers","subscription_url":"https://api.github.com/repos/dlucas1/chpl-website/subscription","commits_url":"https://api.github.com/repos/dlucas1/chpl-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlucas1/chpl-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlucas1/chpl-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlucas1/chpl-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlucas1/chpl-website/contents/{+path}","compare_url":"https://api.github.com/repos/dlucas1/chpl-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlucas1/chpl-website/merges","archive_url":"https://api.github.com/repos/dlucas1/chpl-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlucas1/chpl-website/downloads","issues_url":"https://api.github.com/repos/dlucas1/chpl-website/issues{/number}","pulls_url":"https://api.github.com/repos/dlucas1/chpl-website/pulls{/number}","milestones_url":"https://api.github.com/repos/dlucas1/chpl-website/milestones{/number}","notifications_url":"https://api.github.com/repos/dlucas1/chpl-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlucas1/chpl-website/labels{/name}","releases_url":"https://api.github.com/repos/dlucas1/chpl-website/releases{/id}","deployments_url":"https://api.github.com/repos/dlucas1/chpl-website/deployments","created_at":"2016-07-21T18:28:59Z","updated_at":"2016-07-21T18:29:00Z","pushed_at":"2016-11-01T15:41:07Z","git_url":"git://github.com/dlucas1/chpl-website.git","ssh_url":"git@github.com:dlucas1/chpl-website.git","clone_url":"https://github.com/dlucas1/chpl-website.git","svn_url":"https://github.com/dlucas1/chpl-website","homepage":null,"size":2668,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"chpladmin:development","ref":"development","sha":"fe8a018f9b6422c1971519829dddc30629fcfa1d","user":{"login":"chpladmin","id":11613790,"avatar_url":"https://avatars.githubusercontent.com/u/11613790?v=3","gravatar_id":"","url":"https://api.github.com/users/chpladmin","html_url":"https://github.com/chpladmin","followers_url":"https://api.github.com/users/chpladmin/followers","following_url":"https://api.github.com/users/chpladmin/following{/other_user}","gists_url":"https://api.github.com/users/chpladmin/gists{/gist_id}","starred_url":"https://api.github.com/users/chpladmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chpladmin/subscriptions","organizations_url":"https://api.github.com/users/chpladmin/orgs","repos_url":"https://api.github.com/users/chpladmin/repos","events_url":"https://api.github.com/users/chpladmin/events{/privacy}","received_events_url":"https://api.github.com/users/chpladmin/received_events","type":"Organization","site_admin":false},"repo":{"id":33204165,"name":"chpl-website","full_name":"chpladmin/chpl-website","owner":{"login":"chpladmin","id":11613790,"avatar_url":"https://avatars.githubusercontent.com/u/11613790?v=3","gravatar_id":"","url":"https://api.github.com/users/chpladmin","html_url":"https://github.com/chpladmin","followers_url":"https://api.github.com/users/chpladmin/followers","following_url":"https://api.github.com/users/chpladmin/following{/other_user}","gists_url":"https://api.github.com/users/chpladmin/gists{/gist_id}","starred_url":"https://api.github.com/users/chpladmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chpladmin/subscriptions","organizations_url":"https://api.github.com/users/chpladmin/orgs","repos_url":"https://api.github.com/users/chpladmin/repos","events_url":"https://api.github.com/users/chpladmin/events{/privacy}","received_events_url":"https://api.github.com/users/chpladmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chpladmin/chpl-website","description":"The web UI for chpl","fork":false,"url":"https://api.github.com/repos/chpladmin/chpl-website","forks_url":"https://api.github.com/repos/chpladmin/chpl-website/forks","keys_url":"https://api.github.com/repos/chpladmin/chpl-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chpladmin/chpl-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chpladmin/chpl-website/teams","hooks_url":"https://api.github.com/repos/chpladmin/chpl-website/hooks","issue_events_url":"https://api.github.com/repos/chpladmin/chpl-website/issues/events{/number}","events_url":"https://api.github.com/repos/chpladmin/chpl-website/events","assignees_url":"https://api.github.com/repos/chpladmin/chpl-website/assignees{/user}","branches_url":"https://api.github.com/repos/chpladmin/chpl-website/branches{/branch}","tags_url":"https://api.github.com/repos/chpladmin/chpl-website/tags","blobs_url":"https://api.github.com/repos/chpladmin/chpl-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chpladmin/chpl-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chpladmin/chpl-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/chpladmin/chpl-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chpladmin/chpl-website/statuses/{sha}","languages_url":"https://api.github.com/repos/chpladmin/chpl-website/languages","stargazers_url":"https://api.github.com/repos/chpladmin/chpl-website/stargazers","contributors_url":"https://api.github.com/repos/chpladmin/chpl-website/contributors","subscribers_url":"https://api.github.com/repos/chpladmin/chpl-website/subscribers","subscription_url":"https://api.github.com/repos/chpladmin/chpl-website/subscription","commits_url":"https://api.github.com/repos/chpladmin/chpl-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/chpladmin/chpl-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/chpladmin/chpl-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/chpladmin/chpl-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/chpladmin/chpl-website/contents/{+path}","compare_url":"https://api.github.com/repos/chpladmin/chpl-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chpladmin/chpl-website/merges","archive_url":"https://api.github.com/repos/chpladmin/chpl-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chpladmin/chpl-website/downloads","issues_url":"https://api.github.com/repos/chpladmin/chpl-website/issues{/number}","pulls_url":"https://api.github.com/repos/chpladmin/chpl-website/pulls{/number}","milestones_url":"https://api.github.com/repos/chpladmin/chpl-website/milestones{/number}","notifications_url":"https://api.github.com/repos/chpladmin/chpl-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chpladmin/chpl-website/labels{/name}","releases_url":"https://api.github.com/repos/chpladmin/chpl-website/releases{/id}","deployments_url":"https://api.github.com/repos/chpladmin/chpl-website/deployments","created_at":"2015-03-31T19:04:43Z","updated_at":"2016-01-12T14:16:36Z","pushed_at":"2016-11-02T13:40:58Z","git_url":"git://github.com/chpladmin/chpl-website.git","ssh_url":"git@github.com:chpladmin/chpl-website.git","clone_url":"https://github.com/chpladmin/chpl-website.git","svn_url":"https://github.com/chpladmin/chpl-website","homepage":null,"size":2612,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":0,"forks":6,"open_issues":0,"watchers":0,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/chpladmin/chpl-website/pulls/44"},"html":{"href":"https://github.com/chpladmin/chpl-website/pull/44"},"issue":{"href":"https://api.github.com/repos/chpladmin/chpl-website/issues/44"},"comments":{"href":"https://api.github.com/repos/chpladmin/chpl-website/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/chpladmin/chpl-website/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/chpladmin/chpl-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chpladmin/chpl-website/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/chpladmin/chpl-website/statuses/9617c8f581be8e0417db0452e6f47a00f5f92a84"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":6,"commits":4,"additions":65,"deletions":50,"changed_files":5}}
{"actor":{"display_login":"dlucas1"}}