{"action":"created","issue":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/538","repository_url":"https://api.github.com/repos/cubing/worldcubeassociation.org","labels_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/538/labels{/name}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/538/comments","events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/538/events","html_url":"https://github.com/cubing/worldcubeassociation.org/pull/538","id":150843538,"number":538,"title":"Ensure competition names are not greater than 50 characters when visible","user":{"login":"pingskills","id":4403168,"avatar_url":"https://avatars.githubusercontent.com/u/4403168?v=3","gravatar_id":"","url":"https://api.github.com/users/pingskills","html_url":"https://github.com/pingskills","followers_url":"https://api.github.com/users/pingskills/followers","following_url":"https://api.github.com/users/pingskills/following{/other_user}","gists_url":"https://api.github.com/users/pingskills/gists{/gist_id}","starred_url":"https://api.github.com/users/pingskills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingskills/subscriptions","organizations_url":"https://api.github.com/users/pingskills/orgs","repos_url":"https://api.github.com/users/pingskills/repos","events_url":"https://api.github.com/users/pingskills/events{/privacy}","received_events_url":"https://api.github.com/users/pingskills/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-04-25T12:35:45Z","updated_at":"2016-04-28T01:29:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/538","html_url":"https://github.com/cubing/worldcubeassociation.org/pull/538","diff_url":"https://github.com/cubing/worldcubeassociation.org/pull/538.diff","patch_url":"https://github.com/cubing/worldcubeassociation.org/pull/538.patch"},"body":" I realised that the change I made to ensure a competition name <= 32 characters when it's not visible removed the existing validation for when the competition is visible. So I added back the original validation and added a new test for it to ensure competition names are <= 50 characters when visible."},"comment":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/comments/215281120","html_url":"https://github.com/cubing/worldcubeassociation.org/pull/538#issuecomment-215281120","issue_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/538","id":215281120,"user":{"login":"pedrosino","id":1881933,"avatar_url":"https://avatars.githubusercontent.com/u/1881933?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrosino","html_url":"https://github.com/pedrosino","followers_url":"https://api.github.com/users/pedrosino/followers","following_url":"https://api.github.com/users/pedrosino/following{/other_user}","gists_url":"https://api.github.com/users/pedrosino/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrosino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrosino/subscriptions","organizations_url":"https://api.github.com/users/pedrosino/orgs","repos_url":"https://api.github.com/users/pedrosino/repos","events_url":"https://api.github.com/users/pedrosino/events{/privacy}","received_events_url":"https://api.github.com/users/pedrosino/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T01:29:43Z","updated_at":"2016-04-28T01:29:43Z","body":"I'm probably gonna ask something dumb, but why would the limits be different if the competition is visible or not?\r\n\r\nThe way I see it, every competition will become visible, so the first limit is somewhat pointless.\r\n\r\nI didn't follow the discussion very well since I was travelling, but if I had to choose, I'd say option 2."}}