{"action":"created","comment":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/68928319","id":68928319,"diff_hunk":"@@ -5,11 +5,22 @@ add_library(asl ${SRC_LIST} ${INC_LIST})\n target_include_directories(asl PUBLIC ..)\n target_compile_definitions(asl PUBLIC ADOBE_STD_SERIALIZATION)\n \n-#otherwise boost concept checking fails on adobe::selection_t because it lacks non const begin/end\n+# otherwise boost concept checking fails on adobe::selection_t because it lacks non const begin/end\n target_compile_definitions(asl PUBLIC -DBOOST_RANGE_ENABLE_CONCEPT_ASSERT=0)\n \n-#otherwise boost::move and std::move are ambiguous\n-target_compile_definitions(asl PUBLIC -DBOOST_MOVE_USE_STANDARD_LIBRARY_MOVE)\n+# otherwise boost::move and std::move are ambiguous\n+# commented out here because ADOBE_STD_ flags below make it irrelevant\n+#target_compile_definitions(asl PUBLIC BOOST_MOVE_USE_STANDARD_LIBRARY_MOVE)\n+\n+if (USE_STD_THREAD_LOCAL)\n+    target_compile_definitions(asl PUBLIC ADOBE_STD_THREAD_LOCAL)\n+endif()\n+\n+# GCC6 warning on boost 1.60\n+# right operand of shift expression '(1u << 63u)' is >= than the precision of the left operand [-fpermissive]\n+if (${CMAKE_CXX_COMPILER_ID} STREQUAL \"GNU\")\n+    target_compile_definitions(asl PUBLIC ADOBE_FNV_NO_BIGINTS)","path":"source/CMakeLists.txt","position":21,"original_position":21,"commit_id":"e8c004b57d820da003c0d73725c20b637dc94bf0","original_commit_id":"e8c004b57d820da003c0d73725c20b637dc94bf0","user":{"login":"ilelann","id":580426,"avatar_url":"https://avatars.githubusercontent.com/u/580426?v=3","gravatar_id":"","url":"https://api.github.com/users/ilelann","html_url":"https://github.com/ilelann","followers_url":"https://api.github.com/users/ilelann/followers","following_url":"https://api.github.com/users/ilelann/following{/other_user}","gists_url":"https://api.github.com/users/ilelann/gists{/gist_id}","starred_url":"https://api.github.com/users/ilelann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilelann/subscriptions","organizations_url":"https://api.github.com/users/ilelann/orgs","repos_url":"https://api.github.com/users/ilelann/repos","events_url":"https://api.github.com/users/ilelann/events{/privacy}","received_events_url":"https://api.github.com/users/ilelann/received_events","type":"User","site_admin":false},"body":"admittedly, this is quite an aggressive \"fix\" to silence a warning ... I just don't need big int.\r\nSeems boost 1.61 adressed this issue by the way\r\nhttps://github.com/boostorg/multiprecision/commit/f9c8f9ec091ad232c0a291904f7839d665d098e0","created_at":"2016-06-29T11:12:53Z","updated_at":"2016-06-29T11:12:53Z","html_url":"https://github.com/stlab/adobe_source_libraries/pull/53#discussion_r68928319","pull_request_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments/68928319"},"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/53#discussion_r68928319"},"pull_request":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53","id":75601886,"html_url":"https://github.com/stlab/adobe_source_libraries/pull/53","diff_url":"https://github.com/stlab/adobe_source_libraries/pull/53.diff","patch_url":"https://github.com/stlab/adobe_source_libraries/pull/53.patch","issue_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/53","number":53,"state":"open","locked":false,"title":"GCC6 and cmake fixes","user":{"login":"ilelann","id":580426,"avatar_url":"https://avatars.githubusercontent.com/u/580426?v=3","gravatar_id":"","url":"https://api.github.com/users/ilelann","html_url":"https://github.com/ilelann","followers_url":"https://api.github.com/users/ilelann/followers","following_url":"https://api.github.com/users/ilelann/following{/other_user}","gists_url":"https://api.github.com/users/ilelann/gists{/gist_id}","starred_url":"https://api.github.com/users/ilelann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilelann/subscriptions","organizations_url":"https://api.github.com/users/ilelann/orgs","repos_url":"https://api.github.com/users/ilelann/repos","events_url":"https://api.github.com/users/ilelann/events{/privacy}","received_events_url":"https://api.github.com/users/ilelann/received_events","type":"User","site_admin":false},"body":"* fix some missing #include \r\n* aggressive cleaning of cmath.hpp and once.hpp\r\n* CMake updates \r\n  * clone boost github mirror when boost_libraries is not found\r\n  * allow building with Clang and libcxx under Linux\r\n  * disable Boost.Thread dependency when thread_local is available (== !XCode)\r\n  * force link with pthread in Linux. Fixes crash when not linking with installed Boost.Thread\r\n  * change default build directory to ../build_asl to be nice with my APL scripts\r\n\r\nPlease note that with CMake automatically cloning Boost when USE_SYSTEM_BOOST=OFF is passed, on my Fedora 24 host,  a \r\n\r\n`git clone ... && cd adobe_source_libraries && sh cmake_build_all.sh` \r\n\r\nrequires no other dependency than having a Clang-built libcxx installed for Clang builds.\r\nIt builds six variants (gcc/clang, local/system boost, release/debug).\r\nI excluded clang/system boost only because recent GCC abi tag prevents cross linking.\r\n","created_at":"2016-06-29T07:42:48Z","updated_at":"2016-06-29T11:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a539f6ccbaba98bf7fdf58a6319866c47a08d712","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53/commits","review_comments_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53/comments","review_comment_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/53/comments","statuses_url":"https://api.github.com/repos/stlab/adobe_source_libraries/statuses/e8c004b57d820da003c0d73725c20b637dc94bf0","head":{"label":"ilelann:gcc6_and_cmake_fixes","ref":"gcc6_and_cmake_fixes","sha":"e8c004b57d820da003c0d73725c20b637dc94bf0","user":{"login":"ilelann","id":580426,"avatar_url":"https://avatars.githubusercontent.com/u/580426?v=3","gravatar_id":"","url":"https://api.github.com/users/ilelann","html_url":"https://github.com/ilelann","followers_url":"https://api.github.com/users/ilelann/followers","following_url":"https://api.github.com/users/ilelann/following{/other_user}","gists_url":"https://api.github.com/users/ilelann/gists{/gist_id}","starred_url":"https://api.github.com/users/ilelann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilelann/subscriptions","organizations_url":"https://api.github.com/users/ilelann/orgs","repos_url":"https://api.github.com/users/ilelann/repos","events_url":"https://api.github.com/users/ilelann/events{/privacy}","received_events_url":"https://api.github.com/users/ilelann/received_events","type":"User","site_admin":false},"repo":{"id":14464533,"name":"adobe_source_libraries","full_name":"ilelann/adobe_source_libraries","owner":{"login":"ilelann","id":580426,"avatar_url":"https://avatars.githubusercontent.com/u/580426?v=3","gravatar_id":"","url":"https://api.github.com/users/ilelann","html_url":"https://github.com/ilelann","followers_url":"https://api.github.com/users/ilelann/followers","following_url":"https://api.github.com/users/ilelann/following{/other_user}","gists_url":"https://api.github.com/users/ilelann/gists{/gist_id}","starred_url":"https://api.github.com/users/ilelann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilelann/subscriptions","organizations_url":"https://api.github.com/users/ilelann/orgs","repos_url":"https://api.github.com/users/ilelann/repos","events_url":"https://api.github.com/users/ilelann/events{/privacy}","received_events_url":"https://api.github.com/users/ilelann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilelann/adobe_source_libraries","description":"Adobe Source Libraries","fork":true,"url":"https://api.github.com/repos/ilelann/adobe_source_libraries","forks_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/forks","keys_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/teams","hooks_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/hooks","issue_events_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/issues/events{/number}","events_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/events","assignees_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/assignees{/user}","branches_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/branches{/branch}","tags_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/tags","blobs_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/statuses/{sha}","languages_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/languages","stargazers_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/stargazers","contributors_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/contributors","subscribers_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/subscribers","subscription_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/subscription","commits_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/contents/{+path}","compare_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/merges","archive_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/downloads","issues_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/issues{/number}","pulls_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/pulls{/number}","milestones_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/milestones{/number}","notifications_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/labels{/name}","releases_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/releases{/id}","deployments_url":"https://api.github.com/repos/ilelann/adobe_source_libraries/deployments","created_at":"2013-11-17T09:54:06Z","updated_at":"2015-04-07T21:56:30Z","pushed_at":"2016-06-29T05:48:53Z","git_url":"git://github.com/ilelann/adobe_source_libraries.git","ssh_url":"git@github.com:ilelann/adobe_source_libraries.git","clone_url":"https://github.com/ilelann/adobe_source_libraries.git","svn_url":"https://github.com/ilelann/adobe_source_libraries","homepage":"","size":14992,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stlab:master","ref":"master","sha":"ef12706eb51b36cc37a7097827e315fc1cf1690a","user":{"login":"stlab","id":2448845,"avatar_url":"https://avatars.githubusercontent.com/u/2448845?v=3","gravatar_id":"","url":"https://api.github.com/users/stlab","html_url":"https://github.com/stlab","followers_url":"https://api.github.com/users/stlab/followers","following_url":"https://api.github.com/users/stlab/following{/other_user}","gists_url":"https://api.github.com/users/stlab/gists{/gist_id}","starred_url":"https://api.github.com/users/stlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlab/subscriptions","organizations_url":"https://api.github.com/users/stlab/orgs","repos_url":"https://api.github.com/users/stlab/repos","events_url":"https://api.github.com/users/stlab/events{/privacy}","received_events_url":"https://api.github.com/users/stlab/received_events","type":"Organization","site_admin":false},"repo":{"id":6608880,"name":"adobe_source_libraries","full_name":"stlab/adobe_source_libraries","owner":{"login":"stlab","id":2448845,"avatar_url":"https://avatars.githubusercontent.com/u/2448845?v=3","gravatar_id":"","url":"https://api.github.com/users/stlab","html_url":"https://github.com/stlab","followers_url":"https://api.github.com/users/stlab/followers","following_url":"https://api.github.com/users/stlab/following{/other_user}","gists_url":"https://api.github.com/users/stlab/gists{/gist_id}","starred_url":"https://api.github.com/users/stlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlab/subscriptions","organizations_url":"https://api.github.com/users/stlab/orgs","repos_url":"https://api.github.com/users/stlab/repos","events_url":"https://api.github.com/users/stlab/events{/privacy}","received_events_url":"https://api.github.com/users/stlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stlab/adobe_source_libraries","description":"Adobe Source Libraries","fork":false,"url":"https://api.github.com/repos/stlab/adobe_source_libraries","forks_url":"https://api.github.com/repos/stlab/adobe_source_libraries/forks","keys_url":"https://api.github.com/repos/stlab/adobe_source_libraries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stlab/adobe_source_libraries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stlab/adobe_source_libraries/teams","hooks_url":"https://api.github.com/repos/stlab/adobe_source_libraries/hooks","issue_events_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/events{/number}","events_url":"https://api.github.com/repos/stlab/adobe_source_libraries/events","assignees_url":"https://api.github.com/repos/stlab/adobe_source_libraries/assignees{/user}","branches_url":"https://api.github.com/repos/stlab/adobe_source_libraries/branches{/branch}","tags_url":"https://api.github.com/repos/stlab/adobe_source_libraries/tags","blobs_url":"https://api.github.com/repos/stlab/adobe_source_libraries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stlab/adobe_source_libraries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stlab/adobe_source_libraries/git/refs{/sha}","trees_url":"https://api.github.com/repos/stlab/adobe_source_libraries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stlab/adobe_source_libraries/statuses/{sha}","languages_url":"https://api.github.com/repos/stlab/adobe_source_libraries/languages","stargazers_url":"https://api.github.com/repos/stlab/adobe_source_libraries/stargazers","contributors_url":"https://api.github.com/repos/stlab/adobe_source_libraries/contributors","subscribers_url":"https://api.github.com/repos/stlab/adobe_source_libraries/subscribers","subscription_url":"https://api.github.com/repos/stlab/adobe_source_libraries/subscription","commits_url":"https://api.github.com/repos/stlab/adobe_source_libraries/commits{/sha}","git_commits_url":"https://api.github.com/repos/stlab/adobe_source_libraries/git/commits{/sha}","comments_url":"https://api.github.com/repos/stlab/adobe_source_libraries/comments{/number}","issue_comment_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/comments{/number}","contents_url":"https://api.github.com/repos/stlab/adobe_source_libraries/contents/{+path}","compare_url":"https://api.github.com/repos/stlab/adobe_source_libraries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stlab/adobe_source_libraries/merges","archive_url":"https://api.github.com/repos/stlab/adobe_source_libraries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stlab/adobe_source_libraries/downloads","issues_url":"https://api.github.com/repos/stlab/adobe_source_libraries/issues{/number}","pulls_url":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls{/number}","milestones_url":"https://api.github.com/repos/stlab/adobe_source_libraries/milestones{/number}","notifications_url":"https://api.github.com/repos/stlab/adobe_source_libraries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stlab/adobe_source_libraries/labels{/name}","releases_url":"https://api.github.com/repos/stlab/adobe_source_libraries/releases{/id}","deployments_url":"https://api.github.com/repos/stlab/adobe_source_libraries/deployments","created_at":"2012-11-09T05:09:11Z","updated_at":"2016-06-19T15:13:20Z","pushed_at":"2016-06-29T07:42:48Z","git_url":"git://github.com/stlab/adobe_source_libraries.git","ssh_url":"git@github.com:stlab/adobe_source_libraries.git","clone_url":"https://github.com/stlab/adobe_source_libraries.git","svn_url":"https://github.com/stlab/adobe_source_libraries","homepage":"","size":15310,"stargazers_count":115,"watchers_count":115,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":6,"forks":20,"open_issues":6,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53"},"html":{"href":"https://github.com/stlab/adobe_source_libraries/pull/53"},"issue":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/53"},"comments":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/stlab/adobe_source_libraries/statuses/e8c004b57d820da003c0d73725c20b637dc94bf0"}}}}
{"actor":{"display_login":"ilelann"}}