{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/252","repository_url":"https://api.github.com/repos/JuliaOpt/Optim.jl","labels_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/252/comments","events_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/252/events","html_url":"https://github.com/JuliaOpt/Optim.jl/pull/252","id":169817265,"number":252,"title":"Isolating tests, added univariate test problems, and better testing f…","user":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-07T21:29:22Z","updated_at":"2016-08-08T07:06:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/252","html_url":"https://github.com/JuliaOpt/Optim.jl/pull/252","diff_url":"https://github.com/JuliaOpt/Optim.jl/pull/252.diff","patch_url":"https://github.com/JuliaOpt/Optim.jl/pull/252.patch"},"body":"…or some multivariate solvers.\r\n\r\nTo my surprise, stuff like BFGS wasn't even tested on the UnconstrainedProblems!\r\n\r\nMomentum Gradient Descent has some cases filtered out, as it will increase the objective value at some point, even if it will converge eventually. This is expected, but currently we use `!converged` in the while logic. I wonder if we should simply replace `f_converged` with something like\r\n```julia\r\nf_converged = abs(f_x - f_x_previous) / (abs(f_x) + o.f_tol) < o.f_tol || (nextfloat(f_x) >= f_x_previous && f_x < f_x_previous)\r\n```\r\njust below the convergence assessment in accelerated and momentum gradient descent. Right now it \"converges\" on an increase, which is unfortunate... Different issue though!"},"comment":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/comments/238157365","html_url":"https://github.com/JuliaOpt/Optim.jl/pull/252#issuecomment-238157365","issue_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/252","id":238157365,"user":{"login":"Evizero","id":10854026,"avatar_url":"https://avatars.githubusercontent.com/u/10854026?v=3","gravatar_id":"","url":"https://api.github.com/users/Evizero","html_url":"https://github.com/Evizero","followers_url":"https://api.github.com/users/Evizero/followers","following_url":"https://api.github.com/users/Evizero/following{/other_user}","gists_url":"https://api.github.com/users/Evizero/gists{/gist_id}","starred_url":"https://api.github.com/users/Evizero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evizero/subscriptions","organizations_url":"https://api.github.com/users/Evizero/orgs","repos_url":"https://api.github.com/users/Evizero/repos","events_url":"https://api.github.com/users/Evizero/events{/privacy}","received_events_url":"https://api.github.com/users/Evizero/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T07:06:33Z","updated_at":"2016-08-08T07:06:33Z","body":"Can not reproduce the travis error on OSX 10.11.5 with Julia 0.4.5.\r\n\r\nThe tests execute fine for me"}}
{"actor":{"display_login":"Evizero"}}