{"action":"created","comment":{"url":"https://api.github.com/repos/openT2T/opent2t/pulls/comments/75516149","id":75516149,"diff_hunk":"@@ -303,6 +305,7 @@ export class LocalPackageSource extends PackageSource {\n                 let onboardingPackageName: string =\n                         LocalPackageSource.derivePackageName(onboardingId, \"onboarding\");\n                 onboardingModulePath = onboardingPackageName + \"/\" + onboardingId;\n+","path":"node/lib/package/LocalPackageSource.ts","position":38,"original_position":20,"commit_id":"60b442a87fef1648d3741b60818690b3d6bf4e0a","original_commit_id":"250d6ba2fa3bff23c82508a6ed9c46b5c8a34d20","user":{"login":"sanjaiganesh","id":10471289,"avatar_url":"https://avatars.githubusercontent.com/u/10471289?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjaiganesh","html_url":"https://github.com/sanjaiganesh","followers_url":"https://api.github.com/users/sanjaiganesh/followers","following_url":"https://api.github.com/users/sanjaiganesh/following{/other_user}","gists_url":"https://api.github.com/users/sanjaiganesh/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjaiganesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjaiganesh/subscriptions","organizations_url":"https://api.github.com/users/sanjaiganesh/orgs","repos_url":"https://api.github.com/users/sanjaiganesh/repos","events_url":"https://api.github.com/users/sanjaiganesh/events{/privacy}","received_events_url":"https://api.github.com/users/sanjaiganesh/received_events","type":"User","site_admin":false},"body":"ok. sure. so this should be  below ? Fixed to that now.\r\nonboarding: 'opent2t-onboarding-org-opent2t-test-onboarding/org.opent2t.test.onboarding/thingOnboarding',\r\n\r\n---\r\nIn reply to: [75431448](https://github.com/openT2T/opent2t/pull/22#discussion_r75431448) [](ancestors = 75431448)","created_at":"2016-08-19T16:59:34Z","updated_at":"2016-08-19T16:59:34Z","html_url":"https://github.com/openT2T/opent2t/pull/22#discussion_r75516149","pull_request_url":"https://api.github.com/repos/openT2T/opent2t/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/openT2T/opent2t/pulls/comments/75516149"},"html":{"href":"https://github.com/openT2T/opent2t/pull/22#discussion_r75516149"},"pull_request":{"href":"https://api.github.com/repos/openT2T/opent2t/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/openT2T/opent2t/pulls/22","id":81755726,"html_url":"https://github.com/openT2T/opent2t/pull/22","diff_url":"https://github.com/openT2T/opent2t/pull/22.diff","patch_url":"https://github.com/openT2T/opent2t/pull/22.patch","issue_url":"https://api.github.com/repos/openT2T/opent2t/issues/22","number":22,"state":"open","locked":false,"title":"Adding parsing logic for OnboardingFlow in manifest.xml","user":{"login":"sanjaiganesh","id":10471289,"avatar_url":"https://avatars.githubusercontent.com/u/10471289?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjaiganesh","html_url":"https://github.com/sanjaiganesh","followers_url":"https://api.github.com/users/sanjaiganesh/followers","following_url":"https://api.github.com/users/sanjaiganesh/following{/other_user}","gists_url":"https://api.github.com/users/sanjaiganesh/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjaiganesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjaiganesh/subscriptions","organizations_url":"https://api.github.com/users/sanjaiganesh/orgs","repos_url":"https://api.github.com/users/sanjaiganesh/repos","events_url":"https://api.github.com/users/sanjaiganesh/events{/privacy}","received_events_url":"https://api.github.com/users/sanjaiganesh/received_events","type":"User","site_admin":false},"body":"Just wanted to start pull request, to assist discussion. Frankly, I am pretty confused in terms of naming and directory structure.. also various fields that are required in PackageInfo.onboardingInfo & what their values should be.\r\n\r\nPlease review the following\r\n- Directory structure of the sample onboarding module and contents (manifest.xml and package.json)\r\n- Does PackageOnboardingInfo have all the fields\r\n- Whether these fields are being constructed properly. I am confused here.\r\n- TODOs in LocalPackageSource.ts\r\n\r\nPending:\r\n    PackageInfo.onboardingInfo is not populated in all the places\r\n    Test is not complete to test all the fields\r\n    Directory structure\r\n    Actual Wink onboarding is yet to be modified to consume this (input logic)\r\n\r\nBelow are some of the Values of variables in the source code, for given onboarding module structure. (if helps in reviewing)\r\n\r\n    schemaModulepath : \"opent2t-onboarding-org-opent2t-test-onboarding-one/org.opent2t.test.onboarding.one\"\r\n    onboardingManifestPath: \"org.opent2t.test.onboarding.one/node/manifest.xml\" \r\n    onboardingJsonPath: \"org.opent2t.test.onboarding.one/node/package.json\"\r\n    onboardingModulePath: \"opent2t-onboarding-org-opent2t-test-onboarding.one/org.opent2t.test.onboarding\"\r\n\r\nonbordingInfo field: (in PackageInfo)\r\n    onboardingId: \"org.opent2t.test.onboarding.one\"\r\n    schemas:[]\r\n        \"opent2t-onboarding-org-opent2t-test-onboarding-one/org.opent2t.test.onboarding.one\"\r\n   ..Rest of the fields are good. no confusion.","created_at":"2016-08-18T04:33:51Z","updated_at":"2016-08-19T16:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e02ff7bb59d0007d2deec2fb7963e731aa6b17a5","assignee":{"login":"tjaffri","id":749277,"avatar_url":"https://avatars.githubusercontent.com/u/749277?v=3","gravatar_id":"","url":"https://api.github.com/users/tjaffri","html_url":"https://github.com/tjaffri","followers_url":"https://api.github.com/users/tjaffri/followers","following_url":"https://api.github.com/users/tjaffri/following{/other_user}","gists_url":"https://api.github.com/users/tjaffri/gists{/gist_id}","starred_url":"https://api.github.com/users/tjaffri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjaffri/subscriptions","organizations_url":"https://api.github.com/users/tjaffri/orgs","repos_url":"https://api.github.com/users/tjaffri/repos","events_url":"https://api.github.com/users/tjaffri/events{/privacy}","received_events_url":"https://api.github.com/users/tjaffri/received_events","type":"User","site_admin":false},"assignees":[{"login":"tjaffri","id":749277,"avatar_url":"https://avatars.githubusercontent.com/u/749277?v=3","gravatar_id":"","url":"https://api.github.com/users/tjaffri","html_url":"https://github.com/tjaffri","followers_url":"https://api.github.com/users/tjaffri/followers","following_url":"https://api.github.com/users/tjaffri/following{/other_user}","gists_url":"https://api.github.com/users/tjaffri/gists{/gist_id}","starred_url":"https://api.github.com/users/tjaffri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjaffri/subscriptions","organizations_url":"https://api.github.com/users/tjaffri/orgs","repos_url":"https://api.github.com/users/tjaffri/repos","events_url":"https://api.github.com/users/tjaffri/events{/privacy}","received_events_url":"https://api.github.com/users/tjaffri/received_events","type":"User","site_admin":false},{"login":"jeanpa","id":9542680,"avatar_url":"https://avatars.githubusercontent.com/u/9542680?v=3","gravatar_id":"","url":"https://api.github.com/users/jeanpa","html_url":"https://github.com/jeanpa","followers_url":"https://api.github.com/users/jeanpa/followers","following_url":"https://api.github.com/users/jeanpa/following{/other_user}","gists_url":"https://api.github.com/users/jeanpa/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanpa/subscriptions","organizations_url":"https://api.github.com/users/jeanpa/orgs","repos_url":"https://api.github.com/users/jeanpa/repos","events_url":"https://api.github.com/users/jeanpa/events{/privacy}","received_events_url":"https://api.github.com/users/jeanpa/received_events","type":"User","site_admin":false},{"login":"sanjaiganesh","id":10471289,"avatar_url":"https://avatars.githubusercontent.com/u/10471289?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjaiganesh","html_url":"https://github.com/sanjaiganesh","followers_url":"https://api.github.com/users/sanjaiganesh/followers","following_url":"https://api.github.com/users/sanjaiganesh/following{/other_user}","gists_url":"https://api.github.com/users/sanjaiganesh/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjaiganesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjaiganesh/subscriptions","organizations_url":"https://api.github.com/users/sanjaiganesh/orgs","repos_url":"https://api.github.com/users/sanjaiganesh/repos","events_url":"https://api.github.com/users/sanjaiganesh/events{/privacy}","received_events_url":"https://api.github.com/users/sanjaiganesh/received_events","type":"User","site_admin":false},{"login":"arjun-msft","id":20304470,"avatar_url":"https://avatars.githubusercontent.com/u/20304470?v=3","gravatar_id":"","url":"https://api.github.com/users/arjun-msft","html_url":"https://github.com/arjun-msft","followers_url":"https://api.github.com/users/arjun-msft/followers","following_url":"https://api.github.com/users/arjun-msft/following{/other_user}","gists_url":"https://api.github.com/users/arjun-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/arjun-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjun-msft/subscriptions","organizations_url":"https://api.github.com/users/arjun-msft/orgs","repos_url":"https://api.github.com/users/arjun-msft/repos","events_url":"https://api.github.com/users/arjun-msft/events{/privacy}","received_events_url":"https://api.github.com/users/arjun-msft/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openT2T/opent2t/pulls/22/commits","review_comments_url":"https://api.github.com/repos/openT2T/opent2t/pulls/22/comments","review_comment_url":"https://api.github.com/repos/openT2T/opent2t/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openT2T/opent2t/issues/22/comments","statuses_url":"https://api.github.com/repos/openT2T/opent2t/statuses/60b442a87fef1648d3741b60818690b3d6bf4e0a","head":{"label":"sanjaiganesh:proto","ref":"proto","sha":"60b442a87fef1648d3741b60818690b3d6bf4e0a","user":{"login":"sanjaiganesh","id":10471289,"avatar_url":"https://avatars.githubusercontent.com/u/10471289?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjaiganesh","html_url":"https://github.com/sanjaiganesh","followers_url":"https://api.github.com/users/sanjaiganesh/followers","following_url":"https://api.github.com/users/sanjaiganesh/following{/other_user}","gists_url":"https://api.github.com/users/sanjaiganesh/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjaiganesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjaiganesh/subscriptions","organizations_url":"https://api.github.com/users/sanjaiganesh/orgs","repos_url":"https://api.github.com/users/sanjaiganesh/repos","events_url":"https://api.github.com/users/sanjaiganesh/events{/privacy}","received_events_url":"https://api.github.com/users/sanjaiganesh/received_events","type":"User","site_admin":false},"repo":{"id":64876042,"name":"opent2t","full_name":"sanjaiganesh/opent2t","owner":{"login":"sanjaiganesh","id":10471289,"avatar_url":"https://avatars.githubusercontent.com/u/10471289?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjaiganesh","html_url":"https://github.com/sanjaiganesh","followers_url":"https://api.github.com/users/sanjaiganesh/followers","following_url":"https://api.github.com/users/sanjaiganesh/following{/other_user}","gists_url":"https://api.github.com/users/sanjaiganesh/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjaiganesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjaiganesh/subscriptions","organizations_url":"https://api.github.com/users/sanjaiganesh/orgs","repos_url":"https://api.github.com/users/sanjaiganesh/repos","events_url":"https://api.github.com/users/sanjaiganesh/events{/privacy}","received_events_url":"https://api.github.com/users/sanjaiganesh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sanjaiganesh/opent2t","description":"Cross-platform core libraries for Open Translators to Things","fork":true,"url":"https://api.github.com/repos/sanjaiganesh/opent2t","forks_url":"https://api.github.com/repos/sanjaiganesh/opent2t/forks","keys_url":"https://api.github.com/repos/sanjaiganesh/opent2t/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanjaiganesh/opent2t/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanjaiganesh/opent2t/teams","hooks_url":"https://api.github.com/repos/sanjaiganesh/opent2t/hooks","issue_events_url":"https://api.github.com/repos/sanjaiganesh/opent2t/issues/events{/number}","events_url":"https://api.github.com/repos/sanjaiganesh/opent2t/events","assignees_url":"https://api.github.com/repos/sanjaiganesh/opent2t/assignees{/user}","branches_url":"https://api.github.com/repos/sanjaiganesh/opent2t/branches{/branch}","tags_url":"https://api.github.com/repos/sanjaiganesh/opent2t/tags","blobs_url":"https://api.github.com/repos/sanjaiganesh/opent2t/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanjaiganesh/opent2t/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanjaiganesh/opent2t/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanjaiganesh/opent2t/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanjaiganesh/opent2t/statuses/{sha}","languages_url":"https://api.github.com/repos/sanjaiganesh/opent2t/languages","stargazers_url":"https://api.github.com/repos/sanjaiganesh/opent2t/stargazers","contributors_url":"https://api.github.com/repos/sanjaiganesh/opent2t/contributors","subscribers_url":"https://api.github.com/repos/sanjaiganesh/opent2t/subscribers","subscription_url":"https://api.github.com/repos/sanjaiganesh/opent2t/subscription","commits_url":"https://api.github.com/repos/sanjaiganesh/opent2t/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanjaiganesh/opent2t/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanjaiganesh/opent2t/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanjaiganesh/opent2t/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanjaiganesh/opent2t/contents/{+path}","compare_url":"https://api.github.com/repos/sanjaiganesh/opent2t/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanjaiganesh/opent2t/merges","archive_url":"https://api.github.com/repos/sanjaiganesh/opent2t/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanjaiganesh/opent2t/downloads","issues_url":"https://api.github.com/repos/sanjaiganesh/opent2t/issues{/number}","pulls_url":"https://api.github.com/repos/sanjaiganesh/opent2t/pulls{/number}","milestones_url":"https://api.github.com/repos/sanjaiganesh/opent2t/milestones{/number}","notifications_url":"https://api.github.com/repos/sanjaiganesh/opent2t/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanjaiganesh/opent2t/labels{/name}","releases_url":"https://api.github.com/repos/sanjaiganesh/opent2t/releases{/id}","deployments_url":"https://api.github.com/repos/sanjaiganesh/opent2t/deployments","created_at":"2016-08-03T20:11:26Z","updated_at":"2016-08-03T20:11:28Z","pushed_at":"2016-08-19T16:40:26Z","git_url":"git://github.com/sanjaiganesh/opent2t.git","ssh_url":"git@github.com:sanjaiganesh/opent2t.git","clone_url":"https://github.com/sanjaiganesh/opent2t.git","svn_url":"https://github.com/sanjaiganesh/opent2t","homepage":null,"size":155,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openT2T:master","ref":"master","sha":"c80b92ae016a561259f5a63b1258f068ff345f00","user":{"login":"openT2T","id":17659874,"avatar_url":"https://avatars.githubusercontent.com/u/17659874?v=3","gravatar_id":"","url":"https://api.github.com/users/openT2T","html_url":"https://github.com/openT2T","followers_url":"https://api.github.com/users/openT2T/followers","following_url":"https://api.github.com/users/openT2T/following{/other_user}","gists_url":"https://api.github.com/users/openT2T/gists{/gist_id}","starred_url":"https://api.github.com/users/openT2T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openT2T/subscriptions","organizations_url":"https://api.github.com/users/openT2T/orgs","repos_url":"https://api.github.com/users/openT2T/repos","events_url":"https://api.github.com/users/openT2T/events{/privacy}","received_events_url":"https://api.github.com/users/openT2T/received_events","type":"Organization","site_admin":false},"repo":{"id":62420853,"name":"opent2t","full_name":"openT2T/opent2t","owner":{"login":"openT2T","id":17659874,"avatar_url":"https://avatars.githubusercontent.com/u/17659874?v=3","gravatar_id":"","url":"https://api.github.com/users/openT2T","html_url":"https://github.com/openT2T","followers_url":"https://api.github.com/users/openT2T/followers","following_url":"https://api.github.com/users/openT2T/following{/other_user}","gists_url":"https://api.github.com/users/openT2T/gists{/gist_id}","starred_url":"https://api.github.com/users/openT2T/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openT2T/subscriptions","organizations_url":"https://api.github.com/users/openT2T/orgs","repos_url":"https://api.github.com/users/openT2T/repos","events_url":"https://api.github.com/users/openT2T/events{/privacy}","received_events_url":"https://api.github.com/users/openT2T/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openT2T/opent2t","description":"Cross-platform core libraries for Open Translators to Things","fork":false,"url":"https://api.github.com/repos/openT2T/opent2t","forks_url":"https://api.github.com/repos/openT2T/opent2t/forks","keys_url":"https://api.github.com/repos/openT2T/opent2t/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openT2T/opent2t/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openT2T/opent2t/teams","hooks_url":"https://api.github.com/repos/openT2T/opent2t/hooks","issue_events_url":"https://api.github.com/repos/openT2T/opent2t/issues/events{/number}","events_url":"https://api.github.com/repos/openT2T/opent2t/events","assignees_url":"https://api.github.com/repos/openT2T/opent2t/assignees{/user}","branches_url":"https://api.github.com/repos/openT2T/opent2t/branches{/branch}","tags_url":"https://api.github.com/repos/openT2T/opent2t/tags","blobs_url":"https://api.github.com/repos/openT2T/opent2t/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openT2T/opent2t/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openT2T/opent2t/git/refs{/sha}","trees_url":"https://api.github.com/repos/openT2T/opent2t/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openT2T/opent2t/statuses/{sha}","languages_url":"https://api.github.com/repos/openT2T/opent2t/languages","stargazers_url":"https://api.github.com/repos/openT2T/opent2t/stargazers","contributors_url":"https://api.github.com/repos/openT2T/opent2t/contributors","subscribers_url":"https://api.github.com/repos/openT2T/opent2t/subscribers","subscription_url":"https://api.github.com/repos/openT2T/opent2t/subscription","commits_url":"https://api.github.com/repos/openT2T/opent2t/commits{/sha}","git_commits_url":"https://api.github.com/repos/openT2T/opent2t/git/commits{/sha}","comments_url":"https://api.github.com/repos/openT2T/opent2t/comments{/number}","issue_comment_url":"https://api.github.com/repos/openT2T/opent2t/issues/comments{/number}","contents_url":"https://api.github.com/repos/openT2T/opent2t/contents/{+path}","compare_url":"https://api.github.com/repos/openT2T/opent2t/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openT2T/opent2t/merges","archive_url":"https://api.github.com/repos/openT2T/opent2t/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openT2T/opent2t/downloads","issues_url":"https://api.github.com/repos/openT2T/opent2t/issues{/number}","pulls_url":"https://api.github.com/repos/openT2T/opent2t/pulls{/number}","milestones_url":"https://api.github.com/repos/openT2T/opent2t/milestones{/number}","notifications_url":"https://api.github.com/repos/openT2T/opent2t/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openT2T/opent2t/labels{/name}","releases_url":"https://api.github.com/repos/openT2T/opent2t/releases{/id}","deployments_url":"https://api.github.com/repos/openT2T/opent2t/deployments","created_at":"2016-07-01T21:33:01Z","updated_at":"2016-08-10T14:51:09Z","pushed_at":"2016-08-19T16:40:26Z","git_url":"git://github.com/openT2T/opent2t.git","ssh_url":"git@github.com:openT2T/opent2t.git","clone_url":"https://github.com/openT2T/opent2t.git","svn_url":"https://github.com/openT2T/opent2t","homepage":null,"size":155,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openT2T/opent2t/pulls/22"},"html":{"href":"https://github.com/openT2T/opent2t/pull/22"},"issue":{"href":"https://api.github.com/repos/openT2T/opent2t/issues/22"},"comments":{"href":"https://api.github.com/repos/openT2T/opent2t/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/openT2T/opent2t/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/openT2T/opent2t/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openT2T/opent2t/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/openT2T/opent2t/statuses/60b442a87fef1648d3741b60818690b3d6bf4e0a"}}}}
{"actor":{"display_login":"sanjaiganesh"}}