{"action":"created","issue":{"url":"https://api.github.com/repos/sedenion/ovgme/issues/5","repository_url":"https://api.github.com/repos/sedenion/ovgme","labels_url":"https://api.github.com/repos/sedenion/ovgme/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/sedenion/ovgme/issues/5/comments","events_url":"https://api.github.com/repos/sedenion/ovgme/issues/5/events","html_url":"https://github.com/sedenion/ovgme/issues/5","id":173116710,"number":5,"title":"Repository implementation","user":{"login":"mguegan","id":4387995,"avatar_url":"https://avatars.githubusercontent.com/u/4387995?v=3","gravatar_id":"","url":"https://api.github.com/users/mguegan","html_url":"https://github.com/mguegan","followers_url":"https://api.github.com/users/mguegan/followers","following_url":"https://api.github.com/users/mguegan/following{/other_user}","gists_url":"https://api.github.com/users/mguegan/gists{/gist_id}","starred_url":"https://api.github.com/users/mguegan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mguegan/subscriptions","organizations_url":"https://api.github.com/users/mguegan/orgs","repos_url":"https://api.github.com/users/mguegan/repos","events_url":"https://api.github.com/users/mguegan/events{/privacy}","received_events_url":"https://api.github.com/users/mguegan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-25T05:25:36Z","updated_at":"2016-08-25T17:49:24Z","closed_at":null,"body":"Hi Sedenion,\r\n\r\nThanks for OvGME, this is really a nice piece of work. I wonder why you've implemented the network stack at low-level for grabbing internet files and not using something like 'curl'  ? It would allow you to use multiple protocols (HTTPS) easily by letting the tool doing its best.\r\n\r\nI've done some test yesterday and it seems I've found a bug when trying to grab multiple mods (some weird 404's) :\r\n\r\n``\r\n\"GET /ovgme/476th%20-%20Grease%20Pencil%20Tip-In%20References.zip HTTP/1.1\" 200 5594744 \"-\" \"-\" \"-\"\r\n``\r\n``\r\n\"GET /ovgme/Toubib%27s%20canopy%20references.zipIn%20References.zip HTTP/1.1\" 404 162 \"-\" \"-\" \"-\"\r\n``\r\n\r\nAs you can see, ``In%20References.zip`` is added at the end of the second mods file, looks like a weird memory bug. I'm pretty sure that's the content of my .xml file is correct though.\r\n\r\nSpeaking of XML, it would be nice to have a more user-friendly config file, like JSON or YAML, but that's another story and purely a personal preference. Don't take me wrong, you already have done a fantastic work, I'm just trying to share my thoughts with you."},"comment":{"url":"https://api.github.com/repos/sedenion/ovgme/issues/comments/242479807","html_url":"https://github.com/sedenion/ovgme/issues/5#issuecomment-242479807","issue_url":"https://api.github.com/repos/sedenion/ovgme/issues/5","id":242479807,"user":{"login":"sedenion","id":1930184,"avatar_url":"https://avatars.githubusercontent.com/u/1930184?v=3","gravatar_id":"","url":"https://api.github.com/users/sedenion","html_url":"https://github.com/sedenion","followers_url":"https://api.github.com/users/sedenion/followers","following_url":"https://api.github.com/users/sedenion/following{/other_user}","gists_url":"https://api.github.com/users/sedenion/gists{/gist_id}","starred_url":"https://api.github.com/users/sedenion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sedenion/subscriptions","organizations_url":"https://api.github.com/users/sedenion/orgs","repos_url":"https://api.github.com/users/sedenion/repos","events_url":"https://api.github.com/users/sedenion/events{/privacy}","received_events_url":"https://api.github.com/users/sedenion/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T17:49:24Z","updated_at":"2016-08-25T17:49:24Z","body":"Using curl.exe (shell call) through a compiled program is a kind of nonsense... it is possible, but in this precise case, it is not only ugly, it is almost unusable since by this way, we have absolutly no controls on the download process, no progress callback, no way to know when the download is done nor failed, etc...  No, the standard way, is to use libcurl, which seem pretty cool, if we achieve to compile it as we need it, then link it either  static or dynamic way... If there is realy a need, i will think about spending a week-end on that question, but for now, the current basic implementation is sufficient (except it does not support HTTPS)... and HTTPS is not needed for what OvGME does (in fact, HTTPS is useless for 99% of websites, but business of SSL certs is a gold mine for SSL certs providers (norton and Thawte thank Google for launching this fashion of the \"green padlock\" icon)). Idem for HTTP/2.0... HTTP/2.0 is a benefit only for complexe webpages with lot of contents to download in paralelle way... OvGME only download very simple data and don't need to display a webpage full of HTML5 with canvas, images and sounds... \r\n\r\n"}}
{"actor":{"display_login":"sedenion"}}