{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-upload/issues/27","repository_url":"https://api.github.com/repos/vaadin/vaadin-upload","labels_url":"https://api.github.com/repos/vaadin/vaadin-upload/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-upload/issues/27/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-upload/issues/27/events","html_url":"https://github.com/vaadin/vaadin-upload/pull/27","id":132772412,"number":27,"title":"Demos of MVP Features","user":{"login":"platosha","id":247998,"avatar_url":"https://avatars.githubusercontent.com/u/247998?v=3","gravatar_id":"","url":"https://api.github.com/users/platosha","html_url":"https://github.com/platosha","followers_url":"https://api.github.com/users/platosha/followers","following_url":"https://api.github.com/users/platosha/following{/other_user}","gists_url":"https://api.github.com/users/platosha/gists{/gist_id}","starred_url":"https://api.github.com/users/platosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platosha/subscriptions","organizations_url":"https://api.github.com/users/platosha/orgs","repos_url":"https://api.github.com/users/platosha/repos","events_url":"https://api.github.com/users/platosha/events{/privacy}","received_events_url":"https://api.github.com/users/platosha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/vaadin/vaadin-upload/labels/in%20review","name":"in review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-10T17:55:45Z","updated_at":"2016-02-11T08:00:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-upload/pulls/27","html_url":"https://github.com/vaadin/vaadin-upload/pull/27","diff_url":"https://github.com/vaadin/vaadin-upload/pull/27.diff","patch_url":"https://github.com/vaadin/vaadin-upload/pull/27.patch"},"body":"Connected to #1 \r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-upload/27)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-upload/issues/comments/182756014","html_url":"https://github.com/vaadin/vaadin-upload/pull/27#issuecomment-182756014","issue_url":"https://api.github.com/repos/vaadin/vaadin-upload/issues/27","id":182756014,"user":{"login":"manolo","id":161853,"avatar_url":"https://avatars.githubusercontent.com/u/161853?v=3","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T08:00:34Z","updated_at":"2016-02-11T08:00:34Z","body":"Nice, \n\n---\n\nReview status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[demo/common.html, line 37 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/vaadin-upload/27#-KAC5IPYpHilU3n1ysAu:-KAC5IPZl-2GlvZ1TczJ:-1817574459) ([raw file](https://github.com/vaadin/vaadin-upload/blob/9dc0e1d623c1db066b08305d9e08aead289a035e/demo/common.html#L37)):*\nThis stuff is mandatory in the vaadin docsite, otherwise polymer elements are loaded in non elements pages.\n\n---\n\n*[demo/index.html, line 112 \\[r1\\]](https://reviewable.io:443/reviews/vaadin/vaadin-upload/27#-KAC4ScTzQL1V0ELvvv3:-KAC4ScUWqsvS5vKwwp0:157265231) ([raw file](https://github.com/vaadin/vaadin-upload/blob/69b5998ccbb76a4efebf76e053d7cd9bd0aabf43/demo/index.html#L112)):*\nwindow alert looks very old-fashioned for a component like this. I would use toast, dialog, or a custom div in the component\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/vaadin/vaadin-upload/27#-:-KAEKzVDOdCBkUrGy1ut:1986765558)*\n<!-- Sent from Reviewable.io -->\n"}}