{"action":"created","comment":{"url":"https://api.github.com/repos/openwrt/packages/pulls/comments/84208446","pull_request_review_id":4999427,"id":84208446,"diff_hunk":"@@ -37,9 +37,9 @@ define Package/unbound\n   SECTION:=net\n   CATEGORY:=Network\n   SUBMENU:=IP Addresses and Names\n+  USERID:=unbound=553:unbound=553","path":"net/unbound/Makefile","position":22,"original_position":22,"commit_id":"49892c060dd66113a7cdf4c3860cc1a1d4bb2c5e","original_commit_id":"662a1dc1fcbe72c333c9712ff86c2847e60b239e","user":{"login":"yousong","id":4948057,"avatar_url":"https://avatars.githubusercontent.com/u/4948057?v=3","gravatar_id":"","url":"https://api.github.com/users/yousong","html_url":"https://github.com/yousong","followers_url":"https://api.github.com/users/yousong/followers","following_url":"https://api.github.com/users/yousong/following{/other_user}","gists_url":"https://api.github.com/users/yousong/gists{/gist_id}","starred_url":"https://api.github.com/users/yousong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yousong/subscriptions","organizations_url":"https://api.github.com/users/yousong/orgs","repos_url":"https://api.github.com/users/yousong/repos","events_url":"https://api.github.com/users/yousong/events{/privacy}","received_events_url":"https://api.github.com/users/yousong/received_events","type":"User","site_admin":false},"body":"Hi, @EricLuehrsen , no need to rush when there are doubts ;)\r\n\r\nBy \"fresh install\" did you mean sysupgrade with old config preserved?  If that is the case, then the issue does exist in 15.05.1 but fixed in both OpenWrt/LEDE `master` branch with `package/base-files/files/etc/uci-defaults/13_fix_group_user`.  Archived discussion on this topic is at https://lists.openwrt.org/pipermail/openwrt-devel/2016-April/041160.html\r\n\r\nIn any case, I don't see the difference between using specific ids and the other way.  That dnsmasq using specific uid/gid is not a workaround of anything about uid/gid not being added correctly.\r\n","created_at":"2016-10-20T03:39:46Z","updated_at":"2016-10-20T03:39:46Z","html_url":"https://github.com/openwrt/packages/pull/3358#discussion_r84208446","pull_request_url":"https://api.github.com/repos/openwrt/packages/pulls/3358","_links":{"self":{"href":"https://api.github.com/repos/openwrt/packages/pulls/comments/84208446"},"html":{"href":"https://github.com/openwrt/packages/pull/3358#discussion_r84208446"},"pull_request":{"href":"https://api.github.com/repos/openwrt/packages/pulls/3358"}}},"pull_request":{"url":"https://api.github.com/repos/openwrt/packages/pulls/3358","id":89929200,"html_url":"https://github.com/openwrt/packages/pull/3358","diff_url":"https://github.com/openwrt/packages/pull/3358.diff","patch_url":"https://github.com/openwrt/packages/pull/3358.patch","issue_url":"https://api.github.com/repos/openwrt/packages/issues/3358","number":3358,"state":"open","locked":false,"title":"Unbound: Group patch work for example.conf.in","user":{"login":"EricLuehrsen","id":17078368,"avatar_url":"https://avatars.githubusercontent.com/u/17078368?v=3","gravatar_id":"","url":"https://api.github.com/users/EricLuehrsen","html_url":"https://github.com/EricLuehrsen","followers_url":"https://api.github.com/users/EricLuehrsen/followers","following_url":"https://api.github.com/users/EricLuehrsen/following{/other_user}","gists_url":"https://api.github.com/users/EricLuehrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricLuehrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricLuehrsen/subscriptions","organizations_url":"https://api.github.com/users/EricLuehrsen/orgs","repos_url":"https://api.github.com/users/EricLuehrsen/repos","events_url":"https://api.github.com/users/EricLuehrsen/events{/privacy}","received_events_url":"https://api.github.com/users/EricLuehrsen/received_events","type":"User","site_admin":false},"body":"Maintainer: me\r\nCompile tested: OpenWrt 15.05.1 (ar71xx) SDK\r\nRun tested: -\r\n\r\nDescription: \r\n**example.conf.in** Prevent recurrence of patch-on-patch issue by grouping OpenWrt package changes in one area. Add a few other configurations to prevent surprises by upstream changes. Disable DNSSEC by default due to chicken-n-egg install issue.\r\n**Makefile** Fix install issue where if you don't have user:group \"unbound\" already, then the installer does not create the correct id numbers. Wrap up for package 1.5.10-2.\r\n\r\nPlease wait for vote of confidence by @hansmi  and @Borromini before pull.\r\n","created_at":"2016-10-19T01:51:41Z","updated_at":"2016-10-20T03:39:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ba590359acec4f40989816ea247b84b40c3fb41","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openwrt/packages/pulls/3358/commits","review_comments_url":"https://api.github.com/repos/openwrt/packages/pulls/3358/comments","review_comment_url":"https://api.github.com/repos/openwrt/packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openwrt/packages/issues/3358/comments","statuses_url":"https://api.github.com/repos/openwrt/packages/statuses/49892c060dd66113a7cdf4c3860cc1a1d4bb2c5e","head":{"label":"EricLuehrsen:unbound_uci","ref":"unbound_uci","sha":"49892c060dd66113a7cdf4c3860cc1a1d4bb2c5e","user":{"login":"EricLuehrsen","id":17078368,"avatar_url":"https://avatars.githubusercontent.com/u/17078368?v=3","gravatar_id":"","url":"https://api.github.com/users/EricLuehrsen","html_url":"https://github.com/EricLuehrsen","followers_url":"https://api.github.com/users/EricLuehrsen/followers","following_url":"https://api.github.com/users/EricLuehrsen/following{/other_user}","gists_url":"https://api.github.com/users/EricLuehrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricLuehrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricLuehrsen/subscriptions","organizations_url":"https://api.github.com/users/EricLuehrsen/orgs","repos_url":"https://api.github.com/users/EricLuehrsen/repos","events_url":"https://api.github.com/users/EricLuehrsen/events{/privacy}","received_events_url":"https://api.github.com/users/EricLuehrsen/received_events","type":"User","site_admin":false},"repo":{"id":69210104,"name":"packages","full_name":"EricLuehrsen/packages","owner":{"login":"EricLuehrsen","id":17078368,"avatar_url":"https://avatars.githubusercontent.com/u/17078368?v=3","gravatar_id":"","url":"https://api.github.com/users/EricLuehrsen","html_url":"https://github.com/EricLuehrsen","followers_url":"https://api.github.com/users/EricLuehrsen/followers","following_url":"https://api.github.com/users/EricLuehrsen/following{/other_user}","gists_url":"https://api.github.com/users/EricLuehrsen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricLuehrsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricLuehrsen/subscriptions","organizations_url":"https://api.github.com/users/EricLuehrsen/orgs","repos_url":"https://api.github.com/users/EricLuehrsen/repos","events_url":"https://api.github.com/users/EricLuehrsen/events{/privacy}","received_events_url":"https://api.github.com/users/EricLuehrsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricLuehrsen/packages","description":"Packages Repository","fork":true,"url":"https://api.github.com/repos/EricLuehrsen/packages","forks_url":"https://api.github.com/repos/EricLuehrsen/packages/forks","keys_url":"https://api.github.com/repos/EricLuehrsen/packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricLuehrsen/packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricLuehrsen/packages/teams","hooks_url":"https://api.github.com/repos/EricLuehrsen/packages/hooks","issue_events_url":"https://api.github.com/repos/EricLuehrsen/packages/issues/events{/number}","events_url":"https://api.github.com/repos/EricLuehrsen/packages/events","assignees_url":"https://api.github.com/repos/EricLuehrsen/packages/assignees{/user}","branches_url":"https://api.github.com/repos/EricLuehrsen/packages/branches{/branch}","tags_url":"https://api.github.com/repos/EricLuehrsen/packages/tags","blobs_url":"https://api.github.com/repos/EricLuehrsen/packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricLuehrsen/packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricLuehrsen/packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricLuehrsen/packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricLuehrsen/packages/statuses/{sha}","languages_url":"https://api.github.com/repos/EricLuehrsen/packages/languages","stargazers_url":"https://api.github.com/repos/EricLuehrsen/packages/stargazers","contributors_url":"https://api.github.com/repos/EricLuehrsen/packages/contributors","subscribers_url":"https://api.github.com/repos/EricLuehrsen/packages/subscribers","subscription_url":"https://api.github.com/repos/EricLuehrsen/packages/subscription","commits_url":"https://api.github.com/repos/EricLuehrsen/packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricLuehrsen/packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricLuehrsen/packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricLuehrsen/packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricLuehrsen/packages/contents/{+path}","compare_url":"https://api.github.com/repos/EricLuehrsen/packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricLuehrsen/packages/merges","archive_url":"https://api.github.com/repos/EricLuehrsen/packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricLuehrsen/packages/downloads","issues_url":"https://api.github.com/repos/EricLuehrsen/packages/issues{/number}","pulls_url":"https://api.github.com/repos/EricLuehrsen/packages/pulls{/number}","milestones_url":"https://api.github.com/repos/EricLuehrsen/packages/milestones{/number}","notifications_url":"https://api.github.com/repos/EricLuehrsen/packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricLuehrsen/packages/labels{/name}","releases_url":"https://api.github.com/repos/EricLuehrsen/packages/releases{/id}","deployments_url":"https://api.github.com/repos/EricLuehrsen/packages/deployments","created_at":"2016-09-26T03:38:27Z","updated_at":"2016-09-26T03:38:31Z","pushed_at":"2016-10-20T00:30:10Z","git_url":"git://github.com/EricLuehrsen/packages.git","ssh_url":"git@github.com:EricLuehrsen/packages.git","clone_url":"https://github.com/EricLuehrsen/packages.git","svn_url":"https://github.com/EricLuehrsen/packages","homepage":null,"size":11143,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openwrt:master","ref":"master","sha":"06e404e1cf9aab2cbb3396766d0eb00e9abbcf53","user":{"login":"openwrt","id":2528830,"avatar_url":"https://avatars.githubusercontent.com/u/2528830?v=3","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"repo":{"id":20307838,"name":"packages","full_name":"openwrt/packages","owner":{"login":"openwrt","id":2528830,"avatar_url":"https://avatars.githubusercontent.com/u/2528830?v=3","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openwrt/packages","description":"Packages Repository","fork":false,"url":"https://api.github.com/repos/openwrt/packages","forks_url":"https://api.github.com/repos/openwrt/packages/forks","keys_url":"https://api.github.com/repos/openwrt/packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwrt/packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwrt/packages/teams","hooks_url":"https://api.github.com/repos/openwrt/packages/hooks","issue_events_url":"https://api.github.com/repos/openwrt/packages/issues/events{/number}","events_url":"https://api.github.com/repos/openwrt/packages/events","assignees_url":"https://api.github.com/repos/openwrt/packages/assignees{/user}","branches_url":"https://api.github.com/repos/openwrt/packages/branches{/branch}","tags_url":"https://api.github.com/repos/openwrt/packages/tags","blobs_url":"https://api.github.com/repos/openwrt/packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwrt/packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwrt/packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwrt/packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwrt/packages/statuses/{sha}","languages_url":"https://api.github.com/repos/openwrt/packages/languages","stargazers_url":"https://api.github.com/repos/openwrt/packages/stargazers","contributors_url":"https://api.github.com/repos/openwrt/packages/contributors","subscribers_url":"https://api.github.com/repos/openwrt/packages/subscribers","subscription_url":"https://api.github.com/repos/openwrt/packages/subscription","commits_url":"https://api.github.com/repos/openwrt/packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwrt/packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwrt/packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwrt/packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwrt/packages/contents/{+path}","compare_url":"https://api.github.com/repos/openwrt/packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwrt/packages/merges","archive_url":"https://api.github.com/repos/openwrt/packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwrt/packages/downloads","issues_url":"https://api.github.com/repos/openwrt/packages/issues{/number}","pulls_url":"https://api.github.com/repos/openwrt/packages/pulls{/number}","milestones_url":"https://api.github.com/repos/openwrt/packages/milestones{/number}","notifications_url":"https://api.github.com/repos/openwrt/packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwrt/packages/labels{/name}","releases_url":"https://api.github.com/repos/openwrt/packages/releases{/id}","deployments_url":"https://api.github.com/repos/openwrt/packages/deployments","created_at":"2014-05-29T20:43:16Z","updated_at":"2016-10-19T03:31:42Z","pushed_at":"2016-10-20T00:26:55Z","git_url":"git://github.com/openwrt/packages.git","ssh_url":"git@github.com:openwrt/packages.git","clone_url":"https://github.com/openwrt/packages.git","svn_url":"https://github.com/openwrt/packages","homepage":null,"size":17158,"stargazers_count":747,"watchers_count":747,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":790,"mirror_url":null,"open_issues_count":215,"forks":790,"open_issues":215,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openwrt/packages/pulls/3358"},"html":{"href":"https://github.com/openwrt/packages/pull/3358"},"issue":{"href":"https://api.github.com/repos/openwrt/packages/issues/3358"},"comments":{"href":"https://api.github.com/repos/openwrt/packages/issues/3358/comments"},"review_comments":{"href":"https://api.github.com/repos/openwrt/packages/pulls/3358/comments"},"review_comment":{"href":"https://api.github.com/repos/openwrt/packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openwrt/packages/pulls/3358/commits"},"statuses":{"href":"https://api.github.com/repos/openwrt/packages/statuses/49892c060dd66113a7cdf4c3860cc1a1d4bb2c5e"}}}}
{"actor":{"display_login":"yousong"}}