{"action":"closed","issue":{"url":"https://api.github.com/repos/koalalorenzo/python-digitalocean/issues/166","repository_url":"https://api.github.com/repos/koalalorenzo/python-digitalocean","labels_url":"https://api.github.com/repos/koalalorenzo/python-digitalocean/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/koalalorenzo/python-digitalocean/issues/166/comments","events_url":"https://api.github.com/repos/koalalorenzo/python-digitalocean/issues/166/events","html_url":"https://github.com/koalalorenzo/python-digitalocean/issues/166","id":182091279,"number":166,"title":"Sometimes requests hang forever","user":{"login":"goodcode","id":1550392,"avatar_url":"https://avatars.githubusercontent.com/u/1550392?v=3","gravatar_id":"","url":"https://api.github.com/users/goodcode","html_url":"https://github.com/goodcode","followers_url":"https://api.github.com/users/goodcode/followers","following_url":"https://api.github.com/users/goodcode/following{/other_user}","gists_url":"https://api.github.com/users/goodcode/gists{/gist_id}","starred_url":"https://api.github.com/users/goodcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goodcode/subscriptions","organizations_url":"https://api.github.com/users/goodcode/orgs","repos_url":"https://api.github.com/users/goodcode/repos","events_url":"https://api.github.com/users/goodcode/events{/privacy}","received_events_url":"https://api.github.com/users/goodcode/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/koalalorenzo/python-digitalocean/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-10T19:08:06Z","updated_at":"2016-10-11T05:38:56Z","closed_at":"2016-10-11T05:38:56Z","body":"I just had a case, where the library just hanged forever on creating the SSL connection:\r\n\r\n```\r\nFile: \"build/bdist.linux-x86_64/egg/digitalocean/Manager.py\", line 38, in get_data\r\nFile: \"build/bdist.linux-x86_64/egg/digitalocean/baseapi.py\", line 100, in get_data\r\nFile: \"build/bdist.linux-x86_64/egg/digitalocean/baseapi.py\", line 89, in __perform_request\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/api.py\", line 107, in post\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/api.py\", line 53, in request\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/sessions.py\", line 468, in request\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/sessions.py\", line 576, in send\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/adapters.py\", line 376, in send\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/packages/urllib3/connectionpool.py\", line 559, in urlopen\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/packages/urllib3/connectionpool.py\", line 345, in _make_request\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/packages/urllib3/connectionpool.py\", line 784, in _validate_conn\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/packages/urllib3/connection.py\", line 252, in connect\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/packages/urllib3/util/ssl_.py\", line 317, in ssl_wrap_socket\r\nFile: \"/home/amy/.cache/imoenv/2.7.5.1/cb8359d4d500ee0904b443ac858feae845ce3416/site-packages/requests-2.9.1-py2.7.egg/requests/packages/urllib3/util/ssl_.py\", line 130, in wrap_socket\r\nFile: \"/opt/imopython/2.7.5.1/Python-2.7.5/lib/python2.7/ssl.py\", line 387, in wrap_socket\r\nFile: \"/opt/imopython/2.7.5.1/Python-2.7.5/lib/python2.7/ssl.py\", line 143, in __init__\r\nFile: \"/opt/imopython/2.7.5.1/Python-2.7.5/lib/python2.7/ssl.py\", line 305, in do_handshake\r\n  self._sslobj.do_handshake()\r\n```\r\n\r\nIt would be nice to have a timeout parameter that we can pass. Python requests already supports such a parameter, so it's just a matter of passing it all the way to it.\r\n\r\nI will implement this in my forked branch and will post the pull request here. Feel free to merge it if you like it.\r\n"}}
{"actor":{"display_login":"koalalorenzo"}}