{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1343","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1343/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1343/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1343/events","html_url":"https://github.com/greenplum-db/gpdb/pull/1343","id":190262666,"number":1343,"title":"Add \"installcheck-world\" target (and sync plperl with upstream)","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-18T08:32:24Z","updated_at":"2016-11-21T15:53:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/1343","html_url":"https://github.com/greenplum-db/gpdb/pull/1343","diff_url":"https://github.com/greenplum-db/gpdb/pull/1343.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/1343.patch"},"body":"The main part of this PR is the second patch, to add installcheck-world target to the top-level makefile. Per commit message:\r\n\r\n    Add \"installcheck-world\" makefile target.\r\n    \r\n    The master plan is that we will have straightforward \"world\" makefile\r\n    targets, like newer versions of PostgreSQL has, that build, install,\r\n    and test everything in the source tree. For example, \"make world\" builds\r\n    everything and the kitchen sink, and \"make installcheck-world\" runs\r\n    every test suite against an existing installation.\r\n    \r\n    This patch is the first step in that direction. It creates a top-level\r\n    \"installcheck-world\" target, that runs some of the test suites we have.\r\n    It does not run everything, because the tests for some components are\r\n    either broken, or require additional setup to run. The point of this\r\n    first step is to establish the precedence, and clean up and add\r\n    everything else that we care about to this new target. For example, this\r\n    does not run the gphdfs tests, gpmapreduce tests, or orafce tests yet.\r\n    \r\n    Also, this only adds the \"installcheck-world\" target, not \"world\",\r\n    \"install-world\" nor \"check-world\". Those are TODOs.\r\n    \r\n    Adjust the concourse pipeline scripts to run the new \"installcheck-world\"\r\n    target, replacing the separate \"installcheck-good\" and\r\n    \"installcheck-bugbuster\" tasks. In the future, whenever a new test suite\r\n    is added, it can be added to the installcheck-world target, and the\r\n    pipeline will pick it up immediately, without having to modify the yaml\r\n    files.\r\n    \r\n    An immediate benefit of this is that we now run the isolationtester test\r\n    suite, and the PL tests, as part of the pipeline.\r\n\r\nTo make the PL regression tests pass, this also fixes plperl, by syncing it with the upstream 9.1 version of the source tree and tests. (We had backported it from 9.1 earlier, but the backport was incomplete, and the regression tests were neglected)"},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/261977270","html_url":"https://github.com/greenplum-db/gpdb/pull/1343#issuecomment-261977270","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/1343","id":261977270,"user":{"login":"schubert","id":11972,"avatar_url":"https://avatars.githubusercontent.com/u/11972?v=3","gravatar_id":"","url":"https://api.github.com/users/schubert","html_url":"https://github.com/schubert","followers_url":"https://api.github.com/users/schubert/followers","following_url":"https://api.github.com/users/schubert/following{/other_user}","gists_url":"https://api.github.com/users/schubert/gists{/gist_id}","starred_url":"https://api.github.com/users/schubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schubert/subscriptions","organizations_url":"https://api.github.com/users/schubert/orgs","repos_url":"https://api.github.com/users/schubert/repos","events_url":"https://api.github.com/users/schubert/events{/privacy}","received_events_url":"https://api.github.com/users/schubert/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T15:53:03Z","updated_at":"2016-11-21T15:53:03Z","body":"I'm good with the idea of having installcheck-* targets. You might want to consider using \"all\" instead of \"world\" since the point is to have a target that runs all tests while having the option to run targeted test suites ."}}
{"actor":{"display_login":"schubert"}}