{"action":"created","issue":{"url":"https://api.github.com/repos/footballradar/VueReactPerf/issues/3","repository_url":"https://api.github.com/repos/footballradar/VueReactPerf","labels_url":"https://api.github.com/repos/footballradar/VueReactPerf/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/footballradar/VueReactPerf/issues/3/comments","events_url":"https://api.github.com/repos/footballradar/VueReactPerf/issues/3/events","html_url":"https://github.com/footballradar/VueReactPerf/pull/3","id":156565339,"number":3,"title":"Use production mode for React that strips out all the warnings","user":{"login":"vjeux","id":197597,"avatar_url":"https://avatars.githubusercontent.com/u/197597?v=3","gravatar_id":"","url":"https://api.github.com/users/vjeux","html_url":"https://github.com/vjeux","followers_url":"https://api.github.com/users/vjeux/followers","following_url":"https://api.github.com/users/vjeux/following{/other_user}","gists_url":"https://api.github.com/users/vjeux/gists{/gist_id}","starred_url":"https://api.github.com/users/vjeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjeux/subscriptions","organizations_url":"https://api.github.com/users/vjeux/orgs","repos_url":"https://api.github.com/users/vjeux/repos","events_url":"https://api.github.com/users/vjeux/events{/privacy}","received_events_url":"https://api.github.com/users/vjeux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-24T17:32:48Z","updated_at":"2016-05-24T19:22:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/footballradar/VueReactPerf/pulls/3","html_url":"https://github.com/footballradar/VueReactPerf/pull/3","diff_url":"https://github.com/footballradar/VueReactPerf/pull/3.diff","patch_url":"https://github.com/footballradar/VueReactPerf/pull/3.patch"},"body":"This benchmark is using the dev mode of React which enables a lot of developer warnings and is not meant to be used in production because it is way slower. This pull request enables production mode and the perf is totally different.\r\n\r\nI bumped the number of games to 500 in both React and Vue and this is what the traces look like:\r\n\r\nReact:\r\n<img width=\"1415\" alt=\"screen shot 2016-05-24 at 10 29 12 am\" src=\"https://cloud.githubusercontent.com/assets/197597/15513750/d5f47670-219a-11e6-8b35-0f4f6a8036f5.png\">\r\n\r\nVue:\r\n<img width=\"1415\" alt=\"screen shot 2016-05-24 at 10 29 16 am\" src=\"https://cloud.githubusercontent.com/assets/197597/15513755/da883014-219a-11e6-860c-f71387716cc9.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/footballradar/VueReactPerf/issues/comments/221375645","html_url":"https://github.com/footballradar/VueReactPerf/pull/3#issuecomment-221375645","issue_url":"https://api.github.com/repos/footballradar/VueReactPerf/issues/3","id":221375645,"user":{"login":"yyx990803","id":499550,"avatar_url":"https://avatars.githubusercontent.com/u/499550?v=3","gravatar_id":"","url":"https://api.github.com/users/yyx990803","html_url":"https://github.com/yyx990803","followers_url":"https://api.github.com/users/yyx990803/followers","following_url":"https://api.github.com/users/yyx990803/following{/other_user}","gists_url":"https://api.github.com/users/yyx990803/gists{/gist_id}","starred_url":"https://api.github.com/users/yyx990803/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyx990803/subscriptions","organizations_url":"https://api.github.com/users/yyx990803/orgs","repos_url":"https://api.github.com/users/yyx990803/repos","events_url":"https://api.github.com/users/yyx990803/events{/privacy}","received_events_url":"https://api.github.com/users/yyx990803/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T19:22:16Z","updated_at":"2016-05-24T19:22:16Z","body":"Just want to chime in here - I was running the two versions locally and it seems the React version is doing way fewer actual updates than the Vue version, it seems the delay is different:\r\n\r\nhttps://github.com/footballradar/VueReactPerf/blob/master/src/react.data.js#L20\r\nhttps://github.com/footballradar/VueReactPerf/blob/master/src/vue.data.js#L36\r\n\r\nBasically the Vue version is doing 10 times the work than the React version?..."}}
{"actor":{"display_login":"yyx990803"}}