{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments/77992300","id":77992300,"diff_hunk":"@@ -114,16 +123,10 @@ func main() {\n \t\t// basePath. After that, logs will go only to stderr.\n \t\tfileOnlyLogger.Printf(\"Dumped system information to: %s\", basePath)\n \n-\t\tvar stdout, stderr bytes.Buffer\n-\n-\t\tcmd := exec.Command(\"tar\", \"-czf\", basePath+\".tar.gz\", basePath)\n-\t\tcmd.Stdout = &stdout\n-\t\tcmd.Stderr = &stderr\n-\t\tif err := cmd.Run(); err != nil {\n-\t\t\tlog.Printf(\"There was an error creating archiving the dumped data, so the dumped system information is stored unarchived in: %s\", basePath)\n+\t\tif err := archive(basePath); err != nil {\n+\t\t\tlog.Printf(\"Could not archive dump data, unarchived data in: %s\", basePath)","path":"main.go","position":28,"original_position":28,"commit_id":"fc03b1de69f36ee30a3fc7305f6233929d81979a","original_commit_id":"fc03b1de69f36ee30a3fc7305f6233929d81979a","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"@philbrookes, I'd like to make the message more concise, and don't scare the user with the word\r\n\"error\", since there is nothing we expect her to do about it.\r\n\r\nOpen to suggestions and feedback, wdyt?","created_at":"2016-09-08T12:01:14Z","updated_at":"2016-09-08T12:01:14Z","html_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/48#discussion_r77992300","pull_request_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments/77992300"},"html":{"href":"https://github.com/feedhenry/fh-system-dump-tool/pull/48#discussion_r77992300"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48","id":84464121,"html_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/48","diff_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/48.diff","patch_url":"https://github.com/feedhenry/fh-system-dump-tool/pull/48.patch","issue_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/48","number":48,"state":"open","locked":false,"title":"Extract archive logic to a function","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"This is an attempt to remove some code from `main`, and has the benefit that we can reimplement `archive` later without depending on `tar` if we decide so.\r\n\r\nAlso reviving the discussion from #40, wrt the error message when `tar` fails.","created_at":"2016-09-08T12:00:12Z","updated_at":"2016-09-08T12:01:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a4d56ce356a6261998e1836687535e1cf9b5a1f","assignee":{"login":"philbrookes","id":1033452,"avatar_url":"https://avatars.githubusercontent.com/u/1033452?v=3","gravatar_id":"","url":"https://api.github.com/users/philbrookes","html_url":"https://github.com/philbrookes","followers_url":"https://api.github.com/users/philbrookes/followers","following_url":"https://api.github.com/users/philbrookes/following{/other_user}","gists_url":"https://api.github.com/users/philbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/philbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbrookes/subscriptions","organizations_url":"https://api.github.com/users/philbrookes/orgs","repos_url":"https://api.github.com/users/philbrookes/repos","events_url":"https://api.github.com/users/philbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/philbrookes/received_events","type":"User","site_admin":false},"assignees":[{"login":"philbrookes","id":1033452,"avatar_url":"https://avatars.githubusercontent.com/u/1033452?v=3","gravatar_id":"","url":"https://api.github.com/users/philbrookes","html_url":"https://github.com/philbrookes","followers_url":"https://api.github.com/users/philbrookes/followers","following_url":"https://api.github.com/users/philbrookes/following{/other_user}","gists_url":"https://api.github.com/users/philbrookes/gists{/gist_id}","starred_url":"https://api.github.com/users/philbrookes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbrookes/subscriptions","organizations_url":"https://api.github.com/users/philbrookes/orgs","repos_url":"https://api.github.com/users/philbrookes/repos","events_url":"https://api.github.com/users/philbrookes/events{/privacy}","received_events_url":"https://api.github.com/users/philbrookes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48/commits","review_comments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48/comments","review_comment_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/48/comments","statuses_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/statuses/fc03b1de69f36ee30a3fc7305f6233929d81979a","head":{"label":"rhcarvalho:refactor-archive","ref":"refactor-archive","sha":"fc03b1de69f36ee30a3fc7305f6233929d81979a","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"repo":{"id":65453502,"name":"fh-system-dump-tool","full_name":"rhcarvalho/fh-system-dump-tool","owner":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhcarvalho/fh-system-dump-tool","description":"This repository contains the system dump tool for the RHMAP On-Prem product","fork":true,"url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool","forks_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/forks","keys_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/teams","hooks_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/hooks","issue_events_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/issues/events{/number}","events_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/events","assignees_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/assignees{/user}","branches_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/branches{/branch}","tags_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/tags","blobs_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/languages","stargazers_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/stargazers","contributors_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/contributors","subscribers_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/subscribers","subscription_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/subscription","commits_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/contents/{+path}","compare_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/merges","archive_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/downloads","issues_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/issues{/number}","pulls_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/labels{/name}","releases_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/releases{/id}","deployments_url":"https://api.github.com/repos/rhcarvalho/fh-system-dump-tool/deployments","created_at":"2016-08-11T08:42:33Z","updated_at":"2016-08-11T08:42:34Z","pushed_at":"2016-09-08T11:18:09Z","git_url":"git://github.com/rhcarvalho/fh-system-dump-tool.git","ssh_url":"git@github.com:rhcarvalho/fh-system-dump-tool.git","clone_url":"https://github.com/rhcarvalho/fh-system-dump-tool.git","svn_url":"https://github.com/rhcarvalho/fh-system-dump-tool","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"69910d24898fcc05c45017a8f26b321a4e27409f","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":63058395,"name":"fh-system-dump-tool","full_name":"feedhenry/fh-system-dump-tool","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/fh-system-dump-tool","description":"This repository contains the system dump tool for the RHMAP On-Prem product","fork":false,"url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool","forks_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/forks","keys_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/teams","hooks_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/events","assignees_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/tags","blobs_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/languages","stargazers_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/subscription","commits_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/merges","archive_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/downloads","issues_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/deployments","created_at":"2016-07-11T10:20:52Z","updated_at":"2016-08-08T14:28:41Z","pushed_at":"2016-09-08T12:00:12Z","git_url":"git://github.com/feedhenry/fh-system-dump-tool.git","ssh_url":"git@github.com:feedhenry/fh-system-dump-tool.git","clone_url":"https://github.com/feedhenry/fh-system-dump-tool.git","svn_url":"https://github.com/feedhenry/fh-system-dump-tool","homepage":null,"size":161,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48"},"html":{"href":"https://github.com/feedhenry/fh-system-dump-tool/pull/48"},"issue":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/48"},"comments":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/fh-system-dump-tool/statuses/fc03b1de69f36ee30a3fc7305f6233929d81979a"}}}}
{"actor":{"display_login":"rhcarvalho"}}