{"action":"created","issue":{"url":"https://api.github.com/repos/zendframework/zf1/issues/695","repository_url":"https://api.github.com/repos/zendframework/zf1","labels_url":"https://api.github.com/repos/zendframework/zf1/issues/695/labels{/name}","comments_url":"https://api.github.com/repos/zendframework/zf1/issues/695/comments","events_url":"https://api.github.com/repos/zendframework/zf1/issues/695/events","html_url":"https://github.com/zendframework/zf1/pull/695","id":154445248,"number":695,"title":"Fixed 'Undefined index'","user":{"login":"ephemeralsnow","id":4017914,"avatar_url":"https://avatars.githubusercontent.com/u/4017914?v=3","gravatar_id":"","url":"https://api.github.com/users/ephemeralsnow","html_url":"https://github.com/ephemeralsnow","followers_url":"https://api.github.com/users/ephemeralsnow/followers","following_url":"https://api.github.com/users/ephemeralsnow/following{/other_user}","gists_url":"https://api.github.com/users/ephemeralsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/ephemeralsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ephemeralsnow/subscriptions","organizations_url":"https://api.github.com/users/ephemeralsnow/orgs","repos_url":"https://api.github.com/users/ephemeralsnow/repos","events_url":"https://api.github.com/users/ephemeralsnow/events{/privacy}","received_events_url":"https://api.github.com/users/ephemeralsnow/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zendframework/zf1/labels/unit%20test%20needed","name":"unit test needed","color":"fbca04"},{"url":"https://api.github.com/repos/zendframework/zf1/labels/Zend_Controller","name":"Zend_Controller","color":"008000"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-12T10:08:23Z","updated_at":"2016-05-12T13:03:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zendframework/zf1/pulls/695","html_url":"https://github.com/zendframework/zf1/pull/695","diff_url":"https://github.com/zendframework/zf1/pull/695.diff","patch_url":"https://github.com/zendframework/zf1/pull/695.patch"},"body":"```\r\nUndefined index: xxx\r\n\r\nZendFramework-1.12.18/library/Zend/Controller/Router/Route.php:328\r\nZendFramework-1.12.18/library/Zend/Controller/Router/Route/Chain.php:118\r\nZendFramework-1.12.18/library/Zend/Controller/Router/Rewrite.php:410\r\nZendFramework-1.12.18/library/Zend/Controller/Front.php:911\r\nZendFramework-1.12.18/library/Zend/Test/PHPUnit/ControllerTestCase.php:194\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/zendframework/zf1/issues/comments/218750344","html_url":"https://github.com/zendframework/zf1/pull/695#issuecomment-218750344","issue_url":"https://api.github.com/repos/zendframework/zf1/issues/695","id":218750344,"user":{"login":"ionux","id":6451654,"avatar_url":"https://avatars.githubusercontent.com/u/6451654?v=3","gravatar_id":"","url":"https://api.github.com/users/ionux","html_url":"https://github.com/ionux","followers_url":"https://api.github.com/users/ionux/followers","following_url":"https://api.github.com/users/ionux/following{/other_user}","gists_url":"https://api.github.com/users/ionux/gists{/gist_id}","starred_url":"https://api.github.com/users/ionux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionux/subscriptions","organizations_url":"https://api.github.com/users/ionux/orgs","repos_url":"https://api.github.com/users/ionux/repos","events_url":"https://api.github.com/users/ionux/events{/privacy}","received_events_url":"https://api.github.com/users/ionux/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T13:03:50Z","updated_at":"2016-05-12T13:03:50Z","body":"Yes, but then your comment is confusing, imho:\r\n```php\r\n// Empty variable? Replace with the default value.\r\n```\r\n\r\nIn that case if the default value is null anyway, assigning the null character terminator \"\\0\" might be a good idea to use if you want isset() to pass the check.\r\n\r\nBut, to my original comment, since isset() is a language construct it's much faster in benchmarks.  Plus there's a quirk in the behavior of array_key_exits() that you'll have to watch out for:\r\n```\r\nNote:\r\nFor backward compatibility reasons, array_key_exists() will also return TRUE if key is a\r\nproperty defined within an object given as array. This behaviour should not be relied\r\nupon, and care should be taken to ensure that array is an array.\r\n```\r\n\r\nI'm not picking on your commit, though - I just had a very similar issue at work this week so the problem space is really fresh on my mind. ;)\r\n"}}