{"action":"created","issue":{"url":"https://api.github.com/repos/coderefinery/autocmake/issues/179","repository_url":"https://api.github.com/repos/coderefinery/autocmake","labels_url":"https://api.github.com/repos/coderefinery/autocmake/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/coderefinery/autocmake/issues/179/comments","events_url":"https://api.github.com/repos/coderefinery/autocmake/issues/179/events","html_url":"https://github.com/coderefinery/autocmake/pull/179","id":189664027,"number":179,"title":"Use only Git commands in `git_info`","user":{"login":"robertodr","id":3708689,"avatar_url":"https://avatars.githubusercontent.com/u/3708689?v=3","gravatar_id":"","url":"https://api.github.com/users/robertodr","html_url":"https://github.com/robertodr","followers_url":"https://api.github.com/users/robertodr/followers","following_url":"https://api.github.com/users/robertodr/following{/other_user}","gists_url":"https://api.github.com/users/robertodr/gists{/gist_id}","starred_url":"https://api.github.com/users/robertodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertodr/subscriptions","organizations_url":"https://api.github.com/users/robertodr/orgs","repos_url":"https://api.github.com/users/robertodr/repos","events_url":"https://api.github.com/users/robertodr/events{/privacy}","received_events_url":"https://api.github.com/users/robertodr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-16T10:46:39Z","updated_at":"2016-11-21T18:29:58Z","closed_at":"2016-11-18T17:23:23Z","pull_request":{"url":"https://api.github.com/repos/coderefinery/autocmake/pulls/179","html_url":"https://github.com/coderefinery/autocmake/pull/179","diff_url":"https://github.com/coderefinery/autocmake/pull/179.diff","patch_url":"https://github.com/coderefinery/autocmake/pull/179.patch"},"body":"This PR removes the need for CMake regexes to find the commit author name.\r\nMoreover, the header can be generated in a custom directory and with a custom name.\r\n\r\n@bast @miroi I have fixed the test and fine-tuned the implementation:\r\n1. I have substituted the `add_custom_command` in `git_info.cmake` with a CMake function `generate_git_info_header` (the name can be changed) to fine-tune how the header is generated. The user can now choose location and name. If no arguments are provided to the function, this falls back to the previous implementation, i.e. generate a `git_info.h` header in `${PROJECT_BINARY_DIR}`\r\n2. I have remove the `git_info_sub.cmake` file, since it is no longer necessary."},"comment":{"url":"https://api.github.com/repos/coderefinery/autocmake/issues/comments/262024921","html_url":"https://github.com/coderefinery/autocmake/pull/179#issuecomment-262024921","issue_url":"https://api.github.com/repos/coderefinery/autocmake/issues/179","id":262024921,"user":{"login":"robertodr","id":3708689,"avatar_url":"https://avatars.githubusercontent.com/u/3708689?v=3","gravatar_id":"","url":"https://api.github.com/users/robertodr","html_url":"https://github.com/robertodr","followers_url":"https://api.github.com/users/robertodr/followers","following_url":"https://api.github.com/users/robertodr/following{/other_user}","gists_url":"https://api.github.com/users/robertodr/gists{/gist_id}","starred_url":"https://api.github.com/users/robertodr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertodr/subscriptions","organizations_url":"https://api.github.com/users/robertodr/orgs","repos_url":"https://api.github.com/users/robertodr/repos","events_url":"https://api.github.com/users/robertodr/events{/privacy}","received_events_url":"https://api.github.com/users/robertodr/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T18:29:58Z","updated_at":"2016-11-21T18:29:58Z","body":"I left the default arguments not to hurt existing code using this module. I fully agree with you, explicit is better than implicit."}}
{"actor":{"display_login":"robertodr"}}