{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/nomad/issues/1736","repository_url":"https://api.github.com/repos/hashicorp/nomad","labels_url":"https://api.github.com/repos/hashicorp/nomad/issues/1736/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/nomad/issues/1736/comments","events_url":"https://api.github.com/repos/hashicorp/nomad/issues/1736/events","html_url":"https://github.com/hashicorp/nomad/pull/1736","id":178910834,"number":1736,"title":"Adding support for log driver settings and volume bindings","user":{"login":"Fluxxo","id":10084347,"avatar_url":"https://avatars.githubusercontent.com/u/10084347?v=3","gravatar_id":"","url":"https://api.github.com/users/Fluxxo","html_url":"https://github.com/Fluxxo","followers_url":"https://api.github.com/users/Fluxxo/followers","following_url":"https://api.github.com/users/Fluxxo/following{/other_user}","gists_url":"https://api.github.com/users/Fluxxo/gists{/gist_id}","starred_url":"https://api.github.com/users/Fluxxo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fluxxo/subscriptions","organizations_url":"https://api.github.com/users/Fluxxo/orgs","repos_url":"https://api.github.com/users/Fluxxo/repos","events_url":"https://api.github.com/users/Fluxxo/events{/privacy}","received_events_url":"https://api.github.com/users/Fluxxo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-23T15:47:08Z","updated_at":"2016-09-28T22:02:58Z","closed_at":"2016-09-28T22:02:58Z","pull_request":{"url":"https://api.github.com/repos/hashicorp/nomad/pulls/1736","html_url":"https://github.com/hashicorp/nomad/pull/1736","diff_url":"https://github.com/hashicorp/nomad/pull/1736.diff","patch_url":"https://github.com/hashicorp/nomad/pull/1736.patch"},"body":"This PR adds support for log driver settings passed through the docker run command.\r\n\r\nDocker has various log-drivers and coming with that a couple of log options for each drivers.\r\nAs of now, nomad would only support syslog writing to a nomad specific location. \r\n\r\nTo use nomad in an environment with an existing logging infrastructure like awslog or SPLUNK, it is necessary to pass the right combination of settings to the docker run command.\r\n\r\nThis PR enables to insert a logging options block in the docker driver config in a nomad manifest.\r\nFurthermore, it is now possible to mount host folders into containers and to use data volume container.\r\n\r\nIt could look like this:\r\n\r\n`config {\r\n  image = \"redis:latest\"\r\n  port_map {\r\n    db = 6379\r\n  }\r\n  \r\n  volumes = [\"/path/on/host:/path/in/container\", \"...\", \"...\"]\r\n  volumes_from = [\r\n    \"datastorage\"\r\n  ]\r\n\r\n  logging {\r\n    type = \"syslog\"\r\n    config { \r\n      syslog-address = \"tcp://127.0.0.1:1514\"\r\n      tag = \"your/logging/tag/{{.ImageName}}/{{.Name}}\" \r\n      syslog-format = \"rfc3164\"\r\n    }\r\n  }\r\n}`\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/hashicorp/nomad/issues/comments/250314524","html_url":"https://github.com/hashicorp/nomad/pull/1736#issuecomment-250314524","issue_url":"https://api.github.com/repos/hashicorp/nomad/issues/1736","id":250314524,"user":{"login":"schmichael","id":113362,"avatar_url":"https://avatars.githubusercontent.com/u/113362?v=3","gravatar_id":"","url":"https://api.github.com/users/schmichael","html_url":"https://github.com/schmichael","followers_url":"https://api.github.com/users/schmichael/followers","following_url":"https://api.github.com/users/schmichael/following{/other_user}","gists_url":"https://api.github.com/users/schmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/schmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmichael/subscriptions","organizations_url":"https://api.github.com/users/schmichael/orgs","repos_url":"https://api.github.com/users/schmichael/repos","events_url":"https://api.github.com/users/schmichael/events{/privacy}","received_events_url":"https://api.github.com/users/schmichael/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T22:02:58Z","updated_at":"2016-09-28T22:02:58Z","body":"Thanks for the PR! We on the nomad team wanted to put these settings behind an off-by-default configuration option since they do pose some security issues.\r\n\r\nFollow #1767 if you're interested in knowing when this feature lands in master. It will be in the 0.5 release which should be out in the next few weeks."}}
{"actor":{"display_login":"schmichael"}}