{"action":"created","issue":{"url":"https://api.github.com/repos/atoum/atoum/issues/569","repository_url":"https://api.github.com/repos/atoum/atoum","labels_url":"https://api.github.com/repos/atoum/atoum/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/atoum/atoum/issues/569/comments","events_url":"https://api.github.com/repos/atoum/atoum/issues/569/events","html_url":"https://github.com/atoum/atoum/pull/569","id":130789193,"number":569,"title":"Cache resolved asserters","user":{"login":"jubianchi","id":327237,"avatar_url":"https://avatars.githubusercontent.com/u/327237?v=3","gravatar_id":"","url":"https://api.github.com/users/jubianchi","html_url":"https://github.com/jubianchi","followers_url":"https://api.github.com/users/jubianchi/followers","following_url":"https://api.github.com/users/jubianchi/following{/other_user}","gists_url":"https://api.github.com/users/jubianchi/gists{/gist_id}","starred_url":"https://api.github.com/users/jubianchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jubianchi/subscriptions","organizations_url":"https://api.github.com/users/jubianchi/orgs","repos_url":"https://api.github.com/users/jubianchi/repos","events_url":"https://api.github.com/users/jubianchi/events{/privacy}","received_events_url":"https://api.github.com/users/jubianchi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atoum/atoum/labels/enhancement","name":"enhancement","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-02T19:25:43Z","updated_at":"2016-02-03T08:55:55Z","closed_at":"2016-02-02T22:49:23Z","pull_request":{"url":"https://api.github.com/repos/atoum/atoum/pulls/569","html_url":"https://github.com/atoum/atoum/pull/569","diff_url":"https://github.com/atoum/atoum/pull/569.diff","patch_url":"https://github.com/atoum/atoum/pull/569.patch"},"body":"This tiny patch let us improve performances on atoum tests (this is really clear with inline engine).\r\n\r\n_All the metrics above were generated using the [phpunit-extension](https://github.com/atoum/phpunit-extension) and the [PHP-DI test suite](https://github.com/jubianchi/PHP-DI/compare/e6f30a337cdbff13a1dd9ac73c59654ce44177ab...HEAD) (`vendor/bin/atoum -d tests/UnitTest/ tests/IntegrationTest`)_\r\n\r\n### Before\r\n\r\n```\r\nPHP 7.0.0 (cli) (built: Dec  2 2015 13:06:23) ( NTS )\r\nCopyright (c) 1997-2015 The PHP Group\r\nZend Engine v3.0.0, Copyright (c) 1998-2015 Zend Technologies\r\n    with blackfire v1.9.0, https://blackfire.io, by Blackfireio Inc.\r\n\r\n> Total tests duration: 29.46 seconds.\r\n> Total tests memory usage: 4.00 Mb.\r\n> Running duration: 29.53 seconds.\r\n```\r\n\r\n### After\r\n\r\n```\r\nPHP 7.0.0 (cli) (built: Dec  2 2015 13:06:23) ( NTS )\r\nCopyright (c) 1997-2015 The PHP Group\r\nZend Engine v3.0.0, Copyright (c) 1998-2015 Zend Technologies\r\n    with blackfire v1.9.0, https://blackfire.io, by Blackfireio Inc.\r\n\r\n> Total tests duration: 1.84 seconds.\r\n> Total tests memory usage: 4.00 Mb.\r\n> Running duration: 1.89 seconds.\r\n```\r\n\r\nHere is the diff generated with blackfire (`blackfire run --samples=5 vendor/bin/atoum -d tests/UnitTest/ tests/IntegrationTest`):\r\n\r\n![blackfire](https://cloud.githubusercontent.com/assets/327237/12761381/0f6a008a-c9eb-11e5-838b-46152d009fc9.png)\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/atoum/atoum/issues/comments/179101349","html_url":"https://github.com/atoum/atoum/pull/569#issuecomment-179101349","issue_url":"https://api.github.com/repos/atoum/atoum/issues/569","id":179101349,"user":{"login":"mageekguy","id":457534,"avatar_url":"https://avatars.githubusercontent.com/u/457534?v=3","gravatar_id":"","url":"https://api.github.com/users/mageekguy","html_url":"https://github.com/mageekguy","followers_url":"https://api.github.com/users/mageekguy/followers","following_url":"https://api.github.com/users/mageekguy/following{/other_user}","gists_url":"https://api.github.com/users/mageekguy/gists{/gist_id}","starred_url":"https://api.github.com/users/mageekguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mageekguy/subscriptions","organizations_url":"https://api.github.com/users/mageekguy/orgs","repos_url":"https://api.github.com/users/mageekguy/repos","events_url":"https://api.github.com/users/mageekguy/events{/privacy}","received_events_url":"https://api.github.com/users/mageekguy/received_events","type":"User","site_admin":false},"created_at":"2016-02-03T08:55:55Z","updated_at":"2016-02-03T08:55:55Z","body":"And again, a huge warning: the impact of this patch will be less impressive with other engines (fork is main bottleneck with other engines, and with a fork, the cache is not so efficient because it will be recreated in each subprocess)!"}}