{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-tools/pulls/comments/78023246","id":78023246,"diff_hunk":"@@ -199,19 +209,32 @@ def read_metrics(self):\n             Keyword arguments:\n             None\n         '''\n+        markfordelete = []\n         metrics = []\n+        metrics_folders = os.listdir(self.metrics_directory)\n+        random.shuffle(metrics_folders)\n+\n+        for shardname in metrics_folders:\n+            for filename in os.listdir(os.path.join(self.metrics_directory, shardname)):\n+                ext = os.path.splitext(filename)[-1][1:].lower().strip()\n+\n+                # We only want to load yaml files\n+                if ext not in ['yml', 'yaml']:\n+                    continue\n+","path":"openshift_tools/monitoring/metricmanager.py","position":77,"original_position":77,"commit_id":"86c449a14456be10338b45a173db8b5685d862e1","original_commit_id":"86c449a14456be10338b45a173db8b5685d862e1","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars.githubusercontent.com/u/1385770?v=3","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"body":"doc that we could delete file after read if empty.","created_at":"2016-09-08T14:57:34Z","updated_at":"2016-09-08T14:57:34Z","html_url":"https://github.com/openshift/openshift-tools/pull/1132#discussion_r78023246","pull_request_url":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-tools/pulls/comments/78023246"},"html":{"href":"https://github.com/openshift/openshift-tools/pull/1132#discussion_r78023246"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132","id":84485150,"html_url":"https://github.com/openshift/openshift-tools/pull/1132","diff_url":"https://github.com/openshift/openshift-tools/pull/1132.diff","patch_url":"https://github.com/openshift/openshift-tools/pull/1132.patch","issue_url":"https://api.github.com/repos/openshift/openshift-tools/issues/1132","number":1132,"state":"open","locked":false,"title":"adding sharding based on first 2 character to zagg data files","user":{"login":"ivanhorvath","id":2781042,"avatar_url":"https://avatars.githubusercontent.com/u/2781042?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanhorvath","html_url":"https://github.com/ivanhorvath","followers_url":"https://api.github.com/users/ivanhorvath/followers","following_url":"https://api.github.com/users/ivanhorvath/following{/other_user}","gists_url":"https://api.github.com/users/ivanhorvath/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanhorvath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanhorvath/subscriptions","organizations_url":"https://api.github.com/users/ivanhorvath/orgs","repos_url":"https://api.github.com/users/ivanhorvath/repos","events_url":"https://api.github.com/users/ivanhorvath/events{/privacy}","received_events_url":"https://api.github.com/users/ivanhorvath/received_events","type":"User","site_admin":false},"body":"The two changes to None comparison I changed because pylint was crying about it.","created_at":"2016-09-08T14:11:44Z","updated_at":"2016-09-08T14:57:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf6b9742e1e2c742f2cfdc3b7f81d086e3103de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-tools/issues/1132/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-tools/statuses/86c449a14456be10338b45a173db8b5685d862e1","head":{"label":"ivanhorvath:metricmanager_changes","ref":"metricmanager_changes","sha":"86c449a14456be10338b45a173db8b5685d862e1","user":{"login":"ivanhorvath","id":2781042,"avatar_url":"https://avatars.githubusercontent.com/u/2781042?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanhorvath","html_url":"https://github.com/ivanhorvath","followers_url":"https://api.github.com/users/ivanhorvath/followers","following_url":"https://api.github.com/users/ivanhorvath/following{/other_user}","gists_url":"https://api.github.com/users/ivanhorvath/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanhorvath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanhorvath/subscriptions","organizations_url":"https://api.github.com/users/ivanhorvath/orgs","repos_url":"https://api.github.com/users/ivanhorvath/repos","events_url":"https://api.github.com/users/ivanhorvath/events{/privacy}","received_events_url":"https://api.github.com/users/ivanhorvath/received_events","type":"User","site_admin":false},"repo":{"id":59756309,"name":"openshift-tools","full_name":"ivanhorvath/openshift-tools","owner":{"login":"ivanhorvath","id":2781042,"avatar_url":"https://avatars.githubusercontent.com/u/2781042?v=3","gravatar_id":"","url":"https://api.github.com/users/ivanhorvath","html_url":"https://github.com/ivanhorvath","followers_url":"https://api.github.com/users/ivanhorvath/followers","following_url":"https://api.github.com/users/ivanhorvath/following{/other_user}","gists_url":"https://api.github.com/users/ivanhorvath/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanhorvath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanhorvath/subscriptions","organizations_url":"https://api.github.com/users/ivanhorvath/orgs","repos_url":"https://api.github.com/users/ivanhorvath/repos","events_url":"https://api.github.com/users/ivanhorvath/events{/privacy}","received_events_url":"https://api.github.com/users/ivanhorvath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivanhorvath/openshift-tools","description":"A public repository of scripts used by OpenShift Operations for various purposes","fork":true,"url":"https://api.github.com/repos/ivanhorvath/openshift-tools","forks_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/forks","keys_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/teams","hooks_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/hooks","issue_events_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/issues/events{/number}","events_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/events","assignees_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/assignees{/user}","branches_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/branches{/branch}","tags_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/tags","blobs_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/languages","stargazers_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/stargazers","contributors_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/contributors","subscribers_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/subscribers","subscription_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/subscription","commits_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/contents/{+path}","compare_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/merges","archive_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/downloads","issues_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/issues{/number}","pulls_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/labels{/name}","releases_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/releases{/id}","deployments_url":"https://api.github.com/repos/ivanhorvath/openshift-tools/deployments","created_at":"2016-05-26T14:19:54Z","updated_at":"2016-05-26T14:20:00Z","pushed_at":"2016-09-08T14:37:27Z","git_url":"git://github.com/ivanhorvath/openshift-tools.git","ssh_url":"git@github.com:ivanhorvath/openshift-tools.git","clone_url":"https://github.com/ivanhorvath/openshift-tools.git","svn_url":"https://github.com/ivanhorvath/openshift-tools","homepage":null,"size":4580,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stg"}},"base":{"label":"openshift:stg","ref":"stg","sha":"53ff0df63971192d06eaeb33e8616bd5f84df207","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":36827699,"name":"openshift-tools","full_name":"openshift/openshift-tools","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-tools","description":"A public repository of scripts used by OpenShift Operations for various purposes","fork":false,"url":"https://api.github.com/repos/openshift/openshift-tools","forks_url":"https://api.github.com/repos/openshift/openshift-tools/forks","keys_url":"https://api.github.com/repos/openshift/openshift-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-tools/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-tools/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-tools/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-tools/events","assignees_url":"https://api.github.com/repos/openshift/openshift-tools/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-tools/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-tools/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-tools/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-tools/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-tools/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-tools/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-tools/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-tools/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-tools/merges","archive_url":"https://api.github.com/repos/openshift/openshift-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-tools/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-tools/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-tools/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-tools/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-tools/deployments","created_at":"2015-06-03T20:09:22Z","updated_at":"2016-09-02T09:42:30Z","pushed_at":"2016-09-08T14:37:27Z","git_url":"git://github.com/openshift/openshift-tools.git","ssh_url":"git@github.com:openshift/openshift-tools.git","clone_url":"https://github.com/openshift/openshift-tools.git","svn_url":"https://github.com/openshift/openshift-tools","homepage":null,"size":4774,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":19,"forks":36,"open_issues":19,"watchers":17,"default_branch":"stg"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132"},"html":{"href":"https://github.com/openshift/openshift-tools/pull/1132"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-tools/issues/1132"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-tools/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-tools/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-tools/statuses/86c449a14456be10338b45a173db8b5685d862e1"}}}}
{"actor":{"display_login":"kwoodson"}}