{"action":"created","comment":{"url":"https://api.github.com/repos/naver/ngrinder/pulls/comments/57659367","id":57659367,"diff_hunk":"@@ -268,85 +97,10 @@ protected void initPluginDescriptor(DefaultModuleDescriptorFactory modules, Stri\n \t\tif (defaultPlugin != null) {\n \t\t\tpluginClasses.add(defaultPlugin);\n \t\t}\n-\t\tif (plugins == null) {\n-\t\t\treturn pluginClasses;\n-\t\t}\n-\t\tpluginClasses.addAll(plugins.getPluginAccessor().getEnabledModulesByClass(moduleClass));\n-\t\treturn pluginClasses;\n-\t}\n-\n-\t/**\n-\t * Get plugins by module descriptor and module class.<br/>\n-\t * This method puts the given default plugin at a head of returned plugin list.\n-\t *\n-\t * @param <M>              module type\n-\t * @param moduleDescriptor module descriptor\n-\t * @param moduleClass      module class\n-\t * @param defaultPlugin    default plugin\n-\t * @return plugin list\n-\t */\n-\tpublic <M> List<M> getEnabledModulesByDescriptorAndClass(\n-\t\t\tfinal Class<? extends ModuleDescriptor<M>> moduleDescriptor, final Class<M> moduleClass,\n-\t\t\tM defaultPlugin) {\n-\t\tArrayList<M> pluginClasses = new ArrayList<M>();\n-\t\tif (defaultPlugin != null) {\n-\t\t\tpluginClasses.add(defaultPlugin);\n-\t\t}\n-\t\tif (plugins == null) {\n-\t\t\treturn pluginClasses;\n+\t\tif (manager.getExtensions(moduleClass).size() > 0) {","path":"ngrinder-controller/src/main/java/org/ngrinder/infra/plugin/PluginManager.java","position":265,"original_position":265,"commit_id":"c2116f632359d826b758b9c8caf844569b9fbe47","original_commit_id":"c2116f632359d826b758b9c8caf844569b9fbe47","user":{"login":"junoyoon","id":1000705,"avatar_url":"https://avatars.githubusercontent.com/u/1000705?v=3","gravatar_id":"","url":"https://api.github.com/users/junoyoon","html_url":"https://github.com/junoyoon","followers_url":"https://api.github.com/users/junoyoon/followers","following_url":"https://api.github.com/users/junoyoon/following{/other_user}","gists_url":"https://api.github.com/users/junoyoon/gists{/gist_id}","starred_url":"https://api.github.com/users/junoyoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junoyoon/subscriptions","organizations_url":"https://api.github.com/users/junoyoon/orgs","repos_url":"https://api.github.com/users/junoyoon/repos","events_url":"https://api.github.com/users/junoyoon/events{/privacy}","received_events_url":"https://api.github.com/users/junoyoon/received_events","type":"User","site_admin":false},"body":"동의","created_at":"2016-03-29T01:01:13Z","updated_at":"2016-03-29T01:01:13Z","html_url":"https://github.com/naver/ngrinder/pull/95#discussion_r57659367","pull_request_url":"https://api.github.com/repos/naver/ngrinder/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/naver/ngrinder/pulls/comments/57659367"},"html":{"href":"https://github.com/naver/ngrinder/pull/95#discussion_r57659367"},"pull_request":{"href":"https://api.github.com/repos/naver/ngrinder/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/naver/ngrinder/pulls/95","id":64298486,"html_url":"https://github.com/naver/ngrinder/pull/95","diff_url":"https://github.com/naver/ngrinder/pull/95.diff","patch_url":"https://github.com/naver/ngrinder/pull/95.patch","issue_url":"https://api.github.com/repos/naver/ngrinder/issues/95","number":95,"state":"open","locked":false,"title":" #15 Plugin Framework for Java (PF4J)","user":{"login":"songeunwoo","id":16470009,"avatar_url":"https://avatars.githubusercontent.com/u/16470009?v=3","gravatar_id":"","url":"https://api.github.com/users/songeunwoo","html_url":"https://github.com/songeunwoo","followers_url":"https://api.github.com/users/songeunwoo/followers","following_url":"https://api.github.com/users/songeunwoo/following{/other_user}","gists_url":"https://api.github.com/users/songeunwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/songeunwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songeunwoo/subscriptions","organizations_url":"https://api.github.com/users/songeunwoo/orgs","repos_url":"https://api.github.com/users/songeunwoo/repos","events_url":"https://api.github.com/users/songeunwoo/events{/privacy}","received_events_url":"https://api.github.com/users/songeunwoo/received_events","type":"User","site_admin":false},"body":"\r\n- remove atlassian plugin and append Plugin Framework for Java (PF4J)\r\n- Plugin Framework for Java override find & factory & manager\r\n- add class sso filter interface\r\n\r\n@junoyoon \r\nPlease review the code.\r\n\r\nThank you.","created_at":"2016-03-28T07:50:51Z","updated_at":"2016-03-29T01:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73012af69450cc943472abd53d110279231d94dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/naver/ngrinder/pulls/95/commits","review_comments_url":"https://api.github.com/repos/naver/ngrinder/pulls/95/comments","review_comment_url":"https://api.github.com/repos/naver/ngrinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/naver/ngrinder/issues/95/comments","statuses_url":"https://api.github.com/repos/naver/ngrinder/statuses/c2116f632359d826b758b9c8caf844569b9fbe47","head":{"label":"songeunwoo:feature/ngrinder-15","ref":"feature/ngrinder-15","sha":"c2116f632359d826b758b9c8caf844569b9fbe47","user":{"login":"songeunwoo","id":16470009,"avatar_url":"https://avatars.githubusercontent.com/u/16470009?v=3","gravatar_id":"","url":"https://api.github.com/users/songeunwoo","html_url":"https://github.com/songeunwoo","followers_url":"https://api.github.com/users/songeunwoo/followers","following_url":"https://api.github.com/users/songeunwoo/following{/other_user}","gists_url":"https://api.github.com/users/songeunwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/songeunwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songeunwoo/subscriptions","organizations_url":"https://api.github.com/users/songeunwoo/orgs","repos_url":"https://api.github.com/users/songeunwoo/repos","events_url":"https://api.github.com/users/songeunwoo/events{/privacy}","received_events_url":"https://api.github.com/users/songeunwoo/received_events","type":"User","site_admin":false},"repo":{"id":54096900,"name":"ngrinder","full_name":"songeunwoo/ngrinder","owner":{"login":"songeunwoo","id":16470009,"avatar_url":"https://avatars.githubusercontent.com/u/16470009?v=3","gravatar_id":"","url":"https://api.github.com/users/songeunwoo","html_url":"https://github.com/songeunwoo","followers_url":"https://api.github.com/users/songeunwoo/followers","following_url":"https://api.github.com/users/songeunwoo/following{/other_user}","gists_url":"https://api.github.com/users/songeunwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/songeunwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/songeunwoo/subscriptions","organizations_url":"https://api.github.com/users/songeunwoo/orgs","repos_url":"https://api.github.com/users/songeunwoo/repos","events_url":"https://api.github.com/users/songeunwoo/events{/privacy}","received_events_url":"https://api.github.com/users/songeunwoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/songeunwoo/ngrinder","description":"enterprise level performance testing solution","fork":true,"url":"https://api.github.com/repos/songeunwoo/ngrinder","forks_url":"https://api.github.com/repos/songeunwoo/ngrinder/forks","keys_url":"https://api.github.com/repos/songeunwoo/ngrinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/songeunwoo/ngrinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/songeunwoo/ngrinder/teams","hooks_url":"https://api.github.com/repos/songeunwoo/ngrinder/hooks","issue_events_url":"https://api.github.com/repos/songeunwoo/ngrinder/issues/events{/number}","events_url":"https://api.github.com/repos/songeunwoo/ngrinder/events","assignees_url":"https://api.github.com/repos/songeunwoo/ngrinder/assignees{/user}","branches_url":"https://api.github.com/repos/songeunwoo/ngrinder/branches{/branch}","tags_url":"https://api.github.com/repos/songeunwoo/ngrinder/tags","blobs_url":"https://api.github.com/repos/songeunwoo/ngrinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/songeunwoo/ngrinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/songeunwoo/ngrinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/songeunwoo/ngrinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/songeunwoo/ngrinder/statuses/{sha}","languages_url":"https://api.github.com/repos/songeunwoo/ngrinder/languages","stargazers_url":"https://api.github.com/repos/songeunwoo/ngrinder/stargazers","contributors_url":"https://api.github.com/repos/songeunwoo/ngrinder/contributors","subscribers_url":"https://api.github.com/repos/songeunwoo/ngrinder/subscribers","subscription_url":"https://api.github.com/repos/songeunwoo/ngrinder/subscription","commits_url":"https://api.github.com/repos/songeunwoo/ngrinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/songeunwoo/ngrinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/songeunwoo/ngrinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/songeunwoo/ngrinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/songeunwoo/ngrinder/contents/{+path}","compare_url":"https://api.github.com/repos/songeunwoo/ngrinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/songeunwoo/ngrinder/merges","archive_url":"https://api.github.com/repos/songeunwoo/ngrinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/songeunwoo/ngrinder/downloads","issues_url":"https://api.github.com/repos/songeunwoo/ngrinder/issues{/number}","pulls_url":"https://api.github.com/repos/songeunwoo/ngrinder/pulls{/number}","milestones_url":"https://api.github.com/repos/songeunwoo/ngrinder/milestones{/number}","notifications_url":"https://api.github.com/repos/songeunwoo/ngrinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/songeunwoo/ngrinder/labels{/name}","releases_url":"https://api.github.com/repos/songeunwoo/ngrinder/releases{/id}","deployments_url":"https://api.github.com/repos/songeunwoo/ngrinder/deployments","created_at":"2016-03-17T07:17:35Z","updated_at":"2016-03-17T07:17:38Z","pushed_at":"2016-03-28T07:42:40Z","git_url":"git://github.com/songeunwoo/ngrinder.git","ssh_url":"git@github.com:songeunwoo/ngrinder.git","clone_url":"https://github.com/songeunwoo/ngrinder.git","svn_url":"https://github.com/songeunwoo/ngrinder","homepage":"naver.github.io/ngrinder","size":32346,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"naver:master","ref":"master","sha":"f5d65a0c0cda0013a833cdb6442aa98f79bb8ec2","user":{"login":"naver","id":6589568,"avatar_url":"https://avatars.githubusercontent.com/u/6589568?v=3","gravatar_id":"","url":"https://api.github.com/users/naver","html_url":"https://github.com/naver","followers_url":"https://api.github.com/users/naver/followers","following_url":"https://api.github.com/users/naver/following{/other_user}","gists_url":"https://api.github.com/users/naver/gists{/gist_id}","starred_url":"https://api.github.com/users/naver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naver/subscriptions","organizations_url":"https://api.github.com/users/naver/orgs","repos_url":"https://api.github.com/users/naver/repos","events_url":"https://api.github.com/users/naver/events{/privacy}","received_events_url":"https://api.github.com/users/naver/received_events","type":"Organization","site_admin":false},"repo":{"id":4709330,"name":"ngrinder","full_name":"naver/ngrinder","owner":{"login":"naver","id":6589568,"avatar_url":"https://avatars.githubusercontent.com/u/6589568?v=3","gravatar_id":"","url":"https://api.github.com/users/naver","html_url":"https://github.com/naver","followers_url":"https://api.github.com/users/naver/followers","following_url":"https://api.github.com/users/naver/following{/other_user}","gists_url":"https://api.github.com/users/naver/gists{/gist_id}","starred_url":"https://api.github.com/users/naver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naver/subscriptions","organizations_url":"https://api.github.com/users/naver/orgs","repos_url":"https://api.github.com/users/naver/repos","events_url":"https://api.github.com/users/naver/events{/privacy}","received_events_url":"https://api.github.com/users/naver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/naver/ngrinder","description":"enterprise level performance testing solution","fork":false,"url":"https://api.github.com/repos/naver/ngrinder","forks_url":"https://api.github.com/repos/naver/ngrinder/forks","keys_url":"https://api.github.com/repos/naver/ngrinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naver/ngrinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naver/ngrinder/teams","hooks_url":"https://api.github.com/repos/naver/ngrinder/hooks","issue_events_url":"https://api.github.com/repos/naver/ngrinder/issues/events{/number}","events_url":"https://api.github.com/repos/naver/ngrinder/events","assignees_url":"https://api.github.com/repos/naver/ngrinder/assignees{/user}","branches_url":"https://api.github.com/repos/naver/ngrinder/branches{/branch}","tags_url":"https://api.github.com/repos/naver/ngrinder/tags","blobs_url":"https://api.github.com/repos/naver/ngrinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naver/ngrinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naver/ngrinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/naver/ngrinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naver/ngrinder/statuses/{sha}","languages_url":"https://api.github.com/repos/naver/ngrinder/languages","stargazers_url":"https://api.github.com/repos/naver/ngrinder/stargazers","contributors_url":"https://api.github.com/repos/naver/ngrinder/contributors","subscribers_url":"https://api.github.com/repos/naver/ngrinder/subscribers","subscription_url":"https://api.github.com/repos/naver/ngrinder/subscription","commits_url":"https://api.github.com/repos/naver/ngrinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/naver/ngrinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/naver/ngrinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/naver/ngrinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/naver/ngrinder/contents/{+path}","compare_url":"https://api.github.com/repos/naver/ngrinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naver/ngrinder/merges","archive_url":"https://api.github.com/repos/naver/ngrinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naver/ngrinder/downloads","issues_url":"https://api.github.com/repos/naver/ngrinder/issues{/number}","pulls_url":"https://api.github.com/repos/naver/ngrinder/pulls{/number}","milestones_url":"https://api.github.com/repos/naver/ngrinder/milestones{/number}","notifications_url":"https://api.github.com/repos/naver/ngrinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naver/ngrinder/labels{/name}","releases_url":"https://api.github.com/repos/naver/ngrinder/releases{/id}","deployments_url":"https://api.github.com/repos/naver/ngrinder/deployments","created_at":"2012-06-19T04:14:15Z","updated_at":"2016-03-28T02:18:53Z","pushed_at":"2016-03-28T07:50:51Z","git_url":"git://github.com/naver/ngrinder.git","ssh_url":"git@github.com:naver/ngrinder.git","clone_url":"https://github.com/naver/ngrinder.git","svn_url":"https://github.com/naver/ngrinder","homepage":"naver.github.io/ngrinder","size":32353,"stargazers_count":179,"watchers_count":179,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":13,"forks":67,"open_issues":13,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/naver/ngrinder/pulls/95"},"html":{"href":"https://github.com/naver/ngrinder/pull/95"},"issue":{"href":"https://api.github.com/repos/naver/ngrinder/issues/95"},"comments":{"href":"https://api.github.com/repos/naver/ngrinder/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/naver/ngrinder/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/naver/ngrinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/naver/ngrinder/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/naver/ngrinder/statuses/c2116f632359d826b758b9c8caf844569b9fbe47"}}}}