{"action":"opened","number":340,"pull_request":{"url":"https://api.github.com/repos/requery/requery/pulls/340","id":93980193,"html_url":"https://github.com/requery/requery/pull/340","diff_url":"https://github.com/requery/requery/pull/340.diff","patch_url":"https://github.com/requery/requery/pull/340.patch","issue_url":"https://api.github.com/repos/requery/requery/issues/340","number":340,"state":"open","locked":false,"title":"Fixed generating fields with names forbidden in Java","user":{"login":"rciurkot","id":8318987,"avatar_url":"https://avatars.githubusercontent.com/u/8318987?v=3","gravatar_id":"","url":"https://api.github.com/users/rciurkot","html_url":"https://github.com/rciurkot","followers_url":"https://api.github.com/users/rciurkot/followers","following_url":"https://api.github.com/users/rciurkot/following{/other_user}","gists_url":"https://api.github.com/users/rciurkot/gists{/gist_id}","starred_url":"https://api.github.com/users/rciurkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rciurkot/subscriptions","organizations_url":"https://api.github.com/users/rciurkot/orgs","repos_url":"https://api.github.com/users/rciurkot/repos","events_url":"https://api.github.com/users/rciurkot/events{/privacy}","received_events_url":"https://api.github.com/users/rciurkot/received_events","type":"User","site_admin":false},"body":"Define an Entity class that has properties that could resolve to Java keywords fails code generation. For example\r\n```\r\n@Entity\r\ninterface Keywords : Persistable {\r\n    @get:Key\r\n    @get:Generated\r\n    var id: Int\r\n\r\n    var isDefault: Boolean\r\n}\r\n```\r\nThis class will have `isDefault` property resolved to private field: `private boolean default` which obviously can't compile.\r\n\r\nI've added code that checks if new name is a proper Java name, if not, original name is returned.\r\nAlso I've tried to make it work in Java (there's similar problem), however I've failed to do so.\r\nHope you'll be able to fix it in Java as well.","created_at":"2016-11-16T14:57:47Z","updated_at":"2016-11-16T14:57:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/requery/requery/pulls/340/commits","review_comments_url":"https://api.github.com/repos/requery/requery/pulls/340/comments","review_comment_url":"https://api.github.com/repos/requery/requery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/requery/requery/issues/340/comments","statuses_url":"https://api.github.com/repos/requery/requery/statuses/e069336bbad0a07757d8820e68414885258bbe97","head":{"label":"rciurkot:forbidden_attributes","ref":"forbidden_attributes","sha":"e069336bbad0a07757d8820e68414885258bbe97","user":{"login":"rciurkot","id":8318987,"avatar_url":"https://avatars.githubusercontent.com/u/8318987?v=3","gravatar_id":"","url":"https://api.github.com/users/rciurkot","html_url":"https://github.com/rciurkot","followers_url":"https://api.github.com/users/rciurkot/followers","following_url":"https://api.github.com/users/rciurkot/following{/other_user}","gists_url":"https://api.github.com/users/rciurkot/gists{/gist_id}","starred_url":"https://api.github.com/users/rciurkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rciurkot/subscriptions","organizations_url":"https://api.github.com/users/rciurkot/orgs","repos_url":"https://api.github.com/users/rciurkot/repos","events_url":"https://api.github.com/users/rciurkot/events{/privacy}","received_events_url":"https://api.github.com/users/rciurkot/received_events","type":"User","site_admin":false},"repo":{"id":71358381,"name":"requery","full_name":"rciurkot/requery","owner":{"login":"rciurkot","id":8318987,"avatar_url":"https://avatars.githubusercontent.com/u/8318987?v=3","gravatar_id":"","url":"https://api.github.com/users/rciurkot","html_url":"https://github.com/rciurkot","followers_url":"https://api.github.com/users/rciurkot/followers","following_url":"https://api.github.com/users/rciurkot/following{/other_user}","gists_url":"https://api.github.com/users/rciurkot/gists{/gist_id}","starred_url":"https://api.github.com/users/rciurkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rciurkot/subscriptions","organizations_url":"https://api.github.com/users/rciurkot/orgs","repos_url":"https://api.github.com/users/rciurkot/repos","events_url":"https://api.github.com/users/rciurkot/events{/privacy}","received_events_url":"https://api.github.com/users/rciurkot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rciurkot/requery","description":"requery - modern SQL based query & persistence for Java / Kotlin / Android","fork":true,"url":"https://api.github.com/repos/rciurkot/requery","forks_url":"https://api.github.com/repos/rciurkot/requery/forks","keys_url":"https://api.github.com/repos/rciurkot/requery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rciurkot/requery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rciurkot/requery/teams","hooks_url":"https://api.github.com/repos/rciurkot/requery/hooks","issue_events_url":"https://api.github.com/repos/rciurkot/requery/issues/events{/number}","events_url":"https://api.github.com/repos/rciurkot/requery/events","assignees_url":"https://api.github.com/repos/rciurkot/requery/assignees{/user}","branches_url":"https://api.github.com/repos/rciurkot/requery/branches{/branch}","tags_url":"https://api.github.com/repos/rciurkot/requery/tags","blobs_url":"https://api.github.com/repos/rciurkot/requery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rciurkot/requery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rciurkot/requery/git/refs{/sha}","trees_url":"https://api.github.com/repos/rciurkot/requery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rciurkot/requery/statuses/{sha}","languages_url":"https://api.github.com/repos/rciurkot/requery/languages","stargazers_url":"https://api.github.com/repos/rciurkot/requery/stargazers","contributors_url":"https://api.github.com/repos/rciurkot/requery/contributors","subscribers_url":"https://api.github.com/repos/rciurkot/requery/subscribers","subscription_url":"https://api.github.com/repos/rciurkot/requery/subscription","commits_url":"https://api.github.com/repos/rciurkot/requery/commits{/sha}","git_commits_url":"https://api.github.com/repos/rciurkot/requery/git/commits{/sha}","comments_url":"https://api.github.com/repos/rciurkot/requery/comments{/number}","issue_comment_url":"https://api.github.com/repos/rciurkot/requery/issues/comments{/number}","contents_url":"https://api.github.com/repos/rciurkot/requery/contents/{+path}","compare_url":"https://api.github.com/repos/rciurkot/requery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rciurkot/requery/merges","archive_url":"https://api.github.com/repos/rciurkot/requery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rciurkot/requery/downloads","issues_url":"https://api.github.com/repos/rciurkot/requery/issues{/number}","pulls_url":"https://api.github.com/repos/rciurkot/requery/pulls{/number}","milestones_url":"https://api.github.com/repos/rciurkot/requery/milestones{/number}","notifications_url":"https://api.github.com/repos/rciurkot/requery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rciurkot/requery/labels{/name}","releases_url":"https://api.github.com/repos/rciurkot/requery/releases{/id}","deployments_url":"https://api.github.com/repos/rciurkot/requery/deployments","created_at":"2016-10-19T13:09:37Z","updated_at":"2016-10-19T13:09:39Z","pushed_at":"2016-11-16T14:39:10Z","git_url":"git://github.com/rciurkot/requery.git","ssh_url":"git@github.com:rciurkot/requery.git","clone_url":"https://github.com/rciurkot/requery.git","svn_url":"https://github.com/rciurkot/requery","homepage":"","size":2025,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"requery:master","ref":"master","sha":"35b652dae94bc4b3cd2ddc2e114ab2ef7d2c277e","user":{"login":"requery","id":15840155,"avatar_url":"https://avatars.githubusercontent.com/u/15840155?v=3","gravatar_id":"","url":"https://api.github.com/users/requery","html_url":"https://github.com/requery","followers_url":"https://api.github.com/users/requery/followers","following_url":"https://api.github.com/users/requery/following{/other_user}","gists_url":"https://api.github.com/users/requery/gists{/gist_id}","starred_url":"https://api.github.com/users/requery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/requery/subscriptions","organizations_url":"https://api.github.com/users/requery/orgs","repos_url":"https://api.github.com/users/requery/repos","events_url":"https://api.github.com/users/requery/events{/privacy}","received_events_url":"https://api.github.com/users/requery/received_events","type":"Organization","site_admin":false},"repo":{"id":46154735,"name":"requery","full_name":"requery/requery","owner":{"login":"requery","id":15840155,"avatar_url":"https://avatars.githubusercontent.com/u/15840155?v=3","gravatar_id":"","url":"https://api.github.com/users/requery","html_url":"https://github.com/requery","followers_url":"https://api.github.com/users/requery/followers","following_url":"https://api.github.com/users/requery/following{/other_user}","gists_url":"https://api.github.com/users/requery/gists{/gist_id}","starred_url":"https://api.github.com/users/requery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/requery/subscriptions","organizations_url":"https://api.github.com/users/requery/orgs","repos_url":"https://api.github.com/users/requery/repos","events_url":"https://api.github.com/users/requery/events{/privacy}","received_events_url":"https://api.github.com/users/requery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/requery/requery","description":"requery - modern SQL based query & persistence for Java / Kotlin / Android","fork":false,"url":"https://api.github.com/repos/requery/requery","forks_url":"https://api.github.com/repos/requery/requery/forks","keys_url":"https://api.github.com/repos/requery/requery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/requery/requery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/requery/requery/teams","hooks_url":"https://api.github.com/repos/requery/requery/hooks","issue_events_url":"https://api.github.com/repos/requery/requery/issues/events{/number}","events_url":"https://api.github.com/repos/requery/requery/events","assignees_url":"https://api.github.com/repos/requery/requery/assignees{/user}","branches_url":"https://api.github.com/repos/requery/requery/branches{/branch}","tags_url":"https://api.github.com/repos/requery/requery/tags","blobs_url":"https://api.github.com/repos/requery/requery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/requery/requery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/requery/requery/git/refs{/sha}","trees_url":"https://api.github.com/repos/requery/requery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/requery/requery/statuses/{sha}","languages_url":"https://api.github.com/repos/requery/requery/languages","stargazers_url":"https://api.github.com/repos/requery/requery/stargazers","contributors_url":"https://api.github.com/repos/requery/requery/contributors","subscribers_url":"https://api.github.com/repos/requery/requery/subscribers","subscription_url":"https://api.github.com/repos/requery/requery/subscription","commits_url":"https://api.github.com/repos/requery/requery/commits{/sha}","git_commits_url":"https://api.github.com/repos/requery/requery/git/commits{/sha}","comments_url":"https://api.github.com/repos/requery/requery/comments{/number}","issue_comment_url":"https://api.github.com/repos/requery/requery/issues/comments{/number}","contents_url":"https://api.github.com/repos/requery/requery/contents/{+path}","compare_url":"https://api.github.com/repos/requery/requery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/requery/requery/merges","archive_url":"https://api.github.com/repos/requery/requery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/requery/requery/downloads","issues_url":"https://api.github.com/repos/requery/requery/issues{/number}","pulls_url":"https://api.github.com/repos/requery/requery/pulls{/number}","milestones_url":"https://api.github.com/repos/requery/requery/milestones{/number}","notifications_url":"https://api.github.com/repos/requery/requery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/requery/requery/labels{/name}","releases_url":"https://api.github.com/repos/requery/requery/releases{/id}","deployments_url":"https://api.github.com/repos/requery/requery/deployments","created_at":"2015-11-14T00:45:31Z","updated_at":"2016-11-16T14:23:47Z","pushed_at":"2016-11-15T14:32:33Z","git_url":"git://github.com/requery/requery.git","ssh_url":"git@github.com:requery/requery.git","clone_url":"https://github.com/requery/requery.git","svn_url":"https://github.com/requery/requery","homepage":"","size":2213,"stargazers_count":1468,"watchers_count":1468,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":19,"forks":104,"open_issues":19,"watchers":1468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/requery/requery/pulls/340"},"html":{"href":"https://github.com/requery/requery/pull/340"},"issue":{"href":"https://api.github.com/repos/requery/requery/issues/340"},"comments":{"href":"https://api.github.com/repos/requery/requery/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/requery/requery/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/requery/requery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/requery/requery/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/requery/requery/statuses/e069336bbad0a07757d8820e68414885258bbe97"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":36,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"rciurkot"}}