{"action":"created","issue":{"url":"https://api.github.com/repos/vidstige/jadb/issues/36","repository_url":"https://api.github.com/repos/vidstige/jadb","labels_url":"https://api.github.com/repos/vidstige/jadb/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/vidstige/jadb/issues/36/comments","events_url":"https://api.github.com/repos/vidstige/jadb/issues/36/events","html_url":"https://github.com/vidstige/jadb/issues/36","id":179793001,"number":36,"title":"Separate unit tests from integration test 2.0","user":{"login":"SKART1","id":3259560,"avatar_url":"https://avatars.githubusercontent.com/u/3259560?v=3","gravatar_id":"","url":"https://api.github.com/users/SKART1","html_url":"https://github.com/SKART1","followers_url":"https://api.github.com/users/SKART1/followers","following_url":"https://api.github.com/users/SKART1/following{/other_user}","gists_url":"https://api.github.com/users/SKART1/gists{/gist_id}","starred_url":"https://api.github.com/users/SKART1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKART1/subscriptions","organizations_url":"https://api.github.com/users/SKART1/orgs","repos_url":"https://api.github.com/users/SKART1/repos","events_url":"https://api.github.com/users/SKART1/events{/privacy}","received_events_url":"https://api.github.com/users/SKART1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-28T14:41:46Z","updated_at":"2016-09-30T12:30:18Z","closed_at":null,"body":"#26 was not the best decision separating `unit` and `integration` test by hardcoded  package name. \r\nThis breaks Java feature of `package` visibility - which allows tests to use `package` visible methods and fields of application classes in test classes which have same package name\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/vidstige/jadb/issues/comments/250732439","html_url":"https://github.com/vidstige/jadb/issues/36#issuecomment-250732439","issue_url":"https://api.github.com/repos/vidstige/jadb/issues/36","id":250732439,"user":{"login":"SKART1","id":3259560,"avatar_url":"https://avatars.githubusercontent.com/u/3259560?v=3","gravatar_id":"","url":"https://api.github.com/users/SKART1","html_url":"https://github.com/SKART1","followers_url":"https://api.github.com/users/SKART1/followers","following_url":"https://api.github.com/users/SKART1/following{/other_user}","gists_url":"https://api.github.com/users/SKART1/gists{/gist_id}","starred_url":"https://api.github.com/users/SKART1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKART1/subscriptions","organizations_url":"https://api.github.com/users/SKART1/orgs","repos_url":"https://api.github.com/users/SKART1/repos","events_url":"https://api.github.com/users/SKART1/events{/privacy}","received_events_url":"https://api.github.com/users/SKART1/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T12:30:18Z","updated_at":"2016-09-30T12:30:18Z","body":"For example  - see this [cross-repository comparison](https://github.com/vidstige/jadb/compare/master...SKART1:IMP-38-getprop?expand=1) of #38. \r\n\r\nShortly - I want to implement `getprop` command of android device.\r\n\r\nTo make this feature testable I separated this functionality in 2 parts:\r\n * executing shell command \r\n * parsing `inputstream` as a result. \r\n\r\nThis allows to test most complicated part without overriding `executeShell` method \r\nNot to put garbage in module interface only actual `getprop` method is public and `parseProp`  is not.\r\nTo actually call this method I need package level access which can be achieved only if test have the same package name as `testable` class"}}
{"actor":{"display_login":"SKART1"}}