{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/14104","repository_url":"https://api.github.com/repos/emberjs/ember.js","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/14104/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/14104/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/14104/events","html_url":"https://github.com/emberjs/ember.js/pull/14104","id":172298337,"number":14104,"title":"Call IsVisibleBinding only if no style binding","user":{"login":"les2","id":1066080,"avatar_url":"https://avatars.githubusercontent.com/u/1066080?v=3","gravatar_id":"","url":"https://api.github.com/users/les2","html_url":"https://github.com/les2","followers_url":"https://api.github.com/users/les2/followers","following_url":"https://api.github.com/users/les2/following{/other_user}","gists_url":"https://api.github.com/users/les2/gists{/gist_id}","starred_url":"https://api.github.com/users/les2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/les2/subscriptions","organizations_url":"https://api.github.com/users/les2/orgs","repos_url":"https://api.github.com/users/les2/repos","events_url":"https://api.github.com/users/les2/events{/privacy}","received_events_url":"https://api.github.com/users/les2/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-21T00:45:24Z","updated_at":"2016-08-21T17:51:27Z","closed_at":"2016-08-21T14:20:50Z","pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/14104","html_url":"https://github.com/emberjs/ember.js/pull/14104","diff_url":"https://github.com/emberjs/ember.js/pull/14104.diff","patch_url":"https://github.com/emberjs/ember.js/pull/14104.patch"},"body":"Previously, the `seen` variable was used as both an `Array` and a\r\nhashmap (plain JavaScript object) when it was really an `Array`. The\r\n`Array` would never return `true` for `seen['style']` in this code block\r\nmeaning that the `IsVisibleBinding` call would always be invoked,\r\nregardless of whether there was an attribute binding for `style`. This\r\nbehavior is most likely a bug. The author intends to investigate unit /\r\nintegration tests for this case and add them in a separate commit.\r\n\r\n# Unit Tests\r\n\r\nThe author is investigating tests now but wanted to submit this sooner rather than later in case it is important."},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/241271390","html_url":"https://github.com/emberjs/ember.js/pull/14104#issuecomment-241271390","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/14104","id":241271390,"user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"created_at":"2016-08-21T17:51:27Z","updated_at":"2016-08-21T17:51:27Z","body":"@chancancode - It will almost certainly lead to pain.  See my series of comments on https://github.com/emberjs/ember.js/pull/13881 (where the `isVisible` tests were migrated).  Basically, there is no single thing that can be used across all platforms.  We could theoretically use a platform detection, but I'm not certain that is better."}}
{"actor":{"display_login":"rwjblue"}}