{"action":"created","comment":{"url":"https://api.github.com/repos/Normation/ncf/pulls/comments/79842522","id":79842522,"diff_hunk":"@@ -0,0 +1,44 @@\n+#####################################################################################\n+# Copyright 2016 Normation SAS\n+#####################################################################################\n+#\n+# This program is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, Version 3.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+#\n+#####################################################################################\n+\n+# Initialization\n+# This bundle will make necessary step to prepare ncf before running any configuration\n+# It needs to be called just after loading ncf and its configuration.\n+bundle agent init\n+{\n+\n+  files:\n+      \"${sys.workdir}/modules/\"\n+        copy_from         => local_dcp(\"${me.framework_path}/10_ncf_internals/modules/\"),\n+        depth_search      => recurse(\"inf\"),\n+        perms             => m(\"700\"),\n+        action            => immediate,\n+        move_obstructions => \"true\",\n+        classes           => classes_generic(\"ncf_internals_modules_update\"),","path":"tree/10_ncf_internals/initialization.cf","position":32,"original_position":32,"commit_id":"268832b37dd78424d98fbf70205bc817d3d29425","original_commit_id":"268832b37dd78424d98fbf70205bc817d3d29425","user":{"login":"amousset","id":329388,"avatar_url":"https://avatars.githubusercontent.com/u/329388?v=3","gravatar_id":"","url":"https://api.github.com/users/amousset","html_url":"https://github.com/amousset","followers_url":"https://api.github.com/users/amousset/followers","following_url":"https://api.github.com/users/amousset/following{/other_user}","gists_url":"https://api.github.com/users/amousset/gists{/gist_id}","starred_url":"https://api.github.com/users/amousset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amousset/subscriptions","organizations_url":"https://api.github.com/users/amousset/orgs","repos_url":"https://api.github.com/users/amousset/repos","events_url":"https://api.github.com/users/amousset/events{/privacy}","received_events_url":"https://api.github.com/users/amousset/received_events","type":"User","site_admin":false},"body":"I think we need reports for this in Rudder. We may want to build an `ncf_init_*` class that aggregates all initialization steps to hide internal mechanisms, what is you opinion?","created_at":"2016-09-21T14:13:05Z","updated_at":"2016-09-21T14:13:06Z","html_url":"https://github.com/Normation/ncf/pull/444#discussion_r79842522","pull_request_url":"https://api.github.com/repos/Normation/ncf/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/Normation/ncf/pulls/comments/79842522"},"html":{"href":"https://github.com/Normation/ncf/pull/444#discussion_r79842522"},"pull_request":{"href":"https://api.github.com/repos/Normation/ncf/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/Normation/ncf/pulls/444","id":86168825,"html_url":"https://github.com/Normation/ncf/pull/444","diff_url":"https://github.com/Normation/ncf/pull/444.diff","patch_url":"https://github.com/Normation/ncf/pull/444.patch","issue_url":"https://api.github.com/repos/Normation/ncf/issues/444","number":444,"state":"open","locked":false,"title":"Fixes #9094: Add a bundle to copy local modules into workdir/modules","user":{"login":"amousset","id":329388,"avatar_url":"https://avatars.githubusercontent.com/u/329388?v=3","gravatar_id":"","url":"https://api.github.com/users/amousset","html_url":"https://github.com/amousset","followers_url":"https://api.github.com/users/amousset/followers","following_url":"https://api.github.com/users/amousset/following{/other_user}","gists_url":"https://api.github.com/users/amousset/gists{/gist_id}","starred_url":"https://api.github.com/users/amousset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amousset/subscriptions","organizations_url":"https://api.github.com/users/amousset/orgs","repos_url":"https://api.github.com/users/amousset/repos","events_url":"https://api.github.com/users/amousset/events{/privacy}","received_events_url":"https://api.github.com/users/amousset/received_events","type":"User","site_admin":false},"body":"https://www.rudder-project.org/redmine/issues/9094","created_at":"2016-09-21T14:03:59Z","updated_at":"2016-09-21T14:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6b5d60ea0103c83ed0c422846f56b8d8d8af156","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Normation/ncf/pulls/444/commits","review_comments_url":"https://api.github.com/repos/Normation/ncf/pulls/444/comments","review_comment_url":"https://api.github.com/repos/Normation/ncf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Normation/ncf/issues/444/comments","statuses_url":"https://api.github.com/repos/Normation/ncf/statuses/268832b37dd78424d98fbf70205bc817d3d29425","head":{"label":"amousset:ust_9094/add_a_bundle_to_copy_local_modules_into_workdir_modules","ref":"ust_9094/add_a_bundle_to_copy_local_modules_into_workdir_modules","sha":"268832b37dd78424d98fbf70205bc817d3d29425","user":{"login":"amousset","id":329388,"avatar_url":"https://avatars.githubusercontent.com/u/329388?v=3","gravatar_id":"","url":"https://api.github.com/users/amousset","html_url":"https://github.com/amousset","followers_url":"https://api.github.com/users/amousset/followers","following_url":"https://api.github.com/users/amousset/following{/other_user}","gists_url":"https://api.github.com/users/amousset/gists{/gist_id}","starred_url":"https://api.github.com/users/amousset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amousset/subscriptions","organizations_url":"https://api.github.com/users/amousset/orgs","repos_url":"https://api.github.com/users/amousset/repos","events_url":"https://api.github.com/users/amousset/events{/privacy}","received_events_url":"https://api.github.com/users/amousset/received_events","type":"User","site_admin":false},"repo":{"id":35948434,"name":"ncf","full_name":"amousset/ncf","owner":{"login":"amousset","id":329388,"avatar_url":"https://avatars.githubusercontent.com/u/329388?v=3","gravatar_id":"","url":"https://api.github.com/users/amousset","html_url":"https://github.com/amousset","followers_url":"https://api.github.com/users/amousset/followers","following_url":"https://api.github.com/users/amousset/following{/other_user}","gists_url":"https://api.github.com/users/amousset/gists{/gist_id}","starred_url":"https://api.github.com/users/amousset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amousset/subscriptions","organizations_url":"https://api.github.com/users/amousset/orgs","repos_url":"https://api.github.com/users/amousset/repos","events_url":"https://api.github.com/users/amousset/events{/privacy}","received_events_url":"https://api.github.com/users/amousset/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amousset/ncf","description":"ncf is a framework that runs in pure CFEngine language, to help structure your CFEngine policy and provide reusable, single purpose components distributed under the GPLv3 license.","fork":true,"url":"https://api.github.com/repos/amousset/ncf","forks_url":"https://api.github.com/repos/amousset/ncf/forks","keys_url":"https://api.github.com/repos/amousset/ncf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amousset/ncf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amousset/ncf/teams","hooks_url":"https://api.github.com/repos/amousset/ncf/hooks","issue_events_url":"https://api.github.com/repos/amousset/ncf/issues/events{/number}","events_url":"https://api.github.com/repos/amousset/ncf/events","assignees_url":"https://api.github.com/repos/amousset/ncf/assignees{/user}","branches_url":"https://api.github.com/repos/amousset/ncf/branches{/branch}","tags_url":"https://api.github.com/repos/amousset/ncf/tags","blobs_url":"https://api.github.com/repos/amousset/ncf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amousset/ncf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amousset/ncf/git/refs{/sha}","trees_url":"https://api.github.com/repos/amousset/ncf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amousset/ncf/statuses/{sha}","languages_url":"https://api.github.com/repos/amousset/ncf/languages","stargazers_url":"https://api.github.com/repos/amousset/ncf/stargazers","contributors_url":"https://api.github.com/repos/amousset/ncf/contributors","subscribers_url":"https://api.github.com/repos/amousset/ncf/subscribers","subscription_url":"https://api.github.com/repos/amousset/ncf/subscription","commits_url":"https://api.github.com/repos/amousset/ncf/commits{/sha}","git_commits_url":"https://api.github.com/repos/amousset/ncf/git/commits{/sha}","comments_url":"https://api.github.com/repos/amousset/ncf/comments{/number}","issue_comment_url":"https://api.github.com/repos/amousset/ncf/issues/comments{/number}","contents_url":"https://api.github.com/repos/amousset/ncf/contents/{+path}","compare_url":"https://api.github.com/repos/amousset/ncf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amousset/ncf/merges","archive_url":"https://api.github.com/repos/amousset/ncf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amousset/ncf/downloads","issues_url":"https://api.github.com/repos/amousset/ncf/issues{/number}","pulls_url":"https://api.github.com/repos/amousset/ncf/pulls{/number}","milestones_url":"https://api.github.com/repos/amousset/ncf/milestones{/number}","notifications_url":"https://api.github.com/repos/amousset/ncf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amousset/ncf/labels{/name}","releases_url":"https://api.github.com/repos/amousset/ncf/releases{/id}","deployments_url":"https://api.github.com/repos/amousset/ncf/deployments","created_at":"2015-05-20T13:08:14Z","updated_at":"2016-02-26T14:06:38Z","pushed_at":"2016-09-21T14:03:58Z","git_url":"git://github.com/amousset/ncf.git","ssh_url":"git@github.com:amousset/ncf.git","clone_url":"https://github.com/amousset/ncf.git","svn_url":"https://github.com/amousset/ncf","homepage":"http://www.ncf.io","size":2823,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Normation:master","ref":"master","sha":"21869a93f139d5e9a20a1e957fc553856e63c169","user":{"login":"Normation","id":695105,"avatar_url":"https://avatars.githubusercontent.com/u/695105?v=3","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"repo":{"id":12734168,"name":"ncf","full_name":"Normation/ncf","owner":{"login":"Normation","id":695105,"avatar_url":"https://avatars.githubusercontent.com/u/695105?v=3","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Normation/ncf","description":"ncf is a framework that runs in pure CFEngine language, to help structure your CFEngine policy and provide reusable, single purpose components distributed under the GPLv3 license.","fork":false,"url":"https://api.github.com/repos/Normation/ncf","forks_url":"https://api.github.com/repos/Normation/ncf/forks","keys_url":"https://api.github.com/repos/Normation/ncf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Normation/ncf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Normation/ncf/teams","hooks_url":"https://api.github.com/repos/Normation/ncf/hooks","issue_events_url":"https://api.github.com/repos/Normation/ncf/issues/events{/number}","events_url":"https://api.github.com/repos/Normation/ncf/events","assignees_url":"https://api.github.com/repos/Normation/ncf/assignees{/user}","branches_url":"https://api.github.com/repos/Normation/ncf/branches{/branch}","tags_url":"https://api.github.com/repos/Normation/ncf/tags","blobs_url":"https://api.github.com/repos/Normation/ncf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Normation/ncf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Normation/ncf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Normation/ncf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Normation/ncf/statuses/{sha}","languages_url":"https://api.github.com/repos/Normation/ncf/languages","stargazers_url":"https://api.github.com/repos/Normation/ncf/stargazers","contributors_url":"https://api.github.com/repos/Normation/ncf/contributors","subscribers_url":"https://api.github.com/repos/Normation/ncf/subscribers","subscription_url":"https://api.github.com/repos/Normation/ncf/subscription","commits_url":"https://api.github.com/repos/Normation/ncf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Normation/ncf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Normation/ncf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Normation/ncf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Normation/ncf/contents/{+path}","compare_url":"https://api.github.com/repos/Normation/ncf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Normation/ncf/merges","archive_url":"https://api.github.com/repos/Normation/ncf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Normation/ncf/downloads","issues_url":"https://api.github.com/repos/Normation/ncf/issues{/number}","pulls_url":"https://api.github.com/repos/Normation/ncf/pulls{/number}","milestones_url":"https://api.github.com/repos/Normation/ncf/milestones{/number}","notifications_url":"https://api.github.com/repos/Normation/ncf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Normation/ncf/labels{/name}","releases_url":"https://api.github.com/repos/Normation/ncf/releases{/id}","deployments_url":"https://api.github.com/repos/Normation/ncf/deployments","created_at":"2013-09-10T16:02:33Z","updated_at":"2016-07-04T20:03:12Z","pushed_at":"2016-09-21T14:03:59Z","git_url":"git://github.com/Normation/ncf.git","ssh_url":"git@github.com:Normation/ncf.git","clone_url":"https://github.com/Normation/ncf.git","svn_url":"https://github.com/Normation/ncf","homepage":"http://www.ncf.io","size":3133,"stargazers_count":34,"watchers_count":34,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":16,"forks":25,"open_issues":16,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Normation/ncf/pulls/444"},"html":{"href":"https://github.com/Normation/ncf/pull/444"},"issue":{"href":"https://api.github.com/repos/Normation/ncf/issues/444"},"comments":{"href":"https://api.github.com/repos/Normation/ncf/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/Normation/ncf/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/Normation/ncf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Normation/ncf/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/Normation/ncf/statuses/268832b37dd78424d98fbf70205bc817d3d29425"}}}}
{"actor":{"display_login":"amousset"}}