{"push_id":1384114826,"size":6,"distinct_size":6,"ref":"refs/heads/master","head":"62f9606bf5f59ffcde5da88ecac2c9fde1f4843c","before":"ac996db258bc3b79497e34e3e41f69ad0dc141a5","commits":[{"sha":"4fc5260244b51037a4ac490687b239789ed3015c","author":{"name":"Michael Kirk","email":"e29594e611ac0a020432c78fe16fb81021042f47@endoftheworl.de"},"message":"Don't prompt for feedback if user hasn't completed registration\n\n// FREEBIE","distinct":true,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits/4fc5260244b51037a4ac490687b239789ed3015c"},{"sha":"bae050480ab82093420e4892025034ee6ceda817","author":{"name":"Michael Kirk","email":"e29594e611ac0a020432c78fe16fb81021042f47@endoftheworl.de"},"message":"Debug logging around call init crash.\n\n// FREEBIE","distinct":true,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits/bae050480ab82093420e4892025034ee6ceda817"},{"sha":"f98e57e164e6470662e8b299afe785c1609a3107","author":{"name":"Michael Kirk","email":"e29594e611ac0a020432c78fe16fb81021042f47@endoftheworl.de"},"message":"WIP: Fix hanging registration when background modes disabled\n\nfixes #1329\n\nWe must register notification settings earlier to be sure we'll be able\nto get the users push tokens.\n\nWe were previously relying on a quirk of background fetch, a feature\nwhich we don't *actually* use, wherein it's possible to get push tokens\nfor a user without first prompting them for their notification\nsettings. More on this from UIApplication.h:\n\n    // Calling this will result in either application:didRegisterForRemoteNotificationsWithDeviceToken: or application:didFailToRegisterForRemoteNotificationsWithError: to be called on the application delegate.\n    // ---> Note: these callbacks will be made only if the application has successfully registered for user notifications with registerUserNotificationSettings:, or if it is enabled for Background App Refresh.\n    - (void)registerForRemoteNotifications NS_AVAILABLE_IOS(8_0);\n\nIn the previous implementation, if a user had disabled background\nnotifications (e.g.  in order to save battery), we were waiting for push\ntokens that would never come.\n\nHowever, this simple \"fix\" introduces a UX problem - now we prompt for\nan alert in the middle of our registration flow.\n\n// FREEBIE","distinct":true,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits/f98e57e164e6470662e8b299afe785c1609a3107"},{"sha":"1dd06a5e6c21e756ad334be0f67f4b284c52f202","author":{"name":"Michael Kirk","email":"e29594e611ac0a020432c78fe16fb81021042f47@endoftheworl.de"},"message":"Fix registration flow / Keep push tokens in sync\n\n* Separate registering an account from registering for push notifications\n  * Allows us to complete registration without prompting user for\n    notification settings.\n\nUX Changes\n----------\n* Automatically keep push tokens in sync on startup.\n  Push tokens *can* change, though they rarely do. It happens more often\n  for people switching between appstore/beta builds.\n\n  fixes #1174\n\n* Show alert with registration failure\n  * add secret 8-tap debug log gesture to registration flow\n\n* Move registration to separate flow\n  * don't see flash of inbox when first launching\n\n* show useful error messages when given wrong code / no code\n\n* remove background fetch\n  We werent using it, but only relying on a side effect of it which is\n  no longer necessary.\n\nCode Changes\n------------\n\n* More registration logging.\n\n* Install PromiseKit with carthage\n\n  Our dependencies are not yet framework compatible, so we can't use\n  cocoapods.\n\n* Merge preferences util \"category\" into superclass.\n\n  The immediate reason for this is Swift interop was assuming optional\n  types were not optional, and exploding when a value was nil.\n\n  This is clearer anyway, since we were treating it like a subclass, and\n  it was the only thing using the class anyway.\n\n* auto-genstrings now searches *.swift (and *.h, which was previously\n  broken) for translateable strings.\n\n// FREEBIE","distinct":true,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits/1dd06a5e6c21e756ad334be0f67f4b284c52f202"},{"sha":"78d9c97d70fa0ff111f1dd1bf71ee5b9dfe8c7da","author":{"name":"Michael Kirk","email":"e29594e611ac0a020432c78fe16fb81021042f47@endoftheworl.de"},"message":"Bump build and properly set version.\n\n// FREEBIE","distinct":true,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits/78d9c97d70fa0ff111f1dd1bf71ee5b9dfe8c7da"},{"sha":"62f9606bf5f59ffcde5da88ecac2c9fde1f4843c","author":{"name":"Michael Kirk","email":"e29594e611ac0a020432c78fe16fb81021042f47@endoftheworl.de"},"message":"Merge branch 'mkirk/fix-registration-without-background-modes#1329'\n\n// FREEBIE","distinct":true,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits/62f9606bf5f59ffcde5da88ecac2c9fde1f4843c"}]}
{"actor":{"display_login":"michaelkirk"}}