{"action":"closed","number":509,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust-www/pulls/509","id":83928487,"html_url":"https://github.com/rust-lang/rust-www/pull/509","diff_url":"https://github.com/rust-lang/rust-www/pull/509.diff","patch_url":"https://github.com/rust-lang/rust-www/pull/509.patch","issue_url":"https://api.github.com/repos/rust-lang/rust-www/issues/509","number":509,"state":"closed","locked":false,"title":"Allow the localized messages to go along with the HTML","user":{"login":"lifthrasiir","id":323836,"avatar_url":"https://avatars.githubusercontent.com/u/323836?v=3","gravatar_id":"","url":"https://api.github.com/users/lifthrasiir","html_url":"https://github.com/lifthrasiir","followers_url":"https://api.github.com/users/lifthrasiir/followers","following_url":"https://api.github.com/users/lifthrasiir/following{/other_user}","gists_url":"https://api.github.com/users/lifthrasiir/gists{/gist_id}","starred_url":"https://api.github.com/users/lifthrasiir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifthrasiir/subscriptions","organizations_url":"https://api.github.com/users/lifthrasiir/orgs","repos_url":"https://api.github.com/users/lifthrasiir/repos","events_url":"https://api.github.com/users/lifthrasiir/events{/privacy}","received_events_url":"https://api.github.com/users/lifthrasiir/received_events","type":"User","site_admin":false},"body":"Previously dynamic messages were hard-coded in the script. As the HTML is already localized (or we at least assume so), it is better to put them into the HTML itself---in this case with HTML5 `data-*` attributes.\r\n\r\nThis change mainly concerns with playpen messages (currently \"Running...\" only) and the current version replacements (which didn't really work for untranslated languages anyway---check the browser console). Other kinds of dynamic messages or omitted ones (not sure how to deal with the playpen errors in general, seems not working) can be added in the same way.","created_at":"2016-09-04T17:14:55Z","updated_at":"2016-09-04T18:26:32Z","closed_at":"2016-09-04T18:26:32Z","merged_at":"2016-09-04T18:26:32Z","merge_commit_sha":"420398eac696b016e884fb30a355c2adf59dd476","assignee":{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"assignees":[{"login":"aturon","id":709807,"avatar_url":"https://avatars.githubusercontent.com/u/709807?v=3","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust-www/pulls/509/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust-www/pulls/509/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust-www/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust-www/issues/509/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust-www/statuses/cb8ef9960cca9b0afac1e66c041ef06519558d25","head":{"label":"lifthrasiir:integrated-local-msg","ref":"integrated-local-msg","sha":"cb8ef9960cca9b0afac1e66c041ef06519558d25","user":{"login":"lifthrasiir","id":323836,"avatar_url":"https://avatars.githubusercontent.com/u/323836?v=3","gravatar_id":"","url":"https://api.github.com/users/lifthrasiir","html_url":"https://github.com/lifthrasiir","followers_url":"https://api.github.com/users/lifthrasiir/followers","following_url":"https://api.github.com/users/lifthrasiir/following{/other_user}","gists_url":"https://api.github.com/users/lifthrasiir/gists{/gist_id}","starred_url":"https://api.github.com/users/lifthrasiir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifthrasiir/subscriptions","organizations_url":"https://api.github.com/users/lifthrasiir/orgs","repos_url":"https://api.github.com/users/lifthrasiir/repos","events_url":"https://api.github.com/users/lifthrasiir/events{/privacy}","received_events_url":"https://api.github.com/users/lifthrasiir/received_events","type":"User","site_admin":false},"repo":{"id":67306227,"name":"rust-www","full_name":"lifthrasiir/rust-www","owner":{"login":"lifthrasiir","id":323836,"avatar_url":"https://avatars.githubusercontent.com/u/323836?v=3","gravatar_id":"","url":"https://api.github.com/users/lifthrasiir","html_url":"https://github.com/lifthrasiir","followers_url":"https://api.github.com/users/lifthrasiir/followers","following_url":"https://api.github.com/users/lifthrasiir/following{/other_user}","gists_url":"https://api.github.com/users/lifthrasiir/gists{/gist_id}","starred_url":"https://api.github.com/users/lifthrasiir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifthrasiir/subscriptions","organizations_url":"https://api.github.com/users/lifthrasiir/orgs","repos_url":"https://api.github.com/users/lifthrasiir/repos","events_url":"https://api.github.com/users/lifthrasiir/events{/privacy}","received_events_url":"https://api.github.com/users/lifthrasiir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lifthrasiir/rust-www","description":"lifthrasiir's working copy of rust-lang.org","fork":true,"url":"https://api.github.com/repos/lifthrasiir/rust-www","forks_url":"https://api.github.com/repos/lifthrasiir/rust-www/forks","keys_url":"https://api.github.com/repos/lifthrasiir/rust-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifthrasiir/rust-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifthrasiir/rust-www/teams","hooks_url":"https://api.github.com/repos/lifthrasiir/rust-www/hooks","issue_events_url":"https://api.github.com/repos/lifthrasiir/rust-www/issues/events{/number}","events_url":"https://api.github.com/repos/lifthrasiir/rust-www/events","assignees_url":"https://api.github.com/repos/lifthrasiir/rust-www/assignees{/user}","branches_url":"https://api.github.com/repos/lifthrasiir/rust-www/branches{/branch}","tags_url":"https://api.github.com/repos/lifthrasiir/rust-www/tags","blobs_url":"https://api.github.com/repos/lifthrasiir/rust-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifthrasiir/rust-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifthrasiir/rust-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifthrasiir/rust-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifthrasiir/rust-www/statuses/{sha}","languages_url":"https://api.github.com/repos/lifthrasiir/rust-www/languages","stargazers_url":"https://api.github.com/repos/lifthrasiir/rust-www/stargazers","contributors_url":"https://api.github.com/repos/lifthrasiir/rust-www/contributors","subscribers_url":"https://api.github.com/repos/lifthrasiir/rust-www/subscribers","subscription_url":"https://api.github.com/repos/lifthrasiir/rust-www/subscription","commits_url":"https://api.github.com/repos/lifthrasiir/rust-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifthrasiir/rust-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifthrasiir/rust-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifthrasiir/rust-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifthrasiir/rust-www/contents/{+path}","compare_url":"https://api.github.com/repos/lifthrasiir/rust-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifthrasiir/rust-www/merges","archive_url":"https://api.github.com/repos/lifthrasiir/rust-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifthrasiir/rust-www/downloads","issues_url":"https://api.github.com/repos/lifthrasiir/rust-www/issues{/number}","pulls_url":"https://api.github.com/repos/lifthrasiir/rust-www/pulls{/number}","milestones_url":"https://api.github.com/repos/lifthrasiir/rust-www/milestones{/number}","notifications_url":"https://api.github.com/repos/lifthrasiir/rust-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifthrasiir/rust-www/labels{/name}","releases_url":"https://api.github.com/repos/lifthrasiir/rust-www/releases{/id}","deployments_url":"https://api.github.com/repos/lifthrasiir/rust-www/deployments","created_at":"2016-09-03T18:46:14Z","updated_at":"2016-09-03T20:19:17Z","pushed_at":"2016-09-04T17:10:33Z","git_url":"git://github.com/lifthrasiir/rust-www.git","ssh_url":"git@github.com:lifthrasiir/rust-www.git","clone_url":"https://github.com/lifthrasiir/rust-www.git","svn_url":"https://github.com/lifthrasiir/rust-www","homepage":"","size":5097,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"e8715762072f12ec651ec3822722f296f0beee4f","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":2302682,"name":"rust-www","full_name":"rust-lang/rust-www","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust-www","description":"The Rust website","fork":false,"url":"https://api.github.com/repos/rust-lang/rust-www","forks_url":"https://api.github.com/repos/rust-lang/rust-www/forks","keys_url":"https://api.github.com/repos/rust-lang/rust-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust-www/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust-www/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust-www/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust-www/events","assignees_url":"https://api.github.com/repos/rust-lang/rust-www/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust-www/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust-www/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust-www/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust-www/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust-www/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust-www/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust-www/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust-www/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust-www/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust-www/merges","archive_url":"https://api.github.com/repos/rust-lang/rust-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust-www/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust-www/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust-www/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust-www/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust-www/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust-www/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust-www/deployments","created_at":"2011-08-31T16:42:32Z","updated_at":"2016-09-04T14:36:39Z","pushed_at":"2016-09-04T18:26:32Z","git_url":"git://github.com/rust-lang/rust-www.git","ssh_url":"git@github.com:rust-lang/rust-www.git","clone_url":"https://github.com/rust-lang/rust-www.git","svn_url":"https://github.com/rust-lang/rust-www","homepage":"http://www.rust-lang.org","size":5438,"stargazers_count":43,"watchers_count":43,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":57,"forks":160,"open_issues":57,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust-www/pulls/509"},"html":{"href":"https://github.com/rust-lang/rust-www/pull/509"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust-www/issues/509"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust-www/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust-www/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust-www/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust-www/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust-www/statuses/cb8ef9960cca9b0afac1e66c041ef06519558d25"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":27,"deletions":29,"changed_files":5}}
{"actor":{"display_login":"steveklabnik"}}