{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4103","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4103/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4103/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4103/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/4103","id":161320504,"number":4103,"title":"Z-Probe Servo Endstop issue","user":{"login":"Roxy-3D","id":8404322,"avatar_url":"https://avatars.githubusercontent.com/u/8404322?v=3","gravatar_id":"","url":"https://api.github.com/users/Roxy-3D","html_url":"https://github.com/Roxy-3D","followers_url":"https://api.github.com/users/Roxy-3D/followers","following_url":"https://api.github.com/users/Roxy-3D/following{/other_user}","gists_url":"https://api.github.com/users/Roxy-3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Roxy-3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roxy-3D/subscriptions","organizations_url":"https://api.github.com/users/Roxy-3D/orgs","repos_url":"https://api.github.com/users/Roxy-3D/repos","events_url":"https://api.github.com/users/Roxy-3D/events{/privacy}","received_events_url":"https://api.github.com/users/Roxy-3D/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Bug:%20Potential%20?","name":"Bug: Potential ?","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-06-20T23:44:03Z","updated_at":"2016-06-22T02:06:20Z","closed_at":null,"body":"We have this code block in Marlin_main.cpp.   The problem is, if you are using a Z-Probe on a servo as your Z-Min endstop and you turn Bed Leveling off...   The  void raise_z_for_servo(float z_dest) function is still needed, but it is undefined.\r\n~~~~\r\n\r\n  #if HAS_Z_SERVO_ENDSTOP\r\n\r\n    /**\r\n     * Raise Z to a minimum height to make room for a servo to move\r\n     *\r\n     * zprobe_zoffset: Negative of the Z height where the probe engages\r\n     *         z_dest: The before / after probing raise distance\r\n     *\r\n     * The zprobe_zoffset is negative for a switch below the nozzle, so\r\n     * multiply by Z_HOME_DIR (-1) to move enough away from the bed.\r\n     */\r\n    void raise_z_for_servo(float z_dest) {\r\n      z_dest += home_offset[Z_AXIS];\r\n\r\n      if ((Z_HOME_DIR) < 0 && zprobe_zoffset < 0)\r\n        z_dest -= zprobe_zoffset;\r\n\r\n      if (z_dest > current_position[Z_AXIS])\r\n        do_blocking_move_to_z(z_dest); // also updates current_position\r\n    }\r\n\r\n  #endif\r\n\r\n#endif // AUTO_BED_LEVELING_FEATURE\r\n~~~~\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/227623878","html_url":"https://github.com/MarlinFirmware/Marlin/issues/4103#issuecomment-227623878","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4103","id":227623878,"user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T02:06:20Z","updated_at":"2016-06-22T02:06:20Z","body":"@Roxy-3D You should already be able to do so, but #4021 (https://github.com/thinkyhead/Marlin/tree/rc_raise_z_for_servos) is the most complete cleanup, and the one I'm most \"confident\" in — meaning I'm sure if anything was missed it will be pretty obvious. The `DEBUG_LEVELING_FEATURE` option will definitely help. Debug messages have been updated as part of the cleanup."}}
{"actor":{"display_login":"thinkyhead"}}