{"action":"created","comment":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments/73905900","id":73905900,"diff_hunk":"@@ -227,10 +227,12 @@ def assertMatch() :\n \n \t\treader[\"missingFrameMode\"].setValue( GafferImage.OpenImageIOReader.MissingFrameMode.Black )\n \t\toiio[\"missingFrameMode\"].setValue( GafferImage.OpenImageIOReader.MissingFrameMode.Black )\n+\t\tformatPlug = GafferImage.FormatPlug()\n \t\twith context :\n+\t\t\tdefaultFormat = formatPlug.getDefaultFormat(context)\n \t\t\tself.assertRaisesRegexp( RuntimeError, \".*incompleteSequence.*.exr.*\", reader[\"out\"].image )\n \t\t\tself.assertRaisesRegexp( RuntimeError, \".*incompleteSequence.*.exr.*\", reader[\"out\"][\"format\"].getValue )\n-\t\t\tself.assertEqual( reader[\"out\"][\"dataWindow\"].getValue(), oiio[\"out\"][\"dataWindow\"].getValue() )","path":"python/GafferImageTest/ImageReaderTest.py","position":9,"original_position":18,"commit_id":"3a6cc2b75764c7953052b35a099c9581e246c6ab","original_commit_id":"7b6e36b1a23091be7fef9ab7387c45ab54ffa3fa","user":{"login":"andrewkaufman","id":3979682,"avatar_url":"https://avatars.githubusercontent.com/u/3979682?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewkaufman","html_url":"https://github.com/andrewkaufman","followers_url":"https://api.github.com/users/andrewkaufman/followers","following_url":"https://api.github.com/users/andrewkaufman/following{/other_user}","gists_url":"https://api.github.com/users/andrewkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkaufman/subscriptions","organizations_url":"https://api.github.com/users/andrewkaufman/orgs","repos_url":"https://api.github.com/users/andrewkaufman/repos","events_url":"https://api.github.com/users/andrewkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkaufman/received_events","type":"User","site_admin":false},"body":"I don't think this part of the test should change. the `ImageReader` is still supposed to return the value it gets from the internal `OpenImageIOReader`","created_at":"2016-08-08T16:20:17Z","updated_at":"2016-08-08T16:20:17Z","html_url":"https://github.com/ImageEngine/gaffer/pull/1802#discussion_r73905900","pull_request_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802","_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments/73905900"},"html":{"href":"https://github.com/ImageEngine/gaffer/pull/1802#discussion_r73905900"},"pull_request":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802"}}},"pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802","id":79819986,"html_url":"https://github.com/ImageEngine/gaffer/pull/1802","diff_url":"https://github.com/ImageEngine/gaffer/pull/1802.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1802.patch","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1802","number":1802,"state":"open","locked":false,"title":"improvement to OpenImageIOReader","user":{"login":"lucienfostier","id":770272,"avatar_url":"https://avatars.githubusercontent.com/u/770272?v=3","gravatar_id":"","url":"https://api.github.com/users/lucienfostier","html_url":"https://github.com/lucienfostier","followers_url":"https://api.github.com/users/lucienfostier/followers","following_url":"https://api.github.com/users/lucienfostier/following{/other_user}","gists_url":"https://api.github.com/users/lucienfostier/gists{/gist_id}","starred_url":"https://api.github.com/users/lucienfostier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucienfostier/subscriptions","organizations_url":"https://api.github.com/users/lucienfostier/orgs","repos_url":"https://api.github.com/users/lucienfostier/repos","events_url":"https://api.github.com/users/lucienfostier/events{/privacy}","received_events_url":"https://api.github.com/users/lucienfostier/received_events","type":"User","site_admin":false},"body":"#### GafferImage\r\n##### OpenImageIOReader\r\n\r\n- using current context displayWindow as\r\ndefault dataWindow.\r\n- adding the current context displayWindow to hash if missing frame","created_at":"2016-08-02T22:26:54Z","updated_at":"2016-08-08T16:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1441389c0b57cda8e330858fdc943d9c90eae99d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802/commits","review_comments_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802/comments","review_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1802/comments","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/3a6cc2b75764c7953052b35a099c9581e246c6ab","head":{"label":"lucienfostier:missingFrameBlackReader","ref":"missingFrameBlackReader","sha":"3a6cc2b75764c7953052b35a099c9581e246c6ab","user":{"login":"lucienfostier","id":770272,"avatar_url":"https://avatars.githubusercontent.com/u/770272?v=3","gravatar_id":"","url":"https://api.github.com/users/lucienfostier","html_url":"https://github.com/lucienfostier","followers_url":"https://api.github.com/users/lucienfostier/followers","following_url":"https://api.github.com/users/lucienfostier/following{/other_user}","gists_url":"https://api.github.com/users/lucienfostier/gists{/gist_id}","starred_url":"https://api.github.com/users/lucienfostier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucienfostier/subscriptions","organizations_url":"https://api.github.com/users/lucienfostier/orgs","repos_url":"https://api.github.com/users/lucienfostier/repos","events_url":"https://api.github.com/users/lucienfostier/events{/privacy}","received_events_url":"https://api.github.com/users/lucienfostier/received_events","type":"User","site_admin":false},"repo":{"id":27899965,"name":"gaffer","full_name":"lucienfostier/gaffer","owner":{"login":"lucienfostier","id":770272,"avatar_url":"https://avatars.githubusercontent.com/u/770272?v=3","gravatar_id":"","url":"https://api.github.com/users/lucienfostier","html_url":"https://github.com/lucienfostier","followers_url":"https://api.github.com/users/lucienfostier/followers","following_url":"https://api.github.com/users/lucienfostier/following{/other_user}","gists_url":"https://api.github.com/users/lucienfostier/gists{/gist_id}","starred_url":"https://api.github.com/users/lucienfostier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucienfostier/subscriptions","organizations_url":"https://api.github.com/users/lucienfostier/orgs","repos_url":"https://api.github.com/users/lucienfostier/repos","events_url":"https://api.github.com/users/lucienfostier/events{/privacy}","received_events_url":"https://api.github.com/users/lucienfostier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucienfostier/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":true,"url":"https://api.github.com/repos/lucienfostier/gaffer","forks_url":"https://api.github.com/repos/lucienfostier/gaffer/forks","keys_url":"https://api.github.com/repos/lucienfostier/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucienfostier/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucienfostier/gaffer/teams","hooks_url":"https://api.github.com/repos/lucienfostier/gaffer/hooks","issue_events_url":"https://api.github.com/repos/lucienfostier/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/lucienfostier/gaffer/events","assignees_url":"https://api.github.com/repos/lucienfostier/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/lucienfostier/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/lucienfostier/gaffer/tags","blobs_url":"https://api.github.com/repos/lucienfostier/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucienfostier/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucienfostier/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucienfostier/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucienfostier/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/lucienfostier/gaffer/languages","stargazers_url":"https://api.github.com/repos/lucienfostier/gaffer/stargazers","contributors_url":"https://api.github.com/repos/lucienfostier/gaffer/contributors","subscribers_url":"https://api.github.com/repos/lucienfostier/gaffer/subscribers","subscription_url":"https://api.github.com/repos/lucienfostier/gaffer/subscription","commits_url":"https://api.github.com/repos/lucienfostier/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucienfostier/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucienfostier/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucienfostier/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucienfostier/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/lucienfostier/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucienfostier/gaffer/merges","archive_url":"https://api.github.com/repos/lucienfostier/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucienfostier/gaffer/downloads","issues_url":"https://api.github.com/repos/lucienfostier/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/lucienfostier/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/lucienfostier/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/lucienfostier/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucienfostier/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/lucienfostier/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/lucienfostier/gaffer/deployments","created_at":"2014-12-12T01:23:26Z","updated_at":"2016-04-05T19:39:13Z","pushed_at":"2016-08-08T05:34:50Z","git_url":"git://github.com/lucienfostier/gaffer.git","ssh_url":"git@github.com:lucienfostier/gaffer.git","clone_url":"https://github.com/lucienfostier/gaffer.git","svn_url":"https://github.com/lucienfostier/gaffer","homepage":"http://imageengine.github.io/gaffer/","size":106725,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ImageEngine:master","ref":"master","sha":"e677b3641f44317b226eb7d0af55199b62dc203c","user":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=3","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":9043124,"name":"gaffer","full_name":"ImageEngine/gaffer","owner":{"login":"ImageEngine","id":3976662,"avatar_url":"https://avatars.githubusercontent.com/u/3976662?v=3","gravatar_id":"","url":"https://api.github.com/users/ImageEngine","html_url":"https://github.com/ImageEngine","followers_url":"https://api.github.com/users/ImageEngine/followers","following_url":"https://api.github.com/users/ImageEngine/following{/other_user}","gists_url":"https://api.github.com/users/ImageEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/ImageEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImageEngine/subscriptions","organizations_url":"https://api.github.com/users/ImageEngine/orgs","repos_url":"https://api.github.com/users/ImageEngine/repos","events_url":"https://api.github.com/users/ImageEngine/events{/privacy}","received_events_url":"https://api.github.com/users/ImageEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ImageEngine/gaffer","description":"Gaffer is an open source application framework designed specifically for creating tools for use in visual effects production.","fork":false,"url":"https://api.github.com/repos/ImageEngine/gaffer","forks_url":"https://api.github.com/repos/ImageEngine/gaffer/forks","keys_url":"https://api.github.com/repos/ImageEngine/gaffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImageEngine/gaffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImageEngine/gaffer/teams","hooks_url":"https://api.github.com/repos/ImageEngine/gaffer/hooks","issue_events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/events{/number}","events_url":"https://api.github.com/repos/ImageEngine/gaffer/events","assignees_url":"https://api.github.com/repos/ImageEngine/gaffer/assignees{/user}","branches_url":"https://api.github.com/repos/ImageEngine/gaffer/branches{/branch}","tags_url":"https://api.github.com/repos/ImageEngine/gaffer/tags","blobs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImageEngine/gaffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImageEngine/gaffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImageEngine/gaffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImageEngine/gaffer/statuses/{sha}","languages_url":"https://api.github.com/repos/ImageEngine/gaffer/languages","stargazers_url":"https://api.github.com/repos/ImageEngine/gaffer/stargazers","contributors_url":"https://api.github.com/repos/ImageEngine/gaffer/contributors","subscribers_url":"https://api.github.com/repos/ImageEngine/gaffer/subscribers","subscription_url":"https://api.github.com/repos/ImageEngine/gaffer/subscription","commits_url":"https://api.github.com/repos/ImageEngine/gaffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImageEngine/gaffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImageEngine/gaffer/contents/{+path}","compare_url":"https://api.github.com/repos/ImageEngine/gaffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImageEngine/gaffer/merges","archive_url":"https://api.github.com/repos/ImageEngine/gaffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImageEngine/gaffer/downloads","issues_url":"https://api.github.com/repos/ImageEngine/gaffer/issues{/number}","pulls_url":"https://api.github.com/repos/ImageEngine/gaffer/pulls{/number}","milestones_url":"https://api.github.com/repos/ImageEngine/gaffer/milestones{/number}","notifications_url":"https://api.github.com/repos/ImageEngine/gaffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/labels{/name}","releases_url":"https://api.github.com/repos/ImageEngine/gaffer/releases{/id}","deployments_url":"https://api.github.com/repos/ImageEngine/gaffer/deployments","created_at":"2013-03-27T00:04:53Z","updated_at":"2016-07-31T12:09:47Z","pushed_at":"2016-08-08T05:34:51Z","git_url":"git://github.com/ImageEngine/gaffer.git","ssh_url":"git@github.com:ImageEngine/gaffer.git","clone_url":"https://github.com/ImageEngine/gaffer.git","svn_url":"https://github.com/ImageEngine/gaffer","homepage":"http://www.gafferhq.org","size":110278,"stargazers_count":222,"watchers_count":222,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":205,"forks":86,"open_issues":205,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802"},"html":{"href":"https://github.com/ImageEngine/gaffer/pull/1802"},"issue":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1802"},"comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/issues/1802/comments"},"review_comments":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802/comments"},"review_comment":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1802/commits"},"statuses":{"href":"https://api.github.com/repos/ImageEngine/gaffer/statuses/3a6cc2b75764c7953052b35a099c9581e246c6ab"}}}}
{"actor":{"display_login":"andrewkaufman"}}