{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/14892","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/14892/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/14892/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/14892/events","html_url":"https://github.com/guardian/frontend/pull/14892","id":187359593,"number":14892,"title":"Remove the old stripe implementation and replace with stripe checkout.","user":{"login":"AWare","id":2670496,"avatar_url":"https://avatars.githubusercontent.com/u/2670496?v=3","gravatar_id":"","url":"https://api.github.com/users/AWare","html_url":"https://github.com/AWare","followers_url":"https://api.github.com/users/AWare/followers","following_url":"https://api.github.com/users/AWare/following{/other_user}","gists_url":"https://api.github.com/users/AWare/gists{/gist_id}","starred_url":"https://api.github.com/users/AWare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWare/subscriptions","organizations_url":"https://api.github.com/users/AWare/orgs","repos_url":"https://api.github.com/users/AWare/repos","events_url":"https://api.github.com/users/AWare/events{/privacy}","received_events_url":"https://api.github.com/users/AWare/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-04T15:15:05Z","updated_at":"2016-11-04T15:40:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/14892","html_url":"https://github.com/guardian/frontend/pull/14892","diff_url":"https://github.com/guardian/frontend/pull/14892.diff","patch_url":"https://github.com/guardian/frontend/pull/14892.patch"},"body":"<!--\r\n[We'd love some feedback on any struggles you had with this PR](https://goo.gl/forms/QRQaco334CdpfmNF2).\r\nAll the questions are optional. Any amount of feedback is great!\r\n-->\r\n\r\n## What does this change?\r\nThis replaces the _quite old_ stripe implementation with a new one based on stripe checkout.\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nMembership and subscriptions are replacing their stripe implementations with one based on stripe checkout. (Happy to explain any details on this in person.)\r\n\r\n<!--\r\nIf setting up an AB test, make sure you have read our [AB testing doc](https://github.com/guardian/frontend/blob/master/docs/03-dev-howtos/01-ab-testing.md).\r\n-->\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo.\r\n<!--\r\nRun the AMP test suite with `make validate-amp`\r\n\r\nYou should also validate a specific page that your change affects by adding the amp query string along with the development hash: http://localhost:3000/sport/2016/aug/25/katie-ledecky-first-pitch-washington-nationals-bryce-harper?amp=1#development=1\r\n\r\nThe AMP validation results will appear in your console.\r\n-->\r\n\r\n## Screenshots\r\n\r\n![image](https://cloud.githubusercontent.com/assets/2670496/20010774/4fd9765c-a2a1-11e6-8e66-d73a6b54f095.png)\r\n\r\n## Request for comment\r\n@SiAdcock @paulbrown1982 \r\nNB: This should have a logo, but adding it to stripe is a one line change which I'll do with any desired changes. \r\n\r\n<!--\r\n*Does this PR meet the [contributing guidelines](https://github.com/guardian/frontend/blob/issue_pr_templates/.github/CONTRIBUTING.md#submission)?*\r\n-->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/258466007","html_url":"https://github.com/guardian/frontend/pull/14892#issuecomment-258466007","issue_url":"https://api.github.com/repos/guardian/frontend/issues/14892","id":258466007,"user":{"login":"SiAdcock","id":5931528,"avatar_url":"https://avatars.githubusercontent.com/u/5931528?v=3","gravatar_id":"","url":"https://api.github.com/users/SiAdcock","html_url":"https://github.com/SiAdcock","followers_url":"https://api.github.com/users/SiAdcock/followers","following_url":"https://api.github.com/users/SiAdcock/following{/other_user}","gists_url":"https://api.github.com/users/SiAdcock/gists{/gist_id}","starred_url":"https://api.github.com/users/SiAdcock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiAdcock/subscriptions","organizations_url":"https://api.github.com/users/SiAdcock/orgs","repos_url":"https://api.github.com/users/SiAdcock/repos","events_url":"https://api.github.com/users/SiAdcock/events{/privacy}","received_events_url":"https://api.github.com/users/SiAdcock/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T15:40:22Z","updated_at":"2016-11-04T15:40:22Z","body":"Looks nice dude. I wonder if we should be using our `fastdom` wrapper for the DOM manipulations? Have a look at [this file](https://github.com/guardian/frontend/blob/master/static/src/javascripts/projects/common/modules/navigation/newHeaderNavigation.js#L28) for an idea of how you can use it"}}
{"actor":{"display_login":"SiAdcock"}}