{"action":"closed","number":7564,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7564","id":76457195,"html_url":"https://github.com/nodejs/node/pull/7564","diff_url":"https://github.com/nodejs/node/pull/7564.diff","patch_url":"https://github.com/nodejs/node/pull/7564.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7564","number":7564,"state":"closed","locked":false,"title":"core: normalize malloc, realloc ","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"body":"<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [X] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ncore\r\n\r\n malloc(0) and realloc(ptr, 0) have implementation-defined behavior in\r\n that the standard allows them to either return a unique pointer or a\r\n nullptr for zero-sized allocation requests.  Normalize by always using\r\n a nullptr.\r\n\r\n    - Introduce node::malloc, node::realloc and node::calloc that should\r\n      be used throught our source.\r\n    - Update all existing node source files to use the new functions\r\n      instead of the native allocation functions.\r\n\r\n\r\n","created_at":"2016-07-06T15:59:12Z","updated_at":"2016-09-06T13:52:40Z","closed_at":"2016-09-06T13:52:40Z","merged_at":null,"merge_commit_sha":"17e6c5eb4126b7efddae2d4ae21ee5851272117b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7564/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7564/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7564/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/7517bfee106fb5fad008ceb08c1eb1f45a0cb127","head":{"label":"mhdawson:aix3","ref":"aix3","sha":"7517bfee106fb5fad008ceb08c1eb1f45a0cb127","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"repo":{"id":38691521,"name":"io.js","full_name":"mhdawson/io.js","owner":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhdawson/io.js","description":"Future Node.js releases will be based on io.js","fork":true,"url":"https://api.github.com/repos/mhdawson/io.js","forks_url":"https://api.github.com/repos/mhdawson/io.js/forks","keys_url":"https://api.github.com/repos/mhdawson/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhdawson/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhdawson/io.js/teams","hooks_url":"https://api.github.com/repos/mhdawson/io.js/hooks","issue_events_url":"https://api.github.com/repos/mhdawson/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/mhdawson/io.js/events","assignees_url":"https://api.github.com/repos/mhdawson/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/mhdawson/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/mhdawson/io.js/tags","blobs_url":"https://api.github.com/repos/mhdawson/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhdawson/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhdawson/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhdawson/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhdawson/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mhdawson/io.js/languages","stargazers_url":"https://api.github.com/repos/mhdawson/io.js/stargazers","contributors_url":"https://api.github.com/repos/mhdawson/io.js/contributors","subscribers_url":"https://api.github.com/repos/mhdawson/io.js/subscribers","subscription_url":"https://api.github.com/repos/mhdawson/io.js/subscription","commits_url":"https://api.github.com/repos/mhdawson/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhdawson/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhdawson/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhdawson/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhdawson/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/mhdawson/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhdawson/io.js/merges","archive_url":"https://api.github.com/repos/mhdawson/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhdawson/io.js/downloads","issues_url":"https://api.github.com/repos/mhdawson/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/mhdawson/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mhdawson/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mhdawson/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhdawson/io.js/labels{/name}","releases_url":"https://api.github.com/repos/mhdawson/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/mhdawson/io.js/deployments","created_at":"2015-07-07T14:04:11Z","updated_at":"2016-01-14T22:40:07Z","pushed_at":"2016-09-02T15:09:19Z","git_url":"git://github.com/mhdawson/io.js.git","ssh_url":"git@github.com:mhdawson/io.js.git","clone_url":"https://github.com/mhdawson/io.js.git","svn_url":"https://github.com/mhdawson/io.js","homepage":"https://iojs.org","size":215308,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3504a98b7247a82debcd4f78540b4711c0bbbf41","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-06T13:26:34Z","pushed_at":"2016-09-06T13:52:18Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":300473,"stargazers_count":26428,"watchers_count":26428,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4135,"mirror_url":null,"open_issues_count":767,"forks":4135,"open_issues":767,"watchers":26428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7564"},"html":{"href":"https://github.com/nodejs/node/pull/7564"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7564"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7564/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7564/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7564/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/7517bfee106fb5fad008ceb08c1eb1f45a0cb127"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":25,"review_comments":4,"commits":2,"additions":68,"deletions":38,"changed_files":12}}
{"actor":{"display_login":"mhdawson"}}