{"action":"created","issue":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2342","repository_url":"https://api.github.com/repos/MovingBlocks/Terasology","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2342/labels{/name}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2342/comments","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2342/events","html_url":"https://github.com/MovingBlocks/Terasology/issues/2342","id":158571786,"number":2342,"title":"Filtering modules can impact world gen availability on create game screen","user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/Bite-size","name":"Bite-size","color":"007D00"},{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/Bug","name":"Bug","color":"e10c02"},{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/Hacktoberfest","name":"Hacktoberfest","color":"CE873D"},{"url":"https://api.github.com/repos/MovingBlocks/Terasology/labels/UI","name":"UI","color":"06FF06"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-06-05T20:08:23Z","updated_at":"2016-10-07T03:25:36Z","closed_at":null,"body":"It seems a bit inconsistent exactly how to make it trigger, but the most obvious way I can provoke it is opening the \"Modules\" menu off \"Create Game\" then entering gibberish in the filter box, resulting in no listed modules. Then going back to \"Create Game\" suddenly shows no world generators available (regardless of what modules you actually have enabled)\r\n\r\nI suspect whatever module context is being used for the filtering manages to slip back to the active module context being considered on the create game screen. Something needs to be reset or encapsulated better. Probably an easy fix.\r\n\r\n![modulesfilteredfunny](https://cloud.githubusercontent.com/assets/1063833/15807932/b73ac594-2b37-11e6-9e81-63ba95a6d1f7.png)\r\n\r\nMaybe slightly related: #2074 - as it attempted to change how stuff preloads for preview and such.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34886775-filtering-modules-can-impact-world-gen-availability-on-create-game-screen?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments/252144731","html_url":"https://github.com/MovingBlocks/Terasology/issues/2342#issuecomment-252144731","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2342","id":252144731,"user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T03:25:36Z","updated_at":"2016-10-07T03:25:36Z","body":"Oh, right, let me clarify.\r\n\r\nRemoving `moduleConfig.clear();` *did* correct the issue stated, but it then introduces a different bug: modules can no longer be de-selected (they never get cleared)\r\n\r\nWe need to figure out and maybe split apart some module-holding collection(s) of some sort. So you *can* filter in that textbox, but without having its state affect what the main create game screen thinks is available for world generation.\r\n\r\nProbably the same collection is being used for the filtering and the world gen scanning. So by filtering you clear out the stuff you need back on the main create game screen. Something like that."}}
{"actor":{"display_login":"Cervator"}}