{"action":"created","issue":{"url":"https://api.github.com/repos/georust/rust-geo/issues/68","repository_url":"https://api.github.com/repos/georust/rust-geo","labels_url":"https://api.github.com/repos/georust/rust-geo/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/georust/rust-geo/issues/68/comments","events_url":"https://api.github.com/repos/georust/rust-geo/issues/68/events","html_url":"https://github.com/georust/rust-geo/pull/68","id":181914613,"number":68,"title":"Document Polygon struct parameters","user":{"login":"mbattifarano","id":1844175,"avatar_url":"https://avatars.githubusercontent.com/u/1844175?v=3","gravatar_id":"","url":"https://api.github.com/users/mbattifarano","html_url":"https://github.com/mbattifarano","followers_url":"https://api.github.com/users/mbattifarano/followers","following_url":"https://api.github.com/users/mbattifarano/following{/other_user}","gists_url":"https://api.github.com/users/mbattifarano/gists{/gist_id}","starred_url":"https://api.github.com/users/mbattifarano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbattifarano/subscriptions","organizations_url":"https://api.github.com/users/mbattifarano/orgs","repos_url":"https://api.github.com/users/mbattifarano/repos","events_url":"https://api.github.com/users/mbattifarano/events{/privacy}","received_events_url":"https://api.github.com/users/mbattifarano/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-09T21:57:08Z","updated_at":"2016-10-16T21:58:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/georust/rust-geo/pulls/68","html_url":"https://github.com/georust/rust-geo/pull/68","diff_url":"https://github.com/georust/rust-geo/pull/68.diff","patch_url":"https://github.com/georust/rust-geo/pull/68.patch"},"body":"Addresses #60\r\n\r\nReplaces the Polygon tuple struct with a regular struct:\r\n\r\n```\r\npub struct Polygon<T>\r\n    where T: Float\r\n{\r\n    pub exterior: LineString<T>,\r\n    pub interiors: Vec<LineString<T>>\r\n}\r\n```\r\n\r\nI'm new to rust and eager to learn so comment away!\r\n\r\nThis breaks the existing Polygon constructor since (correct me if\r\nI'm wrong) structs must be instaniated with curly braces and named\r\narguments. To mitigate the effect of this change on existing code,\r\n`Polygon` implements a `new` method that preserves the old interface:\r\n\r\n`Polygon::new(exterior, interiors)`\r\n\r\nI chose `exterior` and `interiors` over `outer` and `inners` as I\r\nbelieve the former pair is more commonly used. I don't feel strongly\r\nabout this choice and will change it upon request."},"comment":{"url":"https://api.github.com/repos/georust/rust-geo/issues/comments/254078111","html_url":"https://github.com/georust/rust-geo/pull/68#issuecomment-254078111","issue_url":"https://api.github.com/repos/georust/rust-geo/issues/68","id":254078111,"user":{"login":"frewsxcv","id":416575,"avatar_url":"https://avatars.githubusercontent.com/u/416575?v=3","gravatar_id":"","url":"https://api.github.com/users/frewsxcv","html_url":"https://github.com/frewsxcv","followers_url":"https://api.github.com/users/frewsxcv/followers","following_url":"https://api.github.com/users/frewsxcv/following{/other_user}","gists_url":"https://api.github.com/users/frewsxcv/gists{/gist_id}","starred_url":"https://api.github.com/users/frewsxcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frewsxcv/subscriptions","organizations_url":"https://api.github.com/users/frewsxcv/orgs","repos_url":"https://api.github.com/users/frewsxcv/repos","events_url":"https://api.github.com/users/frewsxcv/events{/privacy}","received_events_url":"https://api.github.com/users/frewsxcv/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T21:58:37Z","updated_at":"2016-10-16T21:58:37Z","body":"Looks like there are a few more places the new `Polygon` needs to be used."}}
{"actor":{"display_login":"frewsxcv"}}