{"action":"closed","issue":{"url":"https://api.github.com/repos/zencart/zencart/issues/270","repository_url":"https://api.github.com/repos/zencart/zencart","labels_url":"https://api.github.com/repos/zencart/zencart/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/zencart/zencart/issues/270/comments","events_url":"https://api.github.com/repos/zencart/zencart/issues/270/events","html_url":"https://github.com/zencart/zencart/issues/270","id":53975884,"number":270,"title":"Review all uses of htmlspecialchars and zen_db_output","user":{"login":"drbyte","id":404472,"avatar_url":"https://avatars.githubusercontent.com/u/404472?v=3","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zencart/zencart/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"closed","locked":false,"assignee":{"login":"drbyte","id":404472,"avatar_url":"https://avatars.githubusercontent.com/u/404472?v=3","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false},"assignees":[{"login":"drbyte","id":404472,"avatar_url":"https://avatars.githubusercontent.com/u/404472?v=3","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/zencart/zencart/milestones/1","html_url":"https://github.com/zencart/zencart/milestones/v1.6.0","labels_url":"https://api.github.com/repos/zencart/zencart/milestones/1/labels","id":487388,"number":1,"title":"v1.6.0","description":"","creator":{"login":"drbyte","id":404472,"avatar_url":"https://avatars.githubusercontent.com/u/404472?v=3","gravatar_id":"","url":"https://api.github.com/users/drbyte","html_url":"https://github.com/drbyte","followers_url":"https://api.github.com/users/drbyte/followers","following_url":"https://api.github.com/users/drbyte/following{/other_user}","gists_url":"https://api.github.com/users/drbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/drbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbyte/subscriptions","organizations_url":"https://api.github.com/users/drbyte/orgs","repos_url":"https://api.github.com/users/drbyte/repos","events_url":"https://api.github.com/users/drbyte/events{/privacy}","received_events_url":"https://api.github.com/users/drbyte/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":166,"state":"open","created_at":"2013-11-17T03:11:42Z","updated_at":"2016-07-25T14:48:18Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-01-10T23:48:09Z","updated_at":"2016-07-25T14:48:18Z","closed_at":"2016-07-25T14:48:18Z","body":"I'm pretty sure that all remaining references to `zen_db_output()` should actually be using `zen_output_string_protected()` for consistency.\r\n\r\n... and maybe then temporarily move `zen_db_output()` to the compatibility functions file and redefine it to be a call to `zen_output_string_protected()`, for retirement in a future version.\r\n\r\nFurther, I think a review of all direct calls to `htmlspecialchars()` should be done to replace them with `zen_output_string_protected()` also ... unless there's a specific reason not to.\r\n\r\n\r\nCredits to @lat9 http://www.zen-cart.com/showthread.php?215798"}}
{"actor":{"display_login":"zcwilt"}}