{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10217","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10217/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10217/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10217/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10217","id":185245469,"number":10217,"title":"sql: implement pg_catalog.pg_proc","user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars.githubusercontent.com/u/43821?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars.githubusercontent.com/u/5438456?v=3","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-10-25T21:59:23Z","updated_at":"2016-10-31T17:33:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10217","html_url":"https://github.com/cockroachdb/cockroach/pull/10217","diff_url":"https://github.com/cockroachdb/cockroach/pull/10217.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10217.patch"},"body":"`pg_catalog.pg_proc` is a virtual table that contains information on builtin functions.\r\n\r\nSeveral of the columns have been left unimplemented. Please take note of the unimplemented columns - it's possible that we need to add better placeholders or implementations for those. We also don't support `ARRAY`s sufficiently to use them for the array type columns in `pg_proc`.\r\n\r\nIntroduce `parser.TypeAny`, corresponding to a postgres `anyelement` type, and use this instead of NULL for the return type of `least` and `greatest`.\r\n\r\n\r\nFixes #10075.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\n\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10217)\r\n\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/257362359","html_url":"https://github.com/cockroachdb/cockroach/pull/10217#issuecomment-257362359","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10217","id":257362359,"user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars.githubusercontent.com/u/43821?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T17:33:41Z","updated_at":"2016-10-31T17:33:41Z","body":"\n\n\n\nReview status: 1 of 10 files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.\n\n---\n\n*[pkg/sql/parser/type.go, line 82 at r4](https://reviewable.io:443/reviews/cockroachdb/cockroach/10217#-KVQjrEz8JEVCsh_Z5eh:-KVQksdKj_Neb6-4qFh4:b-896fix) ([raw file](https://github.com/cockroachdb/cockroach/blob/7231a567e6ec4b365a45c382c2fd5789b52b0df5/pkg/sql/parser/type.go#L82)):*\n<details><summary><i>Previously, mjibson (Matt Jibson) wrote…</i></summary>\n> \"any time\"? I think this comment needs fixing.\n</details>\nDone.\n\n---\n\n*[pkg/sql/parser/type.go, line 263 at r4](https://reviewable.io:443/reviews/cockroachdb/cockroach/10217#-KVQk-xGyTU49TfuIYsW:-KVQl5at1H1AVRHmri1g:b-o5d27j) ([raw file](https://github.com/cockroachdb/cockroach/blob/7231a567e6ec4b365a45c382c2fd5789b52b0df5/pkg/sql/parser/type.go#L263)):*\n<details><summary><i>Previously, mjibson (Matt Jibson) wrote…</i></summary>\n> We don't want to stick with `<T>`? I like that more than \"anyelement\".\n</details>\nSticking with `<T>` in the docs would require splitting the `String()` method here - since we'd need one string for the docs and one for the name of the type in the `pg_type` table, which needs to be `anyelement` for postgres compatibility.\n\nAlternatively we could resurrect the special casing in the docs. Thoughts?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/10217)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jordanlewis"}}