{"action":"closed","number":776,"pull_request":{"url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/776","id":86430189,"html_url":"https://github.com/jackhumbert/qmk_firmware/pull/776","diff_url":"https://github.com/jackhumbert/qmk_firmware/pull/776.diff","patch_url":"https://github.com/jackhumbert/qmk_firmware/pull/776.patch","issue_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/776","number":776,"state":"closed","locked":false,"title":"Fix issue #772 Meh and Hyper not working","user":{"login":"DidierLoiseau","id":6871742,"avatar_url":"https://avatars.githubusercontent.com/u/6871742?v=3","gravatar_id":"","url":"https://api.github.com/users/DidierLoiseau","html_url":"https://github.com/DidierLoiseau","followers_url":"https://api.github.com/users/DidierLoiseau/followers","following_url":"https://api.github.com/users/DidierLoiseau/following{/other_user}","gists_url":"https://api.github.com/users/DidierLoiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/DidierLoiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DidierLoiseau/subscriptions","organizations_url":"https://api.github.com/users/DidierLoiseau/orgs","repos_url":"https://api.github.com/users/DidierLoiseau/repos","events_url":"https://api.github.com/users/DidierLoiseau/events{/privacy}","received_events_url":"https://api.github.com/users/DidierLoiseau/received_events","type":"User","site_admin":false},"body":"Keys defined as `LCTL(LSFT(KC_NO))` will now behave exactly the same as if they were defined as `LCTL(KC_LSFT)`. This is the case for `MEH`, `HYPR` and `LCAG` (see [keymap.h](https://github.com/jackhumbert/qmk_firmware/blob/0f205a854ff18967acef5a6060efb655b6b77247/quantum/keymap.h#L182-L193)):\r\n\r\n```c\r\n#define HYPR(kc) (kc | QK_LCTL | QK_LSFT | QK_LALT | QK_LGUI)\r\n#define MEH(kc)  (kc | QK_LCTL | QK_LSFT | QK_LALT)\r\n#define LCAG(kc) (kc | QK_LCTL | QK_LALT | QK_LGUI)\r\n```\r\nThis fixes #772 as those keys used to have their mods set as `weak_mods`, which made them quite useless.\r\n\r\nActually, this change would even allow to redefine all modifier keys based on `KC_NO`, e.g.:\r\n```c\r\n#define KC_LCTRL LCTL(KC_NO)\r\n```\r\nwhich would free up keycodes `0xE0` - `0xE7` in [keycode.h](https://github.com/jackhumbert/qmk_firmware/blob/0f205a854ff18967acef5a6060efb655b6b77247/tmk_core/common/keycode.h#L385-L393).","created_at":"2016-09-22T23:09:53Z","updated_at":"2016-09-23T19:26:29Z","closed_at":"2016-09-23T19:26:29Z","merged_at":"2016-09-23T19:26:28Z","merge_commit_sha":"3d42d60b7f778d20f11f058aa278effce2bdb9c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/776/commits","review_comments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/776/comments","review_comment_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/776/comments","statuses_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/statuses/d4309990472895bbbe82f7ba22ed33c16f928778","head":{"label":"DidierLoiseau:issue-772","ref":"issue-772","sha":"d4309990472895bbbe82f7ba22ed33c16f928778","user":{"login":"DidierLoiseau","id":6871742,"avatar_url":"https://avatars.githubusercontent.com/u/6871742?v=3","gravatar_id":"","url":"https://api.github.com/users/DidierLoiseau","html_url":"https://github.com/DidierLoiseau","followers_url":"https://api.github.com/users/DidierLoiseau/followers","following_url":"https://api.github.com/users/DidierLoiseau/following{/other_user}","gists_url":"https://api.github.com/users/DidierLoiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/DidierLoiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DidierLoiseau/subscriptions","organizations_url":"https://api.github.com/users/DidierLoiseau/orgs","repos_url":"https://api.github.com/users/DidierLoiseau/repos","events_url":"https://api.github.com/users/DidierLoiseau/events{/privacy}","received_events_url":"https://api.github.com/users/DidierLoiseau/received_events","type":"User","site_admin":false},"repo":{"id":48702636,"name":"qmk_firmware","full_name":"DidierLoiseau/qmk_firmware","owner":{"login":"DidierLoiseau","id":6871742,"avatar_url":"https://avatars.githubusercontent.com/u/6871742?v=3","gravatar_id":"","url":"https://api.github.com/users/DidierLoiseau","html_url":"https://github.com/DidierLoiseau","followers_url":"https://api.github.com/users/DidierLoiseau/followers","following_url":"https://api.github.com/users/DidierLoiseau/following{/other_user}","gists_url":"https://api.github.com/users/DidierLoiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/DidierLoiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DidierLoiseau/subscriptions","organizations_url":"https://api.github.com/users/DidierLoiseau/orgs","repos_url":"https://api.github.com/users/DidierLoiseau/repos","events_url":"https://api.github.com/users/DidierLoiseau/events{/privacy}","received_events_url":"https://api.github.com/users/DidierLoiseau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DidierLoiseau/qmk_firmware","description":"keyboard controller firmware for Atmel AVR USB family","fork":true,"url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware","forks_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/forks","keys_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/events","assignees_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/merges","archive_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/DidierLoiseau/qmk_firmware/deployments","created_at":"2015-12-28T16:54:39Z","updated_at":"2016-03-08T19:59:04Z","pushed_at":"2016-09-22T23:21:09Z","git_url":"git://github.com/DidierLoiseau/qmk_firmware.git","ssh_url":"git@github.com:DidierLoiseau/qmk_firmware.git","clone_url":"https://github.com/DidierLoiseau/qmk_firmware.git","svn_url":"https://github.com/DidierLoiseau/qmk_firmware","homepage":"","size":62419,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jackhumbert:master","ref":"master","sha":"0f205a854ff18967acef5a6060efb655b6b77247","user":{"login":"jackhumbert","id":141431,"avatar_url":"https://avatars.githubusercontent.com/u/141431?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhumbert","html_url":"https://github.com/jackhumbert","followers_url":"https://api.github.com/users/jackhumbert/followers","following_url":"https://api.github.com/users/jackhumbert/following{/other_user}","gists_url":"https://api.github.com/users/jackhumbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhumbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhumbert/subscriptions","organizations_url":"https://api.github.com/users/jackhumbert/orgs","repos_url":"https://api.github.com/users/jackhumbert/repos","events_url":"https://api.github.com/users/jackhumbert/events{/privacy}","received_events_url":"https://api.github.com/users/jackhumbert/received_events","type":"User","site_admin":false},"repo":{"id":27737393,"name":"qmk_firmware","full_name":"jackhumbert/qmk_firmware","owner":{"login":"jackhumbert","id":141431,"avatar_url":"https://avatars.githubusercontent.com/u/141431?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhumbert","html_url":"https://github.com/jackhumbert","followers_url":"https://api.github.com/users/jackhumbert/followers","following_url":"https://api.github.com/users/jackhumbert/following{/other_user}","gists_url":"https://api.github.com/users/jackhumbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhumbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhumbert/subscriptions","organizations_url":"https://api.github.com/users/jackhumbert/orgs","repos_url":"https://api.github.com/users/jackhumbert/repos","events_url":"https://api.github.com/users/jackhumbert/events{/privacy}","received_events_url":"https://api.github.com/users/jackhumbert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackhumbert/qmk_firmware","description":"keyboard controller firmware for Atmel AVR USB family","fork":false,"url":"https://api.github.com/repos/jackhumbert/qmk_firmware","forks_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/forks","keys_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/events","assignees_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/merges","archive_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/jackhumbert/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2016-09-22T17:06:07Z","pushed_at":"2016-09-23T19:26:29Z","git_url":"git://github.com/jackhumbert/qmk_firmware.git","ssh_url":"git@github.com:jackhumbert/qmk_firmware.git","clone_url":"https://github.com/jackhumbert/qmk_firmware.git","svn_url":"https://github.com/jackhumbert/qmk_firmware","homepage":"","size":86684,"stargazers_count":612,"watchers_count":612,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":976,"mirror_url":null,"open_issues_count":68,"forks":976,"open_issues":68,"watchers":612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/776"},"html":{"href":"https://github.com/jackhumbert/qmk_firmware/pull/776"},"issue":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/776"},"comments":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/issues/776/comments"},"review_comments":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/776/comments"},"review_comment":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/pulls/776/commits"},"statuses":{"href":"https://api.github.com/repos/jackhumbert/qmk_firmware/statuses/d4309990472895bbbe82f7ba22ed33c16f928778"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jackhumbert","id":141431,"avatar_url":"https://avatars.githubusercontent.com/u/141431?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhumbert","html_url":"https://github.com/jackhumbert","followers_url":"https://api.github.com/users/jackhumbert/followers","following_url":"https://api.github.com/users/jackhumbert/following{/other_user}","gists_url":"https://api.github.com/users/jackhumbert/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhumbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhumbert/subscriptions","organizations_url":"https://api.github.com/users/jackhumbert/orgs","repos_url":"https://api.github.com/users/jackhumbert/repos","events_url":"https://api.github.com/users/jackhumbert/events{/privacy}","received_events_url":"https://api.github.com/users/jackhumbert/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"jackhumbert"}}