{"action":"created","issue":{"url":"https://api.github.com/repos/ilyabirman/Likely/issues/114","repository_url":"https://api.github.com/repos/ilyabirman/Likely","labels_url":"https://api.github.com/repos/ilyabirman/Likely/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/ilyabirman/Likely/issues/114/comments","events_url":"https://api.github.com/repos/ilyabirman/Likely/issues/114/events","html_url":"https://github.com/ilyabirman/Likely/issues/114","id":197867858,"number":114,"title":"updateCounter uses find which is not defined in this scope","user":{"login":"vitkarpov","id":3001791,"avatar_url":"https://avatars.githubusercontent.com/u/3001791?v=3","gravatar_id":"","url":"https://api.github.com/users/vitkarpov","html_url":"https://github.com/vitkarpov","followers_url":"https://api.github.com/users/vitkarpov/followers","following_url":"https://api.github.com/users/vitkarpov/following{/other_user}","gists_url":"https://api.github.com/users/vitkarpov/gists{/gist_id}","starred_url":"https://api.github.com/users/vitkarpov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitkarpov/subscriptions","organizations_url":"https://api.github.com/users/vitkarpov/orgs","repos_url":"https://api.github.com/users/vitkarpov/repos","events_url":"https://api.github.com/users/vitkarpov/events{/privacy}","received_events_url":"https://api.github.com/users/vitkarpov/received_events","type":"User","site_admin":false},"labels":[{"id":269649693,"url":"https://api.github.com/repos/ilyabirman/Likely/labels/Bug","name":"Bug","color":"ff0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-28T15:10:57Z","updated_at":"2016-12-28T15:46:02Z","closed_at":null,"body":"updateCounter [uses find](https://github.com/ilyabirman/Likely/blob/master/source/button.js#L158) but [there's no import of this method](https://github.com/ilyabirman/Likely/blob/master/source/button.js#L1) from `dom.js`.\r\n\r\nSo, Uglifyjs just drops it from bundle \r\n\r\n![2016-12-28_18-07-38](https://cloud.githubusercontent.com/assets/3001791/21524626/91b59d2e-cd28-11e6-92a2-2a11d5f9fb6a.png)\r\n\r\nSeems `updateCounter` should not work as expected"},"comment":{"url":"https://api.github.com/repos/ilyabirman/Likely/issues/comments/269495017","html_url":"https://github.com/ilyabirman/Likely/issues/114#issuecomment-269495017","issue_url":"https://api.github.com/repos/ilyabirman/Likely/issues/114","id":269495017,"user":{"login":"vitkarpov","id":3001791,"avatar_url":"https://avatars.githubusercontent.com/u/3001791?v=3","gravatar_id":"","url":"https://api.github.com/users/vitkarpov","html_url":"https://github.com/vitkarpov","followers_url":"https://api.github.com/users/vitkarpov/followers","following_url":"https://api.github.com/users/vitkarpov/following{/other_user}","gists_url":"https://api.github.com/users/vitkarpov/gists{/gist_id}","starred_url":"https://api.github.com/users/vitkarpov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitkarpov/subscriptions","organizations_url":"https://api.github.com/users/vitkarpov/orgs","repos_url":"https://api.github.com/users/vitkarpov/repos","events_url":"https://api.github.com/users/vitkarpov/events{/privacy}","received_events_url":"https://api.github.com/users/vitkarpov/received_events","type":"User","site_admin":false},"created_at":"2016-12-28T15:46:02Z","updated_at":"2016-12-28T15:46:02Z","body":"> Seems like this uses non-standard window.find\r\n\r\nExactly!\r\n\r\n![2016-12-28_18-44-47](https://cloud.githubusercontent.com/assets/3001791/21525336/c2465db6-cd2d-11e6-9967-3906ba571e14.png)\r\n\r\n\r\nAlso turns out that we don't have tests which cover the case, I mean `updateCounter` works but not as expected in case when `find` should return `true` but we don't know it."}}
{"actor":{"display_login":"vitkarpov"}}