{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/25317","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/25317/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/25317/comments","events_url":"https://api.github.com/repos/docker/docker/issues/25317/events","html_url":"https://github.com/docker/docker/pull/25317","id":168793074,"number":25317,"title":"Support `--group` in `docker service create`","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-02T03:44:44Z","updated_at":"2016-08-26T08:42:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/25317","html_url":"https://github.com/docker/docker/pull/25317","diff_url":"https://github.com/docker/docker/pull/25317.diff","patch_url":"https://github.com/docker/docker/pull/25317.patch"},"body":"**- What I did**\r\n\r\nThis fix tries to address the issue raised in #25304 to support `--group` in `docker service create`.\r\n\r\n**- How I did it**\r\n\r\nThis fix adds `--group` to `docker service create`, and adds `Group []string` to ContainerSpec in engine-api and swarmkit for the needed changes.\r\n\r\nThe `Config` and `HostConfig` in container remain the same formats. The groups are appended to `HostConfig.GroupAdd` if needed.\r\n\r\n**- How to verify it**\r\n\r\nAn additional integration test has bee added.\r\n\r\n**- Description for the changelog**\r\n\r\nSupport `--group` in `docker service create`\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\nThis fix fixes #25304.\r\n\r\n**NOTE: PRs for engine-api and swarmkit will be opened separately**\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/242668616","html_url":"https://github.com/docker/docker/pull/25317#issuecomment-242668616","issue_url":"https://api.github.com/repos/docker/docker/issues/25317","id":242668616,"user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T08:42:17Z","updated_at":"2016-08-26T08:42:17Z","body":"LGTM 🐸"}}
{"actor":{"display_login":"vdemeester"}}