{"action":"created","issue":{"url":"https://api.github.com/repos/CGAL/cgal/issues/756","repository_url":"https://api.github.com/repos/CGAL/cgal","labels_url":"https://api.github.com/repos/CGAL/cgal/issues/756/labels{/name}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/756/comments","events_url":"https://api.github.com/repos/CGAL/cgal/issues/756/events","html_url":"https://github.com/CGAL/cgal/issues/756","id":132400944,"number":756,"title":"Memory leaks in Three","user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CGAL/cgal/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/CGAL/cgal/labels/CGAL%203D%20demo","name":"CGAL 3D demo","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/18","html_url":"https://github.com/CGAL/cgal/milestones/4.10-beta","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/18/labels","id":1878697,"number":18,"title":"4.10-beta","description":"","creator":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":2,"state":"open","created_at":"2016-07-12T15:28:34Z","updated_at":"2016-08-23T14:34:09Z","due_on":"2017-01-14T23:00:00Z","closed_at":null},"comments":5,"created_at":"2016-02-09T11:54:28Z","updated_at":"2016-08-23T14:48:37Z","closed_at":null,"body":"- In the [function `QGLContext* createOpenGLContext()` from `<CGAL/Qt/CreateOpenGLContext.h>`][1] there is a `new QOpenGLContext()` that is never deleted. I suggest that the function `createOpenGLContext()` has a parameter `QObject* parent`, that is passed to the constructor of the `QOpenGLContext`. That way, the object owning the context will destroy it itself.\r\n\r\n- In the [function `Scene_item::~Scene_item`][2], the VAOs are \"destroyed\" but the `QOpenGLVertexArrayObject` objects themselves are not deleted. You should call delete directly, because it is documented that the destructor of `QOpenGLVertexArrayObject` calls `destroy()`.\r\n\r\n[1]: https://github.com/CGAL/cgal/commit/c29b3cb70065311d2f35f195871bd3b239aec203#diff-a6248780195497cd3ed9772798a6efdfR28\r\n[2]: https://github.com/CGAL/cgal/commit/49b45a753d6fefc2b7a7e78bfddb5f6314ac21bd#diff-3713fcfe5df492b2195a6d66e0d2cae1R17"},"comment":{"url":"https://api.github.com/repos/CGAL/cgal/issues/comments/241756227","html_url":"https://github.com/CGAL/cgal/issues/756#issuecomment-241756227","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/756","id":241756227,"user":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"created_at":"2016-08-23T14:48:37Z","updated_at":"2016-08-23T14:48:37Z","body":"Let's close this issue. It seems fixed in Qt-5.3, according to https://github.com/CGAL/cgal/issues/756#issuecomment-241754433."}}
{"actor":{"display_login":"lrineau"}}