{"action":"closed","number":229,"pull_request":{"url":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/229","id":85245914,"html_url":"https://github.com/KanoComputing/kano-toolset/pull/229","diff_url":"https://github.com/KanoComputing/kano-toolset/pull/229.diff","patch_url":"https://github.com/KanoComputing/kano-toolset/pull/229.patch","issue_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/229","number":229,"state":"closed","locked":false,"title":"Prevent GUI thread from being blocked by UDHCPC hook processes","user":{"login":"radujipa","id":3577547,"avatar_url":"https://avatars.githubusercontent.com/u/3577547?v=3","gravatar_id":"","url":"https://api.github.com/users/radujipa","html_url":"https://github.com/radujipa","followers_url":"https://api.github.com/users/radujipa/followers","following_url":"https://api.github.com/users/radujipa/following{/other_user}","gists_url":"https://api.github.com/users/radujipa/gists{/gist_id}","starred_url":"https://api.github.com/users/radujipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radujipa/subscriptions","organizations_url":"https://api.github.com/users/radujipa/orgs","repos_url":"https://api.github.com/users/radujipa/repos","events_url":"https://api.github.com/users/radujipa/events{/privacy}","received_events_url":"https://api.github.com/users/radujipa/received_events","type":"User","site_admin":false},"body":"When connecting to WiFi, the kano.script is executed by the UDHCPC client.\r\nIn this script, we introduce various system hooks to the \"internet connection\r\nup\" event. The latest one was kano-dashboard-sysupdates which launches the\r\nUpdater using the run_cmd command. Even though sysupdates is launched in the\r\nbackground, processes spawned via run_cmd will block due to inheriting fds.\r\n\r\nThis fix says that the sysupdates should be run in the background and also\r\ndiscard the standard output and error, on which it would block due to the\r\nprocesses launched through run_cmd (since it uses Popen with piping\r\nstdout and stderr).\r\n\r\n@Ealdwulf @skarbat @tombettany ","created_at":"2016-09-14T15:07:48Z","updated_at":"2016-09-14T16:09:32Z","closed_at":"2016-09-14T16:09:32Z","merged_at":"2016-09-14T16:09:32Z","merge_commit_sha":"9852a5e81b214bceeb724d4e80786f4b40c55d09","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/229/commits","review_comments_url":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/229/comments","review_comment_url":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/229/comments","statuses_url":"https://api.github.com/repos/KanoComputing/kano-toolset/statuses/0ff310fa068ac5040f5b6a314c23f729f4112436","head":{"label":"KanoComputing:wifi-gui-hanging-fix","ref":"wifi-gui-hanging-fix","sha":"0ff310fa068ac5040f5b6a314c23f729f4112436","user":{"login":"KanoComputing","id":3909402,"avatar_url":"https://avatars.githubusercontent.com/u/3909402?v=3","gravatar_id":"","url":"https://api.github.com/users/KanoComputing","html_url":"https://github.com/KanoComputing","followers_url":"https://api.github.com/users/KanoComputing/followers","following_url":"https://api.github.com/users/KanoComputing/following{/other_user}","gists_url":"https://api.github.com/users/KanoComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComputing/subscriptions","organizations_url":"https://api.github.com/users/KanoComputing/orgs","repos_url":"https://api.github.com/users/KanoComputing/repos","events_url":"https://api.github.com/users/KanoComputing/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComputing/received_events","type":"Organization","site_admin":false},"repo":{"id":17444765,"name":"kano-toolset","full_name":"KanoComputing/kano-toolset","owner":{"login":"KanoComputing","id":3909402,"avatar_url":"https://avatars.githubusercontent.com/u/3909402?v=3","gravatar_id":"","url":"https://api.github.com/users/KanoComputing","html_url":"https://github.com/KanoComputing","followers_url":"https://api.github.com/users/KanoComputing/followers","following_url":"https://api.github.com/users/KanoComputing/following{/other_user}","gists_url":"https://api.github.com/users/KanoComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComputing/subscriptions","organizations_url":"https://api.github.com/users/KanoComputing/orgs","repos_url":"https://api.github.com/users/KanoComputing/repos","events_url":"https://api.github.com/users/KanoComputing/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComputing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KanoComputing/kano-toolset","description":"Shared toolset for OS apps","fork":false,"url":"https://api.github.com/repos/KanoComputing/kano-toolset","forks_url":"https://api.github.com/repos/KanoComputing/kano-toolset/forks","keys_url":"https://api.github.com/repos/KanoComputing/kano-toolset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KanoComputing/kano-toolset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KanoComputing/kano-toolset/teams","hooks_url":"https://api.github.com/repos/KanoComputing/kano-toolset/hooks","issue_events_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/events{/number}","events_url":"https://api.github.com/repos/KanoComputing/kano-toolset/events","assignees_url":"https://api.github.com/repos/KanoComputing/kano-toolset/assignees{/user}","branches_url":"https://api.github.com/repos/KanoComputing/kano-toolset/branches{/branch}","tags_url":"https://api.github.com/repos/KanoComputing/kano-toolset/tags","blobs_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/refs{/sha}","trees_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KanoComputing/kano-toolset/statuses/{sha}","languages_url":"https://api.github.com/repos/KanoComputing/kano-toolset/languages","stargazers_url":"https://api.github.com/repos/KanoComputing/kano-toolset/stargazers","contributors_url":"https://api.github.com/repos/KanoComputing/kano-toolset/contributors","subscribers_url":"https://api.github.com/repos/KanoComputing/kano-toolset/subscribers","subscription_url":"https://api.github.com/repos/KanoComputing/kano-toolset/subscription","commits_url":"https://api.github.com/repos/KanoComputing/kano-toolset/commits{/sha}","git_commits_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/commits{/sha}","comments_url":"https://api.github.com/repos/KanoComputing/kano-toolset/comments{/number}","issue_comment_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/comments{/number}","contents_url":"https://api.github.com/repos/KanoComputing/kano-toolset/contents/{+path}","compare_url":"https://api.github.com/repos/KanoComputing/kano-toolset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KanoComputing/kano-toolset/merges","archive_url":"https://api.github.com/repos/KanoComputing/kano-toolset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KanoComputing/kano-toolset/downloads","issues_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues{/number}","pulls_url":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls{/number}","milestones_url":"https://api.github.com/repos/KanoComputing/kano-toolset/milestones{/number}","notifications_url":"https://api.github.com/repos/KanoComputing/kano-toolset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KanoComputing/kano-toolset/labels{/name}","releases_url":"https://api.github.com/repos/KanoComputing/kano-toolset/releases{/id}","deployments_url":"https://api.github.com/repos/KanoComputing/kano-toolset/deployments","created_at":"2014-03-05T15:17:57Z","updated_at":"2016-03-03T07:51:59Z","pushed_at":"2016-09-14T16:09:32Z","git_url":"git://github.com/KanoComputing/kano-toolset.git","ssh_url":"git@github.com:KanoComputing/kano-toolset.git","clone_url":"https://github.com/KanoComputing/kano-toolset.git","svn_url":"https://github.com/KanoComputing/kano-toolset","homepage":null,"size":887,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":4,"default_branch":"jessie"}},"base":{"label":"KanoComputing:jessie","ref":"jessie","sha":"289126e51845abb5bfbc6a912379e16d4e40dce9","user":{"login":"KanoComputing","id":3909402,"avatar_url":"https://avatars.githubusercontent.com/u/3909402?v=3","gravatar_id":"","url":"https://api.github.com/users/KanoComputing","html_url":"https://github.com/KanoComputing","followers_url":"https://api.github.com/users/KanoComputing/followers","following_url":"https://api.github.com/users/KanoComputing/following{/other_user}","gists_url":"https://api.github.com/users/KanoComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComputing/subscriptions","organizations_url":"https://api.github.com/users/KanoComputing/orgs","repos_url":"https://api.github.com/users/KanoComputing/repos","events_url":"https://api.github.com/users/KanoComputing/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComputing/received_events","type":"Organization","site_admin":false},"repo":{"id":17444765,"name":"kano-toolset","full_name":"KanoComputing/kano-toolset","owner":{"login":"KanoComputing","id":3909402,"avatar_url":"https://avatars.githubusercontent.com/u/3909402?v=3","gravatar_id":"","url":"https://api.github.com/users/KanoComputing","html_url":"https://github.com/KanoComputing","followers_url":"https://api.github.com/users/KanoComputing/followers","following_url":"https://api.github.com/users/KanoComputing/following{/other_user}","gists_url":"https://api.github.com/users/KanoComputing/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComputing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComputing/subscriptions","organizations_url":"https://api.github.com/users/KanoComputing/orgs","repos_url":"https://api.github.com/users/KanoComputing/repos","events_url":"https://api.github.com/users/KanoComputing/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComputing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KanoComputing/kano-toolset","description":"Shared toolset for OS apps","fork":false,"url":"https://api.github.com/repos/KanoComputing/kano-toolset","forks_url":"https://api.github.com/repos/KanoComputing/kano-toolset/forks","keys_url":"https://api.github.com/repos/KanoComputing/kano-toolset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KanoComputing/kano-toolset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KanoComputing/kano-toolset/teams","hooks_url":"https://api.github.com/repos/KanoComputing/kano-toolset/hooks","issue_events_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/events{/number}","events_url":"https://api.github.com/repos/KanoComputing/kano-toolset/events","assignees_url":"https://api.github.com/repos/KanoComputing/kano-toolset/assignees{/user}","branches_url":"https://api.github.com/repos/KanoComputing/kano-toolset/branches{/branch}","tags_url":"https://api.github.com/repos/KanoComputing/kano-toolset/tags","blobs_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/refs{/sha}","trees_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KanoComputing/kano-toolset/statuses/{sha}","languages_url":"https://api.github.com/repos/KanoComputing/kano-toolset/languages","stargazers_url":"https://api.github.com/repos/KanoComputing/kano-toolset/stargazers","contributors_url":"https://api.github.com/repos/KanoComputing/kano-toolset/contributors","subscribers_url":"https://api.github.com/repos/KanoComputing/kano-toolset/subscribers","subscription_url":"https://api.github.com/repos/KanoComputing/kano-toolset/subscription","commits_url":"https://api.github.com/repos/KanoComputing/kano-toolset/commits{/sha}","git_commits_url":"https://api.github.com/repos/KanoComputing/kano-toolset/git/commits{/sha}","comments_url":"https://api.github.com/repos/KanoComputing/kano-toolset/comments{/number}","issue_comment_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/comments{/number}","contents_url":"https://api.github.com/repos/KanoComputing/kano-toolset/contents/{+path}","compare_url":"https://api.github.com/repos/KanoComputing/kano-toolset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KanoComputing/kano-toolset/merges","archive_url":"https://api.github.com/repos/KanoComputing/kano-toolset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KanoComputing/kano-toolset/downloads","issues_url":"https://api.github.com/repos/KanoComputing/kano-toolset/issues{/number}","pulls_url":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls{/number}","milestones_url":"https://api.github.com/repos/KanoComputing/kano-toolset/milestones{/number}","notifications_url":"https://api.github.com/repos/KanoComputing/kano-toolset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KanoComputing/kano-toolset/labels{/name}","releases_url":"https://api.github.com/repos/KanoComputing/kano-toolset/releases{/id}","deployments_url":"https://api.github.com/repos/KanoComputing/kano-toolset/deployments","created_at":"2014-03-05T15:17:57Z","updated_at":"2016-03-03T07:51:59Z","pushed_at":"2016-09-14T16:09:32Z","git_url":"git://github.com/KanoComputing/kano-toolset.git","ssh_url":"git@github.com:KanoComputing/kano-toolset.git","clone_url":"https://github.com/KanoComputing/kano-toolset.git","svn_url":"https://github.com/KanoComputing/kano-toolset","homepage":null,"size":887,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":4,"default_branch":"jessie"}},"_links":{"self":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/229"},"html":{"href":"https://github.com/KanoComputing/kano-toolset/pull/229"},"issue":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/229"},"comments":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/KanoComputing/kano-toolset/statuses/0ff310fa068ac5040f5b6a314c23f729f4112436"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"radujipa","id":3577547,"avatar_url":"https://avatars.githubusercontent.com/u/3577547?v=3","gravatar_id":"","url":"https://api.github.com/users/radujipa","html_url":"https://github.com/radujipa","followers_url":"https://api.github.com/users/radujipa/followers","following_url":"https://api.github.com/users/radujipa/following{/other_user}","gists_url":"https://api.github.com/users/radujipa/gists{/gist_id}","starred_url":"https://api.github.com/users/radujipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radujipa/subscriptions","organizations_url":"https://api.github.com/users/radujipa/orgs","repos_url":"https://api.github.com/users/radujipa/repos","events_url":"https://api.github.com/users/radujipa/events{/privacy}","received_events_url":"https://api.github.com/users/radujipa/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"radujipa"}}