{"action":"created","issue":{"url":"https://api.github.com/repos/giulian2003/ShooterDemo/issues/1","repository_url":"https://api.github.com/repos/giulian2003/ShooterDemo","labels_url":"https://api.github.com/repos/giulian2003/ShooterDemo/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/giulian2003/ShooterDemo/issues/1/comments","events_url":"https://api.github.com/repos/giulian2003/ShooterDemo/issues/1/events","html_url":"https://github.com/giulian2003/ShooterDemo/pull/1","id":191832754,"number":1,"title":"Adding Linux build support","user":{"login":"euseibus","id":4100219,"avatar_url":"https://avatars.githubusercontent.com/u/4100219?v=3","gravatar_id":"","url":"https://api.github.com/users/euseibus","html_url":"https://github.com/euseibus","followers_url":"https://api.github.com/users/euseibus/followers","following_url":"https://api.github.com/users/euseibus/following{/other_user}","gists_url":"https://api.github.com/users/euseibus/gists{/gist_id}","starred_url":"https://api.github.com/users/euseibus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euseibus/subscriptions","organizations_url":"https://api.github.com/users/euseibus/orgs","repos_url":"https://api.github.com/users/euseibus/repos","events_url":"https://api.github.com/users/euseibus/events{/privacy}","received_events_url":"https://api.github.com/users/euseibus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-26T23:37:46Z","updated_at":"2016-11-27T19:55:54Z","closed_at":"2016-11-27T10:59:17Z","pull_request":{"url":"https://api.github.com/repos/giulian2003/ShooterDemo/pulls/1","html_url":"https://github.com/giulian2003/ShooterDemo/pull/1","diff_url":"https://github.com/giulian2003/ShooterDemo/pull/1.diff","patch_url":"https://github.com/giulian2003/ShooterDemo/pull/1.patch"},"body":"Hello there!  I got the demo to compile on Linux.  Here's a pull request if you're interested in the changes, let me know what you think!  Unfortunately, I don't have Windows, so I can't test if it still works, but I hope I did not break anything :)\r\n\r\nChange overview:\r\n1. Adding cmake find scripts for SDL, Assimp, GLM, etc.\r\n2. Modified top CMakeLists.txt\r\n3. Q3Loader.cpp was complaining of missing string types -- included <cstring>\r\n4. main.cpp was using backslash in an include which was confusing GCC\r\n5. resources.cpp uses <filesystem>, which is still experimental for Linux, and is in a different place\r\n6. Q3Map.cpp was using a default assignment for a reference parameter, which was failing the build.\r\n   I am not sure if this is a valid statement in MSVC, but GCC is complaining about it not being an lvalue.\r\n   Have not used this type of thing before, might be some compile flags could mask this problem,\r\n   but I \"fixed\" it for now by not having a default assign.\r\n    -  TArchivedFilesInfoMap ReadArchiveFileNames(unzFile zipFileHandle, TFilePosAndLen& bspFilePosAndLen = TFilePosAndLen())\r\n    +  TArchivedFilesInfoMap ReadArchiveFileNames(unzFile zipFileHandle, TFilePosAndLen& bspFilePosAndLen)\r\n\r\nBuild is successful on Fedora 23 with gcc 5.3.1\r\nNot tested on Windows or Mac"},"comment":{"url":"https://api.github.com/repos/giulian2003/ShooterDemo/issues/comments/263143344","html_url":"https://github.com/giulian2003/ShooterDemo/pull/1#issuecomment-263143344","issue_url":"https://api.github.com/repos/giulian2003/ShooterDemo/issues/1","id":263143344,"user":{"login":"giulian2003","id":13883806,"avatar_url":"https://avatars.githubusercontent.com/u/13883806?v=3","gravatar_id":"","url":"https://api.github.com/users/giulian2003","html_url":"https://github.com/giulian2003","followers_url":"https://api.github.com/users/giulian2003/followers","following_url":"https://api.github.com/users/giulian2003/following{/other_user}","gists_url":"https://api.github.com/users/giulian2003/gists{/gist_id}","starred_url":"https://api.github.com/users/giulian2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giulian2003/subscriptions","organizations_url":"https://api.github.com/users/giulian2003/orgs","repos_url":"https://api.github.com/users/giulian2003/repos","events_url":"https://api.github.com/users/giulian2003/events{/privacy}","received_events_url":"https://api.github.com/users/giulian2003/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T19:55:54Z","updated_at":"2016-11-27T19:55:54Z","body":"That's a good point, I'll move the resource files to a separate github repository. Thanks for the tip!"}}
{"actor":{"display_login":"giulian2003"}}