{"action":"created","issue":{"url":"https://api.github.com/repos/pfsense/pfsense/issues/3322","repository_url":"https://api.github.com/repos/pfsense/pfsense","labels_url":"https://api.github.com/repos/pfsense/pfsense/issues/3322/labels{/name}","comments_url":"https://api.github.com/repos/pfsense/pfsense/issues/3322/comments","events_url":"https://api.github.com/repos/pfsense/pfsense/issues/3322/events","html_url":"https://github.com/pfsense/pfsense/pull/3322","id":197872831,"number":3322,"title":"Add privs to control display of notices","user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"labels":[{"id":264533790,"url":"https://api.github.com/repos/pfsense/pfsense/labels/CLA","name":"CLA","color":"009800","default":false},{"id":508764931,"url":"https://api.github.com/repos/pfsense/pfsense/labels/Tested","name":"Tested","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-28T15:44:39Z","updated_at":"2016-12-29T13:17:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pfsense/pfsense/pulls/3322","html_url":"https://github.com/pfsense/pfsense/pull/3322","diff_url":"https://github.com/pfsense/pfsense/pull/3322.diff","patch_url":"https://github.com/pfsense/pfsense/pull/3322.patch"},"body":"This is a suggested way to allow control of the display and clearing of\r\nnotices. The use case is:\r\n1) A user with minimal page privs (e.g. can just change their password, or access a few status pages or...) should not be automatically able to see notices or clear them. Because notices might contain critical system information which discloses some problem with the system, and clearing them would prevent a full firewall administrator from seeing them.\r\n\r\nFor this implementation:\r\na) Users with all pages (admin, anyone in the admins group or with pages-all priv) will see notices and can clear them.\r\nb) Users with user-view-notices can see the notices but not clear them.\r\nc) Users with user-view-clear-notices can see the notices and also clear them.\r\nd) Other users do not see notices.\r\n\r\nIn its current implementation, this is not totally backward-compatible.\r\nUsers who have only a few page privs will see notices prior to upgrade, then after upgrade they will not be able to see notices. The firewall administrator will have to grant them user-view-notices or user-view-clear-notices if they wish these users to see and/or clear notices.\r\n\r\nIt would be possible to automatically add these privs to existing users as a config upgrade step, but actually I suspect that in 99% of cases the firewall admin would not really want such users to see/clear notices.\r\n\r\nDiscussion welcome..."},"comment":{"url":"https://api.github.com/repos/pfsense/pfsense/issues/comments/269628997","html_url":"https://github.com/pfsense/pfsense/pull/3322#issuecomment-269628997","issue_url":"https://api.github.com/repos/pfsense/pfsense/issues/3322","id":269628997,"user":{"login":"phil-davis","id":1535615,"avatar_url":"https://avatars.githubusercontent.com/u/1535615?v=3","gravatar_id":"","url":"https://api.github.com/users/phil-davis","html_url":"https://github.com/phil-davis","followers_url":"https://api.github.com/users/phil-davis/followers","following_url":"https://api.github.com/users/phil-davis/following{/other_user}","gists_url":"https://api.github.com/users/phil-davis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-davis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-davis/subscriptions","organizations_url":"https://api.github.com/users/phil-davis/orgs","repos_url":"https://api.github.com/users/phil-davis/repos","events_url":"https://api.github.com/users/phil-davis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-davis/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T13:17:44Z","updated_at":"2016-12-29T13:17:44Z","body":"I raised issue https://redmine.pfsense.org/issues/7051 for this feature, so if approved it will have trace-ability through Redmine for making release notes."}}
{"actor":{"display_login":"phil-davis"}}