{"action":"created","issue":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2135","repository_url":"https://api.github.com/repos/varnishcache/varnish-cache","labels_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2135/labels{/name}","comments_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2135/comments","events_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2135/events","html_url":"https://github.com/varnishcache/varnish-cache/pull/2135","id":189365613,"number":2135,"title":"Introduce a parameter value for extrachance retries","user":{"login":"ema","id":281102,"avatar_url":"https://avatars.githubusercontent.com/u/281102?v=3","gravatar_id":"","url":"https://api.github.com/users/ema","html_url":"https://github.com/ema","followers_url":"https://api.github.com/users/ema/followers","following_url":"https://api.github.com/users/ema/following{/other_user}","gists_url":"https://api.github.com/users/ema/gists{/gist_id}","starred_url":"https://api.github.com/users/ema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ema/subscriptions","organizations_url":"https://api.github.com/users/ema/orgs","repos_url":"https://api.github.com/users/ema/repos","events_url":"https://api.github.com/users/ema/events{/privacy}","received_events_url":"https://api.github.com/users/ema/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-15T11:21:01Z","updated_at":"2016-11-21T12:43:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/pulls/2135","html_url":"https://github.com/varnishcache/varnish-cache/pull/2135","diff_url":"https://github.com/varnishcache/varnish-cache/pull/2135.diff","patch_url":"https://github.com/varnishcache/varnish-cache/pull/2135.patch"},"body":"There seem to be conditions in the extrachance logic under which Varnish\r\ncould retry a backend request indefinitely. This commit introduces a new\r\nparameter, gethdr_extrachance, allowing to set an upper bound for the\r\namount of retries in vbe_dir_gethdrs.\r\n\r\nThe default value for the newly introduced parameter is 1, setting it to\r\n0 disables the feature entirely.\r\n\r\nThe issue we've observed in production is described here: https://phabricator.wikimedia.org/T150247\r\n\r\nPotentially related bugs: https://github.com/varnishcache/varnish-cache/issues/2126 https://github.com/varnishcache/varnish-cache/issues/1806 https://github.com/varnishcache/varnish-cache/issues/1772"},"comment":{"url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/comments/261927051","html_url":"https://github.com/varnishcache/varnish-cache/pull/2135#issuecomment-261927051","issue_url":"https://api.github.com/repos/varnishcache/varnish-cache/issues/2135","id":261927051,"user":{"login":"bsdphk","id":567236,"avatar_url":"https://avatars.githubusercontent.com/u/567236?v=3","gravatar_id":"","url":"https://api.github.com/users/bsdphk","html_url":"https://github.com/bsdphk","followers_url":"https://api.github.com/users/bsdphk/followers","following_url":"https://api.github.com/users/bsdphk/following{/other_user}","gists_url":"https://api.github.com/users/bsdphk/gists{/gist_id}","starred_url":"https://api.github.com/users/bsdphk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsdphk/subscriptions","organizations_url":"https://api.github.com/users/bsdphk/orgs","repos_url":"https://api.github.com/users/bsdphk/repos","events_url":"https://api.github.com/users/bsdphk/events{/privacy}","received_events_url":"https://api.github.com/users/bsdphk/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T12:43:48Z","updated_at":"2016-11-21T12:43:48Z","body":"If we want this parameter, at the very least we want its minimum >1 so it drains the swamp."}}
{"actor":{"display_login":"bsdphk"}}