{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/61987633","id":61987633,"diff_hunk":"@@ -50,7 +64,7 @@ Http2SessionAccept::accept(NetVConnection *netvc, MIOBuffer *iobuf, IOBufferRead\n \n   // XXX Allocate a Http2ClientSession","path":"proxy/http2/Http2SessionAccept.cc","position":34,"original_position":34,"commit_id":"adbec07a85f43c482797237e538c820b67dd1a4c","original_commit_id":"adbec07a85f43c482797237e538c820b67dd1a4c","user":{"login":"jpeach","id":9917,"avatar_url":"https://avatars.githubusercontent.com/u/9917?v=3","gravatar_id":"","url":"https://api.github.com/users/jpeach","html_url":"https://github.com/jpeach","followers_url":"https://api.github.com/users/jpeach/followers","following_url":"https://api.github.com/users/jpeach/following{/other_user}","gists_url":"https://api.github.com/users/jpeach/gists{/gist_id}","starred_url":"https://api.github.com/users/jpeach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpeach/subscriptions","organizations_url":"https://api.github.com/users/jpeach/orgs","repos_url":"https://api.github.com/users/jpeach/repos","events_url":"https://api.github.com/users/jpeach/events{/privacy}","received_events_url":"https://api.github.com/users/jpeach/received_events","type":"User","site_admin":false},"body":"Looks like this \"XXX\" is done now?","created_at":"2016-05-04T03:42:55Z","updated_at":"2016-05-04T03:42:55Z","html_url":"https://github.com/apache/trafficserver/pull/614#discussion_r61987633","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/614","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/61987633"},"html":{"href":"https://github.com/apache/trafficserver/pull/614#discussion_r61987633"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/614","id":68801792,"html_url":"https://github.com/apache/trafficserver/pull/614","diff_url":"https://github.com/apache/trafficserver/pull/614.diff","patch_url":"https://github.com/apache/trafficserver/pull/614.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/614","number":614,"state":"open","locked":false,"title":"TS-3485: Support ip_allow config for HTTP2","user":{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false},"body":"Actually enforce the ip-level ACL checks for HTTP2 and move to the accept logic to make the decision before creating the session object.","created_at":"2016-05-04T01:54:34Z","updated_at":"2016-05-04T03:42:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9b6403fc526be8629e6be154103a7bb86973017","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/614/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/614/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/614/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/adbec07a85f43c482797237e538c820b67dd1a4c","head":{"label":"shinrich:ts-3485","ref":"ts-3485","sha":"adbec07a85f43c482797237e538c820b67dd1a4c","user":{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false},"repo":{"id":22690186,"name":"trafficserver","full_name":"shinrich/trafficserver","owner":{"login":"shinrich","id":334488,"avatar_url":"https://avatars.githubusercontent.com/u/334488?v=3","gravatar_id":"","url":"https://api.github.com/users/shinrich","html_url":"https://github.com/shinrich","followers_url":"https://api.github.com/users/shinrich/followers","following_url":"https://api.github.com/users/shinrich/following{/other_user}","gists_url":"https://api.github.com/users/shinrich/gists{/gist_id}","starred_url":"https://api.github.com/users/shinrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinrich/subscriptions","organizations_url":"https://api.github.com/users/shinrich/orgs","repos_url":"https://api.github.com/users/shinrich/repos","events_url":"https://api.github.com/users/shinrich/events{/privacy}","received_events_url":"https://api.github.com/users/shinrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinrich/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/shinrich/trafficserver","forks_url":"https://api.github.com/repos/shinrich/trafficserver/forks","keys_url":"https://api.github.com/repos/shinrich/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinrich/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinrich/trafficserver/teams","hooks_url":"https://api.github.com/repos/shinrich/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/shinrich/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/shinrich/trafficserver/events","assignees_url":"https://api.github.com/repos/shinrich/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/shinrich/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/shinrich/trafficserver/tags","blobs_url":"https://api.github.com/repos/shinrich/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinrich/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinrich/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinrich/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinrich/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/shinrich/trafficserver/languages","stargazers_url":"https://api.github.com/repos/shinrich/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/shinrich/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/shinrich/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/shinrich/trafficserver/subscription","commits_url":"https://api.github.com/repos/shinrich/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinrich/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinrich/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinrich/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinrich/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/shinrich/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinrich/trafficserver/merges","archive_url":"https://api.github.com/repos/shinrich/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinrich/trafficserver/downloads","issues_url":"https://api.github.com/repos/shinrich/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/shinrich/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/shinrich/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/shinrich/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinrich/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/shinrich/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/shinrich/trafficserver/deployments","created_at":"2014-08-06T16:38:05Z","updated_at":"2015-05-01T19:57:32Z","pushed_at":"2016-05-04T01:53:10Z","git_url":"git://github.com/shinrich/trafficserver.git","ssh_url":"git@github.com:shinrich/trafficserver.git","clone_url":"https://github.com/shinrich/trafficserver.git","svn_url":"https://github.com/shinrich/trafficserver","homepage":null,"size":51471,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2dd1c4f02414f7639e6cddc580d26f1bc5f1502c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2016-04-30T09:37:45Z","pushed_at":"2016-05-04T01:54:34Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":61738,"stargazers_count":409,"watchers_count":409,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":322,"mirror_url":null,"open_issues_count":24,"forks":322,"open_issues":24,"watchers":409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/614"},"html":{"href":"https://github.com/apache/trafficserver/pull/614"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/614"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/adbec07a85f43c482797237e538c820b67dd1a4c"}}}}