{"action":"created","comment":{"url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/comments/92950453","pull_request_review_id":13472051,"id":92950453,"diff_hunk":"@@ -408,6 +408,8 @@ func (e *Exporter) scrape(scrapes chan<- scrapeResult) {\n \t\tvar c redis.Conn\n \t\tvar err error\n \n+\t\tscrapes <- scrapeResult{Name: \"up\", Addr: addr, Value: 0}","path":"exporter/redis.go","position":4,"original_position":4,"commit_id":"5d903fc8fff20eff9ca44e855f5f4e61e4e08c12","original_commit_id":"5d903fc8fff20eff9ca44e855f5f4e61e4e08c12","user":{"login":"oliver006","id":1222339,"avatar_url":"https://avatars.githubusercontent.com/u/1222339?v=3","gravatar_id":"","url":"https://api.github.com/users/oliver006","html_url":"https://github.com/oliver006","followers_url":"https://api.github.com/users/oliver006/followers","following_url":"https://api.github.com/users/oliver006/following{/other_user}","gists_url":"https://api.github.com/users/oliver006/gists{/gist_id}","starred_url":"https://api.github.com/users/oliver006/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliver006/subscriptions","organizations_url":"https://api.github.com/users/oliver006/orgs","repos_url":"https://api.github.com/users/oliver006/repos","events_url":"https://api.github.com/users/oliver006/events{/privacy}","received_events_url":"https://api.github.com/users/oliver006/received_events","type":"User","site_admin":false},"body":"Doesn't this mark the exporter as down until line 449 marks it as back up? ","created_at":"2016-12-18T20:57:40Z","updated_at":"2016-12-18T20:57:57Z","html_url":"https://github.com/oliver006/redis_exporter/pull/46#discussion_r92950453","pull_request_url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/oliver006/redis_exporter/pulls/comments/92950453"},"html":{"href":"https://github.com/oliver006/redis_exporter/pull/46#discussion_r92950453"},"pull_request":{"href":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46","id":98458667,"html_url":"https://github.com/oliver006/redis_exporter/pull/46","diff_url":"https://github.com/oliver006/redis_exporter/pull/46.diff","patch_url":"https://github.com/oliver006/redis_exporter/pull/46.patch","issue_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/46","number":46,"state":"open","locked":false,"title":"Add redis_up gauge","user":{"login":"eagafonov","id":111455,"avatar_url":"https://avatars.githubusercontent.com/u/111455?v=3","gravatar_id":"","url":"https://api.github.com/users/eagafonov","html_url":"https://github.com/eagafonov","followers_url":"https://api.github.com/users/eagafonov/followers","following_url":"https://api.github.com/users/eagafonov/following{/other_user}","gists_url":"https://api.github.com/users/eagafonov/gists{/gist_id}","starred_url":"https://api.github.com/users/eagafonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eagafonov/subscriptions","organizations_url":"https://api.github.com/users/eagafonov/orgs","repos_url":"https://api.github.com/users/eagafonov/repos","events_url":"https://api.github.com/users/eagafonov/events{/privacy}","received_events_url":"https://api.github.com/users/eagafonov/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/oliver006/redis_exporter/issues/39\r\n\r\nThe implementation is straightforward: set redis_up to 0 before the connection is established (so any connection problems error will produce redis_up = 0) and set to 1 once any metric is fetched from redis server.","created_at":"2016-12-17T23:02:48Z","updated_at":"2016-12-18T20:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaa596a2fbc04599962460bc7b82cdaf9a33c040","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46/commits","review_comments_url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46/comments","review_comment_url":"https://api.github.com/repos/oliver006/redis_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/46/comments","statuses_url":"https://api.github.com/repos/oliver006/redis_exporter/statuses/5d903fc8fff20eff9ca44e855f5f4e61e4e08c12","head":{"label":"eagafonov:master","ref":"master","sha":"5d903fc8fff20eff9ca44e855f5f4e61e4e08c12","user":{"login":"eagafonov","id":111455,"avatar_url":"https://avatars.githubusercontent.com/u/111455?v=3","gravatar_id":"","url":"https://api.github.com/users/eagafonov","html_url":"https://github.com/eagafonov","followers_url":"https://api.github.com/users/eagafonov/followers","following_url":"https://api.github.com/users/eagafonov/following{/other_user}","gists_url":"https://api.github.com/users/eagafonov/gists{/gist_id}","starred_url":"https://api.github.com/users/eagafonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eagafonov/subscriptions","organizations_url":"https://api.github.com/users/eagafonov/orgs","repos_url":"https://api.github.com/users/eagafonov/repos","events_url":"https://api.github.com/users/eagafonov/events{/privacy}","received_events_url":"https://api.github.com/users/eagafonov/received_events","type":"User","site_admin":false},"repo":{"id":76751833,"name":"redis_exporter","full_name":"eagafonov/redis_exporter","owner":{"login":"eagafonov","id":111455,"avatar_url":"https://avatars.githubusercontent.com/u/111455?v=3","gravatar_id":"","url":"https://api.github.com/users/eagafonov","html_url":"https://github.com/eagafonov","followers_url":"https://api.github.com/users/eagafonov/followers","following_url":"https://api.github.com/users/eagafonov/following{/other_user}","gists_url":"https://api.github.com/users/eagafonov/gists{/gist_id}","starred_url":"https://api.github.com/users/eagafonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eagafonov/subscriptions","organizations_url":"https://api.github.com/users/eagafonov/orgs","repos_url":"https://api.github.com/users/eagafonov/repos","events_url":"https://api.github.com/users/eagafonov/events{/privacy}","received_events_url":"https://api.github.com/users/eagafonov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eagafonov/redis_exporter","description":"Prometheus Exporter for Redis Metrics. Supports Redis 2.x and 3.x ","fork":true,"url":"https://api.github.com/repos/eagafonov/redis_exporter","forks_url":"https://api.github.com/repos/eagafonov/redis_exporter/forks","keys_url":"https://api.github.com/repos/eagafonov/redis_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eagafonov/redis_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eagafonov/redis_exporter/teams","hooks_url":"https://api.github.com/repos/eagafonov/redis_exporter/hooks","issue_events_url":"https://api.github.com/repos/eagafonov/redis_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/eagafonov/redis_exporter/events","assignees_url":"https://api.github.com/repos/eagafonov/redis_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/eagafonov/redis_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/eagafonov/redis_exporter/tags","blobs_url":"https://api.github.com/repos/eagafonov/redis_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eagafonov/redis_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eagafonov/redis_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/eagafonov/redis_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eagafonov/redis_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/eagafonov/redis_exporter/languages","stargazers_url":"https://api.github.com/repos/eagafonov/redis_exporter/stargazers","contributors_url":"https://api.github.com/repos/eagafonov/redis_exporter/contributors","subscribers_url":"https://api.github.com/repos/eagafonov/redis_exporter/subscribers","subscription_url":"https://api.github.com/repos/eagafonov/redis_exporter/subscription","commits_url":"https://api.github.com/repos/eagafonov/redis_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/eagafonov/redis_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/eagafonov/redis_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/eagafonov/redis_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/eagafonov/redis_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/eagafonov/redis_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eagafonov/redis_exporter/merges","archive_url":"https://api.github.com/repos/eagafonov/redis_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eagafonov/redis_exporter/downloads","issues_url":"https://api.github.com/repos/eagafonov/redis_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/eagafonov/redis_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/eagafonov/redis_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/eagafonov/redis_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eagafonov/redis_exporter/labels{/name}","releases_url":"https://api.github.com/repos/eagafonov/redis_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/eagafonov/redis_exporter/deployments","created_at":"2016-12-17T22:52:33Z","updated_at":"2016-12-17T22:52:33Z","pushed_at":"2016-12-17T22:58:54Z","git_url":"git://github.com/eagafonov/redis_exporter.git","ssh_url":"git@github.com:eagafonov/redis_exporter.git","clone_url":"https://github.com/eagafonov/redis_exporter.git","svn_url":"https://github.com/eagafonov/redis_exporter","homepage":null,"size":68,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oliver006:master","ref":"master","sha":"a410b50d53985b76f117a6d9ee81ab052c8c1c91","user":{"login":"oliver006","id":1222339,"avatar_url":"https://avatars.githubusercontent.com/u/1222339?v=3","gravatar_id":"","url":"https://api.github.com/users/oliver006","html_url":"https://github.com/oliver006","followers_url":"https://api.github.com/users/oliver006/followers","following_url":"https://api.github.com/users/oliver006/following{/other_user}","gists_url":"https://api.github.com/users/oliver006/gists{/gist_id}","starred_url":"https://api.github.com/users/oliver006/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliver006/subscriptions","organizations_url":"https://api.github.com/users/oliver006/orgs","repos_url":"https://api.github.com/users/oliver006/repos","events_url":"https://api.github.com/users/oliver006/events{/privacy}","received_events_url":"https://api.github.com/users/oliver006/received_events","type":"User","site_admin":false},"repo":{"id":34705315,"name":"redis_exporter","full_name":"oliver006/redis_exporter","owner":{"login":"oliver006","id":1222339,"avatar_url":"https://avatars.githubusercontent.com/u/1222339?v=3","gravatar_id":"","url":"https://api.github.com/users/oliver006","html_url":"https://github.com/oliver006","followers_url":"https://api.github.com/users/oliver006/followers","following_url":"https://api.github.com/users/oliver006/following{/other_user}","gists_url":"https://api.github.com/users/oliver006/gists{/gist_id}","starred_url":"https://api.github.com/users/oliver006/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliver006/subscriptions","organizations_url":"https://api.github.com/users/oliver006/orgs","repos_url":"https://api.github.com/users/oliver006/repos","events_url":"https://api.github.com/users/oliver006/events{/privacy}","received_events_url":"https://api.github.com/users/oliver006/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oliver006/redis_exporter","description":"Prometheus Exporter for Redis Metrics. Supports Redis 2.x and 3.x ","fork":false,"url":"https://api.github.com/repos/oliver006/redis_exporter","forks_url":"https://api.github.com/repos/oliver006/redis_exporter/forks","keys_url":"https://api.github.com/repos/oliver006/redis_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oliver006/redis_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oliver006/redis_exporter/teams","hooks_url":"https://api.github.com/repos/oliver006/redis_exporter/hooks","issue_events_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/oliver006/redis_exporter/events","assignees_url":"https://api.github.com/repos/oliver006/redis_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/oliver006/redis_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/oliver006/redis_exporter/tags","blobs_url":"https://api.github.com/repos/oliver006/redis_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oliver006/redis_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oliver006/redis_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/oliver006/redis_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oliver006/redis_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/oliver006/redis_exporter/languages","stargazers_url":"https://api.github.com/repos/oliver006/redis_exporter/stargazers","contributors_url":"https://api.github.com/repos/oliver006/redis_exporter/contributors","subscribers_url":"https://api.github.com/repos/oliver006/redis_exporter/subscribers","subscription_url":"https://api.github.com/repos/oliver006/redis_exporter/subscription","commits_url":"https://api.github.com/repos/oliver006/redis_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/oliver006/redis_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/oliver006/redis_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/oliver006/redis_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/oliver006/redis_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/oliver006/redis_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oliver006/redis_exporter/merges","archive_url":"https://api.github.com/repos/oliver006/redis_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oliver006/redis_exporter/downloads","issues_url":"https://api.github.com/repos/oliver006/redis_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/oliver006/redis_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/oliver006/redis_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/oliver006/redis_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oliver006/redis_exporter/labels{/name}","releases_url":"https://api.github.com/repos/oliver006/redis_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/oliver006/redis_exporter/deployments","created_at":"2015-04-28T03:11:21Z","updated_at":"2016-12-16T06:49:27Z","pushed_at":"2016-12-17T23:02:48Z","git_url":"git://github.com/oliver006/redis_exporter.git","ssh_url":"git@github.com:oliver006/redis_exporter.git","clone_url":"https://github.com/oliver006/redis_exporter.git","svn_url":"https://github.com/oliver006/redis_exporter","homepage":null,"size":78,"stargazers_count":57,"watchers_count":57,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":8,"forks":41,"open_issues":8,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46"},"html":{"href":"https://github.com/oliver006/redis_exporter/pull/46"},"issue":{"href":"https://api.github.com/repos/oliver006/redis_exporter/issues/46"},"comments":{"href":"https://api.github.com/repos/oliver006/redis_exporter/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/oliver006/redis_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oliver006/redis_exporter/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/oliver006/redis_exporter/statuses/5d903fc8fff20eff9ca44e855f5f4e61e4e08c12"}}}}
{"actor":{"display_login":"oliver006"}}