{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/91873805","pull_request_review_id":12382705,"id":91873805,"diff_hunk":"@@ -33,6 +34,7 @@ export default Route.extend({\n         // and clutter our benchmarks and make it harder to time.\n         records.toArray();\n         heimdall.stop(token);\n+        console.timeEnd('ember-data');","path":"tests/dummy/app/routes/query/route.js","position":12,"original_position":12,"commit_id":"c0f2de0b9bf5fa140989643feea9160935f5f5bf","original_commit_id":"c0f2de0b9bf5fa140989643feea9160935f5f5bf","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"body":"^ should we leave this?","created_at":"2016-12-12T01:53:55Z","updated_at":"2016-12-12T01:54:30Z","html_url":"https://github.com/emberjs/data/pull/4708#discussion_r91873805","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/4708","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/91873805"},"html":{"href":"https://github.com/emberjs/data/pull/4708#discussion_r91873805"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/4708"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/4708","id":97361143,"html_url":"https://github.com/emberjs/data/pull/4708","diff_url":"https://github.com/emberjs/data/pull/4708.diff","patch_url":"https://github.com/emberjs/data/pull/4708.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/4708","number":4708,"state":"open","locked":false,"title":"es6 RecordArrayManager","user":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"body":"There wasn't really a good reason for this singleton being an Ember.Object (it's not resolved / not in the container / no ember-y things in use), and converting it shaves 33% off it's instantiation time in addition to giving us nice es6 syntax (1.53ms => .97ms).\r\n\r\nI additionally moved the instantiation of the `OrderedSet` used to track the `RecordArray`s for an `internalModel` into internal models directly instead of having the manager reach in.  I'm slightly conflicted on this because of the resulting double-underscore for the cached property, but I prefer to leave objects in control of their own properties.\r\n\r\n**Before**\r\n![es6-manager-before](https://cloud.githubusercontent.com/assets/650309/21060860/84a36c6c-bdfe-11e6-9dd4-2fd7320938d9.png)\r\n\r\n**After**\r\n![es6-manager-after](https://cloud.githubusercontent.com/assets/650309/21060869/8a7fb776-bdfe-11e6-8ecc-3fdab1a71715.png)\r\n","created_at":"2016-12-09T18:55:37Z","updated_at":"2016-12-12T01:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4b776b7d7aa91632af0d93d05eef9de344dfc7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/4708/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/4708/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/4708/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/c0f2de0b9bf5fa140989643feea9160935f5f5bf","head":{"label":"runspired:feat/es6-manager","ref":"feat/es6-manager","sha":"c0f2de0b9bf5fa140989643feea9160935f5f5bf","user":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"repo":{"id":66430492,"name":"data","full_name":"runspired/data","owner":{"login":"runspired","id":650309,"avatar_url":"https://avatars.githubusercontent.com/u/650309?v=3","gravatar_id":"","url":"https://api.github.com/users/runspired","html_url":"https://github.com/runspired","followers_url":"https://api.github.com/users/runspired/followers","following_url":"https://api.github.com/users/runspired/following{/other_user}","gists_url":"https://api.github.com/users/runspired/gists{/gist_id}","starred_url":"https://api.github.com/users/runspired/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runspired/subscriptions","organizations_url":"https://api.github.com/users/runspired/orgs","repos_url":"https://api.github.com/users/runspired/repos","events_url":"https://api.github.com/users/runspired/events{/privacy}","received_events_url":"https://api.github.com/users/runspired/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runspired/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/runspired/data","forks_url":"https://api.github.com/repos/runspired/data/forks","keys_url":"https://api.github.com/repos/runspired/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runspired/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runspired/data/teams","hooks_url":"https://api.github.com/repos/runspired/data/hooks","issue_events_url":"https://api.github.com/repos/runspired/data/issues/events{/number}","events_url":"https://api.github.com/repos/runspired/data/events","assignees_url":"https://api.github.com/repos/runspired/data/assignees{/user}","branches_url":"https://api.github.com/repos/runspired/data/branches{/branch}","tags_url":"https://api.github.com/repos/runspired/data/tags","blobs_url":"https://api.github.com/repos/runspired/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runspired/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runspired/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/runspired/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runspired/data/statuses/{sha}","languages_url":"https://api.github.com/repos/runspired/data/languages","stargazers_url":"https://api.github.com/repos/runspired/data/stargazers","contributors_url":"https://api.github.com/repos/runspired/data/contributors","subscribers_url":"https://api.github.com/repos/runspired/data/subscribers","subscription_url":"https://api.github.com/repos/runspired/data/subscription","commits_url":"https://api.github.com/repos/runspired/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/runspired/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/runspired/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/runspired/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/runspired/data/contents/{+path}","compare_url":"https://api.github.com/repos/runspired/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runspired/data/merges","archive_url":"https://api.github.com/repos/runspired/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runspired/data/downloads","issues_url":"https://api.github.com/repos/runspired/data/issues{/number}","pulls_url":"https://api.github.com/repos/runspired/data/pulls{/number}","milestones_url":"https://api.github.com/repos/runspired/data/milestones{/number}","notifications_url":"https://api.github.com/repos/runspired/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runspired/data/labels{/name}","releases_url":"https://api.github.com/repos/runspired/data/releases{/id}","deployments_url":"https://api.github.com/repos/runspired/data/deployments","created_at":"2016-08-24T04:42:27Z","updated_at":"2016-08-24T04:42:29Z","pushed_at":"2016-12-12T01:28:04Z","git_url":"git://github.com/runspired/data.git","ssh_url":"git@github.com:runspired/data.git","clone_url":"https://github.com/runspired/data.git","svn_url":"https://github.com/runspired/data","homepage":"","size":12456,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"7fd36c4a05a34a77d13d67f6c4498832188dbec8","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"name":"data","full_name":"emberjs/data","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2016-12-07T05:37:05Z","pushed_at":"2016-12-12T01:28:05Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":22134,"stargazers_count":2742,"watchers_count":2742,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1093,"mirror_url":null,"open_issues_count":183,"forks":1093,"open_issues":183,"watchers":2742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/4708"},"html":{"href":"https://github.com/emberjs/data/pull/4708"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/4708"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/4708/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/4708/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/4708/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/c0f2de0b9bf5fa140989643feea9160935f5f5bf"}}}}
{"actor":{"display_login":"stefanpenner"}}