{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/93904770","pull_request_review_id":14436189,"id":93904770,"diff_hunk":"@@ -13,36 +13,42 @@\n  * License for the specific language governing permissions and limitations\n  * under the License.\n  */\n-package com.linecorp.armeria.client.endpoint.zookeeper;\n+package com.linecorp.armeria.client.endpoint.zookeeper.common;\n \n import static java.util.Objects.requireNonNull;\n \n import java.nio.charset.StandardCharsets;\n-import java.util.List;\n+import java.util.Set;\n \n import com.linecorp.armeria.client.Endpoint;\n \n /**\n  * Converts a zNode value into a list of {@link Endpoint}s.\n  */\n-@FunctionalInterface\n-public interface ZooKeeperNodeValueConverter {\n+public interface Codec {","path":"zookeeper/src/main/java/com/linecorp/armeria/client/endpoint/zookeeper/common/Codec.java","position":20,"original_position":20,"commit_id":"cb0d9c2a1488867ce599e4ef003b7d04b8164199","original_commit_id":"cb0d9c2a1488867ce599e4ef003b7d04b8164199","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"How about `NodeValueCodec`? (or `ZooKeeperNodeValueCodec`)","created_at":"2016-12-27T07:52:16Z","updated_at":"2016-12-27T08:03:09Z","html_url":"https://github.com/line/armeria/pull/357#discussion_r93904770","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/357","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/93904770"},"html":{"href":"https://github.com/line/armeria/pull/357#discussion_r93904770"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/357"}}},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/357","id":99225554,"html_url":"https://github.com/line/armeria/pull/357","diff_url":"https://github.com/line/armeria/pull/357.diff","patch_url":"https://github.com/line/armeria/pull/357.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/357","number":357,"state":"open","locked":false,"title":"Automatically service registration and discovery support in cloud environment","user":{"login":"jonefeewang","id":3032599,"avatar_url":"https://avatars.githubusercontent.com/u/3032599?v=3","gravatar_id":"","url":"https://api.github.com/users/jonefeewang","html_url":"https://github.com/jonefeewang","followers_url":"https://api.github.com/users/jonefeewang/followers","following_url":"https://api.github.com/users/jonefeewang/following{/other_user}","gists_url":"https://api.github.com/users/jonefeewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonefeewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonefeewang/subscriptions","organizations_url":"https://api.github.com/users/jonefeewang/orgs","repos_url":"https://api.github.com/users/jonefeewang/repos","events_url":"https://api.github.com/users/jonefeewang/events{/privacy}","received_events_url":"https://api.github.com/users/jonefeewang/received_events","type":"User","site_admin":false},"body":"finished feature 331\nhttps://github.com/line/armeria/issues/331","created_at":"2016-12-23T10:30:45Z","updated_at":"2016-12-27T08:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17623bbdf8be238065582a271b78d31b0ab1a772","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/line/armeria/pulls/357/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/357/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/357/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/cb0d9c2a1488867ce599e4ef003b7d04b8164199","head":{"label":"jonefeewang:master","ref":"master","sha":"cb0d9c2a1488867ce599e4ef003b7d04b8164199","user":{"login":"jonefeewang","id":3032599,"avatar_url":"https://avatars.githubusercontent.com/u/3032599?v=3","gravatar_id":"","url":"https://api.github.com/users/jonefeewang","html_url":"https://github.com/jonefeewang","followers_url":"https://api.github.com/users/jonefeewang/followers","following_url":"https://api.github.com/users/jonefeewang/following{/other_user}","gists_url":"https://api.github.com/users/jonefeewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonefeewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonefeewang/subscriptions","organizations_url":"https://api.github.com/users/jonefeewang/orgs","repos_url":"https://api.github.com/users/jonefeewang/repos","events_url":"https://api.github.com/users/jonefeewang/events{/privacy}","received_events_url":"https://api.github.com/users/jonefeewang/received_events","type":"User","site_admin":false},"repo":{"id":67778997,"name":"armeria","full_name":"jonefeewang/armeria","owner":{"login":"jonefeewang","id":3032599,"avatar_url":"https://avatars.githubusercontent.com/u/3032599?v=3","gravatar_id":"","url":"https://api.github.com/users/jonefeewang","html_url":"https://github.com/jonefeewang","followers_url":"https://api.github.com/users/jonefeewang/followers","following_url":"https://api.github.com/users/jonefeewang/following{/other_user}","gists_url":"https://api.github.com/users/jonefeewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonefeewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonefeewang/subscriptions","organizations_url":"https://api.github.com/users/jonefeewang/orgs","repos_url":"https://api.github.com/users/jonefeewang/repos","events_url":"https://api.github.com/users/jonefeewang/events{/privacy}","received_events_url":"https://api.github.com/users/jonefeewang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonefeewang/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/jonefeewang/armeria","forks_url":"https://api.github.com/repos/jonefeewang/armeria/forks","keys_url":"https://api.github.com/repos/jonefeewang/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonefeewang/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonefeewang/armeria/teams","hooks_url":"https://api.github.com/repos/jonefeewang/armeria/hooks","issue_events_url":"https://api.github.com/repos/jonefeewang/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/jonefeewang/armeria/events","assignees_url":"https://api.github.com/repos/jonefeewang/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/jonefeewang/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/jonefeewang/armeria/tags","blobs_url":"https://api.github.com/repos/jonefeewang/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonefeewang/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonefeewang/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonefeewang/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonefeewang/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/jonefeewang/armeria/languages","stargazers_url":"https://api.github.com/repos/jonefeewang/armeria/stargazers","contributors_url":"https://api.github.com/repos/jonefeewang/armeria/contributors","subscribers_url":"https://api.github.com/repos/jonefeewang/armeria/subscribers","subscription_url":"https://api.github.com/repos/jonefeewang/armeria/subscription","commits_url":"https://api.github.com/repos/jonefeewang/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonefeewang/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonefeewang/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonefeewang/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonefeewang/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/jonefeewang/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonefeewang/armeria/merges","archive_url":"https://api.github.com/repos/jonefeewang/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonefeewang/armeria/downloads","issues_url":"https://api.github.com/repos/jonefeewang/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/jonefeewang/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/jonefeewang/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/jonefeewang/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonefeewang/armeria/labels{/name}","releases_url":"https://api.github.com/repos/jonefeewang/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/jonefeewang/armeria/deployments","created_at":"2016-09-09T08:00:04Z","updated_at":"2016-09-09T08:00:07Z","pushed_at":"2016-12-23T10:29:38Z","git_url":"git://github.com/jonefeewang/armeria.git","ssh_url":"git@github.com:jonefeewang/armeria.git","clone_url":"https://github.com/jonefeewang/armeria.git","svn_url":"https://github.com/jonefeewang/armeria","homepage":"http://line.github.io/armeria/","size":13840,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"0824cb738e0443fa320e8bc7dd5221b0d881f88f","user":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2016-12-27T06:55:44Z","pushed_at":"2016-12-27T07:51:40Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":14084,"stargazers_count":642,"watchers_count":642,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":161,"mirror_url":null,"open_issues_count":36,"forks":161,"open_issues":36,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/357"},"html":{"href":"https://github.com/line/armeria/pull/357"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/357"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/357/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/357/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/357/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/cb0d9c2a1488867ce599e4ef003b7d04b8164199"}}}}
{"actor":{"display_login":"trustin"}}