{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/77445001","id":77445001,"diff_hunk":"@@ -849,7 +860,69 @@ protected function updateUserIds($db)\n \t\t\t}\n \t\t\tcatch (RuntimeException $e)\n \t\t\t{\n-\t\t\t\tJFactory::getApplication()->enqueueMessage($e->getMessage(), 'notice');\n+\t\t\t\tJFactory::getApplication()->enqueueMessage($e->getMessage(), 'error');\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\t/**\n+\t * Method to update the dates of sql data content to the current date.\n+\t *\n+\t * @param   JDatabaseDriver  $db  Database connector object $db*.\n+\t *\n+\t * @return  boolean  True on success.\n+\t *\n+\t * @since   __DEPLOY_VERSION__\n+\t */\n+\tprotected function updateDates($db)\n+\t{\n+\t\t// Get the current date.\n+\t\t$currentDate = JFactory::getDate()->toSql();\n+\t\t$nullDate    = $db->getNullDate();\n+\n+\t\t// Update all core tables date fields of the tables with the current date.","path":"installation/model/database.php","position":109,"original_position":109,"commit_id":"af780208219ac0953e0e91016e559a01660488d3","original_commit_id":"af780208219ac0953e0e91016e559a01660488d3","user":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"body":"I think this should exclude checkout out fields. I understand that these are date fields. But in the installer they should never ever be populated and if they are populated then something very weird is going on and we probably should not touch it. ","created_at":"2016-09-04T00:40:09Z","updated_at":"2016-09-04T00:40:09Z","html_url":"https://github.com/joomla/joomla-cms/pull/11577#discussion_r77445001","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/77445001"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11577#discussion_r77445001"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577","id":81197340,"html_url":"https://github.com/joomla/joomla-cms/pull/11577","diff_url":"https://github.com/joomla/joomla-cms/pull/11577.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11577.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11577","number":11577,"state":"open","locked":false,"title":"[installation] Created in 2011-01-01? Update created date plus minor corrections","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\r\n\r\nJoomla on install articles, categories etc with a created date with more than 5 years (2011-01-01) which does not look good when you are installing something new.\r\n\r\nSo this PR adds a method to the installation process to update core and sample data created dates to the current date.\r\n\r\nAlso corrects category creator id in com_banners and com_user_notes (was missing).\r\n\r\n#### Testing Instructions\r\n\r\n1. Use latest staging\r\n2. Delete configuration.php, refresh the page and install joomla with any sample data install step\r\n3. Check the created dates of articles, categories, contacts, etc\r\n4. Now apply this patch, delete configuration.php, refresh the page and install joomla\r\n5. Repeat step 2 to 3 check the created date is now the Joomla install date.\r\n6. Do a code review.\r\n","created_at":"2016-08-12T23:35:40Z","updated_at":"2016-09-04T00:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0ff39d490854b20a0f9a8e388ead508dc627cc3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11577/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/af780208219ac0953e0e91016e559a01660488d3","head":{"label":"andrepereiradasilva:patch-19","ref":"patch-19","sha":"af780208219ac0953e0e91016e559a01660488d3","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"repo":{"id":46170295,"name":"joomla-cms","full_name":"andrepereiradasilva/joomla-cms","owner":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrepereiradasilva/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms","forks_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/forks","keys_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/teams","hooks_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/events","assignees_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/tags","blobs_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/subscription","commits_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/merges","archive_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/downloads","issues_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/andrepereiradasilva/joomla-cms/deployments","created_at":"2015-11-14T10:22:32Z","updated_at":"2016-03-03T00:12:42Z","pushed_at":"2016-09-04T00:30:04Z","git_url":"git://github.com/andrepereiradasilva/joomla-cms.git","ssh_url":"git@github.com:andrepereiradasilva/joomla-cms.git","clone_url":"https://github.com/andrepereiradasilva/joomla-cms.git","svn_url":"https://github.com/andrepereiradasilva/joomla-cms","homepage":"https://www.joomla.org","size":157510,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"563e700cb065837196baf468be404124e91a58b9","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-09-03T06:59:48Z","pushed_at":"2016-09-04T00:36:53Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":294090,"stargazers_count":2129,"watchers_count":2129,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2280,"mirror_url":null,"open_issues_count":446,"forks":2280,"open_issues":446,"watchers":2129,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11577"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11577"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11577/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11577/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/af780208219ac0953e0e91016e559a01660488d3"}}}}
{"actor":{"display_login":"wilsonge"}}