{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8650","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8650/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8650/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8650/events","html_url":"https://github.com/cockroachdb/cockroach/issues/8650","id":171945910,"number":8650,"title":"Clarify stdout summary when node starts","user":{"login":"sploiselle","id":19260003,"avatar_url":"https://avatars.githubusercontent.com/u/19260003?v=3","gravatar_id":"","url":"https://api.github.com/users/sploiselle","html_url":"https://github.com/sploiselle","followers_url":"https://api.github.com/users/sploiselle/followers","following_url":"https://api.github.com/users/sploiselle/following{/other_user}","gists_url":"https://api.github.com/users/sploiselle/gists{/gist_id}","starred_url":"https://api.github.com/users/sploiselle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sploiselle/subscriptions","organizations_url":"https://api.github.com/users/sploiselle/orgs","repos_url":"https://api.github.com/users/sploiselle/repos","events_url":"https://api.github.com/users/sploiselle/events{/privacy}","received_events_url":"https://api.github.com/users/sploiselle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"assignees":[{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-18T16:36:03Z","updated_at":"2016-09-03T12:39:11Z","closed_at":null,"body":"Per @mberhault, we could improve the current stdout behavior of starting nodes/joining clusters by:\r\n\r\n- Including cluster ID\r\n- Removing `join[0]` or augment its behavior when `--join` fails\r\n- Including line \"Initialized new cluster\" vs. \"Joined existing cluster\" that could include the cluster ID.\r\n\r\nThis is a potentially better experience in general but specifically improves visibility into issues when having nodes join clusters.\r\n\r\n### Repro Steps\r\nYou are able to get an ambiguous stdout message in this scenario:\r\n1. Create network that prohibits communication on port 26257.\r\n2. Start a node (`cockroach start --insecure`), which creates the `cockroach-data` dir.\r\n3. Stop the node.\r\n4. Have the node attempt to join an existing cluster (`cockroach start --join=<other IP address>:26257`)\r\n\r\nstdout will then generate something like the following:\r\n\r\n```\r\nbuild:     beta-20160728 @ 2016/07/28 17:02:34 (go1.6.3)\r\nadmin:     http://insecure-node3:8080\r\nsql:       postgresql://root@insecure-node3:26257?sslmode=disable\r\nlogs:      cockroach-data/logs\r\nstore[0]:  path=cockroach-data\r\njoin[0]:   <other IP address>:26257\r\n```\r\n\r\n### Expectation\r\n\r\nAn error message that my node is unable to join the cluster, or some indication that it's creating its own new cluster instead of joining the existing cluster.\r\n\r\n### Reality\r\n\r\nThe command including `--join` looks like it's executed, which leads me to believe the node successfully joined the cluster. The line `join[0]:   <other IP address>:26257` reinforces that supposition.\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/244544116","html_url":"https://github.com/cockroachdb/cockroach/issues/8650#issuecomment-244544116","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8650","id":244544116,"user":{"login":"mberhault","id":5901480,"avatar_url":"https://avatars.githubusercontent.com/u/5901480?v=3","gravatar_id":"","url":"https://api.github.com/users/mberhault","html_url":"https://github.com/mberhault","followers_url":"https://api.github.com/users/mberhault/followers","following_url":"https://api.github.com/users/mberhault/following{/other_user}","gists_url":"https://api.github.com/users/mberhault/gists{/gist_id}","starred_url":"https://api.github.com/users/mberhault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mberhault/subscriptions","organizations_url":"https://api.github.com/users/mberhault/orgs","repos_url":"https://api.github.com/users/mberhault/repos","events_url":"https://api.github.com/users/mberhault/events{/privacy}","received_events_url":"https://api.github.com/users/mberhault/received_events","type":"User","site_admin":false},"created_at":"2016-09-03T12:39:11Z","updated_at":"2016-09-03T12:39:11Z","body":"@a-robinson: the node should fail to start if the clusterID in one of its stores doesn't match the clusterID of the cluster it's about to join. This is the only safety check to make sure a node doesn't join the wrong cluster, we should keep it."}}
{"actor":{"display_login":"mberhault"}}