{"action":"created","issue":{"url":"https://api.github.com/repos/pydata/pandas/issues/13091","repository_url":"https://api.github.com/repos/pydata/pandas","labels_url":"https://api.github.com/repos/pydata/pandas/issues/13091/labels{/name}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/13091/comments","events_url":"https://api.github.com/repos/pydata/pandas/issues/13091/events","html_url":"https://github.com/pydata/pandas/pull/13091","id":153222910,"number":13091,"title":"TST: Fix assertNotIsInstance msg","user":{"login":"sinhrks","id":1696302,"avatar_url":"https://avatars.githubusercontent.com/u/1696302?v=3","gravatar_id":"","url":"https://api.github.com/users/sinhrks","html_url":"https://github.com/sinhrks","followers_url":"https://api.github.com/users/sinhrks/followers","following_url":"https://api.github.com/users/sinhrks/following{/other_user}","gists_url":"https://api.github.com/users/sinhrks/gists{/gist_id}","starred_url":"https://api.github.com/users/sinhrks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinhrks/subscriptions","organizations_url":"https://api.github.com/users/sinhrks/orgs","repos_url":"https://api.github.com/users/sinhrks/repos","events_url":"https://api.github.com/users/sinhrks/events{/privacy}","received_events_url":"https://api.github.com/users/sinhrks/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pydata/pandas/labels/Error%20Reporting","name":"Error Reporting","color":"ffa0ff"},{"url":"https://api.github.com/repos/pydata/pandas/labels/Testing","name":"Testing","color":"C4A000"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/pydata/pandas/milestones/40","html_url":"https://github.com/pydata/pandas/milestones/0.18.2","labels_url":"https://api.github.com/repos/pydata/pandas/milestones/40/labels","id":1639795,"number":40,"title":"0.18.2","description":"","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":158,"closed_issues":3,"state":"open","created_at":"2016-03-11T21:24:45Z","updated_at":"2016-05-05T13:20:20Z","due_on":"2016-06-14T04:00:00Z","closed_at":null},"comments":1,"created_at":"2016-05-05T12:31:50Z","updated_at":"2016-05-05T13:37:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/13091","html_url":"https://github.com/pydata/pandas/pull/13091","diff_url":"https://github.com/pydata/pandas/pull/13091.diff","patch_url":"https://github.com/pydata/pandas/pull/13091.patch"},"body":" - [x] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n\r\nThe current error message below is confusing.\r\n\r\n```\r\ntm.assertNotIsInstance(pd.Series([1]), pd.Series)\r\n# AssertionError: Expected object to be of type <class 'pandas.core.series.Series'>, found <class 'pandas.core.series.Series'> instead\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/pydata/pandas/issues/comments/217156446","html_url":"https://github.com/pydata/pandas/pull/13091#issuecomment-217156446","issue_url":"https://api.github.com/repos/pydata/pandas/issues/13091","id":217156446,"user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T13:37:29Z","updated_at":"2016-05-05T13:37:29Z","body":"so lots of things fail on windows. probably all because of comparisons on int32/int64. \r\n\r\ne.g. ``np.array([1,2,3])`` constructs as ``int32`` on windows. So if you are comparing to something just force the constrution with ``np.array([1,2,3],dtype=np.int64)``. If you ARE expecting platform int, then use ``dtype=np.intp``\r\n\r\nbtw you can setup appveyor (just need to login it free), to at least see build failures. its slow but can give you a feel for errors.\r\n\r\n```\r\n======================================================================\r\nFAIL: pandas.tests.test_tseries.test_outer_join_indexer\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"C:\\Miniconda2\\envs\\pandas3.5\\lib\\site-packages\\nose\\case.py\", line 198, in runTest\r\n    self.test(*self.arg)\r\n  File \"C:\\Users\\conda\\Documents\\pandas3.5\\pandas\\tests\\test_tseries.py\", line 133, in test_outer_join_indexer\r\n    assert_almost_equal(bres, bexp)\r\n  File \"C:\\Users\\conda\\Documents\\pandas3.5\\pandas\\util\\testing.py\", line 131, in assert_almost_equal\r\n    return _testing.assert_almost_equal(left, right, **kwargs)\r\n  File \"pandas\\src\\testing.pyx\", line 58, in pandas._testing.assert_almost_equal (pandas\\src\\testing.c:3479)\r\n    cpdef assert_almost_equal(a, b, bint check_less_precise=False, check_dtype=True,\r\n  File \"pandas\\src\\testing.pyx\", line 131, in pandas._testing.assert_almost_equal (pandas\\src\\testing.c:2184)\r\n    assert_attr_equal('dtype', a, b, obj=obj)\r\n  File \"C:\\Users\\conda\\Documents\\pandas3.5\\pandas\\util\\testing.py\", line 820, in assert_attr_equal\r\n    left_attr, right_attr)\r\n  File \"C:\\Users\\conda\\Documents\\pandas3.5\\pandas\\util\\testing.py\", line 931, in raise_assert_detail\r\n    raise AssertionError(msg)\r\nAssertionError: numpy array are different\r\n\r\nAttribute \"dtype\" are different\r\n[left]:  int64\r\n[right]: int32\r\n\r\n----------------------------------------------------------------------\r\nRan 10142 tests in 405.745s\r\n\r\nFAILED (SKIP=182, failures=52)\r\n```\r\n\r\n```\r\n-> assert_almost_equal(ares, aexp)\r\n(Pdb) l\r\n104         index_exp = np.array([3, 5], dtype=np.int64)\r\n105         assert_almost_equal(index, index_exp)\r\n106\r\n107         aexp = np.array([2, 4])\r\n108         bexp = np.array([1, 2])\r\n109  ->     assert_almost_equal(ares, aexp)\r\n110         assert_almost_equal(bres, bexp)\r\n111\r\n112         a = np.array([5], dtype=np.int64)\r\n113         b = np.array([5], dtype=np.int64)\r\n114\r\n(Pdb) p ares\r\narray([2, 4], dtype=int64)\r\n(Pdb) p bexp\r\narray([1, 2])\r\n(Pdb) p bexp.dtype\r\ndtype('int32')\r\n(Pdb) l 100\r\n 95         assert (np.array_equal(ridx, exp_ridx))\r\n 96\r\n 97\r\n 98     def test_inner_join_indexer():\r\n 99         a = np.array([1, 2, 3, 4, 5], dtype=np.int64)\r\n100         b = np.array([0, 3, 5, 7, 9], dtype=np.int64)\r\n101\r\n102         index, ares, bres = algos.inner_join_indexer_int64(a, b)\r\n103\r\n104         index_exp = np.array([3, 5], dtype=np.int64)\r\n105         assert_almost_equal(index, index_exp)\r\n(Pdb) l\r\n106\r\n107         aexp = np.array([2, 4])\r\n108         bexp = np.array([1, 2])\r\n109  ->     assert_almost_equal(ares, aexp)\r\n110         assert_almost_equal(bres, bexp)\r\n111\r\n112         a = np.array([5], dtype=np.int64)\r\n113         b = np.array([5], dtype=np.int64)\r\n114\r\n115         index, ares, bres = algos.inner_join_indexer_int64(a, b)\r\n116         assert_almost_equal(index, [5])\r\n(Pdb) p bexp\r\narray([1, 2])\r\n(Pdb) p ares\r\narray([2, 4], dtype=int64)\r\n(Pdb)\r\n```"}}