{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/riff-raff/issues/379","repository_url":"https://api.github.com/repos/guardian/riff-raff","labels_url":"https://api.github.com/repos/guardian/riff-raff/issues/379/labels{/name}","comments_url":"https://api.github.com/repos/guardian/riff-raff/issues/379/comments","events_url":"https://api.github.com/repos/guardian/riff-raff/issues/379/events","html_url":"https://github.com/guardian/riff-raff/pull/379","id":184522671,"number":379,"title":"Eliminate use of DeploymentType.all global","user":{"login":"sihil","id":1236466,"avatar_url":"https://avatars.githubusercontent.com/u/1236466?v=3","gravatar_id":"","url":"https://api.github.com/users/sihil","html_url":"https://github.com/sihil","followers_url":"https://api.github.com/users/sihil/followers","following_url":"https://api.github.com/users/sihil/following{/other_user}","gists_url":"https://api.github.com/users/sihil/gists{/gist_id}","starred_url":"https://api.github.com/users/sihil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihil/subscriptions","organizations_url":"https://api.github.com/users/sihil/orgs","repos_url":"https://api.github.com/users/sihil/repos","events_url":"https://api.github.com/users/sihil/events{/privacy}","received_events_url":"https://api.github.com/users/sihil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-21T16:04:09Z","updated_at":"2016-10-24T11:46:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/riff-raff/pulls/379","html_url":"https://github.com/guardian/riff-raff/pull/379","diff_url":"https://github.com/guardian/riff-raff/pull/379.diff","patch_url":"https://github.com/guardian/riff-raff/pull/379.patch"},"body":"Whilst writing the YAML preview pages I realised that eliminating the use of the `DeploymentType.all` global would make the code clearer and (naturally) make it easier to test.\r\n\r\nThis also ties up a loose end where the code still used `ValidatedNel` instead of `Validated` and the `ConfigErrors` semigroup."},"comment":{"url":"https://api.github.com/repos/guardian/riff-raff/issues/comments/255718418","html_url":"https://github.com/guardian/riff-raff/pull/379#issuecomment-255718418","issue_url":"https://api.github.com/repos/guardian/riff-raff/issues/379","id":255718418,"user":{"login":"sihil","id":1236466,"avatar_url":"https://avatars.githubusercontent.com/u/1236466?v=3","gravatar_id":"","url":"https://api.github.com/users/sihil","html_url":"https://github.com/sihil","followers_url":"https://api.github.com/users/sihil/followers","following_url":"https://api.github.com/users/sihil/following{/other_user}","gists_url":"https://api.github.com/users/sihil/gists{/gist_id}","starred_url":"https://api.github.com/users/sihil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihil/subscriptions","organizations_url":"https://api.github.com/users/sihil/orgs","repos_url":"https://api.github.com/users/sihil/repos","events_url":"https://api.github.com/users/sihil/events{/privacy}","received_events_url":"https://api.github.com/users/sihil/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T11:46:22Z","updated_at":"2016-10-24T11:46:22Z","body":"It should all become significantly simpler once JSON deploys are decommissioned. Deploy type checking is all done in the resolver in that instance."}}
{"actor":{"display_login":"sihil"}}