{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/1082","repository_url":"https://api.github.com/repos/musescore/MuseScore","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/1082/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/1082/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/1082/events","html_url":"https://github.com/musescore/MuseScore/pull/1082","id":39198940,"number":1082,"title":"make revision is now a target handled by cmake and depended on by mscore","user":{"login":"akdor1154","id":6732831,"avatar_url":"https://avatars.githubusercontent.com/u/6732831?v=3","gravatar_id":"","url":"https://api.github.com/users/akdor1154","html_url":"https://github.com/akdor1154","followers_url":"https://api.github.com/users/akdor1154/followers","following_url":"https://api.github.com/users/akdor1154/following{/other_user}","gists_url":"https://api.github.com/users/akdor1154/gists{/gist_id}","starred_url":"https://api.github.com/users/akdor1154/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akdor1154/subscriptions","organizations_url":"https://api.github.com/users/akdor1154/orgs","repos_url":"https://api.github.com/users/akdor1154/repos","events_url":"https://api.github.com/users/akdor1154/events{/privacy}","received_events_url":"https://api.github.com/users/akdor1154/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2014-07-31T14:22:10Z","updated_at":"2016-10-24T08:52:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/1082","html_url":"https://github.com/musescore/MuseScore/pull/1082","diff_url":"https://github.com/musescore/MuseScore/pull/1082.diff","patch_url":"https://github.com/musescore/MuseScore/pull/1082.patch"},"body":"make revision is now a target handled by cmake, which is depended on by the mscore target and always run when mscore is built. This means that if I 'git pull' and then 'make' in my build directory, the resulting build will have the correct revision. Likewise for if I do the above in Qt Creator.\r\nThe code also changes the revision to 'unknown' if it can't find Git -- according to the README in git/hooks, the repo is meant to have revision.h contain 'unknown' anyway, but it looks like an actual revision was committed by mistake last year. As the build script now generates revision.h automatically and in all cases, there is no need for revision.h to be in the repository at all, which should reduce the chance of it being accidentally committed in future.\r\nThe only user-facing change is that 'make revision' in the project directory no longer works, you have to call it in your build directory (though you should honestly never have to call it manually at all).\r\n"},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/255683691","html_url":"https://github.com/musescore/MuseScore/pull/1082#issuecomment-255683691","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/1082","id":255683691,"user":{"login":"Jojo-Schmitz","id":1786669,"avatar_url":"https://avatars.githubusercontent.com/u/1786669?v=3","gravatar_id":"","url":"https://api.github.com/users/Jojo-Schmitz","html_url":"https://github.com/Jojo-Schmitz","followers_url":"https://api.github.com/users/Jojo-Schmitz/followers","following_url":"https://api.github.com/users/Jojo-Schmitz/following{/other_user}","gists_url":"https://api.github.com/users/Jojo-Schmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Jojo-Schmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jojo-Schmitz/subscriptions","organizations_url":"https://api.github.com/users/Jojo-Schmitz/orgs","repos_url":"https://api.github.com/users/Jojo-Schmitz/repos","events_url":"https://api.github.com/users/Jojo-Schmitz/events{/privacy}","received_events_url":"https://api.github.com/users/Jojo-Schmitz/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T08:52:10Z","updated_at":"2016-10-24T08:52:10Z","body":"I'm still for that PR, and we do see occasions where this indeed is broken, so it does need fixing, there are numerous bug reports from Linux users with the wrong commit, 3543170, apparentle because the maintainer didn't have that post-checkout hook installed and/or also did not do a `make revision`\r\nAnd it isn't just Linux, @jeetee had an issue with the post-checkout hook on Windows, using tortoisegit(?)"}}
{"actor":{"display_login":"Jojo-Schmitz"}}