{"action":"created","comment":{"url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/comments/75576734","id":75576734,"diff_hunk":"@@ -0,0 +1,52 @@\n+// Part of measurement-kit <https://measurement-kit.github.io/>.\n+// Measurement-kit is free software. See AUTHORS and LICENSE for more\n+// information on the copying conditions.\n+#ifndef JNI_OONI_TEST_WRAPPER_HPP\n+#define JNI_OONI_TEST_WRAPPER_HPP\n+\n+#include <measurement_kit/ooni.hpp>\n+#include <string>\n+\n+class OoniTestWrapper {\n+  public:\n+    OoniTestWrapper(std::string test_name) {\n+        if (test_name == \"tcp_connect\") {\n+            real_test_.reset(new mk::ooni::TcpConnect);","path":"jni/ooni_test_wrapper.hpp","position":14,"original_position":14,"commit_id":"a1e811bc4af197a8b3fddf2db67b228fcb7b3973","original_commit_id":"a1e811bc4af197a8b3fddf2db67b228fcb7b3973","user":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars.githubusercontent.com/u/337298?v=3","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"body":"@lorenzoPrimi here we should add also the other tests. By the way, throwing an exception is not super optimal here because the exception is not routed by Swig and causes the application to terminate.","created_at":"2016-08-20T10:56:49Z","updated_at":"2016-08-20T10:56:49Z","html_url":"https://github.com/measurement-kit/measurement-kit-android/pull/13#discussion_r75576734","pull_request_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/comments/75576734"},"html":{"href":"https://github.com/measurement-kit/measurement-kit-android/pull/13#discussion_r75576734"},"pull_request":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13","id":82075801,"html_url":"https://github.com/measurement-kit/measurement-kit-android/pull/13","diff_url":"https://github.com/measurement-kit/measurement-kit-android/pull/13.diff","patch_url":"https://github.com/measurement-kit/measurement-kit-android/pull/13.patch","issue_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/13","number":13,"state":"open","locked":false,"title":"Add 1:1 wrapper of sync C++ class using Swig","user":{"login":"bassosimone","id":337298,"avatar_url":"https://avatars.githubusercontent.com/u/337298?v=3","gravatar_id":"","url":"https://api.github.com/users/bassosimone","html_url":"https://github.com/bassosimone","followers_url":"https://api.github.com/users/bassosimone/followers","following_url":"https://api.github.com/users/bassosimone/following{/other_user}","gists_url":"https://api.github.com/users/bassosimone/gists{/gist_id}","starred_url":"https://api.github.com/users/bassosimone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bassosimone/subscriptions","organizations_url":"https://api.github.com/users/bassosimone/orgs","repos_url":"https://api.github.com/users/bassosimone/repos","events_url":"https://api.github.com/users/bassosimone/events{/privacy}","received_events_url":"https://api.github.com/users/bassosimone/received_events","type":"User","site_admin":false},"body":"Necessity to add this feature recently discussed with @lorenzoPrimi.\r\n\r\nI am not sure Swig is the \"way to go\" (TM) with async code, but it surely\r\nhelps a lot and does a good work as long as we stay sync.","created_at":"2016-08-20T10:53:16Z","updated_at":"2016-08-20T10:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ced4ee9e4d3918f997dea4067ea39c8852884f8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13/commits","review_comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13/comments","review_comment_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/13/comments","statuses_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/statuses/a1e811bc4af197a8b3fddf2db67b228fcb7b3973","head":{"label":"measurement-kit:feature/swig-api","ref":"feature/swig-api","sha":"a1e811bc4af197a8b3fddf2db67b228fcb7b3973","user":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":47632525,"name":"measurement-kit-android","full_name":"measurement-kit/measurement-kit-android","owner":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-kit/measurement-kit-android","description":"Measurement Kit for Android","fork":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit-android","forks_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/forks","keys_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/teams","hooks_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/hooks","issue_events_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/events","assignees_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/tags","blobs_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/languages","stargazers_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/stargazers","contributors_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/contributors","subscribers_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/subscribers","subscription_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/subscription","commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/merges","archive_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/downloads","issues_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/labels{/name}","releases_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/deployments","created_at":"2015-12-08T15:59:22Z","updated_at":"2016-01-14T20:10:17Z","pushed_at":"2016-08-20T10:53:17Z","git_url":"git://github.com/measurement-kit/measurement-kit-android.git","ssh_url":"git@github.com:measurement-kit/measurement-kit-android.git","clone_url":"https://github.com/measurement-kit/measurement-kit-android.git","svn_url":"https://github.com/measurement-kit/measurement-kit-android","homepage":"https://measurement-kit.github.io/","size":32,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"measurement-kit:master","ref":"master","sha":"b4d4f2ee85d22e0292ef4a3379fe465a9bafcd3b","user":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":47632525,"name":"measurement-kit-android","full_name":"measurement-kit/measurement-kit-android","owner":{"login":"measurement-kit","id":11982841,"avatar_url":"https://avatars.githubusercontent.com/u/11982841?v=3","gravatar_id":"","url":"https://api.github.com/users/measurement-kit","html_url":"https://github.com/measurement-kit","followers_url":"https://api.github.com/users/measurement-kit/followers","following_url":"https://api.github.com/users/measurement-kit/following{/other_user}","gists_url":"https://api.github.com/users/measurement-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-kit/subscriptions","organizations_url":"https://api.github.com/users/measurement-kit/orgs","repos_url":"https://api.github.com/users/measurement-kit/repos","events_url":"https://api.github.com/users/measurement-kit/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/measurement-kit/measurement-kit-android","description":"Measurement Kit for Android","fork":false,"url":"https://api.github.com/repos/measurement-kit/measurement-kit-android","forks_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/forks","keys_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/teams","hooks_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/hooks","issue_events_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/events","assignees_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/tags","blobs_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/languages","stargazers_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/stargazers","contributors_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/contributors","subscribers_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/subscribers","subscription_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/subscription","commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/merges","archive_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/downloads","issues_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/labels{/name}","releases_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-kit/measurement-kit-android/deployments","created_at":"2015-12-08T15:59:22Z","updated_at":"2016-01-14T20:10:17Z","pushed_at":"2016-08-20T10:53:17Z","git_url":"git://github.com/measurement-kit/measurement-kit-android.git","ssh_url":"git@github.com:measurement-kit/measurement-kit-android.git","clone_url":"https://github.com/measurement-kit/measurement-kit-android.git","svn_url":"https://github.com/measurement-kit/measurement-kit-android","homepage":"https://measurement-kit.github.io/","size":32,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13"},"html":{"href":"https://github.com/measurement-kit/measurement-kit-android/pull/13"},"issue":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/13"},"comments":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/measurement-kit/measurement-kit-android/statuses/a1e811bc4af197a8b3fddf2db67b228fcb7b3973"}}}}
{"actor":{"display_login":"bassosimone"}}