{"action":"created","issue":{"url":"https://api.github.com/repos/ga4gh/schemas/issues/562","repository_url":"https://api.github.com/repos/ga4gh/schemas","labels_url":"https://api.github.com/repos/ga4gh/schemas/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/schemas/issues/562/comments","events_url":"https://api.github.com/repos/ga4gh/schemas/issues/562/events","html_url":"https://github.com/ga4gh/schemas/pull/562","id":135906639,"number":562,"title":"Remove impact and change created to createDateTime and updated to updateDateTime","user":{"login":"david4096","id":3795586,"avatar_url":"https://avatars.githubusercontent.com/u/3795586?v=3","gravatar_id":"","url":"https://api.github.com/users/david4096","html_url":"https://github.com/david4096","followers_url":"https://api.github.com/users/david4096/followers","following_url":"https://api.github.com/users/david4096/following{/other_user}","gists_url":"https://api.github.com/users/david4096/gists{/gist_id}","starred_url":"https://api.github.com/users/david4096/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david4096/subscriptions","organizations_url":"https://api.github.com/users/david4096/orgs","repos_url":"https://api.github.com/users/david4096/repos","events_url":"https://api.github.com/users/david4096/events{/privacy}","received_events_url":"https://api.github.com/users/david4096/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ga4gh/schemas/labels/Variant%20Annotation","name":"Variant Annotation","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-24T00:04:33Z","updated_at":"2016-02-25T00:40:24Z","closed_at":"2016-02-24T20:35:03Z","pull_request":{"url":"https://api.github.com/repos/ga4gh/schemas/pulls/562","html_url":"https://github.com/ga4gh/schemas/pull/562","diff_url":"https://github.com/ga4gh/schemas/pull/562.diff","patch_url":"https://github.com/ga4gh/schemas/pull/562.patch"},"body":"Keeps variant annotation records in line with latest from metadata task team. @diekhans "},"comment":{"url":"https://api.github.com/repos/ga4gh/schemas/issues/comments/188535746","html_url":"https://github.com/ga4gh/schemas/pull/562#issuecomment-188535746","issue_url":"https://api.github.com/repos/ga4gh/schemas/issues/562","id":188535746,"user":{"login":"pcingola","id":1334427,"avatar_url":"https://avatars.githubusercontent.com/u/1334427?v=3","gravatar_id":"","url":"https://api.github.com/users/pcingola","html_url":"https://github.com/pcingola","followers_url":"https://api.github.com/users/pcingola/followers","following_url":"https://api.github.com/users/pcingola/following{/other_user}","gists_url":"https://api.github.com/users/pcingola/gists{/gist_id}","starred_url":"https://api.github.com/users/pcingola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcingola/subscriptions","organizations_url":"https://api.github.com/users/pcingola/orgs","repos_url":"https://api.github.com/users/pcingola/repos","events_url":"https://api.github.com/users/pcingola/events{/privacy}","received_events_url":"https://api.github.com/users/pcingola/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T00:40:24Z","updated_at":"2016-02-25T00:40:24Z","body":"No Reece. The recommendation was to leave it,  and evaluate AFTER the merge\nwas completed.\n\n-1\nOn Feb 24, 2016 6:35 PM, \"Reece Hart\" <notifications@github.com> wrote:\n\n> We are scheduled to discuss impact and related data modeling policies at\n> the VATT March 9 meeting. However, stalling the variant_annotation merge\n> delays downstream activities, and therefore we won't do that.\n>\n> That leaves two options: including or excluding the impact component of\n> the schema at this time. Excluding it now leaves open the option of\n> including it later. (And, technically, including it now leaves open the\n> option of retracting it later, but I'm opposed to that route.)\n>\n> I know of 6 opinions on this topic. @pcingola\n> <https://github.com/pcingola> is in favor of keeping impact as-is. The\n> other five -- @fcunningham <https://github.com/fcunningham>, @sarahhunt\n> <https://github.com/sarahhunt>, @jeromekelleher\n> <https://github.com/jeromekelleher>, @diekhans\n> <https://github.com/diekhans>, and I -- are in favor of removing it *at\n> this time*.\n>\n> Furthermore, Daniel MacArthur, Peter Robinson, Deanna Church, Richard\n> Durbin, and Tony Brookes commented on the ga4gh-dwg-annotation list (~Dec\n> 9-18) with comments that I would summarize as 1) most had significant\n> concerns regarding the impact and modifier parts of the schema as-is, and\n> 2) some believed that these components might be valuable *with revisions*\n> (like removing modifier). None believed that acceptance was clear cut.\n>\n> All of you should correct me here, on this this thread, if you believe\n> that I am incorrectly summarizing the data above.\n>\n> So, my opinion is that impact is worth considering and that we should do\n> so when we have a clearer understanding and consensus of terminology and\n> utility. We can more readily consider a PR that includes impact after the\n> March 9 meeting. In order to keep the project moving forward, we should\n> merge this PR into variant_annotation (and, presumably, variant_annotation\n> then into master as discussed on that PR).\n>\n> +1\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/ga4gh/schemas/pull/562#issuecomment-188515494>.\n>\n"}}