{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/3750","repository_url":"https://api.github.com/repos/keybase/client","labels_url":"https://api.github.com/repos/keybase/client/issues/3750/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/3750/comments","events_url":"https://api.github.com/repos/keybase/client/issues/3750/events","html_url":"https://github.com/keybase/client/pull/3750","id":169467630,"number":3750,"title":"Dumb website choice (file/dns) component DESKTOP-1605","user":{"login":"awendland","id":1152104,"avatar_url":"https://avatars.githubusercontent.com/u/1152104?v=3","gravatar_id":"","url":"https://api.github.com/users/awendland","html_url":"https://github.com/awendland","followers_url":"https://api.github.com/users/awendland/followers","following_url":"https://api.github.com/users/awendland/following{/other_user}","gists_url":"https://api.github.com/users/awendland/gists{/gist_id}","starred_url":"https://api.github.com/users/awendland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awendland/subscriptions","organizations_url":"https://api.github.com/users/awendland/orgs","repos_url":"https://api.github.com/users/awendland/repos","events_url":"https://api.github.com/users/awendland/events{/privacy}","received_events_url":"https://api.github.com/users/awendland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-04T20:35:54Z","updated_at":"2016-08-09T17:50:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/3750","html_url":"https://github.com/keybase/client/pull/3750","diff_url":"https://github.com/keybase/client/pull/3750.diff","patch_url":"https://github.com/keybase/client/pull/3750.patch"},"body":"## The What\r\n\r\nProvides a dumb component for a screen that presents the user with a critical choice about their website proof: to plomp some file somewhere, or to do the deed with some DNS.\r\n\r\n### Warning, this PR has eaten 2 other PRs 😱 \r\n![Amoeba eating 2 other PRs](http://i.giphy.com/HdF0qSsv4q2qs.gif)\r\n\r\nThe first PR that was consumer --> #3763\r\nThe second PR to fall prey to this monster --> #3786\r\n\r\n## The How\r\n\r\nThis PR adds three components (conventiently organized into three separate commits!) to address this problem. Let's chat about those a little:\r\n\r\n#### StandardScreen\r\n\r\nThis excitingly named component provides the riveting functionality of laying out the general case screen that appears in many of the designs. It provides for a couple of things, the real exciting ones being:\r\n  - A close button (_Ooo_)\r\n  - A horz/vert centered view that scrolls (_Aahh_)\r\n  - An error bar (_Whoaa_)\r\n\r\nThis component is currently only being used for the other components in this PR, but can easily be applied to several other screens. Off the top of my head: post proof, revoke proof, revoke device, and anything else that is a cancellable information/action screen.\r\n\r\n#### ChoiceScreen\r\n\r\nThis almost-as-excitingly named component is built to make everyone's lives harder by facilitating the axiom of choice. It can take in a bevy of options with such features as *title, description, icon,* and *onClick* and present them in a wonderfully designed (thanks design team!) manner. For extra fun, it implements some jaw-dropping background transitions and horizontal translations on the icon when hovered 🎉😯.\r\n\r\n#### ProveWebsiteChoice\r\n\r\nThis game changing component is a tiny little, super thin wrapper on top of ChoiceScreen that provides the prop information to make the choices pertinent to the new website proof flow. It's not much to look at, and I'm not a fan of the name I gave it, so feel free to rename/move it to fit the new proof flow in a more adequate manner. I don't even know if it should stay as it's own component with how simple it is on top of ChoiceScreen, but I've left it for now so that the integrator of the new website proof flow can do with it as they please.\r\n\r\n@keybase/react-hackers "},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/238634012","html_url":"https://github.com/keybase/client/pull/3750#issuecomment-238634012","issue_url":"https://api.github.com/repos/keybase/client/issues/3750","id":238634012,"user":{"login":"keybase-ci-visdiff","id":19354522,"avatar_url":"https://avatars.githubusercontent.com/u/19354522?v=3","gravatar_id":"","url":"https://api.github.com/users/keybase-ci-visdiff","html_url":"https://github.com/keybase-ci-visdiff","followers_url":"https://api.github.com/users/keybase-ci-visdiff/followers","following_url":"https://api.github.com/users/keybase-ci-visdiff/following{/other_user}","gists_url":"https://api.github.com/users/keybase-ci-visdiff/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase-ci-visdiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase-ci-visdiff/subscriptions","organizations_url":"https://api.github.com/users/keybase-ci-visdiff/orgs","repos_url":"https://api.github.com/users/keybase-ci-visdiff/repos","events_url":"https://api.github.com/users/keybase-ci-visdiff/events{/privacy}","received_events_url":"https://api.github.com/users/keybase-ci-visdiff/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T17:50:06Z","updated_at":"2016-08-09T17:50:06Z","body":":mag_right: The commits 0adb00565587...2274fb959dee introduced some visual changes on linux:\n * Added: **Standard_Screen-Success_w_Custom_Notification_Element**  \n   ![Standard_Screen-Success_w_Custom_Notification_Element rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Standard_Screen-Success_w_Custom_Notification_Element-2274fb959dee.png)\n * Added: **Standard_Screen-Normal**  \n   ![Standard_Screen-Normal rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Standard_Screen-Normal-2274fb959dee.png)\n * Added: **Standard_Screen-Error**  \n   ![Standard_Screen-Error rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Standard_Screen-Error-2274fb959dee.png)\n * Added: **New_Proof_Website-DNS_or_File**  \n   ![New_Proof_Website-DNS_or_File rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/New_Proof_Website-DNS_or_File-2274fb959dee.png)\n * Added: **New_Proof_PGP_import-Import_PGP**  \n   ![New_Proof_PGP_import-Import_PGP rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/New_Proof_PGP_import-Import_PGP-2274fb959dee.png)\n * Added: **New_Proof_PGP-Import_or_Generate**  \n   ![New_Proof_PGP-Import_or_Generate rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/New_Proof_PGP-Import_or_Generate-2274fb959dee.png)\n * Added: **Choice_List-Two_Choices**  \n   ![Choice_List-Two_Choices rendered](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Choice_List-Two_Choices-2274fb959dee.png)\n * Changed: **Tracker-Logged_out** [(before)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Tracker-Logged_out-0adb00565587.png) [(after)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Tracker-Logged_out-2274fb959dee.png) [(diff)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Tracker-Logged_out.png)\n * Changed: **Search-Coming_soon** [(before)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Search-Coming_soon-0adb00565587.png) [(after)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Search-Coming_soon-2274fb959dee.png) [(diff)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Search-Coming_soon.png)\n * Changed: **Folders_TLF-Coming_Soon** [(before)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Folders_TLF-Coming_Soon-0adb00565587.png) [(after)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Folders_TLF-Coming_Soon-2274fb959dee.png) [(diff)](https://keybase-app-visdiff.s3.amazonaws.com/1470764811809-0adb00565587-2274fb959dee-linux/Folders_TLF-Coming_Soon.png)"}}
{"actor":{"display_login":"keybase-ci-visdiff"}}