{"action":"created","comment":{"url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/comments/87915353","pull_request_review_id":8507080,"id":87915353,"diff_hunk":"@@ -1,154 +0,0 @@\n-class AssetFieldType < FieldType","path":"app/models/asset_field_type.rb.orig","position":1,"original_position":1,"commit_id":"afc096b4ab3b1ecaef3fc9597d7e36fe4eaf4a38","original_commit_id":"afc096b4ab3b1ecaef3fc9597d7e36fe4eaf4a38","user":{"login":"toastercup","id":1045168,"avatar_url":"https://avatars.githubusercontent.com/u/1045168?v=3","gravatar_id":"","url":"https://api.github.com/users/toastercup","html_url":"https://github.com/toastercup","followers_url":"https://api.github.com/users/toastercup/followers","following_url":"https://api.github.com/users/toastercup/following{/other_user}","gists_url":"https://api.github.com/users/toastercup/gists{/gist_id}","starred_url":"https://api.github.com/users/toastercup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toastercup/subscriptions","organizations_url":"https://api.github.com/users/toastercup/orgs","repos_url":"https://api.github.com/users/toastercup/repos","events_url":"https://api.github.com/users/toastercup/events{/privacy}","received_events_url":"https://api.github.com/users/toastercup/received_events","type":"User","site_admin":false},"body":":+1: thank you","created_at":"2016-11-14T23:13:12Z","updated_at":"2016-11-14T23:15:16Z","html_url":"https://github.com/cortex-cms/cortex-plugins-core/pull/19#discussion_r87915353","pull_request_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/comments/87915353"},"html":{"href":"https://github.com/cortex-cms/cortex-plugins-core/pull/19#discussion_r87915353"},"pull_request":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19","id":92656936,"html_url":"https://github.com/cortex-cms/cortex-plugins-core/pull/19","diff_url":"https://github.com/cortex-cms/cortex-plugins-core/pull/19.diff","patch_url":"https://github.com/cortex-cms/cortex-plugins-core/pull/19.patch","issue_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/19","number":19,"state":"open","locked":false,"title":"Bugfixes/cor 382+502 tree saving and refactoring","user":{"login":"ElliottAYoung","id":8419757,"avatar_url":"https://avatars.githubusercontent.com/u/8419757?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliottAYoung","html_url":"https://github.com/ElliottAYoung","followers_url":"https://api.github.com/users/ElliottAYoung/followers","following_url":"https://api.github.com/users/ElliottAYoung/following{/other_user}","gists_url":"https://api.github.com/users/ElliottAYoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliottAYoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliottAYoung/subscriptions","organizations_url":"https://api.github.com/users/ElliottAYoung/orgs","repos_url":"https://api.github.com/users/ElliottAYoung/repos","events_url":"https://api.github.com/users/ElliottAYoung/events{/privacy}","received_events_url":"https://api.github.com/users/ElliottAYoung/received_events","type":"User","site_admin":false},"body":"@toastercup @arelia @MKwenhua \r\n\r\nFirst thing - there appears to be a duplicate file of the asset field type that was the remnant of a previous rebase...which is bad...we should double check everything and make sure we don't have more problematic git code floating around anywhere\r\n\r\nSecond thing - turns out using context[:form] (ironically) changed the context of the form and caused the checkboxes in the tree field type to miss the correct reference, making it so they could not save anything from checkbox tree field types. Additionally plays into my PR on main Cortex as well by removing the casting of non hashed data in the model for trees, since they'll always be arrays.","created_at":"2016-11-07T20:24:08Z","updated_at":"2016-11-14T23:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ad9eedb2f86c5ef7a839819d351bbbc464b009d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19/commits","review_comments_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19/comments","review_comment_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/19/comments","statuses_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/statuses/afc096b4ab3b1ecaef3fc9597d7e36fe4eaf4a38","head":{"label":"cortex-cms:bugfixes/COR-382+502-Tree-Saving-and-Refactoring","ref":"bugfixes/COR-382+502-Tree-Saving-and-Refactoring","sha":"afc096b4ab3b1ecaef3fc9597d7e36fe4eaf4a38","user":{"login":"cortex-cms","id":12399718,"avatar_url":"https://avatars.githubusercontent.com/u/12399718?v=3","gravatar_id":"","url":"https://api.github.com/users/cortex-cms","html_url":"https://github.com/cortex-cms","followers_url":"https://api.github.com/users/cortex-cms/followers","following_url":"https://api.github.com/users/cortex-cms/following{/other_user}","gists_url":"https://api.github.com/users/cortex-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/cortex-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cortex-cms/subscriptions","organizations_url":"https://api.github.com/users/cortex-cms/orgs","repos_url":"https://api.github.com/users/cortex-cms/repos","events_url":"https://api.github.com/users/cortex-cms/events{/privacy}","received_events_url":"https://api.github.com/users/cortex-cms/received_events","type":"Organization","site_admin":false},"repo":{"id":68278544,"name":"cortex-plugins-core","full_name":"cortex-cms/cortex-plugins-core","owner":{"login":"cortex-cms","id":12399718,"avatar_url":"https://avatars.githubusercontent.com/u/12399718?v=3","gravatar_id":"","url":"https://api.github.com/users/cortex-cms","html_url":"https://github.com/cortex-cms","followers_url":"https://api.github.com/users/cortex-cms/followers","following_url":"https://api.github.com/users/cortex-cms/following{/other_user}","gists_url":"https://api.github.com/users/cortex-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/cortex-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cortex-cms/subscriptions","organizations_url":"https://api.github.com/users/cortex-cms/orgs","repos_url":"https://api.github.com/users/cortex-cms/repos","events_url":"https://api.github.com/users/cortex-cms/events{/privacy}","received_events_url":"https://api.github.com/users/cortex-cms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cortex-cms/cortex-plugins-core","description":"The combined set of core FieldTypes for the Cortex CMS platform","fork":false,"url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core","forks_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/forks","keys_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/teams","hooks_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/hooks","issue_events_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/events{/number}","events_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/events","assignees_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/assignees{/user}","branches_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/branches{/branch}","tags_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/tags","blobs_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/languages","stargazers_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/stargazers","contributors_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/contributors","subscribers_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/subscribers","subscription_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/subscription","commits_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/contents/{+path}","compare_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/merges","archive_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/downloads","issues_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues{/number}","pulls_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/labels{/name}","releases_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/releases{/id}","deployments_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/deployments","created_at":"2016-09-15T08:36:33Z","updated_at":"2016-10-24T17:59:26Z","pushed_at":"2016-11-07T20:24:08Z","git_url":"git://github.com/cortex-cms/cortex-plugins-core.git","ssh_url":"git@github.com:cortex-cms/cortex-plugins-core.git","clone_url":"https://github.com/cortex-cms/cortex-plugins-core.git","svn_url":"https://github.com/cortex-cms/cortex-plugins-core","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"cortex-cms:develop","ref":"develop","sha":"d101af91d0dbf64fcd3b1e1d5e4bc401296a59a4","user":{"login":"cortex-cms","id":12399718,"avatar_url":"https://avatars.githubusercontent.com/u/12399718?v=3","gravatar_id":"","url":"https://api.github.com/users/cortex-cms","html_url":"https://github.com/cortex-cms","followers_url":"https://api.github.com/users/cortex-cms/followers","following_url":"https://api.github.com/users/cortex-cms/following{/other_user}","gists_url":"https://api.github.com/users/cortex-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/cortex-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cortex-cms/subscriptions","organizations_url":"https://api.github.com/users/cortex-cms/orgs","repos_url":"https://api.github.com/users/cortex-cms/repos","events_url":"https://api.github.com/users/cortex-cms/events{/privacy}","received_events_url":"https://api.github.com/users/cortex-cms/received_events","type":"Organization","site_admin":false},"repo":{"id":68278544,"name":"cortex-plugins-core","full_name":"cortex-cms/cortex-plugins-core","owner":{"login":"cortex-cms","id":12399718,"avatar_url":"https://avatars.githubusercontent.com/u/12399718?v=3","gravatar_id":"","url":"https://api.github.com/users/cortex-cms","html_url":"https://github.com/cortex-cms","followers_url":"https://api.github.com/users/cortex-cms/followers","following_url":"https://api.github.com/users/cortex-cms/following{/other_user}","gists_url":"https://api.github.com/users/cortex-cms/gists{/gist_id}","starred_url":"https://api.github.com/users/cortex-cms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cortex-cms/subscriptions","organizations_url":"https://api.github.com/users/cortex-cms/orgs","repos_url":"https://api.github.com/users/cortex-cms/repos","events_url":"https://api.github.com/users/cortex-cms/events{/privacy}","received_events_url":"https://api.github.com/users/cortex-cms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cortex-cms/cortex-plugins-core","description":"The combined set of core FieldTypes for the Cortex CMS platform","fork":false,"url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core","forks_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/forks","keys_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/teams","hooks_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/hooks","issue_events_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/events{/number}","events_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/events","assignees_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/assignees{/user}","branches_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/branches{/branch}","tags_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/tags","blobs_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/languages","stargazers_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/stargazers","contributors_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/contributors","subscribers_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/subscribers","subscription_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/subscription","commits_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/contents/{+path}","compare_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/merges","archive_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/downloads","issues_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues{/number}","pulls_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/labels{/name}","releases_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/releases{/id}","deployments_url":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/deployments","created_at":"2016-09-15T08:36:33Z","updated_at":"2016-10-24T17:59:26Z","pushed_at":"2016-11-07T20:24:08Z","git_url":"git://github.com/cortex-cms/cortex-plugins-core.git","ssh_url":"git@github.com:cortex-cms/cortex-plugins-core.git","clone_url":"https://github.com/cortex-cms/cortex-plugins-core.git","svn_url":"https://github.com/cortex-cms/cortex-plugins-core","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19"},"html":{"href":"https://github.com/cortex-cms/cortex-plugins-core/pull/19"},"issue":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/19"},"comments":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/cortex-cms/cortex-plugins-core/statuses/afc096b4ab3b1ecaef3fc9597d7e36fe4eaf4a38"}}}}
{"actor":{"display_login":"toastercup"}}