{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments/49724925","id":49724925,"diff_hunk":"@@ -81,6 +81,10 @@\n \t\t\t<artifactId>lombok</artifactId>\n \t\t</dependency>\n \t\t<dependency>\n+\t\t\t<groupId>com.github.kristofa</groupId>","path":"spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/pom.xml","position":4,"original_position":4,"commit_id":"bf191d7cba5251d45a75d2d8682bd3da8b8aba6a","original_commit_id":"bf191d7cba5251d45a75d2d8682bd3da8b8aba6a","user":{"login":"dsyer","id":124075,"avatar_url":"https://avatars.githubusercontent.com/u/124075?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"body":"This sample should not require brave. I though the intention of this change was to remove the brave dependency everywhere, but this is the least likely place to see one.","created_at":"2016-01-14T13:28:00Z","updated_at":"2016-01-14T13:28:00Z","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/108#discussion_r49724925","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments/49724925"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/108#discussion_r49724925"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108","id":56034109,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/108","diff_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/108.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/108.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/108","number":108,"state":"open","locked":false,"title":"Introduces HttpZipkinSpanReporter (rebased)","user":{"login":"marcingrzejszczak","id":3297437,"avatar_url":"https://avatars.githubusercontent.com/u/3297437?v=3","gravatar_id":"","url":"https://api.github.com/users/marcingrzejszczak","html_url":"https://github.com/marcingrzejszczak","followers_url":"https://api.github.com/users/marcingrzejszczak/followers","following_url":"https://api.github.com/users/marcingrzejszczak/following{/other_user}","gists_url":"https://api.github.com/users/marcingrzejszczak/gists{/gist_id}","starred_url":"https://api.github.com/users/marcingrzejszczak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcingrzejszczak/subscriptions","organizations_url":"https://api.github.com/users/marcingrzejszczak/orgs","repos_url":"https://api.github.com/users/marcingrzejszczak/repos","events_url":"https://api.github.com/users/marcingrzejszczak/events{/privacy}","received_events_url":"https://api.github.com/users/marcingrzejszczak/received_events","type":"User","site_admin":false},"body":"Originally - https://github.com/spring-cloud/spring-cloud-sleuth/pull/107\r\n\r\nOriginal note:\r\nBrave's span collector, which turned out to not be a great tool for\r\ndirect use. Brave internally creates spans before sending to its\r\ncollector, so validation is implicit. The flip side of this is using the\r\ncollector directly does not validate spans. This means it is easy to\r\nsend invalid ones, for example missing span names. The problem is more\r\ndifficult as the data is in binary (thrift).\r\n\r\nThis introduces HttpZipkinSpanReporter, which validates via zipkin-java\r\nclasses before sending on the wire. Moreover, this sends in json to make\r\ndebugging problems easier.\r\n\r\nThis does not fully remove the Brave dependency, as further work is\r\nneeded. Particularly, Brave is indirectly referenced in other code.\r\n\r\nSee openzipkin/zipkin-java#68\r\nSee #98 (Reporter is an OpenTracing term)","created_at":"2016-01-14T13:22:17Z","updated_at":"2016-01-14T13:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ced27b711168fd83392055b5b1f69d67461957e5","assignee":null,"milestone":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones/3","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/milestones/1.0.0","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones/3/labels","id":1434835,"number":3,"title":"1.0.0","description":"","creator":{"login":"dsyer","id":124075,"avatar_url":"https://avatars.githubusercontent.com/u/124075?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyer","html_url":"https://github.com/dsyer","followers_url":"https://api.github.com/users/dsyer/followers","following_url":"https://api.github.com/users/dsyer/following{/other_user}","gists_url":"https://api.github.com/users/dsyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyer/subscriptions","organizations_url":"https://api.github.com/users/dsyer/orgs","repos_url":"https://api.github.com/users/dsyer/repos","events_url":"https://api.github.com/users/dsyer/events{/privacy}","received_events_url":"https://api.github.com/users/dsyer/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":11,"state":"open","created_at":"2015-11-30T09:37:36Z","updated_at":"2016-01-14T13:22:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/108/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/bf191d7cba5251d45a75d2d8682bd3da8b8aba6a","head":{"label":"spring-cloud:remove-brave-dep-merged","ref":"remove-brave-dep-merged","sha":"bf191d7cba5251d45a75d2d8682bd3da8b8aba6a","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":31788540,"name":"spring-cloud-sleuth","full_name":"spring-cloud/spring-cloud-sleuth","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth","description":"Distributed tracing for spring cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/releases{/id}","created_at":"2015-03-06T20:51:47Z","updated_at":"2016-01-11T09:53:27Z","pushed_at":"2016-01-14T13:22:17Z","git_url":"git://github.com/spring-cloud/spring-cloud-sleuth.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-sleuth.git","clone_url":"https://github.com/spring-cloud/spring-cloud-sleuth.git","svn_url":"https://github.com/spring-cloud/spring-cloud-sleuth","homepage":"http://cloud.spring.io","size":1780,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":26,"forks":17,"open_issues":26,"watchers":55,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"f7fad008bc033614cbf6d755d2298c3cbaf77b8d","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":31788540,"name":"spring-cloud-sleuth","full_name":"spring-cloud/spring-cloud-sleuth","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth","description":"Distributed tracing for spring cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/releases{/id}","created_at":"2015-03-06T20:51:47Z","updated_at":"2016-01-11T09:53:27Z","pushed_at":"2016-01-14T13:22:17Z","git_url":"git://github.com/spring-cloud/spring-cloud-sleuth.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-sleuth.git","clone_url":"https://github.com/spring-cloud/spring-cloud-sleuth.git","svn_url":"https://github.com/spring-cloud/spring-cloud-sleuth","homepage":"http://cloud.spring.io","size":1780,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":26,"forks":17,"open_issues":26,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/108"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/108"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/bf191d7cba5251d45a75d2d8682bd3da8b8aba6a"}}}}