{"action":"closed","number":32647,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/32647","id":64791362,"html_url":"https://github.com/rust-lang/rust/pull/32647","diff_url":"https://github.com/rust-lang/rust/pull/32647.diff","patch_url":"https://github.com/rust-lang/rust/pull/32647.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/32647","number":32647,"state":"closed","locked":false,"title":"Only allow using the atomic intrinsics on integer types","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"body":"Using these with non-integer types results in LLVM asserts. Atomic operations on non-integer types will require values be transmuted into an integer type of suitable size.\r\n\r\nThis doesn't affect the standard library since `AtomicBool` and `AtomicPtr` currently use `usize` for atomic operations.\r\n\r\nr? @eddyb ","created_at":"2016-03-31T13:38:27Z","updated_at":"2016-04-05T02:01:16Z","closed_at":"2016-04-05T02:01:16Z","merged_at":"2016-04-05T02:01:16Z","merge_commit_sha":"8620bbaafd8bffda3584b4e8534d38dcc09cc6b1","assignee":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/32647/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/32647/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/32647/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/8620bbaafd8bffda3584b4e8534d38dcc09cc6b1","head":{"label":"Amanieu:checked_atomic_intrinsics","ref":"checked_atomic_intrinsics","sha":"8620bbaafd8bffda3584b4e8534d38dcc09cc6b1","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"repo":{"id":45469588,"name":"rust","full_name":"Amanieu/rust","owner":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Amanieu/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/Amanieu/rust","forks_url":"https://api.github.com/repos/Amanieu/rust/forks","keys_url":"https://api.github.com/repos/Amanieu/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amanieu/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amanieu/rust/teams","hooks_url":"https://api.github.com/repos/Amanieu/rust/hooks","issue_events_url":"https://api.github.com/repos/Amanieu/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Amanieu/rust/events","assignees_url":"https://api.github.com/repos/Amanieu/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Amanieu/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Amanieu/rust/tags","blobs_url":"https://api.github.com/repos/Amanieu/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amanieu/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amanieu/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amanieu/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amanieu/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Amanieu/rust/languages","stargazers_url":"https://api.github.com/repos/Amanieu/rust/stargazers","contributors_url":"https://api.github.com/repos/Amanieu/rust/contributors","subscribers_url":"https://api.github.com/repos/Amanieu/rust/subscribers","subscription_url":"https://api.github.com/repos/Amanieu/rust/subscription","commits_url":"https://api.github.com/repos/Amanieu/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amanieu/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amanieu/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amanieu/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amanieu/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Amanieu/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amanieu/rust/merges","archive_url":"https://api.github.com/repos/Amanieu/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amanieu/rust/downloads","issues_url":"https://api.github.com/repos/Amanieu/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Amanieu/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Amanieu/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Amanieu/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amanieu/rust/labels{/name}","releases_url":"https://api.github.com/repos/Amanieu/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Amanieu/rust/deployments","created_at":"2015-11-03T13:52:04Z","updated_at":"2016-03-13T16:41:55Z","pushed_at":"2016-04-03T22:14:56Z","git_url":"git://github.com/Amanieu/rust.git","ssh_url":"git@github.com:Amanieu/rust.git","clone_url":"https://github.com/Amanieu/rust.git","svn_url":"https://github.com/Amanieu/rust","homepage":"http://www.rust-lang.org","size":288780,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"9c2186d4d7427deef9d7c40cd34bf915904a6b09","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-04-04T22:44:52Z","pushed_at":"2016-04-05T02:01:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":485643,"stargazers_count":16120,"watchers_count":16120,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3078,"mirror_url":null,"open_issues_count":2404,"forks":3078,"open_issues":2404,"watchers":16120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32647"},"html":{"href":"https://github.com/rust-lang/rust/pull/32647"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32647"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32647/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32647/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32647/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/8620bbaafd8bffda3584b4e8534d38dcc09cc6b1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":30,"review_comments":2,"commits":2,"additions":161,"deletions":31,"changed_files":3}}