{"action":"created","comment":{"url":"https://api.github.com/repos/michal-mally/mucha/pulls/comments/62965336","id":62965336,"diff_hunk":"@@ -0,0 +1,35 @@\n+package com.solidbrain.russads.configuration;\r\n+\r\n+import java.util.List;\r\n+\r\n+import javax.persistence.EntityManager;\r\n+import javax.persistence.PersistenceContext;\r\n+\r\n+import org.springframework.transaction.annotation.Transactional;\r\n+\r\n+import com.solidbrain.russads.configuration.model.ConfigurationProperty;\r\n+\r\n+public class ConfigurationHelper {\r\n+\r\n+\tpublic static final String AUTO_SALES_REP_KEY = \"autoSalesRep\";\r\n+\r\n+\t@PersistenceContext\r\n+\tEntityManager entityManager;\r","path":"src/main/java/com/solidbrain/russads/configuration/ConfigurationHelper.java","position":17,"original_position":17,"commit_id":"c3eba886671321809420663d86f4e8a366b10af1","original_commit_id":"c3eba886671321809420663d86f4e8a366b10af1","user":{"login":"michal-mally","id":2753108,"avatar_url":"https://avatars.githubusercontent.com/u/2753108?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mally","html_url":"https://github.com/michal-mally","followers_url":"https://api.github.com/users/michal-mally/followers","following_url":"https://api.github.com/users/michal-mally/following{/other_user}","gists_url":"https://api.github.com/users/michal-mally/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mally/subscriptions","organizations_url":"https://api.github.com/users/michal-mally/orgs","repos_url":"https://api.github.com/users/michal-mally/repos","events_url":"https://api.github.com/users/michal-mally/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mally/received_events","type":"User","site_admin":false},"body":"When using Spring Data it is very unusual to inject `EntityManager`. Why you do not just inject `ConfigurationPropertyRepositiry` here?","created_at":"2016-05-12T04:59:40Z","updated_at":"2016-05-12T04:59:40Z","html_url":"https://github.com/michal-mally/mucha/pull/1#discussion_r62965336","pull_request_url":"https://api.github.com/repos/michal-mally/mucha/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/michal-mally/mucha/pulls/comments/62965336"},"html":{"href":"https://github.com/michal-mally/mucha/pull/1#discussion_r62965336"},"pull_request":{"href":"https://api.github.com/repos/michal-mally/mucha/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/michal-mally/mucha/pulls/1","id":69777665,"html_url":"https://github.com/michal-mally/mucha/pull/1","diff_url":"https://github.com/michal-mally/mucha/pull/1.diff","patch_url":"https://github.com/michal-mally/mucha/pull/1.patch","issue_url":"https://api.github.com/repos/michal-mally/mucha/issues/1","number":1,"state":"open","locked":false,"title":"Milestone #3","user":{"login":"michal-mally","id":2753108,"avatar_url":"https://avatars.githubusercontent.com/u/2753108?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mally","html_url":"https://github.com/michal-mally","followers_url":"https://api.github.com/users/michal-mally/followers","following_url":"https://api.github.com/users/michal-mally/following{/other_user}","gists_url":"https://api.github.com/users/michal-mally/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mally/subscriptions","organizations_url":"https://api.github.com/users/michal-mally/orgs","repos_url":"https://api.github.com/users/michal-mally/repos","events_url":"https://api.github.com/users/michal-mally/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mally/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-12T04:20:47Z","updated_at":"2016-05-12T04:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92000a5ae604061fc87a3714d0f9639a71c1b7cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/michal-mally/mucha/pulls/1/commits","review_comments_url":"https://api.github.com/repos/michal-mally/mucha/pulls/1/comments","review_comment_url":"https://api.github.com/repos/michal-mally/mucha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/michal-mally/mucha/issues/1/comments","statuses_url":"https://api.github.com/repos/michal-mally/mucha/statuses/c3eba886671321809420663d86f4e8a366b10af1","head":{"label":"michal-mally:master","ref":"master","sha":"c3eba886671321809420663d86f4e8a366b10af1","user":{"login":"michal-mally","id":2753108,"avatar_url":"https://avatars.githubusercontent.com/u/2753108?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mally","html_url":"https://github.com/michal-mally","followers_url":"https://api.github.com/users/michal-mally/followers","following_url":"https://api.github.com/users/michal-mally/following{/other_user}","gists_url":"https://api.github.com/users/michal-mally/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mally/subscriptions","organizations_url":"https://api.github.com/users/michal-mally/orgs","repos_url":"https://api.github.com/users/michal-mally/repos","events_url":"https://api.github.com/users/michal-mally/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mally/received_events","type":"User","site_admin":false},"repo":{"id":58606963,"name":"mucha","full_name":"michal-mally/mucha","owner":{"login":"michal-mally","id":2753108,"avatar_url":"https://avatars.githubusercontent.com/u/2753108?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mally","html_url":"https://github.com/michal-mally","followers_url":"https://api.github.com/users/michal-mally/followers","following_url":"https://api.github.com/users/michal-mally/following{/other_user}","gists_url":"https://api.github.com/users/michal-mally/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mally/subscriptions","organizations_url":"https://api.github.com/users/michal-mally/orgs","repos_url":"https://api.github.com/users/michal-mally/repos","events_url":"https://api.github.com/users/michal-mally/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mally/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michal-mally/mucha","description":"","fork":true,"url":"https://api.github.com/repos/michal-mally/mucha","forks_url":"https://api.github.com/repos/michal-mally/mucha/forks","keys_url":"https://api.github.com/repos/michal-mally/mucha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michal-mally/mucha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michal-mally/mucha/teams","hooks_url":"https://api.github.com/repos/michal-mally/mucha/hooks","issue_events_url":"https://api.github.com/repos/michal-mally/mucha/issues/events{/number}","events_url":"https://api.github.com/repos/michal-mally/mucha/events","assignees_url":"https://api.github.com/repos/michal-mally/mucha/assignees{/user}","branches_url":"https://api.github.com/repos/michal-mally/mucha/branches{/branch}","tags_url":"https://api.github.com/repos/michal-mally/mucha/tags","blobs_url":"https://api.github.com/repos/michal-mally/mucha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michal-mally/mucha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michal-mally/mucha/git/refs{/sha}","trees_url":"https://api.github.com/repos/michal-mally/mucha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michal-mally/mucha/statuses/{sha}","languages_url":"https://api.github.com/repos/michal-mally/mucha/languages","stargazers_url":"https://api.github.com/repos/michal-mally/mucha/stargazers","contributors_url":"https://api.github.com/repos/michal-mally/mucha/contributors","subscribers_url":"https://api.github.com/repos/michal-mally/mucha/subscribers","subscription_url":"https://api.github.com/repos/michal-mally/mucha/subscription","commits_url":"https://api.github.com/repos/michal-mally/mucha/commits{/sha}","git_commits_url":"https://api.github.com/repos/michal-mally/mucha/git/commits{/sha}","comments_url":"https://api.github.com/repos/michal-mally/mucha/comments{/number}","issue_comment_url":"https://api.github.com/repos/michal-mally/mucha/issues/comments{/number}","contents_url":"https://api.github.com/repos/michal-mally/mucha/contents/{+path}","compare_url":"https://api.github.com/repos/michal-mally/mucha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michal-mally/mucha/merges","archive_url":"https://api.github.com/repos/michal-mally/mucha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michal-mally/mucha/downloads","issues_url":"https://api.github.com/repos/michal-mally/mucha/issues{/number}","pulls_url":"https://api.github.com/repos/michal-mally/mucha/pulls{/number}","milestones_url":"https://api.github.com/repos/michal-mally/mucha/milestones{/number}","notifications_url":"https://api.github.com/repos/michal-mally/mucha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michal-mally/mucha/labels{/name}","releases_url":"https://api.github.com/repos/michal-mally/mucha/releases{/id}","deployments_url":"https://api.github.com/repos/michal-mally/mucha/deployments","created_at":"2016-05-12T04:16:24Z","updated_at":"2016-05-12T04:16:25Z","pushed_at":"2016-05-12T04:20:47Z","git_url":"git://github.com/michal-mally/mucha.git","ssh_url":"git@github.com:michal-mally/mucha.git","clone_url":"https://github.com/michal-mally/mucha.git","svn_url":"https://github.com/michal-mally/mucha","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"michal-mally:before_m3","ref":"before_m3","sha":"60002c986cb0c07b3ab5e9bb876caca2d86cd9af","user":{"login":"michal-mally","id":2753108,"avatar_url":"https://avatars.githubusercontent.com/u/2753108?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mally","html_url":"https://github.com/michal-mally","followers_url":"https://api.github.com/users/michal-mally/followers","following_url":"https://api.github.com/users/michal-mally/following{/other_user}","gists_url":"https://api.github.com/users/michal-mally/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mally/subscriptions","organizations_url":"https://api.github.com/users/michal-mally/orgs","repos_url":"https://api.github.com/users/michal-mally/repos","events_url":"https://api.github.com/users/michal-mally/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mally/received_events","type":"User","site_admin":false},"repo":{"id":58606963,"name":"mucha","full_name":"michal-mally/mucha","owner":{"login":"michal-mally","id":2753108,"avatar_url":"https://avatars.githubusercontent.com/u/2753108?v=3","gravatar_id":"","url":"https://api.github.com/users/michal-mally","html_url":"https://github.com/michal-mally","followers_url":"https://api.github.com/users/michal-mally/followers","following_url":"https://api.github.com/users/michal-mally/following{/other_user}","gists_url":"https://api.github.com/users/michal-mally/gists{/gist_id}","starred_url":"https://api.github.com/users/michal-mally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michal-mally/subscriptions","organizations_url":"https://api.github.com/users/michal-mally/orgs","repos_url":"https://api.github.com/users/michal-mally/repos","events_url":"https://api.github.com/users/michal-mally/events{/privacy}","received_events_url":"https://api.github.com/users/michal-mally/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michal-mally/mucha","description":"","fork":true,"url":"https://api.github.com/repos/michal-mally/mucha","forks_url":"https://api.github.com/repos/michal-mally/mucha/forks","keys_url":"https://api.github.com/repos/michal-mally/mucha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michal-mally/mucha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michal-mally/mucha/teams","hooks_url":"https://api.github.com/repos/michal-mally/mucha/hooks","issue_events_url":"https://api.github.com/repos/michal-mally/mucha/issues/events{/number}","events_url":"https://api.github.com/repos/michal-mally/mucha/events","assignees_url":"https://api.github.com/repos/michal-mally/mucha/assignees{/user}","branches_url":"https://api.github.com/repos/michal-mally/mucha/branches{/branch}","tags_url":"https://api.github.com/repos/michal-mally/mucha/tags","blobs_url":"https://api.github.com/repos/michal-mally/mucha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michal-mally/mucha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michal-mally/mucha/git/refs{/sha}","trees_url":"https://api.github.com/repos/michal-mally/mucha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michal-mally/mucha/statuses/{sha}","languages_url":"https://api.github.com/repos/michal-mally/mucha/languages","stargazers_url":"https://api.github.com/repos/michal-mally/mucha/stargazers","contributors_url":"https://api.github.com/repos/michal-mally/mucha/contributors","subscribers_url":"https://api.github.com/repos/michal-mally/mucha/subscribers","subscription_url":"https://api.github.com/repos/michal-mally/mucha/subscription","commits_url":"https://api.github.com/repos/michal-mally/mucha/commits{/sha}","git_commits_url":"https://api.github.com/repos/michal-mally/mucha/git/commits{/sha}","comments_url":"https://api.github.com/repos/michal-mally/mucha/comments{/number}","issue_comment_url":"https://api.github.com/repos/michal-mally/mucha/issues/comments{/number}","contents_url":"https://api.github.com/repos/michal-mally/mucha/contents/{+path}","compare_url":"https://api.github.com/repos/michal-mally/mucha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michal-mally/mucha/merges","archive_url":"https://api.github.com/repos/michal-mally/mucha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michal-mally/mucha/downloads","issues_url":"https://api.github.com/repos/michal-mally/mucha/issues{/number}","pulls_url":"https://api.github.com/repos/michal-mally/mucha/pulls{/number}","milestones_url":"https://api.github.com/repos/michal-mally/mucha/milestones{/number}","notifications_url":"https://api.github.com/repos/michal-mally/mucha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michal-mally/mucha/labels{/name}","releases_url":"https://api.github.com/repos/michal-mally/mucha/releases{/id}","deployments_url":"https://api.github.com/repos/michal-mally/mucha/deployments","created_at":"2016-05-12T04:16:24Z","updated_at":"2016-05-12T04:16:25Z","pushed_at":"2016-05-12T04:20:47Z","git_url":"git://github.com/michal-mally/mucha.git","ssh_url":"git@github.com:michal-mally/mucha.git","clone_url":"https://github.com/michal-mally/mucha.git","svn_url":"https://github.com/michal-mally/mucha","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/michal-mally/mucha/pulls/1"},"html":{"href":"https://github.com/michal-mally/mucha/pull/1"},"issue":{"href":"https://api.github.com/repos/michal-mally/mucha/issues/1"},"comments":{"href":"https://api.github.com/repos/michal-mally/mucha/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/michal-mally/mucha/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/michal-mally/mucha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/michal-mally/mucha/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/michal-mally/mucha/statuses/c3eba886671321809420663d86f4e8a366b10af1"}}}}