{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments/61359742","id":61359742,"diff_hunk":"@@ -109,8 +109,6 @@ private HttpURLConnection setupConnection() throws IOException {\n             connection.setRequestProperty(header, mRequestHeaders.get(header));\n         }\n \n-        // Avoid reuse of existing sockets to avoid random EOF errors\n-        System.setProperty(\"http.keepAlive\", \"false\");","path":"src/src/com/microsoft/aad/adal/HttpWebRequest.java","position":5,"original_position":5,"commit_id":"8d7faf56c026aba1a233ac60ffe61574c09f91df","original_commit_id":"8d7faf56c026aba1a233ac60ffe61574c09f91df","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"body":"Then do it please","created_at":"2016-04-28T00:39:10Z","updated_at":"2016-04-28T00:39:10Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/604#discussion_r61359742","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments/61359742"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/604#discussion_r61359742"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604","id":67631963,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/604","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/604.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/604.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/604","number":604,"state":"open","locked":false,"title":"reuse of existing sockets and do not disconnect connection due to bug…","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"body":"…gy android implementation\r\n1) http.keepAlive was set to false because there is a bug in connection.disconnect method() which can close socket even if there is another connection is connected to this socket. To avoid that it's better to rely on GC to release connection.\r\nIt's very bad to set http.keepAlive property to false, because it's global system property and if application really makes lots of network calls to one socket, it improves his performance to reuse existing sockets\r\n\r\n2)  When you call getStatusCode before getInputStream HTTP stack behaves really unpredictable and there were some logic added to support that case. \r\nBack in the past getStatusCode function was called before getInputStream for POST methods and after for GET. \r\nBut now  logic is different and getStatusCode always invoked after getInputStream, so we don't need this magic anymore.","created_at":"2016-04-24T09:04:25Z","updated_at":"2016-04-28T00:39:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a570331b97362f165e7358d7862bc05ed2923ad7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/604/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/8d7faf56c026aba1a233ac60ffe61574c09f91df","head":{"label":"imakhalova:connection","ref":"connection","sha":"8d7faf56c026aba1a233ac60ffe61574c09f91df","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"repo":{"id":51237079,"name":"azure-activedirectory-library-for-android","full_name":"imakhalova/azure-activedirectory-library-for-android","owner":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android","description":"The ADAL SDK for Android gives you the ability to add support for Work Accounts to your application with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":true,"url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android","forks_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/forks","keys_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/teams","hooks_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/hooks","issue_events_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/events","assignees_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/tags","blobs_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/languages","stargazers_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/stargazers","contributors_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/contributors","subscribers_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/subscribers","subscription_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/subscription","commits_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/merges","archive_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/downloads","issues_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/labels{/name}","releases_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/deployments","created_at":"2016-02-07T05:42:06Z","updated_at":"2016-02-07T05:42:07Z","pushed_at":"2016-04-24T18:12:50Z","git_url":"git://github.com/imakhalova/azure-activedirectory-library-for-android.git","ssh_url":"git@github.com:imakhalova/azure-activedirectory-library-for-android.git","clone_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android.git","svn_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android","homepage":"http://www.windowsazure.com/en-us/services/active-directory/","size":10097,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"b9f5fed00407b43eec8eda55bb3f2fdbf10126bc","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703238,"name":"azure-activedirectory-library-for-android","full_name":"AzureAD/azure-activedirectory-library-for-android","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android","description":"The ADAL SDK for Android gives you the ability to add support for Work Accounts to your application with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/deployments","created_at":"2013-11-26T00:59:05Z","updated_at":"2016-04-27T13:21:10Z","pushed_at":"2016-04-27T20:13:28Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-android.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-android.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android","homepage":"http://www.windowsazure.com/en-us/services/active-directory/","size":24822,"stargazers_count":64,"watchers_count":64,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":75,"forks":51,"open_issues":75,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/604"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/604"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/8d7faf56c026aba1a233ac60ffe61574c09f91df"}}}}