{"action":"created","issue":{"url":"https://api.github.com/repos/obspy/obspy/issues/1625","repository_url":"https://api.github.com/repos/obspy/obspy","labels_url":"https://api.github.com/repos/obspy/obspy/issues/1625/labels{/name}","comments_url":"https://api.github.com/repos/obspy/obspy/issues/1625/comments","events_url":"https://api.github.com/repos/obspy/obspy/issues/1625/events","html_url":"https://github.com/obspy/obspy/pull/1625","id":196544194,"number":1625,"title":"Fixed https://github.com/obspy/obspy/issues/1621 by bringing Pickler.…","user":{"login":"nackerley","id":14931979,"avatar_url":"https://avatars.githubusercontent.com/u/14931979?v=3","gravatar_id":"","url":"https://api.github.com/users/nackerley","html_url":"https://github.com/nackerley","followers_url":"https://api.github.com/users/nackerley/followers","following_url":"https://api.github.com/users/nackerley/following{/other_user}","gists_url":"https://api.github.com/users/nackerley/gists{/gist_id}","starred_url":"https://api.github.com/users/nackerley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nackerley/subscriptions","organizations_url":"https://api.github.com/users/nackerley/orgs","repos_url":"https://api.github.com/users/nackerley/repos","events_url":"https://api.github.com/users/nackerley/events{/privacy}","received_events_url":"https://api.github.com/users/nackerley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-19T23:08:39Z","updated_at":"2016-12-19T23:10:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/obspy/obspy/pulls/1625","html_url":"https://github.com/obspy/obspy/pull/1625","diff_url":"https://github.com/obspy/obspy/pull/1625.diff","patch_url":"https://github.com/obspy/obspy/pull/1625.patch"},"body":"Fixed #1621 by bringing Pickler._station_magnitude_contributions() into line with other Pickler methods, such as Pickler._arrival(), in particular by making use of Pickler._str(). This means that residual and weight are written even if they are both zero, and not written only when they are `None`.\r\n\r\nI suspect that Pickler._station_magnitude_contributions() was missed when other methods were updated a while back to use Pickler._str() mainly because it is out-of-order with the rest which do use Pickler._str(). A more natural place for it among the methods would be between Pickler._station_magnitude() and Pickler._origin(), but that would have made the diff less clear.\r\n\r\nAlso fixed a bug whereby Event.region was neither written to QuakeML nor read.\r\n\r\nUpdated regression tests to reflect these changes, and added myself to contributors, even this is a very minor contribution. "},"comment":{"url":"https://api.github.com/repos/obspy/obspy/issues/comments/268105704","html_url":"https://github.com/obspy/obspy/pull/1625#issuecomment-268105704","issue_url":"https://api.github.com/repos/obspy/obspy/issues/1625","id":268105704,"user":{"login":"nackerley","id":14931979,"avatar_url":"https://avatars.githubusercontent.com/u/14931979?v=3","gravatar_id":"","url":"https://api.github.com/users/nackerley","html_url":"https://github.com/nackerley","followers_url":"https://api.github.com/users/nackerley/followers","following_url":"https://api.github.com/users/nackerley/following{/other_user}","gists_url":"https://api.github.com/users/nackerley/gists{/gist_id}","starred_url":"https://api.github.com/users/nackerley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nackerley/subscriptions","organizations_url":"https://api.github.com/users/nackerley/orgs","repos_url":"https://api.github.com/users/nackerley/repos","events_url":"https://api.github.com/users/nackerley/events{/privacy}","received_events_url":"https://api.github.com/users/nackerley/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T23:10:19Z","updated_at":"2016-12-19T23:10:19Z","body":"Forking from the maintenance branch seemed easier than resolving all the conflicts when rebasing from master to maintenance. Sorry for any confusion."}}
{"actor":{"display_login":"nackerley"}}