{"action":"created","issue":{"url":"https://api.github.com/repos/bell07/minetest-qa_block/issues/4","repository_url":"https://api.github.com/repos/bell07/minetest-qa_block","labels_url":"https://api.github.com/repos/bell07/minetest-qa_block/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/bell07/minetest-qa_block/issues/4/comments","events_url":"https://api.github.com/repos/bell07/minetest-qa_block/issues/4/events","html_url":"https://github.com/bell07/minetest-qa_block/pull/4","id":187496538,"number":4,"title":"Make useless_items checker more accurate","user":{"login":"Wuzzy2","id":1675853,"avatar_url":"https://avatars.githubusercontent.com/u/1675853?v=3","gravatar_id":"","url":"https://api.github.com/users/Wuzzy2","html_url":"https://github.com/Wuzzy2","followers_url":"https://api.github.com/users/Wuzzy2/followers","following_url":"https://api.github.com/users/Wuzzy2/following{/other_user}","gists_url":"https://api.github.com/users/Wuzzy2/gists{/gist_id}","starred_url":"https://api.github.com/users/Wuzzy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wuzzy2/subscriptions","organizations_url":"https://api.github.com/users/Wuzzy2/orgs","repos_url":"https://api.github.com/users/Wuzzy2/repos","events_url":"https://api.github.com/users/Wuzzy2/events{/privacy}","received_events_url":"https://api.github.com/users/Wuzzy2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-05T13:17:01Z","updated_at":"2016-11-05T13:57:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bell07/minetest-qa_block/pulls/4","html_url":"https://github.com/bell07/minetest-qa_block/pull/4","diff_url":"https://github.com/bell07/minetest-qa_block/pull/4.diff","patch_url":"https://github.com/bell07/minetest-qa_block/pull/4.patch"},"body":"I improved the useless_items checker to make it more accurate. It has now less false-positives.\r\n\r\nFor Minetest Game, it now only returns `default:mese_crystal_fragment`, which is expected. This item is actually useless in (plain) Minetest Game. :-)\r\n\r\nThe current version reported some items falsely as “useless”, like the doors.\r\n\r\nPlease test this script on your machine before merging. Especially if you are on Windows. This is because I am not sure if the path delimeters will work correctly on this platform. If yes, great!\r\n\r\n`DIR_DELIM` comes from builtin but the developers suggested that this global variable is somewhat intended."},"comment":{"url":"https://api.github.com/repos/bell07/minetest-qa_block/issues/comments/258613212","html_url":"https://github.com/bell07/minetest-qa_block/pull/4#issuecomment-258613212","issue_url":"https://api.github.com/repos/bell07/minetest-qa_block/issues/4","id":258613212,"user":{"login":"bell07","id":4731334,"avatar_url":"https://avatars.githubusercontent.com/u/4731334?v=3","gravatar_id":"","url":"https://api.github.com/users/bell07","html_url":"https://github.com/bell07","followers_url":"https://api.github.com/users/bell07/followers","following_url":"https://api.github.com/users/bell07/following{/other_user}","gists_url":"https://api.github.com/users/bell07/gists{/gist_id}","starred_url":"https://api.github.com/users/bell07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bell07/subscriptions","organizations_url":"https://api.github.com/users/bell07/orgs","repos_url":"https://api.github.com/users/bell07/repos","events_url":"https://api.github.com/users/bell07/events{/privacy}","received_events_url":"https://api.github.com/users/bell07/received_events","type":"User","site_admin":false},"created_at":"2016-11-05T13:57:18Z","updated_at":"2016-11-05T13:57:18Z","body":"I do not have any Windows installation, Linux only. So please try to test it in other way (a Win-VM?). Less time today, I will look on the pull request tomorrow."}}
{"actor":{"display_login":"bell07"}}