{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2422","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2422/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2422/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2422/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/2422","id":160068970,"number":2422,"title":"Refactored maven_artifact","user":{"login":"grilo","id":5563873,"avatar_url":"https://avatars.githubusercontent.com/u/5563873?v=3","gravatar_id":"","url":"https://api.github.com/users/grilo","html_url":"https://github.com/grilo","followers_url":"https://api.github.com/users/grilo/followers","following_url":"https://api.github.com/users/grilo/following{/other_user}","gists_url":"https://api.github.com/users/grilo/gists{/gist_id}","starred_url":"https://api.github.com/users/grilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grilo/subscriptions","organizations_url":"https://api.github.com/users/grilo/orgs","repos_url":"https://api.github.com/users/grilo/repos","events_url":"https://api.github.com/users/grilo/events{/privacy}","received_events_url":"https://api.github.com/users/grilo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/needs_revision","name":"needs_revision","color":"eb6420"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/pending_action","name":"pending_action","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-06-13T23:46:53Z","updated_at":"2016-08-14T22:25:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/2422","html_url":"https://github.com/ansible/ansible-modules-extras/pull/2422","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/2422.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/2422.patch"},"body":"##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nmaven_artifact\r\n\r\n##### ANSIBLE VERSION\r\nansible 2.0.0.2\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n\r\n##### SUMMARY\r\nReduced code base in approximately 30%, removed some dead code, simplified some logic, used ansible's own error checking to catch the glaring ones (such as absence of required parameters).\r\nAdded ignore_checksum option, enabling artifact download without forcing remote checksum validation.\r\nAdded aliases to repository, username and password parameters for better consistency.\r\nFixed (unreported) issue where http credentials weren't being propagated correctly.\r\nModule initialization parameters are mandatory according to the documentation but not in the code.\r\n\r\n##### TESTING\r\nI've been using this in production on my company for a couple of days now (a few thousand downloads so far, very heterogeneous parameters), no issues found.\r\n\r\n- hosts: 127.0.0.1\r\n  tasks:\r\n    - maven_artifact: group_id=junit artifact_id=junit dest=/tmp/junit-latest.jar \r\n    - maven_artifact: group_id=junit artifact_id=junit version=4.11 dest=/tmp/junit-4.11.jar \r\n    - maven_artifact: group_id=com.jfrog.artifactory.client artifact_id=api dest=/tmp repository=https://repo.jfrog.org/artifactory/libs-snapshots-local \r\n    - maven_artifact: group_id=com.jfrog.artifactory.client artifact_id=services dest=/tmp repository=https://repo.jfrog.org/artifactory/libs-snapshots-local \r\n    - maven_artifact: group_id=junit artifact_id=junit dest=/tmp/junit-latest.jar state=absent\r\n    - maven_artifact: group_id=junit artifact_id=junit version=4.11 dest=/tmp/junit-4.11.jar state=absent\r\n    - maven_artifact: group_id=com.jfrog.artifactory.client artifact_id=api dest=/tmp repository=https://repo.jfrog.org/artifactory/libs-snapshots-local \r\n    - maven_artifact: group_id=com.jfrog.artifactory.client artifact_id=services dest=/tmp repository=https://repo.jfrog.org/artifactory/libs-snapshots-local \r\n    - maven_artifact: group_id=org.jfrog.maven.plugins artifact_id=jfrog-jnlp-plugin dest=/tmp repository=https://repo.jfrog.org/artifactory/plugins-snapshots-local version=0.3-SNAPSHOT\r\n    - maven_artifact: group_id=org.jfrog.maven.plugins artifact_id=jfrog-jnlp-plugin dest=/tmp repository=https://repo.jfrog.org/artifactory/plugins-snapshots-local version=latest\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/239701648","html_url":"https://github.com/ansible/ansible-modules-extras/pull/2422#issuecomment-239701648","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/2422","id":239701648,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-08-14T22:25:58Z","updated_at":"2016-08-14T22:25:58Z","body":"@grilo A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}
{"actor":{"display_login":"gregdek"}}