{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/sims_utils/pulls/comments/66885039","id":66885039,"diff_hunk":"@@ -0,0 +1,61 @@\n+import numpy as np\n+\n+def _validate_inputs(input_list, input_names, method_name):\n+    \"\"\"\n+    This method will validate the inputs of other methods.\n+\n+    input_list is a list of the inputs passed to a method.\n+\n+    input_name is a list of the variable names associated with\n+    input_list\n+\n+    method_name is the name of the method whose input is being validated.\n+\n+    _validate_inputs will verify that all of the inputs in input_list are:\n+\n+    1) of the same type\n+    2) either floats or numpy arrays\n+    3) if they are numpy arrays, they all have the same length\n+\n+    If any of these criteria are violated, a RuntimeError will be raised\n+\n+    returns True if the inputs are numpy arrays; False if not\n+    \"\"\"\n+\n+    if isinstance(input_list[0], np.ndarray):\n+        desired_type = np.ndarray\n+    elif isinstance(input_list[0], np.float):\n+        desired_type = np.float","path":"python/lsst/sims/utils/CodeUtilities.py","position":28,"original_position":28,"commit_id":"10ff8a9502b62c08d9b5a223e7be40868c3ca809","original_commit_id":"10ff8a9502b62c08d9b5a223e7be40868c3ca809","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"numbers are now acceptable (thanks; I did not know that existed)","created_at":"2016-06-13T23:10:08Z","updated_at":"2016-06-13T23:10:08Z","html_url":"https://github.com/lsst/sims_utils/pull/16#discussion_r66885039","pull_request_url":"https://api.github.com/repos/lsst/sims_utils/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_utils/pulls/comments/66885039"},"html":{"href":"https://github.com/lsst/sims_utils/pull/16#discussion_r66885039"},"pull_request":{"href":"https://api.github.com/repos/lsst/sims_utils/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/sims_utils/pulls/16","id":70613054,"html_url":"https://github.com/lsst/sims_utils/pull/16","diff_url":"https://github.com/lsst/sims_utils/pull/16.diff","patch_url":"https://github.com/lsst/sims_utils/pull/16.patch","issue_url":"https://api.github.com/repos/lsst/sims_utils/issues/16","number":16,"state":"open","locked":false,"title":"Feature/sim 1983/wavefront sensor methods","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"This pull request incorporates the methods I drew up for the camera team to find the coordinates of the corners of specific chips into sims_coordUtils.  I took the opportunity to clean up a few things about the sims_coordUtils and sims_utils API.  Namely: there were several coordinate transformation methods that could only accept numpy arrays as inputs.  They could not accept single floats.  I fixed those methods so that they can accept either numpy arrays or floats.  I also standardized the names of args in the methods defined in sims_coordUtils/CameraUtils.py.\r\n\r\nLike any good pull request, this had implications beyond sims_coordUtils.  There are pull requests in\r\nsims_utils\r\nsims_coordUtils\r\nsims_catUtils\r\nand sims_GalSimInterface\r\nall of which must be built together.","created_at":"2016-05-18T22:57:02Z","updated_at":"2016-06-13T23:10:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cb58caaf184cd26a4f88756dc036c135ff8a6bc","assignee":{"login":"connolly","id":1108163,"avatar_url":"https://avatars.githubusercontent.com/u/1108163?v=3","gravatar_id":"","url":"https://api.github.com/users/connolly","html_url":"https://github.com/connolly","followers_url":"https://api.github.com/users/connolly/followers","following_url":"https://api.github.com/users/connolly/following{/other_user}","gists_url":"https://api.github.com/users/connolly/gists{/gist_id}","starred_url":"https://api.github.com/users/connolly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connolly/subscriptions","organizations_url":"https://api.github.com/users/connolly/orgs","repos_url":"https://api.github.com/users/connolly/repos","events_url":"https://api.github.com/users/connolly/events{/privacy}","received_events_url":"https://api.github.com/users/connolly/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_utils/pulls/16/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_utils/pulls/16/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_utils/issues/16/comments","statuses_url":"https://api.github.com/repos/lsst/sims_utils/statuses/10ff8a9502b62c08d9b5a223e7be40868c3ca809","head":{"label":"lsst:feature/SIM-1983/wavefront_sensor_methods","ref":"feature/SIM-1983/wavefront_sensor_methods","sha":"10ff8a9502b62c08d9b5a223e7be40868c3ca809","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34667977,"name":"sims_utils","full_name":"lsst/sims_utils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_utils","description":"LSST Simulations package for simulation utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_utils","forks_url":"https://api.github.com/repos/lsst/sims_utils/forks","keys_url":"https://api.github.com/repos/lsst/sims_utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_utils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_utils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_utils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_utils/events","assignees_url":"https://api.github.com/repos/lsst/sims_utils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_utils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_utils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_utils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_utils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_utils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_utils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_utils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_utils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_utils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_utils/merges","archive_url":"https://api.github.com/repos/lsst/sims_utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_utils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_utils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_utils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_utils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_utils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_utils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_utils/deployments","created_at":"2015-04-27T13:22:07Z","updated_at":"2016-01-15T21:57:26Z","pushed_at":"2016-06-10T21:17:20Z","git_url":"git://github.com/lsst/sims_utils.git","ssh_url":"git@github.com:lsst/sims_utils.git","clone_url":"https://github.com/lsst/sims_utils.git","svn_url":"https://github.com/lsst/sims_utils","homepage":null,"size":681,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"ce6506fe67f3c80dda5287ba087c61dd6e5a4356","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34667977,"name":"sims_utils","full_name":"lsst/sims_utils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_utils","description":"LSST Simulations package for simulation utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_utils","forks_url":"https://api.github.com/repos/lsst/sims_utils/forks","keys_url":"https://api.github.com/repos/lsst/sims_utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_utils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_utils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_utils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_utils/events","assignees_url":"https://api.github.com/repos/lsst/sims_utils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_utils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_utils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_utils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_utils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_utils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_utils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_utils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_utils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_utils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_utils/merges","archive_url":"https://api.github.com/repos/lsst/sims_utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_utils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_utils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_utils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_utils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_utils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_utils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_utils/deployments","created_at":"2015-04-27T13:22:07Z","updated_at":"2016-01-15T21:57:26Z","pushed_at":"2016-06-10T21:17:20Z","git_url":"git://github.com/lsst/sims_utils.git","ssh_url":"git@github.com:lsst/sims_utils.git","clone_url":"https://github.com/lsst/sims_utils.git","svn_url":"https://github.com/lsst/sims_utils","homepage":null,"size":681,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_utils/pulls/16"},"html":{"href":"https://github.com/lsst/sims_utils/pull/16"},"issue":{"href":"https://api.github.com/repos/lsst/sims_utils/issues/16"},"comments":{"href":"https://api.github.com/repos/lsst/sims_utils/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_utils/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_utils/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_utils/statuses/10ff8a9502b62c08d9b5a223e7be40868c3ca809"}}}}
{"actor":{"display_login":"danielsf"}}