{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/58516772","id":58516772,"diff_hunk":"@@ -0,0 +1,125 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+// ===========================================================================\n+// File: perfinfo.cpp\n+//\n+\n+#include \"common.h\"\n+\n+#if defined(FEATURE_PERFMAP) && !defined(DACCESS_COMPILE)\n+#include \"perfinfo.h\"\n+#include \"pal.h\"\n+\n+PerfInfo::PerfInfo(int pid)\n+{\n+    LIMITED_METHOD_CONTRACT;\n+\n+    WCHAR tempPath[MAX_LONGPATH+1];\n+    if (!GetTempPathW(MAX_LONGPATH, tempPath))","path":"src/vm/perfinfo.cpp","position":19,"original_position":19,"commit_id":"8d7bbff6f76cdad89d639da64d460a9adb0bb2aa","original_commit_id":"8d7bbff6f76cdad89d639da64d460a9adb0bb2aa","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"We have recently tried to erradicate all fixed size buffers from the codebase. Please use WszGetTempPath with SString parameter instead.","created_at":"2016-04-05T10:38:15Z","updated_at":"2016-04-05T10:38:15Z","html_url":"https://github.com/dotnet/coreclr/pull/4068#discussion_r58516772","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4068","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/58516772"},"html":{"href":"https://github.com/dotnet/coreclr/pull/4068#discussion_r58516772"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4068"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/4068","id":65190694,"html_url":"https://github.com/dotnet/coreclr/pull/4068","diff_url":"https://github.com/dotnet/coreclr/pull/4068.diff","patch_url":"https://github.com/dotnet/coreclr/pull/4068.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/4068","number":4068,"state":"open","locked":false,"title":"Generate map files for symbol resolution for Linux native images on PerfView","user":{"login":"Lucrecious","id":4584511,"avatar_url":"https://avatars.githubusercontent.com/u/4584511?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucrecious","html_url":"https://github.com/Lucrecious","followers_url":"https://api.github.com/users/Lucrecious/followers","following_url":"https://api.github.com/users/Lucrecious/following{/other_user}","gists_url":"https://api.github.com/users/Lucrecious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucrecious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucrecious/subscriptions","organizations_url":"https://api.github.com/users/Lucrecious/orgs","repos_url":"https://api.github.com/users/Lucrecious/repos","events_url":"https://api.github.com/users/Lucrecious/events{/privacy}","received_events_url":"https://api.github.com/users/Lucrecious/received_events","type":"User","site_admin":false},"body":"We are trying to enable performance investigations for Linux on Windows through PerfView.\r\n\r\nPart of this plan requires the ability to map unknown symbols to their resolved symbols from the running program's native images. We do this by having the CoreCLR generate perfinfo-%d.map files (where %d is the running process' ID). perfinfo-%.map files that contain all the dlls loaded for the specific process and this helps us generate map files with symbol mappings for all managed code dlls.","created_at":"2016-04-04T18:27:57Z","updated_at":"2016-04-05T10:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb4c733009bf644f95aa9a7e7b34f1e848d13a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4068/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/4068/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/4068/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/8d7bbff6f76cdad89d639da64d460a9adb0bb2aa","head":{"label":"Lucrecious:master","ref":"master","sha":"8d7bbff6f76cdad89d639da64d460a9adb0bb2aa","user":{"login":"Lucrecious","id":4584511,"avatar_url":"https://avatars.githubusercontent.com/u/4584511?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucrecious","html_url":"https://github.com/Lucrecious","followers_url":"https://api.github.com/users/Lucrecious/followers","following_url":"https://api.github.com/users/Lucrecious/following{/other_user}","gists_url":"https://api.github.com/users/Lucrecious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucrecious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucrecious/subscriptions","organizations_url":"https://api.github.com/users/Lucrecious/orgs","repos_url":"https://api.github.com/users/Lucrecious/repos","events_url":"https://api.github.com/users/Lucrecious/events{/privacy}","received_events_url":"https://api.github.com/users/Lucrecious/received_events","type":"User","site_admin":false},"repo":{"id":53890853,"name":"coreclr","full_name":"Lucrecious/coreclr","owner":{"login":"Lucrecious","id":4584511,"avatar_url":"https://avatars.githubusercontent.com/u/4584511?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucrecious","html_url":"https://github.com/Lucrecious","followers_url":"https://api.github.com/users/Lucrecious/followers","following_url":"https://api.github.com/users/Lucrecious/following{/other_user}","gists_url":"https://api.github.com/users/Lucrecious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucrecious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucrecious/subscriptions","organizations_url":"https://api.github.com/users/Lucrecious/orgs","repos_url":"https://api.github.com/users/Lucrecious/repos","events_url":"https://api.github.com/users/Lucrecious/events{/privacy}","received_events_url":"https://api.github.com/users/Lucrecious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lucrecious/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/Lucrecious/coreclr","forks_url":"https://api.github.com/repos/Lucrecious/coreclr/forks","keys_url":"https://api.github.com/repos/Lucrecious/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lucrecious/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lucrecious/coreclr/teams","hooks_url":"https://api.github.com/repos/Lucrecious/coreclr/hooks","issue_events_url":"https://api.github.com/repos/Lucrecious/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/Lucrecious/coreclr/events","assignees_url":"https://api.github.com/repos/Lucrecious/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/Lucrecious/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/Lucrecious/coreclr/tags","blobs_url":"https://api.github.com/repos/Lucrecious/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lucrecious/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lucrecious/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lucrecious/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lucrecious/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/Lucrecious/coreclr/languages","stargazers_url":"https://api.github.com/repos/Lucrecious/coreclr/stargazers","contributors_url":"https://api.github.com/repos/Lucrecious/coreclr/contributors","subscribers_url":"https://api.github.com/repos/Lucrecious/coreclr/subscribers","subscription_url":"https://api.github.com/repos/Lucrecious/coreclr/subscription","commits_url":"https://api.github.com/repos/Lucrecious/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lucrecious/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lucrecious/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lucrecious/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lucrecious/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/Lucrecious/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lucrecious/coreclr/merges","archive_url":"https://api.github.com/repos/Lucrecious/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lucrecious/coreclr/downloads","issues_url":"https://api.github.com/repos/Lucrecious/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/Lucrecious/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/Lucrecious/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/Lucrecious/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lucrecious/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/Lucrecious/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/Lucrecious/coreclr/deployments","created_at":"2016-03-14T20:49:08Z","updated_at":"2016-03-14T20:50:38Z","pushed_at":"2016-04-04T23:47:51Z","git_url":"git://github.com/Lucrecious/coreclr.git","ssh_url":"git@github.com:Lucrecious/coreclr.git","clone_url":"https://github.com/Lucrecious/coreclr.git","svn_url":"https://github.com/Lucrecious/coreclr","homepage":"http://dotnet.github.io/","size":66994,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"387b83fc040ca06c08b602d9174bc7ac80d39f15","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-04-05T07:03:26Z","pushed_at":"2016-04-05T10:24:49Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":77248,"stargazers_count":6104,"watchers_count":6104,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1374,"mirror_url":null,"open_issues_count":689,"forks":1374,"open_issues":689,"watchers":6104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4068"},"html":{"href":"https://github.com/dotnet/coreclr/pull/4068"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/4068"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/4068/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4068/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/4068/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/8d7bbff6f76cdad89d639da64d460a9adb0bb2aa"}}}}