{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/framework/issues/8051","repository_url":"https://api.github.com/repos/vaadin/framework","labels_url":"https://api.github.com/repos/vaadin/framework/issues/8051/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/framework/issues/8051/comments","events_url":"https://api.github.com/repos/vaadin/framework/issues/8051/events","html_url":"https://github.com/vaadin/framework/pull/8051","id":196440421,"number":8051,"title":"Fix documentation for /components","user":{"login":"pleku","id":1478381,"avatar_url":"https://avatars.githubusercontent.com/u/1478381?v=3","gravatar_id":"","url":"https://api.github.com/users/pleku","html_url":"https://github.com/pleku","followers_url":"https://api.github.com/users/pleku/followers","following_url":"https://api.github.com/users/pleku/following{/other_user}","gists_url":"https://api.github.com/users/pleku/gists{/gist_id}","starred_url":"https://api.github.com/users/pleku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleku/subscriptions","organizations_url":"https://api.github.com/users/pleku/orgs","repos_url":"https://api.github.com/users/pleku/repos","events_url":"https://api.github.com/users/pleku/events{/privacy}","received_events_url":"https://api.github.com/users/pleku/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-19T15:25:11Z","updated_at":"2016-12-19T15:49:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/framework/pulls/8051","html_url":"https://github.com/vaadin/framework/pull/8051","diff_url":"https://github.com/vaadin/framework/pull/8051.diff","patch_url":"https://github.com/vaadin/framework/pull/8051.patch"},"body":"Added warning where not updated.\r\nRemoved outdated documentation.\r\nTried to fix parts where it was feasible.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/framework/8051)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/framework/issues/comments/267998334","html_url":"https://github.com/vaadin/framework/pull/8051#issuecomment-267998334","issue_url":"https://api.github.com/repos/vaadin/framework/issues/8051","id":267998334,"user":{"login":"hesara","id":1335918,"avatar_url":"https://avatars.githubusercontent.com/u/1335918?v=3","gravatar_id":"","url":"https://api.github.com/users/hesara","html_url":"https://github.com/hesara","followers_url":"https://api.github.com/users/hesara/followers","following_url":"https://api.github.com/users/hesara/following{/other_user}","gists_url":"https://api.github.com/users/hesara/gists{/gist_id}","starred_url":"https://api.github.com/users/hesara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesara/subscriptions","organizations_url":"https://api.github.com/users/hesara/orgs","repos_url":"https://api.github.com/users/hesara/repos","events_url":"https://api.github.com/users/hesara/events{/privacy}","received_events_url":"https://api.github.com/users/hesara/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T15:49:01Z","updated_at":"2016-12-19T15:49:01Z","body":"\n\n\n\nReviewed 4 of 18 files at r1.\nReview status: 16 of 18 files reviewed at latest revision, 10 unresolved discussions.\n\n---\n\n*[documentation/components/components-label.asciidoc, line 20 at r1](https://reviewable.io:443/reviews/vaadin/framework/8051#-KZMik1n10ezQTgKOmoN:-KZMik1n10ezQTgKOmoO:b-jmgaiu) ([raw file](https://github.com/vaadin/framework/blob/c65810ff2b7e979720ae69a7a46ec9dc385c7ceb/documentation/components/components-label.asciidoc#L20)):*\n> ```AsciiDoc\n> __content mode__ of the label.\n> \n> You can give the label text most conviniently in the constructor, as is done in\n> ```\n\n(conveniently)\n\n---\n\n*[documentation/components/components-label.asciidoc, line 46 at r1](https://reviewable.io:443/reviews/vaadin/framework/8051#-KZMiy0a6sIdtpnoPqku:-KZMiy0a6sIdtpnoPqkv:bu5xmh1) ([raw file](https://github.com/vaadin/framework/blob/c65810ff2b7e979720ae69a7a46ec9dc385c7ceb/documentation/components/components-label.asciidoc#L46)):*\n> ```AsciiDoc\n> editor.addValueChangeListener(event -> label.setValue(value));\n> ----\n> See the http://demo.vaadin.com/book-examples-vaadin7/book#component.label.basic[on-line example, window=\"_blank\"].\n> ```\n\n(these links will need to be updated when there is a suitable deployed version)\n\n---\n\n*[documentation/components/components-label.asciidoc, line 56 at r1](https://reviewable.io:443/reviews/vaadin/framework/8051#-KZMjCVlgXMvPk13PZse:-KZMjCVlgXMvPk13PZsf:b-uohi36) ([raw file](https://github.com/vaadin/framework/blob/c65810ff2b7e979720ae69a7a46ec9dc385c7ceb/documentation/components/components-label.asciidoc#L56)):*\n> ```AsciiDoc\n> == Text Width and Wrapping\n> \n> [classname]#Label# has 100% default width, so the containing layout must also\n> ```\n\ndefault width is now undefined\n\n---\n\n*[documentation/components/components-label.asciidoc, line 76 at r1](https://reviewable.io:443/reviews/vaadin/framework/8051#-KZMjH4G9crrQsg70Avd:-KZMjH4G9crrQsg70Ave:b-uohi36) ([raw file](https://github.com/vaadin/framework/blob/c65810ff2b7e979720ae69a7a46ec9dc385c7ceb/documentation/components/components-label.asciidoc#L76)):*\n> ```AsciiDoc\n> See the http://demo.vaadin.com/book-examples-vaadin7/book#component.label.wrap[on-line example, window=\"_blank\"].\n> \n> As the size of the [classname]#Panel# in the above example is fixed and the\n> ```\n\ndefault width is now undefined\n\n---\n\n*[documentation/components/components-label.asciidoc, line 85 at r1](https://reviewable.io:443/reviews/vaadin/framework/8051#-KZMjJRA29-nfppQmXBT:-KZMjJRA29-nfppQmXBU:bkjk9ic) ([raw file](https://github.com/vaadin/framework/blob/c65810ff2b7e979720ae69a7a46ec9dc385c7ceb/documentation/components/components-label.asciidoc#L85)):*\n> ```AsciiDoc\n> image::img/label-example1.png[width=50%, scaledwidth=75%]\n> \n> Setting [classname]#Label# to undefined width will cause it to not wrap at the\n> ```\n\nprobably needs some editing based on the undefined width change\n\n---\n\n*[documentation/components/components-label.asciidoc, line 95 at r1](https://reviewable.io:443/reviews/vaadin/framework/8051#-KZMjSV5anRNJpq80HFV:-KZMjSV5anRNJpq80HFW:belel9a) ([raw file](https://github.com/vaadin/framework/blob/c65810ff2b7e979720ae69a7a46ec9dc385c7ceb/documentation/components/components-label.asciidoc#L95)):*\n> ```AsciiDoc\n> \n> The content of a label is formatted depending on a __content mode__. By default,\n> the text is assumed to be plain text and any contained XML-specific characters\n> ```\n\n(XML?)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/framework/8051)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"hesara"}}