{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/67812492","id":67812492,"diff_hunk":"@@ -381,7 +381,7 @@ func SetHealthcheckInterval(interval time.Duration) ClientOptionFunc {\n \n // SetMaxRetries sets the maximum number of retries before giving up when\n // performing a HTTP request to Elasticsearch.\n-func SetMaxRetries(maxRetries int) func(*Client) error {\n+func SetMaxRetries(maxRetries int) ClientOptionFunc {","path":"vendor/github.com/olivere/elastic/client.go","position":5,"original_position":5,"commit_id":"8487275fdd1843c83c6cdd0b6c27af522c2f38ef","original_commit_id":"8487275fdd1843c83c6cdd0b6c27af522c2f38ef","user":{"login":"huangyuqi","id":13324377,"avatar_url":"https://avatars.githubusercontent.com/u/13324377?v=3","gravatar_id":"","url":"https://api.github.com/users/huangyuqi","html_url":"https://github.com/huangyuqi","followers_url":"https://api.github.com/users/huangyuqi/followers","following_url":"https://api.github.com/users/huangyuqi/following{/other_user}","gists_url":"https://api.github.com/users/huangyuqi/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyuqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyuqi/subscriptions","organizations_url":"https://api.github.com/users/huangyuqi/orgs","repos_url":"https://api.github.com/users/huangyuqi/repos","events_url":"https://api.github.com/users/huangyuqi/events{/privacy}","received_events_url":"https://api.github.com/users/huangyuqi/received_events","type":"User","site_admin":false},"body":"another question, : )\r\nthe package `github.com/olivere/elastic/` we import is a third party lib we use.  If we modify the code here, and someone use the `godep`  to get the package from the origin location of github, the compile will fail.\r\nso, the better way i think is taking a PR to `github.com/olivere/elastic/` to fix this. ","created_at":"2016-06-21T06:06:20Z","updated_at":"2016-06-21T06:06:20Z","html_url":"https://github.com/kubernetes/heapster/pull/1198#discussion_r67812492","pull_request_url":"https://api.github.com/repos/kubernetes/heapster/pulls/1198","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/67812492"},"html":{"href":"https://github.com/kubernetes/heapster/pull/1198#discussion_r67812492"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1198"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/1198","id":74230696,"html_url":"https://github.com/kubernetes/heapster/pull/1198","diff_url":"https://github.com/kubernetes/heapster/pull/1198.diff","patch_url":"https://github.com/kubernetes/heapster/pull/1198.patch","issue_url":"https://api.github.com/repos/kubernetes/heapster/issues/1198","number":1198,"state":"open","locked":false,"title":"Adds new ElasticSearch URL options","user":{"login":"jamiehannaford","id":1867202,"avatar_url":"https://avatars.githubusercontent.com/u/1867202?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiehannaford","html_url":"https://github.com/jamiehannaford","followers_url":"https://api.github.com/users/jamiehannaford/followers","following_url":"https://api.github.com/users/jamiehannaford/following{/other_user}","gists_url":"https://api.github.com/users/jamiehannaford/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiehannaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiehannaford/subscriptions","organizations_url":"https://api.github.com/users/jamiehannaford/orgs","repos_url":"https://api.github.com/users/jamiehannaford/repos","events_url":"https://api.github.com/users/jamiehannaford/events{/privacy}","received_events_url":"https://api.github.com/users/jamiehannaford/received_events","type":"User","site_admin":false},"body":"Relates to #1196 ","created_at":"2016-06-17T11:53:09Z","updated_at":"2016-06-21T06:06:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4872dc8120442f497a1527d371caa774c011db7","assignee":{"login":"huangyuqi","id":13324377,"avatar_url":"https://avatars.githubusercontent.com/u/13324377?v=3","gravatar_id":"","url":"https://api.github.com/users/huangyuqi","html_url":"https://github.com/huangyuqi","followers_url":"https://api.github.com/users/huangyuqi/followers","following_url":"https://api.github.com/users/huangyuqi/following{/other_user}","gists_url":"https://api.github.com/users/huangyuqi/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyuqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyuqi/subscriptions","organizations_url":"https://api.github.com/users/huangyuqi/orgs","repos_url":"https://api.github.com/users/huangyuqi/repos","events_url":"https://api.github.com/users/huangyuqi/events{/privacy}","received_events_url":"https://api.github.com/users/huangyuqi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/heapster/pulls/1198/commits","review_comments_url":"https://api.github.com/repos/kubernetes/heapster/pulls/1198/comments","review_comment_url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/heapster/issues/1198/comments","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/8487275fdd1843c83c6cdd0b6c27af522c2f38ef","head":{"label":"jamiehannaford:es-options","ref":"es-options","sha":"8487275fdd1843c83c6cdd0b6c27af522c2f38ef","user":{"login":"jamiehannaford","id":1867202,"avatar_url":"https://avatars.githubusercontent.com/u/1867202?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiehannaford","html_url":"https://github.com/jamiehannaford","followers_url":"https://api.github.com/users/jamiehannaford/followers","following_url":"https://api.github.com/users/jamiehannaford/following{/other_user}","gists_url":"https://api.github.com/users/jamiehannaford/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiehannaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiehannaford/subscriptions","organizations_url":"https://api.github.com/users/jamiehannaford/orgs","repos_url":"https://api.github.com/users/jamiehannaford/repos","events_url":"https://api.github.com/users/jamiehannaford/events{/privacy}","received_events_url":"https://api.github.com/users/jamiehannaford/received_events","type":"User","site_admin":false},"repo":{"id":61307397,"name":"heapster","full_name":"jamiehannaford/heapster","owner":{"login":"jamiehannaford","id":1867202,"avatar_url":"https://avatars.githubusercontent.com/u/1867202?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiehannaford","html_url":"https://github.com/jamiehannaford","followers_url":"https://api.github.com/users/jamiehannaford/followers","following_url":"https://api.github.com/users/jamiehannaford/following{/other_user}","gists_url":"https://api.github.com/users/jamiehannaford/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiehannaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiehannaford/subscriptions","organizations_url":"https://api.github.com/users/jamiehannaford/orgs","repos_url":"https://api.github.com/users/jamiehannaford/repos","events_url":"https://api.github.com/users/jamiehannaford/events{/privacy}","received_events_url":"https://api.github.com/users/jamiehannaford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamiehannaford/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":true,"url":"https://api.github.com/repos/jamiehannaford/heapster","forks_url":"https://api.github.com/repos/jamiehannaford/heapster/forks","keys_url":"https://api.github.com/repos/jamiehannaford/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamiehannaford/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamiehannaford/heapster/teams","hooks_url":"https://api.github.com/repos/jamiehannaford/heapster/hooks","issue_events_url":"https://api.github.com/repos/jamiehannaford/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/jamiehannaford/heapster/events","assignees_url":"https://api.github.com/repos/jamiehannaford/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/jamiehannaford/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/jamiehannaford/heapster/tags","blobs_url":"https://api.github.com/repos/jamiehannaford/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamiehannaford/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamiehannaford/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamiehannaford/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamiehannaford/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/jamiehannaford/heapster/languages","stargazers_url":"https://api.github.com/repos/jamiehannaford/heapster/stargazers","contributors_url":"https://api.github.com/repos/jamiehannaford/heapster/contributors","subscribers_url":"https://api.github.com/repos/jamiehannaford/heapster/subscribers","subscription_url":"https://api.github.com/repos/jamiehannaford/heapster/subscription","commits_url":"https://api.github.com/repos/jamiehannaford/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamiehannaford/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamiehannaford/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamiehannaford/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamiehannaford/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/jamiehannaford/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamiehannaford/heapster/merges","archive_url":"https://api.github.com/repos/jamiehannaford/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamiehannaford/heapster/downloads","issues_url":"https://api.github.com/repos/jamiehannaford/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/jamiehannaford/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/jamiehannaford/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/jamiehannaford/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamiehannaford/heapster/labels{/name}","releases_url":"https://api.github.com/repos/jamiehannaford/heapster/releases{/id}","deployments_url":"https://api.github.com/repos/jamiehannaford/heapster/deployments","created_at":"2016-06-16T16:01:58Z","updated_at":"2016-06-16T16:01:59Z","pushed_at":"2016-06-17T11:50:13Z","git_url":"git://github.com/jamiehannaford/heapster.git","ssh_url":"git@github.com:jamiehannaford/heapster.git","clone_url":"https://github.com/jamiehannaford/heapster.git","svn_url":"https://github.com/jamiehannaford/heapster","homepage":"","size":27380,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0b8ae754d5535e06a3ba187ab5f2f86dd48d33c1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":23272510,"name":"heapster","full_name":"kubernetes/heapster","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/heapster","forks_url":"https://api.github.com/repos/kubernetes/heapster/forks","keys_url":"https://api.github.com/repos/kubernetes/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/heapster/teams","hooks_url":"https://api.github.com/repos/kubernetes/heapster/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/heapster/events","assignees_url":"https://api.github.com/repos/kubernetes/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/heapster/tags","blobs_url":"https://api.github.com/repos/kubernetes/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/heapster/languages","stargazers_url":"https://api.github.com/repos/kubernetes/heapster/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/heapster/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/heapster/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/heapster/subscription","commits_url":"https://api.github.com/repos/kubernetes/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/heapster/merges","archive_url":"https://api.github.com/repos/kubernetes/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/heapster/downloads","issues_url":"https://api.github.com/repos/kubernetes/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/heapster/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/heapster/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/heapster/deployments","created_at":"2014-08-24T03:50:18Z","updated_at":"2016-06-21T01:35:05Z","pushed_at":"2016-06-20T14:44:25Z","git_url":"git://github.com/kubernetes/heapster.git","ssh_url":"git@github.com:kubernetes/heapster.git","clone_url":"https://github.com/kubernetes/heapster.git","svn_url":"https://github.com/kubernetes/heapster","homepage":"","size":28917,"stargazers_count":686,"watchers_count":686,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"open_issues_count":124,"forks":229,"open_issues":124,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1198"},"html":{"href":"https://github.com/kubernetes/heapster/pull/1198"},"issue":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/1198"},"comments":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/1198/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1198/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1198/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/heapster/statuses/8487275fdd1843c83c6cdd0b6c27af522c2f38ef"}}}}
{"actor":{"display_login":"huangyuqi"}}