{"action":"created","issue":{"url":"https://api.github.com/repos/scot-dev/scot/issues/195","repository_url":"https://api.github.com/repos/scot-dev/scot","labels_url":"https://api.github.com/repos/scot-dev/scot/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/scot-dev/scot/issues/195/comments","events_url":"https://api.github.com/repos/scot-dev/scot/issues/195/events","html_url":"https://github.com/scot-dev/scot/issues/195","id":194024086,"number":195,"title":"Synchronize p and coefficients","user":{"login":"cbrnr","id":4377312,"avatar_url":"https://avatars.githubusercontent.com/u/4377312?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrnr","html_url":"https://github.com/cbrnr","followers_url":"https://api.github.com/users/cbrnr/followers","following_url":"https://api.github.com/users/cbrnr/following{/other_user}","gists_url":"https://api.github.com/users/cbrnr/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrnr/subscriptions","organizations_url":"https://api.github.com/users/cbrnr/orgs","repos_url":"https://api.github.com/users/cbrnr/repos","events_url":"https://api.github.com/users/cbrnr/events{/privacy}","received_events_url":"https://api.github.com/users/cbrnr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-07T11:23:51Z","updated_at":"2016-12-09T18:22:11Z","closed_at":null,"body":"As discussed in #177, we should synchronize `p` and the coefficient matrices. Currently, the user can set `p` and `coef` independently, and since `p` is implicitly defined by the shape of `coef`, these two variables can get out of sync."},"comment":{"url":"https://api.github.com/repos/scot-dev/scot/issues/comments/266084323","html_url":"https://github.com/scot-dev/scot/issues/195#issuecomment-266084323","issue_url":"https://api.github.com/repos/scot-dev/scot/issues/195","id":266084323,"user":{"login":"mbillingr","id":2392396,"avatar_url":"https://avatars.githubusercontent.com/u/2392396?v=3","gravatar_id":"","url":"https://api.github.com/users/mbillingr","html_url":"https://github.com/mbillingr","followers_url":"https://api.github.com/users/mbillingr/followers","following_url":"https://api.github.com/users/mbillingr/following{/other_user}","gists_url":"https://api.github.com/users/mbillingr/gists{/gist_id}","starred_url":"https://api.github.com/users/mbillingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbillingr/subscriptions","organizations_url":"https://api.github.com/users/mbillingr/orgs","repos_url":"https://api.github.com/users/mbillingr/repos","events_url":"https://api.github.com/users/mbillingr/events{/privacy}","received_events_url":"https://api.github.com/users/mbillingr/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T18:22:11Z","updated_at":"2016-12-09T18:22:11Z","body":"I guess it's best if we make `p` a property that reads its value from the shape of `coef`.\r\n\r\nThis leaves the question open how to deal with fitting, where we do not have coefficients yet but need to know the model order to obtain the coefficients. An option could be to initialize the model order to a shape of `(0, 0, p)` or `(p, 0, 0)`. I'm not sure if this is a nice approach. An alternative could use a private attribute such as `_p` that contains the desired model order when no coefficients are available."}}
{"actor":{"display_login":"mbillingr"}}