{"action":"created","issue":{"url":"https://api.github.com/repos/webslim/bsc-thesis-impl/issues/1","repository_url":"https://api.github.com/repos/webslim/bsc-thesis-impl","labels_url":"https://api.github.com/repos/webslim/bsc-thesis-impl/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/webslim/bsc-thesis-impl/issues/1/comments","events_url":"https://api.github.com/repos/webslim/bsc-thesis-impl/issues/1/events","html_url":"https://github.com/webslim/bsc-thesis-impl/pull/1","id":162859710,"number":1,"title":"Make all ArrayAccess operators virtual (fails compilation)","user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-29T07:36:02Z","updated_at":"2016-06-29T12:01:01Z","closed_at":"2016-06-29T10:19:54Z","pull_request":{"url":"https://api.github.com/repos/webslim/bsc-thesis-impl/pulls/1","html_url":"https://github.com/webslim/bsc-thesis-impl/pull/1","diff_url":"https://github.com/webslim/bsc-thesis-impl/pull/1.diff","patch_url":"https://github.com/webslim/bsc-thesis-impl/pull/1.patch"},"body":"This omission gave incorrect benchmark results *and* incorrect actual\r\nresults. Not having tests *inside* the benchmark sounds like a bad idea.\r\n\r\nHowever, this doesn't compile as-is, because we try refining the return\r\ntype of the virtual function. I think this can be expressed, but it's\r\nmore complicated.\r\n\r\n```\r\n./src/functions/../array_class.h:33:21: error: virtual function 'operator+' has a different return type ('StridedArrayAccess') than the function it overrides\r\n      (which has return type 'ArrayAccess')\r\n        StridedArrayAccess operator+(int offset) {\r\n        ~~~~~~~~~~~~~~~~~~ ^\r\n./src/functions/../array_class.h:17:22: note: overridden virtual function is here\r\n        virtual ArrayAccess operator+(int offset) {\r\n                ~~~~~~~~~~~ ^\r\n./src/functions/../array_class.h:49:26: error: virtual function 'operator+' has a different return type ('BlockStridedArrayAccess') than the function it overrides\r\n      (which has return type 'StridedArrayAccess')\r\n        BlockStridedArrayAccess operator+(int offset) {\r\n        ~~~~~~~~~~~~~~~~~~~~~~~ ^\r\n./src/functions/../array_class.h:33:21: note: overridden virtual function is here\r\n        StridedArrayAccess operator+(int offset) {\r\n        ~~~~~~~~~~~~~~~~~~ ^\r\n```"},"comment":{"url":"https://api.github.com/repos/webslim/bsc-thesis-impl/issues/comments/229335761","html_url":"https://github.com/webslim/bsc-thesis-impl/pull/1#issuecomment-229335761","issue_url":"https://api.github.com/repos/webslim/bsc-thesis-impl/issues/1","id":229335761,"user":{"login":"Blaisorblade","id":289960,"avatar_url":"https://avatars.githubusercontent.com/u/289960?v=3","gravatar_id":"","url":"https://api.github.com/users/Blaisorblade","html_url":"https://github.com/Blaisorblade","followers_url":"https://api.github.com/users/Blaisorblade/followers","following_url":"https://api.github.com/users/Blaisorblade/following{/other_user}","gists_url":"https://api.github.com/users/Blaisorblade/gists{/gist_id}","starred_url":"https://api.github.com/users/Blaisorblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blaisorblade/subscriptions","organizations_url":"https://api.github.com/users/Blaisorblade/orgs","repos_url":"https://api.github.com/users/Blaisorblade/repos","events_url":"https://api.github.com/users/Blaisorblade/events{/privacy}","received_events_url":"https://api.github.com/users/Blaisorblade/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T12:01:01Z","updated_at":"2016-06-29T12:01:01Z","body":"> Thanks, I will update the data.\r\n\r\nPlease don't, because of the bug in https://github.com/webslim/bsc-thesis-impl/commit/c5fa909a3a497998cd2ce45266203b7c45c39fe4#commitcomment-18059545."}}
{"actor":{"display_login":"Blaisorblade"}}