{"action":"closed","number":1711,"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/1711","id":96410863,"html_url":"https://github.com/FAForever/fa/pull/1711","diff_url":"https://github.com/FAForever/fa/pull/1711.diff","patch_url":"https://github.com/FAForever/fa/pull/1711.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/1711","number":1711,"state":"closed","locked":false,"title":"Attempt to address 'ghost' reclaim labels: #1628","user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"body":"This is a first attempt to follow the reclaim logic view through and try to identify the fault. I believe I identified one potential vulnerability: When a prop was destroyed, if it happened such that self.MaxMassReclaim had already been cleaned up, it would return nil and skip the creation of the data block to be synced, leading to the label never being called for destruction.","created_at":"2016-12-03T21:12:35Z","updated_at":"2016-12-03T21:56:35Z","closed_at":"2016-12-03T21:56:35Z","merged_at":"2016-12-03T21:56:35Z","merge_commit_sha":"2fb292c26e66344ce2693064df554b496a94fe39","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/1711/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/2fb292c26e66344ce2693064df554b496a94fe39","head":{"label":"aeoncleanse:fix/ghostReclaim","ref":"fix/ghostReclaim","sha":"2fb292c26e66344ce2693064df554b496a94fe39","user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"repo":{"id":25368939,"name":"fa","full_name":"aeoncleanse/fa","owner":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeoncleanse/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/aeoncleanse/fa","forks_url":"https://api.github.com/repos/aeoncleanse/fa/forks","keys_url":"https://api.github.com/repos/aeoncleanse/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeoncleanse/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeoncleanse/fa/teams","hooks_url":"https://api.github.com/repos/aeoncleanse/fa/hooks","issue_events_url":"https://api.github.com/repos/aeoncleanse/fa/issues/events{/number}","events_url":"https://api.github.com/repos/aeoncleanse/fa/events","assignees_url":"https://api.github.com/repos/aeoncleanse/fa/assignees{/user}","branches_url":"https://api.github.com/repos/aeoncleanse/fa/branches{/branch}","tags_url":"https://api.github.com/repos/aeoncleanse/fa/tags","blobs_url":"https://api.github.com/repos/aeoncleanse/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeoncleanse/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeoncleanse/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeoncleanse/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeoncleanse/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/aeoncleanse/fa/languages","stargazers_url":"https://api.github.com/repos/aeoncleanse/fa/stargazers","contributors_url":"https://api.github.com/repos/aeoncleanse/fa/contributors","subscribers_url":"https://api.github.com/repos/aeoncleanse/fa/subscribers","subscription_url":"https://api.github.com/repos/aeoncleanse/fa/subscription","commits_url":"https://api.github.com/repos/aeoncleanse/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeoncleanse/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeoncleanse/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeoncleanse/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeoncleanse/fa/contents/{+path}","compare_url":"https://api.github.com/repos/aeoncleanse/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeoncleanse/fa/merges","archive_url":"https://api.github.com/repos/aeoncleanse/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeoncleanse/fa/downloads","issues_url":"https://api.github.com/repos/aeoncleanse/fa/issues{/number}","pulls_url":"https://api.github.com/repos/aeoncleanse/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/aeoncleanse/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/aeoncleanse/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeoncleanse/fa/labels{/name}","releases_url":"https://api.github.com/repos/aeoncleanse/fa/releases{/id}","deployments_url":"https://api.github.com/repos/aeoncleanse/fa/deployments","created_at":"2014-10-17T17:21:41Z","updated_at":"2016-05-02T15:19:05Z","pushed_at":"2016-12-03T21:39:38Z","git_url":"git://github.com/aeoncleanse/fa.git","ssh_url":"git@github.com:aeoncleanse/fa.git","clone_url":"https://github.com/aeoncleanse/fa.git","svn_url":"https://github.com/aeoncleanse/fa","homepage":"","size":114958,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:deploy/fafdevelop","ref":"deploy/fafdevelop","sha":"9b04ee33d8b5d5866d710e57c770222ee98f2c14","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","deployments_url":"https://api.github.com/repos/FAForever/fa/deployments","created_at":"2014-09-24T06:34:12Z","updated_at":"2016-11-13T13:21:37Z","pushed_at":"2016-12-03T21:56:35Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":131038,"stargazers_count":40,"watchers_count":40,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":206,"forks":61,"open_issues":206,"watchers":40,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1711"},"html":{"href":"https://github.com/FAForever/fa/pull/1711"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/1711"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/2fb292c26e66344ce2693064df554b496a94fe39"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":27,"deletions":16,"changed_files":3}}
{"actor":{"display_login":"aeoncleanse"}}