{"action":"created","comment":{"url":"https://api.github.com/repos/MariaDB/server/pulls/comments/52770009","id":52770009,"diff_hunk":"@@ -20,11 +20,21 @@ MACRO (CHECK_JEMALLOC)\n       SET(CMAKE_REQUIRED_LIBRARIES pthread dl m)\n       SET(what bundled)\n     ELSE()\n-      SET(libname jemalloc)\n+      IF(CMAKE_SYSTEM_NAME STREQUAL \"FreeBSD\" AND\n+        CMAKE_SYSTEM_VERSION STRGREATER \"10.0\")\n+        SET(libname c)\n+      ELSE()\n+        SET(libname jemalloc)\n+      ENDIF()\n       SET(what system)\n     ENDIF()\n \n-    CHECK_LIBRARY_EXISTS(${libname} malloc_stats_print \"\" HAVE_JEMALLOC)\n+    IF(CMAKE_SYSTEM_NAME STREQUAL \"FreeBSD\" AND\n+      CMAKE_SYSTEM_VERSION STRGREATER \"10.0\")\n+      SET(HAVE_JEMALLOC ON)\n+    ELSE()\n+      CHECK_LIBRARY_EXISTS(${libname} malloc_stats_print \"\" HAVE_JEMALLOC)\n+    ENDIF()","path":"cmake/jemalloc.cmake","position":20,"original_position":20,"commit_id":"0cc3825eab2c24eda101c992d32d89d7e43aaad3","original_commit_id":"0cc3825eab2c24eda101c992d32d89d7e43aaad3","user":{"login":"vuvova","id":2737648,"avatar_url":"https://avatars.githubusercontent.com/u/2737648?v=3","gravatar_id":"","url":"https://api.github.com/users/vuvova","html_url":"https://github.com/vuvova","followers_url":"https://api.github.com/users/vuvova/followers","following_url":"https://api.github.com/users/vuvova/following{/other_user}","gists_url":"https://api.github.com/users/vuvova/gists{/gist_id}","starred_url":"https://api.github.com/users/vuvova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuvova/subscriptions","organizations_url":"https://api.github.com/users/vuvova/orgs","repos_url":"https://api.github.com/users/vuvova/repos","events_url":"https://api.github.com/users/vuvova/events{/privacy}","received_events_url":"https://api.github.com/users/vuvova/received_events","type":"User","site_admin":false},"body":"Why is that? What problem did poudriere had with the old code?","created_at":"2016-02-12T17:17:26Z","updated_at":"2016-02-12T17:17:26Z","html_url":"https://github.com/MariaDB/server/pull/139#discussion_r52770009","pull_request_url":"https://api.github.com/repos/MariaDB/server/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments/52770009"},"html":{"href":"https://github.com/MariaDB/server/pull/139#discussion_r52770009"},"pull_request":{"href":"https://api.github.com/repos/MariaDB/server/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/MariaDB/server/pulls/139","id":54891565,"html_url":"https://github.com/MariaDB/server/pull/139","diff_url":"https://github.com/MariaDB/server/pull/139.diff","patch_url":"https://github.com/MariaDB/server/pull/139.patch","issue_url":"https://api.github.com/repos/MariaDB/server/issues/139","number":139,"state":"open","locked":false,"title":"MDEV-9350 - 10.0 Fix jemalloc detection for FreeBSD","user":{"login":"Sp1l","id":7547697,"avatar_url":"https://avatars.githubusercontent.com/u/7547697?v=3","gravatar_id":"","url":"https://api.github.com/users/Sp1l","html_url":"https://github.com/Sp1l","followers_url":"https://api.github.com/users/Sp1l/followers","following_url":"https://api.github.com/users/Sp1l/following{/other_user}","gists_url":"https://api.github.com/users/Sp1l/gists{/gist_id}","starred_url":"https://api.github.com/users/Sp1l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sp1l/subscriptions","organizations_url":"https://api.github.com/users/Sp1l/orgs","repos_url":"https://api.github.com/users/Sp1l/repos","events_url":"https://api.github.com/users/Sp1l/events{/privacy}","received_events_url":"https://api.github.com/users/Sp1l/received_events","type":"User","site_admin":false},"body":"As of FreeBSD 10.0 (1000012 https://svnweb.freebsd.org/changeset/base/234924) FreeBSD has jemalloc in base.","created_at":"2016-01-01T13:57:06Z","updated_at":"2016-02-12T17:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a29f1a53afc8db41e8ec03dface3b8e7955d797","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MariaDB/server/pulls/139/commits","review_comments_url":"https://api.github.com/repos/MariaDB/server/pulls/139/comments","review_comment_url":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MariaDB/server/issues/139/comments","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/0cc3825eab2c24eda101c992d32d89d7e43aaad3","head":{"label":"Sp1l:FreeBSD-jemalloc","ref":"FreeBSD-jemalloc","sha":"0cc3825eab2c24eda101c992d32d89d7e43aaad3","user":{"login":"Sp1l","id":7547697,"avatar_url":"https://avatars.githubusercontent.com/u/7547697?v=3","gravatar_id":"","url":"https://api.github.com/users/Sp1l","html_url":"https://github.com/Sp1l","followers_url":"https://api.github.com/users/Sp1l/followers","following_url":"https://api.github.com/users/Sp1l/following{/other_user}","gists_url":"https://api.github.com/users/Sp1l/gists{/gist_id}","starred_url":"https://api.github.com/users/Sp1l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sp1l/subscriptions","organizations_url":"https://api.github.com/users/Sp1l/orgs","repos_url":"https://api.github.com/users/Sp1l/repos","events_url":"https://api.github.com/users/Sp1l/events{/privacy}","received_events_url":"https://api.github.com/users/Sp1l/received_events","type":"User","site_admin":false},"repo":{"id":48879247,"name":"mariadb-server","full_name":"Sp1l/mariadb-server","owner":{"login":"Sp1l","id":7547697,"avatar_url":"https://avatars.githubusercontent.com/u/7547697?v=3","gravatar_id":"","url":"https://api.github.com/users/Sp1l","html_url":"https://github.com/Sp1l","followers_url":"https://api.github.com/users/Sp1l/followers","following_url":"https://api.github.com/users/Sp1l/following{/other_user}","gists_url":"https://api.github.com/users/Sp1l/gists{/gist_id}","starred_url":"https://api.github.com/users/Sp1l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sp1l/subscriptions","organizations_url":"https://api.github.com/users/Sp1l/orgs","repos_url":"https://api.github.com/users/Sp1l/repos","events_url":"https://api.github.com/users/Sp1l/events{/privacy}","received_events_url":"https://api.github.com/users/Sp1l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sp1l/mariadb-server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":true,"url":"https://api.github.com/repos/Sp1l/mariadb-server","forks_url":"https://api.github.com/repos/Sp1l/mariadb-server/forks","keys_url":"https://api.github.com/repos/Sp1l/mariadb-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sp1l/mariadb-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sp1l/mariadb-server/teams","hooks_url":"https://api.github.com/repos/Sp1l/mariadb-server/hooks","issue_events_url":"https://api.github.com/repos/Sp1l/mariadb-server/issues/events{/number}","events_url":"https://api.github.com/repos/Sp1l/mariadb-server/events","assignees_url":"https://api.github.com/repos/Sp1l/mariadb-server/assignees{/user}","branches_url":"https://api.github.com/repos/Sp1l/mariadb-server/branches{/branch}","tags_url":"https://api.github.com/repos/Sp1l/mariadb-server/tags","blobs_url":"https://api.github.com/repos/Sp1l/mariadb-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sp1l/mariadb-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sp1l/mariadb-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sp1l/mariadb-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sp1l/mariadb-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Sp1l/mariadb-server/languages","stargazers_url":"https://api.github.com/repos/Sp1l/mariadb-server/stargazers","contributors_url":"https://api.github.com/repos/Sp1l/mariadb-server/contributors","subscribers_url":"https://api.github.com/repos/Sp1l/mariadb-server/subscribers","subscription_url":"https://api.github.com/repos/Sp1l/mariadb-server/subscription","commits_url":"https://api.github.com/repos/Sp1l/mariadb-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sp1l/mariadb-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sp1l/mariadb-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sp1l/mariadb-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sp1l/mariadb-server/contents/{+path}","compare_url":"https://api.github.com/repos/Sp1l/mariadb-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sp1l/mariadb-server/merges","archive_url":"https://api.github.com/repos/Sp1l/mariadb-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sp1l/mariadb-server/downloads","issues_url":"https://api.github.com/repos/Sp1l/mariadb-server/issues{/number}","pulls_url":"https://api.github.com/repos/Sp1l/mariadb-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Sp1l/mariadb-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Sp1l/mariadb-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sp1l/mariadb-server/labels{/name}","releases_url":"https://api.github.com/repos/Sp1l/mariadb-server/releases{/id}","deployments_url":"https://api.github.com/repos/Sp1l/mariadb-server/deployments","created_at":"2016-01-01T13:51:00Z","updated_at":"2016-01-01T13:52:54Z","pushed_at":"2016-01-03T17:15:09Z","git_url":"git://github.com/Sp1l/mariadb-server.git","ssh_url":"git@github.com:Sp1l/mariadb-server.git","clone_url":"https://github.com/Sp1l/mariadb-server.git","svn_url":"https://github.com/Sp1l/mariadb-server","homepage":"","size":381904,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"10.1"}},"base":{"label":"MariaDB:10.0","ref":"10.0","sha":"ae7b39a13a312d9787a4895874f641e2dfe3adca","user":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"repo":{"id":19816070,"name":"server","full_name":"MariaDB/server","owner":{"login":"MariaDB","id":4739304,"avatar_url":"https://avatars.githubusercontent.com/u/4739304?v=3","gravatar_id":"","url":"https://api.github.com/users/MariaDB","html_url":"https://github.com/MariaDB","followers_url":"https://api.github.com/users/MariaDB/followers","following_url":"https://api.github.com/users/MariaDB/following{/other_user}","gists_url":"https://api.github.com/users/MariaDB/gists{/gist_id}","starred_url":"https://api.github.com/users/MariaDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariaDB/subscriptions","organizations_url":"https://api.github.com/users/MariaDB/orgs","repos_url":"https://api.github.com/users/MariaDB/repos","events_url":"https://api.github.com/users/MariaDB/events{/privacy}","received_events_url":"https://api.github.com/users/MariaDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MariaDB/server","description":"MariaDB server is a community developed fork of MySQL server. Started by core members of the original MySQL team, MariaDB actively works with outside developers to deliver the most featureful, stable, and sanely licensed open SQL server in the industry.","fork":false,"url":"https://api.github.com/repos/MariaDB/server","forks_url":"https://api.github.com/repos/MariaDB/server/forks","keys_url":"https://api.github.com/repos/MariaDB/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MariaDB/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MariaDB/server/teams","hooks_url":"https://api.github.com/repos/MariaDB/server/hooks","issue_events_url":"https://api.github.com/repos/MariaDB/server/issues/events{/number}","events_url":"https://api.github.com/repos/MariaDB/server/events","assignees_url":"https://api.github.com/repos/MariaDB/server/assignees{/user}","branches_url":"https://api.github.com/repos/MariaDB/server/branches{/branch}","tags_url":"https://api.github.com/repos/MariaDB/server/tags","blobs_url":"https://api.github.com/repos/MariaDB/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MariaDB/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MariaDB/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/MariaDB/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MariaDB/server/statuses/{sha}","languages_url":"https://api.github.com/repos/MariaDB/server/languages","stargazers_url":"https://api.github.com/repos/MariaDB/server/stargazers","contributors_url":"https://api.github.com/repos/MariaDB/server/contributors","subscribers_url":"https://api.github.com/repos/MariaDB/server/subscribers","subscription_url":"https://api.github.com/repos/MariaDB/server/subscription","commits_url":"https://api.github.com/repos/MariaDB/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/MariaDB/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/MariaDB/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/MariaDB/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/MariaDB/server/contents/{+path}","compare_url":"https://api.github.com/repos/MariaDB/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MariaDB/server/merges","archive_url":"https://api.github.com/repos/MariaDB/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MariaDB/server/downloads","issues_url":"https://api.github.com/repos/MariaDB/server/issues{/number}","pulls_url":"https://api.github.com/repos/MariaDB/server/pulls{/number}","milestones_url":"https://api.github.com/repos/MariaDB/server/milestones{/number}","notifications_url":"https://api.github.com/repos/MariaDB/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MariaDB/server/labels{/name}","releases_url":"https://api.github.com/repos/MariaDB/server/releases{/id}","deployments_url":"https://api.github.com/repos/MariaDB/server/deployments","created_at":"2014-05-15T10:58:50Z","updated_at":"2016-02-12T15:09:52Z","pushed_at":"2016-02-12T16:46:51Z","git_url":"git://github.com/MariaDB/server.git","ssh_url":"git@github.com:MariaDB/server.git","clone_url":"https://github.com/MariaDB/server.git","svn_url":"https://github.com/MariaDB/server","homepage":"","size":882829,"stargazers_count":711,"watchers_count":711,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":214,"mirror_url":null,"open_issues_count":27,"forks":214,"open_issues":27,"watchers":711,"default_branch":"10.1"}},"_links":{"self":{"href":"https://api.github.com/repos/MariaDB/server/pulls/139"},"html":{"href":"https://github.com/MariaDB/server/pull/139"},"issue":{"href":"https://api.github.com/repos/MariaDB/server/issues/139"},"comments":{"href":"https://api.github.com/repos/MariaDB/server/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/MariaDB/server/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/MariaDB/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MariaDB/server/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/MariaDB/server/statuses/0cc3825eab2c24eda101c992d32d89d7e43aaad3"}}}}