{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/comments/56837993","id":56837993,"diff_hunk":"@@ -1458,6 +1485,9 @@ main (int argc,\n   /* We want sigchild in the child */\n   unblock_sigchild ();\n \n+  if (label_exec(opt_exec_label) == -1)","path":"bubblewrap.c","position":68,"original_position":63,"commit_id":"b67d852f888c4da4ed90eca4c859e6486b8939b1","original_commit_id":"4536d4505daf4576e3262af8bded4e42bd0e269e","user":{"login":"alexlarsson","id":990736,"avatar_url":"https://avatars.githubusercontent.com/u/990736?v=3","gravatar_id":"","url":"https://api.github.com/users/alexlarsson","html_url":"https://github.com/alexlarsson","followers_url":"https://api.github.com/users/alexlarsson/followers","following_url":"https://api.github.com/users/alexlarsson/following{/other_user}","gists_url":"https://api.github.com/users/alexlarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexlarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexlarsson/subscriptions","organizations_url":"https://api.github.com/users/alexlarsson/orgs","repos_url":"https://api.github.com/users/alexlarsson/repos","events_url":"https://api.github.com/users/alexlarsson/events{/privacy}","received_events_url":"https://api.github.com/users/alexlarsson/received_events","type":"User","site_admin":false},"body":"missing space","created_at":"2016-03-21T15:10:02Z","updated_at":"2016-03-21T15:10:02Z","html_url":"https://github.com/projectatomic/bubblewrap/pull/25#discussion_r56837993","pull_request_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/comments/56837993"},"html":{"href":"https://github.com/projectatomic/bubblewrap/pull/25#discussion_r56837993"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25","id":63304492,"html_url":"https://github.com/projectatomic/bubblewrap/pull/25","diff_url":"https://github.com/projectatomic/bubblewrap/pull/25.diff","patch_url":"https://github.com/projectatomic/bubblewrap/pull/25.patch","issue_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/25","number":25,"state":"open","locked":false,"title":"Add SELinux Support","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"body":"Still needs work, but it basically adds SELinux labeling support. \r\nPTAL\r\n\r\nNeed to work on policy to make this work, with NO_NEW_PRIVS\r\n\r\n--exec-label unconfined_u:unconfined_r:unconfined_t:s0:c1,c2 --file-label unconfined_u:object_r:sandbox_file_t:s0:c1.c2\r\n\r\nSeems to work.  The look at how stuff is labeled inside of the container \r\n\r\nMainly make sure /dev and any directories you specify with --dir are labeled correctly.","created_at":"2016-03-17T22:46:14Z","updated_at":"2016-03-21T15:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31a6c35fe9a205b458d25887a43cd79744e41a26","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25/commits","review_comments_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25/comments","review_comment_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/25/comments","statuses_url":"https://api.github.com/repos/projectatomic/bubblewrap/statuses/b67d852f888c4da4ed90eca4c859e6486b8939b1","head":{"label":"rhatdan:master","ref":"master","sha":"b67d852f888c4da4ed90eca4c859e6486b8939b1","user":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"repo":{"id":54154502,"name":"bubblewrap","full_name":"rhatdan/bubblewrap","owner":{"login":"rhatdan","id":2000835,"avatar_url":"https://avatars.githubusercontent.com/u/2000835?v=3","gravatar_id":"","url":"https://api.github.com/users/rhatdan","html_url":"https://github.com/rhatdan","followers_url":"https://api.github.com/users/rhatdan/followers","following_url":"https://api.github.com/users/rhatdan/following{/other_user}","gists_url":"https://api.github.com/users/rhatdan/gists{/gist_id}","starred_url":"https://api.github.com/users/rhatdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhatdan/subscriptions","organizations_url":"https://api.github.com/users/rhatdan/orgs","repos_url":"https://api.github.com/users/rhatdan/repos","events_url":"https://api.github.com/users/rhatdan/events{/privacy}","received_events_url":"https://api.github.com/users/rhatdan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhatdan/bubblewrap","description":"","fork":true,"url":"https://api.github.com/repos/rhatdan/bubblewrap","forks_url":"https://api.github.com/repos/rhatdan/bubblewrap/forks","keys_url":"https://api.github.com/repos/rhatdan/bubblewrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhatdan/bubblewrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhatdan/bubblewrap/teams","hooks_url":"https://api.github.com/repos/rhatdan/bubblewrap/hooks","issue_events_url":"https://api.github.com/repos/rhatdan/bubblewrap/issues/events{/number}","events_url":"https://api.github.com/repos/rhatdan/bubblewrap/events","assignees_url":"https://api.github.com/repos/rhatdan/bubblewrap/assignees{/user}","branches_url":"https://api.github.com/repos/rhatdan/bubblewrap/branches{/branch}","tags_url":"https://api.github.com/repos/rhatdan/bubblewrap/tags","blobs_url":"https://api.github.com/repos/rhatdan/bubblewrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhatdan/bubblewrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhatdan/bubblewrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhatdan/bubblewrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhatdan/bubblewrap/statuses/{sha}","languages_url":"https://api.github.com/repos/rhatdan/bubblewrap/languages","stargazers_url":"https://api.github.com/repos/rhatdan/bubblewrap/stargazers","contributors_url":"https://api.github.com/repos/rhatdan/bubblewrap/contributors","subscribers_url":"https://api.github.com/repos/rhatdan/bubblewrap/subscribers","subscription_url":"https://api.github.com/repos/rhatdan/bubblewrap/subscription","commits_url":"https://api.github.com/repos/rhatdan/bubblewrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhatdan/bubblewrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhatdan/bubblewrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhatdan/bubblewrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhatdan/bubblewrap/contents/{+path}","compare_url":"https://api.github.com/repos/rhatdan/bubblewrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhatdan/bubblewrap/merges","archive_url":"https://api.github.com/repos/rhatdan/bubblewrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhatdan/bubblewrap/downloads","issues_url":"https://api.github.com/repos/rhatdan/bubblewrap/issues{/number}","pulls_url":"https://api.github.com/repos/rhatdan/bubblewrap/pulls{/number}","milestones_url":"https://api.github.com/repos/rhatdan/bubblewrap/milestones{/number}","notifications_url":"https://api.github.com/repos/rhatdan/bubblewrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhatdan/bubblewrap/labels{/name}","releases_url":"https://api.github.com/repos/rhatdan/bubblewrap/releases{/id}","deployments_url":"https://api.github.com/repos/rhatdan/bubblewrap/deployments","created_at":"2016-03-17T22:04:30Z","updated_at":"2016-03-17T22:04:31Z","pushed_at":"2016-03-18T13:09:12Z","git_url":"git://github.com/rhatdan/bubblewrap.git","ssh_url":"git@github.com:rhatdan/bubblewrap.git","clone_url":"https://github.com/rhatdan/bubblewrap.git","svn_url":"https://github.com/rhatdan/bubblewrap","homepage":null,"size":149,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"aedbc794d5cc3f5c479c7307054a761f388d2941","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":51868010,"name":"bubblewrap","full_name":"projectatomic/bubblewrap","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/bubblewrap","description":"","fork":false,"url":"https://api.github.com/repos/projectatomic/bubblewrap","forks_url":"https://api.github.com/repos/projectatomic/bubblewrap/forks","keys_url":"https://api.github.com/repos/projectatomic/bubblewrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/bubblewrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/bubblewrap/teams","hooks_url":"https://api.github.com/repos/projectatomic/bubblewrap/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/bubblewrap/events","assignees_url":"https://api.github.com/repos/projectatomic/bubblewrap/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/bubblewrap/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/bubblewrap/tags","blobs_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/bubblewrap/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/bubblewrap/languages","stargazers_url":"https://api.github.com/repos/projectatomic/bubblewrap/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/bubblewrap/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/bubblewrap/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/bubblewrap/subscription","commits_url":"https://api.github.com/repos/projectatomic/bubblewrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/bubblewrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/bubblewrap/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/bubblewrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/bubblewrap/merges","archive_url":"https://api.github.com/repos/projectatomic/bubblewrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/bubblewrap/downloads","issues_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/bubblewrap/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/bubblewrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/bubblewrap/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/bubblewrap/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/bubblewrap/deployments","created_at":"2016-02-16T20:36:10Z","updated_at":"2016-03-18T18:25:12Z","pushed_at":"2016-03-18T13:09:12Z","git_url":"git://github.com/projectatomic/bubblewrap.git","ssh_url":"git@github.com:projectatomic/bubblewrap.git","clone_url":"https://github.com/projectatomic/bubblewrap.git","svn_url":"https://github.com/projectatomic/bubblewrap","homepage":null,"size":168,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":8,"forks":6,"open_issues":8,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25"},"html":{"href":"https://github.com/projectatomic/bubblewrap/pull/25"},"issue":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/issues/25"},"comments":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/statuses/b67d852f888c4da4ed90eca4c859e6486b8939b1"}}}}