{"action":"created","issue":{"url":"https://api.github.com/repos/gburton/Responsive-osCommerce/issues/375","repository_url":"https://api.github.com/repos/gburton/Responsive-osCommerce","labels_url":"https://api.github.com/repos/gburton/Responsive-osCommerce/issues/375/labels{/name}","comments_url":"https://api.github.com/repos/gburton/Responsive-osCommerce/issues/375/comments","events_url":"https://api.github.com/repos/gburton/Responsive-osCommerce/issues/375/events","html_url":"https://github.com/gburton/Responsive-osCommerce/issues/375","id":154881490,"number":375,"title":"Obsolete new_products module in \\includes\\modules\\","user":{"login":"Moxamint","id":11028615,"avatar_url":"https://avatars.githubusercontent.com/u/11028615?v=3","gravatar_id":"","url":"https://api.github.com/users/Moxamint","html_url":"https://github.com/Moxamint","followers_url":"https://api.github.com/users/Moxamint/followers","following_url":"https://api.github.com/users/Moxamint/following{/other_user}","gists_url":"https://api.github.com/users/Moxamint/gists{/gist_id}","starred_url":"https://api.github.com/users/Moxamint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moxamint/subscriptions","organizations_url":"https://api.github.com/users/Moxamint/orgs","repos_url":"https://api.github.com/users/Moxamint/repos","events_url":"https://api.github.com/users/Moxamint/events{/privacy}","received_events_url":"https://api.github.com/users/Moxamint/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-14T23:46:08Z","updated_at":"2016-05-15T07:17:21Z","closed_at":null,"body":"Now we have a new content module 'new_products' in <<\\includes\\modules\\content\\index>> for index page.  Shouldn't we delete file <<\\includes\\modules\\new_products.php>> and remove its reference in <<\\index.php>>?\r\n\r\nThe following line of code in <<\\index.php>>, line 104, throws an error when browsing to sub-category:\r\n\r\n  `<?php include(DIR_WS_MODULES . FILENAME_NEW_PRODUCTS); ?>`\r\n\r\nError message:\r\n\r\n  `1327 - Undeclared variable: MAX_DISPLAY_NEW_PRODUCTS`\r\n\r\nwhere the named variable I believe has been removed from configuration values of the latest repo.  Also, maybe <<\\includes\\modules\\upcoming_products.php>> should be dealt with as well?  Although I don't see it causing any issues yet."},"comment":{"url":"https://api.github.com/repos/gburton/Responsive-osCommerce/issues/comments/219270512","html_url":"https://github.com/gburton/Responsive-osCommerce/issues/375#issuecomment-219270512","issue_url":"https://api.github.com/repos/gburton/Responsive-osCommerce/issues/375","id":219270512,"user":{"login":"Moxamint","id":11028615,"avatar_url":"https://avatars.githubusercontent.com/u/11028615?v=3","gravatar_id":"","url":"https://api.github.com/users/Moxamint","html_url":"https://github.com/Moxamint","followers_url":"https://api.github.com/users/Moxamint/followers","following_url":"https://api.github.com/users/Moxamint/following{/other_user}","gists_url":"https://api.github.com/users/Moxamint/gists{/gist_id}","starred_url":"https://api.github.com/users/Moxamint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Moxamint/subscriptions","organizations_url":"https://api.github.com/users/Moxamint/orgs","repos_url":"https://api.github.com/users/Moxamint/repos","events_url":"https://api.github.com/users/Moxamint/events{/privacy}","received_events_url":"https://api.github.com/users/Moxamint/received_events","type":"User","site_admin":false},"created_at":"2016-05-15T07:17:21Z","updated_at":"2016-05-15T07:17:21Z","body":"You don't get the error if you have MAX_DISPLAY_NEW_PRODUCTS left over in your configuration data table.  Please do a search for MAX_DISPLAY_NEW_PRODUCTS in <<\\install\\oscommerce.sql>> from the latest repo and you'll see what I mean."}}