{"action":"created","comment":{"url":"https://api.github.com/repos/xing/pdf_cover/pulls/comments/54739132","id":54739132,"diff_hunk":"@@ -4,9 +4,7 @@ require \"rubocop/rake_task\"\n \n ENV[\"RAILS_ENV\"] ||= \"test\"\n \n-RSpec::Core::RakeTask.new(:spec).tap do |rspec_task|\n-  rspec_task.rspec_opts = \"--fail-fast\"\n-end\n+RSpec::Core::RakeTask.new(:spec)","path":"Rakefile","position":7,"original_position":7,"commit_id":"e3c82cd7f0d1b4a96c52308486a832a6b1fdb0f9","original_commit_id":"e3c82cd7f0d1b4a96c52308486a832a6b1fdb0f9","user":{"login":"sharnik","id":987,"avatar_url":"https://avatars.githubusercontent.com/u/987?v=3","gravatar_id":"","url":"https://api.github.com/users/sharnik","html_url":"https://github.com/sharnik","followers_url":"https://api.github.com/users/sharnik/followers","following_url":"https://api.github.com/users/sharnik/following{/other_user}","gists_url":"https://api.github.com/users/sharnik/gists{/gist_id}","starred_url":"https://api.github.com/users/sharnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharnik/subscriptions","organizations_url":"https://api.github.com/users/sharnik/orgs","repos_url":"https://api.github.com/users/sharnik/repos","events_url":"https://api.github.com/users/sharnik/events{/privacy}","received_events_url":"https://api.github.com/users/sharnik/received_events","type":"User","site_admin":false},"body":"It's a bit confusing when making a change, see a different test fail (because of the randomised order and fail-fast), but you basically didn't fix anything.","created_at":"2016-03-02T15:34:39Z","updated_at":"2016-03-02T15:34:39Z","html_url":"https://github.com/xing/pdf_cover/pull/3#discussion_r54739132","pull_request_url":"https://api.github.com/repos/xing/pdf_cover/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/xing/pdf_cover/pulls/comments/54739132"},"html":{"href":"https://github.com/xing/pdf_cover/pull/3#discussion_r54739132"},"pull_request":{"href":"https://api.github.com/repos/xing/pdf_cover/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/xing/pdf_cover/pulls/3","id":61394037,"html_url":"https://github.com/xing/pdf_cover/pull/3","diff_url":"https://github.com/xing/pdf_cover/pull/3.diff","patch_url":"https://github.com/xing/pdf_cover/pull/3.patch","issue_url":"https://api.github.com/repos/xing/pdf_cover/issues/3","number":3,"state":"open","locked":false,"title":"Fix naming conflict between the main module and Paperclip processor ","user":{"login":"sharnik","id":987,"avatar_url":"https://avatars.githubusercontent.com/u/987?v=3","gravatar_id":"","url":"https://api.github.com/users/sharnik","html_url":"https://github.com/sharnik","followers_url":"https://api.github.com/users/sharnik/followers","following_url":"https://api.github.com/users/sharnik/following{/other_user}","gists_url":"https://api.github.com/users/sharnik/gists{/gist_id}","starred_url":"https://api.github.com/users/sharnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharnik/subscriptions","organizations_url":"https://api.github.com/users/sharnik/orgs","repos_url":"https://api.github.com/users/sharnik/repos","events_url":"https://api.github.com/users/sharnik/events{/privacy}","received_events_url":"https://api.github.com/users/sharnik/received_events","type":"User","site_admin":false},"body":"We declared a main module named PdfCover and then a Paperclip processor named the same. In some situation it caused Paperclip to blow up when using the gem.\r\n\r\nI've renamed the processor to PdfCoverProcessor to fix that.","created_at":"2016-03-02T12:39:16Z","updated_at":"2016-03-02T15:34:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4bcd39c1d81a1b4892d1ba3adaa9ffdf5e7bfa5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xing/pdf_cover/pulls/3/commits","review_comments_url":"https://api.github.com/repos/xing/pdf_cover/pulls/3/comments","review_comment_url":"https://api.github.com/repos/xing/pdf_cover/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xing/pdf_cover/issues/3/comments","statuses_url":"https://api.github.com/repos/xing/pdf_cover/statuses/e3c82cd7f0d1b4a96c52308486a832a6b1fdb0f9","head":{"label":"sharnik:fix-namespace-issues","ref":"fix-namespace-issues","sha":"e3c82cd7f0d1b4a96c52308486a832a6b1fdb0f9","user":{"login":"sharnik","id":987,"avatar_url":"https://avatars.githubusercontent.com/u/987?v=3","gravatar_id":"","url":"https://api.github.com/users/sharnik","html_url":"https://github.com/sharnik","followers_url":"https://api.github.com/users/sharnik/followers","following_url":"https://api.github.com/users/sharnik/following{/other_user}","gists_url":"https://api.github.com/users/sharnik/gists{/gist_id}","starred_url":"https://api.github.com/users/sharnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharnik/subscriptions","organizations_url":"https://api.github.com/users/sharnik/orgs","repos_url":"https://api.github.com/users/sharnik/repos","events_url":"https://api.github.com/users/sharnik/events{/privacy}","received_events_url":"https://api.github.com/users/sharnik/received_events","type":"User","site_admin":false},"repo":{"id":52961575,"name":"pdf_cover","full_name":"sharnik/pdf_cover","owner":{"login":"sharnik","id":987,"avatar_url":"https://avatars.githubusercontent.com/u/987?v=3","gravatar_id":"","url":"https://api.github.com/users/sharnik","html_url":"https://github.com/sharnik","followers_url":"https://api.github.com/users/sharnik/followers","following_url":"https://api.github.com/users/sharnik/following{/other_user}","gists_url":"https://api.github.com/users/sharnik/gists{/gist_id}","starred_url":"https://api.github.com/users/sharnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharnik/subscriptions","organizations_url":"https://api.github.com/users/sharnik/orgs","repos_url":"https://api.github.com/users/sharnik/repos","events_url":"https://api.github.com/users/sharnik/events{/privacy}","received_events_url":"https://api.github.com/users/sharnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharnik/pdf_cover","description":"Generate PDF cover images with Paperclip and Carrierwave","fork":true,"url":"https://api.github.com/repos/sharnik/pdf_cover","forks_url":"https://api.github.com/repos/sharnik/pdf_cover/forks","keys_url":"https://api.github.com/repos/sharnik/pdf_cover/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharnik/pdf_cover/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharnik/pdf_cover/teams","hooks_url":"https://api.github.com/repos/sharnik/pdf_cover/hooks","issue_events_url":"https://api.github.com/repos/sharnik/pdf_cover/issues/events{/number}","events_url":"https://api.github.com/repos/sharnik/pdf_cover/events","assignees_url":"https://api.github.com/repos/sharnik/pdf_cover/assignees{/user}","branches_url":"https://api.github.com/repos/sharnik/pdf_cover/branches{/branch}","tags_url":"https://api.github.com/repos/sharnik/pdf_cover/tags","blobs_url":"https://api.github.com/repos/sharnik/pdf_cover/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharnik/pdf_cover/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharnik/pdf_cover/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharnik/pdf_cover/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharnik/pdf_cover/statuses/{sha}","languages_url":"https://api.github.com/repos/sharnik/pdf_cover/languages","stargazers_url":"https://api.github.com/repos/sharnik/pdf_cover/stargazers","contributors_url":"https://api.github.com/repos/sharnik/pdf_cover/contributors","subscribers_url":"https://api.github.com/repos/sharnik/pdf_cover/subscribers","subscription_url":"https://api.github.com/repos/sharnik/pdf_cover/subscription","commits_url":"https://api.github.com/repos/sharnik/pdf_cover/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharnik/pdf_cover/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharnik/pdf_cover/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharnik/pdf_cover/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharnik/pdf_cover/contents/{+path}","compare_url":"https://api.github.com/repos/sharnik/pdf_cover/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharnik/pdf_cover/merges","archive_url":"https://api.github.com/repos/sharnik/pdf_cover/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharnik/pdf_cover/downloads","issues_url":"https://api.github.com/repos/sharnik/pdf_cover/issues{/number}","pulls_url":"https://api.github.com/repos/sharnik/pdf_cover/pulls{/number}","milestones_url":"https://api.github.com/repos/sharnik/pdf_cover/milestones{/number}","notifications_url":"https://api.github.com/repos/sharnik/pdf_cover/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharnik/pdf_cover/labels{/name}","releases_url":"https://api.github.com/repos/sharnik/pdf_cover/releases{/id}","deployments_url":"https://api.github.com/repos/sharnik/pdf_cover/deployments","created_at":"2016-03-02T12:37:35Z","updated_at":"2016-03-02T12:37:38Z","pushed_at":"2016-03-02T12:38:21Z","git_url":"git://github.com/sharnik/pdf_cover.git","ssh_url":"git@github.com:sharnik/pdf_cover.git","clone_url":"https://github.com/sharnik/pdf_cover.git","svn_url":"https://github.com/sharnik/pdf_cover","homepage":"","size":36527,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xing:master","ref":"master","sha":"09625685aa01d15566d5e61c7ad812705508c7cf","user":{"login":"xing","id":27901,"avatar_url":"https://avatars.githubusercontent.com/u/27901?v=3","gravatar_id":"","url":"https://api.github.com/users/xing","html_url":"https://github.com/xing","followers_url":"https://api.github.com/users/xing/followers","following_url":"https://api.github.com/users/xing/following{/other_user}","gists_url":"https://api.github.com/users/xing/gists{/gist_id}","starred_url":"https://api.github.com/users/xing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing/subscriptions","organizations_url":"https://api.github.com/users/xing/orgs","repos_url":"https://api.github.com/users/xing/repos","events_url":"https://api.github.com/users/xing/events{/privacy}","received_events_url":"https://api.github.com/users/xing/received_events","type":"Organization","site_admin":false},"repo":{"id":52450574,"name":"pdf_cover","full_name":"xing/pdf_cover","owner":{"login":"xing","id":27901,"avatar_url":"https://avatars.githubusercontent.com/u/27901?v=3","gravatar_id":"","url":"https://api.github.com/users/xing","html_url":"https://github.com/xing","followers_url":"https://api.github.com/users/xing/followers","following_url":"https://api.github.com/users/xing/following{/other_user}","gists_url":"https://api.github.com/users/xing/gists{/gist_id}","starred_url":"https://api.github.com/users/xing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing/subscriptions","organizations_url":"https://api.github.com/users/xing/orgs","repos_url":"https://api.github.com/users/xing/repos","events_url":"https://api.github.com/users/xing/events{/privacy}","received_events_url":"https://api.github.com/users/xing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xing/pdf_cover","description":"Generate PDF cover images with Paperclip and Carrierwave","fork":false,"url":"https://api.github.com/repos/xing/pdf_cover","forks_url":"https://api.github.com/repos/xing/pdf_cover/forks","keys_url":"https://api.github.com/repos/xing/pdf_cover/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xing/pdf_cover/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xing/pdf_cover/teams","hooks_url":"https://api.github.com/repos/xing/pdf_cover/hooks","issue_events_url":"https://api.github.com/repos/xing/pdf_cover/issues/events{/number}","events_url":"https://api.github.com/repos/xing/pdf_cover/events","assignees_url":"https://api.github.com/repos/xing/pdf_cover/assignees{/user}","branches_url":"https://api.github.com/repos/xing/pdf_cover/branches{/branch}","tags_url":"https://api.github.com/repos/xing/pdf_cover/tags","blobs_url":"https://api.github.com/repos/xing/pdf_cover/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xing/pdf_cover/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xing/pdf_cover/git/refs{/sha}","trees_url":"https://api.github.com/repos/xing/pdf_cover/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xing/pdf_cover/statuses/{sha}","languages_url":"https://api.github.com/repos/xing/pdf_cover/languages","stargazers_url":"https://api.github.com/repos/xing/pdf_cover/stargazers","contributors_url":"https://api.github.com/repos/xing/pdf_cover/contributors","subscribers_url":"https://api.github.com/repos/xing/pdf_cover/subscribers","subscription_url":"https://api.github.com/repos/xing/pdf_cover/subscription","commits_url":"https://api.github.com/repos/xing/pdf_cover/commits{/sha}","git_commits_url":"https://api.github.com/repos/xing/pdf_cover/git/commits{/sha}","comments_url":"https://api.github.com/repos/xing/pdf_cover/comments{/number}","issue_comment_url":"https://api.github.com/repos/xing/pdf_cover/issues/comments{/number}","contents_url":"https://api.github.com/repos/xing/pdf_cover/contents/{+path}","compare_url":"https://api.github.com/repos/xing/pdf_cover/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xing/pdf_cover/merges","archive_url":"https://api.github.com/repos/xing/pdf_cover/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xing/pdf_cover/downloads","issues_url":"https://api.github.com/repos/xing/pdf_cover/issues{/number}","pulls_url":"https://api.github.com/repos/xing/pdf_cover/pulls{/number}","milestones_url":"https://api.github.com/repos/xing/pdf_cover/milestones{/number}","notifications_url":"https://api.github.com/repos/xing/pdf_cover/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xing/pdf_cover/labels{/name}","releases_url":"https://api.github.com/repos/xing/pdf_cover/releases{/id}","deployments_url":"https://api.github.com/repos/xing/pdf_cover/deployments","created_at":"2016-02-24T14:59:42Z","updated_at":"2016-02-25T14:56:31Z","pushed_at":"2016-03-02T12:39:18Z","git_url":"git://github.com/xing/pdf_cover.git","ssh_url":"git@github.com:xing/pdf_cover.git","clone_url":"https://github.com/xing/pdf_cover.git","svn_url":"https://github.com/xing/pdf_cover","homepage":"","size":36553,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xing/pdf_cover/pulls/3"},"html":{"href":"https://github.com/xing/pdf_cover/pull/3"},"issue":{"href":"https://api.github.com/repos/xing/pdf_cover/issues/3"},"comments":{"href":"https://api.github.com/repos/xing/pdf_cover/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/xing/pdf_cover/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/xing/pdf_cover/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xing/pdf_cover/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/xing/pdf_cover/statuses/e3c82cd7f0d1b4a96c52308486a832a6b1fdb0f9"}}}}