{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2359","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2359/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2359/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2359/events","html_url":"https://github.com/ethereum/go-ethereum/pull/2359","id":141535128,"number":2359,"title":"rpc: several fixes and support for optional arguments","user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/go-ethereum/labels/review","name":"review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/20","html_url":"https://github.com/ethereum/go-ethereum/milestones/1.4.0","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/20/labels","id":1299388,"number":20,"title":"1.4.0","description":"","creator":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":109,"state":"open","created_at":"2015-09-10T13:53:50Z","updated_at":"2016-04-12T09:00:45Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-03-17T10:03:49Z","updated_at":"2016-04-12T09:09:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2359","html_url":"https://github.com/ethereum/go-ethereum/pull/2359","diff_url":"https://github.com/ethereum/go-ethereum/pull/2359.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/2359.patch"},"body":"This PR includes:\r\n- [X] support for optional arguments in the RPC layer #2312.\r\n- [X] let `eth_call` accept null values for some of the arguments #2319 \r\n- [X] uses a different mechanism for sending RPC request which does not do an export of otto values to go values which could crash the otto vm with null values in arrays (otto bug) #2230\r\n- [X] be less restrictive on the request id #2270\r\n- [X] fixes several failing RPC tests\r\n- [X] removal of unused code\r\n- [X] upgrade of web3 to version 0.16.0 #2403"},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/208806066","html_url":"https://github.com/ethereum/go-ethereum/pull/2359#issuecomment-208806066","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2359","id":208806066,"user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T09:09:08Z","updated_at":"2016-04-12T09:09:08Z","body":"This seem to be a bug in goimports. Goimports removes `\"github.com/microsoft/go-winio\"` from the import list which was run after the rebase (on linux). Solution is to import `winio \"github.com/microsoft/go-winio\"`. Goimports is then able to figure out that this package is used and won't remove it from the import list."}}