{"action":"created","comment":{"url":"https://api.github.com/repos/JayFoxRox/openrw/pulls/comments/74439401","id":74439401,"diff_hunk":"@@ -175,13 +175,21 @@ TextureData::Handle createTexture(RW::BSTextureNative& texNative, RW::BinaryStre\n     return GL_REPEAT;\n   };\n \n-\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR_MIPMAP_LINEAR);\n-\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, glTexFilter(texNative.filterflags));\n+\tbool useMipMaps = false;\n+  if (generateMipMaps) {\n+\t  glGenerateMipmap(GL_TEXTURE_2D);\n+\t\tuseMipMaps = true;\n+\t} else if (hasMipMaps) {\n+\t\t// @todo Load mipmaps from file instead\n+\t  glGenerateMipmap(GL_TEXTURE_2D);\n+\t\tuseMipMaps = true;\n+\t}\n+\tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);","path":"rwlib/source/loaders/LoaderTXD.cpp","position":null,"original_position":15,"commit_id":"e077b04afa51aec0266701d938b42dfe3171aee4","original_commit_id":"bcf471126c260e3469e028e5551cfa93a60c40ac","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"body":"todo wether this is correct. Might be `glTexFilter(texNative.filterflags, false));` ?","created_at":"2016-08-11T15:04:16Z","updated_at":"2016-08-11T15:04:16Z","html_url":"https://github.com/JayFoxRox/openrw/pull/17#discussion_r74439401","pull_request_url":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/JayFoxRox/openrw/pulls/comments/74439401"},"html":{"href":"https://github.com/JayFoxRox/openrw/pull/17#discussion_r74439401"},"pull_request":{"href":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17","id":80606887,"html_url":"https://github.com/JayFoxRox/openrw/pull/17","diff_url":"https://github.com/JayFoxRox/openrw/pull/17.diff","patch_url":"https://github.com/JayFoxRox/openrw/pull/17.patch","issue_url":"https://api.github.com/repos/JayFoxRox/openrw/issues/17","number":17,"state":"open","locked":false,"title":"Refactor TXD loader and support more formats","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"body":"---\r\n\r\nTODO:\r\n- [ ] PR description\r\n- [x] Check for `EXT_texture_compression_s3tc` for TXDs\r\n- Support all formats\r\n  - [ ] FORMAT_DEFAULT         0x0000\r\n  - [x] FORMAT_1555            0x0100 (1 bit alpha, RGB 5 bits each)\r\n  - [x] FORMAT_565             0x0200 (5 bits red, 6 bits green, 5 bits blue)\r\n  - [x] FORMAT_4444            0x0300 (RGBA 4 bits each)\r\n  - [x] DXT: FORMAT_1555            0x0100 (1 bit alpha, RGB 5 bits each; DXT1 with alpha)\r\n  - [x] DXT: FORMAT_565             0x0200 (5 bits red, 6 bits green, 5 bits blue; DXT1 without alpha)\r\n  - [x] DXT: FORMAT_4444            0x0300 (RGBA 4 bits each; DXT3)\r\n  - [ ] FORMAT_LUM8            0x0400 (gray scale, D3DFMT_L8)\r\n  - [x] FORMAT_8888            0x0500 (RGBA 8 bits each)\r\n  - [x] FORMAT_888             0x0600 (RGB 8 bits each, D3DFMT_X8R8G8B8)\r\n  - [ ] FORMAT_555             0x0A00 (RGB 5 bits each - rare, use 565 instead, D3DFMT_X1R5G5B5)\r\n- Support palette modes (do these work with all formats?)\r\n  - [x] FORMAT_EXT_PAL8        0x2000 (2^8 = 256 palette colors)\r\n  - [ ] FORMAT_EXT_PAL4        0x4000 (2^4 = 16 palette colors)\r\n- Mipmaps\r\n  - [ ] FORMAT_EXT_AUTO_MIPMAP 0x1000 (RW generates mipmaps, see special section below)\r\n  - [ ] FORMAT_EXT_MIPMAP      0x8000 (mipmaps included)\r\n- [x] Debug-label textures with their source name and TXD format\r\n- [ ] Isolate GL debug stuff\r\n- [ ] Cleanup","created_at":"2016-08-09T11:52:35Z","updated_at":"2016-08-11T15:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c42e4e8029e044be02cdb0e4c57bd91289f88ad8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17/commits","review_comments_url":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17/comments","review_comment_url":"https://api.github.com/repos/JayFoxRox/openrw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JayFoxRox/openrw/issues/17/comments","statuses_url":"https://api.github.com/repos/JayFoxRox/openrw/statuses/e077b04afa51aec0266701d938b42dfe3171aee4","head":{"label":"JayFoxRox:txd-refactor","ref":"txd-refactor","sha":"e077b04afa51aec0266701d938b42dfe3171aee4","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"repo":{"id":59780349,"name":"openrw","full_name":"JayFoxRox/openrw","owner":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JayFoxRox/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":true,"url":"https://api.github.com/repos/JayFoxRox/openrw","forks_url":"https://api.github.com/repos/JayFoxRox/openrw/forks","keys_url":"https://api.github.com/repos/JayFoxRox/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JayFoxRox/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JayFoxRox/openrw/teams","hooks_url":"https://api.github.com/repos/JayFoxRox/openrw/hooks","issue_events_url":"https://api.github.com/repos/JayFoxRox/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/JayFoxRox/openrw/events","assignees_url":"https://api.github.com/repos/JayFoxRox/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/JayFoxRox/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/JayFoxRox/openrw/tags","blobs_url":"https://api.github.com/repos/JayFoxRox/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JayFoxRox/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JayFoxRox/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/JayFoxRox/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JayFoxRox/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/JayFoxRox/openrw/languages","stargazers_url":"https://api.github.com/repos/JayFoxRox/openrw/stargazers","contributors_url":"https://api.github.com/repos/JayFoxRox/openrw/contributors","subscribers_url":"https://api.github.com/repos/JayFoxRox/openrw/subscribers","subscription_url":"https://api.github.com/repos/JayFoxRox/openrw/subscription","commits_url":"https://api.github.com/repos/JayFoxRox/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/JayFoxRox/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/JayFoxRox/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/JayFoxRox/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/JayFoxRox/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/JayFoxRox/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JayFoxRox/openrw/merges","archive_url":"https://api.github.com/repos/JayFoxRox/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JayFoxRox/openrw/downloads","issues_url":"https://api.github.com/repos/JayFoxRox/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/JayFoxRox/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/JayFoxRox/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/JayFoxRox/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JayFoxRox/openrw/labels{/name}","releases_url":"https://api.github.com/repos/JayFoxRox/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/JayFoxRox/openrw/deployments","created_at":"2016-05-26T20:12:18Z","updated_at":"2016-06-05T18:08:29Z","pushed_at":"2016-08-11T15:02:14Z","git_url":"git://github.com/JayFoxRox/openrw.git","ssh_url":"git@github.com:JayFoxRox/openrw.git","clone_url":"https://github.com/JayFoxRox/openrw.git","svn_url":"https://github.com/JayFoxRox/openrw","homepage":"https://github.com/rwengine/openrw","size":2019,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"JayFoxRox:master","ref":"master","sha":"612a314126d553a620db8d64af2b1b9feb8afe98","user":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"repo":{"id":59780349,"name":"openrw","full_name":"JayFoxRox/openrw","owner":{"login":"JayFoxRox","id":360330,"avatar_url":"https://avatars.githubusercontent.com/u/360330?v=3","gravatar_id":"","url":"https://api.github.com/users/JayFoxRox","html_url":"https://github.com/JayFoxRox","followers_url":"https://api.github.com/users/JayFoxRox/followers","following_url":"https://api.github.com/users/JayFoxRox/following{/other_user}","gists_url":"https://api.github.com/users/JayFoxRox/gists{/gist_id}","starred_url":"https://api.github.com/users/JayFoxRox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayFoxRox/subscriptions","organizations_url":"https://api.github.com/users/JayFoxRox/orgs","repos_url":"https://api.github.com/users/JayFoxRox/repos","events_url":"https://api.github.com/users/JayFoxRox/events{/privacy}","received_events_url":"https://api.github.com/users/JayFoxRox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JayFoxRox/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":true,"url":"https://api.github.com/repos/JayFoxRox/openrw","forks_url":"https://api.github.com/repos/JayFoxRox/openrw/forks","keys_url":"https://api.github.com/repos/JayFoxRox/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JayFoxRox/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JayFoxRox/openrw/teams","hooks_url":"https://api.github.com/repos/JayFoxRox/openrw/hooks","issue_events_url":"https://api.github.com/repos/JayFoxRox/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/JayFoxRox/openrw/events","assignees_url":"https://api.github.com/repos/JayFoxRox/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/JayFoxRox/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/JayFoxRox/openrw/tags","blobs_url":"https://api.github.com/repos/JayFoxRox/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JayFoxRox/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JayFoxRox/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/JayFoxRox/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JayFoxRox/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/JayFoxRox/openrw/languages","stargazers_url":"https://api.github.com/repos/JayFoxRox/openrw/stargazers","contributors_url":"https://api.github.com/repos/JayFoxRox/openrw/contributors","subscribers_url":"https://api.github.com/repos/JayFoxRox/openrw/subscribers","subscription_url":"https://api.github.com/repos/JayFoxRox/openrw/subscription","commits_url":"https://api.github.com/repos/JayFoxRox/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/JayFoxRox/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/JayFoxRox/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/JayFoxRox/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/JayFoxRox/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/JayFoxRox/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JayFoxRox/openrw/merges","archive_url":"https://api.github.com/repos/JayFoxRox/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JayFoxRox/openrw/downloads","issues_url":"https://api.github.com/repos/JayFoxRox/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/JayFoxRox/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/JayFoxRox/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/JayFoxRox/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JayFoxRox/openrw/labels{/name}","releases_url":"https://api.github.com/repos/JayFoxRox/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/JayFoxRox/openrw/deployments","created_at":"2016-05-26T20:12:18Z","updated_at":"2016-06-05T18:08:29Z","pushed_at":"2016-08-11T15:02:14Z","git_url":"git://github.com/JayFoxRox/openrw.git","ssh_url":"git@github.com:JayFoxRox/openrw.git","clone_url":"https://github.com/JayFoxRox/openrw.git","svn_url":"https://github.com/JayFoxRox/openrw","homepage":"https://github.com/rwengine/openrw","size":2019,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17"},"html":{"href":"https://github.com/JayFoxRox/openrw/pull/17"},"issue":{"href":"https://api.github.com/repos/JayFoxRox/openrw/issues/17"},"comments":{"href":"https://api.github.com/repos/JayFoxRox/openrw/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/JayFoxRox/openrw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JayFoxRox/openrw/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/JayFoxRox/openrw/statuses/e077b04afa51aec0266701d938b42dfe3171aee4"}}}}
{"actor":{"display_login":"JayFoxRox"}}