{"action":"created","issue":{"url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap/issues/7","repository_url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap","labels_url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap/issues/7/comments","events_url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap/issues/7/events","html_url":"https://github.com/radiorabe/centos-rpm-liquidsoap/issues/7","id":176175440,"number":7,"title":"liquidsoap@.service - ExecStartPre=/bin/mkdir - (code=exited, status=1/FAILURE)","user":{"login":"paraenggu","id":1186157,"avatar_url":"https://avatars.githubusercontent.com/u/1186157?v=3","gravatar_id":"","url":"https://api.github.com/users/paraenggu","html_url":"https://github.com/paraenggu","followers_url":"https://api.github.com/users/paraenggu/followers","following_url":"https://api.github.com/users/paraenggu/following{/other_user}","gists_url":"https://api.github.com/users/paraenggu/gists{/gist_id}","starred_url":"https://api.github.com/users/paraenggu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paraenggu/subscriptions","organizations_url":"https://api.github.com/users/paraenggu/orgs","repos_url":"https://api.github.com/users/paraenggu/repos","events_url":"https://api.github.com/users/paraenggu/events{/privacy}","received_events_url":"https://api.github.com/users/paraenggu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-10T11:39:34Z","updated_at":"2016-09-10T12:36:55Z","closed_at":null,"body":"The [` ExecStartPre=/bin/mkdir  /var/log/liquidsoap`](https://github.com/radiorabe/centos-rpm-liquidsoap/blob/master/liquidsoap%40.service#L10) fails if the directory already exists (which it does after the second start-up of this service.\r\n\r\n```\r\nsystemctl status liquidsoap@dabplus-on-air-processing\r\n● liquidsoap@dabplus-on-air-processing.service - Liquidsoap\r\n   Loaded: loaded (/usr/lib/systemd/system/liquidsoap@.service; enabled; vendor preset: disabled)\r\n   Active: active (running) since Sam 2016-09-10 13:02:28 CEST; 26min ago\r\n     Docs: http://liquidsoap.fm\r\n           man:liquidsoap(1)\r\n  Process: 4370 ExecStartPre=/bin/chown liquidsoap /var/log/liquidsoap (code=exited, status=0/SUCCESS)\r\n  Process: 4366 ExecStartPre=/bin/mkdir /var/log/liquidsoap (code=exited, status=1/FAILURE)\r\n```\r\n\r\nA simple way to fix this, would be to add the `--parents` option to the `mkdir` call. However, it is probably more appropriate to create the log directory directly within the [liquidsoap.spec](https://github.com/radiorabe/centos-rpm-liquidsoap/blob/master/liquidsoap.spec) RPM."},"comment":{"url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap/issues/comments/246109493","html_url":"https://github.com/radiorabe/centos-rpm-liquidsoap/issues/7#issuecomment-246109493","issue_url":"https://api.github.com/repos/radiorabe/centos-rpm-liquidsoap/issues/7","id":246109493,"user":{"login":"hairmare","id":116588,"avatar_url":"https://avatars.githubusercontent.com/u/116588?v=3","gravatar_id":"","url":"https://api.github.com/users/hairmare","html_url":"https://github.com/hairmare","followers_url":"https://api.github.com/users/hairmare/followers","following_url":"https://api.github.com/users/hairmare/following{/other_user}","gists_url":"https://api.github.com/users/hairmare/gists{/gist_id}","starred_url":"https://api.github.com/users/hairmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hairmare/subscriptions","organizations_url":"https://api.github.com/users/hairmare/orgs","repos_url":"https://api.github.com/users/hairmare/repos","events_url":"https://api.github.com/users/hairmare/events{/privacy}","received_events_url":"https://api.github.com/users/hairmare/received_events","type":"User","site_admin":false},"created_at":"2016-09-10T12:36:55Z","updated_at":"2016-09-10T12:36:55Z","body":"The `ExecStartPre` is prefixed with a dash, thus ignoring the the failure. Why is this a problem?\r\n\r\nI'd rather not have it in the spec since it is up to the user to actually configure this properly (and maybe use a different location or only log to systemd journals using stdout)."}}
{"actor":{"display_login":"hairmare"}}