{"action":"created","comment":{"url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/comments/53297999","id":53297999,"diff_hunk":"@@ -39,6 +40,12 @@ public void setSunPath(String sunPath) {\n             System.arraycopy(sunPath.getBytes(), 0, this.sun_path, 0, sunPath.length());\r\n             System.arraycopy(ZERO_BYTE, 0, this.sun_path, sunPath.length(), 1);\r\n         }\r\n+\r\n+\t\t@Override\r\n+\t\tprotected List getFieldOrder() {\r","path":"src/main/java/org/graylog2/syslog4j/impl/unix/socket/UnixSocketSyslog.java","position":14,"original_position":14,"commit_id":"999568c5da6aeb46e6f5c5335a04f216c3d27df1","original_commit_id":"999568c5da6aeb46e6f5c5335a04f216c3d27df1","user":{"login":"negar7918","id":17046684,"avatar_url":"https://avatars.githubusercontent.com/u/17046684?v=3","gravatar_id":"","url":"https://api.github.com/users/negar7918","html_url":"https://github.com/negar7918","followers_url":"https://api.github.com/users/negar7918/followers","following_url":"https://api.github.com/users/negar7918/following{/other_user}","gists_url":"https://api.github.com/users/negar7918/gists{/gist_id}","starred_url":"https://api.github.com/users/negar7918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negar7918/subscriptions","organizations_url":"https://api.github.com/users/negar7918/orgs","repos_url":"https://api.github.com/users/negar7918/repos","events_url":"https://api.github.com/users/negar7918/events{/privacy}","received_events_url":"https://api.github.com/users/negar7918/received_events","type":"User","site_admin":false},"body":"I checked the older version of jna and they had implementation for the\nmethod but I used a newer version and it is abstract:\n\nhttp://grepcode.com/file/repo1.maven.org/maven2/net.java.dev.jna/jna/3.5.0/com/sun/jna/Structure.java#Structure.getFieldOrder%28%29\n\nBut sure to avoid NPE I can return an empty list (It is not used now so I\ndidn't care really)\n\nOn Thu, Feb 18, 2016 at 11:33 AM, Jochen Schalanda <notifications@github.com\n> wrote:\n\n> In\n> src/main/java/org/graylog2/syslog4j/impl/unix/socket/UnixSocketSyslog.java\n> <https://github.com/Graylog2/syslog4j-graylog2/pull/6#discussion_r53296629>\n> :\n>\n> > @@ -39,6 +40,12 @@ public void setSunPath(String sunPath) {\n> >              System.arraycopy(sunPath.getBytes(), 0, this.sun_path, 0, sunPath.length());\n> >              System.arraycopy(ZERO_BYTE, 0, this.sun_path, sunPath.length(), 1);\n> >          }\n> > +\n> > +\t\t@Override\n> > +\t\tprotected List getFieldOrder() {\n>\n> The Javadoc at\n> https://jna.java.net/nonav/javadoc/com/sun/jna/Structure.html#getFieldOrder()\n> doesn't mention this method being abstract and \"my\" JNA implementation\n> provides a standard implementation for this method.\n>\n> The question is, if is has to be overridden (it hasn't been overridden\n> before this PR), and if it has to, whether it should return null (which\n> might cause NPEs across the board) or simply return an empty list.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Graylog2/syslog4j-graylog2/pull/6/files#r53296629>.\n>\n","created_at":"2016-02-18T10:47:09Z","updated_at":"2016-02-18T10:47:09Z","html_url":"https://github.com/Graylog2/syslog4j-graylog2/pull/6#discussion_r53297999","pull_request_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/comments/53297999"},"html":{"href":"https://github.com/Graylog2/syslog4j-graylog2/pull/6#discussion_r53297999"},"pull_request":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6","id":58742461,"html_url":"https://github.com/Graylog2/syslog4j-graylog2/pull/6","diff_url":"https://github.com/Graylog2/syslog4j-graylog2/pull/6.diff","patch_url":"https://github.com/Graylog2/syslog4j-graylog2/pull/6.patch","issue_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues/6","number":6,"state":"open","locked":false,"title":"Implemented compatibility with frame header.","user":{"login":"negar7918","id":17046684,"avatar_url":"https://avatars.githubusercontent.com/u/17046684?v=3","gravatar_id":"","url":"https://api.github.com/users/negar7918","html_url":"https://github.com/negar7918","followers_url":"https://api.github.com/users/negar7918/followers","following_url":"https://api.github.com/users/negar7918/following{/other_user}","gists_url":"https://api.github.com/users/negar7918/gists{/gist_id}","starred_url":"https://api.github.com/users/negar7918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negar7918/subscriptions","organizations_url":"https://api.github.com/users/negar7918/orgs","repos_url":"https://api.github.com/users/negar7918/repos","events_url":"https://api.github.com/users/negar7918/events{/privacy}","received_events_url":"https://api.github.com/users/negar7918/received_events","type":"User","site_admin":false},"body":"Implemented compatibility with frame header. Frame header is for instance used by syslog() driver in syslog-ng server and is used to support RFC5424.","created_at":"2016-02-09T12:45:19Z","updated_at":"2016-02-18T10:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f03218f2a808e233647ebdd113851eb6a05de0","assignee":{"login":"joschi","id":43951,"avatar_url":"https://avatars.githubusercontent.com/u/43951?v=3","gravatar_id":"","url":"https://api.github.com/users/joschi","html_url":"https://github.com/joschi","followers_url":"https://api.github.com/users/joschi/followers","following_url":"https://api.github.com/users/joschi/following{/other_user}","gists_url":"https://api.github.com/users/joschi/gists{/gist_id}","starred_url":"https://api.github.com/users/joschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschi/subscriptions","organizations_url":"https://api.github.com/users/joschi/orgs","repos_url":"https://api.github.com/users/joschi/repos","events_url":"https://api.github.com/users/joschi/events{/privacy}","received_events_url":"https://api.github.com/users/joschi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues/6/comments","statuses_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/statuses/999568c5da6aeb46e6f5c5335a04f216c3d27df1","head":{"label":"negar7918:master","ref":"master","sha":"999568c5da6aeb46e6f5c5335a04f216c3d27df1","user":{"login":"negar7918","id":17046684,"avatar_url":"https://avatars.githubusercontent.com/u/17046684?v=3","gravatar_id":"","url":"https://api.github.com/users/negar7918","html_url":"https://github.com/negar7918","followers_url":"https://api.github.com/users/negar7918/followers","following_url":"https://api.github.com/users/negar7918/following{/other_user}","gists_url":"https://api.github.com/users/negar7918/gists{/gist_id}","starred_url":"https://api.github.com/users/negar7918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negar7918/subscriptions","organizations_url":"https://api.github.com/users/negar7918/orgs","repos_url":"https://api.github.com/users/negar7918/repos","events_url":"https://api.github.com/users/negar7918/events{/privacy}","received_events_url":"https://api.github.com/users/negar7918/received_events","type":"User","site_admin":false},"repo":{"id":51357102,"name":"syslog4j-graylog2","full_name":"negar7918/syslog4j-graylog2","owner":{"login":"negar7918","id":17046684,"avatar_url":"https://avatars.githubusercontent.com/u/17046684?v=3","gravatar_id":"","url":"https://api.github.com/users/negar7918","html_url":"https://github.com/negar7918","followers_url":"https://api.github.com/users/negar7918/followers","following_url":"https://api.github.com/users/negar7918/following{/other_user}","gists_url":"https://api.github.com/users/negar7918/gists{/gist_id}","starred_url":"https://api.github.com/users/negar7918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negar7918/subscriptions","organizations_url":"https://api.github.com/users/negar7918/orgs","repos_url":"https://api.github.com/users/negar7918/repos","events_url":"https://api.github.com/users/negar7918/events{/privacy}","received_events_url":"https://api.github.com/users/negar7918/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/negar7918/syslog4j-graylog2","description":"The syslog4j fork from Graylog2. This is used since 0.10.0. The original code was very \"special\" and no actions were taken to improve it. This is planned to be replaced completely in future versions.","fork":true,"url":"https://api.github.com/repos/negar7918/syslog4j-graylog2","forks_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/forks","keys_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/teams","hooks_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/hooks","issue_events_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/issues/events{/number}","events_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/events","assignees_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/assignees{/user}","branches_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/branches{/branch}","tags_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/tags","blobs_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/git/refs{/sha}","trees_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/statuses/{sha}","languages_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/languages","stargazers_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/stargazers","contributors_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/contributors","subscribers_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/subscribers","subscription_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/subscription","commits_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/commits{/sha}","git_commits_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/git/commits{/sha}","comments_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/comments{/number}","issue_comment_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/issues/comments{/number}","contents_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/contents/{+path}","compare_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/merges","archive_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/downloads","issues_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/issues{/number}","pulls_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/pulls{/number}","milestones_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/milestones{/number}","notifications_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/labels{/name}","releases_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/releases{/id}","deployments_url":"https://api.github.com/repos/negar7918/syslog4j-graylog2/deployments","created_at":"2016-02-09T09:22:50Z","updated_at":"2016-02-09T09:22:51Z","pushed_at":"2016-02-16T16:45:47Z","git_url":"git://github.com/negar7918/syslog4j-graylog2.git","ssh_url":"git@github.com:negar7918/syslog4j-graylog2.git","clone_url":"https://github.com/negar7918/syslog4j-graylog2.git","svn_url":"https://github.com/negar7918/syslog4j-graylog2","homepage":null,"size":515,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Graylog2:master","ref":"master","sha":"8d48a0ae3e59a151bd57eb3c01b9a5bf13246ac3","user":{"login":"Graylog2","id":474892,"avatar_url":"https://avatars.githubusercontent.com/u/474892?v=3","gravatar_id":"","url":"https://api.github.com/users/Graylog2","html_url":"https://github.com/Graylog2","followers_url":"https://api.github.com/users/Graylog2/followers","following_url":"https://api.github.com/users/Graylog2/following{/other_user}","gists_url":"https://api.github.com/users/Graylog2/gists{/gist_id}","starred_url":"https://api.github.com/users/Graylog2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graylog2/subscriptions","organizations_url":"https://api.github.com/users/Graylog2/orgs","repos_url":"https://api.github.com/users/Graylog2/repos","events_url":"https://api.github.com/users/Graylog2/events{/privacy}","received_events_url":"https://api.github.com/users/Graylog2/received_events","type":"Organization","site_admin":false},"repo":{"id":8785430,"name":"syslog4j-graylog2","full_name":"Graylog2/syslog4j-graylog2","owner":{"login":"Graylog2","id":474892,"avatar_url":"https://avatars.githubusercontent.com/u/474892?v=3","gravatar_id":"","url":"https://api.github.com/users/Graylog2","html_url":"https://github.com/Graylog2","followers_url":"https://api.github.com/users/Graylog2/followers","following_url":"https://api.github.com/users/Graylog2/following{/other_user}","gists_url":"https://api.github.com/users/Graylog2/gists{/gist_id}","starred_url":"https://api.github.com/users/Graylog2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Graylog2/subscriptions","organizations_url":"https://api.github.com/users/Graylog2/orgs","repos_url":"https://api.github.com/users/Graylog2/repos","events_url":"https://api.github.com/users/Graylog2/events{/privacy}","received_events_url":"https://api.github.com/users/Graylog2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Graylog2/syslog4j-graylog2","description":"The syslog4j fork from Graylog2. This is used since 0.10.0. The original code was very \"special\" and no actions were taken to improve it. This is planned to be replaced completely in future versions.","fork":false,"url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2","forks_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/forks","keys_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/teams","hooks_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/hooks","issue_events_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues/events{/number}","events_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/events","assignees_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/assignees{/user}","branches_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/branches{/branch}","tags_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/tags","blobs_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/git/refs{/sha}","trees_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/statuses/{sha}","languages_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/languages","stargazers_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/stargazers","contributors_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/contributors","subscribers_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/subscribers","subscription_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/subscription","commits_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/commits{/sha}","git_commits_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/git/commits{/sha}","comments_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/comments{/number}","issue_comment_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues/comments{/number}","contents_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/contents/{+path}","compare_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/merges","archive_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/downloads","issues_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues{/number}","pulls_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls{/number}","milestones_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/milestones{/number}","notifications_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/labels{/name}","releases_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/releases{/id}","deployments_url":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/deployments","created_at":"2013-03-14T21:07:00Z","updated_at":"2015-09-22T21:43:23Z","pushed_at":"2016-02-15T09:50:35Z","git_url":"git://github.com/Graylog2/syslog4j-graylog2.git","ssh_url":"git@github.com:Graylog2/syslog4j-graylog2.git","clone_url":"https://github.com/Graylog2/syslog4j-graylog2.git","svn_url":"https://github.com/Graylog2/syslog4j-graylog2","homepage":null,"size":826,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6"},"html":{"href":"https://github.com/Graylog2/syslog4j-graylog2/pull/6"},"issue":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues/6"},"comments":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Graylog2/syslog4j-graylog2/statuses/999568c5da6aeb46e6f5c5335a04f216c3d27df1"}}}}