{"action":"created","comment":{"url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/comments/64351375","id":64351375,"diff_hunk":"@@ -498,32 +564,31 @@ public function keepFlashdata($key)\n \t//--------------------------------------------------------------------\n \n \t/**\n-\t * @param $key\n-\t *\n-\t * @return bool\n+\t * Mark a session property or properties as flashdata.\n+\t * \n+\t * @param $key\tProperty identifier or array of them\n+\t * @return False if any of the properties are not already set\n \t */\n \tpublic function markAsFlashdata($key)\n \t{\n \t\tif (is_array($key))\n \t\t{\n \t\t\tfor ($i = 0, $c = count($key); $i < $c; $i++)\n \t\t\t{\n-\t\t\t\tif ( ! isset($_SESSION[$key[$i]]))\n+\t\t\t\tif (!isset($_SESSION[$key[$i]]))\n \t\t\t\t{\n \t\t\t\t\treturn false;\n \t\t\t\t}\n \t\t\t}\n \n \t\t\t$new = array_fill_keys($key, 'new');\n \n-\t\t\t$_SESSION['__ci_vars'] = isset($_SESSION['__ci_vars'])\n-\t\t\t\t? array_merge($_SESSION['__ci_vars'], $new)\n-\t\t\t\t: $new;\n+\t\t\t$_SESSION['__ci_vars'] = isset($_SESSION['__ci_vars']) ? array_merge($_SESSION['__ci_vars'], $new) : $new;\n \n \t\t\treturn true;\n \t\t}\n \n-\t\tif ( ! isset($_SESSION[$key]))\n+\t\tif (!isset($_SESSION[$key]))","path":"system/Session/Session.php","position":551,"original_position":551,"commit_id":"bd66d5bafcd0c91eb3525e19106dfe741538b3be","original_commit_id":"bd66d5bafcd0c91eb3525e19106dfe741538b3be","user":{"login":"jim-parry","id":3203951,"avatar_url":"https://avatars.githubusercontent.com/u/3203951?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-parry","html_url":"https://github.com/jim-parry","followers_url":"https://api.github.com/users/jim-parry/followers","following_url":"https://api.github.com/users/jim-parry/following{/other_user}","gists_url":"https://api.github.com/users/jim-parry/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-parry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-parry/subscriptions","organizations_url":"https://api.github.com/users/jim-parry/orgs","repos_url":"https://api.github.com/users/jim-parry/repos","events_url":"https://api.github.com/users/jim-parry/events{/privacy}","received_events_url":"https://api.github.com/users/jim-parry/received_events","type":"User","site_admin":false},"body":"Ok. I haven't found the auto-format setting for this yet.","created_at":"2016-05-24T08:51:06Z","updated_at":"2016-05-24T08:51:06Z","html_url":"https://github.com/lonnieezell/CodeIgniter4/pull/79#discussion_r64351375","pull_request_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/comments/64351375"},"html":{"href":"https://github.com/lonnieezell/CodeIgniter4/pull/79#discussion_r64351375"},"pull_request":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79","id":70981563,"html_url":"https://github.com/lonnieezell/CodeIgniter4/pull/79","diff_url":"https://github.com/lonnieezell/CodeIgniter4/pull/79.diff","patch_url":"https://github.com/lonnieezell/CodeIgniter4/pull/79.patch","issue_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues/79","number":79,"state":"open","locked":false,"title":"Session documentation.","user":{"login":"jim-parry","id":3203951,"avatar_url":"https://avatars.githubusercontent.com/u/3203951?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-parry","html_url":"https://github.com/jim-parry","followers_url":"https://api.github.com/users/jim-parry/followers","following_url":"https://api.github.com/users/jim-parry/following{/other_user}","gists_url":"https://api.github.com/users/jim-parry/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-parry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-parry/subscriptions","organizations_url":"https://api.github.com/users/jim-parry/orgs","repos_url":"https://api.github.com/users/jim-parry/repos","events_url":"https://api.github.com/users/jim-parry/events{/privacy}","received_events_url":"https://api.github.com/users/jim-parry/received_events","type":"User","site_admin":false},"body":"Fixed API docs & copied user guide section from CI3 - it will probably need more work.\r\nSigned-off-by:Master Yoda <jim_parry@bcit.ca>","created_at":"2016-05-22T16:36:02Z","updated_at":"2016-05-24T08:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d02dc4439bdb9173a2f423a9a8918869e306132a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79/commits","review_comments_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79/comments","review_comment_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues/79/comments","statuses_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/statuses/bd66d5bafcd0c91eb3525e19106dfe741538b3be","head":{"label":"jim-parry:update-sessions","ref":"update-sessions","sha":"bd66d5bafcd0c91eb3525e19106dfe741538b3be","user":{"login":"jim-parry","id":3203951,"avatar_url":"https://avatars.githubusercontent.com/u/3203951?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-parry","html_url":"https://github.com/jim-parry","followers_url":"https://api.github.com/users/jim-parry/followers","following_url":"https://api.github.com/users/jim-parry/following{/other_user}","gists_url":"https://api.github.com/users/jim-parry/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-parry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-parry/subscriptions","organizations_url":"https://api.github.com/users/jim-parry/orgs","repos_url":"https://api.github.com/users/jim-parry/repos","events_url":"https://api.github.com/users/jim-parry/events{/privacy}","received_events_url":"https://api.github.com/users/jim-parry/received_events","type":"User","site_admin":false},"repo":{"id":41465956,"name":"CodeIgniter4","full_name":"jim-parry/CodeIgniter4","owner":{"login":"jim-parry","id":3203951,"avatar_url":"https://avatars.githubusercontent.com/u/3203951?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-parry","html_url":"https://github.com/jim-parry","followers_url":"https://api.github.com/users/jim-parry/followers","following_url":"https://api.github.com/users/jim-parry/following{/other_user}","gists_url":"https://api.github.com/users/jim-parry/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-parry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-parry/subscriptions","organizations_url":"https://api.github.com/users/jim-parry/orgs","repos_url":"https://api.github.com/users/jim-parry/repos","events_url":"https://api.github.com/users/jim-parry/events{/privacy}","received_events_url":"https://api.github.com/users/jim-parry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jim-parry/CodeIgniter4","description":"","fork":true,"url":"https://api.github.com/repos/jim-parry/CodeIgniter4","forks_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/forks","keys_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/teams","hooks_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/hooks","issue_events_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/issues/events{/number}","events_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/events","assignees_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/assignees{/user}","branches_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/branches{/branch}","tags_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/tags","blobs_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/languages","stargazers_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/stargazers","contributors_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/contributors","subscribers_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/subscribers","subscription_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/subscription","commits_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/contents/{+path}","compare_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/merges","archive_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/downloads","issues_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/issues{/number}","pulls_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/labels{/name}","releases_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/releases{/id}","deployments_url":"https://api.github.com/repos/jim-parry/CodeIgniter4/deployments","created_at":"2015-08-27T04:38:42Z","updated_at":"2016-05-15T10:25:47Z","pushed_at":"2016-05-23T17:03:53Z","git_url":"git://github.com/jim-parry/CodeIgniter4.git","ssh_url":"git@github.com:jim-parry/CodeIgniter4.git","clone_url":"https://github.com/jim-parry/CodeIgniter4.git","svn_url":"https://github.com/jim-parry/CodeIgniter4","homepage":null,"size":3081,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"lonnieezell:develop","ref":"develop","sha":"95b9b363d6fd1ef8c3d8db4b84aa91b76f09fb89","user":{"login":"lonnieezell","id":51931,"avatar_url":"https://avatars.githubusercontent.com/u/51931?v=3","gravatar_id":"","url":"https://api.github.com/users/lonnieezell","html_url":"https://github.com/lonnieezell","followers_url":"https://api.github.com/users/lonnieezell/followers","following_url":"https://api.github.com/users/lonnieezell/following{/other_user}","gists_url":"https://api.github.com/users/lonnieezell/gists{/gist_id}","starred_url":"https://api.github.com/users/lonnieezell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonnieezell/subscriptions","organizations_url":"https://api.github.com/users/lonnieezell/orgs","repos_url":"https://api.github.com/users/lonnieezell/repos","events_url":"https://api.github.com/users/lonnieezell/events{/privacy}","received_events_url":"https://api.github.com/users/lonnieezell/received_events","type":"User","site_admin":false},"repo":{"id":41463886,"name":"CodeIgniter4","full_name":"lonnieezell/CodeIgniter4","owner":{"login":"lonnieezell","id":51931,"avatar_url":"https://avatars.githubusercontent.com/u/51931?v=3","gravatar_id":"","url":"https://api.github.com/users/lonnieezell","html_url":"https://github.com/lonnieezell","followers_url":"https://api.github.com/users/lonnieezell/followers","following_url":"https://api.github.com/users/lonnieezell/following{/other_user}","gists_url":"https://api.github.com/users/lonnieezell/gists{/gist_id}","starred_url":"https://api.github.com/users/lonnieezell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonnieezell/subscriptions","organizations_url":"https://api.github.com/users/lonnieezell/orgs","repos_url":"https://api.github.com/users/lonnieezell/repos","events_url":"https://api.github.com/users/lonnieezell/events{/privacy}","received_events_url":"https://api.github.com/users/lonnieezell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lonnieezell/CodeIgniter4","description":"","fork":false,"url":"https://api.github.com/repos/lonnieezell/CodeIgniter4","forks_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/forks","keys_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/teams","hooks_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/hooks","issue_events_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues/events{/number}","events_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/events","assignees_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/assignees{/user}","branches_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/branches{/branch}","tags_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/tags","blobs_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/git/refs{/sha}","trees_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/statuses/{sha}","languages_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/languages","stargazers_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/stargazers","contributors_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/contributors","subscribers_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/subscribers","subscription_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/subscription","commits_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/commits{/sha}","git_commits_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/git/commits{/sha}","comments_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/comments{/number}","issue_comment_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues/comments{/number}","contents_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/contents/{+path}","compare_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/merges","archive_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/downloads","issues_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues{/number}","pulls_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls{/number}","milestones_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/milestones{/number}","notifications_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/labels{/name}","releases_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/releases{/id}","deployments_url":"https://api.github.com/repos/lonnieezell/CodeIgniter4/deployments","created_at":"2015-08-27T03:32:45Z","updated_at":"2016-05-24T04:05:24Z","pushed_at":"2016-05-24T02:59:25Z","git_url":"git://github.com/lonnieezell/CodeIgniter4.git","ssh_url":"git@github.com:lonnieezell/CodeIgniter4.git","clone_url":"https://github.com/lonnieezell/CodeIgniter4.git","svn_url":"https://github.com/lonnieezell/CodeIgniter4","homepage":null,"size":3101,"stargazers_count":90,"watchers_count":90,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":11,"forks":33,"open_issues":11,"watchers":90,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79"},"html":{"href":"https://github.com/lonnieezell/CodeIgniter4/pull/79"},"issue":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues/79"},"comments":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/lonnieezell/CodeIgniter4/statuses/bd66d5bafcd0c91eb3525e19106dfe741538b3be"}}}}
{"actor":{"display_login":"jim-parry"}}