{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/kura/pulls/comments/64062410","id":64062410,"diff_hunk":"@@ -156,4 +154,58 @@ public static String getHostapdConfigFileName(String ifaceName) {\n \t\t}\n \t\treturn sb.toString();\n \t}\n+\t\n+\tprivate static String privGetHostapdConfigFileName(String ifaceName) {","path":"kura/org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/wifi/HostapdManager.java","position":115,"original_position":115,"commit_id":"6d4d56a84f418d234ea72087879c518a28d8910e","original_commit_id":"6d4d56a84f418d234ea72087879c518a28d8910e","user":{"login":"MMaiero","id":10448126,"avatar_url":"https://avatars.githubusercontent.com/u/10448126?v=3","gravatar_id":"","url":"https://api.github.com/users/MMaiero","html_url":"https://github.com/MMaiero","followers_url":"https://api.github.com/users/MMaiero/followers","following_url":"https://api.github.com/users/MMaiero/following{/other_user}","gists_url":"https://api.github.com/users/MMaiero/gists{/gist_id}","starred_url":"https://api.github.com/users/MMaiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MMaiero/subscriptions","organizations_url":"https://api.github.com/users/MMaiero/orgs","repos_url":"https://api.github.com/users/MMaiero/repos","events_url":"https://api.github.com/users/MMaiero/events{/privacy}","received_events_url":"https://api.github.com/users/MMaiero/received_events","type":"User","site_admin":false},"body":"@ibinshtok do you think we could merge the privGetHostapdConfigFileName with the already existing getHostapdConfigFileName? Maybe checking if a certain path exists and returning the correct path back. Is it feasible?","created_at":"2016-05-20T15:42:22Z","updated_at":"2016-05-20T15:42:22Z","html_url":"https://github.com/eclipse/kura/pull/225#discussion_r64062410","pull_request_url":"https://api.github.com/repos/eclipse/kura/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/eclipse/kura/pulls/comments/64062410"},"html":{"href":"https://github.com/eclipse/kura/pull/225#discussion_r64062410"},"pull_request":{"href":"https://api.github.com/repos/eclipse/kura/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/kura/pulls/225","id":70608899,"html_url":"https://github.com/eclipse/kura/pull/225","diff_url":"https://github.com/eclipse/kura/pull/225.diff","patch_url":"https://github.com/eclipse/kura/pull/225.patch","issue_url":"https://api.github.com/repos/eclipse/kura/issues/225","number":225,"state":"open","locked":false,"title":"Fix wifi config hide passwords","user":{"login":"ibinshtok","id":1242271,"avatar_url":"https://avatars.githubusercontent.com/u/1242271?v=3","gravatar_id":"","url":"https://api.github.com/users/ibinshtok","html_url":"https://github.com/ibinshtok","followers_url":"https://api.github.com/users/ibinshtok/followers","following_url":"https://api.github.com/users/ibinshtok/following{/other_user}","gists_url":"https://api.github.com/users/ibinshtok/gists{/gist_id}","starred_url":"https://api.github.com/users/ibinshtok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibinshtok/subscriptions","organizations_url":"https://api.github.com/users/ibinshtok/orgs","repos_url":"https://api.github.com/users/ibinshtok/repos","events_url":"https://api.github.com/users/ibinshtok/events{/privacy}","received_events_url":"https://api.github.com/users/ibinshtok/received_events","type":"User","site_admin":false},"body":"@MMaiero, can you verify this, please? I have tested it on my RG 10-11 having wlan0 in AP mode and wlan1 in Station mode. Both hostapd and wpa-supplicant used respective config files from the /tmp folder which were removed after startup. Respective configuration files in the /etc/ directory have passwords encrypted. ","created_at":"2016-05-18T22:18:29Z","updated_at":"2016-05-20T15:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"594eecbbc541be15928355542dacbb78fd4753ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/kura/pulls/225/commits","review_comments_url":"https://api.github.com/repos/eclipse/kura/pulls/225/comments","review_comment_url":"https://api.github.com/repos/eclipse/kura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/kura/issues/225/comments","statuses_url":"https://api.github.com/repos/eclipse/kura/statuses/6d4d56a84f418d234ea72087879c518a28d8910e","head":{"label":"eclipse:fix-wifi-config-hide-passwords","ref":"fix-wifi-config-hide-passwords","sha":"6d4d56a84f418d234ea72087879c518a28d8910e","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15237269,"name":"kura","full_name":"eclipse/kura","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/kura","description":"Kura project","fork":false,"url":"https://api.github.com/repos/eclipse/kura","forks_url":"https://api.github.com/repos/eclipse/kura/forks","keys_url":"https://api.github.com/repos/eclipse/kura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/kura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/kura/teams","hooks_url":"https://api.github.com/repos/eclipse/kura/hooks","issue_events_url":"https://api.github.com/repos/eclipse/kura/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/kura/events","assignees_url":"https://api.github.com/repos/eclipse/kura/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/kura/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/kura/tags","blobs_url":"https://api.github.com/repos/eclipse/kura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/kura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/kura/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/kura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/kura/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/kura/languages","stargazers_url":"https://api.github.com/repos/eclipse/kura/stargazers","contributors_url":"https://api.github.com/repos/eclipse/kura/contributors","subscribers_url":"https://api.github.com/repos/eclipse/kura/subscribers","subscription_url":"https://api.github.com/repos/eclipse/kura/subscription","commits_url":"https://api.github.com/repos/eclipse/kura/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/kura/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/kura/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/kura/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/kura/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/kura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/kura/merges","archive_url":"https://api.github.com/repos/eclipse/kura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/kura/downloads","issues_url":"https://api.github.com/repos/eclipse/kura/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/kura/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/kura/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/kura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/kura/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/kura/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/kura/deployments","created_at":"2013-12-16T21:07:20Z","updated_at":"2016-05-17T04:21:52Z","pushed_at":"2016-05-20T15:38:43Z","git_url":"git://github.com/eclipse/kura.git","ssh_url":"git@github.com:eclipse/kura.git","clone_url":"https://github.com/eclipse/kura.git","svn_url":"https://github.com/eclipse/kura","homepage":null,"size":91494,"stargazers_count":87,"watchers_count":87,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":92,"forks":72,"open_issues":92,"watchers":87,"default_branch":"develop"}},"base":{"label":"eclipse:develop","ref":"develop","sha":"43f7e1409b0bc6052cc5fe62d394dfe3ba7a799d","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15237269,"name":"kura","full_name":"eclipse/kura","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/kura","description":"Kura project","fork":false,"url":"https://api.github.com/repos/eclipse/kura","forks_url":"https://api.github.com/repos/eclipse/kura/forks","keys_url":"https://api.github.com/repos/eclipse/kura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/kura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/kura/teams","hooks_url":"https://api.github.com/repos/eclipse/kura/hooks","issue_events_url":"https://api.github.com/repos/eclipse/kura/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/kura/events","assignees_url":"https://api.github.com/repos/eclipse/kura/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/kura/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/kura/tags","blobs_url":"https://api.github.com/repos/eclipse/kura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/kura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/kura/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/kura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/kura/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/kura/languages","stargazers_url":"https://api.github.com/repos/eclipse/kura/stargazers","contributors_url":"https://api.github.com/repos/eclipse/kura/contributors","subscribers_url":"https://api.github.com/repos/eclipse/kura/subscribers","subscription_url":"https://api.github.com/repos/eclipse/kura/subscription","commits_url":"https://api.github.com/repos/eclipse/kura/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/kura/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/kura/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/kura/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/kura/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/kura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/kura/merges","archive_url":"https://api.github.com/repos/eclipse/kura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/kura/downloads","issues_url":"https://api.github.com/repos/eclipse/kura/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/kura/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/kura/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/kura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/kura/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/kura/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/kura/deployments","created_at":"2013-12-16T21:07:20Z","updated_at":"2016-05-17T04:21:52Z","pushed_at":"2016-05-20T15:38:43Z","git_url":"git://github.com/eclipse/kura.git","ssh_url":"git@github.com:eclipse/kura.git","clone_url":"https://github.com/eclipse/kura.git","svn_url":"https://github.com/eclipse/kura","homepage":null,"size":91494,"stargazers_count":87,"watchers_count":87,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":92,"forks":72,"open_issues":92,"watchers":87,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/kura/pulls/225"},"html":{"href":"https://github.com/eclipse/kura/pull/225"},"issue":{"href":"https://api.github.com/repos/eclipse/kura/issues/225"},"comments":{"href":"https://api.github.com/repos/eclipse/kura/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/kura/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/kura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/kura/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/kura/statuses/6d4d56a84f418d234ea72087879c518a28d8910e"}}}}
{"actor":{"display_login":"MMaiero"}}