{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/48824696","id":48824696,"diff_hunk":"@@ -75,10 +75,20 @@ def sanity_check_step(self):\n         jar_files = ['picard']\n         if LooseVersion(self.version) < LooseVersion('1.115'):\n             jar_files.append('sam')\n-        custom_paths = {\n-            'files': [\"%s-%s.jar\" % (x, self.version) for x in jar_files],\n-            'dirs': [],\n-        }\n+        if LooseVersion(self.version) < LooseVersion('1.124'):\n+            custom_paths = {\n+                'files': [\"%s-%s.jar\" % (x, self.version) for x in jar_files],\n+                'dirs': [],\n+            }\n+        else:\n+            custom_paths = {\n+                'files': [\n+                    'picard.jar',\n+                    'picard-lib.jar',\n+                    'htsjdk-%s.jar' % self.version,","path":"easybuild/easyblocks/p/picard.py","position":18,"original_position":18,"commit_id":"eb8b4f71a76e043a3d121758bbe66b16cd993aea","original_commit_id":"eb8b4f71a76e043a3d121758bbe66b16cd993aea","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"rather than copy-pasting this whole block, it would be better to change the logic that defines the `jar_files` list?\r\n\r\nHow familiar are you with Python @nathanhaigh? Let us know if you're up for this.","created_at":"2016-01-05T09:11:10Z","updated_at":"2016-01-05T09:11:10Z","html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796#discussion_r48824696","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments/48824696"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/796#discussion_r48824696"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796","id":55048600,"html_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796","diff_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796.diff","patch_url":"https://github.com/hpcugent/easybuild-easyblocks/pull/796.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796","number":796,"state":"open","locked":false,"title":"Updated custom_paths for picard-1.124 and above","user":{"login":"nathanhaigh","id":2037575,"avatar_url":"https://avatars.githubusercontent.com/u/2037575?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhaigh","html_url":"https://github.com/nathanhaigh","followers_url":"https://api.github.com/users/nathanhaigh/followers","following_url":"https://api.github.com/users/nathanhaigh/following{/other_user}","gists_url":"https://api.github.com/users/nathanhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhaigh/subscriptions","organizations_url":"https://api.github.com/users/nathanhaigh/orgs","repos_url":"https://api.github.com/users/nathanhaigh/repos","events_url":"https://api.github.com/users/nathanhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhaigh/received_events","type":"User","site_admin":false},"body":"A restructure of picard at v1.124 means only a single `picard.jar` file is created","created_at":"2016-01-05T02:35:55Z","updated_at":"2016-01-05T09:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5319f45d84216b71b6c256956bed512a1c92c3fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/eb8b4f71a76e043a3d121758bbe66b16cd993aea","head":{"label":"nathanhaigh:picard-1.124","ref":"picard-1.124","sha":"eb8b4f71a76e043a3d121758bbe66b16cd993aea","user":{"login":"nathanhaigh","id":2037575,"avatar_url":"https://avatars.githubusercontent.com/u/2037575?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhaigh","html_url":"https://github.com/nathanhaigh","followers_url":"https://api.github.com/users/nathanhaigh/followers","following_url":"https://api.github.com/users/nathanhaigh/following{/other_user}","gists_url":"https://api.github.com/users/nathanhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhaigh/subscriptions","organizations_url":"https://api.github.com/users/nathanhaigh/orgs","repos_url":"https://api.github.com/users/nathanhaigh/repos","events_url":"https://api.github.com/users/nathanhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhaigh/received_events","type":"User","site_admin":false},"repo":{"id":49033316,"name":"easybuild-easyblocks","full_name":"nathanhaigh/easybuild-easyblocks","owner":{"login":"nathanhaigh","id":2037575,"avatar_url":"https://avatars.githubusercontent.com/u/2037575?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanhaigh","html_url":"https://github.com/nathanhaigh","followers_url":"https://api.github.com/users/nathanhaigh/followers","following_url":"https://api.github.com/users/nathanhaigh/following{/other_user}","gists_url":"https://api.github.com/users/nathanhaigh/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanhaigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanhaigh/subscriptions","organizations_url":"https://api.github.com/users/nathanhaigh/orgs","repos_url":"https://api.github.com/users/nathanhaigh/repos","events_url":"https://api.github.com/users/nathanhaigh/events{/privacy}","received_events_url":"https://api.github.com/users/nathanhaigh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nathanhaigh/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":true,"url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks","forks_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/nathanhaigh/easybuild-easyblocks/releases{/id}","created_at":"2016-01-05T01:14:20Z","updated_at":"2016-01-05T01:14:23Z","pushed_at":"2016-01-05T02:35:33Z","git_url":"git://github.com/nathanhaigh/easybuild-easyblocks.git","ssh_url":"git@github.com:nathanhaigh/easybuild-easyblocks.git","clone_url":"https://github.com/nathanhaigh/easybuild-easyblocks.git","svn_url":"https://github.com/nathanhaigh/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":8259,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"db456c990732e77d236a18030cdf2d1c2a70d77a","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":6228378,"name":"easybuild-easyblocks","full_name":"hpcugent/easybuild-easyblocks","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-easyblocks","description":"Collection of easyblocks that implement support for building and installing software with EasyBuild.","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks","forks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/releases{/id}","created_at":"2012-10-15T14:31:19Z","updated_at":"2015-12-08T11:13:40Z","pushed_at":"2016-01-05T02:35:56Z","git_url":"git://github.com/hpcugent/easybuild-easyblocks.git","ssh_url":"git@github.com:hpcugent/easybuild-easyblocks.git","clone_url":"https://github.com/hpcugent/easybuild-easyblocks.git","svn_url":"https://github.com/hpcugent/easybuild-easyblocks","homepage":"http://hpcugent.github.com/easybuild/","size":9541,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":121,"forks":88,"open_issues":121,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796"},"html":{"href":"https://github.com/hpcugent/easybuild-easyblocks/pull/796"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/issues/796/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/pulls/796/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyblocks/statuses/eb8b4f71a76e043a3d121758bbe66b16cd993aea"}}}}