{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16235","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16235/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16235/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16235/events","html_url":"https://github.com/apache/spark/pull/16235","id":194626394,"number":16235,"title":"[SPARK-18745][SQL] Fix signed integer overflow due to toInt cast","user":{"login":"kiszk","id":1315079,"avatar_url":"https://avatars.githubusercontent.com/u/1315079?v=3","gravatar_id":"","url":"https://api.github.com/users/kiszk","html_url":"https://github.com/kiszk","followers_url":"https://api.github.com/users/kiszk/followers","following_url":"https://api.github.com/users/kiszk/following{/other_user}","gists_url":"https://api.github.com/users/kiszk/gists{/gist_id}","starred_url":"https://api.github.com/users/kiszk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiszk/subscriptions","organizations_url":"https://api.github.com/users/kiszk/orgs","repos_url":"https://api.github.com/users/kiszk/repos","events_url":"https://api.github.com/users/kiszk/events{/privacy}","received_events_url":"https://api.github.com/users/kiszk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-09T15:40:43Z","updated_at":"2016-12-09T18:37:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16235","html_url":"https://github.com/apache/spark/pull/16235","diff_url":"https://github.com/apache/spark/pull/16235.diff","patch_url":"https://github.com/apache/spark/pull/16235.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR avoids that a result of a cast `toInt` is negative due to signed integer overflow (e.g. 0x0000_0000_1???????L.toInt < 0 ). This PR performs casts after we can ensure the value is within range of signed integer (the result of `max(array.length, ???)` is always integer).\r\n\r\n## How was this patch tested?\r\n\r\nManually executed query68 of TPC-DS with 100TB\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/266087974","html_url":"https://github.com/apache/spark/pull/16235#issuecomment-266087974","issue_url":"https://api.github.com/repos/apache/spark/issues/16235","id":266087974,"user":{"login":"hvanhovell","id":9616802,"avatar_url":"https://avatars.githubusercontent.com/u/9616802?v=3","gravatar_id":"","url":"https://api.github.com/users/hvanhovell","html_url":"https://github.com/hvanhovell","followers_url":"https://api.github.com/users/hvanhovell/followers","following_url":"https://api.github.com/users/hvanhovell/following{/other_user}","gists_url":"https://api.github.com/users/hvanhovell/gists{/gist_id}","starred_url":"https://api.github.com/users/hvanhovell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvanhovell/subscriptions","organizations_url":"https://api.github.com/users/hvanhovell/orgs","repos_url":"https://api.github.com/users/hvanhovell/repos","events_url":"https://api.github.com/users/hvanhovell/events{/privacy}","received_events_url":"https://api.github.com/users/hvanhovell/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T18:37:32Z","updated_at":"2016-12-09T18:37:32Z","body":"Ok, lets not do that for now."}}
{"actor":{"display_login":"hvanhovell"}}