{"action":"closed","number":146,"pull_request":{"url":"https://api.github.com/repos/yahoo/fetchr/pulls/146","id":70513702,"html_url":"https://github.com/yahoo/fetchr/pull/146","diff_url":"https://github.com/yahoo/fetchr/pull/146.diff","patch_url":"https://github.com/yahoo/fetchr/pull/146.patch","issue_url":"https://api.github.com/repos/yahoo/fetchr/issues/146","number":146,"state":"closed","locked":false,"title":"Invalid resource error handling","user":{"login":"narkq","id":705650,"avatar_url":"https://avatars.githubusercontent.com/u/705650?v=3","gravatar_id":"","url":"https://api.github.com/users/narkq","html_url":"https://github.com/narkq","followers_url":"https://api.github.com/users/narkq/followers","following_url":"https://api.github.com/users/narkq/following{/other_user}","gists_url":"https://api.github.com/users/narkq/gists{/gist_id}","starred_url":"https://api.github.com/users/narkq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narkq/subscriptions","organizations_url":"https://api.github.com/users/narkq/orgs","repos_url":"https://api.github.com/users/narkq/repos","events_url":"https://api.github.com/users/narkq/events{/privacy}","received_events_url":"https://api.github.com/users/narkq/received_events","type":"User","site_admin":false},"body":"In a server-side fetcher, there is currently no way to handle any error that's thrown by `Fetcher.getService` (since it gets executed via `setImmediate` inside of a promise constructor).\r\nIn particular, if you specify an invalid resource name (and that's easy to do for the new people on team in a substantially complex app), an error ends up in `uncaughtException` handler (or crashes the server).","created_at":"2016-05-18T11:49:33Z","updated_at":"2016-05-18T23:26:02Z","closed_at":"2016-05-18T23:26:02Z","merged_at":"2016-05-18T23:26:02Z","merge_commit_sha":"bd477c3c738bef841b522e6274259ad2cbd76289","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/fetchr/pulls/146/commits","review_comments_url":"https://api.github.com/repos/yahoo/fetchr/pulls/146/comments","review_comment_url":"https://api.github.com/repos/yahoo/fetchr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/fetchr/issues/146/comments","statuses_url":"https://api.github.com/repos/yahoo/fetchr/statuses/b37b8ab731c9e14e2c317f64992bdd7015d3a39e","head":{"label":"narkq:invalid-resource-error-handling","ref":"invalid-resource-error-handling","sha":"b37b8ab731c9e14e2c317f64992bdd7015d3a39e","user":{"login":"narkq","id":705650,"avatar_url":"https://avatars.githubusercontent.com/u/705650?v=3","gravatar_id":"","url":"https://api.github.com/users/narkq","html_url":"https://github.com/narkq","followers_url":"https://api.github.com/users/narkq/followers","following_url":"https://api.github.com/users/narkq/following{/other_user}","gists_url":"https://api.github.com/users/narkq/gists{/gist_id}","starred_url":"https://api.github.com/users/narkq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narkq/subscriptions","organizations_url":"https://api.github.com/users/narkq/orgs","repos_url":"https://api.github.com/users/narkq/repos","events_url":"https://api.github.com/users/narkq/events{/privacy}","received_events_url":"https://api.github.com/users/narkq/received_events","type":"User","site_admin":false},"repo":{"id":59109390,"name":"fetchr","full_name":"narkq/fetchr","owner":{"login":"narkq","id":705650,"avatar_url":"https://avatars.githubusercontent.com/u/705650?v=3","gravatar_id":"","url":"https://api.github.com/users/narkq","html_url":"https://github.com/narkq","followers_url":"https://api.github.com/users/narkq/followers","following_url":"https://api.github.com/users/narkq/following{/other_user}","gists_url":"https://api.github.com/users/narkq/gists{/gist_id}","starred_url":"https://api.github.com/users/narkq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narkq/subscriptions","organizations_url":"https://api.github.com/users/narkq/orgs","repos_url":"https://api.github.com/users/narkq/repos","events_url":"https://api.github.com/users/narkq/events{/privacy}","received_events_url":"https://api.github.com/users/narkq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/narkq/fetchr","description":"Universal data access layer for web applications.","fork":true,"url":"https://api.github.com/repos/narkq/fetchr","forks_url":"https://api.github.com/repos/narkq/fetchr/forks","keys_url":"https://api.github.com/repos/narkq/fetchr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/narkq/fetchr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/narkq/fetchr/teams","hooks_url":"https://api.github.com/repos/narkq/fetchr/hooks","issue_events_url":"https://api.github.com/repos/narkq/fetchr/issues/events{/number}","events_url":"https://api.github.com/repos/narkq/fetchr/events","assignees_url":"https://api.github.com/repos/narkq/fetchr/assignees{/user}","branches_url":"https://api.github.com/repos/narkq/fetchr/branches{/branch}","tags_url":"https://api.github.com/repos/narkq/fetchr/tags","blobs_url":"https://api.github.com/repos/narkq/fetchr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/narkq/fetchr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/narkq/fetchr/git/refs{/sha}","trees_url":"https://api.github.com/repos/narkq/fetchr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/narkq/fetchr/statuses/{sha}","languages_url":"https://api.github.com/repos/narkq/fetchr/languages","stargazers_url":"https://api.github.com/repos/narkq/fetchr/stargazers","contributors_url":"https://api.github.com/repos/narkq/fetchr/contributors","subscribers_url":"https://api.github.com/repos/narkq/fetchr/subscribers","subscription_url":"https://api.github.com/repos/narkq/fetchr/subscription","commits_url":"https://api.github.com/repos/narkq/fetchr/commits{/sha}","git_commits_url":"https://api.github.com/repos/narkq/fetchr/git/commits{/sha}","comments_url":"https://api.github.com/repos/narkq/fetchr/comments{/number}","issue_comment_url":"https://api.github.com/repos/narkq/fetchr/issues/comments{/number}","contents_url":"https://api.github.com/repos/narkq/fetchr/contents/{+path}","compare_url":"https://api.github.com/repos/narkq/fetchr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/narkq/fetchr/merges","archive_url":"https://api.github.com/repos/narkq/fetchr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/narkq/fetchr/downloads","issues_url":"https://api.github.com/repos/narkq/fetchr/issues{/number}","pulls_url":"https://api.github.com/repos/narkq/fetchr/pulls{/number}","milestones_url":"https://api.github.com/repos/narkq/fetchr/milestones{/number}","notifications_url":"https://api.github.com/repos/narkq/fetchr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/narkq/fetchr/labels{/name}","releases_url":"https://api.github.com/repos/narkq/fetchr/releases{/id}","deployments_url":"https://api.github.com/repos/narkq/fetchr/deployments","created_at":"2016-05-18T11:27:10Z","updated_at":"2016-05-18T11:27:11Z","pushed_at":"2016-05-18T11:37:07Z","git_url":"git://github.com/narkq/fetchr.git","ssh_url":"git@github.com:narkq/fetchr.git","clone_url":"https://github.com/narkq/fetchr.git","svn_url":"https://github.com/narkq/fetchr","homepage":"","size":342,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"55d520f7c70ec1779ca31c867e28126bbda735a1","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":21044474,"name":"fetchr","full_name":"yahoo/fetchr","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/fetchr","description":"Universal data access layer for web applications.","fork":false,"url":"https://api.github.com/repos/yahoo/fetchr","forks_url":"https://api.github.com/repos/yahoo/fetchr/forks","keys_url":"https://api.github.com/repos/yahoo/fetchr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/fetchr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/fetchr/teams","hooks_url":"https://api.github.com/repos/yahoo/fetchr/hooks","issue_events_url":"https://api.github.com/repos/yahoo/fetchr/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/fetchr/events","assignees_url":"https://api.github.com/repos/yahoo/fetchr/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/fetchr/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/fetchr/tags","blobs_url":"https://api.github.com/repos/yahoo/fetchr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/fetchr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/fetchr/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/fetchr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/fetchr/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/fetchr/languages","stargazers_url":"https://api.github.com/repos/yahoo/fetchr/stargazers","contributors_url":"https://api.github.com/repos/yahoo/fetchr/contributors","subscribers_url":"https://api.github.com/repos/yahoo/fetchr/subscribers","subscription_url":"https://api.github.com/repos/yahoo/fetchr/subscription","commits_url":"https://api.github.com/repos/yahoo/fetchr/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/fetchr/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/fetchr/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/fetchr/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/fetchr/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/fetchr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/fetchr/merges","archive_url":"https://api.github.com/repos/yahoo/fetchr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/fetchr/downloads","issues_url":"https://api.github.com/repos/yahoo/fetchr/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/fetchr/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/fetchr/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/fetchr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/fetchr/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/fetchr/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/fetchr/deployments","created_at":"2014-06-20T16:22:53Z","updated_at":"2016-05-12T09:27:15Z","pushed_at":"2016-05-18T23:26:02Z","git_url":"git://github.com/yahoo/fetchr.git","ssh_url":"git@github.com:yahoo/fetchr.git","clone_url":"https://github.com/yahoo/fetchr.git","svn_url":"https://github.com/yahoo/fetchr","homepage":"","size":361,"stargazers_count":319,"watchers_count":319,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":10,"forks":79,"open_issues":10,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/fetchr/pulls/146"},"html":{"href":"https://github.com/yahoo/fetchr/pull/146"},"issue":{"href":"https://api.github.com/repos/yahoo/fetchr/issues/146"},"comments":{"href":"https://api.github.com/repos/yahoo/fetchr/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/fetchr/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/fetchr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/fetchr/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/fetchr/statuses/b37b8ab731c9e14e2c317f64992bdd7015d3a39e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lingyan","id":1414235,"avatar_url":"https://avatars.githubusercontent.com/u/1414235?v=3","gravatar_id":"","url":"https://api.github.com/users/lingyan","html_url":"https://github.com/lingyan","followers_url":"https://api.github.com/users/lingyan/followers","following_url":"https://api.github.com/users/lingyan/following{/other_user}","gists_url":"https://api.github.com/users/lingyan/gists{/gist_id}","starred_url":"https://api.github.com/users/lingyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lingyan/subscriptions","organizations_url":"https://api.github.com/users/lingyan/orgs","repos_url":"https://api.github.com/users/lingyan/repos","events_url":"https://api.github.com/users/lingyan/events{/privacy}","received_events_url":"https://api.github.com/users/lingyan/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":88,"deletions":2,"changed_files":3}}