{"action":"created","issue":{"url":"https://api.github.com/repos/RangelReale/osin/issues/135","repository_url":"https://api.github.com/repos/RangelReale/osin","labels_url":"https://api.github.com/repos/RangelReale/osin/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/RangelReale/osin/issues/135/comments","events_url":"https://api.github.com/repos/RangelReale/osin/issues/135/events","html_url":"https://github.com/RangelReale/osin/issues/135","id":186955357,"number":135,"title":"Remove* errors are ignored","user":{"login":"bodhi","id":28731,"avatar_url":"https://avatars.githubusercontent.com/u/28731?v=3","gravatar_id":"","url":"https://api.github.com/users/bodhi","html_url":"https://github.com/bodhi","followers_url":"https://api.github.com/users/bodhi/followers","following_url":"https://api.github.com/users/bodhi/following{/other_user}","gists_url":"https://api.github.com/users/bodhi/gists{/gist_id}","starred_url":"https://api.github.com/users/bodhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodhi/subscriptions","organizations_url":"https://api.github.com/users/bodhi/orgs","repos_url":"https://api.github.com/users/bodhi/repos","events_url":"https://api.github.com/users/bodhi/events{/privacy}","received_events_url":"https://api.github.com/users/bodhi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-03T00:28:48Z","updated_at":"2016-11-18T16:59:30Z","closed_at":null,"body":"(Apologies, I'd make a PR to fix it, but I'm in the middle of something else right now)\r\n\r\nEach of `RemoveAuthorize`, `RemoveAccess` and `RemoveRefresh` are [defined to return an `error`](https://github.com/RangelReale/osin/blob/813fe40b77317edd7a392ae58c00338f9006181d/storage.go), but [the error is ignored in `server.FinishAccessRequest`](https://github.com/RangelReale/osin/blob/813fe40b77317edd7a392ae58c00338f9006181d/access.go#L504-L515)"},"comment":{"url":"https://api.github.com/repos/RangelReale/osin/issues/comments/261583457","html_url":"https://github.com/RangelReale/osin/issues/135#issuecomment-261583457","issue_url":"https://api.github.com/repos/RangelReale/osin/issues/135","id":261583457,"user":{"login":"fgrosse","id":733004,"avatar_url":"https://avatars.githubusercontent.com/u/733004?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrosse","html_url":"https://github.com/fgrosse","followers_url":"https://api.github.com/users/fgrosse/followers","following_url":"https://api.github.com/users/fgrosse/following{/other_user}","gists_url":"https://api.github.com/users/fgrosse/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrosse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrosse/subscriptions","organizations_url":"https://api.github.com/users/fgrosse/orgs","repos_url":"https://api.github.com/users/fgrosse/repos","events_url":"https://api.github.com/users/fgrosse/events{/privacy}","received_events_url":"https://api.github.com/users/fgrosse/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T16:59:30Z","updated_at":"2016-11-18T16:59:30Z","body":"I was also considering removing the return value from the interface and\nwould prefer that very much.\n\nInitially I was thinking this wouldn't work for to the BC break but\nactually there are BC breaks listed at the top of the current change list\nso hopefully this is an option :)\n\nPeter Schultz <notifications@github.com> schrieb am Fr., 18. Nov. 2016,\n17:52:\n\n> My comment above had an unfortunate typo. I updated it accordingly. To\n> clarify: OSIN is a library. It should not impose its opinions about logging\n> on its users. Users of that library should decide if and how to do logging.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/RangelReale/osin/issues/135#issuecomment-261581446>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAsvTDPeXz0b4qZ9itYKR6xb5AZiZ69eks5q_dexgaJpZM4Kn5qm>\n> .\n>\n"}}
{"actor":{"display_login":"fgrosse"}}