{"action":"opened","number":1661,"pull_request":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1661","id":99830622,"html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1661","diff_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1661.diff","patch_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1661.patch","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1661","number":1661,"state":"open","locked":false,"title":"Stop annoying popup window on swipe/move ","user":{"login":"ultrafunkamsterdam","id":21027969,"avatar_url":"https://avatars.githubusercontent.com/u/21027969?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrafunkamsterdam","html_url":"https://github.com/ultrafunkamsterdam","followers_url":"https://api.github.com/users/ultrafunkamsterdam/followers","following_url":"https://api.github.com/users/ultrafunkamsterdam/following{/other_user}","gists_url":"https://api.github.com/users/ultrafunkamsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrafunkamsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrafunkamsterdam/subscriptions","organizations_url":"https://api.github.com/users/ultrafunkamsterdam/orgs","repos_url":"https://api.github.com/users/ultrafunkamsterdam/repos","events_url":"https://api.github.com/users/ultrafunkamsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/ultrafunkamsterdam/received_events","type":"User","site_admin":false},"body":"**Provide a general summary of your changes in the Title above**\r\nOn mobile devices, especially on larger/denser maps, zooming or swiping often results in multiple info-modals. I think this is annoying. \r\nIf you want information about a pokemon,gym or pokestop you should be able to open info modal by just tapping it. \r\n\r\n**Description**\r\nModified map.js\r\nPlaced  mouseover eventlistener in an  if-statement\r\n\r\n` \r\nif ( ! isTouchDevice() && ! isMobileDevice()) {\r\n marker.addListener('mouseover', function () {\r\n    marker.infoWindow.open(map, marker)\r\n    clearSelection()\r\n    updateLabelDiffTime()\r\n  })\r\n  }\r\n`\r\n\r\nCould easily be reversed by removing the if statement in case you absolutely need the annoying popups on swipe so hard.\r\n\r\n**Motivation and Context**\r\n_Why is this change required? What problem does it solve?_\r\nIt's not required, but solves a lot of irritation and phone trhow-aways, indirectly makes traffic safer too 👍 \r\n\r\n**How Has This Been Tested?**\r\n'implemented' it in my map and tested it on iPhone6 (chrome,safari), Galaxy S7 (chrome, samsung stock browser). All working fine. Also on desktop it works fine.\r\n\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n<!--  NOTE: In order to check code style locally and avoid having your build rejected by Travis, -->\r\n<!--  run the following commands before you commit: `flake8 .` and `npm run lint`. Fix any -->\r\n<!--  issues they point out. Note also that flake's NOQA is disabled on Travis. -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.","created_at":"2017-01-01T20:56:26Z","updated_at":"2017-01-01T20:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1661/commits","review_comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1661/comments","review_comment_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1661/comments","statuses_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/statuses/44ba582debd3392517c2ed2b60ffbd753694b2a4","head":{"label":"ultrafunkamsterdam:no-infowindow-on-swipetouch","ref":"no-infowindow-on-swipetouch","sha":"44ba582debd3392517c2ed2b60ffbd753694b2a4","user":{"login":"ultrafunkamsterdam","id":21027969,"avatar_url":"https://avatars.githubusercontent.com/u/21027969?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrafunkamsterdam","html_url":"https://github.com/ultrafunkamsterdam","followers_url":"https://api.github.com/users/ultrafunkamsterdam/followers","following_url":"https://api.github.com/users/ultrafunkamsterdam/following{/other_user}","gists_url":"https://api.github.com/users/ultrafunkamsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrafunkamsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrafunkamsterdam/subscriptions","organizations_url":"https://api.github.com/users/ultrafunkamsterdam/orgs","repos_url":"https://api.github.com/users/ultrafunkamsterdam/repos","events_url":"https://api.github.com/users/ultrafunkamsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/ultrafunkamsterdam/received_events","type":"User","site_admin":false},"repo":{"id":74055125,"name":"PokemonGo-Map-V2","full_name":"ultrafunkamsterdam/PokemonGo-Map-V2","owner":{"login":"ultrafunkamsterdam","id":21027969,"avatar_url":"https://avatars.githubusercontent.com/u/21027969?v=3","gravatar_id":"","url":"https://api.github.com/users/ultrafunkamsterdam","html_url":"https://github.com/ultrafunkamsterdam","followers_url":"https://api.github.com/users/ultrafunkamsterdam/followers","following_url":"https://api.github.com/users/ultrafunkamsterdam/following{/other_user}","gists_url":"https://api.github.com/users/ultrafunkamsterdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ultrafunkamsterdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultrafunkamsterdam/subscriptions","organizations_url":"https://api.github.com/users/ultrafunkamsterdam/orgs","repos_url":"https://api.github.com/users/ultrafunkamsterdam/repos","events_url":"https://api.github.com/users/ultrafunkamsterdam/events{/privacy}","received_events_url":"https://api.github.com/users/ultrafunkamsterdam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ultrafunkamsterdam/PokemonGo-Map-V2","description":"With Hashing server support! For easy installation on deb/ubuntu:  [[ -f easy-install.sh ]] && rm easy-install.sh ; wget https://raw.githubusercontent.com/ultrafunkamsterdam/PokemonGo-Map-V2/develop/easy-install.sh ; sudo chmod 755 easy-install.sh && bash ./easy-install.sh","fork":true,"url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2","forks_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/forks","keys_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/teams","hooks_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/hooks","issue_events_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/issues/events{/number}","events_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/events","assignees_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/assignees{/user}","branches_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/branches{/branch}","tags_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/tags","blobs_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/statuses/{sha}","languages_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/languages","stargazers_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/stargazers","contributors_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/contributors","subscribers_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/subscribers","subscription_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/subscription","commits_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/contents/{+path}","compare_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/merges","archive_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/downloads","issues_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/issues{/number}","pulls_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/pulls{/number}","milestones_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/milestones{/number}","notifications_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/labels{/name}","releases_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/releases{/id}","deployments_url":"https://api.github.com/repos/ultrafunkamsterdam/PokemonGo-Map-V2/deployments","created_at":"2016-11-17T18:23:31Z","updated_at":"2017-01-01T14:21:16Z","pushed_at":"2017-01-01T20:49:13Z","git_url":"git://github.com/ultrafunkamsterdam/PokemonGo-Map-V2.git","ssh_url":"git@github.com:ultrafunkamsterdam/PokemonGo-Map-V2.git","clone_url":"https://github.com/ultrafunkamsterdam/PokemonGo-Map-V2.git","svn_url":"https://github.com/ultrafunkamsterdam/PokemonGo-Map-V2","homepage":"","size":24623,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"PokemonGoMap:develop","ref":"develop","sha":"2614e5da355004696527fb458db5f05470824f43","user":{"login":"PokemonGoMap","id":20848202,"avatar_url":"https://avatars.githubusercontent.com/u/20848202?v=3","gravatar_id":"","url":"https://api.github.com/users/PokemonGoMap","html_url":"https://github.com/PokemonGoMap","followers_url":"https://api.github.com/users/PokemonGoMap/followers","following_url":"https://api.github.com/users/PokemonGoMap/following{/other_user}","gists_url":"https://api.github.com/users/PokemonGoMap/gists{/gist_id}","starred_url":"https://api.github.com/users/PokemonGoMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokemonGoMap/subscriptions","organizations_url":"https://api.github.com/users/PokemonGoMap/orgs","repos_url":"https://api.github.com/users/PokemonGoMap/repos","events_url":"https://api.github.com/users/PokemonGoMap/events{/privacy}","received_events_url":"https://api.github.com/users/PokemonGoMap/received_events","type":"Organization","site_admin":false},"repo":{"id":64970925,"name":"PokemonGo-Map","full_name":"PokemonGoMap/PokemonGo-Map","owner":{"login":"PokemonGoMap","id":20848202,"avatar_url":"https://avatars.githubusercontent.com/u/20848202?v=3","gravatar_id":"","url":"https://api.github.com/users/PokemonGoMap","html_url":"https://github.com/PokemonGoMap","followers_url":"https://api.github.com/users/PokemonGoMap/followers","following_url":"https://api.github.com/users/PokemonGoMap/following{/other_user}","gists_url":"https://api.github.com/users/PokemonGoMap/gists{/gist_id}","starred_url":"https://api.github.com/users/PokemonGoMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PokemonGoMap/subscriptions","organizations_url":"https://api.github.com/users/PokemonGoMap/orgs","repos_url":"https://api.github.com/users/PokemonGoMap/repos","events_url":"https://api.github.com/users/PokemonGoMap/events{/privacy}","received_events_url":"https://api.github.com/users/PokemonGoMap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PokemonGoMap/PokemonGo-Map","description":"🌏 Live visualization of all the pokemon in your area... and more!","fork":false,"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","forks_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/forks","keys_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/teams","hooks_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/hooks","issue_events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/events{/number}","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/events","assignees_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/assignees{/user}","branches_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/branches{/branch}","tags_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/tags","blobs_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/refs{/sha}","trees_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/statuses/{sha}","languages_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/languages","stargazers_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/stargazers","contributors_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/contributors","subscribers_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/subscribers","subscription_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/subscription","commits_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/commits{/sha}","git_commits_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/git/commits{/sha}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/comments{/number}","issue_comment_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments{/number}","contents_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/contents/{+path}","compare_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/merges","archive_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/downloads","issues_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues{/number}","pulls_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls{/number}","milestones_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/milestones{/number}","notifications_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/labels{/name}","releases_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/releases{/id}","deployments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/deployments","created_at":"2016-08-04T22:18:49Z","updated_at":"2017-01-01T05:38:49Z","pushed_at":"2017-01-01T20:38:00Z","git_url":"git://github.com/PokemonGoMap/PokemonGo-Map.git","ssh_url":"git@github.com:PokemonGoMap/PokemonGo-Map.git","clone_url":"https://github.com/PokemonGoMap/PokemonGo-Map.git","svn_url":"https://github.com/PokemonGoMap/PokemonGo-Map","homepage":"","size":24599,"stargazers_count":2570,"watchers_count":2570,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1523,"mirror_url":null,"open_issues_count":243,"forks":1523,"open_issues":243,"watchers":2570,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1661"},"html":{"href":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1661"},"issue":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1661"},"comments":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1661/comments"},"review_comments":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1661/comments"},"review_comment":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1661/commits"},"statuses":{"href":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/statuses/44ba582debd3392517c2ed2b60ffbd753694b2a4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":27,"additions":119,"deletions":33,"changed_files":6}}
{"actor":{"display_login":"ultrafunkamsterdam"}}