{"action":"created","comment":{"url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/comments/76601719","id":76601719,"diff_hunk":"@@ -0,0 +1,45 @@\n+﻿using System;\n+using Microsoft.Xna.Framework;\n+using Microsoft.Xna.Framework.Graphics;\n+using TankDriver.Logic;\n+\n+namespace TankDriver.Models\n+{\n+\tinternal class BulletSpaceModel: IModel\n+\t{\n+\t\tprivate BulletSpace _bulletSpace;\n+\t\tprivate TextureStorage _textureStorage;\n+\n+\t\tpublic BulletSpaceModel (BulletSpace bulletSpace)\n+\t\t{\n+\t\t\t_bulletSpace = bulletSpace;\n+\t\t}\n+\n+\t\tpublic void LoadBulletTextures(IModel bulletModel)\n+\t\t{\n+\t\t\tbulletModel.LoadTextures (_textureStorage);\n+\t\t}\n+\n+\t\t#region IModel implementation\n+\n+\t\tpublic IUnit GetUnit ()\n+\t\t{\n+\t\t\treturn _bulletSpace;\n+\t\t}\n+\n+\t\tpublic void LoadTextures (TextureStorage textureStorage)\n+\t\t{\n+\t\t\t_textureStorage = textureStorage;\n+\t\t}\n+\n+\t\tpublic void Render (SpriteBatch spriteBatch)\n+\t\t{\n+\t\t\tforeach (var bullet in _bulletSpace.Bullets) {\n+\t\t\t\tbullet.GetModel ().Render (spriteBatch);\n+\t\t\t}\n+\t\t}\n+\n+\t\t#endregion\n+\t}\n+}\n+","path":"TankDriver.App/Models/BulletSpaceModel.cs","position":45,"original_position":45,"commit_id":"d12f9df5257d5476579b5a7e8dbe3cbf7525e887","original_commit_id":"d12f9df5257d5476579b5a7e8dbe3cbf7525e887","user":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"body":"Do we really need this `BulletSpaceModel`? I think my initial idea was to have a model for every unit (e.g. tank, aircraft, bullet or missile) and not for abstract entities like that.\r\n\r\nYes, we do have need to store a list of models somewhere, but let's maybe just store the list in the `Game` class itself? And periodically call `Render` and `Update` for each model on the list (including the `TankModel` itself).","created_at":"2016-08-29T12:57:43Z","updated_at":"2016-08-29T12:57:43Z","html_url":"https://github.com/ForNeVeR/TankDriver/pull/20#discussion_r76601719","pull_request_url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/comments/76601719"},"html":{"href":"https://github.com/ForNeVeR/TankDriver/pull/20#discussion_r76601719"},"pull_request":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20","id":83029313,"html_url":"https://github.com/ForNeVeR/TankDriver/pull/20","diff_url":"https://github.com/ForNeVeR/TankDriver/pull/20.diff","patch_url":"https://github.com/ForNeVeR/TankDriver/pull/20.patch","issue_url":"https://api.github.com/repos/ForNeVeR/TankDriver/issues/20","number":20,"state":"open","locked":false,"title":"[WIP] Introduce shooting","user":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"body":"To Do:\r\n- [ ] Unit Tests\r\n\r\n@ForNeVeR even though this PR is WIP I'd like to ask you to review it anyway and provide as many comments and suggestions as possible. Since this is my first experience with C# I probably made lots of mistakes. Thanks!\r\n\r\n---\r\nClose #5 ","created_at":"2016-08-28T22:22:43Z","updated_at":"2016-08-29T12:57:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9368741bbde4c819bd73b8fe65e97bf9e5643c97","assignee":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"assignees":[{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20/commits","review_comments_url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20/comments","review_comment_url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ForNeVeR/TankDriver/issues/20/comments","statuses_url":"https://api.github.com/repos/ForNeVeR/TankDriver/statuses/d12f9df5257d5476579b5a7e8dbe3cbf7525e887","head":{"label":"rexim:feature/shooting-5","ref":"feature/shooting-5","sha":"d12f9df5257d5476579b5a7e8dbe3cbf7525e887","user":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"repo":{"id":66492979,"name":"TankDriver","full_name":"rexim/TankDriver","owner":{"login":"rexim","id":165283,"avatar_url":"https://avatars.githubusercontent.com/u/165283?v=3","gravatar_id":"","url":"https://api.github.com/users/rexim","html_url":"https://github.com/rexim","followers_url":"https://api.github.com/users/rexim/followers","following_url":"https://api.github.com/users/rexim/following{/other_user}","gists_url":"https://api.github.com/users/rexim/gists{/gist_id}","starred_url":"https://api.github.com/users/rexim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rexim/subscriptions","organizations_url":"https://api.github.com/users/rexim/orgs","repos_url":"https://api.github.com/users/rexim/repos","events_url":"https://api.github.com/users/rexim/events{/privacy}","received_events_url":"https://api.github.com/users/rexim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rexim/TankDriver","description":"Simple game in XNA.","fork":true,"url":"https://api.github.com/repos/rexim/TankDriver","forks_url":"https://api.github.com/repos/rexim/TankDriver/forks","keys_url":"https://api.github.com/repos/rexim/TankDriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rexim/TankDriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rexim/TankDriver/teams","hooks_url":"https://api.github.com/repos/rexim/TankDriver/hooks","issue_events_url":"https://api.github.com/repos/rexim/TankDriver/issues/events{/number}","events_url":"https://api.github.com/repos/rexim/TankDriver/events","assignees_url":"https://api.github.com/repos/rexim/TankDriver/assignees{/user}","branches_url":"https://api.github.com/repos/rexim/TankDriver/branches{/branch}","tags_url":"https://api.github.com/repos/rexim/TankDriver/tags","blobs_url":"https://api.github.com/repos/rexim/TankDriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rexim/TankDriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rexim/TankDriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rexim/TankDriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rexim/TankDriver/statuses/{sha}","languages_url":"https://api.github.com/repos/rexim/TankDriver/languages","stargazers_url":"https://api.github.com/repos/rexim/TankDriver/stargazers","contributors_url":"https://api.github.com/repos/rexim/TankDriver/contributors","subscribers_url":"https://api.github.com/repos/rexim/TankDriver/subscribers","subscription_url":"https://api.github.com/repos/rexim/TankDriver/subscription","commits_url":"https://api.github.com/repos/rexim/TankDriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rexim/TankDriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rexim/TankDriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rexim/TankDriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/rexim/TankDriver/contents/{+path}","compare_url":"https://api.github.com/repos/rexim/TankDriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rexim/TankDriver/merges","archive_url":"https://api.github.com/repos/rexim/TankDriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rexim/TankDriver/downloads","issues_url":"https://api.github.com/repos/rexim/TankDriver/issues{/number}","pulls_url":"https://api.github.com/repos/rexim/TankDriver/pulls{/number}","milestones_url":"https://api.github.com/repos/rexim/TankDriver/milestones{/number}","notifications_url":"https://api.github.com/repos/rexim/TankDriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rexim/TankDriver/labels{/name}","releases_url":"https://api.github.com/repos/rexim/TankDriver/releases{/id}","deployments_url":"https://api.github.com/repos/rexim/TankDriver/deployments","created_at":"2016-08-24T19:24:25Z","updated_at":"2016-08-24T19:24:26Z","pushed_at":"2016-08-28T22:17:30Z","git_url":"git://github.com/rexim/TankDriver.git","ssh_url":"git@github.com:rexim/TankDriver.git","clone_url":"https://github.com/rexim/TankDriver.git","svn_url":"https://github.com/rexim/TankDriver","homepage":"","size":114,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ForNeVeR:develop","ref":"develop","sha":"981503905a0169079dccd6230fb0150251b05646","user":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"repo":{"id":3145518,"name":"TankDriver","full_name":"ForNeVeR/TankDriver","owner":{"login":"ForNeVeR","id":92793,"avatar_url":"https://avatars.githubusercontent.com/u/92793?v=3","gravatar_id":"","url":"https://api.github.com/users/ForNeVeR","html_url":"https://github.com/ForNeVeR","followers_url":"https://api.github.com/users/ForNeVeR/followers","following_url":"https://api.github.com/users/ForNeVeR/following{/other_user}","gists_url":"https://api.github.com/users/ForNeVeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ForNeVeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForNeVeR/subscriptions","organizations_url":"https://api.github.com/users/ForNeVeR/orgs","repos_url":"https://api.github.com/users/ForNeVeR/repos","events_url":"https://api.github.com/users/ForNeVeR/events{/privacy}","received_events_url":"https://api.github.com/users/ForNeVeR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ForNeVeR/TankDriver","description":"Simple game about tanks.","fork":false,"url":"https://api.github.com/repos/ForNeVeR/TankDriver","forks_url":"https://api.github.com/repos/ForNeVeR/TankDriver/forks","keys_url":"https://api.github.com/repos/ForNeVeR/TankDriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForNeVeR/TankDriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForNeVeR/TankDriver/teams","hooks_url":"https://api.github.com/repos/ForNeVeR/TankDriver/hooks","issue_events_url":"https://api.github.com/repos/ForNeVeR/TankDriver/issues/events{/number}","events_url":"https://api.github.com/repos/ForNeVeR/TankDriver/events","assignees_url":"https://api.github.com/repos/ForNeVeR/TankDriver/assignees{/user}","branches_url":"https://api.github.com/repos/ForNeVeR/TankDriver/branches{/branch}","tags_url":"https://api.github.com/repos/ForNeVeR/TankDriver/tags","blobs_url":"https://api.github.com/repos/ForNeVeR/TankDriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForNeVeR/TankDriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForNeVeR/TankDriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForNeVeR/TankDriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForNeVeR/TankDriver/statuses/{sha}","languages_url":"https://api.github.com/repos/ForNeVeR/TankDriver/languages","stargazers_url":"https://api.github.com/repos/ForNeVeR/TankDriver/stargazers","contributors_url":"https://api.github.com/repos/ForNeVeR/TankDriver/contributors","subscribers_url":"https://api.github.com/repos/ForNeVeR/TankDriver/subscribers","subscription_url":"https://api.github.com/repos/ForNeVeR/TankDriver/subscription","commits_url":"https://api.github.com/repos/ForNeVeR/TankDriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForNeVeR/TankDriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForNeVeR/TankDriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForNeVeR/TankDriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForNeVeR/TankDriver/contents/{+path}","compare_url":"https://api.github.com/repos/ForNeVeR/TankDriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForNeVeR/TankDriver/merges","archive_url":"https://api.github.com/repos/ForNeVeR/TankDriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForNeVeR/TankDriver/downloads","issues_url":"https://api.github.com/repos/ForNeVeR/TankDriver/issues{/number}","pulls_url":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls{/number}","milestones_url":"https://api.github.com/repos/ForNeVeR/TankDriver/milestones{/number}","notifications_url":"https://api.github.com/repos/ForNeVeR/TankDriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForNeVeR/TankDriver/labels{/name}","releases_url":"https://api.github.com/repos/ForNeVeR/TankDriver/releases{/id}","deployments_url":"https://api.github.com/repos/ForNeVeR/TankDriver/deployments","created_at":"2012-01-10T13:52:06Z","updated_at":"2016-08-25T15:31:49Z","pushed_at":"2016-08-28T22:22:43Z","git_url":"git://github.com/ForNeVeR/TankDriver.git","ssh_url":"git@github.com:ForNeVeR/TankDriver.git","clone_url":"https://github.com/ForNeVeR/TankDriver.git","svn_url":"https://github.com/ForNeVeR/TankDriver","homepage":"","size":92,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20"},"html":{"href":"https://github.com/ForNeVeR/TankDriver/pull/20"},"issue":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/issues/20"},"comments":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/ForNeVeR/TankDriver/statuses/d12f9df5257d5476579b5a7e8dbe3cbf7525e887"}}}}
{"actor":{"display_login":"ForNeVeR"}}