{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/84088354","pull_request_review_id":4887455,"id":84088354,"diff_hunk":"@@ -301,6 +297,18 @@ os::build::internal::build_binaries() {\n     local host_platform=$(os::build::host_platform)\n     local platform\n     for platform in \"${platforms[@]}\"; do\n+      os::build::export_targets_and_binaries \"${platform}\" \"$@\"\n+\n+      local -a nonstatics=()\n+      local -a tests=()\n+      for binary in \"${binaries[@]}\"; do\n+        if [[ \"${binary}\" =~ \".test\"$ ]]; then","path":"hack/common.sh","position":45,"original_position":45,"commit_id":"1d0d379a6e7c79f303ea8b4c3cf5e1ee92bdc590","original_commit_id":"1d0d379a6e7c79f303ea8b4c3cf5e1ee92bdc590","user":{"login":"knobunc","id":10033853,"avatar_url":"https://avatars.githubusercontent.com/u/10033853?v=3","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false},"body":"A bare $ always scares me with bash.  Should we just say:\r\n =~ '.test$'","created_at":"2016-10-19T14:50:18Z","updated_at":"2016-10-19T14:50:18Z","html_url":"https://github.com/openshift/origin/pull/11082#discussion_r84088354","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11082","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/84088354"},"html":{"href":"https://github.com/openshift/origin/pull/11082#discussion_r84088354"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11082"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11082","id":86581769,"html_url":"https://github.com/openshift/origin/pull/11082","diff_url":"https://github.com/openshift/origin/pull/11082.diff","patch_url":"https://github.com/openshift/origin/pull/11082.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11082","number":11082,"state":"open","locked":false,"title":"Convert openshift-sdn to a CNI plugin","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"body":"@danwinship see how you like this one better; the CNI plugin is now essentially a small HTTP client that sends the CNI config and environment over a root-owned unix domain socket to the openshift-node process which serializes all the pod requests and does the actual network setup work.  Hostports not implemented yet, but they'll be less icky than the other branch since we can do it all in openshift-node rather than having to work around that race.","created_at":"2016-09-23T21:11:13Z","updated_at":"2016-10-19T14:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb086b570b468582746e6d77bb3495b73de2e21e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11082/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11082/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11082/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/1d0d379a6e7c79f303ea8b4c3cf5e1ee92bdc590","head":{"label":"dcbw:cni-plugin-light","ref":"cni-plugin-light","sha":"1d0d379a6e7c79f303ea8b4c3cf5e1ee92bdc590","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"repo":{"id":38333285,"name":"origin","full_name":"dcbw/origin","owner":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcbw/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/dcbw/origin","forks_url":"https://api.github.com/repos/dcbw/origin/forks","keys_url":"https://api.github.com/repos/dcbw/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcbw/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcbw/origin/teams","hooks_url":"https://api.github.com/repos/dcbw/origin/hooks","issue_events_url":"https://api.github.com/repos/dcbw/origin/issues/events{/number}","events_url":"https://api.github.com/repos/dcbw/origin/events","assignees_url":"https://api.github.com/repos/dcbw/origin/assignees{/user}","branches_url":"https://api.github.com/repos/dcbw/origin/branches{/branch}","tags_url":"https://api.github.com/repos/dcbw/origin/tags","blobs_url":"https://api.github.com/repos/dcbw/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcbw/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcbw/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcbw/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcbw/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/dcbw/origin/languages","stargazers_url":"https://api.github.com/repos/dcbw/origin/stargazers","contributors_url":"https://api.github.com/repos/dcbw/origin/contributors","subscribers_url":"https://api.github.com/repos/dcbw/origin/subscribers","subscription_url":"https://api.github.com/repos/dcbw/origin/subscription","commits_url":"https://api.github.com/repos/dcbw/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcbw/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcbw/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcbw/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcbw/origin/contents/{+path}","compare_url":"https://api.github.com/repos/dcbw/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcbw/origin/merges","archive_url":"https://api.github.com/repos/dcbw/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcbw/origin/downloads","issues_url":"https://api.github.com/repos/dcbw/origin/issues{/number}","pulls_url":"https://api.github.com/repos/dcbw/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/dcbw/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/dcbw/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcbw/origin/labels{/name}","releases_url":"https://api.github.com/repos/dcbw/origin/releases{/id}","deployments_url":"https://api.github.com/repos/dcbw/origin/deployments","created_at":"2015-06-30T21:09:36Z","updated_at":"2015-06-30T21:09:40Z","pushed_at":"2016-10-18T22:14:23Z","git_url":"git://github.com/dcbw/origin.git","ssh_url":"git@github.com:dcbw/origin.git","clone_url":"https://github.com/dcbw/origin.git","svn_url":"https://github.com/dcbw/origin","homepage":"http://www.openshift.org","size":344039,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e3a28143ac9333ebd53a6024f5ecf75752bd6e96","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-10-19T14:52:00Z","pushed_at":"2016-10-19T14:42:56Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":597094,"stargazers_count":1854,"watchers_count":1854,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1238,"mirror_url":null,"open_issues_count":1241,"forks":1238,"open_issues":1241,"watchers":1854,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11082"},"html":{"href":"https://github.com/openshift/origin/pull/11082"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11082"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11082/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11082/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11082/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/1d0d379a6e7c79f303ea8b4c3cf5e1ee92bdc590"}}}}
{"actor":{"display_login":"knobunc"}}