{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/83772495","pull_request_review_id":4593118,"id":83772495,"diff_hunk":"@@ -107,7 +110,7 @@ class RichHadoopConfiguration(val hConf: hadoop.conf.Configuration) extends AnyV\n       false, hConf)\n   }\n \n-  def copyMerge(srcFilenames: Array[String], destFilename: String, deleteSource: Boolean = true) {\n+  def copyMerge(srcFilenames: Array[(String, (FileStatus) => Int)], destFilename: String, deleteSource: Boolean = true) {","path":"src/main/scala/org/broadinstitute/hail/utils/richUtils/RichHadoopConfiguration.scala","position":26,"original_position":26,"commit_id":"028e086b5b4cd94f4a48e3d247a711901f8e8801","original_commit_id":"028e086b5b4cd94f4a48e3d247a711901f8e8801","user":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars.githubusercontent.com/u/10562794?v=3","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"No need to duplicate f: should be `copyMerge(srcFiles: Array[String], sortFunction: Option[(FileStatus) => Int] = None, ...)`","created_at":"2016-10-18T02:35:14Z","updated_at":"2016-10-18T02:40:54Z","html_url":"https://github.com/hail-is/hail/pull/976#discussion_r83772495","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/976","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/83772495"},"html":{"href":"https://github.com/hail-is/hail/pull/976#discussion_r83772495"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/976"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/976","id":89704379,"html_url":"https://github.com/hail-is/hail/pull/976","diff_url":"https://github.com/hail-is/hail/pull/976.diff","patch_url":"https://github.com/hail-is/hail/pull/976.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/976","number":976,"state":"open","locked":false,"title":"copy merge fix #814","user":{"login":"jigold","id":1693348,"avatar_url":"https://avatars.githubusercontent.com/u/1693348?v=3","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"body":"@tpoterba @cseed Here's a different way of trying to fix this with partially applied functions. I think this is pretty messy, but fewer changes.","created_at":"2016-10-17T21:13:28Z","updated_at":"2016-10-18T02:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31a3dddd44a0f7ee7aab414fcf25a46ceaeef142","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/976/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/976/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/976/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/028e086b5b4cd94f4a48e3d247a711901f8e8801","head":{"label":"jigold:jg_filesort2","ref":"jg_filesort2","sha":"028e086b5b4cd94f4a48e3d247a711901f8e8801","user":{"login":"jigold","id":1693348,"avatar_url":"https://avatars.githubusercontent.com/u/1693348?v=3","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"repo":{"id":64695542,"name":"hail","full_name":"jigold/hail","owner":{"login":"jigold","id":1693348,"avatar_url":"https://avatars.githubusercontent.com/u/1693348?v=3","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jigold/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/jigold/hail","forks_url":"https://api.github.com/repos/jigold/hail/forks","keys_url":"https://api.github.com/repos/jigold/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jigold/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jigold/hail/teams","hooks_url":"https://api.github.com/repos/jigold/hail/hooks","issue_events_url":"https://api.github.com/repos/jigold/hail/issues/events{/number}","events_url":"https://api.github.com/repos/jigold/hail/events","assignees_url":"https://api.github.com/repos/jigold/hail/assignees{/user}","branches_url":"https://api.github.com/repos/jigold/hail/branches{/branch}","tags_url":"https://api.github.com/repos/jigold/hail/tags","blobs_url":"https://api.github.com/repos/jigold/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jigold/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jigold/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/jigold/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jigold/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/jigold/hail/languages","stargazers_url":"https://api.github.com/repos/jigold/hail/stargazers","contributors_url":"https://api.github.com/repos/jigold/hail/contributors","subscribers_url":"https://api.github.com/repos/jigold/hail/subscribers","subscription_url":"https://api.github.com/repos/jigold/hail/subscription","commits_url":"https://api.github.com/repos/jigold/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/jigold/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/jigold/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/jigold/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/jigold/hail/contents/{+path}","compare_url":"https://api.github.com/repos/jigold/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jigold/hail/merges","archive_url":"https://api.github.com/repos/jigold/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jigold/hail/downloads","issues_url":"https://api.github.com/repos/jigold/hail/issues{/number}","pulls_url":"https://api.github.com/repos/jigold/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/jigold/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/jigold/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jigold/hail/labels{/name}","releases_url":"https://api.github.com/repos/jigold/hail/releases{/id}","deployments_url":"https://api.github.com/repos/jigold/hail/deployments","created_at":"2016-08-01T19:28:56Z","updated_at":"2016-08-01T19:28:58Z","pushed_at":"2016-10-17T21:12:33Z","git_url":"git://github.com/jigold/hail.git","ssh_url":"git@github.com:jigold/hail.git","clone_url":"https://github.com/jigold/hail.git","svn_url":"https://github.com/jigold/hail","homepage":"","size":13705,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"9a7e973c5c4046b2f074ab24449ed11d2676b40b","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genetic data analysis","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2016-10-15T23:06:51Z","pushed_at":"2016-10-18T02:24:43Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":8879,"stargazers_count":61,"watchers_count":61,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":251,"forks":21,"open_issues":251,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/976"},"html":{"href":"https://github.com/hail-is/hail/pull/976"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/976"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/976/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/976/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/976/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/028e086b5b4cd94f4a48e3d247a711901f8e8801"}}}}
{"actor":{"display_login":"tpoterba"}}