{"action":"created","comment":{"url":"https://api.github.com/repos/NLog/NLog/pulls/comments/53959864","id":53959864,"diff_hunk":"@@ -509,6 +510,7 @@ private void WriteEventToDatabase(LogEventInfo logEvent)\n                     string stringValue = par.Layout.Render(logEvent);\n \n                     p.Value = stringValue;\n+                    SetParamType(p, par);","path":"src/NLog/Targets/DatabaseTarget.cs","position":12,"original_position":12,"commit_id":"8738bddb7e2f1c6282b249c46ffd7517d9c75783","original_commit_id":"8738bddb7e2f1c6282b249c46ffd7517d9c75783","user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"body":"We can pass here `par.DbType` instead of `par`?","created_at":"2016-02-24T15:58:31Z","updated_at":"2016-02-24T15:58:31Z","html_url":"https://github.com/NLog/NLog/pull/1194#discussion_r53959864","pull_request_url":"https://api.github.com/repos/NLog/NLog/pulls/1194","_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments/53959864"},"html":{"href":"https://github.com/NLog/NLog/pull/1194#discussion_r53959864"},"pull_request":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1194"}}},"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1194","id":57118682,"html_url":"https://github.com/NLog/NLog/pull/1194","diff_url":"https://github.com/NLog/NLog/pull/1194.diff","patch_url":"https://github.com/NLog/NLog/pull/1194.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1194","number":1194,"state":"open","locked":false,"title":"Fixed issue with inserting into Oracle large amounts of data in clobs","user":{"login":"sorvis","id":1037467,"avatar_url":"https://avatars.githubusercontent.com/u/1037467?v=3","gravatar_id":"","url":"https://api.github.com/users/sorvis","html_url":"https://github.com/sorvis","followers_url":"https://api.github.com/users/sorvis/followers","following_url":"https://api.github.com/users/sorvis/following{/other_user}","gists_url":"https://api.github.com/users/sorvis/gists{/gist_id}","starred_url":"https://api.github.com/users/sorvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorvis/subscriptions","organizations_url":"https://api.github.com/users/sorvis/orgs","repos_url":"https://api.github.com/users/sorvis/repos","events_url":"https://api.github.com/users/sorvis/events{/privacy}","received_events_url":"https://api.github.com/users/sorvis/received_events","type":"User","site_admin":false},"body":"Fixed issue with inserting into Oracle clobs that are larger than varchar2.\r\n\r\nThe issue stems with the Microsoft not properly mapping DbType.String into OracleDbType.Clob. NLog fails to insert records into the database that try to insert too large of an amount of data into a clob field with the following error message:\r\n\r\n```\r\nError when writing to database Oracle.DataAccess.Client.OracleException ORA-01460: unimplemented or unreasonable conversion requested    at Oracle.DataAccess.Client.OracleException.HandleErrorHelper(Int32 errCode, OracleConnection conn, IntPtr opsErrCtx, OpoSqlValCtx* pOpoSqlValCtx, Object src, String procedure, Boolean bCheck)\r\n```\r\n\r\nOthers have hit this issue before me: https://groups.google.com/forum/#!topic/nlog-users/NPtPAx43uw8\r\n\r\nI've made the assumption that we want to assume clob after 4000, but in reality we might want to go with 32767 since that is the max in PL/SQL. Alternatively, we might want to consider an optional parameter type that can be configured in the config file so that the user gets to choose if they need something other then the default.","created_at":"2016-01-25T19:35:13Z","updated_at":"2016-02-24T15:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"835a3c21046f9e194245fd3ae6fc66f5a9adf848","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1194/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/8738bddb7e2f1c6282b249c46ffd7517d9c75783","head":{"label":"sorvis:fix_oracle_clobs","ref":"fix_oracle_clobs","sha":"8738bddb7e2f1c6282b249c46ffd7517d9c75783","user":{"login":"sorvis","id":1037467,"avatar_url":"https://avatars.githubusercontent.com/u/1037467?v=3","gravatar_id":"","url":"https://api.github.com/users/sorvis","html_url":"https://github.com/sorvis","followers_url":"https://api.github.com/users/sorvis/followers","following_url":"https://api.github.com/users/sorvis/following{/other_user}","gists_url":"https://api.github.com/users/sorvis/gists{/gist_id}","starred_url":"https://api.github.com/users/sorvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorvis/subscriptions","organizations_url":"https://api.github.com/users/sorvis/orgs","repos_url":"https://api.github.com/users/sorvis/repos","events_url":"https://api.github.com/users/sorvis/events{/privacy}","received_events_url":"https://api.github.com/users/sorvis/received_events","type":"User","site_admin":false},"repo":{"id":50374403,"name":"NLog","full_name":"sorvis/NLog","owner":{"login":"sorvis","id":1037467,"avatar_url":"https://avatars.githubusercontent.com/u/1037467?v=3","gravatar_id":"","url":"https://api.github.com/users/sorvis","html_url":"https://github.com/sorvis","followers_url":"https://api.github.com/users/sorvis/followers","following_url":"https://api.github.com/users/sorvis/following{/other_user}","gists_url":"https://api.github.com/users/sorvis/gists{/gist_id}","starred_url":"https://api.github.com/users/sorvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorvis/subscriptions","organizations_url":"https://api.github.com/users/sorvis/orgs","repos_url":"https://api.github.com/users/sorvis/repos","events_url":"https://api.github.com/users/sorvis/events{/privacy}","received_events_url":"https://api.github.com/users/sorvis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sorvis/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":true,"url":"https://api.github.com/repos/sorvis/NLog","forks_url":"https://api.github.com/repos/sorvis/NLog/forks","keys_url":"https://api.github.com/repos/sorvis/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sorvis/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sorvis/NLog/teams","hooks_url":"https://api.github.com/repos/sorvis/NLog/hooks","issue_events_url":"https://api.github.com/repos/sorvis/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/sorvis/NLog/events","assignees_url":"https://api.github.com/repos/sorvis/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/sorvis/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/sorvis/NLog/tags","blobs_url":"https://api.github.com/repos/sorvis/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sorvis/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sorvis/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/sorvis/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sorvis/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/sorvis/NLog/languages","stargazers_url":"https://api.github.com/repos/sorvis/NLog/stargazers","contributors_url":"https://api.github.com/repos/sorvis/NLog/contributors","subscribers_url":"https://api.github.com/repos/sorvis/NLog/subscribers","subscription_url":"https://api.github.com/repos/sorvis/NLog/subscription","commits_url":"https://api.github.com/repos/sorvis/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/sorvis/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/sorvis/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/sorvis/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/sorvis/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/sorvis/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sorvis/NLog/merges","archive_url":"https://api.github.com/repos/sorvis/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sorvis/NLog/downloads","issues_url":"https://api.github.com/repos/sorvis/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/sorvis/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/sorvis/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/sorvis/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sorvis/NLog/labels{/name}","releases_url":"https://api.github.com/repos/sorvis/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/sorvis/NLog/deployments","created_at":"2016-01-25T19:17:16Z","updated_at":"2016-01-25T19:17:19Z","pushed_at":"2016-02-24T13:19:01Z","git_url":"git://github.com/sorvis/NLog.git","ssh_url":"git@github.com:sorvis/NLog.git","clone_url":"https://github.com/sorvis/NLog.git","svn_url":"https://github.com/sorvis/NLog","homepage":"http://nlog-project.org","size":114121,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NLog:master","ref":"master","sha":"e8a8bef111c16d936ba1ea82efadba0e8c5995c4","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET and Silverlight Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/NLog/NLog/deployments","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-02-24T14:49:35Z","pushed_at":"2016-02-24T13:19:01Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":122523,"stargazers_count":1467,"watchers_count":1467,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":534,"mirror_url":null,"open_issues_count":147,"forks":534,"open_issues":147,"watchers":1467,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1194"},"html":{"href":"https://github.com/NLog/NLog/pull/1194"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/1194"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/8738bddb7e2f1c6282b249c46ffd7517d9c75783"}}}}