{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3180","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3180/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3180/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3180/events","html_url":"https://github.com/home-assistant/home-assistant/pull/3180","id":174944224,"number":3180,"title":"Add open/closed state for open_cover and close_cover in SERVICE_TO_STATE","user":{"login":"nvella","id":8158648,"avatar_url":"https://avatars.githubusercontent.com/u/8158648?v=3","gravatar_id":"","url":"https://api.github.com/users/nvella","html_url":"https://github.com/nvella","followers_url":"https://api.github.com/users/nvella/followers","following_url":"https://api.github.com/users/nvella/following{/other_user}","gists_url":"https://api.github.com/users/nvella/gists{/gist_id}","starred_url":"https://api.github.com/users/nvella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvella/subscriptions","organizations_url":"https://api.github.com/users/nvella/orgs","repos_url":"https://api.github.com/users/nvella/repos","events_url":"https://api.github.com/users/nvella/events{/privacy}","received_events_url":"https://api.github.com/users/nvella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-04T11:28:55Z","updated_at":"2016-09-04T14:05:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/3180","html_url":"https://github.com/home-assistant/home-assistant/pull/3180","diff_url":"https://github.com/home-assistant/home-assistant/pull/3180.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/3180.patch"},"body":"*Note:* I've never contributed to home-assistant before and have tried to follow the CONTRIBUTING.md as well as possible. Please give some constructive criticism if I've done anything wrong.\r\n\r\n**Description:**\r\nThis allows for a cover's state to be set through a scene by adding the cover's ``open_cover`` and ``close_cover`` services to the ``SERVICE_TO_STATE`` dict in ``helpers/state.py``.\r\n\r\n**Related issue (if applicable):** fixes #3177 \r\n\r\n\r\n**Example entry for `configuration.yaml` (if applicable):**\r\n```yaml\r\nscene:\r\n  - name: test\r\n    entities:\r\n      cover.open_this:\r\n        state: 'open'\r\n      cover.close_this:\r\n        state: 'closed'\r\n```\r\n\r\n**Checklist:**\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\nI wasn't sure where to add the tests needed, if any were. The tests for helpers/state.py seem to be fairly generic and don't specifically target any component.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/244605345","html_url":"https://github.com/home-assistant/home-assistant/pull/3180#issuecomment-244605345","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/3180","id":244605345,"user":{"login":"nvella","id":8158648,"avatar_url":"https://avatars.githubusercontent.com/u/8158648?v=3","gravatar_id":"","url":"https://api.github.com/users/nvella","html_url":"https://github.com/nvella","followers_url":"https://api.github.com/users/nvella/followers","following_url":"https://api.github.com/users/nvella/following{/other_user}","gists_url":"https://api.github.com/users/nvella/gists{/gist_id}","starred_url":"https://api.github.com/users/nvella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvella/subscriptions","organizations_url":"https://api.github.com/users/nvella/orgs","repos_url":"https://api.github.com/users/nvella/repos","events_url":"https://api.github.com/users/nvella/events{/privacy}","received_events_url":"https://api.github.com/users/nvella/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T14:05:53Z","updated_at":"2016-09-04T14:05:53Z","body":"Yeah, it looks like adding that mapping for SERVICE_OPEN_COVER_TILT AND SERVICE_CLOSE_COVER_TILT has caused those services to be called for covers that don't support tilting.\r\n\r\nRelevant log entries:\r\n```\r\n[homeassistant.core] Bus:Handling <Event call_service[L]: domain=scene, service_call_id=140212719087968-20, service_data=entity_id=['scene.lounge_evening'], service=turn_on>\r\n[homeassistant.core] Bus:Handling <Event call_service[L]: domain=cover, service_call_id=140212719087968-22, service_data=entity_id=['cover.lounge_side', 'cover.lounge_main'], service=close_cover_tilt>\r\n```"}}
{"actor":{"display_login":"nvella"}}