{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/che/pulls/comments/83002447","pull_request_review_id":3870597,"id":83002447,"diff_hunk":"@@ -116,6 +142,50 @@ public ProjectTypeDef getPrimary() {\n         return all;\n     }\n \n+    /**\n+     * Reset project types and atrributes after initialization\n+     * in case when some attributes are not valid\n+     * (for instance required attributes are not initialized)\n+     *\n+     * @param attributesToDel - invalid attributes\n+     */\n+    void reset(Set<Attribute> attributesToDel) {\n+\n+        Set<String> ptsToDel = new HashSet<>();\n+        for(Attribute attr : attributesToDel) {\n+","path":"wsagent/che-core-api-project/src/main/java/org/eclipse/che/api/project/server/ProjectTypes.java","position":128,"original_position":128,"commit_id":"7ea4a47d65b3995b1cfe086121e4d10c28f4214c","original_commit_id":"7ea4a47d65b3995b1cfe086121e4d10c28f4214c","user":{"login":"skabashnyuk","id":1614429,"avatar_url":"https://avatars.githubusercontent.com/u/1614429?v=3","gravatar_id":"","url":"https://api.github.com/users/skabashnyuk","html_url":"https://github.com/skabashnyuk","followers_url":"https://api.github.com/users/skabashnyuk/followers","following_url":"https://api.github.com/users/skabashnyuk/following{/other_user}","gists_url":"https://api.github.com/users/skabashnyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/skabashnyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skabashnyuk/subscriptions","organizations_url":"https://api.github.com/users/skabashnyuk/orgs","repos_url":"https://api.github.com/users/skabashnyuk/repos","events_url":"https://api.github.com/users/skabashnyuk/events{/privacy}","received_events_url":"https://api.github.com/users/skabashnyuk/received_events","type":"User","site_admin":false},"body":"remove extra empty line.","created_at":"2016-10-12T13:20:10Z","updated_at":"2016-10-12T13:22:15Z","html_url":"https://github.com/eclipse/che/pull/2765#discussion_r83002447","pull_request_url":"https://api.github.com/repos/eclipse/che/pulls/2765","_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments/83002447"},"html":{"href":"https://github.com/eclipse/che/pull/2765#discussion_r83002447"},"pull_request":{"href":"https://api.github.com/repos/eclipse/che/pulls/2765"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/2765","id":89000486,"html_url":"https://github.com/eclipse/che/pull/2765","diff_url":"https://github.com/eclipse/che/pull/2765.diff","patch_url":"https://github.com/eclipse/che/pull/2765.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/2765","number":2765,"state":"open","locked":false,"title":"Apply non-strict rules for PT appliance on project import to avoid wo…","user":{"login":"gazarenkov","id":578124,"avatar_url":"https://avatars.githubusercontent.com/u/578124?v=3","gravatar_id":"","url":"https://api.github.com/users/gazarenkov","html_url":"https://github.com/gazarenkov","followers_url":"https://api.github.com/users/gazarenkov/followers","following_url":"https://api.github.com/users/gazarenkov/following{/other_user}","gists_url":"https://api.github.com/users/gazarenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/gazarenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazarenkov/subscriptions","organizations_url":"https://api.github.com/users/gazarenkov/orgs","repos_url":"https://api.github.com/users/gazarenkov/repos","events_url":"https://api.github.com/users/gazarenkov/events{/privacy}","received_events_url":"https://api.github.com/users/gazarenkov/received_events","type":"User","site_admin":false},"body":"@vparfonov @azatsarynnyy  please review. \r\n\r\n### What does this PR do?\r\nImproves solving the PT related problems with importing Project. Such as: \r\n- The System (Che or Codenvy) does not contain Project Types described in serialized Project configuration. \r\n-  There are non-conformance between PT descriptions so serialized Project configuration  does not contain required (as for PTs registered in the System) Attributes\r\n\r\n### What issues does this PR fix or reference?\r\nnone\r\n\r\n### Previous behavior\r\nInitially import of such data broke Workspace creation.\r\nAfter it was some improved so ANY problem caused adding Problem record (only one) with description replacing primary PT with Blank, removing all the mixins and attributes.\r\n\r\n### New behavior\r\nIn a case of problematic import:\r\n- Added as many Problem record as needed (all the problems are covered)\r\n- In a case of problem with primary PT replaces it with Blank and removes only Attributes belonged to initial PT\r\n- In a case of problem with mixin PT removes only it and removes only Attributes belonged to initial mixin PT\r\n\r\n\r\nPlease review [Che's Contributing Guide](https://github.com/eclipse/che/blob/master/CONTRIBUTING.md) for best practices.\r\n\r\n…rkspace failing","created_at":"2016-10-12T11:42:42Z","updated_at":"2016-10-12T13:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee1113f389988664cb96de863f82859816af79f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/2765/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/2765/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/2765/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/7ea4a47d65b3995b1cfe086121e4d10c28f4214c","head":{"label":"eclipse:non_strict_project_types","ref":"non_strict_project_types","sha":"7ea4a47d65b3995b1cfe086121e4d10c28f4214c","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2016-10-12T06:13:30Z","pushed_at":"2016-10-12T13:19:15Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":53750,"stargazers_count":3244,"watchers_count":3244,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":531,"mirror_url":null,"open_issues_count":316,"forks":531,"open_issues":316,"watchers":3244,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"a6c5a75fb1feb4c6bd0c01440806dfbeb8f4ac77","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2016-10-12T06:13:30Z","pushed_at":"2016-10-12T13:19:15Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":53750,"stargazers_count":3244,"watchers_count":3244,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":531,"mirror_url":null,"open_issues_count":316,"forks":531,"open_issues":316,"watchers":3244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/2765"},"html":{"href":"https://github.com/eclipse/che/pull/2765"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/2765"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/2765/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/2765/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/2765/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/7ea4a47d65b3995b1cfe086121e4d10c28f4214c"}}}}
{"actor":{"display_login":"skabashnyuk"}}