{"action":"created","comment":{"url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/comments/59350473","id":59350473,"diff_hunk":"@@ -26,10 +26,14 @@ See more at http://blog.squix.ch\n #include \"SSD1306.h\"\n #include \"SSD1306Ui.h\"\n #include \"images.h\"\n+#include \"prototypes.h\"\n+\n+// Defaulting the OLED connection to GPIO0 and GPIO2 pins\n+#define SDA_PIN 0\n+#define SDC_PIN 2","path":"examples/SSD1306Demo/SSD1306Demo.ino","position":8,"original_position":8,"commit_id":"3440e10a8ea3fdefc3888fb88ace12818c7c586a","original_commit_id":"3440e10a8ea3fdefc3888fb88ace12818c7c586a","user":{"login":"RetepV","id":4059698,"avatar_url":"https://avatars.githubusercontent.com/u/4059698?v=3","gravatar_id":"","url":"https://api.github.com/users/RetepV","html_url":"https://github.com/RetepV","followers_url":"https://api.github.com/users/RetepV/followers","following_url":"https://api.github.com/users/RetepV/following{/other_user}","gists_url":"https://api.github.com/users/RetepV/gists{/gist_id}","starred_url":"https://api.github.com/users/RetepV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RetepV/subscriptions","organizations_url":"https://api.github.com/users/RetepV/orgs","repos_url":"https://api.github.com/users/RetepV/repos","events_url":"https://api.github.com/users/RetepV/events{/privacy}","received_events_url":"https://api.github.com/users/RetepV/received_events","type":"User","site_admin":false},"body":"What I noticed is that the pins are called SDA and SDC. But the correct naming for I2C is SDA and SCL.\r\n\r\nAlso, pins_arduino.h already defines the SDA and SCL values. I see it for the all variants.\r\n\r\n```\r\nstatic const uint8_t SDA = 4;\r\nstatic const uint8_t SCL = 5;\r\n```\r\n\r\nSo, you could write:\r\n\r\n```\r\n#define SDA_PIN    SDA\r\n#define SCL_PIN    SCL\r\n```\r\nBut really, you could get rid of the defines completely.","created_at":"2016-04-12T09:57:46Z","updated_at":"2016-04-12T09:57:46Z","html_url":"https://github.com/squix78/esp8266-oled-ssd1306/pull/24#discussion_r59350473","pull_request_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/comments/59350473"},"html":{"href":"https://github.com/squix78/esp8266-oled-ssd1306/pull/24#discussion_r59350473"},"pull_request":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24","id":60446035,"html_url":"https://github.com/squix78/esp8266-oled-ssd1306/pull/24","diff_url":"https://github.com/squix78/esp8266-oled-ssd1306/pull/24.diff","patch_url":"https://github.com/squix78/esp8266-oled-ssd1306/pull/24.patch","issue_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues/24","number":24,"state":"open","locked":false,"title":"Pulled function prototypes out into a header file.  Clarified GPIO pin selection in the demo.","user":{"login":"estu0002","id":10803784,"avatar_url":"https://avatars.githubusercontent.com/u/10803784?v=3","gravatar_id":"","url":"https://api.github.com/users/estu0002","html_url":"https://github.com/estu0002","followers_url":"https://api.github.com/users/estu0002/followers","following_url":"https://api.github.com/users/estu0002/following{/other_user}","gists_url":"https://api.github.com/users/estu0002/gists{/gist_id}","starred_url":"https://api.github.com/users/estu0002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estu0002/subscriptions","organizations_url":"https://api.github.com/users/estu0002/orgs","repos_url":"https://api.github.com/users/estu0002/repos","events_url":"https://api.github.com/users/estu0002/events{/privacy}","received_events_url":"https://api.github.com/users/estu0002/received_events","type":"User","site_admin":false},"body":"Fixes #11 ","created_at":"2016-02-24T02:23:44Z","updated_at":"2016-04-12T09:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70be8fafebecaa33f28193d7e95a39a5cc606968","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24/commits","review_comments_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24/comments","review_comment_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues/24/comments","statuses_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/statuses/3440e10a8ea3fdefc3888fb88ace12818c7c586a","head":{"label":"estu0002:master","ref":"master","sha":"3440e10a8ea3fdefc3888fb88ace12818c7c586a","user":{"login":"estu0002","id":10803784,"avatar_url":"https://avatars.githubusercontent.com/u/10803784?v=3","gravatar_id":"","url":"https://api.github.com/users/estu0002","html_url":"https://github.com/estu0002","followers_url":"https://api.github.com/users/estu0002/followers","following_url":"https://api.github.com/users/estu0002/following{/other_user}","gists_url":"https://api.github.com/users/estu0002/gists{/gist_id}","starred_url":"https://api.github.com/users/estu0002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estu0002/subscriptions","organizations_url":"https://api.github.com/users/estu0002/orgs","repos_url":"https://api.github.com/users/estu0002/repos","events_url":"https://api.github.com/users/estu0002/events{/privacy}","received_events_url":"https://api.github.com/users/estu0002/received_events","type":"User","site_admin":false},"repo":{"id":52406298,"name":"esp8266-oled-ssd1306","full_name":"estu0002/esp8266-oled-ssd1306","owner":{"login":"estu0002","id":10803784,"avatar_url":"https://avatars.githubusercontent.com/u/10803784?v=3","gravatar_id":"","url":"https://api.github.com/users/estu0002","html_url":"https://github.com/estu0002","followers_url":"https://api.github.com/users/estu0002/followers","following_url":"https://api.github.com/users/estu0002/following{/other_user}","gists_url":"https://api.github.com/users/estu0002/gists{/gist_id}","starred_url":"https://api.github.com/users/estu0002/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estu0002/subscriptions","organizations_url":"https://api.github.com/users/estu0002/orgs","repos_url":"https://api.github.com/users/estu0002/repos","events_url":"https://api.github.com/users/estu0002/events{/privacy}","received_events_url":"https://api.github.com/users/estu0002/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estu0002/esp8266-oled-ssd1306","description":"Driver for the SSD1306 based 128x64 pixel OLED display running on the Arduino/ESP8266 platform","fork":true,"url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306","forks_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/forks","keys_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/teams","hooks_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/hooks","issue_events_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/issues/events{/number}","events_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/events","assignees_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/assignees{/user}","branches_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/branches{/branch}","tags_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/tags","blobs_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/git/refs{/sha}","trees_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/statuses/{sha}","languages_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/languages","stargazers_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/stargazers","contributors_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/contributors","subscribers_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/subscribers","subscription_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/subscription","commits_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/commits{/sha}","git_commits_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/git/commits{/sha}","comments_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/comments{/number}","issue_comment_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/issues/comments{/number}","contents_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/contents/{+path}","compare_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/merges","archive_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/downloads","issues_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/issues{/number}","pulls_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/pulls{/number}","milestones_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/milestones{/number}","notifications_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/labels{/name}","releases_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/releases{/id}","deployments_url":"https://api.github.com/repos/estu0002/esp8266-oled-ssd1306/deployments","created_at":"2016-02-24T01:56:57Z","updated_at":"2016-02-24T01:56:58Z","pushed_at":"2016-02-24T02:13:38Z","git_url":"git://github.com/estu0002/esp8266-oled-ssd1306.git","ssh_url":"git@github.com:estu0002/esp8266-oled-ssd1306.git","clone_url":"https://github.com/estu0002/esp8266-oled-ssd1306.git","svn_url":"https://github.com/estu0002/esp8266-oled-ssd1306","homepage":"http://blog.squix.ch","size":869,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squix78:master","ref":"master","sha":"a538e99d7eb96414196e72dbe6da7f1324af8120","user":{"login":"squix78","id":716822,"avatar_url":"https://avatars.githubusercontent.com/u/716822?v=3","gravatar_id":"","url":"https://api.github.com/users/squix78","html_url":"https://github.com/squix78","followers_url":"https://api.github.com/users/squix78/followers","following_url":"https://api.github.com/users/squix78/following{/other_user}","gists_url":"https://api.github.com/users/squix78/gists{/gist_id}","starred_url":"https://api.github.com/users/squix78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squix78/subscriptions","organizations_url":"https://api.github.com/users/squix78/orgs","repos_url":"https://api.github.com/users/squix78/repos","events_url":"https://api.github.com/users/squix78/events{/privacy}","received_events_url":"https://api.github.com/users/squix78/received_events","type":"User","site_admin":false},"repo":{"id":46080167,"name":"esp8266-oled-ssd1306","full_name":"squix78/esp8266-oled-ssd1306","owner":{"login":"squix78","id":716822,"avatar_url":"https://avatars.githubusercontent.com/u/716822?v=3","gravatar_id":"","url":"https://api.github.com/users/squix78","html_url":"https://github.com/squix78","followers_url":"https://api.github.com/users/squix78/followers","following_url":"https://api.github.com/users/squix78/following{/other_user}","gists_url":"https://api.github.com/users/squix78/gists{/gist_id}","starred_url":"https://api.github.com/users/squix78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squix78/subscriptions","organizations_url":"https://api.github.com/users/squix78/orgs","repos_url":"https://api.github.com/users/squix78/repos","events_url":"https://api.github.com/users/squix78/events{/privacy}","received_events_url":"https://api.github.com/users/squix78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squix78/esp8266-oled-ssd1306","description":"Driver for the SSD1306 based 128x64 pixel OLED display running on the Arduino/ESP8266 platform","fork":false,"url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306","forks_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/forks","keys_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/teams","hooks_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/hooks","issue_events_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues/events{/number}","events_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/events","assignees_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/assignees{/user}","branches_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/branches{/branch}","tags_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/tags","blobs_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/git/refs{/sha}","trees_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/statuses/{sha}","languages_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/languages","stargazers_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/stargazers","contributors_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/contributors","subscribers_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/subscribers","subscription_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/subscription","commits_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/commits{/sha}","git_commits_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/git/commits{/sha}","comments_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/comments{/number}","issue_comment_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues/comments{/number}","contents_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/contents/{+path}","compare_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/merges","archive_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/downloads","issues_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues{/number}","pulls_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls{/number}","milestones_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/milestones{/number}","notifications_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/labels{/name}","releases_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/releases{/id}","deployments_url":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/deployments","created_at":"2015-11-12T20:53:16Z","updated_at":"2016-04-11T09:02:16Z","pushed_at":"2016-04-10T12:57:46Z","git_url":"git://github.com/squix78/esp8266-oled-ssd1306.git","ssh_url":"git@github.com:squix78/esp8266-oled-ssd1306.git","clone_url":"https://github.com/squix78/esp8266-oled-ssd1306.git","svn_url":"https://github.com/squix78/esp8266-oled-ssd1306","homepage":"http://blog.squix.ch","size":979,"stargazers_count":59,"watchers_count":59,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":13,"forks":20,"open_issues":13,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24"},"html":{"href":"https://github.com/squix78/esp8266-oled-ssd1306/pull/24"},"issue":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues/24"},"comments":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/squix78/esp8266-oled-ssd1306/statuses/3440e10a8ea3fdefc3888fb88ace12818c7c586a"}}}}