{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10353","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10353/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10353/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10353/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10353","id":186439174,"number":10353,"title":"testutils: fix matcher for AmbiguousResultError","user":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-01T00:56:14Z","updated_at":"2016-11-01T01:01:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10353","html_url":"https://github.com/cockroachdb/cockroach/pull/10353","diff_url":"https://github.com/cockroachdb/cockroach/pull/10353.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10353.patch"},"body":"Fixes #10348.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10353)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/257464907","html_url":"https://github.com/cockroachdb/cockroach/pull/10353#issuecomment-257464907","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10353","id":257464907,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T01:01:22Z","updated_at":"2016-11-01T01:01:22Z","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.\n\n---\n\n*[pkg/testutils/error_test.go, line 25 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10353#-KVSOoVCoeE9O-h9fbwB:-KVSOoVDUQ11vI2gmFi5:b-nt4ysb) ([raw file](https://github.com/cockroachdb/cockroach/blob/686fd8f4fea5fa5b022cbe8e29bf9c6925710105/pkg/testutils/error_test.go#L25)):*\n> ```Go\n> func TestIsSQLRetryableError(t *testing.T) {\n> \terrAmbiguous := &roachpb.AmbiguousResultError{}\n> \tif !IsSQLRetryableError(roachpb.NewError(errAmbiguous).GoError()) {\n> ```\n\nwhy the roachpb.NewError dance?\n\n---\n\n*[pkg/testutils/error_test.go, line 26 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/10353#-KVSOr8M750_8GlA6N4N:-KVSOr8M750_8GlA6N4O:bsyerlz) ([raw file](https://github.com/cockroachdb/cockroach/blob/686fd8f4fea5fa5b022cbe8e29bf9c6925710105/pkg/testutils/error_test.go#L26)):*\n> ```Go\n> \terrAmbiguous := &roachpb.AmbiguousResultError{}\n> \tif !IsSQLRetryableError(roachpb.NewError(errAmbiguous).GoError()) {\n> \t\tt.Fatal(\"%s should be a SQLRetryableError\", errAmbiguous)\n> ```\n\nFatalf\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/10353#-:-KVSOs_MefUz_Ex5zBia:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}