{"action":"closed","issue":{"url":"https://api.github.com/repos/snipe/snipe-it/issues/2848","repository_url":"https://api.github.com/repos/snipe/snipe-it","labels_url":"https://api.github.com/repos/snipe/snipe-it/issues/2848/labels{/name}","comments_url":"https://api.github.com/repos/snipe/snipe-it/issues/2848/comments","events_url":"https://api.github.com/repos/snipe/snipe-it/issues/2848/events","html_url":"https://github.com/snipe/snipe-it/issues/2848","id":186100880,"number":2848,"title":"Hand-drawn Signatures: I NEED YOU","user":{"login":"snipe","id":197404,"avatar_url":"https://avatars.githubusercontent.com/u/197404?v=3","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"labels":[{"id":297333872,"url":"https://api.github.com/repos/snipe/snipe-it/labels/testers-needed","name":"testers-needed","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/snipe/snipe-it/milestones/12","html_url":"https://github.com/snipe/snipe-it/milestones/v3.6.0","labels_url":"https://api.github.com/repos/snipe/snipe-it/milestones/12/labels","id":2046087,"number":12,"title":"v3.6.0","description":"","creator":{"login":"snipe","id":197404,"avatar_url":"https://avatars.githubusercontent.com/u/197404?v=3","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":7,"state":"open","created_at":"2016-10-04T07:33:38Z","updated_at":"2016-12-01T23:57:23Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"comments":12,"created_at":"2016-10-29T21:03:38Z","updated_at":"2016-12-01T23:57:23Z","closed_at":"2016-12-01T23:57:23Z","body":"Hey gang,\n\nI've just pushed out some improvements on a feature branch that let you require an actual signature when the user is accepting an asset.\n\n![screenflow](https://cloud.githubusercontent.com/assets/197404/19832670/04b3303a-9ddf-11e6-9ee0-331b7a8ee6bc.gif)\n\nI've been working for over 24 hours straight on this and #2847 though, so I haven't had time to kick the tires on the behavior across multiple browsers (tested in Chrome and Safari so far) and on mobile (which is probably going to be a nightmarish hellscape.)\n### How to Help Test\n\nFirst of all, DO NOT USE YOUR PRODUCTION DATABASE FOR THIS. While I don't think anything we've done should cause breakage, it's just a good idea to duplicate your production database on a development box and use that. You'll need to pull from the `features/drawn_signature` branch instead of master.\n\nYou'll probably need to make the `storage/private_uploads/signatures` directory writable.\n\nEnable Signature Requirements in Admin > Settings:\n\n<img width=\"487\" alt=\"update_settings____snipe-it\" src=\"https://cloud.githubusercontent.com/assets/197404/19832692/ac1bdf48-9ddf-11e6-9d74-6ca24b215360.png\">\n\nAnd then assign some assets out (to a test user or a user whose email account you can access). Make sure the assets you're assigning belong to models that belong to a category that requires asset acceptance, otherwise you'll never get the email.\n\nTest with EULAs and without, test on as many browsers as you can bear. Test on mobile. Make sure the signature section works, and that it stores your signature correctly. Try to view signatures when you're not logged in, or don't have asset view rights. Etc etc.\n\nOnce a signature is saved, view the asset page and check that it shows up under the \"History\" tab, with a clickable thumbnail to view the large version.\n\n<img width=\"656\" alt=\"view_asset_769342208____snipe-it\" src=\"https://cloud.githubusercontent.com/assets/197404/19832744/10c6f4a4-9de1-11e6-9616-6197cbe21135.png\">\n\nOnce I've gotten some rest, I'll be kicking the tires on it a bit more as well.\n\nLooking forward to hearing your feedback!\n"}}
{"actor":{"display_login":"snipe"}}