{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/14069","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14069/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14069/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14069/events","html_url":"https://github.com/cms-sw/cmssw/pull/14069","id":148345256,"number":14069,"title":"Fix compilation with Clang (3.7.1)","user":{"login":"davidlt","id":197091,"avatar_url":"https://avatars.githubusercontent.com/u/197091?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlt","html_url":"https://github.com/davidlt","followers_url":"https://api.github.com/users/davidlt/followers","following_url":"https://api.github.com/users/davidlt/following{/other_user}","gists_url":"https://api.github.com/users/davidlt/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlt/subscriptions","organizations_url":"https://api.github.com/users/davidlt/orgs","repos_url":"https://api.github.com/users/davidlt/repos","events_url":"https://api.github.com/users/davidlt/events{/privacy}","received_events_url":"https://api.github.com/users/davidlt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":88,"closed_issues":346,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-04-14T15:07:11Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-04-14T12:27:05Z","updated_at":"2016-04-14T15:09:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/14069","html_url":"https://github.com/cms-sw/cmssw/pull/14069","diff_url":"https://github.com/cms-sw/cmssw/pull/14069.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/14069.patch"},"body":"The patch resolves issue with Clang compiler.\r\n\r\nN3690 (should be C++11 standard) and latest draft N4567, 9.4.2/3\r\n\r\n...\r\nThe member shall still be defined in a namespace scope if it\r\nis odr-used (3.2) in the program and the namespace scope definition\r\nshall not contain an initializer.\r\n9.4.2/4 talks about how const static data members are being handled.\r\n\r\nAlso standard says that no diagnostic is required by compiler.\r\n\r\nThe following undefined references were reported by linker:\r\n\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0x61): undefined reference to GCTriggerDetId::cell_mask'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0x6e): undefined reference to GCTriggerDetId::cell_shift'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0x7b): undefined reference to GCTriggerDetId::sector_mask'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0x85): undefined reference to GCTriggerDetId::sector_shift'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0x94): undefined reference to GCTriggerDetId::module_mask'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0x9e): undefined reference to GCTriggerDetId::module_shift'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0xad): undefined reference to GCTriggerDetId::layer_mask'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0xb7): undefined reference to GCTriggerDetId::layer_shift'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0xc6): undefined reference to GCTriggerDetId::zside_mask'\r\n    DataFormats/ForwardDetId/src/HGCTriggerDetId.cc:(.text+0xcf): undefined reference to GCTriggerDetId::zside_shift'\r\n\r\nThese are odr-used because\r\n\r\n    inline void setMaskedId( const uint32_t value, const uint32_t &shift, const uint32_t &mask )\r\n\r\n2nd and 3rd arguments are passed by a reference.\r\n\r\nSigned-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/209991184","html_url":"https://github.com/cms-sw/cmssw/pull/14069#issuecomment-209991184","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/14069","id":209991184,"user":{"login":"civanch","id":4955118,"avatar_url":"https://avatars.githubusercontent.com/u/4955118?v=3","gravatar_id":"","url":"https://api.github.com/users/civanch","html_url":"https://github.com/civanch","followers_url":"https://api.github.com/users/civanch/followers","following_url":"https://api.github.com/users/civanch/following{/other_user}","gists_url":"https://api.github.com/users/civanch/gists{/gist_id}","starred_url":"https://api.github.com/users/civanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civanch/subscriptions","organizations_url":"https://api.github.com/users/civanch/orgs","repos_url":"https://api.github.com/users/civanch/repos","events_url":"https://api.github.com/users/civanch/events{/privacy}","received_events_url":"https://api.github.com/users/civanch/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T15:09:35Z","updated_at":"2016-04-14T15:09:35Z","body":"+1"}}