{"action":"created","issue":{"url":"https://api.github.com/repos/SyncFree/antidote/issues/212","repository_url":"https://api.github.com/repos/SyncFree/antidote","labels_url":"https://api.github.com/repos/SyncFree/antidote/issues/212/labels{/name}","comments_url":"https://api.github.com/repos/SyncFree/antidote/issues/212/comments","events_url":"https://api.github.com/repos/SyncFree/antidote/issues/212/events","html_url":"https://github.com/SyncFree/antidote/pull/212","id":174061374,"number":212,"title":"Bcounter new","user":{"login":"balegas","id":1048589,"avatar_url":"https://avatars.githubusercontent.com/u/1048589?v=3","gravatar_id":"","url":"https://api.github.com/users/balegas","html_url":"https://github.com/balegas","followers_url":"https://api.github.com/users/balegas/followers","following_url":"https://api.github.com/users/balegas/following{/other_user}","gists_url":"https://api.github.com/users/balegas/gists{/gist_id}","starred_url":"https://api.github.com/users/balegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balegas/subscriptions","organizations_url":"https://api.github.com/users/balegas/orgs","repos_url":"https://api.github.com/users/balegas/repos","events_url":"https://api.github.com/users/balegas/events{/privacy}","received_events_url":"https://api.github.com/users/balegas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-30T16:11:45Z","updated_at":"2016-08-30T21:00:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SyncFree/antidote/pulls/212","html_url":"https://github.com/SyncFree/antidote/pull/212","diff_url":"https://github.com/SyncFree/antidote/pull/212.diff","patch_url":"https://github.com/SyncFree/antidote/pull/212.patch"},"body":"Simple BCounterMgr implementation.\r\nRequests remote resources when local budget is exhausted.\r\nTimeout-based policy to avoid starving remote resources. A better policy must be implemented if latency is a concern.\r\n\r\nantidote_crdt library must be updated first."},"comment":{"url":"https://api.github.com/repos/SyncFree/antidote/issues/comments/243579225","html_url":"https://github.com/SyncFree/antidote/pull/212#issuecomment-243579225","issue_url":"https://api.github.com/repos/SyncFree/antidote/issues/212","id":243579225,"user":{"login":"balegas","id":1048589,"avatar_url":"https://avatars.githubusercontent.com/u/1048589?v=3","gravatar_id":"","url":"https://api.github.com/users/balegas","html_url":"https://github.com/balegas","followers_url":"https://api.github.com/users/balegas/followers","following_url":"https://api.github.com/users/balegas/following{/other_user}","gists_url":"https://api.github.com/users/balegas/gists{/gist_id}","starred_url":"https://api.github.com/users/balegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balegas/subscriptions","organizations_url":"https://api.github.com/users/balegas/orgs","repos_url":"https://api.github.com/users/balegas/repos","events_url":"https://api.github.com/users/balegas/events{/privacy}","received_events_url":"https://api.github.com/users/balegas/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T21:00:18Z","updated_at":"2016-08-30T21:00:18Z","body":"Hi, this one requires a commit on antidote_crdt library. I’ve also made a pull request for that.\r\n\r\nRegards,\r\nValter\r\n\r\n\r\nOn 30 Aug 2016, at 21:55, Annette Bieniusa <notifications@github.com<mailto:notifications@github.com>> wrote:\r\n\r\nThe bcounter test suite fails (similarly test _dec_multi_success):\r\n\r\n=== Ended at 2016-08-30 22:46:28\r\n=== location [{bcountermgr_SUITE,test_dec_success,\r\n91\r\n},\r\n{test_server,ts_tc,1358},\r\n{test_server,run_test_case_eval1,975},\r\n{test_server,run_test_case_eval,924}]\r\n=== reason = no match of right hand side value\r\n{badrpc,\r\n{'EXIT',\r\n{{undef,\r\n[{antidote_crdt_bcounter,generate_downstream_check,\r\n[{decrement,4},\r\n{dev1@silverbird,{1472,589914,214277}},\r\n{[{{{dev1@silverbird,{1472,589914,214277}},\r\n{dev1@silverbird,{1472,589914,214277}}},\r\n10}],\r\n[]},\r\n4],\r\n[]},\r\n{bcounter_mgr,handle_call,3,\r\n[{file,\r\n\"/Users/annettebieniusa/syncfree/antidote/_build/default/lib/antidote/src/bcounter_mgr.erl\"},\r\n{line,97}]},\r\n{gen_server,handle_msg,5,\r\n[{file,\"gen_server.erl\"},{line,585}]},\r\n{proc_lib,init_p_do_apply,3,\r\n[{file,\"proc_lib.erl\"},{line,239}]}]},\r\n{gen_server,call,\r\n[bcounter_mgr,\r\n{consume,bcounter2,\r\n{decrement,{4,{dev1@silverbird,{1472,589914,214277}}}},\r\n{[{{{dev1@silverbird,{1472,589914,214277}},\r\n{dev1@silverbird,{1472,589914,214277}}},\r\n10}],\r\n[]}}]}}}}\r\nin function bcountermgr_SUITE:test_dec_success/1 (bcountermgr_SUITE.erl, line 91)\r\n\r\n\r\nAnd:\r\n=== Ended at 2016-08-30 22:46:29\r\n=== location [{bcountermgr_SUITE,'-test_dec_fail/1-fun-0-',\r\n102\r\n},\r\n{test_server,ts_tc,1358},\r\n{test_server,run_test_case_eval1,975},\r\n{test_server,run_test_case_eval,924}]\r\n=== reason = {assertEqual_failed,\r\n[{module,bcountermgr_SUITE},\r\n{line,102},\r\n{expression,\"Result\"},\r\n{expected,{error,no_permissions}},\r\n{value,\r\n{badrpc,\r\n{'EXIT',\r\n{{undef,\r\n[{antidote_crdt_bcounter,generate_downstream_check,\r\n[{decrement,5},\r\n{dev3@silverbird,{1472,589914,786101}},\r\n{[{{{dev1@silverbird,{1472,589914,214277}},\r\n{dev1@silverbird,{1472,589914,214277}}},\r\n10}],\r\n[]},\r\n5],\r\n[]},\r\n{bcounter_mgr,handle_call,3,\r\n[{file,\r\n\"/Users/annettebieniusa/syncfree/antidote/_build/default/lib/antidote/src/bcounter_mgr.erl\"},\r\n{line,97}]},\r\n{gen_server,handle_msg,5,\r\n[{file,\"gen_server.erl\"},{line,585}]},\r\n{proc_lib,init_p_do_apply,3,\r\n[{file,\"proc_lib.erl\"},{line,239}]}]},\r\n{gen_server,call,\r\n[bcounter_mgr,\r\n{consume,bcounter3,\r\n{decrement,\r\n{5,{dev3@silverbird,{1472,589914,786101}}}},\r\n{[{{{dev1@silverbird,{1472,589914,214277}},\r\n{dev1@silverbird,{1472,589914,214277}}},\r\n10}],\r\n[]}}]}}}}}]}\r\nin function bcountermgr_SUITE:'-test_dec_fail/1-fun-0-'/2 (bcountermgr_SUITE.erl, line 102)\r\n\r\n> Am 30.08.2016 um 18:11 schrieb balegas <notifications@github.com<mailto:notifications@github.com>>:\r\n>\r\n> Simple BCounterMgr implementation.\r\n> Requests remote resources when local budget is exhausted.\r\n> Timeout-based policy to avoid starving remote resources. A better policy must be implemented if latency is a concern.\r\n>\r\n> You can view, comment on, or merge this pull request online at:\r\n>\r\n> https://github.com/SyncFree/antidote/pull/212\r\n>\r\n> Commit Summary\r\n>\r\n> • Initial commit for new BoundedCounter manager implementation.\r\n> • Fixed minor erros on bounded counter manager.\r\n> • Added transference logic.\r\n> • Removed old tests and added new interdc tests.\r\n> • Merge branch 'async-red-req' of https://github.com/SyncFree/antidote into bcounter-new\r\n> • Added bounded counter transferences between DCs.\r\n> • Inter-DC requests working properly.\r\n> • Merge branch 'master' into bcounter-new\r\n> • Merge branch 'master' into bcounter-new\r\n> File Changes\r\n>\r\n> • M include/antidote.hrl (5)\r\n> • M include/antidote_message_types.hrl (5)\r\n> • M src/antidote_sup.erl (12)\r\n> • A src/bcounter_mgr.erl (219)\r\n> • M src/clocksi_downstream.erl (10)\r\n> • M src/inter_dc_query_receive_socket.erl (4)\r\n> • M src/inter_dc_query_response.erl (14)\r\n> • A test/bcountermgr_SUITE.erl (134)\r\n> Patch Links:\r\n>\r\n> • https://github.com/SyncFree/antidote/pull/212.patch\r\n> • https://github.com/SyncFree/antidote/pull/212.diff\r\n> —\r\n> You are receiving this because you are subscribed to this thread.\r\n> Reply to this email directly, view it on GitHub, or mute the thread.\r\n>\r\n\r\n\r\n—\r\nYou are receiving this because you authored the thread.\r\nReply to this email directly, view it on GitHub<https://github.com/SyncFree/antidote/pull/212#issuecomment-243577924>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABAADduBeGGG2iX58nTAdfzEzaXU1mpWks5qlJjegaJpZM4JwtBr>.\r\n\r\n"}}
{"actor":{"display_login":"balegas"}}