{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/facter/issues/1355","repository_url":"https://api.github.com/repos/puppetlabs/facter","labels_url":"https://api.github.com/repos/puppetlabs/facter/issues/1355/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1355/comments","events_url":"https://api.github.com/repos/puppetlabs/facter/issues/1355/events","html_url":"https://github.com/puppetlabs/facter/pull/1355","id":161263750,"number":1355,"title":"(maint) update the facter.rb script to include puppet/bin to path","user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-20T18:36:03Z","updated_at":"2016-06-20T19:54:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1355","html_url":"https://github.com/puppetlabs/facter/pull/1355","diff_url":"https://github.com/puppetlabs/facter/pull/1355.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1355.patch"},"body":"Currently, to faclitate windows, facter.rb loads the path to the facter/bin\r\ndirectory on to the PATH env var. Vanagon builds of facter and puppet-agent\r\nrequire an extra inclusion of puppet/bin to PATH as well to work on windows.\r\n\r\nThis extra inclusion should not effect current windows builds using pftw"},"comment":{"url":"https://api.github.com/repos/puppetlabs/facter/issues/comments/227250720","html_url":"https://github.com/puppetlabs/facter/pull/1355#issuecomment-227250720","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1355","id":227250720,"user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T19:54:30Z","updated_at":"2016-06-20T19:54:30Z","body":"As a note: this fix is specifically for windows puppet-agent builds using vanagon."}}
{"actor":{"display_login":"McdonaldSeanp"}}