{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/15568","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/15568/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/15568/comments","events_url":"https://api.github.com/repos/apache/spark/issues/15568/events","html_url":"https://github.com/apache/spark/pull/15568","id":184226650,"number":15568,"title":"[SPARK-18028][SQL] simplify TableFileCatalog","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars.githubusercontent.com/u/3182036?v=3","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-20T13:16:05Z","updated_at":"2016-10-20T15:50:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15568","html_url":"https://github.com/apache/spark/pull/15568","diff_url":"https://github.com/apache/spark/pull/15568.diff","patch_url":"https://github.com/apache/spark/pull/15568.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nSimplify/cleanup TableFileCatalog:\r\n\r\n1. pass a `CatalogTable` instead of `databaseName` and `tableName` into `TableFileCatalog`, so that we don't need to fetch table metadata from metastore again\r\n2. In `TableFileCatalog.filterPartitions0`, DO NOT set `PartitioningAwareFileCatalog.BASE_PATH_PARAM`. According to the [classdoc](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileCatalog.scala#L189-L209), the default value of `basePath` already satisfies our need. What's more, if we set this parameter, we may break the case 2 which is metioned in the classdoc.\r\n3. add `equals` and `hashCode` to `TableFileCatalog`\r\n4. add `SessionCatalog.listPartitionsByFilter` which handles case sensitivity.\r\n\r\n## How was this patch tested?\r\n\r\nexisting tests.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/255146302","html_url":"https://github.com/apache/spark/pull/15568#issuecomment-255146302","issue_url":"https://api.github.com/repos/apache/spark/issues/15568","id":255146302,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T15:50:02Z","updated_at":"2016-10-20T15:50:02Z","body":"Test PASSed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67266/\nTest PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}