{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/49644593","id":49644593,"diff_hunk":"@@ -1127,6 +1127,218 @@ textarea {\n }\n \n /* topdoc\n+  name: Icon inside input\n+  family: cf-forms\n+  patterns:\n+    - name: Default icons before and after a default input.\n+      markup: |\n+        <div class=\"input-contains-icon\">\n+            <div class=\"input-contains-icon_before\n+                        input-contains-icon_before__search\">\n+                <span class=\"input-contains-icon_icon\"></span>\n+            </div>\n+            <div class=\"input-contains-icon_after\n+                        input-contains-icon_after__clear\">\n+                <button class=\"btn btn__link btn__secondary\">\n+                    <span class=\"input-contains-icon_icon\"></span>\n+                    <span class=\"input-contains-icon_label\"></span>\n+                </button>\n+            </div>\n+            <input type=\"text\" value=\"\">\n+        </div>\n+    - name: Super-sized icons before and after a super input.\n+      markup: |\n+        <div class=\"input-contains-icon\n+                    input__super\">\n+            <div class=\"input-contains-icon_before\n+                        input-contains-icon_before__search\">\n+                <span class=\"input-contains-icon_icon\"></span>\n+            </div>\n+            <div class=\"input-contains-icon_after\n+                        input-contains-icon_after__clear\">\n+                <button class=\"btn btn__super btn__link btn__secondary\">\n+                    <span class=\"input-contains-icon_icon\"></span>\n+                    <span class=\"input-contains-icon_label\"></span>\n+                </button>\n+            </div>\n+            <input class=\"input__super\"\n+                   type=\"text\"\n+                   value=\"\">\n+        </div>\n+    - name: Default icons before and after a default input, with a button.\n+      markup: |\n+        <div class=\"input-with-btn\">\n+            <div class=\"input-with-btn_input\n+                        input-contains-icon\">\n+                <div class=\"input-contains-icon_before\n+                            input-contains-icon_before__search\">\n+                    <span class=\"input-contains-icon_icon\"></span>\n+                </div>\n+                <div class=\"input-contains-icon_after\n+                            input-contains-icon_after__clear\">\n+                    <button class=\"btn btn__link btn__secondary\">\n+                        <span class=\"input-contains-icon_icon\"></span>\n+                        <span class=\"input-contains-icon_label\"></span>\n+                    </button>\n+                </div>\n+                <input type=\"text\"\n+                       value=\"This is some really long text to make sure that the button doesn't overlap the content in such a way that this input becomes unusable.\" title=\"Test input\">\n+            </div>\n+            <div class=\"input-with-btn_btn\">\n+                <button class=\"btn\">Search</button>\n+            </div>\n+        </div>\n+    - name: Super-sized icons before and after a super input, with a button.\n+      markup: |\n+        <div class=\"input-with-btn\">\n+            <div class=\"input-with-btn_input\n+                        input-contains-icon\n+                        input__super\">\n+                <div class=\"input-contains-icon_before\n+                            input-contains-icon_before__search\">\n+                    <span class=\"input-contains-icon_icon\"></span>\n+                </div>\n+                <div class=\"input-contains-icon_after\n+                            input-contains-icon_after__clear\">\n+                    <button class=\"btn btn__super btn__link btn__secondary\">\n+                        <span class=\"input-contains-icon_icon\"></span>\n+                        <span class=\"input-contains-icon_label\"></span>\n+                    </button>\n+                </div>\n+                <input class=\"input__super\"\n+                       type=\"text\"\n+                       value=\"This is some really long text to make sure that the button doesn't overlap the content in such a way that this input becomes unusable.\" title=\"Test input\">\n+            </div>\n+            <div class=\"input-with-btn_btn\">\n+                <button class=\"btn btn__super\">Search</button>\n+            </div>\n+        </div>\n+  tags:\n+    - cf-forms\n+*/\n+\n+.input-contains-icon {\n+    position: relative;\n+\n+    &_before {\n+        .webfont-regular;\n+        position: absolute;\n+        top: 0;\n+        left: unit( 10px / @btn-font-size, em );\n+        margin: unit( @btn-v-padding / @btn-font-size, em ) 0;","path":"cfgov/unprocessed/css/cf-enhancements.less","position":null,"original_position":102,"commit_id":"c533e5a706c270da2a48a2eec1388576b7067aef","original_commit_id":"336a96e3389bfc2ec2f471a8272831b9fd974e52","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"body":"Removed in https://github.com/cfpb/cfgov-refresh/commit/91fbae6147b56362888b13d8c47d35d5d3284761 ","created_at":"2016-01-13T20:17:19Z","updated_at":"2016-01-13T20:17:19Z","html_url":"https://github.com/cfpb/cfgov-refresh/pull/1330#discussion_r49644593","pull_request_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/49644593"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/1330#discussion_r49644593"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330","id":55773244,"html_url":"https://github.com/cfpb/cfgov-refresh/pull/1330","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/1330.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/1330.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1330","number":1330,"state":"open","locked":false,"title":"Adds input-contains-label class","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"body":"## Additions\r\n\r\n- ~~`input-contains-icon`~~ `input-contains-label` for placing an icon in front and at the end of an input field, plus modifiers for specific icons.\r\n\r\n## Testing\r\n\r\n- Demo at bottom of `/browse-basic/`.\r\n\r\n## Review\r\n\r\n- @jimmynotjim \r\n- @sebworks \r\n- @KimberlyMunoz \r\n\r\n## Screenshots\r\n\r\nMobile:\r\n<img width=\"359\" alt=\"screen shot 2016-01-12 at 10 31 48 am\" src=\"https://cloud.githubusercontent.com/assets/704760/12267774/b4f7b6c6-b917-11e5-85d1-b98d948c6c98.png\">\r\n\r\nTablet:\r\n<img width=\"562\" alt=\"screen shot 2016-01-12 at 10 06 05 am\" src=\"https://cloud.githubusercontent.com/assets/704760/12267780/bdd78136-b917-11e5-839f-8bb94eb373b4.png\">\r\n\r\nDesktop:\r\n<img width=\"628\" alt=\"screen shot 2016-01-12 at 10 05 57 am\" src=\"https://cloud.githubusercontent.com/assets/704760/12267786/c3b621f2-b917-11e5-84d3-789d45eb0547.png\">\r\n\r\n\r\n## Todos\r\n\r\n-  `btn-inside-input` in cf-forms is deprecated by `input-contains-icon`, so that the classes can follow the format of `input-with-btn`. Also, the modifiers are added so that the spacing is controlled. `btn-inside-input` allows a button and a label but doesn't adjust the input padding based on the content of button.","created_at":"2016-01-12T15:33:06Z","updated_at":"2016-01-13T20:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"566700f867f954f7cb5a70da093fb4043cec85b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1330/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/c533e5a706c270da2a48a2eec1388576b7067aef","head":{"label":"cfpb:forms_icon_update","ref":"forms_icon_update","sha":"c533e5a706c270da2a48a2eec1388576b7067aef","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2016-01-12T20:02:37Z","pushed_at":"2016-01-13T20:14:21Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":95743,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":122,"forks":19,"open_issues":122,"watchers":12,"default_branch":"flapjack"}},"base":{"label":"cfpb:flapjack","ref":"flapjack","sha":"89ba4d01321620fa4c995a7f270f87a65a676444","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2016-01-12T20:02:37Z","pushed_at":"2016-01-13T20:14:21Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":95743,"stargazers_count":12,"watchers_count":12,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":122,"forks":19,"open_issues":122,"watchers":12,"default_branch":"flapjack"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/1330"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1330"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/1330/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/1330/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/c533e5a706c270da2a48a2eec1388576b7067aef"}}}}