{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/3753","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/3753/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/3753/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/3753/events","html_url":"https://github.com/qTox/qTox/issues/3753","id":179595505,"number":3753,"title":"Don't compile emoji into the binary for packages","user":{"login":"sudden6","id":5585762,"avatar_url":"https://avatars.githubusercontent.com/u/5585762?v=3","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/qTox/qTox/labels/I-packaging","name":"I-packaging","color":"fc2929"},{"url":"https://api.github.com/repos/qTox/qTox/labels/proposal","name":"proposal","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/qTox/qTox/milestones/12","html_url":"https://github.com/qTox/qTox/milestones/No%20compiling-in%20emoticons","labels_url":"https://api.github.com/repos/qTox/qTox/milestones/12/labels","id":2025739,"number":12,"title":"No compiling-in emoticons","description":"Worked on by @sudden6","creator":{"login":"zetok","id":3148759,"avatar_url":"https://avatars.githubusercontent.com/u/3148759?v=3","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-09-24T09:50:00Z","updated_at":"2016-09-27T23:23:38Z","due_on":"2016-10-24T00:00:00Z","closed_at":null},"comments":0,"created_at":"2016-09-27T19:53:01Z","updated_at":"2016-09-30T16:09:49Z","closed_at":null,"body":"Currently all emoticons are statically compiled into the qTox binary. I think this was done because first it's easy and second because it makes the binary portable.\r\n\r\n### What this proposal is about:\r\n\r\n* Removing the smileys from the binary and putting them into the appropriate folders for the platform\r\n* mainly about Linux and Mac\r\n\r\nWhat this proposal isn't about:\r\n\r\n* Changing the portable builds \r\n\r\n### Why?\r\n\r\n* Smileys don't change that often, no need to compile and update them with the binary\r\n* It's common practice to separate data from the binary (at least in the *NIX based world)\r\n* reduce resource usage during compile\r\n* packagers could choose not to ship the default emoji packs to optimize resource usage for a given distribution\r\n* ideally (IMHO) qTox wouldn't ship any smileys and could use already installed smiley packs -> probably utopic for now\r\n* on Linux if the emoji are installed to `/usr/share/emoticons/<emoji-pack>` KDE applications could use them too -> unified look\r\n\r\n### Steps\r\n\r\n1. Allow compiling without emoticons -> WIP in #3737\r\n2. Package emoji so that they are placed in either `$XDG_DATA_DIR/emoticons` or `$XDG_DATA_DIR/qtox/emoticons`\r\n3. Disable compiling with emoticons for packages implementing the above\r\n\r\n### Alternatives\r\n\r\n* Don't change anything -> well...\r\n* Instead of the raw emoji files it would also be possible to compile and compress them into a `*.qrc` file and use this to dynamically load smiley packs. Advantage would be probably better loading times, but the emoji would be qTox only.\r\n\r\nEDIT: paging @abbat because you do the packaging on OBS and have experience"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/250785564","html_url":"https://github.com/qTox/qTox/issues/3753#issuecomment-250785564","issue_url":"https://api.github.com/repos/qTox/qTox/issues/3753","id":250785564,"user":{"login":"zetok","id":3148759,"avatar_url":"https://avatars.githubusercontent.com/u/3148759?v=3","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T16:09:49Z","updated_at":"2016-09-30T16:09:49Z","body":">Package emoji so that they are placed in either `$XDG_DATA_DIR/emoticons` or `$XDG_DATA_DIR/qtox/emoticons`\r\n\r\nThat's wrong – packaging doesn't touch user dirs, where those vars point to.\r\n\r\nEmoticons should be installed to `/usr/share/emoticons`"}}
{"actor":{"display_login":"zetok"}}