{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/77","repository_url":"https://api.github.com/repos/PowerShell/xSQLServer","labels_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/77/comments","events_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/77/events","html_url":"https://github.com/PowerShell/xSQLServer/pull/77","id":167090643,"number":77,"title":"Sql2016","user":{"login":"aultt","id":13204968,"avatar_url":"https://avatars.githubusercontent.com/u/13204968?v=3","gravatar_id":"","url":"https://api.github.com/users/aultt","html_url":"https://github.com/aultt","followers_url":"https://api.github.com/users/aultt/followers","following_url":"https://api.github.com/users/aultt/following{/other_user}","gists_url":"https://api.github.com/users/aultt/gists{/gist_id}","starred_url":"https://api.github.com/users/aultt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aultt/subscriptions","organizations_url":"https://api.github.com/users/aultt/orgs","repos_url":"https://api.github.com/users/aultt/repos","events_url":"https://api.github.com/users/aultt/events{/privacy}","received_events_url":"https://api.github.com/users/aultt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PowerShell/xSQLServer/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2016-07-22T17:11:33Z","updated_at":"2016-07-28T11:21:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/pulls/77","html_url":"https://github.com/PowerShell/xSQLServer/pull/77","diff_url":"https://github.com/PowerShell/xSQLServer/pull/77.diff","patch_url":"https://github.com/PowerShell/xSQLServer/pull/77.patch"},"body":"Added Support for SQLServer 2016 for standalone and failover cluster\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xsqlserver/77)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/comments/235867995","html_url":"https://github.com/PowerShell/xSQLServer/pull/77#issuecomment-235867995","issue_url":"https://api.github.com/repos/PowerShell/xSQLServer/issues/77","id":235867995,"user":{"login":"johlju","id":7189721,"avatar_url":"https://avatars.githubusercontent.com/u/7189721?v=3","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T11:21:25Z","updated_at":"2016-07-28T11:21:25Z","body":"\n\n\n\nReviewed 1 of 3 files at r3, 2 of 5 files at r5, 1 of 3 files at r6, 1 of 1 files at r7.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[DSCResources/MSFT_xSQLServerFailoverClusterSetup/MSFT_xSQLServerFailoverClusterSetup.psm1, line 454 \\[r7\\]](https://reviewable.io:443/reviews/powershell/xsqlserver/77#-KNlCTdbj6my40vufy1y:-KNlAslg1JHgH-UykQMf:1790994829) ([raw file](https://github.com/powershell/xsqlserver/blob/7e5037f7b99bc5b3a46563562bdd86f255fa9740/DSCResources/MSFT_xSQLServerFailoverClusterSetup/MSFT_xSQLServerFailoverClusterSetup.psm1#L454)):*\n> ```PowerShell\n>     $SQLVersion = GetSQLVersion -Path $Path\n>     \n>     foreach($Feature in $Features.Split(\",\"))\n> ```\n\nCan you change `$Feature` to be `$feature` in this foreach-block.\n\n---\n\n*[DSCResources/MSFT_xSQLServerFailoverClusterSetup/MSFT_xSQLServerFailoverClusterSetup.psm1, line 456 \\[r7\\]](https://reviewable.io:443/reviews/powershell/xsqlserver/77#-KNlCWu2ACNfJhTKxog6:-KNlCWu2ACNfJhTKxog7:950208240) ([raw file](https://github.com/powershell/xsqlserver/blob/7e5037f7b99bc5b3a46563562bdd86f255fa9740/DSCResources/MSFT_xSQLServerFailoverClusterSetup/MSFT_xSQLServerFailoverClusterSetup.psm1#L456)):*\n> ```PowerShell\n>     foreach($Feature in $Features.Split(\",\"))\n>     { \n>          if (($SQLVersion -eq \"13\") -and (($Feature -eq \"SSMS\") -or ($Feature -eq \"ADV_SSMS\")))\n> ```\n\nRemove the whitespace between `if (`\n\n---\n\n*[DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1, line 548 \\[r7\\]](https://reviewable.io:443/reviews/powershell/xsqlserver/77#-KNlCk2mqIPfU1dMuCrh:-KNlCk2mqIPfU1dMuCri:2041384254) ([raw file](https://github.com/powershell/xsqlserver/blob/7e5037f7b99bc5b3a46563562bdd86f255fa9740/DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1#L548)):*\n> ```PowerShell\n>     # Determine features to install\n>     $FeaturesToInstall = \"\"\n>     foreach($Feature in $Features.Split(\",\"))\n> ```\n\nCan you change `$Feature` to `$feature` in this foreach-block\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/powershell/xsqlserver/77)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"johlju"}}