{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/90903654","pull_request_review_id":11417211,"id":90903654,"diff_hunk":"@@ -16,16 +16,20 @@\n \n module Api\n   class Node < Tableless\n+    attr_reader :node_name","path":"crowbar_framework/app/models/api/node.rb","position":4,"original_position":4,"commit_id":"64277187e4d34f7423f512d09d7002e517893032","original_commit_id":"64277187e4d34f7423f512d09d7002e517893032","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"Why not simply `name`?","created_at":"2016-12-05T16:42:32Z","updated_at":"2016-12-05T16:43:56Z","html_url":"https://github.com/crowbar/crowbar-core/pull/856#discussion_r90903654","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/90903654"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/856#discussion_r90903654"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856","id":96553382,"html_url":"https://github.com/crowbar/crowbar-core/pull/856","diff_url":"https://github.com/crowbar/crowbar-core/pull/856.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/856.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/856","number":856,"state":"open","locked":false,"title":"Add ssh connection Remove NodeObject dependency from Api::Node","user":{"login":"felixsch","id":4460715,"avatar_url":"https://avatars.githubusercontent.com/u/4460715?v=3","gravatar_id":"","url":"https://api.github.com/users/felixsch","html_url":"https://github.com/felixsch","followers_url":"https://api.github.com/users/felixsch/followers","following_url":"https://api.github.com/users/felixsch/following{/other_user}","gists_url":"https://api.github.com/users/felixsch/gists{/gist_id}","starred_url":"https://api.github.com/users/felixsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixsch/subscriptions","organizations_url":"https://api.github.com/users/felixsch/orgs","repos_url":"https://api.github.com/users/felixsch/repos","events_url":"https://api.github.com/users/felixsch/events{/privacy}","received_events_url":"https://api.github.com/users/felixsch/received_events","type":"User","site_admin":false},"body":"By duplicating the already existing ssh connection code from NodeObject to a own Class it is possibly to decouple most of the code from Api::Node from NodeObject.\r\n\r\nThis commit is the first step to refactor the NodeObject and move possible parts into the database.","created_at":"2016-12-05T15:48:03Z","updated_at":"2016-12-05T16:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d43ff5586f88ecb868611a71a919ce6751ddd050","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/856/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/64277187e4d34f7423f512d09d7002e517893032","head":{"label":"felixsch:cleanup-api-node","ref":"cleanup-api-node","sha":"64277187e4d34f7423f512d09d7002e517893032","user":{"login":"felixsch","id":4460715,"avatar_url":"https://avatars.githubusercontent.com/u/4460715?v=3","gravatar_id":"","url":"https://api.github.com/users/felixsch","html_url":"https://github.com/felixsch","followers_url":"https://api.github.com/users/felixsch/followers","following_url":"https://api.github.com/users/felixsch/following{/other_user}","gists_url":"https://api.github.com/users/felixsch/gists{/gist_id}","starred_url":"https://api.github.com/users/felixsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixsch/subscriptions","organizations_url":"https://api.github.com/users/felixsch/orgs","repos_url":"https://api.github.com/users/felixsch/repos","events_url":"https://api.github.com/users/felixsch/events{/privacy}","received_events_url":"https://api.github.com/users/felixsch/received_events","type":"User","site_admin":false},"repo":{"id":75075467,"name":"crowbar-core","full_name":"felixsch/crowbar-core","owner":{"login":"felixsch","id":4460715,"avatar_url":"https://avatars.githubusercontent.com/u/4460715?v=3","gravatar_id":"","url":"https://api.github.com/users/felixsch","html_url":"https://github.com/felixsch","followers_url":"https://api.github.com/users/felixsch/followers","following_url":"https://api.github.com/users/felixsch/following{/other_user}","gists_url":"https://api.github.com/users/felixsch/gists{/gist_id}","starred_url":"https://api.github.com/users/felixsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixsch/subscriptions","organizations_url":"https://api.github.com/users/felixsch/orgs","repos_url":"https://api.github.com/users/felixsch/repos","events_url":"https://api.github.com/users/felixsch/events{/privacy}","received_events_url":"https://api.github.com/users/felixsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixsch/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/felixsch/crowbar-core","forks_url":"https://api.github.com/repos/felixsch/crowbar-core/forks","keys_url":"https://api.github.com/repos/felixsch/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixsch/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixsch/crowbar-core/teams","hooks_url":"https://api.github.com/repos/felixsch/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/felixsch/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/felixsch/crowbar-core/events","assignees_url":"https://api.github.com/repos/felixsch/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/felixsch/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/felixsch/crowbar-core/tags","blobs_url":"https://api.github.com/repos/felixsch/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixsch/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixsch/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixsch/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixsch/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/felixsch/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/felixsch/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/felixsch/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/felixsch/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/felixsch/crowbar-core/subscription","commits_url":"https://api.github.com/repos/felixsch/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixsch/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixsch/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixsch/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixsch/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/felixsch/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixsch/crowbar-core/merges","archive_url":"https://api.github.com/repos/felixsch/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixsch/crowbar-core/downloads","issues_url":"https://api.github.com/repos/felixsch/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/felixsch/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/felixsch/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/felixsch/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixsch/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/felixsch/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/felixsch/crowbar-core/deployments","created_at":"2016-11-29T11:36:20Z","updated_at":"2016-11-29T11:36:22Z","pushed_at":"2016-12-05T15:24:24Z","git_url":"git://github.com/felixsch/crowbar-core.git","ssh_url":"git@github.com:felixsch/crowbar-core.git","clone_url":"https://github.com/felixsch/crowbar-core.git","svn_url":"https://github.com/felixsch/crowbar-core","homepage":null,"size":106720,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"9a21ae54c4c1af62de80846a5a4fa8df5e70b1c6","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-11-11T19:16:44Z","pushed_at":"2016-12-05T15:48:03Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":122019,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":47,"forks":38,"open_issues":47,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/856"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/856"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/64277187e4d34f7423f512d09d7002e517893032"}}}}
{"actor":{"display_login":"vuntz"}}