{"action":"created","comment":{"url":"https://api.github.com/repos/opentoken-io/opentoken/pulls/comments/63515675","id":63515675,"diff_hunk":"@@ -19,6 +36,28 @@\n  * @typedef {Object} accountManager~confirmedInfo\n  * @property {string} mfaKey\n  * @property {string} passwordSalt\n+ * @property {accountManager~hashSet} pbkdf2\n+ */\n+\n+/**\n+ * How to hash a password for registering and logging in.\n+ *\n+ * @typedef {Object} accountManager~hashSet\n+ * @property {string} algo\n+ * @property {string} bytes\n+ * @property {string} iterations\n+ * @property {string} saltLength\n+ */\n+\n+/**\n+ * What an account holder needs to create the password hash","path":"lib/account/account-manager.js","position":42,"original_position":42,"commit_id":"f494f74c58b5964658a02a5afe100f3d14e5b482","original_commit_id":"f494f74c58b5964658a02a5afe100f3d14e5b482","user":{"login":"fidian","id":428348,"avatar_url":"https://avatars.githubusercontent.com/u/428348?v=3","gravatar_id":"","url":"https://api.github.com/users/fidian","html_url":"https://github.com/fidian","followers_url":"https://api.github.com/users/fidian/followers","following_url":"https://api.github.com/users/fidian/following{/other_user}","gists_url":"https://api.github.com/users/fidian/gists{/gist_id}","starred_url":"https://api.github.com/users/fidian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidian/subscriptions","organizations_url":"https://api.github.com/users/fidian/orgs","repos_url":"https://api.github.com/users/fidian/repos","events_url":"https://api.github.com/users/fidian/events{/privacy}","received_events_url":"https://api.github.com/users/fidian/received_events","type":"User","site_admin":false},"body":"Would you change \"to\" into \"in order to\"?  It took me three tries reading this sentence to understand that the phrase \"needs to create\" means \"is required to have in order to create\" instead of \"should generate\"","created_at":"2016-05-17T12:53:36Z","updated_at":"2016-05-17T12:53:36Z","html_url":"https://github.com/opentoken-io/opentoken/pull/64#discussion_r63515675","pull_request_url":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/opentoken-io/opentoken/pulls/comments/63515675"},"html":{"href":"https://github.com/opentoken-io/opentoken/pull/64#discussion_r63515675"},"pull_request":{"href":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64","id":69557695,"html_url":"https://github.com/opentoken-io/opentoken/pull/64","diff_url":"https://github.com/opentoken-io/opentoken/pull/64.diff","patch_url":"https://github.com/opentoken-io/opentoken/pull/64.patch","issue_url":"https://api.github.com/repos/opentoken-io/opentoken/issues/64","number":64,"state":"open","locked":false,"title":"Login","user":{"login":"AbsentSemicolon","id":1569396,"avatar_url":"https://avatars.githubusercontent.com/u/1569396?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsentSemicolon","html_url":"https://github.com/AbsentSemicolon","followers_url":"https://api.github.com/users/AbsentSemicolon/followers","following_url":"https://api.github.com/users/AbsentSemicolon/following{/other_user}","gists_url":"https://api.github.com/users/AbsentSemicolon/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsentSemicolon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsentSemicolon/subscriptions","organizations_url":"https://api.github.com/users/AbsentSemicolon/orgs","repos_url":"https://api.github.com/users/AbsentSemicolon/repos","events_url":"https://api.github.com/users/AbsentSemicolon/events{/privacy}","received_events_url":"https://api.github.com/users/AbsentSemicolon/received_events","type":"User","site_admin":false},"body":"This adds the functionality for working with logging into the system.","created_at":"2016-05-10T18:49:20Z","updated_at":"2016-05-17T12:53:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39ef9281ebf4678d9029a659ff98f4315b4d1cb4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64/commits","review_comments_url":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64/comments","review_comment_url":"https://api.github.com/repos/opentoken-io/opentoken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentoken-io/opentoken/issues/64/comments","statuses_url":"https://api.github.com/repos/opentoken-io/opentoken/statuses/f494f74c58b5964658a02a5afe100f3d14e5b482","head":{"label":"AbsentSemicolon:login","ref":"login","sha":"f494f74c58b5964658a02a5afe100f3d14e5b482","user":{"login":"AbsentSemicolon","id":1569396,"avatar_url":"https://avatars.githubusercontent.com/u/1569396?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsentSemicolon","html_url":"https://github.com/AbsentSemicolon","followers_url":"https://api.github.com/users/AbsentSemicolon/followers","following_url":"https://api.github.com/users/AbsentSemicolon/following{/other_user}","gists_url":"https://api.github.com/users/AbsentSemicolon/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsentSemicolon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsentSemicolon/subscriptions","organizations_url":"https://api.github.com/users/AbsentSemicolon/orgs","repos_url":"https://api.github.com/users/AbsentSemicolon/repos","events_url":"https://api.github.com/users/AbsentSemicolon/events{/privacy}","received_events_url":"https://api.github.com/users/AbsentSemicolon/received_events","type":"User","site_admin":false},"repo":{"id":54571107,"name":"opentoken","full_name":"AbsentSemicolon/opentoken","owner":{"login":"AbsentSemicolon","id":1569396,"avatar_url":"https://avatars.githubusercontent.com/u/1569396?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsentSemicolon","html_url":"https://github.com/AbsentSemicolon","followers_url":"https://api.github.com/users/AbsentSemicolon/followers","following_url":"https://api.github.com/users/AbsentSemicolon/following{/other_user}","gists_url":"https://api.github.com/users/AbsentSemicolon/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsentSemicolon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsentSemicolon/subscriptions","organizations_url":"https://api.github.com/users/AbsentSemicolon/orgs","repos_url":"https://api.github.com/users/AbsentSemicolon/repos","events_url":"https://api.github.com/users/AbsentSemicolon/events{/privacy}","received_events_url":"https://api.github.com/users/AbsentSemicolon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AbsentSemicolon/opentoken","description":"Public and free software API to tokenize or encrypt data.","fork":true,"url":"https://api.github.com/repos/AbsentSemicolon/opentoken","forks_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/forks","keys_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/teams","hooks_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/hooks","issue_events_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/issues/events{/number}","events_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/events","assignees_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/assignees{/user}","branches_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/branches{/branch}","tags_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/tags","blobs_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/languages","stargazers_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/stargazers","contributors_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/contributors","subscribers_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/subscribers","subscription_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/subscription","commits_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/contents/{+path}","compare_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/merges","archive_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/downloads","issues_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/issues{/number}","pulls_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/labels{/name}","releases_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/releases{/id}","deployments_url":"https://api.github.com/repos/AbsentSemicolon/opentoken/deployments","created_at":"2016-03-23T15:28:27Z","updated_at":"2016-03-24T14:35:24Z","pushed_at":"2016-05-16T20:54:06Z","git_url":"git://github.com/AbsentSemicolon/opentoken.git","ssh_url":"git@github.com:AbsentSemicolon/opentoken.git","clone_url":"https://github.com/AbsentSemicolon/opentoken.git","svn_url":"https://github.com/AbsentSemicolon/opentoken","homepage":"","size":272,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentoken-io:master","ref":"master","sha":"b4391f308179f574aca581744d2273a3abf026da","user":{"login":"opentoken-io","id":17858137,"avatar_url":"https://avatars.githubusercontent.com/u/17858137?v=3","gravatar_id":"","url":"https://api.github.com/users/opentoken-io","html_url":"https://github.com/opentoken-io","followers_url":"https://api.github.com/users/opentoken-io/followers","following_url":"https://api.github.com/users/opentoken-io/following{/other_user}","gists_url":"https://api.github.com/users/opentoken-io/gists{/gist_id}","starred_url":"https://api.github.com/users/opentoken-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentoken-io/subscriptions","organizations_url":"https://api.github.com/users/opentoken-io/orgs","repos_url":"https://api.github.com/users/opentoken-io/repos","events_url":"https://api.github.com/users/opentoken-io/events{/privacy}","received_events_url":"https://api.github.com/users/opentoken-io/received_events","type":"Organization","site_admin":false},"repo":{"id":54493906,"name":"opentoken","full_name":"opentoken-io/opentoken","owner":{"login":"opentoken-io","id":17858137,"avatar_url":"https://avatars.githubusercontent.com/u/17858137?v=3","gravatar_id":"","url":"https://api.github.com/users/opentoken-io","html_url":"https://github.com/opentoken-io","followers_url":"https://api.github.com/users/opentoken-io/followers","following_url":"https://api.github.com/users/opentoken-io/following{/other_user}","gists_url":"https://api.github.com/users/opentoken-io/gists{/gist_id}","starred_url":"https://api.github.com/users/opentoken-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentoken-io/subscriptions","organizations_url":"https://api.github.com/users/opentoken-io/orgs","repos_url":"https://api.github.com/users/opentoken-io/repos","events_url":"https://api.github.com/users/opentoken-io/events{/privacy}","received_events_url":"https://api.github.com/users/opentoken-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentoken-io/opentoken","description":"Public and free software API to tokenize or encrypt data.","fork":false,"url":"https://api.github.com/repos/opentoken-io/opentoken","forks_url":"https://api.github.com/repos/opentoken-io/opentoken/forks","keys_url":"https://api.github.com/repos/opentoken-io/opentoken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentoken-io/opentoken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentoken-io/opentoken/teams","hooks_url":"https://api.github.com/repos/opentoken-io/opentoken/hooks","issue_events_url":"https://api.github.com/repos/opentoken-io/opentoken/issues/events{/number}","events_url":"https://api.github.com/repos/opentoken-io/opentoken/events","assignees_url":"https://api.github.com/repos/opentoken-io/opentoken/assignees{/user}","branches_url":"https://api.github.com/repos/opentoken-io/opentoken/branches{/branch}","tags_url":"https://api.github.com/repos/opentoken-io/opentoken/tags","blobs_url":"https://api.github.com/repos/opentoken-io/opentoken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentoken-io/opentoken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentoken-io/opentoken/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentoken-io/opentoken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentoken-io/opentoken/statuses/{sha}","languages_url":"https://api.github.com/repos/opentoken-io/opentoken/languages","stargazers_url":"https://api.github.com/repos/opentoken-io/opentoken/stargazers","contributors_url":"https://api.github.com/repos/opentoken-io/opentoken/contributors","subscribers_url":"https://api.github.com/repos/opentoken-io/opentoken/subscribers","subscription_url":"https://api.github.com/repos/opentoken-io/opentoken/subscription","commits_url":"https://api.github.com/repos/opentoken-io/opentoken/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentoken-io/opentoken/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentoken-io/opentoken/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentoken-io/opentoken/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentoken-io/opentoken/contents/{+path}","compare_url":"https://api.github.com/repos/opentoken-io/opentoken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentoken-io/opentoken/merges","archive_url":"https://api.github.com/repos/opentoken-io/opentoken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentoken-io/opentoken/downloads","issues_url":"https://api.github.com/repos/opentoken-io/opentoken/issues{/number}","pulls_url":"https://api.github.com/repos/opentoken-io/opentoken/pulls{/number}","milestones_url":"https://api.github.com/repos/opentoken-io/opentoken/milestones{/number}","notifications_url":"https://api.github.com/repos/opentoken-io/opentoken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentoken-io/opentoken/labels{/name}","releases_url":"https://api.github.com/repos/opentoken-io/opentoken/releases{/id}","deployments_url":"https://api.github.com/repos/opentoken-io/opentoken/deployments","created_at":"2016-03-22T17:10:18Z","updated_at":"2016-04-09T16:45:58Z","pushed_at":"2016-05-17T12:05:58Z","git_url":"git://github.com/opentoken-io/opentoken.git","ssh_url":"git@github.com:opentoken-io/opentoken.git","clone_url":"https://github.com/opentoken-io/opentoken.git","svn_url":"https://github.com/opentoken-io/opentoken","homepage":"","size":285,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64"},"html":{"href":"https://github.com/opentoken-io/opentoken/pull/64"},"issue":{"href":"https://api.github.com/repos/opentoken-io/opentoken/issues/64"},"comments":{"href":"https://api.github.com/repos/opentoken-io/opentoken/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/opentoken-io/opentoken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentoken-io/opentoken/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/opentoken-io/opentoken/statuses/f494f74c58b5964658a02a5afe100f3d14e5b482"}}}}