{"action":"closed","number":37545,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37545","id":95469043,"html_url":"https://github.com/kubernetes/kubernetes/pull/37545","diff_url":"https://github.com/kubernetes/kubernetes/pull/37545.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37545.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37545","number":37545,"state":"closed","locked":false,"title":"drop startKubelet's return","user":{"login":"NickrenREN","id":6104418,"avatar_url":"https://avatars.githubusercontent.com/u/6104418?v=3","gravatar_id":"","url":"https://api.github.com/users/NickrenREN","html_url":"https://github.com/NickrenREN","followers_url":"https://api.github.com/users/NickrenREN/followers","following_url":"https://api.github.com/users/NickrenREN/following{/other_user}","gists_url":"https://api.github.com/users/NickrenREN/gists{/gist_id}","starred_url":"https://api.github.com/users/NickrenREN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickrenREN/subscriptions","organizations_url":"https://api.github.com/users/NickrenREN/orgs","repos_url":"https://api.github.com/users/NickrenREN/repos","events_url":"https://api.github.com/users/NickrenREN/events{/privacy}","received_events_url":"https://api.github.com/users/NickrenREN/received_events","type":"User","site_admin":false},"body":"\r\nSince startKubelet() function will always return nil, we donot need to judge its return err\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37545)\n<!-- Reviewable:end -->\n","created_at":"2016-11-28T10:07:14Z","updated_at":"2016-12-06T08:22:58Z","closed_at":"2016-12-06T08:22:58Z","merged_at":"2016-12-06T08:22:58Z","merge_commit_sha":"7fe882c479db747d1c6f590a62387a742c5e4b14","assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"assignees":[{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37545/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37545/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37545/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/48026ce6553634171766fb6645a39b913afe422e","head":{"label":"NickrenREN:startkubelet","ref":"startkubelet","sha":"48026ce6553634171766fb6645a39b913afe422e","user":{"login":"NickrenREN","id":6104418,"avatar_url":"https://avatars.githubusercontent.com/u/6104418?v=3","gravatar_id":"","url":"https://api.github.com/users/NickrenREN","html_url":"https://github.com/NickrenREN","followers_url":"https://api.github.com/users/NickrenREN/followers","following_url":"https://api.github.com/users/NickrenREN/following{/other_user}","gists_url":"https://api.github.com/users/NickrenREN/gists{/gist_id}","starred_url":"https://api.github.com/users/NickrenREN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickrenREN/subscriptions","organizations_url":"https://api.github.com/users/NickrenREN/orgs","repos_url":"https://api.github.com/users/NickrenREN/repos","events_url":"https://api.github.com/users/NickrenREN/events{/privacy}","received_events_url":"https://api.github.com/users/NickrenREN/received_events","type":"User","site_admin":false},"repo":{"id":71850001,"name":"kubernetes","full_name":"NickrenREN/kubernetes","owner":{"login":"NickrenREN","id":6104418,"avatar_url":"https://avatars.githubusercontent.com/u/6104418?v=3","gravatar_id":"","url":"https://api.github.com/users/NickrenREN","html_url":"https://github.com/NickrenREN","followers_url":"https://api.github.com/users/NickrenREN/followers","following_url":"https://api.github.com/users/NickrenREN/following{/other_user}","gists_url":"https://api.github.com/users/NickrenREN/gists{/gist_id}","starred_url":"https://api.github.com/users/NickrenREN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickrenREN/subscriptions","organizations_url":"https://api.github.com/users/NickrenREN/orgs","repos_url":"https://api.github.com/users/NickrenREN/repos","events_url":"https://api.github.com/users/NickrenREN/events{/privacy}","received_events_url":"https://api.github.com/users/NickrenREN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NickrenREN/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/NickrenREN/kubernetes","forks_url":"https://api.github.com/repos/NickrenREN/kubernetes/forks","keys_url":"https://api.github.com/repos/NickrenREN/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NickrenREN/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NickrenREN/kubernetes/teams","hooks_url":"https://api.github.com/repos/NickrenREN/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/NickrenREN/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/NickrenREN/kubernetes/events","assignees_url":"https://api.github.com/repos/NickrenREN/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/NickrenREN/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/NickrenREN/kubernetes/tags","blobs_url":"https://api.github.com/repos/NickrenREN/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NickrenREN/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NickrenREN/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/NickrenREN/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NickrenREN/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/NickrenREN/kubernetes/languages","stargazers_url":"https://api.github.com/repos/NickrenREN/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/NickrenREN/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/NickrenREN/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/NickrenREN/kubernetes/subscription","commits_url":"https://api.github.com/repos/NickrenREN/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/NickrenREN/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/NickrenREN/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/NickrenREN/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/NickrenREN/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/NickrenREN/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NickrenREN/kubernetes/merges","archive_url":"https://api.github.com/repos/NickrenREN/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NickrenREN/kubernetes/downloads","issues_url":"https://api.github.com/repos/NickrenREN/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/NickrenREN/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/NickrenREN/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/NickrenREN/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NickrenREN/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/NickrenREN/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/NickrenREN/kubernetes/deployments","created_at":"2016-10-25T02:05:43Z","updated_at":"2016-10-25T02:06:24Z","pushed_at":"2016-12-06T06:46:53Z","git_url":"git://github.com/NickrenREN/kubernetes.git","ssh_url":"git@github.com:NickrenREN/kubernetes.git","clone_url":"https://github.com/NickrenREN/kubernetes.git","svn_url":"https://github.com/NickrenREN/kubernetes","homepage":"http://kubernetes.io","size":365088,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0a7aadc28229bc8d3273cf55294cb7a7edaad1b1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-06T08:05:42Z","pushed_at":"2016-12-06T08:22:58Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":660233,"stargazers_count":18920,"watchers_count":18920,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6288,"mirror_url":null,"open_issues_count":5375,"forks":6288,"open_issues":5375,"watchers":18920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37545"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37545"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37545"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37545/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37545/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37545/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/48026ce6553634171766fb6645a39b913afe422e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":2,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"k8s-merge-robot"}}