{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angularfire2/pulls/comments/67051680","id":67051680,"diff_hunk":"@@ -15,80 +15,83 @@ import {\n   AngularFire,\n   FirebaseObjectObservable,\n   FIREBASE_PROVIDERS,\n-  FirebaseAuth,\n-  FirebaseUrl,\n-  FirebaseRef,\n+  AngularFireAuth,\n+  FirebaseConfig,\n+  FirebaseApp,\n   defaultFirebase,","path":"src/angularfire2.spec.ts","position":10,"original_position":10,"commit_id":"881c7c20a405c7cc1378518f9732ac56dff15171","original_commit_id":"881c7c20a405c7cc1378518f9732ac56dff15171","user":{"login":"jeffbcross","id":463703,"avatar_url":"https://avatars.githubusercontent.com/u/463703?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffbcross","html_url":"https://github.com/jeffbcross","followers_url":"https://api.github.com/users/jeffbcross/followers","following_url":"https://api.github.com/users/jeffbcross/following{/other_user}","gists_url":"https://api.github.com/users/jeffbcross/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffbcross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffbcross/subscriptions","organizations_url":"https://api.github.com/users/jeffbcross/orgs","repos_url":"https://api.github.com/users/jeffbcross/repos","events_url":"https://api.github.com/users/jeffbcross/events{/privacy}","received_events_url":"https://api.github.com/users/jeffbcross/received_events","type":"User","site_admin":false},"body":"Should rename to something more appropriate. Something config related. ","created_at":"2016-06-14T20:37:37Z","updated_at":"2016-06-14T20:37:37Z","html_url":"https://github.com/angular/angularfire2/pull/200#discussion_r67051680","pull_request_url":"https://api.github.com/repos/angular/angularfire2/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/angular/angularfire2/pulls/comments/67051680"},"html":{"href":"https://github.com/angular/angularfire2/pull/200#discussion_r67051680"},"pull_request":{"href":"https://api.github.com/repos/angular/angularfire2/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angularfire2/pulls/200","id":72180271,"html_url":"https://github.com/angular/angularfire2/pull/200","diff_url":"https://github.com/angular/angularfire2/pull/200.diff","patch_url":"https://github.com/angular/angularfire2/pull/200.patch","issue_url":"https://api.github.com/repos/angular/angularfire2/issues/200","number":200,"state":"open","locked":false,"title":"Upgrade to Firebase 3.0 SDK","user":{"login":"davideast","id":4570265,"avatar_url":"https://avatars.githubusercontent.com/u/4570265?v=3","gravatar_id":"","url":"https://api.github.com/users/davideast","html_url":"https://github.com/davideast","followers_url":"https://api.github.com/users/davideast/followers","following_url":"https://api.github.com/users/davideast/following{/other_user}","gists_url":"https://api.github.com/users/davideast/gists{/gist_id}","starred_url":"https://api.github.com/users/davideast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davideast/subscriptions","organizations_url":"https://api.github.com/users/davideast/orgs","repos_url":"https://api.github.com/users/davideast/repos","events_url":"https://api.github.com/users/davideast/events{/privacy}","received_events_url":"https://api.github.com/users/davideast/received_events","type":"User","site_admin":false},"body":"@jeffbcross \r\n\r\nWIP PR for the 3.0 SDK.\r\n\r\nChecklist\r\n - [x] Make angularfire2.spec pass\r\n - [x] Make auth.spec pass\r\n - [x] Re-implement getAuth method to use `auth.currentUser`\r\n - [x] Make firebase_list_factory.spec pass\r\n - [x] Make firebase_list_observable.spec pass\r\n - [x] Make firebase_object_factory.spec pass (WIP @davideast)\r\n - [x] Make firebase_object_observable.spec pass (WIP @davideast)\r\n - [x] Make query_observable.spec pass\r\n - [ ] Set up end-to-end tests (WIP @jeffbcross)\r\n - [x] Ship with minimal set of typings for new SDK (should be no tsc errors)\r\n - [x] Generate typings from source and publish (nice to have, not blocking)\r\n - [ ] ~~Deprecate old auth API names (`authWith...`) in favor of names that match new SDK (`signInWith...`)~~\r\n - [ ] Code review and splitting of commits\r\n - [ ] Publish beta to npm behind `beta` tag (i.e. `npm install angularfire2@beta`)\r\n - [ ] Ask for help testing beta in real applications\r\n - [ ] Update guides\r\n - [ ] Merge to master, tag, publish without flag.\r\n\r\nDesign Considerations\r\n\r\n(@jeffbcross): perhaps we should do away with the `AuthProviders` enum, now that there are constructors for each auth provider. Need to consider what value it provides.","created_at":"2016-06-01T13:28:00Z","updated_at":"2016-06-14T20:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97a8120b1ebf750db34a5c58a3b9a2e87ed2304b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular/angularfire2/pulls/200/commits","review_comments_url":"https://api.github.com/repos/angular/angularfire2/pulls/200/comments","review_comment_url":"https://api.github.com/repos/angular/angularfire2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angularfire2/issues/200/comments","statuses_url":"https://api.github.com/repos/angular/angularfire2/statuses/881c7c20a405c7cc1378518f9732ac56dff15171","head":{"label":"davideast:master","ref":"master","sha":"881c7c20a405c7cc1378518f9732ac56dff15171","user":{"login":"davideast","id":4570265,"avatar_url":"https://avatars.githubusercontent.com/u/4570265?v=3","gravatar_id":"","url":"https://api.github.com/users/davideast","html_url":"https://github.com/davideast","followers_url":"https://api.github.com/users/davideast/followers","following_url":"https://api.github.com/users/davideast/following{/other_user}","gists_url":"https://api.github.com/users/davideast/gists{/gist_id}","starred_url":"https://api.github.com/users/davideast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davideast/subscriptions","organizations_url":"https://api.github.com/users/davideast/orgs","repos_url":"https://api.github.com/users/davideast/repos","events_url":"https://api.github.com/users/davideast/events{/privacy}","received_events_url":"https://api.github.com/users/davideast/received_events","type":"User","site_admin":false},"repo":{"id":60178068,"name":"angularfire2","full_name":"davideast/angularfire2","owner":{"login":"davideast","id":4570265,"avatar_url":"https://avatars.githubusercontent.com/u/4570265?v=3","gravatar_id":"","url":"https://api.github.com/users/davideast","html_url":"https://github.com/davideast","followers_url":"https://api.github.com/users/davideast/followers","following_url":"https://api.github.com/users/davideast/following{/other_user}","gists_url":"https://api.github.com/users/davideast/gists{/gist_id}","starred_url":"https://api.github.com/users/davideast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davideast/subscriptions","organizations_url":"https://api.github.com/users/davideast/orgs","repos_url":"https://api.github.com/users/davideast/repos","events_url":"https://api.github.com/users/davideast/events{/privacy}","received_events_url":"https://api.github.com/users/davideast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davideast/angularfire2","description":"The official Angular 2 library for Firebase.","fork":true,"url":"https://api.github.com/repos/davideast/angularfire2","forks_url":"https://api.github.com/repos/davideast/angularfire2/forks","keys_url":"https://api.github.com/repos/davideast/angularfire2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davideast/angularfire2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davideast/angularfire2/teams","hooks_url":"https://api.github.com/repos/davideast/angularfire2/hooks","issue_events_url":"https://api.github.com/repos/davideast/angularfire2/issues/events{/number}","events_url":"https://api.github.com/repos/davideast/angularfire2/events","assignees_url":"https://api.github.com/repos/davideast/angularfire2/assignees{/user}","branches_url":"https://api.github.com/repos/davideast/angularfire2/branches{/branch}","tags_url":"https://api.github.com/repos/davideast/angularfire2/tags","blobs_url":"https://api.github.com/repos/davideast/angularfire2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davideast/angularfire2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davideast/angularfire2/git/refs{/sha}","trees_url":"https://api.github.com/repos/davideast/angularfire2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davideast/angularfire2/statuses/{sha}","languages_url":"https://api.github.com/repos/davideast/angularfire2/languages","stargazers_url":"https://api.github.com/repos/davideast/angularfire2/stargazers","contributors_url":"https://api.github.com/repos/davideast/angularfire2/contributors","subscribers_url":"https://api.github.com/repos/davideast/angularfire2/subscribers","subscription_url":"https://api.github.com/repos/davideast/angularfire2/subscription","commits_url":"https://api.github.com/repos/davideast/angularfire2/commits{/sha}","git_commits_url":"https://api.github.com/repos/davideast/angularfire2/git/commits{/sha}","comments_url":"https://api.github.com/repos/davideast/angularfire2/comments{/number}","issue_comment_url":"https://api.github.com/repos/davideast/angularfire2/issues/comments{/number}","contents_url":"https://api.github.com/repos/davideast/angularfire2/contents/{+path}","compare_url":"https://api.github.com/repos/davideast/angularfire2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davideast/angularfire2/merges","archive_url":"https://api.github.com/repos/davideast/angularfire2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davideast/angularfire2/downloads","issues_url":"https://api.github.com/repos/davideast/angularfire2/issues{/number}","pulls_url":"https://api.github.com/repos/davideast/angularfire2/pulls{/number}","milestones_url":"https://api.github.com/repos/davideast/angularfire2/milestones{/number}","notifications_url":"https://api.github.com/repos/davideast/angularfire2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davideast/angularfire2/labels{/name}","releases_url":"https://api.github.com/repos/davideast/angularfire2/releases{/id}","deployments_url":"https://api.github.com/repos/davideast/angularfire2/deployments","created_at":"2016-06-01T13:11:51Z","updated_at":"2016-06-01T13:11:52Z","pushed_at":"2016-06-14T01:03:07Z","git_url":"git://github.com/davideast/angularfire2.git","ssh_url":"git@github.com:davideast/angularfire2.git","clone_url":"https://github.com/davideast/angularfire2.git","svn_url":"https://github.com/davideast/angularfire2","homepage":"https://angularfire2.com","size":217,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"b56982e1b5e3a447e5d07b5eb29cabea479b8fc6","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49453413,"name":"angularfire2","full_name":"angular/angularfire2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angularfire2","description":"The official Angular 2 library for Firebase.","fork":false,"url":"https://api.github.com/repos/angular/angularfire2","forks_url":"https://api.github.com/repos/angular/angularfire2/forks","keys_url":"https://api.github.com/repos/angular/angularfire2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angularfire2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angularfire2/teams","hooks_url":"https://api.github.com/repos/angular/angularfire2/hooks","issue_events_url":"https://api.github.com/repos/angular/angularfire2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angularfire2/events","assignees_url":"https://api.github.com/repos/angular/angularfire2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angularfire2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angularfire2/tags","blobs_url":"https://api.github.com/repos/angular/angularfire2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angularfire2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angularfire2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angularfire2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angularfire2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angularfire2/languages","stargazers_url":"https://api.github.com/repos/angular/angularfire2/stargazers","contributors_url":"https://api.github.com/repos/angular/angularfire2/contributors","subscribers_url":"https://api.github.com/repos/angular/angularfire2/subscribers","subscription_url":"https://api.github.com/repos/angular/angularfire2/subscription","commits_url":"https://api.github.com/repos/angular/angularfire2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angularfire2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angularfire2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angularfire2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angularfire2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angularfire2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angularfire2/merges","archive_url":"https://api.github.com/repos/angular/angularfire2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angularfire2/downloads","issues_url":"https://api.github.com/repos/angular/angularfire2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angularfire2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angularfire2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angularfire2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angularfire2/labels{/name}","releases_url":"https://api.github.com/repos/angular/angularfire2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angularfire2/deployments","created_at":"2016-01-11T20:47:23Z","updated_at":"2016-06-14T20:25:10Z","pushed_at":"2016-06-14T01:03:08Z","git_url":"git://github.com/angular/angularfire2.git","ssh_url":"git@github.com:angular/angularfire2.git","clone_url":"https://github.com/angular/angularfire2.git","svn_url":"https://github.com/angular/angularfire2","homepage":"https://angularfire2.com","size":275,"stargazers_count":395,"watchers_count":395,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":43,"forks":81,"open_issues":43,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angularfire2/pulls/200"},"html":{"href":"https://github.com/angular/angularfire2/pull/200"},"issue":{"href":"https://api.github.com/repos/angular/angularfire2/issues/200"},"comments":{"href":"https://api.github.com/repos/angular/angularfire2/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angularfire2/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angularfire2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angularfire2/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angularfire2/statuses/881c7c20a405c7cc1378518f9732ac56dff15171"}}}}
{"actor":{"display_login":"jeffbcross"}}