{"action":"created","issue":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9349","repository_url":"https://api.github.com/repos/hazelcast/hazelcast","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9349/labels{/name}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9349/comments","events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9349/events","html_url":"https://github.com/hazelcast/hazelcast/pull/9349","id":192777329,"number":9349,"title":"Add \"on task done\" callback to InvocationFuture","user":{"login":"mtopolnik","id":490953,"avatar_url":"https://avatars.githubusercontent.com/u/490953?v=3","gravatar_id":"","url":"https://api.github.com/users/mtopolnik","html_url":"https://github.com/mtopolnik","followers_url":"https://api.github.com/users/mtopolnik/followers","following_url":"https://api.github.com/users/mtopolnik/following{/other_user}","gists_url":"https://api.github.com/users/mtopolnik/gists{/gist_id}","starred_url":"https://api.github.com/users/mtopolnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtopolnik/subscriptions","organizations_url":"https://api.github.com/users/mtopolnik/orgs","repos_url":"https://api.github.com/users/mtopolnik/repos","events_url":"https://api.github.com/users/mtopolnik/events{/privacy}","received_events_url":"https://api.github.com/users/mtopolnik/received_events","type":"User","site_admin":false},"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740692,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.8","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76/labels","id":1774122,"number":76,"title":"3.8","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":178,"closed_issues":381,"state":"open","created_at":"2016-05-18T14:13:56Z","updated_at":"2016-12-01T07:58:19Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-12-01T07:58:19Z","updated_at":"2016-12-01T08:52:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9349","html_url":"https://github.com/hazelcast/hazelcast/pull/9349","diff_url":"https://github.com/hazelcast/hazelcast/pull/9349.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/9349.patch"},"body":"After implementing `cancel` on Invocation's future, the future's completion status no longer matches the completion of the underlying computational task. As soon as the future is canceled, the user loses interest in the result of the computation, but internally nothing changes for us until the task actually stops executing and releases its resources. We now need a separate signal and an associated callback that runs when the task is done.\r\n\r\nThis PR introduces a small and low-impact addition to `Invocation`, but is crucial for Jet."},"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/264115747","html_url":"https://github.com/hazelcast/hazelcast/pull/9349#issuecomment-264115747","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9349","id":264115747,"user":{"login":"devOpsHazelcast","id":7523732,"avatar_url":"https://avatars.githubusercontent.com/u/7523732?v=3","gravatar_id":"","url":"https://api.github.com/users/devOpsHazelcast","html_url":"https://github.com/devOpsHazelcast","followers_url":"https://api.github.com/users/devOpsHazelcast/followers","following_url":"https://api.github.com/users/devOpsHazelcast/following{/other_user}","gists_url":"https://api.github.com/users/devOpsHazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/devOpsHazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devOpsHazelcast/subscriptions","organizations_url":"https://api.github.com/users/devOpsHazelcast/orgs","repos_url":"https://api.github.com/users/devOpsHazelcast/repos","events_url":"https://api.github.com/users/devOpsHazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/devOpsHazelcast/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T08:52:37Z","updated_at":"2016-12-01T08:52:37Z","body":"Test PASSed.\n"}}
{"actor":{"display_login":"devOpsHazelcast"}}