{"action":"created","comment":{"url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/comments/92500715","pull_request_review_id":13017853,"id":92500715,"diff_hunk":"@@ -267,23 +267,24 @@ - (void)cellRequestedFullScreenOverlay:(RMXCell *)cell {\n #pragma mark - Private\n \n - (Class)cellClassForVariable:(RMXVariable *)variable {\n-  if (variable.controlType == RMXControlTypeButton) {\n+  // TODO(chuga): This is probably not very fast. We should revisit it.\n+  if ([variable.controlType isEqualToString:RMXControlTypeButton]) {\n     return [RMXCellButton class];\n-  } else if (variable.controlType == RMXControlTypeColorList) {\n+  } else if ([variable.controlType isEqualToString:RMXControlTypeColorList]) {\n     return [RMXCellColorList class];\n-  } else if (variable.controlType == RMXControlTypeColorPicker) {\n+  } else if ([variable.controlType isEqualToString:RMXControlTypeColorPicker]) {","path":"src/core/UI/RMXOverlayViewController.m","position":12,"original_position":12,"commit_id":"0396d81c245a3eb09ce9ff03540f509d13ea678a","original_commit_id":"0396d81c245a3eb09ce9ff03540f509d13ea678a","user":{"login":"chriscox","id":265710,"avatar_url":"https://avatars.githubusercontent.com/u/265710?v=3","gravatar_id":"","url":"https://api.github.com/users/chriscox","html_url":"https://github.com/chriscox","followers_url":"https://api.github.com/users/chriscox/followers","following_url":"https://api.github.com/users/chriscox/following{/other_user}","gists_url":"https://api.github.com/users/chriscox/gists{/gist_id}","starred_url":"https://api.github.com/users/chriscox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriscox/subscriptions","organizations_url":"https://api.github.com/users/chriscox/orgs","repos_url":"https://api.github.com/users/chriscox/repos","events_url":"https://api.github.com/users/chriscox/events{/privacy}","received_events_url":"https://api.github.com/users/chriscox/received_events","type":"User","site_admin":false},"body":"Shouldn't this actually be changed to `RMXControlTypeColorInput`?","created_at":"2016-12-14T22:07:11Z","updated_at":"2016-12-14T22:09:39Z","html_url":"https://github.com/material-foundation/material-remixer-ios/pull/70#discussion_r92500715","pull_request_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/comments/92500715"},"html":{"href":"https://github.com/material-foundation/material-remixer-ios/pull/70#discussion_r92500715"},"pull_request":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70","id":98030433,"html_url":"https://github.com/material-foundation/material-remixer-ios/pull/70","diff_url":"https://github.com/material-foundation/material-remixer-ios/pull/70.diff","patch_url":"https://github.com/material-foundation/material-remixer-ios/pull/70.patch","issue_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/70","number":70,"state":"open","locked":false,"title":"Rename typeIdentifier to dataType and fix the naming of our constants","user":{"login":"chuga","id":4545451,"avatar_url":"https://avatars.githubusercontent.com/u/4545451?v=3","gravatar_id":"","url":"https://api.github.com/users/chuga","html_url":"https://github.com/chuga","followers_url":"https://api.github.com/users/chuga/followers","following_url":"https://api.github.com/users/chuga/following{/other_user}","gists_url":"https://api.github.com/users/chuga/gists{/gist_id}","starred_url":"https://api.github.com/users/chuga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuga/subscriptions","organizations_url":"https://api.github.com/users/chuga/orgs","repos_url":"https://api.github.com/users/chuga/repos","events_url":"https://api.github.com/users/chuga/events{/privacy}","received_events_url":"https://api.github.com/users/chuga/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-14T20:34:43Z","updated_at":"2016-12-14T22:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"663afa20671d5b227d1f08c14e141884e5001ceb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70/commits","review_comments_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70/comments","review_comment_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/70/comments","statuses_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/statuses/0396d81c245a3eb09ce9ff03540f509d13ea678a","head":{"label":"material-foundation:fix_naming","ref":"fix_naming","sha":"0396d81c245a3eb09ce9ff03540f509d13ea678a","user":{"login":"material-foundation","id":19556314,"avatar_url":"https://avatars.githubusercontent.com/u/19556314?v=3","gravatar_id":"","url":"https://api.github.com/users/material-foundation","html_url":"https://github.com/material-foundation","followers_url":"https://api.github.com/users/material-foundation/followers","following_url":"https://api.github.com/users/material-foundation/following{/other_user}","gists_url":"https://api.github.com/users/material-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/material-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-foundation/subscriptions","organizations_url":"https://api.github.com/users/material-foundation/orgs","repos_url":"https://api.github.com/users/material-foundation/repos","events_url":"https://api.github.com/users/material-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/material-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":64411025,"name":"material-remixer-ios","full_name":"material-foundation/material-remixer-ios","owner":{"login":"material-foundation","id":19556314,"avatar_url":"https://avatars.githubusercontent.com/u/19556314?v=3","gravatar_id":"","url":"https://api.github.com/users/material-foundation","html_url":"https://github.com/material-foundation","followers_url":"https://api.github.com/users/material-foundation/followers","following_url":"https://api.github.com/users/material-foundation/following{/other_user}","gists_url":"https://api.github.com/users/material-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/material-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-foundation/subscriptions","organizations_url":"https://api.github.com/users/material-foundation/orgs","repos_url":"https://api.github.com/users/material-foundation/repos","events_url":"https://api.github.com/users/material-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/material-foundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-foundation/material-remixer-ios","description":"Remixer helps teams use and refine design specs by providing an abstraction for these values that is accessible and configurable from both inside and outside the app itself","fork":false,"url":"https://api.github.com/repos/material-foundation/material-remixer-ios","forks_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/forks","keys_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/teams","hooks_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/hooks","issue_events_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/events","assignees_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/tags","blobs_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/languages","stargazers_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/stargazers","contributors_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/contributors","subscribers_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/subscribers","subscription_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/subscription","commits_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/merges","archive_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/downloads","issues_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/deployments","created_at":"2016-07-28T16:23:33Z","updated_at":"2016-12-03T00:15:34Z","pushed_at":"2016-12-14T21:17:54Z","git_url":"git://github.com/material-foundation/material-remixer-ios.git","ssh_url":"git@github.com:material-foundation/material-remixer-ios.git","clone_url":"https://github.com/material-foundation/material-remixer-ios.git","svn_url":"https://github.com/material-foundation/material-remixer-ios","homepage":"","size":404,"stargazers_count":50,"watchers_count":50,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":50,"default_branch":"develop"}},"base":{"label":"material-foundation:develop","ref":"develop","sha":"d6612b8452e39fa4db24e4981de7e54715013fdb","user":{"login":"material-foundation","id":19556314,"avatar_url":"https://avatars.githubusercontent.com/u/19556314?v=3","gravatar_id":"","url":"https://api.github.com/users/material-foundation","html_url":"https://github.com/material-foundation","followers_url":"https://api.github.com/users/material-foundation/followers","following_url":"https://api.github.com/users/material-foundation/following{/other_user}","gists_url":"https://api.github.com/users/material-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/material-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-foundation/subscriptions","organizations_url":"https://api.github.com/users/material-foundation/orgs","repos_url":"https://api.github.com/users/material-foundation/repos","events_url":"https://api.github.com/users/material-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/material-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":64411025,"name":"material-remixer-ios","full_name":"material-foundation/material-remixer-ios","owner":{"login":"material-foundation","id":19556314,"avatar_url":"https://avatars.githubusercontent.com/u/19556314?v=3","gravatar_id":"","url":"https://api.github.com/users/material-foundation","html_url":"https://github.com/material-foundation","followers_url":"https://api.github.com/users/material-foundation/followers","following_url":"https://api.github.com/users/material-foundation/following{/other_user}","gists_url":"https://api.github.com/users/material-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/material-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-foundation/subscriptions","organizations_url":"https://api.github.com/users/material-foundation/orgs","repos_url":"https://api.github.com/users/material-foundation/repos","events_url":"https://api.github.com/users/material-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/material-foundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-foundation/material-remixer-ios","description":"Remixer helps teams use and refine design specs by providing an abstraction for these values that is accessible and configurable from both inside and outside the app itself","fork":false,"url":"https://api.github.com/repos/material-foundation/material-remixer-ios","forks_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/forks","keys_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/teams","hooks_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/hooks","issue_events_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/events","assignees_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/tags","blobs_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/languages","stargazers_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/stargazers","contributors_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/contributors","subscribers_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/subscribers","subscription_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/subscription","commits_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/merges","archive_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/downloads","issues_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-foundation/material-remixer-ios/deployments","created_at":"2016-07-28T16:23:33Z","updated_at":"2016-12-03T00:15:34Z","pushed_at":"2016-12-14T21:17:54Z","git_url":"git://github.com/material-foundation/material-remixer-ios.git","ssh_url":"git@github.com:material-foundation/material-remixer-ios.git","clone_url":"https://github.com/material-foundation/material-remixer-ios.git","svn_url":"https://github.com/material-foundation/material-remixer-ios","homepage":"","size":404,"stargazers_count":50,"watchers_count":50,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":16,"forks":4,"open_issues":16,"watchers":50,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70"},"html":{"href":"https://github.com/material-foundation/material-remixer-ios/pull/70"},"issue":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/70"},"comments":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/material-foundation/material-remixer-ios/statuses/0396d81c245a3eb09ce9ff03540f509d13ea678a"}}}}
{"actor":{"display_login":"chriscox"}}