{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/89813632","pull_request_review_id":10347353,"id":89813632,"diff_hunk":"@@ -0,0 +1,184 @@\n+<!DOCTYPE html>\n+<html lang=\"en\">\n+<head>\n+    <meta charset=\"utf-8\">\n+    <meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge\">\n+    <meta name=\"viewport\" content=\"width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=no\">\n+    <meta name=\"description\" content=\"Create 3D models using glTF.\">\n+    <meta name=\"cesium-sandcastle-labels\" content=\"Development\">\n+    <title>Cesium Demo</title>\n+    <script type=\"text/javascript\" src=\"../Sandcastle-header.js\"></script>\n+    <script type=\"text/javascript\" src=\"../../../ThirdParty/requirejs-2.1.20/require.js\"></script>\n+    <script type=\"text/javascript\">\n+    require.config({\n+        baseUrl : '../../../Source',\n+        waitSeconds : 60\n+    });\n+    </script>\n+</head>\n+<body class=\"sandcastle-loading\" data-sandcastle-bucket=\"bucket-requirejs.html\">\n+<style>\n+    @import url(../templates/bucket.css);\n+    #toolbar {\n+        background: rgba(42, 42, 42, 0.8);\n+        padding: 4px;\n+        border-radius: 4px;\n+    }\n+    #toolbar input {\n+        vertical-align: middle;\n+        padding-top: 2px;\n+        padding-bottom: 2px;\n+    }\n+</style>\n+<div id=\"cesiumContainer\" class=\"fullSize\"></div>\n+<div id=\"loadingOverlay\"><h1>Loading...</h1></div>\n+<div id=\"toolbar\">\n+    <table>\n+    <tbody>\n+    <tr>\n+        <td>Size</td>\n+        <td>\n+            <input type=\"range\" min=\"0\" max=\"20\" step=\"1\" data-bind=\"value: highlightSize, valueUpdate: 'input'\">\n+            <input type=\"text\" size=\"5\" data-bind=\"value: highlightSize\">\n+        </td>\n+    </tr>\n+    <tr>\n+        <td>Opacity</td>\n+        <td>\n+            <input type=\"range\" min=\"0\" max=\"100\" step=\"1\" data-bind=\"value: highlightOpacity, valueUpdate: 'input'\">\n+            <input type=\"text\" size=\"5\" data-bind=\"value: highlightOpacity\">\n+        </td>\n+    </tr>\n+\n+</tbody></table>\n+</div>\n+<script id=\"cesium_sandcastle_script\">\n+function startup(Cesium) {\n+    'use strict';\n+//Sandcastle_Begin\n+var viewer = new Cesium.Viewer('cesiumContainer', {\n+    infoBox : false,\n+    selectionIndicator : false,\n+    shadows : true,\n+    // Explicitly request a stencil buffer so highlighting will work.\n+    contextOptions: {\n+        webgl : {\n+            stencil: true","path":"Apps/Sandcastle/gallery/development/3D Models Outline.html","position":66,"original_position":66,"commit_id":"1c3337196905d94c5ae677c2e506422c965a0a77","original_commit_id":"1c3337196905d94c5ae677c2e506422c965a0a77","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Also see https://github.com/AnalyticalGraphicsInc/cesium/pull/4314#issuecomment-254303838","created_at":"2016-11-28T16:08:29Z","updated_at":"2016-11-28T16:08:29Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4314#discussion_r89813632","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/89813632"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4314#discussion_r89813632"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314","id":84934889,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4314","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4314.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4314.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4314","number":4314,"state":"open","locked":false,"title":"Support for model outlining","user":{"login":"jasonbeverage","id":326626,"avatar_url":"https://avatars.githubusercontent.com/u/326626?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonbeverage","html_url":"https://github.com/jasonbeverage","followers_url":"https://api.github.com/users/jasonbeverage/followers","following_url":"https://api.github.com/users/jasonbeverage/following{/other_user}","gists_url":"https://api.github.com/users/jasonbeverage/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonbeverage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonbeverage/subscriptions","organizations_url":"https://api.github.com/users/jasonbeverage/orgs","repos_url":"https://api.github.com/users/jasonbeverage/repos","events_url":"https://api.github.com/users/jasonbeverage/events{/privacy}","received_events_url":"https://api.github.com/users/jasonbeverage/received_events","type":"User","site_admin":false},"body":"Hi all,\n\nI've done a bit of work adding support to Cesium to provide a halo effect for outlining models when they are selected (or any other reason you want to highlight them).\n\nI've included a new sandcastle example that you can try here:\n\nhttps://cesiumdemos.netlify.com/apps/sandcastle/?src=development/3D%20Models%20Outline.html&label=Development\n\nMost of the modifications were to Model.js.  It provides a two pass rendering approach using the stencil buffer, where the model is drawn normally first, filling the stencil buffer, then the model is drawn again using a shader that extrudes the normals and only renders where the original model didn't render.\n\nThis is my first time digging around the guts of the model rendering code in Cesium, so I'd appreciate any feedback on the approach I took.\n\nThanks!\n\nJason\n","created_at":"2016-09-12T20:03:22Z","updated_at":"2016-11-28T16:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43984dcf7517ec02c691faed63bf12cfe0c9884a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4314/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/1c3337196905d94c5ae677c2e506422c965a0a77","head":{"label":"jasonbeverage:modelhighlight","ref":"modelhighlight","sha":"1c3337196905d94c5ae677c2e506422c965a0a77","user":{"login":"jasonbeverage","id":326626,"avatar_url":"https://avatars.githubusercontent.com/u/326626?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonbeverage","html_url":"https://github.com/jasonbeverage","followers_url":"https://api.github.com/users/jasonbeverage/followers","following_url":"https://api.github.com/users/jasonbeverage/following{/other_user}","gists_url":"https://api.github.com/users/jasonbeverage/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonbeverage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonbeverage/subscriptions","organizations_url":"https://api.github.com/users/jasonbeverage/orgs","repos_url":"https://api.github.com/users/jasonbeverage/repos","events_url":"https://api.github.com/users/jasonbeverage/events{/privacy}","received_events_url":"https://api.github.com/users/jasonbeverage/received_events","type":"User","site_admin":false},"repo":{"id":40604866,"name":"cesium","full_name":"jasonbeverage/cesium","owner":{"login":"jasonbeverage","id":326626,"avatar_url":"https://avatars.githubusercontent.com/u/326626?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonbeverage","html_url":"https://github.com/jasonbeverage","followers_url":"https://api.github.com/users/jasonbeverage/followers","following_url":"https://api.github.com/users/jasonbeverage/following{/other_user}","gists_url":"https://api.github.com/users/jasonbeverage/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonbeverage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonbeverage/subscriptions","organizations_url":"https://api.github.com/users/jasonbeverage/orgs","repos_url":"https://api.github.com/users/jasonbeverage/repos","events_url":"https://api.github.com/users/jasonbeverage/events{/privacy}","received_events_url":"https://api.github.com/users/jasonbeverage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonbeverage/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/jasonbeverage/cesium","forks_url":"https://api.github.com/repos/jasonbeverage/cesium/forks","keys_url":"https://api.github.com/repos/jasonbeverage/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonbeverage/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonbeverage/cesium/teams","hooks_url":"https://api.github.com/repos/jasonbeverage/cesium/hooks","issue_events_url":"https://api.github.com/repos/jasonbeverage/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/jasonbeverage/cesium/events","assignees_url":"https://api.github.com/repos/jasonbeverage/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/jasonbeverage/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/jasonbeverage/cesium/tags","blobs_url":"https://api.github.com/repos/jasonbeverage/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonbeverage/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonbeverage/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonbeverage/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonbeverage/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonbeverage/cesium/languages","stargazers_url":"https://api.github.com/repos/jasonbeverage/cesium/stargazers","contributors_url":"https://api.github.com/repos/jasonbeverage/cesium/contributors","subscribers_url":"https://api.github.com/repos/jasonbeverage/cesium/subscribers","subscription_url":"https://api.github.com/repos/jasonbeverage/cesium/subscription","commits_url":"https://api.github.com/repos/jasonbeverage/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonbeverage/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonbeverage/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonbeverage/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonbeverage/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/jasonbeverage/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonbeverage/cesium/merges","archive_url":"https://api.github.com/repos/jasonbeverage/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonbeverage/cesium/downloads","issues_url":"https://api.github.com/repos/jasonbeverage/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/jasonbeverage/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonbeverage/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonbeverage/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonbeverage/cesium/labels{/name}","releases_url":"https://api.github.com/repos/jasonbeverage/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/jasonbeverage/cesium/deployments","created_at":"2015-08-12T14:22:05Z","updated_at":"2016-02-18T18:18:45Z","pushed_at":"2016-11-24T03:13:11Z","git_url":"git://github.com/jasonbeverage/cesium.git","ssh_url":"git@github.com:jasonbeverage/cesium.git","clone_url":"https://github.com/jasonbeverage/cesium.git","svn_url":"https://github.com/jasonbeverage/cesium","homepage":"cesiumjs.org","size":240908,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"0f859ecf0c7ed11dda37922131434e4a7676a684","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2016-11-28T09:34:24Z","pushed_at":"2016-11-27T16:44:26Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":417127,"stargazers_count":1820,"watchers_count":1820,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":874,"mirror_url":null,"open_issues_count":509,"forks":874,"open_issues":509,"watchers":1820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/4314"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4314"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/4314/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/4314/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/1c3337196905d94c5ae677c2e506422c965a0a77"}}}}
{"actor":{"display_login":"pjcozzi"}}