{"action":"created","comment":{"url":"https://api.github.com/repos/typetools/checker-framework/pulls/comments/59937551","id":59937551,"diff_hunk":"@@ -511,4 +515,66 @@ protected TreeAnnotator createTreeAnnotator() {\n                new ImplicitsTreeAnnotator(this)\n         );\n     }\n+\n+    @Override\n+    public void annotateImplicit(Element elt, AnnotatedTypeMirror type) {\n+        insertLockCheckerGuardedByIfJcipOrJavaxGuardedByIsPresent(elt, type);\n+\n+        super.annotateImplicit(elt, type);\n+    }\n+\n+    @Override\n+    public void annotateImplicit(Tree tree, AnnotatedTypeMirror type, boolean useFlow) {\n+        if (tree.getKind() == Tree.Kind.VARIABLE) {\n+            insertLockCheckerGuardedByIfJcipOrJavaxGuardedByIsPresent(InternalUtils.symbol((VariableTree) tree), type);\n+        }\n+\n+        super.annotateImplicit(tree, type, useFlow);\n+    }\n+\n+    /**\n+     * Given a field declaration with a {@code @net.jcip.annotations.GuardedBy} or\n+     * {@code javax.annotation.concurrent.GuardedBy} annotation and an AnnotatedTypeMirror\n+     * for that field, inserts the corresponding {@code @org.checkerframework.checker.lock.qual.GuardedBy}\n+     * type qualifier into that AnnotatedTypeMirror.\n+     *\n+     * @param element the Element for a field declaration (this method does nothing if the Element is not for a field declaration)","path":"checker/src/org/checkerframework/checker/lock/LockAnnotatedTypeFactory.java","position":47,"original_position":47,"commit_id":"c290c5e64bea513586fb018bc410318bef217eb5","original_commit_id":"c290c5e64bea513586fb018bc410318bef217eb5","user":{"login":"smillst","id":13260174,"avatar_url":"https://avatars.githubusercontent.com/u/13260174?v=3","gravatar_id":"","url":"https://api.github.com/users/smillst","html_url":"https://github.com/smillst","followers_url":"https://api.github.com/users/smillst/followers","following_url":"https://api.github.com/users/smillst/following{/other_user}","gists_url":"https://api.github.com/users/smillst/gists{/gist_id}","starred_url":"https://api.github.com/users/smillst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smillst/subscriptions","organizations_url":"https://api.github.com/users/smillst/orgs","repos_url":"https://api.github.com/users/smillst/repos","events_url":"https://api.github.com/users/smillst/events{/privacy}","received_events_url":"https://api.github.com/users/smillst/received_events","type":"User","site_admin":false},"body":"The parenthetical makes  `the Element for a field declaration` incorrect.  It's really any element.","created_at":"2016-04-15T20:39:57Z","updated_at":"2016-04-15T20:39:57Z","html_url":"https://github.com/typetools/checker-framework/pull/661#discussion_r59937551","pull_request_url":"https://api.github.com/repos/typetools/checker-framework/pulls/661","_links":{"self":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/comments/59937551"},"html":{"href":"https://github.com/typetools/checker-framework/pull/661#discussion_r59937551"},"pull_request":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/typetools/checker-framework/pulls/661","id":65714123,"html_url":"https://github.com/typetools/checker-framework/pull/661","diff_url":"https://github.com/typetools/checker-framework/pull/661.diff","patch_url":"https://github.com/typetools/checker-framework/pull/661.patch","issue_url":"https://api.github.com/repos/typetools/checker-framework/issues/661","number":661,"state":"open","locked":false,"title":"Add support for the JCIP and Javax @GuardedBy annotations","user":{"login":"jthaine","id":7230054,"avatar_url":"https://avatars.githubusercontent.com/u/7230054?v=3","gravatar_id":"","url":"https://api.github.com/users/jthaine","html_url":"https://github.com/jthaine","followers_url":"https://api.github.com/users/jthaine/followers","following_url":"https://api.github.com/users/jthaine/following{/other_user}","gists_url":"https://api.github.com/users/jthaine/gists{/gist_id}","starred_url":"https://api.github.com/users/jthaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthaine/subscriptions","organizations_url":"https://api.github.com/users/jthaine/orgs","repos_url":"https://api.github.com/users/jthaine/repos","events_url":"https://api.github.com/users/jthaine/events{/privacy}","received_events_url":"https://api.github.com/users/jthaine/received_events","type":"User","site_admin":false},"body":"Note that the JCIPAnnotations.java test cases are now greatly simplified because JCIP and Javax @GuardedBy are not allowed on receivers.","created_at":"2016-04-07T23:05:39Z","updated_at":"2016-04-15T20:39:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d967d42a6e9b344c94fb021996a96c27e13c772","assignee":{"login":"jthaine","id":7230054,"avatar_url":"https://avatars.githubusercontent.com/u/7230054?v=3","gravatar_id":"","url":"https://api.github.com/users/jthaine","html_url":"https://github.com/jthaine","followers_url":"https://api.github.com/users/jthaine/followers","following_url":"https://api.github.com/users/jthaine/following{/other_user}","gists_url":"https://api.github.com/users/jthaine/gists{/gist_id}","starred_url":"https://api.github.com/users/jthaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthaine/subscriptions","organizations_url":"https://api.github.com/users/jthaine/orgs","repos_url":"https://api.github.com/users/jthaine/repos","events_url":"https://api.github.com/users/jthaine/events{/privacy}","received_events_url":"https://api.github.com/users/jthaine/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/typetools/checker-framework/pulls/661/commits","review_comments_url":"https://api.github.com/repos/typetools/checker-framework/pulls/661/comments","review_comment_url":"https://api.github.com/repos/typetools/checker-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typetools/checker-framework/issues/661/comments","statuses_url":"https://api.github.com/repos/typetools/checker-framework/statuses/c290c5e64bea513586fb018bc410318bef217eb5","head":{"label":"typetools:jcip_javax_guardedby_support","ref":"jcip_javax_guardedby_support","sha":"c290c5e64bea513586fb018bc410318bef217eb5","user":{"login":"typetools","id":12883499,"avatar_url":"https://avatars.githubusercontent.com/u/12883499?v=3","gravatar_id":"","url":"https://api.github.com/users/typetools","html_url":"https://github.com/typetools","followers_url":"https://api.github.com/users/typetools/followers","following_url":"https://api.github.com/users/typetools/following{/other_user}","gists_url":"https://api.github.com/users/typetools/gists{/gist_id}","starred_url":"https://api.github.com/users/typetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typetools/subscriptions","organizations_url":"https://api.github.com/users/typetools/orgs","repos_url":"https://api.github.com/users/typetools/repos","events_url":"https://api.github.com/users/typetools/events{/privacy}","received_events_url":"https://api.github.com/users/typetools/received_events","type":"Organization","site_admin":false},"repo":{"id":38488726,"name":"checker-framework","full_name":"typetools/checker-framework","owner":{"login":"typetools","id":12883499,"avatar_url":"https://avatars.githubusercontent.com/u/12883499?v=3","gravatar_id":"","url":"https://api.github.com/users/typetools","html_url":"https://github.com/typetools","followers_url":"https://api.github.com/users/typetools/followers","following_url":"https://api.github.com/users/typetools/following{/other_user}","gists_url":"https://api.github.com/users/typetools/gists{/gist_id}","starred_url":"https://api.github.com/users/typetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typetools/subscriptions","organizations_url":"https://api.github.com/users/typetools/orgs","repos_url":"https://api.github.com/users/typetools/repos","events_url":"https://api.github.com/users/typetools/events{/privacy}","received_events_url":"https://api.github.com/users/typetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typetools/checker-framework","description":"Pluggable type-checking for Java","fork":false,"url":"https://api.github.com/repos/typetools/checker-framework","forks_url":"https://api.github.com/repos/typetools/checker-framework/forks","keys_url":"https://api.github.com/repos/typetools/checker-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typetools/checker-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typetools/checker-framework/teams","hooks_url":"https://api.github.com/repos/typetools/checker-framework/hooks","issue_events_url":"https://api.github.com/repos/typetools/checker-framework/issues/events{/number}","events_url":"https://api.github.com/repos/typetools/checker-framework/events","assignees_url":"https://api.github.com/repos/typetools/checker-framework/assignees{/user}","branches_url":"https://api.github.com/repos/typetools/checker-framework/branches{/branch}","tags_url":"https://api.github.com/repos/typetools/checker-framework/tags","blobs_url":"https://api.github.com/repos/typetools/checker-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typetools/checker-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typetools/checker-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/typetools/checker-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typetools/checker-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/typetools/checker-framework/languages","stargazers_url":"https://api.github.com/repos/typetools/checker-framework/stargazers","contributors_url":"https://api.github.com/repos/typetools/checker-framework/contributors","subscribers_url":"https://api.github.com/repos/typetools/checker-framework/subscribers","subscription_url":"https://api.github.com/repos/typetools/checker-framework/subscription","commits_url":"https://api.github.com/repos/typetools/checker-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/typetools/checker-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/typetools/checker-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/typetools/checker-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/typetools/checker-framework/contents/{+path}","compare_url":"https://api.github.com/repos/typetools/checker-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typetools/checker-framework/merges","archive_url":"https://api.github.com/repos/typetools/checker-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typetools/checker-framework/downloads","issues_url":"https://api.github.com/repos/typetools/checker-framework/issues{/number}","pulls_url":"https://api.github.com/repos/typetools/checker-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/typetools/checker-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/typetools/checker-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typetools/checker-framework/labels{/name}","releases_url":"https://api.github.com/repos/typetools/checker-framework/releases{/id}","deployments_url":"https://api.github.com/repos/typetools/checker-framework/deployments","created_at":"2015-07-03T11:09:17Z","updated_at":"2016-04-15T08:23:18Z","pushed_at":"2016-04-15T20:18:58Z","git_url":"git://github.com/typetools/checker-framework.git","ssh_url":"git@github.com:typetools/checker-framework.git","clone_url":"https://github.com/typetools/checker-framework.git","svn_url":"https://github.com/typetools/checker-framework","homepage":"http://checkerframework.org/","size":179493,"stargazers_count":99,"watchers_count":99,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":165,"forks":33,"open_issues":165,"watchers":99,"default_branch":"master"}},"base":{"label":"typetools:lock-checker-february-new-complete-changes","ref":"lock-checker-february-new-complete-changes","sha":"6b8b64b2a7985b8254dcba8dd102f5efc24b1927","user":{"login":"typetools","id":12883499,"avatar_url":"https://avatars.githubusercontent.com/u/12883499?v=3","gravatar_id":"","url":"https://api.github.com/users/typetools","html_url":"https://github.com/typetools","followers_url":"https://api.github.com/users/typetools/followers","following_url":"https://api.github.com/users/typetools/following{/other_user}","gists_url":"https://api.github.com/users/typetools/gists{/gist_id}","starred_url":"https://api.github.com/users/typetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typetools/subscriptions","organizations_url":"https://api.github.com/users/typetools/orgs","repos_url":"https://api.github.com/users/typetools/repos","events_url":"https://api.github.com/users/typetools/events{/privacy}","received_events_url":"https://api.github.com/users/typetools/received_events","type":"Organization","site_admin":false},"repo":{"id":38488726,"name":"checker-framework","full_name":"typetools/checker-framework","owner":{"login":"typetools","id":12883499,"avatar_url":"https://avatars.githubusercontent.com/u/12883499?v=3","gravatar_id":"","url":"https://api.github.com/users/typetools","html_url":"https://github.com/typetools","followers_url":"https://api.github.com/users/typetools/followers","following_url":"https://api.github.com/users/typetools/following{/other_user}","gists_url":"https://api.github.com/users/typetools/gists{/gist_id}","starred_url":"https://api.github.com/users/typetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typetools/subscriptions","organizations_url":"https://api.github.com/users/typetools/orgs","repos_url":"https://api.github.com/users/typetools/repos","events_url":"https://api.github.com/users/typetools/events{/privacy}","received_events_url":"https://api.github.com/users/typetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typetools/checker-framework","description":"Pluggable type-checking for Java","fork":false,"url":"https://api.github.com/repos/typetools/checker-framework","forks_url":"https://api.github.com/repos/typetools/checker-framework/forks","keys_url":"https://api.github.com/repos/typetools/checker-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typetools/checker-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typetools/checker-framework/teams","hooks_url":"https://api.github.com/repos/typetools/checker-framework/hooks","issue_events_url":"https://api.github.com/repos/typetools/checker-framework/issues/events{/number}","events_url":"https://api.github.com/repos/typetools/checker-framework/events","assignees_url":"https://api.github.com/repos/typetools/checker-framework/assignees{/user}","branches_url":"https://api.github.com/repos/typetools/checker-framework/branches{/branch}","tags_url":"https://api.github.com/repos/typetools/checker-framework/tags","blobs_url":"https://api.github.com/repos/typetools/checker-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typetools/checker-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typetools/checker-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/typetools/checker-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typetools/checker-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/typetools/checker-framework/languages","stargazers_url":"https://api.github.com/repos/typetools/checker-framework/stargazers","contributors_url":"https://api.github.com/repos/typetools/checker-framework/contributors","subscribers_url":"https://api.github.com/repos/typetools/checker-framework/subscribers","subscription_url":"https://api.github.com/repos/typetools/checker-framework/subscription","commits_url":"https://api.github.com/repos/typetools/checker-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/typetools/checker-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/typetools/checker-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/typetools/checker-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/typetools/checker-framework/contents/{+path}","compare_url":"https://api.github.com/repos/typetools/checker-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typetools/checker-framework/merges","archive_url":"https://api.github.com/repos/typetools/checker-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typetools/checker-framework/downloads","issues_url":"https://api.github.com/repos/typetools/checker-framework/issues{/number}","pulls_url":"https://api.github.com/repos/typetools/checker-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/typetools/checker-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/typetools/checker-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typetools/checker-framework/labels{/name}","releases_url":"https://api.github.com/repos/typetools/checker-framework/releases{/id}","deployments_url":"https://api.github.com/repos/typetools/checker-framework/deployments","created_at":"2015-07-03T11:09:17Z","updated_at":"2016-04-15T08:23:18Z","pushed_at":"2016-04-15T20:18:58Z","git_url":"git://github.com/typetools/checker-framework.git","ssh_url":"git@github.com:typetools/checker-framework.git","clone_url":"https://github.com/typetools/checker-framework.git","svn_url":"https://github.com/typetools/checker-framework","homepage":"http://checkerframework.org/","size":179493,"stargazers_count":99,"watchers_count":99,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":165,"forks":33,"open_issues":165,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/661"},"html":{"href":"https://github.com/typetools/checker-framework/pull/661"},"issue":{"href":"https://api.github.com/repos/typetools/checker-framework/issues/661"},"comments":{"href":"https://api.github.com/repos/typetools/checker-framework/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typetools/checker-framework/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/typetools/checker-framework/statuses/c290c5e64bea513586fb018bc410318bef217eb5"}}}}