{"action":"created","issue":{"url":"https://api.github.com/repos/OSGP/Platform/issues/450","repository_url":"https://api.github.com/repos/OSGP/Platform","labels_url":"https://api.github.com/repos/OSGP/Platform/issues/450/labels{/name}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/450/comments","events_url":"https://api.github.com/repos/OSGP/Platform/issues/450/events","html_url":"https://github.com/OSGP/Platform/pull/450","id":166282983,"number":450,"title":"Feat firmware version","user":{"login":"thijlboonen","id":7225121,"avatar_url":"https://avatars.githubusercontent.com/u/7225121?v=3","gravatar_id":"","url":"https://api.github.com/users/thijlboonen","html_url":"https://github.com/thijlboonen","followers_url":"https://api.github.com/users/thijlboonen/followers","following_url":"https://api.github.com/users/thijlboonen/following{/other_user}","gists_url":"https://api.github.com/users/thijlboonen/gists{/gist_id}","starred_url":"https://api.github.com/users/thijlboonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijlboonen/subscriptions","organizations_url":"https://api.github.com/users/thijlboonen/orgs","repos_url":"https://api.github.com/users/thijlboonen/repos","events_url":"https://api.github.com/users/thijlboonen/events{/privacy}","received_events_url":"https://api.github.com/users/thijlboonen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OSGP/Platform/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"bjornamkreutz","id":9213004,"avatar_url":"https://avatars.githubusercontent.com/u/9213004?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornamkreutz","html_url":"https://github.com/bjornamkreutz","followers_url":"https://api.github.com/users/bjornamkreutz/followers","following_url":"https://api.github.com/users/bjornamkreutz/following{/other_user}","gists_url":"https://api.github.com/users/bjornamkreutz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornamkreutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornamkreutz/subscriptions","organizations_url":"https://api.github.com/users/bjornamkreutz/orgs","repos_url":"https://api.github.com/users/bjornamkreutz/repos","events_url":"https://api.github.com/users/bjornamkreutz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornamkreutz/received_events","type":"User","site_admin":false},"assignees":[{"login":"bjornamkreutz","id":9213004,"avatar_url":"https://avatars.githubusercontent.com/u/9213004?v=3","gravatar_id":"","url":"https://api.github.com/users/bjornamkreutz","html_url":"https://github.com/bjornamkreutz","followers_url":"https://api.github.com/users/bjornamkreutz/followers","following_url":"https://api.github.com/users/bjornamkreutz/following{/other_user}","gists_url":"https://api.github.com/users/bjornamkreutz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornamkreutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornamkreutz/subscriptions","organizations_url":"https://api.github.com/users/bjornamkreutz/orgs","repos_url":"https://api.github.com/users/bjornamkreutz/repos","events_url":"https://api.github.com/users/bjornamkreutz/events{/privacy}","received_events_url":"https://api.github.com/users/bjornamkreutz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-07-19T09:10:07Z","updated_at":"2016-07-20T07:23:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/450","html_url":"https://github.com/OSGP/Platform/pull/450","diff_url":"https://github.com/OSGP/Platform/pull/450.diff","patch_url":"https://github.com/OSGP/Platform/pull/450.patch"},"body":"Temporary PR\r\n"},"comment":{"url":"https://api.github.com/repos/OSGP/Platform/issues/comments/233863826","html_url":"https://github.com/OSGP/Platform/pull/450#issuecomment-233863826","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/450","id":233863826,"user":{"login":"jenkins-ip-10-4-24-184","id":12208121,"avatar_url":"https://avatars.githubusercontent.com/u/12208121?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-ip-10-4-24-184","html_url":"https://github.com/jenkins-ip-10-4-24-184","followers_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/followers","following_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/subscriptions","organizations_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/orgs","repos_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/repos","events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T07:23:04Z","updated_at":"2016-07-20T07:23:04Z","body":"SonarQube analysis reported 15 issues\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 11 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 4 minor\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L421](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L421): The Cyclomatic Complexity of this method \"addFirmware\" is 13 which is greater than 10 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L421](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L421): Method has 8 parameters, which is greater than 7 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS00107)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L423](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L423): Define and throw a dedicated exception instead of using a generic one. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS00112)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L514](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L514): The Cyclomatic Complexity of this method \"changeFirmware\" is 11 which is greater than 10 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L514](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L514): Method has 8 parameters, which is greater than 7 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS00107)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L572](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L572): Define and throw a dedicated exception instead of using a generic one. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS00112)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementService.java#L662](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L662): Define and throw a dedicated exception instead of using a generic one. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS00112)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementEndpoint.java#L256](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/endpoints/FirmwareManagementEndpoint.java#L256): Remove this unused method parameter \"request\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1172)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [FirmwareManagementEndpoint.java#L443](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/endpoints/FirmwareManagementEndpoint.java#L443): Remove this unused method parameter \"request\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1172)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [FirmwareManagementService.java#L293](https://github.com/OSGP/Platform/blob/7520b8a5db37f140b1119dbca70ff930e660c16e/osgp-adapter-ws-core/src/main/java/com/alliander/osgp/adapter/ws/core/application/services/FirmwareManagementService.java#L293): Define a constant instead of duplicating this literal \"Manufacturer doesn't exixts.\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://54.77.62.182/sonarqube/coding_rules#rule_key=squid%3AS1192)\n"}}
{"actor":{"display_login":"jenkins-ip-10-4-24-184"}}