{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17256","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17256/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17256/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17256/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17256","id":157829241,"number":17256,"title":"Core/Gameobject: Gameobjects that are spawned by spell despawn after …","user":{"login":"runningnak3d","id":387830,"avatar_url":"https://avatars.githubusercontent.com/u/387830?v=3","gravatar_id":"","url":"https://api.github.com/users/runningnak3d","html_url":"https://github.com/runningnak3d","followers_url":"https://api.github.com/users/runningnak3d/followers","following_url":"https://api.github.com/users/runningnak3d/following{/other_user}","gists_url":"https://api.github.com/users/runningnak3d/gists{/gist_id}","starred_url":"https://api.github.com/users/runningnak3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runningnak3d/subscriptions","organizations_url":"https://api.github.com/users/runningnak3d/orgs","repos_url":"https://api.github.com/users/runningnak3d/repos","events_url":"https://api.github.com/users/runningnak3d/events{/privacy}","received_events_url":"https://api.github.com/users/runningnak3d/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600"},{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Feedback-PatchFix","name":"Feedback-PatchFix","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-01T05:56:25Z","updated_at":"2016-06-01T12:06:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17256","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17256","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17256.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17256.patch"},"body":"**Changes proposed**:\r\n\r\n- \r\n- \r\n- \r\n\r\n**Target branch(es)**: 335/6x\r\n\r\n**Issues addressed**: Fixes #12842 \r\n\r\n**Tests performed**: builds. Tested with .add quest 12842 / .cast 46310. Didn't notice any adverse affects to statically spawned GOs.\r\n\r\n**Known issues and TODO list**:\r\n\r\n- [ ]  Need to test with more spell summoned GOs\r\n- [ ] Need to make sure that statically spawned GOs are not affected\r\n\r\n**NOTE** If your Pull Request is SQL only create a ticket instead\r\n\r\n**SUGESTION** If your Pull Request contains SQL give it one imposible date, for example 9999_99_99_99_database.sql on that way it will be free on merge.\r\n\r\n…looting. If a GO contains quest loot it should not de-spawn until the de-spawn timer from Spell.dbc expires.\r\n\r\nCloses #12842"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/222972627","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17256#issuecomment-222972627","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17256","id":222972627,"user":{"login":"runningnak3d","id":387830,"avatar_url":"https://avatars.githubusercontent.com/u/387830?v=3","gravatar_id":"","url":"https://api.github.com/users/runningnak3d","html_url":"https://github.com/runningnak3d","followers_url":"https://api.github.com/users/runningnak3d/followers","following_url":"https://api.github.com/users/runningnak3d/following{/other_user}","gists_url":"https://api.github.com/users/runningnak3d/gists{/gist_id}","starred_url":"https://api.github.com/users/runningnak3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runningnak3d/subscriptions","organizations_url":"https://api.github.com/users/runningnak3d/orgs","repos_url":"https://api.github.com/users/runningnak3d/repos","events_url":"https://api.github.com/users/runningnak3d/events{/privacy}","received_events_url":"https://api.github.com/users/runningnak3d/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T12:06:07Z","updated_at":"2016-06-01T12:06:07Z","body":"@Shauren As I pointed out to @Rusher this shouldn't (if blizz wasn't bat shit crazy) break anything. There is a reason that I pointed out that some additional tests needed to be done. I assumed (which you never do) that objects like that would have a duration of 0 or something very close to it. Now that I know what I need to be looking for, I will look over those spells and see if there is anything to indicate that they should be insta-de-spawned. Lastly, as for \"flat out wrong\". Uh no, the code that was there was flat out wrong, and I am pretty sure that you added it :)"}}
{"actor":{"display_login":"runningnak3d"}}