{"action":"created","comment":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments/89857364","pull_request_review_id":10388116,"id":89857364,"diff_hunk":"@@ -290,35 +307,49 @@ Meteor.startup(() => {\n });\n \n IpRemoteHostImpl = class IpRemoteHostImpl {\n-  constructor(address) {\n+  constructor(address, tls) {\n     if (address.upper64 || address.upper64 === 0) {\n       // address is an ip.capnp:IpAddress, we need to convert it\n       this.address = addressToString(address);\n     } else {\n       this.address = address;\n     }\n+\n+    this.tls = tls;\n   }\n \n   getTcpPort(portNum) {\n-    return { port: new TcpPortImpl(this.address, portNum) };\n+    return { port: new TcpPortImpl(this.address, portNum, this.tls) };\n   }\n \n   getUdpPort(portNum) {\n+    if (this.tls) {\n+      const error = new Error(\"UDP over TLS is not yet supported\");","path":"shell/server/drivers/ip.js","position":105,"original_position":105,"commit_id":"86f69f735ae1b021caf87bcb966b556276c6a99d","original_commit_id":"86f69f735ae1b021caf87bcb966b556276c6a99d","user":{"login":"kentonv","id":4001805,"avatar_url":"https://avatars.githubusercontent.com/u/4001805?v=3","gravatar_id":"","url":"https://api.github.com/users/kentonv","html_url":"https://github.com/kentonv","followers_url":"https://api.github.com/users/kentonv/followers","following_url":"https://api.github.com/users/kentonv/following{/other_user}","gists_url":"https://api.github.com/users/kentonv/gists{/gist_id}","starred_url":"https://api.github.com/users/kentonv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentonv/subscriptions","organizations_url":"https://api.github.com/users/kentonv/orgs","repos_url":"https://api.github.com/users/kentonv/repos","events_url":"https://api.github.com/users/kentonv/events{/privacy}","received_events_url":"https://api.github.com/users/kentonv/received_events","type":"User","site_admin":false},"body":"Technically this would be \"TLS over UDP\", or perhaps more precisely \"DTLS over UDP\", rather than \"UDP over TLS\".","created_at":"2016-11-28T19:14:57Z","updated_at":"2016-11-28T19:15:17Z","html_url":"https://github.com/sandstorm-io/sandstorm/pull/2776#discussion_r89857364","pull_request_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776","_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments/89857364"},"html":{"href":"https://github.com/sandstorm-io/sandstorm/pull/2776#discussion_r89857364"},"pull_request":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776"}}},"pull_request":{"url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776","id":95408006,"html_url":"https://github.com/sandstorm-io/sandstorm/pull/2776","diff_url":"https://github.com/sandstorm-io/sandstorm/pull/2776.diff","patch_url":"https://github.com/sandstorm-io/sandstorm/pull/2776.patch","issue_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2776","number":2776,"state":"open","locked":false,"title":"Add option for IpNetwork to be layered on top of TLS.","user":{"login":"dwrensha","id":495768,"avatar_url":"https://avatars.githubusercontent.com/u/495768?v=3","gravatar_id":"","url":"https://api.github.com/users/dwrensha","html_url":"https://github.com/dwrensha","followers_url":"https://api.github.com/users/dwrensha/followers","following_url":"https://api.github.com/users/dwrensha/following{/other_user}","gists_url":"https://api.github.com/users/dwrensha/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrensha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrensha/subscriptions","organizations_url":"https://api.github.com/users/dwrensha/orgs","repos_url":"https://api.github.com/users/dwrensha/repos","events_url":"https://api.github.com/users/dwrensha/events{/privacy}","received_events_url":"https://api.github.com/users/dwrensha/received_events","type":"User","site_admin":false},"body":"This is an implementation of @kentonv's [suggestion](https://github.com/sandstorm-io/sandstorm/pull/2774#issuecomment-263086336) from #2774.\r\n\r\nThis changes the database representation of `IpNetwork` sturdyrefs and includes a migration to convert existing sturdyrefs of the form `ipNetwork: true` into `ipNetwork: {encryption: {none: null}}`.\r\n\r\nAdds a \"TLS-encrypted outbound network access\" table to the \"Network capabilities\" section of the admin panel. Also in the \"Network capabilities\" section, fixes some bugs, most of which were introduced when we switched to using the `claimRequest()` flow. `cap.owner.grain.introducerIdentity` is now obsolete!","created_at":"2016-11-27T16:34:50Z","updated_at":"2016-11-28T19:15:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d591f3741a5554ec817a5f7f7bc9f27c66c18a3b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776/commits","review_comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776/comments","review_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2776/comments","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/86f69f735ae1b021caf87bcb966b556276c6a99d","head":{"label":"dwrensha:tls-ip-network","ref":"tls-ip-network","sha":"86f69f735ae1b021caf87bcb966b556276c6a99d","user":{"login":"dwrensha","id":495768,"avatar_url":"https://avatars.githubusercontent.com/u/495768?v=3","gravatar_id":"","url":"https://api.github.com/users/dwrensha","html_url":"https://github.com/dwrensha","followers_url":"https://api.github.com/users/dwrensha/followers","following_url":"https://api.github.com/users/dwrensha/following{/other_user}","gists_url":"https://api.github.com/users/dwrensha/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrensha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrensha/subscriptions","organizations_url":"https://api.github.com/users/dwrensha/orgs","repos_url":"https://api.github.com/users/dwrensha/repos","events_url":"https://api.github.com/users/dwrensha/events{/privacy}","received_events_url":"https://api.github.com/users/dwrensha/received_events","type":"User","site_admin":false},"repo":{"id":17964729,"name":"sandstorm","full_name":"dwrensha/sandstorm","owner":{"login":"dwrensha","id":495768,"avatar_url":"https://avatars.githubusercontent.com/u/495768?v=3","gravatar_id":"","url":"https://api.github.com/users/dwrensha","html_url":"https://github.com/dwrensha","followers_url":"https://api.github.com/users/dwrensha/followers","following_url":"https://api.github.com/users/dwrensha/following{/other_user}","gists_url":"https://api.github.com/users/dwrensha/gists{/gist_id}","starred_url":"https://api.github.com/users/dwrensha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwrensha/subscriptions","organizations_url":"https://api.github.com/users/dwrensha/orgs","repos_url":"https://api.github.com/users/dwrensha/repos","events_url":"https://api.github.com/users/dwrensha/events{/privacy}","received_events_url":"https://api.github.com/users/dwrensha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwrensha/sandstorm","description":"Personal Cloud Sandbox","fork":true,"url":"https://api.github.com/repos/dwrensha/sandstorm","forks_url":"https://api.github.com/repos/dwrensha/sandstorm/forks","keys_url":"https://api.github.com/repos/dwrensha/sandstorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwrensha/sandstorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwrensha/sandstorm/teams","hooks_url":"https://api.github.com/repos/dwrensha/sandstorm/hooks","issue_events_url":"https://api.github.com/repos/dwrensha/sandstorm/issues/events{/number}","events_url":"https://api.github.com/repos/dwrensha/sandstorm/events","assignees_url":"https://api.github.com/repos/dwrensha/sandstorm/assignees{/user}","branches_url":"https://api.github.com/repos/dwrensha/sandstorm/branches{/branch}","tags_url":"https://api.github.com/repos/dwrensha/sandstorm/tags","blobs_url":"https://api.github.com/repos/dwrensha/sandstorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwrensha/sandstorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwrensha/sandstorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwrensha/sandstorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwrensha/sandstorm/statuses/{sha}","languages_url":"https://api.github.com/repos/dwrensha/sandstorm/languages","stargazers_url":"https://api.github.com/repos/dwrensha/sandstorm/stargazers","contributors_url":"https://api.github.com/repos/dwrensha/sandstorm/contributors","subscribers_url":"https://api.github.com/repos/dwrensha/sandstorm/subscribers","subscription_url":"https://api.github.com/repos/dwrensha/sandstorm/subscription","commits_url":"https://api.github.com/repos/dwrensha/sandstorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwrensha/sandstorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwrensha/sandstorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwrensha/sandstorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwrensha/sandstorm/contents/{+path}","compare_url":"https://api.github.com/repos/dwrensha/sandstorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwrensha/sandstorm/merges","archive_url":"https://api.github.com/repos/dwrensha/sandstorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwrensha/sandstorm/downloads","issues_url":"https://api.github.com/repos/dwrensha/sandstorm/issues{/number}","pulls_url":"https://api.github.com/repos/dwrensha/sandstorm/pulls{/number}","milestones_url":"https://api.github.com/repos/dwrensha/sandstorm/milestones{/number}","notifications_url":"https://api.github.com/repos/dwrensha/sandstorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwrensha/sandstorm/labels{/name}","releases_url":"https://api.github.com/repos/dwrensha/sandstorm/releases{/id}","deployments_url":"https://api.github.com/repos/dwrensha/sandstorm/deployments","created_at":"2014-03-21T01:42:05Z","updated_at":"2016-01-11T12:49:39Z","pushed_at":"2016-11-28T19:10:57Z","git_url":"git://github.com/dwrensha/sandstorm.git","ssh_url":"git@github.com:dwrensha/sandstorm.git","clone_url":"https://github.com/dwrensha/sandstorm.git","svn_url":"https://github.com/dwrensha/sandstorm","homepage":null,"size":14785,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sandstorm-io:master","ref":"master","sha":"83764042053eea74e90021267ffe23af0d38183a","user":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":15728293,"name":"sandstorm","full_name":"sandstorm-io/sandstorm","owner":{"login":"sandstorm-io","id":7479094,"avatar_url":"https://avatars.githubusercontent.com/u/7479094?v=3","gravatar_id":"","url":"https://api.github.com/users/sandstorm-io","html_url":"https://github.com/sandstorm-io","followers_url":"https://api.github.com/users/sandstorm-io/followers","following_url":"https://api.github.com/users/sandstorm-io/following{/other_user}","gists_url":"https://api.github.com/users/sandstorm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sandstorm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandstorm-io/subscriptions","organizations_url":"https://api.github.com/users/sandstorm-io/orgs","repos_url":"https://api.github.com/users/sandstorm-io/repos","events_url":"https://api.github.com/users/sandstorm-io/events{/privacy}","received_events_url":"https://api.github.com/users/sandstorm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sandstorm-io/sandstorm","description":"Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.","fork":false,"url":"https://api.github.com/repos/sandstorm-io/sandstorm","forks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/forks","keys_url":"https://api.github.com/repos/sandstorm-io/sandstorm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandstorm-io/sandstorm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandstorm-io/sandstorm/teams","hooks_url":"https://api.github.com/repos/sandstorm-io/sandstorm/hooks","issue_events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/events{/number}","events_url":"https://api.github.com/repos/sandstorm-io/sandstorm/events","assignees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/assignees{/user}","branches_url":"https://api.github.com/repos/sandstorm-io/sandstorm/branches{/branch}","tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/tags","blobs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/{sha}","languages_url":"https://api.github.com/repos/sandstorm-io/sandstorm/languages","stargazers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/stargazers","contributors_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contributors","subscribers_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscribers","subscription_url":"https://api.github.com/repos/sandstorm-io/sandstorm/subscription","commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandstorm-io/sandstorm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandstorm-io/sandstorm/contents/{+path}","compare_url":"https://api.github.com/repos/sandstorm-io/sandstorm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandstorm-io/sandstorm/merges","archive_url":"https://api.github.com/repos/sandstorm-io/sandstorm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandstorm-io/sandstorm/downloads","issues_url":"https://api.github.com/repos/sandstorm-io/sandstorm/issues{/number}","pulls_url":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls{/number}","milestones_url":"https://api.github.com/repos/sandstorm-io/sandstorm/milestones{/number}","notifications_url":"https://api.github.com/repos/sandstorm-io/sandstorm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandstorm-io/sandstorm/labels{/name}","releases_url":"https://api.github.com/repos/sandstorm-io/sandstorm/releases{/id}","deployments_url":"https://api.github.com/repos/sandstorm-io/sandstorm/deployments","created_at":"2014-01-08T07:10:33Z","updated_at":"2016-11-28T17:39:43Z","pushed_at":"2016-11-28T18:58:02Z","git_url":"git://github.com/sandstorm-io/sandstorm.git","ssh_url":"git@github.com:sandstorm-io/sandstorm.git","clone_url":"https://github.com/sandstorm-io/sandstorm.git","svn_url":"https://github.com/sandstorm-io/sandstorm","homepage":"https://sandstorm.io","size":40163,"stargazers_count":3998,"watchers_count":3998,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":381,"mirror_url":null,"open_issues_count":493,"forks":381,"open_issues":493,"watchers":3998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776"},"html":{"href":"https://github.com/sandstorm-io/sandstorm/pull/2776"},"issue":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2776"},"comments":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/issues/2776/comments"},"review_comments":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776/comments"},"review_comment":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/pulls/2776/commits"},"statuses":{"href":"https://api.github.com/repos/sandstorm-io/sandstorm/statuses/86f69f735ae1b021caf87bcb966b556276c6a99d"}}}}
{"actor":{"display_login":"kentonv"}}