{"action":"created","comment":{"url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/comments/89552048","pull_request_review_id":10097566,"id":89552048,"diff_hunk":"@@ -0,0 +1,100 @@\n+<?php\n+\n+/**\n+ * @file\n+ * Contains the overwritten field base export.\n+ *\n+ * These are exact copies from features.field.inc but as features does not allow\n+ * us to alter the export data, we implement them ourselves. The other hooks are\n+ * simply calling their original.\n+ *\n+ * The only modified COMPONENT hook is COMPONENT_features_export_render(). Here\n+ * we do 2 things:\n+ *  1. We modify the export array to lock the fields.\n+ *  2. We check if there might be a datetime field instead of datestamp and we\n+ *     notify the user that it's not compliant with the requirements.\n+ */\n+\n+/**\n+ * Implements hook_features_export_render().\n+ */\n+function _dt_dev_field_base_features_export_render($module, $data, $export = NULL) {\n+  $code = array();\n+  $code[] = '  $field_bases = array();';\n+  $code[] = '';\n+  foreach ($data as $identifier) {\n+    if ($field = features_field_base_load($identifier)) {\n+      // Lock the field.\n+      $field['locked'] = 1;\n+      // If there is a datetime field, we have to stop the export. Depending on\n+      // the way we export we take different actions.\n+      if ($export && $field['type'] == 'datetime') {\n+        $replacements = [\n+          '%label' => $field['field_name'],\n+          '%type' => $field['type'],\n+          '%message' => 'This is not allowed, please use datestamp instead',\n+        ];\n+        watchdog('features', 'Attempt to update field %label with type %type: %message.', $replacements);\n+        drupal_set_message(t('Attempt to update field %label with type %type: %message.', $replacements));\n+        if (drupal_is_cli() && function_exists('drush_main')) {","path":"resources/dev_modules/dt_dev/dt_dev.features_field_base.inc","position":39,"original_position":39,"commit_id":"6b1251aded437d996550a905b150018e153defcd","original_commit_id":"6b1251aded437d996550a905b150018e153defcd","user":{"login":"tatarbj","id":781403,"avatar_url":"https://avatars.githubusercontent.com/u/781403?v=3","gravatar_id":"","url":"https://api.github.com/users/tatarbj","html_url":"https://github.com/tatarbj","followers_url":"https://api.github.com/users/tatarbj/followers","following_url":"https://api.github.com/users/tatarbj/following{/other_user}","gists_url":"https://api.github.com/users/tatarbj/gists{/gist_id}","starred_url":"https://api.github.com/users/tatarbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatarbj/subscriptions","organizations_url":"https://api.github.com/users/tatarbj/orgs","repos_url":"https://api.github.com/users/tatarbj/repos","events_url":"https://api.github.com/users/tatarbj/events{/privacy}","received_events_url":"https://api.github.com/users/tatarbj/received_events","type":"User","site_admin":false},"body":"really nice way of checking where we are! thanks for the high quality!","created_at":"2016-11-24T23:33:50Z","updated_at":"2016-11-24T23:38:57Z","html_url":"https://github.com/ec-europa/subsite-starterkit/pull/28#discussion_r89552048","pull_request_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/comments/89552048"},"html":{"href":"https://github.com/ec-europa/subsite-starterkit/pull/28#discussion_r89552048"},"pull_request":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28","id":90555720,"html_url":"https://github.com/ec-europa/subsite-starterkit/pull/28","diff_url":"https://github.com/ec-europa/subsite-starterkit/pull/28.diff","patch_url":"https://github.com/ec-europa/subsite-starterkit/pull/28.patch","issue_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues/28","number":28,"state":"open","locked":false,"title":"Additional targets","user":{"login":"haringsrob","id":866743,"avatar_url":"https://avatars.githubusercontent.com/u/866743?v=3","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"body":"Hi,\n\nThe code below is developed by the digital transformation team. As these targets can save time of both the developers as QA team we propose to add these to the starterkit.\n1. Configurable javascript browser and selenium url (Because of the issues with cphp)\n2. dt_dev module, see the readme.\n3. Updated version of the multisite_requirements that can run on cphp\n\nRegards,\n","created_at":"2016-10-24T06:30:33Z","updated_at":"2016-11-24T23:38:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd2e5dc301f6a6a9b9174614e85d3d67fe3a2a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28/commits","review_comments_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28/comments","review_comment_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues/28/comments","statuses_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/statuses/6b1251aded437d996550a905b150018e153defcd","head":{"label":"haringsrob:feature/maintenance-additional-targets","ref":"feature/maintenance-additional-targets","sha":"6b1251aded437d996550a905b150018e153defcd","user":{"login":"haringsrob","id":866743,"avatar_url":"https://avatars.githubusercontent.com/u/866743?v=3","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"repo":{"id":71758079,"name":"subsite-starterkit","full_name":"haringsrob/subsite-starterkit","owner":{"login":"haringsrob","id":866743,"avatar_url":"https://avatars.githubusercontent.com/u/866743?v=3","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haringsrob/subsite-starterkit","description":"A starting point for creating new websites for the NextEuropa platform of the European Commission.","fork":true,"url":"https://api.github.com/repos/haringsrob/subsite-starterkit","forks_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/forks","keys_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/teams","hooks_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/hooks","issue_events_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/events","assignees_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/tags","blobs_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/languages","stargazers_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/stargazers","contributors_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/contributors","subscribers_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/subscribers","subscription_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/subscription","commits_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/merges","archive_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/downloads","issues_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/labels{/name}","releases_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/haringsrob/subsite-starterkit/deployments","created_at":"2016-10-24T06:23:20Z","updated_at":"2016-10-24T06:23:21Z","pushed_at":"2016-10-24T06:28:04Z","git_url":"git://github.com/haringsrob/subsite-starterkit.git","ssh_url":"git@github.com:haringsrob/subsite-starterkit.git","clone_url":"https://github.com/haringsrob/subsite-starterkit.git","svn_url":"https://github.com/haringsrob/subsite-starterkit","homepage":null,"size":243,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ec-europa:master","ref":"master","sha":"1b8636d586fa5c1c3bcab23ada538926b2e47fd6","user":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":40656194,"name":"subsite-starterkit","full_name":"ec-europa/subsite-starterkit","owner":{"login":"ec-europa","id":10885565,"avatar_url":"https://avatars.githubusercontent.com/u/10885565?v=3","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/subsite-starterkit","description":"A starting point for creating new websites for the NextEuropa platform of the European Commission.","fork":false,"url":"https://api.github.com/repos/ec-europa/subsite-starterkit","forks_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/forks","keys_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/teams","hooks_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/events","assignees_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/tags","blobs_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/languages","stargazers_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/subscription","commits_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/merges","archive_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/downloads","issues_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/releases{/id}","deployments_url":"https://api.github.com/repos/ec-europa/subsite-starterkit/deployments","created_at":"2015-08-13T11:54:47Z","updated_at":"2016-11-11T13:21:12Z","pushed_at":"2016-11-24T11:01:52Z","git_url":"git://github.com/ec-europa/subsite-starterkit.git","ssh_url":"git@github.com:ec-europa/subsite-starterkit.git","clone_url":"https://github.com/ec-europa/subsite-starterkit.git","svn_url":"https://github.com/ec-europa/subsite-starterkit","homepage":null,"size":374,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28"},"html":{"href":"https://github.com/ec-europa/subsite-starterkit/pull/28"},"issue":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues/28"},"comments":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/ec-europa/subsite-starterkit/statuses/6b1251aded437d996550a905b150018e153defcd"}}}}
{"actor":{"display_login":"tatarbj"}}