{"action":"opened","number":1377,"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1377","id":78605052,"html_url":"https://github.com/Microsoft/visualfsharp/pull/1377","diff_url":"https://github.com/Microsoft/visualfsharp/pull/1377.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/1377.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1377","number":1377,"state":"open","locked":false,"title":"Better error message when specializing generic abstract type with unit","user":{"login":"smoothdeveloper","id":87944,"avatar_url":"https://avatars.githubusercontent.com/u/87944?v=3","gravatar_id":"","url":"https://api.github.com/users/smoothdeveloper","html_url":"https://github.com/smoothdeveloper","followers_url":"https://api.github.com/users/smoothdeveloper/followers","following_url":"https://api.github.com/users/smoothdeveloper/following{/other_user}","gists_url":"https://api.github.com/users/smoothdeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/smoothdeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoothdeveloper/subscriptions","organizations_url":"https://api.github.com/users/smoothdeveloper/orgs","repos_url":"https://api.github.com/users/smoothdeveloper/repos","events_url":"https://api.github.com/users/smoothdeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/smoothdeveloper/received_events","type":"User","site_admin":false},"body":"Attempt to fix #35\r\n\r\nI'll need some guidance in terms of where to add tests and of course if there is anything wrong with the matching I'm doing / assumptions I'm taking.\r\n\r\nI'm concerned the matching might yield false positive if there are cases where using `unit` as a generic type argument would be valid, but this is difficult for me to reason about as of now.\r\n\r\nAlso looking for better ideas for the error message.","created_at":"2016-07-24T18:16:51Z","updated_at":"2016-07-24T18:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1377/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1377/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1377/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/4d557aff2ab09ac35c1ff374aa220bd0c4d7e59f","head":{"label":"smoothdeveloper:issue-35-return-type-abstract-method-unit","ref":"issue-35-return-type-abstract-method-unit","sha":"4d557aff2ab09ac35c1ff374aa220bd0c4d7e59f","user":{"login":"smoothdeveloper","id":87944,"avatar_url":"https://avatars.githubusercontent.com/u/87944?v=3","gravatar_id":"","url":"https://api.github.com/users/smoothdeveloper","html_url":"https://github.com/smoothdeveloper","followers_url":"https://api.github.com/users/smoothdeveloper/followers","following_url":"https://api.github.com/users/smoothdeveloper/following{/other_user}","gists_url":"https://api.github.com/users/smoothdeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/smoothdeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoothdeveloper/subscriptions","organizations_url":"https://api.github.com/users/smoothdeveloper/orgs","repos_url":"https://api.github.com/users/smoothdeveloper/repos","events_url":"https://api.github.com/users/smoothdeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/smoothdeveloper/received_events","type":"User","site_admin":false},"repo":{"id":50009307,"name":"visualfsharp","full_name":"smoothdeveloper/visualfsharp","owner":{"login":"smoothdeveloper","id":87944,"avatar_url":"https://avatars.githubusercontent.com/u/87944?v=3","gravatar_id":"","url":"https://api.github.com/users/smoothdeveloper","html_url":"https://github.com/smoothdeveloper","followers_url":"https://api.github.com/users/smoothdeveloper/followers","following_url":"https://api.github.com/users/smoothdeveloper/following{/other_user}","gists_url":"https://api.github.com/users/smoothdeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/smoothdeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoothdeveloper/subscriptions","organizations_url":"https://api.github.com/users/smoothdeveloper/orgs","repos_url":"https://api.github.com/users/smoothdeveloper/repos","events_url":"https://api.github.com/users/smoothdeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/smoothdeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smoothdeveloper/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/smoothdeveloper/visualfsharp","forks_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/forks","keys_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/teams","hooks_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/events","assignees_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/tags","blobs_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/subscription","commits_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/merges","archive_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/downloads","issues_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/smoothdeveloper/visualfsharp/deployments","created_at":"2016-01-20T06:20:35Z","updated_at":"2016-01-20T06:20:50Z","pushed_at":"2016-07-24T18:11:21Z","git_url":"git://github.com/smoothdeveloper/visualfsharp.git","ssh_url":"git@github.com:smoothdeveloper/visualfsharp.git","clone_url":"https://github.com/smoothdeveloper/visualfsharp.git","svn_url":"https://github.com/smoothdeveloper/visualfsharp","homepage":null,"size":70360,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b4021e6af7d19581127e4462c9d581ea6f15d4da","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2016-07-23T11:35:30Z","pushed_at":"2016-07-23T14:27:47Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":229325,"stargazers_count":786,"watchers_count":786,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":254,"forks":199,"open_issues":254,"watchers":786,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1377"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/1377"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1377"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1377/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1377/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1377/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/4d557aff2ab09ac35c1ff374aa220bd0c4d7e59f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"smoothdeveloper"}}