{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/59426021","id":59426021,"diff_hunk":"@@ -621,6 +618,11 @@ namespace Js\n         }\n #endif\n \n+// xplat-todo: This __try/__except catches AV and resumes from out of bound TypedArray access.","path":"lib/Runtime/Library/JavascriptFunction.cpp","position":14,"original_position":14,"commit_id":"aa34e57b0e3d50ce405decced77465386eb41bec","original_commit_id":"aa34e57b0e3d50ce405decced77465386eb41bec","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"body":"Thanks for referring to the related virtualAlloc dependencies. From the code, IsValidVirtualBufferLength always returns false and JavascriptArrayBuffer::AllocWrapper already has Assert(false) on non _WIN64 platforms. This feature is already disabled. I'll change the comment and remove this xplat-todo.","created_at":"2016-04-12T18:16:09Z","updated_at":"2016-04-12T18:16:09Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/779#discussion_r59426021","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/59426021"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/779#discussion_r59426021"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779","id":66082509,"html_url":"https://github.com/Microsoft/ChakraCore/pull/779","diff_url":"https://github.com/Microsoft/ChakraCore/pull/779.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/779.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/779","number":779,"state":"open","locked":false,"title":"xplat: build lib/Runtime/Library","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"body":"This change enables building `lib/Runtime/Library`.\n- Added a few unimplemented stubs into `CommonPal.h`.\n- Replaced a bunch of `__try/__finally(__leave)` with `TryFinally`.\n- `JavascriptBuiltInFunctions.cpp`: Added `BUILTIN_TEMPLATE` to work with\n  all TypedArray types as they are template specializations and need\n  `template<>`.\n- `TypedArray.cpp`: Needed to move `Is`/`FromVar` specializations forward\n  before being used.\n\nTODO:\n- Figure out how to work around one __try/__except use -- to resume from\n  out of bound array access AV.\n\n2 files excluded from build:\n- JavascriptErrorDebug.cpp: using interfaces\n- MathLibrary.cpp: using intrinsics conflicting with stdlib/math.h\n","created_at":"2016-04-12T00:08:08Z","updated_at":"2016-04-12T18:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e96b7efac5a4477464d3ed7cd40eb30f07223d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/779/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/aa34e57b0e3d50ce405decced77465386eb41bec","head":{"label":"jianchun:lib","ref":"lib","sha":"aa34e57b0e3d50ce405decced77465386eb41bec","user":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"repo":{"id":49751915,"name":"ChakraCore","full_name":"jianchun/ChakraCore","owner":{"login":"jianchun","id":11861955,"avatar_url":"https://avatars.githubusercontent.com/u/11861955?v=3","gravatar_id":"","url":"https://api.github.com/users/jianchun","html_url":"https://github.com/jianchun","followers_url":"https://api.github.com/users/jianchun/followers","following_url":"https://api.github.com/users/jianchun/following{/other_user}","gists_url":"https://api.github.com/users/jianchun/gists{/gist_id}","starred_url":"https://api.github.com/users/jianchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianchun/subscriptions","organizations_url":"https://api.github.com/users/jianchun/orgs","repos_url":"https://api.github.com/users/jianchun/repos","events_url":"https://api.github.com/users/jianchun/events{/privacy}","received_events_url":"https://api.github.com/users/jianchun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jianchun/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/jianchun/ChakraCore","forks_url":"https://api.github.com/repos/jianchun/ChakraCore/forks","keys_url":"https://api.github.com/repos/jianchun/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jianchun/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jianchun/ChakraCore/teams","hooks_url":"https://api.github.com/repos/jianchun/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/jianchun/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/jianchun/ChakraCore/events","assignees_url":"https://api.github.com/repos/jianchun/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/jianchun/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/jianchun/ChakraCore/tags","blobs_url":"https://api.github.com/repos/jianchun/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jianchun/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jianchun/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/jianchun/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jianchun/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/jianchun/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/jianchun/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/jianchun/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/jianchun/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/jianchun/ChakraCore/subscription","commits_url":"https://api.github.com/repos/jianchun/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/jianchun/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/jianchun/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/jianchun/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/jianchun/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/jianchun/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jianchun/ChakraCore/merges","archive_url":"https://api.github.com/repos/jianchun/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jianchun/ChakraCore/downloads","issues_url":"https://api.github.com/repos/jianchun/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/jianchun/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/jianchun/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/jianchun/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jianchun/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/jianchun/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/jianchun/ChakraCore/deployments","created_at":"2016-01-16T00:14:09Z","updated_at":"2016-01-16T00:14:24Z","pushed_at":"2016-04-12T00:08:08Z","git_url":"git://github.com/jianchun/ChakraCore.git","ssh_url":"git@github.com:jianchun/ChakraCore.git","clone_url":"https://github.com/jianchun/ChakraCore.git","svn_url":"https://github.com/jianchun/ChakraCore","homepage":null,"size":24224,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:linux","ref":"linux","sha":"b27dd9f2fcf9a9d14be8a9f57dc267d500accea3","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-04-12T17:07:47Z","pushed_at":"2016-04-12T17:33:50Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":29922,"stargazers_count":5082,"watchers_count":5082,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":552,"mirror_url":null,"open_issues_count":132,"forks":552,"open_issues":132,"watchers":5082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/779"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/779"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/779/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/779/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/aa34e57b0e3d50ce405decced77465386eb41bec"}}}}