{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/comments/77270616","id":77270616,"diff_hunk":"@@ -67,12 +67,12 @@\n   private static final String MAX_BUFFERED_RECORDS_DOC =\n       \"Approximately the max number of records each task will buffer. This config controls the memory usage for each task. When the number of \"\n       + \"buffered records is larger than this value, the partitions assigned to this task will be paused.\";\n-  private static final long MAX_BUFFERED_RECORDS_DEFAULT = 100000;\n+  private static final long MAX_BUFFERED_RECORDS_DEFAULT = 20000;\n   private static final String MAX_BUFFERED_RECORDS_DISPLAY = \"Max Number of Records to Buffer\";\n \n   public static final String BATCH_SIZE_CONFIG = \"batch.size\";\n   private static final String BATCH_SIZE_DOC = \"The number of requests to process as a batch when writing to Elasticsearch.\";\n-  private static final int BATCH_SIZE_DEFAULT = 10000;\n+  private static final int BATCH_SIZE_DEFAULT = 2000;","path":"src/main/java/io/confluent/connect/elasticsearch/ElasticsearchSinkConnectorConfig.java","position":11,"original_position":11,"commit_id":"66803ce6562863df49506e6c9b28dccbbfc36e41","original_commit_id":"66803ce6562863df49506e6c9b28dccbbfc36e41","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars.githubusercontent.com/u/47366?v=3","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"It'd be worth looking at how large the request payload gets to be with an average workload and this batch size. It's easy to batch *too* much data too, although this is at least only a maximum. We can revisit this when we have some perf data to look at.","created_at":"2016-09-01T23:13:30Z","updated_at":"2016-09-01T23:13:30Z","html_url":"https://github.com/confluentinc/kafka-connect-elasticsearch/pull/21#discussion_r77270616","pull_request_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/comments/77270616"},"html":{"href":"https://github.com/confluentinc/kafka-connect-elasticsearch/pull/21#discussion_r77270616"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21","id":83721856,"html_url":"https://github.com/confluentinc/kafka-connect-elasticsearch/pull/21","diff_url":"https://github.com/confluentinc/kafka-connect-elasticsearch/pull/21.diff","patch_url":"https://github.com/confluentinc/kafka-connect-elasticsearch/pull/21.patch","issue_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/21","number":21,"state":"open","locked":false,"title":"CC-301: Lower default values of `max.buffered.records` and `batch.size`","user":{"login":"shikhar","id":74267,"avatar_url":"https://avatars.githubusercontent.com/u/74267?v=3","gravatar_id":"","url":"https://api.github.com/users/shikhar","html_url":"https://github.com/shikhar","followers_url":"https://api.github.com/users/shikhar/followers","following_url":"https://api.github.com/users/shikhar/following{/other_user}","gists_url":"https://api.github.com/users/shikhar/gists{/gist_id}","starred_url":"https://api.github.com/users/shikhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shikhar/subscriptions","organizations_url":"https://api.github.com/users/shikhar/orgs","repos_url":"https://api.github.com/users/shikhar/repos","events_url":"https://api.github.com/users/shikhar/events{/privacy}","received_events_url":"https://api.github.com/users/shikhar/received_events","type":"User","site_admin":false},"body":"Also some slight cleanup around throwing `RetriableException` when `max.buffered.records` is hit","created_at":"2016-09-01T23:07:08Z","updated_at":"2016-09-01T23:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d2e4fec1a0d9fe69c726aadc8c2764cdc30768d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21/commits","review_comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21/comments","review_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/21/comments","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/statuses/66803ce6562863df49506e6c9b28dccbbfc36e41","head":{"label":"confluentinc:cc-301","ref":"cc-301","sha":"66803ce6562863df49506e6c9b28dccbbfc36e41","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":51432300,"name":"kafka-connect-elasticsearch","full_name":"confluentinc/kafka-connect-elasticsearch","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/kafka-connect-elasticsearch","description":"Kafka Connect Elasticsearch connector","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch","forks_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/deployments","created_at":"2016-02-10T09:44:07Z","updated_at":"2016-08-31T16:25:09Z","pushed_at":"2016-09-01T23:07:08Z","git_url":"git://github.com/confluentinc/kafka-connect-elasticsearch.git","ssh_url":"git@github.com:confluentinc/kafka-connect-elasticsearch.git","clone_url":"https://github.com/confluentinc/kafka-connect-elasticsearch.git","svn_url":"https://github.com/confluentinc/kafka-connect-elasticsearch","homepage":null,"size":112,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":13,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"f2b4284863f202780d19fbb29d26a29a473d0bc6","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":51432300,"name":"kafka-connect-elasticsearch","full_name":"confluentinc/kafka-connect-elasticsearch","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars.githubusercontent.com/u/9439498?v=3","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/kafka-connect-elasticsearch","description":"Kafka Connect Elasticsearch connector","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch","forks_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/deployments","created_at":"2016-02-10T09:44:07Z","updated_at":"2016-08-31T16:25:09Z","pushed_at":"2016-09-01T23:07:08Z","git_url":"git://github.com/confluentinc/kafka-connect-elasticsearch.git","ssh_url":"git@github.com:confluentinc/kafka-connect-elasticsearch.git","clone_url":"https://github.com/confluentinc/kafka-connect-elasticsearch.git","svn_url":"https://github.com/confluentinc/kafka-connect-elasticsearch","homepage":null,"size":112,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21"},"html":{"href":"https://github.com/confluentinc/kafka-connect-elasticsearch/pull/21"},"issue":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/21"},"comments":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/kafka-connect-elasticsearch/statuses/66803ce6562863df49506e6c9b28dccbbfc36e41"}}}}
{"actor":{"display_login":"ewencp"}}