{"action":"created","comment":{"url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments/75341875","id":75341875,"diff_hunk":"@@ -615,7 +668,7 @@ class Service(ECSBaseActor):\n     \"\"\"\n \n     all_options = {\n-        'state': (STATE, 'present', 'Desired state: present/absent'),\n+        'desired_state': (STATE, 'present', 'Desired state: present/absent'),","path":"kingpin/actors/aws/ecs.py","position":94,"original_position":94,"commit_id":"9812c5c511105580d7f2c6569421c8864cdb46a8","original_commit_id":"9812c5c511105580d7f2c6569421c8864cdb46a8","user":{"login":"swaggy","id":2256129,"avatar_url":"https://avatars.githubusercontent.com/u/2256129?v=3","gravatar_id":"","url":"https://api.github.com/users/swaggy","html_url":"https://github.com/swaggy","followers_url":"https://api.github.com/users/swaggy/followers","following_url":"https://api.github.com/users/swaggy/following{/other_user}","gists_url":"https://api.github.com/users/swaggy/gists{/gist_id}","starred_url":"https://api.github.com/users/swaggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaggy/subscriptions","organizations_url":"https://api.github.com/users/swaggy/orgs","repos_url":"https://api.github.com/users/swaggy/repos","events_url":"https://api.github.com/users/swaggy/events{/privacy}","received_events_url":"https://api.github.com/users/swaggy/received_events","type":"User","site_admin":false},"body":"Okay, fair argument, but that's disappointing to me, since state as an option doesn't read like a verb to me. Something I can get used to though.","created_at":"2016-08-18T16:30:21Z","updated_at":"2016-08-18T16:30:21Z","html_url":"https://github.com/Nextdoor/kingpin/pull/399#discussion_r75341875","pull_request_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399","_links":{"self":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments/75341875"},"html":{"href":"https://github.com/Nextdoor/kingpin/pull/399#discussion_r75341875"},"pull_request":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399"}}},"pull_request":{"url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399","id":81746536,"html_url":"https://github.com/Nextdoor/kingpin/pull/399","diff_url":"https://github.com/Nextdoor/kingpin/pull/399.diff","patch_url":"https://github.com/Nextdoor/kingpin/pull/399.patch","issue_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/399","number":399,"state":"open","locked":false,"title":"Improve ECS service deletion.","user":{"login":"swaggy","id":2256129,"avatar_url":"https://avatars.githubusercontent.com/u/2256129?v=3","gravatar_id":"","url":"https://api.github.com/users/swaggy","html_url":"https://github.com/swaggy","followers_url":"https://api.github.com/users/swaggy/followers","following_url":"https://api.github.com/users/swaggy/following{/other_user}","gists_url":"https://api.github.com/users/swaggy/gists{/gist_id}","starred_url":"https://api.github.com/users/swaggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaggy/subscriptions","organizations_url":"https://api.github.com/users/swaggy/orgs","repos_url":"https://api.github.com/users/swaggy/repos","events_url":"https://api.github.com/users/swaggy/events{/privacy}","received_events_url":"https://api.github.com/users/swaggy/received_events","type":"User","site_admin":false},"body":"This update improves logging, documentation, and script readability of the ECS service actor.\r\nIt also cleans up old task definitions.\r\n\r\nChanges:\r\n\r\n* Rename option: state to desired_state.\r\n  This clarifies the option in the script and makes it more immediately obvious that this is the state to go to.\r\n* Refactor from using _ensure_service.\r\n  Previously, deletion was logging many lines with misleading text such as 'Deployed successfully'.\r\n  Additionally, ensure_service's documentation talks about only 'updating' a service. This goes back to giving it that single responsibility.\r\n* Clean up documentation to include the 'absent' desired state, plus other misc. documentation improvements.\r\n* Split stop service from delete service. This allows us to add a way of only stopping and not deleting in the future, if we need.\r\n* Add correct logging for deletion.\r\n* Rename wait_for_deployment and is_service_deployed to wait_for_service_update and is_service_updated.\r\n  This better correlates to their new responsibility due to service deletion.\r\n* Adds functionality which deregisters old task definitions associated to a service that is being deleted.\r\n  We were leaving them around before.\r\n\r\n@mikhail @niallo ","created_at":"2016-08-18T02:08:03Z","updated_at":"2016-08-18T16:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2673e08cc7e20c48c755135130755f226c175697","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399/commits","review_comments_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399/comments","review_comment_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/399/comments","statuses_url":"https://api.github.com/repos/Nextdoor/kingpin/statuses/9812c5c511105580d7f2c6569421c8864cdb46a8","head":{"label":"Nextdoor:improve_delete_service","ref":"improve_delete_service","sha":"9812c5c511105580d7f2c6569421c8864cdb46a8","user":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"repo":{"id":22902460,"name":"kingpin","full_name":"Nextdoor/kingpin","owner":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nextdoor/kingpin","description":"Deployment Automation Engine","fork":false,"url":"https://api.github.com/repos/Nextdoor/kingpin","forks_url":"https://api.github.com/repos/Nextdoor/kingpin/forks","keys_url":"https://api.github.com/repos/Nextdoor/kingpin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nextdoor/kingpin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nextdoor/kingpin/teams","hooks_url":"https://api.github.com/repos/Nextdoor/kingpin/hooks","issue_events_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/events{/number}","events_url":"https://api.github.com/repos/Nextdoor/kingpin/events","assignees_url":"https://api.github.com/repos/Nextdoor/kingpin/assignees{/user}","branches_url":"https://api.github.com/repos/Nextdoor/kingpin/branches{/branch}","tags_url":"https://api.github.com/repos/Nextdoor/kingpin/tags","blobs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nextdoor/kingpin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nextdoor/kingpin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nextdoor/kingpin/statuses/{sha}","languages_url":"https://api.github.com/repos/Nextdoor/kingpin/languages","stargazers_url":"https://api.github.com/repos/Nextdoor/kingpin/stargazers","contributors_url":"https://api.github.com/repos/Nextdoor/kingpin/contributors","subscribers_url":"https://api.github.com/repos/Nextdoor/kingpin/subscribers","subscription_url":"https://api.github.com/repos/Nextdoor/kingpin/subscription","commits_url":"https://api.github.com/repos/Nextdoor/kingpin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nextdoor/kingpin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nextdoor/kingpin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nextdoor/kingpin/contents/{+path}","compare_url":"https://api.github.com/repos/Nextdoor/kingpin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nextdoor/kingpin/merges","archive_url":"https://api.github.com/repos/Nextdoor/kingpin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nextdoor/kingpin/downloads","issues_url":"https://api.github.com/repos/Nextdoor/kingpin/issues{/number}","pulls_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls{/number}","milestones_url":"https://api.github.com/repos/Nextdoor/kingpin/milestones{/number}","notifications_url":"https://api.github.com/repos/Nextdoor/kingpin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nextdoor/kingpin/labels{/name}","releases_url":"https://api.github.com/repos/Nextdoor/kingpin/releases{/id}","deployments_url":"https://api.github.com/repos/Nextdoor/kingpin/deployments","created_at":"2014-08-13T04:23:40Z","updated_at":"2016-05-17T23:39:53Z","pushed_at":"2016-08-18T03:27:35Z","git_url":"git://github.com/Nextdoor/kingpin.git","ssh_url":"git@github.com:Nextdoor/kingpin.git","clone_url":"https://github.com/Nextdoor/kingpin.git","svn_url":"https://github.com/Nextdoor/kingpin","homepage":"","size":1511,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":34,"forks":4,"open_issues":34,"watchers":8,"default_branch":"master"}},"base":{"label":"Nextdoor:master","ref":"master","sha":"575343fadc777c3d27e88fecfb64e62ca11593a8","user":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"repo":{"id":22902460,"name":"kingpin","full_name":"Nextdoor/kingpin","owner":{"login":"Nextdoor","id":605176,"avatar_url":"https://avatars.githubusercontent.com/u/605176?v=3","gravatar_id":"","url":"https://api.github.com/users/Nextdoor","html_url":"https://github.com/Nextdoor","followers_url":"https://api.github.com/users/Nextdoor/followers","following_url":"https://api.github.com/users/Nextdoor/following{/other_user}","gists_url":"https://api.github.com/users/Nextdoor/gists{/gist_id}","starred_url":"https://api.github.com/users/Nextdoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nextdoor/subscriptions","organizations_url":"https://api.github.com/users/Nextdoor/orgs","repos_url":"https://api.github.com/users/Nextdoor/repos","events_url":"https://api.github.com/users/Nextdoor/events{/privacy}","received_events_url":"https://api.github.com/users/Nextdoor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nextdoor/kingpin","description":"Deployment Automation Engine","fork":false,"url":"https://api.github.com/repos/Nextdoor/kingpin","forks_url":"https://api.github.com/repos/Nextdoor/kingpin/forks","keys_url":"https://api.github.com/repos/Nextdoor/kingpin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nextdoor/kingpin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nextdoor/kingpin/teams","hooks_url":"https://api.github.com/repos/Nextdoor/kingpin/hooks","issue_events_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/events{/number}","events_url":"https://api.github.com/repos/Nextdoor/kingpin/events","assignees_url":"https://api.github.com/repos/Nextdoor/kingpin/assignees{/user}","branches_url":"https://api.github.com/repos/Nextdoor/kingpin/branches{/branch}","tags_url":"https://api.github.com/repos/Nextdoor/kingpin/tags","blobs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nextdoor/kingpin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nextdoor/kingpin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nextdoor/kingpin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nextdoor/kingpin/statuses/{sha}","languages_url":"https://api.github.com/repos/Nextdoor/kingpin/languages","stargazers_url":"https://api.github.com/repos/Nextdoor/kingpin/stargazers","contributors_url":"https://api.github.com/repos/Nextdoor/kingpin/contributors","subscribers_url":"https://api.github.com/repos/Nextdoor/kingpin/subscribers","subscription_url":"https://api.github.com/repos/Nextdoor/kingpin/subscription","commits_url":"https://api.github.com/repos/Nextdoor/kingpin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nextdoor/kingpin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nextdoor/kingpin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nextdoor/kingpin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nextdoor/kingpin/contents/{+path}","compare_url":"https://api.github.com/repos/Nextdoor/kingpin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nextdoor/kingpin/merges","archive_url":"https://api.github.com/repos/Nextdoor/kingpin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nextdoor/kingpin/downloads","issues_url":"https://api.github.com/repos/Nextdoor/kingpin/issues{/number}","pulls_url":"https://api.github.com/repos/Nextdoor/kingpin/pulls{/number}","milestones_url":"https://api.github.com/repos/Nextdoor/kingpin/milestones{/number}","notifications_url":"https://api.github.com/repos/Nextdoor/kingpin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nextdoor/kingpin/labels{/name}","releases_url":"https://api.github.com/repos/Nextdoor/kingpin/releases{/id}","deployments_url":"https://api.github.com/repos/Nextdoor/kingpin/deployments","created_at":"2014-08-13T04:23:40Z","updated_at":"2016-05-17T23:39:53Z","pushed_at":"2016-08-18T03:27:35Z","git_url":"git://github.com/Nextdoor/kingpin.git","ssh_url":"git@github.com:Nextdoor/kingpin.git","clone_url":"https://github.com/Nextdoor/kingpin.git","svn_url":"https://github.com/Nextdoor/kingpin","homepage":"","size":1511,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":34,"forks":4,"open_issues":34,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399"},"html":{"href":"https://github.com/Nextdoor/kingpin/pull/399"},"issue":{"href":"https://api.github.com/repos/Nextdoor/kingpin/issues/399"},"comments":{"href":"https://api.github.com/repos/Nextdoor/kingpin/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nextdoor/kingpin/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/Nextdoor/kingpin/statuses/9812c5c511105580d7f2c6569421c8864cdb46a8"}}}}
{"actor":{"display_login":"swaggy"}}