{"action":"created","comment":{"url":"https://api.github.com/repos/fscheck/FsCheck/pulls/comments/78146163","id":78146163,"diff_hunk":"@@ -181,7 +181,7 @@ module Gen =\n         | :? array<_> as arr ->\n             elementsArr arr\n         | _ ->\n-            choose (0, (Seq.length xs)-1) |> map (flip Seq.nth xs)\n+            choose (0, (Seq.length xs)-1) |> map (flip Seq.item xs)","path":"src/FsCheck/Gen.fs","position":5,"original_position":5,"commit_id":"de5218ad7da12f9d382f062afdc284f959b498bb","original_commit_id":"de5218ad7da12f9d382f062afdc284f959b498bb","user":{"login":"kurtschelfthout","id":164917,"avatar_url":"https://avatars.githubusercontent.com/u/164917?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtschelfthout","html_url":"https://github.com/kurtschelfthout","followers_url":"https://api.github.com/users/kurtschelfthout/followers","following_url":"https://api.github.com/users/kurtschelfthout/following{/other_user}","gists_url":"https://api.github.com/users/kurtschelfthout/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtschelfthout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtschelfthout/subscriptions","organizations_url":"https://api.github.com/users/kurtschelfthout/orgs","repos_url":"https://api.github.com/users/kurtschelfthout/repos","events_url":"https://api.github.com/users/kurtschelfthout/events{/privacy}","received_events_url":"https://api.github.com/users/kurtschelfthout/received_events","type":"User","site_admin":false},"body":"That means you're compiling against a later version of FSharp.Core. FsCheck on master is compiled against 4.3.1.0 - this was not obsoleted in that version. So there is no reason for the ifdef. FsCheck project indeed has warnings as errors turned on.","created_at":"2016-09-09T08:38:12Z","updated_at":"2016-09-09T08:38:12Z","html_url":"https://github.com/fscheck/FsCheck/pull/308#discussion_r78146163","pull_request_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/comments/78146163"},"html":{"href":"https://github.com/fscheck/FsCheck/pull/308#discussion_r78146163"},"pull_request":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/fscheck/FsCheck/pulls/308","id":84481957,"html_url":"https://github.com/fscheck/FsCheck/pull/308","diff_url":"https://github.com/fscheck/FsCheck/pull/308.diff","patch_url":"https://github.com/fscheck/FsCheck/pull/308.patch","issue_url":"https://api.github.com/repos/fscheck/FsCheck/issues/308","number":308,"state":"open","locked":false,"title":"add osx to travis (on master branch)","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"body":"with mono `latest`, let's check if osx works\r\n\r\nwith new edits from maintainers feature of github, i think you @kurtschelfthout  can push commit to this branch\r\n","created_at":"2016-09-08T13:54:55Z","updated_at":"2016-09-09T08:38:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"820c7e2530634ed77eb2994abfb9f3f8f7de7c58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/308/commits","review_comments_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/308/comments","review_comment_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fscheck/FsCheck/issues/308/comments","statuses_url":"https://api.github.com/repos/fscheck/FsCheck/statuses/de5218ad7da12f9d382f062afdc284f959b498bb","head":{"label":"enricosada:add_osx_to_travis","ref":"add_osx_to_travis","sha":"de5218ad7da12f9d382f062afdc284f959b498bb","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"repo":{"id":54521291,"name":"FsCheck","full_name":"enricosada/FsCheck","owner":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enricosada/FsCheck","description":"Random Testing for .NET","fork":true,"url":"https://api.github.com/repos/enricosada/FsCheck","forks_url":"https://api.github.com/repos/enricosada/FsCheck/forks","keys_url":"https://api.github.com/repos/enricosada/FsCheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enricosada/FsCheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enricosada/FsCheck/teams","hooks_url":"https://api.github.com/repos/enricosada/FsCheck/hooks","issue_events_url":"https://api.github.com/repos/enricosada/FsCheck/issues/events{/number}","events_url":"https://api.github.com/repos/enricosada/FsCheck/events","assignees_url":"https://api.github.com/repos/enricosada/FsCheck/assignees{/user}","branches_url":"https://api.github.com/repos/enricosada/FsCheck/branches{/branch}","tags_url":"https://api.github.com/repos/enricosada/FsCheck/tags","blobs_url":"https://api.github.com/repos/enricosada/FsCheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enricosada/FsCheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enricosada/FsCheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/enricosada/FsCheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enricosada/FsCheck/statuses/{sha}","languages_url":"https://api.github.com/repos/enricosada/FsCheck/languages","stargazers_url":"https://api.github.com/repos/enricosada/FsCheck/stargazers","contributors_url":"https://api.github.com/repos/enricosada/FsCheck/contributors","subscribers_url":"https://api.github.com/repos/enricosada/FsCheck/subscribers","subscription_url":"https://api.github.com/repos/enricosada/FsCheck/subscription","commits_url":"https://api.github.com/repos/enricosada/FsCheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/enricosada/FsCheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/enricosada/FsCheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/enricosada/FsCheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/enricosada/FsCheck/contents/{+path}","compare_url":"https://api.github.com/repos/enricosada/FsCheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enricosada/FsCheck/merges","archive_url":"https://api.github.com/repos/enricosada/FsCheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enricosada/FsCheck/downloads","issues_url":"https://api.github.com/repos/enricosada/FsCheck/issues{/number}","pulls_url":"https://api.github.com/repos/enricosada/FsCheck/pulls{/number}","milestones_url":"https://api.github.com/repos/enricosada/FsCheck/milestones{/number}","notifications_url":"https://api.github.com/repos/enricosada/FsCheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enricosada/FsCheck/labels{/name}","releases_url":"https://api.github.com/repos/enricosada/FsCheck/releases{/id}","deployments_url":"https://api.github.com/repos/enricosada/FsCheck/deployments","created_at":"2016-03-23T01:32:11Z","updated_at":"2016-03-23T01:32:11Z","pushed_at":"2016-09-08T17:39:42Z","git_url":"git://github.com/enricosada/FsCheck.git","ssh_url":"git@github.com:enricosada/FsCheck.git","clone_url":"https://github.com/enricosada/FsCheck.git","svn_url":"https://github.com/enricosada/FsCheck","homepage":"https://fscheck.github.io/FsCheck/","size":13464,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fscheck:master","ref":"master","sha":"2fd5676eb5f34c98100bac7b04a0979a12dd9838","user":{"login":"fscheck","id":12610206,"avatar_url":"https://avatars.githubusercontent.com/u/12610206?v=3","gravatar_id":"","url":"https://api.github.com/users/fscheck","html_url":"https://github.com/fscheck","followers_url":"https://api.github.com/users/fscheck/followers","following_url":"https://api.github.com/users/fscheck/following{/other_user}","gists_url":"https://api.github.com/users/fscheck/gists{/gist_id}","starred_url":"https://api.github.com/users/fscheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscheck/subscriptions","organizations_url":"https://api.github.com/users/fscheck/orgs","repos_url":"https://api.github.com/users/fscheck/repos","events_url":"https://api.github.com/users/fscheck/events{/privacy}","received_events_url":"https://api.github.com/users/fscheck/received_events","type":"Organization","site_admin":false},"repo":{"id":10790442,"name":"FsCheck","full_name":"fscheck/FsCheck","owner":{"login":"fscheck","id":12610206,"avatar_url":"https://avatars.githubusercontent.com/u/12610206?v=3","gravatar_id":"","url":"https://api.github.com/users/fscheck","html_url":"https://github.com/fscheck","followers_url":"https://api.github.com/users/fscheck/followers","following_url":"https://api.github.com/users/fscheck/following{/other_user}","gists_url":"https://api.github.com/users/fscheck/gists{/gist_id}","starred_url":"https://api.github.com/users/fscheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscheck/subscriptions","organizations_url":"https://api.github.com/users/fscheck/orgs","repos_url":"https://api.github.com/users/fscheck/repos","events_url":"https://api.github.com/users/fscheck/events{/privacy}","received_events_url":"https://api.github.com/users/fscheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fscheck/FsCheck","description":"Random Testing for .NET","fork":false,"url":"https://api.github.com/repos/fscheck/FsCheck","forks_url":"https://api.github.com/repos/fscheck/FsCheck/forks","keys_url":"https://api.github.com/repos/fscheck/FsCheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fscheck/FsCheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fscheck/FsCheck/teams","hooks_url":"https://api.github.com/repos/fscheck/FsCheck/hooks","issue_events_url":"https://api.github.com/repos/fscheck/FsCheck/issues/events{/number}","events_url":"https://api.github.com/repos/fscheck/FsCheck/events","assignees_url":"https://api.github.com/repos/fscheck/FsCheck/assignees{/user}","branches_url":"https://api.github.com/repos/fscheck/FsCheck/branches{/branch}","tags_url":"https://api.github.com/repos/fscheck/FsCheck/tags","blobs_url":"https://api.github.com/repos/fscheck/FsCheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fscheck/FsCheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fscheck/FsCheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/fscheck/FsCheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fscheck/FsCheck/statuses/{sha}","languages_url":"https://api.github.com/repos/fscheck/FsCheck/languages","stargazers_url":"https://api.github.com/repos/fscheck/FsCheck/stargazers","contributors_url":"https://api.github.com/repos/fscheck/FsCheck/contributors","subscribers_url":"https://api.github.com/repos/fscheck/FsCheck/subscribers","subscription_url":"https://api.github.com/repos/fscheck/FsCheck/subscription","commits_url":"https://api.github.com/repos/fscheck/FsCheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/fscheck/FsCheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/fscheck/FsCheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/fscheck/FsCheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/fscheck/FsCheck/contents/{+path}","compare_url":"https://api.github.com/repos/fscheck/FsCheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fscheck/FsCheck/merges","archive_url":"https://api.github.com/repos/fscheck/FsCheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fscheck/FsCheck/downloads","issues_url":"https://api.github.com/repos/fscheck/FsCheck/issues{/number}","pulls_url":"https://api.github.com/repos/fscheck/FsCheck/pulls{/number}","milestones_url":"https://api.github.com/repos/fscheck/FsCheck/milestones{/number}","notifications_url":"https://api.github.com/repos/fscheck/FsCheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fscheck/FsCheck/labels{/name}","releases_url":"https://api.github.com/repos/fscheck/FsCheck/releases{/id}","deployments_url":"https://api.github.com/repos/fscheck/FsCheck/deployments","created_at":"2013-06-19T11:46:46Z","updated_at":"2016-09-09T06:53:40Z","pushed_at":"2016-09-08T17:39:42Z","git_url":"git://github.com/fscheck/FsCheck.git","ssh_url":"git@github.com:fscheck/FsCheck.git","clone_url":"https://github.com/fscheck/FsCheck.git","svn_url":"https://github.com/fscheck/FsCheck","homepage":"https://fscheck.github.io/FsCheck/","size":15920,"stargazers_count":319,"watchers_count":319,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":76,"mirror_url":null,"open_issues_count":26,"forks":76,"open_issues":26,"watchers":319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/308"},"html":{"href":"https://github.com/fscheck/FsCheck/pull/308"},"issue":{"href":"https://api.github.com/repos/fscheck/FsCheck/issues/308"},"comments":{"href":"https://api.github.com/repos/fscheck/FsCheck/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/fscheck/FsCheck/statuses/de5218ad7da12f9d382f062afdc284f959b498bb"}}}}
{"actor":{"display_login":"kurtschelfthout"}}