{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/mysql/issues/143","repository_url":"https://api.github.com/repos/openshift/mysql","labels_url":"https://api.github.com/repos/openshift/mysql/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/openshift/mysql/issues/143/comments","events_url":"https://api.github.com/repos/openshift/mysql/issues/143/events","html_url":"https://github.com/openshift/mysql/pull/143","id":155704191,"number":143,"title":"[DO NOT MERGE] Proof-of-concept deduplication","user":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-19T10:29:40Z","updated_at":"2016-05-19T11:17:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/mysql/pulls/143","html_url":"https://github.com/openshift/mysql/pull/143","diff_url":"https://github.com/openshift/mysql/pull/143.diff","patch_url":"https://github.com/openshift/mysql/pull/143.patch"},"body":"This is my first shot at an deduplication idea of using sed to generate trees. So far there is only one script in `hack/generate.sh` that, when run from the root directory will generate directories v5.5 and v5.6 from the directory origin, using the appropriate sed files to substitute correct versions and so on.\r\n\r\nOne thing I don't like is the `if [ \"@@REPLICATION@@\" = \"GTID\" ]; then` approach that I'd taken so far. I'd much less be in favour of a macro-style conditional `#ifdef` construct, I'd like to hear discussion on that.\r\n\r\nThis PR still retains 5.5 and 5.6 directories and is just for initial discussion.\r\n\r\n@mfojtik @bparees @hhorak @praiskup @ppisar @pkajaba PTAL"},"comment":{"url":"https://api.github.com/repos/openshift/mysql/issues/comments/220295750","html_url":"https://github.com/openshift/mysql/pull/143#issuecomment-220295750","issue_url":"https://api.github.com/repos/openshift/mysql/issues/143","id":220295750,"user":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"created_at":"2016-05-19T11:17:12Z","updated_at":"2016-05-19T11:17:12Z","body":"@rhcarvalho how about instead making sure there are no `@@<anything>@@` left-over?"}}