{"action":"closed","number":48,"pull_request":{"url":"https://api.github.com/repos/deis/docker-go-dev/pulls/48","id":79110611,"html_url":"https://github.com/deis/docker-go-dev/pull/48","diff_url":"https://github.com/deis/docker-go-dev/pull/48.diff","patch_url":"https://github.com/deis/docker-go-dev/pull/48.patch","issue_url":"https://api.github.com/repos/deis/docker-go-dev/issues/48","number":48,"state":"closed","locked":false,"title":"Proposal: feat(linters): switch to gometalinter","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"body":"[Gometalinter](https://github.com/alecthomas/gometalinter) is a linter that combines the most popular linters together.\r\n\r\nIt contains the linters we already use: `go vet`, `gofmt`, and `golint`, but also many more useful ones, such as the ones used by [goreportcard](https://goreportcard.com/report/github.com/deis/controller-sdk-go). It also runs them in parallel, so it shouldn't incur a large performance penalty.\r\n\r\nIt also prints out standardized output for all linters and returns error codes, so we don't have to use the hacks we use with gofmt to get a proper error code. It's also smart about the input format of packages, so we can just run `gometalinter ./...` and not have to worry about keeping lists of packages and go files to run the linter on, reducing makefile maintenance.","created_at":"2016-07-27T22:44:01Z","updated_at":"2016-07-28T20:50:19Z","closed_at":"2016-07-28T20:50:18Z","merged_at":"2016-07-28T20:50:18Z","merge_commit_sha":"8ea9077f2220c6b83ae4d9c56f5c916784d0edbc","assignee":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"assignees":[{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/deis/docker-go-dev/pulls/48/commits","review_comments_url":"https://api.github.com/repos/deis/docker-go-dev/pulls/48/comments","review_comment_url":"https://api.github.com/repos/deis/docker-go-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/docker-go-dev/issues/48/comments","statuses_url":"https://api.github.com/repos/deis/docker-go-dev/statuses/9d3d1cdbbb243be2b0ba3f70c116de31be1ee10d","head":{"label":"Joshua-Anderson:gometalinter","ref":"gometalinter","sha":"9d3d1cdbbb243be2b0ba3f70c116de31be1ee10d","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"repo":{"id":64149360,"name":"docker-go-dev","full_name":"Joshua-Anderson/docker-go-dev","owner":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Joshua-Anderson/docker-go-dev","description":"A containerized development environment to support building Go-based Deis v2 components","fork":true,"url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev","forks_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/forks","keys_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/teams","hooks_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/hooks","issue_events_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/issues/events{/number}","events_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/events","assignees_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/assignees{/user}","branches_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/branches{/branch}","tags_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/tags","blobs_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/languages","stargazers_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/stargazers","contributors_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/contributors","subscribers_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/subscribers","subscription_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/subscription","commits_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/contents/{+path}","compare_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/merges","archive_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/downloads","issues_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/issues{/number}","pulls_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/labels{/name}","releases_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/releases{/id}","deployments_url":"https://api.github.com/repos/Joshua-Anderson/docker-go-dev/deployments","created_at":"2016-07-25T16:10:46Z","updated_at":"2016-07-25T16:10:47Z","pushed_at":"2016-07-27T23:56:17Z","git_url":"git://github.com/Joshua-Anderson/docker-go-dev.git","ssh_url":"git@github.com:Joshua-Anderson/docker-go-dev.git","clone_url":"https://github.com/Joshua-Anderson/docker-go-dev.git","svn_url":"https://github.com/Joshua-Anderson/docker-go-dev","homepage":"http://deis.com","size":30,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"fe98b8411444bdc4296aa731ed71ec435d86fe9d","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":46892216,"name":"docker-go-dev","full_name":"deis/docker-go-dev","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/docker-go-dev","description":"A containerized development environment to support building Go-based Deis v2 components","fork":false,"url":"https://api.github.com/repos/deis/docker-go-dev","forks_url":"https://api.github.com/repos/deis/docker-go-dev/forks","keys_url":"https://api.github.com/repos/deis/docker-go-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/docker-go-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/docker-go-dev/teams","hooks_url":"https://api.github.com/repos/deis/docker-go-dev/hooks","issue_events_url":"https://api.github.com/repos/deis/docker-go-dev/issues/events{/number}","events_url":"https://api.github.com/repos/deis/docker-go-dev/events","assignees_url":"https://api.github.com/repos/deis/docker-go-dev/assignees{/user}","branches_url":"https://api.github.com/repos/deis/docker-go-dev/branches{/branch}","tags_url":"https://api.github.com/repos/deis/docker-go-dev/tags","blobs_url":"https://api.github.com/repos/deis/docker-go-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/docker-go-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/docker-go-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/docker-go-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/docker-go-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/docker-go-dev/languages","stargazers_url":"https://api.github.com/repos/deis/docker-go-dev/stargazers","contributors_url":"https://api.github.com/repos/deis/docker-go-dev/contributors","subscribers_url":"https://api.github.com/repos/deis/docker-go-dev/subscribers","subscription_url":"https://api.github.com/repos/deis/docker-go-dev/subscription","commits_url":"https://api.github.com/repos/deis/docker-go-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/docker-go-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/docker-go-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/docker-go-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/docker-go-dev/contents/{+path}","compare_url":"https://api.github.com/repos/deis/docker-go-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/docker-go-dev/merges","archive_url":"https://api.github.com/repos/deis/docker-go-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/docker-go-dev/downloads","issues_url":"https://api.github.com/repos/deis/docker-go-dev/issues{/number}","pulls_url":"https://api.github.com/repos/deis/docker-go-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/docker-go-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/docker-go-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/docker-go-dev/labels{/name}","releases_url":"https://api.github.com/repos/deis/docker-go-dev/releases{/id}","deployments_url":"https://api.github.com/repos/deis/docker-go-dev/deployments","created_at":"2015-11-25T23:00:51Z","updated_at":"2016-07-01T17:37:41Z","pushed_at":"2016-07-28T20:50:18Z","git_url":"git://github.com/deis/docker-go-dev.git","ssh_url":"git@github.com:deis/docker-go-dev.git","clone_url":"https://github.com/deis/docker-go-dev.git","svn_url":"https://github.com/deis/docker-go-dev","homepage":"http://deis.com","size":32,"stargazers_count":8,"watchers_count":8,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/docker-go-dev/pulls/48"},"html":{"href":"https://github.com/deis/docker-go-dev/pull/48"},"issue":{"href":"https://api.github.com/repos/deis/docker-go-dev/issues/48"},"comments":{"href":"https://api.github.com/repos/deis/docker-go-dev/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/docker-go-dev/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/docker-go-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/docker-go-dev/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/deis/docker-go-dev/statuses/9d3d1cdbbb243be2b0ba3f70c116de31be1ee10d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":23,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"Joshua-Anderson"}}