{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/comments/57377465","id":57377465,"diff_hunk":"@@ -75,6 +79,27 @@ function ResponsiveNav(rootEl) {\n \t\t}\n \t}\n \n+\tfunction incrementMenuDepths(el) {\n+\t\t// id's are prefixed to ensure that any id based functionality uses the visible element","path":"src/js/ResponsiveNav.js","position":16,"original_position":16,"commit_id":"833b0b8e54e4732c7b98d08f34574f9dacc343bf","original_commit_id":"833b0b8e54e4732c7b98d08f34574f9dacc343bf","user":{"login":"AlbertoElias","id":913117,"avatar_url":"https://avatars.githubusercontent.com/u/913117?v=3","gravatar_id":"","url":"https://api.github.com/users/AlbertoElias","html_url":"https://github.com/AlbertoElias","followers_url":"https://api.github.com/users/AlbertoElias/followers","following_url":"https://api.github.com/users/AlbertoElias/following{/other_user}","gists_url":"https://api.github.com/users/AlbertoElias/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbertoElias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbertoElias/subscriptions","organizations_url":"https://api.github.com/users/AlbertoElias/orgs","repos_url":"https://api.github.com/users/AlbertoElias/repos","events_url":"https://api.github.com/users/AlbertoElias/events{/privacy}","received_events_url":"https://api.github.com/users/AlbertoElias/received_events","type":"User","site_admin":false},"body":"what ids?","created_at":"2016-03-24T19:52:37Z","updated_at":"2016-03-24T19:52:37Z","html_url":"https://github.com/Financial-Times/o-hierarchical-nav/pull/61#discussion_r57377465","pull_request_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/comments/57377465"},"html":{"href":"https://github.com/Financial-Times/o-hierarchical-nav/pull/61#discussion_r57377465"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61","id":63916446,"html_url":"https://github.com/Financial-Times/o-hierarchical-nav/pull/61","diff_url":"https://github.com/Financial-Times/o-hierarchical-nav/pull/61.diff","patch_url":"https://github.com/Financial-Times/o-hierarchical-nav/pull/61.patch","issue_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues/61","number":61,"state":"open","locked":false,"title":"[enhancement] Nav-level increase when cloning sub-menus","user":{"login":"petrklus","id":1115667,"avatar_url":"https://avatars.githubusercontent.com/u/1115667?v=3","gravatar_id":"","url":"https://api.github.com/users/petrklus","html_url":"https://github.com/petrklus","followers_url":"https://api.github.com/users/petrklus/followers","following_url":"https://api.github.com/users/petrklus/following{/other_user}","gists_url":"https://api.github.com/users/petrklus/gists{/gist_id}","starred_url":"https://api.github.com/users/petrklus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrklus/subscriptions","organizations_url":"https://api.github.com/users/petrklus/orgs","repos_url":"https://api.github.com/users/petrklus/repos","events_url":"https://api.github.com/users/petrklus/events{/privacy}","received_events_url":"https://api.github.com/users/petrklus/received_events","type":"User","site_admin":false},"body":"Please find proposed amend to ResponsiveNav.js to better support multi-level responsive menus. When data-o-hierarchical-nav-is-cloneable is specified for a parent, the script ensures that the nav-level of the cloned submenu is increased to compensate for it being placed under the \"More/Menu\" elements.","created_at":"2016-03-23T16:58:30Z","updated_at":"2016-03-24T19:52:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3772744b9ee93916d938284d972acaed210533a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues/61/comments","statuses_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/statuses/833b0b8e54e4732c7b98d08f34574f9dacc343bf","head":{"label":"cnk-digital-solutions:master","ref":"master","sha":"833b0b8e54e4732c7b98d08f34574f9dacc343bf","user":{"login":"cnk-digital-solutions","id":3205493,"avatar_url":"https://avatars.githubusercontent.com/u/3205493?v=3","gravatar_id":"","url":"https://api.github.com/users/cnk-digital-solutions","html_url":"https://github.com/cnk-digital-solutions","followers_url":"https://api.github.com/users/cnk-digital-solutions/followers","following_url":"https://api.github.com/users/cnk-digital-solutions/following{/other_user}","gists_url":"https://api.github.com/users/cnk-digital-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/cnk-digital-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnk-digital-solutions/subscriptions","organizations_url":"https://api.github.com/users/cnk-digital-solutions/orgs","repos_url":"https://api.github.com/users/cnk-digital-solutions/repos","events_url":"https://api.github.com/users/cnk-digital-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/cnk-digital-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":54574188,"name":"o-hierarchical-nav","full_name":"cnk-digital-solutions/o-hierarchical-nav","owner":{"login":"cnk-digital-solutions","id":3205493,"avatar_url":"https://avatars.githubusercontent.com/u/3205493?v=3","gravatar_id":"","url":"https://api.github.com/users/cnk-digital-solutions","html_url":"https://github.com/cnk-digital-solutions","followers_url":"https://api.github.com/users/cnk-digital-solutions/followers","following_url":"https://api.github.com/users/cnk-digital-solutions/following{/other_user}","gists_url":"https://api.github.com/users/cnk-digital-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/cnk-digital-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnk-digital-solutions/subscriptions","organizations_url":"https://api.github.com/users/cnk-digital-solutions/orgs","repos_url":"https://api.github.com/users/cnk-digital-solutions/repos","events_url":"https://api.github.com/users/cnk-digital-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/cnk-digital-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cnk-digital-solutions/o-hierarchical-nav","description":"Hierarchical navigation for responsive pages","fork":true,"url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav","forks_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/forks","keys_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/teams","hooks_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/hooks","issue_events_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/issues/events{/number}","events_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/events","assignees_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/assignees{/user}","branches_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/branches{/branch}","tags_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/tags","blobs_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/statuses/{sha}","languages_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/languages","stargazers_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/stargazers","contributors_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/contributors","subscribers_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/subscribers","subscription_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/subscription","commits_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/contents/{+path}","compare_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/merges","archive_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/downloads","issues_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/issues{/number}","pulls_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/pulls{/number}","milestones_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/milestones{/number}","notifications_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/labels{/name}","releases_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/releases{/id}","deployments_url":"https://api.github.com/repos/cnk-digital-solutions/o-hierarchical-nav/deployments","created_at":"2016-03-23T16:07:35Z","updated_at":"2016-03-23T16:07:36Z","pushed_at":"2016-03-23T16:55:55Z","git_url":"git://github.com/cnk-digital-solutions/o-hierarchical-nav.git","ssh_url":"git@github.com:cnk-digital-solutions/o-hierarchical-nav.git","clone_url":"https://github.com/cnk-digital-solutions/o-hierarchical-nav.git","svn_url":"https://github.com/cnk-digital-solutions/o-hierarchical-nav","homepage":"http://registry.origami.ft.com/components/o-hierarchical-nav","size":136,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"7b499e7c65b683162f79cc3fa4b56a38b5ef859a","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":20965009,"name":"o-hierarchical-nav","full_name":"Financial-Times/o-hierarchical-nav","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/o-hierarchical-nav","description":"Hierarchical navigation for responsive pages","fork":false,"url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav","forks_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/forks","keys_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/teams","hooks_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/events","assignees_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/tags","blobs_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/subscription","commits_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/merges","archive_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/downloads","issues_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/deployments","created_at":"2014-06-18T14:25:08Z","updated_at":"2016-03-24T11:54:58Z","pushed_at":"2016-03-24T15:47:40Z","git_url":"git://github.com/Financial-Times/o-hierarchical-nav.git","ssh_url":"git@github.com:Financial-Times/o-hierarchical-nav.git","clone_url":"https://github.com/Financial-Times/o-hierarchical-nav.git","svn_url":"https://github.com/Financial-Times/o-hierarchical-nav","homepage":"http://registry.origami.ft.com/components/o-hierarchical-nav","size":145,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61"},"html":{"href":"https://github.com/Financial-Times/o-hierarchical-nav/pull/61"},"issue":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues/61"},"comments":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/o-hierarchical-nav/statuses/833b0b8e54e4732c7b98d08f34574f9dacc343bf"}}}}