{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/90705287","pull_request_review_id":11223679,"id":90705287,"diff_hunk":"@@ -26,7 +26,7 @@ type baseEnvironSuite struct {\n \n func (s *baseEnvironSuite) SetUpTest(c *gc.C) {\n \ts.FakeJujuXDGDataHomeSuite.SetUpTest(c)\n-\tenv, err := manualProvider{}.Open(environs.OpenParams{\n+\tenv, err := ManualProvider{}.Open(environs.OpenParams{","path":"provider/manual/environ_test.go","position":5,"original_position":5,"commit_id":"42c89729bfc4ca79a4eda03881cc1474e36e5078","original_commit_id":"42c89729bfc4ca79a4eda03881cc1474e36e5078","user":{"login":"kat-co","id":5490961,"avatar_url":"https://avatars.githubusercontent.com/u/5490961?v=3","gravatar_id":"","url":"https://api.github.com/users/kat-co","html_url":"https://github.com/kat-co","followers_url":"https://api.github.com/users/kat-co/followers","following_url":"https://api.github.com/users/kat-co/following{/other_user}","gists_url":"https://api.github.com/users/kat-co/gists{/gist_id}","starred_url":"https://api.github.com/users/kat-co/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kat-co/subscriptions","organizations_url":"https://api.github.com/users/kat-co/orgs","repos_url":"https://api.github.com/users/kat-co/repos","events_url":"https://api.github.com/users/kat-co/events{/privacy}","received_events_url":"https://api.github.com/users/kat-co/received_events","type":"User","site_admin":false},"body":"Don't we need a `Ping` function here?","created_at":"2016-12-02T19:33:24Z","updated_at":"2016-12-02T19:33:24Z","html_url":"https://github.com/juju/juju/pull/6621#discussion_r90705287","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/6621","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/90705287"},"html":{"href":"https://github.com/juju/juju/pull/6621#discussion_r90705287"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/6621"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6621","id":95436237,"html_url":"https://github.com/juju/juju/pull/6621","diff_url":"https://github.com/juju/juju/pull/6621.diff","patch_url":"https://github.com/juju/juju/pull/6621.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6621","number":6621,"state":"open","locked":false,"title":"Add Ping method to providers","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"body":"In order to know if an endpoint is correct when adding a cloud,\r\nwe need to be able to ping that provider to get an idea if it\r\neven exists.  This is long before bootstrap or even credentials,\r\nso we need a way to reasonably determine if a cloud of the\r\ncorrect type exists at the hostname/ip.  This is different per\r\ncloud, thus a per-provider endpoint.\r\n\r\nThis fixes https://bugs.launchpad.net/juju/+bug/1641970","created_at":"2016-11-28T04:20:42Z","updated_at":"2016-12-02T19:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02e71f4a2868df9d3ea532414eec9cea06c0d273","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6621/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6621/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6621/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/42c89729bfc4ca79a4eda03881cc1474e36e5078","head":{"label":"natefinch:fix-1641970","ref":"fix-1641970","sha":"42c89729bfc4ca79a4eda03881cc1474e36e5078","user":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"repo":{"id":25370863,"name":"juju","full_name":"natefinch/juju","owner":{"login":"natefinch","id":3185864,"avatar_url":"https://avatars.githubusercontent.com/u/3185864?v=3","gravatar_id":"","url":"https://api.github.com/users/natefinch","html_url":"https://github.com/natefinch","followers_url":"https://api.github.com/users/natefinch/followers","following_url":"https://api.github.com/users/natefinch/following{/other_user}","gists_url":"https://api.github.com/users/natefinch/gists{/gist_id}","starred_url":"https://api.github.com/users/natefinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefinch/subscriptions","organizations_url":"https://api.github.com/users/natefinch/orgs","repos_url":"https://api.github.com/users/natefinch/repos","events_url":"https://api.github.com/users/natefinch/events{/privacy}","received_events_url":"https://api.github.com/users/natefinch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natefinch/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/natefinch/juju","forks_url":"https://api.github.com/repos/natefinch/juju/forks","keys_url":"https://api.github.com/repos/natefinch/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natefinch/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natefinch/juju/teams","hooks_url":"https://api.github.com/repos/natefinch/juju/hooks","issue_events_url":"https://api.github.com/repos/natefinch/juju/issues/events{/number}","events_url":"https://api.github.com/repos/natefinch/juju/events","assignees_url":"https://api.github.com/repos/natefinch/juju/assignees{/user}","branches_url":"https://api.github.com/repos/natefinch/juju/branches{/branch}","tags_url":"https://api.github.com/repos/natefinch/juju/tags","blobs_url":"https://api.github.com/repos/natefinch/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natefinch/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natefinch/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/natefinch/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natefinch/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/natefinch/juju/languages","stargazers_url":"https://api.github.com/repos/natefinch/juju/stargazers","contributors_url":"https://api.github.com/repos/natefinch/juju/contributors","subscribers_url":"https://api.github.com/repos/natefinch/juju/subscribers","subscription_url":"https://api.github.com/repos/natefinch/juju/subscription","commits_url":"https://api.github.com/repos/natefinch/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/natefinch/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/natefinch/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/natefinch/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/natefinch/juju/contents/{+path}","compare_url":"https://api.github.com/repos/natefinch/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natefinch/juju/merges","archive_url":"https://api.github.com/repos/natefinch/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natefinch/juju/downloads","issues_url":"https://api.github.com/repos/natefinch/juju/issues{/number}","pulls_url":"https://api.github.com/repos/natefinch/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/natefinch/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/natefinch/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natefinch/juju/labels{/name}","releases_url":"https://api.github.com/repos/natefinch/juju/releases{/id}","deployments_url":"https://api.github.com/repos/natefinch/juju/deployments","created_at":"2014-10-17T18:12:48Z","updated_at":"2016-09-28T19:37:03Z","pushed_at":"2016-12-02T19:10:28Z","git_url":"git://github.com/natefinch/juju.git","ssh_url":"git@github.com:natefinch/juju.git","clone_url":"https://github.com/natefinch/juju.git","svn_url":"https://github.com/natefinch/juju","homepage":"juju.ubuntu.com","size":96776,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"eab93104400ff759192bc06ee26e4fe3aa90b9b7","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-12-01T10:16:36Z","pushed_at":"2016-12-02T19:10:30Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":128942,"stargazers_count":539,"watchers_count":539,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":20,"forks":169,"open_issues":20,"watchers":539,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6621"},"html":{"href":"https://github.com/juju/juju/pull/6621"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6621"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6621/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6621/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6621/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/42c89729bfc4ca79a4eda03881cc1474e36e5078"}}}}
{"actor":{"display_login":"kat-co"}}