{"action":"created","issue":{"url":"https://api.github.com/repos/silvermine/silverstripe-cms/issues/1","repository_url":"https://api.github.com/repos/silvermine/silverstripe-cms","labels_url":"https://api.github.com/repos/silvermine/silverstripe-cms/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/silvermine/silverstripe-cms/issues/1/comments","events_url":"https://api.github.com/repos/silvermine/silverstripe-cms/issues/1/events","html_url":"https://github.com/silvermine/silverstripe-cms/pull/1","id":176997359,"number":1,"title":"Fixed ReportAdmin.js posting invalid data","user":{"login":"RhodeHummel","id":1737359,"avatar_url":"https://avatars.githubusercontent.com/u/1737359?v=3","gravatar_id":"","url":"https://api.github.com/users/RhodeHummel","html_url":"https://github.com/RhodeHummel","followers_url":"https://api.github.com/users/RhodeHummel/followers","following_url":"https://api.github.com/users/RhodeHummel/following{/other_user}","gists_url":"https://api.github.com/users/RhodeHummel/gists{/gist_id}","starred_url":"https://api.github.com/users/RhodeHummel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RhodeHummel/subscriptions","organizations_url":"https://api.github.com/users/RhodeHummel/orgs","repos_url":"https://api.github.com/users/RhodeHummel/repos","events_url":"https://api.github.com/users/RhodeHummel/events{/privacy}","received_events_url":"https://api.github.com/users/RhodeHummel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-14T19:25:22Z","updated_at":"2016-09-15T12:20:27Z","closed_at":"2016-09-15T12:20:27Z","pull_request":{"url":"https://api.github.com/repos/silvermine/silverstripe-cms/pulls/1","html_url":"https://github.com/silvermine/silverstripe-cms/pull/1","diff_url":"https://github.com/silvermine/silverstripe-cms/pull/1.diff","patch_url":"https://github.com/silvermine/silverstripe-cms/pull/1.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/silvermine/silverstripe-cms/issues/comments/247312747","html_url":"https://github.com/silvermine/silverstripe-cms/pull/1#issuecomment-247312747","issue_url":"https://api.github.com/repos/silvermine/silverstripe-cms/issues/1","id":247312747,"user":{"login":"jthomerson","id":171934,"avatar_url":"https://avatars.githubusercontent.com/u/171934?v=3","gravatar_id":"","url":"https://api.github.com/users/jthomerson","html_url":"https://github.com/jthomerson","followers_url":"https://api.github.com/users/jthomerson/followers","following_url":"https://api.github.com/users/jthomerson/following{/other_user}","gists_url":"https://api.github.com/users/jthomerson/gists{/gist_id}","starred_url":"https://api.github.com/users/jthomerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jthomerson/subscriptions","organizations_url":"https://api.github.com/users/jthomerson/orgs","repos_url":"https://api.github.com/users/jthomerson/repos","events_url":"https://api.github.com/users/jthomerson/events{/privacy}","received_events_url":"https://api.github.com/users/jthomerson/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T12:20:27Z","updated_at":"2016-09-15T12:20:27Z","body":"@RhodeHummel remember this is a fork of an open source project, so the first thing to check is if the bug has been fixed upstream and we just don't have it yet.\r\n\r\nChecking:\r\n```\r\njrthomer@WORKSTATION:silverstripe-cms$ git diff silvermine/3.1 official/3.1 -- javascript/ReportAdmin.js\r\ndiff --git a/javascript/ReportAdmin.js b/javascript/ReportAdmin.js\r\nindex 5d927a8..271dd23 100644\r\n--- a/javascript/ReportAdmin.js\r\n+++ b/javascript/ReportAdmin.js\r\n@@ -9,7 +9,7 @@\r\n                                var url = $.path.parseUrl(document.location.href).hrefNoSearch, \r\n                                        params = this.find(':input[name^=filters]').serializeArray();\r\n                                params = $.grep(params, function(param) {return (param.value);}); // filter out empty\r\n-                               if(params) url = $.path.addSearchParams(url, params);\r\n+                               if(params) url = $.path.addSearchParams(url, $.param(params));\r\n                                $('.cms-container').loadPanel(url);\r\n                                return false;\r\n                        }\r\n```\r\n\r\nYep, they fixed it. Where did it come from?\r\n\r\n```\r\njrthomer@WORKSTATION:silverstripe-cms$ git blame official/3.1 javascript/ReportAdmin.js \r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  1) /**\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  2)  * File: ReportAdmin.js\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  3)  */\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  4) \r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  5) (function($) {\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  6)  $.entwine('ss', function($){\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  7)          $('.ReportAdmin .cms-edit-form').entwine({\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200  8)                  onsubmit: function(e) {\r\n98e824bc (Ingo Schommer  2012-12-04 10:22:29 +0100  9)                          var url = $.path.parseUrl(document.location.href).hrefNoSearch, \r\n98e824bc (Ingo Schommer  2012-12-04 10:22:29 +0100 10)                                  params = this.find(':input[name^=filters]').serializeArray();\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 11)                          params = $.grep(params, function(param) {return (param.value);}); // filter out empty\r\n1625d126 (Stig Lindqvist 2014-02-25 17:16:42 +1300 12)                          if(params) url = $.path.addSearchParams(url, $.param(params));\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 13)                          $('.cms-container').loadPanel(url);\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 14)                          return false;\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 15)                  }\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 16)          });\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 17)  \r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 18)  });\r\n57c615d6 (Ingo Schommer  2012-07-12 16:14:17 +0200 19) })(jQuery);\r\n```\r\n\r\nIs it safe to just cherry-pick the commit that they used to fix it? Or does it have other changes we'd need to review?\r\n\r\n```\r\njrthomer@WORKSTATION:silverstripe-cms$ git show 1625d126\r\ncommit 1625d126c2d9151829fbdccdcc659822ea1b4905\r\nAuthor: Stig Lindqvist <stojg.lindqvist@gmail.com>\r\nDate:   Tue Feb 25 17:16:42 2014 +1300\r\n\r\n    BUG Report admin don't listen to filters\r\n    \r\n    It seems like filter params that are added to the url are added in a bad way\r\n    \r\n    Currently\r\n    \r\n        ?0[name]=filters[ContentReviewOwnerID]&0[value]=1\r\n    \r\n    Expected:\r\n    \r\n        ?filters[ContentReviewOwnerID]=1\r\n\r\ndiff --git a/javascript/ReportAdmin.js b/javascript/ReportAdmin.js\r\nindex 5d927a8..271dd23 100644\r\n--- a/javascript/ReportAdmin.js\r\n+++ b/javascript/ReportAdmin.js\r\n@@ -9,7 +9,7 @@\r\n                                var url = $.path.parseUrl(document.location.href).hrefNoSearch, \r\n                                        params = this.find(':input[name^=filters]').serializeArray();\r\n                                params = $.grep(params, function(param) {return (param.value);}); // filter out empty\r\n-                               if(params) url = $.path.addSearchParams(url, params);\r\n+                               if(params) url = $.path.addSearchParams(url, $.param(params));\r\n                                $('.cms-container').loadPanel(url);\r\n                                return false;\r\n                        }\r\n```\r\n\r\nYep, it's safe. Let's pull it into ours.\r\n\r\n```\r\njrthomer@WORKSTATION:silverstripe-cms$ git cherry-pick 1625d126c2d9151829fbdccdcc659822ea1b4905\r\n[3.1 e832c50] BUG Report admin don't listen to filters\r\n Author: Stig Lindqvist <stojg.lindqvist@gmail.com>\r\n Date: Tue Feb 25 17:16:42 2014 +1300\r\n 1 file changed, 1 insertion(+), 1 deletion(-)\r\njrthomer@WORKSTATION:silverstripe-cms$ git status\r\nOn branch 3.1\r\nYour branch is ahead of 'silvermine/3.1' by 1 commit.\r\n  (use \"git push\" to publish your local commits)\r\nnothing to commit, working directory clean\r\njrthomer@WORKSTATION:silverstripe-cms$ git push silvermine 3.1\r\nCounting objects: 4, done.\r\nDelta compression using up to 8 threads.\r\nCompressing objects: 100% (4/4), done.\r\nWriting objects: 100% (4/4), 541 bytes | 0 bytes/s, done.\r\nTotal 4 (delta 3), reused 0 (delta 0)\r\nremote: Resolving deltas: 100% (3/3), completed with 3 local objects.\r\nTo git@github.com:silvermine/silverstripe-cms.git\r\n   1187766..e832c50  3.1 -> 3.1\r\n```"}}
{"actor":{"display_login":"jthomerson"}}