{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/78701669","id":78701669,"diff_hunk":"@@ -1450,7 +1450,7 @@ pub struct ItemId {\n /// The name might be a dummy name in case of anonymous items\n #[derive(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Debug)]\n pub struct Item {\n-    pub name: Name,\n+    pub name: Spanned<Name>,","path":"src/librustc/hir/mod.rs","position":5,"original_position":5,"commit_id":"d7551dfd03c9d7264cae3eadd58044fd23b43c82","original_commit_id":"d7551dfd03c9d7264cae3eadd58044fd23b43c82","user":{"login":"phungleson","id":93457,"avatar_url":"https://avatars.githubusercontent.com/u/93457?v=3","gravatar_id":"","url":"https://api.github.com/users/phungleson","html_url":"https://github.com/phungleson","followers_url":"https://api.github.com/users/phungleson/followers","following_url":"https://api.github.com/users/phungleson/following{/other_user}","gists_url":"https://api.github.com/users/phungleson/gists{/gist_id}","starred_url":"https://api.github.com/users/phungleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phungleson/subscriptions","organizations_url":"https://api.github.com/users/phungleson/orgs","repos_url":"https://api.github.com/users/phungleson/repos","events_url":"https://api.github.com/users/phungleson/events{/privacy}","received_events_url":"https://api.github.com/users/phungleson/received_events","type":"User","site_admin":false},"body":"Ah no worries, I just kept last changes so that it is easier to continue the discussion.\r\n\r\nOkay so continue, when we display the error, we only have `hir::Item`. Specifically at this section\r\n\r\nhttps://github.com/rust-lang/rust/blob/f1f40f850e2546c2c187514e3d61d17544ba433f/src/librustc/traits/error_reporting.rs#L571-L585\r\n\r\nIt seems that we can get the `hir::Item` by doing something like this `self.map.find(4)`, not sure if we can get `ast::Item` at that place?\r\n\r\n\r\n\r\n","created_at":"2016-09-14T07:58:47Z","updated_at":"2016-09-14T07:58:48Z","html_url":"https://github.com/rust-lang/rust/pull/36466#discussion_r78701669","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/36466","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/78701669"},"html":{"href":"https://github.com/rust-lang/rust/pull/36466#discussion_r78701669"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36466"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36466","id":85155015,"html_url":"https://github.com/rust-lang/rust/pull/36466","diff_url":"https://github.com/rust-lang/rust/pull/36466.diff","patch_url":"https://github.com/rust-lang/rust/pull/36466.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36466","number":36466,"state":"open","locked":false,"title":"Update E0072 bonus to new error format","user":{"login":"phungleson","id":93457,"avatar_url":"https://avatars.githubusercontent.com/u/93457?v=3","gravatar_id":"","url":"https://api.github.com/users/phungleson","html_url":"https://github.com/phungleson","followers_url":"https://api.github.com/users/phungleson/followers","following_url":"https://api.github.com/users/phungleson/following{/other_user}","gists_url":"https://api.github.com/users/phungleson/gists{/gist_id}","starred_url":"https://api.github.com/users/phungleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phungleson/subscriptions","organizations_url":"https://api.github.com/users/phungleson/orgs","repos_url":"https://api.github.com/users/phungleson/repos","events_url":"https://api.github.com/users/phungleson/events{/privacy}","received_events_url":"https://api.github.com/users/phungleson/received_events","type":"User","site_admin":false},"body":"WIP\r\n\r\nFixes #35965\r\nPart of #35233\r\n\r\nr? @jonathandturner","created_at":"2016-09-14T01:54:26Z","updated_at":"2016-09-14T07:58:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"315c4a25ba41c8e3905a7475c669d40a49c193fa","assignee":{"login":"jonathandturner","id":547158,"avatar_url":"https://avatars.githubusercontent.com/u/547158?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathandturner","html_url":"https://github.com/jonathandturner","followers_url":"https://api.github.com/users/jonathandturner/followers","following_url":"https://api.github.com/users/jonathandturner/following{/other_user}","gists_url":"https://api.github.com/users/jonathandturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathandturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathandturner/subscriptions","organizations_url":"https://api.github.com/users/jonathandturner/orgs","repos_url":"https://api.github.com/users/jonathandturner/repos","events_url":"https://api.github.com/users/jonathandturner/events{/privacy}","received_events_url":"https://api.github.com/users/jonathandturner/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonathandturner","id":547158,"avatar_url":"https://avatars.githubusercontent.com/u/547158?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathandturner","html_url":"https://github.com/jonathandturner","followers_url":"https://api.github.com/users/jonathandturner/followers","following_url":"https://api.github.com/users/jonathandturner/following{/other_user}","gists_url":"https://api.github.com/users/jonathandturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathandturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathandturner/subscriptions","organizations_url":"https://api.github.com/users/jonathandturner/orgs","repos_url":"https://api.github.com/users/jonathandturner/repos","events_url":"https://api.github.com/users/jonathandturner/events{/privacy}","received_events_url":"https://api.github.com/users/jonathandturner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/36466/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/36466/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36466/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d7551dfd03c9d7264cae3eadd58044fd23b43c82","head":{"label":"phungleson:e0072-bonus","ref":"e0072-bonus","sha":"d7551dfd03c9d7264cae3eadd58044fd23b43c82","user":{"login":"phungleson","id":93457,"avatar_url":"https://avatars.githubusercontent.com/u/93457?v=3","gravatar_id":"","url":"https://api.github.com/users/phungleson","html_url":"https://github.com/phungleson","followers_url":"https://api.github.com/users/phungleson/followers","following_url":"https://api.github.com/users/phungleson/following{/other_user}","gists_url":"https://api.github.com/users/phungleson/gists{/gist_id}","starred_url":"https://api.github.com/users/phungleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phungleson/subscriptions","organizations_url":"https://api.github.com/users/phungleson/orgs","repos_url":"https://api.github.com/users/phungleson/repos","events_url":"https://api.github.com/users/phungleson/events{/privacy}","received_events_url":"https://api.github.com/users/phungleson/received_events","type":"User","site_admin":false},"repo":{"id":24943362,"name":"rust","full_name":"phungleson/rust","owner":{"login":"phungleson","id":93457,"avatar_url":"https://avatars.githubusercontent.com/u/93457?v=3","gravatar_id":"","url":"https://api.github.com/users/phungleson","html_url":"https://github.com/phungleson","followers_url":"https://api.github.com/users/phungleson/followers","following_url":"https://api.github.com/users/phungleson/following{/other_user}","gists_url":"https://api.github.com/users/phungleson/gists{/gist_id}","starred_url":"https://api.github.com/users/phungleson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phungleson/subscriptions","organizations_url":"https://api.github.com/users/phungleson/orgs","repos_url":"https://api.github.com/users/phungleson/repos","events_url":"https://api.github.com/users/phungleson/events{/privacy}","received_events_url":"https://api.github.com/users/phungleson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phungleson/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/phungleson/rust","forks_url":"https://api.github.com/repos/phungleson/rust/forks","keys_url":"https://api.github.com/repos/phungleson/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phungleson/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phungleson/rust/teams","hooks_url":"https://api.github.com/repos/phungleson/rust/hooks","issue_events_url":"https://api.github.com/repos/phungleson/rust/issues/events{/number}","events_url":"https://api.github.com/repos/phungleson/rust/events","assignees_url":"https://api.github.com/repos/phungleson/rust/assignees{/user}","branches_url":"https://api.github.com/repos/phungleson/rust/branches{/branch}","tags_url":"https://api.github.com/repos/phungleson/rust/tags","blobs_url":"https://api.github.com/repos/phungleson/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phungleson/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phungleson/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/phungleson/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phungleson/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/phungleson/rust/languages","stargazers_url":"https://api.github.com/repos/phungleson/rust/stargazers","contributors_url":"https://api.github.com/repos/phungleson/rust/contributors","subscribers_url":"https://api.github.com/repos/phungleson/rust/subscribers","subscription_url":"https://api.github.com/repos/phungleson/rust/subscription","commits_url":"https://api.github.com/repos/phungleson/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/phungleson/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/phungleson/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/phungleson/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/phungleson/rust/contents/{+path}","compare_url":"https://api.github.com/repos/phungleson/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phungleson/rust/merges","archive_url":"https://api.github.com/repos/phungleson/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phungleson/rust/downloads","issues_url":"https://api.github.com/repos/phungleson/rust/issues{/number}","pulls_url":"https://api.github.com/repos/phungleson/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/phungleson/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/phungleson/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phungleson/rust/labels{/name}","releases_url":"https://api.github.com/repos/phungleson/rust/releases{/id}","deployments_url":"https://api.github.com/repos/phungleson/rust/deployments","created_at":"2014-10-08T14:02:28Z","updated_at":"2016-08-31T02:26:37Z","pushed_at":"2016-09-13T10:02:38Z","git_url":"git://github.com/phungleson/rust.git","ssh_url":"git@github.com:phungleson/rust.git","clone_url":"https://github.com/phungleson/rust.git","svn_url":"https://github.com/phungleson/rust","homepage":"http://www.rust-lang.org","size":298537,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"b1363a73ede57ae595f3a1be2bb75d308ba4f7f6","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-09-14T07:55:16Z","pushed_at":"2016-09-14T07:35:57Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":510155,"stargazers_count":18277,"watchers_count":18277,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3525,"mirror_url":null,"open_issues_count":2823,"forks":3525,"open_issues":2823,"watchers":18277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36466"},"html":{"href":"https://github.com/rust-lang/rust/pull/36466"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36466"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36466/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36466/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36466/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d7551dfd03c9d7264cae3eadd58044fd23b43c82"}}}}
{"actor":{"display_login":"phungleson"}}