{"action":"closed","number":1435,"pull_request":{"url":"https://api.github.com/repos/Jasig/cas/pulls/1435","id":55520064,"html_url":"https://github.com/Jasig/cas/pull/1435","diff_url":"https://github.com/Jasig/cas/pull/1435.diff","patch_url":"https://github.com/Jasig/cas/pull/1435.patch","issue_url":"https://api.github.com/repos/Jasig/cas/issues/1435","number":1435,"state":"closed","locked":false,"title":"Update X.509 Authentication Guide","user":{"login":"jbjonesjr","id":533967,"avatar_url":"https://avatars.githubusercontent.com/u/533967?v=3","gravatar_id":"","url":"https://api.github.com/users/jbjonesjr","html_url":"https://github.com/jbjonesjr","followers_url":"https://api.github.com/users/jbjonesjr/followers","following_url":"https://api.github.com/users/jbjonesjr/following{/other_user}","gists_url":"https://api.github.com/users/jbjonesjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jbjonesjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbjonesjr/subscriptions","organizations_url":"https://api.github.com/users/jbjonesjr/orgs","repos_url":"https://api.github.com/users/jbjonesjr/repos","events_url":"https://api.github.com/users/jbjonesjr/events{/privacy}","received_events_url":"https://api.github.com/users/jbjonesjr/received_events","type":"User","site_admin":true},"body":"**NOTE:** This replaces PR #1431 \r\n--------\r\nWhen attempting to follow the X.509 Authentication Guide, I found some errors in the documentation and code snippets. This included:\r\n\r\n* [x] mal-formed xml syntax\r\n* [x] deprecated spring webflow properties and beans\r\n\r\nThis PR addresses these concerns. I have validated the included configurations worked on my clean configuration, of which the details are below:\r\n\r\n* Fedora 23\r\n* Oracle JRE 1.8.0_66\r\n* Apache Tomcat 8\r\n* Jasig CAS 4.1.3\r\n* CAS X509 Handler 4.1.3","created_at":"2016-01-08T22:39:53Z","updated_at":"2016-01-09T08:17:33Z","closed_at":"2016-01-09T08:17:33Z","merged_at":"2016-01-09T08:17:33Z","merge_commit_sha":"d7be7269a3c1b890703e42cee138a5df15d2c77b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jasig/cas/pulls/1435/commits","review_comments_url":"https://api.github.com/repos/Jasig/cas/pulls/1435/comments","review_comment_url":"https://api.github.com/repos/Jasig/cas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jasig/cas/issues/1435/comments","statuses_url":"https://api.github.com/repos/Jasig/cas/statuses/2d8102d9bc6f7f37d787c45d87a533ec6e98f177","head":{"label":"jbjonesjr:patch-1","ref":"patch-1","sha":"2d8102d9bc6f7f37d787c45d87a533ec6e98f177","user":{"login":"jbjonesjr","id":533967,"avatar_url":"https://avatars.githubusercontent.com/u/533967?v=3","gravatar_id":"","url":"https://api.github.com/users/jbjonesjr","html_url":"https://github.com/jbjonesjr","followers_url":"https://api.github.com/users/jbjonesjr/followers","following_url":"https://api.github.com/users/jbjonesjr/following{/other_user}","gists_url":"https://api.github.com/users/jbjonesjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jbjonesjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbjonesjr/subscriptions","organizations_url":"https://api.github.com/users/jbjonesjr/orgs","repos_url":"https://api.github.com/users/jbjonesjr/repos","events_url":"https://api.github.com/users/jbjonesjr/events{/privacy}","received_events_url":"https://api.github.com/users/jbjonesjr/received_events","type":"User","site_admin":true},"repo":{"id":48968316,"name":"cas","full_name":"jbjonesjr/cas","owner":{"login":"jbjonesjr","id":533967,"avatar_url":"https://avatars.githubusercontent.com/u/533967?v=3","gravatar_id":"","url":"https://api.github.com/users/jbjonesjr","html_url":"https://github.com/jbjonesjr","followers_url":"https://api.github.com/users/jbjonesjr/followers","following_url":"https://api.github.com/users/jbjonesjr/following{/other_user}","gists_url":"https://api.github.com/users/jbjonesjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jbjonesjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbjonesjr/subscriptions","organizations_url":"https://api.github.com/users/jbjonesjr/orgs","repos_url":"https://api.github.com/users/jbjonesjr/repos","events_url":"https://api.github.com/users/jbjonesjr/events{/privacy}","received_events_url":"https://api.github.com/users/jbjonesjr/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/jbjonesjr/cas","description":"Apereo CAS - Single Sign On for the Web","fork":true,"url":"https://api.github.com/repos/jbjonesjr/cas","forks_url":"https://api.github.com/repos/jbjonesjr/cas/forks","keys_url":"https://api.github.com/repos/jbjonesjr/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbjonesjr/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbjonesjr/cas/teams","hooks_url":"https://api.github.com/repos/jbjonesjr/cas/hooks","issue_events_url":"https://api.github.com/repos/jbjonesjr/cas/issues/events{/number}","events_url":"https://api.github.com/repos/jbjonesjr/cas/events","assignees_url":"https://api.github.com/repos/jbjonesjr/cas/assignees{/user}","branches_url":"https://api.github.com/repos/jbjonesjr/cas/branches{/branch}","tags_url":"https://api.github.com/repos/jbjonesjr/cas/tags","blobs_url":"https://api.github.com/repos/jbjonesjr/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbjonesjr/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbjonesjr/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbjonesjr/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbjonesjr/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbjonesjr/cas/languages","stargazers_url":"https://api.github.com/repos/jbjonesjr/cas/stargazers","contributors_url":"https://api.github.com/repos/jbjonesjr/cas/contributors","subscribers_url":"https://api.github.com/repos/jbjonesjr/cas/subscribers","subscription_url":"https://api.github.com/repos/jbjonesjr/cas/subscription","commits_url":"https://api.github.com/repos/jbjonesjr/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbjonesjr/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbjonesjr/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbjonesjr/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbjonesjr/cas/contents/{+path}","compare_url":"https://api.github.com/repos/jbjonesjr/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbjonesjr/cas/merges","archive_url":"https://api.github.com/repos/jbjonesjr/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbjonesjr/cas/downloads","issues_url":"https://api.github.com/repos/jbjonesjr/cas/issues{/number}","pulls_url":"https://api.github.com/repos/jbjonesjr/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbjonesjr/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbjonesjr/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbjonesjr/cas/labels{/name}","releases_url":"https://api.github.com/repos/jbjonesjr/cas/releases{/id}","created_at":"2016-01-04T01:42:28Z","updated_at":"2016-01-04T01:42:42Z","pushed_at":"2016-01-04T14:23:53Z","git_url":"git://github.com/jbjonesjr/cas.git","ssh_url":"git@github.com:jbjonesjr/cas.git","clone_url":"https://github.com/jbjonesjr/cas.git","svn_url":"https://github.com/jbjonesjr/cas","homepage":"http://jasig.github.io/cas/","size":795487,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jasig:4.1.x","ref":"4.1.x","sha":"9d8e460bd32c6b3cfc8234029960768052fdf7b9","user":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"repo":{"id":2352744,"name":"cas","full_name":"Jasig/cas","owner":{"login":"Jasig","id":884285,"avatar_url":"https://avatars.githubusercontent.com/u/884285?v=3","gravatar_id":"","url":"https://api.github.com/users/Jasig","html_url":"https://github.com/Jasig","followers_url":"https://api.github.com/users/Jasig/followers","following_url":"https://api.github.com/users/Jasig/following{/other_user}","gists_url":"https://api.github.com/users/Jasig/gists{/gist_id}","starred_url":"https://api.github.com/users/Jasig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jasig/subscriptions","organizations_url":"https://api.github.com/users/Jasig/orgs","repos_url":"https://api.github.com/users/Jasig/repos","events_url":"https://api.github.com/users/Jasig/events{/privacy}","received_events_url":"https://api.github.com/users/Jasig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jasig/cas","description":"Apereo CAS - Single Sign On for the Web","fork":false,"url":"https://api.github.com/repos/Jasig/cas","forks_url":"https://api.github.com/repos/Jasig/cas/forks","keys_url":"https://api.github.com/repos/Jasig/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jasig/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jasig/cas/teams","hooks_url":"https://api.github.com/repos/Jasig/cas/hooks","issue_events_url":"https://api.github.com/repos/Jasig/cas/issues/events{/number}","events_url":"https://api.github.com/repos/Jasig/cas/events","assignees_url":"https://api.github.com/repos/Jasig/cas/assignees{/user}","branches_url":"https://api.github.com/repos/Jasig/cas/branches{/branch}","tags_url":"https://api.github.com/repos/Jasig/cas/tags","blobs_url":"https://api.github.com/repos/Jasig/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jasig/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jasig/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jasig/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jasig/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/Jasig/cas/languages","stargazers_url":"https://api.github.com/repos/Jasig/cas/stargazers","contributors_url":"https://api.github.com/repos/Jasig/cas/contributors","subscribers_url":"https://api.github.com/repos/Jasig/cas/subscribers","subscription_url":"https://api.github.com/repos/Jasig/cas/subscription","commits_url":"https://api.github.com/repos/Jasig/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jasig/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jasig/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jasig/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jasig/cas/contents/{+path}","compare_url":"https://api.github.com/repos/Jasig/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jasig/cas/merges","archive_url":"https://api.github.com/repos/Jasig/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jasig/cas/downloads","issues_url":"https://api.github.com/repos/Jasig/cas/issues{/number}","pulls_url":"https://api.github.com/repos/Jasig/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/Jasig/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/Jasig/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jasig/cas/labels{/name}","releases_url":"https://api.github.com/repos/Jasig/cas/releases{/id}","created_at":"2011-09-09T01:36:42Z","updated_at":"2016-01-09T02:36:58Z","pushed_at":"2016-01-09T08:17:33Z","git_url":"git://github.com/Jasig/cas.git","ssh_url":"git@github.com:Jasig/cas.git","clone_url":"https://github.com/Jasig/cas.git","svn_url":"https://github.com/Jasig/cas","homepage":"http://jasig.github.io/cas/","size":832768,"stargazers_count":1070,"watchers_count":1070,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":828,"mirror_url":null,"open_issues_count":44,"forks":828,"open_issues":44,"watchers":1070,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jasig/cas/pulls/1435"},"html":{"href":"https://github.com/Jasig/cas/pull/1435"},"issue":{"href":"https://api.github.com/repos/Jasig/cas/issues/1435"},"comments":{"href":"https://api.github.com/repos/Jasig/cas/issues/1435/comments"},"review_comments":{"href":"https://api.github.com/repos/Jasig/cas/pulls/1435/comments"},"review_comment":{"href":"https://api.github.com/repos/Jasig/cas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jasig/cas/pulls/1435/commits"},"statuses":{"href":"https://api.github.com/repos/Jasig/cas/statuses/2d8102d9bc6f7f37d787c45d87a533ec6e98f177"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}