{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/76907952","id":76907952,"diff_hunk":"@@ -232,17 +234,44 @@ Portal.details.NcWmsPanel = Ext.extend(Ext.Container, {\n         this.add(this.pointTimeSeriesPanel);\n     },\n \n-    _defaultDateTimePickerConfiguration: function() {\n+    areDatesLogical: function(datePicker) {\n+\n+        if (this.endDateTimePicker.rendered && this.startDateTimePicker.rendered) {\n+\n+            var start = moment(this.startDateTimePicker.getValue()).clone();\n+            var end = moment(this.endDateTimePicker.getValue()).clone();\n+            var date = moment(datePicker.getValue()).clone();\n+\n+            if (datePicker.pickerType == this.START_DATE) {\n+                start = date;\n+            }\n+            else {\n+                end = date;\n+            }\n+\n+            if (start.isValid() && end.isValid() && !this._isDateRangeValid(start,end)) {\n+                return String.format(OpenLayers.i18n('dateFormLogicalError'),\n+                    start.format('Do MMMM YYYY'),","path":"web-app/js/portal/details/NcWmsPanel.js","position":58,"original_position":58,"commit_id":"db1ab4baf8da587ecdeddbdbfd3da2e472962bb4","original_commit_id":"db1ab4baf8da587ecdeddbdbfd3da2e472962bb4","user":{"login":"anguss00","id":5964166,"avatar_url":"https://avatars.githubusercontent.com/u/5964166?v=3","gravatar_id":"","url":"https://api.github.com/users/anguss00","html_url":"https://github.com/anguss00","followers_url":"https://api.github.com/users/anguss00/followers","following_url":"https://api.github.com/users/anguss00/following{/other_user}","gists_url":"https://api.github.com/users/anguss00/gists{/gist_id}","starred_url":"https://api.github.com/users/anguss00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anguss00/subscriptions","organizations_url":"https://api.github.com/users/anguss00/orgs","repos_url":"https://api.github.com/users/anguss00/repos","events_url":"https://api.github.com/users/anguss00/events{/privacy}","received_events_url":"https://api.github.com/users/anguss00/received_events","type":"User","site_admin":false},"body":"Don't mind me, all good!","created_at":"2016-08-31T00:59:22Z","updated_at":"2016-08-31T00:59:22Z","html_url":"https://github.com/aodn/aodn-portal/pull/2295#discussion_r76907952","pull_request_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295","_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/76907952"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/2295#discussion_r76907952"},"pull_request":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295","id":83210770,"html_url":"https://github.com/aodn/aodn-portal/pull/2295","diff_url":"https://github.com/aodn/aodn-portal/pull/2295.diff","patch_url":"https://github.com/aodn/aodn-portal/pull/2295.patch","issue_url":"https://api.github.com/repos/aodn/aodn-portal/issues/2295","number":2295,"state":"open","locked":false,"title":"Fixes #2249 date range logic validation","user":{"login":"pmbohm","id":1066981,"avatar_url":"https://avatars.githubusercontent.com/u/1066981?v=3","gravatar_id":"","url":"https://api.github.com/users/pmbohm","html_url":"https://github.com/pmbohm","followers_url":"https://api.github.com/users/pmbohm/followers","following_url":"https://api.github.com/users/pmbohm/following{/other_user}","gists_url":"https://api.github.com/users/pmbohm/gists{/gist_id}","starred_url":"https://api.github.com/users/pmbohm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmbohm/subscriptions","organizations_url":"https://api.github.com/users/pmbohm/orgs","repos_url":"https://api.github.com/users/pmbohm/repos","events_url":"https://api.github.com/users/pmbohm/events{/privacy}","received_events_url":"https://api.github.com/users/pmbohm/received_events","type":"User","site_admin":false},"body":"Upgrade Moment.js","created_at":"2016-08-30T05:34:20Z","updated_at":"2016-08-31T00:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f02a27bdd535ad836c11399fd0c73dc1254a77e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295/commits","review_comments_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295/comments","review_comment_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/issues/2295/comments","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/db1ab4baf8da587ecdeddbdbfd3da2e472962bb4","head":{"label":"aodn:issue-2249","ref":"issue-2249","sha":"db1ab4baf8da587ecdeddbdbfd3da2e472962bb4","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","deployments_url":"https://api.github.com/repos/aodn/aodn-portal/deployments","created_at":"2012-11-22T01:42:50Z","updated_at":"2016-08-26T02:08:11Z","pushed_at":"2016-08-31T00:51:04Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"https://imos.aodn.org.au/","size":76312,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":31,"forks":12,"open_issues":31,"watchers":8,"default_branch":"master"}},"base":{"label":"aodn:master","ref":"master","sha":"ded4b414f2ac791c6eec47c432878cb17ca90ffe","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","deployments_url":"https://api.github.com/repos/aodn/aodn-portal/deployments","created_at":"2012-11-22T01:42:50Z","updated_at":"2016-08-26T02:08:11Z","pushed_at":"2016-08-31T00:51:04Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"https://imos.aodn.org.au/","size":76312,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":31,"forks":12,"open_issues":31,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/2295"},"issue":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/2295"},"comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/2295/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/2295/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/aodn-portal/statuses/db1ab4baf8da587ecdeddbdbfd3da2e472962bb4"}}}}
{"actor":{"display_login":"anguss00"}}