{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/419","labels_url":"https://api.github.com/repos/zulip/zulip/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/419/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/419/events","html_url":"https://github.com/zulip/zulip/pull/419","id":126166223,"number":419,"title":"Adding OpenBSD compatibility","user":{"login":"blablacio","id":3009538,"avatar_url":"https://avatars.githubusercontent.com/u/3009538?v=3","gravatar_id":"","url":"https://api.github.com/users/blablacio","html_url":"https://github.com/blablacio","followers_url":"https://api.github.com/users/blablacio/followers","following_url":"https://api.github.com/users/blablacio/following{/other_user}","gists_url":"https://api.github.com/users/blablacio/gists{/gist_id}","starred_url":"https://api.github.com/users/blablacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blablacio/subscriptions","organizations_url":"https://api.github.com/users/blablacio/orgs","repos_url":"https://api.github.com/users/blablacio/repos","events_url":"https://api.github.com/users/blablacio/events{/privacy}","received_events_url":"https://api.github.com/users/blablacio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-12T12:11:36Z","updated_at":"2016-01-13T06:07:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/419","html_url":"https://github.com/zulip/zulip/pull/419","diff_url":"https://github.com/zulip/zulip/pull/419.diff","patch_url":"https://github.com/zulip/zulip/pull/419.patch"},"body":"There are some changes in scripts that I made sure don't break Linux instances, but needs to be tested. Other notable changes that could possibly cause problems are changes in Node and Python requirements."},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/171179833","html_url":"https://github.com/zulip/zulip/pull/419#issuecomment-171179833","issue_url":"https://api.github.com/repos/zulip/zulip/issues/419","id":171179833,"user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T06:07:38Z","updated_at":"2016-01-13T06:07:38Z","body":"OK aside from those line notes above, it seems like there's two larger things worth doing:\r\n\r\n(1) Doing an audit through the other output of `git grep 'bash -[xe]'` and fixing those too\r\n(2) Adding a lint rule for bash #! lines to avoid this regressing.  I think a good way to do this would be to add in `tools/lint-all` a `bash_rules` section to be run inside check_custom_checks, and make a new `by_lang['.sh']` that's populated with e.g. `grep --files-with-matches '#!.*bash' $(find scripts/ tools/ bin/ -type f | grep -v [.])`\r\n\r\n(2) should probably be a second commit.\r\n\r\nOtherwise this lgtm!\r\n"}}