{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-session/issues/421","repository_url":"https://api.github.com/repos/spring-projects/spring-session","labels_url":"https://api.github.com/repos/spring-projects/spring-session/issues/421/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-session/issues/421/comments","events_url":"https://api.github.com/repos/spring-projects/spring-session/issues/421/events","html_url":"https://github.com/spring-projects/spring-session/pull/421","id":140045699,"number":421,"title":"Fix JdbcOperationsSessionRepository to correctly cleanup expired sessions","user":{"login":"erindru","id":1001316,"avatar_url":"https://avatars.githubusercontent.com/u/1001316?v=3","gravatar_id":"","url":"https://api.github.com/users/erindru","html_url":"https://github.com/erindru","followers_url":"https://api.github.com/users/erindru/followers","following_url":"https://api.github.com/users/erindru/following{/other_user}","gists_url":"https://api.github.com/users/erindru/gists{/gist_id}","starred_url":"https://api.github.com/users/erindru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erindru/subscriptions","organizations_url":"https://api.github.com/users/erindru/orgs","repos_url":"https://api.github.com/users/erindru/repos","events_url":"https://api.github.com/users/erindru/events{/privacy}","received_events_url":"https://api.github.com/users/erindru/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-11T00:06:33Z","updated_at":"2016-03-11T06:38:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-session/pulls/421","html_url":"https://github.com/spring-projects/spring-session/pull/421","diff_url":"https://github.com/spring-projects/spring-session/pull/421.diff","patch_url":"https://github.com/spring-projects/spring-session/pull/421.patch"},"body":"Right now, when JdbcOperationsSessionRepository cleans up sessions, it deletes all sessions with a LAST_ACCESSED_TIME < the current time.\r\n\r\nIn practice, this is pretty much every session, and the session inactive interval is not respected. This results in every session getting deleted every minute when the `@Scheduled` task is run.\r\n\r\nI have modified the `cleanUpExpiredSessions` function to *only* clean up sessions that have been inactive for longer than the threshold time, and added an integration test to verify this."},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-session/issues/comments/195217441","html_url":"https://github.com/spring-projects/spring-session/pull/421#issuecomment-195217441","issue_url":"https://api.github.com/repos/spring-projects/spring-session/issues/421","id":195217441,"user":{"login":"vpavic","id":1149230,"avatar_url":"https://avatars.githubusercontent.com/u/1149230?v=3","gravatar_id":"","url":"https://api.github.com/users/vpavic","html_url":"https://github.com/vpavic","followers_url":"https://api.github.com/users/vpavic/followers","following_url":"https://api.github.com/users/vpavic/following{/other_user}","gists_url":"https://api.github.com/users/vpavic/gists{/gist_id}","starred_url":"https://api.github.com/users/vpavic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpavic/subscriptions","organizations_url":"https://api.github.com/users/vpavic/orgs","repos_url":"https://api.github.com/users/vpavic/repos","events_url":"https://api.github.com/users/vpavic/events{/privacy}","received_events_url":"https://api.github.com/users/vpavic/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T06:38:06Z","updated_at":"2016-03-11T06:38:06Z","body":"@erindru thanks for testing the JDBC repository and pointing this out!\r\nNot sure how I managed to disregard the inactivity interval during initial implementation."}}