{"action":"closed","number":1860,"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1860","id":98446668,"html_url":"https://github.com/NLog/NLog/pull/1860","diff_url":"https://github.com/NLog/NLog/pull/1860.diff","patch_url":"https://github.com/NLog/NLog/pull/1860.patch","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1860","number":1860,"state":"closed","locked":false,"title":"FileAppenderCache implements IDisposable","user":{"login":"ie-zero","id":7550062,"avatar_url":"https://avatars.githubusercontent.com/u/7550062?v=3","gravatar_id":"","url":"https://api.github.com/users/ie-zero","html_url":"https://github.com/ie-zero","followers_url":"https://api.github.com/users/ie-zero/followers","following_url":"https://api.github.com/users/ie-zero/following{/other_user}","gists_url":"https://api.github.com/users/ie-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/ie-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ie-zero/subscriptions","organizations_url":"https://api.github.com/users/ie-zero/orgs","repos_url":"https://api.github.com/users/ie-zero/repos","events_url":"https://api.github.com/users/ie-zero/events{/privacy}","received_events_url":"https://api.github.com/users/ie-zero/received_events","type":"User","site_admin":false},"body":"IDisposable is implemented by FileAppenderCache class according to Microsoft recommendations \"CA1001: Types that own disposable fields should be disposable\".\r\n\r\nNon-breaking change as the class is internal.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/nlog/nlog/1860)\n<!-- Reviewable:end -->\n","created_at":"2016-12-17T15:21:46Z","updated_at":"2016-12-17T16:28:57Z","closed_at":"2016-12-17T16:28:57Z","merged_at":"2016-12-17T16:28:57Z","merge_commit_sha":"c8c388c221a98ece60717f3baaf9b41461992ec7","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/34","html_url":"https://github.com/NLog/NLog/milestone/34","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/34/labels","id":2166959,"number":34,"title":"4.4.1","description":"","creator":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":3,"state":"open","created_at":"2016-11-30T17:47:50Z","updated_at":"2016-12-17T16:28:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NLog/NLog/pulls/1860/commits","review_comments_url":"https://api.github.com/repos/NLog/NLog/pulls/1860/comments","review_comment_url":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1860/comments","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/5e3933361f397503900883368eb3c3a28f4f7788","head":{"label":"ie-zero:FileAppenderCache_IDisposable","ref":"FileAppenderCache_IDisposable","sha":"5e3933361f397503900883368eb3c3a28f4f7788","user":{"login":"ie-zero","id":7550062,"avatar_url":"https://avatars.githubusercontent.com/u/7550062?v=3","gravatar_id":"","url":"https://api.github.com/users/ie-zero","html_url":"https://github.com/ie-zero","followers_url":"https://api.github.com/users/ie-zero/followers","following_url":"https://api.github.com/users/ie-zero/following{/other_user}","gists_url":"https://api.github.com/users/ie-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/ie-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ie-zero/subscriptions","organizations_url":"https://api.github.com/users/ie-zero/orgs","repos_url":"https://api.github.com/users/ie-zero/repos","events_url":"https://api.github.com/users/ie-zero/events{/privacy}","received_events_url":"https://api.github.com/users/ie-zero/received_events","type":"User","site_admin":false},"repo":{"id":75535413,"name":"NLog","full_name":"ie-zero/NLog","owner":{"login":"ie-zero","id":7550062,"avatar_url":"https://avatars.githubusercontent.com/u/7550062?v=3","gravatar_id":"","url":"https://api.github.com/users/ie-zero","html_url":"https://github.com/ie-zero","followers_url":"https://api.github.com/users/ie-zero/followers","following_url":"https://api.github.com/users/ie-zero/following{/other_user}","gists_url":"https://api.github.com/users/ie-zero/gists{/gist_id}","starred_url":"https://api.github.com/users/ie-zero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ie-zero/subscriptions","organizations_url":"https://api.github.com/users/ie-zero/orgs","repos_url":"https://api.github.com/users/ie-zero/repos","events_url":"https://api.github.com/users/ie-zero/events{/privacy}","received_events_url":"https://api.github.com/users/ie-zero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ie-zero/NLog","description":"[Do not clone - Development Copy] NLog - Advanced .NET, Silverlight and Xamarin Logging","fork":true,"url":"https://api.github.com/repos/ie-zero/NLog","forks_url":"https://api.github.com/repos/ie-zero/NLog/forks","keys_url":"https://api.github.com/repos/ie-zero/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ie-zero/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ie-zero/NLog/teams","hooks_url":"https://api.github.com/repos/ie-zero/NLog/hooks","issue_events_url":"https://api.github.com/repos/ie-zero/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/ie-zero/NLog/events","assignees_url":"https://api.github.com/repos/ie-zero/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/ie-zero/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/ie-zero/NLog/tags","blobs_url":"https://api.github.com/repos/ie-zero/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ie-zero/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ie-zero/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/ie-zero/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ie-zero/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/ie-zero/NLog/languages","stargazers_url":"https://api.github.com/repos/ie-zero/NLog/stargazers","contributors_url":"https://api.github.com/repos/ie-zero/NLog/contributors","subscribers_url":"https://api.github.com/repos/ie-zero/NLog/subscribers","subscription_url":"https://api.github.com/repos/ie-zero/NLog/subscription","commits_url":"https://api.github.com/repos/ie-zero/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/ie-zero/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/ie-zero/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/ie-zero/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/ie-zero/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/ie-zero/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ie-zero/NLog/merges","archive_url":"https://api.github.com/repos/ie-zero/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ie-zero/NLog/downloads","issues_url":"https://api.github.com/repos/ie-zero/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/ie-zero/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/ie-zero/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/ie-zero/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ie-zero/NLog/labels{/name}","releases_url":"https://api.github.com/repos/ie-zero/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/ie-zero/NLog/deployments","created_at":"2016-12-04T12:16:21Z","updated_at":"2016-12-04T12:55:10Z","pushed_at":"2016-12-17T15:20:30Z","git_url":"git://github.com/ie-zero/NLog.git","ssh_url":"git@github.com:ie-zero/NLog.git","clone_url":"https://github.com/ie-zero/NLog.git","svn_url":"https://github.com/ie-zero/NLog","homepage":"http://nlog-project.org","size":102942,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NLog:master","ref":"master","sha":"18dac2fb2696c22b3b27f249cc74fa966998a78b","user":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"repo":{"id":5780416,"name":"NLog","full_name":"NLog/NLog","owner":{"login":"NLog","id":2331628,"avatar_url":"https://avatars.githubusercontent.com/u/2331628?v=3","gravatar_id":"","url":"https://api.github.com/users/NLog","html_url":"https://github.com/NLog","followers_url":"https://api.github.com/users/NLog/followers","following_url":"https://api.github.com/users/NLog/following{/other_user}","gists_url":"https://api.github.com/users/NLog/gists{/gist_id}","starred_url":"https://api.github.com/users/NLog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NLog/subscriptions","organizations_url":"https://api.github.com/users/NLog/orgs","repos_url":"https://api.github.com/users/NLog/repos","events_url":"https://api.github.com/users/NLog/events{/privacy}","received_events_url":"https://api.github.com/users/NLog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NLog/NLog","description":"NLog - Advanced .NET, Silverlight and Xamarin Logging","fork":false,"url":"https://api.github.com/repos/NLog/NLog","forks_url":"https://api.github.com/repos/NLog/NLog/forks","keys_url":"https://api.github.com/repos/NLog/NLog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NLog/NLog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NLog/NLog/teams","hooks_url":"https://api.github.com/repos/NLog/NLog/hooks","issue_events_url":"https://api.github.com/repos/NLog/NLog/issues/events{/number}","events_url":"https://api.github.com/repos/NLog/NLog/events","assignees_url":"https://api.github.com/repos/NLog/NLog/assignees{/user}","branches_url":"https://api.github.com/repos/NLog/NLog/branches{/branch}","tags_url":"https://api.github.com/repos/NLog/NLog/tags","blobs_url":"https://api.github.com/repos/NLog/NLog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NLog/NLog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NLog/NLog/git/refs{/sha}","trees_url":"https://api.github.com/repos/NLog/NLog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NLog/NLog/statuses/{sha}","languages_url":"https://api.github.com/repos/NLog/NLog/languages","stargazers_url":"https://api.github.com/repos/NLog/NLog/stargazers","contributors_url":"https://api.github.com/repos/NLog/NLog/contributors","subscribers_url":"https://api.github.com/repos/NLog/NLog/subscribers","subscription_url":"https://api.github.com/repos/NLog/NLog/subscription","commits_url":"https://api.github.com/repos/NLog/NLog/commits{/sha}","git_commits_url":"https://api.github.com/repos/NLog/NLog/git/commits{/sha}","comments_url":"https://api.github.com/repos/NLog/NLog/comments{/number}","issue_comment_url":"https://api.github.com/repos/NLog/NLog/issues/comments{/number}","contents_url":"https://api.github.com/repos/NLog/NLog/contents/{+path}","compare_url":"https://api.github.com/repos/NLog/NLog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NLog/NLog/merges","archive_url":"https://api.github.com/repos/NLog/NLog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NLog/NLog/downloads","issues_url":"https://api.github.com/repos/NLog/NLog/issues{/number}","pulls_url":"https://api.github.com/repos/NLog/NLog/pulls{/number}","milestones_url":"https://api.github.com/repos/NLog/NLog/milestones{/number}","notifications_url":"https://api.github.com/repos/NLog/NLog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NLog/NLog/labels{/name}","releases_url":"https://api.github.com/repos/NLog/NLog/releases{/id}","deployments_url":"https://api.github.com/repos/NLog/NLog/deployments","created_at":"2012-09-12T13:49:29Z","updated_at":"2016-12-17T07:52:24Z","pushed_at":"2016-12-17T16:28:57Z","git_url":"git://github.com/NLog/NLog.git","ssh_url":"git@github.com:NLog/NLog.git","clone_url":"https://github.com/NLog/NLog.git","svn_url":"https://github.com/NLog/NLog","homepage":"http://nlog-project.org","size":104196,"stargazers_count":2032,"watchers_count":2032,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":706,"mirror_url":null,"open_issues_count":198,"forks":706,"open_issues":198,"watchers":2032,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1860"},"html":{"href":"https://github.com/NLog/NLog/pull/1860"},"issue":{"href":"https://api.github.com/repos/NLog/NLog/issues/1860"},"comments":{"href":"https://api.github.com/repos/NLog/NLog/issues/1860/comments"},"review_comments":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1860/comments"},"review_comment":{"href":"https://api.github.com/repos/NLog/NLog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NLog/NLog/pulls/1860/commits"},"statuses":{"href":"https://api.github.com/repos/NLog/NLog/statuses/5e3933361f397503900883368eb3c3a28f4f7788"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":8,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"304NotModified"}}