{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/routing/issues/1106","repository_url":"https://api.github.com/repos/maidsafe/routing","labels_url":"https://api.github.com/repos/maidsafe/routing/issues/1106/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1106/comments","events_url":"https://api.github.com/repos/maidsafe/routing/issues/1106/events","html_url":"https://github.com/maidsafe/routing/pull/1106","id":167809206,"number":1106,"title":"refactor/states: merge JoiningNode and Node states","user":{"login":"madadam","id":5271,"avatar_url":"https://avatars.githubusercontent.com/u/5271?v=3","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"assignees":[{"login":"afck","id":7894725,"avatar_url":"https://avatars.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-07-27T09:23:37Z","updated_at":"2016-07-27T11:34:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1106","html_url":"https://github.com/maidsafe/routing/pull/1106","diff_url":"https://github.com/maidsafe/routing/pull/1106.diff","patch_url":"https://github.com/maidsafe/routing/pull/1106.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/maidsafe/routing/1106)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/routing/issues/comments/235559994","html_url":"https://github.com/maidsafe/routing/pull/1106#issuecomment-235559994","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1106","id":235559994,"user":{"login":"madadam","id":5271,"avatar_url":"https://avatars.githubusercontent.com/u/5271?v=3","gravatar_id":"","url":"https://api.github.com/users/madadam","html_url":"https://github.com/madadam","followers_url":"https://api.github.com/users/madadam/followers","following_url":"https://api.github.com/users/madadam/following{/other_user}","gists_url":"https://api.github.com/users/madadam/gists{/gist_id}","starred_url":"https://api.github.com/users/madadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madadam/subscriptions","organizations_url":"https://api.github.com/users/madadam/orgs","repos_url":"https://api.github.com/users/madadam/repos","events_url":"https://api.github.com/users/madadam/events{/privacy}","received_events_url":"https://api.github.com/users/madadam/received_events","type":"User","site_admin":false},"created_at":"2016-07-27T11:34:42Z","updated_at":"2016-07-27T11:34:42Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/states/node.rs, line 1814 \\[r1\\]](https://reviewable.io:443/reviews/maidsafe/routing/1106#-KNg2YU8_x0hK-X7FcqA:-KNg73ojXk2pyBGXLQE6:-233772088) ([raw file](https://github.com/maidsafe/routing/blob/82c622999961beef998a5051d0c69276ea5299d5/src/states/node.rs#L1814)):*\n<details><summary><i>Previously, afck (Andreas Fackler) wrote…</i></summary>\n> You could just `||` these two conditions and get rid of the local `result` variable.\n</details>\nI can't, because that would short-circuit the evaluation. I need both methods to be always called, no matter what they return. There might be a cleaner way to express this though...\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/maidsafe/routing/1106)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"madadam"}}