{"action":"created","comment":{"url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/comments/83716586","pull_request_review_id":4542285,"id":83716586,"diff_hunk":"@@ -16,6 +16,7 @@\n   ],\n   \"require\": {\n     \"php\": \"^5.6 || ^7.0\",\n+    \"laravel/framework\": \"5.1.* || 5.2.* || 5.3.*\",","path":"composer.json","position":4,"original_position":4,"commit_id":"ce8e265e58987ab875479fb5e42eda9266cb6023","original_commit_id":"ce8e265e58987ab875479fb5e42eda9266cb6023","user":{"login":"cviebrock","id":166810,"avatar_url":"https://avatars.githubusercontent.com/u/166810?v=3","gravatar_id":"","url":"https://api.github.com/users/cviebrock","html_url":"https://github.com/cviebrock","followers_url":"https://api.github.com/users/cviebrock/followers","following_url":"https://api.github.com/users/cviebrock/following{/other_user}","gists_url":"https://api.github.com/users/cviebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/cviebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cviebrock/subscriptions","organizations_url":"https://api.github.com/users/cviebrock/orgs","repos_url":"https://api.github.com/users/cviebrock/repos","events_url":"https://api.github.com/users/cviebrock/events{/privacy}","received_events_url":"https://api.github.com/users/cviebrock/received_events","type":"User","site_admin":false},"body":"If we require this, we probably don't need to require the `illuminate/*` packages as well, do we?\r\n\r\nAlso, does this break support in Lumen?","created_at":"2016-10-17T19:33:44Z","updated_at":"2016-10-17T19:33:44Z","html_url":"https://github.com/cviebrock/eloquent-sluggable/pull/322#discussion_r83716586","pull_request_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322","_links":{"self":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/comments/83716586"},"html":{"href":"https://github.com/cviebrock/eloquent-sluggable/pull/322#discussion_r83716586"},"pull_request":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322","id":89686588,"html_url":"https://github.com/cviebrock/eloquent-sluggable/pull/322","diff_url":"https://github.com/cviebrock/eloquent-sluggable/pull/322.diff","patch_url":"https://github.com/cviebrock/eloquent-sluggable/pull/322.patch","issue_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/322","number":322,"state":"open","locked":false,"title":"Make \"SlugService\" overridable by binding it to the container","user":{"login":"qodeboy","id":543453,"avatar_url":"https://avatars.githubusercontent.com/u/543453?v=3","gravatar_id":"","url":"https://api.github.com/users/qodeboy","html_url":"https://github.com/qodeboy","followers_url":"https://api.github.com/users/qodeboy/followers","following_url":"https://api.github.com/users/qodeboy/following{/other_user}","gists_url":"https://api.github.com/users/qodeboy/gists{/gist_id}","starred_url":"https://api.github.com/users/qodeboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qodeboy/subscriptions","organizations_url":"https://api.github.com/users/qodeboy/orgs","repos_url":"https://api.github.com/users/qodeboy/repos","events_url":"https://api.github.com/users/qodeboy/events{/privacy}","received_events_url":"https://api.github.com/users/qodeboy/received_events","type":"User","site_admin":false},"body":"As mentioned in #320 we need a way to override ```SlugService``` implementation to work out cross-model slugs.\r\n\r\nChanges outline:\r\n- Add ```laravel/framework``` as dependency. Not sure it is needed, but ```app()``` helper is now used across code base.\r\n- Create ```SlugContract``` interface.\r\n- Make ```SlugService``` implement it.\r\n- Change all code which used ```SlugService``` directly to either ```SlugContract``` typehint or ```app(SlugContract::class)``` call.","created_at":"2016-10-17T19:29:09Z","updated_at":"2016-10-17T19:33:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e83d92e12069277b1349b249f7d3de2a10da54c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322/commits","review_comments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322/comments","review_comment_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/322/comments","statuses_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/statuses/ce8e265e58987ab875479fb5e42eda9266cb6023","head":{"label":"qodeboy:bind-slug-service-to-container","ref":"bind-slug-service-to-container","sha":"ce8e265e58987ab875479fb5e42eda9266cb6023","user":{"login":"qodeboy","id":543453,"avatar_url":"https://avatars.githubusercontent.com/u/543453?v=3","gravatar_id":"","url":"https://api.github.com/users/qodeboy","html_url":"https://github.com/qodeboy","followers_url":"https://api.github.com/users/qodeboy/followers","following_url":"https://api.github.com/users/qodeboy/following{/other_user}","gists_url":"https://api.github.com/users/qodeboy/gists{/gist_id}","starred_url":"https://api.github.com/users/qodeboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qodeboy/subscriptions","organizations_url":"https://api.github.com/users/qodeboy/orgs","repos_url":"https://api.github.com/users/qodeboy/repos","events_url":"https://api.github.com/users/qodeboy/events{/privacy}","received_events_url":"https://api.github.com/users/qodeboy/received_events","type":"User","site_admin":false},"repo":{"id":71147485,"name":"eloquent-sluggable","full_name":"qodeboy/eloquent-sluggable","owner":{"login":"qodeboy","id":543453,"avatar_url":"https://avatars.githubusercontent.com/u/543453?v=3","gravatar_id":"","url":"https://api.github.com/users/qodeboy","html_url":"https://github.com/qodeboy","followers_url":"https://api.github.com/users/qodeboy/followers","following_url":"https://api.github.com/users/qodeboy/following{/other_user}","gists_url":"https://api.github.com/users/qodeboy/gists{/gist_id}","starred_url":"https://api.github.com/users/qodeboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qodeboy/subscriptions","organizations_url":"https://api.github.com/users/qodeboy/orgs","repos_url":"https://api.github.com/users/qodeboy/repos","events_url":"https://api.github.com/users/qodeboy/events{/privacy}","received_events_url":"https://api.github.com/users/qodeboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qodeboy/eloquent-sluggable","description":"Easy creation of slugs for your Eloquent models in Laravel","fork":true,"url":"https://api.github.com/repos/qodeboy/eloquent-sluggable","forks_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/forks","keys_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/teams","hooks_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/hooks","issue_events_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/issues/events{/number}","events_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/events","assignees_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/assignees{/user}","branches_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/branches{/branch}","tags_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/tags","blobs_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/git/refs{/sha}","trees_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/statuses/{sha}","languages_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/languages","stargazers_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/stargazers","contributors_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/contributors","subscribers_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/subscribers","subscription_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/subscription","commits_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/commits{/sha}","git_commits_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/git/commits{/sha}","comments_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/comments{/number}","issue_comment_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/issues/comments{/number}","contents_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/contents/{+path}","compare_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/merges","archive_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/downloads","issues_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/issues{/number}","pulls_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/pulls{/number}","milestones_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/milestones{/number}","notifications_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/labels{/name}","releases_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/releases{/id}","deployments_url":"https://api.github.com/repos/qodeboy/eloquent-sluggable/deployments","created_at":"2016-10-17T14:33:25Z","updated_at":"2016-10-17T14:33:26Z","pushed_at":"2016-10-17T19:31:03Z","git_url":"git://github.com/qodeboy/eloquent-sluggable.git","ssh_url":"git@github.com:qodeboy/eloquent-sluggable.git","clone_url":"https://github.com/qodeboy/eloquent-sluggable.git","svn_url":"https://github.com/qodeboy/eloquent-sluggable","homepage":"","size":443,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cviebrock:master","ref":"master","sha":"1832f0427f1aaf1c83a0d39df3da2b5602a3096f","user":{"login":"cviebrock","id":166810,"avatar_url":"https://avatars.githubusercontent.com/u/166810?v=3","gravatar_id":"","url":"https://api.github.com/users/cviebrock","html_url":"https://github.com/cviebrock","followers_url":"https://api.github.com/users/cviebrock/followers","following_url":"https://api.github.com/users/cviebrock/following{/other_user}","gists_url":"https://api.github.com/users/cviebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/cviebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cviebrock/subscriptions","organizations_url":"https://api.github.com/users/cviebrock/orgs","repos_url":"https://api.github.com/users/cviebrock/repos","events_url":"https://api.github.com/users/cviebrock/events{/privacy}","received_events_url":"https://api.github.com/users/cviebrock/received_events","type":"User","site_admin":false},"repo":{"id":10513456,"name":"eloquent-sluggable","full_name":"cviebrock/eloquent-sluggable","owner":{"login":"cviebrock","id":166810,"avatar_url":"https://avatars.githubusercontent.com/u/166810?v=3","gravatar_id":"","url":"https://api.github.com/users/cviebrock","html_url":"https://github.com/cviebrock","followers_url":"https://api.github.com/users/cviebrock/followers","following_url":"https://api.github.com/users/cviebrock/following{/other_user}","gists_url":"https://api.github.com/users/cviebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/cviebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cviebrock/subscriptions","organizations_url":"https://api.github.com/users/cviebrock/orgs","repos_url":"https://api.github.com/users/cviebrock/repos","events_url":"https://api.github.com/users/cviebrock/events{/privacy}","received_events_url":"https://api.github.com/users/cviebrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cviebrock/eloquent-sluggable","description":"Easy creation of slugs for your Eloquent models in Laravel","fork":false,"url":"https://api.github.com/repos/cviebrock/eloquent-sluggable","forks_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/forks","keys_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/teams","hooks_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/hooks","issue_events_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/events{/number}","events_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/events","assignees_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/assignees{/user}","branches_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/branches{/branch}","tags_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/tags","blobs_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/refs{/sha}","trees_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/statuses/{sha}","languages_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/languages","stargazers_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/stargazers","contributors_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/contributors","subscribers_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/subscribers","subscription_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/subscription","commits_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/commits{/sha}","git_commits_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/git/commits{/sha}","comments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/comments{/number}","issue_comment_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/comments{/number}","contents_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/contents/{+path}","compare_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/merges","archive_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/downloads","issues_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues{/number}","pulls_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls{/number}","milestones_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/milestones{/number}","notifications_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/labels{/name}","releases_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/releases{/id}","deployments_url":"https://api.github.com/repos/cviebrock/eloquent-sluggable/deployments","created_at":"2013-06-05T21:42:39Z","updated_at":"2016-10-17T17:13:50Z","pushed_at":"2016-10-17T19:31:03Z","git_url":"git://github.com/cviebrock/eloquent-sluggable.git","ssh_url":"git@github.com:cviebrock/eloquent-sluggable.git","clone_url":"https://github.com/cviebrock/eloquent-sluggable.git","svn_url":"https://github.com/cviebrock/eloquent-sluggable","homepage":"","size":620,"stargazers_count":1285,"watchers_count":1285,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":3,"forks":203,"open_issues":3,"watchers":1285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322"},"html":{"href":"https://github.com/cviebrock/eloquent-sluggable/pull/322"},"issue":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/322"},"comments":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/cviebrock/eloquent-sluggable/statuses/ce8e265e58987ab875479fb5e42eda9266cb6023"}}}}
{"actor":{"display_login":"cviebrock"}}