{"action":"created","comment":{"url":"https://api.github.com/repos/gevent/gevent/pulls/comments/60944054","id":60944054,"diff_hunk":"@@ -1,8 +0,0 @@\n-from gevent import monkey","path":"src/greentest/test__threading_holding_lock_while_monkey.py","position":1,"original_position":1,"commit_id":"dbb91f054485239a6a1bafb3c49c58d410991fd2","original_commit_id":"dbb91f054485239a6a1bafb3c49c58d410991fd2","user":{"login":"jamadden","id":1256082,"avatar_url":"https://avatars.githubusercontent.com/u/1256082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamadden","html_url":"https://github.com/jamadden","followers_url":"https://api.github.com/users/jamadden/followers","following_url":"https://api.github.com/users/jamadden/following{/other_user}","gists_url":"https://api.github.com/users/jamadden/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadden/subscriptions","organizations_url":"https://api.github.com/users/jamadden/orgs","repos_url":"https://api.github.com/users/jamadden/repos","events_url":"https://api.github.com/users/jamadden/events{/privacy}","received_events_url":"https://api.github.com/users/jamadden/received_events","type":"User","site_admin":false},"body":"Why was this test removed?","created_at":"2016-04-25T16:30:39Z","updated_at":"2016-04-25T16:30:39Z","html_url":"https://github.com/gevent/gevent/pull/798#discussion_r60944054","pull_request_url":"https://api.github.com/repos/gevent/gevent/pulls/798","_links":{"self":{"href":"https://api.github.com/repos/gevent/gevent/pulls/comments/60944054"},"html":{"href":"https://github.com/gevent/gevent/pull/798#discussion_r60944054"},"pull_request":{"href":"https://api.github.com/repos/gevent/gevent/pulls/798"}}},"pull_request":{"url":"https://api.github.com/repos/gevent/gevent/pulls/798","id":67748704,"html_url":"https://github.com/gevent/gevent/pull/798","diff_url":"https://github.com/gevent/gevent/pull/798.diff","patch_url":"https://github.com/gevent/gevent/pull/798.patch","issue_url":"https://api.github.com/repos/gevent/gevent/issues/798","number":798,"state":"open","locked":false,"title":"Patch existing locks","user":{"login":"lxsli","id":88806,"avatar_url":"https://avatars.githubusercontent.com/u/88806?v=3","gravatar_id":"","url":"https://api.github.com/users/lxsli","html_url":"https://github.com/lxsli","followers_url":"https://api.github.com/users/lxsli/followers","following_url":"https://api.github.com/users/lxsli/following{/other_user}","gists_url":"https://api.github.com/users/lxsli/gists{/gist_id}","starred_url":"https://api.github.com/users/lxsli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxsli/subscriptions","organizations_url":"https://api.github.com/users/lxsli/orgs","repos_url":"https://api.github.com/users/lxsli/repos","events_url":"https://api.github.com/users/lxsli/events{/privacy}","received_events_url":"https://api.github.com/users/lxsli/received_events","type":"User","site_admin":false},"body":"In projects which dynamically determine whether to activate gevent,\r\nit can be hard not to import a low level module like logging before\r\ngevent. When logging is imported it initialises a threading.RLock\r\nwhich it uses to protect the logging configuration. If two\r\ngreenthreads attempt to claim this lock, the second one will block the\r\n/native/ thread not just itself. As green systems usually only have\r\none native thread, this will freeze the whole system.\r\n\r\nWhile searching the GC for unsafe RLocks, replace their internal Lock\r\nwith a safe one. Or on Python3, where the default RLock implementation\r\nis in C, swap the whole RLock out with a safe Python version.","created_at":"2016-04-25T16:26:13Z","updated_at":"2016-04-25T16:30:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2284b54258e61dcfe34dd2351a477081162509c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gevent/gevent/pulls/798/commits","review_comments_url":"https://api.github.com/repos/gevent/gevent/pulls/798/comments","review_comment_url":"https://api.github.com/repos/gevent/gevent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gevent/gevent/issues/798/comments","statuses_url":"https://api.github.com/repos/gevent/gevent/statuses/dbb91f054485239a6a1bafb3c49c58d410991fd2","head":{"label":"lxsli:master","ref":"master","sha":"dbb91f054485239a6a1bafb3c49c58d410991fd2","user":{"login":"lxsli","id":88806,"avatar_url":"https://avatars.githubusercontent.com/u/88806?v=3","gravatar_id":"","url":"https://api.github.com/users/lxsli","html_url":"https://github.com/lxsli","followers_url":"https://api.github.com/users/lxsli/followers","following_url":"https://api.github.com/users/lxsli/following{/other_user}","gists_url":"https://api.github.com/users/lxsli/gists{/gist_id}","starred_url":"https://api.github.com/users/lxsli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxsli/subscriptions","organizations_url":"https://api.github.com/users/lxsli/orgs","repos_url":"https://api.github.com/users/lxsli/repos","events_url":"https://api.github.com/users/lxsli/events{/privacy}","received_events_url":"https://api.github.com/users/lxsli/received_events","type":"User","site_admin":false},"repo":{"id":55703488,"name":"gevent","full_name":"lxsli/gevent","owner":{"login":"lxsli","id":88806,"avatar_url":"https://avatars.githubusercontent.com/u/88806?v=3","gravatar_id":"","url":"https://api.github.com/users/lxsli","html_url":"https://github.com/lxsli","followers_url":"https://api.github.com/users/lxsli/followers","following_url":"https://api.github.com/users/lxsli/following{/other_user}","gists_url":"https://api.github.com/users/lxsli/gists{/gist_id}","starred_url":"https://api.github.com/users/lxsli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxsli/subscriptions","organizations_url":"https://api.github.com/users/lxsli/orgs","repos_url":"https://api.github.com/users/lxsli/repos","events_url":"https://api.github.com/users/lxsli/events{/privacy}","received_events_url":"https://api.github.com/users/lxsli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lxsli/gevent","description":"Coroutine-based concurrency library for Python","fork":true,"url":"https://api.github.com/repos/lxsli/gevent","forks_url":"https://api.github.com/repos/lxsli/gevent/forks","keys_url":"https://api.github.com/repos/lxsli/gevent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxsli/gevent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxsli/gevent/teams","hooks_url":"https://api.github.com/repos/lxsli/gevent/hooks","issue_events_url":"https://api.github.com/repos/lxsli/gevent/issues/events{/number}","events_url":"https://api.github.com/repos/lxsli/gevent/events","assignees_url":"https://api.github.com/repos/lxsli/gevent/assignees{/user}","branches_url":"https://api.github.com/repos/lxsli/gevent/branches{/branch}","tags_url":"https://api.github.com/repos/lxsli/gevent/tags","blobs_url":"https://api.github.com/repos/lxsli/gevent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxsli/gevent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxsli/gevent/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxsli/gevent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxsli/gevent/statuses/{sha}","languages_url":"https://api.github.com/repos/lxsli/gevent/languages","stargazers_url":"https://api.github.com/repos/lxsli/gevent/stargazers","contributors_url":"https://api.github.com/repos/lxsli/gevent/contributors","subscribers_url":"https://api.github.com/repos/lxsli/gevent/subscribers","subscription_url":"https://api.github.com/repos/lxsli/gevent/subscription","commits_url":"https://api.github.com/repos/lxsli/gevent/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxsli/gevent/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxsli/gevent/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxsli/gevent/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxsli/gevent/contents/{+path}","compare_url":"https://api.github.com/repos/lxsli/gevent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxsli/gevent/merges","archive_url":"https://api.github.com/repos/lxsli/gevent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxsli/gevent/downloads","issues_url":"https://api.github.com/repos/lxsli/gevent/issues{/number}","pulls_url":"https://api.github.com/repos/lxsli/gevent/pulls{/number}","milestones_url":"https://api.github.com/repos/lxsli/gevent/milestones{/number}","notifications_url":"https://api.github.com/repos/lxsli/gevent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxsli/gevent/labels{/name}","releases_url":"https://api.github.com/repos/lxsli/gevent/releases{/id}","deployments_url":"https://api.github.com/repos/lxsli/gevent/deployments","created_at":"2016-04-07T14:56:24Z","updated_at":"2016-04-07T14:56:29Z","pushed_at":"2016-04-25T16:25:44Z","git_url":"git://github.com/lxsli/gevent.git","ssh_url":"git@github.com:lxsli/gevent.git","clone_url":"https://github.com/lxsli/gevent.git","svn_url":"https://github.com/lxsli/gevent","homepage":"http://gevent.org","size":9316,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gevent:master","ref":"master","sha":"93e4352a8de3c1fb4702cd581b735b8e27dac4fb","user":{"login":"gevent","id":5564530,"avatar_url":"https://avatars.githubusercontent.com/u/5564530?v=3","gravatar_id":"","url":"https://api.github.com/users/gevent","html_url":"https://github.com/gevent","followers_url":"https://api.github.com/users/gevent/followers","following_url":"https://api.github.com/users/gevent/following{/other_user}","gists_url":"https://api.github.com/users/gevent/gists{/gist_id}","starred_url":"https://api.github.com/users/gevent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gevent/subscriptions","organizations_url":"https://api.github.com/users/gevent/orgs","repos_url":"https://api.github.com/users/gevent/repos","events_url":"https://api.github.com/users/gevent/events{/privacy}","received_events_url":"https://api.github.com/users/gevent/received_events","type":"Organization","site_admin":false},"repo":{"id":5801666,"name":"gevent","full_name":"gevent/gevent","owner":{"login":"gevent","id":5564530,"avatar_url":"https://avatars.githubusercontent.com/u/5564530?v=3","gravatar_id":"","url":"https://api.github.com/users/gevent","html_url":"https://github.com/gevent","followers_url":"https://api.github.com/users/gevent/followers","following_url":"https://api.github.com/users/gevent/following{/other_user}","gists_url":"https://api.github.com/users/gevent/gists{/gist_id}","starred_url":"https://api.github.com/users/gevent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gevent/subscriptions","organizations_url":"https://api.github.com/users/gevent/orgs","repos_url":"https://api.github.com/users/gevent/repos","events_url":"https://api.github.com/users/gevent/events{/privacy}","received_events_url":"https://api.github.com/users/gevent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gevent/gevent","description":"Coroutine-based concurrency library for Python","fork":false,"url":"https://api.github.com/repos/gevent/gevent","forks_url":"https://api.github.com/repos/gevent/gevent/forks","keys_url":"https://api.github.com/repos/gevent/gevent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gevent/gevent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gevent/gevent/teams","hooks_url":"https://api.github.com/repos/gevent/gevent/hooks","issue_events_url":"https://api.github.com/repos/gevent/gevent/issues/events{/number}","events_url":"https://api.github.com/repos/gevent/gevent/events","assignees_url":"https://api.github.com/repos/gevent/gevent/assignees{/user}","branches_url":"https://api.github.com/repos/gevent/gevent/branches{/branch}","tags_url":"https://api.github.com/repos/gevent/gevent/tags","blobs_url":"https://api.github.com/repos/gevent/gevent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gevent/gevent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gevent/gevent/git/refs{/sha}","trees_url":"https://api.github.com/repos/gevent/gevent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gevent/gevent/statuses/{sha}","languages_url":"https://api.github.com/repos/gevent/gevent/languages","stargazers_url":"https://api.github.com/repos/gevent/gevent/stargazers","contributors_url":"https://api.github.com/repos/gevent/gevent/contributors","subscribers_url":"https://api.github.com/repos/gevent/gevent/subscribers","subscription_url":"https://api.github.com/repos/gevent/gevent/subscription","commits_url":"https://api.github.com/repos/gevent/gevent/commits{/sha}","git_commits_url":"https://api.github.com/repos/gevent/gevent/git/commits{/sha}","comments_url":"https://api.github.com/repos/gevent/gevent/comments{/number}","issue_comment_url":"https://api.github.com/repos/gevent/gevent/issues/comments{/number}","contents_url":"https://api.github.com/repos/gevent/gevent/contents/{+path}","compare_url":"https://api.github.com/repos/gevent/gevent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gevent/gevent/merges","archive_url":"https://api.github.com/repos/gevent/gevent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gevent/gevent/downloads","issues_url":"https://api.github.com/repos/gevent/gevent/issues{/number}","pulls_url":"https://api.github.com/repos/gevent/gevent/pulls{/number}","milestones_url":"https://api.github.com/repos/gevent/gevent/milestones{/number}","notifications_url":"https://api.github.com/repos/gevent/gevent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gevent/gevent/labels{/name}","releases_url":"https://api.github.com/repos/gevent/gevent/releases{/id}","deployments_url":"https://api.github.com/repos/gevent/gevent/deployments","created_at":"2012-09-13T22:03:03Z","updated_at":"2016-04-25T12:58:52Z","pushed_at":"2016-04-25T16:26:13Z","git_url":"git://github.com/gevent/gevent.git","ssh_url":"git@github.com:gevent/gevent.git","clone_url":"https://github.com/gevent/gevent.git","svn_url":"https://github.com/gevent/gevent","homepage":"http://gevent.org","size":13949,"stargazers_count":2705,"watchers_count":2705,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":577,"mirror_url":null,"open_issues_count":38,"forks":577,"open_issues":38,"watchers":2705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gevent/gevent/pulls/798"},"html":{"href":"https://github.com/gevent/gevent/pull/798"},"issue":{"href":"https://api.github.com/repos/gevent/gevent/issues/798"},"comments":{"href":"https://api.github.com/repos/gevent/gevent/issues/798/comments"},"review_comments":{"href":"https://api.github.com/repos/gevent/gevent/pulls/798/comments"},"review_comment":{"href":"https://api.github.com/repos/gevent/gevent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gevent/gevent/pulls/798/commits"},"statuses":{"href":"https://api.github.com/repos/gevent/gevent/statuses/dbb91f054485239a6a1bafb3c49c58d410991fd2"}}}}