{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/comments/92359028","pull_request_review_id":12871530,"id":92359028,"diff_hunk":"@@ -21,40 +21,51 @@\n \n import com.google.common.base.Preconditions;\n import com.intellij.openapi.module.Module;\n+import com.intellij.openapi.project.Project;\n import com.intellij.openapi.vfs.VirtualFile;\n import java.util.Collection;\n import java.util.Collections;\n+import java.util.HashMap;\n import java.util.HashSet;\n+import java.util.Map;\n import java.util.Set;\n+import java.util.stream.Collectors;\n+import java.util.stream.Stream;\n import javax.annotation.CheckForNull;\n import javax.annotation.Nullable;\n import org.sonarlint.intellij.trigger.TriggerType;\n \n public class SonarLintJob {\n-  private final Module m;\n-  private final Set<VirtualFile> files;\n+  private final Map<Module, Collection<VirtualFile>> files;\n   private final TriggerType trigger;\n   private final long creationTime;\n   @Nullable private final AnalysisCallback callback;\n \n-  SonarLintJob(Module m, Collection<VirtualFile> files, TriggerType trigger) {\n-    this(m, files, trigger, null);\n+  SonarLintJob(Module module, Collection<VirtualFile> files, TriggerType trigger) {\n+    this(Collections.singletonMap(module, files), trigger, null);\n   }\n \n-  SonarLintJob(Module m, Collection<VirtualFile> files, TriggerType trigger, @Nullable AnalysisCallback callback) {\n+  SonarLintJob(Map<Module, Collection<VirtualFile>> files, TriggerType trigger) {\n+    this(files, trigger, null);\n+  }\n+\n+  SonarLintJob(Map<Module, Collection<VirtualFile>> files, TriggerType trigger, @Nullable AnalysisCallback callback) {\n     this.callback = callback;\n-    Preconditions.checkNotNull(m);\n+    Preconditions.checkNotNull(files);\n     Preconditions.checkNotNull(trigger);\n-    Preconditions.checkArgument(!files.isEmpty(), \"List of files is empty\");\n+    Preconditions.checkArgument(!files.isEmpty(), \"List of filesPerModule is empty\");","path":"src/main/java/org/sonarlint/intellij/analysis/SonarLintJob.java","position":43,"original_position":43,"commit_id":"cc61d37c1f0152eaed7eb035d90b31c2ff56d5d5","original_commit_id":"cc61d37c1f0152eaed7eb035d90b31c2ff56d5d5","user":{"login":"janos-ss","id":21700885,"avatar_url":"https://avatars.githubusercontent.com/u/21700885?v=3","gravatar_id":"","url":"https://api.github.com/users/janos-ss","html_url":"https://github.com/janos-ss","followers_url":"https://api.github.com/users/janos-ss/followers","following_url":"https://api.github.com/users/janos-ss/following{/other_user}","gists_url":"https://api.github.com/users/janos-ss/gists{/gist_id}","starred_url":"https://api.github.com/users/janos-ss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janos-ss/subscriptions","organizations_url":"https://api.github.com/users/janos-ss/orgs","repos_url":"https://api.github.com/users/janos-ss/repos","events_url":"https://api.github.com/users/janos-ss/events{/privacy}","received_events_url":"https://api.github.com/users/janos-ss/received_events","type":"User","site_admin":false},"body":"unintended replace?","created_at":"2016-12-14T10:01:07Z","updated_at":"2016-12-14T10:01:07Z","html_url":"https://github.com/SonarSource/sonarlint-intellij/pull/86#discussion_r92359028","pull_request_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/comments/92359028"},"html":{"href":"https://github.com/SonarSource/sonarlint-intellij/pull/86#discussion_r92359028"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86","id":97919705,"html_url":"https://github.com/SonarSource/sonarlint-intellij/pull/86","diff_url":"https://github.com/SonarSource/sonarlint-intellij/pull/86.diff","patch_url":"https://github.com/SonarSource/sonarlint-intellij/pull/86.patch","issue_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/86","number":86,"state":"open","locked":false,"title":"Fix multi-module analysis","user":{"login":"dbmeneses","id":12492673,"avatar_url":"https://avatars.githubusercontent.com/u/12492673?v=3","gravatar_id":"","url":"https://api.github.com/users/dbmeneses","html_url":"https://github.com/dbmeneses","followers_url":"https://api.github.com/users/dbmeneses/followers","following_url":"https://api.github.com/users/dbmeneses/following{/other_user}","gists_url":"https://api.github.com/users/dbmeneses/gists{/gist_id}","starred_url":"https://api.github.com/users/dbmeneses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbmeneses/subscriptions","organizations_url":"https://api.github.com/users/dbmeneses/orgs","repos_url":"https://api.github.com/users/dbmeneses/repos","events_url":"https://api.github.com/users/dbmeneses/events{/privacy}","received_events_url":"https://api.github.com/users/dbmeneses/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-14T09:57:18Z","updated_at":"2016-12-14T10:01:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0410708e6434dc0896d1f51efd7da6e8141bfc3b","assignee":{"login":"dbmeneses","id":12492673,"avatar_url":"https://avatars.githubusercontent.com/u/12492673?v=3","gravatar_id":"","url":"https://api.github.com/users/dbmeneses","html_url":"https://github.com/dbmeneses","followers_url":"https://api.github.com/users/dbmeneses/followers","following_url":"https://api.github.com/users/dbmeneses/following{/other_user}","gists_url":"https://api.github.com/users/dbmeneses/gists{/gist_id}","starred_url":"https://api.github.com/users/dbmeneses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbmeneses/subscriptions","organizations_url":"https://api.github.com/users/dbmeneses/orgs","repos_url":"https://api.github.com/users/dbmeneses/repos","events_url":"https://api.github.com/users/dbmeneses/events{/privacy}","received_events_url":"https://api.github.com/users/dbmeneses/received_events","type":"User","site_admin":false},"assignees":[{"login":"dbmeneses","id":12492673,"avatar_url":"https://avatars.githubusercontent.com/u/12492673?v=3","gravatar_id":"","url":"https://api.github.com/users/dbmeneses","html_url":"https://github.com/dbmeneses","followers_url":"https://api.github.com/users/dbmeneses/followers","following_url":"https://api.github.com/users/dbmeneses/following{/other_user}","gists_url":"https://api.github.com/users/dbmeneses/gists{/gist_id}","starred_url":"https://api.github.com/users/dbmeneses/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbmeneses/subscriptions","organizations_url":"https://api.github.com/users/dbmeneses/orgs","repos_url":"https://api.github.com/users/dbmeneses/repos","events_url":"https://api.github.com/users/dbmeneses/events{/privacy}","received_events_url":"https://api.github.com/users/dbmeneses/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/86/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/statuses/cc61d37c1f0152eaed7eb035d90b31c2ff56d5d5","head":{"label":"SonarSource:multi_module_analysis","ref":"multi_module_analysis","sha":"cc61d37c1f0152eaed7eb035d90b31c2ff56d5d5","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":13929787,"name":"sonarlint-intellij","full_name":"SonarSource/sonarlint-intellij","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonarlint-intellij","description":"IntelliJ IDEA Plugin","fork":false,"url":"https://api.github.com/repos/SonarSource/sonarlint-intellij","forks_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/forks","keys_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/events","assignees_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/merges","archive_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/deployments","created_at":"2013-10-28T15:27:56Z","updated_at":"2016-12-13T18:02:47Z","pushed_at":"2016-12-14T09:57:18Z","git_url":"git://github.com/SonarSource/sonarlint-intellij.git","ssh_url":"git@github.com:SonarSource/sonarlint-intellij.git","clone_url":"https://github.com/SonarSource/sonarlint-intellij.git","svn_url":"https://github.com/SonarSource/sonarlint-intellij","homepage":"https://plugins.jetbrains.com/plugin/4971","size":19357,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":1,"forks":29,"open_issues":1,"watchers":116,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"62e3093c6f4cee04012273409ebe3e34205715d5","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":13929787,"name":"sonarlint-intellij","full_name":"SonarSource/sonarlint-intellij","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonarlint-intellij","description":"IntelliJ IDEA Plugin","fork":false,"url":"https://api.github.com/repos/SonarSource/sonarlint-intellij","forks_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/forks","keys_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/events","assignees_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/merges","archive_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonarlint-intellij/deployments","created_at":"2013-10-28T15:27:56Z","updated_at":"2016-12-13T18:02:47Z","pushed_at":"2016-12-14T09:57:18Z","git_url":"git://github.com/SonarSource/sonarlint-intellij.git","ssh_url":"git@github.com:SonarSource/sonarlint-intellij.git","clone_url":"https://github.com/SonarSource/sonarlint-intellij.git","svn_url":"https://github.com/SonarSource/sonarlint-intellij","homepage":"https://plugins.jetbrains.com/plugin/4971","size":19357,"stargazers_count":116,"watchers_count":116,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":1,"forks":29,"open_issues":1,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86"},"html":{"href":"https://github.com/SonarSource/sonarlint-intellij/pull/86"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/86"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonarlint-intellij/statuses/cc61d37c1f0152eaed7eb035d90b31c2ff56d5d5"}}}}
{"actor":{"display_login":"janos-ss"}}