{"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/kislyuk/signxml/pulls/46","id":63947591,"html_url":"https://github.com/kislyuk/signxml/pull/46","diff_url":"https://github.com/kislyuk/signxml/pull/46.diff","patch_url":"https://github.com/kislyuk/signxml/pull/46.patch","issue_url":"https://api.github.com/repos/kislyuk/signxml/issues/46","number":46,"state":"closed","locked":false,"title":"Remove signature nodes appropriately","user":{"login":"klondi","id":2823369,"avatar_url":"https://avatars.githubusercontent.com/u/2823369?v=3","gravatar_id":"","url":"https://api.github.com/users/klondi","html_url":"https://github.com/klondi","followers_url":"https://api.github.com/users/klondi/followers","following_url":"https://api.github.com/users/klondi/following{/other_user}","gists_url":"https://api.github.com/users/klondi/gists{/gist_id}","starred_url":"https://api.github.com/users/klondi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klondi/subscriptions","organizations_url":"https://api.github.com/users/klondi/orgs","repos_url":"https://api.github.com/users/klondi/repos","events_url":"https://api.github.com/users/klondi/events{/privacy}","received_events_url":"https://api.github.com/users/klondi/received_events","type":"User","site_admin":false},"body":"This solves the issue with double signatures in XML. Removal is also done so that any text after the signature is preserved.\r\n\r\nI found this issue when trying to validate SAML 2.0 responses with a signature on both the assertion and the node signed with the library.\r\n\r\nThis should at least solve #40 but it may solve others like #44","created_at":"2016-03-23T20:29:13Z","updated_at":"2016-03-24T15:03:45Z","closed_at":"2016-03-24T15:03:45Z","merged_at":"2016-03-24T15:03:45Z","merge_commit_sha":"6c0c801f4b75e8722e7e1f646aef696f36af2a5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kislyuk/signxml/pulls/46/commits","review_comments_url":"https://api.github.com/repos/kislyuk/signxml/pulls/46/comments","review_comment_url":"https://api.github.com/repos/kislyuk/signxml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kislyuk/signxml/issues/46/comments","statuses_url":"https://api.github.com/repos/kislyuk/signxml/statuses/3de87c2243c8de2ea46baf75d7b4a2c714f16fc9","head":{"label":"CoresecSystems:master","ref":"master","sha":"3de87c2243c8de2ea46baf75d7b4a2c714f16fc9","user":{"login":"CoresecSystems","id":14996323,"avatar_url":"https://avatars.githubusercontent.com/u/14996323?v=3","gravatar_id":"","url":"https://api.github.com/users/CoresecSystems","html_url":"https://github.com/CoresecSystems","followers_url":"https://api.github.com/users/CoresecSystems/followers","following_url":"https://api.github.com/users/CoresecSystems/following{/other_user}","gists_url":"https://api.github.com/users/CoresecSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/CoresecSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoresecSystems/subscriptions","organizations_url":"https://api.github.com/users/CoresecSystems/orgs","repos_url":"https://api.github.com/users/CoresecSystems/repos","events_url":"https://api.github.com/users/CoresecSystems/events{/privacy}","received_events_url":"https://api.github.com/users/CoresecSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":54589899,"name":"signxml","full_name":"CoresecSystems/signxml","owner":{"login":"CoresecSystems","id":14996323,"avatar_url":"https://avatars.githubusercontent.com/u/14996323?v=3","gravatar_id":"","url":"https://api.github.com/users/CoresecSystems","html_url":"https://github.com/CoresecSystems","followers_url":"https://api.github.com/users/CoresecSystems/followers","following_url":"https://api.github.com/users/CoresecSystems/following{/other_user}","gists_url":"https://api.github.com/users/CoresecSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/CoresecSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoresecSystems/subscriptions","organizations_url":"https://api.github.com/users/CoresecSystems/orgs","repos_url":"https://api.github.com/users/CoresecSystems/repos","events_url":"https://api.github.com/users/CoresecSystems/events{/privacy}","received_events_url":"https://api.github.com/users/CoresecSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CoresecSystems/signxml","description":"Python XML Signature library","fork":true,"url":"https://api.github.com/repos/CoresecSystems/signxml","forks_url":"https://api.github.com/repos/CoresecSystems/signxml/forks","keys_url":"https://api.github.com/repos/CoresecSystems/signxml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoresecSystems/signxml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoresecSystems/signxml/teams","hooks_url":"https://api.github.com/repos/CoresecSystems/signxml/hooks","issue_events_url":"https://api.github.com/repos/CoresecSystems/signxml/issues/events{/number}","events_url":"https://api.github.com/repos/CoresecSystems/signxml/events","assignees_url":"https://api.github.com/repos/CoresecSystems/signxml/assignees{/user}","branches_url":"https://api.github.com/repos/CoresecSystems/signxml/branches{/branch}","tags_url":"https://api.github.com/repos/CoresecSystems/signxml/tags","blobs_url":"https://api.github.com/repos/CoresecSystems/signxml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoresecSystems/signxml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoresecSystems/signxml/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoresecSystems/signxml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoresecSystems/signxml/statuses/{sha}","languages_url":"https://api.github.com/repos/CoresecSystems/signxml/languages","stargazers_url":"https://api.github.com/repos/CoresecSystems/signxml/stargazers","contributors_url":"https://api.github.com/repos/CoresecSystems/signxml/contributors","subscribers_url":"https://api.github.com/repos/CoresecSystems/signxml/subscribers","subscription_url":"https://api.github.com/repos/CoresecSystems/signxml/subscription","commits_url":"https://api.github.com/repos/CoresecSystems/signxml/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoresecSystems/signxml/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoresecSystems/signxml/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoresecSystems/signxml/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoresecSystems/signxml/contents/{+path}","compare_url":"https://api.github.com/repos/CoresecSystems/signxml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoresecSystems/signxml/merges","archive_url":"https://api.github.com/repos/CoresecSystems/signxml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoresecSystems/signxml/downloads","issues_url":"https://api.github.com/repos/CoresecSystems/signxml/issues{/number}","pulls_url":"https://api.github.com/repos/CoresecSystems/signxml/pulls{/number}","milestones_url":"https://api.github.com/repos/CoresecSystems/signxml/milestones{/number}","notifications_url":"https://api.github.com/repos/CoresecSystems/signxml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoresecSystems/signxml/labels{/name}","releases_url":"https://api.github.com/repos/CoresecSystems/signxml/releases{/id}","deployments_url":"https://api.github.com/repos/CoresecSystems/signxml/deployments","created_at":"2016-03-23T20:11:04Z","updated_at":"2016-03-23T20:11:05Z","pushed_at":"2016-03-24T13:58:03Z","git_url":"git://github.com/CoresecSystems/signxml.git","ssh_url":"git@github.com:CoresecSystems/signxml.git","clone_url":"https://github.com/CoresecSystems/signxml.git","svn_url":"https://github.com/CoresecSystems/signxml","homepage":"https://signxml.readthedocs.org/","size":310,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kislyuk:master","ref":"master","sha":"6521e5523d90d255cb100922412c5de03d623665","user":{"login":"kislyuk","id":862013,"avatar_url":"https://avatars.githubusercontent.com/u/862013?v=3","gravatar_id":"","url":"https://api.github.com/users/kislyuk","html_url":"https://github.com/kislyuk","followers_url":"https://api.github.com/users/kislyuk/followers","following_url":"https://api.github.com/users/kislyuk/following{/other_user}","gists_url":"https://api.github.com/users/kislyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/kislyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kislyuk/subscriptions","organizations_url":"https://api.github.com/users/kislyuk/orgs","repos_url":"https://api.github.com/users/kislyuk/repos","events_url":"https://api.github.com/users/kislyuk/events{/privacy}","received_events_url":"https://api.github.com/users/kislyuk/received_events","type":"User","site_admin":false},"repo":{"id":23617000,"name":"signxml","full_name":"kislyuk/signxml","owner":{"login":"kislyuk","id":862013,"avatar_url":"https://avatars.githubusercontent.com/u/862013?v=3","gravatar_id":"","url":"https://api.github.com/users/kislyuk","html_url":"https://github.com/kislyuk","followers_url":"https://api.github.com/users/kislyuk/followers","following_url":"https://api.github.com/users/kislyuk/following{/other_user}","gists_url":"https://api.github.com/users/kislyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/kislyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kislyuk/subscriptions","organizations_url":"https://api.github.com/users/kislyuk/orgs","repos_url":"https://api.github.com/users/kislyuk/repos","events_url":"https://api.github.com/users/kislyuk/events{/privacy}","received_events_url":"https://api.github.com/users/kislyuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kislyuk/signxml","description":"Python XML Signature library","fork":false,"url":"https://api.github.com/repos/kislyuk/signxml","forks_url":"https://api.github.com/repos/kislyuk/signxml/forks","keys_url":"https://api.github.com/repos/kislyuk/signxml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kislyuk/signxml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kislyuk/signxml/teams","hooks_url":"https://api.github.com/repos/kislyuk/signxml/hooks","issue_events_url":"https://api.github.com/repos/kislyuk/signxml/issues/events{/number}","events_url":"https://api.github.com/repos/kislyuk/signxml/events","assignees_url":"https://api.github.com/repos/kislyuk/signxml/assignees{/user}","branches_url":"https://api.github.com/repos/kislyuk/signxml/branches{/branch}","tags_url":"https://api.github.com/repos/kislyuk/signxml/tags","blobs_url":"https://api.github.com/repos/kislyuk/signxml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kislyuk/signxml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kislyuk/signxml/git/refs{/sha}","trees_url":"https://api.github.com/repos/kislyuk/signxml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kislyuk/signxml/statuses/{sha}","languages_url":"https://api.github.com/repos/kislyuk/signxml/languages","stargazers_url":"https://api.github.com/repos/kislyuk/signxml/stargazers","contributors_url":"https://api.github.com/repos/kislyuk/signxml/contributors","subscribers_url":"https://api.github.com/repos/kislyuk/signxml/subscribers","subscription_url":"https://api.github.com/repos/kislyuk/signxml/subscription","commits_url":"https://api.github.com/repos/kislyuk/signxml/commits{/sha}","git_commits_url":"https://api.github.com/repos/kislyuk/signxml/git/commits{/sha}","comments_url":"https://api.github.com/repos/kislyuk/signxml/comments{/number}","issue_comment_url":"https://api.github.com/repos/kislyuk/signxml/issues/comments{/number}","contents_url":"https://api.github.com/repos/kislyuk/signxml/contents/{+path}","compare_url":"https://api.github.com/repos/kislyuk/signxml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kislyuk/signxml/merges","archive_url":"https://api.github.com/repos/kislyuk/signxml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kislyuk/signxml/downloads","issues_url":"https://api.github.com/repos/kislyuk/signxml/issues{/number}","pulls_url":"https://api.github.com/repos/kislyuk/signxml/pulls{/number}","milestones_url":"https://api.github.com/repos/kislyuk/signxml/milestones{/number}","notifications_url":"https://api.github.com/repos/kislyuk/signxml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kislyuk/signxml/labels{/name}","releases_url":"https://api.github.com/repos/kislyuk/signxml/releases{/id}","deployments_url":"https://api.github.com/repos/kislyuk/signxml/deployments","created_at":"2014-09-03T10:59:24Z","updated_at":"2016-01-29T12:33:58Z","pushed_at":"2016-03-24T15:03:45Z","git_url":"git://github.com/kislyuk/signxml.git","ssh_url":"git@github.com:kislyuk/signxml.git","clone_url":"https://github.com/kislyuk/signxml.git","svn_url":"https://github.com/kislyuk/signxml","homepage":"https://signxml.readthedocs.org/","size":314,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":17,"forks":20,"open_issues":17,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kislyuk/signxml/pulls/46"},"html":{"href":"https://github.com/kislyuk/signxml/pull/46"},"issue":{"href":"https://api.github.com/repos/kislyuk/signxml/issues/46"},"comments":{"href":"https://api.github.com/repos/kislyuk/signxml/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/kislyuk/signxml/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/kislyuk/signxml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kislyuk/signxml/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/kislyuk/signxml/statuses/3de87c2243c8de2ea46baf75d7b4a2c714f16fc9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kislyuk","id":862013,"avatar_url":"https://avatars.githubusercontent.com/u/862013?v=3","gravatar_id":"","url":"https://api.github.com/users/kislyuk","html_url":"https://github.com/kislyuk","followers_url":"https://api.github.com/users/kislyuk/followers","following_url":"https://api.github.com/users/kislyuk/following{/other_user}","gists_url":"https://api.github.com/users/kislyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/kislyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kislyuk/subscriptions","organizations_url":"https://api.github.com/users/kislyuk/orgs","repos_url":"https://api.github.com/users/kislyuk/repos","events_url":"https://api.github.com/users/kislyuk/events{/privacy}","received_events_url":"https://api.github.com/users/kislyuk/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"commits":4,"additions":461,"deletions":16,"changed_files":13}}