{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/comments/60357608","id":60357608,"diff_hunk":"@@ -1,4 +1,4 @@\n-﻿namespace NServiceBus.Azure.Transports.WindowsAzureStorageQueues\n+﻿namespace NServiceBus.Azure.Transports.WindowsAzureStorageQueues.Internals","path":"src/Transport/AzureMessageQueueCreator.cs","position":2,"original_position":2,"commit_id":"a4df3d48b9184ad2742c90ca0bf554969fe6b7a8","original_commit_id":"a4df3d48b9184ad2742c90ca0bf554969fe6b7a8","user":{"login":"WojcikMike","id":604826,"avatar_url":"https://avatars.githubusercontent.com/u/604826?v=3","gravatar_id":"","url":"https://api.github.com/users/WojcikMike","html_url":"https://github.com/WojcikMike","followers_url":"https://api.github.com/users/WojcikMike/followers","following_url":"https://api.github.com/users/WojcikMike/following{/other_user}","gists_url":"https://api.github.com/users/WojcikMike/gists{/gist_id}","starred_url":"https://api.github.com/users/WojcikMike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojcikMike/subscriptions","organizations_url":"https://api.github.com/users/WojcikMike/orgs","repos_url":"https://api.github.com/users/WojcikMike/repos","events_url":"https://api.github.com/users/WojcikMike/events{/privacy}","received_events_url":"https://api.github.com/users/WojcikMike/received_events","type":"User","site_admin":false},"body":"Yeah I don't like it either, I asked number of people how to obsolete gracefully class that was changed to internal and the options were:\r\n* rename the leftover class to something else, and keep the original type with obsolete\r\n* move the leftover class to other namespace, and keep the original type with obsolete\r\n\r\nBoth of those solutions have pros and cons. What is more i don't have any good name for the namespace. So I am happy to adjust this change to something else that will allow us to achieve the goal","created_at":"2016-04-20T06:53:56Z","updated_at":"2016-04-20T06:53:56Z","html_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues/pull/90#discussion_r60357608","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/comments/60357608"},"html":{"href":"https://github.com/Particular/NServiceBus.AzureStorageQueues/pull/90#discussion_r60357608"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90","id":67041615,"html_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues/pull/90","diff_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues/pull/90.diff","patch_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues/pull/90.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/90","number":90,"state":"open","locked":false,"title":"[WIP] Marking as obsolete all changes in public API","user":{"login":"WojcikMike","id":604826,"avatar_url":"https://avatars.githubusercontent.com/u/604826?v=3","gravatar_id":"","url":"https://api.github.com/users/WojcikMike","html_url":"https://github.com/WojcikMike","followers_url":"https://api.github.com/users/WojcikMike/followers","following_url":"https://api.github.com/users/WojcikMike/following{/other_user}","gists_url":"https://api.github.com/users/WojcikMike/gists{/gist_id}","starred_url":"https://api.github.com/users/WojcikMike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojcikMike/subscriptions","organizations_url":"https://api.github.com/users/WojcikMike/orgs","repos_url":"https://api.github.com/users/WojcikMike/repos","events_url":"https://api.github.com/users/WojcikMike/events{/privacy}","received_events_url":"https://api.github.com/users/WojcikMike/received_events","type":"User","site_admin":false},"body":"Connects to #87","created_at":"2016-04-19T15:41:37Z","updated_at":"2016-04-20T06:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08130b2d2c8524d58ff3b9ade72b3ee0f6cb8848","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/90/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/statuses/a4df3d48b9184ad2742c90ca0bf554969fe6b7a8","head":{"label":"Particular:introduce-obsolete","ref":"introduce-obsolete","sha":"a4df3d48b9184ad2742c90ca0bf554969fe6b7a8","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":29925374,"name":"NServiceBus.AzureStorageQueues","full_name":"Particular/NServiceBus.AzureStorageQueues","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues","description":"Azure Storage Queues Transport for NServiceBus","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues","forks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/deployments","created_at":"2015-01-27T17:22:40Z","updated_at":"2016-02-22T00:44:01Z","pushed_at":"2016-04-19T20:04:48Z","git_url":"git://github.com/Particular/NServiceBus.AzureStorageQueues.git","ssh_url":"git@github.com:Particular/NServiceBus.AzureStorageQueues.git","clone_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues.git","svn_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues","homepage":"http://docs.particular.net/nservicebus/azure/azure-storage-queues-transport","size":838,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":0,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"ecebcff330cf9f2f283f035f8dc994ecee552c9b","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":29925374,"name":"NServiceBus.AzureStorageQueues","full_name":"Particular/NServiceBus.AzureStorageQueues","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues","description":"Azure Storage Queues Transport for NServiceBus","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues","forks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/deployments","created_at":"2015-01-27T17:22:40Z","updated_at":"2016-02-22T00:44:01Z","pushed_at":"2016-04-19T20:04:48Z","git_url":"git://github.com/Particular/NServiceBus.AzureStorageQueues.git","ssh_url":"git@github.com:Particular/NServiceBus.AzureStorageQueues.git","clone_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues.git","svn_url":"https://github.com/Particular/NServiceBus.AzureStorageQueues","homepage":"http://docs.particular.net/nservicebus/azure/azure-storage-queues-transport","size":838,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":15,"forks":1,"open_issues":15,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90"},"html":{"href":"https://github.com/Particular/NServiceBus.AzureStorageQueues/pull/90"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/90"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureStorageQueues/statuses/a4df3d48b9184ad2742c90ca0bf554969fe6b7a8"}}}}