{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/82877573","pull_request_review_id":3753745,"id":82877573,"diff_hunk":"@@ -476,6 +476,24 @@ class PreconditionJacobi : public PreconditionRelaxation<MatrixType>\n {\n public:\n   /**\n+   * AdditionalData to store relaxation parameter.\n+   */\n+  struct AdditionalData : public PreconditionRelaxation<MatrixType>::AdditionalData","path":"include/deal.II/lac/precondition.h","position":28,"original_position":28,"commit_id":"56c344e5fa6a2dbf33c5fdac880c01da62252b9b","original_commit_id":"56c344e5fa6a2dbf33c5fdac880c01da62252b9b","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"Here and in the other places, there is no actual need to declare this `struct` -- it is entirely equivalent to the one in `PreconditionRelaxation`. Because `PreconditionRelaxation` is a base class, the structure is actually already available, though one may use through `typename` to get at it. But rather than declare this class, declare a constructor, and simply pass the argument down to the base class, why not just say\r\n```\r\n  using PreconditionRelaxation<MatrixType>::AdditionalData;\r\n```\r\nhere to make the `struct` available as a member of the current class as well?","created_at":"2016-10-11T20:08:21Z","updated_at":"2016-10-11T20:08:21Z","html_url":"https://github.com/dealii/dealii/pull/3184#discussion_r82877573","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/3184","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/82877573"},"html":{"href":"https://github.com/dealii/dealii/pull/3184#discussion_r82877573"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3184"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/3184","id":87891661,"html_url":"https://github.com/dealii/dealii/pull/3184","diff_url":"https://github.com/dealii/dealii/pull/3184.diff","patch_url":"https://github.com/dealii/dealii/pull/3184.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/3184","number":3184,"state":"open","locked":false,"title":"make PreconditionJacobi work with MGSmootherPrecondition by defining …","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"…AdditionalData\r\n\r\npartially address https://github.com/dealii/dealii/issues/3183\r\n\r\ntry unit tests which use Jacobi:\r\n\r\n- [x] `bits/step-4_dg_periodic.cc`\r\n- [x] `lac/block_matrices_04.cc`\r\n- [x] `lac/filtered_matrix_06.cc1\r\n- [x] `lac/linear_operator_01b.cc`\r\n- [x] `lac/schur_complement_02.cc`\r\n- [x] `lac/schur_complement_01.cc`\r\n- [x] `lac/solver_relaxation_01.cc`\r\n- [x] `lac/sparse_matrices.cc`\r\n\r\n`lac/linear_operator_08.cc` and `numerics/data_out_curved_cells.cc` fail for me on master without the patch.\r\n\r\n- [x] add a unit test\r\n","created_at":"2016-10-04T13:16:32Z","updated_at":"2016-10-11T20:09:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d741b251f28bab23e5fceece47bda0a4ac739298","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/3184/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/3184/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/3184/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/56c344e5fa6a2dbf33c5fdac880c01da62252b9b","head":{"label":"davydden:feature/PreconditionJacobi_MGSmootherPrecondition","ref":"feature/PreconditionJacobi_MGSmootherPrecondition","sha":"56c344e5fa6a2dbf33c5fdac880c01da62252b9b","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"repo":{"id":22635610,"name":"dealii","full_name":"davydden/dealii","owner":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davydden/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/davydden/dealii","forks_url":"https://api.github.com/repos/davydden/dealii/forks","keys_url":"https://api.github.com/repos/davydden/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davydden/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davydden/dealii/teams","hooks_url":"https://api.github.com/repos/davydden/dealii/hooks","issue_events_url":"https://api.github.com/repos/davydden/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/davydden/dealii/events","assignees_url":"https://api.github.com/repos/davydden/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/davydden/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/davydden/dealii/tags","blobs_url":"https://api.github.com/repos/davydden/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davydden/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davydden/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/davydden/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davydden/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/davydden/dealii/languages","stargazers_url":"https://api.github.com/repos/davydden/dealii/stargazers","contributors_url":"https://api.github.com/repos/davydden/dealii/contributors","subscribers_url":"https://api.github.com/repos/davydden/dealii/subscribers","subscription_url":"https://api.github.com/repos/davydden/dealii/subscription","commits_url":"https://api.github.com/repos/davydden/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/davydden/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/davydden/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/davydden/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/davydden/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/davydden/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davydden/dealii/merges","archive_url":"https://api.github.com/repos/davydden/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davydden/dealii/downloads","issues_url":"https://api.github.com/repos/davydden/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/davydden/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/davydden/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/davydden/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davydden/dealii/labels{/name}","releases_url":"https://api.github.com/repos/davydden/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/davydden/dealii/deployments","created_at":"2014-08-05T08:06:18Z","updated_at":"2015-01-10T19:48:48Z","pushed_at":"2016-10-11T17:37:40Z","git_url":"git://github.com/davydden/dealii.git","ssh_url":"git@github.com:davydden/dealii.git","clone_url":"https://github.com/davydden/dealii.git","svn_url":"https://github.com/davydden/dealii","homepage":"http://www.dealii.org/","size":147463,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"b6b524916128001a26ba865181e3b4f52e605abd","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-10-08T20:43:09Z","pushed_at":"2016-10-11T17:37:41Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":168206,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":183,"forks":187,"open_issues":183,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3184"},"html":{"href":"https://github.com/dealii/dealii/pull/3184"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/3184"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/3184/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3184/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3184/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/56c344e5fa6a2dbf33c5fdac880c01da62252b9b"}}}}
{"actor":{"display_login":"bangerth"}}