{"action":"created","comment":{"url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/comments/87719049","pull_request_review_id":8320344,"id":87719049,"diff_hunk":"@@ -1,81 +1,83 @@\n+# Licensed to the Apache Software Foundation (ASF) under one or more\n+# contributor license agreements.  See the NOTICE file distributed with\n+# this work for additional information regarding copyright ownership.\n+# The ASF licenses this file to You under the Apache License, Version 2.0\n+# (the \"License\"); you may not use this file except in compliance with\n+# the License.  You may obtain a copy of the License at\n #\n-# Copyright (c) 2016 GigaSpaces Technologies Ltd. All rights reserved.\n-# \n-# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\n-# not use this file except in compliance with the License. You may obtain\n-# a copy of the License at\n-# \n-#      http://www.apache.org/licenses/LICENSE-2.0\n-# \n-# Unless required by applicable law or agreed to in writing, software\n-# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n-# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n-# License for the specific language governing permissions and limitations\n-# under the License.\n+#     http://www.apache.org/licenses/LICENSE-2.0\n #\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n \n-from .utils import coerce_value\n-from .. import UnimplementedFunctionalityError\n-from ..utils import StrictDict, full_type_name, puts\n from collections import OrderedDict\n+from .utils import coerce_value\n+from ..utils import StrictDict, puts\n+\n \n class Function(object):\n     \"\"\"\n     An intrinsic function.\n-    \n+\n     Serves as a placeholder for a value that should eventually be derived\n     by calling the function.\n     \"\"\"\n-    \n+\n     @property\n     def as_raw(self):\n-        raise UnimplementedFunctionalityError(full_type_name(self) + '.as_raw')\n+        raise NotImplementedError\n \n     def _evaluate(self, context, container):\n-        raise UnimplementedFunctionalityError(full_type_name(self) + '._evaluate')\n+        raise NotImplementedError\n \n     def __deepcopy__(self, memo):\n         # Circumvent cloning in order to maintain our state\n         return self\n \n+\n class Element(object):\n     \"\"\"\n     Base class for :class:`ServiceInstance` elements.\n-    \n+\n     All elements support validation, diagnostic dumping, and representation as\n     raw data (which can be translated into JSON or YAML) via :code:`as_raw`.\n     \"\"\"\n-    \n+\n     @property\n     def as_raw(self):\n-        raise UnimplementedFunctionalityError(full_type_name(self) + '.as_raw')\n+        raise NotImplementedError\n \n     def validate(self, context):\n         pass\n \n     def coerce_values(self, context, container, report_issues):\n         pass\n-    \n+\n     def dump(self, context):\n         pass\n \n+\n class ModelElement(Element):\n     \"\"\"\n     Base class for :class:`ServiceModel` elements.\n-    \n-    All model elements can be instantiated into :class:`ServiceInstance` elements. \n+\n+    All model elements can be instantiated into :class:`ServiceInstance` elements.\n     \"\"\"\n \n     def instantiate(self, context, container):\n-        pass\n+        raise NotImplementedError","path":"src/aria/aria/modeling/elements.py","position":98,"original_position":98,"commit_id":"47eb87789252f813112fd0c680c223cc1a43c880","original_commit_id":"47eb87789252f813112fd0c680c223cc1a43c880","user":{"login":"AviaE","id":11952207,"avatar_url":"https://avatars.githubusercontent.com/u/11952207?v=3","gravatar_id":"","url":"https://api.github.com/users/AviaE","html_url":"https://github.com/AviaE","followers_url":"https://api.github.com/users/AviaE/followers","following_url":"https://api.github.com/users/AviaE/following{/other_user}","gists_url":"https://api.github.com/users/AviaE/gists{/gist_id}","starred_url":"https://api.github.com/users/AviaE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AviaE/subscriptions","organizations_url":"https://api.github.com/users/AviaE/orgs","repos_url":"https://api.github.com/users/AviaE/repos","events_url":"https://api.github.com/users/AviaE/events{/privacy}","received_events_url":"https://api.github.com/users/AviaE/received_events","type":"User","site_admin":false},"body":"Tal's intention was for it to be a protoype function, so yeah. I agree that the previous implementation of `pass` can be confusing.","created_at":"2016-11-13T19:10:38Z","updated_at":"2016-11-13T19:10:38Z","html_url":"https://github.com/aria-tosca/aria-ng/pull/17#discussion_r87719049","pull_request_url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/comments/87719049"},"html":{"href":"https://github.com/aria-tosca/aria-ng/pull/17#discussion_r87719049"},"pull_request":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17","id":93477718,"html_url":"https://github.com/aria-tosca/aria-ng/pull/17","diff_url":"https://github.com/aria-tosca/aria-ng/pull/17.diff","patch_url":"https://github.com/aria-tosca/aria-ng/pull/17.patch","issue_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues/17","number":17,"state":"open","locked":false,"title":"Linting - avia","user":{"login":"AviaE","id":11952207,"avatar_url":"https://avatars.githubusercontent.com/u/11952207?v=3","gravatar_id":"","url":"https://api.github.com/users/AviaE","html_url":"https://github.com/AviaE","followers_url":"https://api.github.com/users/AviaE/followers","following_url":"https://api.github.com/users/AviaE/following{/other_user}","gists_url":"https://api.github.com/users/AviaE/gists{/gist_id}","starred_url":"https://api.github.com/users/AviaE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AviaE/subscriptions","organizations_url":"https://api.github.com/users/AviaE/orgs","repos_url":"https://api.github.com/users/AviaE/repos","events_url":"https://api.github.com/users/AviaE/events{/privacy}","received_events_url":"https://api.github.com/users/AviaE/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-13T16:21:11Z","updated_at":"2016-11-13T19:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ab359088467ec02e87dc836320fcc8424286660","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17/commits","review_comments_url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17/comments","review_comment_url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues/17/comments","statuses_url":"https://api.github.com/repos/aria-tosca/aria-ng/statuses/47eb87789252f813112fd0c680c223cc1a43c880","head":{"label":"aria-tosca:linting","ref":"linting","sha":"47eb87789252f813112fd0c680c223cc1a43c880","user":{"login":"aria-tosca","id":14369280,"avatar_url":"https://avatars.githubusercontent.com/u/14369280?v=3","gravatar_id":"","url":"https://api.github.com/users/aria-tosca","html_url":"https://github.com/aria-tosca","followers_url":"https://api.github.com/users/aria-tosca/followers","following_url":"https://api.github.com/users/aria-tosca/following{/other_user}","gists_url":"https://api.github.com/users/aria-tosca/gists{/gist_id}","starred_url":"https://api.github.com/users/aria-tosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aria-tosca/subscriptions","organizations_url":"https://api.github.com/users/aria-tosca/orgs","repos_url":"https://api.github.com/users/aria-tosca/repos","events_url":"https://api.github.com/users/aria-tosca/events{/privacy}","received_events_url":"https://api.github.com/users/aria-tosca/received_events","type":"Organization","site_admin":false},"repo":{"id":64415484,"name":"aria-ng","full_name":"aria-tosca/aria-ng","owner":{"login":"aria-tosca","id":14369280,"avatar_url":"https://avatars.githubusercontent.com/u/14369280?v=3","gravatar_id":"","url":"https://api.github.com/users/aria-tosca","html_url":"https://github.com/aria-tosca","followers_url":"https://api.github.com/users/aria-tosca/followers","following_url":"https://api.github.com/users/aria-tosca/following{/other_user}","gists_url":"https://api.github.com/users/aria-tosca/gists{/gist_id}","starred_url":"https://api.github.com/users/aria-tosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aria-tosca/subscriptions","organizations_url":"https://api.github.com/users/aria-tosca/orgs","repos_url":"https://api.github.com/users/aria-tosca/repos","events_url":"https://api.github.com/users/aria-tosca/events{/privacy}","received_events_url":"https://api.github.com/users/aria-tosca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aria-tosca/aria-ng","description":"ARIA Next Generation (experimental)","fork":false,"url":"https://api.github.com/repos/aria-tosca/aria-ng","forks_url":"https://api.github.com/repos/aria-tosca/aria-ng/forks","keys_url":"https://api.github.com/repos/aria-tosca/aria-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aria-tosca/aria-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aria-tosca/aria-ng/teams","hooks_url":"https://api.github.com/repos/aria-tosca/aria-ng/hooks","issue_events_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues/events{/number}","events_url":"https://api.github.com/repos/aria-tosca/aria-ng/events","assignees_url":"https://api.github.com/repos/aria-tosca/aria-ng/assignees{/user}","branches_url":"https://api.github.com/repos/aria-tosca/aria-ng/branches{/branch}","tags_url":"https://api.github.com/repos/aria-tosca/aria-ng/tags","blobs_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aria-tosca/aria-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/aria-tosca/aria-ng/languages","stargazers_url":"https://api.github.com/repos/aria-tosca/aria-ng/stargazers","contributors_url":"https://api.github.com/repos/aria-tosca/aria-ng/contributors","subscribers_url":"https://api.github.com/repos/aria-tosca/aria-ng/subscribers","subscription_url":"https://api.github.com/repos/aria-tosca/aria-ng/subscription","commits_url":"https://api.github.com/repos/aria-tosca/aria-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/aria-tosca/aria-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/aria-tosca/aria-ng/contents/{+path}","compare_url":"https://api.github.com/repos/aria-tosca/aria-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aria-tosca/aria-ng/merges","archive_url":"https://api.github.com/repos/aria-tosca/aria-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aria-tosca/aria-ng/downloads","issues_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues{/number}","pulls_url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/aria-tosca/aria-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/aria-tosca/aria-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aria-tosca/aria-ng/labels{/name}","releases_url":"https://api.github.com/repos/aria-tosca/aria-ng/releases{/id}","deployments_url":"https://api.github.com/repos/aria-tosca/aria-ng/deployments","created_at":"2016-07-28T17:35:41Z","updated_at":"2016-11-06T16:42:29Z","pushed_at":"2016-11-13T16:49:15Z","git_url":"git://github.com/aria-tosca/aria-ng.git","ssh_url":"git@github.com:aria-tosca/aria-ng.git","clone_url":"https://github.com/aria-tosca/aria-ng.git","svn_url":"https://github.com/aria-tosca/aria-ng","homepage":null,"size":6802,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"aria-tosca:master","ref":"master","sha":"074cc85ea803dc20e078fa7e487082d5e702eb3c","user":{"login":"aria-tosca","id":14369280,"avatar_url":"https://avatars.githubusercontent.com/u/14369280?v=3","gravatar_id":"","url":"https://api.github.com/users/aria-tosca","html_url":"https://github.com/aria-tosca","followers_url":"https://api.github.com/users/aria-tosca/followers","following_url":"https://api.github.com/users/aria-tosca/following{/other_user}","gists_url":"https://api.github.com/users/aria-tosca/gists{/gist_id}","starred_url":"https://api.github.com/users/aria-tosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aria-tosca/subscriptions","organizations_url":"https://api.github.com/users/aria-tosca/orgs","repos_url":"https://api.github.com/users/aria-tosca/repos","events_url":"https://api.github.com/users/aria-tosca/events{/privacy}","received_events_url":"https://api.github.com/users/aria-tosca/received_events","type":"Organization","site_admin":false},"repo":{"id":64415484,"name":"aria-ng","full_name":"aria-tosca/aria-ng","owner":{"login":"aria-tosca","id":14369280,"avatar_url":"https://avatars.githubusercontent.com/u/14369280?v=3","gravatar_id":"","url":"https://api.github.com/users/aria-tosca","html_url":"https://github.com/aria-tosca","followers_url":"https://api.github.com/users/aria-tosca/followers","following_url":"https://api.github.com/users/aria-tosca/following{/other_user}","gists_url":"https://api.github.com/users/aria-tosca/gists{/gist_id}","starred_url":"https://api.github.com/users/aria-tosca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aria-tosca/subscriptions","organizations_url":"https://api.github.com/users/aria-tosca/orgs","repos_url":"https://api.github.com/users/aria-tosca/repos","events_url":"https://api.github.com/users/aria-tosca/events{/privacy}","received_events_url":"https://api.github.com/users/aria-tosca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aria-tosca/aria-ng","description":"ARIA Next Generation (experimental)","fork":false,"url":"https://api.github.com/repos/aria-tosca/aria-ng","forks_url":"https://api.github.com/repos/aria-tosca/aria-ng/forks","keys_url":"https://api.github.com/repos/aria-tosca/aria-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aria-tosca/aria-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aria-tosca/aria-ng/teams","hooks_url":"https://api.github.com/repos/aria-tosca/aria-ng/hooks","issue_events_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues/events{/number}","events_url":"https://api.github.com/repos/aria-tosca/aria-ng/events","assignees_url":"https://api.github.com/repos/aria-tosca/aria-ng/assignees{/user}","branches_url":"https://api.github.com/repos/aria-tosca/aria-ng/branches{/branch}","tags_url":"https://api.github.com/repos/aria-tosca/aria-ng/tags","blobs_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aria-tosca/aria-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/aria-tosca/aria-ng/languages","stargazers_url":"https://api.github.com/repos/aria-tosca/aria-ng/stargazers","contributors_url":"https://api.github.com/repos/aria-tosca/aria-ng/contributors","subscribers_url":"https://api.github.com/repos/aria-tosca/aria-ng/subscribers","subscription_url":"https://api.github.com/repos/aria-tosca/aria-ng/subscription","commits_url":"https://api.github.com/repos/aria-tosca/aria-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/aria-tosca/aria-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/aria-tosca/aria-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/aria-tosca/aria-ng/contents/{+path}","compare_url":"https://api.github.com/repos/aria-tosca/aria-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aria-tosca/aria-ng/merges","archive_url":"https://api.github.com/repos/aria-tosca/aria-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aria-tosca/aria-ng/downloads","issues_url":"https://api.github.com/repos/aria-tosca/aria-ng/issues{/number}","pulls_url":"https://api.github.com/repos/aria-tosca/aria-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/aria-tosca/aria-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/aria-tosca/aria-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aria-tosca/aria-ng/labels{/name}","releases_url":"https://api.github.com/repos/aria-tosca/aria-ng/releases{/id}","deployments_url":"https://api.github.com/repos/aria-tosca/aria-ng/deployments","created_at":"2016-07-28T17:35:41Z","updated_at":"2016-11-06T16:42:29Z","pushed_at":"2016-11-13T16:49:15Z","git_url":"git://github.com/aria-tosca/aria-ng.git","ssh_url":"git@github.com:aria-tosca/aria-ng.git","clone_url":"https://github.com/aria-tosca/aria-ng.git","svn_url":"https://github.com/aria-tosca/aria-ng","homepage":null,"size":6802,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17"},"html":{"href":"https://github.com/aria-tosca/aria-ng/pull/17"},"issue":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/issues/17"},"comments":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/aria-tosca/aria-ng/statuses/47eb87789252f813112fd0c680c223cc1a43c880"}}}}
{"actor":{"display_login":"AviaE"}}