{"action":"created","issue":{"url":"https://api.github.com/repos/apinf/platform/issues/1770","repository_url":"https://api.github.com/repos/apinf/platform","labels_url":"https://api.github.com/repos/apinf/platform/issues/1770/labels{/name}","comments_url":"https://api.github.com/repos/apinf/platform/issues/1770/comments","events_url":"https://api.github.com/repos/apinf/platform/issues/1770/events","html_url":"https://github.com/apinf/platform/pull/1770","id":182496777,"number":1770,"title":"Feature/email settings change accounts ui","user":{"login":"brylie","id":17307,"avatar_url":"https://avatars.githubusercontent.com/u/17307?v=3","gravatar_id":"","url":"https://api.github.com/users/brylie","html_url":"https://github.com/brylie","followers_url":"https://api.github.com/users/brylie/followers","following_url":"https://api.github.com/users/brylie/following{/other_user}","gists_url":"https://api.github.com/users/brylie/gists{/gist_id}","starred_url":"https://api.github.com/users/brylie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brylie/subscriptions","organizations_url":"https://api.github.com/users/brylie/orgs","repos_url":"https://api.github.com/users/brylie/repos","events_url":"https://api.github.com/users/brylie/events{/privacy}","received_events_url":"https://api.github.com/users/brylie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/apinf/platform/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"marla-singer","id":20643403,"avatar_url":"https://avatars.githubusercontent.com/u/20643403?v=3","gravatar_id":"","url":"https://api.github.com/users/marla-singer","html_url":"https://github.com/marla-singer","followers_url":"https://api.github.com/users/marla-singer/followers","following_url":"https://api.github.com/users/marla-singer/following{/other_user}","gists_url":"https://api.github.com/users/marla-singer/gists{/gist_id}","starred_url":"https://api.github.com/users/marla-singer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marla-singer/subscriptions","organizations_url":"https://api.github.com/users/marla-singer/orgs","repos_url":"https://api.github.com/users/marla-singer/repos","events_url":"https://api.github.com/users/marla-singer/events{/privacy}","received_events_url":"https://api.github.com/users/marla-singer/received_events","type":"User","site_admin":false},"assignees":[{"login":"marla-singer","id":20643403,"avatar_url":"https://avatars.githubusercontent.com/u/20643403?v=3","gravatar_id":"","url":"https://api.github.com/users/marla-singer","html_url":"https://github.com/marla-singer","followers_url":"https://api.github.com/users/marla-singer/followers","following_url":"https://api.github.com/users/marla-singer/following{/other_user}","gists_url":"https://api.github.com/users/marla-singer/gists{/gist_id}","starred_url":"https://api.github.com/users/marla-singer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marla-singer/subscriptions","organizations_url":"https://api.github.com/users/marla-singer/orgs","repos_url":"https://api.github.com/users/marla-singer/repos","events_url":"https://api.github.com/users/marla-singer/events{/privacy}","received_events_url":"https://api.github.com/users/marla-singer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apinf/platform/milestones/33","html_url":"https://github.com/apinf/platform/milestones/Sprint%2033","labels_url":"https://api.github.com/repos/apinf/platform/milestones/33/labels","id":2058929,"number":33,"title":"Sprint 33","description":"APInf Sprint 33: 10 - 21 Oct 2016","creator":{"login":"bajiat","id":11626388,"avatar_url":"https://avatars.githubusercontent.com/u/11626388?v=3","gravatar_id":"","url":"https://api.github.com/users/bajiat","html_url":"https://github.com/bajiat","followers_url":"https://api.github.com/users/bajiat/followers","following_url":"https://api.github.com/users/bajiat/following{/other_user}","gists_url":"https://api.github.com/users/bajiat/gists{/gist_id}","starred_url":"https://api.github.com/users/bajiat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajiat/subscriptions","organizations_url":"https://api.github.com/users/bajiat/orgs","repos_url":"https://api.github.com/users/bajiat/repos","events_url":"https://api.github.com/users/bajiat/events{/privacy}","received_events_url":"https://api.github.com/users/bajiat/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":26,"state":"open","created_at":"2016-10-10T11:32:31Z","updated_at":"2016-10-13T14:12:38Z","due_on":"2016-10-21T00:00:00Z","closed_at":null},"comments":23,"created_at":"2016-10-12T11:01:47Z","updated_at":"2016-10-13T15:02:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apinf/platform/pulls/1770","html_url":"https://github.com/apinf/platform/pull/1770","diff_url":"https://github.com/apinf/platform/pull/1770.diff","patch_url":"https://github.com/apinf/platform/pull/1770.patch"},"body":"Closes #1725\r\nCloses #1727\r\nCloses #1719 \r\nCloses #1742 \r\n\r\n# Changes\r\n- conditionally change Accounts Templates links and features based on email settings\r\n  - showForgotPasswordLink\r\n  - showResendVerificationEmailLink\r\n- move login_verify.js to users module\r\n  - fix startup.js import\r\n  - refactor and lint file\r\n  - remove call to `loginAttemptVerifier` setting from AutoForm\r\n- fix `env.MAIL_URL` template string to remove newlines\r\n\r\n# Rationale\r\nWe probably only need to set the `loginAttemptVerifier` on startup, and update the function to handle our use cases:\r\n- email settings enabled\r\n- email settings not enabled"},"comment":{"url":"https://api.github.com/repos/apinf/platform/issues/comments/253539845","html_url":"https://github.com/apinf/platform/pull/1770#issuecomment-253539845","issue_url":"https://api.github.com/repos/apinf/platform/issues/1770","id":253539845,"user":{"login":"brylie","id":17307,"avatar_url":"https://avatars.githubusercontent.com/u/17307?v=3","gravatar_id":"","url":"https://api.github.com/users/brylie","html_url":"https://github.com/brylie","followers_url":"https://api.github.com/users/brylie/followers","following_url":"https://api.github.com/users/brylie/following{/other_user}","gists_url":"https://api.github.com/users/brylie/gists{/gist_id}","starred_url":"https://api.github.com/users/brylie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brylie/subscriptions","organizations_url":"https://api.github.com/users/brylie/orgs","repos_url":"https://api.github.com/users/brylie/repos","events_url":"https://api.github.com/users/brylie/events{/privacy}","received_events_url":"https://api.github.com/users/brylie/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T15:02:04Z","updated_at":"2016-10-13T15:02:04Z","body":"Note: we cannot configure AccountsTemplates settings after they have been initialized:\r\n\r\n```js\r\nUpdate mail configuration: Error: Configuration options must be set before AccountsTemplates.init!\r\n```\r\n\r\nWe have to figure out a different solution, as part of another PR."}}
{"actor":{"display_login":"brylie"}}