{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments/59967504","id":59967504,"diff_hunk":"@@ -74,27 +70,18 @@ This instruction based on Ubuntu 14.04 LTS but may work with other OS with few c\n         }\n \n         location / {\n+            proxy_pass http://zeppelin;\n             proxy_set_header X-Real-IP $remote_addr;\n             proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;\n             proxy_set_header Host $http_host;\n             proxy_set_header X-NginX-Proxy true;\n-            proxy_pass http://zeppelin;\n             proxy_redirect off;\n             auth_basic \"Restricted\";\n             auth_basic_user_file /etc/nginx/.htpasswd;\n         }\n-    }\n \n-    # Zeppelin Websocket\n-    server {\n-        listen [YOUR-ZEPPELIN-WEBSOCKET-PORT] ssl;    # add ssl is optional, to serve HTTPS connection\n-        server_name [YOUR-ZEPPELIN-SERVER-HOST];    # for example: zeppelin.mycompany.com\n-\n-        ssl_certificate [PATH-TO-YOUR-CERT-FILE];            # optional, to serve HTTPS connection\n-        ssl_certificate_key [PATH-TO-YOUR-CERT-KEY-FILE];    # optional, to serve HTTPS connection","path":"docs/security/authentication.md","position":35,"original_position":35,"commit_id":"d55239808ccbad4a78d1edfe6222d29bdbf232c4","original_commit_id":"d55239808ccbad4a78d1edfe6222d29bdbf232c4","user":{"login":"astroshim","id":3348133,"avatar_url":"https://avatars.githubusercontent.com/u/3348133?v=3","gravatar_id":"","url":"https://api.github.com/users/astroshim","html_url":"https://github.com/astroshim","followers_url":"https://api.github.com/users/astroshim/followers","following_url":"https://api.github.com/users/astroshim/following{/other_user}","gists_url":"https://api.github.com/users/astroshim/gists{/gist_id}","starred_url":"https://api.github.com/users/astroshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroshim/subscriptions","organizations_url":"https://api.github.com/users/astroshim/orgs","repos_url":"https://api.github.com/users/astroshim/repos","events_url":"https://api.github.com/users/astroshim/events{/privacy}","received_events_url":"https://api.github.com/users/astroshim/received_events","type":"User","site_admin":false},"body":"Of course ssl configurations are intended. The origin document had two server for http and https and had ssl configurations all of them.","created_at":"2016-04-16T13:18:53Z","updated_at":"2016-04-16T13:18:53Z","html_url":"https://github.com/apache/incubator-zeppelin/pull/814#discussion_r59967504","pull_request_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments/59967504"},"html":{"href":"https://github.com/apache/incubator-zeppelin/pull/814#discussion_r59967504"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814","id":65151399,"html_url":"https://github.com/apache/incubator-zeppelin/pull/814","diff_url":"https://github.com/apache/incubator-zeppelin/pull/814.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/814.patch","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/814","number":814,"state":"open","locked":false,"title":"Fix nginx config to use single port for websocket and REST.","user":{"login":"astroshim","id":3348133,"avatar_url":"https://avatars.githubusercontent.com/u/3348133?v=3","gravatar_id":"","url":"https://api.github.com/users/astroshim","html_url":"https://github.com/astroshim","followers_url":"https://api.github.com/users/astroshim/followers","following_url":"https://api.github.com/users/astroshim/following{/other_user}","gists_url":"https://api.github.com/users/astroshim/gists{/gist_id}","starred_url":"https://api.github.com/users/astroshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroshim/subscriptions","organizations_url":"https://api.github.com/users/astroshim/orgs","repos_url":"https://api.github.com/users/astroshim/repos","events_url":"https://api.github.com/users/astroshim/events{/privacy}","received_events_url":"https://api.github.com/users/astroshim/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\nZeppelin uses single port number for REST and websocket since 0.5.5 so It should be fixed nginx config to use single port for websocket and RESTAPI.\r\n\r\n### What type of PR is it?\r\nBug Fix | Documentation \r\n\r\n### Todos\r\n* [x] - fix to use single port nubmer for websocket and REST.\r\n\r\n### How should this be tested?\r\nTry to set up the nginx config to use single port number for websocket and REST. \r\n\r\n### Screenshots (if appropriate)\r\n![image](https://cloud.githubusercontent.com/assets/3348133/14250636/4c6edf1e-faba-11e5-8d22-1f39e667e140.png)\r\n\r\n### Questions:\r\n* Does the licenses files need update? no\r\n* Is there breaking changes for older versions? no\r\n* Does this needs documentation? no","created_at":"2016-04-04T14:12:08Z","updated_at":"2016-04-16T13:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c1e0b012a2f8c87c0629d92e7a5f89577faccff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/814/comments","statuses_url":"https://api.github.com/repos/apache/incubator-zeppelin/statuses/d55239808ccbad4a78d1edfe6222d29bdbf232c4","head":{"label":"astroshim:fix-nginx-config","ref":"fix-nginx-config","sha":"d55239808ccbad4a78d1edfe6222d29bdbf232c4","user":{"login":"astroshim","id":3348133,"avatar_url":"https://avatars.githubusercontent.com/u/3348133?v=3","gravatar_id":"","url":"https://api.github.com/users/astroshim","html_url":"https://github.com/astroshim","followers_url":"https://api.github.com/users/astroshim/followers","following_url":"https://api.github.com/users/astroshim/following{/other_user}","gists_url":"https://api.github.com/users/astroshim/gists{/gist_id}","starred_url":"https://api.github.com/users/astroshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroshim/subscriptions","organizations_url":"https://api.github.com/users/astroshim/orgs","repos_url":"https://api.github.com/users/astroshim/repos","events_url":"https://api.github.com/users/astroshim/events{/privacy}","received_events_url":"https://api.github.com/users/astroshim/received_events","type":"User","site_admin":false},"repo":{"id":46538777,"name":"incubator-zeppelin","full_name":"astroshim/incubator-zeppelin","owner":{"login":"astroshim","id":3348133,"avatar_url":"https://avatars.githubusercontent.com/u/3348133?v=3","gravatar_id":"","url":"https://api.github.com/users/astroshim","html_url":"https://github.com/astroshim","followers_url":"https://api.github.com/users/astroshim/followers","following_url":"https://api.github.com/users/astroshim/following{/other_user}","gists_url":"https://api.github.com/users/astroshim/gists{/gist_id}","starred_url":"https://api.github.com/users/astroshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroshim/subscriptions","organizations_url":"https://api.github.com/users/astroshim/orgs","repos_url":"https://api.github.com/users/astroshim/repos","events_url":"https://api.github.com/users/astroshim/events{/privacy}","received_events_url":"https://api.github.com/users/astroshim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astroshim/incubator-zeppelin","description":"Mirror of Apache Zeppelin (Incubating)","fork":true,"url":"https://api.github.com/repos/astroshim/incubator-zeppelin","forks_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/forks","keys_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/teams","hooks_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/hooks","issue_events_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/events","assignees_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/tags","blobs_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/languages","stargazers_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/stargazers","contributors_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/contributors","subscribers_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/subscribers","subscription_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/subscription","commits_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/merges","archive_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/downloads","issues_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/astroshim/incubator-zeppelin/deployments","created_at":"2015-11-20T04:15:16Z","updated_at":"2016-01-11T08:30:31Z","pushed_at":"2016-04-14T12:27:42Z","git_url":"git://github.com/astroshim/incubator-zeppelin.git","ssh_url":"git@github.com:astroshim/incubator-zeppelin.git","clone_url":"https://github.com/astroshim/incubator-zeppelin.git","svn_url":"https://github.com/astroshim/incubator-zeppelin","homepage":null,"size":22941,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b51af33cb1e74f337ee119f8a26f87989d86fcbc","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"name":"incubator-zeppelin","full_name":"apache/incubator-zeppelin","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-zeppelin","description":"Mirror of Apache Zeppelin (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-zeppelin","forks_url":"https://api.github.com/repos/apache/incubator-zeppelin/forks","keys_url":"https://api.github.com/repos/apache/incubator-zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/incubator-zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/events","assignees_url":"https://api.github.com/repos/apache/incubator-zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/incubator-zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-zeppelin/merges","archive_url":"https://api.github.com/repos/apache/incubator-zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2016-04-16T11:41:10Z","pushed_at":"2016-04-16T11:28:36Z","git_url":"git://github.com/apache/incubator-zeppelin.git","ssh_url":"git@github.com:apache/incubator-zeppelin.git","clone_url":"https://github.com/apache/incubator-zeppelin.git","svn_url":"https://github.com/apache/incubator-zeppelin","homepage":null,"size":97190,"stargazers_count":1371,"watchers_count":1371,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":673,"mirror_url":"git://git.apache.org/incubator-zeppelin.git","open_issues_count":88,"forks":673,"open_issues":88,"watchers":1371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814"},"html":{"href":"https://github.com/apache/incubator-zeppelin/pull/814"},"issue":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/issues/814"},"comments":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/issues/814/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/814/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-zeppelin/statuses/d55239808ccbad4a78d1edfe6222d29bdbf232c4"}}}}