{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/mux.js/pulls/comments/58556744","id":58556744,"diff_hunk":"@@ -1100,23 +1180,39 @@ Transmuxer = function(options) {\n \n   // feed incoming data to the front of the parsing pipeline\n   this.push = function(data) {\n+    if (hasFlushed) {","path":"lib/mp4/transmuxer.js","position":161,"original_position":161,"commit_id":"751097e0a123879f0a914fd4492cbab3df655426","original_commit_id":"751097e0a123879f0a914fd4492cbab3df655426","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"If we don't support dynamic reconfiguration of the transmuxer after flushing, most of this code wouldn't be necessary. What is the use-case for reconfiguring the transmuxer after flushes?","created_at":"2016-04-05T15:16:22Z","updated_at":"2016-04-05T15:16:22Z","html_url":"https://github.com/videojs/mux.js/pull/76#discussion_r58556744","pull_request_url":"https://api.github.com/repos/videojs/mux.js/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/comments/58556744"},"html":{"href":"https://github.com/videojs/mux.js/pull/76#discussion_r58556744"},"pull_request":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/mux.js/pulls/76","id":64717809,"html_url":"https://github.com/videojs/mux.js/pull/76","diff_url":"https://github.com/videojs/mux.js/pull/76.diff","patch_url":"https://github.com/videojs/mux.js/pull/76.patch","issue_url":"https://api.github.com/repos/videojs/mux.js/issues/76","number":76,"state":"open","locked":false,"title":"Have the transmuxer pipeline automatically configure itself based on input","user":{"login":"imbcmdth","id":162465,"avatar_url":"https://avatars.githubusercontent.com/u/162465?v=3","gravatar_id":"","url":"https://api.github.com/users/imbcmdth","html_url":"https://github.com/imbcmdth","followers_url":"https://api.github.com/users/imbcmdth/followers","following_url":"https://api.github.com/users/imbcmdth/following{/other_user}","gists_url":"https://api.github.com/users/imbcmdth/gists{/gist_id}","starred_url":"https://api.github.com/users/imbcmdth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imbcmdth/subscriptions","organizations_url":"https://api.github.com/users/imbcmdth/orgs","repos_url":"https://api.github.com/users/imbcmdth/repos","events_url":"https://api.github.com/users/imbcmdth/events{/privacy}","received_events_url":"https://api.github.com/users/imbcmdth/received_events","type":"User","site_admin":false},"body":"Experimental attempt to have the transmuxer pipeline get smarter about what to do with the data that is passed into it. \r\n\r\n* Added the ability to tear down the pipeline\r\n* Added a sniffer function that checks to see if the data is likely an AAC by checking to see if it starts with an ID3 tag\r\n* The pipeline creation now happens when the first segment or when a different type of segment is passed in\r\n* The audio track is saved so that the `timelineStartInfo` data is preserved between pipeline changes","created_at":"2016-03-31T00:18:20Z","updated_at":"2016-04-05T15:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05c605238334d66d2423b33a5a42158a0bd90fc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/mux.js/pulls/76/commits","review_comments_url":"https://api.github.com/repos/videojs/mux.js/pulls/76/comments","review_comment_url":"https://api.github.com/repos/videojs/mux.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/mux.js/issues/76/comments","statuses_url":"https://api.github.com/repos/videojs/mux.js/statuses/751097e0a123879f0a914fd4492cbab3df655426","head":{"label":"videojs:dynamic-configuration","ref":"dynamic-configuration","sha":"751097e0a123879f0a914fd4492cbab3df655426","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":40461390,"name":"mux.js","full_name":"videojs/mux.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/mux.js","description":"Lightweight utilities for inspecting and manipulating video container formats.","fork":false,"url":"https://api.github.com/repos/videojs/mux.js","forks_url":"https://api.github.com/repos/videojs/mux.js/forks","keys_url":"https://api.github.com/repos/videojs/mux.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/mux.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/mux.js/teams","hooks_url":"https://api.github.com/repos/videojs/mux.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/mux.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/mux.js/events","assignees_url":"https://api.github.com/repos/videojs/mux.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/mux.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/mux.js/tags","blobs_url":"https://api.github.com/repos/videojs/mux.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/mux.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/mux.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/mux.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/mux.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/mux.js/languages","stargazers_url":"https://api.github.com/repos/videojs/mux.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/mux.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/mux.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/mux.js/subscription","commits_url":"https://api.github.com/repos/videojs/mux.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/mux.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/mux.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/mux.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/mux.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/mux.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/mux.js/merges","archive_url":"https://api.github.com/repos/videojs/mux.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/mux.js/downloads","issues_url":"https://api.github.com/repos/videojs/mux.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/mux.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/mux.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/mux.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/mux.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/mux.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/mux.js/deployments","created_at":"2015-08-10T03:31:07Z","updated_at":"2016-04-05T10:15:41Z","pushed_at":"2016-04-04T23:34:05Z","git_url":"git://github.com/videojs/mux.js.git","ssh_url":"git@github.com:videojs/mux.js.git","clone_url":"https://github.com/videojs/mux.js.git","svn_url":"https://github.com/videojs/mux.js","homepage":null,"size":4241,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":12,"forks":20,"open_issues":12,"watchers":47,"default_branch":"master"}},"base":{"label":"videojs:development","ref":"development","sha":"704321ba9de8eded5b2885cc7c32d86b849e2025","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":40461390,"name":"mux.js","full_name":"videojs/mux.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/mux.js","description":"Lightweight utilities for inspecting and manipulating video container formats.","fork":false,"url":"https://api.github.com/repos/videojs/mux.js","forks_url":"https://api.github.com/repos/videojs/mux.js/forks","keys_url":"https://api.github.com/repos/videojs/mux.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/mux.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/mux.js/teams","hooks_url":"https://api.github.com/repos/videojs/mux.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/mux.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/mux.js/events","assignees_url":"https://api.github.com/repos/videojs/mux.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/mux.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/mux.js/tags","blobs_url":"https://api.github.com/repos/videojs/mux.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/mux.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/mux.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/mux.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/mux.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/mux.js/languages","stargazers_url":"https://api.github.com/repos/videojs/mux.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/mux.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/mux.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/mux.js/subscription","commits_url":"https://api.github.com/repos/videojs/mux.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/mux.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/mux.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/mux.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/mux.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/mux.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/mux.js/merges","archive_url":"https://api.github.com/repos/videojs/mux.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/mux.js/downloads","issues_url":"https://api.github.com/repos/videojs/mux.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/mux.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/mux.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/mux.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/mux.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/mux.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/mux.js/deployments","created_at":"2015-08-10T03:31:07Z","updated_at":"2016-04-05T10:15:41Z","pushed_at":"2016-04-04T23:34:05Z","git_url":"git://github.com/videojs/mux.js.git","ssh_url":"git@github.com:videojs/mux.js.git","clone_url":"https://github.com/videojs/mux.js.git","svn_url":"https://github.com/videojs/mux.js","homepage":null,"size":4241,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":12,"forks":20,"open_issues":12,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/76"},"html":{"href":"https://github.com/videojs/mux.js/pull/76"},"issue":{"href":"https://api.github.com/repos/videojs/mux.js/issues/76"},"comments":{"href":"https://api.github.com/repos/videojs/mux.js/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/mux.js/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/mux.js/statuses/751097e0a123879f0a914fd4492cbab3df655426"}}}}