{"action":"created","issue":{"url":"https://api.github.com/repos/yaronn/xml-crypto/issues/102","repository_url":"https://api.github.com/repos/yaronn/xml-crypto","labels_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/102/comments","events_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/102/events","html_url":"https://github.com/yaronn/xml-crypto/issues/102","id":142101358,"number":102,"title":"Error with CanonicalAlgorithm implementation","user":{"login":"microshine","id":7333669,"avatar_url":"https://avatars.githubusercontent.com/u/7333669?v=3","gravatar_id":"","url":"https://api.github.com/users/microshine","html_url":"https://github.com/microshine","followers_url":"https://api.github.com/users/microshine/followers","following_url":"https://api.github.com/users/microshine/following{/other_user}","gists_url":"https://api.github.com/users/microshine/gists{/gist_id}","starred_url":"https://api.github.com/users/microshine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microshine/subscriptions","organizations_url":"https://api.github.com/users/microshine/orgs","repos_url":"https://api.github.com/users/microshine/repos","events_url":"https://api.github.com/users/microshine/events{/privacy}","received_events_url":"https://api.github.com/users/microshine/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/yaronn/xml-crypto/labels/enhancement","name":"enhancement","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-19T21:16:30Z","updated_at":"2016-05-06T00:41:13Z","closed_at":null,"body":"```javascript\r\nCanonicalizationAlgorithms  = {\r\n        \"http://www.w3.org/2001/10/xml-exc-c14n#\": ExclusiveCanonicalization,\r\n        \"http://www.w3.org/2001/10/xml-exc-c14n#WithComments\": ExclusiveCanonicalizationWithComments,\r\n        \"http://www.w3.org/2000/09/xmldsig#enveloped-signature\": EnvelopedSignature\r\n    };\r\n```\r\n\r\nAll algorithms have got `process` function, but with different result types\r\n\r\n```javascript\r\nEnvelopedSignature.process(node: Node, options?): Node;\r\nExclusiveCanonicalization.process(node: Node, options?): string;\r\nExclusiveCanonicalizationWithComments.process(node: Node, options?): string;\r\n```\r\n\r\nIt can be a problem with `createSignature` function\r\nhttps://github.com/yaronn/xml-crypto/blob/master/lib/signed-xml.js#L701-L704\r\nbecause `signatureAlgorithm.getSignature` needs `signedInfo: string | Buffer`"},"comment":{"url":"https://api.github.com/repos/yaronn/xml-crypto/issues/comments/217319044","html_url":"https://github.com/yaronn/xml-crypto/issues/102#issuecomment-217319044","issue_url":"https://api.github.com/repos/yaronn/xml-crypto/issues/102","id":217319044,"user":{"login":"rmhrisk","id":1619279,"avatar_url":"https://avatars.githubusercontent.com/u/1619279?v=3","gravatar_id":"","url":"https://api.github.com/users/rmhrisk","html_url":"https://github.com/rmhrisk","followers_url":"https://api.github.com/users/rmhrisk/followers","following_url":"https://api.github.com/users/rmhrisk/following{/other_user}","gists_url":"https://api.github.com/users/rmhrisk/gists{/gist_id}","starred_url":"https://api.github.com/users/rmhrisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmhrisk/subscriptions","organizations_url":"https://api.github.com/users/rmhrisk/orgs","repos_url":"https://api.github.com/users/rmhrisk/repos","events_url":"https://api.github.com/users/rmhrisk/events{/privacy}","received_events_url":"https://api.github.com/users/rmhrisk/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T00:41:13Z","updated_at":"2016-05-06T00:41:13Z","body":"We ended up fixing this in our implementation derived from this great package :  https://www.npmjs.com/package/xadesjs"}}