{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/11733","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/11733/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11733/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/11733/events","html_url":"https://github.com/openshift/origin/pull/11733","id":186828620,"number":11733,"title":"[WIP] UPSTREAM: 36071: Add --local & --dry-run flags to `oc set` sub-commands","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars.githubusercontent.com/u/3902875?v=3","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/17","html_url":"https://github.com/openshift/origin/milestones/1.5.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/17/labels","id":2049440,"number":17,"title":"1.5.0","description":null,"creator":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":1,"state":"open","created_at":"2016-10-05T12:16:28Z","updated_at":"2016-11-15T17:32:28Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2016-11-02T15:11:21Z","updated_at":"2016-11-15T18:13:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11733","html_url":"https://github.com/openshift/origin/pull/11733","diff_url":"https://github.com/openshift/origin/pull/11733.diff","patch_url":"https://github.com/openshift/origin/pull/11733.patch"},"body":"UPSTREAM: https://github.com/kubernetes/kubernetes/pull/36071\r\nRelated Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1390139\r\n\r\nRelated PR (adds `--local` and `--dr-run` flags to `oc set resources`): https://github.com/openshift/origin/pull/11694\r\n\r\nPartially addresses: https://github.com/openshift/origin/issues/7899\r\n\r\nsome `oc set ...` sub-commands do not implement `--dry-run` or `--local`\r\noptions. This patch adds these missing options to all sub-commands and\r\nensures that backwards compatibility remains for commands that treat the\r\n--output option as a ``dry-run flag.\r\n\r\n##### Example\r\n```\r\n$ oc set image dc dctest dctest-1=default/testimage:latest --dry-run\r\nNAME      REVISION   DESIRED   CURRENT   TRIGGERED BY\r\ndctest    1          1         1         config\r\n\r\n$ oc set image dc dctest dctest-1=default/testimage:latest -o name\r\ndeploymentconfig/dctest\r\n\r\n$ oc set build-secret mysecret --push --all -o\r\ncustom-columns=NAME:.metadata.name\r\nNAME\r\ngitauthtest\r\nrepo-base\r\n\r\n$ oc set build-secret mysecret --push --all --dry-run\r\nNAME          TYPE      FROM      LATEST\r\ngitauthtest   Source    Git       1\r\nNAME        TYPE      FROM      LATEST\r\nrepo-base   Docker    Git       8\r\n```\r\n\r\n##### Affected commands\r\n\r\n- [x] `oc set build-hook`\r\n- [x] `oc set image` (Also fixed upstream in https://github.com/kubernetes/kubernetes/pull/36071)\r\n- [x] `oc set probe`\r\n- [x] `oc set resources` (fixed in https://github.com/openshift/origin/pull/11694)\r\n- [x] `oc set triggers`\r\n- [x] `oc set volume`\r\n- [x] `oc set env`\r\n- [x] `oc set deployment-hook`\r\n- [x] `oc set build-secret`\r\n- [x] `oc set route-backends`\r\n\r\ncc @openshift/cli-review "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/260720600","html_url":"https://github.com/openshift/origin/pull/11733#issuecomment-260720600","issue_url":"https://api.github.com/repos/openshift/origin/issues/11733","id":260720600,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T18:13:40Z","updated_at":"2016-11-15T18:13:40Z","body":"continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11449/) (Base Commit: 406af360a2fc325fd79470c92114bee998bd9984)"}}
{"actor":{"display_login":"openshift-bot"}}