{"action":"created","issue":{"url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/issues/420","repository_url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer","labels_url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/issues/420/labels{/name}","comments_url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/issues/420/comments","events_url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/issues/420/events","html_url":"https://github.com/GovernmentCommunicationsHeadquarters/Gaffer/issues/420","id":178294631,"number":420,"title":"AbstractCoreKeyAccumuloElementConverter has unnecessary call to System.currentTimeMillis()","user":{"login":"gaffer01","id":16287361,"avatar_url":"https://avatars.githubusercontent.com/u/16287361?v=3","gravatar_id":"","url":"https://api.github.com/users/gaffer01","html_url":"https://github.com/gaffer01","followers_url":"https://api.github.com/users/gaffer01/followers","following_url":"https://api.github.com/users/gaffer01/following{/other_user}","gists_url":"https://api.github.com/users/gaffer01/gists{/gist_id}","starred_url":"https://api.github.com/users/gaffer01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaffer01/subscriptions","organizations_url":"https://api.github.com/users/gaffer01/orgs","repos_url":"https://api.github.com/users/gaffer01/repos","events_url":"https://api.github.com/users/gaffer01/events{/privacy}","received_events_url":"https://api.github.com/users/gaffer01/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/labels/enhancement","name":"enhancement","color":"fbca04"},{"url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/labels/p:normal","name":"p:normal","color":"77bbff"}],"state":"closed","locked":false,"assignee":{"login":"james010101101","id":17004332,"avatar_url":"https://avatars.githubusercontent.com/u/17004332?v=3","gravatar_id":"","url":"https://api.github.com/users/james010101101","html_url":"https://github.com/james010101101","followers_url":"https://api.github.com/users/james010101101/followers","following_url":"https://api.github.com/users/james010101101/following{/other_user}","gists_url":"https://api.github.com/users/james010101101/gists{/gist_id}","starred_url":"https://api.github.com/users/james010101101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james010101101/subscriptions","organizations_url":"https://api.github.com/users/james010101101/orgs","repos_url":"https://api.github.com/users/james010101101/repos","events_url":"https://api.github.com/users/james010101101/events{/privacy}","received_events_url":"https://api.github.com/users/james010101101/received_events","type":"User","site_admin":false},"assignees":[{"login":"james010101101","id":17004332,"avatar_url":"https://avatars.githubusercontent.com/u/17004332?v=3","gravatar_id":"","url":"https://api.github.com/users/james010101101","html_url":"https://github.com/james010101101","followers_url":"https://api.github.com/users/james010101101/followers","following_url":"https://api.github.com/users/james010101101/following{/other_user}","gists_url":"https://api.github.com/users/james010101101/gists{/gist_id}","starred_url":"https://api.github.com/users/james010101101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/james010101101/subscriptions","organizations_url":"https://api.github.com/users/james010101101/orgs","repos_url":"https://api.github.com/users/james010101101/repos","events_url":"https://api.github.com/users/james010101101/events{/privacy}","received_events_url":"https://api.github.com/users/james010101101/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-09-21T09:34:10Z","updated_at":"2016-09-26T10:32:53Z","closed_at":"2016-09-26T10:32:53Z","body":"There are two places in `AbstractCoreKeyAccumuloElementConverter` where there is a call to `System.currentTimeMillis()` which is ignored if a timestamp has been provided. As this is called for every `Element` that is inserted, that's a lot of potentially expensive overhead. The `buildTimestamp` method should call `System.currentTimeMillis()` only if it needs to because no timestamp has been provided.\r\n\r\nTwo other issues with this class could be fixed at the same time (separate issues can be raised if necessary): there is a reference to `new byte[0]` but elsewhere in the class `AccumuloStoreConstants.EMPTY_BYTES` is used instead; in `getKeyFromEntity` there is a comment that \"Row key is formed from identifier and group\" - this is not true - it should say \"Row key is formed from vertex\"."},"comment":{"url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/issues/comments/249535309","html_url":"https://github.com/GovernmentCommunicationsHeadquarters/Gaffer/issues/420#issuecomment-249535309","issue_url":"https://api.github.com/repos/GovernmentCommunicationsHeadquarters/Gaffer/issues/420","id":249535309,"user":{"login":"p013570","id":16834101,"avatar_url":"https://avatars.githubusercontent.com/u/16834101?v=3","gravatar_id":"","url":"https://api.github.com/users/p013570","html_url":"https://github.com/p013570","followers_url":"https://api.github.com/users/p013570/followers","following_url":"https://api.github.com/users/p013570/following{/other_user}","gists_url":"https://api.github.com/users/p013570/gists{/gist_id}","starred_url":"https://api.github.com/users/p013570/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p013570/subscriptions","organizations_url":"https://api.github.com/users/p013570/orgs","repos_url":"https://api.github.com/users/p013570/repos","events_url":"https://api.github.com/users/p013570/events{/privacy}","received_events_url":"https://api.github.com/users/p013570/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T10:32:53Z","updated_at":"2016-09-26T10:32:53Z","body":"Merged into develop."}}
{"actor":{"display_login":"p013570"}}