{"action":"created","issue":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/171","repository_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase","labels_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/171/comments","events_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/171/events","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/171","id":182958159,"number":171,"title":"Build failed on tns run android","user":{"login":"LakshmiEvana","id":17317992,"avatar_url":"https://avatars.githubusercontent.com/u/17317992?v=3","gravatar_id":"","url":"https://api.github.com/users/LakshmiEvana","html_url":"https://github.com/LakshmiEvana","followers_url":"https://api.github.com/users/LakshmiEvana/followers","following_url":"https://api.github.com/users/LakshmiEvana/following{/other_user}","gists_url":"https://api.github.com/users/LakshmiEvana/gists{/gist_id}","starred_url":"https://api.github.com/users/LakshmiEvana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LakshmiEvana/subscriptions","organizations_url":"https://api.github.com/users/LakshmiEvana/orgs","repos_url":"https://api.github.com/users/LakshmiEvana/repos","events_url":"https://api.github.com/users/LakshmiEvana/events{/privacy}","received_events_url":"https://api.github.com/users/LakshmiEvana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-10-14T03:57:01Z","updated_at":"2016-11-10T08:09:04Z","closed_at":null,"body":"HI,\nAfter adding firebase plugin I'm getting following error when I'm trying to build my app by using tns run android command.\n\nError -\nCommand E:\\Native Script\\firebasetest3\\platforms\\android\\gradlew.bat failed with\nexit code 1\nHelp me please!\n"},"comment":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/comments/259626350","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/171#issuecomment-259626350","issue_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/171","id":259626350,"user":{"login":"dxshindeo","id":18443089,"avatar_url":"https://avatars.githubusercontent.com/u/18443089?v=3","gravatar_id":"","url":"https://api.github.com/users/dxshindeo","html_url":"https://github.com/dxshindeo","followers_url":"https://api.github.com/users/dxshindeo/followers","following_url":"https://api.github.com/users/dxshindeo/following{/other_user}","gists_url":"https://api.github.com/users/dxshindeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dxshindeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dxshindeo/subscriptions","organizations_url":"https://api.github.com/users/dxshindeo/orgs","repos_url":"https://api.github.com/users/dxshindeo/repos","events_url":"https://api.github.com/users/dxshindeo/events{/privacy}","received_events_url":"https://api.github.com/users/dxshindeo/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T08:09:04Z","updated_at":"2016-11-10T08:09:04Z","body":"Ooookeeeey, when I check the `node_modules/nativescript-plugin-firebase/platforms/android/include.gradle` file, I see that they are including 9.6.+ version of Firebase in the project, so that's where the error occurs: **Google maps version is \"+\" (currently 9.8.0), Firebase is \"9.6.1\".**\r\n\r\nSo, I have to equalize both those plugin versions. I added the following code in ``App_Resources/Android/app.gradle`` as per https://github.com/dapriett/nativescript-google-maps-sdk :\r\n\r\n```\r\nproject.ext {\r\n    googlePlayServicesVersion = \"9.6.+\"\r\n}\r\n```\r\n\r\nAnd that fixed the issue, now project compiles successfully. However, I downgraded the gmaps. It is more logical to upgrade the firebase instead, to match the latest gmaps version, but firebase plugin doesn't have this nice refference that you can make in `App_Resources/Android/app.gradle` as gmaps can, which means, after plugin installation, **you have to manually, on every time you fullly rebuild app (deleting node_modules folder)** go into `node_modules/nativescript-plugin-firebase/platforms/android/include.gradle` and change the versions included to \"+\" .\r\n\r\nSuggestion to Eddy - make that project.ext refference in your plugin, so we don't have to manually change versions every time our node_modules folder has to be recreated."}}
{"actor":{"display_login":"dxshindeo"}}