{"action":"created","comment":{"url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/comments/90769185","pull_request_review_id":11287475,"id":90769185,"diff_hunk":"@@ -33,12 +33,18 @@ public class AsyncService : IAsyncService\n             if (searchResultsGrid == null) return result;\n \n             var searchResultsLinks = GetSearchResultsLinks(searchResultsGrid);\n+\n+            var PageTasks = new List<Task<HtmlDocument>>();\n+\n             foreach (var linkUrl in searchResultsLinks)\n             {\n                 result.Add(linkUrl);\n                 await LoadDocumentAsync(linkUrl);","path":"src/SyncVsAsync/Services/AsyncService.cs","position":10,"original_position":10,"commit_id":"f1a4906e84e72b4a8dea9fd9c7f3b35099db7152","original_commit_id":"f1a4906e84e72b4a8dea9fd9c7f3b35099db7152","user":{"login":"Measuring","id":1107063,"avatar_url":"https://avatars.githubusercontent.com/u/1107063?v=3","gravatar_id":"","url":"https://api.github.com/users/Measuring","html_url":"https://github.com/Measuring","followers_url":"https://api.github.com/users/Measuring/followers","following_url":"https://api.github.com/users/Measuring/following{/other_user}","gists_url":"https://api.github.com/users/Measuring/gists{/gist_id}","starred_url":"https://api.github.com/users/Measuring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Measuring/subscriptions","organizations_url":"https://api.github.com/users/Measuring/orgs","repos_url":"https://api.github.com/users/Measuring/repos","events_url":"https://api.github.com/users/Measuring/events{/privacy}","received_events_url":"https://api.github.com/users/Measuring/received_events","type":"User","site_admin":false},"body":"Remove the await keyword here.","created_at":"2016-12-04T02:35:27Z","updated_at":"2016-12-04T02:35:27Z","html_url":"https://github.com/jkruer01/SyncVsAsync/pull/1#discussion_r90769185","pull_request_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/comments/90769185"},"html":{"href":"https://github.com/jkruer01/SyncVsAsync/pull/1#discussion_r90769185"},"pull_request":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1","id":96214904,"html_url":"https://github.com/jkruer01/SyncVsAsync/pull/1","diff_url":"https://github.com/jkruer01/SyncVsAsync/pull/1.diff","patch_url":"https://github.com/jkruer01/SyncVsAsync/pull/1.patch","issue_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues/1","number":1,"state":"open","locked":false,"title":"Fix AsyncService to actually work asynchronously","user":{"login":"SamNazar","id":6413241,"avatar_url":"https://avatars.githubusercontent.com/u/6413241?v=3","gravatar_id":"","url":"https://api.github.com/users/SamNazar","html_url":"https://github.com/SamNazar","followers_url":"https://api.github.com/users/SamNazar/followers","following_url":"https://api.github.com/users/SamNazar/following{/other_user}","gists_url":"https://api.github.com/users/SamNazar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamNazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamNazar/subscriptions","organizations_url":"https://api.github.com/users/SamNazar/orgs","repos_url":"https://api.github.com/users/SamNazar/repos","events_url":"https://api.github.com/users/SamNazar/events{/privacy}","received_events_url":"https://api.github.com/users/SamNazar/received_events","type":"User","site_admin":false},"body":"Original code awaited (waited for) each call to LoadDocumentAsync.  The service now makes all of the calls asynchronously, and then waits for them to all finish (via Task.WaitAll).","created_at":"2016-12-02T03:18:58Z","updated_at":"2016-12-04T02:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae5442f5c7c4be8b2ee58913614d70f431d6b29f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues/1/comments","statuses_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/statuses/f1a4906e84e72b4a8dea9fd9c7f3b35099db7152","head":{"label":"SamNazar:patch-1","ref":"patch-1","sha":"f1a4906e84e72b4a8dea9fd9c7f3b35099db7152","user":{"login":"SamNazar","id":6413241,"avatar_url":"https://avatars.githubusercontent.com/u/6413241?v=3","gravatar_id":"","url":"https://api.github.com/users/SamNazar","html_url":"https://github.com/SamNazar","followers_url":"https://api.github.com/users/SamNazar/followers","following_url":"https://api.github.com/users/SamNazar/following{/other_user}","gists_url":"https://api.github.com/users/SamNazar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamNazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamNazar/subscriptions","organizations_url":"https://api.github.com/users/SamNazar/orgs","repos_url":"https://api.github.com/users/SamNazar/repos","events_url":"https://api.github.com/users/SamNazar/events{/privacy}","received_events_url":"https://api.github.com/users/SamNazar/received_events","type":"User","site_admin":false},"repo":{"id":75356160,"name":"SyncVsAsync","full_name":"SamNazar/SyncVsAsync","owner":{"login":"SamNazar","id":6413241,"avatar_url":"https://avatars.githubusercontent.com/u/6413241?v=3","gravatar_id":"","url":"https://api.github.com/users/SamNazar","html_url":"https://github.com/SamNazar","followers_url":"https://api.github.com/users/SamNazar/followers","following_url":"https://api.github.com/users/SamNazar/following{/other_user}","gists_url":"https://api.github.com/users/SamNazar/gists{/gist_id}","starred_url":"https://api.github.com/users/SamNazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamNazar/subscriptions","organizations_url":"https://api.github.com/users/SamNazar/orgs","repos_url":"https://api.github.com/users/SamNazar/repos","events_url":"https://api.github.com/users/SamNazar/events{/privacy}","received_events_url":"https://api.github.com/users/SamNazar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamNazar/SyncVsAsync","description":"Comparison of Sync vs Async API","fork":true,"url":"https://api.github.com/repos/SamNazar/SyncVsAsync","forks_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/forks","keys_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/teams","hooks_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/hooks","issue_events_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/issues/events{/number}","events_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/events","assignees_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/assignees{/user}","branches_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/branches{/branch}","tags_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/tags","blobs_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/statuses/{sha}","languages_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/languages","stargazers_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/stargazers","contributors_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/contributors","subscribers_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/subscribers","subscription_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/subscription","commits_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/contents/{+path}","compare_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/merges","archive_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/downloads","issues_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/issues{/number}","pulls_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/pulls{/number}","milestones_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/milestones{/number}","notifications_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/labels{/name}","releases_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/releases{/id}","deployments_url":"https://api.github.com/repos/SamNazar/SyncVsAsync/deployments","created_at":"2016-12-02T03:15:43Z","updated_at":"2016-12-02T03:15:44Z","pushed_at":"2016-12-02T03:18:29Z","git_url":"git://github.com/SamNazar/SyncVsAsync.git","ssh_url":"git@github.com:SamNazar/SyncVsAsync.git","clone_url":"https://github.com/SamNazar/SyncVsAsync.git","svn_url":"https://github.com/SamNazar/SyncVsAsync","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jkruer01:master","ref":"master","sha":"ba6bce0a246773f794210a36fd65b058701878dd","user":{"login":"jkruer01","id":8005531,"avatar_url":"https://avatars.githubusercontent.com/u/8005531?v=3","gravatar_id":"","url":"https://api.github.com/users/jkruer01","html_url":"https://github.com/jkruer01","followers_url":"https://api.github.com/users/jkruer01/followers","following_url":"https://api.github.com/users/jkruer01/following{/other_user}","gists_url":"https://api.github.com/users/jkruer01/gists{/gist_id}","starred_url":"https://api.github.com/users/jkruer01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkruer01/subscriptions","organizations_url":"https://api.github.com/users/jkruer01/orgs","repos_url":"https://api.github.com/users/jkruer01/repos","events_url":"https://api.github.com/users/jkruer01/events{/privacy}","received_events_url":"https://api.github.com/users/jkruer01/received_events","type":"User","site_admin":false},"repo":{"id":75016090,"name":"SyncVsAsync","full_name":"jkruer01/SyncVsAsync","owner":{"login":"jkruer01","id":8005531,"avatar_url":"https://avatars.githubusercontent.com/u/8005531?v=3","gravatar_id":"","url":"https://api.github.com/users/jkruer01","html_url":"https://github.com/jkruer01","followers_url":"https://api.github.com/users/jkruer01/followers","following_url":"https://api.github.com/users/jkruer01/following{/other_user}","gists_url":"https://api.github.com/users/jkruer01/gists{/gist_id}","starred_url":"https://api.github.com/users/jkruer01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkruer01/subscriptions","organizations_url":"https://api.github.com/users/jkruer01/orgs","repos_url":"https://api.github.com/users/jkruer01/repos","events_url":"https://api.github.com/users/jkruer01/events{/privacy}","received_events_url":"https://api.github.com/users/jkruer01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkruer01/SyncVsAsync","description":"Comparison of Sync vs Async API","fork":false,"url":"https://api.github.com/repos/jkruer01/SyncVsAsync","forks_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/forks","keys_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/teams","hooks_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/hooks","issue_events_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues/events{/number}","events_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/events","assignees_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/assignees{/user}","branches_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/branches{/branch}","tags_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/tags","blobs_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/statuses/{sha}","languages_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/languages","stargazers_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/stargazers","contributors_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/contributors","subscribers_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/subscribers","subscription_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/subscription","commits_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/contents/{+path}","compare_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/merges","archive_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/downloads","issues_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues{/number}","pulls_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls{/number}","milestones_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/milestones{/number}","notifications_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/labels{/name}","releases_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/releases{/id}","deployments_url":"https://api.github.com/repos/jkruer01/SyncVsAsync/deployments","created_at":"2016-11-28T21:32:14Z","updated_at":"2016-11-28T23:38:09Z","pushed_at":"2016-12-02T03:18:58Z","git_url":"git://github.com/jkruer01/SyncVsAsync.git","ssh_url":"git@github.com:jkruer01/SyncVsAsync.git","clone_url":"https://github.com/jkruer01/SyncVsAsync.git","svn_url":"https://github.com/jkruer01/SyncVsAsync","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1"},"html":{"href":"https://github.com/jkruer01/SyncVsAsync/pull/1"},"issue":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues/1"},"comments":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jkruer01/SyncVsAsync/statuses/f1a4906e84e72b4a8dea9fd9c7f3b35099db7152"}}}}
{"actor":{"display_login":"Measuring"}}