{"action":"created","issue":{"url":"https://api.github.com/repos/quran/quran.com-frontend/issues/390","repository_url":"https://api.github.com/repos/quran/quran.com-frontend","labels_url":"https://api.github.com/repos/quran/quran.com-frontend/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/quran/quran.com-frontend/issues/390/comments","events_url":"https://api.github.com/repos/quran/quran.com-frontend/issues/390/events","html_url":"https://github.com/quran/quran.com-frontend/pull/390","id":164709018,"number":390,"title":"#383 Ayah Play Audio + Redux Refactoring (WIP)","user":{"login":"sabeurthabti","id":2606228,"avatar_url":"https://avatars.githubusercontent.com/u/2606228?v=3","gravatar_id":"","url":"https://api.github.com/users/sabeurthabti","html_url":"https://github.com/sabeurthabti","followers_url":"https://api.github.com/users/sabeurthabti/followers","following_url":"https://api.github.com/users/sabeurthabti/following{/other_user}","gists_url":"https://api.github.com/users/sabeurthabti/gists{/gist_id}","starred_url":"https://api.github.com/users/sabeurthabti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabeurthabti/subscriptions","organizations_url":"https://api.github.com/users/sabeurthabti/orgs","repos_url":"https://api.github.com/users/sabeurthabti/repos","events_url":"https://api.github.com/users/sabeurthabti/events{/privacy}","received_events_url":"https://api.github.com/users/sabeurthabti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-10T10:15:19Z","updated_at":"2016-07-10T15:36:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quran/quran.com-frontend/pulls/390","html_url":"https://github.com/quran/quran.com-frontend/pull/390","diff_url":"https://github.com/quran/quran.com-frontend/pull/390.diff","patch_url":"https://github.com/quran/quran.com-frontend/pull/390.patch"},"body":"Hi, \r\n\r\nThis will be a slightly *fat* PR. I am not a fan of the decorators, I will make a suggested change and let me know if you agree. I find wrapping the component in a normal function is much easier for new contributors who probably don't use bleed-edge of ES. Also they have not made it into the official spec. Thoughts?\r\n\r\n- [x] Clicking the Play link should play the current ayah.\r\n- [x] Refactoring out decorators\r\n- [x] Hide play in search results\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/quran/quran.com-frontend/issues/comments/231595109","html_url":"https://github.com/quran/quran.com-frontend/pull/390#issuecomment-231595109","issue_url":"https://api.github.com/repos/quran/quran.com-frontend/issues/390","id":231595109,"user":{"login":"mmahalwy","id":3749095,"avatar_url":"https://avatars.githubusercontent.com/u/3749095?v=3","gravatar_id":"","url":"https://api.github.com/users/mmahalwy","html_url":"https://github.com/mmahalwy","followers_url":"https://api.github.com/users/mmahalwy/followers","following_url":"https://api.github.com/users/mmahalwy/following{/other_user}","gists_url":"https://api.github.com/users/mmahalwy/gists{/gist_id}","starred_url":"https://api.github.com/users/mmahalwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmahalwy/subscriptions","organizations_url":"https://api.github.com/users/mmahalwy/orgs","repos_url":"https://api.github.com/users/mmahalwy/repos","events_url":"https://api.github.com/users/mmahalwy/events{/privacy}","received_events_url":"https://api.github.com/users/mmahalwy/received_events","type":"User","site_admin":false},"created_at":"2016-07-10T15:36:31Z","updated_at":"2016-07-10T15:36:31Z","body":"@sabeurthabti this is awesome mashallah! Thanks for this\r\n\r\nre decorators: i do really like how you separated the `mapStateToProps` methods, should definitely do that myself too. As for decorators, I do see your point about them being bleeding edge. One thing that separating them will benefit us is testability, more specifically see: http://redux.js.org/docs/recipes/WritingTests.html#connected-components\r\n\r\nI do see your point but I really do like decorators, so I am torn. I think we should make a call and go with it. What do you think? "}}
{"actor":{"display_login":"mmahalwy"}}