{"action":"created","comment":{"url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/comments/83564735","pull_request_review_id":4398742,"id":83564735,"diff_hunk":"@@ -0,0 +1,285 @@\n+package ru.mipt.java2016.homework.g597.miller.task1;\n+\n+import ru.mipt.java2016.homework.base.task1.Calculator;\n+import ru.mipt.java2016.homework.base.task1.ParsingException;\n+\n+import java.util.Stack;\n+\n+/**\n+ * The implementation of Calculator.\n+ * Created by Vova Miller on 11.10.2016.\n+ */\n+\n+class MillerCalculator implements Calculator {\n+\n+    // Стек, содержащий постфиксную запись выражения.\n+    private Stack<String> postfix;","path":"homework-g597-miller/src/main/java/ru/mipt/java2016/homework/g597/miller/task1/MillerCalculator.java","position":15,"original_position":16,"commit_id":"23d9e9b3426809c92184a56291a84167014876ed","original_commit_id":"23d9e9b3426809c92184a56291a84167014876ed","user":{"login":"ignorer","id":4057463,"avatar_url":"https://avatars.githubusercontent.com/u/4057463?v=3","gravatar_id":"","url":"https://api.github.com/users/ignorer","html_url":"https://github.com/ignorer","followers_url":"https://api.github.com/users/ignorer/followers","following_url":"https://api.github.com/users/ignorer/following{/other_user}","gists_url":"https://api.github.com/users/ignorer/gists{/gist_id}","starred_url":"https://api.github.com/users/ignorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignorer/subscriptions","organizations_url":"https://api.github.com/users/ignorer/orgs","repos_url":"https://api.github.com/users/ignorer/repos","events_url":"https://api.github.com/users/ignorer/events{/privacy}","received_events_url":"https://api.github.com/users/ignorer/received_events","type":"User","site_admin":false},"body":"Та же проблема, что и у многих - поле выполнения функции `calculate()` стеки остаются висеть в памяти. Стоит их очищать, но стоит учитывать, что из функции `calculate()` может вылететь исключение, и тогда недостроенный стек для постфиксной записи будет занимать место в куче. Собственно, это фиксится очисткой коллекции в блоке finally в основной функции.\r\nА вообще если чуточку изменить код, можно было бы и не создавать это поле вовсе, сделав его возвращаемым значением функции `toPostfix()` и аргументом функции `calculateWithStack()`, но лучше уже с этим не заморачиваться.","created_at":"2016-10-17T00:23:49Z","updated_at":"2016-10-17T00:48:47Z","html_url":"https://github.com/fediq/mipt-java-2016/pull/101#discussion_r83564735","pull_request_url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/comments/83564735"},"html":{"href":"https://github.com/fediq/mipt-java-2016/pull/101#discussion_r83564735"},"pull_request":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101","id":89455207,"html_url":"https://github.com/fediq/mipt-java-2016/pull/101","diff_url":"https://github.com/fediq/mipt-java-2016/pull/101.diff","patch_url":"https://github.com/fediq/mipt-java-2016/pull/101.patch","issue_url":"https://api.github.com/repos/fediq/mipt-java-2016/issues/101","number":101,"state":"open","locked":false,"title":"g597.miller.task1","user":{"login":"VovaMiller","id":22771072,"avatar_url":"https://avatars.githubusercontent.com/u/22771072?v=3","gravatar_id":"","url":"https://api.github.com/users/VovaMiller","html_url":"https://github.com/VovaMiller","followers_url":"https://api.github.com/users/VovaMiller/followers","following_url":"https://api.github.com/users/VovaMiller/following{/other_user}","gists_url":"https://api.github.com/users/VovaMiller/gists{/gist_id}","starred_url":"https://api.github.com/users/VovaMiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VovaMiller/subscriptions","organizations_url":"https://api.github.com/users/VovaMiller/orgs","repos_url":"https://api.github.com/users/VovaMiller/repos","events_url":"https://api.github.com/users/VovaMiller/events{/privacy}","received_events_url":"https://api.github.com/users/VovaMiller/received_events","type":"User","site_admin":false},"body":"It must be stopped","created_at":"2016-10-14T21:08:50Z","updated_at":"2016-10-17T00:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48f55b552f4ec8472121ad64560acbf72ab369a8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101/commits","review_comments_url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101/comments","review_comment_url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fediq/mipt-java-2016/issues/101/comments","statuses_url":"https://api.github.com/repos/fediq/mipt-java-2016/statuses/23d9e9b3426809c92184a56291a84167014876ed","head":{"label":"VovaMiller:master","ref":"master","sha":"23d9e9b3426809c92184a56291a84167014876ed","user":{"login":"VovaMiller","id":22771072,"avatar_url":"https://avatars.githubusercontent.com/u/22771072?v=3","gravatar_id":"","url":"https://api.github.com/users/VovaMiller","html_url":"https://github.com/VovaMiller","followers_url":"https://api.github.com/users/VovaMiller/followers","following_url":"https://api.github.com/users/VovaMiller/following{/other_user}","gists_url":"https://api.github.com/users/VovaMiller/gists{/gist_id}","starred_url":"https://api.github.com/users/VovaMiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VovaMiller/subscriptions","organizations_url":"https://api.github.com/users/VovaMiller/orgs","repos_url":"https://api.github.com/users/VovaMiller/repos","events_url":"https://api.github.com/users/VovaMiller/events{/privacy}","received_events_url":"https://api.github.com/users/VovaMiller/received_events","type":"User","site_admin":false},"repo":{"id":70947324,"name":"mipt-java-2016","full_name":"VovaMiller/mipt-java-2016","owner":{"login":"VovaMiller","id":22771072,"avatar_url":"https://avatars.githubusercontent.com/u/22771072?v=3","gravatar_id":"","url":"https://api.github.com/users/VovaMiller","html_url":"https://github.com/VovaMiller","followers_url":"https://api.github.com/users/VovaMiller/followers","following_url":"https://api.github.com/users/VovaMiller/following{/other_user}","gists_url":"https://api.github.com/users/VovaMiller/gists{/gist_id}","starred_url":"https://api.github.com/users/VovaMiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VovaMiller/subscriptions","organizations_url":"https://api.github.com/users/VovaMiller/orgs","repos_url":"https://api.github.com/users/VovaMiller/repos","events_url":"https://api.github.com/users/VovaMiller/events{/privacy}","received_events_url":"https://api.github.com/users/VovaMiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VovaMiller/mipt-java-2016","description":"Практическая часть курса \"Программирование на Java\", 2016 год","fork":true,"url":"https://api.github.com/repos/VovaMiller/mipt-java-2016","forks_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/forks","keys_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/teams","hooks_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/hooks","issue_events_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/issues/events{/number}","events_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/events","assignees_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/assignees{/user}","branches_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/branches{/branch}","tags_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/tags","blobs_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/git/refs{/sha}","trees_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/statuses/{sha}","languages_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/languages","stargazers_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/stargazers","contributors_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/contributors","subscribers_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/subscribers","subscription_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/subscription","commits_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/commits{/sha}","git_commits_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/git/commits{/sha}","comments_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/comments{/number}","issue_comment_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/issues/comments{/number}","contents_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/contents/{+path}","compare_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/merges","archive_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/downloads","issues_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/issues{/number}","pulls_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/pulls{/number}","milestones_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/milestones{/number}","notifications_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/labels{/name}","releases_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/releases{/id}","deployments_url":"https://api.github.com/repos/VovaMiller/mipt-java-2016/deployments","created_at":"2016-10-14T21:06:40Z","updated_at":"2016-10-14T21:06:41Z","pushed_at":"2016-10-14T21:07:36Z","git_url":"git://github.com/VovaMiller/mipt-java-2016.git","ssh_url":"git@github.com:VovaMiller/mipt-java-2016.git","clone_url":"https://github.com/VovaMiller/mipt-java-2016.git","svn_url":"https://github.com/VovaMiller/mipt-java-2016","homepage":null,"size":228,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fediq:master","ref":"master","sha":"e49ad0115dc1f65666f8d5447799720aa5d79b22","user":{"login":"fediq","id":1057798,"avatar_url":"https://avatars.githubusercontent.com/u/1057798?v=3","gravatar_id":"","url":"https://api.github.com/users/fediq","html_url":"https://github.com/fediq","followers_url":"https://api.github.com/users/fediq/followers","following_url":"https://api.github.com/users/fediq/following{/other_user}","gists_url":"https://api.github.com/users/fediq/gists{/gist_id}","starred_url":"https://api.github.com/users/fediq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fediq/subscriptions","organizations_url":"https://api.github.com/users/fediq/orgs","repos_url":"https://api.github.com/users/fediq/repos","events_url":"https://api.github.com/users/fediq/events{/privacy}","received_events_url":"https://api.github.com/users/fediq/received_events","type":"User","site_admin":false},"repo":{"id":69496783,"name":"mipt-java-2016","full_name":"fediq/mipt-java-2016","owner":{"login":"fediq","id":1057798,"avatar_url":"https://avatars.githubusercontent.com/u/1057798?v=3","gravatar_id":"","url":"https://api.github.com/users/fediq","html_url":"https://github.com/fediq","followers_url":"https://api.github.com/users/fediq/followers","following_url":"https://api.github.com/users/fediq/following{/other_user}","gists_url":"https://api.github.com/users/fediq/gists{/gist_id}","starred_url":"https://api.github.com/users/fediq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fediq/subscriptions","organizations_url":"https://api.github.com/users/fediq/orgs","repos_url":"https://api.github.com/users/fediq/repos","events_url":"https://api.github.com/users/fediq/events{/privacy}","received_events_url":"https://api.github.com/users/fediq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fediq/mipt-java-2016","description":"Практическая часть курса \"Программирование на Java\", 2016 год","fork":false,"url":"https://api.github.com/repos/fediq/mipt-java-2016","forks_url":"https://api.github.com/repos/fediq/mipt-java-2016/forks","keys_url":"https://api.github.com/repos/fediq/mipt-java-2016/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fediq/mipt-java-2016/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fediq/mipt-java-2016/teams","hooks_url":"https://api.github.com/repos/fediq/mipt-java-2016/hooks","issue_events_url":"https://api.github.com/repos/fediq/mipt-java-2016/issues/events{/number}","events_url":"https://api.github.com/repos/fediq/mipt-java-2016/events","assignees_url":"https://api.github.com/repos/fediq/mipt-java-2016/assignees{/user}","branches_url":"https://api.github.com/repos/fediq/mipt-java-2016/branches{/branch}","tags_url":"https://api.github.com/repos/fediq/mipt-java-2016/tags","blobs_url":"https://api.github.com/repos/fediq/mipt-java-2016/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fediq/mipt-java-2016/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fediq/mipt-java-2016/git/refs{/sha}","trees_url":"https://api.github.com/repos/fediq/mipt-java-2016/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fediq/mipt-java-2016/statuses/{sha}","languages_url":"https://api.github.com/repos/fediq/mipt-java-2016/languages","stargazers_url":"https://api.github.com/repos/fediq/mipt-java-2016/stargazers","contributors_url":"https://api.github.com/repos/fediq/mipt-java-2016/contributors","subscribers_url":"https://api.github.com/repos/fediq/mipt-java-2016/subscribers","subscription_url":"https://api.github.com/repos/fediq/mipt-java-2016/subscription","commits_url":"https://api.github.com/repos/fediq/mipt-java-2016/commits{/sha}","git_commits_url":"https://api.github.com/repos/fediq/mipt-java-2016/git/commits{/sha}","comments_url":"https://api.github.com/repos/fediq/mipt-java-2016/comments{/number}","issue_comment_url":"https://api.github.com/repos/fediq/mipt-java-2016/issues/comments{/number}","contents_url":"https://api.github.com/repos/fediq/mipt-java-2016/contents/{+path}","compare_url":"https://api.github.com/repos/fediq/mipt-java-2016/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fediq/mipt-java-2016/merges","archive_url":"https://api.github.com/repos/fediq/mipt-java-2016/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fediq/mipt-java-2016/downloads","issues_url":"https://api.github.com/repos/fediq/mipt-java-2016/issues{/number}","pulls_url":"https://api.github.com/repos/fediq/mipt-java-2016/pulls{/number}","milestones_url":"https://api.github.com/repos/fediq/mipt-java-2016/milestones{/number}","notifications_url":"https://api.github.com/repos/fediq/mipt-java-2016/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fediq/mipt-java-2016/labels{/name}","releases_url":"https://api.github.com/repos/fediq/mipt-java-2016/releases{/id}","deployments_url":"https://api.github.com/repos/fediq/mipt-java-2016/deployments","created_at":"2016-09-28T19:29:28Z","updated_at":"2016-10-16T12:40:22Z","pushed_at":"2016-10-16T22:46:14Z","git_url":"git://github.com/fediq/mipt-java-2016.git","ssh_url":"git@github.com:fediq/mipt-java-2016.git","clone_url":"https://github.com/fediq/mipt-java-2016.git","svn_url":"https://github.com/fediq/mipt-java-2016","homepage":null,"size":930,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":22,"forks":85,"open_issues":22,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101"},"html":{"href":"https://github.com/fediq/mipt-java-2016/pull/101"},"issue":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/issues/101"},"comments":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/fediq/mipt-java-2016/statuses/23d9e9b3426809c92184a56291a84167014876ed"}}}}
{"actor":{"display_login":"ignorer"}}