{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleChrome/devsummit/issues/47","repository_url":"https://api.github.com/repos/GoogleChrome/devsummit","labels_url":"https://api.github.com/repos/GoogleChrome/devsummit/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/devsummit/issues/47/comments","events_url":"https://api.github.com/repos/GoogleChrome/devsummit/issues/47/events","html_url":"https://github.com/GoogleChrome/devsummit/issues/47","id":187266136,"number":47,"title":"Discussing lighthouse issues","user":{"login":"ramlmn","id":12368291,"avatar_url":"https://avatars.githubusercontent.com/u/12368291?v=3","gravatar_id":"","url":"https://api.github.com/users/ramlmn","html_url":"https://github.com/ramlmn","followers_url":"https://api.github.com/users/ramlmn/followers","following_url":"https://api.github.com/users/ramlmn/following{/other_user}","gists_url":"https://api.github.com/users/ramlmn/gists{/gist_id}","starred_url":"https://api.github.com/users/ramlmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramlmn/subscriptions","organizations_url":"https://api.github.com/users/ramlmn/orgs","repos_url":"https://api.github.com/users/ramlmn/repos","events_url":"https://api.github.com/users/ramlmn/events{/privacy}","received_events_url":"https://api.github.com/users/ramlmn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-04T07:00:44Z","updated_at":"2016-11-04T12:20:07Z","closed_at":"2016-11-04T12:20:07Z","body":"Issues:\r\n* **Not enough contrast ratio on some elements:**\r\n\r\n  *Problem:* The problem is text elements are placed on top of SVG's. Lighthouse assumes that these elements have a background color of nearest parent element(`body` in most cases, which has a background of `#fafafa`), even when these elements visually have background that of SVG's.\r\n\r\n  *Dirty fix:* Apply colors of SVG to any of the parent elements.\r\n\r\n  For example:\r\n  ``` html\r\n  <footer class=\"footer\">\r\n    <div class=\"footer__content\" role=\"presentation\">\r\n      <p>&copy; Google 2016</p>\r\n      <p>\r\n        <a target=\"_blank\" rel=\"noopener\" href=\"http://www.google.com/intl/en/policies/privacy/\">Privacy</a> &amp;\r\n        <a target=\"_blank\" rel=\"noopener\" href=\"http://www.google.com/intl/en/policies/terms/\">Terms</a>\r\n      </p>\r\n      <p>\r\n        <a href=\"/devsummit/code-of-conduct\">Code of Conduct</a>\r\n      </p>\r\n    </div>\r\n    <svg width=\"100%\" height=\"100%\" preserveAspectRatio=\"none\" viewBox=\"0 0 1224 302\">\r\n      <polygon x=\"0\" y=\"0\" fill=\"#F0F0F0\" points=\"0 20 1224 0 1224 302 0 302\"></polygon>\r\n      <polygon x=\"0\" y=\"0\" fill=\"#4D6BC3\" points=\"0 226 1224 194 1224 302 0 302\"></polygon>\r\n    </svg>\r\n  </footer>\r\n  ```\r\n  The color of svg(`#4D6BC3`) can be applied to `.footer__content > p` as `background-color`(and some other tweaks) so that lighthouse knows that.\r\n\r\n  This is a dirty hack, you may or may not like it, if you want Lighthouse score.\r\n\r\n* **No:** `<meta name=\"theme-color\">`"}}
{"actor":{"display_login":"paullewis"}}