{"action":"closed","number":43,"pull_request":{"url":"https://api.github.com/repos/infograf768/joomla-cms/pulls/43","id":85388002,"html_url":"https://github.com/infograf768/joomla-cms/pull/43","diff_url":"https://github.com/infograf768/joomla-cms/pull/43.diff","patch_url":"https://github.com/infograf768/joomla-cms/pull/43.patch","issue_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/43","number":43,"state":"closed","locked":false,"title":"Several Improvements","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"body":"I've made the following changes:\r\n* Rewrote `ContentHelperAssociation::displayAssociations()` quite a bit. It now only returns an array with the association item (the URL) and the language object instead of generated HTML. Also changed it so it only does one foreach on the language and not multiple times like it did before.\r\n* Registered the `ContentHelperAssociation` class in the components entry point so we don't have to load it in every view.\r\n* Rewrote the JLayout so it generates the HTML itself. It can be easily overriden by templates. It's now also reusable by other extensions.\r\n* Removed the \"Show_Flag\" param. If it is deemed necessary it can be added back and a conditional put into the JLayout and the `default_items` layout from the category view. It should even work on menuitem and article level now if needed.\r\n* The association data is now collected in the articles model and the article view respectively (same as other data like tags).\r\n","created_at":"2016-09-15T11:37:31Z","updated_at":"2016-09-16T06:59:40Z","closed_at":"2016-09-16T06:59:40Z","merged_at":null,"merge_commit_sha":"450c5b2d3fb1f7e25fdd339e4ec293b4987511eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls/43/commits","review_comments_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls/43/comments","review_comment_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/43/comments","statuses_url":"https://api.github.com/repos/infograf768/joomla-cms/statuses/4126471e6e74a6abb6c2f4eb257e5cce9b80edb1","head":{"label":"Bakual:newsaddassocfrontend","ref":"newsaddassocfrontend","sha":"4126471e6e74a6abb6c2f4eb257e5cce9b80edb1","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"repo":{"id":5132763,"name":"joomla-cms","full_name":"Bakual/joomla-cms","owner":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bakual/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Bakual/joomla-cms","forks_url":"https://api.github.com/repos/Bakual/joomla-cms/forks","keys_url":"https://api.github.com/repos/Bakual/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bakual/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bakual/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Bakual/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Bakual/joomla-cms/events","assignees_url":"https://api.github.com/repos/Bakual/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Bakual/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Bakual/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bakual/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bakual/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bakual/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Bakual/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Bakual/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Bakual/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Bakual/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Bakual/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Bakual/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bakual/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bakual/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bakual/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Bakual/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bakual/joomla-cms/merges","archive_url":"https://api.github.com/repos/Bakual/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bakual/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Bakual/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Bakual/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Bakual/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Bakual/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bakual/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Bakual/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Bakual/joomla-cms/deployments","created_at":"2012-07-21T10:15:11Z","updated_at":"2016-02-11T20:44:19Z","pushed_at":"2016-09-15T14:22:36Z","git_url":"git://github.com/Bakual/joomla-cms.git","ssh_url":"git@github.com:Bakual/joomla-cms.git","clone_url":"https://github.com/Bakual/joomla-cms.git","svn_url":"https://github.com/Bakual/joomla-cms","homepage":"http://joomla.org","size":157340,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"staging"}},"base":{"label":"infograf768:newsaddassocfrontend","ref":"newsaddassocfrontend","sha":"268391ba0198d4b69381c43e2edc88b6f6ea93e8","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"repo":{"id":3025712,"name":"joomla-cms","full_name":"infograf768/joomla-cms","owner":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infograf768/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/infograf768/joomla-cms","forks_url":"https://api.github.com/repos/infograf768/joomla-cms/forks","keys_url":"https://api.github.com/repos/infograf768/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infograf768/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infograf768/joomla-cms/teams","hooks_url":"https://api.github.com/repos/infograf768/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/infograf768/joomla-cms/events","assignees_url":"https://api.github.com/repos/infograf768/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/infograf768/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/infograf768/joomla-cms/tags","blobs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infograf768/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/infograf768/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infograf768/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/infograf768/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/infograf768/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/infograf768/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/infograf768/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/infograf768/joomla-cms/subscription","commits_url":"https://api.github.com/repos/infograf768/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/infograf768/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/infograf768/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/infograf768/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/infograf768/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infograf768/joomla-cms/merges","archive_url":"https://api.github.com/repos/infograf768/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infograf768/joomla-cms/downloads","issues_url":"https://api.github.com/repos/infograf768/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/infograf768/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/infograf768/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infograf768/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/infograf768/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/infograf768/joomla-cms/deployments","created_at":"2011-12-21T08:55:33Z","updated_at":"2016-02-15T02:03:35Z","pushed_at":"2016-09-16T06:53:16Z","git_url":"git://github.com/infograf768/joomla-cms.git","ssh_url":"git@github.com:infograf768/joomla-cms.git","clone_url":"https://github.com/infograf768/joomla-cms.git","svn_url":"https://github.com/infograf768/joomla-cms","homepage":"http://joomla.org","size":147344,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infograf768/joomla-cms/pulls/43"},"html":{"href":"https://github.com/infograf768/joomla-cms/pull/43"},"issue":{"href":"https://api.github.com/repos/infograf768/joomla-cms/issues/43"},"comments":{"href":"https://api.github.com/repos/infograf768/joomla-cms/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/infograf768/joomla-cms/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/infograf768/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infograf768/joomla-cms/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/infograf768/joomla-cms/statuses/4126471e6e74a6abb6c2f4eb257e5cce9b80edb1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":3,"additions":58,"deletions":67,"changed_files":10}}
{"actor":{"display_login":"infograf768"}}