{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments/89109301","pull_request_review_id":9654992,"id":89109301,"diff_hunk":"@@ -0,0 +1,86 @@\n+ -----  Name of requirement that is covered-----\n+ ----- Certificate have EMPTY in pt_preloaded JSON of module_config section\n+ ----- Verification criteria------\n+ -----  SDL must continue working as assigned.\n+\n+\n+--[[ General configuration parameters ]]\n+config.defaultProtocolVersion = 2\n+config.deviceMAC = \"12ca17b49af2289436f303e0166030a21e525d266e209267433801a8fd4071a0\"\n+\n+--[[ Required Shared libraries ]]  \n+local mobile_session = require('mobile_session')\n+local commonFunctions = require('user_modules/shared_testcases/commonFunctions')\n+local commonPreconditions = require('user_modules/shared_testcases/commonPreconditions')\n+local commonSteps = require('user_modules/shared_testcases/commonSteps')\n+local commonTestCases = require('user_modules/shared_testcases/commonTestCases')\n+NewTestSuiteNumber = 0\n+require('user_modules/AppTypes')\n+\n+--[[ Local preparing ]]\n+commonSteps:DeleteLogsFileAndPolicyTable()\n+Test = require('connecttest')\n+\n+\n+local function policyUpdate(self)\n+  local pathToSnaphot = nil\n+  EXPECT_HMICALL (\"BasicCommunication.PolicyUpdate\")\n+  :Do(function(_,data)\n+      pathToSnaphot = data.params.file\n+      self.hmiConnection:SendResponse(data.id, \"BasicCommunication.PolicyUpdate\", \"SUCCESS\", {})\n+    end)\n+   local RequestIdGetURLS = self.hmiConnection:SendRequest(\"SDL.GetURLS\", { service = 7 })\n+   EXPECT_HMIRESPONSE(RequestIdGetURLS,{result = {code = 0, method = \"SDL.GetURLS\", urls = {url = \"http://policies.telematics.ford.com/api/policies\"}}})\n+    :Do(function(_,data)\n+      self.hmiConnection:SendNotification(\"BasicCommunication.OnSystemRequest\",\n+        {\n+          requestType = \"PROPRIETARY\",\n+          url = \"http://policies.telematics.ford.com/api/policies\",\n+          appID = self.applications [\"Test Application\"],\n+          fileName = \"sdl_snapshot.json\"\n+        },\n+        pathToSnaphot\n+      )\n+    end)\n+  EXPECT_NOTIFICATION(\"OnSystemRequest\", {requestType = \"PROPRIETARY\" })\n+  :Do(function(_,data)\n+      local CorIdSystemRequest = self.mobileSession:SendRPC (\"SystemRequest\",\n+        {\n+          requestType = \"PROPRIETARY\",\n+          fileName = \"sdl_snapshot.json\"\n+        },\n+        pathToSnaphot\n+      )\n+   EXPECT_HMICALL(\"BasicCommunication.SystemRequest\")\n+     :Do(function(_,data)\n+          self.hmiConnection:SendResponse(data.id,\"BasicCommunication.SystemRequest\", \"SUCCESS\", {})\n+        end)\n+      EXPECT_RESPONSE(CorIdSystemRequest, {success = true, resultCode = \"SUCCESS\"})\n+      :Do(function(_,data)\n+          --Copy of JSON file in /tmp/fs/mp/images/ivsu_cache/\n+          --Example:os.execute(\"cp /home/anikolaev/OpenSDL_AUTOMATION/test_run/files/ptu.json /tmp/fs/mp/images/ivsu_cache/\")\n+          self.hmiConnection:SendNotification(\"SDL.OnReceivedPolicyUpdate\",\n+            {\n+              policyfile = \"/tmp/fs/mp/images/ivsu_cache/ptu.json\"\n+            })\n+        end)\n+      :Do(function(_,data)","path":"test_scripts/Polices/Policies_Security/003_ATF_P_PolicyTable_Certificate_EMPTY_value.lua","position":67,"original_position":67,"commit_id":"da22e7d0ce2440aee12afbd7286ea88d57b91de1","original_commit_id":"da22e7d0ce2440aee12afbd7286ea88d57b91de1","user":{"login":"aarotar","id":11179479,"avatar_url":"https://avatars.githubusercontent.com/u/11179479?v=3","gravatar_id":"","url":"https://api.github.com/users/aarotar","html_url":"https://github.com/aarotar","followers_url":"https://api.github.com/users/aarotar/followers","following_url":"https://api.github.com/users/aarotar/following{/other_user}","gists_url":"https://api.github.com/users/aarotar/gists{/gist_id}","starred_url":"https://api.github.com/users/aarotar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarotar/subscriptions","organizations_url":"https://api.github.com/users/aarotar/orgs","repos_url":"https://api.github.com/users/aarotar/repos","events_url":"https://api.github.com/users/aarotar/events{/privacy}","received_events_url":"https://api.github.com/users/aarotar/received_events","type":"User","site_admin":false},"body":"@Aleksandriys, avoid unused variables (data variable isn't used in function)","created_at":"2016-11-22T12:56:23Z","updated_at":"2016-11-22T13:04:10Z","html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/50#discussion_r89109301","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments/89109301"},"html":{"href":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/50#discussion_r89109301"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50","id":93929237,"html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/50","diff_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/50.diff","patch_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/50.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/50","number":50,"state":"open","locked":false,"title":"Added script for coverage Policies_Security","user":{"login":"Aleksandriys","id":20112650,"avatar_url":"https://avatars.githubusercontent.com/u/20112650?v=3","gravatar_id":"","url":"https://api.github.com/users/Aleksandriys","html_url":"https://github.com/Aleksandriys","followers_url":"https://api.github.com/users/Aleksandriys/followers","following_url":"https://api.github.com/users/Aleksandriys/following{/other_user}","gists_url":"https://api.github.com/users/Aleksandriys/gists{/gist_id}","starred_url":"https://api.github.com/users/Aleksandriys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aleksandriys/subscriptions","organizations_url":"https://api.github.com/users/Aleksandriys/orgs","repos_url":"https://api.github.com/users/Aleksandriys/repos","events_url":"https://api.github.com/users/Aleksandriys/events{/privacy}","received_events_url":"https://api.github.com/users/Aleksandriys/received_events","type":"User","site_admin":false},"body":"@aarotar \r\nPlease review.","created_at":"2016-11-16T09:29:00Z","updated_at":"2016-11-22T13:04:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9906c8f57c6c2350554bd4dcb2d9637f1101b4d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/50/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/da22e7d0ce2440aee12afbd7286ea88d57b91de1","head":{"label":"Aleksandriys:feature/policy_security/certificate_value_empty","ref":"feature/policy_security/certificate_value_empty","sha":"da22e7d0ce2440aee12afbd7286ea88d57b91de1","user":{"login":"Aleksandriys","id":20112650,"avatar_url":"https://avatars.githubusercontent.com/u/20112650?v=3","gravatar_id":"","url":"https://api.github.com/users/Aleksandriys","html_url":"https://github.com/Aleksandriys","followers_url":"https://api.github.com/users/Aleksandriys/followers","following_url":"https://api.github.com/users/Aleksandriys/following{/other_user}","gists_url":"https://api.github.com/users/Aleksandriys/gists{/gist_id}","starred_url":"https://api.github.com/users/Aleksandriys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aleksandriys/subscriptions","organizations_url":"https://api.github.com/users/Aleksandriys/orgs","repos_url":"https://api.github.com/users/Aleksandriys/repos","events_url":"https://api.github.com/users/Aleksandriys/events{/privacy}","received_events_url":"https://api.github.com/users/Aleksandriys/received_events","type":"User","site_admin":false},"repo":{"id":73716232,"name":"sdl_atf_test_scripts_smart","full_name":"Aleksandriys/sdl_atf_test_scripts_smart","owner":{"login":"Aleksandriys","id":20112650,"avatar_url":"https://avatars.githubusercontent.com/u/20112650?v=3","gravatar_id":"","url":"https://api.github.com/users/Aleksandriys","html_url":"https://github.com/Aleksandriys","followers_url":"https://api.github.com/users/Aleksandriys/followers","following_url":"https://api.github.com/users/Aleksandriys/following{/other_user}","gists_url":"https://api.github.com/users/Aleksandriys/gists{/gist_id}","starred_url":"https://api.github.com/users/Aleksandriys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aleksandriys/subscriptions","organizations_url":"https://api.github.com/users/Aleksandriys/orgs","repos_url":"https://api.github.com/users/Aleksandriys/repos","events_url":"https://api.github.com/users/Aleksandriys/events{/privacy}","received_events_url":"https://api.github.com/users/Aleksandriys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aleksandriys/sdl_atf_test_scripts_smart","description":"Test scripts for sdl_atf","fork":true,"url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart","forks_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/forks","keys_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/teams","hooks_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/hooks","issue_events_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/issues/events{/number}","events_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/events","assignees_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/assignees{/user}","branches_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/branches{/branch}","tags_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/tags","blobs_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/statuses/{sha}","languages_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/languages","stargazers_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/stargazers","contributors_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/contributors","subscribers_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/subscribers","subscription_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/subscription","commits_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/contents/{+path}","compare_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/merges","archive_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/downloads","issues_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/issues{/number}","pulls_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/pulls{/number}","milestones_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/milestones{/number}","notifications_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/labels{/name}","releases_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/releases{/id}","deployments_url":"https://api.github.com/repos/Aleksandriys/sdl_atf_test_scripts_smart/deployments","created_at":"2016-11-14T15:05:57Z","updated_at":"2016-11-14T15:06:29Z","pushed_at":"2016-11-18T15:05:16Z","git_url":"git://github.com/Aleksandriys/sdl_atf_test_scripts_smart.git","ssh_url":"git@github.com:Aleksandriys/sdl_atf_test_scripts_smart.git","clone_url":"https://github.com/Aleksandriys/sdl_atf_test_scripts_smart.git","svn_url":"https://github.com/Aleksandriys/sdl_atf_test_scripts_smart","homepage":null,"size":18123,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"32470acce04be350b62fa8c7af74d57f2a76bf60","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":53459525,"name":"sdl_atf_test_scripts","full_name":"smartdevicelink/sdl_atf_test_scripts","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts","description":"Test scripts for sdl_atf","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/deployments","created_at":"2016-03-09T01:53:02Z","updated_at":"2016-04-27T09:25:04Z","pushed_at":"2016-11-22T07:50:17Z","git_url":"git://github.com/smartdevicelink/sdl_atf_test_scripts.git","ssh_url":"git@github.com:smartdevicelink/sdl_atf_test_scripts.git","clone_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts.git","svn_url":"https://github.com/smartdevicelink/sdl_atf_test_scripts","homepage":null,"size":18216,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":68,"forks":20,"open_issues":68,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50"},"html":{"href":"https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/50"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/50"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_atf_test_scripts/statuses/da22e7d0ce2440aee12afbd7286ea88d57b91de1"}}}}
{"actor":{"display_login":"aarotar"}}