{"push_id":1146133899,"size":11,"distinct_size":11,"ref":"refs/heads/master","head":"a04852716b47d4264fae39318ce2d27b32873ae4","before":"e6fe38fa36d62e3f2ff6c1ea9e70b4f6bc3bd395","commits":[{"sha":"91e1003378978ade103f9c65db5b7e4ae59cba4e","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(TK-366) Remove timeout arg from borrow-with-timeout\n\nPreviously, `borrow-from-pool-with-timeout` took both `pool-contxt` and\n`borrow-timeout` as args. However, the borrow timeout used by this function is\nalready in the config attached to the pool context. This commit simplifies the\ncall users will have to make to `borrow-from-pool-with-timeout` by removing this\nredundant argument","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/91e1003378978ade103f9c65db5b7e4ae59cba4e"},{"sha":"977d879bcb53f7f238d07caedcbfb4cb58046f37","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(maint) Remove duplicate test\n\nPreviously the `basic-flush-test` in `jruby-agents-test` and `flush-pool-test`\nin `jruby-pool-int-test` duplicated eachother. This commit removes\n`basic-flush-test`, since `flush-pool-test` is able to take advantage of test\nhelpers in the int test namespace that make it somewhat cleaner.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/977d879bcb53f7f238d07caedcbfb4cb58046f37"},{"sha":"9ace9f0910a8e50ac242157c0f804025cbb184ed","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(TK-366) Remove JRuby TK service\n\nRemove the jruby-pool TK service and protocol. Instead of this service, users\nof this library will use the `pool-manager-service` to create a pool context,\nand then pass that pool context to the functions in the `jruby-core`\nnamespace, to borrow, return, and flush instances.\n\nMove the `with-lock` and `with-jruby-instance` macros out of the service and\ninto the `jruby-core` namespace. Add a core `register-event-handler` function.\n\nAdd a test TK service to the `jruby-service-test` namespace to test that a TK\nservice that depends on the new pool-manager-service and uses its\n`create-pool` works as expected. Replace the\n`test-pool-population-during-init` test in this namespace with unit tests -\nthe logic of this test is specific to puppet server, and there should be an\nintegration test in the puppet server repo for puppet server's logic. The unit\ntests added test that a borrow will block on the pool being initialized and\nthat a borrow will block until an instance becomes available.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/9ace9f0910a8e50ac242157c0f804025cbb184ed"},{"sha":"fffcca6a0932dab207e3c863efa21ecd3db916e7","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(TK-366) Remove top-level :jruby key\n\nPreviously, `create-pool` required as input a config without a top level\n`:jruby` key, but `initialize-config` took in a map with a top level `:jruby`\nkey and returned a map without this key. This commit updates\n`initialize-config` to need a top level `:jruby` key, so that it is consistent\nwith `create-pool`.\n\nIn addition, update `cli-run!` to not call `initialize-config`, and require\nthe config passed into `cli-run!` and `cli-ruby!` to match the JRubyConfig\nschema. This matches the behavior of `create-pool` - thus any time we\ninstantiate JRuby containers, we require users to pass in a pre-munged config\nthat matches the schema. Users can use `initialize-config` to munge the config\nand provide defaults, or they can do their own munging.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/fffcca6a0932dab207e3c863efa21ecd3db916e7"},{"sha":"ec1b068f41fd71a3556fa2cab497020c93405252","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(main) Add a foo.rb file and have cli tests use it to do a require\n\nPreviously there were several tests commented out because the required puppet\nto be on the ruby load path, and we don't want puppet to be a dependency (even\na test one) of this library. This commit adds a `foo.rb` ruby file with a\nsingle method, `foo` that returns the string `bar`. This file can then be\ncalled from the tests to make sure that the `ruby` and `irb` commands can\nrequire a library on the load path.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/ec1b068f41fd71a3556fa2cab497020c93405252"},{"sha":"f6b1cf3a9ead83c7abd03daa894551b63c61adbb","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(maint) Rename alias `core` to `jruby-core`\n\nPreviously, the `jruby-core` namespace was sometimes required with the alias\n`core` and sometimes with the alias `jruby-core`. This commit updates several\nrequires so that this project consistently uses `jruby-core` as the alias.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/f6b1cf3a9ead83c7abd03daa894551b63c61adbb"},{"sha":"a8f519c7e1d784b063e9caa9823ec43f17c88b03","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(maint) Use consistent alias for trapperkeeper bootstrap testutils\n\nChange all aliases of puppetlabs.trapperkeeper.testutils.bootstrap to\ntk-bootstrap for consistency.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/a8f519c7e1d784b063e9caa9823ec43f17c88b03"},{"sha":"8af1aae87d9cd49bab0b471247fff5cd78336675","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(TK-366) Update tests to not rely on knowledge of `create-pool` implementation\n\nPreviously, rather than using the `create-pool` service function from the\npool-manager-service, several tests called `create-pool-context` and\n`prime-pool!` themselves, meaning they were relying on knowledge of the\nimplementation of `create-pool`. Users should never call `create-pool-context`\nthemselves.\n\nThis test updates several of these tests to use `create-pool` instead. A few\ntests were left calling `create-pool-context` and `prime-pool!`, since they\nare specifically testing `prime-pool!`'s behavior, rather than using these\nfunctions to get a pool-context to use in other tests.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/8af1aae87d9cd49bab0b471247fff5cd78336675"},{"sha":"5df915745884e23c0cf70b27d3468d6ed79b04cf","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(TK-366) Update docstring for borrow-from-pool-with-timeout\n\nUpdate docstring for borrow-from-pool-with-timeout to say that the\nborrow-timeout used is pulled from the config on the pool-context.\n\nAdd a TODO to consider adding a second arity of this function, for passing in\na custom borrow-timeout.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/5df915745884e23c0cf70b27d3468d6ed79b04cf"},{"sha":"864ff7eb8f04be28208525fa91301a2bf8d79541","author":{"name":"Ruth Linehan","email":"aa63b9e6b1afaa3eb088557644df488a72bd3680@puppetlabs.com"},"message":"(TK-366) Add event-callbacks to pool-context\n\nAdd the event-callbacks atom to the pool-context so that the\n`with-jruby-instance` and `with-lock` macros do not require it to be passed\nin.\n\nNote that the other core functions - e.g. `borrow-from-pool(-with-timeout)`,\n`return-to-pool`, 'lock', 'unlock', and the flush functions were not updated\nto not have `event-callbacks` as an arg because most of these do not take\n`pool-context` as an arg, and they already required `event-callbacks` as an\narg, whereas the macros previously existed in the service and pulled the\n`event-callbacks` from the service context.","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/864ff7eb8f04be28208525fa91301a2bf8d79541"},{"sha":"a04852716b47d4264fae39318ce2d27b32873ae4","author":{"name":"Joe Pinsonault","email":"57cce5d432af2ca078cbf6decea9901b0fffc72e@gmail.com"},"message":"Merge pull request #10 from rlinehan/TK-366-remove-tk-service\n\n(TK-366) Remove JRuby TK service","distinct":true,"url":"https://api.github.com/repos/puppetlabs/jruby-utils/commits/a04852716b47d4264fae39318ce2d27b32873ae4"}]}
{"actor":{"display_login":"jpinsonault"}}