{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/55119498","id":55119498,"diff_hunk":"@@ -23,9 +25,23 @@ module.exports = Command.extend({\n       analytics: this.analytics,\n       project: this.project\n     });\n+    var ShowAssetSizesTask = this.tasks.ShowAssetSizes;\n+    var showTask = new ShowAssetSizesTask({\n+      ui: this.ui\n+    });\n \n-    return win.checkWindowsElevation(this.ui).then(function() {\n-      return buildTask.run(commandOptions);\n+    return win.checkWindowsElevation(this.ui).then(function () {\n+      return Promise.resolve()","path":"lib/commands/build.js","position":36,"original_position":36,"commit_id":"e1b96c33efa67bb6584858b9db7299a33228c667","original_commit_id":"e1b96c33efa67bb6584858b9db7299a33228c667","user":{"login":"Turbo87","id":141300,"avatar_url":"https://avatars.githubusercontent.com/u/141300?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbo87","html_url":"https://github.com/Turbo87","followers_url":"https://api.github.com/users/Turbo87/followers","following_url":"https://api.github.com/users/Turbo87/following{/other_user}","gists_url":"https://api.github.com/users/Turbo87/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbo87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbo87/subscriptions","organizations_url":"https://api.github.com/users/Turbo87/orgs","repos_url":"https://api.github.com/users/Turbo87/repos","events_url":"https://api.github.com/users/Turbo87/events{/privacy}","received_events_url":"https://api.github.com/users/Turbo87/received_events","type":"User","site_admin":false},"body":"why do you use nested promises here instead of `then()` chaining?","created_at":"2016-03-05T10:50:26Z","updated_at":"2016-03-05T10:50:26Z","html_url":"https://github.com/ember-cli/ember-cli/pull/4358#discussion_r55119498","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments/55119498"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/4358#discussion_r55119498"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358","id":38738865,"html_url":"https://github.com/ember-cli/ember-cli/pull/4358","diff_url":"https://github.com/ember-cli/ember-cli/pull/4358.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/4358.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358","number":4358,"state":"open","locked":false,"title":"[ENHANCEMENT] Output build sizes command","user":{"login":"martypenner","id":1819798,"avatar_url":"https://avatars.githubusercontent.com/u/1819798?v=3","gravatar_id":"","url":"https://api.github.com/users/martypenner","html_url":"https://github.com/martypenner","followers_url":"https://api.github.com/users/martypenner/followers","following_url":"https://api.github.com/users/martypenner/following{/other_user}","gists_url":"https://api.github.com/users/martypenner/gists{/gist_id}","starred_url":"https://api.github.com/users/martypenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martypenner/subscriptions","organizations_url":"https://api.github.com/users/martypenner/orgs","repos_url":"https://api.github.com/users/martypenner/repos","events_url":"https://api.github.com/users/martypenner/events{/privacy}","received_events_url":"https://api.github.com/users/martypenner/received_events","type":"User","site_admin":false},"body":"This is a very naive implementation that simply checks the given asset path (`dist/assets` by default) for any `*.{css,js}` files and outputs their human-readable size. I chose to do it this way because of lack of access to the output tree when running this command.\r\n\r\nThe command itself is run like this: `ember show-asset-sizes`. If assets are stored in a non-standard directory, run `ember show-asset-sizes --asset-path path/to/assets`. The command name is a bit verbose, but I wasn't sure of a better name that would also convey the meaning.\r\n\r\nSome notes:\r\n- The command tests in `show-asset-sizes-test.js` are failing with \"undefined is not a function\". I cannot for the life of me seem to figure out what's going on there. Doing anything but `return`ing the command promise in the tests passes. As soon as I try to `return` the promise, the tests fail. My node-fu is weak.\r\n- It does not run the `Builder` like the `serve` or `test` tasks do. I thought rebuilding the project might be frustrating when simply trying to see your asset sizes. If the asset directory can't be found, the task throws an error instead. If we decide to run the `Builder` in this task, then we could get rid of the cli argument for the asset path.\r\n\r\n#4293","created_at":"2015-06-29T03:16:34Z","updated_at":"2016-03-05T10:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7afec58832943d3e22341d93cb1f6b922c62ea59","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/e1b96c33efa67bb6584858b9db7299a33228c667","head":{"label":"martypenner:output-build-sizes","ref":"output-build-sizes","sha":"e1b96c33efa67bb6584858b9db7299a33228c667","user":{"login":"martypenner","id":1819798,"avatar_url":"https://avatars.githubusercontent.com/u/1819798?v=3","gravatar_id":"","url":"https://api.github.com/users/martypenner","html_url":"https://github.com/martypenner","followers_url":"https://api.github.com/users/martypenner/followers","following_url":"https://api.github.com/users/martypenner/following{/other_user}","gists_url":"https://api.github.com/users/martypenner/gists{/gist_id}","starred_url":"https://api.github.com/users/martypenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martypenner/subscriptions","organizations_url":"https://api.github.com/users/martypenner/orgs","repos_url":"https://api.github.com/users/martypenner/repos","events_url":"https://api.github.com/users/martypenner/events{/privacy}","received_events_url":"https://api.github.com/users/martypenner/received_events","type":"User","site_admin":false},"repo":{"id":37422178,"name":"ember-cli","full_name":"martypenner/ember-cli","owner":{"login":"martypenner","id":1819798,"avatar_url":"https://avatars.githubusercontent.com/u/1819798?v=3","gravatar_id":"","url":"https://api.github.com/users/martypenner","html_url":"https://github.com/martypenner","followers_url":"https://api.github.com/users/martypenner/followers","following_url":"https://api.github.com/users/martypenner/following{/other_user}","gists_url":"https://api.github.com/users/martypenner/gists{/gist_id}","starred_url":"https://api.github.com/users/martypenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martypenner/subscriptions","organizations_url":"https://api.github.com/users/martypenner/orgs","repos_url":"https://api.github.com/users/martypenner/repos","events_url":"https://api.github.com/users/martypenner/events{/privacy}","received_events_url":"https://api.github.com/users/martypenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martypenner/ember-cli","description":"","fork":true,"url":"https://api.github.com/repos/martypenner/ember-cli","forks_url":"https://api.github.com/repos/martypenner/ember-cli/forks","keys_url":"https://api.github.com/repos/martypenner/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martypenner/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martypenner/ember-cli/teams","hooks_url":"https://api.github.com/repos/martypenner/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/martypenner/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/martypenner/ember-cli/events","assignees_url":"https://api.github.com/repos/martypenner/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/martypenner/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/martypenner/ember-cli/tags","blobs_url":"https://api.github.com/repos/martypenner/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martypenner/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martypenner/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/martypenner/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martypenner/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/martypenner/ember-cli/languages","stargazers_url":"https://api.github.com/repos/martypenner/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/martypenner/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/martypenner/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/martypenner/ember-cli/subscription","commits_url":"https://api.github.com/repos/martypenner/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/martypenner/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/martypenner/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/martypenner/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/martypenner/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/martypenner/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martypenner/ember-cli/merges","archive_url":"https://api.github.com/repos/martypenner/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martypenner/ember-cli/downloads","issues_url":"https://api.github.com/repos/martypenner/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/martypenner/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/martypenner/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/martypenner/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martypenner/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/martypenner/ember-cli/releases{/id}","deployments_url":"https://api.github.com/repos/martypenner/ember-cli/deployments","created_at":"2015-06-14T17:27:03Z","updated_at":"2016-01-12T15:39:43Z","pushed_at":"2016-02-20T18:00:28Z","git_url":"git://github.com/martypenner/ember-cli.git","ssh_url":"git@github.com:martypenner/ember-cli.git","clone_url":"https://github.com/martypenner/ember-cli.git","svn_url":"https://github.com/martypenner/ember-cli","homepage":"http://www.ember-cli.com/","size":6948,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"8f763af7b63a8594636c9b036a12da1c88800c1a","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":14089735,"name":"ember-cli","full_name":"ember-cli/ember-cli","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli","description":"","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli","forks_url":"https://api.github.com/repos/ember-cli/ember-cli/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/ember-cli/deployments","created_at":"2013-11-03T17:34:43Z","updated_at":"2016-03-03T23:01:49Z","pushed_at":"2016-03-05T10:02:12Z","git_url":"git://github.com/ember-cli/ember-cli.git","ssh_url":"git@github.com:ember-cli/ember-cli.git","clone_url":"https://github.com/ember-cli/ember-cli.git","svn_url":"https://github.com/ember-cli/ember-cli","homepage":"http://ember-cli.com/","size":17424,"stargazers_count":2801,"watchers_count":2801,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":809,"mirror_url":null,"open_issues_count":144,"forks":809,"open_issues":144,"watchers":2801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358"},"html":{"href":"https://github.com/ember-cli/ember-cli/pull/4358"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/issues/4358/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli/pulls/4358/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli/statuses/e1b96c33efa67bb6584858b9db7299a33228c667"}}}}