{"action":"created","issue":{"url":"https://api.github.com/repos/JBKahn/django-sharding/issues/31","repository_url":"https://api.github.com/repos/JBKahn/django-sharding","labels_url":"https://api.github.com/repos/JBKahn/django-sharding/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/JBKahn/django-sharding/issues/31/comments","events_url":"https://api.github.com/repos/JBKahn/django-sharding/issues/31/events","html_url":"https://github.com/JBKahn/django-sharding/pull/31","id":171718029,"number":31,"title":"Django 1.10 compat","user":{"login":"JBKahn","id":2654653,"avatar_url":"https://avatars.githubusercontent.com/u/2654653?v=3","gravatar_id":"","url":"https://api.github.com/users/JBKahn","html_url":"https://github.com/JBKahn","followers_url":"https://api.github.com/users/JBKahn/followers","following_url":"https://api.github.com/users/JBKahn/following{/other_user}","gists_url":"https://api.github.com/users/JBKahn/gists{/gist_id}","starred_url":"https://api.github.com/users/JBKahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBKahn/subscriptions","organizations_url":"https://api.github.com/users/JBKahn/orgs","repos_url":"https://api.github.com/users/JBKahn/repos","events_url":"https://api.github.com/users/JBKahn/events{/privacy}","received_events_url":"https://api.github.com/users/JBKahn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-08-17T17:44:18Z","updated_at":"2016-08-17T21:48:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JBKahn/django-sharding/pulls/31","html_url":"https://github.com/JBKahn/django-sharding/pull/31","diff_url":"https://github.com/JBKahn/django-sharding/pull/31.diff","patch_url":"https://github.com/JBKahn/django-sharding/pull/31.patch"},"body":"Ensure all the tests are working and all seems good for Django 1.10\r\n\r\nscrewing around trying to figure out  a hacky way to make it work didn't work but I got this far and almost closed the terminal without copying it down:\r\n```\r\nipdb> cls._meta.add_manager\r\n<bound method Options.add_manager of <Options for TestModel>>\r\nipdb> cls._meta.add_manager(ShardManager())\r\nipdb> cls._meta.managers_map\r\n{u'objects': <django.db.models.manager.Manager object at 0x7f22070741d0>, None: <class 'django_sharding_library.manager.ShardManager'>}\r\nipdb> cls._meta.managers_map['objects'] = cls._meta.managers_map[None]\r\n```\r\n\r\nthe changes to `add_to_class` seem to have broken this. The above code works in place but doesn't persist."},"comment":{"url":"https://api.github.com/repos/JBKahn/django-sharding/issues/comments/240559899","html_url":"https://github.com/JBKahn/django-sharding/pull/31#issuecomment-240559899","issue_url":"https://api.github.com/repos/JBKahn/django-sharding/issues/31","id":240559899,"user":{"login":"JBKahn","id":2654653,"avatar_url":"https://avatars.githubusercontent.com/u/2654653?v=3","gravatar_id":"","url":"https://api.github.com/users/JBKahn","html_url":"https://github.com/JBKahn","followers_url":"https://api.github.com/users/JBKahn/followers","following_url":"https://api.github.com/users/JBKahn/following{/other_user}","gists_url":"https://api.github.com/users/JBKahn/gists{/gist_id}","starred_url":"https://api.github.com/users/JBKahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JBKahn/subscriptions","organizations_url":"https://api.github.com/users/JBKahn/orgs","repos_url":"https://api.github.com/users/JBKahn/repos","events_url":"https://api.github.com/users/JBKahn/events{/privacy}","received_events_url":"https://api.github.com/users/JBKahn/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T21:48:57Z","updated_at":"2016-08-17T21:48:57Z","body":"@4word I fiddled with this a bit more, just the failing cases around detecting wether you chose to override the manager seem more complex on Django 1.10, can I get your help with this since I'm not really familiar with using managers."}}
{"actor":{"display_login":"JBKahn"}}