{"action":"created","issue":{"url":"https://api.github.com/repos/mpetroff/pannellum/issues/166","repository_url":"https://api.github.com/repos/mpetroff/pannellum","labels_url":"https://api.github.com/repos/mpetroff/pannellum/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/mpetroff/pannellum/issues/166/comments","events_url":"https://api.github.com/repos/mpetroff/pannellum/issues/166/events","html_url":"https://github.com/mpetroff/pannellum/pull/166","id":160345788,"number":166,"title":"Prevent empty values in URL config from stopping panorama rendering","user":{"login":"jannecederberg","id":2441319,"avatar_url":"https://avatars.githubusercontent.com/u/2441319?v=3","gravatar_id":"","url":"https://api.github.com/users/jannecederberg","html_url":"https://github.com/jannecederberg","followers_url":"https://api.github.com/users/jannecederberg/followers","following_url":"https://api.github.com/users/jannecederberg/following{/other_user}","gists_url":"https://api.github.com/users/jannecederberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jannecederberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannecederberg/subscriptions","organizations_url":"https://api.github.com/users/jannecederberg/orgs","repos_url":"https://api.github.com/users/jannecederberg/repos","events_url":"https://api.github.com/users/jannecederberg/events{/privacy}","received_events_url":"https://api.github.com/users/jannecederberg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-15T06:13:22Z","updated_at":"2016-06-18T09:16:18Z","closed_at":"2016-06-17T16:38:35Z","pull_request":{"url":"https://api.github.com/repos/mpetroff/pannellum/pulls/166","html_url":"https://github.com/mpetroff/pannellum/pull/166","diff_url":"https://github.com/mpetroff/pannellum/pull/166.diff","patch_url":"https://github.com/mpetroff/pannellum/pull/166.patch"},"body":"Should the user use URL configuration for their panorama and then specify an option/key but leave the value empty, previously this would stop the panorama from being displayed due to the generated JSON config from src/standalone/standalone.js being invalid.\r\n\r\nThis commit omits creating an on-the-fly JSON string and instead uses a JavaScript object (which the generated JSON string was converted to anyway).\r\n\r\nThe background of wanting to enable URL options with possibly empty values relates to using Pannellum with static site generators. Depending on the static site generator, specifying default values for undefined template variables can result in lots of template notation whereas outputting a value for a variable that isn't defined usuallly simply outputs an empty string. It would hence be desirable to treat the empty-string value of an option/key in URL config as if that option/key were not user-supplied at all and hence the Pannellum default value for that option/key be used."},"comment":{"url":"https://api.github.com/repos/mpetroff/pannellum/issues/comments/226931582","html_url":"https://github.com/mpetroff/pannellum/pull/166#issuecomment-226931582","issue_url":"https://api.github.com/repos/mpetroff/pannellum/issues/166","id":226931582,"user":{"login":"jannecederberg","id":2441319,"avatar_url":"https://avatars.githubusercontent.com/u/2441319?v=3","gravatar_id":"","url":"https://api.github.com/users/jannecederberg","html_url":"https://github.com/jannecederberg","followers_url":"https://api.github.com/users/jannecederberg/followers","following_url":"https://api.github.com/users/jannecederberg/following{/other_user}","gists_url":"https://api.github.com/users/jannecederberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jannecederberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannecederberg/subscriptions","organizations_url":"https://api.github.com/users/jannecederberg/orgs","repos_url":"https://api.github.com/users/jannecederberg/repos","events_url":"https://api.github.com/users/jannecederberg/events{/privacy}","received_events_url":"https://api.github.com/users/jannecederberg/received_events","type":"User","site_admin":false},"created_at":"2016-06-18T09:16:18Z","updated_at":"2016-06-18T09:16:18Z","body":"Ok, great, thank you and welcome!"}}
{"actor":{"display_login":"jannecederberg"}}