{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/76924097","id":76924097,"diff_hunk":"@@ -91,6 +92,11 @@\n      */\n     private final ClassLoader loader;\n \n+    /**\n+     * Ensures that the deprecation log entry for Groovy is only written on the first Groovy script compiled.\n+     */\n+    private AtomicBoolean isDeprecationLogged = new AtomicBoolean(false);","path":"modules/lang-groovy/src/main/java/org/elasticsearch/script/groovy/GroovyScriptEngineService.java","position":15,"original_position":15,"commit_id":"3077060147d2f44c992ff7ca4e89dbbc5af53ab6","original_commit_id":"3077060147d2f44c992ff7ca4e89dbbc5af53ab6","user":{"login":"pickypg","id":1501235,"avatar_url":"https://avatars.githubusercontent.com/u/1501235?v=3","gravatar_id":"","url":"https://api.github.com/users/pickypg","html_url":"https://github.com/pickypg","followers_url":"https://api.github.com/users/pickypg/followers","following_url":"https://api.github.com/users/pickypg/following{/other_user}","gists_url":"https://api.github.com/users/pickypg/gists{/gist_id}","starred_url":"https://api.github.com/users/pickypg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pickypg/subscriptions","organizations_url":"https://api.github.com/users/pickypg/orgs","repos_url":"https://api.github.com/users/pickypg/repos","events_url":"https://api.github.com/users/pickypg/events{/privacy}","received_events_url":"https://api.github.com/users/pickypg/received_events","type":"User","site_admin":false},"body":"I don't know that we want to limit it to only the first compilation. We may also want to warn on each use as well (search and execution so that users know where they're using them if it's hidden away in some existing code somewhere).\r\n\r\nSpecifically, if they are using file-based scripts, then we lose the other half of deprecation logging, which is the `Warning` header that gets sent back to HTTP clients starting in 5.0. I'd want to complain often and loudly. Since it's just like any other logger, they can just disable `deprecation.script.groovy` deprecation logging if they choose to do it.\r\n\r\n----\r\n\r\nIf we do keep it, then this should be `final`.","created_at":"2016-08-31T04:48:52Z","updated_at":"2016-08-31T04:48:52Z","html_url":"https://github.com/elastic/elasticsearch/pull/20244#discussion_r76924097","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/76924097"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/20244#discussion_r76924097"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244","id":83377850,"html_url":"https://github.com/elastic/elasticsearch/pull/20244","diff_url":"https://github.com/elastic/elasticsearch/pull/20244.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/20244.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20244","number":20244,"state":"open","locked":false,"title":"Deprecate Groovy, Python, and Javascript","user":{"login":"jdconrad","id":2126764,"avatar_url":"https://avatars.githubusercontent.com/u/2126764?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconrad","html_url":"https://github.com/jdconrad","followers_url":"https://api.github.com/users/jdconrad/followers","following_url":"https://api.github.com/users/jdconrad/following{/other_user}","gists_url":"https://api.github.com/users/jdconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconrad/subscriptions","organizations_url":"https://api.github.com/users/jdconrad/orgs","repos_url":"https://api.github.com/users/jdconrad/repos","events_url":"https://api.github.com/users/jdconrad/events{/privacy}","received_events_url":"https://api.github.com/users/jdconrad/received_events","type":"User","site_admin":false},"body":"As the title says.\r\n\r\nSee (#20129)","created_at":"2016-08-31T02:12:20Z","updated_at":"2016-08-31T04:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c483e92a2340b7c51004ab92b9637bc4d16fc18c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20244/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/3077060147d2f44c992ff7ca4e89dbbc5af53ab6","head":{"label":"jdconrad:deprecate","ref":"deprecate","sha":"3077060147d2f44c992ff7ca4e89dbbc5af53ab6","user":{"login":"jdconrad","id":2126764,"avatar_url":"https://avatars.githubusercontent.com/u/2126764?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconrad","html_url":"https://github.com/jdconrad","followers_url":"https://api.github.com/users/jdconrad/followers","following_url":"https://api.github.com/users/jdconrad/following{/other_user}","gists_url":"https://api.github.com/users/jdconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconrad/subscriptions","organizations_url":"https://api.github.com/users/jdconrad/orgs","repos_url":"https://api.github.com/users/jdconrad/repos","events_url":"https://api.github.com/users/jdconrad/events{/privacy}","received_events_url":"https://api.github.com/users/jdconrad/received_events","type":"User","site_admin":false},"repo":{"id":33491776,"name":"elasticsearch","full_name":"jdconrad/elasticsearch","owner":{"login":"jdconrad","id":2126764,"avatar_url":"https://avatars.githubusercontent.com/u/2126764?v=3","gravatar_id":"","url":"https://api.github.com/users/jdconrad","html_url":"https://github.com/jdconrad","followers_url":"https://api.github.com/users/jdconrad/followers","following_url":"https://api.github.com/users/jdconrad/following{/other_user}","gists_url":"https://api.github.com/users/jdconrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jdconrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdconrad/subscriptions","organizations_url":"https://api.github.com/users/jdconrad/orgs","repos_url":"https://api.github.com/users/jdconrad/repos","events_url":"https://api.github.com/users/jdconrad/events{/privacy}","received_events_url":"https://api.github.com/users/jdconrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdconrad/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jdconrad/elasticsearch","forks_url":"https://api.github.com/repos/jdconrad/elasticsearch/forks","keys_url":"https://api.github.com/repos/jdconrad/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdconrad/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdconrad/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jdconrad/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jdconrad/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jdconrad/elasticsearch/events","assignees_url":"https://api.github.com/repos/jdconrad/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jdconrad/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jdconrad/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdconrad/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jdconrad/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jdconrad/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jdconrad/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jdconrad/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jdconrad/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jdconrad/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdconrad/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdconrad/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdconrad/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdconrad/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jdconrad/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdconrad/elasticsearch/merges","archive_url":"https://api.github.com/repos/jdconrad/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdconrad/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jdconrad/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jdconrad/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jdconrad/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jdconrad/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdconrad/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jdconrad/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jdconrad/elasticsearch/deployments","created_at":"2015-04-06T16:19:42Z","updated_at":"2016-01-19T17:54:08Z","pushed_at":"2016-08-31T02:10:07Z","git_url":"git://github.com/jdconrad/elasticsearch.git","ssh_url":"git@github.com:jdconrad/elasticsearch.git","clone_url":"https://github.com/jdconrad/elasticsearch.git","svn_url":"https://github.com/jdconrad/elasticsearch","homepage":"http://elasticsearch.org","size":212685,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a68083f5cba18c9c109c99aafd758ebccbfdcbb8","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-08-31T02:13:29Z","pushed_at":"2016-08-31T02:31:00Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":343588,"stargazers_count":18192,"watchers_count":18192,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6162,"mirror_url":null,"open_issues_count":1128,"forks":6162,"open_issues":1128,"watchers":18192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/20244"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/20244"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/20244/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/20244/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/3077060147d2f44c992ff7ca4e89dbbc5af53ab6"}}}}
{"actor":{"display_login":"pickypg"}}