{"action":"created","comment":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments/73693518","id":73693518,"diff_hunk":"@@ -32,9 +87,12 @@ end;\n \n function onMobEngaged(mob,target)\n     -- pop pets\n-    for i = 17056170, 17056177, 1 do\n-        SpawnMob(i,180):updateEnmity(target);\n-        GetMobByID(i):setModelId(1841);\n+    for i = 1, 8 do\n+        local pet = GetMobByID(petIDs[1][i]);\n+        pet:setModelId(1841);\n+        pet:spawn();\n+        pet:updateClaim(target);","path":"scripts/zones/Aydeewa_Subterrane/mobs/Pandemonium_Warden.lua","position":83,"original_position":83,"commit_id":"56a351e32194b6e1f22bade91bb4cf2dfc921294","original_commit_id":"56a351e32194b6e1f22bade91bb4cf2dfc921294","user":{"login":"neosatus","id":17725395,"avatar_url":"https://avatars.githubusercontent.com/u/17725395?v=3","gravatar_id":"","url":"https://api.github.com/users/neosatus","html_url":"https://github.com/neosatus","followers_url":"https://api.github.com/users/neosatus/followers","following_url":"https://api.github.com/users/neosatus/following{/other_user}","gists_url":"https://api.github.com/users/neosatus/gists{/gist_id}","starred_url":"https://api.github.com/users/neosatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neosatus/subscriptions","organizations_url":"https://api.github.com/users/neosatus/orgs","repos_url":"https://api.github.com/users/neosatus/repos","events_url":"https://api.github.com/users/neosatus/events{/privacy}","received_events_url":"https://api.github.com/users/neosatus/received_events","type":"User","site_admin":false},"body":"Hmm... so there's also that block of code that was left over from previous version where if it's not time for a phase change or an astral flow it just checks to make sure the pets are engaged and if not it teleports them to PW and engages them on the tank. This is to prevent people from dragging the adds off and leaving them somewhere. If I spawn them unclaimed, they'll get hit by that code and engaged anyways (I think, at work, can't test). Should I remove that block of code too? They spawn on top of PW each phase regardless of where they are so they'll be able to engage normally. If they get drug off it'll just be for one phase which isn't a big deal I guess. The longest phase is only 20k hp.","created_at":"2016-08-05T13:41:48Z","updated_at":"2016-08-05T13:41:48Z","html_url":"https://github.com/DarkstarProject/darkstar/pull/3303#discussion_r73693518","pull_request_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303","_links":{"self":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments/73693518"},"html":{"href":"https://github.com/DarkstarProject/darkstar/pull/3303#discussion_r73693518"},"pull_request":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303"}}},"pull_request":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303","id":79672907,"html_url":"https://github.com/DarkstarProject/darkstar/pull/3303","diff_url":"https://github.com/DarkstarProject/darkstar/pull/3303.diff","patch_url":"https://github.com/DarkstarProject/darkstar/pull/3303.patch","issue_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/3303","number":3303,"state":"open","locked":false,"title":"New Pandemonium Warden Implementation","user":{"login":"neosatus","id":17725395,"avatar_url":"https://avatars.githubusercontent.com/u/17725395?v=3","gravatar_id":"","url":"https://api.github.com/users/neosatus","html_url":"https://github.com/neosatus","followers_url":"https://api.github.com/users/neosatus/followers","following_url":"https://api.github.com/users/neosatus/following{/other_user}","gists_url":"https://api.github.com/users/neosatus/gists{/gist_id}","starred_url":"https://api.github.com/users/neosatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neosatus/subscriptions","organizations_url":"https://api.github.com/users/neosatus/orgs","repos_url":"https://api.github.com/users/neosatus/repos","events_url":"https://api.github.com/users/neosatus/events{/privacy}","received_events_url":"https://api.github.com/users/neosatus/received_events","type":"User","site_admin":false},"body":"* Working phases\r\n* Working Astral Flows\r\n* Unskippable Adds\r\n* Several new LuaBaseEntity functions\r\n\r\nNotes:\r\n* This is building on Era Devs Warp and Lee's old PW script where they modified the current DSP version to make PW unkillable with no healthbar until all the phases have been completed. This allows us to use realistic phase HP amounts since we can just reset his HP for each phase and trigger a change on HPP <= 1. The current version tries to squish all the phase HPs into PW's leaving him with none at the end when the fight should enter it's true 2nd phase.\r\n* I reworked the phases from a long string of if statements to several arrays and a single logic check, as the previous note suggested. I tested and modified each TP move to make sure it worked and was retail accurate. I also split Chariot into 4 phases each doing one of the TP moves like in retail.\r\n* I reworked the final phase Astral Flows. In retail, these were 8x simultaneous Astral Flow Blood Pacts every 25%. In practice that causes clients to crash so I changed it to 1x Astral Flow every 10% with accompanying pet respawn. It also uses the array/single logic check approach. The Avatars are correctly matched with their abilities. I reuse a spawning pet as an Avatar and just keep them around. Carbuncle is last, PW is weakened by then...\r\n* I made the pets alternate between two sets of 8 pets so that players couldn't kill the adds directly before forcing a phase change to prevent them from respawning or otherwise glitch them. ~~I wrote a function to clone HP and status effects (presently just sleep, more can be added) that I use for these swaps.~~ This is an abundance of caution. If they get around this whatever.\r\n* Further discussion about the pets, since nothing on DSP gains immunity to sleep overtime like on retail, the lamps are fully sleepable. I think this is okay because they have 9k HP each while the first few phases have 10k and then 15k. It still requires a coordinated group of BLMs who are multitasking sleeping and bursting. I think if they're made immune to sleep they should have much less HP so a coordinated group of BLMs could -aga them down. \r\n* ~~I tried to make PW sleep immune but my attempt doesn't work and I don't know what else to try.~~\r\n* Brainjack charms now. I enjoyed it when one of my test characters got charmed and the other got one shot by Discoid.\r\n* Searing Light mobskill wasn't a thing and is now and \"Homing Missle\" is now spelled correctly so it matches up with the DB.\r\n* When he disengages he fully resets his phase variables, should he do that?\r\n\r\nNew LuaBaseEntity Functions:\r\n* ~~despawn (calls PAI function)~~\r\n* isSpawned (calls PAI function)\r\n* isEngaged (calls PAI function)\r\n* isAsleep (more effects? another condition?) (I just discovered this is a clone of a status.lua function)\r\n* ~~clone (needed for PW)~~\r\n\r\nThis is still not retail accurate although a lot closer than the current version. It's tested, functional and challenging. I'm pushing it up here so Era can easily patch it in for some live testing.\r\n\r\nEDIT: Updated","created_at":"2016-08-02T04:00:35Z","updated_at":"2016-08-05T13:41:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8248588848b5d5cfd79567761ceca2a1ac20c693","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303/commits","review_comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303/comments","review_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/3303/comments","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/56a351e32194b6e1f22bade91bb4cf2dfc921294","head":{"label":"neosatus:PWFix","ref":"PWFix","sha":"56a351e32194b6e1f22bade91bb4cf2dfc921294","user":{"login":"neosatus","id":17725395,"avatar_url":"https://avatars.githubusercontent.com/u/17725395?v=3","gravatar_id":"","url":"https://api.github.com/users/neosatus","html_url":"https://github.com/neosatus","followers_url":"https://api.github.com/users/neosatus/followers","following_url":"https://api.github.com/users/neosatus/following{/other_user}","gists_url":"https://api.github.com/users/neosatus/gists{/gist_id}","starred_url":"https://api.github.com/users/neosatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neosatus/subscriptions","organizations_url":"https://api.github.com/users/neosatus/orgs","repos_url":"https://api.github.com/users/neosatus/repos","events_url":"https://api.github.com/users/neosatus/events{/privacy}","received_events_url":"https://api.github.com/users/neosatus/received_events","type":"User","site_admin":false},"repo":{"id":62012917,"name":"darkstar","full_name":"neosatus/darkstar","owner":{"login":"neosatus","id":17725395,"avatar_url":"https://avatars.githubusercontent.com/u/17725395?v=3","gravatar_id":"","url":"https://api.github.com/users/neosatus","html_url":"https://github.com/neosatus","followers_url":"https://api.github.com/users/neosatus/followers","following_url":"https://api.github.com/users/neosatus/following{/other_user}","gists_url":"https://api.github.com/users/neosatus/gists{/gist_id}","starred_url":"https://api.github.com/users/neosatus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neosatus/subscriptions","organizations_url":"https://api.github.com/users/neosatus/orgs","repos_url":"https://api.github.com/users/neosatus/repos","events_url":"https://api.github.com/users/neosatus/events{/privacy}","received_events_url":"https://api.github.com/users/neosatus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neosatus/darkstar","description":"FFXI Server Emulator","fork":true,"url":"https://api.github.com/repos/neosatus/darkstar","forks_url":"https://api.github.com/repos/neosatus/darkstar/forks","keys_url":"https://api.github.com/repos/neosatus/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neosatus/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neosatus/darkstar/teams","hooks_url":"https://api.github.com/repos/neosatus/darkstar/hooks","issue_events_url":"https://api.github.com/repos/neosatus/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/neosatus/darkstar/events","assignees_url":"https://api.github.com/repos/neosatus/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/neosatus/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/neosatus/darkstar/tags","blobs_url":"https://api.github.com/repos/neosatus/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neosatus/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neosatus/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/neosatus/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neosatus/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/neosatus/darkstar/languages","stargazers_url":"https://api.github.com/repos/neosatus/darkstar/stargazers","contributors_url":"https://api.github.com/repos/neosatus/darkstar/contributors","subscribers_url":"https://api.github.com/repos/neosatus/darkstar/subscribers","subscription_url":"https://api.github.com/repos/neosatus/darkstar/subscription","commits_url":"https://api.github.com/repos/neosatus/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/neosatus/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/neosatus/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/neosatus/darkstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/neosatus/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/neosatus/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neosatus/darkstar/merges","archive_url":"https://api.github.com/repos/neosatus/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neosatus/darkstar/downloads","issues_url":"https://api.github.com/repos/neosatus/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/neosatus/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/neosatus/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/neosatus/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neosatus/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/neosatus/darkstar/releases{/id}","deployments_url":"https://api.github.com/repos/neosatus/darkstar/deployments","created_at":"2016-06-26T23:30:16Z","updated_at":"2016-06-26T23:30:28Z","pushed_at":"2016-08-05T03:24:00Z","git_url":"git://github.com/neosatus/darkstar.git","ssh_url":"git@github.com:neosatus/darkstar.git","clone_url":"https://github.com/neosatus/darkstar.git","svn_url":"https://github.com/neosatus/darkstar","homepage":"https://forums.dspt.info/index.php","size":174443,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DarkstarProject:master","ref":"master","sha":"70ed18c43bca02f649f87796f9a21fbab51d2d2a","user":{"login":"DarkstarProject","id":6373714,"avatar_url":"https://avatars.githubusercontent.com/u/6373714?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15814642,"name":"darkstar","full_name":"DarkstarProject/darkstar","owner":{"login":"DarkstarProject","id":6373714,"avatar_url":"https://avatars.githubusercontent.com/u/6373714?v=3","gravatar_id":"","url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DarkstarProject/darkstar","description":"FFXI Server Emulator","fork":false,"url":"https://api.github.com/repos/DarkstarProject/darkstar","forks_url":"https://api.github.com/repos/DarkstarProject/darkstar/forks","keys_url":"https://api.github.com/repos/DarkstarProject/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkstarProject/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkstarProject/darkstar/teams","hooks_url":"https://api.github.com/repos/DarkstarProject/darkstar/hooks","issue_events_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/DarkstarProject/darkstar/events","assignees_url":"https://api.github.com/repos/DarkstarProject/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/DarkstarProject/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/tags","blobs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkstarProject/darkstar/languages","stargazers_url":"https://api.github.com/repos/DarkstarProject/darkstar/stargazers","contributors_url":"https://api.github.com/repos/DarkstarProject/darkstar/contributors","subscribers_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscribers","subscription_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscription","commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkstarProject/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/DarkstarProject/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkstarProject/darkstar/merges","archive_url":"https://api.github.com/repos/DarkstarProject/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkstarProject/darkstar/downloads","issues_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkstarProject/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkstarProject/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkstarProject/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/DarkstarProject/darkstar/releases{/id}","deployments_url":"https://api.github.com/repos/DarkstarProject/darkstar/deployments","created_at":"2014-01-11T01:31:17Z","updated_at":"2016-07-29T17:49:00Z","pushed_at":"2016-08-05T10:34:55Z","git_url":"git://github.com/DarkstarProject/darkstar.git","ssh_url":"git@github.com:DarkstarProject/darkstar.git","clone_url":"https://github.com/DarkstarProject/darkstar.git","svn_url":"https://github.com/DarkstarProject/darkstar","homepage":"https://forums.dspt.info/index.php","size":252322,"stargazers_count":188,"watchers_count":188,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":353,"mirror_url":null,"open_issues_count":336,"forks":353,"open_issues":336,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303"},"html":{"href":"https://github.com/DarkstarProject/darkstar/pull/3303"},"issue":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/3303"},"comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/3303/comments"},"review_comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303/comments"},"review_comment":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/3303/commits"},"statuses":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/56a351e32194b6e1f22bade91bb4cf2dfc921294"}}}}
{"actor":{"display_login":"neosatus"}}