{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments/83087422","pull_request_review_id":3951547,"id":83087422,"diff_hunk":"@@ -41,7 +41,7 @@ public ResponseCompressionProvider(IEnumerable<ICompressionProvider> providers,\n \n             if (options.Value.MimeTypes == null || !options.Value.MimeTypes.Any())\n             {\n-                throw new InvalidOperationException(\"No mime types specified\");\n+                throw new InvalidOperationException(\"No MIME types specified\");","path":"src/Microsoft.AspNetCore.ResponseCompression/ResponseCompressionProvider.cs","position":5,"original_position":5,"commit_id":"511d711620a0c26d8d6b82022c74216a4ff2a392","original_commit_id":"511d711620a0c26d8d6b82022c74216a4ff2a392","user":{"login":"Eilon","id":202643,"avatar_url":"https://avatars.githubusercontent.com/u/202643?v=3","gravatar_id":"","url":"https://api.github.com/users/Eilon","html_url":"https://github.com/Eilon","followers_url":"https://api.github.com/users/Eilon/followers","following_url":"https://api.github.com/users/Eilon/following{/other_user}","gists_url":"https://api.github.com/users/Eilon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eilon/subscriptions","organizations_url":"https://api.github.com/users/Eilon/orgs","repos_url":"https://api.github.com/users/Eilon/repos","events_url":"https://api.github.com/users/Eilon/events{/privacy}","received_events_url":"https://api.github.com/users/Eilon/received_events","type":"User","site_admin":false},"body":"End sentences with a period","created_at":"2016-10-12T20:06:51Z","updated_at":"2016-10-12T20:07:01Z","html_url":"https://github.com/aspnet/BasicMiddleware/pull/125#discussion_r83087422","pull_request_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments/83087422"},"html":{"href":"https://github.com/aspnet/BasicMiddleware/pull/125#discussion_r83087422"},"pull_request":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125","id":89068637,"html_url":"https://github.com/aspnet/BasicMiddleware/pull/125","diff_url":"https://github.com/aspnet/BasicMiddleware/pull/125.diff","patch_url":"https://github.com/aspnet/BasicMiddleware/pull/125.patch","issue_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/125","number":125,"state":"closed","locked":false,"title":"compression code cleanup","user":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=3","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"body":"https://github.com/aspnet/BasicMiddleware/issues/108#issuecomment-253042371 @Eilon @DamianEdwards @JunTaoLuo \r\n\r\nFixing several minor items from the API review.\r\n- Use Singleton services rather than Transient\r\n- EnableHttps -> EnableForHttps\r\n- Split ResponseCompressionExtensions\r\n\r\nThe larger items will be addressed separately","created_at":"2016-10-12T18:32:24Z","updated_at":"2016-10-12T20:07:01Z","closed_at":"2016-10-12T18:55:22Z","merged_at":"2016-10-12T18:55:22Z","merge_commit_sha":"511d711620a0c26d8d6b82022c74216a4ff2a392","assignee":{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=3","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tratcher","id":1821173,"avatar_url":"https://avatars.githubusercontent.com/u/1821173?v=3","gravatar_id":"","url":"https://api.github.com/users/Tratcher","html_url":"https://github.com/Tratcher","followers_url":"https://api.github.com/users/Tratcher/followers","following_url":"https://api.github.com/users/Tratcher/following{/other_user}","gists_url":"https://api.github.com/users/Tratcher/gists{/gist_id}","starred_url":"https://api.github.com/users/Tratcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tratcher/subscriptions","organizations_url":"https://api.github.com/users/Tratcher/orgs","repos_url":"https://api.github.com/users/Tratcher/repos","events_url":"https://api.github.com/users/Tratcher/events{/privacy}","received_events_url":"https://api.github.com/users/Tratcher/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aspnet/BasicMiddleware/milestones/7","html_url":"https://github.com/aspnet/BasicMiddleware/milestones/1.1.0-preview1","labels_url":"https://api.github.com/repos/aspnet/BasicMiddleware/milestones/7/labels","id":1856196,"number":7,"title":"1.1.0-preview1","description":"","creator":{"login":"muratg","id":1808428,"avatar_url":"https://avatars.githubusercontent.com/u/1808428?v=3","gravatar_id":"","url":"https://api.github.com/users/muratg","html_url":"https://github.com/muratg","followers_url":"https://api.github.com/users/muratg/followers","following_url":"https://api.github.com/users/muratg/following{/other_user}","gists_url":"https://api.github.com/users/muratg/gists{/gist_id}","starred_url":"https://api.github.com/users/muratg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratg/subscriptions","organizations_url":"https://api.github.com/users/muratg/orgs","repos_url":"https://api.github.com/users/muratg/repos","events_url":"https://api.github.com/users/muratg/events{/privacy}","received_events_url":"https://api.github.com/users/muratg/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":11,"state":"open","created_at":"2016-06-29T21:06:35Z","updated_at":"2016-10-12T18:55:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125/commits","review_comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125/comments","review_comment_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/125/comments","statuses_url":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/511d711620a0c26d8d6b82022c74216a4ff2a392","head":{"label":"aspnet:tratcher/cleanup","ref":"tratcher/cleanup","sha":"511d711620a0c26d8d6b82022c74216a4ff2a392","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38068840,"name":"BasicMiddleware","full_name":"aspnet/BasicMiddleware","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/BasicMiddleware","description":"Basic middleware components for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/BasicMiddleware","forks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/forks","keys_url":"https://api.github.com/repos/aspnet/BasicMiddleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/BasicMiddleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/BasicMiddleware/teams","hooks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/hooks","issue_events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/events","assignees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/BasicMiddleware/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/tags","blobs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/BasicMiddleware/languages","stargazers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/stargazers","contributors_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contributors","subscribers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscribers","subscription_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscription","commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/BasicMiddleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/BasicMiddleware/merges","archive_url":"https://api.github.com/repos/aspnet/BasicMiddleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/BasicMiddleware/downloads","issues_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/BasicMiddleware/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/BasicMiddleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/BasicMiddleware/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/BasicMiddleware/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/deployments","created_at":"2015-06-25T19:15:27Z","updated_at":"2016-10-11T08:32:59Z","pushed_at":"2016-10-12T18:55:46Z","git_url":"git://github.com/aspnet/BasicMiddleware.git","ssh_url":"git@github.com:aspnet/BasicMiddleware.git","clone_url":"https://github.com/aspnet/BasicMiddleware.git","svn_url":"https://github.com/aspnet/BasicMiddleware","homepage":"","size":651,"stargazers_count":45,"watchers_count":45,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":35,"forks":11,"open_issues":35,"watchers":45,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"03b63e2c2a5ec27deef4be692ff2119188b67d73","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":38068840,"name":"BasicMiddleware","full_name":"aspnet/BasicMiddleware","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/BasicMiddleware","description":"Basic middleware components for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/BasicMiddleware","forks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/forks","keys_url":"https://api.github.com/repos/aspnet/BasicMiddleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/BasicMiddleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/BasicMiddleware/teams","hooks_url":"https://api.github.com/repos/aspnet/BasicMiddleware/hooks","issue_events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/BasicMiddleware/events","assignees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/BasicMiddleware/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/tags","blobs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/BasicMiddleware/languages","stargazers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/stargazers","contributors_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contributors","subscribers_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscribers","subscription_url":"https://api.github.com/repos/aspnet/BasicMiddleware/subscription","commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/BasicMiddleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/BasicMiddleware/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/BasicMiddleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/BasicMiddleware/merges","archive_url":"https://api.github.com/repos/aspnet/BasicMiddleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/BasicMiddleware/downloads","issues_url":"https://api.github.com/repos/aspnet/BasicMiddleware/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/BasicMiddleware/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/BasicMiddleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/BasicMiddleware/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/BasicMiddleware/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/BasicMiddleware/deployments","created_at":"2015-06-25T19:15:27Z","updated_at":"2016-10-11T08:32:59Z","pushed_at":"2016-10-12T18:55:46Z","git_url":"git://github.com/aspnet/BasicMiddleware.git","ssh_url":"git@github.com:aspnet/BasicMiddleware.git","clone_url":"https://github.com/aspnet/BasicMiddleware.git","svn_url":"https://github.com/aspnet/BasicMiddleware","homepage":"","size":651,"stargazers_count":45,"watchers_count":45,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":35,"forks":11,"open_issues":35,"watchers":45,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125"},"html":{"href":"https://github.com/aspnet/BasicMiddleware/pull/125"},"issue":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/125"},"comments":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/BasicMiddleware/statuses/511d711620a0c26d8d6b82022c74216a4ff2a392"}}}}
{"actor":{"display_login":"Eilon"}}