{"action":"created","comment":{"url":"https://api.github.com/repos/deis/workflow-e2e/pulls/comments/77422016","id":77422016,"diff_hunk":"@@ -65,34 +65,33 @@ var _ = Describe(\"deis healthchecks\", func() {\n \t\t\t\tEventually(sess).Should(Exit(0))\n \t\t\t})\n \n-\t\t\t// disable httpGet liveness checks as it won't pass for every app\n-\t\t\t// TODO(bacongobbler): somehow determine *what* port we need to set the liveness check for this app\n-\t\t\tXSpecify(\"that user can set a httpGet liveness healthcheck\", func() {\n-\t\t\t\tsess, err := cmd.Start(\"deis healthchecks:set liveness httpGet -a %s 80\", &user, app.Name)\n+\t\t\t// 1500 is port of th app we are deploying deis/example-dockerfile-http","path":"tests/healthcheck_test.go","position":8,"original_position":8,"commit_id":"079d1da05e370a5a3d6038fe903c70bf57a2cb9a","original_commit_id":"079d1da05e370a5a3d6038fe903c70bf57a2cb9a","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"body":"can you please change this back to \"the port of the app\"?","created_at":"2016-09-02T22:46:59Z","updated_at":"2016-09-02T22:46:59Z","html_url":"https://github.com/deis/workflow-e2e/pull/320#discussion_r77422016","pull_request_url":"https://api.github.com/repos/deis/workflow-e2e/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/deis/workflow-e2e/pulls/comments/77422016"},"html":{"href":"https://github.com/deis/workflow-e2e/pull/320#discussion_r77422016"},"pull_request":{"href":"https://api.github.com/repos/deis/workflow-e2e/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/deis/workflow-e2e/pulls/320","id":83859193,"html_url":"https://github.com/deis/workflow-e2e/pull/320","diff_url":"https://github.com/deis/workflow-e2e/pull/320.diff","patch_url":"https://github.com/deis/workflow-e2e/pull/320.patch","issue_url":"https://api.github.com/repos/deis/workflow-e2e/issues/320","number":320,"state":"open","locked":false,"title":"fix(healthcheck): use correct port the image exposes","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"body":"with this PR https://github.com/deis/controller/pull/1036 the healthchecks are properly checked and hence the e2e fails.","created_at":"2016-09-02T20:20:44Z","updated_at":"2016-09-02T22:46:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ad4b373ad67e720e78e0daf0ae1f3d3dd2f5b49","assignee":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"assignees":[{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/deis/workflow-e2e/milestones/14","html_url":"https://github.com/deis/workflow-e2e/milestones/v2.5","labels_url":"https://api.github.com/repos/deis/workflow-e2e/milestones/14/labels","id":1922158,"number":14,"title":"v2.5","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":9,"state":"open","created_at":"2016-08-03T21:49:54Z","updated_at":"2016-09-02T21:45:20Z","due_on":"2016-09-06T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/workflow-e2e/pulls/320/commits","review_comments_url":"https://api.github.com/repos/deis/workflow-e2e/pulls/320/comments","review_comment_url":"https://api.github.com/repos/deis/workflow-e2e/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/workflow-e2e/issues/320/comments","statuses_url":"https://api.github.com/repos/deis/workflow-e2e/statuses/079d1da05e370a5a3d6038fe903c70bf57a2cb9a","head":{"label":"kmala:tests","ref":"tests","sha":"079d1da05e370a5a3d6038fe903c70bf57a2cb9a","user":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"repo":{"id":53360227,"name":"workflow-e2e","full_name":"kmala/workflow-e2e","owner":{"login":"kmala","id":12552530,"avatar_url":"https://avatars.githubusercontent.com/u/12552530?v=3","gravatar_id":"","url":"https://api.github.com/users/kmala","html_url":"https://github.com/kmala","followers_url":"https://api.github.com/users/kmala/followers","following_url":"https://api.github.com/users/kmala/following{/other_user}","gists_url":"https://api.github.com/users/kmala/gists{/gist_id}","starred_url":"https://api.github.com/users/kmala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmala/subscriptions","organizations_url":"https://api.github.com/users/kmala/orgs","repos_url":"https://api.github.com/users/kmala/repos","events_url":"https://api.github.com/users/kmala/events{/privacy}","received_events_url":"https://api.github.com/users/kmala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmala/workflow-e2e","description":"End-to-end tests for Deis Workflow","fork":true,"url":"https://api.github.com/repos/kmala/workflow-e2e","forks_url":"https://api.github.com/repos/kmala/workflow-e2e/forks","keys_url":"https://api.github.com/repos/kmala/workflow-e2e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmala/workflow-e2e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmala/workflow-e2e/teams","hooks_url":"https://api.github.com/repos/kmala/workflow-e2e/hooks","issue_events_url":"https://api.github.com/repos/kmala/workflow-e2e/issues/events{/number}","events_url":"https://api.github.com/repos/kmala/workflow-e2e/events","assignees_url":"https://api.github.com/repos/kmala/workflow-e2e/assignees{/user}","branches_url":"https://api.github.com/repos/kmala/workflow-e2e/branches{/branch}","tags_url":"https://api.github.com/repos/kmala/workflow-e2e/tags","blobs_url":"https://api.github.com/repos/kmala/workflow-e2e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmala/workflow-e2e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmala/workflow-e2e/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmala/workflow-e2e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmala/workflow-e2e/statuses/{sha}","languages_url":"https://api.github.com/repos/kmala/workflow-e2e/languages","stargazers_url":"https://api.github.com/repos/kmala/workflow-e2e/stargazers","contributors_url":"https://api.github.com/repos/kmala/workflow-e2e/contributors","subscribers_url":"https://api.github.com/repos/kmala/workflow-e2e/subscribers","subscription_url":"https://api.github.com/repos/kmala/workflow-e2e/subscription","commits_url":"https://api.github.com/repos/kmala/workflow-e2e/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmala/workflow-e2e/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmala/workflow-e2e/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmala/workflow-e2e/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmala/workflow-e2e/contents/{+path}","compare_url":"https://api.github.com/repos/kmala/workflow-e2e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmala/workflow-e2e/merges","archive_url":"https://api.github.com/repos/kmala/workflow-e2e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmala/workflow-e2e/downloads","issues_url":"https://api.github.com/repos/kmala/workflow-e2e/issues{/number}","pulls_url":"https://api.github.com/repos/kmala/workflow-e2e/pulls{/number}","milestones_url":"https://api.github.com/repos/kmala/workflow-e2e/milestones{/number}","notifications_url":"https://api.github.com/repos/kmala/workflow-e2e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmala/workflow-e2e/labels{/name}","releases_url":"https://api.github.com/repos/kmala/workflow-e2e/releases{/id}","deployments_url":"https://api.github.com/repos/kmala/workflow-e2e/deployments","created_at":"2016-03-07T21:24:30Z","updated_at":"2016-03-07T21:24:31Z","pushed_at":"2016-09-02T22:37:43Z","git_url":"git://github.com/kmala/workflow-e2e.git","ssh_url":"git@github.com:kmala/workflow-e2e.git","clone_url":"https://github.com/kmala/workflow-e2e.git","svn_url":"https://github.com/kmala/workflow-e2e","homepage":null,"size":18261,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"5bc8cb0f487bc09887e50da7ee2409e22debd134","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":48503688,"name":"workflow-e2e","full_name":"deis/workflow-e2e","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/workflow-e2e","description":"End-to-end tests for Deis Workflow","fork":false,"url":"https://api.github.com/repos/deis/workflow-e2e","forks_url":"https://api.github.com/repos/deis/workflow-e2e/forks","keys_url":"https://api.github.com/repos/deis/workflow-e2e/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/workflow-e2e/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/workflow-e2e/teams","hooks_url":"https://api.github.com/repos/deis/workflow-e2e/hooks","issue_events_url":"https://api.github.com/repos/deis/workflow-e2e/issues/events{/number}","events_url":"https://api.github.com/repos/deis/workflow-e2e/events","assignees_url":"https://api.github.com/repos/deis/workflow-e2e/assignees{/user}","branches_url":"https://api.github.com/repos/deis/workflow-e2e/branches{/branch}","tags_url":"https://api.github.com/repos/deis/workflow-e2e/tags","blobs_url":"https://api.github.com/repos/deis/workflow-e2e/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/workflow-e2e/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/workflow-e2e/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/workflow-e2e/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/workflow-e2e/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/workflow-e2e/languages","stargazers_url":"https://api.github.com/repos/deis/workflow-e2e/stargazers","contributors_url":"https://api.github.com/repos/deis/workflow-e2e/contributors","subscribers_url":"https://api.github.com/repos/deis/workflow-e2e/subscribers","subscription_url":"https://api.github.com/repos/deis/workflow-e2e/subscription","commits_url":"https://api.github.com/repos/deis/workflow-e2e/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/workflow-e2e/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/workflow-e2e/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/workflow-e2e/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/workflow-e2e/contents/{+path}","compare_url":"https://api.github.com/repos/deis/workflow-e2e/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/workflow-e2e/merges","archive_url":"https://api.github.com/repos/deis/workflow-e2e/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/workflow-e2e/downloads","issues_url":"https://api.github.com/repos/deis/workflow-e2e/issues{/number}","pulls_url":"https://api.github.com/repos/deis/workflow-e2e/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/workflow-e2e/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/workflow-e2e/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/workflow-e2e/labels{/name}","releases_url":"https://api.github.com/repos/deis/workflow-e2e/releases{/id}","deployments_url":"https://api.github.com/repos/deis/workflow-e2e/deployments","created_at":"2015-12-23T17:50:37Z","updated_at":"2016-08-31T20:05:43Z","pushed_at":"2016-09-02T22:37:43Z","git_url":"git://github.com/deis/workflow-e2e.git","ssh_url":"git@github.com:deis/workflow-e2e.git","clone_url":"https://github.com/deis/workflow-e2e.git","svn_url":"https://github.com/deis/workflow-e2e","homepage":null,"size":18316,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":44,"forks":15,"open_issues":44,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/workflow-e2e/pulls/320"},"html":{"href":"https://github.com/deis/workflow-e2e/pull/320"},"issue":{"href":"https://api.github.com/repos/deis/workflow-e2e/issues/320"},"comments":{"href":"https://api.github.com/repos/deis/workflow-e2e/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/workflow-e2e/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/workflow-e2e/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/workflow-e2e/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/deis/workflow-e2e/statuses/079d1da05e370a5a3d6038fe903c70bf57a2cb9a"}}}}
{"actor":{"display_login":"bacongobbler"}}