{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59404051","id":59404051,"diff_hunk":"@@ -626,17 +631,23 @@ private struct UrlDecoder\n             private void FlushBytes()\n             {\n                 Debug.Assert(_numBytes > 0);\n+                if (_charBuffer == null)\n+                    _charBuffer = new char[_bufferSize];\n+\n                 _numChars += _encoding.GetChars(_byteBuffer, 0, _numBytes, _charBuffer, _numChars);\n                 _numBytes = 0;\n             }\n \n             internal UrlDecoder(int bufferSize, Encoding encoding)\n             {\n+                _containsUnsafe = false;\n+                _containsSpaces = false;\n+\n                 _bufferSize = bufferSize;\n                 _encoding = encoding;\n \n-                _charBuffer = new char[bufferSize];\n-                \n+                _charBuffer = null; // char buffer created on demand","path":"src/System.Runtime.Extensions/src/System/Net/WebUtility.cs","position":48,"original_position":53,"commit_id":"5f256f3b7f19629c9a1a7b3ec81225e5ac812e99","original_commit_id":"8cb7fc402997ec0fbf19df5ed2d3d44970919787","user":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"body":"right. looking more, it looks when having ascii characters, it needs to be encoded by the encoder. bu tif the character is not ascii will be stored as it is without encoding. so I believe what they are doing is collecting ascii charcaters in the array, and everytime need to flush it, will run the encoder just once on the array before the flush. so it is just optimizing to not calling the encoder with every ascii character. ","created_at":"2016-04-12T16:08:30Z","updated_at":"2016-04-12T16:08:30Z","html_url":"https://github.com/dotnet/corefx/pull/7671#discussion_r59404051","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7671","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59404051"},"html":{"href":"https://github.com/dotnet/corefx/pull/7671#discussion_r59404051"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7671"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7671","id":66120449,"html_url":"https://github.com/dotnet/corefx/pull/7671","diff_url":"https://github.com/dotnet/corefx/pull/7671.diff","patch_url":"https://github.com/dotnet/corefx/pull/7671.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7671","number":7671,"state":"open","locked":false,"title":"Improve performance of WebUtility.Decode for non-escaped strings","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"- Cuts allocations down to 1/3 of the original\r\n- Doubles performance (in time)\r\n\r\n- We still allocate a little bit, as removing all allocations would harm the performance of strings that actually need escaping\r\n\r\n## Benchmark - escaping needed\r\n- No performance regressions\r\n\r\n![benchmark escaping](https://cloud.githubusercontent.com/assets/1275900/14454716/c85fc7bc-0093-11e6-8c65-3eba5ce34729.png)\r\n\r\n\r\n## Benchmark - no escaping needed\r\n![benchmark no escaping](https://cloud.githubusercontent.com/assets/1275900/14454713/c5124e54-0093-11e6-983b-ad3ae9e654ff.png)\r\n\r\n## Benchmark Code\r\n<details>\r\n<summary>Click here</summary>\r\n```\r\nstatic void Main(string[] args)\r\n{\r\n\t// Escaping\r\n    TimeAction(\"Old: \", () => Old.UrlDecode(\"%ABabc\"));\r\n    TimeAction(\"New: \", () => New.UrlDecode(\"%ABabc\"));\r\n\r\n    // No escaping\r\n    TimeAction(\"Old: \", () => Old.UrlDecode(\"abc\"));\r\n    TimeAction(\"New: \", () => New.UrlDecode(\"abc\"));\r\n\r\n    Console.ReadLine();\r\n}\r\n\r\npublic static void TimeAction(string prefix, Action action)\r\n{\r\n    var sw = new Stopwatch();\r\n    for (int iter = 0; iter < 5; iter++)\r\n    {\r\n        int gen0 = GC.CollectionCount(0);\r\n        sw.Restart();\r\n        for (int i = 0; i < 10000000; i++)\r\n        {\r\n            action();\r\n        }\r\n        sw.Stop();\r\n        Console.WriteLine($\"{prefix}Time: {sw.Elapsed.TotalSeconds}\\tGC0: {GC.CollectionCount(0) - gen0}\");\r\n    }\r\n}\r\n```\r\n</details>\r\n\r\n/cc @stephentoub @jamesqo @davidsh \r\nFixes #6542 together with #7546","created_at":"2016-04-12T08:45:50Z","updated_at":"2016-04-12T16:08:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0724c369563d7b783c8b320cd4bcb7c6691c8b58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7671/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7671/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7671/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/5f256f3b7f19629c9a1a7b3ec81225e5ac812e99","head":{"label":"hughbe:webutility-decode","ref":"webutility-decode","sha":"5f256f3b7f19629c9a1a7b3ec81225e5ac812e99","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":47085914,"name":"corefx","full_name":"hughbe/corefx","owner":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughbe/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/hughbe/corefx","forks_url":"https://api.github.com/repos/hughbe/corefx/forks","keys_url":"https://api.github.com/repos/hughbe/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/corefx/teams","hooks_url":"https://api.github.com/repos/hughbe/corefx/hooks","issue_events_url":"https://api.github.com/repos/hughbe/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/corefx/events","assignees_url":"https://api.github.com/repos/hughbe/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/corefx/tags","blobs_url":"https://api.github.com/repos/hughbe/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/corefx/languages","stargazers_url":"https://api.github.com/repos/hughbe/corefx/stargazers","contributors_url":"https://api.github.com/repos/hughbe/corefx/contributors","subscribers_url":"https://api.github.com/repos/hughbe/corefx/subscribers","subscription_url":"https://api.github.com/repos/hughbe/corefx/subscription","commits_url":"https://api.github.com/repos/hughbe/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/corefx/merges","archive_url":"https://api.github.com/repos/hughbe/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/corefx/downloads","issues_url":"https://api.github.com/repos/hughbe/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/corefx/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/corefx/deployments","created_at":"2015-11-30T00:15:59Z","updated_at":"2016-01-17T12:57:11Z","pushed_at":"2016-04-12T16:04:19Z","git_url":"git://github.com/hughbe/corefx.git","ssh_url":"git@github.com:hughbe/corefx.git","clone_url":"https://github.com/hughbe/corefx.git","svn_url":"https://github.com/hughbe/corefx","homepage":"http://dotnet.github.io/","size":63875,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ccfa9c41cf7fc1a434cebc90ee1bb5abfa29966c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-12T15:17:33Z","pushed_at":"2016-04-12T16:04:19Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":86239,"stargazers_count":9482,"watchers_count":9482,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2241,"mirror_url":null,"open_issues_count":952,"forks":2241,"open_issues":952,"watchers":9482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7671"},"html":{"href":"https://github.com/dotnet/corefx/pull/7671"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7671"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7671/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7671/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7671/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/5f256f3b7f19629c9a1a7b3ec81225e5ac812e99"}}}}