{"action":"closed","number":190,"pull_request":{"url":"https://api.github.com/repos/krakjoe/apcu/pulls/190","id":78611034,"html_url":"https://github.com/krakjoe/apcu/pull/190","diff_url":"https://github.com/krakjoe/apcu/pull/190.diff","patch_url":"https://github.com/krakjoe/apcu/pull/190.patch","issue_url":"https://api.github.com/repos/krakjoe/apcu/issues/190","number":190,"state":"closed","locked":false,"title":"Fix memory leak/failed check for duplicates when serializing arrays and object","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"body":"Affects built in serializer as well as the igbinary7 serializer.\r\n\r\nThe apc serialization/unserialization code was checking\r\nIS_REFCOUNTED_P(val).\r\nHowever, when objects were being serialized as strings, the \r\nIS_REFCOUNTED bit in the type flags wasn't being set (Bitmask was 0)\r\n\r\nThis meant that if there were two uses of an object being serialized, it would be\r\ncloned, since the code treated `dst` as if it couldn't be refcounted, and \r\nthus didn't add the mapping from `src`'s zend_refcounted pointer to `dst` into\r\n`si->copied`\r\n\r\nFound this bug while working on https://github.com/igbinary/igbinary7/pull/23\r\n","created_at":"2016-07-24T21:58:01Z","updated_at":"2016-09-29T16:25:56Z","closed_at":"2016-09-29T16:25:56Z","merged_at":"2016-09-29T16:25:56Z","merge_commit_sha":"3e84a134f60f1f049c599e90ae749b30bd79775b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/krakjoe/apcu/pulls/190/commits","review_comments_url":"https://api.github.com/repos/krakjoe/apcu/pulls/190/comments","review_comment_url":"https://api.github.com/repos/krakjoe/apcu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krakjoe/apcu/issues/190/comments","statuses_url":"https://api.github.com/repos/krakjoe/apcu/statuses/278aedb6da1e923330493fff03496f8401755dea","head":{"label":"TysonAndre:fix-custom-serializer","ref":"fix-custom-serializer","sha":"278aedb6da1e923330493fff03496f8401755dea","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"repo":{"id":64086605,"name":"apcu","full_name":"TysonAndre/apcu","owner":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TysonAndre/apcu","description":"APCu - APC User Cache","fork":true,"url":"https://api.github.com/repos/TysonAndre/apcu","forks_url":"https://api.github.com/repos/TysonAndre/apcu/forks","keys_url":"https://api.github.com/repos/TysonAndre/apcu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TysonAndre/apcu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TysonAndre/apcu/teams","hooks_url":"https://api.github.com/repos/TysonAndre/apcu/hooks","issue_events_url":"https://api.github.com/repos/TysonAndre/apcu/issues/events{/number}","events_url":"https://api.github.com/repos/TysonAndre/apcu/events","assignees_url":"https://api.github.com/repos/TysonAndre/apcu/assignees{/user}","branches_url":"https://api.github.com/repos/TysonAndre/apcu/branches{/branch}","tags_url":"https://api.github.com/repos/TysonAndre/apcu/tags","blobs_url":"https://api.github.com/repos/TysonAndre/apcu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TysonAndre/apcu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TysonAndre/apcu/git/refs{/sha}","trees_url":"https://api.github.com/repos/TysonAndre/apcu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TysonAndre/apcu/statuses/{sha}","languages_url":"https://api.github.com/repos/TysonAndre/apcu/languages","stargazers_url":"https://api.github.com/repos/TysonAndre/apcu/stargazers","contributors_url":"https://api.github.com/repos/TysonAndre/apcu/contributors","subscribers_url":"https://api.github.com/repos/TysonAndre/apcu/subscribers","subscription_url":"https://api.github.com/repos/TysonAndre/apcu/subscription","commits_url":"https://api.github.com/repos/TysonAndre/apcu/commits{/sha}","git_commits_url":"https://api.github.com/repos/TysonAndre/apcu/git/commits{/sha}","comments_url":"https://api.github.com/repos/TysonAndre/apcu/comments{/number}","issue_comment_url":"https://api.github.com/repos/TysonAndre/apcu/issues/comments{/number}","contents_url":"https://api.github.com/repos/TysonAndre/apcu/contents/{+path}","compare_url":"https://api.github.com/repos/TysonAndre/apcu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TysonAndre/apcu/merges","archive_url":"https://api.github.com/repos/TysonAndre/apcu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TysonAndre/apcu/downloads","issues_url":"https://api.github.com/repos/TysonAndre/apcu/issues{/number}","pulls_url":"https://api.github.com/repos/TysonAndre/apcu/pulls{/number}","milestones_url":"https://api.github.com/repos/TysonAndre/apcu/milestones{/number}","notifications_url":"https://api.github.com/repos/TysonAndre/apcu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TysonAndre/apcu/labels{/name}","releases_url":"https://api.github.com/repos/TysonAndre/apcu/releases{/id}","deployments_url":"https://api.github.com/repos/TysonAndre/apcu/deployments","created_at":"2016-07-24T21:32:56Z","updated_at":"2016-09-14T21:02:52Z","pushed_at":"2016-09-29T15:37:14Z","git_url":"git://github.com/TysonAndre/apcu.git","ssh_url":"git@github.com:TysonAndre/apcu.git","clone_url":"https://github.com/TysonAndre/apcu.git","svn_url":"https://github.com/TysonAndre/apcu","homepage":"","size":1069,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"krakjoe:master","ref":"master","sha":"62f559e18f2cf047ff77b090682fdfb4e7314df5","user":{"login":"krakjoe","id":2236138,"avatar_url":"https://avatars.githubusercontent.com/u/2236138?v=3","gravatar_id":"","url":"https://api.github.com/users/krakjoe","html_url":"https://github.com/krakjoe","followers_url":"https://api.github.com/users/krakjoe/followers","following_url":"https://api.github.com/users/krakjoe/following{/other_user}","gists_url":"https://api.github.com/users/krakjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/krakjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakjoe/subscriptions","organizations_url":"https://api.github.com/users/krakjoe/orgs","repos_url":"https://api.github.com/users/krakjoe/repos","events_url":"https://api.github.com/users/krakjoe/events{/privacy}","received_events_url":"https://api.github.com/users/krakjoe/received_events","type":"User","site_admin":false},"repo":{"id":8491867,"name":"apcu","full_name":"krakjoe/apcu","owner":{"login":"krakjoe","id":2236138,"avatar_url":"https://avatars.githubusercontent.com/u/2236138?v=3","gravatar_id":"","url":"https://api.github.com/users/krakjoe","html_url":"https://github.com/krakjoe","followers_url":"https://api.github.com/users/krakjoe/followers","following_url":"https://api.github.com/users/krakjoe/following{/other_user}","gists_url":"https://api.github.com/users/krakjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/krakjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakjoe/subscriptions","organizations_url":"https://api.github.com/users/krakjoe/orgs","repos_url":"https://api.github.com/users/krakjoe/repos","events_url":"https://api.github.com/users/krakjoe/events{/privacy}","received_events_url":"https://api.github.com/users/krakjoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krakjoe/apcu","description":"APCu - APC User Cache","fork":false,"url":"https://api.github.com/repos/krakjoe/apcu","forks_url":"https://api.github.com/repos/krakjoe/apcu/forks","keys_url":"https://api.github.com/repos/krakjoe/apcu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krakjoe/apcu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krakjoe/apcu/teams","hooks_url":"https://api.github.com/repos/krakjoe/apcu/hooks","issue_events_url":"https://api.github.com/repos/krakjoe/apcu/issues/events{/number}","events_url":"https://api.github.com/repos/krakjoe/apcu/events","assignees_url":"https://api.github.com/repos/krakjoe/apcu/assignees{/user}","branches_url":"https://api.github.com/repos/krakjoe/apcu/branches{/branch}","tags_url":"https://api.github.com/repos/krakjoe/apcu/tags","blobs_url":"https://api.github.com/repos/krakjoe/apcu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krakjoe/apcu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krakjoe/apcu/git/refs{/sha}","trees_url":"https://api.github.com/repos/krakjoe/apcu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krakjoe/apcu/statuses/{sha}","languages_url":"https://api.github.com/repos/krakjoe/apcu/languages","stargazers_url":"https://api.github.com/repos/krakjoe/apcu/stargazers","contributors_url":"https://api.github.com/repos/krakjoe/apcu/contributors","subscribers_url":"https://api.github.com/repos/krakjoe/apcu/subscribers","subscription_url":"https://api.github.com/repos/krakjoe/apcu/subscription","commits_url":"https://api.github.com/repos/krakjoe/apcu/commits{/sha}","git_commits_url":"https://api.github.com/repos/krakjoe/apcu/git/commits{/sha}","comments_url":"https://api.github.com/repos/krakjoe/apcu/comments{/number}","issue_comment_url":"https://api.github.com/repos/krakjoe/apcu/issues/comments{/number}","contents_url":"https://api.github.com/repos/krakjoe/apcu/contents/{+path}","compare_url":"https://api.github.com/repos/krakjoe/apcu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krakjoe/apcu/merges","archive_url":"https://api.github.com/repos/krakjoe/apcu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krakjoe/apcu/downloads","issues_url":"https://api.github.com/repos/krakjoe/apcu/issues{/number}","pulls_url":"https://api.github.com/repos/krakjoe/apcu/pulls{/number}","milestones_url":"https://api.github.com/repos/krakjoe/apcu/milestones{/number}","notifications_url":"https://api.github.com/repos/krakjoe/apcu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krakjoe/apcu/labels{/name}","releases_url":"https://api.github.com/repos/krakjoe/apcu/releases{/id}","deployments_url":"https://api.github.com/repos/krakjoe/apcu/deployments","created_at":"2013-03-01T01:21:28Z","updated_at":"2016-09-29T16:06:18Z","pushed_at":"2016-09-29T16:25:58Z","git_url":"git://github.com/krakjoe/apcu.git","ssh_url":"git@github.com:krakjoe/apcu.git","clone_url":"https://github.com/krakjoe/apcu.git","svn_url":"https://github.com/krakjoe/apcu","homepage":"","size":1560,"stargazers_count":530,"watchers_count":530,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":19,"forks":77,"open_issues":19,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krakjoe/apcu/pulls/190"},"html":{"href":"https://github.com/krakjoe/apcu/pull/190"},"issue":{"href":"https://api.github.com/repos/krakjoe/apcu/issues/190"},"comments":{"href":"https://api.github.com/repos/krakjoe/apcu/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/krakjoe/apcu/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/krakjoe/apcu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krakjoe/apcu/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/krakjoe/apcu/statuses/278aedb6da1e923330493fff03496f8401755dea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"krakjoe","id":2236138,"avatar_url":"https://avatars.githubusercontent.com/u/2236138?v=3","gravatar_id":"","url":"https://api.github.com/users/krakjoe","html_url":"https://github.com/krakjoe","followers_url":"https://api.github.com/users/krakjoe/followers","following_url":"https://api.github.com/users/krakjoe/following{/other_user}","gists_url":"https://api.github.com/users/krakjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/krakjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakjoe/subscriptions","organizations_url":"https://api.github.com/users/krakjoe/orgs","repos_url":"https://api.github.com/users/krakjoe/repos","events_url":"https://api.github.com/users/krakjoe/events{/privacy}","received_events_url":"https://api.github.com/users/krakjoe/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":122,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"krakjoe"}}