{"action":"created","issue":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2022","repository_url":"https://api.github.com/repos/buttonmen-dev/buttonmen","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2022/labels{/name}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2022/comments","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2022/events","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2022","id":157333827,"number":2022,"title":"Added user preference for die backgrounds","user":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=3","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/labels/incomplete","name":"incomplete","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=3","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"assignees":[{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=3","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-05-28T11:12:55Z","updated_at":"2016-06-30T15:34:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/2022","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2022","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/2022.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/2022.patch"},"body":"Fixes #822. Depends on #1981.\r\n\r\nTested with a standard Soldiers matchup, and changed the user preference multiple times, then logged in as the opponent to see that their view is unchanged.\r\n\r\nKnown issue: twin dice are not dealt with specifically, they are displayed as their combined maximum\r\n\r\nhttp://jenkins.buttonweavers.com:8080/job/buttonmen-blackshadowshade/1149/ (if it passes)"},"comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/229696817","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/2022#issuecomment-229696817","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/2022","id":229696817,"user":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=3","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T15:34:05Z","updated_at":"2016-06-30T15:34:05Z","body":"One note for your redo here is: i think the various attribute classes (`die_dead` and whatnot) are outputs not inputs from the POV of the code --- where possible, they are used to affect browser behavior, not as inputs to the code about logic to use in assembling the page in the first place.  That's because the code already has the logic it used to needs to figure out the state of a die, from the API data, and doesn't need to rederive it from the page.\r\n\r\nIn other words, IMO you should be able to use dieClickableInfo and dieStatus to figure out which image to display for each die, you shouldn't need the CSS properties."}}
{"actor":{"display_login":"cgolubi1"}}