{"action":"created","issue":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/5038","repository_url":"https://api.github.com/repos/syl20bnr/spacemacs","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/5038/labels{/name}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/5038/comments","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/5038/events","html_url":"https://github.com/syl20bnr/spacemacs/pull/5038","id":133032207,"number":5038,"title":"Remove ruby-end-mode and use smartparens instead","user":{"login":"mmainz","id":5417714,"avatar_url":"https://avatars.githubusercontent.com/u/5417714?v=3","gravatar_id":"","url":"https://api.github.com/users/mmainz","html_url":"https://github.com/mmainz","followers_url":"https://api.github.com/users/mmainz/followers","following_url":"https://api.github.com/users/mmainz/following{/other_user}","gists_url":"https://api.github.com/users/mmainz/gists{/gist_id}","starred_url":"https://api.github.com/users/mmainz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmainz/subscriptions","organizations_url":"https://api.github.com/users/mmainz/orgs","repos_url":"https://api.github.com/users/mmainz/repos","events_url":"https://api.github.com/users/mmainz/events{/privacy}","received_events_url":"https://api.github.com/users/mmainz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/syl20bnr/spacemacs/labels/Enhancement%20%E2%98%BA","name":"Enhancement ☺","color":"fef2c0"}],"state":"closed","locked":false,"assignee":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"assignees":[{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-02-11T17:13:27Z","updated_at":"2016-08-16T23:49:14Z","closed_at":"2016-02-15T05:17:30Z","pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/5038","html_url":"https://github.com/syl20bnr/spacemacs/pull/5038","diff_url":"https://github.com/syl20bnr/spacemacs/pull/5038.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/5038.patch"},"body":"ruby-end-mode does not always behave correctly. An example for that is\r\nif statements, which don't have an end statement if they are written on\r\none line. Also, it feels dirty to use a Ruby package to implement Elixir\r\nsyntax behaviour.\r\nSmartparens has functionality to define pairs for certain major modes.\r\nThis adds smartparens pairs for the \"do\" keyword and the arrow (->)\r\noperator, so that the \"end\" keyword is automatically inserted and\r\nproperly indented on enter.\r\n\r\nThis also seems to be the recommended way to get this kind of behaviour.\r\nSee here: https://github.com/tonini/alchemist.el/issues/97\r\n"},"comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments/240274057","html_url":"https://github.com/syl20bnr/spacemacs/pull/5038#issuecomment-240274057","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/5038","id":240274057,"user":{"login":"jojojames","id":1227856,"avatar_url":"https://avatars.githubusercontent.com/u/1227856?v=3","gravatar_id":"","url":"https://api.github.com/users/jojojames","html_url":"https://github.com/jojojames","followers_url":"https://api.github.com/users/jojojames/followers","following_url":"https://api.github.com/users/jojojames/following{/other_user}","gists_url":"https://api.github.com/users/jojojames/gists{/gist_id}","starred_url":"https://api.github.com/users/jojojames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojojames/subscriptions","organizations_url":"https://api.github.com/users/jojojames/orgs","repos_url":"https://api.github.com/users/jojojames/repos","events_url":"https://api.github.com/users/jojojames/events{/privacy}","received_events_url":"https://api.github.com/users/jojojames/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T23:49:14Z","updated_at":"2016-08-16T23:49:14Z","body":"Would this be better?\r\n\r\n    (sp-local-pair \"fn\" \"end\"\r\n                   :when '((\"SPC\" \"RET\"))\r\n                   :post-handlers '(sp-ruby-def-post-handler)\r\n                   :actions '(insert navigate))\r\n\r\nYou can have -> without the end so they aren't a true pair, with -> you'll get unintentional 'ends' added when you type code like this.\r\n\r\n    if x = 3 do\r\n      case y = :ok do\r\n        :ok -> :ok\r\n        :error -> a = \"it's an error\"\r\n      end\r\n    else\r\n      z = 11\r\n    end\r\n\r\nhttp://elixir-lang.readthedocs.io/en/latest/technical/scoping.html\r\n\r\nfn examples would be\r\n\r\nfn end\r\nfn y -> end\r\n\r\n"}}
{"actor":{"display_login":"jojojames"}}