{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/stan/issues/2147","repository_url":"https://api.github.com/repos/stan-dev/stan","labels_url":"https://api.github.com/repos/stan-dev/stan/issues/2147/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/2147/comments","events_url":"https://api.github.com/repos/stan-dev/stan/issues/2147/events","html_url":"https://github.com/stan-dev/stan/pull/2147","id":192475569,"number":2147,"title":"Bugfix/issue 2146 compound declare define matrix","user":{"login":"mitzimorris","id":5466612,"avatar_url":"https://avatars.githubusercontent.com/u/5466612?v=3","gravatar_id":"","url":"https://api.github.com/users/mitzimorris","html_url":"https://github.com/mitzimorris","followers_url":"https://api.github.com/users/mitzimorris/followers","following_url":"https://api.github.com/users/mitzimorris/following{/other_user}","gists_url":"https://api.github.com/users/mitzimorris/gists{/gist_id}","starred_url":"https://api.github.com/users/mitzimorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitzimorris/subscriptions","organizations_url":"https://api.github.com/users/mitzimorris/orgs","repos_url":"https://api.github.com/users/mitzimorris/repos","events_url":"https://api.github.com/users/mitzimorris/events{/privacy}","received_events_url":"https://api.github.com/users/mitzimorris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-30T04:55:14Z","updated_at":"2016-12-02T03:17:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/2147","html_url":"https://github.com/stan-dev/stan/pull/2147","diff_url":"https://github.com/stan-dev/stan/pull/2147.diff","patch_url":"https://github.com/stan-dev/stan/pull/2147.patch"},"body":"#### Submisison Checklist\r\n\r\n- [x] Run unit tests: `./runTests.py src/test/unit`\r\n- [x] Run cpplint: `make cpplint`\r\n- [x] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary\r\n\r\nFixed Stan lang grammar rules so that compound declaration/definition statements for matrix variables record variable definition during parsing.\r\n\r\n#### Intended Effect\r\n\r\nCompount declaration/definition statements work for matrix types.\r\n\r\n#### How to Verify\r\n\r\nRun the Stan compiler over test model src/test/test-models/good/declare-define-var-matrix-2.stan, which contains the following 2 matrix definition statements:\r\n\r\n> transformed data {\r\n>   matrix[2,3] m23;\r\n>   matrix[2,3] yam23 = m23;\r\n> }\r\n\r\nVerify that the compiled model includes variable assignment statement as well as variable declaration:\r\n\r\n>         // initialize undefined transformed variables to avoid seg fault on val access\r\n>         stan::math::fill(m23,DUMMY_VAR__);\r\n>         stan::math::fill(yam23,DUMMY_VAR__);\r\n>         // assign variable definitions\r\n>         stan::math::assign(yam23,m23);\r\n\r\n#### Side Effects\r\n\r\n#### Documentation\r\n\r\n#### Reviewer Suggestions\r\n\r\nDaniel Lee\r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Mitzi Morris\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)"},"comment":{"url":"https://api.github.com/repos/stan-dev/stan/issues/comments/264363307","html_url":"https://github.com/stan-dev/stan/pull/2147#issuecomment-264363307","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/2147","id":264363307,"user":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"created_at":"2016-12-02T03:17:25Z","updated_at":"2016-12-02T03:17:25Z","body":"Jenkins, retest this please."}}
{"actor":{"display_login":"syclik"}}