{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments/57253755","id":57253755,"diff_hunk":"@@ -31,3 +31,32 @@ type RawSpan struct {\n \t// The span's associated baggage.\n \tBaggage map[string]string // initialized on first use\n }\n+\n+// SpanDetail summarizes the identifying fields of a Span, for\n+// diagnostic and implementation-specific purposes.\n+type SpanDetail struct {","path":"raw.go","position":7,"original_position":7,"commit_id":"1ee3a33576999437861bea0db4772e3c8c853411","original_commit_id":"a79cc149a467cf7c6947763d3b20bf87ab7b6dd4","user":{"login":"jmacd","id":3629705,"avatar_url":"https://avatars.githubusercontent.com/u/3629705?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacd","html_url":"https://github.com/jmacd","followers_url":"https://api.github.com/users/jmacd/followers","following_url":"https://api.github.com/users/jmacd/following{/other_user}","gists_url":"https://api.github.com/users/jmacd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacd/subscriptions","organizations_url":"https://api.github.com/users/jmacd/orgs","repos_url":"https://api.github.com/users/jmacd/repos","events_url":"https://api.github.com/users/jmacd/events{/privacy}","received_events_url":"https://api.github.com/users/jmacd/received_events","type":"User","site_admin":false},"body":"(Suddenly realizing it would be better if my first pull request to an OT repo were not trying to punch holes in these abstractions.)  I would ask @bensigelman to fill in some motivation here, since I'm not sure I'll get the language right.","created_at":"2016-03-23T23:20:52Z","updated_at":"2016-03-23T23:20:52Z","html_url":"https://github.com/opentracing/basictracer-go/pull/18#discussion_r57253755","pull_request_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments/57253755"},"html":{"href":"https://github.com/opentracing/basictracer-go/pull/18#discussion_r57253755"},"pull_request":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18","id":63955897,"html_url":"https://github.com/opentracing/basictracer-go/pull/18","diff_url":"https://github.com/opentracing/basictracer-go/pull/18.diff","patch_url":"https://github.com/opentracing/basictracer-go/pull/18.patch","issue_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/18","number":18,"state":"open","locked":false,"title":"Expose details for basictracer spans / tracers","user":{"login":"jmacd","id":3629705,"avatar_url":"https://avatars.githubusercontent.com/u/3629705?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacd","html_url":"https://github.com/jmacd","followers_url":"https://api.github.com/users/jmacd/followers","following_url":"https://api.github.com/users/jmacd/following{/other_user}","gists_url":"https://api.github.com/users/jmacd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacd/subscriptions","organizations_url":"https://api.github.com/users/jmacd/orgs","repos_url":"https://api.github.com/users/jmacd/repos","events_url":"https://api.github.com/users/jmacd/events{/privacy}","received_events_url":"https://api.github.com/users/jmacd/received_events","type":"User","site_admin":false},"body":"This allows basictracer implementations to extract detail (Context, Operation, Start) from spans at runtime and to retrieve the global Recorder implementation.","created_at":"2016-03-23T21:28:34Z","updated_at":"2016-03-23T23:20:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e6b6c4a3d43562a13343bdff28f29fb9271f50b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18/commits","review_comments_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18/comments","review_comment_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/18/comments","statuses_url":"https://api.github.com/repos/opentracing/basictracer-go/statuses/1ee3a33576999437861bea0db4772e3c8c853411","head":{"label":"jmacd:changes/exposebasicdetail","ref":"changes/exposebasicdetail","sha":"1ee3a33576999437861bea0db4772e3c8c853411","user":{"login":"jmacd","id":3629705,"avatar_url":"https://avatars.githubusercontent.com/u/3629705?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacd","html_url":"https://github.com/jmacd","followers_url":"https://api.github.com/users/jmacd/followers","following_url":"https://api.github.com/users/jmacd/following{/other_user}","gists_url":"https://api.github.com/users/jmacd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacd/subscriptions","organizations_url":"https://api.github.com/users/jmacd/orgs","repos_url":"https://api.github.com/users/jmacd/repos","events_url":"https://api.github.com/users/jmacd/events{/privacy}","received_events_url":"https://api.github.com/users/jmacd/received_events","type":"User","site_admin":false},"repo":{"id":54593953,"name":"basictracer-go","full_name":"jmacd/basictracer-go","owner":{"login":"jmacd","id":3629705,"avatar_url":"https://avatars.githubusercontent.com/u/3629705?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacd","html_url":"https://github.com/jmacd","followers_url":"https://api.github.com/users/jmacd/followers","following_url":"https://api.github.com/users/jmacd/following{/other_user}","gists_url":"https://api.github.com/users/jmacd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacd/subscriptions","organizations_url":"https://api.github.com/users/jmacd/orgs","repos_url":"https://api.github.com/users/jmacd/repos","events_url":"https://api.github.com/users/jmacd/events{/privacy}","received_events_url":"https://api.github.com/users/jmacd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmacd/basictracer-go","description":"The Go incarnation of the cross-platform \"BasicTracer\" reference impl for OpenTracing","fork":true,"url":"https://api.github.com/repos/jmacd/basictracer-go","forks_url":"https://api.github.com/repos/jmacd/basictracer-go/forks","keys_url":"https://api.github.com/repos/jmacd/basictracer-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmacd/basictracer-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmacd/basictracer-go/teams","hooks_url":"https://api.github.com/repos/jmacd/basictracer-go/hooks","issue_events_url":"https://api.github.com/repos/jmacd/basictracer-go/issues/events{/number}","events_url":"https://api.github.com/repos/jmacd/basictracer-go/events","assignees_url":"https://api.github.com/repos/jmacd/basictracer-go/assignees{/user}","branches_url":"https://api.github.com/repos/jmacd/basictracer-go/branches{/branch}","tags_url":"https://api.github.com/repos/jmacd/basictracer-go/tags","blobs_url":"https://api.github.com/repos/jmacd/basictracer-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmacd/basictracer-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmacd/basictracer-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmacd/basictracer-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmacd/basictracer-go/statuses/{sha}","languages_url":"https://api.github.com/repos/jmacd/basictracer-go/languages","stargazers_url":"https://api.github.com/repos/jmacd/basictracer-go/stargazers","contributors_url":"https://api.github.com/repos/jmacd/basictracer-go/contributors","subscribers_url":"https://api.github.com/repos/jmacd/basictracer-go/subscribers","subscription_url":"https://api.github.com/repos/jmacd/basictracer-go/subscription","commits_url":"https://api.github.com/repos/jmacd/basictracer-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmacd/basictracer-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmacd/basictracer-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmacd/basictracer-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmacd/basictracer-go/contents/{+path}","compare_url":"https://api.github.com/repos/jmacd/basictracer-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmacd/basictracer-go/merges","archive_url":"https://api.github.com/repos/jmacd/basictracer-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmacd/basictracer-go/downloads","issues_url":"https://api.github.com/repos/jmacd/basictracer-go/issues{/number}","pulls_url":"https://api.github.com/repos/jmacd/basictracer-go/pulls{/number}","milestones_url":"https://api.github.com/repos/jmacd/basictracer-go/milestones{/number}","notifications_url":"https://api.github.com/repos/jmacd/basictracer-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmacd/basictracer-go/labels{/name}","releases_url":"https://api.github.com/repos/jmacd/basictracer-go/releases{/id}","deployments_url":"https://api.github.com/repos/jmacd/basictracer-go/deployments","created_at":"2016-03-23T21:22:52Z","updated_at":"2016-03-23T21:22:53Z","pushed_at":"2016-03-23T22:17:53Z","git_url":"git://github.com/jmacd/basictracer-go.git","ssh_url":"git@github.com:jmacd/basictracer-go.git","clone_url":"https://github.com/jmacd/basictracer-go.git","svn_url":"https://github.com/jmacd/basictracer-go","homepage":"","size":90,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing:master","ref":"master","sha":"e79a6e4bb4a70da437c0546805e47552a62cd7f6","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":52178939,"name":"basictracer-go","full_name":"opentracing/basictracer-go","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/basictracer-go","description":"The Go incarnation of the cross-platform \"BasicTracer\" reference impl for OpenTracing","fork":false,"url":"https://api.github.com/repos/opentracing/basictracer-go","forks_url":"https://api.github.com/repos/opentracing/basictracer-go/forks","keys_url":"https://api.github.com/repos/opentracing/basictracer-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/basictracer-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/basictracer-go/teams","hooks_url":"https://api.github.com/repos/opentracing/basictracer-go/hooks","issue_events_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/basictracer-go/events","assignees_url":"https://api.github.com/repos/opentracing/basictracer-go/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/basictracer-go/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/basictracer-go/tags","blobs_url":"https://api.github.com/repos/opentracing/basictracer-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/basictracer-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/basictracer-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/basictracer-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/basictracer-go/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/basictracer-go/languages","stargazers_url":"https://api.github.com/repos/opentracing/basictracer-go/stargazers","contributors_url":"https://api.github.com/repos/opentracing/basictracer-go/contributors","subscribers_url":"https://api.github.com/repos/opentracing/basictracer-go/subscribers","subscription_url":"https://api.github.com/repos/opentracing/basictracer-go/subscription","commits_url":"https://api.github.com/repos/opentracing/basictracer-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/basictracer-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/basictracer-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/basictracer-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/basictracer-go/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/basictracer-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/basictracer-go/merges","archive_url":"https://api.github.com/repos/opentracing/basictracer-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/basictracer-go/downloads","issues_url":"https://api.github.com/repos/opentracing/basictracer-go/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/basictracer-go/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/basictracer-go/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/basictracer-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/basictracer-go/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/basictracer-go/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/basictracer-go/deployments","created_at":"2016-02-20T22:34:23Z","updated_at":"2016-03-08T00:55:58Z","pushed_at":"2016-03-23T22:17:54Z","git_url":"git://github.com/opentracing/basictracer-go.git","ssh_url":"git@github.com:opentracing/basictracer-go.git","clone_url":"https://github.com/opentracing/basictracer-go.git","svn_url":"https://github.com/opentracing/basictracer-go","homepage":"","size":91,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18"},"html":{"href":"https://github.com/opentracing/basictracer-go/pull/18"},"issue":{"href":"https://api.github.com/repos/opentracing/basictracer-go/issues/18"},"comments":{"href":"https://api.github.com/repos/opentracing/basictracer-go/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/basictracer-go/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/basictracer-go/statuses/1ee3a33576999437861bea0db4772e3c8c853411"}}}}