{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/1010","repository_url":"https://api.github.com/repos/OpenMW/openmw","labels_url":"https://api.github.com/repos/OpenMW/openmw/issues/1010/labels{/name}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1010/comments","events_url":"https://api.github.com/repos/OpenMW/openmw/issues/1010/events","html_url":"https://github.com/OpenMW/openmw/pull/1010","id":169520770,"number":1010,"title":"Render water in editor.","user":{"login":"Aesylwinn","id":4952410,"avatar_url":"https://avatars.githubusercontent.com/u/4952410?v=3","gravatar_id":"","url":"https://api.github.com/users/Aesylwinn","html_url":"https://github.com/Aesylwinn","followers_url":"https://api.github.com/users/Aesylwinn/followers","following_url":"https://api.github.com/users/Aesylwinn/following{/other_user}","gists_url":"https://api.github.com/users/Aesylwinn/gists{/gist_id}","starred_url":"https://api.github.com/users/Aesylwinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aesylwinn/subscriptions","organizations_url":"https://api.github.com/users/Aesylwinn/orgs","repos_url":"https://api.github.com/users/Aesylwinn/repos","events_url":"https://api.github.com/users/Aesylwinn/events{/privacy}","received_events_url":"https://api.github.com/users/Aesylwinn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-05T03:21:04Z","updated_at":"2016-08-05T18:03:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1010","html_url":"https://github.com/OpenMW/openmw/pull/1010","diff_url":"https://github.com/OpenMW/openmw/pull/1010.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1010.patch"},"body":"This implements [feature#1596.](https://bugs.openmw.org/issues/1596)\r\n\r\nI wasn't sure what the best way to go about keeping up to date with the cell data. It seemed silly to add yet another slot to the WorldSpaceWidget class that would have to be inherited by both the Paged/Unpaged child classes and passed on to the correct cell. I can change it to do that if desired.\r\n\r\n@scrawl \r\nI was having issues with the lighting flickering when I moved or looked around in certain spots, so I had to disable it. Any idea what could be causing that? Also, should I be using higher numbers for the rendering bins, or will 1000 and 2000 be fine?"},"comment":{"url":"https://api.github.com/repos/OpenMW/openmw/issues/comments/237920552","html_url":"https://github.com/OpenMW/openmw/pull/1010#issuecomment-237920552","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1010","id":237920552,"user":{"login":"scrawl","id":720642,"avatar_url":"https://avatars.githubusercontent.com/u/720642?v=3","gravatar_id":"","url":"https://api.github.com/users/scrawl","html_url":"https://github.com/scrawl","followers_url":"https://api.github.com/users/scrawl/followers","following_url":"https://api.github.com/users/scrawl/following{/other_user}","gists_url":"https://api.github.com/users/scrawl/gists{/gist_id}","starred_url":"https://api.github.com/users/scrawl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrawl/subscriptions","organizations_url":"https://api.github.com/users/scrawl/orgs","repos_url":"https://api.github.com/users/scrawl/repos","events_url":"https://api.github.com/users/scrawl/events{/privacy}","received_events_url":"https://api.github.com/users/scrawl/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T18:03:43Z","updated_at":"2016-08-05T18:03:43Z","body":"> I don't think I need to ignore the point lights anymore. The the ambient light is getting set to full blast and some testing would suggest that the point lights no longer have any effect on the water.\r\n\r\nThat might not be the case when lighting is set to Night mode and the scene ambient is much lower.\r\n\r\nActually, I just remembered that point lights are not even enabled by default. Only by adding a [LightListCallback](https://github.com/OpenMW/openmw/blob/master/components/sceneutil/lightmanager.hpp#L149) to the object (or a parent node of the object) the point lighting is enabled. So there is nothing to be done here (no need to explicitely ignore point lights)."}}
{"actor":{"display_login":"scrawl"}}