{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/39","id":45155021,"html_url":"https://github.com/Ocramius/GeneratedHydrator/pull/39","diff_url":"https://github.com/Ocramius/GeneratedHydrator/pull/39.diff","patch_url":"https://github.com/Ocramius/GeneratedHydrator/pull/39.patch","issue_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues/39","number":39,"state":"closed","locked":false,"title":"Configurable generator","user":{"login":"sandermarechal","id":145240,"avatar_url":"https://avatars.githubusercontent.com/u/145240?v=3","gravatar_id":"","url":"https://api.github.com/users/sandermarechal","html_url":"https://github.com/sandermarechal","followers_url":"https://api.github.com/users/sandermarechal/followers","following_url":"https://api.github.com/users/sandermarechal/following{/other_user}","gists_url":"https://api.github.com/users/sandermarechal/gists{/gist_id}","starred_url":"https://api.github.com/users/sandermarechal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandermarechal/subscriptions","organizations_url":"https://api.github.com/users/sandermarechal/orgs","repos_url":"https://api.github.com/users/sandermarechal/repos","events_url":"https://api.github.com/users/sandermarechal/events{/privacy}","received_events_url":"https://api.github.com/users/sandermarechal/received_events","type":"User","site_admin":false},"body":"This is a rebase of #21 with added unittests.\r\n\r\nOne thing I am wondering about is the method signature of `HydratorGeneratorFactory::createHydratorGenerator()`. The original implementation by @magnusnordlander has no parameters for this method. I think it may be smart to pass `$realClassName` as a parameter so that a factory can return different types of HydratorGenerators for different classes.","created_at":"2015-09-16T10:31:50Z","updated_at":"2016-01-12T11:03:42Z","closed_at":"2016-01-12T11:03:41Z","merged_at":null,"merge_commit_sha":"03cfe7fad41b057a8b027a7b1945d046d63482de","assignee":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/milestones/8","html_url":"https://github.com/Ocramius/GeneratedHydrator/milestones/2.0.0","labels_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/milestones/8/labels","id":1078539,"number":8,"title":"2.0.0","description":"","creator":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2015-04-22T09:09:35Z","updated_at":"2016-01-12T11:03:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/39/commits","review_comments_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/39/comments","review_comment_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues/39/comments","statuses_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/statuses/38966dc4f48e472e78cbfdb7ef02f8573790281d","head":{"label":"Prezent:configurable-generator","ref":"configurable-generator","sha":"38966dc4f48e472e78cbfdb7ef02f8573790281d","user":{"login":"Prezent","id":4508883,"avatar_url":"https://avatars.githubusercontent.com/u/4508883?v=3","gravatar_id":"","url":"https://api.github.com/users/Prezent","html_url":"https://github.com/Prezent","followers_url":"https://api.github.com/users/Prezent/followers","following_url":"https://api.github.com/users/Prezent/following{/other_user}","gists_url":"https://api.github.com/users/Prezent/gists{/gist_id}","starred_url":"https://api.github.com/users/Prezent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prezent/subscriptions","organizations_url":"https://api.github.com/users/Prezent/orgs","repos_url":"https://api.github.com/users/Prezent/repos","events_url":"https://api.github.com/users/Prezent/events{/privacy}","received_events_url":"https://api.github.com/users/Prezent/received_events","type":"Organization","site_admin":false},"repo":{"id":42574774,"name":"GeneratedHydrator","full_name":"Prezent/GeneratedHydrator","owner":{"login":"Prezent","id":4508883,"avatar_url":"https://avatars.githubusercontent.com/u/4508883?v=3","gravatar_id":"","url":"https://api.github.com/users/Prezent","html_url":"https://github.com/Prezent","followers_url":"https://api.github.com/users/Prezent/followers","following_url":"https://api.github.com/users/Prezent/following{/other_user}","gists_url":"https://api.github.com/users/Prezent/gists{/gist_id}","starred_url":"https://api.github.com/users/Prezent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prezent/subscriptions","organizations_url":"https://api.github.com/users/Prezent/orgs","repos_url":"https://api.github.com/users/Prezent/repos","events_url":"https://api.github.com/users/Prezent/events{/privacy}","received_events_url":"https://api.github.com/users/Prezent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prezent/GeneratedHydrator","description":":bullettrain_side: Generated Object Hydrator for PHP - fast conversion from array to object to array","fork":true,"url":"https://api.github.com/repos/Prezent/GeneratedHydrator","forks_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/forks","keys_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/teams","hooks_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/hooks","issue_events_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/issues/events{/number}","events_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/events","assignees_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/assignees{/user}","branches_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/branches{/branch}","tags_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/tags","blobs_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/statuses/{sha}","languages_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/languages","stargazers_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/stargazers","contributors_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/contributors","subscribers_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/subscribers","subscription_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/subscription","commits_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/contents/{+path}","compare_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/merges","archive_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/downloads","issues_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/issues{/number}","pulls_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/pulls{/number}","milestones_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/milestones{/number}","notifications_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/labels{/name}","releases_url":"https://api.github.com/repos/Prezent/GeneratedHydrator/releases{/id}","created_at":"2015-09-16T08:29:04Z","updated_at":"2015-09-16T08:29:04Z","pushed_at":"2015-09-29T13:25:05Z","git_url":"git://github.com/Prezent/GeneratedHydrator.git","ssh_url":"git@github.com:Prezent/GeneratedHydrator.git","clone_url":"https://github.com/Prezent/GeneratedHydrator.git","svn_url":"https://github.com/Prezent/GeneratedHydrator","homepage":"","size":819,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ocramius:master","ref":"master","sha":"ba0c96cfbf311203cf7664c566463f4530024ad1","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"repo":{"id":11350663,"name":"GeneratedHydrator","full_name":"Ocramius/GeneratedHydrator","owner":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ocramius/GeneratedHydrator","description":":bullettrain_side: Fast Generated Object Hydrator for PHP","fork":false,"url":"https://api.github.com/repos/Ocramius/GeneratedHydrator","forks_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/forks","keys_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/teams","hooks_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/hooks","issue_events_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues/events{/number}","events_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/events","assignees_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/assignees{/user}","branches_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/branches{/branch}","tags_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/tags","blobs_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/statuses/{sha}","languages_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/languages","stargazers_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/stargazers","contributors_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/contributors","subscribers_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/subscribers","subscription_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/subscription","commits_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/contents/{+path}","compare_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/merges","archive_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/downloads","issues_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues{/number}","pulls_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls{/number}","milestones_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/milestones{/number}","notifications_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/labels{/name}","releases_url":"https://api.github.com/repos/Ocramius/GeneratedHydrator/releases{/id}","created_at":"2013-07-11T19:16:40Z","updated_at":"2016-01-12T10:57:28Z","pushed_at":"2016-01-12T11:03:23Z","git_url":"git://github.com/Ocramius/GeneratedHydrator.git","ssh_url":"git@github.com:Ocramius/GeneratedHydrator.git","clone_url":"https://github.com/Ocramius/GeneratedHydrator.git","svn_url":"https://github.com/Ocramius/GeneratedHydrator","homepage":"","size":788,"stargazers_count":184,"watchers_count":184,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":13,"forks":24,"open_issues":13,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/39"},"html":{"href":"https://github.com/Ocramius/GeneratedHydrator/pull/39"},"issue":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues/39"},"comments":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/Ocramius/GeneratedHydrator/statuses/38966dc4f48e472e78cbfdb7ef02f8573790281d"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":211,"deletions":5,"changed_files":9}}