{"action":"created","comment":{"url":"https://api.github.com/repos/quantcast/qfs/pulls/comments/59077311","id":59077311,"diff_hunk":"@@ -13,8 +13,12 @@\n cmake_minimum_required(VERSION 2.8.4 FATAL_ERROR)\n cmake_policy(VERSION ${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}.${CMAKE_PATCH_VERSION})\n \n+IF (NOT DEFINED KFS_DIR_PREFIX)\n+    set (KFS_DIR_PREFIX ${CMAKE_SOURCE_DIR})","path":"CMakeLists.txt","position":5,"original_position":5,"commit_id":"40b6f2cbc7e8b1a0f880eca229aa80c0178450a4","original_commit_id":"e631832c026a81968851e0e5b62de3fb990c284c","user":{"login":"fsareshwala","id":212864,"avatar_url":"https://avatars.githubusercontent.com/u/212864?v=3","gravatar_id":"","url":"https://api.github.com/users/fsareshwala","html_url":"https://github.com/fsareshwala","followers_url":"https://api.github.com/users/fsareshwala/followers","following_url":"https://api.github.com/users/fsareshwala/following{/other_user}","gists_url":"https://api.github.com/users/fsareshwala/gists{/gist_id}","starred_url":"https://api.github.com/users/fsareshwala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsareshwala/subscriptions","organizations_url":"https://api.github.com/users/fsareshwala/orgs","repos_url":"https://api.github.com/users/fsareshwala/repos","events_url":"https://api.github.com/users/fsareshwala/events{/privacy}","received_events_url":"https://api.github.com/users/fsareshwala/received_events","type":"User","site_admin":false},"body":"I mean that QFS is now an external project to that other source code you are talking about. They no longer live in the same source tree and so we should use solutions for that situation. That is a solved problem. The internal project you are talking about should add qfs as an external project through cmake, link against it's shared or static libraries, and call any APIs that it needs in that way. It is probably doing just that right now but expecting some filesystem path structure. That's what I want to move away from.\r\n\r\nHow about this for now: remove this change from this pull request and make another pull request for this change specifically. That way, we can go forward with this bug fix while we still discuss this change. What do you think?","created_at":"2016-04-08T19:30:37Z","updated_at":"2016-04-08T19:30:37Z","html_url":"https://github.com/quantcast/qfs/pull/120#discussion_r59077311","pull_request_url":"https://api.github.com/repos/quantcast/qfs/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/comments/59077311"},"html":{"href":"https://github.com/quantcast/qfs/pull/120#discussion_r59077311"},"pull_request":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/quantcast/qfs/pulls/120","id":65422136,"html_url":"https://github.com/quantcast/qfs/pull/120","diff_url":"https://github.com/quantcast/qfs/pull/120.diff","patch_url":"https://github.com/quantcast/qfs/pull/120.patch","issue_url":"https://api.github.com/repos/quantcast/qfs/issues/120","number":120,"state":"open","locked":false,"title":"Topic/objectstorewritefix","user":{"login":"mikeov","id":2245721,"avatar_url":"https://avatars.githubusercontent.com/u/2245721?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeov","html_url":"https://github.com/mikeov","followers_url":"https://api.github.com/users/mikeov/followers","following_url":"https://api.github.com/users/mikeov/following{/other_user}","gists_url":"https://api.github.com/users/mikeov/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeov/subscriptions","organizations_url":"https://api.github.com/users/mikeov/orgs","repos_url":"https://api.github.com/users/mikeov/repos","events_url":"https://api.github.com/users/mikeov/events{/privacy}","received_events_url":"https://api.github.com/users/mikeov/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-06T07:38:09Z","updated_at":"2016-04-08T19:30:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b451fc329d58eccab04e12de18c5d9884734781","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/quantcast/qfs/pulls/120/commits","review_comments_url":"https://api.github.com/repos/quantcast/qfs/pulls/120/comments","review_comment_url":"https://api.github.com/repos/quantcast/qfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantcast/qfs/issues/120/comments","statuses_url":"https://api.github.com/repos/quantcast/qfs/statuses/40b6f2cbc7e8b1a0f880eca229aa80c0178450a4","head":{"label":"quantcast:topic/objectstorewritefix","ref":"topic/objectstorewritefix","sha":"40b6f2cbc7e8b1a0f880eca229aa80c0178450a4","user":{"login":"quantcast","id":2146873,"avatar_url":"https://avatars.githubusercontent.com/u/2146873?v=3","gravatar_id":"","url":"https://api.github.com/users/quantcast","html_url":"https://github.com/quantcast","followers_url":"https://api.github.com/users/quantcast/followers","following_url":"https://api.github.com/users/quantcast/following{/other_user}","gists_url":"https://api.github.com/users/quantcast/gists{/gist_id}","starred_url":"https://api.github.com/users/quantcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantcast/subscriptions","organizations_url":"https://api.github.com/users/quantcast/orgs","repos_url":"https://api.github.com/users/quantcast/repos","events_url":"https://api.github.com/users/quantcast/events{/privacy}","received_events_url":"https://api.github.com/users/quantcast/received_events","type":"Organization","site_admin":false},"repo":{"id":5447814,"name":"qfs","full_name":"quantcast/qfs","owner":{"login":"quantcast","id":2146873,"avatar_url":"https://avatars.githubusercontent.com/u/2146873?v=3","gravatar_id":"","url":"https://api.github.com/users/quantcast","html_url":"https://github.com/quantcast","followers_url":"https://api.github.com/users/quantcast/followers","following_url":"https://api.github.com/users/quantcast/following{/other_user}","gists_url":"https://api.github.com/users/quantcast/gists{/gist_id}","starred_url":"https://api.github.com/users/quantcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantcast/subscriptions","organizations_url":"https://api.github.com/users/quantcast/orgs","repos_url":"https://api.github.com/users/quantcast/repos","events_url":"https://api.github.com/users/quantcast/events{/privacy}","received_events_url":"https://api.github.com/users/quantcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantcast/qfs","description":"Quantcast File System","fork":false,"url":"https://api.github.com/repos/quantcast/qfs","forks_url":"https://api.github.com/repos/quantcast/qfs/forks","keys_url":"https://api.github.com/repos/quantcast/qfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantcast/qfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantcast/qfs/teams","hooks_url":"https://api.github.com/repos/quantcast/qfs/hooks","issue_events_url":"https://api.github.com/repos/quantcast/qfs/issues/events{/number}","events_url":"https://api.github.com/repos/quantcast/qfs/events","assignees_url":"https://api.github.com/repos/quantcast/qfs/assignees{/user}","branches_url":"https://api.github.com/repos/quantcast/qfs/branches{/branch}","tags_url":"https://api.github.com/repos/quantcast/qfs/tags","blobs_url":"https://api.github.com/repos/quantcast/qfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantcast/qfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantcast/qfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantcast/qfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantcast/qfs/statuses/{sha}","languages_url":"https://api.github.com/repos/quantcast/qfs/languages","stargazers_url":"https://api.github.com/repos/quantcast/qfs/stargazers","contributors_url":"https://api.github.com/repos/quantcast/qfs/contributors","subscribers_url":"https://api.github.com/repos/quantcast/qfs/subscribers","subscription_url":"https://api.github.com/repos/quantcast/qfs/subscription","commits_url":"https://api.github.com/repos/quantcast/qfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantcast/qfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantcast/qfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantcast/qfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantcast/qfs/contents/{+path}","compare_url":"https://api.github.com/repos/quantcast/qfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantcast/qfs/merges","archive_url":"https://api.github.com/repos/quantcast/qfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantcast/qfs/downloads","issues_url":"https://api.github.com/repos/quantcast/qfs/issues{/number}","pulls_url":"https://api.github.com/repos/quantcast/qfs/pulls{/number}","milestones_url":"https://api.github.com/repos/quantcast/qfs/milestones{/number}","notifications_url":"https://api.github.com/repos/quantcast/qfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantcast/qfs/labels{/name}","releases_url":"https://api.github.com/repos/quantcast/qfs/releases{/id}","deployments_url":"https://api.github.com/repos/quantcast/qfs/deployments","created_at":"2012-08-17T03:59:37Z","updated_at":"2016-04-07T04:40:55Z","pushed_at":"2016-04-08T17:09:44Z","git_url":"git://github.com/quantcast/qfs.git","ssh_url":"git@github.com:quantcast/qfs.git","clone_url":"https://github.com/quantcast/qfs.git","svn_url":"https://github.com/quantcast/qfs","homepage":"https://quantcast.atlassian.net","size":18832,"stargazers_count":433,"watchers_count":433,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":118,"mirror_url":null,"open_issues_count":6,"forks":118,"open_issues":6,"watchers":433,"default_branch":"master"}},"base":{"label":"quantcast:master","ref":"master","sha":"89e617e28d51d8bb2359eb0f93a162f304c91d24","user":{"login":"quantcast","id":2146873,"avatar_url":"https://avatars.githubusercontent.com/u/2146873?v=3","gravatar_id":"","url":"https://api.github.com/users/quantcast","html_url":"https://github.com/quantcast","followers_url":"https://api.github.com/users/quantcast/followers","following_url":"https://api.github.com/users/quantcast/following{/other_user}","gists_url":"https://api.github.com/users/quantcast/gists{/gist_id}","starred_url":"https://api.github.com/users/quantcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantcast/subscriptions","organizations_url":"https://api.github.com/users/quantcast/orgs","repos_url":"https://api.github.com/users/quantcast/repos","events_url":"https://api.github.com/users/quantcast/events{/privacy}","received_events_url":"https://api.github.com/users/quantcast/received_events","type":"Organization","site_admin":false},"repo":{"id":5447814,"name":"qfs","full_name":"quantcast/qfs","owner":{"login":"quantcast","id":2146873,"avatar_url":"https://avatars.githubusercontent.com/u/2146873?v=3","gravatar_id":"","url":"https://api.github.com/users/quantcast","html_url":"https://github.com/quantcast","followers_url":"https://api.github.com/users/quantcast/followers","following_url":"https://api.github.com/users/quantcast/following{/other_user}","gists_url":"https://api.github.com/users/quantcast/gists{/gist_id}","starred_url":"https://api.github.com/users/quantcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantcast/subscriptions","organizations_url":"https://api.github.com/users/quantcast/orgs","repos_url":"https://api.github.com/users/quantcast/repos","events_url":"https://api.github.com/users/quantcast/events{/privacy}","received_events_url":"https://api.github.com/users/quantcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantcast/qfs","description":"Quantcast File System","fork":false,"url":"https://api.github.com/repos/quantcast/qfs","forks_url":"https://api.github.com/repos/quantcast/qfs/forks","keys_url":"https://api.github.com/repos/quantcast/qfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantcast/qfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantcast/qfs/teams","hooks_url":"https://api.github.com/repos/quantcast/qfs/hooks","issue_events_url":"https://api.github.com/repos/quantcast/qfs/issues/events{/number}","events_url":"https://api.github.com/repos/quantcast/qfs/events","assignees_url":"https://api.github.com/repos/quantcast/qfs/assignees{/user}","branches_url":"https://api.github.com/repos/quantcast/qfs/branches{/branch}","tags_url":"https://api.github.com/repos/quantcast/qfs/tags","blobs_url":"https://api.github.com/repos/quantcast/qfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantcast/qfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantcast/qfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantcast/qfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantcast/qfs/statuses/{sha}","languages_url":"https://api.github.com/repos/quantcast/qfs/languages","stargazers_url":"https://api.github.com/repos/quantcast/qfs/stargazers","contributors_url":"https://api.github.com/repos/quantcast/qfs/contributors","subscribers_url":"https://api.github.com/repos/quantcast/qfs/subscribers","subscription_url":"https://api.github.com/repos/quantcast/qfs/subscription","commits_url":"https://api.github.com/repos/quantcast/qfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantcast/qfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantcast/qfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantcast/qfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantcast/qfs/contents/{+path}","compare_url":"https://api.github.com/repos/quantcast/qfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantcast/qfs/merges","archive_url":"https://api.github.com/repos/quantcast/qfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantcast/qfs/downloads","issues_url":"https://api.github.com/repos/quantcast/qfs/issues{/number}","pulls_url":"https://api.github.com/repos/quantcast/qfs/pulls{/number}","milestones_url":"https://api.github.com/repos/quantcast/qfs/milestones{/number}","notifications_url":"https://api.github.com/repos/quantcast/qfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantcast/qfs/labels{/name}","releases_url":"https://api.github.com/repos/quantcast/qfs/releases{/id}","deployments_url":"https://api.github.com/repos/quantcast/qfs/deployments","created_at":"2012-08-17T03:59:37Z","updated_at":"2016-04-07T04:40:55Z","pushed_at":"2016-04-08T17:09:44Z","git_url":"git://github.com/quantcast/qfs.git","ssh_url":"git@github.com:quantcast/qfs.git","clone_url":"https://github.com/quantcast/qfs.git","svn_url":"https://github.com/quantcast/qfs","homepage":"https://quantcast.atlassian.net","size":18832,"stargazers_count":433,"watchers_count":433,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":118,"mirror_url":null,"open_issues_count":6,"forks":118,"open_issues":6,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/120"},"html":{"href":"https://github.com/quantcast/qfs/pull/120"},"issue":{"href":"https://api.github.com/repos/quantcast/qfs/issues/120"},"comments":{"href":"https://api.github.com/repos/quantcast/qfs/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantcast/qfs/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/quantcast/qfs/statuses/40b6f2cbc7e8b1a0f880eca229aa80c0178450a4"}}}}