{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21740","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21740/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21740/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21740/events","html_url":"https://github.com/kubernetes/kubernetes/pull/21740","id":135686378,"number":21740,"title":"Fix error logic and leaking goroutine in docker unit test.","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"fad8c7"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/component/kubelet","name":"component/kubelet","color":"0052cc"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-02-23T09:42:43Z","updated_at":"2016-02-23T10:08:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/21740","html_url":"https://github.com/kubernetes/kubernetes/pull/21740","diff_url":"https://github.com/kubernetes/kubernetes/pull/21740.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/21740.patch"},"body":"This PR did 2 things:\r\n* Let fake docker manager use default image puller instead of serialized image puller to avoid leaking goroutines during unit test running.\r\n* Fix error in `TestSyncPodWithFailure`. Different test cases should not share the same fake docker client.\r\n\r\n/cc @yujuhong @vishh "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/187635945","html_url":"https://github.com/kubernetes/kubernetes/pull/21740#issuecomment-187635945","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/21740","id":187635945,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T10:08:15Z","updated_at":"2016-02-23T10:08:15Z","body":"GCE e2e test build/test **passed** for commit 3338304c7b50a9affa143dbca686b9ab8180bd2d.\n* [Build Log](http://pr-test.k8s.io/21740/kubernetes-pull-build-test-e2e-gce/29934/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/21740/kubernetes-pull-build-test-e2e-gce/29934/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//29934)\n"}}