{"action":"created","issue":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1786","repository_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1786/labels{/name}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1786/comments","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1786/events","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1786","id":185753244,"number":1786,"title":"Cleaning up logging enabled functionality","user":{"login":"khawkins","id":755462,"avatar_url":"https://avatars.githubusercontent.com/u/755462?v=3","gravatar_id":"","url":"https://api.github.com/users/khawkins","html_url":"https://github.com/khawkins","followers_url":"https://api.github.com/users/khawkins/followers","following_url":"https://api.github.com/users/khawkins/following{/other_user}","gists_url":"https://api.github.com/users/khawkins/gists{/gist_id}","starred_url":"https://api.github.com/users/khawkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khawkins/subscriptions","organizations_url":"https://api.github.com/users/khawkins/orgs","repos_url":"https://api.github.com/users/khawkins/repos","events_url":"https://api.github.com/users/khawkins/events{/privacy}","received_events_url":"https://api.github.com/users/khawkins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-27T19:03:02Z","updated_at":"2016-10-27T19:47:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/1786","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1786","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1786.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1786.patch"},"body":"@bhariharan For your consideration:\r\n\r\n- Refactoring the enabled/disabled functionality to a more Objective-C-friendly design pattern.\r\n- Making property getter/setters simply front-ends to the persisted values."},"comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments/256749558","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/1786#issuecomment-256749558","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/1786","id":256749558,"user":{"login":"huminzhi","id":992106,"avatar_url":"https://avatars.githubusercontent.com/u/992106?v=3","gravatar_id":"","url":"https://api.github.com/users/huminzhi","html_url":"https://github.com/huminzhi","followers_url":"https://api.github.com/users/huminzhi/followers","following_url":"https://api.github.com/users/huminzhi/following{/other_user}","gists_url":"https://api.github.com/users/huminzhi/gists{/gist_id}","starred_url":"https://api.github.com/users/huminzhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huminzhi/subscriptions","organizations_url":"https://api.github.com/users/huminzhi/orgs","repos_url":"https://api.github.com/users/huminzhi/repos","events_url":"https://api.github.com/users/huminzhi/events{/privacy}","received_events_url":"https://api.github.com/users/huminzhi/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T19:47:32Z","updated_at":"2016-10-27T19:47:32Z","body":"<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Error\">\n          2 Errors\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n\n    <tr>\n      <td>:no_entry_sign:</td>\n      <td data-sticky=\"false\">Tests have failed, see below for more information.</td>\n    </tr>\n    <tr>\n      <td>:no_entry_sign:</td>\n      <td data-sticky=\"false\">Code coverage under minimum of 80%</td>\n    </tr>\n  </tbody>\n</table>\n\n### Tests: \n\nClassname | Name|\n--- | ---|\nSFSecurityTests | testKeyStoreThreadSafety|\n\n\n## Current coverage for SalesforceAnalytics.framework is `73%`\nFiles changed | - | - \n--- | --- | ---\nSFSDKEventStoreManager.m | `81%` | :white_check_mark:\nSFSDKEventStoreManager.m | `81%` | :white_check_mark:\n\n---\n## Current coverage for SalesforceSDKCore.framework is `51%`\nFiles changed | - | - \n--- | --- | ---\nSFSDKSalesforceAnalyticsManager.m | `45%` | :no_entry_sign:\nSFSDKSalesforceAnalyticsManager.m | `45%` | :no_entry_sign:\n\n---\n## Current coverage for CocoaLumberjack.framework is `32%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartStore.framework is `63%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartSync.framework is `76%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SalesforceHybridSDK.framework is `43%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SalesforceReact.framework is `0%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for RestAPIExplorer.app is `26%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartSyncExplorer.app is `19%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartSyncExplorerCommon.framework is `0%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for RecentContactsTodayExtension.appex is `0%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for AccountEditor.app is `0%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for NoteSync.app is `0%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartSyncExplorerHybrid.app is `0%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SalesforceSDKCoreTestApp.app is `30%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartStoreTestApp.app is `61%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SmartSyncTestApp.app is `61%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SalesforceHybridSDKTestApp.app is `85%`\n✅ *No files affecting coverage found*\n\n---\n## Current coverage for SalesforceAnalyticsTestApp.app is `61%`\n✅ *No files affecting coverage found*\n\n---\n\n> Powered by [xcov](https://github.com/nakiostudio/xcov)\n\n<p align=\"right\" data-meta=\"generated_by_CI-result\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">danger</a>\n</p>\n"}}
{"actor":{"display_login":"huminzhi"}}