{"action":"created","issue":{"url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386","repository_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions","labels_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386/labels{/name}","comments_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386/comments","events_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386/events","html_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386","id":145610398,"number":386,"title":"Semantic (Not)BeEquivalent for XDocument/XElement","user":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-04T07:48:22Z","updated_at":"2016-04-12T06:24:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/pulls/386","html_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386","diff_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386.diff","patch_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386.patch"},"body":"Also fixed a bug where the location for xml comparisons was incorrect after a selfclosed <xml /> element had been compared.\r\n\r\nThe tests for `XDocument/XElement.Should().BeEquivalent()` are not very covering. They basically just checks that semantical equivalency is used. The tests for `XmlNode` are much more extensive, as those are what I used to test the `XmlReaderValidator` implementation. How do you want the tests? I can think of three options.\r\n\r\n1. Kept as it is\r\n2. Also do full tests/specs for `XDocument/XElement` (will be a lot of copied tests)\r\n3. Move the detailed tests to a separate class that tests `XmlReaderValidator` directly\r\n"},"comment":{"url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/comments/208727470","html_url":"https://github.com/dennisdoomen/FluentAssertions/pull/386#issuecomment-208727470","issue_url":"https://api.github.com/repos/dennisdoomen/FluentAssertions/issues/386","id":208727470,"user":{"login":"AndersAbel","id":4894558,"avatar_url":"https://avatars.githubusercontent.com/u/4894558?v=3","gravatar_id":"","url":"https://api.github.com/users/AndersAbel","html_url":"https://github.com/AndersAbel","followers_url":"https://api.github.com/users/AndersAbel/followers","following_url":"https://api.github.com/users/AndersAbel/following{/other_user}","gists_url":"https://api.github.com/users/AndersAbel/gists{/gist_id}","starred_url":"https://api.github.com/users/AndersAbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndersAbel/subscriptions","organizations_url":"https://api.github.com/users/AndersAbel/orgs","repos_url":"https://api.github.com/users/AndersAbel/repos","events_url":"https://api.github.com/users/AndersAbel/events{/privacy}","received_events_url":"https://api.github.com/users/AndersAbel/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T06:24:34Z","updated_at":"2016-04-12T06:24:34Z","body":"Now I think this one is ready to be merged. Do you have anything more you want me to fix?\r\n\r\nI've got another one coming with `HaveAttribute` etc. for XmlElements. I've based it on this commit, so I can't create a PR for it independently. As soon as this one is merged I'll submit the other one."}}