{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7355","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7355/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7355/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7355/events","html_url":"https://github.com/ManageIQ/manageiq/pull/7355","id":141598095,"number":7355,"title":"Add LVM2 Thin Volume / Pool Support","user":{"login":"movitto","id":166845,"avatar_url":"https://avatars.githubusercontent.com/u/166845?v=3","gravatar_id":"","url":"https://api.github.com/users/movitto","html_url":"https://github.com/movitto","followers_url":"https://api.github.com/users/movitto/followers","following_url":"https://api.github.com/users/movitto/following{/other_user}","gists_url":"https://api.github.com/users/movitto/gists{/gist_id}","starred_url":"https://api.github.com/users/movitto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/movitto/subscriptions","organizations_url":"https://api.github.com/users/movitto/orgs","repos_url":"https://api.github.com/users/movitto/repos","events_url":"https://api.github.com/users/movitto/events{/privacy}","received_events_url":"https://api.github.com/users/movitto/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/smart_state","name":"smart_state","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-03-17T14:26:01Z","updated_at":"2016-04-12T19:22:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7355","html_url":"https://github.com/ManageIQ/manageiq/pull/7355","diff_url":"https://github.com/ManageIQ/manageiq/pull/7355.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7355.patch"},"body":"Extends LVM logic to parse LVM2 Thin Pool Metadata and lookup mapped blocks when reading from thin volumes."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/209062815","html_url":"https://github.com/ManageIQ/manageiq/pull/7355#issuecomment-209062815","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7355","id":209062815,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T19:22:23Z","updated_at":"2016-04-12T19:22:23Z","body":"<rubocop />**...continued**\n- [ ] :small_blue_diamond: - [Line 84](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/thin/superblock.rb#L84), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for device_to_data is too high. [27.53/15]\n\n**gems/pending/VolumeManager/LVM/volume_group.rb**\n- [ ] :large_orange_diamond: - [Line 8](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L8), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 9](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L9), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 10](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L10), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 11](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L11), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 13](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L13), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 15](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L15), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 16](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L16), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 20](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L20), Col 57 - [Style/SymbolProc](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SymbolProc) - Pass `&:thin_pool?` as an argument to `select` instead of a block.\n- [ ] :large_orange_diamond: - [Line 24](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L24), Col 52 - [Style/SymbolProc](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SymbolProc) - Pass `&:thin?` as an argument to `select` instead of a block.\n- [ ] :large_orange_diamond: - [Line 27](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L27), Col 7 - [Style/MethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MethodName) - Use snake_case for method names.\n- [ ] :large_orange_diamond: - [Line 28](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L28), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 29](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L29), Col 5 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 30](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L30), Col 36 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 32](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L32), Col 7 - [Style/Next](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/Next) - Use `next` to skip iteration.\n- [ ] :large_orange_diamond: - [Line 34](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L34), Col 66 - [Style/SymbolProc](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SymbolProc) - Pass `&:metadata` as an argument to `collect` instead of a block.\n- [ ] :large_orange_diamond: - [Line 35](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L35), Col 66 - [Style/SymbolProc](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SymbolProc) - Pass `&:pool` as an argument to `collect` instead of a block.\n- [ ] :large_orange_diamond: - [Line 37](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L37), Col 19 - [Style/SpaceAroundOperators](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAroundOperators) - Operator `<<` should be surrounded by a single space.\n- [ ] :large_orange_diamond: - [Line 37](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L37), Col 21 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :large_orange_diamond: - [Line 42](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L42), Col 36 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 66](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L66), Col 33 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :large_orange_diamond: - [Line 78](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L78), Col 30 - [Style/VariableName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/VariableName) - Use snake_case for variable names.\n- [ ] :small_blue_diamond: - [Line 27](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L27), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for getLvs is too high. [28.88/15]\n- [ ] :small_blue_diamond: - [Line 57](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L57), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for dump is too high. [54.08/15]\n- [ ] :small_blue_diamond: - [Line 57](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/LVM/volume_group.rb#L57), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [36/25]\n\n**gems/pending/VolumeManager/MiqVolumeManager.rb**\n- [ ] :red_circle: **Warn** - [Line 147](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/MiqVolumeManager.rb#L147), Col 22 - [Lint/UnusedBlockArgument](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UnusedBlockArgument) - Unused block argument - `vgname`. If it's necessary, use `_` or `_vgname` as an argument name to indicate that it won't be used.\n- [ ] :large_orange_diamond: - [Line 146](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/MiqVolumeManager.rb#L146), Col 7 - [Style/MethodName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MethodName) - Use snake_case for method names.\n- [ ] :small_blue_diamond: - [Line 146](https://github.com/movitto/manageiq/blob/ce72c7d4fe8e0976b4118cff8ca7c91773d4a204/gems/pending/VolumeManager/MiqVolumeManager.rb#L146), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for parseLvmThinMetadata is too high. [19/15]\n"}}