{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/60983257","id":60983257,"diff_hunk":"@@ -129,7 +129,8 @@ unforeseen and unpredictable issues.\n \n Exceptions thrown from within the event handler will not be caught. Instead the\n process will exit with a non zero exit code and the stack trace will be printed.\n-This is to avoid infinite recursion.\n+This is to avoid infinite recursion. There may be other situations where the","path":"doc/api/process.md","position":5,"original_position":5,"commit_id":"e7ff3f18dfbc777e8e356b017489f5a4fd05ea23","original_commit_id":"e7ff3f18dfbc777e8e356b017489f5a4fd05ea23","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"body":"Some clarification on the \"other situations\" would be nice. After reading this, people might not be clear whether or not their `uncaughtException` handler can be expected to run or not.","created_at":"2016-04-25T20:31:23Z","updated_at":"2016-04-25T20:31:23Z","html_url":"https://github.com/nodejs/node/pull/6378#discussion_r60983257","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6378","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/60983257"},"html":{"href":"https://github.com/nodejs/node/pull/6378#discussion_r60983257"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6378"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6378","id":67777707,"html_url":"https://github.com/nodejs/node/pull/6378","diff_url":"https://github.com/nodejs/node/pull/6378.diff","patch_url":"https://github.com/nodejs/node/pull/6378.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6378","number":6378,"state":"open","locked":false,"title":"doc: Warn against `uncaughtException` dependency.","user":{"login":"lance","id":15952,"avatar_url":"https://avatars.githubusercontent.com/u/15952?v=3","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [x] documentation is changed or added\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n\r\ndoc\r\n\r\n##### Description of change\r\n\r\nState in the documentation that `uncaughtException` is not a reliable\r\nway to restart a crashed application, and clarify that an application\r\nmay crash in ways that do not trigger this event.\r\n\r\nFixes https://github.com/nodejs/node/issues/6223","created_at":"2016-04-25T19:52:42Z","updated_at":"2016-04-25T20:31:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d67742d540234cf462f787db72b4434bd7fda37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6378/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6378/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6378/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/e7ff3f18dfbc777e8e356b017489f5a4fd05ea23","head":{"label":"lance:uncaught-exception-doc","ref":"uncaught-exception-doc","sha":"e7ff3f18dfbc777e8e356b017489f5a4fd05ea23","user":{"login":"lance","id":15952,"avatar_url":"https://avatars.githubusercontent.com/u/15952?v=3","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"repo":{"id":52987437,"name":"node","full_name":"lance/node","owner":{"login":"lance","id":15952,"avatar_url":"https://avatars.githubusercontent.com/u/15952?v=3","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lance/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/lance/node","forks_url":"https://api.github.com/repos/lance/node/forks","keys_url":"https://api.github.com/repos/lance/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lance/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lance/node/teams","hooks_url":"https://api.github.com/repos/lance/node/hooks","issue_events_url":"https://api.github.com/repos/lance/node/issues/events{/number}","events_url":"https://api.github.com/repos/lance/node/events","assignees_url":"https://api.github.com/repos/lance/node/assignees{/user}","branches_url":"https://api.github.com/repos/lance/node/branches{/branch}","tags_url":"https://api.github.com/repos/lance/node/tags","blobs_url":"https://api.github.com/repos/lance/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lance/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lance/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/lance/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lance/node/statuses/{sha}","languages_url":"https://api.github.com/repos/lance/node/languages","stargazers_url":"https://api.github.com/repos/lance/node/stargazers","contributors_url":"https://api.github.com/repos/lance/node/contributors","subscribers_url":"https://api.github.com/repos/lance/node/subscribers","subscription_url":"https://api.github.com/repos/lance/node/subscription","commits_url":"https://api.github.com/repos/lance/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/lance/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/lance/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/lance/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/lance/node/contents/{+path}","compare_url":"https://api.github.com/repos/lance/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lance/node/merges","archive_url":"https://api.github.com/repos/lance/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lance/node/downloads","issues_url":"https://api.github.com/repos/lance/node/issues{/number}","pulls_url":"https://api.github.com/repos/lance/node/pulls{/number}","milestones_url":"https://api.github.com/repos/lance/node/milestones{/number}","notifications_url":"https://api.github.com/repos/lance/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lance/node/labels{/name}","releases_url":"https://api.github.com/repos/lance/node/releases{/id}","deployments_url":"https://api.github.com/repos/lance/node/deployments","created_at":"2016-03-02T18:47:13Z","updated_at":"2016-03-02T18:47:24Z","pushed_at":"2016-04-25T19:51:32Z","git_url":"git://github.com/lance/node.git","ssh_url":"git@github.com:lance/node.git","clone_url":"https://github.com/lance/node.git","svn_url":"https://github.com/lance/node","homepage":"https://nodejs.org","size":186292,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"eb4201f07a1b1f430ddf4efad4f276f3088def97","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-04-25T19:35:21Z","pushed_at":"2016-04-25T19:52:42Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":246738,"stargazers_count":22378,"watchers_count":22378,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3072,"mirror_url":null,"open_issues_count":662,"forks":3072,"open_issues":662,"watchers":22378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6378"},"html":{"href":"https://github.com/nodejs/node/pull/6378"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6378"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6378/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6378/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6378/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/e7ff3f18dfbc777e8e356b017489f5a4fd05ea23"}}}}