{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/10419","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/10419/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/10419/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/10419/events","html_url":"https://github.com/facebook/react-native/pull/10419","id":183326958,"number":10419,"title":"JS platform module override file","user":{"login":"GantMan","id":997157,"avatar_url":"https://avatars.githubusercontent.com/u/997157?v=3","gravatar_id":"","url":"https://api.github.com/users/GantMan","html_url":"https://github.com/GantMan","followers_url":"https://api.github.com/users/GantMan/followers","following_url":"https://api.github.com/users/GantMan/following{/other_user}","gists_url":"https://api.github.com/users/GantMan/gists{/gist_id}","starred_url":"https://api.github.com/users/GantMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GantMan/subscriptions","organizations_url":"https://api.github.com/users/GantMan/orgs","repos_url":"https://api.github.com/users/GantMan/repos","events_url":"https://api.github.com/users/GantMan/events{/privacy}","received_events_url":"https://api.github.com/users/GantMan/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":468774151,"url":"https://api.github.com/repos/facebook/react-native/labels/Core%20Team","name":"Core Team","color":"0052cc","default":false},{"id":172176599,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-10-17T05:14:52Z","updated_at":"2016-10-29T03:40:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/10419","html_url":"https://github.com/facebook/react-native/pull/10419","diff_url":"https://github.com/facebook/react-native/pull/10419.diff","patch_url":"https://github.com/facebook/react-native/pull/10419.patch"},"body":"On the hope to integrate further with multiple operating systems, packager does the job!  \r\n\r\nThis solution can go slightly further and solve a growing concern, beyond OS specific JavaScript.  We have a growing need for OS VERSION specific javascript, in iOS and Windows.\r\n\r\n### Case 1: Windows 7 (Platform added in this PR)\r\nIn the React Native Windows domain, we're creating a large shared JavaScript base, but in some situations (like Vibration), this requires alternate behavior.  This PR allows Windows 10 and Windows 7 to share most `*.windows.js` files, but allow for some specific `*.windows7.js` javascript files, by adding major versioning to the `getModule` cascade.\r\n\r\n### Case 2: iOS 10\r\nThis could also help transition across difficult bridges of deprecation, as things like `RefreshControl` gets migrated to a first class citizen like it is in iOS10.  Different JS could load different native modules as beginning point for testing OS version specific solutions, or for breaking ground on other specific concerns for advanced operating systems, [discussed here](https://www.facebook.com/groups/reactnativeoss/permalink/1586734651623163/).  \r\n\r\n### Summary:\r\nThis is a proposed solution, but the need already exists in ReactNativeWindows, which is currently developing support for Windows 7.\r\n\r\ncc: @satya164  - Thoughts?\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/257068558","html_url":"https://github.com/facebook/react-native/pull/10419#issuecomment-257068558","issue_url":"https://api.github.com/repos/facebook/react-native/issues/10419","id":257068558,"user":{"login":"ide","id":379606,"avatar_url":"https://avatars.githubusercontent.com/u/379606?v=3","gravatar_id":"","url":"https://api.github.com/users/ide","html_url":"https://github.com/ide","followers_url":"https://api.github.com/users/ide/followers","following_url":"https://api.github.com/users/ide/following{/other_user}","gists_url":"https://api.github.com/users/ide/gists{/gist_id}","starred_url":"https://api.github.com/users/ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ide/subscriptions","organizations_url":"https://api.github.com/users/ide/orgs","repos_url":"https://api.github.com/users/ide/repos","events_url":"https://api.github.com/users/ide/events{/privacy}","received_events_url":"https://api.github.com/users/ide/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T03:40:31Z","updated_at":"2016-10-29T03:40:31Z","body":"@cpojer For RN the convention is to put configuration options in rn-cli.config.js, unless there's a good reason otherwise we should put new options there"}}
{"actor":{"display_login":"ide"}}