{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/comments/57434463","id":57434463,"diff_hunk":"@@ -107,15 +107,25 @@ end\n @doc \"\"\"`sys = ss2tf(s::StateSpace)`, ` sys = ss2tf(A, B, C, Ts = 0, inames = \"\", onames = \"\")`\n \n Convert a `StateSpace` realization to a `TransferFunction`\"\"\" ->\n-function ss2tf(s::StateSpace)\n-    return ss2tf(s.A, s.B, s.C, s.Ts, s.inputnames, s.outputnames)\n+function ss2tf(s::StateSpace, inames = \"\", onames = \"\")\n+    return ss2tf(s.A, s.B, s.C, s.Ts, inames, onames)\n end\n \n function ss2tf(A, B, C, Ts = 0, inames = \"\", onames = \"\")","path":"src/types/tf2ss.jl","position":10,"original_position":10,"commit_id":"22b44e14ba590987d92de2ef8ab6c8ae102a4636","original_commit_id":"22b44e14ba590987d92de2ef8ab6c8ae102a4636","user":{"login":"mfalt","id":3237193,"avatar_url":"https://avatars.githubusercontent.com/u/3237193?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalt","html_url":"https://github.com/mfalt","followers_url":"https://api.github.com/users/mfalt/followers","following_url":"https://api.github.com/users/mfalt/following{/other_user}","gists_url":"https://api.github.com/users/mfalt/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalt/subscriptions","organizations_url":"https://api.github.com/users/mfalt/orgs","repos_url":"https://api.github.com/users/mfalt/repos","events_url":"https://api.github.com/users/mfalt/events{/privacy}","received_events_url":"https://api.github.com/users/mfalt/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2016-03-25T10:35:58Z","updated_at":"2016-03-25T10:35:58Z","html_url":"https://github.com/JuliaControl/ControlSystems.jl/pull/41#discussion_r57434463","pull_request_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/comments/57434463"},"html":{"href":"https://github.com/JuliaControl/ControlSystems.jl/pull/41#discussion_r57434463"},"pull_request":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41","id":64088927,"html_url":"https://github.com/JuliaControl/ControlSystems.jl/pull/41","diff_url":"https://github.com/JuliaControl/ControlSystems.jl/pull/41.diff","patch_url":"https://github.com/JuliaControl/ControlSystems.jl/pull/41.patch","issue_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/41","number":41,"state":"open","locked":false,"title":"Kalman","user":{"login":"baggepinnen","id":3797491,"avatar_url":"https://avatars.githubusercontent.com/u/3797491?v=3","gravatar_id":"","url":"https://api.github.com/users/baggepinnen","html_url":"https://github.com/baggepinnen","followers_url":"https://api.github.com/users/baggepinnen/followers","following_url":"https://api.github.com/users/baggepinnen/following{/other_user}","gists_url":"https://api.github.com/users/baggepinnen/gists{/gist_id}","starred_url":"https://api.github.com/users/baggepinnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baggepinnen/subscriptions","organizations_url":"https://api.github.com/users/baggepinnen/orgs","repos_url":"https://api.github.com/users/baggepinnen/repos","events_url":"https://api.github.com/users/baggepinnen/events{/privacy}","received_events_url":"https://api.github.com/users/baggepinnen/received_events","type":"User","site_admin":false},"body":"This PR adds\r\n- Function kalman, similar to lqg\r\n- Numerical adjustments to charpoly\r\n- Adjustable tolerance for isapprox between transfer functions\r\n- Tests for feedback","created_at":"2016-03-24T19:50:22Z","updated_at":"2016-03-25T10:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482c3d5e2e608950fcb0ee4597e37f519e40a7ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41/commits","review_comments_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41/comments","review_comment_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/41/comments","statuses_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/statuses/22b44e14ba590987d92de2ef8ab6c8ae102a4636","head":{"label":"JuliaControl:kalman","ref":"kalman","sha":"22b44e14ba590987d92de2ef8ab6c8ae102a4636","user":{"login":"JuliaControl","id":10605979,"avatar_url":"https://avatars.githubusercontent.com/u/10605979?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaControl","html_url":"https://github.com/JuliaControl","followers_url":"https://api.github.com/users/JuliaControl/followers","following_url":"https://api.github.com/users/JuliaControl/following{/other_user}","gists_url":"https://api.github.com/users/JuliaControl/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaControl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaControl/subscriptions","organizations_url":"https://api.github.com/users/JuliaControl/orgs","repos_url":"https://api.github.com/users/JuliaControl/repos","events_url":"https://api.github.com/users/JuliaControl/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaControl/received_events","type":"Organization","site_admin":false},"repo":{"id":29503786,"name":"ControlSystems.jl","full_name":"JuliaControl/ControlSystems.jl","owner":{"login":"JuliaControl","id":10605979,"avatar_url":"https://avatars.githubusercontent.com/u/10605979?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaControl","html_url":"https://github.com/JuliaControl","followers_url":"https://api.github.com/users/JuliaControl/followers","following_url":"https://api.github.com/users/JuliaControl/following{/other_user}","gists_url":"https://api.github.com/users/JuliaControl/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaControl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaControl/subscriptions","organizations_url":"https://api.github.com/users/JuliaControl/orgs","repos_url":"https://api.github.com/users/JuliaControl/repos","events_url":"https://api.github.com/users/JuliaControl/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaControl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaControl/ControlSystems.jl","description":"A Controls Toolbox for Julia","fork":false,"url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl","forks_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/forks","keys_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/teams","hooks_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/events","assignees_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/tags","blobs_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/subscription","commits_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/merges","archive_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/downloads","issues_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/deployments","created_at":"2015-01-20T00:30:32Z","updated_at":"2016-03-24T13:54:40Z","pushed_at":"2016-03-24T19:50:22Z","git_url":"git://github.com/JuliaControl/ControlSystems.jl.git","ssh_url":"git@github.com:JuliaControl/ControlSystems.jl.git","clone_url":"https://github.com/JuliaControl/ControlSystems.jl.git","svn_url":"https://github.com/JuliaControl/ControlSystems.jl","homepage":null,"size":946,"stargazers_count":19,"watchers_count":19,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":22,"forks":7,"open_issues":22,"watchers":19,"default_branch":"master"}},"base":{"label":"JuliaControl:master","ref":"master","sha":"2cd9190f1d2a503ffa823f748b20eb4c97d018e9","user":{"login":"JuliaControl","id":10605979,"avatar_url":"https://avatars.githubusercontent.com/u/10605979?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaControl","html_url":"https://github.com/JuliaControl","followers_url":"https://api.github.com/users/JuliaControl/followers","following_url":"https://api.github.com/users/JuliaControl/following{/other_user}","gists_url":"https://api.github.com/users/JuliaControl/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaControl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaControl/subscriptions","organizations_url":"https://api.github.com/users/JuliaControl/orgs","repos_url":"https://api.github.com/users/JuliaControl/repos","events_url":"https://api.github.com/users/JuliaControl/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaControl/received_events","type":"Organization","site_admin":false},"repo":{"id":29503786,"name":"ControlSystems.jl","full_name":"JuliaControl/ControlSystems.jl","owner":{"login":"JuliaControl","id":10605979,"avatar_url":"https://avatars.githubusercontent.com/u/10605979?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaControl","html_url":"https://github.com/JuliaControl","followers_url":"https://api.github.com/users/JuliaControl/followers","following_url":"https://api.github.com/users/JuliaControl/following{/other_user}","gists_url":"https://api.github.com/users/JuliaControl/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaControl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaControl/subscriptions","organizations_url":"https://api.github.com/users/JuliaControl/orgs","repos_url":"https://api.github.com/users/JuliaControl/repos","events_url":"https://api.github.com/users/JuliaControl/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaControl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaControl/ControlSystems.jl","description":"A Controls Toolbox for Julia","fork":false,"url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl","forks_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/forks","keys_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/teams","hooks_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/events","assignees_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/tags","blobs_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/subscription","commits_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/merges","archive_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/downloads","issues_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/deployments","created_at":"2015-01-20T00:30:32Z","updated_at":"2016-03-24T13:54:40Z","pushed_at":"2016-03-24T19:50:22Z","git_url":"git://github.com/JuliaControl/ControlSystems.jl.git","ssh_url":"git@github.com:JuliaControl/ControlSystems.jl.git","clone_url":"https://github.com/JuliaControl/ControlSystems.jl.git","svn_url":"https://github.com/JuliaControl/ControlSystems.jl","homepage":null,"size":946,"stargazers_count":19,"watchers_count":19,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":22,"forks":7,"open_issues":22,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41"},"html":{"href":"https://github.com/JuliaControl/ControlSystems.jl/pull/41"},"issue":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/41"},"comments":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaControl/ControlSystems.jl/statuses/22b44e14ba590987d92de2ef8ab6c8ae102a4636"}}}}