{"action":"created","comment":{"url":"https://api.github.com/repos/crate/elasticsearch/pulls/comments/71848318","id":71848318,"diff_hunk":"@@ -19,82 +19,91 @@\n \n package org.elasticsearch.cloud.azure.management;\n \n+import com.microsoft.aad.adal4j.AuthenticationResult;\n+import com.microsoft.azure.management.compute.ComputeManagementClient;\n+import com.microsoft.azure.management.compute.ComputeManagementService;\n+import com.microsoft.azure.utility.AuthHelper;\n import com.microsoft.windowsazure.Configuration;\n-import com.microsoft.windowsazure.core.utils.KeyStoreType;\n-import com.microsoft.windowsazure.management.compute.ComputeManagementClient;\n-import com.microsoft.windowsazure.management.compute.ComputeManagementService;\n-import com.microsoft.windowsazure.management.compute.models.HostedServiceGetDetailedResponse;\n import com.microsoft.windowsazure.management.configuration.ManagementConfiguration;\n import org.elasticsearch.ElasticsearchException;\n-import org.elasticsearch.cloud.azure.AzureServiceDisableException;\n-import org.elasticsearch.cloud.azure.AzureServiceRemoteException;\n+import org.elasticsearch.cloud.azure.AzureModule;\n import org.elasticsearch.common.component.AbstractLifecycleComponent;\n import org.elasticsearch.common.inject.Inject;\n import org.elasticsearch.common.settings.Settings;\n+import org.elasticsearch.plugins.Plugin;\n \n import java.io.IOException;\n import java.net.URI;\n-import java.net.URISyntaxException;\n \n import static org.elasticsearch.cloud.azure.management.AzureComputeService.Management.*;\n \n-/**\n- *\n- */\n public class AzureComputeServiceImpl extends AbstractLifecycleComponent<AzureComputeServiceImpl>\n-    implements AzureComputeService {\n+        implements AzureComputeService {\n+\n+    public static class TestPlugin extends Plugin {","path":"plugins/cloud-azure/src/main/java/org/elasticsearch/cloud/azure/management/AzureComputeServiceImpl.java","position":36,"original_position":36,"commit_id":"0b61ab421d633c77fed890d259a10dd25f760c73","original_commit_id":"0b61ab421d633c77fed890d259a10dd25f760c73","user":{"login":"mfussenegger","id":38700,"avatar_url":"https://avatars.githubusercontent.com/u/38700?v=3","gravatar_id":"","url":"https://api.github.com/users/mfussenegger","html_url":"https://github.com/mfussenegger","followers_url":"https://api.github.com/users/mfussenegger/followers","following_url":"https://api.github.com/users/mfussenegger/following{/other_user}","gists_url":"https://api.github.com/users/mfussenegger/gists{/gist_id}","starred_url":"https://api.github.com/users/mfussenegger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfussenegger/subscriptions","organizations_url":"https://api.github.com/users/mfussenegger/orgs","repos_url":"https://api.github.com/users/mfussenegger/repos","events_url":"https://api.github.com/users/mfussenegger/events{/privacy}","received_events_url":"https://api.github.com/users/mfussenegger/received_events","type":"User","site_admin":false},"body":"TestPlugin inside non-test code?","created_at":"2016-07-22T09:03:35Z","updated_at":"2016-07-22T09:03:35Z","html_url":"https://github.com/crate/elasticsearch/pull/87#discussion_r71848318","pull_request_url":"https://api.github.com/repos/crate/elasticsearch/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/crate/elasticsearch/pulls/comments/71848318"},"html":{"href":"https://github.com/crate/elasticsearch/pull/87#discussion_r71848318"},"pull_request":{"href":"https://api.github.com/repos/crate/elasticsearch/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/crate/elasticsearch/pulls/87","id":78322825,"html_url":"https://github.com/crate/elasticsearch/pull/87","diff_url":"https://github.com/crate/elasticsearch/pull/87.diff","patch_url":"https://github.com/crate/elasticsearch/pull/87.patch","issue_url":"https://api.github.com/repos/crate/elasticsearch/issues/87","number":87,"state":"open","locked":false,"title":"Cloud azure plugin","user":{"login":"bogensberger","id":1038966,"avatar_url":"https://avatars.githubusercontent.com/u/1038966?v=3","gravatar_id":"","url":"https://api.github.com/users/bogensberger","html_url":"https://github.com/bogensberger","followers_url":"https://api.github.com/users/bogensberger/followers","following_url":"https://api.github.com/users/bogensberger/following{/other_user}","gists_url":"https://api.github.com/users/bogensberger/gists{/gist_id}","starred_url":"https://api.github.com/users/bogensberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogensberger/subscriptions","organizations_url":"https://api.github.com/users/bogensberger/orgs","repos_url":"https://api.github.com/users/bogensberger/repos","events_url":"https://api.github.com/users/bogensberger/events{/privacy}","received_events_url":"https://api.github.com/users/bogensberger/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-21T14:12:11Z","updated_at":"2016-07-22T09:03:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d65bd8c1827d05da5943f783c080ea30218f82d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crate/elasticsearch/pulls/87/commits","review_comments_url":"https://api.github.com/repos/crate/elasticsearch/pulls/87/comments","review_comment_url":"https://api.github.com/repos/crate/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crate/elasticsearch/issues/87/comments","statuses_url":"https://api.github.com/repos/crate/elasticsearch/statuses/0b61ab421d633c77fed890d259a10dd25f760c73","head":{"label":"crate:cloud-azure-plugin","ref":"cloud-azure-plugin","sha":"0b61ab421d633c77fed890d259a10dd25f760c73","user":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":16169064,"name":"elasticsearch","full_name":"crate/elasticsearch","owner":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/crate/elasticsearch","forks_url":"https://api.github.com/repos/crate/elasticsearch/forks","keys_url":"https://api.github.com/repos/crate/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/elasticsearch/teams","hooks_url":"https://api.github.com/repos/crate/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/crate/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/crate/elasticsearch/events","assignees_url":"https://api.github.com/repos/crate/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/crate/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/crate/elasticsearch/tags","blobs_url":"https://api.github.com/repos/crate/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/crate/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/crate/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/crate/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/crate/elasticsearch/subscription","commits_url":"https://api.github.com/repos/crate/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/crate/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/elasticsearch/merges","archive_url":"https://api.github.com/repos/crate/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/elasticsearch/downloads","issues_url":"https://api.github.com/repos/crate/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/crate/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/crate/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/crate/elasticsearch/deployments","created_at":"2014-01-23T10:16:56Z","updated_at":"2015-05-04T08:22:11Z","pushed_at":"2016-07-22T08:51:21Z","git_url":"git://github.com/crate/elasticsearch.git","ssh_url":"git@github.com:crate/elasticsearch.git","clone_url":"https://github.com/crate/elasticsearch.git","svn_url":"https://github.com/crate/elasticsearch","homepage":"http://elasticsearch.org","size":233605,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"crate:2.3_cherry","ref":"2.3_cherry","sha":"4e547cb7fa176eeb9710d021fbbc13321f8d0b72","user":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"repo":{"id":16169064,"name":"elasticsearch","full_name":"crate/elasticsearch","owner":{"login":"crate","id":4048232,"avatar_url":"https://avatars.githubusercontent.com/u/4048232?v=3","gravatar_id":"","url":"https://api.github.com/users/crate","html_url":"https://github.com/crate","followers_url":"https://api.github.com/users/crate/followers","following_url":"https://api.github.com/users/crate/following{/other_user}","gists_url":"https://api.github.com/users/crate/gists{/gist_id}","starred_url":"https://api.github.com/users/crate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crate/subscriptions","organizations_url":"https://api.github.com/users/crate/orgs","repos_url":"https://api.github.com/users/crate/repos","events_url":"https://api.github.com/users/crate/events{/privacy}","received_events_url":"https://api.github.com/users/crate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crate/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/crate/elasticsearch","forks_url":"https://api.github.com/repos/crate/elasticsearch/forks","keys_url":"https://api.github.com/repos/crate/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crate/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crate/elasticsearch/teams","hooks_url":"https://api.github.com/repos/crate/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/crate/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/crate/elasticsearch/events","assignees_url":"https://api.github.com/repos/crate/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/crate/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/crate/elasticsearch/tags","blobs_url":"https://api.github.com/repos/crate/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crate/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crate/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/crate/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crate/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/crate/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/crate/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/crate/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/crate/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/crate/elasticsearch/subscription","commits_url":"https://api.github.com/repos/crate/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/crate/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/crate/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/crate/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/crate/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/crate/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crate/elasticsearch/merges","archive_url":"https://api.github.com/repos/crate/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crate/elasticsearch/downloads","issues_url":"https://api.github.com/repos/crate/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/crate/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/crate/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/crate/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crate/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/crate/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/crate/elasticsearch/deployments","created_at":"2014-01-23T10:16:56Z","updated_at":"2015-05-04T08:22:11Z","pushed_at":"2016-07-22T08:51:21Z","git_url":"git://github.com/crate/elasticsearch.git","ssh_url":"git@github.com:crate/elasticsearch.git","clone_url":"https://github.com/crate/elasticsearch.git","svn_url":"https://github.com/crate/elasticsearch","homepage":"http://elasticsearch.org","size":233605,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crate/elasticsearch/pulls/87"},"html":{"href":"https://github.com/crate/elasticsearch/pull/87"},"issue":{"href":"https://api.github.com/repos/crate/elasticsearch/issues/87"},"comments":{"href":"https://api.github.com/repos/crate/elasticsearch/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/crate/elasticsearch/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/crate/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crate/elasticsearch/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/crate/elasticsearch/statuses/0b61ab421d633c77fed890d259a10dd25f760c73"}}}}
{"actor":{"display_login":"mfussenegger"}}