{"action":"created","issue":{"url":"https://api.github.com/repos/fenos/Notifynder/issues/72","repository_url":"https://api.github.com/repos/fenos/Notifynder","labels_url":"https://api.github.com/repos/fenos/Notifynder/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/fenos/Notifynder/issues/72/comments","events_url":"https://api.github.com/repos/fenos/Notifynder/issues/72/events","html_url":"https://github.com/fenos/Notifynder/pull/72","id":125517105,"number":72,"title":"Remove custom translator and use laravel's translation functionalities","user":{"login":"okaufmann","id":4414498,"avatar_url":"https://avatars.githubusercontent.com/u/4414498?v=3","gravatar_id":"","url":"https://api.github.com/users/okaufmann","html_url":"https://github.com/okaufmann","followers_url":"https://api.github.com/users/okaufmann/followers","following_url":"https://api.github.com/users/okaufmann/following{/other_user}","gists_url":"https://api.github.com/users/okaufmann/gists{/gist_id}","starred_url":"https://api.github.com/users/okaufmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okaufmann/subscriptions","organizations_url":"https://api.github.com/users/okaufmann/orgs","repos_url":"https://api.github.com/users/okaufmann/repos","events_url":"https://api.github.com/users/okaufmann/events{/privacy}","received_events_url":"https://api.github.com/users/okaufmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-01-08T00:39:08Z","updated_at":"2016-04-22T12:31:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fenos/Notifynder/pulls/72","html_url":"https://github.com/fenos/Notifynder/pull/72","diff_url":"https://github.com/fenos/Notifynder/pull/72.diff","patch_url":"https://github.com/fenos/Notifynder/pull/72.patch"},"body":"I think its better to use laravels build in translation tools.\r\n\r\nWith this PR it is possible to add a new file per language in `resources/lang/{lang}/notifynder.php`. Further its possible to toggle translation in config files with the key `translate.enabled`.\r\n\r\nHope this is useful for you too."},"comment":{"url":"https://api.github.com/repos/fenos/Notifynder/issues/comments/213405533","html_url":"https://github.com/fenos/Notifynder/pull/72#issuecomment-213405533","issue_url":"https://api.github.com/repos/fenos/Notifynder/issues/72","id":213405533,"user":{"login":"Gummibeer","id":6187884,"avatar_url":"https://avatars.githubusercontent.com/u/6187884?v=3","gravatar_id":"","url":"https://api.github.com/users/Gummibeer","html_url":"https://github.com/Gummibeer","followers_url":"https://api.github.com/users/Gummibeer/followers","following_url":"https://api.github.com/users/Gummibeer/following{/other_user}","gists_url":"https://api.github.com/users/Gummibeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Gummibeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gummibeer/subscriptions","organizations_url":"https://api.github.com/users/Gummibeer/orgs","repos_url":"https://api.github.com/users/Gummibeer/repos","events_url":"https://api.github.com/users/Gummibeer/events{/privacy}","received_events_url":"https://api.github.com/users/Gummibeer/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T12:31:24Z","updated_at":"2016-04-22T12:31:24Z","body":"@okaufmann hey, can you pls merge the master branch here and check if everything is working!? If yes push it and if it passes all tests I will merge it.\r\n\r\n*For the breaking changes:*\r\n* the most breaking change would be the config!? Will it be possible/needed to write an artisan command that transfers the old config translations to the new laravel translation files?\r\n* you have removed some public methods - so there are breaking changes in old method calls!?"}}