{"action":"created","comment":{"url":"https://api.github.com/repos/apache/reef/pulls/comments/61005733","id":61005733,"diff_hunk":"@@ -54,26 +56,73 @@ internal sealed class FileSystemInputPartition<T> : IInputPartition<T>, IDisposa\n             _id = id;\n             _fileSystem = fileSystem;\n             _fileSerializer = fileSerializer;\n-            _filePaths = filePaths;\n             _tempFileCreator = tempFileCreator;\n-            _isInitialized = false;\n-            _copyToLocal = copyToLocal;\n+            _filePaths = filePaths;\n+\n+            if (!copyToLocal)\n+            {\n+                // Implies that the files are already local.","path":"lang/cs/Org.Apache.REEF.IO/PartitionedData/FileSystem/FileSystemInputPartition.cs","position":44,"original_position":44,"commit_id":"cbd5d3f1e9be9c62ef1e8fa0f0204f45d0274bc7","original_commit_id":"cbd5d3f1e9be9c62ef1e8fa0f0204f45d0274bc7","user":{"login":"jwang98052","id":5666504,"avatar_url":"https://avatars.githubusercontent.com/u/5666504?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang98052","html_url":"https://github.com/jwang98052","followers_url":"https://api.github.com/users/jwang98052/followers","following_url":"https://api.github.com/users/jwang98052/following{/other_user}","gists_url":"https://api.github.com/users/jwang98052/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang98052/subscriptions","organizations_url":"https://api.github.com/users/jwang98052/orgs","repos_url":"https://api.github.com/users/jwang98052/repos","events_url":"https://api.github.com/users/jwang98052/events{/privacy}","received_events_url":"https://api.github.com/users/jwang98052/received_events","type":"User","site_admin":false},"body":"In original code, files are provided in _filePaths, usually remote files. \r\n\r\nIf the user what to download files to local first, and if the files are not downloaded yet, then download (Initialize()), then Deserialize from the local downloaded files. \r\n\r\nElse, meaning if user doesn't choose to copyToLocal, then Deserialize from the original files directly.  ","created_at":"2016-04-25T23:09:40Z","updated_at":"2016-04-25T23:09:40Z","html_url":"https://github.com/apache/reef/pull/968#discussion_r61005733","pull_request_url":"https://api.github.com/repos/apache/reef/pulls/968","_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/comments/61005733"},"html":{"href":"https://github.com/apache/reef/pull/968#discussion_r61005733"},"pull_request":{"href":"https://api.github.com/repos/apache/reef/pulls/968"}}},"pull_request":{"url":"https://api.github.com/repos/apache/reef/pulls/968","id":67785637,"html_url":"https://github.com/apache/reef/pull/968","diff_url":"https://github.com/apache/reef/pull/968.diff","patch_url":"https://github.com/apache/reef/pull/968.patch","issue_url":"https://api.github.com/repos/apache/reef/issues/968","number":968,"state":"open","locked":false,"title":"[REEF-1339] Adding IInputPartition.Cache() for data download and cache","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"body":"This addressed the issue by\r\n  * Adding an unstable Cache function.\r\n  * Modify existing implementations of IInputPartition to allow them to cache only on invocation of Cache instead of on initialization.\r\n\r\nJIRA:\r\n  [REEF-1339](https://issues.apache.org/jira/browse/REEF-1339)","created_at":"2016-04-25T20:48:27Z","updated_at":"2016-04-25T23:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c066f8ab9e7300dd2cd700bb2bdd82c130e662","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/reef/pulls/968/commits","review_comments_url":"https://api.github.com/repos/apache/reef/pulls/968/comments","review_comment_url":"https://api.github.com/repos/apache/reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/reef/issues/968/comments","statuses_url":"https://api.github.com/repos/apache/reef/statuses/cbd5d3f1e9be9c62ef1e8fa0f0204f45d0274bc7","head":{"label":"afchung:REEF-1339","ref":"REEF-1339","sha":"cbd5d3f1e9be9c62ef1e8fa0f0204f45d0274bc7","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"repo":{"id":31485914,"name":"reef","full_name":"afchung/reef","owner":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afchung/reef","description":"Mirror of Apache REEF","fork":true,"url":"https://api.github.com/repos/afchung/reef","forks_url":"https://api.github.com/repos/afchung/reef/forks","keys_url":"https://api.github.com/repos/afchung/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afchung/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afchung/reef/teams","hooks_url":"https://api.github.com/repos/afchung/reef/hooks","issue_events_url":"https://api.github.com/repos/afchung/reef/issues/events{/number}","events_url":"https://api.github.com/repos/afchung/reef/events","assignees_url":"https://api.github.com/repos/afchung/reef/assignees{/user}","branches_url":"https://api.github.com/repos/afchung/reef/branches{/branch}","tags_url":"https://api.github.com/repos/afchung/reef/tags","blobs_url":"https://api.github.com/repos/afchung/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afchung/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afchung/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/afchung/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afchung/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/afchung/reef/languages","stargazers_url":"https://api.github.com/repos/afchung/reef/stargazers","contributors_url":"https://api.github.com/repos/afchung/reef/contributors","subscribers_url":"https://api.github.com/repos/afchung/reef/subscribers","subscription_url":"https://api.github.com/repos/afchung/reef/subscription","commits_url":"https://api.github.com/repos/afchung/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/afchung/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/afchung/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/afchung/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/afchung/reef/contents/{+path}","compare_url":"https://api.github.com/repos/afchung/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afchung/reef/merges","archive_url":"https://api.github.com/repos/afchung/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afchung/reef/downloads","issues_url":"https://api.github.com/repos/afchung/reef/issues{/number}","pulls_url":"https://api.github.com/repos/afchung/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/afchung/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/afchung/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afchung/reef/labels{/name}","releases_url":"https://api.github.com/repos/afchung/reef/releases{/id}","deployments_url":"https://api.github.com/repos/afchung/reef/deployments","created_at":"2015-03-01T03:44:31Z","updated_at":"2016-01-13T15:51:07Z","pushed_at":"2016-04-25T20:48:16Z","git_url":"git://github.com/afchung/reef.git","ssh_url":"git@github.com:afchung/reef.git","clone_url":"https://github.com/afchung/reef.git","svn_url":"https://github.com/afchung/reef","homepage":"","size":35154,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ffa976a70643641608405e2e221d5cf7b0d02388","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"reef","full_name":"apache/reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/reef","description":"Mirror of Apache REEF","fork":false,"url":"https://api.github.com/repos/apache/reef","forks_url":"https://api.github.com/repos/apache/reef/forks","keys_url":"https://api.github.com/repos/apache/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/reef/teams","hooks_url":"https://api.github.com/repos/apache/reef/hooks","issue_events_url":"https://api.github.com/repos/apache/reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/reef/events","assignees_url":"https://api.github.com/repos/apache/reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/reef/tags","blobs_url":"https://api.github.com/repos/apache/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/reef/languages","stargazers_url":"https://api.github.com/repos/apache/reef/stargazers","contributors_url":"https://api.github.com/repos/apache/reef/contributors","subscribers_url":"https://api.github.com/repos/apache/reef/subscribers","subscription_url":"https://api.github.com/repos/apache/reef/subscription","commits_url":"https://api.github.com/repos/apache/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/reef/merges","archive_url":"https://api.github.com/repos/apache/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/reef/downloads","issues_url":"https://api.github.com/repos/apache/reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/reef/releases{/id}","deployments_url":"https://api.github.com/repos/apache/reef/deployments","created_at":"2014-10-23T07:00:10Z","updated_at":"2016-04-23T12:24:09Z","pushed_at":"2016-04-25T22:18:51Z","git_url":"git://github.com/apache/reef.git","ssh_url":"git@github.com:apache/reef.git","clone_url":"https://github.com/apache/reef.git","svn_url":"https://github.com/apache/reef","homepage":"","size":47821,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":"git://git.apache.org/reef.git","open_issues_count":5,"forks":55,"open_issues":5,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/968"},"html":{"href":"https://github.com/apache/reef/pull/968"},"issue":{"href":"https://api.github.com/repos/apache/reef/issues/968"},"comments":{"href":"https://api.github.com/repos/apache/reef/issues/968/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/reef/pulls/968/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/reef/pulls/968/commits"},"statuses":{"href":"https://api.github.com/repos/apache/reef/statuses/cbd5d3f1e9be9c62ef1e8fa0f0204f45d0274bc7"}}}}