{"action":"created","comment":{"url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments/92579597","pull_request_review_id":13097009,"id":92579597,"diff_hunk":"@@ -219,9 +229,22 @@ PrimitiveRenderer.prototype.addPrimitive = function(attributes) {\n     throw new GlError(\"Wrong number of attributes given\");\n   if (this.count == this.capacity) {\n     let c = this.capacity*2, nd, nda, ndi, i, j, k, o, e = this.elements;\n+    if (c > this.maxCount) {\n+      if (this.capacity < this.maxCount) {\n+        c = this.maxCount;\n+      } else {\n+        this.indexByteCount = 4;\n+        this.itemTotalByteCount = this.itemAttribByteCount +\n+          this.numElements * this.indexByteCount;\n+        this.maxCount = Math.floor((1 << 31) / this.itemAttribByteCount);","path":"plugins/cindy3d/src/js/PrimitiveRenderer.js","position":66,"original_position":66,"commit_id":"3835f13c2160bbcffc1bcde9ededebf6dc23a386","original_commit_id":"3835f13c2160bbcffc1bcde9ededebf6dc23a386","user":{"login":"montaga","id":15124152,"avatar_url":"https://avatars.githubusercontent.com/u/15124152?v=3","gravatar_id":"","url":"https://api.github.com/users/montaga","html_url":"https://github.com/montaga","followers_url":"https://api.github.com/users/montaga/followers","following_url":"https://api.github.com/users/montaga/following{/other_user}","gists_url":"https://api.github.com/users/montaga/gists{/gist_id}","starred_url":"https://api.github.com/users/montaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montaga/subscriptions","organizations_url":"https://api.github.com/users/montaga/orgs","repos_url":"https://api.github.com/users/montaga/repos","events_url":"https://api.github.com/users/montaga/events{/privacy}","received_events_url":"https://api.github.com/users/montaga/received_events","type":"User","site_admin":false},"body":"Actually, we would like to have `2^32` here. With the division we will use doubles anyway.\r\nSo we could simply use `Math.pow(2,32)`, or if you like bit-shifts `2*((-1^(1<<31))+1)` ;-)\r\n","created_at":"2016-12-15T10:14:27Z","updated_at":"2016-12-15T10:14:27Z","html_url":"https://github.com/CindyJS/CindyJS/pull/553#discussion_r92579597","pull_request_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553","_links":{"self":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments/92579597"},"html":{"href":"https://github.com/CindyJS/CindyJS/pull/553#discussion_r92579597"},"pull_request":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553"}}},"pull_request":{"url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553","id":97978467,"html_url":"https://github.com/CindyJS/CindyJS/pull/553","diff_url":"https://github.com/CindyJS/CindyJS/pull/553.diff","patch_url":"https://github.com/CindyJS/CindyJS/pull/553.patch","issue_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/553","number":553,"state":"open","locked":false,"title":"Draw larger number of primitives using uint indexing","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"body":"This requires the OES_element_index_uint extension.  If that is not available, nothing will be drawn at all since the drawElements call is invalid in that case.  So this is a partial solution to #552.","created_at":"2016-12-14T15:49:35Z","updated_at":"2016-12-15T10:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88e7343b3b40000d5fb18593be1041a239260771","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553/commits","review_comments_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553/comments","review_comment_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/553/comments","statuses_url":"https://api.github.com/repos/CindyJS/CindyJS/statuses/3835f13c2160bbcffc1bcde9ededebf6dc23a386","head":{"label":"gagern:uintIndices","ref":"uintIndices","sha":"3835f13c2160bbcffc1bcde9ededebf6dc23a386","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"repo":{"id":42124777,"name":"CindyJS","full_name":"gagern/CindyJS","owner":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gagern/CindyJS","description":"A JavaScript framework for interactive (mathematical) content","fork":true,"url":"https://api.github.com/repos/gagern/CindyJS","forks_url":"https://api.github.com/repos/gagern/CindyJS/forks","keys_url":"https://api.github.com/repos/gagern/CindyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gagern/CindyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gagern/CindyJS/teams","hooks_url":"https://api.github.com/repos/gagern/CindyJS/hooks","issue_events_url":"https://api.github.com/repos/gagern/CindyJS/issues/events{/number}","events_url":"https://api.github.com/repos/gagern/CindyJS/events","assignees_url":"https://api.github.com/repos/gagern/CindyJS/assignees{/user}","branches_url":"https://api.github.com/repos/gagern/CindyJS/branches{/branch}","tags_url":"https://api.github.com/repos/gagern/CindyJS/tags","blobs_url":"https://api.github.com/repos/gagern/CindyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gagern/CindyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gagern/CindyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/gagern/CindyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gagern/CindyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/gagern/CindyJS/languages","stargazers_url":"https://api.github.com/repos/gagern/CindyJS/stargazers","contributors_url":"https://api.github.com/repos/gagern/CindyJS/contributors","subscribers_url":"https://api.github.com/repos/gagern/CindyJS/subscribers","subscription_url":"https://api.github.com/repos/gagern/CindyJS/subscription","commits_url":"https://api.github.com/repos/gagern/CindyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/gagern/CindyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/gagern/CindyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/gagern/CindyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/gagern/CindyJS/contents/{+path}","compare_url":"https://api.github.com/repos/gagern/CindyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gagern/CindyJS/merges","archive_url":"https://api.github.com/repos/gagern/CindyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gagern/CindyJS/downloads","issues_url":"https://api.github.com/repos/gagern/CindyJS/issues{/number}","pulls_url":"https://api.github.com/repos/gagern/CindyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/gagern/CindyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/gagern/CindyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gagern/CindyJS/labels{/name}","releases_url":"https://api.github.com/repos/gagern/CindyJS/releases{/id}","deployments_url":"https://api.github.com/repos/gagern/CindyJS/deployments","created_at":"2015-09-08T16:29:07Z","updated_at":"2016-10-22T04:57:36Z","pushed_at":"2016-12-14T15:48:41Z","git_url":"git://github.com/gagern/CindyJS.git","ssh_url":"git@github.com:gagern/CindyJS.git","clone_url":"https://github.com/gagern/CindyJS.git","svn_url":"https://github.com/gagern/CindyJS","homepage":"http://cindyjs.org/","size":14562,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CindyJS:master","ref":"master","sha":"4033f65c823ae7d4a677e3c18661f829a186c706","user":{"login":"CindyJS","id":14181218,"avatar_url":"https://avatars.githubusercontent.com/u/14181218?v=3","gravatar_id":"","url":"https://api.github.com/users/CindyJS","html_url":"https://github.com/CindyJS","followers_url":"https://api.github.com/users/CindyJS/followers","following_url":"https://api.github.com/users/CindyJS/following{/other_user}","gists_url":"https://api.github.com/users/CindyJS/gists{/gist_id}","starred_url":"https://api.github.com/users/CindyJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CindyJS/subscriptions","organizations_url":"https://api.github.com/users/CindyJS/orgs","repos_url":"https://api.github.com/users/CindyJS/repos","events_url":"https://api.github.com/users/CindyJS/events{/privacy}","received_events_url":"https://api.github.com/users/CindyJS/received_events","type":"Organization","site_admin":false},"repo":{"id":42122684,"name":"CindyJS","full_name":"CindyJS/CindyJS","owner":{"login":"CindyJS","id":14181218,"avatar_url":"https://avatars.githubusercontent.com/u/14181218?v=3","gravatar_id":"","url":"https://api.github.com/users/CindyJS","html_url":"https://github.com/CindyJS","followers_url":"https://api.github.com/users/CindyJS/followers","following_url":"https://api.github.com/users/CindyJS/following{/other_user}","gists_url":"https://api.github.com/users/CindyJS/gists{/gist_id}","starred_url":"https://api.github.com/users/CindyJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CindyJS/subscriptions","organizations_url":"https://api.github.com/users/CindyJS/orgs","repos_url":"https://api.github.com/users/CindyJS/repos","events_url":"https://api.github.com/users/CindyJS/events{/privacy}","received_events_url":"https://api.github.com/users/CindyJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CindyJS/CindyJS","description":"A JavaScript framework for interactive (mathematical) content","fork":false,"url":"https://api.github.com/repos/CindyJS/CindyJS","forks_url":"https://api.github.com/repos/CindyJS/CindyJS/forks","keys_url":"https://api.github.com/repos/CindyJS/CindyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CindyJS/CindyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CindyJS/CindyJS/teams","hooks_url":"https://api.github.com/repos/CindyJS/CindyJS/hooks","issue_events_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/events{/number}","events_url":"https://api.github.com/repos/CindyJS/CindyJS/events","assignees_url":"https://api.github.com/repos/CindyJS/CindyJS/assignees{/user}","branches_url":"https://api.github.com/repos/CindyJS/CindyJS/branches{/branch}","tags_url":"https://api.github.com/repos/CindyJS/CindyJS/tags","blobs_url":"https://api.github.com/repos/CindyJS/CindyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CindyJS/CindyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CindyJS/CindyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/CindyJS/CindyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CindyJS/CindyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/CindyJS/CindyJS/languages","stargazers_url":"https://api.github.com/repos/CindyJS/CindyJS/stargazers","contributors_url":"https://api.github.com/repos/CindyJS/CindyJS/contributors","subscribers_url":"https://api.github.com/repos/CindyJS/CindyJS/subscribers","subscription_url":"https://api.github.com/repos/CindyJS/CindyJS/subscription","commits_url":"https://api.github.com/repos/CindyJS/CindyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/CindyJS/CindyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/CindyJS/CindyJS/contents/{+path}","compare_url":"https://api.github.com/repos/CindyJS/CindyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CindyJS/CindyJS/merges","archive_url":"https://api.github.com/repos/CindyJS/CindyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CindyJS/CindyJS/downloads","issues_url":"https://api.github.com/repos/CindyJS/CindyJS/issues{/number}","pulls_url":"https://api.github.com/repos/CindyJS/CindyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/CindyJS/CindyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/CindyJS/CindyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/labels{/name}","releases_url":"https://api.github.com/repos/CindyJS/CindyJS/releases{/id}","deployments_url":"https://api.github.com/repos/CindyJS/CindyJS/deployments","created_at":"2015-09-08T15:51:32Z","updated_at":"2016-12-14T09:27:55Z","pushed_at":"2016-12-14T18:29:34Z","git_url":"git://github.com/CindyJS/CindyJS.git","ssh_url":"git@github.com:CindyJS/CindyJS.git","clone_url":"https://github.com/CindyJS/CindyJS.git","svn_url":"https://github.com/CindyJS/CindyJS","homepage":"https://cindyjs.org/","size":13561,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":114,"forks":14,"open_issues":114,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553"},"html":{"href":"https://github.com/CindyJS/CindyJS/pull/553"},"issue":{"href":"https://api.github.com/repos/CindyJS/CindyJS/issues/553"},"comments":{"href":"https://api.github.com/repos/CindyJS/CindyJS/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CindyJS/CindyJS/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/CindyJS/CindyJS/statuses/3835f13c2160bbcffc1bcde9ededebf6dc23a386"}}}}
{"actor":{"display_login":"montaga"}}