{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/60572339","id":60572339,"diff_hunk":"@@ -110,7 +110,7 @@ struct Land\n         static void transposeTextureData(const uint16_t *in, uint16_t *out);\n     };\n \n-    void load(ESMReader &esm, bool &isDeleted);\n+    virtual void load(ESMReader &esm, bool &isDeleted);","path":"components/esm/loadland.hpp","position":5,"original_position":5,"commit_id":"eb41f3e4b74dcb7277afd2bcb250741022d3f300","original_commit_id":"eb41f3e4b74dcb7277afd2bcb250741022d3f300","user":{"login":"Pi03k","id":1756537,"avatar_url":"https://avatars.githubusercontent.com/u/1756537?v=3","gravatar_id":"","url":"https://api.github.com/users/Pi03k","html_url":"https://github.com/Pi03k","followers_url":"https://api.github.com/users/Pi03k/followers","following_url":"https://api.github.com/users/Pi03k/following{/other_user}","gists_url":"https://api.github.com/users/Pi03k/gists{/gist_id}","starred_url":"https://api.github.com/users/Pi03k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pi03k/subscriptions","organizations_url":"https://api.github.com/users/Pi03k/orgs","repos_url":"https://api.github.com/users/Pi03k/repos","events_url":"https://api.github.com/users/Pi03k/events{/privacy}","received_events_url":"https://api.github.com/users/Pi03k/received_events","type":"User","site_admin":false},"body":"apps/opencs/model/world/land.hpp line 18 has this exact method in derived class. Without virtual this method would be shadowed. Adding virtual will allow for dynamic dispatch / polymorphism / method overriding. Right?","created_at":"2016-04-21T12:40:56Z","updated_at":"2016-04-21T12:40:56Z","html_url":"https://github.com/OpenMW/openmw/pull/929#discussion_r60572339","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/929","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/60572339"},"html":{"href":"https://github.com/OpenMW/openmw/pull/929#discussion_r60572339"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/929"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/929","id":67038736,"html_url":"https://github.com/OpenMW/openmw/pull/929","diff_url":"https://github.com/OpenMW/openmw/pull/929.diff","patch_url":"https://github.com/OpenMW/openmw/pull/929.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/929","number":929,"state":"open","locked":false,"title":"Feature 936","user":{"login":"Pi03k","id":1756537,"avatar_url":"https://avatars.githubusercontent.com/u/1756537?v=3","gravatar_id":"","url":"https://api.github.com/users/Pi03k","html_url":"https://github.com/Pi03k","followers_url":"https://api.github.com/users/Pi03k/followers","following_url":"https://api.github.com/users/Pi03k/following{/other_user}","gists_url":"https://api.github.com/users/Pi03k/gists{/gist_id}","starred_url":"https://api.github.com/users/Pi03k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pi03k/subscriptions","organizations_url":"https://api.github.com/users/Pi03k/orgs","repos_url":"https://api.github.com/users/Pi03k/repos","events_url":"https://api.github.com/users/Pi03k/events{/privacy}","received_events_url":"https://api.github.com/users/Pi03k/received_events","type":"User","site_admin":false},"body":"https://bugs.openmw.org/issues/936\r\n![land_table_ft_936](https://cloud.githubusercontent.com/assets/1756537/14644804/a5ecd952-0653-11e6-9312-773148fdee90.png)\r\n","created_at":"2016-04-19T15:25:49Z","updated_at":"2016-04-21T12:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc65a6c5e19d95de67cf1dd189ebf749b7c4ec08","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/929/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/929/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/929/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/eb41f3e4b74dcb7277afd2bcb250741022d3f300","head":{"label":"Pi03k:feature_936","ref":"feature_936","sha":"eb41f3e4b74dcb7277afd2bcb250741022d3f300","user":{"login":"Pi03k","id":1756537,"avatar_url":"https://avatars.githubusercontent.com/u/1756537?v=3","gravatar_id":"","url":"https://api.github.com/users/Pi03k","html_url":"https://github.com/Pi03k","followers_url":"https://api.github.com/users/Pi03k/followers","following_url":"https://api.github.com/users/Pi03k/following{/other_user}","gists_url":"https://api.github.com/users/Pi03k/gists{/gist_id}","starred_url":"https://api.github.com/users/Pi03k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pi03k/subscriptions","organizations_url":"https://api.github.com/users/Pi03k/orgs","repos_url":"https://api.github.com/users/Pi03k/repos","events_url":"https://api.github.com/users/Pi03k/events{/privacy}","received_events_url":"https://api.github.com/users/Pi03k/received_events","type":"User","site_admin":false},"repo":{"id":36874302,"name":"openmw","full_name":"Pi03k/openmw","owner":{"login":"Pi03k","id":1756537,"avatar_url":"https://avatars.githubusercontent.com/u/1756537?v=3","gravatar_id":"","url":"https://api.github.com/users/Pi03k","html_url":"https://github.com/Pi03k","followers_url":"https://api.github.com/users/Pi03k/followers","following_url":"https://api.github.com/users/Pi03k/following{/other_user}","gists_url":"https://api.github.com/users/Pi03k/gists{/gist_id}","starred_url":"https://api.github.com/users/Pi03k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pi03k/subscriptions","organizations_url":"https://api.github.com/users/Pi03k/orgs","repos_url":"https://api.github.com/users/Pi03k/repos","events_url":"https://api.github.com/users/Pi03k/events{/privacy}","received_events_url":"https://api.github.com/users/Pi03k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pi03k/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/Pi03k/openmw","forks_url":"https://api.github.com/repos/Pi03k/openmw/forks","keys_url":"https://api.github.com/repos/Pi03k/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pi03k/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pi03k/openmw/teams","hooks_url":"https://api.github.com/repos/Pi03k/openmw/hooks","issue_events_url":"https://api.github.com/repos/Pi03k/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/Pi03k/openmw/events","assignees_url":"https://api.github.com/repos/Pi03k/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/Pi03k/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/Pi03k/openmw/tags","blobs_url":"https://api.github.com/repos/Pi03k/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pi03k/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pi03k/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pi03k/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pi03k/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/Pi03k/openmw/languages","stargazers_url":"https://api.github.com/repos/Pi03k/openmw/stargazers","contributors_url":"https://api.github.com/repos/Pi03k/openmw/contributors","subscribers_url":"https://api.github.com/repos/Pi03k/openmw/subscribers","subscription_url":"https://api.github.com/repos/Pi03k/openmw/subscription","commits_url":"https://api.github.com/repos/Pi03k/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pi03k/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pi03k/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pi03k/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pi03k/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/Pi03k/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pi03k/openmw/merges","archive_url":"https://api.github.com/repos/Pi03k/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pi03k/openmw/downloads","issues_url":"https://api.github.com/repos/Pi03k/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/Pi03k/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/Pi03k/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/Pi03k/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pi03k/openmw/labels{/name}","releases_url":"https://api.github.com/repos/Pi03k/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/Pi03k/openmw/deployments","created_at":"2015-06-04T14:13:06Z","updated_at":"2016-01-27T09:13:01Z","pushed_at":"2016-04-19T14:22:23Z","git_url":"git://github.com/Pi03k/openmw.git","ssh_url":"git@github.com:Pi03k/openmw.git","clone_url":"https://github.com/Pi03k/openmw.git","svn_url":"https://github.com/Pi03k/openmw","homepage":"http://www.openmw.org/","size":44773,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"f0778e22ddd695afef1b6e8a1506e9d9811e4228","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars.githubusercontent.com/u/6727417?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMW/openmw/deployments","created_at":"2009-08-23T14:46:21Z","updated_at":"2016-04-21T01:24:52Z","pushed_at":"2016-04-20T09:38:13Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":56151,"stargazers_count":1083,"watchers_count":1083,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":426,"mirror_url":null,"open_issues_count":13,"forks":426,"open_issues":13,"watchers":1083,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/929"},"html":{"href":"https://github.com/OpenMW/openmw/pull/929"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/929"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/929/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/929/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/929/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/eb41f3e4b74dcb7277afd2bcb250741022d3f300"}}}}