{"action":"closed","number":8013,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/8013","id":67584854,"html_url":"https://github.com/dotnet/corefx/pull/8013","diff_url":"https://github.com/dotnet/corefx/pull/8013.diff","patch_url":"https://github.com/dotnet/corefx/pull/8013.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/8013","number":8013,"state":"closed","locked":false,"title":"SocketException improvements","user":{"login":"ericeil","id":7407587,"avatar_url":"https://avatars.githubusercontent.com/u/7407587?v=3","gravatar_id":"","url":"https://api.github.com/users/ericeil","html_url":"https://github.com/ericeil","followers_url":"https://api.github.com/users/ericeil/followers","following_url":"https://api.github.com/users/ericeil/following{/other_user}","gists_url":"https://api.github.com/users/ericeil/gists{/gist_id}","starred_url":"https://api.github.com/users/ericeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericeil/subscriptions","organizations_url":"https://api.github.com/users/ericeil/orgs","repos_url":"https://api.github.com/users/ericeil/repos","events_url":"https://api.github.com/users/ericeil/events{/privacy}","received_events_url":"https://api.github.com/users/ericeil/received_events","type":"User","site_admin":false},"body":"- Move all instantiation of InternalSocketException into SocketExceptionFactory.  Rename InternalSocketException to ExtendedSocketException, and encapsulate it in SocketExceptionFactory to prevent a proliferation of dependencies on this type.\r\n\r\n- Add support for adding an EndPoint to the exception message in ExtendedSocketException (fixes #7873).\r\n\r\n- Remove the TODOs around #7853.  I don't believe it's worth complicating the public contracts just in case someone does an exact type equality comparison on a SocketException.  (Fixes #7853)","created_at":"2016-04-22T23:09:48Z","updated_at":"2016-04-25T17:40:19Z","closed_at":"2016-04-25T17:40:19Z","merged_at":"2016-04-25T17:40:19Z","merge_commit_sha":"1baa9ad06a466a5d6399e1e0a7a7a02564ab51b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/8013/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/8013/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/8013/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/adbe3dd0636d6a52f6d89619207ad3b62fe12625","head":{"label":"ericeil:SocketExceptionEndPoint","ref":"SocketExceptionEndPoint","sha":"adbe3dd0636d6a52f6d89619207ad3b62fe12625","user":{"login":"ericeil","id":7407587,"avatar_url":"https://avatars.githubusercontent.com/u/7407587?v=3","gravatar_id":"","url":"https://api.github.com/users/ericeil","html_url":"https://github.com/ericeil","followers_url":"https://api.github.com/users/ericeil/followers","following_url":"https://api.github.com/users/ericeil/following{/other_user}","gists_url":"https://api.github.com/users/ericeil/gists{/gist_id}","starred_url":"https://api.github.com/users/ericeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericeil/subscriptions","organizations_url":"https://api.github.com/users/ericeil/orgs","repos_url":"https://api.github.com/users/ericeil/repos","events_url":"https://api.github.com/users/ericeil/events{/privacy}","received_events_url":"https://api.github.com/users/ericeil/received_events","type":"User","site_admin":false},"repo":{"id":43165675,"name":"corefx","full_name":"ericeil/corefx","owner":{"login":"ericeil","id":7407587,"avatar_url":"https://avatars.githubusercontent.com/u/7407587?v=3","gravatar_id":"","url":"https://api.github.com/users/ericeil","html_url":"https://github.com/ericeil","followers_url":"https://api.github.com/users/ericeil/followers","following_url":"https://api.github.com/users/ericeil/following{/other_user}","gists_url":"https://api.github.com/users/ericeil/gists{/gist_id}","starred_url":"https://api.github.com/users/ericeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericeil/subscriptions","organizations_url":"https://api.github.com/users/ericeil/orgs","repos_url":"https://api.github.com/users/ericeil/repos","events_url":"https://api.github.com/users/ericeil/events{/privacy}","received_events_url":"https://api.github.com/users/ericeil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericeil/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ericeil/corefx","forks_url":"https://api.github.com/repos/ericeil/corefx/forks","keys_url":"https://api.github.com/repos/ericeil/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericeil/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericeil/corefx/teams","hooks_url":"https://api.github.com/repos/ericeil/corefx/hooks","issue_events_url":"https://api.github.com/repos/ericeil/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ericeil/corefx/events","assignees_url":"https://api.github.com/repos/ericeil/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ericeil/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ericeil/corefx/tags","blobs_url":"https://api.github.com/repos/ericeil/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericeil/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericeil/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericeil/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericeil/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ericeil/corefx/languages","stargazers_url":"https://api.github.com/repos/ericeil/corefx/stargazers","contributors_url":"https://api.github.com/repos/ericeil/corefx/contributors","subscribers_url":"https://api.github.com/repos/ericeil/corefx/subscribers","subscription_url":"https://api.github.com/repos/ericeil/corefx/subscription","commits_url":"https://api.github.com/repos/ericeil/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericeil/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericeil/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericeil/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericeil/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ericeil/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericeil/corefx/merges","archive_url":"https://api.github.com/repos/ericeil/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericeil/corefx/downloads","issues_url":"https://api.github.com/repos/ericeil/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ericeil/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ericeil/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ericeil/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericeil/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ericeil/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ericeil/corefx/deployments","created_at":"2015-09-25T17:47:32Z","updated_at":"2016-01-12T19:24:17Z","pushed_at":"2016-04-25T17:39:38Z","git_url":"git://github.com/ericeil/corefx.git","ssh_url":"git@github.com:ericeil/corefx.git","clone_url":"https://github.com/ericeil/corefx.git","svn_url":"https://github.com/ericeil/corefx","homepage":"http://dotnet.github.io/core/","size":64785,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ef5c3c260fca6b8ad95eea2659eaaea44d420241","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-25T12:42:50Z","pushed_at":"2016-04-25T17:40:19Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":89253,"stargazers_count":9562,"watchers_count":9562,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2279,"mirror_url":null,"open_issues_count":980,"forks":2279,"open_issues":980,"watchers":9562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8013"},"html":{"href":"https://github.com/dotnet/corefx/pull/8013"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8013"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/8013/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8013/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/8013/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/adbe3dd0636d6a52f6d89619207ad3b62fe12625"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ericeil","id":7407587,"avatar_url":"https://avatars.githubusercontent.com/u/7407587?v=3","gravatar_id":"","url":"https://api.github.com/users/ericeil","html_url":"https://github.com/ericeil","followers_url":"https://api.github.com/users/ericeil/followers","following_url":"https://api.github.com/users/ericeil/following{/other_user}","gists_url":"https://api.github.com/users/ericeil/gists{/gist_id}","starred_url":"https://api.github.com/users/ericeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericeil/subscriptions","organizations_url":"https://api.github.com/users/ericeil/orgs","repos_url":"https://api.github.com/users/ericeil/repos","events_url":"https://api.github.com/users/ericeil/events{/privacy}","received_events_url":"https://api.github.com/users/ericeil/received_events","type":"User","site_admin":false},"comments":4,"review_comments":8,"commits":2,"additions":76,"deletions":56,"changed_files":11}}