{"action":"opened","number":583,"pull_request":{"url":"https://api.github.com/repos/keplerproject/luarocks/pulls/583","id":76788112,"html_url":"https://github.com/keplerproject/luarocks/pull/583","diff_url":"https://github.com/keplerproject/luarocks/pull/583.diff","patch_url":"https://github.com/keplerproject/luarocks/pull/583.patch","issue_url":"https://api.github.com/repos/keplerproject/luarocks/issues/583","number":583,"state":"open","locked":false,"title":"Minor changes and fixes for new test suite","user":{"login":"mpeterv","id":6032370,"avatar_url":"https://avatars.githubusercontent.com/u/6032370?v=3","gravatar_id":"","url":"https://api.github.com/users/mpeterv","html_url":"https://github.com/mpeterv","followers_url":"https://api.github.com/users/mpeterv/followers","following_url":"https://api.github.com/users/mpeterv/following{/other_user}","gists_url":"https://api.github.com/users/mpeterv/gists{/gist_id}","starred_url":"https://api.github.com/users/mpeterv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpeterv/subscriptions","organizations_url":"https://api.github.com/users/mpeterv/orgs","repos_url":"https://api.github.com/users/mpeterv/repos","events_url":"https://api.github.com/users/mpeterv/events{/privacy}","received_events_url":"https://api.github.com/users/mpeterv/received_events","type":"User","site_admin":false},"body":"This is just a heap of commits adjusting the new test suite a little. Not sure if this can be merged completely, will probably refine and cherry-pick commits one by one.\r\n\r\nSo far I like the new test suite a lot. Implementing it using busted allows us to later improve it further:\r\n\r\n* Make it Windows-compatible\r\n* Try to reduce output noise for successful tests. Typically in busted specs tests don't output anything at all if they pass. On failure, assertion that failed should provide enough information for debugging. This is definitely not true for `assert.is_true` and `assert.is_false` assertions that are used when checking command success and failure (it just prints: `expected true, got false`). If we'll go this way we'll need custom assertions that execute command and print it and its output on unexpected result. A collections of such assertions would be valuable for testing other command-line programs, might want to make that a library.","created_at":"2016-07-08T17:42:48Z","updated_at":"2016-07-08T17:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15561322609905b3a7a288d737ccc1db7be6c7c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/keplerproject/luarocks/pulls/583/commits","review_comments_url":"https://api.github.com/repos/keplerproject/luarocks/pulls/583/comments","review_comment_url":"https://api.github.com/repos/keplerproject/luarocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keplerproject/luarocks/issues/583/comments","statuses_url":"https://api.github.com/repos/keplerproject/luarocks/statuses/a05ba7ce42ae4e42f80b5cacdd8770ae5e6cc04b","head":{"label":"mpeterv:adjust-new-tests","ref":"adjust-new-tests","sha":"a05ba7ce42ae4e42f80b5cacdd8770ae5e6cc04b","user":{"login":"mpeterv","id":6032370,"avatar_url":"https://avatars.githubusercontent.com/u/6032370?v=3","gravatar_id":"","url":"https://api.github.com/users/mpeterv","html_url":"https://github.com/mpeterv","followers_url":"https://api.github.com/users/mpeterv/followers","following_url":"https://api.github.com/users/mpeterv/following{/other_user}","gists_url":"https://api.github.com/users/mpeterv/gists{/gist_id}","starred_url":"https://api.github.com/users/mpeterv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpeterv/subscriptions","organizations_url":"https://api.github.com/users/mpeterv/orgs","repos_url":"https://api.github.com/users/mpeterv/repos","events_url":"https://api.github.com/users/mpeterv/events{/privacy}","received_events_url":"https://api.github.com/users/mpeterv/received_events","type":"User","site_admin":false},"repo":{"id":17364625,"name":"luarocks","full_name":"mpeterv/luarocks","owner":{"login":"mpeterv","id":6032370,"avatar_url":"https://avatars.githubusercontent.com/u/6032370?v=3","gravatar_id":"","url":"https://api.github.com/users/mpeterv","html_url":"https://github.com/mpeterv","followers_url":"https://api.github.com/users/mpeterv/followers","following_url":"https://api.github.com/users/mpeterv/following{/other_user}","gists_url":"https://api.github.com/users/mpeterv/gists{/gist_id}","starred_url":"https://api.github.com/users/mpeterv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpeterv/subscriptions","organizations_url":"https://api.github.com/users/mpeterv/orgs","repos_url":"https://api.github.com/users/mpeterv/repos","events_url":"https://api.github.com/users/mpeterv/events{/privacy}","received_events_url":"https://api.github.com/users/mpeterv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpeterv/luarocks","description":"LuaRocks is  a deployment and management system for Lua modules.","fork":true,"url":"https://api.github.com/repos/mpeterv/luarocks","forks_url":"https://api.github.com/repos/mpeterv/luarocks/forks","keys_url":"https://api.github.com/repos/mpeterv/luarocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpeterv/luarocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpeterv/luarocks/teams","hooks_url":"https://api.github.com/repos/mpeterv/luarocks/hooks","issue_events_url":"https://api.github.com/repos/mpeterv/luarocks/issues/events{/number}","events_url":"https://api.github.com/repos/mpeterv/luarocks/events","assignees_url":"https://api.github.com/repos/mpeterv/luarocks/assignees{/user}","branches_url":"https://api.github.com/repos/mpeterv/luarocks/branches{/branch}","tags_url":"https://api.github.com/repos/mpeterv/luarocks/tags","blobs_url":"https://api.github.com/repos/mpeterv/luarocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpeterv/luarocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpeterv/luarocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpeterv/luarocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpeterv/luarocks/statuses/{sha}","languages_url":"https://api.github.com/repos/mpeterv/luarocks/languages","stargazers_url":"https://api.github.com/repos/mpeterv/luarocks/stargazers","contributors_url":"https://api.github.com/repos/mpeterv/luarocks/contributors","subscribers_url":"https://api.github.com/repos/mpeterv/luarocks/subscribers","subscription_url":"https://api.github.com/repos/mpeterv/luarocks/subscription","commits_url":"https://api.github.com/repos/mpeterv/luarocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpeterv/luarocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpeterv/luarocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpeterv/luarocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpeterv/luarocks/contents/{+path}","compare_url":"https://api.github.com/repos/mpeterv/luarocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpeterv/luarocks/merges","archive_url":"https://api.github.com/repos/mpeterv/luarocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpeterv/luarocks/downloads","issues_url":"https://api.github.com/repos/mpeterv/luarocks/issues{/number}","pulls_url":"https://api.github.com/repos/mpeterv/luarocks/pulls{/number}","milestones_url":"https://api.github.com/repos/mpeterv/luarocks/milestones{/number}","notifications_url":"https://api.github.com/repos/mpeterv/luarocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpeterv/luarocks/labels{/name}","releases_url":"https://api.github.com/repos/mpeterv/luarocks/releases{/id}","deployments_url":"https://api.github.com/repos/mpeterv/luarocks/deployments","created_at":"2014-03-03T11:54:17Z","updated_at":"2016-01-11T08:30:33Z","pushed_at":"2016-07-08T17:29:07Z","git_url":"git://github.com/mpeterv/luarocks.git","ssh_url":"git@github.com:mpeterv/luarocks.git","clone_url":"https://github.com/mpeterv/luarocks.git","svn_url":"https://github.com/mpeterv/luarocks","homepage":"http://www.luarocks.org","size":7720,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keplerproject:master","ref":"master","sha":"5af7e0d7c2dcf65e41ae8523f3771e9528be32a7","user":{"login":"keplerproject","id":129602,"avatar_url":"https://avatars.githubusercontent.com/u/129602?v=3","gravatar_id":"","url":"https://api.github.com/users/keplerproject","html_url":"https://github.com/keplerproject","followers_url":"https://api.github.com/users/keplerproject/followers","following_url":"https://api.github.com/users/keplerproject/following{/other_user}","gists_url":"https://api.github.com/users/keplerproject/gists{/gist_id}","starred_url":"https://api.github.com/users/keplerproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keplerproject/subscriptions","organizations_url":"https://api.github.com/users/keplerproject/orgs","repos_url":"https://api.github.com/users/keplerproject/repos","events_url":"https://api.github.com/users/keplerproject/events{/privacy}","received_events_url":"https://api.github.com/users/keplerproject/received_events","type":"Organization","site_admin":false},"repo":{"id":571621,"name":"luarocks","full_name":"keplerproject/luarocks","owner":{"login":"keplerproject","id":129602,"avatar_url":"https://avatars.githubusercontent.com/u/129602?v=3","gravatar_id":"","url":"https://api.github.com/users/keplerproject","html_url":"https://github.com/keplerproject","followers_url":"https://api.github.com/users/keplerproject/followers","following_url":"https://api.github.com/users/keplerproject/following{/other_user}","gists_url":"https://api.github.com/users/keplerproject/gists{/gist_id}","starred_url":"https://api.github.com/users/keplerproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keplerproject/subscriptions","organizations_url":"https://api.github.com/users/keplerproject/orgs","repos_url":"https://api.github.com/users/keplerproject/repos","events_url":"https://api.github.com/users/keplerproject/events{/privacy}","received_events_url":"https://api.github.com/users/keplerproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keplerproject/luarocks","description":"LuaRocks is  a package manager for Lua modules.","fork":false,"url":"https://api.github.com/repos/keplerproject/luarocks","forks_url":"https://api.github.com/repos/keplerproject/luarocks/forks","keys_url":"https://api.github.com/repos/keplerproject/luarocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keplerproject/luarocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keplerproject/luarocks/teams","hooks_url":"https://api.github.com/repos/keplerproject/luarocks/hooks","issue_events_url":"https://api.github.com/repos/keplerproject/luarocks/issues/events{/number}","events_url":"https://api.github.com/repos/keplerproject/luarocks/events","assignees_url":"https://api.github.com/repos/keplerproject/luarocks/assignees{/user}","branches_url":"https://api.github.com/repos/keplerproject/luarocks/branches{/branch}","tags_url":"https://api.github.com/repos/keplerproject/luarocks/tags","blobs_url":"https://api.github.com/repos/keplerproject/luarocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keplerproject/luarocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keplerproject/luarocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/keplerproject/luarocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keplerproject/luarocks/statuses/{sha}","languages_url":"https://api.github.com/repos/keplerproject/luarocks/languages","stargazers_url":"https://api.github.com/repos/keplerproject/luarocks/stargazers","contributors_url":"https://api.github.com/repos/keplerproject/luarocks/contributors","subscribers_url":"https://api.github.com/repos/keplerproject/luarocks/subscribers","subscription_url":"https://api.github.com/repos/keplerproject/luarocks/subscription","commits_url":"https://api.github.com/repos/keplerproject/luarocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/keplerproject/luarocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/keplerproject/luarocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/keplerproject/luarocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/keplerproject/luarocks/contents/{+path}","compare_url":"https://api.github.com/repos/keplerproject/luarocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keplerproject/luarocks/merges","archive_url":"https://api.github.com/repos/keplerproject/luarocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keplerproject/luarocks/downloads","issues_url":"https://api.github.com/repos/keplerproject/luarocks/issues{/number}","pulls_url":"https://api.github.com/repos/keplerproject/luarocks/pulls{/number}","milestones_url":"https://api.github.com/repos/keplerproject/luarocks/milestones{/number}","notifications_url":"https://api.github.com/repos/keplerproject/luarocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keplerproject/luarocks/labels{/name}","releases_url":"https://api.github.com/repos/keplerproject/luarocks/releases{/id}","deployments_url":"https://api.github.com/repos/keplerproject/luarocks/deployments","created_at":"2010-03-20T18:23:35Z","updated_at":"2016-07-08T16:34:22Z","pushed_at":"2016-07-08T17:42:48Z","git_url":"git://github.com/keplerproject/luarocks.git","ssh_url":"git@github.com:keplerproject/luarocks.git","clone_url":"https://github.com/keplerproject/luarocks.git","svn_url":"https://github.com/keplerproject/luarocks","homepage":"http://www.luarocks.org","size":23520,"stargazers_count":654,"watchers_count":654,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":142,"mirror_url":null,"open_issues_count":87,"forks":142,"open_issues":87,"watchers":654,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keplerproject/luarocks/pulls/583"},"html":{"href":"https://github.com/keplerproject/luarocks/pull/583"},"issue":{"href":"https://api.github.com/repos/keplerproject/luarocks/issues/583"},"comments":{"href":"https://api.github.com/repos/keplerproject/luarocks/issues/583/comments"},"review_comments":{"href":"https://api.github.com/repos/keplerproject/luarocks/pulls/583/comments"},"review_comment":{"href":"https://api.github.com/repos/keplerproject/luarocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keplerproject/luarocks/pulls/583/commits"},"statuses":{"href":"https://api.github.com/repos/keplerproject/luarocks/statuses/a05ba7ce42ae4e42f80b5cacdd8770ae5e6cc04b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":23,"additions":405,"deletions":469,"changed_files":28}}
{"actor":{"display_login":"mpeterv"}}