{"action":"created","issue":{"url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/72","repository_url":"https://api.github.com/repos/open-ephys/plugin-GUI","labels_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/72/comments","events_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/72/events","html_url":"https://github.com/open-ephys/plugin-GUI/pull/72","id":164683236,"number":72,"title":"[VisualizerEditor] Helpers to override `buttonClicked` added.","user":{"login":"arrow-","id":9897445,"avatar_url":"https://avatars.githubusercontent.com/u/9897445?v=3","gravatar_id":"","url":"https://api.github.com/users/arrow-","html_url":"https://github.com/arrow-","followers_url":"https://api.github.com/users/arrow-/followers","following_url":"https://api.github.com/users/arrow-/following{/other_user}","gists_url":"https://api.github.com/users/arrow-/gists{/gist_id}","starred_url":"https://api.github.com/users/arrow-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arrow-/subscriptions","organizations_url":"https://api.github.com/users/arrow-/orgs","repos_url":"https://api.github.com/users/arrow-/repos","events_url":"https://api.github.com/users/arrow-/events{/privacy}","received_events_url":"https://api.github.com/users/arrow-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-09T20:03:18Z","updated_at":"2016-07-15T21:24:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-ephys/plugin-GUI/pulls/72","html_url":"https://github.com/open-ephys/plugin-GUI/pull/72","diff_url":"https://github.com/open-ephys/plugin-GUI/pull/72.diff","patch_url":"https://github.com/open-ephys/plugin-GUI/pull/72.patch"},"body":"These changes were made primarily to accommodate for the cyclops-stimulator. Since `buttonClicked` manipulates the `DataViewport` via `AccessClass`, a sub-class of `VisualizerEditor` cannot functionally override the method.\r\nHence:\r\n\r\n* Added `protected` methods which manipulate `DataViewport` (via `AccessClass`)\r\n* moved the SelectorButtons into `protected` area, essential!\r\n* All of the additions _are_ essential to the cyclops-stimulator.\r\n* There is NO change in the public interface.\r\n\r\nNow, _my_ `buttonClicked` method can access the SelectorButtons, manipulate `DataViewport`.\r\nPlease remove the (new) comments from VisualizerEditor::buttonClicked (`.cpp`), they are not needed anymore."},"comment":{"url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/comments/233073474","html_url":"https://github.com/open-ephys/plugin-GUI/pull/72#issuecomment-233073474","issue_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/72","id":233073474,"user":{"login":"sept-en","id":7783792,"avatar_url":"https://avatars.githubusercontent.com/u/7783792?v=3","gravatar_id":"","url":"https://api.github.com/users/sept-en","html_url":"https://github.com/sept-en","followers_url":"https://api.github.com/users/sept-en/followers","following_url":"https://api.github.com/users/sept-en/following{/other_user}","gists_url":"https://api.github.com/users/sept-en/gists{/gist_id}","starred_url":"https://api.github.com/users/sept-en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sept-en/subscriptions","organizations_url":"https://api.github.com/users/sept-en/orgs","repos_url":"https://api.github.com/users/sept-en/repos","events_url":"https://api.github.com/users/sept-en/events{/privacy}","received_events_url":"https://api.github.com/users/sept-en/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T21:24:13Z","updated_at":"2016-07-15T21:24:13Z","body":"@arrow-, yeah I understand that some plugins might require this feature to somehow respond to the closing window events.\r\n\r\nHowever, I think that's better approach would be to create DataWindow::LIstener and then subscribe VisualizerEditor for the events of DataWindow (Observer pattern). In my opinion, we will have a bit cleaner and less coupled design.\r\n\r\nWhat do you think?\r\n\r\nBest regards,\r\nKirill Abramov."}}
{"actor":{"display_login":"sept-en"}}