{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/82917509","pull_request_review_id":3791244,"id":82917509,"diff_hunk":"@@ -53,3 +53,23 @@ local.mk\n \n # clint errors, generated by `make lint`\n /errors.json\n+\n+# Files generated from running CMake in-tree\n+CMakeCache.txt\n+CMakeFiles/\n+CPackConfig.cmake\n+CPackSourceConfig.cmake\n+compile_commands.json\n+cmake_install.cmake\n+install_manifest.txt\n+*.mpack\n+*.ninja\n+Makefile\n+\n+# Ignore some artifacts if you do an in-tree build","path":".gitignore","position":17,"original_position":17,"commit_id":"958da09964446f875da8c41086f251cb2d1dcd46","original_commit_id":"958da09964446f875da8c41086f251cb2d1dcd46","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"I think it's ok to let generated stuff appear in git status. ","created_at":"2016-10-12T00:34:03Z","updated_at":"2016-10-12T00:34:04Z","html_url":"https://github.com/neovim/neovim/pull/5466#discussion_r82917509","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/5466","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/82917509"},"html":{"href":"https://github.com/neovim/neovim/pull/5466#discussion_r82917509"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5466"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/5466","id":88933114,"html_url":"https://github.com/neovim/neovim/pull/5466","diff_url":"https://github.com/neovim/neovim/pull/5466.diff","patch_url":"https://github.com/neovim/neovim/pull/5466.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/5466","number":5466,"state":"open","locked":false,"title":"Fix generated files for in-tree build.","user":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"body":"Don't get your hopes up yet, but this does allow an in-tree build to proceed.  The one catch is that when using the \"Unix Makefiles\" generator, it will clobber our top-level Makefile--so we'll need to do something more if we want to prevent that problem.  But this is a good start.  It also includes updates to .gitignore to help prevent `git status` from becoming an abomination if you try it.\r\n\r\nNote: there really is no way to clean everything up well (outside of a `git clean -fdx`), so I don't recommend this.  But I thought we could at least fix enough of the in-tree build that if we change our minds, someone else doesn't have to tackle this particular issue.","created_at":"2016-10-12T00:10:15Z","updated_at":"2016-10-12T00:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cddc0963ebbeb49c5de45ebb5b891f3c2cba81b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/5466/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/5466/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/5466/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/958da09964446f875da8c41086f251cb2d1dcd46","head":{"label":"jszakmeister:fix-generated-files-for-in-tree-build","ref":"fix-generated-files-for-in-tree-build","sha":"958da09964446f875da8c41086f251cb2d1dcd46","user":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"repo":{"id":17115700,"name":"neovim","full_name":"jszakmeister/neovim","owner":{"login":"jszakmeister","id":448087,"avatar_url":"https://avatars.githubusercontent.com/u/448087?v=3","gravatar_id":"","url":"https://api.github.com/users/jszakmeister","html_url":"https://github.com/jszakmeister","followers_url":"https://api.github.com/users/jszakmeister/followers","following_url":"https://api.github.com/users/jszakmeister/following{/other_user}","gists_url":"https://api.github.com/users/jszakmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/jszakmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszakmeister/subscriptions","organizations_url":"https://api.github.com/users/jszakmeister/orgs","repos_url":"https://api.github.com/users/jszakmeister/repos","events_url":"https://api.github.com/users/jszakmeister/events{/privacy}","received_events_url":"https://api.github.com/users/jszakmeister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jszakmeister/neovim","description":"Vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/jszakmeister/neovim","forks_url":"https://api.github.com/repos/jszakmeister/neovim/forks","keys_url":"https://api.github.com/repos/jszakmeister/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jszakmeister/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jszakmeister/neovim/teams","hooks_url":"https://api.github.com/repos/jszakmeister/neovim/hooks","issue_events_url":"https://api.github.com/repos/jszakmeister/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/jszakmeister/neovim/events","assignees_url":"https://api.github.com/repos/jszakmeister/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/jszakmeister/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/jszakmeister/neovim/tags","blobs_url":"https://api.github.com/repos/jszakmeister/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jszakmeister/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jszakmeister/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/jszakmeister/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jszakmeister/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/jszakmeister/neovim/languages","stargazers_url":"https://api.github.com/repos/jszakmeister/neovim/stargazers","contributors_url":"https://api.github.com/repos/jszakmeister/neovim/contributors","subscribers_url":"https://api.github.com/repos/jszakmeister/neovim/subscribers","subscription_url":"https://api.github.com/repos/jszakmeister/neovim/subscription","commits_url":"https://api.github.com/repos/jszakmeister/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/jszakmeister/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/jszakmeister/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/jszakmeister/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/jszakmeister/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/jszakmeister/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jszakmeister/neovim/merges","archive_url":"https://api.github.com/repos/jszakmeister/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jszakmeister/neovim/downloads","issues_url":"https://api.github.com/repos/jszakmeister/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/jszakmeister/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/jszakmeister/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/jszakmeister/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jszakmeister/neovim/labels{/name}","releases_url":"https://api.github.com/repos/jszakmeister/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/jszakmeister/neovim/deployments","created_at":"2014-02-23T19:59:02Z","updated_at":"2015-05-08T21:00:07Z","pushed_at":"2016-10-12T00:20:36Z","git_url":"git://github.com/jszakmeister/neovim.git","ssh_url":"git@github.com:jszakmeister/neovim.git","clone_url":"https://github.com/jszakmeister/neovim.git","svn_url":"https://github.com/jszakmeister/neovim","homepage":"","size":42446,"stargazers_count":1,"watchers_count":1,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"1dde512498d2fa9f3427861b5d4f894c778f992b","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility.","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-10-11T21:44:14Z","pushed_at":"2016-10-12T00:21:57Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":71583,"stargazers_count":20279,"watchers_count":20279,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1450,"mirror_url":null,"open_issues_count":787,"forks":1450,"open_issues":787,"watchers":20279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5466"},"html":{"href":"https://github.com/neovim/neovim/pull/5466"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/5466"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/5466/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5466/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/5466/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/958da09964446f875da8c41086f251cb2d1dcd46"}}}}
{"actor":{"display_login":"justinmk"}}