{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/13819","repository_url":"https://api.github.com/repos/odoo/odoo","labels_url":"https://api.github.com/repos/odoo/odoo/issues/13819/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/13819/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/13819/events","html_url":"https://github.com/odoo/odoo/pull/13819","id":183049075,"number":13819,"title":"[FIX] Base amount computation does ignore taxes with child taxes","user":{"login":"wtaferner","id":362478,"avatar_url":"https://avatars.githubusercontent.com/u/362478?v=3","gravatar_id":"","url":"https://api.github.com/users/wtaferner","html_url":"https://github.com/wtaferner","followers_url":"https://api.github.com/users/wtaferner/followers","following_url":"https://api.github.com/users/wtaferner/following{/other_user}","gists_url":"https://api.github.com/users/wtaferner/gists{/gist_id}","starred_url":"https://api.github.com/users/wtaferner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtaferner/subscriptions","organizations_url":"https://api.github.com/users/wtaferner/orgs","repos_url":"https://api.github.com/users/wtaferner/repos","events_url":"https://api.github.com/users/wtaferner/events{/privacy}","received_events_url":"https://api.github.com/users/wtaferner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nim-odoo","id":11041725,"avatar_url":"https://avatars.githubusercontent.com/u/11041725?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-odoo","html_url":"https://github.com/nim-odoo","followers_url":"https://api.github.com/users/nim-odoo/followers","following_url":"https://api.github.com/users/nim-odoo/following{/other_user}","gists_url":"https://api.github.com/users/nim-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-odoo/subscriptions","organizations_url":"https://api.github.com/users/nim-odoo/orgs","repos_url":"https://api.github.com/users/nim-odoo/repos","events_url":"https://api.github.com/users/nim-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/nim-odoo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nim-odoo","id":11041725,"avatar_url":"https://avatars.githubusercontent.com/u/11041725?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-odoo","html_url":"https://github.com/nim-odoo","followers_url":"https://api.github.com/users/nim-odoo/followers","following_url":"https://api.github.com/users/nim-odoo/following{/other_user}","gists_url":"https://api.github.com/users/nim-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-odoo/subscriptions","organizations_url":"https://api.github.com/users/nim-odoo/orgs","repos_url":"https://api.github.com/users/nim-odoo/repos","events_url":"https://api.github.com/users/nim-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/nim-odoo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-10-14T13:24:21Z","updated_at":"2016-10-14T14:23:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/13819","html_url":"https://github.com/odoo/odoo/pull/13819","diff_url":"https://github.com/odoo/odoo/pull/13819.diff","patch_url":"https://github.com/odoo/odoo/pull/13819.patch"},"body":"Description of the issue/feature this PR addresses:\r\nIf a tax is used on invoice lines with one or more children taxes the base amount will be zero instead of the correct base amount.\r\n\r\nCurrent behavior before PR:\r\nNot for all use cases correctly calculated (missing child tax applications)\r\n\r\nDesired behavior after PR is merged:\r\nChild tax applications possible\r\n\r\n@nim-odoo\r\nYou improved it in https://github.com/odoo/odoo/commit/dd1eb03af5aa5ed9bec2c8ede8d4d2f4106c505d about a month ago but there is still at least one use case missing which I implemented\r\n\r\nThank you for merging in case you agree with me.\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/253814492","html_url":"https://github.com/odoo/odoo/pull/13819#issuecomment-253814492","issue_url":"https://api.github.com/repos/odoo/odoo/issues/13819","id":253814492,"user":{"login":"wtaferner","id":362478,"avatar_url":"https://avatars.githubusercontent.com/u/362478?v=3","gravatar_id":"","url":"https://api.github.com/users/wtaferner","html_url":"https://github.com/wtaferner","followers_url":"https://api.github.com/users/wtaferner/followers","following_url":"https://api.github.com/users/wtaferner/following{/other_user}","gists_url":"https://api.github.com/users/wtaferner/gists{/gist_id}","starred_url":"https://api.github.com/users/wtaferner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtaferner/subscriptions","organizations_url":"https://api.github.com/users/wtaferner/orgs","repos_url":"https://api.github.com/users/wtaferner/repos","events_url":"https://api.github.com/users/wtaferner/events{/privacy}","received_events_url":"https://api.github.com/users/wtaferner/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T14:23:11Z","updated_at":"2016-10-14T14:23:11Z","body":"Ok, but what was done so far was to get back the base amount of all the other taxes but the one I was calculating the base amount?\r\n\r\nMy use case is simple:\r\nEU Purchase tax triggering two taxes to be calculated (could be reverse charge or normal import) and the amount to pay is zero."}}
{"actor":{"display_login":"wtaferner"}}