{"action":"created","issue":{"url":"https://api.github.com/repos/Workiva/dart_dev/issues/161","repository_url":"https://api.github.com/repos/Workiva/dart_dev","labels_url":"https://api.github.com/repos/Workiva/dart_dev/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/Workiva/dart_dev/issues/161/comments","events_url":"https://api.github.com/repos/Workiva/dart_dev/issues/161/events","html_url":"https://github.com/Workiva/dart_dev/pull/161","id":158450255,"number":161,"title":"CP-1864 Wait for pub-serve process to complete before test execution","user":{"login":"jayudey-wf","id":4429043,"avatar_url":"https://avatars.githubusercontent.com/u/4429043?v=3","gravatar_id":"","url":"https://api.github.com/users/jayudey-wf","html_url":"https://github.com/jayudey-wf","followers_url":"https://api.github.com/users/jayudey-wf/followers","following_url":"https://api.github.com/users/jayudey-wf/following{/other_user}","gists_url":"https://api.github.com/users/jayudey-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jayudey-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayudey-wf/subscriptions","organizations_url":"https://api.github.com/users/jayudey-wf/orgs","repos_url":"https://api.github.com/users/jayudey-wf/repos","events_url":"https://api.github.com/users/jayudey-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jayudey-wf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-03T20:40:00Z","updated_at":"2016-06-09T14:37:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Workiva/dart_dev/pulls/161","html_url":"https://github.com/Workiva/dart_dev/pull/161","diff_url":"https://github.com/Workiva/dart_dev/pull/161.diff","patch_url":"https://github.com/Workiva/dart_dev/pull/161.patch"},"body":"## Issue\r\n- There was a race condition that existed where https://github.com/Workiva/dart_dev/blob/master/test/integration/test_test.dart#L152 could start executing before the pub serve process could get set up. This was causing test failures.\r\n\r\n## Changes\r\n**Source:**\r\n- Waited for pub-serve to complete prior to test execution\r\n\r\n**Tests:**\r\n- n/a\r\n\r\n## Areas of Regression\r\n- Tests failing\r\n\r\n## Testing\r\n- Check out branch locally and verify that tests are still passing, on Travis it appears that for dart 1.16.1 content_shell was not properly installed and is causing failures there (https://travis-ci.org/Workiva/dart_dev/builds/135127265#L872)\r\n\r\n## Code Review\r\n@dustinlessard-wf \r\n@evanweible-wf \r\n@trentgrover-wf "},"comment":{"url":"https://api.github.com/repos/Workiva/dart_dev/issues/comments/224915021","html_url":"https://github.com/Workiva/dart_dev/pull/161#issuecomment-224915021","issue_url":"https://api.github.com/repos/Workiva/dart_dev/issues/161","id":224915021,"user":{"login":"evanweible-wf","id":1738457,"avatar_url":"https://avatars.githubusercontent.com/u/1738457?v=3","gravatar_id":"","url":"https://api.github.com/users/evanweible-wf","html_url":"https://github.com/evanweible-wf","followers_url":"https://api.github.com/users/evanweible-wf/followers","following_url":"https://api.github.com/users/evanweible-wf/following{/other_user}","gists_url":"https://api.github.com/users/evanweible-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/evanweible-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanweible-wf/subscriptions","organizations_url":"https://api.github.com/users/evanweible-wf/orgs","repos_url":"https://api.github.com/users/evanweible-wf/repos","events_url":"https://api.github.com/users/evanweible-wf/events{/privacy}","received_events_url":"https://api.github.com/users/evanweible-wf/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T14:37:48Z","updated_at":"2016-06-09T14:37:48Z","body":"QA Resource Approval: +1\r\n\r\n- [x] Testing instruction\r\n- [x] Dev +1's\r\n- [x] Dev/QA +10 with detail of what was tested\r\n- [x] Unit test created/updated\r\n- [x] All unit tests pass\r\n\r\nMerging into master."}}
{"actor":{"display_login":"evanweible-wf"}}