{"action":"created","comment":{"url":"https://api.github.com/repos/Symantec/scotty/pulls/comments/60773252","id":60773252,"diff_hunk":"@@ -34,11 +37,108 @@ type Record struct {\n \tTimestamp time.Time\n }\n \n+// Writer is the interface for writing to persistent store.\n+// Implementations of Writer must be safe to use with multiple goroutines.\n type Writer interface {\n+\t// Write writes given collection of records to persistent storage\n+\tWrite(records []Record) error\n+}\n+\n+// LimitedWriter is a Writer which provides information on what types of\n+// values it can write.\n+type LimitedWriter interface {\n+\tWriter\n \t// IsTypeSupported returns true if this writer supports metrics\n \t// of a particular kind.\n \tIsTypeSupported(kind types.Type) bool\n+}\n ","path":"pstore/api.go","position":31,"original_position":31,"commit_id":"4bbff0e1806a654cfa1c3380775d6ddbbcbfd275","original_commit_id":"4bbff0e1806a654cfa1c3380775d6ddbbcbfd275","user":{"login":"rgooch","id":9002662,"avatar_url":"https://avatars.githubusercontent.com/u/9002662?v=3","gravatar_id":"","url":"https://api.github.com/users/rgooch","html_url":"https://github.com/rgooch","followers_url":"https://api.github.com/users/rgooch/followers","following_url":"https://api.github.com/users/rgooch/following{/other_user}","gists_url":"https://api.github.com/users/rgooch/gists{/gist_id}","starred_url":"https://api.github.com/users/rgooch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgooch/subscriptions","organizations_url":"https://api.github.com/users/rgooch/orgs","repos_url":"https://api.github.com/users/rgooch/repos","events_url":"https://api.github.com/users/rgooch/events{/privacy}","received_events_url":"https://api.github.com/users/rgooch/received_events","type":"User","site_admin":false},"body":"Similar comment as above.","created_at":"2016-04-22T17:22:06Z","updated_at":"2016-04-22T17:22:06Z","html_url":"https://github.com/Symantec/scotty/pull/51#discussion_r60773252","pull_request_url":"https://api.github.com/repos/Symantec/scotty/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/Symantec/scotty/pulls/comments/60773252"},"html":{"href":"https://github.com/Symantec/scotty/pull/51#discussion_r60773252"},"pull_request":{"href":"https://api.github.com/repos/Symantec/scotty/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/Symantec/scotty/pulls/51","id":67541093,"html_url":"https://github.com/Symantec/scotty/pull/51","diff_url":"https://github.com/Symantec/scotty/pull/51.diff","patch_url":"https://github.com/Symantec/scotty/pull/51.patch","issue_url":"https://api.github.com/repos/Symantec/scotty/issues/51","number":51,"state":"open","locked":false,"title":"Introduce new abstractions in pstore package.","user":{"login":"keep94","id":1761650,"avatar_url":"https://avatars.githubusercontent.com/u/1761650?v=3","gravatar_id":"","url":"https://api.github.com/users/keep94","html_url":"https://github.com/keep94","followers_url":"https://api.github.com/users/keep94/followers","following_url":"https://api.github.com/users/keep94/following{/other_user}","gists_url":"https://api.github.com/users/keep94/gists{/gist_id}","starred_url":"https://api.github.com/users/keep94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keep94/subscriptions","organizations_url":"https://api.github.com/users/keep94/orgs","repos_url":"https://api.github.com/users/keep94/repos","events_url":"https://api.github.com/users/keep94/events{/privacy}","received_events_url":"https://api.github.com/users/keep94/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-22T16:49:43Z","updated_at":"2016-04-22T17:22:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03be7cbc1e49b5f8f02ec0188798d257716380db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Symantec/scotty/pulls/51/commits","review_comments_url":"https://api.github.com/repos/Symantec/scotty/pulls/51/comments","review_comment_url":"https://api.github.com/repos/Symantec/scotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Symantec/scotty/issues/51/comments","statuses_url":"https://api.github.com/repos/Symantec/scotty/statuses/4bbff0e1806a654cfa1c3380775d6ddbbcbfd275","head":{"label":"keep94:codereview","ref":"codereview","sha":"4bbff0e1806a654cfa1c3380775d6ddbbcbfd275","user":{"login":"keep94","id":1761650,"avatar_url":"https://avatars.githubusercontent.com/u/1761650?v=3","gravatar_id":"","url":"https://api.github.com/users/keep94","html_url":"https://github.com/keep94","followers_url":"https://api.github.com/users/keep94/followers","following_url":"https://api.github.com/users/keep94/following{/other_user}","gists_url":"https://api.github.com/users/keep94/gists{/gist_id}","starred_url":"https://api.github.com/users/keep94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keep94/subscriptions","organizations_url":"https://api.github.com/users/keep94/orgs","repos_url":"https://api.github.com/users/keep94/repos","events_url":"https://api.github.com/users/keep94/events{/privacy}","received_events_url":"https://api.github.com/users/keep94/received_events","type":"User","site_admin":false},"repo":{"id":50072352,"name":"scotty","full_name":"keep94/scotty","owner":{"login":"keep94","id":1761650,"avatar_url":"https://avatars.githubusercontent.com/u/1761650?v=3","gravatar_id":"","url":"https://api.github.com/users/keep94","html_url":"https://github.com/keep94","followers_url":"https://api.github.com/users/keep94/followers","following_url":"https://api.github.com/users/keep94/following{/other_user}","gists_url":"https://api.github.com/users/keep94/gists{/gist_id}","starred_url":"https://api.github.com/users/keep94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keep94/subscriptions","organizations_url":"https://api.github.com/users/keep94/orgs","repos_url":"https://api.github.com/users/keep94/repos","events_url":"https://api.github.com/users/keep94/events{/privacy}","received_events_url":"https://api.github.com/users/keep94/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keep94/scotty","description":"A highly scalable collector for tricorder applications","fork":true,"url":"https://api.github.com/repos/keep94/scotty","forks_url":"https://api.github.com/repos/keep94/scotty/forks","keys_url":"https://api.github.com/repos/keep94/scotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keep94/scotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keep94/scotty/teams","hooks_url":"https://api.github.com/repos/keep94/scotty/hooks","issue_events_url":"https://api.github.com/repos/keep94/scotty/issues/events{/number}","events_url":"https://api.github.com/repos/keep94/scotty/events","assignees_url":"https://api.github.com/repos/keep94/scotty/assignees{/user}","branches_url":"https://api.github.com/repos/keep94/scotty/branches{/branch}","tags_url":"https://api.github.com/repos/keep94/scotty/tags","blobs_url":"https://api.github.com/repos/keep94/scotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keep94/scotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keep94/scotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/keep94/scotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keep94/scotty/statuses/{sha}","languages_url":"https://api.github.com/repos/keep94/scotty/languages","stargazers_url":"https://api.github.com/repos/keep94/scotty/stargazers","contributors_url":"https://api.github.com/repos/keep94/scotty/contributors","subscribers_url":"https://api.github.com/repos/keep94/scotty/subscribers","subscription_url":"https://api.github.com/repos/keep94/scotty/subscription","commits_url":"https://api.github.com/repos/keep94/scotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/keep94/scotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/keep94/scotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/keep94/scotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/keep94/scotty/contents/{+path}","compare_url":"https://api.github.com/repos/keep94/scotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keep94/scotty/merges","archive_url":"https://api.github.com/repos/keep94/scotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keep94/scotty/downloads","issues_url":"https://api.github.com/repos/keep94/scotty/issues{/number}","pulls_url":"https://api.github.com/repos/keep94/scotty/pulls{/number}","milestones_url":"https://api.github.com/repos/keep94/scotty/milestones{/number}","notifications_url":"https://api.github.com/repos/keep94/scotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keep94/scotty/labels{/name}","releases_url":"https://api.github.com/repos/keep94/scotty/releases{/id}","deployments_url":"https://api.github.com/repos/keep94/scotty/deployments","created_at":"2016-01-21T01:12:00Z","updated_at":"2016-01-25T17:21:48Z","pushed_at":"2016-04-22T16:49:20Z","git_url":"git://github.com/keep94/scotty.git","ssh_url":"git@github.com:keep94/scotty.git","clone_url":"https://github.com/keep94/scotty.git","svn_url":"https://github.com/keep94/scotty","homepage":null,"size":261,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Symantec:master","ref":"master","sha":"ac063a55b73a566018062f23f0cc57ec53f3a243","user":{"login":"Symantec","id":7462319,"avatar_url":"https://avatars.githubusercontent.com/u/7462319?v=3","gravatar_id":"","url":"https://api.github.com/users/Symantec","html_url":"https://github.com/Symantec","followers_url":"https://api.github.com/users/Symantec/followers","following_url":"https://api.github.com/users/Symantec/following{/other_user}","gists_url":"https://api.github.com/users/Symantec/gists{/gist_id}","starred_url":"https://api.github.com/users/Symantec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Symantec/subscriptions","organizations_url":"https://api.github.com/users/Symantec/orgs","repos_url":"https://api.github.com/users/Symantec/repos","events_url":"https://api.github.com/users/Symantec/events{/privacy}","received_events_url":"https://api.github.com/users/Symantec/received_events","type":"Organization","site_admin":false},"repo":{"id":48025009,"name":"scotty","full_name":"Symantec/scotty","owner":{"login":"Symantec","id":7462319,"avatar_url":"https://avatars.githubusercontent.com/u/7462319?v=3","gravatar_id":"","url":"https://api.github.com/users/Symantec","html_url":"https://github.com/Symantec","followers_url":"https://api.github.com/users/Symantec/followers","following_url":"https://api.github.com/users/Symantec/following{/other_user}","gists_url":"https://api.github.com/users/Symantec/gists{/gist_id}","starred_url":"https://api.github.com/users/Symantec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Symantec/subscriptions","organizations_url":"https://api.github.com/users/Symantec/orgs","repos_url":"https://api.github.com/users/Symantec/repos","events_url":"https://api.github.com/users/Symantec/events{/privacy}","received_events_url":"https://api.github.com/users/Symantec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Symantec/scotty","description":"A highly scalable collector for tricorder applications","fork":false,"url":"https://api.github.com/repos/Symantec/scotty","forks_url":"https://api.github.com/repos/Symantec/scotty/forks","keys_url":"https://api.github.com/repos/Symantec/scotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Symantec/scotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Symantec/scotty/teams","hooks_url":"https://api.github.com/repos/Symantec/scotty/hooks","issue_events_url":"https://api.github.com/repos/Symantec/scotty/issues/events{/number}","events_url":"https://api.github.com/repos/Symantec/scotty/events","assignees_url":"https://api.github.com/repos/Symantec/scotty/assignees{/user}","branches_url":"https://api.github.com/repos/Symantec/scotty/branches{/branch}","tags_url":"https://api.github.com/repos/Symantec/scotty/tags","blobs_url":"https://api.github.com/repos/Symantec/scotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Symantec/scotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Symantec/scotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Symantec/scotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Symantec/scotty/statuses/{sha}","languages_url":"https://api.github.com/repos/Symantec/scotty/languages","stargazers_url":"https://api.github.com/repos/Symantec/scotty/stargazers","contributors_url":"https://api.github.com/repos/Symantec/scotty/contributors","subscribers_url":"https://api.github.com/repos/Symantec/scotty/subscribers","subscription_url":"https://api.github.com/repos/Symantec/scotty/subscription","commits_url":"https://api.github.com/repos/Symantec/scotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Symantec/scotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Symantec/scotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Symantec/scotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Symantec/scotty/contents/{+path}","compare_url":"https://api.github.com/repos/Symantec/scotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Symantec/scotty/merges","archive_url":"https://api.github.com/repos/Symantec/scotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Symantec/scotty/downloads","issues_url":"https://api.github.com/repos/Symantec/scotty/issues{/number}","pulls_url":"https://api.github.com/repos/Symantec/scotty/pulls{/number}","milestones_url":"https://api.github.com/repos/Symantec/scotty/milestones{/number}","notifications_url":"https://api.github.com/repos/Symantec/scotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Symantec/scotty/labels{/name}","releases_url":"https://api.github.com/repos/Symantec/scotty/releases{/id}","deployments_url":"https://api.github.com/repos/Symantec/scotty/deployments","created_at":"2015-12-15T06:48:52Z","updated_at":"2016-01-21T05:12:52Z","pushed_at":"2016-04-22T16:49:43Z","git_url":"git://github.com/Symantec/scotty.git","ssh_url":"git@github.com:Symantec/scotty.git","clone_url":"https://github.com/Symantec/scotty.git","svn_url":"https://github.com/Symantec/scotty","homepage":null,"size":249,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Symantec/scotty/pulls/51"},"html":{"href":"https://github.com/Symantec/scotty/pull/51"},"issue":{"href":"https://api.github.com/repos/Symantec/scotty/issues/51"},"comments":{"href":"https://api.github.com/repos/Symantec/scotty/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/Symantec/scotty/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/Symantec/scotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Symantec/scotty/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/Symantec/scotty/statuses/4bbff0e1806a654cfa1c3380775d6ddbbcbfd275"}}}}