{"action":"created","comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/64364147","id":64364147,"diff_hunk":"@@ -217,14 +217,14 @@ struct GSRegSIGBLID\n #define GSIMR\t\t((u32&)*(PS2MEM_GS+0x1010))\n #define GSSIGLBLID\t((GSRegSIGBLID&)*(PS2MEM_GS+0x1080))\n \n-enum GS_RegionMode\n+enum GS_VideoMode","path":"pcsx2/GS.h","position":5,"original_position":5,"commit_id":"d22af625fdc813f0fc368f48f4e504ec19a97567","original_commit_id":"28720ca59a3b2e246fce396bcd5f4046e6cfdc19","user":{"login":"gregory38","id":1569559,"avatar_url":"https://avatars.githubusercontent.com/u/1569559?v=3","gravatar_id":"","url":"https://api.github.com/users/gregory38","html_url":"https://github.com/gregory38","followers_url":"https://api.github.com/users/gregory38/followers","following_url":"https://api.github.com/users/gregory38/following{/other_user}","gists_url":"https://api.github.com/users/gregory38/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory38/subscriptions","organizations_url":"https://api.github.com/users/gregory38/orgs","repos_url":"https://api.github.com/users/gregory38/repos","events_url":"https://api.github.com/users/gregory38/events{/privacy}","received_events_url":"https://api.github.com/users/gregory38/received_events","type":"User","site_admin":false},"body":"Either you use c++11 enum class or you use a prefix on the enum as a pseudo scope.","created_at":"2016-05-24T10:12:06Z","updated_at":"2016-05-24T10:12:06Z","html_url":"https://github.com/PCSX2/pcsx2/pull/1368#discussion_r64364147","pull_request_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368","_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments/64364147"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1368#discussion_r64364147"},"pull_request":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368"}}},"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368","id":71167767,"html_url":"https://github.com/PCSX2/pcsx2/pull/1368","diff_url":"https://github.com/PCSX2/pcsx2/pull/1368.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1368.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1368","number":1368,"state":"open","locked":false,"title":"PCSX2-Counters: Some Changes to Video mode counter stuffs","user":{"login":"ssakash","id":8477408,"avatar_url":"https://avatars.githubusercontent.com/u/8477408?v=3","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"body":"**Summary of Changes**:\r\n\r\n* The detected values using the SMODE registers were for the video modes and not for the region of the game, changed the variable naming to video modes to prevent any confusions.\r\n\r\n* Fixed a bug where 1080I was reported as progressive. ( I need more tests from other games where 1080I mode was used, @FlatOutPS2 - could you give GT4 a test ? )\r\n\r\n* Future Change - I can only do it after #1234 is merged. **Don't merge yet**.","created_at":"2016-05-24T07:09:50Z","updated_at":"2016-05-24T10:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f09beaecb705ca0258926e8a9ae3f62ce75d631","assignee":{"login":"ramapcsx2","id":6278722,"avatar_url":"https://avatars.githubusercontent.com/u/6278722?v=3","gravatar_id":"","url":"https://api.github.com/users/ramapcsx2","html_url":"https://github.com/ramapcsx2","followers_url":"https://api.github.com/users/ramapcsx2/followers","following_url":"https://api.github.com/users/ramapcsx2/following{/other_user}","gists_url":"https://api.github.com/users/ramapcsx2/gists{/gist_id}","starred_url":"https://api.github.com/users/ramapcsx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramapcsx2/subscriptions","organizations_url":"https://api.github.com/users/ramapcsx2/orgs","repos_url":"https://api.github.com/users/ramapcsx2/repos","events_url":"https://api.github.com/users/ramapcsx2/events{/privacy}","received_events_url":"https://api.github.com/users/ramapcsx2/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1368/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/d22af625fdc813f0fc368f48f4e504ec19a97567","head":{"label":"PCSX2-Alpha:Counters","ref":"Counters","sha":"d22af625fdc813f0fc368f48f4e504ec19a97567","user":{"login":"PCSX2-Alpha","id":13759170,"avatar_url":"https://avatars.githubusercontent.com/u/13759170?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2-Alpha","html_url":"https://github.com/PCSX2-Alpha","followers_url":"https://api.github.com/users/PCSX2-Alpha/followers","following_url":"https://api.github.com/users/PCSX2-Alpha/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2-Alpha/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2-Alpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2-Alpha/subscriptions","organizations_url":"https://api.github.com/users/PCSX2-Alpha/orgs","repos_url":"https://api.github.com/users/PCSX2-Alpha/repos","events_url":"https://api.github.com/users/PCSX2-Alpha/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2-Alpha/received_events","type":"Organization","site_admin":false},"repo":{"id":40579679,"name":"pcsx2","full_name":"PCSX2-Alpha/pcsx2","owner":{"login":"PCSX2-Alpha","id":13759170,"avatar_url":"https://avatars.githubusercontent.com/u/13759170?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2-Alpha","html_url":"https://github.com/PCSX2-Alpha","followers_url":"https://api.github.com/users/PCSX2-Alpha/followers","following_url":"https://api.github.com/users/PCSX2-Alpha/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2-Alpha/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2-Alpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2-Alpha/subscriptions","organizations_url":"https://api.github.com/users/PCSX2-Alpha/orgs","repos_url":"https://api.github.com/users/PCSX2-Alpha/repos","events_url":"https://api.github.com/users/PCSX2-Alpha/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2-Alpha/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2-Alpha/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":true,"url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2","forks_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2-Alpha/pcsx2/deployments","created_at":"2015-08-12T04:09:58Z","updated_at":"2016-01-19T08:33:49Z","pushed_at":"2016-05-24T08:25:24Z","git_url":"git://github.com/PCSX2-Alpha/pcsx2.git","ssh_url":"git@github.com:PCSX2-Alpha/pcsx2.git","clone_url":"https://github.com/PCSX2-Alpha/pcsx2.git","svn_url":"https://github.com/PCSX2-Alpha/pcsx2","homepage":"http://pcsx2.net/","size":78468,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"68eb3774b9ab71c77d462d2143f707fef894d7e7","user":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"name":"pcsx2","full_name":"PCSX2/pcsx2","owner":{"login":"PCSX2","id":6278711,"avatar_url":"https://avatars.githubusercontent.com/u/6278711?v=3","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2/pcsx2/deployments","created_at":"2013-12-22T17:56:48Z","updated_at":"2016-05-24T08:57:14Z","pushed_at":"2016-05-24T08:32:15Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":92551,"stargazers_count":1243,"watchers_count":1243,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":294,"mirror_url":null,"open_issues_count":255,"forks":294,"open_issues":255,"watchers":1243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1368"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1368"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1368/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1368/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/d22af625fdc813f0fc368f48f4e504ec19a97567"}}}}
{"actor":{"display_login":"gregory38"}}