{"action":"created","issue":{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/35","repository_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats","labels_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/35/comments","events_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/35/events","html_url":"https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/35","id":148657234,"number":35,"title":"Energy true/estimated binning in \"aeff_2d\"","user":{"login":"TarekHC","id":7864276,"avatar_url":"https://avatars.githubusercontent.com/u/7864276?v=3","gravatar_id":"","url":"https://api.github.com/users/TarekHC","html_url":"https://github.com/TarekHC","followers_url":"https://api.github.com/users/TarekHC/followers","following_url":"https://api.github.com/users/TarekHC/following{/other_user}","gists_url":"https://api.github.com/users/TarekHC/gists{/gist_id}","starred_url":"https://api.github.com/users/TarekHC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TarekHC/subscriptions","organizations_url":"https://api.github.com/users/TarekHC/orgs","repos_url":"https://api.github.com/users/TarekHC/repos","events_url":"https://api.github.com/users/TarekHC/events{/privacy}","received_events_url":"https://api.github.com/users/TarekHC/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/labels/status:%20needs%20detailed%20proposal","name":"status: needs detailed proposal","color":"1d76db"},{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/labels/type:%20change%20request","name":"type: change request","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2016-04-15T13:10:31Z","updated_at":"2016-04-22T08:17:45Z","closed_at":null,"body":"Hi all, \r\n\r\nAren't we currently \"imposing\" effective area vs true energy to have the same binning as the effective area vs estimated energy? Isn't that completely misleading?\r\n\r\nI would propose to add another pair of columns defining the true energy binning (even if its identical). \r\n\r\nI edit it further: The energy column is always labelled as \"Energy axis\". I would propose to always specify to which energy we are referring to. Specially in the case of IRFs."},"comment":{"url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/comments/213319010","html_url":"https://github.com/open-gamma-ray-astro/gamma-astro-data-formats/issues/35#issuecomment-213319010","issue_url":"https://api.github.com/repos/open-gamma-ray-astro/gamma-astro-data-formats/issues/35","id":213319010,"user":{"login":"TarekHC","id":7864276,"avatar_url":"https://avatars.githubusercontent.com/u/7864276?v=3","gravatar_id":"","url":"https://api.github.com/users/TarekHC","html_url":"https://github.com/TarekHC","followers_url":"https://api.github.com/users/TarekHC/followers","following_url":"https://api.github.com/users/TarekHC/following{/other_user}","gists_url":"https://api.github.com/users/TarekHC/gists{/gist_id}","starred_url":"https://api.github.com/users/TarekHC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TarekHC/subscriptions","organizations_url":"https://api.github.com/users/TarekHC/orgs","repos_url":"https://api.github.com/users/TarekHC/repos","events_url":"https://api.github.com/users/TarekHC/events{/privacy}","received_events_url":"https://api.github.com/users/TarekHC/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T08:17:45Z","updated_at":"2016-04-22T08:17:45Z","body":">If would propose to use \"ERECO\" consistently for reconstructed energies. I don’t think that there is an OGIP standard for this (which is more focused on X-rays where this corresponds basically to detector channels).\r\n\r\nI agree. We should be consistent. That would require to change the energy naming also in the event lists.\r\n\r\n>I guess it would however also be good to change the EXTNAME and HDUCLASS2 (and CAL_CNAM) keywords to avoid any confusion. A suggestion would be: - EXTNAME: \"EFFECTIVE AREA (RECO)\" - HDUCLASS2: \"EFF_AREA_RECO\"\r\n\r\nYes, this should be required. If not, the FITS files would not be very comprehensible.\r\n\r\n>We also need to think about whether we actually want to change the name of the effective area columns (so far: \"EFFAREA\"). Since the meaning of the information does not change (both are effective area), I would in fact suggest to keep the column name.\r\n\r\nI agree.\r\n\r\n>So to summarize, my proposal would be to have for true energy: - EXTNAME: \"EFFECTIVE AREA\" - HDUCLASS2: \"EFF_AREA\" - ENERG_LO - ENERG_HI - THETA_LO - THETA_HI - EFFAREA \r\n>And for reconstructed energy: - EXTNAME: \"EFFECTIVE AREA (RECO)\" - HDUCLASS2: \"EFF_AREA_RECO\" - ERECO_LO - ERECO_HI - THETA_LO - THETA_HI - EFFAREA\r\n\r\nOk. For now, this could be a better option than current standard.\r\n\r\nAlthough I must say I don't like adding both effective areas. I would prefer all IRFs to be as a function of true energy. But if there is general agreement of also adding EFFAREA vs ERECO then I guess its fine.\r\n\r\nAs soon as I find some time, I will try to modify the text and do a pull request (if no one did it already).\r\n\r\n\r\n\r\n"}}