{"action":"created","issue":{"url":"https://api.github.com/repos/cisco/libsrtp/issues/200","repository_url":"https://api.github.com/repos/cisco/libsrtp","labels_url":"https://api.github.com/repos/cisco/libsrtp/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/cisco/libsrtp/issues/200/comments","events_url":"https://api.github.com/repos/cisco/libsrtp/issues/200/events","html_url":"https://github.com/cisco/libsrtp/issues/200","id":173837489,"number":200,"title":"libsrtp 2.0.0 no longer exposes [srtp_]crypto_kernel_replace_cipher_type","user":{"login":"JonathanLennox","id":4006649,"avatar_url":"https://avatars.githubusercontent.com/u/4006649?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanLennox","html_url":"https://github.com/JonathanLennox","followers_url":"https://api.github.com/users/JonathanLennox/followers","following_url":"https://api.github.com/users/JonathanLennox/following{/other_user}","gists_url":"https://api.github.com/users/JonathanLennox/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanLennox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanLennox/subscriptions","organizations_url":"https://api.github.com/users/JonathanLennox/orgs","repos_url":"https://api.github.com/users/JonathanLennox/repos","events_url":"https://api.github.com/users/JonathanLennox/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanLennox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-29T18:18:38Z","updated_at":"2016-08-30T20:46:11Z","closed_at":null,"body":"Rev a9ac898d removed the install of the crypto/include header files into the srtp install directory.\r\n\r\nA consequence of this is that [srtp_]crypto_kernel_replace_cipher_type is no longer exposed.  Our system uses this API to replace srtp's crypto implementation with our own, optimized one, so this is blocking us moving up to 2.0.0.\r\n\r\nAny thoughts on the best way to fix this?"},"comment":{"url":"https://api.github.com/repos/cisco/libsrtp/issues/comments/243575053","html_url":"https://github.com/cisco/libsrtp/issues/200#issuecomment-243575053","issue_url":"https://api.github.com/repos/cisco/libsrtp/issues/200","id":243575053,"user":{"login":"pabuhler","id":15016732,"avatar_url":"https://avatars.githubusercontent.com/u/15016732?v=3","gravatar_id":"","url":"https://api.github.com/users/pabuhler","html_url":"https://github.com/pabuhler","followers_url":"https://api.github.com/users/pabuhler/followers","following_url":"https://api.github.com/users/pabuhler/following{/other_user}","gists_url":"https://api.github.com/users/pabuhler/gists{/gist_id}","starred_url":"https://api.github.com/users/pabuhler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabuhler/subscriptions","organizations_url":"https://api.github.com/users/pabuhler/orgs","repos_url":"https://api.github.com/users/pabuhler/repos","events_url":"https://api.github.com/users/pabuhler/events{/privacy}","received_events_url":"https://api.github.com/users/pabuhler/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T20:46:11Z","updated_at":"2016-08-30T20:46:11Z","body":"It certainly looks like this API was meant to be \"public\" along with srtp_crypto_kernel_replace_auth_type.\r\nAlthough I don't know how much of the other functions in the file are meant to be accessed externally.\r\nI see the debug functions have wrappers in srtp.h\r\nWe definitely should expose the api again but maybe in a cleaner fashion?\r\nPerhaps in a sub include folder so it is clearly not part of srtp usage api or in a new include file specifically for this api.\r\nIdeally we should only expose what is needed for this api and not the entire krypto kernel but at this point not sure on the amount of work required and if it would be worth it.\r\n\r\nThis i guess should go in to master, what will be a 2.1.x release at some point.\r\n\r\nOther suggestion, will you work on this?"}}
{"actor":{"display_login":"pabuhler"}}