{"action":"created","comment":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments/82608688","pull_request_review_id":3503828,"id":82608688,"diff_hunk":"@@ -18,6 +18,6 @@ export class Service {\n         } else {\n             ret = \"TR__RESOURCE\";\n         }\n-        return amount !== 1 ? ret + \"_PLURAL\" : ret;\n+        return amount != 1 ? ret + \"_PLURAL\" : ret;","path":"src/adhocracy_frontend/adhocracy_frontend/static/js/Packages/Core/Names/Names.ts","position":5,"original_position":5,"commit_id":"83ffa7f8546ed6cc51a93fd5b9c06f36e96a76b2","original_commit_id":"58d29fd930cbc26a4ae8ece20b056acb49f34205","user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"body":"While this fixes the symptom, it also hides the underlying issue. My interpretation is the following:\r\n\r\n`amount`was not `1`, but `\"1\"`. This is because of chain of unexpected behavior:\r\n\r\n-  The backend returns all values as strings.\r\n-  The frontend converts the values automatically based on information from the meta API\r\n-  The meta API does not contains \"search\" fields, e.g. `SIPool.count`\r\n-  `SIPool.count` is used as `amount` in the listing\r\n\r\nSo the proper fix would be to convert the value to number in Listing.ts","created_at":"2016-10-10T13:57:56Z","updated_at":"2016-10-10T13:58:02Z","html_url":"https://github.com/liqd/adhocracy3/pull/2784#discussion_r82608688","pull_request_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784","_links":{"self":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments/82608688"},"html":{"href":"https://github.com/liqd/adhocracy3/pull/2784#discussion_r82608688"},"pull_request":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784"}}},"pull_request":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784","id":88660959,"html_url":"https://github.com/liqd/adhocracy3/pull/2784","diff_url":"https://github.com/liqd/adhocracy3/pull/2784.diff","patch_url":"https://github.com/liqd/adhocracy3/pull/2784.patch","issue_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2784","number":2784,"state":"open","locked":false,"title":"fix debate workbench","user":{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false},"body":"- there is now no empty resource dropdown in the process header (fixup of #2741) \r\n- the document listing counter now says \"1 resource\" (unfortunately, the linter complains about `!=`)\r\n- a button saying \"add document\" appears in the header (i.e. in the `processHeaderSlot`; sort-of continues #2143 and #2113).\r\n\r\nI tested `meinberlin`, `demo` and `euth`.","created_at":"2016-10-10T13:18:42Z","updated_at":"2016-10-10T13:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddd9e19d56aa7a24ae0f4b71f6131c03b7d7e1d4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784/commits","review_comments_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784/comments","review_comment_url":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2784/comments","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/83ffa7f8546ed6cc51a93fd5b9c06f36e96a76b2","head":{"label":"liqd:2016-10-js-fix-debate-wb","ref":"2016-10-js-fix-debate-wb","sha":"83ffa7f8546ed6cc51a93fd5b9c06f36e96a76b2","user":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"repo":{"id":22982974,"name":"adhocracy3","full_name":"liqd/adhocracy3","owner":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liqd/adhocracy3","description":"Adhocracy 3 with customizations for various projects","fork":false,"url":"https://api.github.com/repos/liqd/adhocracy3","forks_url":"https://api.github.com/repos/liqd/adhocracy3/forks","keys_url":"https://api.github.com/repos/liqd/adhocracy3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqd/adhocracy3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqd/adhocracy3/teams","hooks_url":"https://api.github.com/repos/liqd/adhocracy3/hooks","issue_events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/events{/number}","events_url":"https://api.github.com/repos/liqd/adhocracy3/events","assignees_url":"https://api.github.com/repos/liqd/adhocracy3/assignees{/user}","branches_url":"https://api.github.com/repos/liqd/adhocracy3/branches{/branch}","tags_url":"https://api.github.com/repos/liqd/adhocracy3/tags","blobs_url":"https://api.github.com/repos/liqd/adhocracy3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqd/adhocracy3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqd/adhocracy3/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqd/adhocracy3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/{sha}","languages_url":"https://api.github.com/repos/liqd/adhocracy3/languages","stargazers_url":"https://api.github.com/repos/liqd/adhocracy3/stargazers","contributors_url":"https://api.github.com/repos/liqd/adhocracy3/contributors","subscribers_url":"https://api.github.com/repos/liqd/adhocracy3/subscribers","subscription_url":"https://api.github.com/repos/liqd/adhocracy3/subscription","commits_url":"https://api.github.com/repos/liqd/adhocracy3/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqd/adhocracy3/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqd/adhocracy3/contents/{+path}","compare_url":"https://api.github.com/repos/liqd/adhocracy3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqd/adhocracy3/merges","archive_url":"https://api.github.com/repos/liqd/adhocracy3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqd/adhocracy3/downloads","issues_url":"https://api.github.com/repos/liqd/adhocracy3/issues{/number}","pulls_url":"https://api.github.com/repos/liqd/adhocracy3/pulls{/number}","milestones_url":"https://api.github.com/repos/liqd/adhocracy3/milestones{/number}","notifications_url":"https://api.github.com/repos/liqd/adhocracy3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqd/adhocracy3/labels{/name}","releases_url":"https://api.github.com/repos/liqd/adhocracy3/releases{/id}","deployments_url":"https://api.github.com/repos/liqd/adhocracy3/deployments","created_at":"2014-08-15T08:07:57Z","updated_at":"2016-10-07T18:50:59Z","pushed_at":"2016-10-10T13:42:09Z","git_url":"git://github.com/liqd/adhocracy3.git","ssh_url":"git@github.com:liqd/adhocracy3.git","clone_url":"https://github.com/liqd/adhocracy3.git","svn_url":"https://github.com/liqd/adhocracy3","homepage":"https://adhocracy3.readthedocs.io","size":27889,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":80,"forks":14,"open_issues":80,"watchers":47,"default_branch":"master"}},"base":{"label":"liqd:master","ref":"master","sha":"76b5ac4fec9e93fe8c9ce3384e6623df60655cf5","user":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"repo":{"id":22982974,"name":"adhocracy3","full_name":"liqd/adhocracy3","owner":{"login":"liqd","id":2312088,"avatar_url":"https://avatars.githubusercontent.com/u/2312088?v=3","gravatar_id":"","url":"https://api.github.com/users/liqd","html_url":"https://github.com/liqd","followers_url":"https://api.github.com/users/liqd/followers","following_url":"https://api.github.com/users/liqd/following{/other_user}","gists_url":"https://api.github.com/users/liqd/gists{/gist_id}","starred_url":"https://api.github.com/users/liqd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liqd/subscriptions","organizations_url":"https://api.github.com/users/liqd/orgs","repos_url":"https://api.github.com/users/liqd/repos","events_url":"https://api.github.com/users/liqd/events{/privacy}","received_events_url":"https://api.github.com/users/liqd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liqd/adhocracy3","description":"Adhocracy 3 with customizations for various projects","fork":false,"url":"https://api.github.com/repos/liqd/adhocracy3","forks_url":"https://api.github.com/repos/liqd/adhocracy3/forks","keys_url":"https://api.github.com/repos/liqd/adhocracy3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liqd/adhocracy3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liqd/adhocracy3/teams","hooks_url":"https://api.github.com/repos/liqd/adhocracy3/hooks","issue_events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/events{/number}","events_url":"https://api.github.com/repos/liqd/adhocracy3/events","assignees_url":"https://api.github.com/repos/liqd/adhocracy3/assignees{/user}","branches_url":"https://api.github.com/repos/liqd/adhocracy3/branches{/branch}","tags_url":"https://api.github.com/repos/liqd/adhocracy3/tags","blobs_url":"https://api.github.com/repos/liqd/adhocracy3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liqd/adhocracy3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liqd/adhocracy3/git/refs{/sha}","trees_url":"https://api.github.com/repos/liqd/adhocracy3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liqd/adhocracy3/statuses/{sha}","languages_url":"https://api.github.com/repos/liqd/adhocracy3/languages","stargazers_url":"https://api.github.com/repos/liqd/adhocracy3/stargazers","contributors_url":"https://api.github.com/repos/liqd/adhocracy3/contributors","subscribers_url":"https://api.github.com/repos/liqd/adhocracy3/subscribers","subscription_url":"https://api.github.com/repos/liqd/adhocracy3/subscription","commits_url":"https://api.github.com/repos/liqd/adhocracy3/commits{/sha}","git_commits_url":"https://api.github.com/repos/liqd/adhocracy3/git/commits{/sha}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/comments{/number}","issue_comment_url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments{/number}","contents_url":"https://api.github.com/repos/liqd/adhocracy3/contents/{+path}","compare_url":"https://api.github.com/repos/liqd/adhocracy3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liqd/adhocracy3/merges","archive_url":"https://api.github.com/repos/liqd/adhocracy3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liqd/adhocracy3/downloads","issues_url":"https://api.github.com/repos/liqd/adhocracy3/issues{/number}","pulls_url":"https://api.github.com/repos/liqd/adhocracy3/pulls{/number}","milestones_url":"https://api.github.com/repos/liqd/adhocracy3/milestones{/number}","notifications_url":"https://api.github.com/repos/liqd/adhocracy3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liqd/adhocracy3/labels{/name}","releases_url":"https://api.github.com/repos/liqd/adhocracy3/releases{/id}","deployments_url":"https://api.github.com/repos/liqd/adhocracy3/deployments","created_at":"2014-08-15T08:07:57Z","updated_at":"2016-10-07T18:50:59Z","pushed_at":"2016-10-10T13:42:09Z","git_url":"git://github.com/liqd/adhocracy3.git","ssh_url":"git@github.com:liqd/adhocracy3.git","clone_url":"https://github.com/liqd/adhocracy3.git","svn_url":"https://github.com/liqd/adhocracy3","homepage":"https://adhocracy3.readthedocs.io","size":27889,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":80,"forks":14,"open_issues":80,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784"},"html":{"href":"https://github.com/liqd/adhocracy3/pull/2784"},"issue":{"href":"https://api.github.com/repos/liqd/adhocracy3/issues/2784"},"comments":{"href":"https://api.github.com/repos/liqd/adhocracy3/issues/2784/comments"},"review_comments":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784/comments"},"review_comment":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liqd/adhocracy3/pulls/2784/commits"},"statuses":{"href":"https://api.github.com/repos/liqd/adhocracy3/statuses/83ffa7f8546ed6cc51a93fd5b9c06f36e96a76b2"}}}}
{"actor":{"display_login":"xi"}}