{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69042442","id":69042442,"diff_hunk":"@@ -319,19 +307,19 @@ type killCmd struct {\n }\n \n func (k *killCmd) Kill() error {\n-\tif k == nil {\n-\t\tglog.V(2).Infof(\"The killCmd is nil, nothing will be killed\")\n-\t\treturn nil\n-\t}\n+","path":"test/e2e_node/e2e_service.go","position":null,"original_position":90,"commit_id":"4ec2f63e41f838b35986d6b7a3b0d9cc958c231f","original_commit_id":"4bb370f95c25041bc3f0e402b0434be370ecdf0f","user":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars.githubusercontent.com/u/903617?v=3","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2016-06-29T22:48:15Z","updated_at":"2016-06-29T22:48:15Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28228#discussion_r69042442","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69042442"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28228#discussion_r69042442"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228","id":75685724,"html_url":"https://github.com/kubernetes/kubernetes/pull/28228","diff_url":"https://github.com/kubernetes/kubernetes/pull/28228.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28228.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28228","number":28228,"state":"open","locked":false,"title":"Use slices of items to clean up after tests","user":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars.githubusercontent.com/u/903617?v=3","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"body":"Fixes #27582.\r\n\r\nWe used to maintain a pointer variable for each process to kill after the\r\ntests finish. @lavalamp suggested using a slice instead, which is a much\r\ncleaner solution. This implements @lavalamp's suggestion and also extends\r\nthe idea to tracking directories that need to be removed after the tests finish.\r\n\r\nThis also means that we should no longer check for nil `killCmd`s inside\r\n`func (k *killCmd) Kill() error {...}` (see #27582 and #27589). If a nil\r\n`killCmd` makes it in there, something is bad elsewhere and we want to see\r\nthe nil pointer exception immediately.\r\n\r\nMentioning @timstclair and @euank wrt the original issue/PR. ","created_at":"2016-06-29T17:07:21Z","updated_at":"2016-06-29T22:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1710f55da2c7b32661253231a4ddecbe8db2358","assignee":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"assignees":[{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28228/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4ec2f63e41f838b35986d6b7a3b0d9cc958c231f","head":{"label":"mtaufen:e2e-killcmd-cleanup","ref":"e2e-killcmd-cleanup","sha":"4ec2f63e41f838b35986d6b7a3b0d9cc958c231f","user":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars.githubusercontent.com/u/903617?v=3","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"repo":{"id":58391682,"name":"kubernetes","full_name":"mtaufen/kubernetes","owner":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars.githubusercontent.com/u/903617?v=3","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtaufen/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/mtaufen/kubernetes","forks_url":"https://api.github.com/repos/mtaufen/kubernetes/forks","keys_url":"https://api.github.com/repos/mtaufen/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtaufen/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtaufen/kubernetes/teams","hooks_url":"https://api.github.com/repos/mtaufen/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mtaufen/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mtaufen/kubernetes/events","assignees_url":"https://api.github.com/repos/mtaufen/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mtaufen/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mtaufen/kubernetes/tags","blobs_url":"https://api.github.com/repos/mtaufen/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtaufen/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtaufen/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtaufen/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtaufen/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mtaufen/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mtaufen/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mtaufen/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mtaufen/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mtaufen/kubernetes/subscription","commits_url":"https://api.github.com/repos/mtaufen/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtaufen/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtaufen/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtaufen/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtaufen/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mtaufen/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtaufen/kubernetes/merges","archive_url":"https://api.github.com/repos/mtaufen/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtaufen/kubernetes/downloads","issues_url":"https://api.github.com/repos/mtaufen/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mtaufen/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mtaufen/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mtaufen/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtaufen/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mtaufen/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mtaufen/kubernetes/deployments","created_at":"2016-05-09T16:30:01Z","updated_at":"2016-05-09T16:30:16Z","pushed_at":"2016-06-29T22:47:46Z","git_url":"git://github.com/mtaufen/kubernetes.git","ssh_url":"git@github.com:mtaufen/kubernetes.git","clone_url":"https://github.com/mtaufen/kubernetes.git","svn_url":"https://github.com/mtaufen/kubernetes","homepage":"http://kubernetes.io","size":273361,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8621326a7a542605cb958a61c37b27fa80f6d12c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-29T21:41:53Z","pushed_at":"2016-06-29T22:47:48Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":483336,"stargazers_count":15156,"watchers_count":15156,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4736,"mirror_url":null,"open_issues_count":3763,"forks":4736,"open_issues":3763,"watchers":15156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28228"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28228"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28228/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28228/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4ec2f63e41f838b35986d6b7a3b0d9cc958c231f"}}}}
{"actor":{"display_login":"mtaufen"}}