{"action":"closed","number":1918,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/1918","id":71390360,"html_url":"https://github.com/brave/browser-laptop/pull/1918","diff_url":"https://github.com/brave/browser-laptop/pull/1918.diff","patch_url":"https://github.com/brave/browser-laptop/pull/1918.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/1918","number":1918,"state":"closed","locked":false,"title":"Add font-awesome folder icon for folders on bookmarks toolbar and menus","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Ran `git rebase -i` to squash commits if needed.\r\n\r\nFix #1469 \r\n\r\nImage 1:\r\n![](https://cloud.githubusercontent.com/assets/3362943/15540466/772d249c-22c2-11e6-96f6-ffc82ab029fd.jpg)\r\n\r\nPlease make sure that ``@bookmarksIconSize: 16px;`` is based on ``const iconSize = 16`` [(here)](https://github.com/luixxiul/browser-laptop/blob/b2c4775606a2384bdff7d80ddb7f58343c27f33b/js/components/bookmarksToolbar.js#L126).\r\n\r\nI like the white icon better than ``fa-folder``, which is a black icon.\r\nhttp://fontawesome.io/icon/folder/","created_at":"2016-05-25T13:25:11Z","updated_at":"2016-05-28T23:33:56Z","closed_at":"2016-05-28T23:33:56Z","merged_at":"2016-05-28T23:33:56Z","merge_commit_sha":"36743908d053c3b6219eaece553a023f9921dcef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/1918/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/1918/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/1918/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/90e8ba7feb7231aea9df8ec9307993b597636c01","head":{"label":"luixxiul:bookmarkicon","ref":"bookmarkicon","sha":"90e8ba7feb7231aea9df8ec9307993b597636c01","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"repo":{"id":59339519,"name":"browser-laptop","full_name":"luixxiul/browser-laptop","owner":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars.githubusercontent.com/u/3362943?v=3","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luixxiul/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/luixxiul/browser-laptop","forks_url":"https://api.github.com/repos/luixxiul/browser-laptop/forks","keys_url":"https://api.github.com/repos/luixxiul/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luixxiul/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luixxiul/browser-laptop/teams","hooks_url":"https://api.github.com/repos/luixxiul/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/luixxiul/browser-laptop/events","assignees_url":"https://api.github.com/repos/luixxiul/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/luixxiul/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/luixxiul/browser-laptop/tags","blobs_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luixxiul/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/luixxiul/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/luixxiul/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/luixxiul/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/luixxiul/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/luixxiul/browser-laptop/subscription","commits_url":"https://api.github.com/repos/luixxiul/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/luixxiul/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/luixxiul/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/luixxiul/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/luixxiul/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luixxiul/browser-laptop/merges","archive_url":"https://api.github.com/repos/luixxiul/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luixxiul/browser-laptop/downloads","issues_url":"https://api.github.com/repos/luixxiul/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/luixxiul/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/luixxiul/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/luixxiul/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luixxiul/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/luixxiul/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/luixxiul/browser-laptop/deployments","created_at":"2016-05-21T03:21:58Z","updated_at":"2016-05-21T03:22:00Z","pushed_at":"2016-05-28T18:32:49Z","git_url":"git://github.com/luixxiul/browser-laptop.git","ssh_url":"git@github.com:luixxiul/browser-laptop.git","clone_url":"https://github.com/luixxiul/browser-laptop.git","svn_url":"https://github.com/luixxiul/browser-laptop","homepage":"https://www.brave.com","size":13277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"a759247a0dc589a02d5543aa73dd845721dd9765","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-05-28T23:10:15Z","pushed_at":"2016-05-28T23:33:56Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":19190,"stargazers_count":2883,"watchers_count":2883,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"open_issues_count":530,"forks":307,"open_issues":530,"watchers":2883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/1918"},"html":{"href":"https://github.com/brave/browser-laptop/pull/1918"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/1918"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/1918/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/1918/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/1918/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/90e8ba7feb7231aea9df8ec9307993b597636c01"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"comments":5,"review_comments":6,"commits":1,"additions":26,"deletions":0,"changed_files":5}}
{"actor":{"display_login":"bsclifton"}}