{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/grid/pulls/comments/71302027","id":71302027,"diff_hunk":"@@ -20,11 +20,10 @@ trait PanDomainAuthActions extends AuthActions {\n   override def authCallbackUrl: String = s\"$authCallbackBaseUri/oauthCallback\"\n \n   override lazy val domain: String = properties(\"panda.domain\")\n-  lazy val awsKeyId                = properties(\"panda.aws.key\")\n-  lazy val awsSecretAccessKey      = properties(\"panda.aws.secret\")\n \n-  override def awsCredentialsProvider = new StaticCredentialsProvider(\n-    new BasicAWSCredentials(awsKeyId, awsSecretAccessKey)\n+  override def awsCredentialsProvider = new AWSCredentialsProviderChain(\n+    new ProfileCredentialsProvider(\"media-service\"),\n+    new InstanceProfileCredentialsProvider","path":"common-lib/src/main/scala/com/gu/mediaservice/lib/auth/Panda.scala","position":21,"original_position":21,"commit_id":"e3a6268456438eb8c39573299f97293e0d93829e","original_commit_id":"e3a6268456438eb8c39573299f97293e0d93829e","user":{"login":"philwills","id":68329,"avatar_url":"https://avatars.githubusercontent.com/u/68329?v=3","gravatar_id":"","url":"https://api.github.com/users/philwills","html_url":"https://github.com/philwills","followers_url":"https://api.github.com/users/philwills/followers","following_url":"https://api.github.com/users/philwills/following{/other_user}","gists_url":"https://api.github.com/users/philwills/gists{/gist_id}","starred_url":"https://api.github.com/users/philwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwills/subscriptions","organizations_url":"https://api.github.com/users/philwills/orgs","repos_url":"https://api.github.com/users/philwills/repos","events_url":"https://api.github.com/users/philwills/events{/privacy}","received_events_url":"https://api.github.com/users/philwills/received_events","type":"User","site_admin":false},"body":"It does in theory, but in practise you're unlikely to have both profile credentials and instance profile credentials.","created_at":"2016-07-19T09:29:54Z","updated_at":"2016-07-19T09:29:54Z","html_url":"https://github.com/guardian/grid/pull/1960#discussion_r71302027","pull_request_url":"https://api.github.com/repos/guardian/grid/pulls/1960","_links":{"self":{"href":"https://api.github.com/repos/guardian/grid/pulls/comments/71302027"},"html":{"href":"https://github.com/guardian/grid/pull/1960#discussion_r71302027"},"pull_request":{"href":"https://api.github.com/repos/guardian/grid/pulls/1960"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/grid/pulls/1960","id":77941308,"html_url":"https://github.com/guardian/grid/pull/1960","diff_url":"https://github.com/guardian/grid/pull/1960.diff","patch_url":"https://github.com/guardian/grid/pull/1960.patch","issue_url":"https://api.github.com/repos/guardian/grid/issues/1960","number":1960,"state":"open","locked":false,"title":"Use InstanceProfileCredentialsProvider where available.","user":{"login":"kenoir","id":953792,"avatar_url":"https://avatars.githubusercontent.com/u/953792?v=3","gravatar_id":"","url":"https://api.github.com/users/kenoir","html_url":"https://github.com/kenoir","followers_url":"https://api.github.com/users/kenoir/followers","following_url":"https://api.github.com/users/kenoir/following{/other_user}","gists_url":"https://api.github.com/users/kenoir/gists{/gist_id}","starred_url":"https://api.github.com/users/kenoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenoir/subscriptions","organizations_url":"https://api.github.com/users/kenoir/orgs","repos_url":"https://api.github.com/users/kenoir/repos","events_url":"https://api.github.com/users/kenoir/events{/privacy}","received_events_url":"https://api.github.com/users/kenoir/received_events","type":"User","site_admin":false},"body":"In order that we can remove hard coded pan-domain credentials from the instances.\r\n\r\nDepends on https://github.com/guardian/grid-infra/pull/263.","created_at":"2016-07-19T09:07:19Z","updated_at":"2016-07-19T09:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70dd103b102b48d725be8b4daa116664d73c95d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/grid/pulls/1960/commits","review_comments_url":"https://api.github.com/repos/guardian/grid/pulls/1960/comments","review_comment_url":"https://api.github.com/repos/guardian/grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/grid/issues/1960/comments","statuses_url":"https://api.github.com/repos/guardian/grid/statuses/e3a6268456438eb8c39573299f97293e0d93829e","head":{"label":"guardian:use-instance-role-panda","ref":"use-instance-role-panda","sha":"e3a6268456438eb8c39573299f97293e0d93829e","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":12298112,"name":"grid","full_name":"guardian/grid","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/grid","description":"The Guardian’s new image management system","fork":false,"url":"https://api.github.com/repos/guardian/grid","forks_url":"https://api.github.com/repos/guardian/grid/forks","keys_url":"https://api.github.com/repos/guardian/grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/grid/teams","hooks_url":"https://api.github.com/repos/guardian/grid/hooks","issue_events_url":"https://api.github.com/repos/guardian/grid/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/grid/events","assignees_url":"https://api.github.com/repos/guardian/grid/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/grid/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/grid/tags","blobs_url":"https://api.github.com/repos/guardian/grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/grid/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/grid/languages","stargazers_url":"https://api.github.com/repos/guardian/grid/stargazers","contributors_url":"https://api.github.com/repos/guardian/grid/contributors","subscribers_url":"https://api.github.com/repos/guardian/grid/subscribers","subscription_url":"https://api.github.com/repos/guardian/grid/subscription","commits_url":"https://api.github.com/repos/guardian/grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/grid/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/grid/merges","archive_url":"https://api.github.com/repos/guardian/grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/grid/downloads","issues_url":"https://api.github.com/repos/guardian/grid/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/grid/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/grid/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/grid/labels{/name}","releases_url":"https://api.github.com/repos/guardian/grid/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/grid/deployments","created_at":"2013-08-22T13:49:31Z","updated_at":"2016-07-19T00:18:28Z","pushed_at":"2016-07-19T09:07:19Z","git_url":"git://github.com/guardian/grid.git","ssh_url":"git@github.com:guardian/grid.git","clone_url":"https://github.com/guardian/grid.git","svn_url":"https://github.com/guardian/grid","homepage":"","size":15240,"stargazers_count":1114,"watchers_count":1114,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":63,"forks":63,"open_issues":63,"watchers":1114,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"160d1cf3146d1acbe200fd5362f1d4a5b90742db","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":12298112,"name":"grid","full_name":"guardian/grid","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/grid","description":"The Guardian’s new image management system","fork":false,"url":"https://api.github.com/repos/guardian/grid","forks_url":"https://api.github.com/repos/guardian/grid/forks","keys_url":"https://api.github.com/repos/guardian/grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/grid/teams","hooks_url":"https://api.github.com/repos/guardian/grid/hooks","issue_events_url":"https://api.github.com/repos/guardian/grid/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/grid/events","assignees_url":"https://api.github.com/repos/guardian/grid/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/grid/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/grid/tags","blobs_url":"https://api.github.com/repos/guardian/grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/grid/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/grid/languages","stargazers_url":"https://api.github.com/repos/guardian/grid/stargazers","contributors_url":"https://api.github.com/repos/guardian/grid/contributors","subscribers_url":"https://api.github.com/repos/guardian/grid/subscribers","subscription_url":"https://api.github.com/repos/guardian/grid/subscription","commits_url":"https://api.github.com/repos/guardian/grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/grid/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/grid/merges","archive_url":"https://api.github.com/repos/guardian/grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/grid/downloads","issues_url":"https://api.github.com/repos/guardian/grid/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/grid/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/grid/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/grid/labels{/name}","releases_url":"https://api.github.com/repos/guardian/grid/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/grid/deployments","created_at":"2013-08-22T13:49:31Z","updated_at":"2016-07-19T00:18:28Z","pushed_at":"2016-07-19T09:07:19Z","git_url":"git://github.com/guardian/grid.git","ssh_url":"git@github.com:guardian/grid.git","clone_url":"https://github.com/guardian/grid.git","svn_url":"https://github.com/guardian/grid","homepage":"","size":15240,"stargazers_count":1114,"watchers_count":1114,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":63,"forks":63,"open_issues":63,"watchers":1114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/grid/pulls/1960"},"html":{"href":"https://github.com/guardian/grid/pull/1960"},"issue":{"href":"https://api.github.com/repos/guardian/grid/issues/1960"},"comments":{"href":"https://api.github.com/repos/guardian/grid/issues/1960/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/grid/pulls/1960/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/grid/pulls/1960/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/grid/statuses/e3a6268456438eb8c39573299f97293e0d93829e"}}}}
{"actor":{"display_login":"philwills"}}