{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/57491312","id":57491312,"diff_hunk":"@@ -210,13 +210,25 @@ var _ = KubeDescribe(\"Addon update\", func() {\n \t\t// Reduce the addon update intervals so that we have faster response\n \t\t// to changes in the addon directory.\n \t\t// do not use \"service\" command because it clears the environment variables\n-\t\tsshExecAndVerify(sshClient, \"sudo TEST_ADDON_CHECK_INTERVAL_SEC=1 /etc/init.d/kube-addons restart\")\n+\t\tif testContext.OSDistro == \"debian\" {\n+\t\t\tsshExecAndVerify(sshClient, \"sudo TEST_ADDON_CHECK_INTERVAL_SEC=1 /etc/init.d/kube-addons restart\")\n+\t\t} else if testContext.OSDistro == \"trusty\" {\n+\t\t\tsshExecAndVerify(sshClient, \"sudo initctl restart kube-addons TEST_ADDON_CHECK_INTERVAL_SEC=1\")\n+\t\t} else {\n+\t\t\tFailf(\"Unsupported OS distro type %s\", testContext.OSDistro)","path":"test/e2e/addon_update.go","position":10,"original_position":10,"commit_id":"d89c3340198ae428991e2336b494a7df193add2f","original_commit_id":"d89c3340198ae428991e2336b494a7df193add2f","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"do we know what we should be using for coreos?","created_at":"2016-03-25T21:08:16Z","updated_at":"2016-03-25T21:08:16Z","html_url":"https://github.com/kubernetes/kubernetes/pull/23466#discussion_r57491312","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/57491312"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23466#discussion_r57491312"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466","id":64128423,"html_url":"https://github.com/kubernetes/kubernetes/pull/23466","diff_url":"https://github.com/kubernetes/kubernetes/pull/23466.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23466.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23466","number":23466,"state":"open","locked":false,"title":"Support differentiation of OS distro in e2e tests","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"body":"This change fixes issue #23221 by adding a flag \"os-distro\" in e2e testing framework. This flag inherits the value of env variable OS_DISTRIBUTION. The change also fixes the e2e test case of addon update for trusty by revising the testing code and kube-addons job in trusty master support.\r\n\r\nI verified it by running 'go run hack/e2e.go --v --test --test_args=\"--ginkgo.focus=should\\spropagate\\sadd-on\\sfile\\schanges\"'. Now this test case can pass on trusty.\r\n\r\n@ixdy @roberthbailey @dchen1107 please review this change.\r\n\r\ncc/ @wonderfly @fabioy FYI","created_at":"2016-03-25T03:44:28Z","updated_at":"2016-03-25T21:08:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ab14732a899027004b7ee507dbdd0484a72527e","assignee":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":848,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2016-03-25T20:37:10Z","due_on":"2016-03-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23466/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d89c3340198ae428991e2336b494a7df193add2f","head":{"label":"andyzheng0831:fix","ref":"fix","sha":"d89c3340198ae428991e2336b494a7df193add2f","user":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"repo":{"id":44209465,"name":"kubernetes","full_name":"andyzheng0831/kubernetes","owner":{"login":"andyzheng0831","id":8453435,"avatar_url":"https://avatars.githubusercontent.com/u/8453435?v=3","gravatar_id":"","url":"https://api.github.com/users/andyzheng0831","html_url":"https://github.com/andyzheng0831","followers_url":"https://api.github.com/users/andyzheng0831/followers","following_url":"https://api.github.com/users/andyzheng0831/following{/other_user}","gists_url":"https://api.github.com/users/andyzheng0831/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzheng0831/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzheng0831/subscriptions","organizations_url":"https://api.github.com/users/andyzheng0831/orgs","repos_url":"https://api.github.com/users/andyzheng0831/repos","events_url":"https://api.github.com/users/andyzheng0831/events{/privacy}","received_events_url":"https://api.github.com/users/andyzheng0831/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyzheng0831/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/andyzheng0831/kubernetes","forks_url":"https://api.github.com/repos/andyzheng0831/kubernetes/forks","keys_url":"https://api.github.com/repos/andyzheng0831/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyzheng0831/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyzheng0831/kubernetes/teams","hooks_url":"https://api.github.com/repos/andyzheng0831/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/andyzheng0831/kubernetes/events","assignees_url":"https://api.github.com/repos/andyzheng0831/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/andyzheng0831/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/andyzheng0831/kubernetes/tags","blobs_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyzheng0831/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/andyzheng0831/kubernetes/languages","stargazers_url":"https://api.github.com/repos/andyzheng0831/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/andyzheng0831/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/andyzheng0831/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/andyzheng0831/kubernetes/subscription","commits_url":"https://api.github.com/repos/andyzheng0831/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyzheng0831/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyzheng0831/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyzheng0831/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/andyzheng0831/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyzheng0831/kubernetes/merges","archive_url":"https://api.github.com/repos/andyzheng0831/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyzheng0831/kubernetes/downloads","issues_url":"https://api.github.com/repos/andyzheng0831/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/andyzheng0831/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/andyzheng0831/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/andyzheng0831/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyzheng0831/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/andyzheng0831/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/andyzheng0831/kubernetes/deployments","created_at":"2015-10-13T22:35:08Z","updated_at":"2016-01-30T17:40:02Z","pushed_at":"2016-03-25T05:02:56Z","git_url":"git://github.com/andyzheng0831/kubernetes.git","ssh_url":"git@github.com:andyzheng0831/kubernetes.git","clone_url":"https://github.com/andyzheng0831/kubernetes.git","svn_url":"https://github.com/andyzheng0831/kubernetes","homepage":"http://kubernetes.io","size":184183,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4e4ad61260e7708d15ce6d33647f1ef0a0a22929","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-03-25T18:49:00Z","pushed_at":"2016-03-25T20:49:50Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":346042,"stargazers_count":13504,"watchers_count":13504,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3921,"mirror_url":null,"open_issues_count":3117,"forks":3921,"open_issues":3117,"watchers":13504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23466"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23466"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23466/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23466/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d89c3340198ae428991e2336b494a7df193add2f"}}}}