{"action":"created","issue":{"url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/1019","repository_url":"https://api.github.com/repos/Cadasta/cadasta-platform","labels_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/1019/labels{/name}","comments_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/1019/comments","events_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/1019/events","html_url":"https://github.com/Cadasta/cadasta-platform/pull/1019","id":197176373,"number":1019,"title":"Fix #1018: Make project details editing work again","user":{"login":"seav","id":873653,"avatar_url":"https://avatars.githubusercontent.com/u/873653?v=3","gravatar_id":"","url":"https://api.github.com/users/seav","html_url":"https://github.com/seav","followers_url":"https://api.github.com/users/seav/followers","following_url":"https://api.github.com/users/seav/following{/other_user}","gists_url":"https://api.github.com/users/seav/gists{/gist_id}","starred_url":"https://api.github.com/users/seav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seav/subscriptions","organizations_url":"https://api.github.com/users/seav/orgs","repos_url":"https://api.github.com/users/seav/repos","events_url":"https://api.github.com/users/seav/events{/privacy}","received_events_url":"https://api.github.com/users/seav/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-22T13:38:32Z","updated_at":"2016-12-22T15:46:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Cadasta/cadasta-platform/pulls/1019","html_url":"https://github.com/Cadasta/cadasta-platform/pull/1019","diff_url":"https://github.com/Cadasta/cadasta-platform/pull/1019.diff","patch_url":"https://github.com/Cadasta/cadasta-platform/pull/1019.patch"},"body":"### Proposed changes in this pull request\r\n- Fix #1018:\r\n    - Corrected call to `super().post()`.\r\n    - Update unit tests. In particular, _test_post_with_blocked_questionnaire_upload_ should have resulted in a successful form submission. Also, `questionnaire` is removed from the default `post_data` in order to simulate the missing questionnaire fields in the template if the project has records.\r\n\r\n### When should this PR be merged\r\nSoon.\r\n\r\n### Risks\r\nNone foreseen.\r\n\r\n### Follow up actions\r\nNone.\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description. \r\n- [ ] **Is the PR labeled correctly?** It should have the `migration` label if a new migration is added. \r\n- [ ] **Is the risk level assessment sufficient?** The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts. \r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled. \r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests. \r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/). \r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components. \r\n- [ ] **If this is a bug fix, are tests for the issue in place**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the [Cadasta Platform Documentation](https://github.com/Cadasta/cadasta-docs).\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented in the [API docs](https://github.com/Cadasta/api-docs).\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki. \r\n"},"comment":{"url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/comments/268826784","html_url":"https://github.com/Cadasta/cadasta-platform/pull/1019#issuecomment-268826784","issue_url":"https://api.github.com/repos/Cadasta/cadasta-platform/issues/1019","id":268826784,"user":{"login":"oliverroick","id":159510,"avatar_url":"https://avatars.githubusercontent.com/u/159510?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverroick","html_url":"https://github.com/oliverroick","followers_url":"https://api.github.com/users/oliverroick/followers","following_url":"https://api.github.com/users/oliverroick/following{/other_user}","gists_url":"https://api.github.com/users/oliverroick/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverroick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverroick/subscriptions","organizations_url":"https://api.github.com/users/oliverroick/orgs","repos_url":"https://api.github.com/users/oliverroick/repos","events_url":"https://api.github.com/users/oliverroick/events{/privacy}","received_events_url":"https://api.github.com/users/oliverroick/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T15:46:45Z","updated_at":"2016-12-22T15:46:45Z","body":"I added necessary checks to the form also taking into account Eugene's remarks. Tests have both added to views and forms covering various scenarios. "}}
{"actor":{"display_login":"oliverroick"}}