{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/58280254","id":58280254,"diff_hunk":"@@ -188,4 +189,103 @@ class TopicCommandTest extends ZooKeeperTestHarness with Logging with RackAwareT\n     }\n     checkReplicaDistribution(assignment, rackInfo, rackInfo.size, alteredNumPartitions, replicationFactor)\n   }\n+\n+  def testDescribePartitions() {","path":"core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala","position":25,"original_position":25,"commit_id":"7cae009d17bfce1ea3e3127829c8fc75c9edee93","original_commit_id":"7cae009d17bfce1ea3e3127829c8fc75c9edee93","user":{"login":"gwenshap","id":1189030,"avatar_url":"https://avatars.githubusercontent.com/u/1189030?v=3","gravatar_id":"","url":"https://api.github.com/users/gwenshap","html_url":"https://github.com/gwenshap","followers_url":"https://api.github.com/users/gwenshap/followers","following_url":"https://api.github.com/users/gwenshap/following{/other_user}","gists_url":"https://api.github.com/users/gwenshap/gists{/gist_id}","starred_url":"https://api.github.com/users/gwenshap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwenshap/subscriptions","organizations_url":"https://api.github.com/users/gwenshap/orgs","repos_url":"https://api.github.com/users/gwenshap/repos","events_url":"https://api.github.com/users/gwenshap/events{/privacy}","received_events_url":"https://api.github.com/users/gwenshap/received_events","type":"User","site_admin":false},"body":"Thanks for the tests! They are obviously sensitive to any change in formatting.\r\n\r\nIs the intention to guarantee that the formatting will never change?","created_at":"2016-04-01T23:17:57Z","updated_at":"2016-04-01T23:17:57Z","html_url":"https://github.com/apache/kafka/pull/1014#discussion_r58280254","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1014","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/58280254"},"html":{"href":"https://github.com/apache/kafka/pull/1014#discussion_r58280254"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1014"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1014","id":61759852,"html_url":"https://github.com/apache/kafka/pull/1014","diff_url":"https://github.com/apache/kafka/pull/1014.diff","patch_url":"https://github.com/apache/kafka/pull/1014.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1014","number":1014,"state":"open","locked":false,"title":"KAFKA-3331: Refactor TopicCommand to make describeTopic testable and …","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"…add unit tests.","created_at":"2016-03-04T19:35:29Z","updated_at":"2016-04-01T23:17:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c94b5ef4c05aa25c890550d18aca84a46827e804","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1014/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1014/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1014/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/7cae009d17bfce1ea3e3127829c8fc75c9edee93","head":{"label":"SinghAsDev:KAFKA-3331","ref":"KAFKA-3331","sha":"7cae009d17bfce1ea3e3127829c8fc75c9edee93","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"repo":{"id":29443488,"name":"kafka","full_name":"SinghAsDev/kafka","owner":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SinghAsDev/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/SinghAsDev/kafka","forks_url":"https://api.github.com/repos/SinghAsDev/kafka/forks","keys_url":"https://api.github.com/repos/SinghAsDev/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SinghAsDev/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SinghAsDev/kafka/teams","hooks_url":"https://api.github.com/repos/SinghAsDev/kafka/hooks","issue_events_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/SinghAsDev/kafka/events","assignees_url":"https://api.github.com/repos/SinghAsDev/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/SinghAsDev/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/SinghAsDev/kafka/tags","blobs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SinghAsDev/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/SinghAsDev/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SinghAsDev/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/SinghAsDev/kafka/languages","stargazers_url":"https://api.github.com/repos/SinghAsDev/kafka/stargazers","contributors_url":"https://api.github.com/repos/SinghAsDev/kafka/contributors","subscribers_url":"https://api.github.com/repos/SinghAsDev/kafka/subscribers","subscription_url":"https://api.github.com/repos/SinghAsDev/kafka/subscription","commits_url":"https://api.github.com/repos/SinghAsDev/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/SinghAsDev/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/SinghAsDev/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/SinghAsDev/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/SinghAsDev/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SinghAsDev/kafka/merges","archive_url":"https://api.github.com/repos/SinghAsDev/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SinghAsDev/kafka/downloads","issues_url":"https://api.github.com/repos/SinghAsDev/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/SinghAsDev/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/SinghAsDev/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/SinghAsDev/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SinghAsDev/kafka/labels{/name}","releases_url":"https://api.github.com/repos/SinghAsDev/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/SinghAsDev/kafka/deployments","created_at":"2015-01-18T22:26:11Z","updated_at":"2015-01-18T22:26:13Z","pushed_at":"2016-03-31T18:28:55Z","git_url":"git://github.com/SinghAsDev/kafka.git","ssh_url":"git@github.com:SinghAsDev/kafka.git","clone_url":"https://github.com/SinghAsDev/kafka.git","svn_url":"https://github.com/SinghAsDev/kafka","homepage":null,"size":28822,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"623ab1e7c6497c000bc9c9978637f20542a3191c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-04-01T09:59:03Z","pushed_at":"2016-04-01T22:58:15Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":38574,"stargazers_count":2884,"watchers_count":2884,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1741,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":171,"forks":1741,"open_issues":171,"watchers":2884,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1014"},"html":{"href":"https://github.com/apache/kafka/pull/1014"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1014"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1014/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1014/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1014/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/7cae009d17bfce1ea3e3127829c8fc75c9edee93"}}}}