{"action":"created","issue":{"url":"https://api.github.com/repos/skeeto/emacsql/issues/19","repository_url":"https://api.github.com/repos/skeeto/emacsql","labels_url":"https://api.github.com/repos/skeeto/emacsql/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/skeeto/emacsql/issues/19/comments","events_url":"https://api.github.com/repos/skeeto/emacsql/issues/19/events","html_url":"https://github.com/skeeto/emacsql/pull/19","id":140157800,"number":19,"title":"Expand identifier vectors when passed as parameters (#7).","user":{"login":"tarsius","id":25046,"avatar_url":"https://avatars.githubusercontent.com/u/25046?v=3","gravatar_id":"","url":"https://api.github.com/users/tarsius","html_url":"https://github.com/tarsius","followers_url":"https://api.github.com/users/tarsius/followers","following_url":"https://api.github.com/users/tarsius/following{/other_user}","gists_url":"https://api.github.com/users/tarsius/gists{/gist_id}","starred_url":"https://api.github.com/users/tarsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarsius/subscriptions","organizations_url":"https://api.github.com/users/tarsius/orgs","repos_url":"https://api.github.com/users/tarsius/repos","events_url":"https://api.github.com/users/tarsius/events{/privacy}","received_events_url":"https://api.github.com/users/tarsius/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-11T11:15:23Z","updated_at":"2016-03-14T19:32:18Z","closed_at":"2016-03-14T19:26:46Z","pull_request":{"url":"https://api.github.com/repos/skeeto/emacsql/pulls/19","html_url":"https://github.com/skeeto/emacsql/pull/19","diff_url":"https://github.com/skeeto/emacsql/pull/19.diff","patch_url":"https://github.com/skeeto/emacsql/pull/19.patch"},"body":"Following up on #7:\r\n\r\nThis just implements what I originally asked for, support for `[:select $i1 ...] (vector 'foo 'bar)`. (With the exception, that it uses `$i` instead of `$v`, taking your explanations into account.\r\n\r\n> Also, if you really wanted it to be complete, [...]\r\n\r\nThis does not support expressions inside the identifiers. Doing that would mean that there would be a second \"prepare-time\" during \"format-time\". And that would require that parameters would be collected again, but currently there is no support for that, which probably is a good thing. So I use `mapconcat` instead of `emacsql--*combine` and `emacsql--*idents`.\r\n\r\nAnd I don't really see how `[:select $i1 ...] [(* a 2)]` would be better than just `[:select [(* a 2)] ...]`. If there are to be expressions here, then one would likely hard-code them anway or one would have to resort to manually constructing the vector and the contained expressions anyway.\r\n\r\nMaybe there's a use-case for preparing not only SQL but also some of the vectors among ARGS, but I don't see it right now. So for now I am keeping it simple."},"comment":{"url":"https://api.github.com/repos/skeeto/emacsql/issues/comments/196487780","html_url":"https://github.com/skeeto/emacsql/pull/19#issuecomment-196487780","issue_url":"https://api.github.com/repos/skeeto/emacsql/issues/19","id":196487780,"user":{"login":"skeeto","id":29988,"avatar_url":"https://avatars.githubusercontent.com/u/29988?v=3","gravatar_id":"","url":"https://api.github.com/users/skeeto","html_url":"https://github.com/skeeto","followers_url":"https://api.github.com/users/skeeto/followers","following_url":"https://api.github.com/users/skeeto/following{/other_user}","gists_url":"https://api.github.com/users/skeeto/gists{/gist_id}","starred_url":"https://api.github.com/users/skeeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeeto/subscriptions","organizations_url":"https://api.github.com/users/skeeto/orgs","repos_url":"https://api.github.com/users/skeeto/repos","events_url":"https://api.github.com/users/skeeto/events{/privacy}","received_events_url":"https://api.github.com/users/skeeto/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T19:32:18Z","updated_at":"2016-03-14T19:32:18Z","body":"> This does not support expressions inside the identifiers.\r\n\r\nI'd say because of this it's kind of a hack. But since dynamically selecting columns is itself a dirty hack, and this change doesn't hurt anything else, that's perfectly fine.\r\n\r\nThanks!"}}