{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/redding/romo/pulls/67","id":90878477,"html_url":"https://github.com/redding/romo/pull/67","diff_url":"https://github.com/redding/romo/pull/67.diff","patch_url":"https://github.com/redding/romo/pull/67.patch","issue_url":"https://api.github.com/repos/redding/romo/issues/67","number":67,"state":"closed","locked":false,"title":"tooltip: have tooltips intelligently choose top vs bottom pos","user":{"login":"kellyredding","id":82110,"avatar_url":"https://avatars.githubusercontent.com/u/82110?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyredding","html_url":"https://github.com/kellyredding","followers_url":"https://api.github.com/users/kellyredding/followers","following_url":"https://api.github.com/users/kellyredding/following{/other_user}","gists_url":"https://api.github.com/users/kellyredding/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyredding/subscriptions","organizations_url":"https://api.github.com/users/kellyredding/orgs","repos_url":"https://api.github.com/users/kellyredding/repos","events_url":"https://api.github.com/users/kellyredding/events{/privacy}","received_events_url":"https://api.github.com/users/kellyredding/received_events","type":"User","site_admin":false},"body":"This is similar behavior to the dropdowns.  If a tooltip is set\r\nto position top or bottom, it will first check to make sure there\r\nis enough room to position itself that way.  If not, it will\r\nswitch to the opposite pos as it is assumed there will be enough\r\nroom that way.\r\n\r\nThe only wrinkle that is different from dropdowns is the tooltip\r\narrow UI.  I had to unbind the CSS for positioning the arrow from\r\nthe element configured position setting.  It now needs to be based\r\non a specific arrow position setting we set on the popup once we\r\ndetermine the live position of the popup.\r\n\r\nThis only applies to top/bottom positioning.  We chose not to\r\nimplement auto left/right positioning as it comes up so less\r\nfrequently and can be designed around in almost all cases.  We\r\nmay choose to add it later as specific needs arise.  This all is\r\ntrue for dropdowns.\r\n\r\n@jcredding ready for review.","created_at":"2016-10-25T19:48:49Z","updated_at":"2016-10-25T20:01:58Z","closed_at":"2016-10-25T20:01:58Z","merged_at":"2016-10-25T20:01:58Z","merge_commit_sha":"f2f8afae53b52d3df59e8d623d3ef71efbe5c5c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/redding/romo/pulls/67/commits","review_comments_url":"https://api.github.com/repos/redding/romo/pulls/67/comments","review_comment_url":"https://api.github.com/repos/redding/romo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redding/romo/issues/67/comments","statuses_url":"https://api.github.com/repos/redding/romo/statuses/ea775f61f068beab697b53c958d9909a66d5c64a","head":{"label":"redding:kr-tooltip-decide-pos","ref":"kr-tooltip-decide-pos","sha":"ea775f61f068beab697b53c958d9909a66d5c64a","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":14547845,"name":"romo","full_name":"redding/romo","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/romo","description":"A UI Toolkit.","fork":false,"url":"https://api.github.com/repos/redding/romo","forks_url":"https://api.github.com/repos/redding/romo/forks","keys_url":"https://api.github.com/repos/redding/romo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/romo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/romo/teams","hooks_url":"https://api.github.com/repos/redding/romo/hooks","issue_events_url":"https://api.github.com/repos/redding/romo/issues/events{/number}","events_url":"https://api.github.com/repos/redding/romo/events","assignees_url":"https://api.github.com/repos/redding/romo/assignees{/user}","branches_url":"https://api.github.com/repos/redding/romo/branches{/branch}","tags_url":"https://api.github.com/repos/redding/romo/tags","blobs_url":"https://api.github.com/repos/redding/romo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/romo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/romo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/romo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/romo/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/romo/languages","stargazers_url":"https://api.github.com/repos/redding/romo/stargazers","contributors_url":"https://api.github.com/repos/redding/romo/contributors","subscribers_url":"https://api.github.com/repos/redding/romo/subscribers","subscription_url":"https://api.github.com/repos/redding/romo/subscription","commits_url":"https://api.github.com/repos/redding/romo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/romo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/romo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/romo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redding/romo/contents/{+path}","compare_url":"https://api.github.com/repos/redding/romo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/romo/merges","archive_url":"https://api.github.com/repos/redding/romo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/romo/downloads","issues_url":"https://api.github.com/repos/redding/romo/issues{/number}","pulls_url":"https://api.github.com/repos/redding/romo/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/romo/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/romo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/romo/labels{/name}","releases_url":"https://api.github.com/repos/redding/romo/releases{/id}","deployments_url":"https://api.github.com/repos/redding/romo/deployments","created_at":"2013-11-20T05:42:10Z","updated_at":"2016-01-11T17:28:29Z","pushed_at":"2016-10-25T20:01:58Z","git_url":"git://github.com/redding/romo.git","ssh_url":"git@github.com:redding/romo.git","clone_url":"https://github.com/redding/romo.git","svn_url":"https://github.com/redding/romo","homepage":"http://redding.github.io/romo/index.html","size":628,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"redding:master","ref":"master","sha":"0161e4fea79d9f047ee1394d53039ca69928dff4","user":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"repo":{"id":14547845,"name":"romo","full_name":"redding/romo","owner":{"login":"redding","id":2427810,"avatar_url":"https://avatars.githubusercontent.com/u/2427810?v=3","gravatar_id":"","url":"https://api.github.com/users/redding","html_url":"https://github.com/redding","followers_url":"https://api.github.com/users/redding/followers","following_url":"https://api.github.com/users/redding/following{/other_user}","gists_url":"https://api.github.com/users/redding/gists{/gist_id}","starred_url":"https://api.github.com/users/redding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redding/subscriptions","organizations_url":"https://api.github.com/users/redding/orgs","repos_url":"https://api.github.com/users/redding/repos","events_url":"https://api.github.com/users/redding/events{/privacy}","received_events_url":"https://api.github.com/users/redding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redding/romo","description":"A UI Toolkit.","fork":false,"url":"https://api.github.com/repos/redding/romo","forks_url":"https://api.github.com/repos/redding/romo/forks","keys_url":"https://api.github.com/repos/redding/romo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redding/romo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redding/romo/teams","hooks_url":"https://api.github.com/repos/redding/romo/hooks","issue_events_url":"https://api.github.com/repos/redding/romo/issues/events{/number}","events_url":"https://api.github.com/repos/redding/romo/events","assignees_url":"https://api.github.com/repos/redding/romo/assignees{/user}","branches_url":"https://api.github.com/repos/redding/romo/branches{/branch}","tags_url":"https://api.github.com/repos/redding/romo/tags","blobs_url":"https://api.github.com/repos/redding/romo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redding/romo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redding/romo/git/refs{/sha}","trees_url":"https://api.github.com/repos/redding/romo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redding/romo/statuses/{sha}","languages_url":"https://api.github.com/repos/redding/romo/languages","stargazers_url":"https://api.github.com/repos/redding/romo/stargazers","contributors_url":"https://api.github.com/repos/redding/romo/contributors","subscribers_url":"https://api.github.com/repos/redding/romo/subscribers","subscription_url":"https://api.github.com/repos/redding/romo/subscription","commits_url":"https://api.github.com/repos/redding/romo/commits{/sha}","git_commits_url":"https://api.github.com/repos/redding/romo/git/commits{/sha}","comments_url":"https://api.github.com/repos/redding/romo/comments{/number}","issue_comment_url":"https://api.github.com/repos/redding/romo/issues/comments{/number}","contents_url":"https://api.github.com/repos/redding/romo/contents/{+path}","compare_url":"https://api.github.com/repos/redding/romo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redding/romo/merges","archive_url":"https://api.github.com/repos/redding/romo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redding/romo/downloads","issues_url":"https://api.github.com/repos/redding/romo/issues{/number}","pulls_url":"https://api.github.com/repos/redding/romo/pulls{/number}","milestones_url":"https://api.github.com/repos/redding/romo/milestones{/number}","notifications_url":"https://api.github.com/repos/redding/romo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redding/romo/labels{/name}","releases_url":"https://api.github.com/repos/redding/romo/releases{/id}","deployments_url":"https://api.github.com/repos/redding/romo/deployments","created_at":"2013-11-20T05:42:10Z","updated_at":"2016-01-11T17:28:29Z","pushed_at":"2016-10-25T20:01:58Z","git_url":"git://github.com/redding/romo.git","ssh_url":"git@github.com:redding/romo.git","clone_url":"https://github.com/redding/romo.git","svn_url":"https://github.com/redding/romo","homepage":"http://redding.github.io/romo/index.html","size":628,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redding/romo/pulls/67"},"html":{"href":"https://github.com/redding/romo/pull/67"},"issue":{"href":"https://api.github.com/repos/redding/romo/issues/67"},"comments":{"href":"https://api.github.com/repos/redding/romo/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/redding/romo/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/redding/romo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redding/romo/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/redding/romo/statuses/ea775f61f068beab697b53c958d9909a66d5c64a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kellyredding","id":82110,"avatar_url":"https://avatars.githubusercontent.com/u/82110?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyredding","html_url":"https://github.com/kellyredding","followers_url":"https://api.github.com/users/kellyredding/followers","following_url":"https://api.github.com/users/kellyredding/following{/other_user}","gists_url":"https://api.github.com/users/kellyredding/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyredding/subscriptions","organizations_url":"https://api.github.com/users/kellyredding/orgs","repos_url":"https://api.github.com/users/kellyredding/repos","events_url":"https://api.github.com/users/kellyredding/events{/privacy}","received_events_url":"https://api.github.com/users/kellyredding/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":71,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"kellyredding"}}