{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/1022","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/1022/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1022/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/1022/events","html_url":"https://github.com/pmem/nvml/pull/1022","id":166841381,"number":1022,"title":"test: split tests into local and remote ones","user":{"login":"ldorau","id":8492895,"avatar_url":"https://avatars.githubusercontent.com/u/8492895?v=3","gravatar_id":"","url":"https://api.github.com/users/ldorau","html_url":"https://github.com/ldorau","followers_url":"https://api.github.com/users/ldorau/followers","following_url":"https://api.github.com/users/ldorau/following{/other_user}","gists_url":"https://api.github.com/users/ldorau/gists{/gist_id}","starred_url":"https://api.github.com/users/ldorau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldorau/subscriptions","organizations_url":"https://api.github.com/users/ldorau/orgs","repos_url":"https://api.github.com/users/ldorau/repos","events_url":"https://api.github.com/users/ldorau/events{/privacy}","received_events_url":"https://api.github.com/users/ldorau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-21T15:00:47Z","updated_at":"2016-07-21T16:14:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1022","html_url":"https://github.com/pmem/nvml/pull/1022","diff_url":"https://github.com/pmem/nvml/pull/1022.diff","patch_url":"https://github.com/pmem/nvml/pull/1022.patch"},"body":"The patch cleans up the main Makefile.\r\nIt splits tests into local and remote ones.\r\n\r\nThe 'obj_rpmem_basic_integration' unit test has not been run\r\nduring 'make pcheck' so far. The patch fixes this issue too.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1022)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/234304224","html_url":"https://github.com/pmem/nvml/pull/1022#issuecomment-234304224","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1022","id":234304224,"user":{"login":"marcinslusarz","id":12811376,"avatar_url":"https://avatars.githubusercontent.com/u/12811376?v=3","gravatar_id":"","url":"https://api.github.com/users/marcinslusarz","html_url":"https://github.com/marcinslusarz","followers_url":"https://api.github.com/users/marcinslusarz/followers","following_url":"https://api.github.com/users/marcinslusarz/following{/other_user}","gists_url":"https://api.github.com/users/marcinslusarz/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinslusarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinslusarz/subscriptions","organizations_url":"https://api.github.com/users/marcinslusarz/orgs","repos_url":"https://api.github.com/users/marcinslusarz/repos","events_url":"https://api.github.com/users/marcinslusarz/events{/privacy}","received_events_url":"https://api.github.com/users/marcinslusarz/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T16:14:31Z","updated_at":"2016-07-21T16:14:31Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[src/test/Makefile, line 389 \\[r1\\]](https://reviewable.io:443/reviews/pmem/nvml/1022#-KNDCr7LzOpWX3cC_X3u:-KNDCr7M8QXtT4At0xxd:657595213) ([raw file](https://github.com/pmem/nvml/blob/e09114dcfaee9a5a7fad4aeb07c3b4b1ae904099/src/test/Makefile#L389)):*\n> ```Makefile\n> pcheck_remote: TARGET = pcheck\n> pcheck_remote: $(REMOTE_TESTS)\n> \t@echo \"No failures.\"\n> ```\n\nI think we should also have \"pcheck_local\" target.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/1022)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"marcinslusarz"}}