{"action":"created","issue":{"url":"https://api.github.com/repos/friendica/friendica/issues/2979","repository_url":"https://api.github.com/repos/friendica/friendica","labels_url":"https://api.github.com/repos/friendica/friendica/issues/2979/labels{/name}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/2979/comments","events_url":"https://api.github.com/repos/friendica/friendica/issues/2979/events","html_url":"https://github.com/friendica/friendica/pull/2979","id":192131766,"number":2979,"title":"Issue 2772: Pending contacts should now be displayed","user":{"login":"annando","id":844208,"avatar_url":"https://avatars.githubusercontent.com/u/844208?v=3","gravatar_id":"","url":"https://api.github.com/users/annando","html_url":"https://github.com/annando","followers_url":"https://api.github.com/users/annando/followers","following_url":"https://api.github.com/users/annando/following{/other_user}","gists_url":"https://api.github.com/users/annando/gists{/gist_id}","starred_url":"https://api.github.com/users/annando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annando/subscriptions","organizations_url":"https://api.github.com/users/annando/orgs","repos_url":"https://api.github.com/users/annando/repos","events_url":"https://api.github.com/users/annando/events{/privacy}","received_events_url":"https://api.github.com/users/annando/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-28T22:14:13Z","updated_at":"2016-11-29T13:58:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/2979","html_url":"https://github.com/friendica/friendica/pull/2979","diff_url":"https://github.com/friendica/friendica/pull/2979.diff","patch_url":"https://github.com/friendica/friendica/pull/2979.patch"},"body":"See issue https://github.com/friendica/friendica/issues/2772"},"comment":{"url":"https://api.github.com/repos/friendica/friendica/issues/comments/263576491","html_url":"https://github.com/friendica/friendica/pull/2979#issuecomment-263576491","issue_url":"https://api.github.com/repos/friendica/friendica/issues/2979","id":263576491,"user":{"login":"rabuzarus","id":3750381,"avatar_url":"https://avatars.githubusercontent.com/u/3750381?v=3","gravatar_id":"","url":"https://api.github.com/users/rabuzarus","html_url":"https://github.com/rabuzarus","followers_url":"https://api.github.com/users/rabuzarus/followers","following_url":"https://api.github.com/users/rabuzarus/following{/other_user}","gists_url":"https://api.github.com/users/rabuzarus/gists{/gist_id}","starred_url":"https://api.github.com/users/rabuzarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabuzarus/subscriptions","organizations_url":"https://api.github.com/users/rabuzarus/orgs","repos_url":"https://api.github.com/users/rabuzarus/repos","events_url":"https://api.github.com/users/rabuzarus/events{/privacy}","received_events_url":"https://api.github.com/users/rabuzarus/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T13:58:04Z","updated_at":"2016-11-29T13:58:04Z","body":"Sry @annando I have some more questions. But it's better to ask now.\r\n\r\nYou know I'm not very familiar with the protocol stuff. So maybe I'm totally wrong. But should we generate a atom feed (in `public static function feed()`) for pending contacts? What would it change? Can this introduce privacy issues?\r\n\r\nIn the api you changed code e.g. in `function api_get_user()` I don't use the api so I don't have any knowledge of the intended behavior. But the variable for the query is `$countfriends` but a pending contact isn't a friend at this time. At this place it doesn't matter because this code part is commented out. But it will maybe the input of a rewrite to enable this code part again.\r\n\r\nBut what I wan't to say is. Since I'm not that familiar with some of the code parts can you please double check (if it does make sense at this point and if we won't leak unnecessary or false infos) if we need to include the pending contacts in all of the changed queries .\r\n\r\nIf you give me your OK after checking I will merge it\r\n"}}
{"actor":{"display_login":"rabuzarus"}}