{"action":"created","comment":{"url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/comments/77081688","id":77081688,"diff_hunk":"@@ -154,27 +154,39 @@ Assembly[] LoadConfigurationAssemblies()\n                 }\n             }\n \n-            foreach (var library in _dependencyContext.RuntimeLibraries)\n+            foreach (var assemblyName in GetSerilogConfigurationAssemblies())\n             {\n-                if (library.Name != null && library.Name.ToLowerInvariant().Contains(\"serilog\"))\n-                {\n-                    var assumedName = new AssemblyName(library.Name);\n-                    var assumed = Assembly.Load(assumedName);\n-                    if (assumed != null && !assemblies.ContainsKey(assumed.FullName))\n-                        assemblies.Add(assumed.FullName, assumed);\n-\n-                    foreach (var assemblyRef in library.Assemblies)\n-                    {\n-                        var assembly = Assembly.Load(assemblyRef.Name);\n-                        if (assembly != null && !assemblies.ContainsKey(assembly.FullName))\n-                            assemblies.Add(assembly.FullName, assembly);\n-                    }\n-                }\n+                var assumedName = new AssemblyName(assemblyName);\n+                var assumed = Assembly.Load(assumedName);\n+                if (assumed != null && !assemblies.ContainsKey(assumed.FullName))\n+                    assemblies.Add(assumed.FullName, assumed);\n             }\n \n             return assemblies.Values.ToArray();\n         }\n \n+        string[] GetSerilogConfigurationAssemblies()\n+        {\n+            var query = Enumerable.Empty<string>();\n+            var filter = new Func<string, bool>(name => name != null && name.ToLowerInvariant().Contains(\"serilog\"));\n+\n+            if (_dependencyContext != null)\n+            {\n+                query = from lib in _dependencyContext.RuntimeLibraries where filter(lib.Name) select lib.Name;\n+            }\n+            else\n+            {\n+#if APPDOMAIN\n+                query = from outputAssemblyPath in System.IO.Directory.GetFiles(AppDomain.CurrentDomain.BaseDirectory, \"*.dll\", System.IO.SearchOption.AllDirectories)","path":"src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs","position":51,"original_position":51,"commit_id":"167fdd8d6379b03b49679b895614d7777948717e","original_commit_id":"167fdd8d6379b03b49679b895614d7777948717e","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"body":"`SearchOption.AllDirectories` might cause problems for apps that keep plug-ins in subfolders - often these contain distinct sets of assemblies that are loaded into different appdomains, meaning we could find multiple versions of DLLs of interest if this is specified.","created_at":"2016-08-31T21:59:14Z","updated_at":"2016-08-31T21:59:14Z","html_url":"https://github.com/serilog/serilog-settings-configuration/pull/22#discussion_r77081688","pull_request_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/comments/77081688"},"html":{"href":"https://github.com/serilog/serilog-settings-configuration/pull/22#discussion_r77081688"},"pull_request":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22","id":83435225,"html_url":"https://github.com/serilog/serilog-settings-configuration/pull/22","diff_url":"https://github.com/serilog/serilog-settings-configuration/pull/22.diff","patch_url":"https://github.com/serilog/serilog-settings-configuration/pull/22.patch","issue_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/22","number":22,"state":"open","locked":false,"title":"Support MSBuild (non-project.json) projects","user":{"login":"skomis-mm","id":15090984,"avatar_url":"https://avatars.githubusercontent.com/u/15090984?v=3","gravatar_id":"","url":"https://api.github.com/users/skomis-mm","html_url":"https://github.com/skomis-mm","followers_url":"https://api.github.com/users/skomis-mm/followers","following_url":"https://api.github.com/users/skomis-mm/following{/other_user}","gists_url":"https://api.github.com/users/skomis-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/skomis-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomis-mm/subscriptions","organizations_url":"https://api.github.com/users/skomis-mm/orgs","repos_url":"https://api.github.com/users/skomis-mm/repos","events_url":"https://api.github.com/users/skomis-mm/events{/privacy}","received_events_url":"https://api.github.com/users/skomis-mm/received_events","type":"User","site_admin":false},"body":"fixes [this](https://github.com/serilog/serilog-settings-configuration/issues/20)","created_at":"2016-08-31T11:32:06Z","updated_at":"2016-08-31T21:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"528e38f94d68d44e53862f87e76c4bd98b2f1fbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/22/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/statuses/167fdd8d6379b03b49679b895614d7777948717e","head":{"label":"skomis-mm:serilog-dev","ref":"serilog-dev","sha":"167fdd8d6379b03b49679b895614d7777948717e","user":{"login":"skomis-mm","id":15090984,"avatar_url":"https://avatars.githubusercontent.com/u/15090984?v=3","gravatar_id":"","url":"https://api.github.com/users/skomis-mm","html_url":"https://github.com/skomis-mm","followers_url":"https://api.github.com/users/skomis-mm/followers","following_url":"https://api.github.com/users/skomis-mm/following{/other_user}","gists_url":"https://api.github.com/users/skomis-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/skomis-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomis-mm/subscriptions","organizations_url":"https://api.github.com/users/skomis-mm/orgs","repos_url":"https://api.github.com/users/skomis-mm/repos","events_url":"https://api.github.com/users/skomis-mm/events{/privacy}","received_events_url":"https://api.github.com/users/skomis-mm/received_events","type":"User","site_admin":false},"repo":{"id":60164558,"name":"serilog-settings-configuration","full_name":"skomis-mm/serilog-settings-configuration","owner":{"login":"skomis-mm","id":15090984,"avatar_url":"https://avatars.githubusercontent.com/u/15090984?v=3","gravatar_id":"","url":"https://api.github.com/users/skomis-mm","html_url":"https://github.com/skomis-mm","followers_url":"https://api.github.com/users/skomis-mm/followers","following_url":"https://api.github.com/users/skomis-mm/following{/other_user}","gists_url":"https://api.github.com/users/skomis-mm/gists{/gist_id}","starred_url":"https://api.github.com/users/skomis-mm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomis-mm/subscriptions","organizations_url":"https://api.github.com/users/skomis-mm/orgs","repos_url":"https://api.github.com/users/skomis-mm/repos","events_url":"https://api.github.com/users/skomis-mm/events{/privacy}","received_events_url":"https://api.github.com/users/skomis-mm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skomis-mm/serilog-settings-configuration","description":"A Serilog configuration provider that reads from Microsoft.Extensions.Configuration","fork":true,"url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration","forks_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/forks","keys_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/teams","hooks_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/hooks","issue_events_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/issues/events{/number}","events_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/events","assignees_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/assignees{/user}","branches_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/branches{/branch}","tags_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/tags","blobs_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/languages","stargazers_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/stargazers","contributors_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/contributors","subscribers_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/subscribers","subscription_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/subscription","commits_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/contents/{+path}","compare_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/merges","archive_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/downloads","issues_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/issues{/number}","pulls_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/labels{/name}","releases_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/releases{/id}","deployments_url":"https://api.github.com/repos/skomis-mm/serilog-settings-configuration/deployments","created_at":"2016-06-01T09:40:35Z","updated_at":"2016-06-01T09:40:35Z","pushed_at":"2016-08-31T17:40:12Z","git_url":"git://github.com/skomis-mm/serilog-settings-configuration.git","ssh_url":"git@github.com:skomis-mm/serilog-settings-configuration.git","clone_url":"https://github.com/skomis-mm/serilog-settings-configuration.git","svn_url":"https://github.com/skomis-mm/serilog-settings-configuration","homepage":"","size":287,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serilog:dev","ref":"dev","sha":"c89fcc050719246649623588fd2991f9869eb76e","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":37307621,"name":"serilog-settings-configuration","full_name":"serilog/serilog-settings-configuration","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-settings-configuration","description":"A Serilog configuration provider that reads from Microsoft.Extensions.Configuration","fork":false,"url":"https://api.github.com/repos/serilog/serilog-settings-configuration","forks_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/forks","keys_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/events","assignees_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/merges","archive_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog-settings-configuration/deployments","created_at":"2015-06-12T07:12:16Z","updated_at":"2016-06-29T08:37:13Z","pushed_at":"2016-08-31T11:32:06Z","git_url":"git://github.com/serilog/serilog-settings-configuration.git","ssh_url":"git@github.com:serilog/serilog-settings-configuration.git","clone_url":"https://github.com/serilog/serilog-settings-configuration.git","svn_url":"https://github.com/serilog/serilog-settings-configuration","homepage":"","size":278,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":5,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22"},"html":{"href":"https://github.com/serilog/serilog-settings-configuration/pull/22"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/22"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-settings-configuration/statuses/167fdd8d6379b03b49679b895614d7777948717e"}}}}
{"actor":{"display_login":"nblumhardt"}}