{"action":"created","comment":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/comments/73936482","id":73936482,"diff_hunk":"@@ -61,6 +61,25 @@\n \n     //checked state is set by the theme\n   }\n+\n+  // temporary placeholder loading button style\n+  &.loading {\n+    position: relative;\n+\n+    &::after {\n+      content: 'Loading...';\n+      position: absolute;\n+      background-color: rgba(0,0,0,0.6); // use variablized color when refactoring\n+      color: white; // use variablized color when refactoring\n+      text-align: center;\n+      top: 0;\n+      left: 0;\n+      right: 0;\n+      bottom: 0;\n+      font-size: 14px;\n+      cursor: default;","path":"styles/components/_buttons.scss","position":20,"original_position":20,"commit_id":"c3846cc820df1ada23cd5052aff6f377915dd052","original_commit_id":"c3846cc820df1ada23cd5052aff6f377915dd052","user":{"login":"jjeffryes","id":1584275,"avatar_url":"https://avatars.githubusercontent.com/u/1584275?v=3","gravatar_id":"","url":"https://api.github.com/users/jjeffryes","html_url":"https://github.com/jjeffryes","followers_url":"https://api.github.com/users/jjeffryes/followers","following_url":"https://api.github.com/users/jjeffryes/following{/other_user}","gists_url":"https://api.github.com/users/jjeffryes/gists{/gist_id}","starred_url":"https://api.github.com/users/jjeffryes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjeffryes/subscriptions","organizations_url":"https://api.github.com/users/jjeffryes/orgs","repos_url":"https://api.github.com/users/jjeffryes/repos","events_url":"https://api.github.com/users/jjeffryes/events{/privacy}","received_events_url":"https://api.github.com/users/jjeffryes/received_events","type":"User","site_admin":false},"body":"Yup. Border-radius doesn't normally inherit, but if you put border-radius: inherit on the after selector the injected content will inherit it from the wrapping parent element.","created_at":"2016-08-08T19:17:52Z","updated_at":"2016-08-08T19:17:52Z","html_url":"https://github.com/OpenBazaar/openbazaar-desktop/pull/25#discussion_r73936482","pull_request_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/comments/73936482"},"html":{"href":"https://github.com/OpenBazaar/openbazaar-desktop/pull/25#discussion_r73936482"},"pull_request":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25","id":80321901,"html_url":"https://github.com/OpenBazaar/openbazaar-desktop/pull/25","diff_url":"https://github.com/OpenBazaar/openbazaar-desktop/pull/25.diff","patch_url":"https://github.com/OpenBazaar/openbazaar-desktop/pull/25.patch","issue_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/25","number":25,"state":"open","locked":false,"title":"Save settings","user":{"login":"rmisio","id":794517,"avatar_url":"https://avatars.githubusercontent.com/u/794517?v=3","gravatar_id":"","url":"https://api.github.com/users/rmisio","html_url":"https://github.com/rmisio","followers_url":"https://api.github.com/users/rmisio/followers","following_url":"https://api.github.com/users/rmisio/following{/other_user}","gists_url":"https://api.github.com/users/rmisio/gists{/gist_id}","starred_url":"https://api.github.com/users/rmisio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmisio/subscriptions","organizations_url":"https://api.github.com/users/rmisio/orgs","repos_url":"https://api.github.com/users/rmisio/repos","events_url":"https://api.github.com/users/rmisio/events{/privacy}","received_events_url":"https://api.github.com/users/rmisio/received_events","type":"User","site_admin":false},"body":"This PR brings in the functionality to save the Settings > General and Settings > Page tabs to their respective APIs. It also brings in the currency, language and country reference data modules.\r\n\r\nTo see some client validation in action, set the Page tab website field to an invalid url or the email field to an invalid email.\r\n\r\nTo see the 'close modal at own risk' warning if closing while a save is in progress, you're probably going to need to throttle your network speed (in the Network tab).","created_at":"2016-08-05T23:54:02Z","updated_at":"2016-08-08T19:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c75139c34469141c8a00d7eaa37a20f54024b613","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25/commits","review_comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25/comments","review_comment_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/25/comments","statuses_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/statuses/c3846cc820df1ada23cd5052aff6f377915dd052","head":{"label":"OpenBazaar:save-settings","ref":"save-settings","sha":"c3846cc820df1ada23cd5052aff6f377915dd052","user":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":61640921,"name":"openbazaar-desktop","full_name":"OpenBazaar/openbazaar-desktop","owner":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenBazaar/openbazaar-desktop","description":"2.0 Desktop Client for OpenBazaar (talks to openbazaar-go server daemon)","fork":false,"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop","forks_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/forks","keys_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/teams","hooks_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/hooks","issue_events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/events","assignees_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/tags","blobs_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/languages","stargazers_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/stargazers","contributors_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/contributors","subscribers_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/subscribers","subscription_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/subscription","commits_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/merges","archive_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/downloads","issues_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/labels{/name}","releases_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/deployments","created_at":"2016-06-21T14:34:19Z","updated_at":"2016-08-04T10:59:42Z","pushed_at":"2016-08-05T23:54:03Z","git_url":"git://github.com/OpenBazaar/openbazaar-desktop.git","ssh_url":"git@github.com:OpenBazaar/openbazaar-desktop.git","clone_url":"https://github.com/OpenBazaar/openbazaar-desktop.git","svn_url":"https://github.com/OpenBazaar/openbazaar-desktop","homepage":null,"size":362,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":11,"default_branch":"master"}},"base":{"label":"OpenBazaar:master","ref":"master","sha":"575da1d3a7471458823ddb597fb9b6686c63ceb9","user":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"repo":{"id":61640921,"name":"openbazaar-desktop","full_name":"OpenBazaar/openbazaar-desktop","owner":{"login":"OpenBazaar","id":7438770,"avatar_url":"https://avatars.githubusercontent.com/u/7438770?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenBazaar","html_url":"https://github.com/OpenBazaar","followers_url":"https://api.github.com/users/OpenBazaar/followers","following_url":"https://api.github.com/users/OpenBazaar/following{/other_user}","gists_url":"https://api.github.com/users/OpenBazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenBazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenBazaar/subscriptions","organizations_url":"https://api.github.com/users/OpenBazaar/orgs","repos_url":"https://api.github.com/users/OpenBazaar/repos","events_url":"https://api.github.com/users/OpenBazaar/events{/privacy}","received_events_url":"https://api.github.com/users/OpenBazaar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenBazaar/openbazaar-desktop","description":"2.0 Desktop Client for OpenBazaar (talks to openbazaar-go server daemon)","fork":false,"url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop","forks_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/forks","keys_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/teams","hooks_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/hooks","issue_events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/events","assignees_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/tags","blobs_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/languages","stargazers_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/stargazers","contributors_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/contributors","subscribers_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/subscribers","subscription_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/subscription","commits_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/merges","archive_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/downloads","issues_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/labels{/name}","releases_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/deployments","created_at":"2016-06-21T14:34:19Z","updated_at":"2016-08-04T10:59:42Z","pushed_at":"2016-08-05T23:54:03Z","git_url":"git://github.com/OpenBazaar/openbazaar-desktop.git","ssh_url":"git@github.com:OpenBazaar/openbazaar-desktop.git","clone_url":"https://github.com/OpenBazaar/openbazaar-desktop.git","svn_url":"https://github.com/OpenBazaar/openbazaar-desktop","homepage":null,"size":362,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25"},"html":{"href":"https://github.com/OpenBazaar/openbazaar-desktop/pull/25"},"issue":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/25"},"comments":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/OpenBazaar/openbazaar-desktop/statuses/c3846cc820df1ada23cd5052aff6f377915dd052"}}}}
{"actor":{"display_login":"jjeffryes"}}