{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/issues/34","repository_url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin","labels_url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/issues/34/comments","events_url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/issues/34/events","html_url":"https://github.com/jenkinsci/amazon-ecs-plugin/pull/34","id":191117197,"number":34,"title":"Add taskRoleArn configuration option","user":{"login":"roehrijn","id":2474078,"avatar_url":"https://avatars.githubusercontent.com/u/2474078?v=3","gravatar_id":"","url":"https://api.github.com/users/roehrijn","html_url":"https://github.com/roehrijn","followers_url":"https://api.github.com/users/roehrijn/followers","following_url":"https://api.github.com/users/roehrijn/following{/other_user}","gists_url":"https://api.github.com/users/roehrijn/gists{/gist_id}","starred_url":"https://api.github.com/users/roehrijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roehrijn/subscriptions","organizations_url":"https://api.github.com/users/roehrijn/orgs","repos_url":"https://api.github.com/users/roehrijn/repos","events_url":"https://api.github.com/users/roehrijn/events{/privacy}","received_events_url":"https://api.github.com/users/roehrijn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-22T20:34:06Z","updated_at":"2016-11-22T20:42:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/pulls/34","html_url":"https://github.com/jenkinsci/amazon-ecs-plugin/pull/34","diff_url":"https://github.com/jenkinsci/amazon-ecs-plugin/pull/34.diff","patch_url":"https://github.com/jenkinsci/amazon-ecs-plugin/pull/34.patch"},"body":"This will add the possibility to assign an IAM role to the slave ECS task definition.\r\nTo do this I needed to update the dependency to the newer AWS SDK, because adding a task role is not supported in the old version."},"comment":{"url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/issues/comments/262359823","html_url":"https://github.com/jenkinsci/amazon-ecs-plugin/pull/34#issuecomment-262359823","issue_url":"https://api.github.com/repos/jenkinsci/amazon-ecs-plugin/issues/34","id":262359823,"user":{"login":"roehrijn","id":2474078,"avatar_url":"https://avatars.githubusercontent.com/u/2474078?v=3","gravatar_id":"","url":"https://api.github.com/users/roehrijn","html_url":"https://github.com/roehrijn","followers_url":"https://api.github.com/users/roehrijn/followers","following_url":"https://api.github.com/users/roehrijn/following{/other_user}","gists_url":"https://api.github.com/users/roehrijn/gists{/gist_id}","starred_url":"https://api.github.com/users/roehrijn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roehrijn/subscriptions","organizations_url":"https://api.github.com/users/roehrijn/orgs","repos_url":"https://api.github.com/users/roehrijn/repos","events_url":"https://api.github.com/users/roehrijn/events{/privacy}","received_events_url":"https://api.github.com/users/roehrijn/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T20:42:32Z","updated_at":"2016-11-22T20:42:32Z","body":"@joh-m some thoughts about your change:\r\n\r\n1. I would suggest to add at least a short explanation to the configuration screen what the purpose of the new taskRoleArn field is and how to use is. Hope you agree.\r\n2. Wouldn't it be better not to call `#withTaskRoleArn(...)` ith no ARN is supplied in configuration? \r\n\r\n"}}
{"actor":{"display_login":"roehrijn"}}