{"action":"created","issue":{"url":"https://api.github.com/repos/goldfire/howler.js/issues/244","labels_url":"https://api.github.com/repos/goldfire/howler.js/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/goldfire/howler.js/issues/244/comments","events_url":"https://api.github.com/repos/goldfire/howler.js/issues/244/events","html_url":"https://github.com/goldfire/howler.js/pull/244","id":50938720,"number":244,"title":"Default effects properties were not set, + minor fixes","user":{"login":"luxigo","id":1018226,"avatar_url":"https://avatars.githubusercontent.com/u/1018226?v=3","gravatar_id":"","url":"https://api.github.com/users/luxigo","html_url":"https://github.com/luxigo","followers_url":"https://api.github.com/users/luxigo/followers","following_url":"https://api.github.com/users/luxigo/following{/other_user}","gists_url":"https://api.github.com/users/luxigo/gists{/gist_id}","starred_url":"https://api.github.com/users/luxigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxigo/subscriptions","organizations_url":"https://api.github.com/users/luxigo/orgs","repos_url":"https://api.github.com/users/luxigo/repos","events_url":"https://api.github.com/users/luxigo/events{/privacy}","received_events_url":"https://api.github.com/users/luxigo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/goldfire/howler.js/milestones/1","html_url":"https://github.com/goldfire/howler.js/milestones/2.0","labels_url":"https://api.github.com/repos/goldfire/howler.js/milestones/1/labels","id":1324492,"number":1,"title":"2.0","description":"","creator":{"login":"goldfire","id":882005,"avatar_url":"https://avatars.githubusercontent.com/u/882005?v=3","gravatar_id":"","url":"https://api.github.com/users/goldfire","html_url":"https://github.com/goldfire","followers_url":"https://api.github.com/users/goldfire/followers","following_url":"https://api.github.com/users/goldfire/following{/other_user}","gists_url":"https://api.github.com/users/goldfire/gists{/gist_id}","starred_url":"https://api.github.com/users/goldfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldfire/subscriptions","organizations_url":"https://api.github.com/users/goldfire/orgs","repos_url":"https://api.github.com/users/goldfire/repos","events_url":"https://api.github.com/users/goldfire/events{/privacy}","received_events_url":"https://api.github.com/users/goldfire/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":120,"state":"open","created_at":"2015-09-25T20:33:57Z","updated_at":"2016-01-15T22:33:07Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2014-12-04T08:06:20Z","updated_at":"2016-01-15T22:33:23Z","closed_at":"2016-01-15T22:33:07Z","pull_request":{"url":"https://api.github.com/repos/goldfire/howler.js/pulls/244","html_url":"https://github.com/goldfire/howler.js/pull/244","diff_url":"https://github.com/goldfire/howler.js/pull/244.diff","patch_url":"https://github.com/goldfire/howler.js/pull/244.patch"},"body":"1.\r\nDefault effects properties were not set in the HowlerGlobal object.\r\n\r\nThe HowlerGlobal object (window.Howler) is instantiated here:\r\nhttps://github.com/goldfire/howler.js/blob/2.0/src/howler.core.js#L232\r\n\r\nBut it happends before HowlerGlobal.prototype.init is overrided here:\r\nhttps://github.com/goldfire/howler.js/blob/2.0/src/plugins/howler.effects.js#L25\r\n\r\nSetting default effect properties in the HowlerGlobal.prototype solved the problem.\r\n\r\n2.\r\nself.ctx.listener.setOrientation was not set properly on https://github.com/goldfire/howler.js/blob/2.0/src/plugins/howler.effects.js#L105\r\n\r\n3.\r\nThere was a typo in coneOUterangle\r\n\r\n4.\r\nIt was not possible to specify only a subset of the panner attributes (maybe it was on purpose ?.. take it or leave it)\r\n"},"comment":{"url":"https://api.github.com/repos/goldfire/howler.js/issues/comments/172113997","html_url":"https://github.com/goldfire/howler.js/pull/244#issuecomment-172113997","issue_url":"https://api.github.com/repos/goldfire/howler.js/issues/244","id":172113997,"user":{"login":"goldfire","id":882005,"avatar_url":"https://avatars.githubusercontent.com/u/882005?v=3","gravatar_id":"","url":"https://api.github.com/users/goldfire","html_url":"https://github.com/goldfire","followers_url":"https://api.github.com/users/goldfire/followers","following_url":"https://api.github.com/users/goldfire/following{/other_user}","gists_url":"https://api.github.com/users/goldfire/gists{/gist_id}","starred_url":"https://api.github.com/users/goldfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldfire/subscriptions","organizations_url":"https://api.github.com/users/goldfire/orgs","repos_url":"https://api.github.com/users/goldfire/repos","events_url":"https://api.github.com/users/goldfire/events{/privacy}","received_events_url":"https://api.github.com/users/goldfire/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T22:33:23Z","updated_at":"2016-01-15T22:33:23Z","body":"Thanks for finding all of these, and sorry it took so long to get merged!"}}