{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/58028476","id":58028476,"diff_hunk":"@@ -95,6 +98,23 @@ def child_index=(idx)\n       move_to_child_with_index(parent, idx.to_i) unless new_record?\n     end\n \n+    def move_to_child_with_index(node, index)\n+      # closure_tree does not provide any method that move nodes regarding position\n+      # this method overrides move_to_child_with_index offered by awesome_nested_set","path":"core/app/models/spree/taxon.rb","position":17,"original_position":17,"commit_id":"a0202ebf93164eea5fb068087bd69a6558297fed","original_commit_id":"a0202ebf93164eea5fb068087bd69a6558297fed","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"body":"Wait, \"overrides\"? Is `awesome_nested_set` still around to be overridden, or does the method just follow the signature from `awesome_nested_set`?\r\n\r\nAlso: We tend to have comments above method definitions, along with a little bit of [YARD doc](https://gist.github.com/chetan/1827484). If you could move that once we've come to a decision about this PR, that'd be great.","created_at":"2016-03-31T09:58:28Z","updated_at":"2016-03-31T09:58:28Z","html_url":"https://github.com/solidusio/solidus/pull/662#discussion_r58028476","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/58028476"},"html":{"href":"https://github.com/solidusio/solidus/pull/662#discussion_r58028476"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/662"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/662","id":55310988,"html_url":"https://github.com/solidusio/solidus/pull/662","diff_url":"https://github.com/solidusio/solidus/pull/662.diff","patch_url":"https://github.com/solidusio/solidus/pull/662.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/662","number":662,"state":"open","locked":false,"title":"Switching to closure tree #588","user":{"login":"simo163","id":3654076,"avatar_url":"https://avatars.githubusercontent.com/u/3654076?v=3","gravatar_id":"","url":"https://api.github.com/users/simo163","html_url":"https://github.com/simo163","followers_url":"https://api.github.com/users/simo163/followers","following_url":"https://api.github.com/users/simo163/following{/other_user}","gists_url":"https://api.github.com/users/simo163/gists{/gist_id}","starred_url":"https://api.github.com/users/simo163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo163/subscriptions","organizations_url":"https://api.github.com/users/simo163/orgs","repos_url":"https://api.github.com/users/simo163/repos","events_url":"https://api.github.com/users/simo163/events{/privacy}","received_events_url":"https://api.github.com/users/simo163/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-07T08:21:05Z","updated_at":"2016-03-31T09:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502d3a5df112659b9caa0af46e542c482d21cc80","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/662/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/662/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/662/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/a0202ebf93164eea5fb068087bd69a6558297fed","head":{"label":"simo163:switching-to-closure-tree","ref":"switching-to-closure-tree","sha":"a0202ebf93164eea5fb068087bd69a6558297fed","user":{"login":"simo163","id":3654076,"avatar_url":"https://avatars.githubusercontent.com/u/3654076?v=3","gravatar_id":"","url":"https://api.github.com/users/simo163","html_url":"https://github.com/simo163","followers_url":"https://api.github.com/users/simo163/followers","following_url":"https://api.github.com/users/simo163/following{/other_user}","gists_url":"https://api.github.com/users/simo163/gists{/gist_id}","starred_url":"https://api.github.com/users/simo163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo163/subscriptions","organizations_url":"https://api.github.com/users/simo163/orgs","repos_url":"https://api.github.com/users/simo163/repos","events_url":"https://api.github.com/users/simo163/events{/privacy}","received_events_url":"https://api.github.com/users/simo163/received_events","type":"User","site_admin":false},"repo":{"id":45524482,"name":"solidus","full_name":"simo163/solidus","owner":{"login":"simo163","id":3654076,"avatar_url":"https://avatars.githubusercontent.com/u/3654076?v=3","gravatar_id":"","url":"https://api.github.com/users/simo163","html_url":"https://github.com/simo163","followers_url":"https://api.github.com/users/simo163/followers","following_url":"https://api.github.com/users/simo163/following{/other_user}","gists_url":"https://api.github.com/users/simo163/gists{/gist_id}","starred_url":"https://api.github.com/users/simo163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo163/subscriptions","organizations_url":"https://api.github.com/users/simo163/orgs","repos_url":"https://api.github.com/users/simo163/repos","events_url":"https://api.github.com/users/simo163/events{/privacy}","received_events_url":"https://api.github.com/users/simo163/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simo163/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/simo163/solidus","forks_url":"https://api.github.com/repos/simo163/solidus/forks","keys_url":"https://api.github.com/repos/simo163/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simo163/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simo163/solidus/teams","hooks_url":"https://api.github.com/repos/simo163/solidus/hooks","issue_events_url":"https://api.github.com/repos/simo163/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/simo163/solidus/events","assignees_url":"https://api.github.com/repos/simo163/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/simo163/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/simo163/solidus/tags","blobs_url":"https://api.github.com/repos/simo163/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simo163/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simo163/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/simo163/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simo163/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/simo163/solidus/languages","stargazers_url":"https://api.github.com/repos/simo163/solidus/stargazers","contributors_url":"https://api.github.com/repos/simo163/solidus/contributors","subscribers_url":"https://api.github.com/repos/simo163/solidus/subscribers","subscription_url":"https://api.github.com/repos/simo163/solidus/subscription","commits_url":"https://api.github.com/repos/simo163/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/simo163/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/simo163/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/simo163/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/simo163/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/simo163/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simo163/solidus/merges","archive_url":"https://api.github.com/repos/simo163/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simo163/solidus/downloads","issues_url":"https://api.github.com/repos/simo163/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/simo163/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/simo163/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/simo163/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simo163/solidus/labels{/name}","releases_url":"https://api.github.com/repos/simo163/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/simo163/solidus/deployments","created_at":"2015-11-04T08:13:03Z","updated_at":"2015-11-04T08:13:11Z","pushed_at":"2016-02-02T15:15:57Z","git_url":"git://github.com/simo163/solidus.git","ssh_url":"git@github.com:simo163/solidus.git","clone_url":"https://github.com/simo163/solidus.git","svn_url":"https://github.com/simo163/solidus","homepage":"http://solidus.io/","size":61587,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"e4428c0596d2b60c1c82243304ef9087da4ac6cf","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2016-03-31T05:40:59Z","pushed_at":"2016-03-31T09:49:25Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":68350,"stargazers_count":865,"watchers_count":865,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":120,"forks":223,"open_issues":120,"watchers":865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/662"},"html":{"href":"https://github.com/solidusio/solidus/pull/662"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/662"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/a0202ebf93164eea5fb068087bd69a6558297fed"}}}}