{"action":"created","issue":{"url":"https://api.github.com/repos/FransBouma/DocNet/issues/31","repository_url":"https://api.github.com/repos/FransBouma/DocNet","labels_url":"https://api.github.com/repos/FransBouma/DocNet/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/FransBouma/DocNet/issues/31/comments","events_url":"https://api.github.com/repos/FransBouma/DocNet/issues/31/events","html_url":"https://github.com/FransBouma/DocNet/pull/31","id":139057350,"number":31,"title":"Added support for @@include tag which will allow embedding html/markdown files from the '_partial' folder","user":{"login":"seemantr","id":5182698,"avatar_url":"https://avatars.githubusercontent.com/u/5182698?v=3","gravatar_id":"","url":"https://api.github.com/users/seemantr","html_url":"https://github.com/seemantr","followers_url":"https://api.github.com/users/seemantr/followers","following_url":"https://api.github.com/users/seemantr/following{/other_user}","gists_url":"https://api.github.com/users/seemantr/gists{/gist_id}","starred_url":"https://api.github.com/users/seemantr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seemantr/subscriptions","organizations_url":"https://api.github.com/users/seemantr/orgs","repos_url":"https://api.github.com/users/seemantr/repos","events_url":"https://api.github.com/users/seemantr/events{/privacy}","received_events_url":"https://api.github.com/users/seemantr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-07T18:41:36Z","updated_at":"2016-03-09T10:59:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FransBouma/DocNet/pulls/31","html_url":"https://github.com/FransBouma/DocNet/pull/31","diff_url":"https://github.com/FransBouma/DocNet/pull/31.diff","patch_url":"https://github.com/FransBouma/DocNet/pull/31.patch"},"body":"Done changes as per our discussion. Unfortunately this is not recursive in terms of include tags but that can be easily added at a later point of time. I have to send a new PR as I wanted to base it on your latest changes."},"comment":{"url":"https://api.github.com/repos/FransBouma/DocNet/issues/comments/194241414","html_url":"https://github.com/FransBouma/DocNet/pull/31#issuecomment-194241414","issue_url":"https://api.github.com/repos/FransBouma/DocNet/issues/31","id":194241414,"user":{"login":"FransBouma","id":3628530,"avatar_url":"https://avatars.githubusercontent.com/u/3628530?v=3","gravatar_id":"","url":"https://api.github.com/users/FransBouma","html_url":"https://github.com/FransBouma","followers_url":"https://api.github.com/users/FransBouma/followers","following_url":"https://api.github.com/users/FransBouma/following{/other_user}","gists_url":"https://api.github.com/users/FransBouma/gists{/gist_id}","starred_url":"https://api.github.com/users/FransBouma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FransBouma/subscriptions","organizations_url":"https://api.github.com/users/FransBouma/orgs","repos_url":"https://api.github.com/users/FransBouma/repos","events_url":"https://api.github.com/users/FransBouma/events{/privacy}","received_events_url":"https://api.github.com/users/FransBouma/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T10:59:30Z","updated_at":"2016-03-09T10:59:30Z","body":"I think you can commit to a PR or update a PR, though I don't know specifics about that. (I often see 'commented on an outdated PR' in other repos, so it should be possible. \r\n\r\nAnyway, on to your contribution: :) It's not a big deal it's not recursive, I'll add an issue that it should be updated. \r\n\r\nWhat I'll do post merge though is change the default. I don't like the '_partial' default, so I'll change that. As that will break your own code, I'll add a docnet.json setting for configuring the include folder so you can keep using '_partial', which you likely chose to meet your own setup. :)\r\n\r\nIn my template engine in LLBLGen Pro I've implemented a recursive template include parser directive some years ago so it's not a big problem for me to implement that later on. \r\n\r\nThanks!"}}