{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/81387144","pull_request_review_id":2372642,"id":81387144,"diff_hunk":"@@ -101,7 +101,7 @@ console.error(interfaces);\n switch (platform) {\n   case 'linux':\n     {\n-      const filter = function(e) { return e.address == '127.0.0.1'; };\n+      const filter = function(e) { return e.address === '127.0.0.1'; };\n       const actual = interfaces.lo.filter(filter);","path":"test/parallel/test-os.js","position":6,"original_position":6,"commit_id":"b4e11629b1474149ea97ad98f02bf60a2cc1a351","original_commit_id":"b4e11629b1474149ea97ad98f02bf60a2cc1a351","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"The arrow function will work in the `linux` part, but I don't believe it can (at least not in any obvious way) in the second instance (in the `win32` portion) where the line it needs to be put into is longer. I'm reluctant to make them different from each other. Seems clearer to me to have them both be the same, even if it means an extra line in one case. Since the comment is labeled as a `nit` and ends with a question mark, I'm going to take that to mean that it's OK for this to land without that suggestion.","created_at":"2016-09-30T17:57:12Z","updated_at":"2016-09-30T17:57:12Z","html_url":"https://github.com/nodejs/node/pull/8761#discussion_r81387144","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/8761","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/81387144"},"html":{"href":"https://github.com/nodejs/node/pull/8761#discussion_r81387144"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/8761"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8761","id":86631072,"html_url":"https://github.com/nodejs/node/pull/8761","diff_url":"https://github.com/nodejs/node/pull/8761.diff","patch_url":"https://github.com/nodejs/node/pull/8761.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8761","number":8761,"state":"open","locked":false,"title":"test: cleanup/update test-os.js","user":{"login":"mikeswoods","id":133008,"avatar_url":"https://avatars.githubusercontent.com/u/133008?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeswoods","html_url":"https://github.com/mikeswoods","followers_url":"https://api.github.com/users/mikeswoods/followers","following_url":"https://api.github.com/users/mikeswoods/following{/other_user}","gists_url":"https://api.github.com/users/mikeswoods/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeswoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeswoods/subscriptions","organizations_url":"https://api.github.com/users/mikeswoods/orgs","repos_url":"https://api.github.com/users/mikeswoods/repos","events_url":"https://api.github.com/users/mikeswoods/events{/privacy}","received_events_url":"https://api.github.com/users/mikeswoods/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ntest\r\n\r\n##### Description of change\r\nReplaced `==` with `===\r\nReplaced `indexOf(...) !== -1` with `includes()`","created_at":"2016-09-24T21:25:25Z","updated_at":"2016-09-30T17:57:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ec8702e4142349eda27ae08862195d9ca45c10f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8761/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8761/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8761/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b4e11629b1474149ea97ad98f02bf60a2cc1a351","head":{"label":"mikeswoods:first-contribution-parallel-test-os","ref":"first-contribution-parallel-test-os","sha":"b4e11629b1474149ea97ad98f02bf60a2cc1a351","user":{"login":"mikeswoods","id":133008,"avatar_url":"https://avatars.githubusercontent.com/u/133008?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeswoods","html_url":"https://github.com/mikeswoods","followers_url":"https://api.github.com/users/mikeswoods/followers","following_url":"https://api.github.com/users/mikeswoods/following{/other_user}","gists_url":"https://api.github.com/users/mikeswoods/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeswoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeswoods/subscriptions","organizations_url":"https://api.github.com/users/mikeswoods/orgs","repos_url":"https://api.github.com/users/mikeswoods/repos","events_url":"https://api.github.com/users/mikeswoods/events{/privacy}","received_events_url":"https://api.github.com/users/mikeswoods/received_events","type":"User","site_admin":false},"repo":{"id":69125910,"name":"node","full_name":"mikeswoods/node","owner":{"login":"mikeswoods","id":133008,"avatar_url":"https://avatars.githubusercontent.com/u/133008?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeswoods","html_url":"https://github.com/mikeswoods","followers_url":"https://api.github.com/users/mikeswoods/followers","following_url":"https://api.github.com/users/mikeswoods/following{/other_user}","gists_url":"https://api.github.com/users/mikeswoods/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeswoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeswoods/subscriptions","organizations_url":"https://api.github.com/users/mikeswoods/orgs","repos_url":"https://api.github.com/users/mikeswoods/repos","events_url":"https://api.github.com/users/mikeswoods/events{/privacy}","received_events_url":"https://api.github.com/users/mikeswoods/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikeswoods/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/mikeswoods/node","forks_url":"https://api.github.com/repos/mikeswoods/node/forks","keys_url":"https://api.github.com/repos/mikeswoods/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikeswoods/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikeswoods/node/teams","hooks_url":"https://api.github.com/repos/mikeswoods/node/hooks","issue_events_url":"https://api.github.com/repos/mikeswoods/node/issues/events{/number}","events_url":"https://api.github.com/repos/mikeswoods/node/events","assignees_url":"https://api.github.com/repos/mikeswoods/node/assignees{/user}","branches_url":"https://api.github.com/repos/mikeswoods/node/branches{/branch}","tags_url":"https://api.github.com/repos/mikeswoods/node/tags","blobs_url":"https://api.github.com/repos/mikeswoods/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikeswoods/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikeswoods/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikeswoods/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikeswoods/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mikeswoods/node/languages","stargazers_url":"https://api.github.com/repos/mikeswoods/node/stargazers","contributors_url":"https://api.github.com/repos/mikeswoods/node/contributors","subscribers_url":"https://api.github.com/repos/mikeswoods/node/subscribers","subscription_url":"https://api.github.com/repos/mikeswoods/node/subscription","commits_url":"https://api.github.com/repos/mikeswoods/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikeswoods/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikeswoods/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikeswoods/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikeswoods/node/contents/{+path}","compare_url":"https://api.github.com/repos/mikeswoods/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikeswoods/node/merges","archive_url":"https://api.github.com/repos/mikeswoods/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikeswoods/node/downloads","issues_url":"https://api.github.com/repos/mikeswoods/node/issues{/number}","pulls_url":"https://api.github.com/repos/mikeswoods/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mikeswoods/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mikeswoods/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikeswoods/node/labels{/name}","releases_url":"https://api.github.com/repos/mikeswoods/node/releases{/id}","deployments_url":"https://api.github.com/repos/mikeswoods/node/deployments","created_at":"2016-09-24T20:28:09Z","updated_at":"2016-09-24T20:28:31Z","pushed_at":"2016-09-24T22:48:19Z","git_url":"git://github.com/mikeswoods/node.git","ssh_url":"git@github.com:mikeswoods/node.git","clone_url":"https://github.com/mikeswoods/node.git","svn_url":"https://github.com/mikeswoods/node","homepage":"https://nodejs.org","size":231572,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"d196c5d2af6b5727289bf2da68514517bd1c257f","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-30T17:55:46Z","pushed_at":"2016-09-30T17:35:54Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":306482,"stargazers_count":27232,"watchers_count":27232,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4424,"mirror_url":null,"open_issues_count":829,"forks":4424,"open_issues":829,"watchers":27232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8761"},"html":{"href":"https://github.com/nodejs/node/pull/8761"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8761"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8761/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8761/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8761/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b4e11629b1474149ea97ad98f02bf60a2cc1a351"}}}}
{"actor":{"display_login":"Trott"}}