{"action":"created","comment":{"url":"https://api.github.com/repos/18F/calc/pulls/comments/78400223","id":78400223,"diff_hunk":"@@ -18,7 +20,19 @@ def set_fake_gleaned_data(self, rows):\n         session.save()\n \n     def setUp(self):\n+        super().setUp()\n         registry._init()\n+        call_command('initgroups', stdout=io.StringIO())","path":"data_capture/tests/test_price_list_views.py","position":13,"original_position":13,"commit_id":"9fdab07f5d88f363936d9080946156d319b47846","original_commit_id":"9fdab07f5d88f363936d9080946156d319b47846","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"body":"Huh, I wonder if this adds much overhead to how fast the tests run.","created_at":"2016-09-12T15:55:47Z","updated_at":"2016-09-12T15:55:47Z","html_url":"https://github.com/18F/calc/pull/694#discussion_r78400223","pull_request_url":"https://api.github.com/repos/18F/calc/pulls/694","_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/comments/78400223"},"html":{"href":"https://github.com/18F/calc/pull/694#discussion_r78400223"},"pull_request":{"href":"https://api.github.com/repos/18F/calc/pulls/694"}}},"pull_request":{"url":"https://api.github.com/repos/18F/calc/pulls/694","id":84498079,"html_url":"https://github.com/18F/calc/pull/694","diff_url":"https://github.com/18F/calc/pull/694.diff","patch_url":"https://github.com/18F/calc/pull/694.patch","issue_url":"https://api.github.com/repos/18F/calc/issues/694","number":694,"state":"open","locked":false,"title":"Implement Contract Officers role and protect Price List Upload views","user":{"login":"jseppi","id":697848,"avatar_url":"https://avatars.githubusercontent.com/u/697848?v=3","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false},"body":"Adds a new decorator to test that user has Contract Officer permissions, and decorates price list upload views with the new decorator.\r\n\r\ncloses #686 \r\n\r\nTo Do:\r\n- [x] add Contract Officers role and permissions\r\n- [x] restrict Price List Upload views based on relevant permissions\r\n- [x] tests\r\n  - [x] for decorator\r\n  - [x] that views are protected\r\n  - [x] for new role in `initgroups`\r\n- [x] merge `develop`\r\n- [x] modify to have this decorator do login redirection when a user is not-authenticated, and throw `PermissionDenied` if the user is authenticated but doesn't have the right perms.","created_at":"2016-09-08T15:18:35Z","updated_at":"2016-09-12T15:55:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2187681cd3ec9e572d302e8b500796acbed0be1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/calc/pulls/694/commits","review_comments_url":"https://api.github.com/repos/18F/calc/pulls/694/comments","review_comment_url":"https://api.github.com/repos/18F/calc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/calc/issues/694/comments","statuses_url":"https://api.github.com/repos/18F/calc/statuses/9fdab07f5d88f363936d9080946156d319b47846","head":{"label":"18F:contract-officer-role","ref":"contract-officer-role","sha":"9fdab07f5d88f363936d9080946156d319b47846","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2016-09-02T17:29:13Z","pushed_at":"2016-09-12T15:52:26Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":16596,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":102,"forks":42,"open_issues":102,"watchers":82,"default_branch":"develop"}},"base":{"label":"18F:develop","ref":"develop","sha":"e4585b28d4a31f64fe5f9a96b7ca1521204f8a94","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":26967517,"name":"calc","full_name":"18F/calc","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/calc","description":"An estimator for hourly rates on professional services contracts","fork":false,"url":"https://api.github.com/repos/18F/calc","forks_url":"https://api.github.com/repos/18F/calc/forks","keys_url":"https://api.github.com/repos/18F/calc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/calc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/calc/teams","hooks_url":"https://api.github.com/repos/18F/calc/hooks","issue_events_url":"https://api.github.com/repos/18F/calc/issues/events{/number}","events_url":"https://api.github.com/repos/18F/calc/events","assignees_url":"https://api.github.com/repos/18F/calc/assignees{/user}","branches_url":"https://api.github.com/repos/18F/calc/branches{/branch}","tags_url":"https://api.github.com/repos/18F/calc/tags","blobs_url":"https://api.github.com/repos/18F/calc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/calc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/calc/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/calc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/calc/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/calc/languages","stargazers_url":"https://api.github.com/repos/18F/calc/stargazers","contributors_url":"https://api.github.com/repos/18F/calc/contributors","subscribers_url":"https://api.github.com/repos/18F/calc/subscribers","subscription_url":"https://api.github.com/repos/18F/calc/subscription","commits_url":"https://api.github.com/repos/18F/calc/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/calc/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/calc/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/calc/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/calc/contents/{+path}","compare_url":"https://api.github.com/repos/18F/calc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/calc/merges","archive_url":"https://api.github.com/repos/18F/calc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/calc/downloads","issues_url":"https://api.github.com/repos/18F/calc/issues{/number}","pulls_url":"https://api.github.com/repos/18F/calc/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/calc/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/calc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/calc/labels{/name}","releases_url":"https://api.github.com/repos/18F/calc/releases{/id}","deployments_url":"https://api.github.com/repos/18F/calc/deployments","created_at":"2014-11-21T16:22:24Z","updated_at":"2016-09-02T17:29:13Z","pushed_at":"2016-09-12T15:52:26Z","git_url":"git://github.com/18F/calc.git","ssh_url":"git@github.com:18F/calc.git","clone_url":"https://github.com/18F/calc.git","svn_url":"https://github.com/18F/calc","homepage":"https://calc.gsa.gov/","size":16596,"stargazers_count":82,"watchers_count":82,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":102,"forks":42,"open_issues":102,"watchers":82,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/calc/pulls/694"},"html":{"href":"https://github.com/18F/calc/pull/694"},"issue":{"href":"https://api.github.com/repos/18F/calc/issues/694"},"comments":{"href":"https://api.github.com/repos/18F/calc/issues/694/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/calc/pulls/694/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/calc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/calc/pulls/694/commits"},"statuses":{"href":"https://api.github.com/repos/18F/calc/statuses/9fdab07f5d88f363936d9080946156d319b47846"}}}}
{"actor":{"display_login":"toolness"}}