{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/60678153","id":60678153,"diff_hunk":"@@ -762,16 +777,33 @@\n         RESPONSES[ApiKeys.SYNC_GROUP.id] = SYNC_GROUP_RESPONSE;\n         RESPONSES[ApiKeys.DESCRIBE_GROUPS.id] = DESCRIBE_GROUPS_RESPONSE;\n         RESPONSES[ApiKeys.LIST_GROUPS.id] = LIST_GROUPS_RESPONSE;\n+        RESPONSES[ApiKeys.API_VERSION.id] = API_VERSION_RESPONSE;\n \n-        /* set the maximum version of each api */\n-        for (ApiKeys api : ApiKeys.values())\n+        /* set the minimum and maximum version of each api */\n+        for (ApiKeys api : ApiKeys.values()) {","path":"clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java","position":42,"original_position":42,"commit_id":"007eb834e1db11c5d34ec29c402d23a82ff1a95e","original_commit_id":"007eb834e1db11c5d34ec29c402d23a82ff1a95e","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"Yea, that should tidy up Protocol class a bit. Will do that.","created_at":"2016-04-22T00:59:33Z","updated_at":"2016-04-22T00:59:33Z","html_url":"https://github.com/apache/kafka/pull/986#discussion_r60678153","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/986","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/60678153"},"html":{"href":"https://github.com/apache/kafka/pull/986#discussion_r60678153"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/986"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/986","id":61165966,"html_url":"https://github.com/apache/kafka/pull/986","diff_url":"https://github.com/apache/kafka/pull/986.diff","patch_url":"https://github.com/apache/kafka/pull/986.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/986","number":986,"state":"open","locked":false,"title":"KAFKA-3307: Add ProtocolVersion request/response and server side handling.","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"The patch does the following.\r\n1. For unknown requests or protocol versions, broker sends an empty response, instead of simple closing the connection.\r\n2. Adds ProtocolVersion request and response, and server side implementation.","created_at":"2016-02-29T23:35:04Z","updated_at":"2016-04-22T00:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa62e3c770160c7ad5c97ef534ff9b6535738cf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/986/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/986/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/986/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/007eb834e1db11c5d34ec29c402d23a82ff1a95e","head":{"label":"SinghAsDev:KAFKA-3307","ref":"KAFKA-3307","sha":"007eb834e1db11c5d34ec29c402d23a82ff1a95e","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"repo":{"id":29443488,"name":"kafka","full_name":"SinghAsDev/kafka","owner":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SinghAsDev/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/SinghAsDev/kafka","forks_url":"https://api.github.com/repos/SinghAsDev/kafka/forks","keys_url":"https://api.github.com/repos/SinghAsDev/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SinghAsDev/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SinghAsDev/kafka/teams","hooks_url":"https://api.github.com/repos/SinghAsDev/kafka/hooks","issue_events_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/SinghAsDev/kafka/events","assignees_url":"https://api.github.com/repos/SinghAsDev/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/SinghAsDev/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/SinghAsDev/kafka/tags","blobs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SinghAsDev/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/SinghAsDev/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SinghAsDev/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/SinghAsDev/kafka/languages","stargazers_url":"https://api.github.com/repos/SinghAsDev/kafka/stargazers","contributors_url":"https://api.github.com/repos/SinghAsDev/kafka/contributors","subscribers_url":"https://api.github.com/repos/SinghAsDev/kafka/subscribers","subscription_url":"https://api.github.com/repos/SinghAsDev/kafka/subscription","commits_url":"https://api.github.com/repos/SinghAsDev/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/SinghAsDev/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/SinghAsDev/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/SinghAsDev/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/SinghAsDev/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SinghAsDev/kafka/merges","archive_url":"https://api.github.com/repos/SinghAsDev/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SinghAsDev/kafka/downloads","issues_url":"https://api.github.com/repos/SinghAsDev/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/SinghAsDev/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/SinghAsDev/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/SinghAsDev/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SinghAsDev/kafka/labels{/name}","releases_url":"https://api.github.com/repos/SinghAsDev/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/SinghAsDev/kafka/deployments","created_at":"2015-01-18T22:26:11Z","updated_at":"2015-01-18T22:26:13Z","pushed_at":"2016-04-21T23:30:50Z","git_url":"git://github.com/SinghAsDev/kafka.git","ssh_url":"git@github.com:SinghAsDev/kafka.git","clone_url":"https://github.com/SinghAsDev/kafka.git","svn_url":"https://github.com/SinghAsDev/kafka","homepage":null,"size":29512,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"9d71489ff0e62fd1897c7a6f54671673db7b37b8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-04-21T15:28:22Z","pushed_at":"2016-04-22T00:54:25Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":39829,"stargazers_count":2979,"watchers_count":2979,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1791,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":186,"forks":1791,"open_issues":186,"watchers":2979,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/986"},"html":{"href":"https://github.com/apache/kafka/pull/986"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/986"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/986/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/986/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/986/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/007eb834e1db11c5d34ec29c402d23a82ff1a95e"}}}}