{"action":"created","issue":{"url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/issues/15","repository_url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools","labels_url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/issues/15/comments","events_url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/issues/15/events","html_url":"https://github.com/open-forcefield-group/open-forcefield-tools/pull/15","id":164958853,"number":15,"title":"Revision of API document after discussion at UC Irvine, 7/11/2016","user":{"login":"mrshirts","id":4274132,"avatar_url":"https://avatars.githubusercontent.com/u/4274132?v=3","gravatar_id":"","url":"https://api.github.com/users/mrshirts","html_url":"https://github.com/mrshirts","followers_url":"https://api.github.com/users/mrshirts/followers","following_url":"https://api.github.com/users/mrshirts/following{/other_user}","gists_url":"https://api.github.com/users/mrshirts/gists{/gist_id}","starred_url":"https://api.github.com/users/mrshirts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrshirts/subscriptions","organizations_url":"https://api.github.com/users/mrshirts/orgs","repos_url":"https://api.github.com/users/mrshirts/repos","events_url":"https://api.github.com/users/mrshirts/events{/privacy}","received_events_url":"https://api.github.com/users/mrshirts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-11T23:01:40Z","updated_at":"2016-07-13T05:03:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/pulls/15","html_url":"https://github.com/open-forcefield-group/open-forcefield-tools/pull/15","diff_url":"https://github.com/open-forcefield-group/open-forcefield-tools/pull/15.diff","patch_url":"https://github.com/open-forcefield-group/open-forcefield-tools/pull/15.patch"},"body":"API changes (mostly minor):\r\n\r\n* Merged the concepts of `MeasuredPhysicalProperty` and `ComputedPhysicalProperty` into a single `PhysicalProperty`\r\n* (minor) Changed `Mixture` to `Composition`\r\n* (minor) Made `Composition` a member of `ThermodynamicState`\r\n* (minor) Added `phase` as a member of `ThermodynamicState`\r\n* (minor) Modified the name of parameter sets to models, since we might later generalize to be able to sample over functional forms as well via the same mechanism\r\n* (minor) `MeasurementMethod` could be a simulation method description.\r\n* (minor) `PhysicalProperty` objects returned from computeProperties can have a model appended to them.\r\n\r\nMinor documentation changes:\r\n* Changed the opening so that it first described the concept, then directly went into describing the objects in detail\r\n* Resolved several \"questions\" left open in the document that had been addressed in issues and in-person discussion\r\n* Tried to make it clear when data structures should be mapped from ThermoML to make copying back and forth from that format easier (and to take advantage of the ways that ThermoML has already documented things)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/issues/comments/232257180","html_url":"https://github.com/open-forcefield-group/open-forcefield-tools/pull/15#issuecomment-232257180","issue_url":"https://api.github.com/repos/open-forcefield-group/open-forcefield-tools/issues/15","id":232257180,"user":{"login":"mrshirts","id":4274132,"avatar_url":"https://avatars.githubusercontent.com/u/4274132?v=3","gravatar_id":"","url":"https://api.github.com/users/mrshirts","html_url":"https://github.com/mrshirts","followers_url":"https://api.github.com/users/mrshirts/followers","following_url":"https://api.github.com/users/mrshirts/following{/other_user}","gists_url":"https://api.github.com/users/mrshirts/gists{/gist_id}","starred_url":"https://api.github.com/users/mrshirts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrshirts/subscriptions","organizations_url":"https://api.github.com/users/mrshirts/orgs","repos_url":"https://api.github.com/users/mrshirts/repos","events_url":"https://api.github.com/users/mrshirts/events{/privacy}","received_events_url":"https://api.github.com/users/mrshirts/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T05:03:46Z","updated_at":"2016-07-13T05:03:46Z","body":"> More generally, why are you changing the API when I am in the middle of implementing it? I gave you guys plenty of time to comment on this during the design phase!\r\n\r\nVery valid concern.  1) it wasn't clear that there progress that it would make a difference from what had been committed so far 2) if there were changes, making them sooner is better than waiting until later 3) design documents can't be expected to be totally frozen, because better understanding of the problem will affect the design.\r\n\r\nAnd 4) a lot of the final discussion took place when I was on vacation with family, so I didn't get a chance to really look over it until I got to UCI on Monday.\r\n\r\nBut it's still a valid concern."}}
{"actor":{"display_login":"mrshirts"}}