{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/69383063","id":69383063,"diff_hunk":"@@ -27,5 +27,5 @@ var proxy = new Proxy({}, {\n \n var result = Object.getOwnPropertyDescriptors(proxy);\n assert.sameValue(result.hasOwnProperty('DUPLICATE'), true);\n-assert.sameValue(result.DUPLICATE, undefined);\n+assert.sameValue(result.DUPLICATE, descriptors[descriptors.length - 1]);\n assert.sameValue(log, 'ownKeys|getOwnPropertyDescriptor:DUPLICATE|getOwnPropertyDescriptor:DUPLICATE|getOwnPropertyDescriptor:DUPLICATE|');","path":"test/built-ins/Object/getOwnPropertyDescriptors/duplicate-keys.js","position":null,"original_position":6,"commit_id":"709710579eda5c7b30b73983a810f5c068e9b5e1","original_commit_id":"4285f85b27b0342f981ee92a4628b24a80f27b21","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"aha, good call again :-) thanks, keep the nits coming!","created_at":"2016-07-02T21:43:38Z","updated_at":"2016-07-02T21:43:38Z","html_url":"https://github.com/tc39/test262/pull/662#discussion_r69383063","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/69383063"},"html":{"href":"https://github.com/tc39/test262/pull/662#discussion_r69383063"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/662"}}},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/662","id":72421084,"html_url":"https://github.com/tc39/test262/pull/662","diff_url":"https://github.com/tc39/test262/pull/662.diff","patch_url":"https://github.com/tc39/test262/pull/662.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/662","number":662,"state":"open","locked":false,"title":"`Object.getOwnPropertyDescriptors`: add test to ensure undefined descriptors are not added","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Per https://github.com/tc39/ecma262/pull/593\r\n\r\n**NOTE**: do not merge yet, until TC39 consensus is reached and the above PR is also merged.","created_at":"2016-06-02T21:31:49Z","updated_at":"2016-07-02T21:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa52203e95346d1bb9250908a6d6e1dfc53281e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/662/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/662/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/662/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/709710579eda5c7b30b73983a810f5c068e9b5e1","head":{"label":"ljharb:ljharb/gopds_change","ref":"ljharb/gopds_change","sha":"709710579eda5c7b30b73983a810f5c068e9b5e1","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"repo":{"id":36524421,"name":"test262","full_name":"ljharb/test262","owner":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljharb/test262","description":"Official ECMAScript Conformance Test Suite","fork":true,"url":"https://api.github.com/repos/ljharb/test262","forks_url":"https://api.github.com/repos/ljharb/test262/forks","keys_url":"https://api.github.com/repos/ljharb/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljharb/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljharb/test262/teams","hooks_url":"https://api.github.com/repos/ljharb/test262/hooks","issue_events_url":"https://api.github.com/repos/ljharb/test262/issues/events{/number}","events_url":"https://api.github.com/repos/ljharb/test262/events","assignees_url":"https://api.github.com/repos/ljharb/test262/assignees{/user}","branches_url":"https://api.github.com/repos/ljharb/test262/branches{/branch}","tags_url":"https://api.github.com/repos/ljharb/test262/tags","blobs_url":"https://api.github.com/repos/ljharb/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljharb/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljharb/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljharb/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljharb/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/ljharb/test262/languages","stargazers_url":"https://api.github.com/repos/ljharb/test262/stargazers","contributors_url":"https://api.github.com/repos/ljharb/test262/contributors","subscribers_url":"https://api.github.com/repos/ljharb/test262/subscribers","subscription_url":"https://api.github.com/repos/ljharb/test262/subscription","commits_url":"https://api.github.com/repos/ljharb/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljharb/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljharb/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljharb/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljharb/test262/contents/{+path}","compare_url":"https://api.github.com/repos/ljharb/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljharb/test262/merges","archive_url":"https://api.github.com/repos/ljharb/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljharb/test262/downloads","issues_url":"https://api.github.com/repos/ljharb/test262/issues{/number}","pulls_url":"https://api.github.com/repos/ljharb/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/ljharb/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/ljharb/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljharb/test262/labels{/name}","releases_url":"https://api.github.com/repos/ljharb/test262/releases{/id}","deployments_url":"https://api.github.com/repos/ljharb/test262/deployments","created_at":"2015-05-29T19:22:07Z","updated_at":"2016-02-01T09:13:00Z","pushed_at":"2016-07-02T21:43:36Z","git_url":"git://github.com/ljharb/test262.git","ssh_url":"git@github.com:ljharb/test262.git","clone_url":"https://github.com/ljharb/test262.git","svn_url":"https://github.com/ljharb/test262","homepage":"test262.ecmascript.org","size":55007,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"fce8b5852d7d9d3839dea6922bae306934ac115a","user":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"avatar_url":"https://avatars.githubusercontent.com/u/1725583?v=3","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2016-06-28T08:57:07Z","pushed_at":"2016-07-02T21:43:36Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":57937,"stargazers_count":315,"watchers_count":315,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":96,"forks":101,"open_issues":96,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/662"},"html":{"href":"https://github.com/tc39/test262/pull/662"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/662"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/709710579eda5c7b30b73983a810f5c068e9b5e1"}}}}
{"actor":{"display_login":"ljharb"}}