{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19512","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19512/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19512/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19512/events","html_url":"https://github.com/NixOS/nixpkgs/pull/19512","id":182780726,"number":19512,"title":"WIP: rewrite hardening in plain nix","user":{"login":"groxxda","id":5701271,"avatar_url":"https://avatars.githubusercontent.com/u/5701271?v=3","gravatar_id":"","url":"https://api.github.com/users/groxxda","html_url":"https://github.com/groxxda","followers_url":"https://api.github.com/users/groxxda/followers","following_url":"https://api.github.com/users/groxxda/following{/other_user}","gists_url":"https://api.github.com/users/groxxda/gists{/gist_id}","starred_url":"https://api.github.com/users/groxxda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groxxda/subscriptions","organizations_url":"https://api.github.com/users/groxxda/orgs","repos_url":"https://api.github.com/users/groxxda/repos","events_url":"https://api.github.com/users/groxxda/events{/privacy}","received_events_url":"https://api.github.com/users/groxxda/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-13T12:51:02Z","updated_at":"2016-10-13T13:00:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19512","html_url":"https://github.com/NixOS/nixpkgs/pull/19512","diff_url":"https://github.com/NixOS/nixpkgs/pull/19512.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/19512.patch"},"body":"###### Motivation for this change\r\nDoing it in nix makes it more lazy.\r\n\r\nSee commit messages for more details\r\n\r\nFixes #18995 \r\n\r\n**This PR is not ready to merge.**\r\nI post it to get feedback on the changes.\r\n\r\n### TODO:\r\n\r\n- Add hardening for other cc derivations\r\n- Handle pie hardening (probably via `.spec` file for gcc, sadly unsupported on clang)\r\n- Make `all` flag more efficiently (see https://github.com/NixOS/nixpkgs/commit/4bf0576a75fce51d0d52b7513e117d7f7a353dd0 for details) \r\n\r\nCC @fpletz @globin  \r\n\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/253505972","html_url":"https://github.com/NixOS/nixpkgs/pull/19512#issuecomment-253505972","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19512","id":253505972,"user":{"login":"groxxda","id":5701271,"avatar_url":"https://avatars.githubusercontent.com/u/5701271?v=3","gravatar_id":"","url":"https://api.github.com/users/groxxda","html_url":"https://github.com/groxxda","followers_url":"https://api.github.com/users/groxxda/followers","following_url":"https://api.github.com/users/groxxda/following{/other_user}","gists_url":"https://api.github.com/users/groxxda/gists{/gist_id}","starred_url":"https://api.github.com/users/groxxda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groxxda/subscriptions","organizations_url":"https://api.github.com/users/groxxda/orgs","repos_url":"https://api.github.com/users/groxxda/repos","events_url":"https://api.github.com/users/groxxda/events{/privacy}","received_events_url":"https://api.github.com/users/groxxda/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T13:00:33Z","updated_at":"2016-10-13T13:00:33Z","body":"@fpletz can I help with the remaining todos?"}}
{"actor":{"display_login":"groxxda"}}