{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2329","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2329/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2329/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2329/events","html_url":"https://github.com/openshift/openshift-ansible/pull/2329","id":172125157,"number":2329,"title":"Fix the “node on master” feature","user":{"login":"lhuard1A","id":9693988,"avatar_url":"https://avatars.githubusercontent.com/u/9693988?v=3","gravatar_id":"","url":"https://api.github.com/users/lhuard1A","html_url":"https://github.com/lhuard1A","followers_url":"https://api.github.com/users/lhuard1A/followers","following_url":"https://api.github.com/users/lhuard1A/following{/other_user}","gists_url":"https://api.github.com/users/lhuard1A/gists{/gist_id}","starred_url":"https://api.github.com/users/lhuard1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhuard1A/subscriptions","organizations_url":"https://api.github.com/users/lhuard1A/orgs","repos_url":"https://api.github.com/users/lhuard1A/repos","events_url":"https://api.github.com/users/lhuard1A/events{/privacy}","received_events_url":"https://api.github.com/users/lhuard1A/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-19T12:54:12Z","updated_at":"2016-08-19T13:43:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2329","html_url":"https://github.com/openshift/openshift-ansible/pull/2329","diff_url":"https://github.com/openshift/openshift-ansible/pull/2329.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2329.patch"},"body":"What we want to do is to add the master as a node if:\r\n* `g_nodeonmaster` is set to true, and\r\n* we are not in the case where we want to add new nodes.\r\n\r\nThe second test was done by only checking whether `g_new_node_hosts` was defined.\r\nThis was wrong because, in all cloud-provider setups, this variable was set\r\nwith the default value of “empty list” (`[]`).\r\nThe test has been changed to use the `bool` filter so that it correctly evaluates\r\nto false (and hence, effectively add the master as a node) when `g_new_node_hosts`\r\nis the empty list."},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/241021704","html_url":"https://github.com/openshift/openshift-ansible/pull/2329#issuecomment-241021704","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2329","id":241021704,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T13:43:16Z","updated_at":"2016-08-19T13:43:16Z","body":"bce3235761a16fd8048760ce8ee63e0a64d672a7 - State: success - All Test Contexts: \"aos-ci-jenkins/OS_3.2_NOT_containerized, aos-ci-jenkins/OS_3.2_NOT_containerized_e2e_tests\" - Logs: https://aos-ci.s3.amazonaws.com/openshift/openshift-ansible/jenkins-openshift-ansible-3-test-matrix-CONTAINERIZED=_NOT_containerized,OSE_VER=3.2,PYTHON=System-CPython-2.7,TOPOLOGY=openshift-cluster,TargetBranch=master,nodes=openshift-ansible-slave-206/bce3235761a16fd8048760ce8ee63e0a64d672a7.txt"}}
{"actor":{"display_login":"openshift-bot"}}