{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/83692180","pull_request_review_id":4519218,"id":83692180,"diff_hunk":"@@ -52,7 +52,10 @@\n       end\n \n       describe 'with no custom parameters' do\n+        it { is_expected.to compile.with_all_deps }","path":"spec/classes/puppet_init_spec.rb","position":4,"original_position":4,"commit_id":"10f0c44d52d155b288749f063626433bc5e06a1d","original_commit_id":"10f0c44d52d155b288749f063626433bc5e06a1d","user":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"body":"this fails with the windows OSes in the spec environment","created_at":"2016-10-17T17:24:07Z","updated_at":"2016-10-17T17:24:07Z","html_url":"https://github.com/theforeman/puppet-puppet/pull/444#discussion_r83692180","pull_request_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/83692180"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/444#discussion_r83692180"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444","id":89604108,"html_url":"https://github.com/theforeman/puppet-puppet/pull/444","diff_url":"https://github.com/theforeman/puppet-puppet/pull/444.diff","patch_url":"https://github.com/theforeman/puppet-puppet/pull/444.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/444","number":444,"state":"open","locked":false,"title":"fixes #15550 - start Puppet agent after server is running","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Ensures no race condition will occur between the generate CA step of the\r\nserver configuration and the agent starting up, generating its own\r\nprivate key.\r\n\r\n---\r\n\r\nThe agent started by `puppet::agent::service` generates its private key _after_ forking (if entropy is low, it might even take a while), and so this might otherwise happen at the same time as `puppet::server::config` calling `puppet cert generate`. If the agent is slower to write to disk, its key overwrites the one used by the generate command to create the new certificate.","created_at":"2016-10-17T11:17:37Z","updated_at":"2016-10-17T17:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"059ce3b63f698be44538e8f84ea46002643e1f27","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/444/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/10f0c44d52d155b288749f063626433bc5e06a1d","head":{"label":"domcleal:15550-master-agent-service-order","ref":"15550-master-agent-service-order","sha":"10f0c44d52d155b288749f063626433bc5e06a1d","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"repo":{"id":6615584,"name":"puppet-puppet","full_name":"domcleal/puppet-puppet","owner":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/domcleal/puppet-puppet","description":"Puppet module for Puppet client and server","fork":true,"url":"https://api.github.com/repos/domcleal/puppet-puppet","forks_url":"https://api.github.com/repos/domcleal/puppet-puppet/forks","keys_url":"https://api.github.com/repos/domcleal/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domcleal/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domcleal/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/domcleal/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/domcleal/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/domcleal/puppet-puppet/events","assignees_url":"https://api.github.com/repos/domcleal/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/domcleal/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/domcleal/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/domcleal/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domcleal/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domcleal/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/domcleal/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domcleal/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/domcleal/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/domcleal/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/domcleal/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/domcleal/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/domcleal/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/domcleal/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/domcleal/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/domcleal/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/domcleal/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/domcleal/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/domcleal/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domcleal/puppet-puppet/merges","archive_url":"https://api.github.com/repos/domcleal/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domcleal/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/domcleal/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/domcleal/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/domcleal/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/domcleal/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domcleal/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/domcleal/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/domcleal/puppet-puppet/deployments","created_at":"2012-11-09T15:39:43Z","updated_at":"2015-02-18T17:06:17Z","pushed_at":"2016-10-17T14:39:07Z","git_url":"git://github.com/domcleal/puppet-puppet.git","ssh_url":"git@github.com:domcleal/puppet-puppet.git","clone_url":"https://github.com/domcleal/puppet-puppet.git","svn_url":"https://github.com/domcleal/puppet-puppet","homepage":"","size":855,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"38a8c2f2d2a2cdd9c40937909177874abf104d76","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449635,"name":"puppet-puppet","full_name":"theforeman/puppet-puppet","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-puppet","description":"Puppet module for Puppet client and server","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-puppet","forks_url":"https://api.github.com/repos/theforeman/puppet-puppet/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-puppet/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-puppet/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-puppet/deployments","created_at":"2012-02-15T13:23:34Z","updated_at":"2016-09-19T07:40:33Z","pushed_at":"2016-10-17T17:06:58Z","git_url":"git://github.com/theforeman/puppet-puppet.git","ssh_url":"git@github.com:theforeman/puppet-puppet.git","clone_url":"https://github.com/theforeman/puppet-puppet.git","svn_url":"https://github.com/theforeman/puppet-puppet","homepage":"","size":1247,"stargazers_count":55,"watchers_count":55,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":21,"forks":151,"open_issues":21,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/444"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/444"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/10f0c44d52d155b288749f063626433bc5e06a1d"}}}}
{"actor":{"display_login":"mmoll"}}