{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/53267718","id":53267718,"diff_hunk":"@@ -730,6 +741,14 @@ enum UseLexicalScopeFlag {\n     UseLexicalScope,\n }\n \n+#[allow(dead_code)]\n+enum LookupTarget {\n+    // Lookup only in the current crate\n+    CurrentCrate,","path":"src/librustc_resolve/lib.rs","position":83,"original_position":83,"commit_id":"686814b8ffc9d4aa6b7788c67989f5529b5ceaf6","original_commit_id":"686814b8ffc9d4aa6b7788c67989f5529b5ceaf6","user":{"login":"VladUreche","id":428706,"avatar_url":"https://avatars.githubusercontent.com/u/428706?v=3","gravatar_id":"","url":"https://api.github.com/users/VladUreche","html_url":"https://github.com/VladUreche","followers_url":"https://api.github.com/users/VladUreche/followers","following_url":"https://api.github.com/users/VladUreche/following{/other_user}","gists_url":"https://api.github.com/users/VladUreche/gists{/gist_id}","starred_url":"https://api.github.com/users/VladUreche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladUreche/subscriptions","organizations_url":"https://api.github.com/users/VladUreche/orgs","repos_url":"https://api.github.com/users/VladUreche/repos","events_url":"https://api.github.com/users/VladUreche/events{/privacy}","received_events_url":"https://api.github.com/users/VladUreche/received_events","type":"User","site_admin":false},"body":"Good question. Originally I was looking only in the current crate, but it makes more sense to always look everywhere.\r\nShould I remove it?","created_at":"2016-02-18T03:29:49Z","updated_at":"2016-02-18T03:29:49Z","html_url":"https://github.com/rust-lang/rust/pull/31674#discussion_r53267718","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/31674","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/53267718"},"html":{"href":"https://github.com/rust-lang/rust/pull/31674#discussion_r53267718"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31674"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/31674","id":59355777,"html_url":"https://github.com/rust-lang/rust/pull/31674","diff_url":"https://github.com/rust-lang/rust/pull/31674.diff","patch_url":"https://github.com/rust-lang/rust/pull/31674.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/31674","number":31674,"state":"open","locked":false,"title":"Bug #21221: Show candidates for names not in scope","user":{"login":"VladUreche","id":428706,"avatar_url":"https://avatars.githubusercontent.com/u/428706?v=3","gravatar_id":"","url":"https://api.github.com/users/VladUreche","html_url":"https://github.com/VladUreche","followers_url":"https://api.github.com/users/VladUreche/followers","following_url":"https://api.github.com/users/VladUreche/following{/other_user}","gists_url":"https://api.github.com/users/VladUreche/gists{/gist_id}","starred_url":"https://api.github.com/users/VladUreche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladUreche/subscriptions","organizations_url":"https://api.github.com/users/VladUreche/orgs","repos_url":"https://api.github.com/users/VladUreche/repos","events_url":"https://api.github.com/users/VladUreche/events{/privacy}","received_events_url":"https://api.github.com/users/VladUreche/received_events","type":"User","site_admin":false},"body":"This commit adds functionality that allows the name resolution pass\r\nto search for entities (traits/types/enums/structs) by name, in\r\norder to show recommendations along with the errors.\r\n\r\nFor now, only E0405 and E0412 have suggestions attached, as per the\r\nrequest in bug #21221, but it's likely other errors can also benefit\r\nfrom the ability to generate suggestions.","created_at":"2016-02-15T12:10:56Z","updated_at":"2016-02-18T03:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"273e7d85b1fe69f4d0274683777339a70eb8c286","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/31674/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/31674/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/31674/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/686814b8ffc9d4aa6b7788c67989f5529b5ceaf6","head":{"label":"VladUreche:issue/21221","ref":"issue/21221","sha":"686814b8ffc9d4aa6b7788c67989f5529b5ceaf6","user":{"login":"VladUreche","id":428706,"avatar_url":"https://avatars.githubusercontent.com/u/428706?v=3","gravatar_id":"","url":"https://api.github.com/users/VladUreche","html_url":"https://github.com/VladUreche","followers_url":"https://api.github.com/users/VladUreche/followers","following_url":"https://api.github.com/users/VladUreche/following{/other_user}","gists_url":"https://api.github.com/users/VladUreche/gists{/gist_id}","starred_url":"https://api.github.com/users/VladUreche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladUreche/subscriptions","organizations_url":"https://api.github.com/users/VladUreche/orgs","repos_url":"https://api.github.com/users/VladUreche/repos","events_url":"https://api.github.com/users/VladUreche/events{/privacy}","received_events_url":"https://api.github.com/users/VladUreche/received_events","type":"User","site_admin":false},"repo":{"id":51617370,"name":"rust","full_name":"VladUreche/rust","owner":{"login":"VladUreche","id":428706,"avatar_url":"https://avatars.githubusercontent.com/u/428706?v=3","gravatar_id":"","url":"https://api.github.com/users/VladUreche","html_url":"https://github.com/VladUreche","followers_url":"https://api.github.com/users/VladUreche/followers","following_url":"https://api.github.com/users/VladUreche/following{/other_user}","gists_url":"https://api.github.com/users/VladUreche/gists{/gist_id}","starred_url":"https://api.github.com/users/VladUreche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladUreche/subscriptions","organizations_url":"https://api.github.com/users/VladUreche/orgs","repos_url":"https://api.github.com/users/VladUreche/repos","events_url":"https://api.github.com/users/VladUreche/events{/privacy}","received_events_url":"https://api.github.com/users/VladUreche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VladUreche/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/VladUreche/rust","forks_url":"https://api.github.com/repos/VladUreche/rust/forks","keys_url":"https://api.github.com/repos/VladUreche/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladUreche/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladUreche/rust/teams","hooks_url":"https://api.github.com/repos/VladUreche/rust/hooks","issue_events_url":"https://api.github.com/repos/VladUreche/rust/issues/events{/number}","events_url":"https://api.github.com/repos/VladUreche/rust/events","assignees_url":"https://api.github.com/repos/VladUreche/rust/assignees{/user}","branches_url":"https://api.github.com/repos/VladUreche/rust/branches{/branch}","tags_url":"https://api.github.com/repos/VladUreche/rust/tags","blobs_url":"https://api.github.com/repos/VladUreche/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladUreche/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladUreche/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladUreche/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladUreche/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/VladUreche/rust/languages","stargazers_url":"https://api.github.com/repos/VladUreche/rust/stargazers","contributors_url":"https://api.github.com/repos/VladUreche/rust/contributors","subscribers_url":"https://api.github.com/repos/VladUreche/rust/subscribers","subscription_url":"https://api.github.com/repos/VladUreche/rust/subscription","commits_url":"https://api.github.com/repos/VladUreche/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladUreche/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladUreche/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladUreche/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladUreche/rust/contents/{+path}","compare_url":"https://api.github.com/repos/VladUreche/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladUreche/rust/merges","archive_url":"https://api.github.com/repos/VladUreche/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladUreche/rust/downloads","issues_url":"https://api.github.com/repos/VladUreche/rust/issues{/number}","pulls_url":"https://api.github.com/repos/VladUreche/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/VladUreche/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/VladUreche/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladUreche/rust/labels{/name}","releases_url":"https://api.github.com/repos/VladUreche/rust/releases{/id}","deployments_url":"https://api.github.com/repos/VladUreche/rust/deployments","created_at":"2016-02-12T21:23:36Z","updated_at":"2016-02-12T21:24:16Z","pushed_at":"2016-02-17T12:04:10Z","git_url":"git://github.com/VladUreche/rust.git","ssh_url":"git@github.com:VladUreche/rust.git","clone_url":"https://github.com/VladUreche/rust.git","svn_url":"https://github.com/VladUreche/rust","homepage":"http://www.rust-lang.org","size":280523,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0d1cd9bd6ac65e2a3fa8a1519fd368de79d5bfb5","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-02-18T02:11:03Z","pushed_at":"2016-02-18T02:49:32Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":471421,"stargazers_count":15341,"watchers_count":15341,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2979,"mirror_url":null,"open_issues_count":2309,"forks":2979,"open_issues":2309,"watchers":15341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31674"},"html":{"href":"https://github.com/rust-lang/rust/pull/31674"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31674"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/31674/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31674/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/31674/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/686814b8ffc9d4aa6b7788c67989f5529b5ceaf6"}}}}