{"action":"created","comment":{"url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/comments/82519440","pull_request_review_id":3423100,"id":82519440,"diff_hunk":"@@ -25,7 +25,7 @@ main :: IO ()\n main = mapM_ (\\example -> resetScreen >> example) examples\n \n resetScreen :: IO ()\n-resetScreen = clearScreen >> setSGR [Reset] >> setCursorPosition 0 0\n+resetScreen = setSGR [Reset] >> clearScreen >> setCursorPosition 0 0","path":"System/Console/ANSI/Example.hs","position":5,"original_position":5,"commit_id":"ad187ba8978c22ec5cbdd3abf7a54b7099258f2d","original_commit_id":"ad187ba8978c22ec5cbdd3abf7a54b7099258f2d","user":{"login":"feuerbach","id":24844,"avatar_url":"https://avatars.githubusercontent.com/u/24844?v=3","gravatar_id":"","url":"https://api.github.com/users/feuerbach","html_url":"https://github.com/feuerbach","followers_url":"https://api.github.com/users/feuerbach/followers","following_url":"https://api.github.com/users/feuerbach/following{/other_user}","gists_url":"https://api.github.com/users/feuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/feuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feuerbach/subscriptions","organizations_url":"https://api.github.com/users/feuerbach/orgs","repos_url":"https://api.github.com/users/feuerbach/repos","events_url":"https://api.github.com/users/feuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/feuerbach/received_events","type":"User","site_admin":false},"body":"Is this order important? If so, perhaps it should be documented somewhere?","created_at":"2016-10-09T10:21:26Z","updated_at":"2016-10-09T10:21:26Z","html_url":"https://github.com/feuerbach/ansi-terminal/pull/13#discussion_r82519440","pull_request_url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/comments/82519440"},"html":{"href":"https://github.com/feuerbach/ansi-terminal/pull/13#discussion_r82519440"},"pull_request":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13","id":83332735,"html_url":"https://github.com/feuerbach/ansi-terminal/pull/13","diff_url":"https://github.com/feuerbach/ansi-terminal/pull/13.diff","patch_url":"https://github.com/feuerbach/ansi-terminal/pull/13.patch","issue_url":"https://api.github.com/repos/feuerbach/ansi-terminal/issues/13","number":13,"state":"open","locked":false,"title":"Windows >= 10.0.10586, greater ANSI support","user":{"login":"mpilgrem","id":14206448,"avatar_url":"https://avatars.githubusercontent.com/u/14206448?v=3","gravatar_id":"","url":"https://api.github.com/users/mpilgrem","html_url":"https://github.com/mpilgrem","followers_url":"https://api.github.com/users/mpilgrem/followers","following_url":"https://api.github.com/users/mpilgrem/following{/other_user}","gists_url":"https://api.github.com/users/mpilgrem/gists{/gist_id}","starred_url":"https://api.github.com/users/mpilgrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpilgrem/subscriptions","organizations_url":"https://api.github.com/users/mpilgrem/orgs","repos_url":"https://api.github.com/users/mpilgrem/repos","events_url":"https://api.github.com/users/mpilgrem/events{/privacy}","received_events_url":"https://api.github.com/users/mpilgrem/received_events","type":"User","site_admin":false},"body":"This is the first time I have ever 'forked' anything, and I am not at all experienced with Haskell. I am conscious that over 100 other packages depend on `ansi-terminal` and I would not want to 'break' anything. This pull request is largely my experimenting - I do not expect it will be of much use to anyone.\r\n\r\nWith those caveats:\r\n\r\n`module System.Info.Windows` is intended to be able to detect the version of Windows, making use of, and parsing, Windows' `VER` command's output. It relies on the `process` package.\r\n\r\n`module System.Console.ANSI.Windows` chooses between the `U` (Unix - or, perhaps, 'universal') or `E` (emulated) functions, depending on `windowsVersion` via `isANSIVersion` - save for the `SetTitle` (where a control code sequence is not used) and `ScrollPageUp\\Down` (where Microsoft does not appear to have implemented the code sequences, despite its documentation), where the `E` functions are always used.\r\n\r\nIn `Example.hs`, I slowed down the `pause` (because examples were going past too quickly for me to follow). I also swapped the order in `resetScreen` because filling the screen with spaces first before resetting to the default was giving unexpected results when  `SetUnderlining DoubleUnderline` did nothing after `SetUnderlining SingleUnderline` had previously been applied in the examples.\r\n\r\nI used `stack` to build and test (on a Windows 10 PC using Command Prompt only - no other terminals or OSs have been tried), so I amended `.gitignore` to include ignoring the configuration file and the working folder.\r\n\r\nIn the `.cabal` file, I added `process` and `System.Info.Windows`. `stack` complained that `other-modules` were missing when it built the example, so I added them too. I've bumped the minor version up one, to 0.6.2.4.","created_at":"2016-08-30T19:33:43Z","updated_at":"2016-10-09T10:34:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c65eb95fa0b4a2d914a11253aab8e04724b81a07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13/commits","review_comments_url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13/comments","review_comment_url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feuerbach/ansi-terminal/issues/13/comments","statuses_url":"https://api.github.com/repos/feuerbach/ansi-terminal/statuses/ad187ba8978c22ec5cbdd3abf7a54b7099258f2d","head":{"label":"mpilgrem:windows10","ref":"windows10","sha":"ad187ba8978c22ec5cbdd3abf7a54b7099258f2d","user":{"login":"mpilgrem","id":14206448,"avatar_url":"https://avatars.githubusercontent.com/u/14206448?v=3","gravatar_id":"","url":"https://api.github.com/users/mpilgrem","html_url":"https://github.com/mpilgrem","followers_url":"https://api.github.com/users/mpilgrem/followers","following_url":"https://api.github.com/users/mpilgrem/following{/other_user}","gists_url":"https://api.github.com/users/mpilgrem/gists{/gist_id}","starred_url":"https://api.github.com/users/mpilgrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpilgrem/subscriptions","organizations_url":"https://api.github.com/users/mpilgrem/orgs","repos_url":"https://api.github.com/users/mpilgrem/repos","events_url":"https://api.github.com/users/mpilgrem/events{/privacy}","received_events_url":"https://api.github.com/users/mpilgrem/received_events","type":"User","site_admin":false},"repo":{"id":66877164,"name":"ansi-terminal","full_name":"mpilgrem/ansi-terminal","owner":{"login":"mpilgrem","id":14206448,"avatar_url":"https://avatars.githubusercontent.com/u/14206448?v=3","gravatar_id":"","url":"https://api.github.com/users/mpilgrem","html_url":"https://github.com/mpilgrem","followers_url":"https://api.github.com/users/mpilgrem/followers","following_url":"https://api.github.com/users/mpilgrem/following{/other_user}","gists_url":"https://api.github.com/users/mpilgrem/gists{/gist_id}","starred_url":"https://api.github.com/users/mpilgrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpilgrem/subscriptions","organizations_url":"https://api.github.com/users/mpilgrem/orgs","repos_url":"https://api.github.com/users/mpilgrem/repos","events_url":"https://api.github.com/users/mpilgrem/events{/privacy}","received_events_url":"https://api.github.com/users/mpilgrem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpilgrem/ansi-terminal","description":"ANSI terminal support for Haskell, with Windows compatibility","fork":true,"url":"https://api.github.com/repos/mpilgrem/ansi-terminal","forks_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/forks","keys_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/teams","hooks_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/hooks","issue_events_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/issues/events{/number}","events_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/events","assignees_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/assignees{/user}","branches_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/branches{/branch}","tags_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/tags","blobs_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/languages","stargazers_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/stargazers","contributors_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/contributors","subscribers_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/subscribers","subscription_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/subscription","commits_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/contents/{+path}","compare_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/merges","archive_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/downloads","issues_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/issues{/number}","pulls_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/labels{/name}","releases_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/releases{/id}","deployments_url":"https://api.github.com/repos/mpilgrem/ansi-terminal/deployments","created_at":"2016-08-29T20:14:11Z","updated_at":"2016-08-29T20:14:12Z","pushed_at":"2016-10-03T21:50:00Z","git_url":"git://github.com/mpilgrem/ansi-terminal.git","ssh_url":"git@github.com:mpilgrem/ansi-terminal.git","clone_url":"https://github.com/mpilgrem/ansi-terminal.git","svn_url":"https://github.com/mpilgrem/ansi-terminal","homepage":"","size":97,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feuerbach:master","ref":"master","sha":"391f4f30c98be8a751994d4f1b0252849279f1b4","user":{"login":"feuerbach","id":24844,"avatar_url":"https://avatars.githubusercontent.com/u/24844?v=3","gravatar_id":"","url":"https://api.github.com/users/feuerbach","html_url":"https://github.com/feuerbach","followers_url":"https://api.github.com/users/feuerbach/followers","following_url":"https://api.github.com/users/feuerbach/following{/other_user}","gists_url":"https://api.github.com/users/feuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/feuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feuerbach/subscriptions","organizations_url":"https://api.github.com/users/feuerbach/orgs","repos_url":"https://api.github.com/users/feuerbach/repos","events_url":"https://api.github.com/users/feuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/feuerbach/received_events","type":"User","site_admin":false},"repo":{"id":15224185,"name":"ansi-terminal","full_name":"feuerbach/ansi-terminal","owner":{"login":"feuerbach","id":24844,"avatar_url":"https://avatars.githubusercontent.com/u/24844?v=3","gravatar_id":"","url":"https://api.github.com/users/feuerbach","html_url":"https://github.com/feuerbach","followers_url":"https://api.github.com/users/feuerbach/followers","following_url":"https://api.github.com/users/feuerbach/following{/other_user}","gists_url":"https://api.github.com/users/feuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/feuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feuerbach/subscriptions","organizations_url":"https://api.github.com/users/feuerbach/orgs","repos_url":"https://api.github.com/users/feuerbach/repos","events_url":"https://api.github.com/users/feuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/feuerbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feuerbach/ansi-terminal","description":"ANSI terminal support for Haskell, with Windows compatibility","fork":false,"url":"https://api.github.com/repos/feuerbach/ansi-terminal","forks_url":"https://api.github.com/repos/feuerbach/ansi-terminal/forks","keys_url":"https://api.github.com/repos/feuerbach/ansi-terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feuerbach/ansi-terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feuerbach/ansi-terminal/teams","hooks_url":"https://api.github.com/repos/feuerbach/ansi-terminal/hooks","issue_events_url":"https://api.github.com/repos/feuerbach/ansi-terminal/issues/events{/number}","events_url":"https://api.github.com/repos/feuerbach/ansi-terminal/events","assignees_url":"https://api.github.com/repos/feuerbach/ansi-terminal/assignees{/user}","branches_url":"https://api.github.com/repos/feuerbach/ansi-terminal/branches{/branch}","tags_url":"https://api.github.com/repos/feuerbach/ansi-terminal/tags","blobs_url":"https://api.github.com/repos/feuerbach/ansi-terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feuerbach/ansi-terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feuerbach/ansi-terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/feuerbach/ansi-terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feuerbach/ansi-terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/feuerbach/ansi-terminal/languages","stargazers_url":"https://api.github.com/repos/feuerbach/ansi-terminal/stargazers","contributors_url":"https://api.github.com/repos/feuerbach/ansi-terminal/contributors","subscribers_url":"https://api.github.com/repos/feuerbach/ansi-terminal/subscribers","subscription_url":"https://api.github.com/repos/feuerbach/ansi-terminal/subscription","commits_url":"https://api.github.com/repos/feuerbach/ansi-terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/feuerbach/ansi-terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/feuerbach/ansi-terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/feuerbach/ansi-terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/feuerbach/ansi-terminal/contents/{+path}","compare_url":"https://api.github.com/repos/feuerbach/ansi-terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feuerbach/ansi-terminal/merges","archive_url":"https://api.github.com/repos/feuerbach/ansi-terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feuerbach/ansi-terminal/downloads","issues_url":"https://api.github.com/repos/feuerbach/ansi-terminal/issues{/number}","pulls_url":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/feuerbach/ansi-terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/feuerbach/ansi-terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feuerbach/ansi-terminal/labels{/name}","releases_url":"https://api.github.com/repos/feuerbach/ansi-terminal/releases{/id}","deployments_url":"https://api.github.com/repos/feuerbach/ansi-terminal/deployments","created_at":"2013-12-16T11:32:21Z","updated_at":"2016-10-07T17:04:56Z","pushed_at":"2016-10-09T10:07:58Z","git_url":"git://github.com/feuerbach/ansi-terminal.git","ssh_url":"git@github.com:feuerbach/ansi-terminal.git","clone_url":"https://github.com/feuerbach/ansi-terminal.git","svn_url":"https://github.com/feuerbach/ansi-terminal","homepage":"","size":220,"stargazers_count":20,"watchers_count":20,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13"},"html":{"href":"https://github.com/feuerbach/ansi-terminal/pull/13"},"issue":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/issues/13"},"comments":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/feuerbach/ansi-terminal/statuses/ad187ba8978c22ec5cbdd3abf7a54b7099258f2d"}}}}
{"actor":{"display_login":"feuerbach"}}