{"action":"created","issue":{"url":"https://api.github.com/repos/s-macke/jor1k/issues/117","repository_url":"https://api.github.com/repos/s-macke/jor1k","labels_url":"https://api.github.com/repos/s-macke/jor1k/issues/117/labels{/name}","comments_url":"https://api.github.com/repos/s-macke/jor1k/issues/117/comments","events_url":"https://api.github.com/repos/s-macke/jor1k/issues/117/events","html_url":"https://github.com/s-macke/jor1k/issues/117","id":145780887,"number":117,"title":"Decide on strategy to support authentication/authorization so that multiple relay providers can be used","user":{"login":"gdm85","id":7117866,"avatar_url":"https://avatars.githubusercontent.com/u/7117866?v=3","gravatar_id":"","url":"https://api.github.com/users/gdm85","html_url":"https://github.com/gdm85","followers_url":"https://api.github.com/users/gdm85/followers","following_url":"https://api.github.com/users/gdm85/following{/other_user}","gists_url":"https://api.github.com/users/gdm85/gists{/gist_id}","starred_url":"https://api.github.com/users/gdm85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdm85/subscriptions","organizations_url":"https://api.github.com/users/gdm85/orgs","repos_url":"https://api.github.com/users/gdm85/repos","events_url":"https://api.github.com/users/gdm85/events{/privacy}","received_events_url":"https://api.github.com/users/gdm85/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-04T19:27:08Z","updated_at":"2016-04-07T08:36:30Z","closed_at":null,"body":"Sorry if this is the wrong way to communicate with you guys, however please note that I have ported Benjamin's websockproxy to Go and just added a reference here:\r\n\r\nhttps://github.com/s-macke/jor1k/wiki/Network-support/_compare/6946626baab0b9a0f23f25f7476499cde02b6165...de4254df4906d475b277168a45fc3e922a11864a\r\n\r\nHope it will be of use; in particular I think it may be useful for use with Docker containers and when persistent TAP will be supported (it's planned).\r\n\r\nI have not submitted patches for AUTH support, however I may if you think it's an useful addition. This is how it would work:\r\n1. if the querystring variable `authKey` is specified, then send a special `AUTH` frame when the websocket connects\r\n\r\nYou can see a rough version of this here: https://github.com/gdm85/jor1k/commit/cfa0181e511958a4606a7d1ebc121d4708cde7b9\r\n\r\nJust to be precise, the AUTH feature I added is **optional** and current go-websockproxy works as a replacement for the python version.\r\n\r\nhttps://github.com/gdm85/go-websockproxy"},"comment":{"url":"https://api.github.com/repos/s-macke/jor1k/issues/comments/206760346","html_url":"https://github.com/s-macke/jor1k/issues/117#issuecomment-206760346","issue_url":"https://api.github.com/repos/s-macke/jor1k/issues/117","id":206760346,"user":{"login":"benjamincburns","id":803016,"avatar_url":"https://avatars.githubusercontent.com/u/803016?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamincburns","html_url":"https://github.com/benjamincburns","followers_url":"https://api.github.com/users/benjamincburns/followers","following_url":"https://api.github.com/users/benjamincburns/following{/other_user}","gists_url":"https://api.github.com/users/benjamincburns/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamincburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamincburns/subscriptions","organizations_url":"https://api.github.com/users/benjamincburns/orgs","repos_url":"https://api.github.com/users/benjamincburns/repos","events_url":"https://api.github.com/users/benjamincburns/events{/privacy}","received_events_url":"https://api.github.com/users/benjamincburns/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T08:36:29Z","updated_at":"2016-04-07T08:36:29Z","body":"No worries, and I apologize if I seemed offended. I find it's best in\nconversations like this to be a bit more explicit and deliberate than I\nnormally would be just to make sure my point comes across.\n\nRegarding implementing, I'm a bit biased since I proposed the scheme, so I\ndefer to @s-macke as he will ultimately need to maintain it on the jor1k\nside. Otherwise I'm certainly keen.\n\nOn Thu, Apr 7, 2016, 19:34 gdm85 <notifications@github.com> wrote:\n\n> @benjamincburns <https://github.com/benjamincburns> sorry I didn't mean\n> to say that you were proposing http auth/digest, I was just telling a case\n> where websockets show a difference with common HTTP.\n>\n> As per the /capabilities endpoint you proposed, I already said it sounds\n> very good to me and would allow even a scenario without the lossy ethernet\n> frame drops. The cable connect/disconnect also sounds really nice if it is\n> ever planned/implemented.\n>\n> Maybe I was not explicit enough, thanks for the detailed explanation (I am\n> sure other readers will benefit from it too): I am willing to implement it\n> as you said and it could definitely work with POST+cookies. I also\n> understand that there could be better implementations, but honestly a\n> /capabilities endpoint and POST with cookie sounds already very fair to\n> me.\n>\n> So I guess I shall go on and implement this in the Go version? At least as\n> a prototype branch\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/s-macke/jor1k/issues/117#issuecomment-206739188>\n>\n"}}