{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/130","id":73236820,"html_url":"https://github.com/openzfs/openzfs/pull/130","diff_url":"https://github.com/openzfs/openzfs/pull/130.diff","patch_url":"https://github.com/openzfs/openzfs/pull/130.patch","issue_url":"https://api.github.com/repos/openzfs/openzfs/issues/130","number":130,"state":"closed","locked":false,"title":"7090 zfs should improve allocation order and throttle allocations","user":{"login":"grwilson","id":595369,"avatar_url":"https://avatars.githubusercontent.com/u/595369?v=3","gravatar_id":"","url":"https://api.github.com/users/grwilson","html_url":"https://github.com/grwilson","followers_url":"https://api.github.com/users/grwilson/followers","following_url":"https://api.github.com/users/grwilson/following{/other_user}","gists_url":"https://api.github.com/users/grwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/grwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grwilson/subscriptions","organizations_url":"https://api.github.com/users/grwilson/orgs","repos_url":"https://api.github.com/users/grwilson/repos","events_url":"https://api.github.com/users/grwilson/events{/privacy}","received_events_url":"https://api.github.com/users/grwilson/received_events","type":"User","site_admin":false},"body":"Reviewed by: Matthew Ahrens <mahrens@delphix.com>\r\nReviewed by: Sebastien Roy <sebastien.roy@delphix.com>\r\nReviewed by: Alex Reece <alex@delphix.com>\r\nReviewed by: Prakash Surya <prakash.surya@delphix.com>\r\nReviewed by: Adam Leventhal <ahl@delphix.com>\r\nReviewed by: Christopher Siden <christopher.siden@delphix.com>\r\nReviewed by: Paul Dagnelie <paul.dagnelie@delphix.com>\r\nReviewed by: Dan Kimmel <dan.kimmel@delphix.com>\r\n\r\nWhen write I/Os are issued, they are issued in block order but the ZIO pipeline will drive them asynchronously through the allocation stage which can result in blocks being allocated out-of-order. It would be nice to preserve as much of the logical order as possible.\r\n\r\nIn addition, the allocations are equally scattered across all top-level VDEVs but not all top-level VDEVs are created equally. The pipeline should be able to detect devices that are more capable of handling allocations and should allocate more blocks to those devices. This allows for dynamic allocation distribution when devices are imbalanced as fuller devices will tend to be slower than empty devices.\r\n\r\nThe change includes a new pool-wide allocation queue which would throttle and order allocations in the ZIO pipeline. The queue would be ordered by issued time and offset and would provide an initial amount of allocation of work to each top-level vdev. The allocation logic utilizes a reservation system to reserve allocations that will be performed by the allocator. Once an allocation is successfully completed it's scheduled on a given top-level vdev. Each top-level vdev maintains a maximum number of allocations that it can handle (mg_alloc_queue_depth). The pool-wide reserved allocations (top-levels * mg_alloc_queue_depth) are distributed across the top-level vdevs metaslab groups and round robin across all eligible metaslab groups to distribute the work. As top-levels complete their work, they receive additional work from the pool-wide allocation queue until the allocation queue is emptied.\r\n\r\nUpstream bugs:\r\n32514 allocations should be ordered\r\n32515 throttle allocations on slow devices\r\n35487 dcenter panics with double fault\r\n35731 allocation throttle unnecessarily induces ganging\r\n36145 ztest fails in dbuf_verify: buf[i] == 0, due to dedup and bp_override\r\n39061 allocations fail on newly added devices\r\nDLPX-31466 allocation throttle does not throttle\r\nDLPX-36032 allocation throttled zio gets stuck behind other tasks in taskq\r\nDLPX-36110 allocation throttle should be enabled by default\r\nDLPX-40445 sometimes a dedup-ed, bp_override I/O can fail to be written","created_at":"2016-06-09T15:38:49Z","updated_at":"2016-08-02T16:43:06Z","closed_at":"2016-08-02T16:43:06Z","merged_at":null,"merge_commit_sha":"715a2c976d95af5335270daaac9b25273ae919fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzfs/openzfs/pulls/130/commits","review_comments_url":"https://api.github.com/repos/openzfs/openzfs/pulls/130/comments","review_comment_url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzfs/openzfs/issues/130/comments","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/2dff4aa9f7eee6fc1897a0b0cfe3ea3afa8716de","head":{"label":"grwilson:throttle","ref":"throttle","sha":"2dff4aa9f7eee6fc1897a0b0cfe3ea3afa8716de","user":{"login":"grwilson","id":595369,"avatar_url":"https://avatars.githubusercontent.com/u/595369?v=3","gravatar_id":"","url":"https://api.github.com/users/grwilson","html_url":"https://github.com/grwilson","followers_url":"https://api.github.com/users/grwilson/followers","following_url":"https://api.github.com/users/grwilson/following{/other_user}","gists_url":"https://api.github.com/users/grwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/grwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grwilson/subscriptions","organizations_url":"https://api.github.com/users/grwilson/orgs","repos_url":"https://api.github.com/users/grwilson/repos","events_url":"https://api.github.com/users/grwilson/events{/privacy}","received_events_url":"https://api.github.com/users/grwilson/received_events","type":"User","site_admin":false},"repo":{"id":44754032,"name":"openzfs","full_name":"grwilson/openzfs","owner":{"login":"grwilson","id":595369,"avatar_url":"https://avatars.githubusercontent.com/u/595369?v=3","gravatar_id":"","url":"https://api.github.com/users/grwilson","html_url":"https://github.com/grwilson","followers_url":"https://api.github.com/users/grwilson/followers","following_url":"https://api.github.com/users/grwilson/following{/other_user}","gists_url":"https://api.github.com/users/grwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/grwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grwilson/subscriptions","organizations_url":"https://api.github.com/users/grwilson/orgs","repos_url":"https://api.github.com/users/grwilson/repos","events_url":"https://api.github.com/users/grwilson/events{/privacy}","received_events_url":"https://api.github.com/users/grwilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grwilson/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/grwilson/openzfs","forks_url":"https://api.github.com/repos/grwilson/openzfs/forks","keys_url":"https://api.github.com/repos/grwilson/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grwilson/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grwilson/openzfs/teams","hooks_url":"https://api.github.com/repos/grwilson/openzfs/hooks","issue_events_url":"https://api.github.com/repos/grwilson/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/grwilson/openzfs/events","assignees_url":"https://api.github.com/repos/grwilson/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/grwilson/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/grwilson/openzfs/tags","blobs_url":"https://api.github.com/repos/grwilson/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grwilson/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grwilson/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/grwilson/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grwilson/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/grwilson/openzfs/languages","stargazers_url":"https://api.github.com/repos/grwilson/openzfs/stargazers","contributors_url":"https://api.github.com/repos/grwilson/openzfs/contributors","subscribers_url":"https://api.github.com/repos/grwilson/openzfs/subscribers","subscription_url":"https://api.github.com/repos/grwilson/openzfs/subscription","commits_url":"https://api.github.com/repos/grwilson/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/grwilson/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/grwilson/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/grwilson/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/grwilson/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/grwilson/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grwilson/openzfs/merges","archive_url":"https://api.github.com/repos/grwilson/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grwilson/openzfs/downloads","issues_url":"https://api.github.com/repos/grwilson/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/grwilson/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/grwilson/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/grwilson/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grwilson/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/grwilson/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/grwilson/openzfs/deployments","created_at":"2015-10-22T15:19:18Z","updated_at":"2016-02-10T14:38:40Z","pushed_at":"2016-07-22T19:13:09Z","git_url":"git://github.com/grwilson/openzfs.git","ssh_url":"git@github.com:grwilson/openzfs.git","clone_url":"https://github.com/grwilson/openzfs.git","svn_url":"https://github.com/grwilson/openzfs","homepage":"http://open-zfs.org","size":254526,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzfs:master","ref":"master","sha":"ec740b054b8de7985649ab4bd36c32cd0ebd6d6f","user":{"login":"openzfs","id":4510897,"avatar_url":"https://avatars.githubusercontent.com/u/4510897?v=3","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"repo":{"id":44220580,"name":"openzfs","full_name":"openzfs/openzfs","owner":{"login":"openzfs","id":4510897,"avatar_url":"https://avatars.githubusercontent.com/u/4510897?v=3","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfs/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/openzfs/openzfs","forks_url":"https://api.github.com/repos/openzfs/openzfs/forks","keys_url":"https://api.github.com/repos/openzfs/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfs/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfs/openzfs/teams","hooks_url":"https://api.github.com/repos/openzfs/openzfs/hooks","issue_events_url":"https://api.github.com/repos/openzfs/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/openzfs/openzfs/events","assignees_url":"https://api.github.com/repos/openzfs/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/openzfs/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/openzfs/openzfs/tags","blobs_url":"https://api.github.com/repos/openzfs/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfs/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfs/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfs/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfs/openzfs/languages","stargazers_url":"https://api.github.com/repos/openzfs/openzfs/stargazers","contributors_url":"https://api.github.com/repos/openzfs/openzfs/contributors","subscribers_url":"https://api.github.com/repos/openzfs/openzfs/subscribers","subscription_url":"https://api.github.com/repos/openzfs/openzfs/subscription","commits_url":"https://api.github.com/repos/openzfs/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfs/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfs/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfs/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzfs/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/openzfs/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfs/openzfs/merges","archive_url":"https://api.github.com/repos/openzfs/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfs/openzfs/downloads","issues_url":"https://api.github.com/repos/openzfs/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/openzfs/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfs/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfs/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfs/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/openzfs/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/openzfs/openzfs/deployments","created_at":"2015-10-14T03:03:50Z","updated_at":"2016-07-31T22:52:21Z","pushed_at":"2016-08-02T16:43:03Z","git_url":"git://github.com/openzfs/openzfs.git","ssh_url":"git@github.com:openzfs/openzfs.git","clone_url":"https://github.com/openzfs/openzfs.git","svn_url":"https://github.com/openzfs/openzfs","homepage":"http://open-zfs.org","size":254784,"stargazers_count":79,"watchers_count":79,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":40,"forks":28,"open_issues":40,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/130"},"html":{"href":"https://github.com/openzfs/openzfs/pull/130"},"issue":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/130"},"comments":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/openzfs/openzfs/statuses/2dff4aa9f7eee6fc1897a0b0cfe3ea3afa8716de"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1011,"deletions":208,"changed_files":17}}
{"actor":{"display_login":"ahrens"}}