{"action":"closed","number":2835,"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2835","id":81808493,"html_url":"https://github.com/sulu/sulu/pull/2835","diff_url":"https://github.com/sulu/sulu/pull/2835.diff","patch_url":"https://github.com/sulu/sulu/pull/2835.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2835","number":2835,"state":"closed","locked":false,"title":"Used the delegating file loader from symfony instead of own implementation for loading webspace xml files","user":{"login":"marcelmoosbrugger","id":1998663,"avatar_url":"https://avatars.githubusercontent.com/u/1998663?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelmoosbrugger","html_url":"https://github.com/marcelmoosbrugger","followers_url":"https://api.github.com/users/marcelmoosbrugger/followers","following_url":"https://api.github.com/users/marcelmoosbrugger/following{/other_user}","gists_url":"https://api.github.com/users/marcelmoosbrugger/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelmoosbrugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelmoosbrugger/subscriptions","organizations_url":"https://api.github.com/users/marcelmoosbrugger/orgs","repos_url":"https://api.github.com/users/marcelmoosbrugger/repos","events_url":"https://api.github.com/users/marcelmoosbrugger/events{/privacy}","received_events_url":"https://api.github.com/users/marcelmoosbrugger/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | no\r\n| New feature? | no\r\n| Enhancement? | yes\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | -\r\n| Related issues/PRs | -\r\n| License | MIT\r\n| Documentation PR | -\r\n\r\n#### What's in this PR?\r\n\r\nFor configuring webspaces there are currently two supported formats (one is deprecated). For that reason there were and still are two different XMLFileLoader. For choosing between the different XMLFileLoader there was another class named \"DelegatingFileLoader\". The behavior implemented by that class can completely be covered with classes provided by symfony. This PR removes the `DelegatingFileLoader` and makes the `WebspaceManager` use the classes from symfony instead.","created_at":"2016-08-18T12:39:39Z","updated_at":"2016-08-18T13:20:48Z","closed_at":"2016-08-18T13:20:47Z","merged_at":"2016-08-18T13:20:47Z","merge_commit_sha":"6320990f76863b74d4cec6b473f01bbcd403dd18","assignee":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"assignees":[{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/sulu/sulu/milestones/17","html_url":"https://github.com/sulu/sulu/milestones/Release%201.4","labels_url":"https://api.github.com/repos/sulu/sulu/milestones/17/labels","id":1656857,"number":17,"title":"Release 1.4","description":"","creator":{"login":"chirimoya","id":627313,"avatar_url":"https://avatars.githubusercontent.com/u/627313?v=3","gravatar_id":"","url":"https://api.github.com/users/chirimoya","html_url":"https://github.com/chirimoya","followers_url":"https://api.github.com/users/chirimoya/followers","following_url":"https://api.github.com/users/chirimoya/following{/other_user}","gists_url":"https://api.github.com/users/chirimoya/gists{/gist_id}","starred_url":"https://api.github.com/users/chirimoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirimoya/subscriptions","organizations_url":"https://api.github.com/users/chirimoya/orgs","repos_url":"https://api.github.com/users/chirimoya/repos","events_url":"https://api.github.com/users/chirimoya/events{/privacy}","received_events_url":"https://api.github.com/users/chirimoya/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":4,"state":"open","created_at":"2016-03-21T09:56:37Z","updated_at":"2016-08-18T13:20:48Z","due_on":"2016-10-12T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2835/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2835/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2835/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/2e1da9d922e5b6e2504b04c54fddc18a60701e07","head":{"label":"marcelmoosbrugger:enhancement/delegating-loader","ref":"enhancement/delegating-loader","sha":"2e1da9d922e5b6e2504b04c54fddc18a60701e07","user":{"login":"marcelmoosbrugger","id":1998663,"avatar_url":"https://avatars.githubusercontent.com/u/1998663?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelmoosbrugger","html_url":"https://github.com/marcelmoosbrugger","followers_url":"https://api.github.com/users/marcelmoosbrugger/followers","following_url":"https://api.github.com/users/marcelmoosbrugger/following{/other_user}","gists_url":"https://api.github.com/users/marcelmoosbrugger/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelmoosbrugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelmoosbrugger/subscriptions","organizations_url":"https://api.github.com/users/marcelmoosbrugger/orgs","repos_url":"https://api.github.com/users/marcelmoosbrugger/repos","events_url":"https://api.github.com/users/marcelmoosbrugger/events{/privacy}","received_events_url":"https://api.github.com/users/marcelmoosbrugger/received_events","type":"User","site_admin":false},"repo":{"id":62557084,"name":"sulu","full_name":"marcelmoosbrugger/sulu","owner":{"login":"marcelmoosbrugger","id":1998663,"avatar_url":"https://avatars.githubusercontent.com/u/1998663?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelmoosbrugger","html_url":"https://github.com/marcelmoosbrugger","followers_url":"https://api.github.com/users/marcelmoosbrugger/followers","following_url":"https://api.github.com/users/marcelmoosbrugger/following{/other_user}","gists_url":"https://api.github.com/users/marcelmoosbrugger/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelmoosbrugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelmoosbrugger/subscriptions","organizations_url":"https://api.github.com/users/marcelmoosbrugger/orgs","repos_url":"https://api.github.com/users/marcelmoosbrugger/repos","events_url":"https://api.github.com/users/marcelmoosbrugger/events{/privacy}","received_events_url":"https://api.github.com/users/marcelmoosbrugger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcelmoosbrugger/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/marcelmoosbrugger/sulu","forks_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/forks","keys_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/teams","hooks_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/hooks","issue_events_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/events","assignees_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/tags","blobs_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/languages","stargazers_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/stargazers","contributors_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/contributors","subscribers_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/subscribers","subscription_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/subscription","commits_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/merges","archive_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/downloads","issues_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/labels{/name}","releases_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/marcelmoosbrugger/sulu/deployments","created_at":"2016-07-04T11:26:26Z","updated_at":"2016-07-04T11:26:34Z","pushed_at":"2016-08-18T12:41:11Z","git_url":"git://github.com/marcelmoosbrugger/sulu.git","ssh_url":"git@github.com:marcelmoosbrugger/sulu.git","clone_url":"https://github.com/marcelmoosbrugger/sulu.git","svn_url":"https://github.com/marcelmoosbrugger/sulu","homepage":"sulu.io","size":80753,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"7ba150aa243d5fc14e1d7327a2fcdff918f20465","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-08-17T23:38:37Z","pushed_at":"2016-08-18T13:20:47Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":92245,"stargazers_count":145,"watchers_count":145,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":459,"forks":56,"open_issues":459,"watchers":145,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2835"},"html":{"href":"https://github.com/sulu/sulu/pull/2835"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2835"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2835/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2835/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2835/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/2e1da9d922e5b6e2504b04c54fddc18a60701e07"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":19,"deletions":150,"changed_files":6}}
{"actor":{"display_login":"danrot"}}