{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/82403690","pull_request_review_id":3315630,"id":82403690,"diff_hunk":"@@ -0,0 +1,99 @@\n+/*\n+ * Copyright (c) 2016, Ford Motor Company\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * Redistributions of source code must retain the above copyright notice, this\n+ * list of conditions and the following disclaimer.\n+ *\n+ * Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following\n+ * disclaimer in the documentation and/or other materials provided with the\n+ * distribution.\n+ *\n+ * Neither the name of the Ford Motor Company nor the names of its contributors\n+ * may be used to endorse or promote products derived from this software\n+ * without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include <stdint.h>\n+#include <string>\n+\n+#include \"gtest/gtest.h\"\n+#include \"application_manager/commands/commands_test.h\"\n+#include \"application_manager/commands/command_request_test.h\"\n+#include \"application_manager/mock_hmi_capabilities.h\"\n+#include \"application_manager/mock_application_manager.h\"\n+#include \"application_manager/mock_event_dispatcher.h\"\n+#include \"application_manager/commands/hmi/navi_is_ready_response.h\"\n+\n+namespace test {\n+namespace components {\n+namespace commands_test {\n+namespace hmi_commands_test {\n+namespace navi_is_ready_responce {\n+\n+namespace am = ::application_manager;\n+namespace commands = am::commands;\n+\n+using ::testing::ReturnRef;\n+using ::testing::Eq;\n+using ::utils::SharedPtr;\n+using commands::MessageSharedPtr;\n+using commands::ResponseFromHMI;\n+\n+typedef SharedPtr<ResponseFromHMI> ResponseFromHMIPtr;\n+\n+namespace {\n+const bool kNaviIsAvailable = true;\n+const bool kNaviIsNotAvailable = false;\n+}  // namespace\n+\n+class NaviIsReadyResponseTest\n+    : public CommandRequestTest<CommandsTestMocks::kIsNice> {\n+ public:\n+  void TestRunWithSpecificNaviState(const bool is_available) {\n+    application_manager_test::MockHMICapabilities mock_hmi_capabilities;\n+    MessageSharedPtr command_msg(CreateMessage(smart_objects::SmartType_Map));\n+    (*command_msg)[am::strings::msg_params][am::strings::available] =\n+        is_available;\n+\n+    ResponseFromHMIPtr command(\n+        CreateCommand<commands::NaviIsReadyResponse>(command_msg));\n+\n+    EXPECT_CALL(mock_app_manager_, hmi_capabilities())\n+        .WillOnce(ReturnRef(mock_hmi_capabilities));\n+    EXPECT_CALL(mock_hmi_capabilities,\n+                set_is_navi_cooperating(Eq(is_available)));","path":"src/components/application_manager/test/commands/hmi/navi_is_ready_response_test.cc","position":null,"original_position":81,"commit_id":"90d82ed2395758746766341530cb36f3bba6e6cb","original_commit_id":"ab303cf382e281d7620c7f22f5b147e98b70d330","user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"body":"@LevchenkoS Fixed in 90d82ed","created_at":"2016-10-07T14:47:02Z","updated_at":"2016-10-07T14:47:02Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/877#discussion_r82403690","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/82403690"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/877#discussion_r82403690"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877","id":88277576,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/877","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/877.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/877.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/877","number":877,"state":"open","locked":false,"title":"Cover commands with unit tests","user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"body":"Covered code lines for following files:\r\n - navi_is_ready_response;\r\n - dial_number_request;\r\n - get_urls;\r\n - perform_audio_pass_thru_request; \r\n - show_constant_tbt_request.\r\n\r\nRelated task : APPLINK-28075\r\nReopened #862 ","created_at":"2016-10-06T14:51:46Z","updated_at":"2016-10-07T14:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f66d7906a3b8e256115a862763ef2723cc704f12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/877/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/90d82ed2395758746766341530cb36f3bba6e6cb","head":{"label":"dcherniev:feature/Fully_cover_commands_with_unit_tests","ref":"feature/Fully_cover_commands_with_unit_tests","sha":"90d82ed2395758746766341530cb36f3bba6e6cb","user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"repo":{"id":69333178,"name":"sdl_core","full_name":"dcherniev/sdl_core","owner":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcherniev/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/dcherniev/sdl_core","forks_url":"https://api.github.com/repos/dcherniev/sdl_core/forks","keys_url":"https://api.github.com/repos/dcherniev/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcherniev/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcherniev/sdl_core/teams","hooks_url":"https://api.github.com/repos/dcherniev/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/dcherniev/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/dcherniev/sdl_core/events","assignees_url":"https://api.github.com/repos/dcherniev/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/dcherniev/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/dcherniev/sdl_core/tags","blobs_url":"https://api.github.com/repos/dcherniev/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcherniev/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcherniev/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcherniev/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcherniev/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/dcherniev/sdl_core/languages","stargazers_url":"https://api.github.com/repos/dcherniev/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/dcherniev/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/dcherniev/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/dcherniev/sdl_core/subscription","commits_url":"https://api.github.com/repos/dcherniev/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcherniev/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcherniev/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcherniev/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcherniev/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/dcherniev/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcherniev/sdl_core/merges","archive_url":"https://api.github.com/repos/dcherniev/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcherniev/sdl_core/downloads","issues_url":"https://api.github.com/repos/dcherniev/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/dcherniev/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/dcherniev/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/dcherniev/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcherniev/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/dcherniev/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/dcherniev/sdl_core/deployments","created_at":"2016-09-27T07:59:09Z","updated_at":"2016-09-27T07:59:18Z","pushed_at":"2016-10-07T14:43:25Z","git_url":"git://github.com/dcherniev/sdl_core.git","ssh_url":"git@github.com:dcherniev/sdl_core.git","clone_url":"https://github.com/dcherniev/sdl_core.git","svn_url":"https://github.com/dcherniev/sdl_core","homepage":"","size":177029,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:feature/pre_5_0_0_modifications","ref":"feature/pre_5_0_0_modifications","sha":"b70320791a0355a1cbc285a1b67c7ca39b62803d","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-09-29T03:18:39Z","pushed_at":"2016-10-07T14:43:25Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":313090,"stargazers_count":79,"watchers_count":79,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":92,"forks":99,"open_issues":92,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/877"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/877"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/877/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/877/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/90d82ed2395758746766341530cb36f3bba6e6cb"}}}}
{"actor":{"display_login":"dcherniev"}}