{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5743","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5743/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5743/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5743/events","html_url":"https://github.com/NREL/EnergyPlus/pull/5743","id":161699625,"number":5743,"title":"Add auto-sizing capability for Nominal Air Flow Rate and Nominal Air Face Velocity in Desiccant BalancedFlow Performance DataType1 object","user":{"login":"Nigusse","id":5805126,"avatar_url":"https://avatars.githubusercontent.com/u/5805126?v=3","gravatar_id":"","url":"https://api.github.com/users/Nigusse","html_url":"https://github.com/Nigusse","followers_url":"https://api.github.com/users/Nigusse/followers","following_url":"https://api.github.com/users/Nigusse/following{/other_user}","gists_url":"https://api.github.com/users/Nigusse/gists{/gist_id}","starred_url":"https://api.github.com/users/Nigusse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nigusse/subscriptions","organizations_url":"https://api.github.com/users/Nigusse/orgs","repos_url":"https://api.github.com/users/Nigusse/repos","events_url":"https://api.github.com/users/Nigusse/events{/privacy}","received_events_url":"https://api.github.com/users/Nigusse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Defect","name":"Defect","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"assignees":[{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-06-22T14:33:47Z","updated_at":"2016-07-14T13:31:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5743","html_url":"https://github.com/NREL/EnergyPlus/pull/5743","diff_url":"https://github.com/NREL/EnergyPlus/pull/5743.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5743.patch"},"body":"Addressed 5465\r\n\r\nPull request overview\r\n---------------------\r\nAdded auto-sizing capability for Nominal Air Flow Rate and Nominal Air Face Velocity in Desiccant BalancedFlow Performance DataType1 object.  Also consolidated Heat Recovery sizing into ReportSzingingManager routine. \r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/232665957","html_url":"https://github.com/NREL/EnergyPlus/pull/5743#issuecomment-232665957","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5743","id":232665957,"user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars.githubusercontent.com/u/5778156?v=3","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T13:31:52Z","updated_at":"2016-07-14T13:31:52Z","body":"Review results of CI. Changes to eio file is what is expected when changing local model sizing to instead use the RequestSizing function. New inputs for autosizing appear to be working correctly. Other warnings in err file are due to other branches (surfaces < 6 and surfaces < 3 use reciprocity). Warnings reported from CI have been eliminated. All checks are green and have passed."}}
{"actor":{"display_login":"rraustad"}}