{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/85345448","pull_request_review_id":6066953,"id":85345448,"diff_hunk":"@@ -39,7 +44,7 @@ static ARM_DRIVER_STORAGE *cfstore_svm_storage_drv = &ARM_Driver_Storage_MTD_K64\n #endif /* CFSTORE_CONFIG_BACKEND_FLASH_ENABLED */\n \n /* the storage volume manager instance used to generate virtual mtd descriptors */\n-static StorageVolumeManager volumeManager;\n+StorageVolumeManager volumeManager;","path":"features/storage/FEATURE_STORAGE/cfstore/source/cfstore_svm.cpp","position":19,"original_position":19,"commit_id":"8876b7ef3878d26717f73af3e6cb39a015720a2a","original_commit_id":"8876b7ef3878d26717f73af3e6cb39a015720a2a","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars.githubusercontent.com/u/2963726?v=3","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"why was it static previously? shouldn't there be a getter rather than global scope symbol?","created_at":"2016-10-27T14:14:28Z","updated_at":"2016-10-27T14:14:28Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/3143#discussion_r85345448","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/85345448"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3143#discussion_r85345448"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143","id":91163574,"html_url":"https://github.com/ARMmbed/mbed-os/pull/3143","diff_url":"https://github.com/ARMmbed/mbed-os/pull/3143.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/3143.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3143","number":3143,"state":"open","locked":false,"title":"CFStore fix needed for the Cloud Client","user":{"login":"marcuschangarm","id":7205609,"avatar_url":"https://avatars.githubusercontent.com/u/7205609?v=3","gravatar_id":"","url":"https://api.github.com/users/marcuschangarm","html_url":"https://github.com/marcuschangarm","followers_url":"https://api.github.com/users/marcuschangarm/followers","following_url":"https://api.github.com/users/marcuschangarm/following{/other_user}","gists_url":"https://api.github.com/users/marcuschangarm/gists{/gist_id}","starred_url":"https://api.github.com/users/marcuschangarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcuschangarm/subscriptions","organizations_url":"https://api.github.com/users/marcuschangarm/orgs","repos_url":"https://api.github.com/users/marcuschangarm/repos","events_url":"https://api.github.com/users/marcuschangarm/events{/privacy}","received_events_url":"https://api.github.com/users/marcuschangarm/received_events","type":"User","site_admin":false},"body":"Removed static declaration for the StorageVolumeManager in the CFStore. The StorageVolumeManager must be accessible to all users of the region covered by the manager.\r\n\r\nAlso added define guards to the CFStore size and location so that these can be changed in the configuration file and not hard coded.\r\n","created_at":"2016-10-27T09:28:59Z","updated_at":"2016-10-27T14:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18c15adae977340ac94fd2e6a63b45d9856600f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3143/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/8876b7ef3878d26717f73af3e6cb39a015720a2a","head":{"label":"marcuschangarm:config-store-fix","ref":"config-store-fix","sha":"8876b7ef3878d26717f73af3e6cb39a015720a2a","user":{"login":"marcuschangarm","id":7205609,"avatar_url":"https://avatars.githubusercontent.com/u/7205609?v=3","gravatar_id":"","url":"https://api.github.com/users/marcuschangarm","html_url":"https://github.com/marcuschangarm","followers_url":"https://api.github.com/users/marcuschangarm/followers","following_url":"https://api.github.com/users/marcuschangarm/following{/other_user}","gists_url":"https://api.github.com/users/marcuschangarm/gists{/gist_id}","starred_url":"https://api.github.com/users/marcuschangarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcuschangarm/subscriptions","organizations_url":"https://api.github.com/users/marcuschangarm/orgs","repos_url":"https://api.github.com/users/marcuschangarm/repos","events_url":"https://api.github.com/users/marcuschangarm/events{/privacy}","received_events_url":"https://api.github.com/users/marcuschangarm/received_events","type":"User","site_admin":false},"repo":{"id":72091329,"name":"mbed-os","full_name":"marcuschangarm/mbed-os","owner":{"login":"marcuschangarm","id":7205609,"avatar_url":"https://avatars.githubusercontent.com/u/7205609?v=3","gravatar_id":"","url":"https://api.github.com/users/marcuschangarm","html_url":"https://github.com/marcuschangarm","followers_url":"https://api.github.com/users/marcuschangarm/followers","following_url":"https://api.github.com/users/marcuschangarm/following{/other_user}","gists_url":"https://api.github.com/users/marcuschangarm/gists{/gist_id}","starred_url":"https://api.github.com/users/marcuschangarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcuschangarm/subscriptions","organizations_url":"https://api.github.com/users/marcuschangarm/orgs","repos_url":"https://api.github.com/users/marcuschangarm/repos","events_url":"https://api.github.com/users/marcuschangarm/events{/privacy}","received_events_url":"https://api.github.com/users/marcuschangarm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcuschangarm/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/marcuschangarm/mbed-os","forks_url":"https://api.github.com/repos/marcuschangarm/mbed-os/forks","keys_url":"https://api.github.com/repos/marcuschangarm/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcuschangarm/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcuschangarm/mbed-os/teams","hooks_url":"https://api.github.com/repos/marcuschangarm/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/marcuschangarm/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/marcuschangarm/mbed-os/events","assignees_url":"https://api.github.com/repos/marcuschangarm/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/marcuschangarm/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/marcuschangarm/mbed-os/tags","blobs_url":"https://api.github.com/repos/marcuschangarm/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcuschangarm/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcuschangarm/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcuschangarm/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcuschangarm/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/marcuschangarm/mbed-os/languages","stargazers_url":"https://api.github.com/repos/marcuschangarm/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/marcuschangarm/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/marcuschangarm/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/marcuschangarm/mbed-os/subscription","commits_url":"https://api.github.com/repos/marcuschangarm/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcuschangarm/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcuschangarm/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcuschangarm/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcuschangarm/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/marcuschangarm/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcuschangarm/mbed-os/merges","archive_url":"https://api.github.com/repos/marcuschangarm/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcuschangarm/mbed-os/downloads","issues_url":"https://api.github.com/repos/marcuschangarm/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/marcuschangarm/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/marcuschangarm/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/marcuschangarm/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcuschangarm/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/marcuschangarm/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/marcuschangarm/mbed-os/deployments","created_at":"2016-10-27T09:12:14Z","updated_at":"2016-10-27T09:13:45Z","pushed_at":"2016-10-27T09:25:20Z","git_url":"git://github.com/marcuschangarm/mbed-os.git","ssh_url":"git@github.com:marcuschangarm/mbed-os.git","clone_url":"https://github.com/marcuschangarm/mbed-os.git","svn_url":"https://github.com/marcuschangarm/mbed-os","homepage":"https://mbed.com","size":86958,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"f33088b7e46eaaabe7bb6657c46c53aa8de6807b","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-10-27T03:00:16Z","pushed_at":"2016-10-27T13:58:27Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":108188,"stargazers_count":789,"watchers_count":789,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":788,"mirror_url":null,"open_issues_count":401,"forks":788,"open_issues":401,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3143"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3143"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3143/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3143/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/8876b7ef3878d26717f73af3e6cb39a015720a2a"}}}}
{"actor":{"display_login":"0xc0170"}}