{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material/issues/8893","repository_url":"https://api.github.com/repos/angular/material","labels_url":"https://api.github.com/repos/angular/material/issues/8893/labels{/name}","comments_url":"https://api.github.com/repos/angular/material/issues/8893/comments","events_url":"https://api.github.com/repos/angular/material/issues/8893/events","html_url":"https://github.com/angular/material/pull/8893","id":162787142,"number":8893,"title":"fix(select): Allow non-english characters for keyboard selection.","user":{"login":"topherfangio","id":54370,"avatar_url":"https://avatars.githubusercontent.com/u/54370?v=3","gravatar_id":"","url":"https://api.github.com/users/topherfangio","html_url":"https://github.com/topherfangio","followers_url":"https://api.github.com/users/topherfangio/followers","following_url":"https://api.github.com/users/topherfangio/following{/other_user}","gists_url":"https://api.github.com/users/topherfangio/gists{/gist_id}","starred_url":"https://api.github.com/users/topherfangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topherfangio/subscriptions","organizations_url":"https://api.github.com/users/topherfangio/orgs","repos_url":"https://api.github.com/users/topherfangio/repos","events_url":"https://api.github.com/users/topherfangio/events{/privacy}","received_events_url":"https://api.github.com/users/topherfangio/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/material/labels/needs:%20review","name":"needs: review","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T21:04:40Z","updated_at":"2016-07-01T01:31:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/material/pulls/8893","html_url":"https://github.com/angular/material/pull/8893","diff_url":"https://github.com/angular/material/pull/8893.diff","patch_url":"https://github.com/angular/material/pull/8893.patch"},"body":"Our previous method for checking whether or not the typed character matched the first letter of an `<md-option>` was constrained to the letters `[a-zA-Z]`.\r\n\r\nFix by allowing more characters and checking the validity via the `String.fromCharCode()` method.\r\n\r\nFixes #7730."},"comment":{"url":"https://api.github.com/repos/angular/material/issues/comments/229832758","html_url":"https://github.com/angular/material/pull/8893#issuecomment-229832758","issue_url":"https://api.github.com/repos/angular/material/issues/8893","id":229832758,"user":{"login":"topherfangio","id":54370,"avatar_url":"https://avatars.githubusercontent.com/u/54370?v=3","gravatar_id":"","url":"https://api.github.com/users/topherfangio","html_url":"https://github.com/topherfangio","followers_url":"https://api.github.com/users/topherfangio/followers","following_url":"https://api.github.com/users/topherfangio/following{/other_user}","gists_url":"https://api.github.com/users/topherfangio/gists{/gist_id}","starred_url":"https://api.github.com/users/topherfangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topherfangio/subscriptions","organizations_url":"https://api.github.com/users/topherfangio/orgs","repos_url":"https://api.github.com/users/topherfangio/repos","events_url":"https://api.github.com/users/topherfangio/events{/privacy}","received_events_url":"https://api.github.com/users/topherfangio/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T01:31:08Z","updated_at":"2016-07-01T01:31:08Z","body":"I looked at switching it out from using keyCode, but the replacement is supposed to be [KeyboardEvent.key](https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key) which as far as I can tell from the Browser Compatibility list is extremely unsupported at the moment (it has 0 support from Safari and only became available in Chrome 51...the current version).\r\n\r\nI'm certainly open to changing it if we can find a better approach, but I'm honestly thinking we might just wait until `.key` becomes more widely supported and replace it then."}}
{"actor":{"display_login":"topherfangio"}}