{"action":"created","comment":{"url":"https://api.github.com/repos/firehol/netdata/pulls/comments/81194602","pull_request_review_id":2192779,"id":81194602,"diff_hunk":"@@ -60,18 +60,16 @@\n #include <zlib.h>\n #endif\n \n-#ifdef __GNUC__\n-#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)\n-\n-#if __x86_64__ || __ppc64__\n+#if (SIZEOF_VOID_P == 8)\n #define ENVIRONMENT64\n-#else\n+#elif (SIZEOF_VOID_P == 4)\n #define ENVIRONMENT32\n+#else\n+#error \"Cannot detect if this is a 32 or 64 bit CPU\"\n #endif\n \n-#else // !__GNUC__\n-#define NETDATA_NO_ATOMIC_INSTRUCTIONS 1\n-#define ENVIRONMENT32\n+#ifdef __GNUC__\n+#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__)","path":"src/common.h","position":21,"original_position":21,"commit_id":"0713b7dd22f7744289a06aa352bdacaa7fbcdc0c","original_commit_id":"0713b7dd22f7744289a06aa352bdacaa7fbcdc0c","user":{"login":"alonbl","id":1263789,"avatar_url":"https://avatars.githubusercontent.com/u/1263789?v=3","gravatar_id":"","url":"https://api.github.com/users/alonbl","html_url":"https://github.com/alonbl","followers_url":"https://api.github.com/users/alonbl/followers","following_url":"https://api.github.com/users/alonbl/following{/other_user}","gists_url":"https://api.github.com/users/alonbl/gists{/gist_id}","starred_url":"https://api.github.com/users/alonbl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonbl/subscriptions","organizations_url":"https://api.github.com/users/alonbl/orgs","repos_url":"https://api.github.com/users/alonbl/repos","events_url":"https://api.github.com/users/alonbl/events{/privacy}","received_events_url":"https://api.github.com/users/alonbl/received_events","type":"User","site_admin":false},"body":"I hope this is not used for anything.","created_at":"2016-09-29T17:48:02Z","updated_at":"2016-09-29T17:48:02Z","html_url":"https://github.com/firehol/netdata/pull/1032#discussion_r81194602","pull_request_url":"https://api.github.com/repos/firehol/netdata/pulls/1032","_links":{"self":{"href":"https://api.github.com/repos/firehol/netdata/pulls/comments/81194602"},"html":{"href":"https://github.com/firehol/netdata/pull/1032#discussion_r81194602"},"pull_request":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1032"}}},"pull_request":{"url":"https://api.github.com/repos/firehol/netdata/pulls/1032","id":87030932,"html_url":"https://github.com/firehol/netdata/pull/1032","diff_url":"https://github.com/firehol/netdata/pull/1032.diff","patch_url":"https://github.com/firehol/netdata/pull/1032.patch","issue_url":"https://api.github.com/repos/firehol/netdata/issues/1032","number":1032,"state":"closed","locked":false,"title":"32/64 bit cpu detection with autoconf","user":{"login":"ktsaou","id":2662304,"avatar_url":"https://avatars.githubusercontent.com/u/2662304?v=3","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"body":"@alonbl please review this.\r\nIs this what you had in mind?","created_at":"2016-09-27T23:29:53Z","updated_at":"2016-09-29T17:48:02Z","closed_at":"2016-09-28T15:28:27Z","merged_at":"2016-09-28T15:28:27Z","merge_commit_sha":"7e4d6904404b6777a83046de3edca8a7a5df10c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/firehol/netdata/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/firehol/netdata/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/firehol/netdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firehol/netdata/issues/1032/comments","statuses_url":"https://api.github.com/repos/firehol/netdata/statuses/0713b7dd22f7744289a06aa352bdacaa7fbcdc0c","head":{"label":"ktsaou:master","ref":"master","sha":"0713b7dd22f7744289a06aa352bdacaa7fbcdc0c","user":{"login":"ktsaou","id":2662304,"avatar_url":"https://avatars.githubusercontent.com/u/2662304?v=3","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"repo":{"id":55527319,"name":"netdata","full_name":"ktsaou/netdata","owner":{"login":"ktsaou","id":2662304,"avatar_url":"https://avatars.githubusercontent.com/u/2662304?v=3","gravatar_id":"","url":"https://api.github.com/users/ktsaou","html_url":"https://github.com/ktsaou","followers_url":"https://api.github.com/users/ktsaou/followers","following_url":"https://api.github.com/users/ktsaou/following{/other_user}","gists_url":"https://api.github.com/users/ktsaou/gists{/gist_id}","starred_url":"https://api.github.com/users/ktsaou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktsaou/subscriptions","organizations_url":"https://api.github.com/users/ktsaou/orgs","repos_url":"https://api.github.com/users/ktsaou/repos","events_url":"https://api.github.com/users/ktsaou/events{/privacy}","received_events_url":"https://api.github.com/users/ktsaou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktsaou/netdata","description":"Real-time performance monitoring, done right!","fork":true,"url":"https://api.github.com/repos/ktsaou/netdata","forks_url":"https://api.github.com/repos/ktsaou/netdata/forks","keys_url":"https://api.github.com/repos/ktsaou/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktsaou/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktsaou/netdata/teams","hooks_url":"https://api.github.com/repos/ktsaou/netdata/hooks","issue_events_url":"https://api.github.com/repos/ktsaou/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/ktsaou/netdata/events","assignees_url":"https://api.github.com/repos/ktsaou/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/ktsaou/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/ktsaou/netdata/tags","blobs_url":"https://api.github.com/repos/ktsaou/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktsaou/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktsaou/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktsaou/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktsaou/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/ktsaou/netdata/languages","stargazers_url":"https://api.github.com/repos/ktsaou/netdata/stargazers","contributors_url":"https://api.github.com/repos/ktsaou/netdata/contributors","subscribers_url":"https://api.github.com/repos/ktsaou/netdata/subscribers","subscription_url":"https://api.github.com/repos/ktsaou/netdata/subscription","commits_url":"https://api.github.com/repos/ktsaou/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktsaou/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktsaou/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktsaou/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktsaou/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/ktsaou/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktsaou/netdata/merges","archive_url":"https://api.github.com/repos/ktsaou/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktsaou/netdata/downloads","issues_url":"https://api.github.com/repos/ktsaou/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/ktsaou/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/ktsaou/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/ktsaou/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktsaou/netdata/labels{/name}","releases_url":"https://api.github.com/repos/ktsaou/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/ktsaou/netdata/deployments","created_at":"2016-04-05T17:17:22Z","updated_at":"2016-04-20T14:01:14Z","pushed_at":"2016-09-29T08:19:55Z","git_url":"git://github.com/ktsaou/netdata.git","ssh_url":"git@github.com:ktsaou/netdata.git","clone_url":"https://github.com/ktsaou/netdata.git","svn_url":"https://github.com/ktsaou/netdata","homepage":"http://netdata.firehol.org","size":6922,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firehol:master","ref":"master","sha":"6af22bc80d6e9829f0940d8bae6ceb1fe077e298","user":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"repo":{"id":10744183,"name":"netdata","full_name":"firehol/netdata","owner":{"login":"firehol","id":9442231,"avatar_url":"https://avatars.githubusercontent.com/u/9442231?v=3","gravatar_id":"","url":"https://api.github.com/users/firehol","html_url":"https://github.com/firehol","followers_url":"https://api.github.com/users/firehol/followers","following_url":"https://api.github.com/users/firehol/following{/other_user}","gists_url":"https://api.github.com/users/firehol/gists{/gist_id}","starred_url":"https://api.github.com/users/firehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firehol/subscriptions","organizations_url":"https://api.github.com/users/firehol/orgs","repos_url":"https://api.github.com/users/firehol/repos","events_url":"https://api.github.com/users/firehol/events{/privacy}","received_events_url":"https://api.github.com/users/firehol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firehol/netdata","description":"Real-time performance monitoring, done right!","fork":false,"url":"https://api.github.com/repos/firehol/netdata","forks_url":"https://api.github.com/repos/firehol/netdata/forks","keys_url":"https://api.github.com/repos/firehol/netdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firehol/netdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firehol/netdata/teams","hooks_url":"https://api.github.com/repos/firehol/netdata/hooks","issue_events_url":"https://api.github.com/repos/firehol/netdata/issues/events{/number}","events_url":"https://api.github.com/repos/firehol/netdata/events","assignees_url":"https://api.github.com/repos/firehol/netdata/assignees{/user}","branches_url":"https://api.github.com/repos/firehol/netdata/branches{/branch}","tags_url":"https://api.github.com/repos/firehol/netdata/tags","blobs_url":"https://api.github.com/repos/firehol/netdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firehol/netdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firehol/netdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/firehol/netdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firehol/netdata/statuses/{sha}","languages_url":"https://api.github.com/repos/firehol/netdata/languages","stargazers_url":"https://api.github.com/repos/firehol/netdata/stargazers","contributors_url":"https://api.github.com/repos/firehol/netdata/contributors","subscribers_url":"https://api.github.com/repos/firehol/netdata/subscribers","subscription_url":"https://api.github.com/repos/firehol/netdata/subscription","commits_url":"https://api.github.com/repos/firehol/netdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/firehol/netdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/firehol/netdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/firehol/netdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/firehol/netdata/contents/{+path}","compare_url":"https://api.github.com/repos/firehol/netdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firehol/netdata/merges","archive_url":"https://api.github.com/repos/firehol/netdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firehol/netdata/downloads","issues_url":"https://api.github.com/repos/firehol/netdata/issues{/number}","pulls_url":"https://api.github.com/repos/firehol/netdata/pulls{/number}","milestones_url":"https://api.github.com/repos/firehol/netdata/milestones{/number}","notifications_url":"https://api.github.com/repos/firehol/netdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firehol/netdata/labels{/name}","releases_url":"https://api.github.com/repos/firehol/netdata/releases{/id}","deployments_url":"https://api.github.com/repos/firehol/netdata/deployments","created_at":"2013-06-17T18:39:10Z","updated_at":"2016-09-29T17:47:00Z","pushed_at":"2016-09-29T08:22:56Z","git_url":"git://github.com/firehol/netdata.git","ssh_url":"git@github.com:firehol/netdata.git","clone_url":"https://github.com/firehol/netdata.git","svn_url":"https://github.com/firehol/netdata","homepage":"http://my-netdata.io","size":7725,"stargazers_count":14988,"watchers_count":14988,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1084,"mirror_url":null,"open_issues_count":154,"forks":1084,"open_issues":154,"watchers":14988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1032"},"html":{"href":"https://github.com/firehol/netdata/pull/1032"},"issue":{"href":"https://api.github.com/repos/firehol/netdata/issues/1032"},"comments":{"href":"https://api.github.com/repos/firehol/netdata/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/firehol/netdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firehol/netdata/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/firehol/netdata/statuses/0713b7dd22f7744289a06aa352bdacaa7fbcdc0c"}}}}
{"actor":{"display_login":"alonbl"}}