{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/49579915","id":49579915,"diff_hunk":"@@ -64,7 +64,7 @@ public void testResourceInclusion() {\n                 \"end\\n\";\n \n         String kmodule = \"<kmodule xmlns:xsi=\\\"http://www.w3.org/2001/XMLSchema-instance\\\" \\n\" +\n-                \"         xmlns=\\\"http://jboss.org/kie/6.0.0/kmodule\\\">\\n\" +\n+                \"         xmlns=\\\"http://www.drools.org/xsd/kmodule\\\">\\n\" +","path":"drools-compiler/src/test/java/org/drools/compiler/integrationtests/KieBuilderTest.java","position":5,"original_position":5,"commit_id":"8b9ec49f4d7d224ceb6ede73da1195e5455e7551","original_commit_id":"8b9ec49f4d7d224ceb6ede73da1195e5455e7551","user":{"login":"ge0ffrey","id":176880,"avatar_url":"https://avatars.githubusercontent.com/u/176880?v=3","gravatar_id":"","url":"https://api.github.com/users/ge0ffrey","html_url":"https://github.com/ge0ffrey","followers_url":"https://api.github.com/users/ge0ffrey/followers","following_url":"https://api.github.com/users/ge0ffrey/following{/other_user}","gists_url":"https://api.github.com/users/ge0ffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ge0ffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ge0ffrey/subscriptions","organizations_url":"https://api.github.com/users/ge0ffrey/orgs","repos_url":"https://api.github.com/users/ge0ffrey/repos","events_url":"https://api.github.com/users/ge0ffrey/events{/privacy}","received_events_url":"https://api.github.com/users/ge0ffrey/received_events","type":"User","site_admin":false},"body":"That test should indeed work with the old namespace. Let's duplicate that\ntest so the old namespace is tested too (as well as the new one).\n\nI am on PTO today, I'll try to take a look tomorrow\n\n2016-01-12 20:06 GMT+01:00 Mario Fusco <notifications@github.com>:\n\n> In\n> drools-compiler/src/test/java/org/drools/compiler/integrationtests/KieBuilderTest.java\n> <https://github.com/droolsjbpm/drools/pull/596#discussion_r49498241>:\n>\n> > @@ -64,7 +64,7 @@ public void testResourceInclusion() {\n> >                  \"end\\n\";\n> >\n> >          String kmodule = \"<kmodule xmlns:xsi=\\\"http://www.w3.org/2001/XMLSchema-instance\\\" \\n\" +\n> > -                \"         xmlns=\\\"http://jboss.org/kie/6.0.0/kmodule\\\">\\n\" +\n> > +                \"         xmlns=\\\"http://www.drools.org/xsd/kmodule\\\">\\n\" +\n>\n> @ge0ffrey <https://github.com/ge0ffrey> I think what you did broke\n> backward compatibility anyway. The old namespace should still work but if I\n> try to use the old one here this test fails.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/droolsjbpm/drools/pull/596/files#r49498241>.\n>\n\n\n\n-- \nWith kind regards / Met vriendelijke groeten,\nGeoffrey De Smet\n","created_at":"2016-01-13T11:39:28Z","updated_at":"2016-01-13T11:39:28Z","html_url":"https://github.com/droolsjbpm/drools/pull/596#discussion_r49579915","pull_request_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/596","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments/49579915"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/596#discussion_r49579915"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/596"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/drools/pulls/596","id":55601440,"html_url":"https://github.com/droolsjbpm/drools/pull/596","diff_url":"https://github.com/droolsjbpm/drools/pull/596.diff","patch_url":"https://github.com/droolsjbpm/drools/pull/596.patch","issue_url":"https://api.github.com/repos/droolsjbpm/drools/issues/596","number":596,"state":"open","locked":false,"title":"DROOLS-1023 Change kmodule.xsd targetNamespace to become versionless …","user":{"login":"ge0ffrey","id":176880,"avatar_url":"https://avatars.githubusercontent.com/u/176880?v=3","gravatar_id":"","url":"https://api.github.com/users/ge0ffrey","html_url":"https://github.com/ge0ffrey","followers_url":"https://api.github.com/users/ge0ffrey/followers","following_url":"https://api.github.com/users/ge0ffrey/following{/other_user}","gists_url":"https://api.github.com/users/ge0ffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ge0ffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ge0ffrey/subscriptions","organizations_url":"https://api.github.com/users/ge0ffrey/orgs","repos_url":"https://api.github.com/users/ge0ffrey/repos","events_url":"https://api.github.com/users/ge0ffrey/events{/privacy}","received_events_url":"https://api.github.com/users/ge0ffrey/received_events","type":"User","site_admin":false},"body":"DROOLS-1023 Change kmodule.xsd targetNamespace to become versionless (to avoid hardcoding \"6.0.0\" in it)","created_at":"2016-01-11T09:41:51Z","updated_at":"2016-01-13T11:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ab9269448f32de983237915654dec3c6ffdaade","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/596/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/596/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/issues/596/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/8b9ec49f4d7d224ceb6ede73da1195e5455e7551","head":{"label":"ge0ffrey:kmodule-xsd-patch","ref":"kmodule-xsd-patch","sha":"8b9ec49f4d7d224ceb6ede73da1195e5455e7551","user":{"login":"ge0ffrey","id":176880,"avatar_url":"https://avatars.githubusercontent.com/u/176880?v=3","gravatar_id":"","url":"https://api.github.com/users/ge0ffrey","html_url":"https://github.com/ge0ffrey","followers_url":"https://api.github.com/users/ge0ffrey/followers","following_url":"https://api.github.com/users/ge0ffrey/following{/other_user}","gists_url":"https://api.github.com/users/ge0ffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ge0ffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ge0ffrey/subscriptions","organizations_url":"https://api.github.com/users/ge0ffrey/orgs","repos_url":"https://api.github.com/users/ge0ffrey/repos","events_url":"https://api.github.com/users/ge0ffrey/events{/privacy}","received_events_url":"https://api.github.com/users/ge0ffrey/received_events","type":"User","site_admin":false},"repo":{"id":3864363,"name":"drools","full_name":"ge0ffrey/drools","owner":{"login":"ge0ffrey","id":176880,"avatar_url":"https://avatars.githubusercontent.com/u/176880?v=3","gravatar_id":"","url":"https://api.github.com/users/ge0ffrey","html_url":"https://github.com/ge0ffrey","followers_url":"https://api.github.com/users/ge0ffrey/followers","following_url":"https://api.github.com/users/ge0ffrey/following{/other_user}","gists_url":"https://api.github.com/users/ge0ffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ge0ffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ge0ffrey/subscriptions","organizations_url":"https://api.github.com/users/ge0ffrey/orgs","repos_url":"https://api.github.com/users/ge0ffrey/repos","events_url":"https://api.github.com/users/ge0ffrey/events{/privacy}","received_events_url":"https://api.github.com/users/ge0ffrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ge0ffrey/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/ge0ffrey/drools","forks_url":"https://api.github.com/repos/ge0ffrey/drools/forks","keys_url":"https://api.github.com/repos/ge0ffrey/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ge0ffrey/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ge0ffrey/drools/teams","hooks_url":"https://api.github.com/repos/ge0ffrey/drools/hooks","issue_events_url":"https://api.github.com/repos/ge0ffrey/drools/issues/events{/number}","events_url":"https://api.github.com/repos/ge0ffrey/drools/events","assignees_url":"https://api.github.com/repos/ge0ffrey/drools/assignees{/user}","branches_url":"https://api.github.com/repos/ge0ffrey/drools/branches{/branch}","tags_url":"https://api.github.com/repos/ge0ffrey/drools/tags","blobs_url":"https://api.github.com/repos/ge0ffrey/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ge0ffrey/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ge0ffrey/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ge0ffrey/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ge0ffrey/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/ge0ffrey/drools/languages","stargazers_url":"https://api.github.com/repos/ge0ffrey/drools/stargazers","contributors_url":"https://api.github.com/repos/ge0ffrey/drools/contributors","subscribers_url":"https://api.github.com/repos/ge0ffrey/drools/subscribers","subscription_url":"https://api.github.com/repos/ge0ffrey/drools/subscription","commits_url":"https://api.github.com/repos/ge0ffrey/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ge0ffrey/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ge0ffrey/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ge0ffrey/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ge0ffrey/drools/contents/{+path}","compare_url":"https://api.github.com/repos/ge0ffrey/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ge0ffrey/drools/merges","archive_url":"https://api.github.com/repos/ge0ffrey/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ge0ffrey/drools/downloads","issues_url":"https://api.github.com/repos/ge0ffrey/drools/issues{/number}","pulls_url":"https://api.github.com/repos/ge0ffrey/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/ge0ffrey/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/ge0ffrey/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ge0ffrey/drools/labels{/name}","releases_url":"https://api.github.com/repos/ge0ffrey/drools/releases{/id}","created_at":"2012-03-29T09:04:27Z","updated_at":"2013-01-08T11:16:57Z","pushed_at":"2016-01-11T09:41:13Z","git_url":"git://github.com/ge0ffrey/drools.git","ssh_url":"git@github.com:ge0ffrey/drools.git","clone_url":"https://github.com/ge0ffrey/drools.git","svn_url":"https://github.com/ge0ffrey/drools","homepage":"http://www.jboss.org/drools","size":134950,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"c38feb6acbe7a04ecbed3bea0f0fcfb064d22d9c","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"name":"drools","full_name":"droolsjbpm/drools","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/droolsjbpm/drools","forks_url":"https://api.github.com/repos/droolsjbpm/drools/forks","keys_url":"https://api.github.com/repos/droolsjbpm/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/drools/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/drools/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/drools/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/drools/events","assignees_url":"https://api.github.com/repos/droolsjbpm/drools/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/drools/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/drools/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/drools/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/drools/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/drools/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/drools/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/drools/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/drools/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/drools/merges","archive_url":"https://api.github.com/repos/droolsjbpm/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/drools/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/drools/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/drools/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/drools/releases{/id}","created_at":"2011-02-18T08:37:05Z","updated_at":"2016-01-13T04:56:18Z","pushed_at":"2016-01-13T03:58:09Z","git_url":"git://github.com/droolsjbpm/drools.git","ssh_url":"git@github.com:droolsjbpm/drools.git","clone_url":"https://github.com/droolsjbpm/drools.git","svn_url":"https://github.com/droolsjbpm/drools","homepage":"http://www.drools.org","size":236996,"stargazers_count":525,"watchers_count":525,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":751,"mirror_url":null,"open_issues_count":5,"forks":751,"open_issues":5,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/596"},"html":{"href":"https://github.com/droolsjbpm/drools/pull/596"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/596"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/issues/596/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/596/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/drools/pulls/596/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/drools/statuses/8b9ec49f4d7d224ceb6ede73da1195e5455e7551"}}}}