{"action":"created","issue":{"url":"https://api.github.com/repos/ethz-asl/kalibr/issues/65","repository_url":"https://api.github.com/repos/ethz-asl/kalibr","labels_url":"https://api.github.com/repos/ethz-asl/kalibr/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/ethz-asl/kalibr/issues/65/comments","events_url":"https://api.github.com/repos/ethz-asl/kalibr/issues/65/events","html_url":"https://github.com/ethz-asl/kalibr/pull/65","id":169303329,"number":65,"title":"Rolling Shutter Camera calibration","user":{"login":"othlu","id":1914635,"avatar_url":"https://avatars.githubusercontent.com/u/1914635?v=3","gravatar_id":"","url":"https://api.github.com/users/othlu","html_url":"https://github.com/othlu","followers_url":"https://api.github.com/users/othlu/followers","following_url":"https://api.github.com/users/othlu/following{/other_user}","gists_url":"https://api.github.com/users/othlu/gists{/gist_id}","starred_url":"https://api.github.com/users/othlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othlu/subscriptions","organizations_url":"https://api.github.com/users/othlu/orgs","repos_url":"https://api.github.com/users/othlu/repos","events_url":"https://api.github.com/users/othlu/events{/privacy}","received_events_url":"https://api.github.com/users/othlu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-04T06:51:31Z","updated_at":"2016-08-19T07:20:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethz-asl/kalibr/pulls/65","html_url":"https://github.com/ethz-asl/kalibr/pull/65","diff_url":"https://github.com/ethz-asl/kalibr/pull/65.diff","patch_url":"https://github.com/ethz-asl/kalibr/pull/65.patch"},"body":"A module to fully calibrate the intrinsics, distortion coefficients and line delay of rolling shutter cameras.\r\nBesides the python implementation it includes the following changes and fixes/improvements:\r\n_ disable obsolete CameraGeometryDesignVariableContainer in favor of CameraDesignVariable\r\n_ remove duplicate definitions of ReprojectionError from aslam_cv_backend\r\n_ CameraDesignVariable exposes a ScalarExpression representing the time at which a keypoint was observed\r\n_ exports ScalarExpressionNodeKeypointTime to python\r\n_ restore CovarainceReprojectionError which enables state-depending error term standardization\r\n_ CovarianceReprojectionError::observationTime() returned frame_time + 2* time offset\r\n_ Fix an issue in the DogLeg- and Base-TrustRegionPolicy that prevented the correct calculation of the trust region size and resulted in bad/no convergence\r\n\r\nThis PR repeats the one onto zurich-eye/Kalibr: https://github.com/zurich-eye/kalibr/pull/6"},"comment":{"url":"https://api.github.com/repos/ethz-asl/kalibr/issues/comments/240946658","html_url":"https://github.com/ethz-asl/kalibr/pull/65#issuecomment-240946658","issue_url":"https://api.github.com/repos/ethz-asl/kalibr/issues/65","id":240946658,"user":{"login":"othlu","id":1914635,"avatar_url":"https://avatars.githubusercontent.com/u/1914635?v=3","gravatar_id":"","url":"https://api.github.com/users/othlu","html_url":"https://github.com/othlu","followers_url":"https://api.github.com/users/othlu/followers","following_url":"https://api.github.com/users/othlu/following{/other_user}","gists_url":"https://api.github.com/users/othlu/gists{/gist_id}","starred_url":"https://api.github.com/users/othlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/othlu/subscriptions","organizations_url":"https://api.github.com/users/othlu/orgs","repos_url":"https://api.github.com/users/othlu/repos","events_url":"https://api.github.com/users/othlu/events{/privacy}","received_events_url":"https://api.github.com/users/othlu/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T07:20:16Z","updated_at":"2016-08-19T07:20:16Z","body":"We already fixed those issues when merging into another repo - they didn't make it into my branch. Sorry about that.\r\nWe renamed the `covarianceMatrix` to `covarianceMap`, as, strictly speaking, it is not a covariance matrix but a linear map for covariance matrices. The fix you did, isn't correct but should not break anything as the exported function isn't used in the calibration code."}}
{"actor":{"display_login":"othlu"}}