{"action":"created","comment":{"url":"https://api.github.com/repos/uber/jaeger-client-node/pulls/comments/83073334","pull_request_review_id":3938092,"id":83073334,"diff_hunk":"@@ -0,0 +1,164 @@\n+// Copyright (c) 2016 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+\n+import SpanContext from './span_context';\n+import Span from './span';\n+import ConstSampler from './samplers/const_sampler';\n+import InMemoryReporter from './reporters/in_memory_reporter';\n+import ProbabilisticSampler from './samplers/probabilistic_sampler';\n+import RateLimitingSampler from './samplers/ratelimiting_sampler';\n+import RemoteReporter from './reporters/remote_reporter';\n+import CompositeReporter from './reporters/composite_reporter';\n+import LoggingReporter from './reporters/logging_reporter';\n+import RemoteSampler from './samplers/remote_sampler';\n+import Tracer from './tracer';\n+import UDPSender from './reporters/udp_sender';\n+import {Validator} from 'jsonschema';\n+import Logtron from 'logtron';","path":"src/configuration.js","position":35,"original_position":35,"commit_id":"bd0d8b291e01f26ed4975118814a42c7c3368daf","original_commit_id":"bd0d8b291e01f26ed4975118814a42c7c3368daf","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars.githubusercontent.com/u/3523016?v=3","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"that is my point - we do not want prod dependency on logtron, in case other people use other loggers.","created_at":"2016-10-12T18:49:55Z","updated_at":"2016-10-12T18:49:55Z","html_url":"https://github.com/uber/jaeger-client-node/pull/27#discussion_r83073334","pull_request_url":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-node/pulls/comments/83073334"},"html":{"href":"https://github.com/uber/jaeger-client-node/pull/27#discussion_r83073334"},"pull_request":{"href":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27","id":88714276,"html_url":"https://github.com/uber/jaeger-client-node/pull/27","diff_url":"https://github.com/uber/jaeger-client-node/pull/27.diff","patch_url":"https://github.com/uber/jaeger-client-node/pull/27.patch","issue_url":"https://api.github.com/repos/uber/jaeger-client-node/issues/27","number":27,"state":"open","locked":false,"title":"Yaml config loading for Jaeger Tracer","user":{"login":"oibe","id":1320611,"avatar_url":"https://avatars.githubusercontent.com/u/1320611?v=3","gravatar_id":"","url":"https://api.github.com/users/oibe","html_url":"https://github.com/oibe","followers_url":"https://api.github.com/users/oibe/followers","following_url":"https://api.github.com/users/oibe/following{/other_user}","gists_url":"https://api.github.com/users/oibe/gists{/gist_id}","starred_url":"https://api.github.com/users/oibe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oibe/subscriptions","organizations_url":"https://api.github.com/users/oibe/orgs","repos_url":"https://api.github.com/users/oibe/repos","events_url":"https://api.github.com/users/oibe/events{/privacy}","received_events_url":"https://api.github.com/users/oibe/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-10T19:05:09Z","updated_at":"2016-10-12T18:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b7836a72e2bcdc5320e98c527a1ee6898b2f4c7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27/commits","review_comments_url":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27/comments","review_comment_url":"https://api.github.com/repos/uber/jaeger-client-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/jaeger-client-node/issues/27/comments","statuses_url":"https://api.github.com/repos/uber/jaeger-client-node/statuses/bd0d8b291e01f26ed4975118814a42c7c3368daf","head":{"label":"uber:create_yaml_parsing","ref":"create_yaml_parsing","sha":"bd0d8b291e01f26ed4975118814a42c7c3368daf","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56551035,"name":"jaeger-client-node","full_name":"uber/jaeger-client-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-node","description":"Jaeger Bindings for Javascript OpenTracing API","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-node","forks_url":"https://api.github.com/repos/uber/jaeger-client-node/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-node/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-node/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-node/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-node/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-node/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-node/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-node/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-node/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-node/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-node/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-node/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-node/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-node/deployments","created_at":"2016-04-19T00:11:04Z","updated_at":"2016-09-30T09:31:12Z","pushed_at":"2016-10-12T17:55:36Z","git_url":"git://github.com/uber/jaeger-client-node.git","ssh_url":"git@github.com:uber/jaeger-client-node.git","clone_url":"https://github.com/uber/jaeger-client-node.git","svn_url":"https://github.com/uber/jaeger-client-node","homepage":"","size":227,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"b2165341a212bbf1a6b4f72e14596e260938f318","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":56551035,"name":"jaeger-client-node","full_name":"uber/jaeger-client-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/jaeger-client-node","description":"Jaeger Bindings for Javascript OpenTracing API","fork":false,"url":"https://api.github.com/repos/uber/jaeger-client-node","forks_url":"https://api.github.com/repos/uber/jaeger-client-node/forks","keys_url":"https://api.github.com/repos/uber/jaeger-client-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/jaeger-client-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/jaeger-client-node/teams","hooks_url":"https://api.github.com/repos/uber/jaeger-client-node/hooks","issue_events_url":"https://api.github.com/repos/uber/jaeger-client-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/jaeger-client-node/events","assignees_url":"https://api.github.com/repos/uber/jaeger-client-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/jaeger-client-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/jaeger-client-node/tags","blobs_url":"https://api.github.com/repos/uber/jaeger-client-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/jaeger-client-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/jaeger-client-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/jaeger-client-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/jaeger-client-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/jaeger-client-node/languages","stargazers_url":"https://api.github.com/repos/uber/jaeger-client-node/stargazers","contributors_url":"https://api.github.com/repos/uber/jaeger-client-node/contributors","subscribers_url":"https://api.github.com/repos/uber/jaeger-client-node/subscribers","subscription_url":"https://api.github.com/repos/uber/jaeger-client-node/subscription","commits_url":"https://api.github.com/repos/uber/jaeger-client-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/jaeger-client-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/jaeger-client-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/jaeger-client-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/jaeger-client-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/jaeger-client-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/jaeger-client-node/merges","archive_url":"https://api.github.com/repos/uber/jaeger-client-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/jaeger-client-node/downloads","issues_url":"https://api.github.com/repos/uber/jaeger-client-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/jaeger-client-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/jaeger-client-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/jaeger-client-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/jaeger-client-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/jaeger-client-node/releases{/id}","deployments_url":"https://api.github.com/repos/uber/jaeger-client-node/deployments","created_at":"2016-04-19T00:11:04Z","updated_at":"2016-09-30T09:31:12Z","pushed_at":"2016-10-12T17:55:36Z","git_url":"git://github.com/uber/jaeger-client-node.git","ssh_url":"git@github.com:uber/jaeger-client-node.git","clone_url":"https://github.com/uber/jaeger-client-node.git","svn_url":"https://github.com/uber/jaeger-client-node","homepage":"","size":227,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27"},"html":{"href":"https://github.com/uber/jaeger-client-node/pull/27"},"issue":{"href":"https://api.github.com/repos/uber/jaeger-client-node/issues/27"},"comments":{"href":"https://api.github.com/repos/uber/jaeger-client-node/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/jaeger-client-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/jaeger-client-node/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/uber/jaeger-client-node/statuses/bd0d8b291e01f26ed4975118814a42c7c3368daf"}}}}
{"actor":{"display_login":"yurishkuro"}}