{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/scalding/pulls/comments/51639551","id":51639551,"diff_hunk":"@@ -0,0 +1,73 @@\n+package com.twitter.scalding\n+\n+object ArgOptions extends Enumeration {\n+  type ArgOptions = Value\n+  val RequiredArg, OptionalArg, ListArg, BooleanArg = Value\n+}\n+\n+class DescriptionArgs(override val m: Map[String, List[String]]) extends Args(m){","path":"scalding-core/src/main/scala/com/twitter/scalding/DescribedExecutionApp.scala","position":8,"original_position":8,"commit_id":"af0435b6a7e6ac749d185e9bb0430c99de3e734d","original_commit_id":"af0435b6a7e6ac749d185e9bb0430c99de3e734d","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"body":"why not put this in scalding-args package?","created_at":"2016-02-02T21:37:30Z","updated_at":"2016-02-02T21:37:30Z","html_url":"https://github.com/twitter/scalding/pull/1492#discussion_r51639551","pull_request_url":"https://api.github.com/repos/twitter/scalding/pulls/1492","_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments/51639551"},"html":{"href":"https://github.com/twitter/scalding/pull/1492#discussion_r51639551"},"pull_request":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1492"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/scalding/pulls/1492","id":58031344,"html_url":"https://github.com/twitter/scalding/pull/1492","diff_url":"https://github.com/twitter/scalding/pull/1492.diff","patch_url":"https://github.com/twitter/scalding/pull/1492.patch","issue_url":"https://api.github.com/repos/twitter/scalding/issues/1492","number":1492,"state":"open","locked":false,"title":"Arg Descriptions/Help for Execution Apps","user":{"login":"richwhitjr","id":202552,"avatar_url":"https://avatars.githubusercontent.com/u/202552?v=3","gravatar_id":"","url":"https://api.github.com/users/richwhitjr","html_url":"https://github.com/richwhitjr","followers_url":"https://api.github.com/users/richwhitjr/followers","following_url":"https://api.github.com/users/richwhitjr/following{/other_user}","gists_url":"https://api.github.com/users/richwhitjr/gists{/gist_id}","starred_url":"https://api.github.com/users/richwhitjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richwhitjr/subscriptions","organizations_url":"https://api.github.com/users/richwhitjr/orgs","repos_url":"https://api.github.com/users/richwhitjr/repos","events_url":"https://api.github.com/users/richwhitjr/events{/privacy}","received_events_url":"https://api.github.com/users/richwhitjr/received_events","type":"User","site_admin":false},"body":"Many times I think it would be helpful to have described Args for a Scalding Job so you can run a help command.  This is difficult though because of the lazy arg model used by Scalding.  I really didn't want to change Arg parsing in Scalding so instead this review does the simple thing and lets users add descriptions to Args and see the descriptions with a --help command option.\r\n\r\n","created_at":"2016-02-02T18:46:23Z","updated_at":"2016-02-02T21:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6814f8cdd9d5a452528cfd2de25370c9cea1817b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/scalding/pulls/1492/commits","review_comments_url":"https://api.github.com/repos/twitter/scalding/pulls/1492/comments","review_comment_url":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/scalding/issues/1492/comments","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/af0435b6a7e6ac749d185e9bb0430c99de3e734d","head":{"label":"richwhitjr:develop","ref":"develop","sha":"af0435b6a7e6ac749d185e9bb0430c99de3e734d","user":{"login":"richwhitjr","id":202552,"avatar_url":"https://avatars.githubusercontent.com/u/202552?v=3","gravatar_id":"","url":"https://api.github.com/users/richwhitjr","html_url":"https://github.com/richwhitjr","followers_url":"https://api.github.com/users/richwhitjr/followers","following_url":"https://api.github.com/users/richwhitjr/following{/other_user}","gists_url":"https://api.github.com/users/richwhitjr/gists{/gist_id}","starred_url":"https://api.github.com/users/richwhitjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richwhitjr/subscriptions","organizations_url":"https://api.github.com/users/richwhitjr/orgs","repos_url":"https://api.github.com/users/richwhitjr/repos","events_url":"https://api.github.com/users/richwhitjr/events{/privacy}","received_events_url":"https://api.github.com/users/richwhitjr/received_events","type":"User","site_admin":false},"repo":{"id":50117500,"name":"scalding","full_name":"richwhitjr/scalding","owner":{"login":"richwhitjr","id":202552,"avatar_url":"https://avatars.githubusercontent.com/u/202552?v=3","gravatar_id":"","url":"https://api.github.com/users/richwhitjr","html_url":"https://github.com/richwhitjr","followers_url":"https://api.github.com/users/richwhitjr/followers","following_url":"https://api.github.com/users/richwhitjr/following{/other_user}","gists_url":"https://api.github.com/users/richwhitjr/gists{/gist_id}","starred_url":"https://api.github.com/users/richwhitjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richwhitjr/subscriptions","organizations_url":"https://api.github.com/users/richwhitjr/orgs","repos_url":"https://api.github.com/users/richwhitjr/repos","events_url":"https://api.github.com/users/richwhitjr/events{/privacy}","received_events_url":"https://api.github.com/users/richwhitjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richwhitjr/scalding","description":"A Scala API for Cascading","fork":true,"url":"https://api.github.com/repos/richwhitjr/scalding","forks_url":"https://api.github.com/repos/richwhitjr/scalding/forks","keys_url":"https://api.github.com/repos/richwhitjr/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richwhitjr/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richwhitjr/scalding/teams","hooks_url":"https://api.github.com/repos/richwhitjr/scalding/hooks","issue_events_url":"https://api.github.com/repos/richwhitjr/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/richwhitjr/scalding/events","assignees_url":"https://api.github.com/repos/richwhitjr/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/richwhitjr/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/richwhitjr/scalding/tags","blobs_url":"https://api.github.com/repos/richwhitjr/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richwhitjr/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richwhitjr/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/richwhitjr/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richwhitjr/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/richwhitjr/scalding/languages","stargazers_url":"https://api.github.com/repos/richwhitjr/scalding/stargazers","contributors_url":"https://api.github.com/repos/richwhitjr/scalding/contributors","subscribers_url":"https://api.github.com/repos/richwhitjr/scalding/subscribers","subscription_url":"https://api.github.com/repos/richwhitjr/scalding/subscription","commits_url":"https://api.github.com/repos/richwhitjr/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/richwhitjr/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/richwhitjr/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/richwhitjr/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/richwhitjr/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/richwhitjr/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richwhitjr/scalding/merges","archive_url":"https://api.github.com/repos/richwhitjr/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richwhitjr/scalding/downloads","issues_url":"https://api.github.com/repos/richwhitjr/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/richwhitjr/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/richwhitjr/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/richwhitjr/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richwhitjr/scalding/labels{/name}","releases_url":"https://api.github.com/repos/richwhitjr/scalding/releases{/id}","deployments_url":"https://api.github.com/repos/richwhitjr/scalding/deployments","created_at":"2016-01-21T15:43:36Z","updated_at":"2016-01-21T15:43:38Z","pushed_at":"2016-02-02T18:42:22Z","git_url":"git://github.com/richwhitjr/scalding.git","ssh_url":"git@github.com:richwhitjr/scalding.git","clone_url":"https://github.com/richwhitjr/scalding.git","svn_url":"https://github.com/richwhitjr/scalding","homepage":"http://twitter.com/scalding","size":13296,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"e60da7167e5e472d23dee39c041480bf73a6422e","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3146558,"name":"scalding","full_name":"twitter/scalding","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/scalding","description":"A Scala API for Cascading","fork":false,"url":"https://api.github.com/repos/twitter/scalding","forks_url":"https://api.github.com/repos/twitter/scalding/forks","keys_url":"https://api.github.com/repos/twitter/scalding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/scalding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/scalding/teams","hooks_url":"https://api.github.com/repos/twitter/scalding/hooks","issue_events_url":"https://api.github.com/repos/twitter/scalding/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/scalding/events","assignees_url":"https://api.github.com/repos/twitter/scalding/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/scalding/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/scalding/tags","blobs_url":"https://api.github.com/repos/twitter/scalding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/scalding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/scalding/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/scalding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/scalding/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/scalding/languages","stargazers_url":"https://api.github.com/repos/twitter/scalding/stargazers","contributors_url":"https://api.github.com/repos/twitter/scalding/contributors","subscribers_url":"https://api.github.com/repos/twitter/scalding/subscribers","subscription_url":"https://api.github.com/repos/twitter/scalding/subscription","commits_url":"https://api.github.com/repos/twitter/scalding/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/scalding/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/scalding/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/scalding/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/scalding/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/scalding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/scalding/merges","archive_url":"https://api.github.com/repos/twitter/scalding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/scalding/downloads","issues_url":"https://api.github.com/repos/twitter/scalding/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/scalding/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/scalding/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/scalding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/scalding/labels{/name}","releases_url":"https://api.github.com/repos/twitter/scalding/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/scalding/deployments","created_at":"2012-01-10T16:22:08Z","updated_at":"2016-01-31T12:45:05Z","pushed_at":"2016-02-02T21:17:38Z","git_url":"git://github.com/twitter/scalding.git","ssh_url":"git@github.com:twitter/scalding.git","clone_url":"https://github.com/twitter/scalding.git","svn_url":"https://github.com/twitter/scalding","homepage":"http://twitter.com/scalding","size":15002,"stargazers_count":2420,"watchers_count":2420,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":559,"mirror_url":null,"open_issues_count":265,"forks":559,"open_issues":265,"watchers":2420,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1492"},"html":{"href":"https://github.com/twitter/scalding/pull/1492"},"issue":{"href":"https://api.github.com/repos/twitter/scalding/issues/1492"},"comments":{"href":"https://api.github.com/repos/twitter/scalding/issues/1492/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1492/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/scalding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/scalding/pulls/1492/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/scalding/statuses/af0435b6a7e6ac749d185e9bb0430c99de3e734d"}}}}