{"action":"created","issue":{"url":"https://api.github.com/repos/micro/micro/issues/56","repository_url":"https://api.github.com/repos/micro/micro","labels_url":"https://api.github.com/repos/micro/micro/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/micro/micro/issues/56/comments","events_url":"https://api.github.com/repos/micro/micro/issues/56/events","html_url":"https://github.com/micro/micro/issues/56","id":157431641,"number":56,"title":"Add ability to disable CORS checking or whitelisting origins for sidecar","user":{"login":"nii236","id":4482567,"avatar_url":"https://avatars.githubusercontent.com/u/4482567?v=3","gravatar_id":"","url":"https://api.github.com/users/nii236","html_url":"https://github.com/nii236","followers_url":"https://api.github.com/users/nii236/followers","following_url":"https://api.github.com/users/nii236/following{/other_user}","gists_url":"https://api.github.com/users/nii236/gists{/gist_id}","starred_url":"https://api.github.com/users/nii236/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nii236/subscriptions","organizations_url":"https://api.github.com/users/nii236/orgs","repos_url":"https://api.github.com/users/nii236/repos","events_url":"https://api.github.com/users/nii236/events{/privacy}","received_events_url":"https://api.github.com/users/nii236/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-30T05:01:23Z","updated_at":"2016-06-04T15:57:41Z","closed_at":null,"body":"Due to the CheckOrigin in [broker.go](https://github.com/micro/micro/blob/master/internal/handler/broker.go#L32) not being set, it is `nil`. This means that websocket connections from a different origin (in my case, outside the docker machine) can not connect to it.\r\n\r\nPlease allow the `sidecar_cors` option to be passed into this field. At the moment, `sidecar_cors` is not currently working (I think).\r\n\r\nComments for CheckOrigin are here:\r\n```\r\n// CheckOrigin returns true if the request Origin header is acceptable. If\r\n// CheckOrigin is nil, the host in the Origin header must not be set or\r\n// must match the host of the request.\r\n```"},"comment":{"url":"https://api.github.com/repos/micro/micro/issues/comments/223763118","html_url":"https://github.com/micro/micro/issues/56#issuecomment-223763118","issue_url":"https://api.github.com/repos/micro/micro/issues/56","id":223763118,"user":{"login":"asim","id":17530,"avatar_url":"https://avatars.githubusercontent.com/u/17530?v=3","gravatar_id":"","url":"https://api.github.com/users/asim","html_url":"https://github.com/asim","followers_url":"https://api.github.com/users/asim/followers","following_url":"https://api.github.com/users/asim/following{/other_user}","gists_url":"https://api.github.com/users/asim/gists{/gist_id}","starred_url":"https://api.github.com/users/asim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asim/subscriptions","organizations_url":"https://api.github.com/users/asim/orgs","repos_url":"https://api.github.com/users/asim/repos","events_url":"https://api.github.com/users/asim/events{/privacy}","received_events_url":"https://api.github.com/users/asim/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T15:57:41Z","updated_at":"2016-06-04T15:57:41Z","body":"It should be used to set things for the sidecar but is not setup. "}}
{"actor":{"display_login":"asim"}}