{"action":"created","issue":{"url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/2506","repository_url":"https://api.github.com/repos/PolarisSS13/Polaris","labels_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/2506/labels{/name}","comments_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/2506/comments","events_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/2506/events","html_url":"https://github.com/PolarisSS13/Polaris/pull/2506","id":178166800,"number":2506,"title":"The Great Storage Wars","user":{"login":"Yoshax","id":8885521,"avatar_url":"https://avatars.githubusercontent.com/u/8885521?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoshax","html_url":"https://github.com/Yoshax","followers_url":"https://api.github.com/users/Yoshax/followers","following_url":"https://api.github.com/users/Yoshax/following{/other_user}","gists_url":"https://api.github.com/users/Yoshax/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoshax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoshax/subscriptions","organizations_url":"https://api.github.com/users/Yoshax/orgs","repos_url":"https://api.github.com/users/Yoshax/repos","events_url":"https://api.github.com/users/Yoshax/events{/privacy}","received_events_url":"https://api.github.com/users/Yoshax/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-20T20:06:01Z","updated_at":"2016-09-21T03:10:48Z","closed_at":"2016-09-21T03:10:48Z","pull_request":{"url":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/2506","html_url":"https://github.com/PolarisSS13/Polaris/pull/2506","diff_url":"https://github.com/PolarisSS13/Polaris/pull/2506.diff","patch_url":"https://github.com/PolarisSS13/Polaris/pull/2506.patch"},"body":"Hello, and welcome to my PR. This PR proposes large changes to storage.\r\n\r\nThis PR does the following:\r\n- Storage items can no longer hold items of the same size.\r\n- Many storage items are slightly smaller in capacity.\r\n- Many items are now larger.\r\n  - This includes but is not limited to: Guns, other weapons, suits, armor, tanks."},"comment":{"url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/comments/248499284","html_url":"https://github.com/PolarisSS13/Polaris/pull/2506#issuecomment-248499284","issue_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/2506","id":248499284,"user":{"login":"Neerti","id":4955802,"avatar_url":"https://avatars.githubusercontent.com/u/4955802?v=3","gravatar_id":"","url":"https://api.github.com/users/Neerti","html_url":"https://github.com/Neerti","followers_url":"https://api.github.com/users/Neerti/followers","following_url":"https://api.github.com/users/Neerti/following{/other_user}","gists_url":"https://api.github.com/users/Neerti/gists{/gist_id}","starred_url":"https://api.github.com/users/Neerti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neerti/subscriptions","organizations_url":"https://api.github.com/users/Neerti/orgs","repos_url":"https://api.github.com/users/Neerti/repos","events_url":"https://api.github.com/users/Neerti/events{/privacy}","received_events_url":"https://api.github.com/users/Neerti/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T03:10:48Z","updated_at":"2016-09-21T03:10:48Z","body":"So, this PR is quite big, at nearly 90 files changed, and approximately 2.8k lines edited.  Reviewing it took quite awhile, so sorry for this somewhat slow response, but anyways.\r\n\r\nI'm not in favor for most of these changes.  There's a few things I like, like the jetpacks, but most of this is quite bad in my opinion, and seems really unnessecary.  Some of the changes are also not very obvious to someone just reading the top comment.\r\n\r\nI'll list some of the stuff I have issues with, and which some others would likely to know what this PR actually does.\r\n\r\n- **Makes backpacks contain 21 space instead of 28, and reduces the max w_class to 3.  This makes the normal bag have room for 5.25 medium (w_class 3) items instead of 7, as it does now.  Since most people will have the atmos box in their bag, that's down to four medium items, which is quite tight.**\r\n- Dufflebags bizzarely remain unchanged in the space department.\r\n- **Makes stacks/rods/floor tiles w_class 4.  This makes them unable to be put in a backpack.**\r\n- Fire extingushers increased to w_class 4.\r\n- C4 now w_class 3.\r\n- Hatchets now w_class 3.\r\n- Briefcases maximum storage reduced by 1, making it unable to store four medium items, as it is 15 on the PR vs 16 today.\r\n- Secure briefcases max storage reduced by 2 for no apparent reason.\r\n- Binoculars increased to w_class 3, making inventory more scarce with the above change to bags.\r\n- Flashlights now w_class 3, making inventory space tighter and disabling pocket storage.\r\n- **Mining bags increased to w_class 4.**\r\n- Plant bags increased to w_class 4.\r\n- Plastic bags that the janitor uses increased to w_class 4.\r\n- The emergency oxygen tank cannot fit in a pocket.\r\n- The normal tanks cannot fit in a backpack.\r\n- Bear traps increased to w_class 4, which makes their rare use by baddies even more rare.\r\n- Single tank bombs are increased to w_class 4.  See above.\r\n- Rad suit and fire suit increased to w_class 4.  Seems unnessecary, as holding one in your backpack currently takes about a third of your storage.  The accompnying helmet also takes up more room.\r\n- All wedding slots reduced by 1.\r\n- Cable stack increased to w_class 3, for some reason.\r\n- Retro, Captain's laser increased to w_class 4, when they look like a pistol, and a sleek one at that.\r\n- Lasertag also fits that profile but I don't care too heavily about this one.\r\n- Most if not all the SMGs are now too big to fit in a backpack, even tho based on the sprite you'd think they would fit, just poorly.  The Uzi is also increased to w_class 4.\r\n- In general, the massive increase of w_class on weapons makes it harder for antags to hide their weapons.\r\n\r\nRemember, anything w_class 4 will be unable to fit in a backpack after this change.\r\nw_class 3 means that it takes one of five of your imaginary slots, which is generally cut to one out of four due to your internals box existing.\r\n\r\nAll in all, this PR is just badness all around, especially for engineering.  I don't want this, and most staff I talked to about this don't really want this.  I'm sure a lot of players also feel the same way.  This creates what I see as unnecessary conflict with a lot of people to an issue that doesn't really exist or is pressing.\r\n\r\nDo not want."}}
{"actor":{"display_login":"Neerti"}}