{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1626","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1626/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1626/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1626/events","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1626","id":144178375,"number":1626,"title":"EZP-25627 provide default layout template allowing show sf toolbar","user":{"login":"crevillo","id":306215,"avatar_url":"https://avatars.githubusercontent.com/u/306215?v=3","gravatar_id":"","url":"https://api.github.com/users/crevillo","html_url":"https://github.com/crevillo","followers_url":"https://api.github.com/users/crevillo/followers","following_url":"https://api.github.com/users/crevillo/following{/other_user}","gists_url":"https://api.github.com/users/crevillo/gists{/gist_id}","starred_url":"https://api.github.com/users/crevillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crevillo/subscriptions","organizations_url":"https://api.github.com/users/crevillo/orgs","repos_url":"https://api.github.com/users/crevillo/repos","events_url":"https://api.github.com/users/crevillo/events{/privacy}","received_events_url":"https://api.github.com/users/crevillo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":35,"created_at":"2016-03-29T07:15:26Z","updated_at":"2016-04-16T09:59:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1626","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1626","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1626.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1626.patch"},"body":"WIP\r\n------\r\n\r\nHere's another try to solve this. In this case i create a new `pagelayout.html.twig` template and a new param in `templating.yml` file. i called it `ezpublish.pagelayout`. Better naming suggestions are very welcomed :). \r\n\r\nThe `full.html.twig`extends that new `viewBaseLayout`.\r\nOne concern about this is what if the user tries something like \r\n```twig\r\n {{ render( controller( \"ez_content:viewAction\", {'contentId': contentId, 'viewType': 'full', 'noLayout': 1} ) ) }}\r\n```\r\nIn this case, shouldn't we modify full template to check if ```noLayout``` is true or false?\r\n\r\nping @andrerom @emodric @bdunogier "},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/210784235","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1626#issuecomment-210784235","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1626","id":210784235,"user":{"login":"emodric","id":362286,"avatar_url":"https://avatars.githubusercontent.com/u/362286?v=3","gravatar_id":"","url":"https://api.github.com/users/emodric","html_url":"https://github.com/emodric","followers_url":"https://api.github.com/users/emodric/followers","following_url":"https://api.github.com/users/emodric/following{/other_user}","gists_url":"https://api.github.com/users/emodric/gists{/gist_id}","starred_url":"https://api.github.com/users/emodric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emodric/subscriptions","organizations_url":"https://api.github.com/users/emodric/orgs","repos_url":"https://api.github.com/users/emodric/repos","events_url":"https://api.github.com/users/emodric/events{/privacy}","received_events_url":"https://api.github.com/users/emodric/received_events","type":"User","site_admin":false},"created_at":"2016-04-16T09:59:50Z","updated_at":"2016-04-16T09:59:50Z","body":"Looks good to me too 👍 "}}