{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/2461","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/2461/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/2461/comments","events_url":"https://api.github.com/repos/apache/flink/issues/2461/events","html_url":"https://github.com/apache/flink/pull/2461","id":174725178,"number":2461,"title":"[FLINK-4505][Cluster Management] Implement TaskManagerFactory to brin…","user":{"login":"wangzhijiang999","id":12387855,"avatar_url":"https://avatars.githubusercontent.com/u/12387855?v=3","gravatar_id":"","url":"https://api.github.com/users/wangzhijiang999","html_url":"https://github.com/wangzhijiang999","followers_url":"https://api.github.com/users/wangzhijiang999/followers","following_url":"https://api.github.com/users/wangzhijiang999/following{/other_user}","gists_url":"https://api.github.com/users/wangzhijiang999/gists{/gist_id}","starred_url":"https://api.github.com/users/wangzhijiang999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangzhijiang999/subscriptions","organizations_url":"https://api.github.com/users/wangzhijiang999/orgs","repos_url":"https://api.github.com/users/wangzhijiang999/repos","events_url":"https://api.github.com/users/wangzhijiang999/events{/privacy}","received_events_url":"https://api.github.com/users/wangzhijiang999/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-02T10:07:41Z","updated_at":"2016-09-02T11:03:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/2461","html_url":"https://github.com/apache/flink/pull/2461","diff_url":"https://github.com/apache/flink/pull/2461.diff","patch_url":"https://github.com/apache/flink/pull/2461.patch"},"body":"Implement TaskExecutorFactory that should be an abstract class with the helper methods to bring up the TaskManager. The factory can be implemented by some classes to start a TaskManager in different modes (testing, standalone, yarn)."},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/244346733","html_url":"https://github.com/apache/flink/pull/2461#issuecomment-244346733","issue_url":"https://api.github.com/repos/apache/flink/issues/2461","id":244346733,"user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T11:03:20Z","updated_at":"2016-09-02T11:03:20Z","body":"Thanks for the contribution @wangzhijiang999.\r\n\r\nI think the abstraction is not right. The `StandaloneFactory` and the `YarnFactory` should actually only differ in the class of the `TaskExecutor` they start. Furthermore, I think that the network interface selection should not be part of the factory. Instead I would pass the hostname and port to the `createTaskManager(hostname, port)` method which constructs the `TaskManager`. Maybe it makes even sense to pass the `RpcService` via the `createTaskManager(RpcService)` and defer the RpcService creation to the outside method running the select interface method. \r\n\r\nThe difference between the Standalone/Yarn and Testing factory is that the first two create the TM components whereas the `TestingFactory` is initialized with the `TaskManager` components."}}
{"actor":{"display_login":"tillrohrmann"}}