{"action":"created","issue":{"url":"https://api.github.com/repos/plotly/plotly.js/issues/1171","repository_url":"https://api.github.com/repos/plotly/plotly.js","labels_url":"https://api.github.com/repos/plotly/plotly.js/issues/1171/labels{/name}","comments_url":"https://api.github.com/repos/plotly/plotly.js/issues/1171/comments","events_url":"https://api.github.com/repos/plotly/plotly.js/issues/1171/events","html_url":"https://github.com/plotly/plotly.js/pull/1171","id":190445775,"number":1171,"title":"updatemenus: fix wrong header update","user":{"login":"n-riesco","id":6199391,"avatar_url":"https://avatars.githubusercontent.com/u/6199391?v=3","gravatar_id":"","url":"https://api.github.com/users/n-riesco","html_url":"https://github.com/n-riesco","followers_url":"https://api.github.com/users/n-riesco/followers","following_url":"https://api.github.com/users/n-riesco/following{/other_user}","gists_url":"https://api.github.com/users/n-riesco/gists{/gist_id}","starred_url":"https://api.github.com/users/n-riesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n-riesco/subscriptions","organizations_url":"https://api.github.com/users/n-riesco/orgs","repos_url":"https://api.github.com/users/n-riesco/repos","events_url":"https://api.github.com/users/n-riesco/events{/privacy}","received_events_url":"https://api.github.com/users/n-riesco/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-18T23:23:49Z","updated_at":"2016-11-21T09:16:07Z","closed_at":"2016-11-19T07:31:05Z","pull_request":{"url":"https://api.github.com/repos/plotly/plotly.js/pulls/1171","html_url":"https://github.com/plotly/plotly.js/pull/1171","diff_url":"https://github.com/plotly/plotly.js/pull/1171.diff","patch_url":"https://github.com/plotly/plotly.js/pull/1171.patch"},"body":"* Note that the click handler already updates the header and invokes\r\n  `Plots.executeAPICommand`.\r\n\r\nFixes #1169"},"comment":{"url":"https://api.github.com/repos/plotly/plotly.js/issues/comments/261884296","html_url":"https://github.com/plotly/plotly.js/pull/1171#issuecomment-261884296","issue_url":"https://api.github.com/repos/plotly/plotly.js/issues/1171","id":261884296,"user":{"login":"n-riesco","id":6199391,"avatar_url":"https://avatars.githubusercontent.com/u/6199391?v=3","gravatar_id":"","url":"https://api.github.com/users/n-riesco","html_url":"https://github.com/n-riesco","followers_url":"https://api.github.com/users/n-riesco/followers","following_url":"https://api.github.com/users/n-riesco/following{/other_user}","gists_url":"https://api.github.com/users/n-riesco/gists{/gist_id}","starred_url":"https://api.github.com/users/n-riesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n-riesco/subscriptions","organizations_url":"https://api.github.com/users/n-riesco/orgs","repos_url":"https://api.github.com/users/n-riesco/repos","events_url":"https://api.github.com/users/n-riesco/events{/privacy}","received_events_url":"https://api.github.com/users/n-riesco/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T09:16:07Z","updated_at":"2016-11-21T09:16:07Z","body":"@rreusser\r\n\r\nI've tracked this issue down to [plots/command.js:bindingValueHasChange](plots/command.js) (the algorithm to detect changes in `gd._fullData` only checks the first trace).\r\n\r\nThis issue could be worked around in [Menuupdates.draw](https://github.com/plotly/plotly.js/blob/645344f613a6c085df568bc10f99ba73d8ef81c6/src/components/updatemenus/draw.js#L118), but, unless there is a reason not to, I think that making `plots/command.js:bindingValueHasChange` more accurate is a better solution."}}
{"actor":{"display_login":"n-riesco"}}