{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/glimpseio/glacier/pulls/39","id":93877747,"html_url":"https://github.com/glimpseio/glacier/pull/39","diff_url":"https://github.com/glimpseio/glacier/pull/39.diff","patch_url":"https://github.com/glimpseio/glacier/pull/39.patch","issue_url":"https://api.github.com/repos/glimpseio/glacier/issues/39","number":39,"state":"closed","locked":false,"title":"Update data source API to members return promises on completion","user":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars.githubusercontent.com/u/2932786?v=3","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"body":"This makes usage and testing easier, as you no longer have to determine completeness by waiting for the model to settle.\r\n\r\n@phillip092 was having some issues when writing tests where it was difficult to determine when the model was fully updated - this API change should alleviate that issue.","created_at":"2016-11-16T00:21:17Z","updated_at":"2016-11-16T00:25:03Z","closed_at":"2016-11-16T00:25:03Z","merged_at":"2016-11-16T00:25:03Z","merge_commit_sha":"8e829f2722c6aed77d64588651076ba7797c4491","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/glimpseio/glacier/pulls/39/commits","review_comments_url":"https://api.github.com/repos/glimpseio/glacier/pulls/39/comments","review_comment_url":"https://api.github.com/repos/glimpseio/glacier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glimpseio/glacier/issues/39/comments","statuses_url":"https://api.github.com/repos/glimpseio/glacier/statuses/78ab79a114f35e510a3dd984450657ac88cc11e7","head":{"label":"glimpseio:better-adapter-api","ref":"better-adapter-api","sha":"78ab79a114f35e510a3dd984450657ac88cc11e7","user":{"login":"glimpseio","id":10204112,"avatar_url":"https://avatars.githubusercontent.com/u/10204112?v=3","gravatar_id":"","url":"https://api.github.com/users/glimpseio","html_url":"https://github.com/glimpseio","followers_url":"https://api.github.com/users/glimpseio/followers","following_url":"https://api.github.com/users/glimpseio/following{/other_user}","gists_url":"https://api.github.com/users/glimpseio/gists{/gist_id}","starred_url":"https://api.github.com/users/glimpseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimpseio/subscriptions","organizations_url":"https://api.github.com/users/glimpseio/orgs","repos_url":"https://api.github.com/users/glimpseio/repos","events_url":"https://api.github.com/users/glimpseio/events{/privacy}","received_events_url":"https://api.github.com/users/glimpseio/received_events","type":"Organization","site_admin":false},"repo":{"id":66981689,"name":"glacier","full_name":"glimpseio/glacier","owner":{"login":"glimpseio","id":10204112,"avatar_url":"https://avatars.githubusercontent.com/u/10204112?v=3","gravatar_id":"","url":"https://api.github.com/users/glimpseio","html_url":"https://github.com/glimpseio","followers_url":"https://api.github.com/users/glimpseio/followers","following_url":"https://api.github.com/users/glimpseio/following{/other_user}","gists_url":"https://api.github.com/users/glimpseio/gists{/gist_id}","starred_url":"https://api.github.com/users/glimpseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimpseio/subscriptions","organizations_url":"https://api.github.com/users/glimpseio/orgs","repos_url":"https://api.github.com/users/glimpseio/repos","events_url":"https://api.github.com/users/glimpseio/events{/privacy}","received_events_url":"https://api.github.com/users/glimpseio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glimpseio/glacier","description":null,"fork":false,"url":"https://api.github.com/repos/glimpseio/glacier","forks_url":"https://api.github.com/repos/glimpseio/glacier/forks","keys_url":"https://api.github.com/repos/glimpseio/glacier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glimpseio/glacier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glimpseio/glacier/teams","hooks_url":"https://api.github.com/repos/glimpseio/glacier/hooks","issue_events_url":"https://api.github.com/repos/glimpseio/glacier/issues/events{/number}","events_url":"https://api.github.com/repos/glimpseio/glacier/events","assignees_url":"https://api.github.com/repos/glimpseio/glacier/assignees{/user}","branches_url":"https://api.github.com/repos/glimpseio/glacier/branches{/branch}","tags_url":"https://api.github.com/repos/glimpseio/glacier/tags","blobs_url":"https://api.github.com/repos/glimpseio/glacier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glimpseio/glacier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glimpseio/glacier/git/refs{/sha}","trees_url":"https://api.github.com/repos/glimpseio/glacier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glimpseio/glacier/statuses/{sha}","languages_url":"https://api.github.com/repos/glimpseio/glacier/languages","stargazers_url":"https://api.github.com/repos/glimpseio/glacier/stargazers","contributors_url":"https://api.github.com/repos/glimpseio/glacier/contributors","subscribers_url":"https://api.github.com/repos/glimpseio/glacier/subscribers","subscription_url":"https://api.github.com/repos/glimpseio/glacier/subscription","commits_url":"https://api.github.com/repos/glimpseio/glacier/commits{/sha}","git_commits_url":"https://api.github.com/repos/glimpseio/glacier/git/commits{/sha}","comments_url":"https://api.github.com/repos/glimpseio/glacier/comments{/number}","issue_comment_url":"https://api.github.com/repos/glimpseio/glacier/issues/comments{/number}","contents_url":"https://api.github.com/repos/glimpseio/glacier/contents/{+path}","compare_url":"https://api.github.com/repos/glimpseio/glacier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glimpseio/glacier/merges","archive_url":"https://api.github.com/repos/glimpseio/glacier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glimpseio/glacier/downloads","issues_url":"https://api.github.com/repos/glimpseio/glacier/issues{/number}","pulls_url":"https://api.github.com/repos/glimpseio/glacier/pulls{/number}","milestones_url":"https://api.github.com/repos/glimpseio/glacier/milestones{/number}","notifications_url":"https://api.github.com/repos/glimpseio/glacier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glimpseio/glacier/labels{/name}","releases_url":"https://api.github.com/repos/glimpseio/glacier/releases{/id}","deployments_url":"https://api.github.com/repos/glimpseio/glacier/deployments","created_at":"2016-08-30T22:15:39Z","updated_at":"2016-11-01T16:47:57Z","pushed_at":"2016-11-16T00:25:03Z","git_url":"git://github.com/glimpseio/glacier.git","ssh_url":"git@github.com:glimpseio/glacier.git","clone_url":"https://github.com/glimpseio/glacier.git","svn_url":"https://github.com/glimpseio/glacier","homepage":null,"size":29741,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":25,"forks":0,"open_issues":25,"watchers":0,"default_branch":"master"}},"base":{"label":"glimpseio:master","ref":"master","sha":"56f4a7047823eeda4531f909e2526c38652d188d","user":{"login":"glimpseio","id":10204112,"avatar_url":"https://avatars.githubusercontent.com/u/10204112?v=3","gravatar_id":"","url":"https://api.github.com/users/glimpseio","html_url":"https://github.com/glimpseio","followers_url":"https://api.github.com/users/glimpseio/followers","following_url":"https://api.github.com/users/glimpseio/following{/other_user}","gists_url":"https://api.github.com/users/glimpseio/gists{/gist_id}","starred_url":"https://api.github.com/users/glimpseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimpseio/subscriptions","organizations_url":"https://api.github.com/users/glimpseio/orgs","repos_url":"https://api.github.com/users/glimpseio/repos","events_url":"https://api.github.com/users/glimpseio/events{/privacy}","received_events_url":"https://api.github.com/users/glimpseio/received_events","type":"Organization","site_admin":false},"repo":{"id":66981689,"name":"glacier","full_name":"glimpseio/glacier","owner":{"login":"glimpseio","id":10204112,"avatar_url":"https://avatars.githubusercontent.com/u/10204112?v=3","gravatar_id":"","url":"https://api.github.com/users/glimpseio","html_url":"https://github.com/glimpseio","followers_url":"https://api.github.com/users/glimpseio/followers","following_url":"https://api.github.com/users/glimpseio/following{/other_user}","gists_url":"https://api.github.com/users/glimpseio/gists{/gist_id}","starred_url":"https://api.github.com/users/glimpseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glimpseio/subscriptions","organizations_url":"https://api.github.com/users/glimpseio/orgs","repos_url":"https://api.github.com/users/glimpseio/repos","events_url":"https://api.github.com/users/glimpseio/events{/privacy}","received_events_url":"https://api.github.com/users/glimpseio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glimpseio/glacier","description":null,"fork":false,"url":"https://api.github.com/repos/glimpseio/glacier","forks_url":"https://api.github.com/repos/glimpseio/glacier/forks","keys_url":"https://api.github.com/repos/glimpseio/glacier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glimpseio/glacier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glimpseio/glacier/teams","hooks_url":"https://api.github.com/repos/glimpseio/glacier/hooks","issue_events_url":"https://api.github.com/repos/glimpseio/glacier/issues/events{/number}","events_url":"https://api.github.com/repos/glimpseio/glacier/events","assignees_url":"https://api.github.com/repos/glimpseio/glacier/assignees{/user}","branches_url":"https://api.github.com/repos/glimpseio/glacier/branches{/branch}","tags_url":"https://api.github.com/repos/glimpseio/glacier/tags","blobs_url":"https://api.github.com/repos/glimpseio/glacier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glimpseio/glacier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glimpseio/glacier/git/refs{/sha}","trees_url":"https://api.github.com/repos/glimpseio/glacier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glimpseio/glacier/statuses/{sha}","languages_url":"https://api.github.com/repos/glimpseio/glacier/languages","stargazers_url":"https://api.github.com/repos/glimpseio/glacier/stargazers","contributors_url":"https://api.github.com/repos/glimpseio/glacier/contributors","subscribers_url":"https://api.github.com/repos/glimpseio/glacier/subscribers","subscription_url":"https://api.github.com/repos/glimpseio/glacier/subscription","commits_url":"https://api.github.com/repos/glimpseio/glacier/commits{/sha}","git_commits_url":"https://api.github.com/repos/glimpseio/glacier/git/commits{/sha}","comments_url":"https://api.github.com/repos/glimpseio/glacier/comments{/number}","issue_comment_url":"https://api.github.com/repos/glimpseio/glacier/issues/comments{/number}","contents_url":"https://api.github.com/repos/glimpseio/glacier/contents/{+path}","compare_url":"https://api.github.com/repos/glimpseio/glacier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glimpseio/glacier/merges","archive_url":"https://api.github.com/repos/glimpseio/glacier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glimpseio/glacier/downloads","issues_url":"https://api.github.com/repos/glimpseio/glacier/issues{/number}","pulls_url":"https://api.github.com/repos/glimpseio/glacier/pulls{/number}","milestones_url":"https://api.github.com/repos/glimpseio/glacier/milestones{/number}","notifications_url":"https://api.github.com/repos/glimpseio/glacier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glimpseio/glacier/labels{/name}","releases_url":"https://api.github.com/repos/glimpseio/glacier/releases{/id}","deployments_url":"https://api.github.com/repos/glimpseio/glacier/deployments","created_at":"2016-08-30T22:15:39Z","updated_at":"2016-11-01T16:47:57Z","pushed_at":"2016-11-16T00:25:03Z","git_url":"git://github.com/glimpseio/glacier.git","ssh_url":"git@github.com:glimpseio/glacier.git","clone_url":"https://github.com/glimpseio/glacier.git","svn_url":"https://github.com/glimpseio/glacier","homepage":null,"size":29741,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":25,"forks":0,"open_issues":25,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glimpseio/glacier/pulls/39"},"html":{"href":"https://github.com/glimpseio/glacier/pull/39"},"issue":{"href":"https://api.github.com/repos/glimpseio/glacier/issues/39"},"comments":{"href":"https://api.github.com/repos/glimpseio/glacier/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/glimpseio/glacier/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/glimpseio/glacier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glimpseio/glacier/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/glimpseio/glacier/statuses/78ab79a114f35e510a3dd984450657ac88cc11e7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"weswigham","id":2932786,"avatar_url":"https://avatars.githubusercontent.com/u/2932786?v=3","gravatar_id":"","url":"https://api.github.com/users/weswigham","html_url":"https://github.com/weswigham","followers_url":"https://api.github.com/users/weswigham/followers","following_url":"https://api.github.com/users/weswigham/following{/other_user}","gists_url":"https://api.github.com/users/weswigham/gists{/gist_id}","starred_url":"https://api.github.com/users/weswigham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weswigham/subscriptions","organizations_url":"https://api.github.com/users/weswigham/orgs","repos_url":"https://api.github.com/users/weswigham/repos","events_url":"https://api.github.com/users/weswigham/events{/privacy}","received_events_url":"https://api.github.com/users/weswigham/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":10,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"weswigham"}}