{"action":"created","issue":{"url":"https://api.github.com/repos/wiremod/wire/issues/1192","repository_url":"https://api.github.com/repos/wiremod/wire","labels_url":"https://api.github.com/repos/wiremod/wire/issues/1192/labels{/name}","comments_url":"https://api.github.com/repos/wiremod/wire/issues/1192/comments","events_url":"https://api.github.com/repos/wiremod/wire/issues/1192/events","html_url":"https://github.com/wiremod/wire/pull/1192","id":167735304,"number":1192,"title":"xwl:writeArray() - No longer null-terminate","user":{"login":"adosikas","id":3721366,"avatar_url":"https://avatars.githubusercontent.com/u/3721366?v=3","gravatar_id":"","url":"https://api.github.com/users/adosikas","html_url":"https://github.com/adosikas","followers_url":"https://api.github.com/users/adosikas/followers","following_url":"https://api.github.com/users/adosikas/following{/other_user}","gists_url":"https://api.github.com/users/adosikas/gists{/gist_id}","starred_url":"https://api.github.com/users/adosikas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adosikas/subscriptions","organizations_url":"https://api.github.com/users/adosikas/orgs","repos_url":"https://api.github.com/users/adosikas/repos","events_url":"https://api.github.com/users/adosikas/events{/privacy}","received_events_url":"https://api.github.com/users/adosikas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-26T23:25:36Z","updated_at":"2016-07-28T21:24:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wiremod/wire/pulls/1192","html_url":"https://github.com/wiremod/wire/pull/1192","diff_url":"https://github.com/wiremod/wire/pull/1192.diff","patch_url":"https://github.com/wiremod/wire/pull/1192.patch"},"body":"Fixes #879\r\n\r\nThere is no need to automatically null terminate all arrays, readArray specifies the size of the area to read and manually adding a 0 to array in case it is needed for whatever reason is trivial. And there are seperate functions for writing/reading strings.\r\n\r\nI added back the null-terminator for sub-tables (there probably is a better way to do that) since those would otherwise be hard to parse back into a array without mapping out all pointers beforehand.\r\n\r\nAn alternate solution would be a wirelink:writeArraySimple(address,array) function, that just writes the numerical contents of the array, without any sub-tables, null-terminations or other confusing stuff, which is certainly useful for many things including digital screens, where you just want to input a row of simple numbers."},"comment":{"url":"https://api.github.com/repos/wiremod/wire/issues/comments/236029714","html_url":"https://github.com/wiremod/wire/pull/1192#issuecomment-236029714","issue_url":"https://api.github.com/repos/wiremod/wire/issues/1192","id":236029714,"user":{"login":"TomyLobo","id":963797,"avatar_url":"https://avatars.githubusercontent.com/u/963797?v=3","gravatar_id":"","url":"https://api.github.com/users/TomyLobo","html_url":"https://github.com/TomyLobo","followers_url":"https://api.github.com/users/TomyLobo/followers","following_url":"https://api.github.com/users/TomyLobo/following{/other_user}","gists_url":"https://api.github.com/users/TomyLobo/gists{/gist_id}","starred_url":"https://api.github.com/users/TomyLobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomyLobo/subscriptions","organizations_url":"https://api.github.com/users/TomyLobo/orgs","repos_url":"https://api.github.com/users/TomyLobo/repos","events_url":"https://api.github.com/users/TomyLobo/events{/privacy}","received_events_url":"https://api.github.com/users/TomyLobo/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T21:24:17Z","updated_at":"2016-07-28T21:24:17Z","body":"``writeArray`` isn't the counterpart to ``readArray``.\r\nIt's the counterpart to all the array handling features in Wire CPU.\r\nWire CPU is the origin of the memory cell system, not E2, and in Wire CPU everything is zero-terminated."}}
{"actor":{"display_login":"TomyLobo"}}