{"action":"closed","issue":{"url":"https://api.github.com/repos/openwhisk/openwhisk/issues/731","repository_url":"https://api.github.com/repos/openwhisk/openwhisk","labels_url":"https://api.github.com/repos/openwhisk/openwhisk/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/openwhisk/openwhisk/issues/731/comments","events_url":"https://api.github.com/repos/openwhisk/openwhisk/issues/731/events","html_url":"https://github.com/openwhisk/openwhisk/issues/731","id":161685697,"number":731,"title":"git package does not specify triggerName as a required parameter for webhook","user":{"login":"starpit","id":4741620,"avatar_url":"https://avatars.githubusercontent.com/u/4741620?v=3","gravatar_id":"","url":"https://api.github.com/users/starpit","html_url":"https://github.com/starpit","followers_url":"https://api.github.com/users/starpit/followers","following_url":"https://api.github.com/users/starpit/following{/other_user}","gists_url":"https://api.github.com/users/starpit/gists{/gist_id}","starred_url":"https://api.github.com/users/starpit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starpit/subscriptions","organizations_url":"https://api.github.com/users/starpit/orgs","repos_url":"https://api.github.com/users/starpit/repos","events_url":"https://api.github.com/users/starpit/events{/privacy}","received_events_url":"https://api.github.com/users/starpit/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openwhisk/openwhisk/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/openwhisk/openwhisk/labels/packages","name":"packages","color":"c5def5"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-22T13:40:38Z","updated_at":"2016-06-22T14:00:23Z","closed_at":"2016-06-22T14:00:23Z","body":"the `webhook.js` source code has\r\n```\r\n  var triggerName = params.triggerName.split(\"/\");\r\n```\r\n\r\nbut the `installGit.sh` script does not mention `triggerName` even as a parameter, let alone that it is required.\r\n\r\ni'm not sure what the right fix is here. it seems odd that a feed takes as input the trigger name. shouldn't this be an implicit part of every feed invocation, something that is passed through by the controller?\r\n\r\notherwise, how can i construct a form for the user to fill out? i'm already asking them for a name for the trigger. but i don't know that i need to pass this through to the feed (since the metadata doesn't tell me there is a required triggerName attribute); even if it did, how would i know that the name i'm **already** asking the user to provide is the same one that the webhook CREATE invocation also requires?"}}
{"actor":{"display_login":"starpit"}}