{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/66748237","id":66748237,"diff_hunk":"@@ -2,17 +2,38 @@ popover = null;\n \n module \"Popover unit tests\",\n   setup: ->\n-    Ember.run ->\n-      popover = Ember.Widgets.PopoverComponent.popup\n-        rootElement: '#ember-testing'\n-  ,\n+    return\n+\n   teardown: ->\n     Ember.run ->\n       popover.destroy()\n \n test 'The popover removes itself properly from the DOM', ->\n+  Ember.run ->\n+    popover = Ember.Widgets.PopoverComponent.popup\n+      rootElement: '#ember-testing'\n+\n   sinon.spy(popover, \"hide\")\n   wait().then ->\n     keyEvent('.popover-content', 'keyup', 27)\n   wait().then ->\n     ok(popover.hide.calledOnce, \"`hide` gets called when hitting escape\")\n+    popover.hide.restore()\n+\n+test 'Popover does not hide other popover if hideOthers is false', ->\n+  expect 2\n+\n+  jQueryHide = sinon.stub($.fn, 'trigger');\n+  # Case 1: other popover should be hidden by default\n+  Ember.run ->\n+    popover = Ember.Widgets.PopoverComponent.popup({rootElement: '#ember-testing'})\n+  andThen ->\n+    ok(jQueryHide.calledOnce, \"Hide action is triggered\")","path":"tests/unit/popover_test.coffee","position":34,"original_position":34,"commit_id":"0a41e8162aa469d2c62345a3f9312eb3df6ba9ac","original_commit_id":"0a41e8162aa469d2c62345a3f9312eb3df6ba9ac","user":{"login":"thangdinh","id":8838366,"avatar_url":"https://avatars.githubusercontent.com/u/8838366?v=3","gravatar_id":"","url":"https://api.github.com/users/thangdinh","html_url":"https://github.com/thangdinh","followers_url":"https://api.github.com/users/thangdinh/followers","following_url":"https://api.github.com/users/thangdinh/following{/other_user}","gists_url":"https://api.github.com/users/thangdinh/gists{/gist_id}","starred_url":"https://api.github.com/users/thangdinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thangdinh/subscriptions","organizations_url":"https://api.github.com/users/thangdinh/orgs","repos_url":"https://api.github.com/users/thangdinh/repos","events_url":"https://api.github.com/users/thangdinh/events{/privacy}","received_events_url":"https://api.github.com/users/thangdinh/received_events","type":"User","site_admin":false},"body":"please change the message to indicate that hide action should be triggered by default when hideOptions is not set.","created_at":"2016-06-13T07:19:03Z","updated_at":"2016-06-13T07:19:03Z","html_url":"https://github.com/Addepar/ember-widgets/pull/238#discussion_r66748237","pull_request_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/66748237"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/238#discussion_r66748237"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238","id":73301379,"html_url":"https://github.com/Addepar/ember-widgets/pull/238","diff_url":"https://github.com/Addepar/ember-widgets/pull/238.diff","patch_url":"https://github.com/Addepar/ember-widgets/pull/238.patch","issue_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/238","number":238,"state":"open","locked":false,"title":"Add hideOthers option to popover","user":{"login":"mgreenbaum","id":1013317,"avatar_url":"https://avatars.githubusercontent.com/u/1013317?v=3","gravatar_id":"","url":"https://api.github.com/users/mgreenbaum","html_url":"https://github.com/mgreenbaum","followers_url":"https://api.github.com/users/mgreenbaum/followers","following_url":"https://api.github.com/users/mgreenbaum/following{/other_user}","gists_url":"https://api.github.com/users/mgreenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/mgreenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgreenbaum/subscriptions","organizations_url":"https://api.github.com/users/mgreenbaum/orgs","repos_url":"https://api.github.com/users/mgreenbaum/repos","events_url":"https://api.github.com/users/mgreenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/mgreenbaum/received_events","type":"User","site_admin":false},"body":"Allow users to disable the hideAll that's triggered when\r\nlaunching a popover. This change is necessary for keeping\r\nmultiple popovers open at the same time.\r\n\r\n@billy-addepar ","created_at":"2016-06-09T23:15:07Z","updated_at":"2016-06-13T07:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cdb7fbbd9d76d1d37246cbcaccb883e2c62567b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/238/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/0a41e8162aa469d2c62345a3f9312eb3df6ba9ac","head":{"label":"Addepar:greenbaum/hideOthers","ref":"greenbaum/hideOthers","sha":"0a41e8162aa469d2c62345a3f9312eb3df6ba9ac","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/Addepar/ember-widgets/deployments","created_at":"2013-10-23T04:39:36Z","updated_at":"2016-06-05T18:09:21Z","pushed_at":"2016-06-10T22:30:41Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":35079,"stargazers_count":290,"watchers_count":290,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":42,"forks":84,"open_issues":42,"watchers":290,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"1e2e539efac948806d8bf3eed663d84129d6bf36","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","deployments_url":"https://api.github.com/repos/Addepar/ember-widgets/deployments","created_at":"2013-10-23T04:39:36Z","updated_at":"2016-06-05T18:09:21Z","pushed_at":"2016-06-10T22:30:41Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":35079,"stargazers_count":290,"watchers_count":290,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":42,"forks":84,"open_issues":42,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/238"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/238"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-widgets/statuses/0a41e8162aa469d2c62345a3f9312eb3df6ba9ac"}}}}
{"actor":{"display_login":"thangdinh"}}