{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/26583","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/26583/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/26583/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/26583/events","html_url":"https://github.com/owncloud/core/pull/26583","id":188075727,"number":26583,"title":"share api expanded by tags","user":{"login":"mjobst-necls","id":23121972,"avatar_url":"https://avatars.githubusercontent.com/u/23121972?v=3","gravatar_id":"","url":"https://api.github.com/users/mjobst-necls","html_url":"https://github.com/mjobst-necls","followers_url":"https://api.github.com/users/mjobst-necls/followers","following_url":"https://api.github.com/users/mjobst-necls/following{/other_user}","gists_url":"https://api.github.com/users/mjobst-necls/gists{/gist_id}","starred_url":"https://api.github.com/users/mjobst-necls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjobst-necls/subscriptions","organizations_url":"https://api.github.com/users/mjobst-necls/orgs","repos_url":"https://api.github.com/users/mjobst-necls/repos","events_url":"https://api.github.com/users/mjobst-necls/events{/privacy}","received_events_url":"https://api.github.com/users/mjobst-necls/received_events","type":"User","site_admin":false},"labels":[{"id":17709846,"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed","default":false},{"id":18122325,"url":"https://api.github.com/repos/owncloud/core/labels/feature:sharing","name":"feature:sharing","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/76","html_url":"https://github.com/owncloud/core/milestones/9.2","labels_url":"https://api.github.com/repos/owncloud/core/milestones/76/labels","id":1632230,"number":76,"title":"9.2","description":null,"creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":461,"closed_issues":424,"state":"open","created_at":"2016-03-09T07:18:43Z","updated_at":"2016-11-08T22:50:04Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-11-08T19:02:42Z","updated_at":"2016-11-09T00:08:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/26583","html_url":"https://github.com/owncloud/core/pull/26583","diff_url":"https://github.com/owncloud/core/pull/26583.diff","patch_url":"https://github.com/owncloud/core/pull/26583.patch"},"body":"<!--\r\nThanks for submitting a change to ownCloud!\r\n\r\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/.github/CONTRIBUTING.md#guidelines\r\n\r\nFor fixing potential security issues please see https://owncloud.org/security/\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\r\n\r\nWe will carefully discuss if your change can or has to be backported to stable branches.\r\n-->\r\n\r\n## Description\r\nModification of the share api. The share api adds the file tags to the response if \"show_tags\" is existing and has a positive value in the request.\r\n\r\n**Attention**: This Issue is not solved yet by this first commits. Additional information is needed. I'm also not yet confident with the naming conventions at all.\r\n\r\n1) Is the request parameter name \"show_tags\" ok?\r\n\r\n2) Check the modified populateTags() function. That function was only used in the /apps/files/ajax/list.php\r\n2a) Is that list.php still needed?\r\n2b) How can this file be tested?\r\n2c) The populateTags() function returned the same value as passed by as parameter. Did this function really do its job correct?\r\n\r\n3) Should it be/Is it possible to mark remote shares as favorite?\r\n\r\n4) The favorite indicator should be shown in the share views. The tags can now be retrieved by the share api. Do you think my approach regarding adding the entries to the _allowedList_ (see #26437) would be ok by now\r\n\r\n5) Is 'file_source' the correct field to identify the object in shares?\r\n\r\nAdditional Tests have to be added. I will do this when all questions have been answered.\r\n\r\n## Related Issue\r\n#19753\r\n\r\n#19753 should be done before #26437\r\n\r\n## Motivation and Context\r\nThe share views should be enhanced by the favorite indicator and actions. \r\n\r\n## How Has This Been Tested?\r\nBy simple api calls.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/259299729","html_url":"https://github.com/owncloud/core/pull/26583#issuecomment-259299729","issue_url":"https://api.github.com/repos/owncloud/core/issues/26583","id":259299729,"user":{"login":"mjobst-necls","id":23121972,"avatar_url":"https://avatars.githubusercontent.com/u/23121972?v=3","gravatar_id":"","url":"https://api.github.com/users/mjobst-necls","html_url":"https://github.com/mjobst-necls","followers_url":"https://api.github.com/users/mjobst-necls/followers","following_url":"https://api.github.com/users/mjobst-necls/following{/other_user}","gists_url":"https://api.github.com/users/mjobst-necls/gists{/gist_id}","starred_url":"https://api.github.com/users/mjobst-necls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjobst-necls/subscriptions","organizations_url":"https://api.github.com/users/mjobst-necls/orgs","repos_url":"https://api.github.com/users/mjobst-necls/repos","events_url":"https://api.github.com/users/mjobst-necls/events{/privacy}","received_events_url":"https://api.github.com/users/mjobst-necls/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T00:08:28Z","updated_at":"2016-11-09T00:08:28Z","body":"Ok. This should work now. There still exist a few little bugs (Expiration date/Shared With disappear, Size is not shown correctly on details view), but they will be fixed by #26552 after some modifications. "}}
{"actor":{"display_login":"mjobst-necls"}}