{"action":"created","comment":{"url":"https://api.github.com/repos/apache/falcon/pulls/comments/70922580","id":70922580,"diff_hunk":"@@ -94,12 +96,15 @@ private String buildSqoopCommand(Cluster cluster, Feed feed) throws FalconExcept\n         StringBuilder sqoopArgs = new StringBuilder();\n         StringBuilder sqoopOptions = new StringBuilder();\n \n-        buildConnectArg(sqoopArgs, cluster).append(ImportExportCommon.ARG_SEPARATOR);\n-        buildTableArg(sqoopArgs, cluster).append(ImportExportCommon.ARG_SEPARATOR);\n-        Datasource datasource = DatasourceHelper.getDatasource(FeedHelper.getExportDatasourceName(\n-                FeedHelper.getCluster(entity, cluster.getName())));\n-        ImportExportCommon.buildUserPasswordArg(sqoopArgs, sqoopOptions, datasource)\n-                .append(ImportExportCommon.ARG_SEPARATOR);\n+        org.apache.falcon.entity.v0.feed.Cluster feedCluster = FeedHelper.getCluster(entity, cluster.getName());\n+        Datasource datasource = DatasourceHelper.getDatasource(FeedHelper.getExportDatasourceName(feedCluster));","path":"oozie/src/main/java/org/apache/falcon/oozie/DatabaseExportWorkflowBuilder.java","position":21,"original_position":21,"commit_id":"3131122a4c8936ff8c337406fe457be0e5c36c29","original_commit_id":"3131122a4c8936ff8c337406fe457be0e5c36c29","user":{"login":"vrangan","id":2677913,"avatar_url":"https://avatars.githubusercontent.com/u/2677913?v=3","gravatar_id":"","url":"https://api.github.com/users/vrangan","html_url":"https://github.com/vrangan","followers_url":"https://api.github.com/users/vrangan/followers","following_url":"https://api.github.com/users/vrangan/following{/other_user}","gists_url":"https://api.github.com/users/vrangan/gists{/gist_id}","starred_url":"https://api.github.com/users/vrangan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrangan/subscriptions","organizations_url":"https://api.github.com/users/vrangan/orgs","repos_url":"https://api.github.com/users/vrangan/repos","events_url":"https://api.github.com/users/vrangan/events{/privacy}","received_events_url":"https://api.github.com/users/vrangan/received_events","type":"User","site_admin":false},"body":"How do we handle connector specific direct mode and verbose options from the properties (which are key value pairs but these are single arguments to Sqoop)","created_at":"2016-07-15T05:15:14Z","updated_at":"2016-07-15T05:15:14Z","html_url":"https://github.com/apache/falcon/pull/224#discussion_r70922580","pull_request_url":"https://api.github.com/repos/apache/falcon/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments/70922580"},"html":{"href":"https://github.com/apache/falcon/pull/224#discussion_r70922580"},"pull_request":{"href":"https://api.github.com/repos/apache/falcon/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/apache/falcon/pulls/224","id":77217662,"html_url":"https://github.com/apache/falcon/pull/224","diff_url":"https://github.com/apache/falcon/pull/224.diff","patch_url":"https://github.com/apache/falcon/pull/224.patch","issue_url":"https://api.github.com/repos/apache/falcon/issues/224","number":224,"state":"open","locked":false,"title":"FALCON-2066 : Add support for various database types for import and e…","user":{"login":"vramachan","id":11688485,"avatar_url":"https://avatars.githubusercontent.com/u/11688485?v=3","gravatar_id":"","url":"https://api.github.com/users/vramachan","html_url":"https://github.com/vramachan","followers_url":"https://api.github.com/users/vramachan/followers","following_url":"https://api.github.com/users/vramachan/following{/other_user}","gists_url":"https://api.github.com/users/vramachan/gists{/gist_id}","starred_url":"https://api.github.com/users/vramachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramachan/subscriptions","organizations_url":"https://api.github.com/users/vramachan/orgs","repos_url":"https://api.github.com/users/vramachan/repos","events_url":"https://api.github.com/users/vramachan/events{/privacy}","received_events_url":"https://api.github.com/users/vramachan/received_events","type":"User","site_admin":false},"body":"+ Add support for various database types\r\n+ Validate new database types work \r\n+ Add examples for various new database types\r\n+ Add documentation about database types\r\n+ Remove specifying driver option for supported database types ","created_at":"2016-07-13T01:27:55Z","updated_at":"2016-07-15T05:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aa5d268a864724c2a02526b3fbfe7cf861af8c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/falcon/pulls/224/commits","review_comments_url":"https://api.github.com/repos/apache/falcon/pulls/224/comments","review_comment_url":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/falcon/issues/224/comments","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/3131122a4c8936ff8c337406fe457be0e5c36c29","head":{"label":"vramachan:FALCON-2066.DatabaseTypes","ref":"FALCON-2066.DatabaseTypes","sha":"3131122a4c8936ff8c337406fe457be0e5c36c29","user":{"login":"vramachan","id":11688485,"avatar_url":"https://avatars.githubusercontent.com/u/11688485?v=3","gravatar_id":"","url":"https://api.github.com/users/vramachan","html_url":"https://github.com/vramachan","followers_url":"https://api.github.com/users/vramachan/followers","following_url":"https://api.github.com/users/vramachan/following{/other_user}","gists_url":"https://api.github.com/users/vramachan/gists{/gist_id}","starred_url":"https://api.github.com/users/vramachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramachan/subscriptions","organizations_url":"https://api.github.com/users/vramachan/orgs","repos_url":"https://api.github.com/users/vramachan/repos","events_url":"https://api.github.com/users/vramachan/events{/privacy}","received_events_url":"https://api.github.com/users/vramachan/received_events","type":"User","site_admin":false},"repo":{"id":56727821,"name":"falcon","full_name":"vramachan/falcon","owner":{"login":"vramachan","id":11688485,"avatar_url":"https://avatars.githubusercontent.com/u/11688485?v=3","gravatar_id":"","url":"https://api.github.com/users/vramachan","html_url":"https://github.com/vramachan","followers_url":"https://api.github.com/users/vramachan/followers","following_url":"https://api.github.com/users/vramachan/following{/other_user}","gists_url":"https://api.github.com/users/vramachan/gists{/gist_id}","starred_url":"https://api.github.com/users/vramachan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramachan/subscriptions","organizations_url":"https://api.github.com/users/vramachan/orgs","repos_url":"https://api.github.com/users/vramachan/repos","events_url":"https://api.github.com/users/vramachan/events{/privacy}","received_events_url":"https://api.github.com/users/vramachan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vramachan/falcon","description":"Mirror of Apache Falcon","fork":true,"url":"https://api.github.com/repos/vramachan/falcon","forks_url":"https://api.github.com/repos/vramachan/falcon/forks","keys_url":"https://api.github.com/repos/vramachan/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vramachan/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vramachan/falcon/teams","hooks_url":"https://api.github.com/repos/vramachan/falcon/hooks","issue_events_url":"https://api.github.com/repos/vramachan/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/vramachan/falcon/events","assignees_url":"https://api.github.com/repos/vramachan/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/vramachan/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/vramachan/falcon/tags","blobs_url":"https://api.github.com/repos/vramachan/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vramachan/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vramachan/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/vramachan/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vramachan/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/vramachan/falcon/languages","stargazers_url":"https://api.github.com/repos/vramachan/falcon/stargazers","contributors_url":"https://api.github.com/repos/vramachan/falcon/contributors","subscribers_url":"https://api.github.com/repos/vramachan/falcon/subscribers","subscription_url":"https://api.github.com/repos/vramachan/falcon/subscription","commits_url":"https://api.github.com/repos/vramachan/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/vramachan/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/vramachan/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/vramachan/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/vramachan/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/vramachan/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vramachan/falcon/merges","archive_url":"https://api.github.com/repos/vramachan/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vramachan/falcon/downloads","issues_url":"https://api.github.com/repos/vramachan/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/vramachan/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/vramachan/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/vramachan/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vramachan/falcon/labels{/name}","releases_url":"https://api.github.com/repos/vramachan/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/vramachan/falcon/deployments","created_at":"2016-04-20T23:37:25Z","updated_at":"2016-04-20T23:37:29Z","pushed_at":"2016-07-13T01:25:54Z","git_url":"git://github.com/vramachan/falcon.git","ssh_url":"git@github.com:vramachan/falcon.git","clone_url":"https://github.com/vramachan/falcon.git","svn_url":"https://github.com/vramachan/falcon","homepage":null,"size":30575,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e46e5c4c641fd5e35eb1fbdacbeb04d116f3a6e7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":11543457,"name":"falcon","full_name":"apache/falcon","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/falcon","description":"Mirror of Apache Falcon","fork":false,"url":"https://api.github.com/repos/apache/falcon","forks_url":"https://api.github.com/repos/apache/falcon/forks","keys_url":"https://api.github.com/repos/apache/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/falcon/teams","hooks_url":"https://api.github.com/repos/apache/falcon/hooks","issue_events_url":"https://api.github.com/repos/apache/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/apache/falcon/events","assignees_url":"https://api.github.com/repos/apache/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/apache/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/apache/falcon/tags","blobs_url":"https://api.github.com/repos/apache/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/falcon/languages","stargazers_url":"https://api.github.com/repos/apache/falcon/stargazers","contributors_url":"https://api.github.com/repos/apache/falcon/contributors","subscribers_url":"https://api.github.com/repos/apache/falcon/subscribers","subscription_url":"https://api.github.com/repos/apache/falcon/subscription","commits_url":"https://api.github.com/repos/apache/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/apache/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/falcon/merges","archive_url":"https://api.github.com/repos/apache/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/falcon/downloads","issues_url":"https://api.github.com/repos/apache/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/apache/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/falcon/labels{/name}","releases_url":"https://api.github.com/repos/apache/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/apache/falcon/deployments","created_at":"2013-07-20T07:00:14Z","updated_at":"2016-07-10T10:50:14Z","pushed_at":"2016-07-14T22:06:12Z","git_url":"git://github.com/apache/falcon.git","ssh_url":"git@github.com:apache/falcon.git","clone_url":"https://github.com/apache/falcon.git","svn_url":"https://github.com/apache/falcon","homepage":null,"size":32687,"stargazers_count":53,"watchers_count":53,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":"git://git.apache.org/falcon.git","open_issues_count":24,"forks":79,"open_issues":24,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/224"},"html":{"href":"https://github.com/apache/falcon/pull/224"},"issue":{"href":"https://api.github.com/repos/apache/falcon/issues/224"},"comments":{"href":"https://api.github.com/repos/apache/falcon/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/falcon/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/falcon/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/apache/falcon/statuses/3131122a4c8936ff8c337406fe457be0e5c36c29"}}}}
{"actor":{"display_login":"vrangan"}}