{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499/events","html_url":"https://github.com/cms-sw/cmssw/pull/15499","id":171675916,"number":15499,"title":"HE- energy reconstruction - phase1","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-approved","name":"alca-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-approved","name":"orp-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-approved","name":"reconstruction-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":69,"closed_issues":1320,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-08-31T17:05:49Z","due_on":null,"closed_at":null},"comments":82,"created_at":"2016-08-17T14:42:44Z","updated_at":"2016-08-31T18:37:49Z","closed_at":"2016-08-30T10:55:28Z","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499","html_url":"https://github.com/cms-sw/cmssw/pull/15499","diff_url":"https://github.com/cms-sw/cmssw/pull/15499.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15499.patch"},"body":"This PR implement the phase1 M2/M0 method and add some general cleanup in some code common to the run2 version.\r\n\r\nThings to note:\r\n1) removed unused inputTags/enum\r\n2) re-arranged Pset to handle the M2 paramters for the siPM             \r\n3) from Salvat's fixed M0 energy ( see commit d67ef34 )\r\n4) memory heap std::vector<double> & Output --> float*, (see commit 3551190) Slava/Igor's request\r\n5) from Slava's various double -> float to speed time ( see commit a3fb0c6)\r\n\r\nSlides w/ descriptions/tests include up to commit 6bc3caa https://indico.cern.ch/event/563410/contributions/2277004/attachments/1324249/1988640/PR15499.pdf\r\n\r\nTo be considered for the 80X backport (pure sw changes):\r\na3fb0c6: from Slava this improve the CPU timing of 20% on ttbar events\r\n4359dac: from Carl this protect for potential division by zero\r\n3551190: from Slava/Igor this improve the memory"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/243859343","html_url":"https://github.com/cms-sw/cmssw/pull/15499#issuecomment-243859343","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499","id":243859343,"user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T18:37:49Z","updated_at":"2016-08-31T18:37:49Z","body":"Thanks for the tip, but I still couldn't reproduce the crash with that. I'm just going to run valgrind and see if points to anything useful."}}
{"actor":{"display_login":"kpedro88"}}