{"action":"created","issue":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/272","repository_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator","labels_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/272/comments","events_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/272/events","html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/272","id":140918760,"number":272,"title":"Element should be an array when maxOccurs is a number","user":{"login":"ghost","id":10137,"avatar_url":"https://avatars.githubusercontent.com/u/10137?v=3","gravatar_id":"","url":"https://api.github.com/users/ghost","html_url":"https://github.com/ghost","followers_url":"https://api.github.com/users/ghost/followers","following_url":"https://api.github.com/users/ghost/following{/other_user}","gists_url":"https://api.github.com/users/ghost/gists{/gist_id}","starred_url":"https://api.github.com/users/ghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghost/subscriptions","organizations_url":"https://api.github.com/users/ghost/orgs","repos_url":"https://api.github.com/users/ghost/repos","events_url":"https://api.github.com/users/ghost/events{/privacy}","received_events_url":"https://api.github.com/users/ghost/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/labels/Bug","name":"Bug","color":"e30d0d"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-03-15T09:24:41Z","updated_at":"2016-10-17T19:28:23Z","closed_at":"2016-10-17T19:28:23Z","pull_request":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/pulls/272","html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/272","diff_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/272.diff","patch_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/272.patch"},"body":"I found that not all elements in a WSDL document that should be an array, where found to be one.  In the _isElementArray_ function in [_TypeNode.php_](src/Xml/TypeNode.php) only elements with the attribute _maxOccurs_ set to _unbounded_ where found to be an array.  I changed the test, so elements with the attribute _maxOccurs_ set to 2 or higher where also found to be an array.\r\n\r\nI've tested this code with only one type of WSDL and have not found drawbacks in other parts of the could.  I do not know if there are checks for arrays, to be found invalid, if there are more items than _maxOccurs_ specifies.  But for my code that was no issue."},"comment":{"url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/comments/254308093","html_url":"https://github.com/wsdl2phpgenerator/wsdl2phpgenerator/pull/272#issuecomment-254308093","issue_url":"https://api.github.com/repos/wsdl2phpgenerator/wsdl2phpgenerator/issues/272","id":254308093,"user":{"login":"kasperg","id":73966,"avatar_url":"https://avatars.githubusercontent.com/u/73966?v=3","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T19:28:23Z","updated_at":"2016-10-17T19:28:23Z","body":"Thanks for the contribution @peter-vanpoucke and for chiming in @DerMika.\r\n\r\nI took the liberty of readding a trailing line break and committing the fix in 80fb8a21d0c8e7231bb7004c50110c4c2e90f194."}}
{"actor":{"display_login":"kasperg"}}