{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/80307176","id":80307176,"diff_hunk":"@@ -14961,6 +14965,19 @@ Lowerer::GenerateFastElemIIntIndexCommon(\n             autoReuseNewLengthOpnd.Initialize(newLengthOpnd, m_func);\n         }\n \n+        // This is a common enough case that we want to go through this path instead of the simpler one, since doing it this way is faster for preallocated but un-filled arrays.\n+        if (!!(bailOutKind & IR::BailOutOnInvalidatedArrayLength))\n+        {\n+            // If we'd increase the array length, go to the helper\n+            indirOpnd = IR::IndirOpnd::New(arrayOpnd, Js::JavascriptArray::GetOffsetOfLength(), TyUint32, this->m_func);\n+            InsertCompareBranch(\n+                newLengthOpnd,\n+                indirOpnd,\n+                Js::OpCode::BrGe_A,","path":"lib/Backend/Lower.cpp","position":84,"original_position":84,"commit_id":"252edc132c43bfc83acea5112146406a0f33afe2","original_commit_id":"606e8e3aa28d7ec6f8d85448be5b72d3f4fc44d7","user":{"login":"rajatd","id":15348123,"avatar_url":"https://avatars.githubusercontent.com/u/15348123?v=3","gravatar_id":"","url":"https://api.github.com/users/rajatd","html_url":"https://github.com/rajatd","followers_url":"https://api.github.com/users/rajatd/followers","following_url":"https://api.github.com/users/rajatd/following{/other_user}","gists_url":"https://api.github.com/users/rajatd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatd/subscriptions","organizations_url":"https://api.github.com/users/rajatd/orgs","repos_url":"https://api.github.com/users/rajatd/repos","events_url":"https://api.github.com/users/rajatd/events{/privacy}","received_events_url":"https://api.github.com/users/rajatd/received_events","type":"User","site_admin":false},"body":">BrGe_A [](start = 28, length = 6)\r\n\r\nshould this be BrGt_A ?","created_at":"2016-09-23T19:04:55Z","updated_at":"2016-09-23T19:04:55Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1587#discussion_r80307176","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/80307176"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1587#discussion_r80307176"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587","id":85502783,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1587","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1587.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1587.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1587","number":1587,"state":"open","locked":false,"title":"Defer LdLen instruction handling until globopt so that we can leave it as LdFld for non-array-like objects.","user":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars.githubusercontent.com/u/69503?v=3","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"body":"This changset makes us handle situations better where the .length field is used on objects other than arrays/strings/arguments, and makes a few optimizations a little more robust.","created_at":"2016-09-16T00:22:17Z","updated_at":"2016-09-23T19:04:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d973a0157fbaa983341d22670c5718c76ef4e08","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1587/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/252edc132c43bfc83acea5112146406a0f33afe2","head":{"label":"Penguinwizzard:ldlen_fixups","ref":"ldlen_fixups","sha":"252edc132c43bfc83acea5112146406a0f33afe2","user":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars.githubusercontent.com/u/69503?v=3","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"repo":{"id":68159295,"name":"ChakraCore","full_name":"Penguinwizzard/ChakraCore","owner":{"login":"Penguinwizzard","id":69503,"avatar_url":"https://avatars.githubusercontent.com/u/69503?v=3","gravatar_id":"","url":"https://api.github.com/users/Penguinwizzard","html_url":"https://github.com/Penguinwizzard","followers_url":"https://api.github.com/users/Penguinwizzard/followers","following_url":"https://api.github.com/users/Penguinwizzard/following{/other_user}","gists_url":"https://api.github.com/users/Penguinwizzard/gists{/gist_id}","starred_url":"https://api.github.com/users/Penguinwizzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Penguinwizzard/subscriptions","organizations_url":"https://api.github.com/users/Penguinwizzard/orgs","repos_url":"https://api.github.com/users/Penguinwizzard/repos","events_url":"https://api.github.com/users/Penguinwizzard/events{/privacy}","received_events_url":"https://api.github.com/users/Penguinwizzard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Penguinwizzard/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/Penguinwizzard/ChakraCore","forks_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/forks","keys_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/events","assignees_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/merges","archive_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Penguinwizzard/ChakraCore/deployments","created_at":"2016-09-14T00:39:02Z","updated_at":"2016-09-14T00:39:23Z","pushed_at":"2016-09-23T18:31:58Z","git_url":"git://github.com/Penguinwizzard/ChakraCore.git","ssh_url":"git@github.com:Penguinwizzard/ChakraCore.git","clone_url":"https://github.com/Penguinwizzard/ChakraCore.git","svn_url":"https://github.com/Penguinwizzard/ChakraCore","homepage":null,"size":88898,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"bce7a35e6f66ebf53917bc884f4bdf000e211ed4","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-09-23T11:58:16Z","pushed_at":"2016-09-23T18:31:59Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":52429,"stargazers_count":5653,"watchers_count":5653,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":628,"mirror_url":null,"open_issues_count":169,"forks":628,"open_issues":169,"watchers":5653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1587"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1587"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1587/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1587/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/252edc132c43bfc83acea5112146406a0f33afe2"}}}}
{"actor":{"display_login":"rajatd"}}