{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/57404595","id":57404595,"diff_hunk":"@@ -85,8 +85,9 @@ int sd_dhcp6_client_set_index(sd_dhcp6_client *client, int interface_index);\n int sd_dhcp6_client_set_local_address(sd_dhcp6_client *client, const struct in6_addr *local_address);\n int sd_dhcp6_client_set_mac(sd_dhcp6_client *client, const uint8_t *addr,\n                             size_t addr_len, uint16_t arp_type);\n-int sd_dhcp6_client_set_duid(sd_dhcp6_client *client, uint16_t type, uint8_t *duid,\n-                             size_t duid_len);\n+int sd_dhcp6_client_set_duid(sd_dhcp6_client *client, uint16_t duid_type,\n+                             size_t duid_len, uint8_t *duid);\n+int sd_dhcp6_client_set_iaid(sd_dhcp6_client *client, uint32_t iaid);","path":"src/systemd/sd-dhcp6-client.h","position":8,"original_position":8,"commit_id":"f622ed3866705cdf3ae1f152468a39d8ee3287ae","original_commit_id":"f622ed3866705cdf3ae1f152468a39d8ee3287ae","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars.githubusercontent.com/u/349618?v=3","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"Why this change?","created_at":"2016-03-24T23:43:13Z","updated_at":"2016-03-24T23:43:13Z","html_url":"https://github.com/systemd/systemd/pull/2890#discussion_r57404595","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/2890","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/57404595"},"html":{"href":"https://github.com/systemd/systemd/pull/2890#discussion_r57404595"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2890"}}},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/2890","id":63972684,"html_url":"https://github.com/systemd/systemd/pull/2890","diff_url":"https://github.com/systemd/systemd/pull/2890.diff","patch_url":"https://github.com/systemd/systemd/pull/2890.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/2890","number":2890,"state":"open","locked":false,"title":"DHCP DUID, IAID configuration options","user":{"login":"vinaykul","id":12750645,"avatar_url":"https://avatars.githubusercontent.com/u/12750645?v=3","gravatar_id":"","url":"https://api.github.com/users/vinaykul","html_url":"https://github.com/vinaykul","followers_url":"https://api.github.com/users/vinaykul/followers","following_url":"https://api.github.com/users/vinaykul/following{/other_user}","gists_url":"https://api.github.com/users/vinaykul/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaykul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaykul/subscriptions","organizations_url":"https://api.github.com/users/vinaykul/orgs","repos_url":"https://api.github.com/users/vinaykul/repos","events_url":"https://api.github.com/users/vinaykul/events{/privacy}","received_events_url":"https://api.github.com/users/vinaykul/received_events","type":"User","site_admin":false},"body":"This integrates changes in https://github.com/systemd/systemd/pull/2818 and https://github.com/systemd/systemd/pull/2857, and fixes the public header file issue in  https://github.com/systemd/systemd/pull/2818#issuecomment-199515053.\r\n\r\nTested using our VM upgrade scenario:\r\nIAID is specified in 10-eth0.network file in the [Link] section.\r\n1. DUID specified in /etc/systemd/networkd.conf\r\n2. DUID specified in /etc/systemd/network/10-eth0.network\r\n3. DUID in networkd.conf overridden by DUID specified in 10-eth0.network.\r\n\r\nIPv6 address migration was successful in all these cases. IPv4 address migration happened if ClientIdentifier=duid, and would not migrate if it is 'mac'. \r\n\r\nIf DUID and IAID are not specified, systemd generates them based on machine-id and ifname respectively.\r\n\r\n/cc @teg @poettering @keszybz @zonque @thom311 @nfnty \r\n\r\n","created_at":"2016-03-24T00:10:37Z","updated_at":"2016-03-24T23:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f55b4974bc1d030eb7d3f05f6baa137810d1100","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/2890/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/2890/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/2890/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/f622ed3866705cdf3ae1f152468a39d8ee3287ae","head":{"label":"vinaykul:master","ref":"master","sha":"f622ed3866705cdf3ae1f152468a39d8ee3287ae","user":{"login":"vinaykul","id":12750645,"avatar_url":"https://avatars.githubusercontent.com/u/12750645?v=3","gravatar_id":"","url":"https://api.github.com/users/vinaykul","html_url":"https://github.com/vinaykul","followers_url":"https://api.github.com/users/vinaykul/followers","following_url":"https://api.github.com/users/vinaykul/following{/other_user}","gists_url":"https://api.github.com/users/vinaykul/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaykul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaykul/subscriptions","organizations_url":"https://api.github.com/users/vinaykul/orgs","repos_url":"https://api.github.com/users/vinaykul/repos","events_url":"https://api.github.com/users/vinaykul/events{/privacy}","received_events_url":"https://api.github.com/users/vinaykul/received_events","type":"User","site_admin":false},"repo":{"id":52642301,"name":"systemd","full_name":"vinaykul/systemd","owner":{"login":"vinaykul","id":12750645,"avatar_url":"https://avatars.githubusercontent.com/u/12750645?v=3","gravatar_id":"","url":"https://api.github.com/users/vinaykul","html_url":"https://github.com/vinaykul","followers_url":"https://api.github.com/users/vinaykul/followers","following_url":"https://api.github.com/users/vinaykul/following{/other_user}","gists_url":"https://api.github.com/users/vinaykul/gists{/gist_id}","starred_url":"https://api.github.com/users/vinaykul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinaykul/subscriptions","organizations_url":"https://api.github.com/users/vinaykul/orgs","repos_url":"https://api.github.com/users/vinaykul/repos","events_url":"https://api.github.com/users/vinaykul/events{/privacy}","received_events_url":"https://api.github.com/users/vinaykul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinaykul/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/vinaykul/systemd","forks_url":"https://api.github.com/repos/vinaykul/systemd/forks","keys_url":"https://api.github.com/repos/vinaykul/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinaykul/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinaykul/systemd/teams","hooks_url":"https://api.github.com/repos/vinaykul/systemd/hooks","issue_events_url":"https://api.github.com/repos/vinaykul/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/vinaykul/systemd/events","assignees_url":"https://api.github.com/repos/vinaykul/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/vinaykul/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/vinaykul/systemd/tags","blobs_url":"https://api.github.com/repos/vinaykul/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinaykul/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinaykul/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinaykul/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinaykul/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/vinaykul/systemd/languages","stargazers_url":"https://api.github.com/repos/vinaykul/systemd/stargazers","contributors_url":"https://api.github.com/repos/vinaykul/systemd/contributors","subscribers_url":"https://api.github.com/repos/vinaykul/systemd/subscribers","subscription_url":"https://api.github.com/repos/vinaykul/systemd/subscription","commits_url":"https://api.github.com/repos/vinaykul/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinaykul/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinaykul/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinaykul/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinaykul/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/vinaykul/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinaykul/systemd/merges","archive_url":"https://api.github.com/repos/vinaykul/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinaykul/systemd/downloads","issues_url":"https://api.github.com/repos/vinaykul/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/vinaykul/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/vinaykul/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/vinaykul/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinaykul/systemd/labels{/name}","releases_url":"https://api.github.com/repos/vinaykul/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/vinaykul/systemd/deployments","created_at":"2016-02-27T00:45:49Z","updated_at":"2016-02-27T00:45:56Z","pushed_at":"2016-03-23T23:49:40Z","git_url":"git://github.com/vinaykul/systemd.git","ssh_url":"git@github.com:vinaykul/systemd.git","clone_url":"https://github.com/vinaykul/systemd.git","svn_url":"https://github.com/vinaykul/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":56184,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"1eb963a32ddd2147057178cc230d919b66a90db7","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2016-03-24T18:19:01Z","pushed_at":"2016-03-24T09:37:19Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":69098,"stargazers_count":969,"watchers_count":969,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":376,"mirror_url":null,"open_issues_count":363,"forks":376,"open_issues":363,"watchers":969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2890"},"html":{"href":"https://github.com/systemd/systemd/pull/2890"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/2890"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/2890/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2890/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/2890/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/f622ed3866705cdf3ae1f152468a39d8ee3287ae"}}}}