{"action":"created","issue":{"url":"https://api.github.com/repos/servo/saltfs/issues/290","repository_url":"https://api.github.com/repos/servo/saltfs","labels_url":"https://api.github.com/repos/servo/saltfs/issues/290/labels{/name}","comments_url":"https://api.github.com/repos/servo/saltfs/issues/290/comments","events_url":"https://api.github.com/repos/servo/saltfs/issues/290/events","html_url":"https://github.com/servo/saltfs/pull/290","id":145318043,"number":290,"title":"Update android-18 menu entry to 8 for SDK r24","user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-02T00:43:40Z","updated_at":"2016-05-13T05:00:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/saltfs/pulls/290","html_url":"https://github.com/servo/saltfs/pull/290","diff_url":"https://github.com/servo/saltfs/pull/290.diff","patch_url":"https://github.com/servo/saltfs/pull/290.patch"},"body":"We're ignoring Travis builds for the cross builder and this fix needs to be verified in Vagrant (this VM takes a while to provision unfortunately). We may want to actually try running a build in Vagrant to see if this works.\r\n\r\nWe updated to Android SDK r24 in November from r23, but did not update\r\nthe menu entry to install the android-18 target. The new number comes\r\nfrom the output of `./android sdk list`.\r\n\r\nWe need to delete the `/home/servo/android/sdk/r24.4.1` folder before applying this fix to the builders. Ideally this would get checked for by Salt, but currently you can only specify one file for the ` - creates: ` key of `cmd.run`, and our state creates the `platform-tools` dir and the `android-18` dir. I'll open a Salt issue for this.\r\n\r\ncc @larsbergstrom, https://github.com/servo/servo/issues/10339\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/saltfs/290)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/saltfs/issues/comments/218952313","html_url":"https://github.com/servo/saltfs/pull/290#issuecomment-218952313","issue_url":"https://api.github.com/repos/servo/saltfs/issues/290","id":218952313,"user":{"login":"aneeshusa","id":2085567,"avatar_url":"https://avatars.githubusercontent.com/u/2085567?v=3","gravatar_id":"","url":"https://api.github.com/users/aneeshusa","html_url":"https://github.com/aneeshusa","followers_url":"https://api.github.com/users/aneeshusa/followers","following_url":"https://api.github.com/users/aneeshusa/following{/other_user}","gists_url":"https://api.github.com/users/aneeshusa/gists{/gist_id}","starred_url":"https://api.github.com/users/aneeshusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneeshusa/subscriptions","organizations_url":"https://api.github.com/users/aneeshusa/orgs","repos_url":"https://api.github.com/users/aneeshusa/repos","events_url":"https://api.github.com/users/aneeshusa/events{/privacy}","received_events_url":"https://api.github.com/users/aneeshusa/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T05:00:01Z","updated_at":"2016-05-13T05:00:01Z","body":"Ping on this; `android-nightly` was failing to compile previously (I think due to an LLVM bug), but a recent rustup means compilation now succeeds and this is again a blocker for sucessful android-nightly runs."}}