{"action":"created","issue":{"url":"https://api.github.com/repos/mholt/caddy/issues/1126","repository_url":"https://api.github.com/repos/mholt/caddy","labels_url":"https://api.github.com/repos/mholt/caddy/issues/1126/labels{/name}","comments_url":"https://api.github.com/repos/mholt/caddy/issues/1126/comments","events_url":"https://api.github.com/repos/mholt/caddy/issues/1126/events","html_url":"https://github.com/mholt/caddy/pull/1126","id":178723282,"number":1126,"title":"Make FastCGI persistent connections optional; add tests","user":{"login":"Echsecutor","id":5765579,"avatar_url":"https://avatars.githubusercontent.com/u/5765579?v=3","gravatar_id":"","url":"https://api.github.com/users/Echsecutor","html_url":"https://github.com/Echsecutor","followers_url":"https://api.github.com/users/Echsecutor/followers","following_url":"https://api.github.com/users/Echsecutor/following{/other_user}","gists_url":"https://api.github.com/users/Echsecutor/gists{/gist_id}","starred_url":"https://api.github.com/users/Echsecutor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Echsecutor/subscriptions","organizations_url":"https://api.github.com/users/Echsecutor/orgs","repos_url":"https://api.github.com/users/Echsecutor/repos","events_url":"https://api.github.com/users/Echsecutor/events{/privacy}","received_events_url":"https://api.github.com/users/Echsecutor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mholt/caddy/labels/under%20review","name":"under review","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-22T21:19:45Z","updated_at":"2016-09-24T00:23:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mholt/caddy/pulls/1126","html_url":"https://github.com/mholt/caddy/pull/1126","diff_url":"https://github.com/mholt/caddy/pull/1126.diff","patch_url":"https://github.com/mholt/caddy/pull/1126.patch"},"body":"Here I deliver some code which I still owe you. ;)\r\nThis should have been in my last pull request already.\r\n\r\nI have added a \"persistent\" (bool) option to the fastcgi directive to toggle the use of the new persistent fastcgi connections. Furthermore I have added test for the new directive, but more importantly also for the persistent connections. This test has already revealed, that the new persistent connection can be broken by to many parallel requests. I am investigating...\r\nThis is a quick fix for https://github.com/mholt/caddy/issues/1123"},"comment":{"url":"https://api.github.com/repos/mholt/caddy/issues/comments/249331329","html_url":"https://github.com/mholt/caddy/pull/1126#issuecomment-249331329","issue_url":"https://api.github.com/repos/mholt/caddy/issues/1126","id":249331329,"user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"created_at":"2016-09-24T00:23:48Z","updated_at":"2016-09-24T00:23:48Z","body":"@Echsecutor I think we will go with @abiosoft's PR. However, yours has the TestPersistence function which I think would be good to have. Basically, you've already written a test for what his PR fixes, and I think it would be very good to have that test."}}
{"actor":{"display_login":"mholt"}}