{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/samueljseay/page_object/pulls/5","id":99283300,"html_url":"https://github.com/samueljseay/page_object/pull/5","diff_url":"https://github.com/samueljseay/page_object/pull/5.diff","patch_url":"https://github.com/samueljseay/page_object/pull/5.patch","issue_url":"https://api.github.com/repos/samueljseay/page_object/issues/5","number":5,"state":"closed","locked":false,"title":"Add option to not clear before filling","user":{"login":"backspace","id":43280,"avatar_url":"https://avatars.githubusercontent.com/u/43280?v=3","gravatar_id":"","url":"https://api.github.com/users/backspace","html_url":"https://github.com/backspace","followers_url":"https://api.github.com/users/backspace/followers","following_url":"https://api.github.com/users/backspace/following{/other_user}","gists_url":"https://api.github.com/users/backspace/gists{/gist_id}","starred_url":"https://api.github.com/users/backspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backspace/subscriptions","organizations_url":"https://api.github.com/users/backspace/orgs","repos_url":"https://api.github.com/users/backspace/repos","events_url":"https://api.github.com/users/backspace/events{/privacy}","received_events_url":"https://api.github.com/users/backspace/received_events","type":"User","site_admin":false},"body":"Hello, thanks so much for this library! I was wanting something like it in January as I’ve become fond of the pattern in Ember, so it’s nice to come back to Elixir and have it around.\r\n\r\nI’ve found that I’m unable to use `fillable` to choose values from a `select` because Hound throws this error:\r\n\r\n`Element must be user-editable in order to clear it.`\r\n\r\nThat’s because the underlying `fill_field` clears the element first and Hound doesn’t know how to do that with a `select`. So this is a naïve implementation with a `clear: false` option that will cause it to use Hound’s `input_into_field` instead.\r\n\r\nI don’t propose that you actually merge this, I just want to get your feedback on what you think the interface should be, if you want to go ahead with supporting this use case. Since `ember-cli-page-object` already has a `selectable` action, I imagine that would be more in line with your plans?\r\n\r\nWhile I’m here, do you have any thoughts about the `component`-type pattern of `ember-cli-page-object`? I used a nested module and it seems similar enough, does that seem worth documenting, or maybe it’s obvious to people with more Elixir experience?\r\n\r\nI could also make another pull request with an `is_visible` query, which is something I’m missing. It can use [`Hound.Matchers.element?/2`](https://hexdocs.pm/hound/Hound.Matchers.html#element?/2).\r\n\r\nLet me know your thoughts!","created_at":"2016-12-23T21:40:01Z","updated_at":"2017-01-01T18:47:48Z","closed_at":"2017-01-01T18:47:48Z","merged_at":null,"merge_commit_sha":"a786975b48af243727032a6348648c309a8b8d0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/samueljseay/page_object/pulls/5/commits","review_comments_url":"https://api.github.com/repos/samueljseay/page_object/pulls/5/comments","review_comment_url":"https://api.github.com/repos/samueljseay/page_object/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samueljseay/page_object/issues/5/comments","statuses_url":"https://api.github.com/repos/samueljseay/page_object/statuses/b975c5e7073c3fe274eb16bc75de70f2fa82f513","head":{"label":"backspace:fillable-with-clearing","ref":"fillable-with-clearing","sha":"b975c5e7073c3fe274eb16bc75de70f2fa82f513","user":{"login":"backspace","id":43280,"avatar_url":"https://avatars.githubusercontent.com/u/43280?v=3","gravatar_id":"","url":"https://api.github.com/users/backspace","html_url":"https://github.com/backspace","followers_url":"https://api.github.com/users/backspace/followers","following_url":"https://api.github.com/users/backspace/following{/other_user}","gists_url":"https://api.github.com/users/backspace/gists{/gist_id}","starred_url":"https://api.github.com/users/backspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backspace/subscriptions","organizations_url":"https://api.github.com/users/backspace/orgs","repos_url":"https://api.github.com/users/backspace/repos","events_url":"https://api.github.com/users/backspace/events{/privacy}","received_events_url":"https://api.github.com/users/backspace/received_events","type":"User","site_admin":false},"repo":{"id":77250014,"name":"page_object","full_name":"backspace/page_object","owner":{"login":"backspace","id":43280,"avatar_url":"https://avatars.githubusercontent.com/u/43280?v=3","gravatar_id":"","url":"https://api.github.com/users/backspace","html_url":"https://github.com/backspace","followers_url":"https://api.github.com/users/backspace/followers","following_url":"https://api.github.com/users/backspace/following{/other_user}","gists_url":"https://api.github.com/users/backspace/gists{/gist_id}","starred_url":"https://api.github.com/users/backspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backspace/subscriptions","organizations_url":"https://api.github.com/users/backspace/orgs","repos_url":"https://api.github.com/users/backspace/repos","events_url":"https://api.github.com/users/backspace/events{/privacy}","received_events_url":"https://api.github.com/users/backspace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/backspace/page_object","description":"Page Objects for Hound / Elixir","fork":true,"url":"https://api.github.com/repos/backspace/page_object","forks_url":"https://api.github.com/repos/backspace/page_object/forks","keys_url":"https://api.github.com/repos/backspace/page_object/keys{/key_id}","collaborators_url":"https://api.github.com/repos/backspace/page_object/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/backspace/page_object/teams","hooks_url":"https://api.github.com/repos/backspace/page_object/hooks","issue_events_url":"https://api.github.com/repos/backspace/page_object/issues/events{/number}","events_url":"https://api.github.com/repos/backspace/page_object/events","assignees_url":"https://api.github.com/repos/backspace/page_object/assignees{/user}","branches_url":"https://api.github.com/repos/backspace/page_object/branches{/branch}","tags_url":"https://api.github.com/repos/backspace/page_object/tags","blobs_url":"https://api.github.com/repos/backspace/page_object/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/backspace/page_object/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/backspace/page_object/git/refs{/sha}","trees_url":"https://api.github.com/repos/backspace/page_object/git/trees{/sha}","statuses_url":"https://api.github.com/repos/backspace/page_object/statuses/{sha}","languages_url":"https://api.github.com/repos/backspace/page_object/languages","stargazers_url":"https://api.github.com/repos/backspace/page_object/stargazers","contributors_url":"https://api.github.com/repos/backspace/page_object/contributors","subscribers_url":"https://api.github.com/repos/backspace/page_object/subscribers","subscription_url":"https://api.github.com/repos/backspace/page_object/subscription","commits_url":"https://api.github.com/repos/backspace/page_object/commits{/sha}","git_commits_url":"https://api.github.com/repos/backspace/page_object/git/commits{/sha}","comments_url":"https://api.github.com/repos/backspace/page_object/comments{/number}","issue_comment_url":"https://api.github.com/repos/backspace/page_object/issues/comments{/number}","contents_url":"https://api.github.com/repos/backspace/page_object/contents/{+path}","compare_url":"https://api.github.com/repos/backspace/page_object/compare/{base}...{head}","merges_url":"https://api.github.com/repos/backspace/page_object/merges","archive_url":"https://api.github.com/repos/backspace/page_object/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/backspace/page_object/downloads","issues_url":"https://api.github.com/repos/backspace/page_object/issues{/number}","pulls_url":"https://api.github.com/repos/backspace/page_object/pulls{/number}","milestones_url":"https://api.github.com/repos/backspace/page_object/milestones{/number}","notifications_url":"https://api.github.com/repos/backspace/page_object/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/backspace/page_object/labels{/name}","releases_url":"https://api.github.com/repos/backspace/page_object/releases{/id}","deployments_url":"https://api.github.com/repos/backspace/page_object/deployments","created_at":"2016-12-23T20:50:40Z","updated_at":"2016-12-23T20:50:43Z","pushed_at":"2017-01-01T17:12:36Z","git_url":"git://github.com/backspace/page_object.git","ssh_url":"git@github.com:backspace/page_object.git","clone_url":"https://github.com/backspace/page_object.git","svn_url":"https://github.com/backspace/page_object","homepage":"","size":41,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samueljseay:master","ref":"master","sha":"4ba3a698ada5c3d2cfe1b3c52477715431535211","user":{"login":"samueljseay","id":1281828,"avatar_url":"https://avatars.githubusercontent.com/u/1281828?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljseay","html_url":"https://github.com/samueljseay","followers_url":"https://api.github.com/users/samueljseay/followers","following_url":"https://api.github.com/users/samueljseay/following{/other_user}","gists_url":"https://api.github.com/users/samueljseay/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljseay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljseay/subscriptions","organizations_url":"https://api.github.com/users/samueljseay/orgs","repos_url":"https://api.github.com/users/samueljseay/repos","events_url":"https://api.github.com/users/samueljseay/events{/privacy}","received_events_url":"https://api.github.com/users/samueljseay/received_events","type":"User","site_admin":false},"repo":{"id":61974399,"name":"page_object","full_name":"samueljseay/page_object","owner":{"login":"samueljseay","id":1281828,"avatar_url":"https://avatars.githubusercontent.com/u/1281828?v=3","gravatar_id":"","url":"https://api.github.com/users/samueljseay","html_url":"https://github.com/samueljseay","followers_url":"https://api.github.com/users/samueljseay/followers","following_url":"https://api.github.com/users/samueljseay/following{/other_user}","gists_url":"https://api.github.com/users/samueljseay/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljseay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljseay/subscriptions","organizations_url":"https://api.github.com/users/samueljseay/orgs","repos_url":"https://api.github.com/users/samueljseay/repos","events_url":"https://api.github.com/users/samueljseay/events{/privacy}","received_events_url":"https://api.github.com/users/samueljseay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samueljseay/page_object","description":"Page Objects for Hound / Elixir","fork":false,"url":"https://api.github.com/repos/samueljseay/page_object","forks_url":"https://api.github.com/repos/samueljseay/page_object/forks","keys_url":"https://api.github.com/repos/samueljseay/page_object/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samueljseay/page_object/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samueljseay/page_object/teams","hooks_url":"https://api.github.com/repos/samueljseay/page_object/hooks","issue_events_url":"https://api.github.com/repos/samueljseay/page_object/issues/events{/number}","events_url":"https://api.github.com/repos/samueljseay/page_object/events","assignees_url":"https://api.github.com/repos/samueljseay/page_object/assignees{/user}","branches_url":"https://api.github.com/repos/samueljseay/page_object/branches{/branch}","tags_url":"https://api.github.com/repos/samueljseay/page_object/tags","blobs_url":"https://api.github.com/repos/samueljseay/page_object/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samueljseay/page_object/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samueljseay/page_object/git/refs{/sha}","trees_url":"https://api.github.com/repos/samueljseay/page_object/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samueljseay/page_object/statuses/{sha}","languages_url":"https://api.github.com/repos/samueljseay/page_object/languages","stargazers_url":"https://api.github.com/repos/samueljseay/page_object/stargazers","contributors_url":"https://api.github.com/repos/samueljseay/page_object/contributors","subscribers_url":"https://api.github.com/repos/samueljseay/page_object/subscribers","subscription_url":"https://api.github.com/repos/samueljseay/page_object/subscription","commits_url":"https://api.github.com/repos/samueljseay/page_object/commits{/sha}","git_commits_url":"https://api.github.com/repos/samueljseay/page_object/git/commits{/sha}","comments_url":"https://api.github.com/repos/samueljseay/page_object/comments{/number}","issue_comment_url":"https://api.github.com/repos/samueljseay/page_object/issues/comments{/number}","contents_url":"https://api.github.com/repos/samueljseay/page_object/contents/{+path}","compare_url":"https://api.github.com/repos/samueljseay/page_object/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samueljseay/page_object/merges","archive_url":"https://api.github.com/repos/samueljseay/page_object/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samueljseay/page_object/downloads","issues_url":"https://api.github.com/repos/samueljseay/page_object/issues{/number}","pulls_url":"https://api.github.com/repos/samueljseay/page_object/pulls{/number}","milestones_url":"https://api.github.com/repos/samueljseay/page_object/milestones{/number}","notifications_url":"https://api.github.com/repos/samueljseay/page_object/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samueljseay/page_object/labels{/name}","releases_url":"https://api.github.com/repos/samueljseay/page_object/releases{/id}","deployments_url":"https://api.github.com/repos/samueljseay/page_object/deployments","created_at":"2016-06-26T04:59:53Z","updated_at":"2016-11-07T15:25:50Z","pushed_at":"2017-01-01T17:13:02Z","git_url":"git://github.com/samueljseay/page_object.git","ssh_url":"git@github.com:samueljseay/page_object.git","clone_url":"https://github.com/samueljseay/page_object.git","svn_url":"https://github.com/samueljseay/page_object","homepage":"","size":39,"stargazers_count":11,"watchers_count":11,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samueljseay/page_object/pulls/5"},"html":{"href":"https://github.com/samueljseay/page_object/pull/5"},"issue":{"href":"https://api.github.com/repos/samueljseay/page_object/issues/5"},"comments":{"href":"https://api.github.com/repos/samueljseay/page_object/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/samueljseay/page_object/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/samueljseay/page_object/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samueljseay/page_object/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/samueljseay/page_object/statuses/b975c5e7073c3fe274eb16bc75de70f2fa82f513"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":52,"deletions":15,"changed_files":3}}
{"actor":{"display_login":"backspace"}}