{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/67853928","id":67853928,"diff_hunk":"@@ -41,20 +40,24 @@ def verify_retirement(vm):\n                  message=\"Wait for VM {} removed from provider\".format(vm.name))\n     else:\n         today = datetime.date.today()\n-        get_date = partial(vm.get_detail, [\"Lifecycle\", \"Retirement Date\"])\n-        get_state = partial(vm.get_detail, [\"Power Management\", \"Power State\"])\n \n         # wait for the info block showing a date as retired date\n+        @pytest.wait_for(delay=30, timeout='5m')\n         def retirement_date_present():\n-            return get_date() != \"Never\"\n+            vm.summary.reload()\n+            return vm.summary.lifecycle.retirement_date.text_value.lower() != 'never'\n \n-        wait_for(retirement_date_present, delay=30, num_sec=600, message=\"retirement_date_present\")\n+        # wait for the state to change\n+        @pytest.wait_for(delay=15, timeout='6m')\n+        def wait_for_retired():\n+            vm.summary.reload()\n+            return vm.summary.lifecycle.retirement_state.text_value.lower() == 'retired'\n \n-        # wait for the power state to go to 'off'\n-        wait_for(lambda: get_state() in {'off', 'suspended'}, delay=30, num_sec=360)\n+        assert vm.summary.power_management.power_state.text_value in {'off', 'suspended', 'unknown'}","path":"cfme/tests/cloud_infra_common/test_retirement.py","position":31,"original_position":31,"commit_id":"e9d9c8a5e816d8e59df4595573ecc864b5df3508","original_commit_id":"e9d9c8a5e816d8e59df4595573ecc864b5df3508","user":{"login":"mfalesni","id":2163040,"avatar_url":"https://avatars.githubusercontent.com/u/2163040?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalesni","html_url":"https://github.com/mfalesni","followers_url":"https://api.github.com/users/mfalesni/followers","following_url":"https://api.github.com/users/mfalesni/following{/other_user}","gists_url":"https://api.github.com/users/mfalesni/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalesni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalesni/subscriptions","organizations_url":"https://api.github.com/users/mfalesni/orgs","repos_url":"https://api.github.com/users/mfalesni/repos","events_url":"https://api.github.com/users/mfalesni/events{/privacy}","received_events_url":"https://api.github.com/users/mfalesni/received_events","type":"User","site_admin":false},"body":"I would love to see some definition on what power state is expected after retirement. The previous code did not check the Retirement Status at all.","created_at":"2016-06-21T11:52:35Z","updated_at":"2016-06-21T11:52:35Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/3100#discussion_r67853928","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/67853928"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/3100#discussion_r67853928"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100","id":74432651,"html_url":"https://github.com/ManageIQ/integration_tests/pull/3100","diff_url":"https://github.com/ManageIQ/integration_tests/pull/3100.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/3100.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3100","number":3100,"state":"open","locked":false,"title":"Fix retirement tests","user":{"login":"mfalesni","id":2163040,"avatar_url":"https://avatars.githubusercontent.com/u/2163040?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalesni","html_url":"https://github.com/mfalesni","followers_url":"https://api.github.com/users/mfalesni/followers","following_url":"https://api.github.com/users/mfalesni/following{/other_user}","gists_url":"https://api.github.com/users/mfalesni/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalesni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalesni/subscriptions","organizations_url":"https://api.github.com/users/mfalesni/orgs","repos_url":"https://api.github.com/users/mfalesni/repos","events_url":"https://api.github.com/users/mfalesni/events{/privacy}","received_events_url":"https://api.github.com/users/mfalesni/received_events","type":"User","site_admin":false},"body":"They waited for a bad thing","created_at":"2016-06-20T12:06:56Z","updated_at":"2016-06-21T11:52:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f280197e3f042f9dff5d95d4de8909619dc6e5b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3100/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/e9d9c8a5e816d8e59df4595573ecc864b5df3508","head":{"label":"mfalesni:retirement_fix","ref":"retirement_fix","sha":"e9d9c8a5e816d8e59df4595573ecc864b5df3508","user":{"login":"mfalesni","id":2163040,"avatar_url":"https://avatars.githubusercontent.com/u/2163040?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalesni","html_url":"https://github.com/mfalesni","followers_url":"https://api.github.com/users/mfalesni/followers","following_url":"https://api.github.com/users/mfalesni/following{/other_user}","gists_url":"https://api.github.com/users/mfalesni/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalesni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalesni/subscriptions","organizations_url":"https://api.github.com/users/mfalesni/orgs","repos_url":"https://api.github.com/users/mfalesni/repos","events_url":"https://api.github.com/users/mfalesni/events{/privacy}","received_events_url":"https://api.github.com/users/mfalesni/received_events","type":"User","site_admin":false},"repo":{"id":12919747,"name":"cfme_tests","full_name":"mfalesni/cfme_tests","owner":{"login":"mfalesni","id":2163040,"avatar_url":"https://avatars.githubusercontent.com/u/2163040?v=3","gravatar_id":"","url":"https://api.github.com/users/mfalesni","html_url":"https://github.com/mfalesni","followers_url":"https://api.github.com/users/mfalesni/followers","following_url":"https://api.github.com/users/mfalesni/following{/other_user}","gists_url":"https://api.github.com/users/mfalesni/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalesni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalesni/subscriptions","organizations_url":"https://api.github.com/users/mfalesni/orgs","repos_url":"https://api.github.com/users/mfalesni/repos","events_url":"https://api.github.com/users/mfalesni/events{/privacy}","received_events_url":"https://api.github.com/users/mfalesni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfalesni/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/mfalesni/cfme_tests","forks_url":"https://api.github.com/repos/mfalesni/cfme_tests/forks","keys_url":"https://api.github.com/repos/mfalesni/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfalesni/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfalesni/cfme_tests/teams","hooks_url":"https://api.github.com/repos/mfalesni/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/mfalesni/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/mfalesni/cfme_tests/events","assignees_url":"https://api.github.com/repos/mfalesni/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/mfalesni/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/mfalesni/cfme_tests/tags","blobs_url":"https://api.github.com/repos/mfalesni/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfalesni/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfalesni/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfalesni/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfalesni/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mfalesni/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/mfalesni/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/mfalesni/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/mfalesni/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/mfalesni/cfme_tests/subscription","commits_url":"https://api.github.com/repos/mfalesni/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfalesni/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfalesni/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfalesni/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfalesni/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/mfalesni/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfalesni/cfme_tests/merges","archive_url":"https://api.github.com/repos/mfalesni/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfalesni/cfme_tests/downloads","issues_url":"https://api.github.com/repos/mfalesni/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/mfalesni/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mfalesni/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mfalesni/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfalesni/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/mfalesni/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/mfalesni/cfme_tests/deployments","created_at":"2013-09-18T10:01:35Z","updated_at":"2015-05-06T16:22:20Z","pushed_at":"2016-06-20T14:36:41Z","git_url":"git://github.com/mfalesni/cfme_tests.git","ssh_url":"git@github.com:mfalesni/cfme_tests.git","clone_url":"https://github.com/mfalesni/cfme_tests.git","svn_url":"https://github.com/mfalesni/cfme_tests","homepage":"","size":10663,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"79e29acc32f6c9ad0316528a4c3a1fcf7f83372e","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2016-06-10T01:37:43Z","pushed_at":"2016-06-21T11:50:45Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":14741,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":82,"forks":60,"open_issues":82,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/3100"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3100"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3100/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3100/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/e9d9c8a5e816d8e59df4595573ecc864b5df3508"}}}}
{"actor":{"display_login":"mfalesni"}}