{"action":"created","comment":{"url":"https://api.github.com/repos/colobot/colobot/pulls/comments/80119158","id":80119158,"diff_hunk":"@@ -2120,11 +2157,22 @@ void CEdit::SetMultiFont(bool bMulti)\n     m_format.clear();\n \n     if (bMulti)\n-    {\n-        m_format.reserve(m_maxChar+1);\n-        for (int i = 0; i <= m_maxChar+1; i++)\n-        {\n-            m_format.push_back(m_fontType);\n+    {\r\n+        if ( !IsInfinite() )","path":"src/ui/controls/edit.cpp","position":964,"original_position":964,"commit_id":"5b2559fcf4376bbaa2840f8945c32cd009de61bf","original_commit_id":"5b2559fcf4376bbaa2840f8945c32cd009de61bf","user":{"login":"krzys-h","id":1517255,"avatar_url":"https://avatars.githubusercontent.com/u/1517255?v=3","gravatar_id":"","url":"https://api.github.com/users/krzys-h","html_url":"https://github.com/krzys-h","followers_url":"https://api.github.com/users/krzys-h/followers","following_url":"https://api.github.com/users/krzys-h/following{/other_user}","gists_url":"https://api.github.com/users/krzys-h/gists{/gist_id}","starred_url":"https://api.github.com/users/krzys-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzys-h/subscriptions","organizations_url":"https://api.github.com/users/krzys-h/orgs","repos_url":"https://api.github.com/users/krzys-h/repos","events_url":"https://api.github.com/users/krzys-h/events{/privacy}","received_events_url":"https://api.github.com/users/krzys-h/received_events","type":"User","site_admin":false},"body":"It's not really good to depend on the value of IsInfinite() in code like this, using std::string like mentioned in other comments should help eliminate that.","created_at":"2016-09-22T19:35:13Z","updated_at":"2016-09-22T19:39:45Z","html_url":"https://github.com/colobot/colobot/pull/836#discussion_r80119158","pull_request_url":"https://api.github.com/repos/colobot/colobot/pulls/836","_links":{"self":{"href":"https://api.github.com/repos/colobot/colobot/pulls/comments/80119158"},"html":{"href":"https://github.com/colobot/colobot/pull/836#discussion_r80119158"},"pull_request":{"href":"https://api.github.com/repos/colobot/colobot/pulls/836"}}},"pull_request":{"url":"https://api.github.com/repos/colobot/colobot/pulls/836","id":86366510,"html_url":"https://github.com/colobot/colobot/pull/836","diff_url":"https://github.com/colobot/colobot/pull/836.diff","patch_url":"https://github.com/colobot/colobot/pull/836.patch","issue_url":"https://api.github.com/repos/colobot/colobot/issues/836","number":836,"state":"open","locked":false,"title":"Edit Control - character limit","user":{"login":"MatiRg","id":13033134,"avatar_url":"https://avatars.githubusercontent.com/u/13033134?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiRg","html_url":"https://github.com/MatiRg","followers_url":"https://api.github.com/users/MatiRg/followers","following_url":"https://api.github.com/users/MatiRg/following{/other_user}","gists_url":"https://api.github.com/users/MatiRg/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiRg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiRg/subscriptions","organizations_url":"https://api.github.com/users/MatiRg/orgs","repos_url":"https://api.github.com/users/MatiRg/repos","events_url":"https://api.github.com/users/MatiRg/events{/privacy}","received_events_url":"https://api.github.com/users/MatiRg/received_events","type":"User","site_admin":false},"body":"Edit Control now can use infinite character limit and of course it can still be set to use certain amount of characters.\r\nThis issue:\r\nhttps://github.com/colobot/colobot/issues/820\r\nand I think also:\r\nhttps://github.com/colobot/colobot/issues/300\r\nIn future You probally will migrate to CEGUI so all UI issues will be then resolved?","created_at":"2016-09-22T16:01:23Z","updated_at":"2016-09-22T19:39:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e483a28f12f86011a6568fc72dba8d389efba22e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/colobot/colobot/pulls/836/commits","review_comments_url":"https://api.github.com/repos/colobot/colobot/pulls/836/comments","review_comment_url":"https://api.github.com/repos/colobot/colobot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colobot/colobot/issues/836/comments","statuses_url":"https://api.github.com/repos/colobot/colobot/statuses/5b2559fcf4376bbaa2840f8945c32cd009de61bf","head":{"label":"MatiRg:dev","ref":"dev","sha":"5b2559fcf4376bbaa2840f8945c32cd009de61bf","user":{"login":"MatiRg","id":13033134,"avatar_url":"https://avatars.githubusercontent.com/u/13033134?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiRg","html_url":"https://github.com/MatiRg","followers_url":"https://api.github.com/users/MatiRg/followers","following_url":"https://api.github.com/users/MatiRg/following{/other_user}","gists_url":"https://api.github.com/users/MatiRg/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiRg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiRg/subscriptions","organizations_url":"https://api.github.com/users/MatiRg/orgs","repos_url":"https://api.github.com/users/MatiRg/repos","events_url":"https://api.github.com/users/MatiRg/events{/privacy}","received_events_url":"https://api.github.com/users/MatiRg/received_events","type":"User","site_admin":false},"repo":{"id":68926889,"name":"colobot","full_name":"MatiRg/colobot","owner":{"login":"MatiRg","id":13033134,"avatar_url":"https://avatars.githubusercontent.com/u/13033134?v=3","gravatar_id":"","url":"https://api.github.com/users/MatiRg","html_url":"https://github.com/MatiRg","followers_url":"https://api.github.com/users/MatiRg/followers","following_url":"https://api.github.com/users/MatiRg/following{/other_user}","gists_url":"https://api.github.com/users/MatiRg/gists{/gist_id}","starred_url":"https://api.github.com/users/MatiRg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatiRg/subscriptions","organizations_url":"https://api.github.com/users/MatiRg/orgs","repos_url":"https://api.github.com/users/MatiRg/repos","events_url":"https://api.github.com/users/MatiRg/events{/privacy}","received_events_url":"https://api.github.com/users/MatiRg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatiRg/colobot","description":"Source code of open-source Colobot: Gold Edition project developed by Epsitec and TerranovaTeam","fork":true,"url":"https://api.github.com/repos/MatiRg/colobot","forks_url":"https://api.github.com/repos/MatiRg/colobot/forks","keys_url":"https://api.github.com/repos/MatiRg/colobot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatiRg/colobot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatiRg/colobot/teams","hooks_url":"https://api.github.com/repos/MatiRg/colobot/hooks","issue_events_url":"https://api.github.com/repos/MatiRg/colobot/issues/events{/number}","events_url":"https://api.github.com/repos/MatiRg/colobot/events","assignees_url":"https://api.github.com/repos/MatiRg/colobot/assignees{/user}","branches_url":"https://api.github.com/repos/MatiRg/colobot/branches{/branch}","tags_url":"https://api.github.com/repos/MatiRg/colobot/tags","blobs_url":"https://api.github.com/repos/MatiRg/colobot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatiRg/colobot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatiRg/colobot/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatiRg/colobot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatiRg/colobot/statuses/{sha}","languages_url":"https://api.github.com/repos/MatiRg/colobot/languages","stargazers_url":"https://api.github.com/repos/MatiRg/colobot/stargazers","contributors_url":"https://api.github.com/repos/MatiRg/colobot/contributors","subscribers_url":"https://api.github.com/repos/MatiRg/colobot/subscribers","subscription_url":"https://api.github.com/repos/MatiRg/colobot/subscription","commits_url":"https://api.github.com/repos/MatiRg/colobot/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatiRg/colobot/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatiRg/colobot/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatiRg/colobot/issues/comments{/number}","contents_url":"https://api.github.com/repos/MatiRg/colobot/contents/{+path}","compare_url":"https://api.github.com/repos/MatiRg/colobot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatiRg/colobot/merges","archive_url":"https://api.github.com/repos/MatiRg/colobot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatiRg/colobot/downloads","issues_url":"https://api.github.com/repos/MatiRg/colobot/issues{/number}","pulls_url":"https://api.github.com/repos/MatiRg/colobot/pulls{/number}","milestones_url":"https://api.github.com/repos/MatiRg/colobot/milestones{/number}","notifications_url":"https://api.github.com/repos/MatiRg/colobot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatiRg/colobot/labels{/name}","releases_url":"https://api.github.com/repos/MatiRg/colobot/releases{/id}","deployments_url":"https://api.github.com/repos/MatiRg/colobot/deployments","created_at":"2016-09-22T14:01:30Z","updated_at":"2016-09-22T14:01:33Z","pushed_at":"2016-09-22T15:53:58Z","git_url":"git://github.com/MatiRg/colobot.git","ssh_url":"git@github.com:MatiRg/colobot.git","clone_url":"https://github.com/MatiRg/colobot.git","svn_url":"https://github.com/MatiRg/colobot","homepage":"http://colobot.info/","size":16524,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"colobot:dev","ref":"dev","sha":"6b6eca61cb56f5859ce0b964b6df7b2139dac12c","user":{"login":"colobot","id":2401308,"avatar_url":"https://avatars.githubusercontent.com/u/2401308?v=3","gravatar_id":"","url":"https://api.github.com/users/colobot","html_url":"https://github.com/colobot","followers_url":"https://api.github.com/users/colobot/followers","following_url":"https://api.github.com/users/colobot/following{/other_user}","gists_url":"https://api.github.com/users/colobot/gists{/gist_id}","starred_url":"https://api.github.com/users/colobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colobot/subscriptions","organizations_url":"https://api.github.com/users/colobot/orgs","repos_url":"https://api.github.com/users/colobot/repos","events_url":"https://api.github.com/users/colobot/events{/privacy}","received_events_url":"https://api.github.com/users/colobot/received_events","type":"Organization","site_admin":false},"repo":{"id":3662703,"name":"colobot","full_name":"colobot/colobot","owner":{"login":"colobot","id":2401308,"avatar_url":"https://avatars.githubusercontent.com/u/2401308?v=3","gravatar_id":"","url":"https://api.github.com/users/colobot","html_url":"https://github.com/colobot","followers_url":"https://api.github.com/users/colobot/followers","following_url":"https://api.github.com/users/colobot/following{/other_user}","gists_url":"https://api.github.com/users/colobot/gists{/gist_id}","starred_url":"https://api.github.com/users/colobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colobot/subscriptions","organizations_url":"https://api.github.com/users/colobot/orgs","repos_url":"https://api.github.com/users/colobot/repos","events_url":"https://api.github.com/users/colobot/events{/privacy}","received_events_url":"https://api.github.com/users/colobot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/colobot/colobot","description":"Source code of open-source Colobot: Gold Edition project developed by Epsitec and TerranovaTeam","fork":false,"url":"https://api.github.com/repos/colobot/colobot","forks_url":"https://api.github.com/repos/colobot/colobot/forks","keys_url":"https://api.github.com/repos/colobot/colobot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colobot/colobot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colobot/colobot/teams","hooks_url":"https://api.github.com/repos/colobot/colobot/hooks","issue_events_url":"https://api.github.com/repos/colobot/colobot/issues/events{/number}","events_url":"https://api.github.com/repos/colobot/colobot/events","assignees_url":"https://api.github.com/repos/colobot/colobot/assignees{/user}","branches_url":"https://api.github.com/repos/colobot/colobot/branches{/branch}","tags_url":"https://api.github.com/repos/colobot/colobot/tags","blobs_url":"https://api.github.com/repos/colobot/colobot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colobot/colobot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colobot/colobot/git/refs{/sha}","trees_url":"https://api.github.com/repos/colobot/colobot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colobot/colobot/statuses/{sha}","languages_url":"https://api.github.com/repos/colobot/colobot/languages","stargazers_url":"https://api.github.com/repos/colobot/colobot/stargazers","contributors_url":"https://api.github.com/repos/colobot/colobot/contributors","subscribers_url":"https://api.github.com/repos/colobot/colobot/subscribers","subscription_url":"https://api.github.com/repos/colobot/colobot/subscription","commits_url":"https://api.github.com/repos/colobot/colobot/commits{/sha}","git_commits_url":"https://api.github.com/repos/colobot/colobot/git/commits{/sha}","comments_url":"https://api.github.com/repos/colobot/colobot/comments{/number}","issue_comment_url":"https://api.github.com/repos/colobot/colobot/issues/comments{/number}","contents_url":"https://api.github.com/repos/colobot/colobot/contents/{+path}","compare_url":"https://api.github.com/repos/colobot/colobot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colobot/colobot/merges","archive_url":"https://api.github.com/repos/colobot/colobot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colobot/colobot/downloads","issues_url":"https://api.github.com/repos/colobot/colobot/issues{/number}","pulls_url":"https://api.github.com/repos/colobot/colobot/pulls{/number}","milestones_url":"https://api.github.com/repos/colobot/colobot/milestones{/number}","notifications_url":"https://api.github.com/repos/colobot/colobot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colobot/colobot/labels{/name}","releases_url":"https://api.github.com/repos/colobot/colobot/releases{/id}","deployments_url":"https://api.github.com/repos/colobot/colobot/deployments","created_at":"2012-03-08T18:06:46Z","updated_at":"2016-09-20T07:48:09Z","pushed_at":"2016-09-22T16:01:23Z","git_url":"git://github.com/colobot/colobot.git","ssh_url":"git@github.com:colobot/colobot.git","clone_url":"https://github.com/colobot/colobot.git","svn_url":"https://github.com/colobot/colobot","homepage":"http://colobot.info/","size":51477,"stargazers_count":310,"watchers_count":310,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":151,"forks":79,"open_issues":151,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colobot/colobot/pulls/836"},"html":{"href":"https://github.com/colobot/colobot/pull/836"},"issue":{"href":"https://api.github.com/repos/colobot/colobot/issues/836"},"comments":{"href":"https://api.github.com/repos/colobot/colobot/issues/836/comments"},"review_comments":{"href":"https://api.github.com/repos/colobot/colobot/pulls/836/comments"},"review_comment":{"href":"https://api.github.com/repos/colobot/colobot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colobot/colobot/pulls/836/commits"},"statuses":{"href":"https://api.github.com/repos/colobot/colobot/statuses/5b2559fcf4376bbaa2840f8945c32cd009de61bf"}}}}
{"actor":{"display_login":"krzys-h"}}