{"action":"opened","number":268,"pull_request":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/268","id":79927251,"html_url":"https://github.com/FreeOpcUa/python-opcua/pull/268","diff_url":"https://github.com/FreeOpcUa/python-opcua/pull/268.diff","patch_url":"https://github.com/FreeOpcUa/python-opcua/pull/268.patch","issue_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/268","number":268,"state":"open","locked":false,"title":"DO NOT MERGE: functionality to detect interrupted connections","user":{"login":"georgschoelly","id":1846232,"avatar_url":"https://avatars.githubusercontent.com/u/1846232?v=3","gravatar_id":"","url":"https://api.github.com/users/georgschoelly","html_url":"https://github.com/georgschoelly","followers_url":"https://api.github.com/users/georgschoelly/followers","following_url":"https://api.github.com/users/georgschoelly/following{/other_user}","gists_url":"https://api.github.com/users/georgschoelly/gists{/gist_id}","starred_url":"https://api.github.com/users/georgschoelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgschoelly/subscriptions","organizations_url":"https://api.github.com/users/georgschoelly/orgs","repos_url":"https://api.github.com/users/georgschoelly/repos","events_url":"https://api.github.com/users/georgschoelly/events{/privacy}","received_events_url":"https://api.github.com/users/georgschoelly/received_events","type":"User","site_admin":false},"body":"I've implemented a class that mirrors the alarms of my opc ua server. This involves keeping open a client subscribed to some events. In case the connection gets interrupted, I can just delete all my state and re-connect.\r\n\r\nHowever, for this to work I need a way to detect a connection interruption. There seem to be some more people interested in this: https://github.com/FreeOpcUa/python-opcua/issues/106 (connection loss), https://github.com/FreeOpcUa/python-opcua/issues/146 (automatic reconnect).\r\n\r\nI've started an implementation (untested so far) and I would like some feedback. I realise that the KeepAlive thread is probably going away in a future version of python-opcua when you switch to asyncio. However, I feel we could implement it for 1.0 anyway because it's quite important functionality. I would document the fact that this API might not be around to stay.\r\n\r\nWhat do you think of this? Is this the right way?","created_at":"2016-08-03T15:29:21Z","updated_at":"2016-08-03T15:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/268/commits","review_comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/268/comments","review_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/268/comments","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/70b43fb8f9062680abf9ab6480fb5e8d7f1e9c17","head":{"label":"georgschoelly:interruption_callback","ref":"interruption_callback","sha":"70b43fb8f9062680abf9ab6480fb5e8d7f1e9c17","user":{"login":"georgschoelly","id":1846232,"avatar_url":"https://avatars.githubusercontent.com/u/1846232?v=3","gravatar_id":"","url":"https://api.github.com/users/georgschoelly","html_url":"https://github.com/georgschoelly","followers_url":"https://api.github.com/users/georgschoelly/followers","following_url":"https://api.github.com/users/georgschoelly/following{/other_user}","gists_url":"https://api.github.com/users/georgschoelly/gists{/gist_id}","starred_url":"https://api.github.com/users/georgschoelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgschoelly/subscriptions","organizations_url":"https://api.github.com/users/georgschoelly/orgs","repos_url":"https://api.github.com/users/georgschoelly/repos","events_url":"https://api.github.com/users/georgschoelly/events{/privacy}","received_events_url":"https://api.github.com/users/georgschoelly/received_events","type":"User","site_admin":false},"repo":{"id":62722943,"name":"python-opcua","full_name":"georgschoelly/python-opcua","owner":{"login":"georgschoelly","id":1846232,"avatar_url":"https://avatars.githubusercontent.com/u/1846232?v=3","gravatar_id":"","url":"https://api.github.com/users/georgschoelly","html_url":"https://github.com/georgschoelly","followers_url":"https://api.github.com/users/georgschoelly/followers","following_url":"https://api.github.com/users/georgschoelly/following{/other_user}","gists_url":"https://api.github.com/users/georgschoelly/gists{/gist_id}","starred_url":"https://api.github.com/users/georgschoelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgschoelly/subscriptions","organizations_url":"https://api.github.com/users/georgschoelly/orgs","repos_url":"https://api.github.com/users/georgschoelly/repos","events_url":"https://api.github.com/users/georgschoelly/events{/privacy}","received_events_url":"https://api.github.com/users/georgschoelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgschoelly/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":true,"url":"https://api.github.com/repos/georgschoelly/python-opcua","forks_url":"https://api.github.com/repos/georgschoelly/python-opcua/forks","keys_url":"https://api.github.com/repos/georgschoelly/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgschoelly/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgschoelly/python-opcua/teams","hooks_url":"https://api.github.com/repos/georgschoelly/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/georgschoelly/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/georgschoelly/python-opcua/events","assignees_url":"https://api.github.com/repos/georgschoelly/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/georgschoelly/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/georgschoelly/python-opcua/tags","blobs_url":"https://api.github.com/repos/georgschoelly/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgschoelly/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgschoelly/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgschoelly/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgschoelly/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/georgschoelly/python-opcua/languages","stargazers_url":"https://api.github.com/repos/georgschoelly/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/georgschoelly/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/georgschoelly/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/georgschoelly/python-opcua/subscription","commits_url":"https://api.github.com/repos/georgschoelly/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgschoelly/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgschoelly/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgschoelly/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgschoelly/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/georgschoelly/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgschoelly/python-opcua/merges","archive_url":"https://api.github.com/repos/georgschoelly/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgschoelly/python-opcua/downloads","issues_url":"https://api.github.com/repos/georgschoelly/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/georgschoelly/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/georgschoelly/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/georgschoelly/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgschoelly/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/georgschoelly/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/georgschoelly/python-opcua/deployments","created_at":"2016-07-06T13:27:09Z","updated_at":"2016-07-06T13:27:10Z","pushed_at":"2016-08-03T14:40:12Z","git_url":"git://github.com/georgschoelly/python-opcua.git","ssh_url":"git@github.com:georgschoelly/python-opcua.git","clone_url":"https://github.com/georgschoelly/python-opcua.git","svn_url":"https://github.com/georgschoelly/python-opcua","homepage":"http://freeopcua.github.io/","size":2652,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FreeOpcUa:master","ref":"master","sha":"9d27883857ae53bcce0f1e5310c2aae6cf59e6f6","user":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"repo":{"id":31074280,"name":"python-opcua","full_name":"FreeOpcUa/python-opcua","owner":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeOpcUa/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":false,"url":"https://api.github.com/repos/FreeOpcUa/python-opcua","forks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/forks","keys_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/teams","hooks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/events","assignees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/tags","blobs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/languages","stargazers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscription","commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/merges","archive_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/downloads","issues_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/deployments","created_at":"2015-02-20T16:46:53Z","updated_at":"2016-08-02T16:11:58Z","pushed_at":"2016-08-03T15:29:21Z","git_url":"git://github.com/FreeOpcUa/python-opcua.git","ssh_url":"git@github.com:FreeOpcUa/python-opcua.git","clone_url":"https://github.com/FreeOpcUa/python-opcua.git","svn_url":"https://github.com/FreeOpcUa/python-opcua","homepage":"http://freeopcua.github.io/","size":3192,"stargazers_count":74,"watchers_count":74,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":20,"forks":42,"open_issues":20,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/268"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/268"},"issue":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/268"},"comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/70b43fb8f9062680abf9ab6480fb5e8d7f1e9c17"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"georgschoelly"}}