{"action":"opened","number":364,"pull_request":{"url":"https://api.github.com/repos/torch/cutorch/pulls/364","id":62658235,"html_url":"https://github.com/torch/cutorch/pull/364","diff_url":"https://github.com/torch/cutorch/pull/364.diff","patch_url":"https://github.com/torch/cutorch/pull/364.patch","issue_url":"https://api.github.com/repos/torch/cutorch/issues/364","number":364,"state":"open","locked":false,"title":"Add potrs with MAGMA","user":{"login":"bamos","id":707462,"avatar_url":"https://avatars.githubusercontent.com/u/707462?v=3","gravatar_id":"","url":"https://api.github.com/users/bamos","html_url":"https://github.com/bamos","followers_url":"https://api.github.com/users/bamos/followers","following_url":"https://api.github.com/users/bamos/following{/other_user}","gists_url":"https://api.github.com/users/bamos/gists{/gist_id}","starred_url":"https://api.github.com/users/bamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamos/subscriptions","organizations_url":"https://api.github.com/users/bamos/orgs","repos_url":"https://api.github.com/users/bamos/repos","events_url":"https://api.github.com/users/bamos/events{/privacy}","received_events_url":"https://api.github.com/users/bamos/received_events","type":"User","site_admin":false},"body":"Hi, this PR adds `potrs` with MAGMA.\r\n\r\nI followed the structure of the existing `potrf` code and copied the\r\n`potrs` argument checks from [THTensorLapack](https://github.com/torch/torch7/blob/37a523e17a8c66785e753bb112eac5f97e6496e9/lib/TH/generic/THTensorLapack.c#L562).\r\nThe test compares the output to Torch's CPU version and is passing on my system.\r\n\r\nThis is my first time modifying `cutorch` and any Torch internals.\r\nCan somebody check that I used `THCudaTensor_newColumnMajor` and `free` correctly?\r\nI used `rb_` as the source for `b_` because  `magma_spotrs_gpu` returns results in `b_data`.\r\nI'm not sure if I should use `th_magma_smalloc_pinned` or `THCudaTensor_newColumnMajor` for `a_data`.\r\n\r\n-Brandon.","created_at":"2016-03-13T01:26:44Z","updated_at":"2016-03-13T01:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/torch/cutorch/pulls/364/commits","review_comments_url":"https://api.github.com/repos/torch/cutorch/pulls/364/comments","review_comment_url":"https://api.github.com/repos/torch/cutorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torch/cutorch/issues/364/comments","statuses_url":"https://api.github.com/repos/torch/cutorch/statuses/2598a014860ed00b3ae08e619b3caf817b0786bf","head":{"label":"bamos:potrs","ref":"potrs","sha":"2598a014860ed00b3ae08e619b3caf817b0786bf","user":{"login":"bamos","id":707462,"avatar_url":"https://avatars.githubusercontent.com/u/707462?v=3","gravatar_id":"","url":"https://api.github.com/users/bamos","html_url":"https://github.com/bamos","followers_url":"https://api.github.com/users/bamos/followers","following_url":"https://api.github.com/users/bamos/following{/other_user}","gists_url":"https://api.github.com/users/bamos/gists{/gist_id}","starred_url":"https://api.github.com/users/bamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamos/subscriptions","organizations_url":"https://api.github.com/users/bamos/orgs","repos_url":"https://api.github.com/users/bamos/repos","events_url":"https://api.github.com/users/bamos/events{/privacy}","received_events_url":"https://api.github.com/users/bamos/received_events","type":"User","site_admin":false},"repo":{"id":53758300,"name":"cutorch","full_name":"bamos/cutorch","owner":{"login":"bamos","id":707462,"avatar_url":"https://avatars.githubusercontent.com/u/707462?v=3","gravatar_id":"","url":"https://api.github.com/users/bamos","html_url":"https://github.com/bamos","followers_url":"https://api.github.com/users/bamos/followers","following_url":"https://api.github.com/users/bamos/following{/other_user}","gists_url":"https://api.github.com/users/bamos/gists{/gist_id}","starred_url":"https://api.github.com/users/bamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamos/subscriptions","organizations_url":"https://api.github.com/users/bamos/orgs","repos_url":"https://api.github.com/users/bamos/repos","events_url":"https://api.github.com/users/bamos/events{/privacy}","received_events_url":"https://api.github.com/users/bamos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bamos/cutorch","description":"A CUDA backend for Torch7","fork":true,"url":"https://api.github.com/repos/bamos/cutorch","forks_url":"https://api.github.com/repos/bamos/cutorch/forks","keys_url":"https://api.github.com/repos/bamos/cutorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bamos/cutorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bamos/cutorch/teams","hooks_url":"https://api.github.com/repos/bamos/cutorch/hooks","issue_events_url":"https://api.github.com/repos/bamos/cutorch/issues/events{/number}","events_url":"https://api.github.com/repos/bamos/cutorch/events","assignees_url":"https://api.github.com/repos/bamos/cutorch/assignees{/user}","branches_url":"https://api.github.com/repos/bamos/cutorch/branches{/branch}","tags_url":"https://api.github.com/repos/bamos/cutorch/tags","blobs_url":"https://api.github.com/repos/bamos/cutorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bamos/cutorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bamos/cutorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/bamos/cutorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bamos/cutorch/statuses/{sha}","languages_url":"https://api.github.com/repos/bamos/cutorch/languages","stargazers_url":"https://api.github.com/repos/bamos/cutorch/stargazers","contributors_url":"https://api.github.com/repos/bamos/cutorch/contributors","subscribers_url":"https://api.github.com/repos/bamos/cutorch/subscribers","subscription_url":"https://api.github.com/repos/bamos/cutorch/subscription","commits_url":"https://api.github.com/repos/bamos/cutorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/bamos/cutorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/bamos/cutorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/bamos/cutorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/bamos/cutorch/contents/{+path}","compare_url":"https://api.github.com/repos/bamos/cutorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bamos/cutorch/merges","archive_url":"https://api.github.com/repos/bamos/cutorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bamos/cutorch/downloads","issues_url":"https://api.github.com/repos/bamos/cutorch/issues{/number}","pulls_url":"https://api.github.com/repos/bamos/cutorch/pulls{/number}","milestones_url":"https://api.github.com/repos/bamos/cutorch/milestones{/number}","notifications_url":"https://api.github.com/repos/bamos/cutorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bamos/cutorch/labels{/name}","releases_url":"https://api.github.com/repos/bamos/cutorch/releases{/id}","deployments_url":"https://api.github.com/repos/bamos/cutorch/deployments","created_at":"2016-03-12T23:25:07Z","updated_at":"2016-03-12T23:25:08Z","pushed_at":"2016-03-13T01:13:01Z","git_url":"git://github.com/bamos/cutorch.git","ssh_url":"git@github.com:bamos/cutorch.git","clone_url":"https://github.com/bamos/cutorch.git","svn_url":"https://github.com/bamos/cutorch","homepage":"","size":10436,"stargazers_count":0,"watchers_count":0,"language":"Cuda","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"a7147d00e61a5e182a277995f5d1e99ec3bdf0f8","user":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":13677478,"name":"cutorch","full_name":"torch/cutorch","owner":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/cutorch","description":"A CUDA backend for Torch7","fork":false,"url":"https://api.github.com/repos/torch/cutorch","forks_url":"https://api.github.com/repos/torch/cutorch/forks","keys_url":"https://api.github.com/repos/torch/cutorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/cutorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/cutorch/teams","hooks_url":"https://api.github.com/repos/torch/cutorch/hooks","issue_events_url":"https://api.github.com/repos/torch/cutorch/issues/events{/number}","events_url":"https://api.github.com/repos/torch/cutorch/events","assignees_url":"https://api.github.com/repos/torch/cutorch/assignees{/user}","branches_url":"https://api.github.com/repos/torch/cutorch/branches{/branch}","tags_url":"https://api.github.com/repos/torch/cutorch/tags","blobs_url":"https://api.github.com/repos/torch/cutorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/cutorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/cutorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/cutorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/cutorch/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/cutorch/languages","stargazers_url":"https://api.github.com/repos/torch/cutorch/stargazers","contributors_url":"https://api.github.com/repos/torch/cutorch/contributors","subscribers_url":"https://api.github.com/repos/torch/cutorch/subscribers","subscription_url":"https://api.github.com/repos/torch/cutorch/subscription","commits_url":"https://api.github.com/repos/torch/cutorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/cutorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/cutorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/cutorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch/cutorch/contents/{+path}","compare_url":"https://api.github.com/repos/torch/cutorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/cutorch/merges","archive_url":"https://api.github.com/repos/torch/cutorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/cutorch/downloads","issues_url":"https://api.github.com/repos/torch/cutorch/issues{/number}","pulls_url":"https://api.github.com/repos/torch/cutorch/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/cutorch/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/cutorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/cutorch/labels{/name}","releases_url":"https://api.github.com/repos/torch/cutorch/releases{/id}","deployments_url":"https://api.github.com/repos/torch/cutorch/deployments","created_at":"2013-10-18T12:29:23Z","updated_at":"2016-03-12T12:00:21Z","pushed_at":"2016-03-09T23:48:34Z","git_url":"git://github.com/torch/cutorch.git","ssh_url":"git@github.com:torch/cutorch.git","clone_url":"https://github.com/torch/cutorch.git","svn_url":"https://github.com/torch/cutorch","homepage":"","size":10996,"stargazers_count":113,"watchers_count":113,"language":"Cuda","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":30,"forks":93,"open_issues":30,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/cutorch/pulls/364"},"html":{"href":"https://github.com/torch/cutorch/pull/364"},"issue":{"href":"https://api.github.com/repos/torch/cutorch/issues/364"},"comments":{"href":"https://api.github.com/repos/torch/cutorch/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/cutorch/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/cutorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torch/cutorch/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/torch/cutorch/statuses/2598a014860ed00b3ae08e619b3caf817b0786bf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":58,"deletions":0,"changed_files":4}}