{"action":"created","comment":{"url":"https://api.github.com/repos/metamx/locators/pulls/comments/75997286","id":75997286,"diff_hunk":"@@ -1,316 +1,432 @@\n-\n+import {EventEmitter} from \"events\";\n import http = require(\"http\");\n-import EventEmitterModule = require(\"events\");\n-import EventEmitter = EventEmitterModule.EventEmitter;\n-import async = require(\"async\");\n-import Promise = require(\"q\");\n import zookeeper = require(\"node-zookeeper-client\");\n-import Client = zookeeper.Client;\n-var Exception = zookeeper.Exception;\n+import Promise = require(\"bluebird\");\n \n-import { Location, Locator, DataExtractor } from \"./common\";\n+import {Location, Locator, LocatorEmitter, LocatorFactory, DataExtractor} from \"./common\";\n import LocatorException = require(\"./locatorException\");\n \n+function deferredLocationRequest() : Promise.Resolver<Location> {\n+    var resolve, reject;\n+    var promise = new Promise<Location>(function() {","path":"src/zookeeper.ts","position":19,"original_position":19,"commit_id":"dd1c3a24a5de79d5f66373b1d561e5e6c62d45e6","original_commit_id":"1a03c566ef137f4e165c166cba698eec3dc0026d","user":{"login":"clintropolis","id":1577461,"avatar_url":"https://avatars.githubusercontent.com/u/1577461?v=3","gravatar_id":"","url":"https://api.github.com/users/clintropolis","html_url":"https://github.com/clintropolis","followers_url":"https://api.github.com/users/clintropolis/followers","following_url":"https://api.github.com/users/clintropolis/following{/other_user}","gists_url":"https://api.github.com/users/clintropolis/gists{/gist_id}","starred_url":"https://api.github.com/users/clintropolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintropolis/subscriptions","organizations_url":"https://api.github.com/users/clintropolis/orgs","repos_url":"https://api.github.com/users/clintropolis/repos","events_url":"https://api.github.com/users/clintropolis/events{/privacy}","received_events_url":"https://api.github.com/users/clintropolis/received_events","type":"User","site_admin":false},"body":"`function` is still legit typescript syntax 😛","created_at":"2016-08-24T05:38:45Z","updated_at":"2016-08-24T05:38:45Z","html_url":"https://github.com/metamx/locators/pull/9#discussion_r75997286","pull_request_url":"https://api.github.com/repos/metamx/locators/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/metamx/locators/pulls/comments/75997286"},"html":{"href":"https://github.com/metamx/locators/pull/9#discussion_r75997286"},"pull_request":{"href":"https://api.github.com/repos/metamx/locators/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/metamx/locators/pulls/9","id":82347980,"html_url":"https://github.com/metamx/locators/pull/9","diff_url":"https://github.com/metamx/locators/pull/9.diff","patch_url":"https://github.com/metamx/locators/pull/9.patch","issue_url":"https://api.github.com/repos/metamx/locators/issues/9","number":9,"state":"open","locked":false,"title":"major refactor","user":{"login":"clintropolis","id":1577461,"avatar_url":"https://avatars.githubusercontent.com/u/1577461?v=3","gravatar_id":"","url":"https://api.github.com/users/clintropolis","html_url":"https://github.com/clintropolis","followers_url":"https://api.github.com/users/clintropolis/followers","following_url":"https://api.github.com/users/clintropolis/following{/other_user}","gists_url":"https://api.github.com/users/clintropolis/gists{/gist_id}","starred_url":"https://api.github.com/users/clintropolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintropolis/subscriptions","organizations_url":"https://api.github.com/users/clintropolis/orgs","repos_url":"https://api.github.com/users/clintropolis/repos","events_url":"https://api.github.com/users/clintropolis/events{/privacy}","received_events_url":"https://api.github.com/users/clintropolis/received_events","type":"User","site_admin":false},"body":"changes:\r\n* code has been significantly refactored and should (hopefully) be much easier to follow\r\n* updated readme\r\n* update typescript, use tsconfig.json instead of config in gruntfile\r\n* migrate from tsd to typings\r\n* migrate from q to bluebird\r\n* clean up some odds and ends","created_at":"2016-08-23T11:32:04Z","updated_at":"2016-08-24T05:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"090f56a8af817c96d6b6be805a3cf80dc588eed9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/metamx/locators/pulls/9/commits","review_comments_url":"https://api.github.com/repos/metamx/locators/pulls/9/comments","review_comment_url":"https://api.github.com/repos/metamx/locators/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metamx/locators/issues/9/comments","statuses_url":"https://api.github.com/repos/metamx/locators/statuses/dd1c3a24a5de79d5f66373b1d561e5e6c62d45e6","head":{"label":"metamx:refactor","ref":"refactor","sha":"dd1c3a24a5de79d5f66373b1d561e5e6c62d45e6","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":28058798,"name":"locators","full_name":"metamx/locators","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/locators","description":"A collection of service locators using different mechanisms","fork":false,"url":"https://api.github.com/repos/metamx/locators","forks_url":"https://api.github.com/repos/metamx/locators/forks","keys_url":"https://api.github.com/repos/metamx/locators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/locators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/locators/teams","hooks_url":"https://api.github.com/repos/metamx/locators/hooks","issue_events_url":"https://api.github.com/repos/metamx/locators/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/locators/events","assignees_url":"https://api.github.com/repos/metamx/locators/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/locators/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/locators/tags","blobs_url":"https://api.github.com/repos/metamx/locators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/locators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/locators/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/locators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/locators/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/locators/languages","stargazers_url":"https://api.github.com/repos/metamx/locators/stargazers","contributors_url":"https://api.github.com/repos/metamx/locators/contributors","subscribers_url":"https://api.github.com/repos/metamx/locators/subscribers","subscription_url":"https://api.github.com/repos/metamx/locators/subscription","commits_url":"https://api.github.com/repos/metamx/locators/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/locators/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/locators/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/locators/issues/comments{/number}","contents_url":"https://api.github.com/repos/metamx/locators/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/locators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/locators/merges","archive_url":"https://api.github.com/repos/metamx/locators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/locators/downloads","issues_url":"https://api.github.com/repos/metamx/locators/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/locators/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/locators/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/locators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/locators/labels{/name}","releases_url":"https://api.github.com/repos/metamx/locators/releases{/id}","deployments_url":"https://api.github.com/repos/metamx/locators/deployments","created_at":"2014-12-15T22:14:43Z","updated_at":"2015-04-24T01:07:16Z","pushed_at":"2016-08-24T05:21:53Z","git_url":"git://github.com/metamx/locators.git","ssh_url":"git@github.com:metamx/locators.git","clone_url":"https://github.com/metamx/locators.git","svn_url":"https://github.com/metamx/locators","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"metamx:master","ref":"master","sha":"c4d694ddac902a9cd9a5681f3f20393910ef58e1","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":28058798,"name":"locators","full_name":"metamx/locators","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/locators","description":"A collection of service locators using different mechanisms","fork":false,"url":"https://api.github.com/repos/metamx/locators","forks_url":"https://api.github.com/repos/metamx/locators/forks","keys_url":"https://api.github.com/repos/metamx/locators/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/locators/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/locators/teams","hooks_url":"https://api.github.com/repos/metamx/locators/hooks","issue_events_url":"https://api.github.com/repos/metamx/locators/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/locators/events","assignees_url":"https://api.github.com/repos/metamx/locators/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/locators/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/locators/tags","blobs_url":"https://api.github.com/repos/metamx/locators/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/locators/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/locators/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/locators/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/locators/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/locators/languages","stargazers_url":"https://api.github.com/repos/metamx/locators/stargazers","contributors_url":"https://api.github.com/repos/metamx/locators/contributors","subscribers_url":"https://api.github.com/repos/metamx/locators/subscribers","subscription_url":"https://api.github.com/repos/metamx/locators/subscription","commits_url":"https://api.github.com/repos/metamx/locators/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/locators/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/locators/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/locators/issues/comments{/number}","contents_url":"https://api.github.com/repos/metamx/locators/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/locators/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/locators/merges","archive_url":"https://api.github.com/repos/metamx/locators/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/locators/downloads","issues_url":"https://api.github.com/repos/metamx/locators/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/locators/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/locators/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/locators/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/locators/labels{/name}","releases_url":"https://api.github.com/repos/metamx/locators/releases{/id}","deployments_url":"https://api.github.com/repos/metamx/locators/deployments","created_at":"2014-12-15T22:14:43Z","updated_at":"2015-04-24T01:07:16Z","pushed_at":"2016-08-24T05:21:53Z","git_url":"git://github.com/metamx/locators.git","ssh_url":"git@github.com:metamx/locators.git","clone_url":"https://github.com/metamx/locators.git","svn_url":"https://github.com/metamx/locators","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metamx/locators/pulls/9"},"html":{"href":"https://github.com/metamx/locators/pull/9"},"issue":{"href":"https://api.github.com/repos/metamx/locators/issues/9"},"comments":{"href":"https://api.github.com/repos/metamx/locators/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/metamx/locators/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/metamx/locators/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metamx/locators/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/metamx/locators/statuses/dd1c3a24a5de79d5f66373b1d561e5e6c62d45e6"}}}}
{"actor":{"display_login":"clintropolis"}}