{"action":"created","issue":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1494","repository_url":"https://api.github.com/repos/The-Compiler/qutebrowser","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1494/labels{/name}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1494/comments","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1494/events","html_url":"https://github.com/The-Compiler/qutebrowser/pull/1494","id":154737839,"number":1494,"title":"Properly replace variables in set-cmd-text command","user":{"login":"forkbong","id":10636055,"avatar_url":"https://avatars.githubusercontent.com/u/10636055?v=3","gravatar_id":"","url":"https://api.github.com/users/forkbong","html_url":"https://github.com/forkbong","followers_url":"https://api.github.com/users/forkbong/followers","following_url":"https://api.github.com/users/forkbong/following{/other_user}","gists_url":"https://api.github.com/users/forkbong/gists{/gist_id}","starred_url":"https://api.github.com/users/forkbong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkbong/subscriptions","organizations_url":"https://api.github.com/users/forkbong/orgs","repos_url":"https://api.github.com/users/forkbong/repos","events_url":"https://api.github.com/users/forkbong/events{/privacy}","received_events_url":"https://api.github.com/users/forkbong/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels/PR:%20needs%20initial%20review","name":"PR: needs initial review","color":"f9d0c4"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-13T15:24:21Z","updated_at":"2016-05-13T19:49:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/1494","html_url":"https://github.com/The-Compiler/qutebrowser/pull/1494","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/1494.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/1494.patch"},"body":"Fixes #123 and partially fixes #1483.\r\n\r\nI tried splitting arguments with `shlex.split()` but I had some problems with\r\nquotes.  I had to use `posix=False` to keep them from disappearing, but even\r\nthen tests like\r\n```\r\nWhen I run :set-cmd-text -s :message-info \"foo\r\nAnd I run :set-cmd-text -a bar\"\r\n```\r\nfailed because of unmatched quotes.  So I used `srt.split()` instead, which\r\nseems OK to me in this context.\r\n\r\nI will open a separate pull request for decoding hovering URLs later."},"comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments/219142451","html_url":"https://github.com/The-Compiler/qutebrowser/pull/1494#issuecomment-219142451","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/1494","id":219142451,"user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T19:49:40Z","updated_at":"2016-05-13T19:49:40Z","body":"Thanks for the quick update! Can you please also add a test for using `:set-cmd-text` with `{url:pretty}`, i.e. the thing which didn't work before and now should work?"}}