{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/77674878","id":77674878,"diff_hunk":"@@ -145,7 +145,7 @@ def getComponentMetrics(self,\n \n     if metricResponse.status.status == common_pb2.NOTOK:\n       if metricResponse.status.HasField(\"message\"):\n-        Log.error(metricResponse.status.message)\n+        Log.warn(metricResponse.status.message)","path":"heron/tools/tracker/src/python/handlers/metricshandler.py","position":5,"original_position":5,"commit_id":"4af20c23f84c0ebfeb150e253979740abbc07129","original_commit_id":"4af20c23f84c0ebfeb150e253979740abbc07129","user":{"login":"billonahill","id":23758,"avatar_url":"https://avatars.githubusercontent.com/u/23758?v=3","gravatar_id":"","url":"https://api.github.com/users/billonahill","html_url":"https://github.com/billonahill","followers_url":"https://api.github.com/users/billonahill/followers","following_url":"https://api.github.com/users/billonahill/following{/other_user}","gists_url":"https://api.github.com/users/billonahill/gists{/gist_id}","starred_url":"https://api.github.com/users/billonahill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billonahill/subscriptions","organizations_url":"https://api.github.com/users/billonahill/orgs","repos_url":"https://api.github.com/users/billonahill/repos","events_url":"https://api.github.com/users/billonahill/events{/privacy}","received_events_url":"https://api.github.com/users/billonahill/received_events","type":"User","site_admin":false},"body":"Log.warn seems fine here, but I typically like to prepend some text to make it clear that this message is from the metrics manager. \"Received the following response from the metrics manager: ...\"\r\n\r\nSame for metricstimeline.py below.","created_at":"2016-09-06T16:56:21Z","updated_at":"2016-09-06T16:56:21Z","html_url":"https://github.com/twitter/heron/pull/1336#discussion_r77674878","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/1336","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/77674878"},"html":{"href":"https://github.com/twitter/heron/pull/1336#discussion_r77674878"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/1336"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1336","id":83882491,"html_url":"https://github.com/twitter/heron/pull/1336","diff_url":"https://github.com/twitter/heron/pull/1336.diff","patch_url":"https://github.com/twitter/heron/pull/1336.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1336","number":1336,"state":"open","locked":false,"title":"Improve TMaster return message when metrics is not available","user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"body":"In `GetMetrics` function, if there is no metrics associated with a component, we will now check if the component actually exists in the topology. If it exists in the topology, we know that the metrics is not yet available. We can then return a more proper error message.\r\n\r\nresolves #1322 \r\n\r\ncc @kramasamy @cckellogg @billonahill ","created_at":"2016-09-03T01:42:54Z","updated_at":"2016-09-06T16:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4549edbce1d451f8b4991fc05e58f727ce9deb34","assignee":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"assignees":[{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1336/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1336/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1336/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/4af20c23f84c0ebfeb150e253979740abbc07129","head":{"label":"objmagic:unknown-component-err","ref":"unknown-component-err","sha":"4af20c23f84c0ebfeb150e253979740abbc07129","user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"repo":{"id":59701078,"name":"heron","full_name":"objmagic/heron","owner":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objmagic/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/objmagic/heron","forks_url":"https://api.github.com/repos/objmagic/heron/forks","keys_url":"https://api.github.com/repos/objmagic/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objmagic/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objmagic/heron/teams","hooks_url":"https://api.github.com/repos/objmagic/heron/hooks","issue_events_url":"https://api.github.com/repos/objmagic/heron/issues/events{/number}","events_url":"https://api.github.com/repos/objmagic/heron/events","assignees_url":"https://api.github.com/repos/objmagic/heron/assignees{/user}","branches_url":"https://api.github.com/repos/objmagic/heron/branches{/branch}","tags_url":"https://api.github.com/repos/objmagic/heron/tags","blobs_url":"https://api.github.com/repos/objmagic/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objmagic/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objmagic/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/objmagic/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objmagic/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/objmagic/heron/languages","stargazers_url":"https://api.github.com/repos/objmagic/heron/stargazers","contributors_url":"https://api.github.com/repos/objmagic/heron/contributors","subscribers_url":"https://api.github.com/repos/objmagic/heron/subscribers","subscription_url":"https://api.github.com/repos/objmagic/heron/subscription","commits_url":"https://api.github.com/repos/objmagic/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/objmagic/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/objmagic/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/objmagic/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/objmagic/heron/contents/{+path}","compare_url":"https://api.github.com/repos/objmagic/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objmagic/heron/merges","archive_url":"https://api.github.com/repos/objmagic/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objmagic/heron/downloads","issues_url":"https://api.github.com/repos/objmagic/heron/issues{/number}","pulls_url":"https://api.github.com/repos/objmagic/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/objmagic/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/objmagic/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objmagic/heron/labels{/name}","releases_url":"https://api.github.com/repos/objmagic/heron/releases{/id}","deployments_url":"https://api.github.com/repos/objmagic/heron/deployments","created_at":"2016-05-25T22:08:44Z","updated_at":"2016-05-25T22:08:47Z","pushed_at":"2016-09-03T01:44:23Z","git_url":"git://github.com/objmagic/heron.git","ssh_url":"git@github.com:objmagic/heron.git","clone_url":"https://github.com/objmagic/heron.git","svn_url":"https://github.com/objmagic/heron","homepage":"http://heronstreaming.io","size":118597,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"4c64fa7ebb4323496a0d86fb6ced10e8dc2597a8","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2016-09-06T10:12:07Z","pushed_at":"2016-09-06T08:56:59Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":146885,"stargazers_count":2316,"watchers_count":2316,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":380,"mirror_url":null,"open_issues_count":182,"forks":380,"open_issues":182,"watchers":2316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1336"},"html":{"href":"https://github.com/twitter/heron/pull/1336"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1336"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1336/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1336/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1336/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/4af20c23f84c0ebfeb150e253979740abbc07129"}}}}
{"actor":{"display_login":"billonahill"}}