{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/crayzeewulf/libserial/pulls/69","id":84791124,"html_url":"https://github.com/crayzeewulf/libserial/pull/69","diff_url":"https://github.com/crayzeewulf/libserial/pull/69.diff","patch_url":"https://github.com/crayzeewulf/libserial/pull/69.patch","issue_url":"https://api.github.com/repos/crayzeewulf/libserial/issues/69","number":69,"state":"closed","locked":false,"title":"Fix all compiler warnings and Standardize curly brace indentation.","user":{"login":"mcsauder","id":2497951,"avatar_url":"https://avatars.githubusercontent.com/u/2497951?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsauder","html_url":"https://github.com/mcsauder","followers_url":"https://api.github.com/users/mcsauder/followers","following_url":"https://api.github.com/users/mcsauder/following{/other_user}","gists_url":"https://api.github.com/users/mcsauder/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsauder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsauder/subscriptions","organizations_url":"https://api.github.com/users/mcsauder/orgs","repos_url":"https://api.github.com/users/mcsauder/repos","events_url":"https://api.github.com/users/mcsauder/events{/privacy}","received_events_url":"https://api.github.com/users/mcsauder/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis PR fixes all of the compiler const return type warnings that the pedantic compiler flag setting revealed.  It also reverts vMin to vmin and vTime to vtime to match the library's convention, (my apologies for mixing that up previously).\r\n\r\nI believe that this PR should mostly wrap up all of the work after establishing the unit tests and updating the doxy commenting.  If there is anything you'd like to see changed please let me know!\r\n\r\n-Mark ","created_at":"2016-09-11T16:38:41Z","updated_at":"2016-10-24T05:42:26Z","closed_at":"2016-10-24T05:42:26Z","merged_at":"2016-10-24T05:42:26Z","merge_commit_sha":"80e5f25f9a91d515ced485737085c021593dea82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crayzeewulf/libserial/pulls/69/commits","review_comments_url":"https://api.github.com/repos/crayzeewulf/libserial/pulls/69/comments","review_comment_url":"https://api.github.com/repos/crayzeewulf/libserial/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crayzeewulf/libserial/issues/69/comments","statuses_url":"https://api.github.com/repos/crayzeewulf/libserial/statuses/2ee12eab05525443da0760848d56512d70357d17","head":{"label":"mcsauder:master","ref":"master","sha":"2ee12eab05525443da0760848d56512d70357d17","user":{"login":"mcsauder","id":2497951,"avatar_url":"https://avatars.githubusercontent.com/u/2497951?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsauder","html_url":"https://github.com/mcsauder","followers_url":"https://api.github.com/users/mcsauder/followers","following_url":"https://api.github.com/users/mcsauder/following{/other_user}","gists_url":"https://api.github.com/users/mcsauder/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsauder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsauder/subscriptions","organizations_url":"https://api.github.com/users/mcsauder/orgs","repos_url":"https://api.github.com/users/mcsauder/repos","events_url":"https://api.github.com/users/mcsauder/events{/privacy}","received_events_url":"https://api.github.com/users/mcsauder/received_events","type":"User","site_admin":false},"repo":{"id":67662858,"name":"libserial","full_name":"mcsauder/libserial","owner":{"login":"mcsauder","id":2497951,"avatar_url":"https://avatars.githubusercontent.com/u/2497951?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsauder","html_url":"https://github.com/mcsauder","followers_url":"https://api.github.com/users/mcsauder/followers","following_url":"https://api.github.com/users/mcsauder/following{/other_user}","gists_url":"https://api.github.com/users/mcsauder/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsauder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsauder/subscriptions","organizations_url":"https://api.github.com/users/mcsauder/orgs","repos_url":"https://api.github.com/users/mcsauder/repos","events_url":"https://api.github.com/users/mcsauder/events{/privacy}","received_events_url":"https://api.github.com/users/mcsauder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcsauder/libserial","description":" Serial Port Programming in C++","fork":true,"url":"https://api.github.com/repos/mcsauder/libserial","forks_url":"https://api.github.com/repos/mcsauder/libserial/forks","keys_url":"https://api.github.com/repos/mcsauder/libserial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcsauder/libserial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcsauder/libserial/teams","hooks_url":"https://api.github.com/repos/mcsauder/libserial/hooks","issue_events_url":"https://api.github.com/repos/mcsauder/libserial/issues/events{/number}","events_url":"https://api.github.com/repos/mcsauder/libserial/events","assignees_url":"https://api.github.com/repos/mcsauder/libserial/assignees{/user}","branches_url":"https://api.github.com/repos/mcsauder/libserial/branches{/branch}","tags_url":"https://api.github.com/repos/mcsauder/libserial/tags","blobs_url":"https://api.github.com/repos/mcsauder/libserial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcsauder/libserial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcsauder/libserial/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcsauder/libserial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcsauder/libserial/statuses/{sha}","languages_url":"https://api.github.com/repos/mcsauder/libserial/languages","stargazers_url":"https://api.github.com/repos/mcsauder/libserial/stargazers","contributors_url":"https://api.github.com/repos/mcsauder/libserial/contributors","subscribers_url":"https://api.github.com/repos/mcsauder/libserial/subscribers","subscription_url":"https://api.github.com/repos/mcsauder/libserial/subscription","commits_url":"https://api.github.com/repos/mcsauder/libserial/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcsauder/libserial/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcsauder/libserial/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcsauder/libserial/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcsauder/libserial/contents/{+path}","compare_url":"https://api.github.com/repos/mcsauder/libserial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcsauder/libserial/merges","archive_url":"https://api.github.com/repos/mcsauder/libserial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcsauder/libserial/downloads","issues_url":"https://api.github.com/repos/mcsauder/libserial/issues{/number}","pulls_url":"https://api.github.com/repos/mcsauder/libserial/pulls{/number}","milestones_url":"https://api.github.com/repos/mcsauder/libserial/milestones{/number}","notifications_url":"https://api.github.com/repos/mcsauder/libserial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcsauder/libserial/labels{/name}","releases_url":"https://api.github.com/repos/mcsauder/libserial/releases{/id}","deployments_url":"https://api.github.com/repos/mcsauder/libserial/deployments","created_at":"2016-09-08T02:55:03Z","updated_at":"2016-09-08T02:55:05Z","pushed_at":"2016-09-24T19:49:14Z","git_url":"git://github.com/mcsauder/libserial.git","ssh_url":"git@github.com:mcsauder/libserial.git","clone_url":"https://github.com/mcsauder/libserial.git","svn_url":"https://github.com/mcsauder/libserial","homepage":"","size":610,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crayzeewulf:master","ref":"master","sha":"729741781a09d82b18b2ea8bd174fd131d2c6863","user":{"login":"crayzeewulf","id":2294944,"avatar_url":"https://avatars.githubusercontent.com/u/2294944?v=3","gravatar_id":"","url":"https://api.github.com/users/crayzeewulf","html_url":"https://github.com/crayzeewulf","followers_url":"https://api.github.com/users/crayzeewulf/followers","following_url":"https://api.github.com/users/crayzeewulf/following{/other_user}","gists_url":"https://api.github.com/users/crayzeewulf/gists{/gist_id}","starred_url":"https://api.github.com/users/crayzeewulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crayzeewulf/subscriptions","organizations_url":"https://api.github.com/users/crayzeewulf/orgs","repos_url":"https://api.github.com/users/crayzeewulf/repos","events_url":"https://api.github.com/users/crayzeewulf/events{/privacy}","received_events_url":"https://api.github.com/users/crayzeewulf/received_events","type":"User","site_admin":false},"repo":{"id":36825529,"name":"libserial","full_name":"crayzeewulf/libserial","owner":{"login":"crayzeewulf","id":2294944,"avatar_url":"https://avatars.githubusercontent.com/u/2294944?v=3","gravatar_id":"","url":"https://api.github.com/users/crayzeewulf","html_url":"https://github.com/crayzeewulf","followers_url":"https://api.github.com/users/crayzeewulf/followers","following_url":"https://api.github.com/users/crayzeewulf/following{/other_user}","gists_url":"https://api.github.com/users/crayzeewulf/gists{/gist_id}","starred_url":"https://api.github.com/users/crayzeewulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crayzeewulf/subscriptions","organizations_url":"https://api.github.com/users/crayzeewulf/orgs","repos_url":"https://api.github.com/users/crayzeewulf/repos","events_url":"https://api.github.com/users/crayzeewulf/events{/privacy}","received_events_url":"https://api.github.com/users/crayzeewulf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crayzeewulf/libserial","description":" Serial Port Programming in C++","fork":false,"url":"https://api.github.com/repos/crayzeewulf/libserial","forks_url":"https://api.github.com/repos/crayzeewulf/libserial/forks","keys_url":"https://api.github.com/repos/crayzeewulf/libserial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crayzeewulf/libserial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crayzeewulf/libserial/teams","hooks_url":"https://api.github.com/repos/crayzeewulf/libserial/hooks","issue_events_url":"https://api.github.com/repos/crayzeewulf/libserial/issues/events{/number}","events_url":"https://api.github.com/repos/crayzeewulf/libserial/events","assignees_url":"https://api.github.com/repos/crayzeewulf/libserial/assignees{/user}","branches_url":"https://api.github.com/repos/crayzeewulf/libserial/branches{/branch}","tags_url":"https://api.github.com/repos/crayzeewulf/libserial/tags","blobs_url":"https://api.github.com/repos/crayzeewulf/libserial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crayzeewulf/libserial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crayzeewulf/libserial/git/refs{/sha}","trees_url":"https://api.github.com/repos/crayzeewulf/libserial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crayzeewulf/libserial/statuses/{sha}","languages_url":"https://api.github.com/repos/crayzeewulf/libserial/languages","stargazers_url":"https://api.github.com/repos/crayzeewulf/libserial/stargazers","contributors_url":"https://api.github.com/repos/crayzeewulf/libserial/contributors","subscribers_url":"https://api.github.com/repos/crayzeewulf/libserial/subscribers","subscription_url":"https://api.github.com/repos/crayzeewulf/libserial/subscription","commits_url":"https://api.github.com/repos/crayzeewulf/libserial/commits{/sha}","git_commits_url":"https://api.github.com/repos/crayzeewulf/libserial/git/commits{/sha}","comments_url":"https://api.github.com/repos/crayzeewulf/libserial/comments{/number}","issue_comment_url":"https://api.github.com/repos/crayzeewulf/libserial/issues/comments{/number}","contents_url":"https://api.github.com/repos/crayzeewulf/libserial/contents/{+path}","compare_url":"https://api.github.com/repos/crayzeewulf/libserial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crayzeewulf/libserial/merges","archive_url":"https://api.github.com/repos/crayzeewulf/libserial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crayzeewulf/libserial/downloads","issues_url":"https://api.github.com/repos/crayzeewulf/libserial/issues{/number}","pulls_url":"https://api.github.com/repos/crayzeewulf/libserial/pulls{/number}","milestones_url":"https://api.github.com/repos/crayzeewulf/libserial/milestones{/number}","notifications_url":"https://api.github.com/repos/crayzeewulf/libserial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crayzeewulf/libserial/labels{/name}","releases_url":"https://api.github.com/repos/crayzeewulf/libserial/releases{/id}","deployments_url":"https://api.github.com/repos/crayzeewulf/libserial/deployments","created_at":"2015-06-03T19:28:17Z","updated_at":"2016-10-18T07:15:32Z","pushed_at":"2016-10-24T05:42:27Z","git_url":"git://github.com/crayzeewulf/libserial.git","ssh_url":"git@github.com:crayzeewulf/libserial.git","clone_url":"https://github.com/crayzeewulf/libserial.git","svn_url":"https://github.com/crayzeewulf/libserial","homepage":"","size":710,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crayzeewulf/libserial/pulls/69"},"html":{"href":"https://github.com/crayzeewulf/libserial/pull/69"},"issue":{"href":"https://api.github.com/repos/crayzeewulf/libserial/issues/69"},"comments":{"href":"https://api.github.com/repos/crayzeewulf/libserial/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/crayzeewulf/libserial/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/crayzeewulf/libserial/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crayzeewulf/libserial/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/crayzeewulf/libserial/statuses/2ee12eab05525443da0760848d56512d70357d17"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"crayzeewulf","id":2294944,"avatar_url":"https://avatars.githubusercontent.com/u/2294944?v=3","gravatar_id":"","url":"https://api.github.com/users/crayzeewulf","html_url":"https://github.com/crayzeewulf","followers_url":"https://api.github.com/users/crayzeewulf/followers","following_url":"https://api.github.com/users/crayzeewulf/following{/other_user}","gists_url":"https://api.github.com/users/crayzeewulf/gists{/gist_id}","starred_url":"https://api.github.com/users/crayzeewulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crayzeewulf/subscriptions","organizations_url":"https://api.github.com/users/crayzeewulf/orgs","repos_url":"https://api.github.com/users/crayzeewulf/repos","events_url":"https://api.github.com/users/crayzeewulf/events{/privacy}","received_events_url":"https://api.github.com/users/crayzeewulf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":484,"deletions":307,"changed_files":6}}
{"actor":{"display_login":"crayzeewulf"}}