{"action":"created","issue":{"url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core/issues/40","repository_url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core","labels_url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core/issues/40/comments","events_url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core/issues/40/events","html_url":"https://github.com/CommonBuildToolset/CBT.Core/issues/40","id":194230726,"number":40,"title":"Can't control import order of cbt modules","user":{"login":"kingerja","id":11019677,"avatar_url":"https://avatars.githubusercontent.com/u/11019677?v=3","gravatar_id":"","url":"https://api.github.com/users/kingerja","html_url":"https://github.com/kingerja","followers_url":"https://api.github.com/users/kingerja/followers","following_url":"https://api.github.com/users/kingerja/following{/other_user}","gists_url":"https://api.github.com/users/kingerja/gists{/gist_id}","starred_url":"https://api.github.com/users/kingerja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingerja/subscriptions","organizations_url":"https://api.github.com/users/kingerja/orgs","repos_url":"https://api.github.com/users/kingerja/repos","events_url":"https://api.github.com/users/kingerja/events{/privacy}","received_events_url":"https://api.github.com/users/kingerja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-08T02:24:48Z","updated_at":"2016-12-08T02:28:44Z","closed_at":null,"body":"Project.Json\r\n    \"CBT.NuGet\": \"1.0.5-GPbeta\",\r\n    \"CBT.Microsoft.Common.Targets\": \"1.0.0\",\r\n    \"ILMerge.MSBuild.DPG\": \"1.0.0-beta\",\r\n    \"CBT.After.Any.Targets\": \"1.0.0\",\r\n\r\nGenerated imports\r\n  <Import Project=\"$(CBTModule_CBT_After_Any_Targets)\\CBT\\Module\\$(MSBuildThisFile)\" Condition=\"Exists('$(CBTModule_CBT_After_Any_Targets)\\CBT\\Module\\$(MSBuildThisFile)')\" />\r\n  <Import Project=\"$(CBTModule_CBT_Microsoft_Common_Targets)\\CBT\\Module\\$(MSBuildThisFile)\" Condition=\"Exists('$(CBTModule_CBT_Microsoft_Common_Targets)\\CBT\\Module\\$(MSBuildThisFile)')\" />\r\n  <Import Project=\"$(CBTModule_CBT_NuGet)\\CBT\\Module\\$(MSBuildThisFile)\" Condition=\"Exists('$(CBTModule_CBT_NuGet)\\CBT\\Module\\$(MSBuildThisFile)')\" />\r\n  <Import Project=\"$(CBTModule_CBT_Traversal)\\CBT\\Module\\$(MSBuildThisFile)\" Condition=\"Exists('$(CBTModule_CBT_Traversal)\\CBT\\Module\\$(MSBuildThisFile)')\" />\r\n  <Import Project=\"$(CBTModule_ILMerge)\\CBT\\Module\\$(MSBuildThisFile)\" Condition=\"Exists('$(CBTModule_ILMerge)\\CBT\\Module\\$(MSBuildThisFile)')\" />\r\n  <Import Project=\"$(CBTModule_ILMerge_MSBuild_DPG)\\CBT\\Module\\$(MSBuildThisFile)\" Condition=\"Exists('$(CBTModule_ILMerge_MSBuild_DPG)\\CBT\\Module\\$(MSBuildThisFile)')\" />\r\n\r\n\r\nThere are two issues here.\r\n1.  targets import order is really important in msbuild we need a way to control this.  I suggest based off the order they are listed in the project.json file.  \r\n2.  automatically generating the imports for the transitive closure makes it impossible for the user to specify if a module should be imported or not if it is referenced in some other module.  For auto importing it should be required that an entry is in the project.json even if it is technically redundant.\r\n\r\nUnless you have a better way we can reason about import order and when something is imported as a module or not.\r\n"},"comment":{"url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core/issues/comments/265635893","html_url":"https://github.com/CommonBuildToolset/CBT.Core/issues/40#issuecomment-265635893","issue_url":"https://api.github.com/repos/CommonBuildToolset/CBT.Core/issues/40","id":265635893,"user":{"login":"kingerja","id":11019677,"avatar_url":"https://avatars.githubusercontent.com/u/11019677?v=3","gravatar_id":"","url":"https://api.github.com/users/kingerja","html_url":"https://github.com/kingerja","followers_url":"https://api.github.com/users/kingerja/followers","following_url":"https://api.github.com/users/kingerja/following{/other_user}","gists_url":"https://api.github.com/users/kingerja/gists{/gist_id}","starred_url":"https://api.github.com/users/kingerja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingerja/subscriptions","organizations_url":"https://api.github.com/users/kingerja/orgs","repos_url":"https://api.github.com/users/kingerja/repos","events_url":"https://api.github.com/users/kingerja/events{/privacy}","received_events_url":"https://api.github.com/users/kingerja/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T02:28:44Z","updated_at":"2016-12-08T02:28:44Z","body":"I am guessing this is related to the forming up of the \r\nCBTAllModulePaths property"}}
{"actor":{"display_login":"kingerja"}}