{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/6733","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/6733/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6733/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/6733/events","html_url":"https://github.com/dotnet/corefx/pull/6733","id":139116781,"number":6733,"title":"Add negative tests for JapaneseCalendar","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-07T22:41:58Z","updated_at":"2016-03-08T10:26:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6733","html_url":"https://github.com/dotnet/corefx/pull/6733","diff_url":"https://github.com/dotnet/corefx/pull/6733.diff","patch_url":"https://github.com/dotnet/corefx/pull/6733.patch"},"body":"Adds negative tests for:\r\n- AddMonths\r\n- AddYears\r\n- GetDaysInMonth\r\n- GetDaysInYear\r\n- GetMonthsInYear\r\n- IsLeapYear\r\n- IsLeapMonth\r\n- IsLeapDay\r\n- ToDateTime\r\n- ToFourDigitYear\r\n- TwoDigitYearMax\r\n\r\nAlso cleans up CalendarHelpers to be more resilient, easier to plug-n-play\r\nwith, and support calendars with multiple eras!\r\n\r\nI've tried to avoid hardcoding lots of values, but the only place I had to was YearOffset.\r\nThe previous implementation was incorrect. For example, TaiwanCalendar has a MinSupportedDateTime value equal to DateTime.MinValue, but an offset of 1911 years\r\n\r\n/cc @stephentoub @tarekgh"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/193709191","html_url":"https://github.com/dotnet/corefx/pull/6733#issuecomment-193709191","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6733","id":193709191,"user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T10:26:41Z","updated_at":"2016-03-08T10:26:41Z","body":"Nice one - the UNIX failures seem to have been fixed ;)"}}