{"action":"created","comment":{"url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/comments/64210276","id":64210276,"diff_hunk":"@@ -920,22 +920,22 @@ struct JSPrinter {\n         char *test = end;\n         // remove zeros, and also doubles can use at most 24 digits, we can truncate any extras even if not zero\n         while ((*test == '0' || test - buffer > 24) && test > buffer) test--;\n-        int num = end - test;\n+        size_t num = end - test;\n         if (num >= 3) {\n           test++;\n           test[0] = 'e';\n           if (num < 10) {\n-            test[1] = '0' + num;\n+            test[1] = (char)('0' + num);","path":"src/emscripten-optimizer/simple_ast.h","position":73,"original_position":65,"commit_id":"e681a49e9e8fe4d0b0c639c035e64ef141493a52","original_commit_id":"4de0914d1aa8c47490b0345ccf7aa8adfd53321c","user":{"login":"BSalita","id":1225749,"avatar_url":"https://avatars.githubusercontent.com/u/1225749?v=3","gravatar_id":"","url":"https://api.github.com/users/BSalita","html_url":"https://github.com/BSalita","followers_url":"https://api.github.com/users/BSalita/followers","following_url":"https://api.github.com/users/BSalita/following{/other_user}","gists_url":"https://api.github.com/users/BSalita/gists{/gist_id}","starred_url":"https://api.github.com/users/BSalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BSalita/subscriptions","organizations_url":"https://api.github.com/users/BSalita/orgs","repos_url":"https://api.github.com/users/BSalita/repos","events_url":"https://api.github.com/users/BSalita/events{/privacy}","received_events_url":"https://api.github.com/users/BSalita/received_events","type":"User","site_admin":false},"body":"I've not wanted to create more changes to this PR. However, since you asked twice, I went ahead and coded per your request.","created_at":"2016-05-23T11:59:57Z","updated_at":"2016-05-23T11:59:57Z","html_url":"https://github.com/WebAssembly/binaryen/pull/491#discussion_r64210276","pull_request_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491","_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/comments/64210276"},"html":{"href":"https://github.com/WebAssembly/binaryen/pull/491#discussion_r64210276"},"pull_request":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491","id":70005148,"html_url":"https://github.com/WebAssembly/binaryen/pull/491","diff_url":"https://github.com/WebAssembly/binaryen/pull/491.diff","patch_url":"https://github.com/WebAssembly/binaryen/pull/491.patch","issue_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/491","number":491,"state":"open","locked":false,"title":"Initial Length Harmonies","user":{"login":"BSalita","id":1225749,"avatar_url":"https://avatars.githubusercontent.com/u/1225749?v=3","gravatar_id":"","url":"https://api.github.com/users/BSalita","html_url":"https://github.com/BSalita","followers_url":"https://api.github.com/users/BSalita/followers","following_url":"https://api.github.com/users/BSalita/following{/other_user}","gists_url":"https://api.github.com/users/BSalita/gists{/gist_id}","starred_url":"https://api.github.com/users/BSalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BSalita/subscriptions","organizations_url":"https://api.github.com/users/BSalita/orgs","repos_url":"https://api.github.com/users/BSalita/repos","events_url":"https://api.github.com/users/BSalita/events{/privacy}","received_events_url":"https://api.github.com/users/BSalita/received_events","type":"User","site_admin":false},"body":"Initial commits for harmonizing lengths (Index, size_t, uint32_t ...)","created_at":"2016-05-13T14:32:27Z","updated_at":"2016-05-23T11:59:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5684a78b9375e676ca922ad0641e062f0e2e68fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/491/comments","statuses_url":"https://api.github.com/repos/WebAssembly/binaryen/statuses/e681a49e9e8fe4d0b0c639c035e64ef141493a52","head":{"label":"BSalita:master","ref":"master","sha":"e681a49e9e8fe4d0b0c639c035e64ef141493a52","user":{"login":"BSalita","id":1225749,"avatar_url":"https://avatars.githubusercontent.com/u/1225749?v=3","gravatar_id":"","url":"https://api.github.com/users/BSalita","html_url":"https://github.com/BSalita","followers_url":"https://api.github.com/users/BSalita/followers","following_url":"https://api.github.com/users/BSalita/following{/other_user}","gists_url":"https://api.github.com/users/BSalita/gists{/gist_id}","starred_url":"https://api.github.com/users/BSalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BSalita/subscriptions","organizations_url":"https://api.github.com/users/BSalita/orgs","repos_url":"https://api.github.com/users/BSalita/repos","events_url":"https://api.github.com/users/BSalita/events{/privacy}","received_events_url":"https://api.github.com/users/BSalita/received_events","type":"User","site_admin":false},"repo":{"id":58673981,"name":"binaryen","full_name":"BSalita/binaryen","owner":{"login":"BSalita","id":1225749,"avatar_url":"https://avatars.githubusercontent.com/u/1225749?v=3","gravatar_id":"","url":"https://api.github.com/users/BSalita","html_url":"https://github.com/BSalita","followers_url":"https://api.github.com/users/BSalita/followers","following_url":"https://api.github.com/users/BSalita/following{/other_user}","gists_url":"https://api.github.com/users/BSalita/gists{/gist_id}","starred_url":"https://api.github.com/users/BSalita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BSalita/subscriptions","organizations_url":"https://api.github.com/users/BSalita/orgs","repos_url":"https://api.github.com/users/BSalita/repos","events_url":"https://api.github.com/users/BSalita/events{/privacy}","received_events_url":"https://api.github.com/users/BSalita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BSalita/binaryen","description":"Compiler infrastructure and toolchain library for WebAssembly, in C++","fork":true,"url":"https://api.github.com/repos/BSalita/binaryen","forks_url":"https://api.github.com/repos/BSalita/binaryen/forks","keys_url":"https://api.github.com/repos/BSalita/binaryen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BSalita/binaryen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BSalita/binaryen/teams","hooks_url":"https://api.github.com/repos/BSalita/binaryen/hooks","issue_events_url":"https://api.github.com/repos/BSalita/binaryen/issues/events{/number}","events_url":"https://api.github.com/repos/BSalita/binaryen/events","assignees_url":"https://api.github.com/repos/BSalita/binaryen/assignees{/user}","branches_url":"https://api.github.com/repos/BSalita/binaryen/branches{/branch}","tags_url":"https://api.github.com/repos/BSalita/binaryen/tags","blobs_url":"https://api.github.com/repos/BSalita/binaryen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BSalita/binaryen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BSalita/binaryen/git/refs{/sha}","trees_url":"https://api.github.com/repos/BSalita/binaryen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BSalita/binaryen/statuses/{sha}","languages_url":"https://api.github.com/repos/BSalita/binaryen/languages","stargazers_url":"https://api.github.com/repos/BSalita/binaryen/stargazers","contributors_url":"https://api.github.com/repos/BSalita/binaryen/contributors","subscribers_url":"https://api.github.com/repos/BSalita/binaryen/subscribers","subscription_url":"https://api.github.com/repos/BSalita/binaryen/subscription","commits_url":"https://api.github.com/repos/BSalita/binaryen/commits{/sha}","git_commits_url":"https://api.github.com/repos/BSalita/binaryen/git/commits{/sha}","comments_url":"https://api.github.com/repos/BSalita/binaryen/comments{/number}","issue_comment_url":"https://api.github.com/repos/BSalita/binaryen/issues/comments{/number}","contents_url":"https://api.github.com/repos/BSalita/binaryen/contents/{+path}","compare_url":"https://api.github.com/repos/BSalita/binaryen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BSalita/binaryen/merges","archive_url":"https://api.github.com/repos/BSalita/binaryen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BSalita/binaryen/downloads","issues_url":"https://api.github.com/repos/BSalita/binaryen/issues{/number}","pulls_url":"https://api.github.com/repos/BSalita/binaryen/pulls{/number}","milestones_url":"https://api.github.com/repos/BSalita/binaryen/milestones{/number}","notifications_url":"https://api.github.com/repos/BSalita/binaryen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BSalita/binaryen/labels{/name}","releases_url":"https://api.github.com/repos/BSalita/binaryen/releases{/id}","deployments_url":"https://api.github.com/repos/BSalita/binaryen/deployments","created_at":"2016-05-12T20:20:30Z","updated_at":"2016-05-12T20:20:35Z","pushed_at":"2016-05-23T11:45:00Z","git_url":"git://github.com/BSalita/binaryen.git","ssh_url":"git@github.com:BSalita/binaryen.git","clone_url":"https://github.com/BSalita/binaryen.git","svn_url":"https://github.com/BSalita/binaryen","homepage":"","size":18783,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebAssembly:master","ref":"master","sha":"4a720eca42c463d53db1c81f9957a3e5d9011836","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":45208608,"name":"binaryen","full_name":"WebAssembly/binaryen","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/binaryen","description":"Compiler infrastructure and toolchain library for WebAssembly, in C++","fork":false,"url":"https://api.github.com/repos/WebAssembly/binaryen","forks_url":"https://api.github.com/repos/WebAssembly/binaryen/forks","keys_url":"https://api.github.com/repos/WebAssembly/binaryen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/binaryen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/binaryen/teams","hooks_url":"https://api.github.com/repos/WebAssembly/binaryen/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/binaryen/events","assignees_url":"https://api.github.com/repos/WebAssembly/binaryen/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/binaryen/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/binaryen/tags","blobs_url":"https://api.github.com/repos/WebAssembly/binaryen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/binaryen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/binaryen/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/binaryen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/binaryen/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/binaryen/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/binaryen/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/binaryen/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/binaryen/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/binaryen/subscription","commits_url":"https://api.github.com/repos/WebAssembly/binaryen/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/binaryen/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/binaryen/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/binaryen/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/binaryen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/binaryen/merges","archive_url":"https://api.github.com/repos/WebAssembly/binaryen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/binaryen/downloads","issues_url":"https://api.github.com/repos/WebAssembly/binaryen/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/binaryen/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/binaryen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/binaryen/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/binaryen/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/binaryen/deployments","created_at":"2015-10-29T20:26:28Z","updated_at":"2016-05-23T08:06:25Z","pushed_at":"2016-05-23T11:51:24Z","git_url":"git://github.com/WebAssembly/binaryen.git","ssh_url":"git@github.com:WebAssembly/binaryen.git","clone_url":"https://github.com/WebAssembly/binaryen.git","svn_url":"https://github.com/WebAssembly/binaryen","homepage":"","size":21229,"stargazers_count":681,"watchers_count":681,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":72,"forks":58,"open_issues":72,"watchers":681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491"},"html":{"href":"https://github.com/WebAssembly/binaryen/pull/491"},"issue":{"href":"https://api.github.com/repos/WebAssembly/binaryen/issues/491"},"comments":{"href":"https://api.github.com/repos/WebAssembly/binaryen/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/binaryen/statuses/e681a49e9e8fe4d0b0c639c035e64ef141493a52"}}}}
{"actor":{"display_login":"BSalita"}}