{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/92236085","pull_request_review_id":12747865,"id":92236085,"diff_hunk":"@@ -8,14 +8,27 @@\n  */\n namespace eZ\\Publish\\Core\\REST\\Server\\Input\\Parser\\Criterion;\n \n+use eZ\\Publish\\Core\\REST\\Common\\Exceptions\\Parser;\n use eZ\\Publish\\Core\\REST\\Common\\Input\\BaseParser;\n use eZ\\Publish\\Core\\REST\\Common\\Input\\ParsingDispatcher;\n+use eZ\\Publish\\API\\Repository\\Values\\Content\\Query\\Criterion\\DateMetadata as DateMetadataCriterion;\n \n /**\n  * Parser for ViewInput Criterion.\n  */\n class DateMetadata extends BaseParser\n {\n+    /** @var array */\n+    public $availableOperators = [","path":"eZ/Publish/Core/REST/Server/Input/Parser/Criterion/DateMetadata.php","position":15,"original_position":15,"commit_id":"f049fb439658e202a50f991d72b62f2d5dbeef55","original_commit_id":"f049fb439658e202a50f991d72b62f2d5dbeef55","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"privat?","created_at":"2016-12-13T18:39:14Z","updated_at":"2016-12-13T18:39:14Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1861#discussion_r92236085","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/92236085"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1861#discussion_r92236085"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861","id":97315996,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1861","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1861.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1861.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1861","number":1861,"state":"open","locked":false,"title":"EZP-26780 Implement DateMetadata criterion parser in REST","user":{"login":"kamilmusial","id":3974074,"avatar_url":"https://avatars.githubusercontent.com/u/3974074?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilmusial","html_url":"https://github.com/kamilmusial","followers_url":"https://api.github.com/users/kamilmusial/followers","following_url":"https://api.github.com/users/kamilmusial/following{/other_user}","gists_url":"https://api.github.com/users/kamilmusial/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilmusial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilmusial/subscriptions","organizations_url":"https://api.github.com/users/kamilmusial/orgs","repos_url":"https://api.github.com/users/kamilmusial/repos","events_url":"https://api.github.com/users/kamilmusial/events{/privacy}","received_events_url":"https://api.github.com/users/kamilmusial/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.ez.no/browse/EZP-26780\r\n\r\nCurrently there's no `OperatorCriterion`, so there's no easy way to set `$operator` for `DateMetadataCriterion` like it's done in other parsers.\r\n\r\nThat could be done by simply passing a string value to criterion constructor, but that'd omit a specification whitelist. So there's quick check in an array of abstract class reflection constants to validate an operator input before return a criterion object.\r\n\r\nAnother approach could be to implement an `OperatorCriterion` parser, but that should be another issue(?)\r\n","created_at":"2016-12-09T14:14:54Z","updated_at":"2016-12-13T18:39:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314986ecd95e6835dc9bba05cc21e2f2ce878297","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1861/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/f049fb439658e202a50f991d72b62f2d5dbeef55","head":{"label":"kamilmusial:master","ref":"master","sha":"f049fb439658e202a50f991d72b62f2d5dbeef55","user":{"login":"kamilmusial","id":3974074,"avatar_url":"https://avatars.githubusercontent.com/u/3974074?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilmusial","html_url":"https://github.com/kamilmusial","followers_url":"https://api.github.com/users/kamilmusial/followers","following_url":"https://api.github.com/users/kamilmusial/following{/other_user}","gists_url":"https://api.github.com/users/kamilmusial/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilmusial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilmusial/subscriptions","organizations_url":"https://api.github.com/users/kamilmusial/orgs","repos_url":"https://api.github.com/users/kamilmusial/repos","events_url":"https://api.github.com/users/kamilmusial/events{/privacy}","received_events_url":"https://api.github.com/users/kamilmusial/received_events","type":"User","site_admin":false},"repo":{"id":42109058,"name":"ezpublish-kernel","full_name":"kamilmusial/ezpublish-kernel","owner":{"login":"kamilmusial","id":3974074,"avatar_url":"https://avatars.githubusercontent.com/u/3974074?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilmusial","html_url":"https://github.com/kamilmusial","followers_url":"https://api.github.com/users/kamilmusial/followers","following_url":"https://api.github.com/users/kamilmusial/following{/other_user}","gists_url":"https://api.github.com/users/kamilmusial/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilmusial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilmusial/subscriptions","organizations_url":"https://api.github.com/users/kamilmusial/orgs","repos_url":"https://api.github.com/users/kamilmusial/repos","events_url":"https://api.github.com/users/kamilmusial/events{/privacy}","received_events_url":"https://api.github.com/users/kamilmusial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kamilmusial/ezpublish-kernel","description":"eZ Platform (aka eZ Publish 6.x) kernel","fork":true,"url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel","forks_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/kamilmusial/ezpublish-kernel/deployments","created_at":"2015-09-08T11:48:56Z","updated_at":"2016-12-08T14:53:50Z","pushed_at":"2016-12-13T07:26:36Z","git_url":"git://github.com/kamilmusial/ezpublish-kernel.git","ssh_url":"git@github.com:kamilmusial/ezpublish-kernel.git","clone_url":"https://github.com/kamilmusial/ezpublish-kernel.git","svn_url":"https://github.com/kamilmusial/ezpublish-kernel","homepage":"http://ez.no","size":47283,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"34f8a09a24a8b49a3ca247a40696891280fda81a","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"Kernel (Repository, MVC layer, REST) for eZ Platform","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/deployments","created_at":"2011-04-26T08:54:24Z","updated_at":"2016-11-26T05:04:58Z","pushed_at":"2016-12-13T16:06:03Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"git@github.com:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ezplatform.com/","size":47680,"stargazers_count":118,"watchers_count":118,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":63,"forks":165,"open_issues":63,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1861"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1861"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1861/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1861/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/f049fb439658e202a50f991d72b62f2d5dbeef55"}}}}
{"actor":{"display_login":"andrerom"}}