{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5697","repository_url":"https://api.github.com/repos/ember-cli/ember-cli","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5697/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5697/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5697/events","html_url":"https://github.com/ember-cli/ember-cli/pull/5697","id":144056449,"number":5697,"title":"Remove unecessary Promise.hash usage","user":{"login":"ryanlabouve","id":1318878,"avatar_url":"https://avatars.githubusercontent.com/u/1318878?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanlabouve","html_url":"https://github.com/ryanlabouve","followers_url":"https://api.github.com/users/ryanlabouve/followers","following_url":"https://api.github.com/users/ryanlabouve/following{/other_user}","gists_url":"https://api.github.com/users/ryanlabouve/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanlabouve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanlabouve/subscriptions","organizations_url":"https://api.github.com/users/ryanlabouve/orgs","repos_url":"https://api.github.com/users/ryanlabouve/repos","events_url":"https://api.github.com/users/ryanlabouve/events{/privacy}","received_events_url":"https://api.github.com/users/ryanlabouve/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ember-cli/ember-cli/labels/Cleanup","name":"Cleanup","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-28T19:13:23Z","updated_at":"2016-03-28T23:35:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5697","html_url":"https://github.com/ember-cli/ember-cli/pull/5697","diff_url":"https://github.com/ember-cli/ember-cli/pull/5697.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/5697.patch"},"body":"During the contributor workshop we discovered an uncessesary usage of `Promise.hash`.\r\n\r\n* directory is a string that is passed in (https://github.com/ember-cli/ember-cli/compare/master...ryanlabouve:unnecessary-promise?expand=1#diff-3677132bf6240059b3a3637716019c84L707)\r\n\r\n* require is synchronous (https://github.com/ember-cli/ember-cli/compare/master...ryanlabouve:unnecessary-promise?expand=1#diff-3677132bf6240059b3a3637716019c84L708)\r\n\r\nWe have removed and re-ran the test suite to verify.\r\n\r\n/cc @lukemelia "},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/202625918","html_url":"https://github.com/ember-cli/ember-cli/pull/5697#issuecomment-202625918","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5697","id":202625918,"user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T23:35:09Z","updated_at":"2016-03-28T23:35:09Z","body":":shipi"}}