{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1037","repository_url":"https://api.github.com/repos/electron-userland/electron-builder","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1037/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1037/comments","events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1037/events","html_url":"https://github.com/electron-userland/electron-builder/issues/1037","id":197165109,"number":1037,"title":"TypeError: s.trim is not a function","user":{"login":"df-karuna","id":3124496,"avatar_url":"https://avatars.githubusercontent.com/u/3124496?v=3","gravatar_id":"","url":"https://api.github.com/users/df-karuna","html_url":"https://github.com/df-karuna","followers_url":"https://api.github.com/users/df-karuna/followers","following_url":"https://api.github.com/users/df-karuna/following{/other_user}","gists_url":"https://api.github.com/users/df-karuna/gists{/gist_id}","starred_url":"https://api.github.com/users/df-karuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/df-karuna/subscriptions","organizations_url":"https://api.github.com/users/df-karuna/orgs","repos_url":"https://api.github.com/users/df-karuna/repos","events_url":"https://api.github.com/users/df-karuna/events{/privacy}","received_events_url":"https://api.github.com/users/df-karuna/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-22T12:33:18Z","updated_at":"2016-12-22T12:35:44Z","closed_at":null,"body":"<!-- Which version of electron-builder are you using? -->\r\n* **Version**: 4.6.0\r\n\r\n<!-- What target are you building for? -->\r\n* **Target**: nsis\r\n\r\n<!-- Enter your issue details below this comment. -->\r\n\r\nHello. I tried first time to use `electron-builder` but, the error `TypeError: s.trim is not a function` had occured and what is the `TypeError: s.trim is not a function` meaning in here.\r\n\r\nI don't understand why ouutput like this `Signing StocktalkPC.exe (certificate file \"undefined\")` but I declared envrionment variable `WIN_CSC_LINK` the full path with file(ex, D:\\myapp\\cert.pfx)\r\nand `WIN_CSC_KEY_PASSWORD` as my cfx's password. \r\n\r\nI'm using Windows Server 2008, and I tried to build for 32 bit application\r\nand here is my `package.json` snippet and error messages.\r\n\r\nThanks for your help.\r\ndf-karuna.\r\n\r\n```\r\n  \"devDependencies\": {\r\n    \"asar\": \"^0.12.3\",\r\n    \"electron\": \"^1.4.5\",\r\n    \"typescript\" : \"^2.1.4\",\r\n    \"electron-builder\": \"^7.14.2\",\r\n    \"electron-installer-squirrel-windows\": \"^1.3.0\",\r\n    \"electron-packager\": \"8.1.0\"\r\n  },\r\n  \"build\": {\r\n    \"appId\": \"kr.stocktalk.pc\",\r\n    \"forceCodeSigning\" : true,\r\n    \"nsis\" : {\r\n      \"runAfterFinish\" : false,\r\n      \"installerIcon\" : \"./stocktalk.ico\",\r\n      \"installerHeaderIcon\" : \"./stocktalk.ico\",\r\n      \"language\" : \"0412\",\r\n      \"include\" : false\r\n    },\r\n    \"win\": {\r\n      \"target\" : \"nsis\",\r\n      \"icon\": \"./stocktalk-large-test.ico\",\r\n      \"signingHashAlgorithms\" : \"sha256\",\r\n      \"certificateSubjectName\" : \"CDEFINITION\",\r\n      \"timeStampServer\" : false\r\n    }\r\n  },\r\n  \"scripts\": {\r\n    \"start\": \"electron .\",\r\n    \"build\": \"electron-packager . --overwrite --icon=stocktalk.ico --asar --arch=ia32\",\r\n    \"dist-test:win\": \"build --dir --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/\",\r\n    \"dist-test:nsis\": \"build --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/\",\r\n    \"dist:win\": \"build --dir --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/\",\r\n    \"dist:nsis\": \"build --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/\"\r\n  },\r\n```\r\n\r\n\r\n```\r\nD:\\ws-atom\\stocktalk-electron>npm run dist-test:nsis\r\n\r\n> StocktalkPC@2.1.0 dist-test:nsis D:\\ws-atom\\stocktalk-electron\r\n> build --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/\r\n\r\nSkip app dependencies rebuild because dev and app dependencies are not separated\r\nPackaging for platform win32 ia32 using electron 1.4.5 to dist\\win-ia32-unpacked\r\n\r\nSigning StocktalkPC.exe (certificate file \"undefined\")\r\nnode_modules\\node-notifier is not packed into asar archive - contains executable code\r\nBuilding nsis ia32\r\n\r\nBuilding NSIS installer\r\n\r\nCustom NSIS script is used - uninstaller is not signed by electron-builder\r\nTypeError: s.trim is not a function\r\n    at isEmptyOrSpaces (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\util\\util.ts:280:25)\r\n    at D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\platformPackager.ts:480:15\r\n    at next (native)\r\nFrom previous event:\r\n    at WinPackager.getResource (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\platformPackager.js:512:11)\r\n    at D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\targets\\nsis.ts:258:42\r\nFrom previous event:\r\n    at NsisTarget.executeMakensis (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\targets\\nsis.js:348:11)\r\n    at D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\targets\\nsis.ts:202:58\r\nFrom previous event:\r\n    at NsisTarget.buildInstaller (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\targets\\nsis.js:269:11)\r\n    at NsisTarget.finishBuild (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\targets\\nsis.ts:67:49)\r\n    at D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\packager.ts:138:31\r\nFrom previous event:\r\n    at Packager.doBuild (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\packager.js:254:11)\r\n    at D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\packager.ts:102:32\r\n    at next (native)\r\n    at processImmediate [as _immediateCallback] (timers.js:383:17)\r\nFrom previous event:\r\n    at Packager.build (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\packager.js:206:11)\r\n    at D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\src\\builder.ts:234:33\r\n    at next (native)\r\nFrom previous event:\r\n    at build (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\builder.js:81:21)\r\n    at Object.<anonymous> (D:\\ws-atom\\stocktalk-electron\\node_modules\\electron-builder\\out\\build-cli.js:66:41)\r\n    at Module._compile (module.js:409:26)\r\n    at Object.Module._extensions..js (module.js:416:10)\r\n    at Module.load (module.js:343:32)\r\n    at Function.Module._load (module.js:300:12)\r\n    at Function.Module.runMain (module.js:441:10)\r\n    at startup (node.js:139:18)\r\n    at node.js:974:3\r\n\r\nnpm ERR! Windows_NT 6.1.7601\r\nnpm ERR! argv \"C:\\\\Program Files (x86)\\\\nodejs\\\\node.exe\" \"C:\\\\Program Files (x86)\\\\nodejs\\\\node_modules\\\\npm\\\\bin\\\\npm-cli.j\r\ns\" \"run\" \"dist-test:nsis\"\r\nnpm ERR! node v4.6.0\r\nnpm ERR! npm  v2.15.9\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! StocktalkPC@2.1.0 dist-test:nsis: `build --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/`\r\nnpm ERR! Exit status 4294967295\r\nnpm ERR!\r\nnpm ERR! Failed at the StocktalkPC@2.1.0 dist-test:nsis script 'build --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/'.\r\nnpm ERR! This is most likely a problem with the StocktalkPC package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR!     build --ia32 && cp ./stocktalk.ico ./dist/win-unpacked/\r\nnpm ERR! You can get information on how to open an issue for this project with:\r\nnpm ERR!     npm bugs StocktalkPC\r\nnpm ERR! Or if that isn't available, you can get their info via:\r\nnpm ERR!\r\nnpm ERR!     npm owner ls StocktalkPC\r\nnpm ERR! There is likely additional logging output above.\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR!     D:\\ws-atom\\stocktalk-electron\\npm-debug.log\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments/268790987","html_url":"https://github.com/electron-userland/electron-builder/issues/1037#issuecomment-268790987","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1037","id":268790987,"user":{"login":"develar","id":350686,"avatar_url":"https://avatars.githubusercontent.com/u/350686?v=3","gravatar_id":"","url":"https://api.github.com/users/develar","html_url":"https://github.com/develar","followers_url":"https://api.github.com/users/develar/followers","following_url":"https://api.github.com/users/develar/following{/other_user}","gists_url":"https://api.github.com/users/develar/gists{/gist_id}","starred_url":"https://api.github.com/users/develar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/develar/subscriptions","organizations_url":"https://api.github.com/users/develar/orgs","repos_url":"https://api.github.com/users/develar/repos","events_url":"https://api.github.com/users/develar/events{/privacy}","received_events_url":"https://api.github.com/users/develar/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T12:35:44Z","updated_at":"2016-12-22T12:35:44Z","body":"> node v4.6.0\r\n\r\nCould you please upgrade to node 6?"}}
{"actor":{"display_login":"develar"}}