{"action":"opened","number":603,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/603","id":57425776,"html_url":"https://github.com/rackerlabs/blueflood/pull/603","diff_url":"https://github.com/rackerlabs/blueflood/pull/603.diff","patch_url":"https://github.com/rackerlabs/blueflood/pull/603.patch","issue_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/603","number":603,"state":"open","locked":false,"title":"add tests for Gauge, Set","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"body":"**Why:**\r\nThe goal is to increase test coverage of the various Serialization/De-serialization code, particularly in the are of Enum and aggregated metrics.\r\n\r\n**How:**\r\n* add Gauge and Set serialization/de-serialization tests\r\n* stop using serialized files in SerializationTest class\r\n* move some String related serialization/de-serialization tests from SerializationTest.class to its own test classes and add more tests to increase coverage. Support for String metrics is no longer available in the main code base\r\n\r\n**Not Included:**\r\n* didn't improve coverage for Histogram serialization/de-serialization code. I was told Histogram is to be deprecated\r\n* didn't improve coverage for SimpleNumberSerialization. I could not get the normal round trip test to work.\r\n","created_at":"2016-01-27T21:30:14Z","updated_at":"2016-01-27T21:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/603/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/603/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/603/comments","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/6c81eccb0590ca4c45648f3a1f17449240bea8e5","head":{"label":"shintasmith:refactor_serializer_test","ref":"refactor_serializer_test","sha":"6c81eccb0590ca4c45648f3a1f17449240bea8e5","user":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"repo":{"id":45861100,"name":"blueflood","full_name":"shintasmith/blueflood","owner":{"login":"shintasmith","id":3640870,"avatar_url":"https://avatars.githubusercontent.com/u/3640870?v=3","gravatar_id":"","url":"https://api.github.com/users/shintasmith","html_url":"https://github.com/shintasmith","followers_url":"https://api.github.com/users/shintasmith/followers","following_url":"https://api.github.com/users/shintasmith/following{/other_user}","gists_url":"https://api.github.com/users/shintasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/shintasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shintasmith/subscriptions","organizations_url":"https://api.github.com/users/shintasmith/orgs","repos_url":"https://api.github.com/users/shintasmith/repos","events_url":"https://api.github.com/users/shintasmith/events{/privacy}","received_events_url":"https://api.github.com/users/shintasmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shintasmith/blueflood","description":"A distributed system designed to ingest and process time series data","fork":true,"url":"https://api.github.com/repos/shintasmith/blueflood","forks_url":"https://api.github.com/repos/shintasmith/blueflood/forks","keys_url":"https://api.github.com/repos/shintasmith/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shintasmith/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shintasmith/blueflood/teams","hooks_url":"https://api.github.com/repos/shintasmith/blueflood/hooks","issue_events_url":"https://api.github.com/repos/shintasmith/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/shintasmith/blueflood/events","assignees_url":"https://api.github.com/repos/shintasmith/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/shintasmith/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/shintasmith/blueflood/tags","blobs_url":"https://api.github.com/repos/shintasmith/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shintasmith/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shintasmith/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/shintasmith/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shintasmith/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/shintasmith/blueflood/languages","stargazers_url":"https://api.github.com/repos/shintasmith/blueflood/stargazers","contributors_url":"https://api.github.com/repos/shintasmith/blueflood/contributors","subscribers_url":"https://api.github.com/repos/shintasmith/blueflood/subscribers","subscription_url":"https://api.github.com/repos/shintasmith/blueflood/subscription","commits_url":"https://api.github.com/repos/shintasmith/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/shintasmith/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/shintasmith/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/shintasmith/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/shintasmith/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/shintasmith/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shintasmith/blueflood/merges","archive_url":"https://api.github.com/repos/shintasmith/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shintasmith/blueflood/downloads","issues_url":"https://api.github.com/repos/shintasmith/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/shintasmith/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/shintasmith/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/shintasmith/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shintasmith/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/shintasmith/blueflood/releases{/id}","deployments_url":"https://api.github.com/repos/shintasmith/blueflood/deployments","created_at":"2015-11-09T19:22:42Z","updated_at":"2016-01-12T19:55:23Z","pushed_at":"2016-01-27T20:55:08Z","git_url":"git://github.com/shintasmith/blueflood.git","ssh_url":"git@github.com:shintasmith/blueflood.git","clone_url":"https://github.com/shintasmith/blueflood.git","svn_url":"https://github.com/shintasmith/blueflood","homepage":"http://www.blueflood.io","size":8892,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"081f53f6d70190c221b3b8b841a6c0783ff18377","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":10081109,"name":"blueflood","full_name":"rackerlabs/blueflood","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/blueflood","description":"A distributed system designed to ingest and process time series data","fork":false,"url":"https://api.github.com/repos/rackerlabs/blueflood","forks_url":"https://api.github.com/repos/rackerlabs/blueflood/forks","keys_url":"https://api.github.com/repos/rackerlabs/blueflood/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/blueflood/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/blueflood/teams","hooks_url":"https://api.github.com/repos/rackerlabs/blueflood/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/blueflood/events","assignees_url":"https://api.github.com/repos/rackerlabs/blueflood/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/blueflood/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/blueflood/tags","blobs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/blueflood/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/blueflood/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/blueflood/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/blueflood/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/blueflood/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/blueflood/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/blueflood/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/blueflood/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/blueflood/subscription","commits_url":"https://api.github.com/repos/rackerlabs/blueflood/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/blueflood/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/blueflood/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/blueflood/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/blueflood/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/blueflood/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/blueflood/merges","archive_url":"https://api.github.com/repos/rackerlabs/blueflood/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/blueflood/downloads","issues_url":"https://api.github.com/repos/rackerlabs/blueflood/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/blueflood/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/blueflood/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/blueflood/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/blueflood/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/blueflood/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/blueflood/deployments","created_at":"2013-05-15T14:50:39Z","updated_at":"2016-01-26T15:05:44Z","pushed_at":"2016-01-27T16:37:30Z","git_url":"git://github.com/rackerlabs/blueflood.git","ssh_url":"git@github.com:rackerlabs/blueflood.git","clone_url":"https://github.com/rackerlabs/blueflood.git","svn_url":"https://github.com/rackerlabs/blueflood","homepage":"http://www.blueflood.io","size":12118,"stargazers_count":404,"watchers_count":404,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":29,"forks":51,"open_issues":29,"watchers":404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/603"},"html":{"href":"https://github.com/rackerlabs/blueflood/pull/603"},"issue":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/603"},"comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/issues/603/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/603/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/blueflood/pulls/603/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/blueflood/statuses/6c81eccb0590ca4c45648f3a1f17449240bea8e5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":316,"deletions":127,"changed_files":8}}