{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/85042834","pull_request_review_id":5781625,"id":85042834,"diff_hunk":"@@ -0,0 +1,14 @@\n+{{- if .Values.Persistence.Datadir.Enabled -}}\n+kind: PersistentVolumeClaim\n+apiVersion: v1\n+metadata:\n+  name: {{ template \"fullname\" . }}-datadir\n+  annotations:\n+    volume.alpha.kubernetes.io/storage-class: {{ .Values.Persistence.StorageClass | quote }}","path":"incubator/minecraft/templates/datadir-pvc.yaml","position":7,"original_position":7,"commit_id":"5a0505730d5dbbfd94942b21967a909959766eb1","original_commit_id":"5a0505730d5dbbfd94942b21967a909959766eb1","user":{"login":"gtaylor","id":75556,"avatar_url":"https://avatars.githubusercontent.com/u/75556?v=3","gravatar_id":"","url":"https://api.github.com/users/gtaylor","html_url":"https://github.com/gtaylor","followers_url":"https://api.github.com/users/gtaylor/followers","following_url":"https://api.github.com/users/gtaylor/following{/other_user}","gists_url":"https://api.github.com/users/gtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/gtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtaylor/subscriptions","organizations_url":"https://api.github.com/users/gtaylor/orgs","repos_url":"https://api.github.com/users/gtaylor/repos","events_url":"https://api.github.com/users/gtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/gtaylor/received_events","type":"User","site_admin":false},"body":"The only scenario I can think of where you wouldn't want persistence is in testing. You can disable the PVC and use an emptyDir by setting `Values.Persistence.Datadir.Enabled` to false in the event that you don't.","created_at":"2016-10-26T03:10:37Z","updated_at":"2016-10-26T03:10:38Z","html_url":"https://github.com/kubernetes/charts/pull/154#discussion_r85042834","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/85042834"},"html":{"href":"https://github.com/kubernetes/charts/pull/154#discussion_r85042834"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/154","id":90749977,"html_url":"https://github.com/kubernetes/charts/pull/154","diff_url":"https://github.com/kubernetes/charts/pull/154.diff","patch_url":"https://github.com/kubernetes/charts/pull/154.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/154","number":154,"state":"open","locked":false,"title":"Add minecraft chart to incubator.","user":{"login":"gtaylor","id":75556,"avatar_url":"https://avatars.githubusercontent.com/u/75556?v=3","gravatar_id":"","url":"https://api.github.com/users/gtaylor","html_url":"https://github.com/gtaylor","followers_url":"https://api.github.com/users/gtaylor/followers","following_url":"https://api.github.com/users/gtaylor/following{/other_user}","gists_url":"https://api.github.com/users/gtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/gtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtaylor/subscriptions","organizations_url":"https://api.github.com/users/gtaylor/orgs","repos_url":"https://api.github.com/users/gtaylor/repos","events_url":"https://api.github.com/users/gtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/gtaylor/received_events","type":"User","site_admin":false},"body":"Surprise!","created_at":"2016-10-25T07:06:11Z","updated_at":"2016-10-26T03:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ef106c35bcaca9b43673abf2e0374193e2e55d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/154/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/154/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/154/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/5a0505730d5dbbfd94942b21967a909959766eb1","head":{"label":"gtaylor:minecraft","ref":"minecraft","sha":"5a0505730d5dbbfd94942b21967a909959766eb1","user":{"login":"gtaylor","id":75556,"avatar_url":"https://avatars.githubusercontent.com/u/75556?v=3","gravatar_id":"","url":"https://api.github.com/users/gtaylor","html_url":"https://github.com/gtaylor","followers_url":"https://api.github.com/users/gtaylor/followers","following_url":"https://api.github.com/users/gtaylor/following{/other_user}","gists_url":"https://api.github.com/users/gtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/gtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtaylor/subscriptions","organizations_url":"https://api.github.com/users/gtaylor/orgs","repos_url":"https://api.github.com/users/gtaylor/repos","events_url":"https://api.github.com/users/gtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/gtaylor/received_events","type":"User","site_admin":false},"repo":{"id":71616222,"name":"charts","full_name":"gtaylor/charts","owner":{"login":"gtaylor","id":75556,"avatar_url":"https://avatars.githubusercontent.com/u/75556?v=3","gravatar_id":"","url":"https://api.github.com/users/gtaylor","html_url":"https://github.com/gtaylor","followers_url":"https://api.github.com/users/gtaylor/followers","following_url":"https://api.github.com/users/gtaylor/following{/other_user}","gists_url":"https://api.github.com/users/gtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/gtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtaylor/subscriptions","organizations_url":"https://api.github.com/users/gtaylor/orgs","repos_url":"https://api.github.com/users/gtaylor/repos","events_url":"https://api.github.com/users/gtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/gtaylor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtaylor/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/gtaylor/charts","forks_url":"https://api.github.com/repos/gtaylor/charts/forks","keys_url":"https://api.github.com/repos/gtaylor/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtaylor/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtaylor/charts/teams","hooks_url":"https://api.github.com/repos/gtaylor/charts/hooks","issue_events_url":"https://api.github.com/repos/gtaylor/charts/issues/events{/number}","events_url":"https://api.github.com/repos/gtaylor/charts/events","assignees_url":"https://api.github.com/repos/gtaylor/charts/assignees{/user}","branches_url":"https://api.github.com/repos/gtaylor/charts/branches{/branch}","tags_url":"https://api.github.com/repos/gtaylor/charts/tags","blobs_url":"https://api.github.com/repos/gtaylor/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtaylor/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtaylor/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtaylor/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtaylor/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/gtaylor/charts/languages","stargazers_url":"https://api.github.com/repos/gtaylor/charts/stargazers","contributors_url":"https://api.github.com/repos/gtaylor/charts/contributors","subscribers_url":"https://api.github.com/repos/gtaylor/charts/subscribers","subscription_url":"https://api.github.com/repos/gtaylor/charts/subscription","commits_url":"https://api.github.com/repos/gtaylor/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtaylor/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtaylor/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtaylor/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtaylor/charts/contents/{+path}","compare_url":"https://api.github.com/repos/gtaylor/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtaylor/charts/merges","archive_url":"https://api.github.com/repos/gtaylor/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtaylor/charts/downloads","issues_url":"https://api.github.com/repos/gtaylor/charts/issues{/number}","pulls_url":"https://api.github.com/repos/gtaylor/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/gtaylor/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/gtaylor/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtaylor/charts/labels{/name}","releases_url":"https://api.github.com/repos/gtaylor/charts/releases{/id}","deployments_url":"https://api.github.com/repos/gtaylor/charts/deployments","created_at":"2016-10-22T04:16:13Z","updated_at":"2016-10-22T04:16:15Z","pushed_at":"2016-10-26T00:32:08Z","git_url":"git://github.com/gtaylor/charts.git","ssh_url":"git@github.com:gtaylor/charts.git","clone_url":"https://github.com/gtaylor/charts.git","svn_url":"https://github.com/gtaylor/charts","homepage":"","size":284,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"da8b5624f4e06d6e59221f6a86a7de0e7d575ce0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2016-10-25T01:33:31Z","pushed_at":"2016-10-26T03:10:26Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":670,"stargazers_count":101,"watchers_count":101,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":31,"forks":69,"open_issues":31,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/154"},"html":{"href":"https://github.com/kubernetes/charts/pull/154"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/154"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/5a0505730d5dbbfd94942b21967a909959766eb1"}}}}
{"actor":{"display_login":"gtaylor"}}