{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/73687804","id":73687804,"diff_hunk":"@@ -286,10 +286,13 @@ def c_lib_dirs(self):\n     def do_constant_folding(self, node):\n         return False\n \n-    def __init__(self, border_mode, subsample=(1, 1), conv_mode='conv',\n-                 precision=\"float32\"):\n+    def __init__(self):\n         COp.__init__(self, [\"conv_desc.c\"], \"APPLY_SPECIFIC(conv_desc)\")\n \n+    def make_node(self, kern_shape, border_mode, subsample=(1, 1), conv_mode='conv', precision=\"float32\"):\n+        if kern_shape.type.ndim != 1 or kern_shape.type.dtype != 'int64':\n+            raise TypeError('kern must be 1D shape tensor')","path":"theano/gpuarray/dnn.py","position":11,"original_position":11,"commit_id":"009867d2a1cc251c956556044ac34730f3716b77","original_commit_id":"009867d2a1cc251c956556044ac34730f3716b77","user":{"login":"gokul-uf","id":5398125,"avatar_url":"https://avatars.githubusercontent.com/u/5398125?v=3","gravatar_id":"","url":"https://api.github.com/users/gokul-uf","html_url":"https://github.com/gokul-uf","followers_url":"https://api.github.com/users/gokul-uf/followers","following_url":"https://api.github.com/users/gokul-uf/following{/other_user}","gists_url":"https://api.github.com/users/gokul-uf/gists{/gist_id}","starred_url":"https://api.github.com/users/gokul-uf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokul-uf/subscriptions","organizations_url":"https://api.github.com/users/gokul-uf/orgs","repos_url":"https://api.github.com/users/gokul-uf/repos","events_url":"https://api.github.com/users/gokul-uf/events{/privacy}","received_events_url":"https://api.github.com/users/gokul-uf/received_events","type":"User","site_admin":false},"body":"This message was present in the codebase even before I got to work. What do you suggest the message should be?","created_at":"2016-08-05T12:59:53Z","updated_at":"2016-08-05T12:59:53Z","html_url":"https://github.com/Theano/Theano/pull/4765#discussion_r73687804","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4765","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/73687804"},"html":{"href":"https://github.com/Theano/Theano/pull/4765#discussion_r73687804"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4765"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4765","id":78058878,"html_url":"https://github.com/Theano/Theano/pull/4765","diff_url":"https://github.com/Theano/Theano/pull/4765.diff","patch_url":"https://github.com/Theano/Theano/pull/4765.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4765","number":4765,"state":"open","locked":false,"title":"[WIP] Reduce C code generated when using GpuDnnConvDesc","user":{"login":"gokul-uf","id":5398125,"avatar_url":"https://avatars.githubusercontent.com/u/5398125?v=3","gravatar_id":"","url":"https://api.github.com/users/gokul-uf","html_url":"https://github.com/gokul-uf","followers_url":"https://api.github.com/users/gokul-uf/followers","following_url":"https://api.github.com/users/gokul-uf/following{/other_user}","gists_url":"https://api.github.com/users/gokul-uf/gists{/gist_id}","starred_url":"https://api.github.com/users/gokul-uf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokul-uf/subscriptions","organizations_url":"https://api.github.com/users/gokul-uf/orgs","repos_url":"https://api.github.com/users/gokul-uf/repos","events_url":"https://api.github.com/users/gokul-uf/events{/privacy}","received_events_url":"https://api.github.com/users/gokul-uf/received_events","type":"User","site_admin":false},"body":"This is a continuation of PR #4638. I've made the commits a bit more clean.\r\nTODO: to what number should I increment the c_cache_version to?\r\n\r\nnosetests theano/gpuarray/test_dnn.py fails with the following output.\r\n (a part of it)\r\n```\r\n======================================================================\r\nERROR: theano.gpuarray.tests.test_dnn.test_dnn_conv_grad\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python2.7/dist-packages/nose/case.py\", line 197, in runTest\r\n    self.test(*self.arg)\r\n  File \"/home/gokul/Theano/theano/gpuarray/tests/test_dnn.py\", line 763, in test_dnn_conv_grad\r\n    utt.verify_grad(dconv, [img_val, kern_val, out_val])\r\n  File \"/home/gokul/Theano/theano/tests/unittest_tools.py\", line 91, in verify_grad\r\n    T.verify_grad(op, pt, n_tests, rng, *args, **kwargs)\r\n  File \"/home/gokul/Theano/theano/gradient.py\", line 1654, in verify_grad\r\n    o_fn = function(tensor_pt, o_output, name='gradient.py fwd')\r\n  File \"/home/gokul/Theano/theano/gradient.py\", line 1635, in function\r\n    on_unused_input='ignore', name=name)\r\n  File \"/home/gokul/Theano/theano/compile/function.py\", line 322, in function\r\n    output_keys=output_keys)\r\n  File \"/home/gokul/Theano/theano/compile/pfunc.py\", line 480, in pfunc\r\n    output_keys=output_keys)\r\n  File \"/home/gokul/Theano/theano/compile/function_module.py\", line 1784, in orig_function\r\n    defaults)\r\n  File \"/home/gokul/Theano/theano/compile/function_module.py\", line 1648, in create\r\n    input_storage=input_storage_lists, storage_map=storage_map)\r\n  File \"/home/gokul/Theano/theano/gof/link.py\", line 699, in make_thunk\r\n    storage_map=storage_map)[:3]\r\n  File \"/home/gokul/Theano/theano/gof/vm.py\", line 1042, in make_all\r\n    no_recycling))\r\n  File \"/home/gokul/Theano/theano/gof/op.py\", line 975, in make_thunk\r\n    no_recycling)\r\n  File \"/home/gokul/Theano/theano/gof/op.py\", line 875, in make_c_thunk\r\n    output_storage=node_output_storage)\r\n  File \"/home/gokul/Theano/theano/gof/cc.py\", line 1189, in make_thunk\r\n    keep_lock=keep_lock)\r\n  File \"/home/gokul/Theano/theano/gof/cc.py\", line 1130, in __compile__\r\n    keep_lock=keep_lock)\r\n  File \"/home/gokul/Theano/theano/gof/cc.py\", line 1585, in cthunk_factory\r\n    key=key, lnk=self, keep_lock=keep_lock)\r\n  File \"/home/gokul/Theano/theano/gof/cmodule.py\", line 1145, in module_from_key\r\n    module = lnk.compile_cmodule(location)\r\n  File \"/home/gokul/Theano/theano/gof/cc.py\", line 1491, in compile_cmodule\r\n    preargs=preargs)\r\n  File \"/home/gokul/Theano/theano/gof/cmodule.py\", line 2299, in compile_str\r\n    (status, compile_stderr.replace('\\n', '. ')))\r\nException: ('The following error happened while compiling the node', GpuDnnConvDesc(MakeVector{dtype='int64'}.0, TensorConstant{(3,) of 0}, TensorConstant{[1 1 0]}, TensorConstant{0}, TensorConstant{32}, TensorConstant{1}, TensorConstant{3}), '\\n', 'Compilation failed (return status=1): /home/gokul/.theano/compiledir_Linux-3.19--generic-x86_64-with-Ubuntu-14.04-trusty-x86_64-2.7.6-64/tmpb60Wnv/mod.cpp: In member function \\xe2\\x80\\x98int {anonymous}::__struct_compiled_op_ec8795bee5233416784c277810d57ff0::run()\\xe2\\x80\\x99:. /home/gokul/.theano/compiledir_Linux-3.19--generic-x86_64-with-Ubuntu-14.04-trusty-x86_64-2.7.6-64/tmpb60Wnv/mod.cpp:893:83: error: cannot convert \\xe2\\x80\\x98PyArrayObject* {aka tagPyArrayObject*}\\xe2\\x80\\x99 to \\xe2\\x80\\x98PyObject* {aka _object*}\\xe2\\x80\\x99 for argument \\xe2\\x80\\x984\\xe2\\x80\\x99 to \\xe2\\x80\\x98int conv_desc_node_ec8795bee5233416784c277810d57ff0_0(PyArrayObject*, PyArrayObject*, PyArrayObject*, PyObject*, PyObject*, PyObject*, PyObject*, cudnnConvolutionStruct**)\\xe2\\x80\\x99.                    if (APPLY_SPECIFIC(conv_desc)(V3, V5, V7, V9, V11, V13, V15, &V1) != 0) {.                                                                                    ^. ', '[GpuDnnConvDesc(<TensorType(int64, vector)>, TensorConstant{(3,) of 0}, TensorConstant{[1 1 0]}, TensorConstant{0}, TensorConstant{32}, TensorConstant{1}, TensorConstant{3})]')\r\n-------------------- >> begin captured stdout << ---------------------\r\n===============================\r\n===============================\r\n/home/gokul/.theano/compiledir_Linux-3.19--generic-x86_64-with-Ubuntu-14.04-trusty-x86_64-2.7.6-64/tmpb60Wnv/mod.cpp: In member function \\u2018int {anonymous}::__struct_compiled_op_ec8795bee5233416784c277810d57ff0::run()\\u2019:\r\n/home/gokul/.theano/compiledir_Linux-3.19--generic-x86_64-with-Ubuntu-14.04-trusty-x86_64-2.7.6-64/tmpb60Wnv/mod.cpp:893:83: error: cannot convert \\u2018PyArrayObject* {aka tagPyArrayObject*}\\u2019 to \\u2018PyObject* {aka _object*}\\u2019 for argument \\u20184\\u2019 to \\u2018int conv_desc_node_ec8795bee5233416784c277810d57ff0_0(PyArrayObject*, PyArrayObject*, PyArrayObject*, PyObject*, PyObject*, PyObject*, PyObject*, cudnnConvolutionStruct**)\\u2019\r\n                   if (APPLY_SPECIFIC(conv_desc)(V3, V5, V7, V9, V11, V13, V15, &V1) != 0) {\r\n                                                                                   ^\r\n\r\n\r\n--------------------- >> end captured stdout << ----------------------\r\n```","created_at":"2016-07-19T22:15:58Z","updated_at":"2016-08-05T12:59:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"241d986385dfa57b6dcb6b38f677223d3fa1a7fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4765/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4765/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4765/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/009867d2a1cc251c956556044ac34730f3716b77","head":{"label":"gokul-uf:clean_reduce_gpu","ref":"clean_reduce_gpu","sha":"009867d2a1cc251c956556044ac34730f3716b77","user":{"login":"gokul-uf","id":5398125,"avatar_url":"https://avatars.githubusercontent.com/u/5398125?v=3","gravatar_id":"","url":"https://api.github.com/users/gokul-uf","html_url":"https://github.com/gokul-uf","followers_url":"https://api.github.com/users/gokul-uf/followers","following_url":"https://api.github.com/users/gokul-uf/following{/other_user}","gists_url":"https://api.github.com/users/gokul-uf/gists{/gist_id}","starred_url":"https://api.github.com/users/gokul-uf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokul-uf/subscriptions","organizations_url":"https://api.github.com/users/gokul-uf/orgs","repos_url":"https://api.github.com/users/gokul-uf/repos","events_url":"https://api.github.com/users/gokul-uf/events{/privacy}","received_events_url":"https://api.github.com/users/gokul-uf/received_events","type":"User","site_admin":false},"repo":{"id":51005128,"name":"Theano","full_name":"gokul-uf/Theano","owner":{"login":"gokul-uf","id":5398125,"avatar_url":"https://avatars.githubusercontent.com/u/5398125?v=3","gravatar_id":"","url":"https://api.github.com/users/gokul-uf","html_url":"https://github.com/gokul-uf","followers_url":"https://api.github.com/users/gokul-uf/followers","following_url":"https://api.github.com/users/gokul-uf/following{/other_user}","gists_url":"https://api.github.com/users/gokul-uf/gists{/gist_id}","starred_url":"https://api.github.com/users/gokul-uf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokul-uf/subscriptions","organizations_url":"https://api.github.com/users/gokul-uf/orgs","repos_url":"https://api.github.com/users/gokul-uf/repos","events_url":"https://api.github.com/users/gokul-uf/events{/privacy}","received_events_url":"https://api.github.com/users/gokul-uf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gokul-uf/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/gokul-uf/Theano","forks_url":"https://api.github.com/repos/gokul-uf/Theano/forks","keys_url":"https://api.github.com/repos/gokul-uf/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gokul-uf/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gokul-uf/Theano/teams","hooks_url":"https://api.github.com/repos/gokul-uf/Theano/hooks","issue_events_url":"https://api.github.com/repos/gokul-uf/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/gokul-uf/Theano/events","assignees_url":"https://api.github.com/repos/gokul-uf/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/gokul-uf/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/gokul-uf/Theano/tags","blobs_url":"https://api.github.com/repos/gokul-uf/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gokul-uf/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gokul-uf/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/gokul-uf/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gokul-uf/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/gokul-uf/Theano/languages","stargazers_url":"https://api.github.com/repos/gokul-uf/Theano/stargazers","contributors_url":"https://api.github.com/repos/gokul-uf/Theano/contributors","subscribers_url":"https://api.github.com/repos/gokul-uf/Theano/subscribers","subscription_url":"https://api.github.com/repos/gokul-uf/Theano/subscription","commits_url":"https://api.github.com/repos/gokul-uf/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/gokul-uf/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/gokul-uf/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/gokul-uf/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/gokul-uf/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/gokul-uf/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gokul-uf/Theano/merges","archive_url":"https://api.github.com/repos/gokul-uf/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gokul-uf/Theano/downloads","issues_url":"https://api.github.com/repos/gokul-uf/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/gokul-uf/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/gokul-uf/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/gokul-uf/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gokul-uf/Theano/labels{/name}","releases_url":"https://api.github.com/repos/gokul-uf/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/gokul-uf/Theano/deployments","created_at":"2016-02-03T14:32:14Z","updated_at":"2016-02-03T14:32:17Z","pushed_at":"2016-07-26T09:18:17Z","git_url":"git://github.com/gokul-uf/Theano.git","ssh_url":"git@github.com:gokul-uf/Theano.git","clone_url":"https://github.com/gokul-uf/Theano.git","svn_url":"https://github.com/gokul-uf/Theano","homepage":"http://www.deeplearning.net/software/theano","size":57266,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"e4e08782d3a10d010d3a99bc87fd0fc3b0465405","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-08-05T10:02:36Z","pushed_at":"2016-08-04T21:42:58Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":75495,"stargazers_count":4256,"watchers_count":4256,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1526,"mirror_url":null,"open_issues_count":738,"forks":1526,"open_issues":738,"watchers":4256,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4765"},"html":{"href":"https://github.com/Theano/Theano/pull/4765"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4765"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4765/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4765/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4765/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/009867d2a1cc251c956556044ac34730f3716b77"}}}}
{"actor":{"display_login":"gokul-uf"}}