{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/issues/79","repository_url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl","labels_url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/issues/79/comments","events_url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/issues/79/events","html_url":"https://github.com/JuliaLang/IterativeSolvers.jl/pull/79","id":168168623,"number":79,"title":"Add blas sugar and blas optimizations to methods","user":{"login":"lopezm94","id":14032787,"avatar_url":"https://avatars.githubusercontent.com/u/14032787?v=3","gravatar_id":"","url":"https://api.github.com/users/lopezm94","html_url":"https://github.com/lopezm94","followers_url":"https://api.github.com/users/lopezm94/followers","following_url":"https://api.github.com/users/lopezm94/following{/other_user}","gists_url":"https://api.github.com/users/lopezm94/gists{/gist_id}","starred_url":"https://api.github.com/users/lopezm94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopezm94/subscriptions","organizations_url":"https://api.github.com/users/lopezm94/orgs","repos_url":"https://api.github.com/users/lopezm94/repos","events_url":"https://api.github.com/users/lopezm94/events{/privacy}","received_events_url":"https://api.github.com/users/lopezm94/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-07-28T18:49:11Z","updated_at":"2016-08-14T19:19:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/pulls/79","html_url":"https://github.com/JuliaLang/IterativeSolvers.jl/pull/79","diff_url":"https://github.com/JuliaLang/IterativeSolvers.jl/pull/79.diff","patch_url":"https://github.com/JuliaLang/IterativeSolvers.jl/pull/79.patch"},"body":"In response to issue #16 and #26 here I add blas optimizations to cg and krylov orthogonalization. The new internal macro `@blas!` matches between `scal!`, `scal`, `axpy!` or `blascopy!` (each of them with added robustness). If there is people interested in some form of blas sugar I wouldn't mind making a new package.\r\n\r\n*Better to merge when the benchmarks are set*"},"comment":{"url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/issues/comments/239691228","html_url":"https://github.com/JuliaLang/IterativeSolvers.jl/pull/79#issuecomment-239691228","issue_url":"https://api.github.com/repos/JuliaLang/IterativeSolvers.jl/issues/79","id":239691228,"user":{"login":"lopezm94","id":14032787,"avatar_url":"https://avatars.githubusercontent.com/u/14032787?v=3","gravatar_id":"","url":"https://api.github.com/users/lopezm94","html_url":"https://github.com/lopezm94","followers_url":"https://api.github.com/users/lopezm94/followers","following_url":"https://api.github.com/users/lopezm94/following{/other_user}","gists_url":"https://api.github.com/users/lopezm94/gists{/gist_id}","starred_url":"https://api.github.com/users/lopezm94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lopezm94/subscriptions","organizations_url":"https://api.github.com/users/lopezm94/orgs","repos_url":"https://api.github.com/users/lopezm94/repos","events_url":"https://api.github.com/users/lopezm94/events{/privacy}","received_events_url":"https://api.github.com/users/lopezm94/received_events","type":"User","site_admin":false},"created_at":"2016-08-14T19:19:34Z","updated_at":"2016-08-14T19:19:34Z","body":"I think you are right, `@blas` is not necessary.\r\n\r\n```julia\r\njulia> using BenchmarkTools\r\n\r\njulia> a = 2.5;\r\n\r\njulia> X = rand(1000,1000);\r\n\r\njulia> @benchmark a*X\r\nBenchmarkTools.Trial: \r\n  samples:          770\r\n  evals/sample:     1\r\n  time tolerance:   5.00%\r\n  memory tolerance: 1.00%\r\n  memory estimate:  7.63 mb\r\n  allocs estimate:  2\r\n  minimum time:     1.16 ms (0.00% GC)\r\n  median time:      7.05 ms (0.00% GC)\r\n  mean time:        5.86 ms (0.00% GC)\r\n  maximum time:     15.91 ms (0.00% GC)\r\n\r\njulia> @benchmark scale(a,X)\r\nBenchmarkTools.Trial: \r\n  samples:          776\r\n  evals/sample:     1\r\n  time tolerance:   5.00%\r\n  memory tolerance: 1.00%\r\n  memory estimate:  7.63 mb\r\n  allocs estimate:  2\r\n  minimum time:     1.22 ms (0.00% GC)\r\n  median time:      6.88 ms (0.00% GC)\r\n  mean time:        5.80 ms (0.00% GC)\r\n  maximum time:     11.21 ms (0.00% GC)\r\n```"}}
{"actor":{"display_login":"lopezm94"}}