{"action":"created","issue":{"url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/80","repository_url":"https://api.github.com/repos/neos/Neos.Cqrs","labels_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/80/comments","events_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/80/events","html_url":"https://github.com/neos/Neos.Cqrs/issues/80","id":187585253,"number":80,"title":"Rename AbstractEventSourcedRepository->findByIdentifier()","user":{"login":"robertlemke","id":95582,"avatar_url":"https://avatars.githubusercontent.com/u/95582?v=3","gravatar_id":"","url":"https://api.github.com/users/robertlemke","html_url":"https://github.com/robertlemke","followers_url":"https://api.github.com/users/robertlemke/followers","following_url":"https://api.github.com/users/robertlemke/following{/other_user}","gists_url":"https://api.github.com/users/robertlemke/gists{/gist_id}","starred_url":"https://api.github.com/users/robertlemke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertlemke/subscriptions","organizations_url":"https://api.github.com/users/robertlemke/orgs","repos_url":"https://api.github.com/users/robertlemke/repos","events_url":"https://api.github.com/users/robertlemke/events{/privacy}","received_events_url":"https://api.github.com/users/robertlemke/received_events","type":"User","site_admin":false},"labels":[{"id":439849368,"url":"https://api.github.com/repos/neos/Neos.Cqrs/labels/I:%20Needs%20feedback","name":"I: Needs feedback","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-06T20:07:32Z","updated_at":"2016-11-07T10:36:04Z","closed_at":null,"body":"I think that the name of the method `findByIdentifier` in class `AbstractEventSourcedRepository` is inconsistent:\r\n\r\n- in the Projector we use `get()` instead\r\n- in other `find*` methods we would usually use `findOneByIdentifier`\r\n\r\nSince the event sourced repository should have any further finder methods anyway, I suggest that we rename the method to `get()`."},"comment":{"url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/comments/258801287","html_url":"https://github.com/neos/Neos.Cqrs/issues/80#issuecomment-258801287","issue_url":"https://api.github.com/repos/neos/Neos.Cqrs/issues/80","id":258801287,"user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T10:36:04Z","updated_at":"2016-11-07T10:36:04Z","body":"I agree to rename this to `get()` but we should also adjust it's behavior then:\r\nCurrently we [catch](https://github.com/neos/Neos.Cqrs/blob/master/Classes/EventStore/AbstractEventSourcedRepository.php#L68-L72) any `EventStreamNotFoundException` and return `null`. For `get` we should just throw the exception"}}
{"actor":{"display_login":"bwaidelich"}}