{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6114","repository_url":"https://api.github.com/repos/silverstripe/silverstripe-framework","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6114/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6114/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6114/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/6114","id":179935664,"number":6114,"title":"API Implement many_many through","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-09-29T02:08:10Z","updated_at":"2016-10-06T09:12:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/6114","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/6114","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/6114.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/6114.patch"},"body":"Fixes #5615\r\n\r\nMerge with CMS changes: https://github.com/silverstripe/silverstripe-cms/pull/1639\r\n\r\nThis change introduces a slight refactor in model relationship handling; Validation has been updated, and moved to DataObjectSchema.\r\n\r\nThe basic implementation of this feature is that a many_many relation now utilises a nested has_many relation, which is rewritten as a joined subquery within it in place of a join table.\r\n\r\nIn order to ensure that both has_many and many_many queries are joined, and independently augmented correctly, a ManyManyThroughQueryManipulator object has been implemented to merge them during `getFinalisedQuery()`.\r\n\r\nI've also taken advantage of the `::class` language feature in PHP 5.5 to replace some class literals.\r\n\r\nIncludes the following ORM changes:\r\n- API Remove DataObject::validateModelDefinitions, and move to DataObjectSchema\r\n- API Remove deprecated 3.0 syntax for addSelect()\r\n- API made DataList::createDataObject public\r\n- API Move component parsing logic to DataObjectSchema\r\n- API Remove support for triangular has_many / belongs_many relationships"},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/251908278","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/6114#issuecomment-251908278","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/6114","id":251908278,"user":{"login":"kinglozzer","id":1655548,"avatar_url":"https://avatars.githubusercontent.com/u/1655548?v=3","gravatar_id":"","url":"https://api.github.com/users/kinglozzer","html_url":"https://github.com/kinglozzer","followers_url":"https://api.github.com/users/kinglozzer/followers","following_url":"https://api.github.com/users/kinglozzer/following{/other_user}","gists_url":"https://api.github.com/users/kinglozzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kinglozzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinglozzer/subscriptions","organizations_url":"https://api.github.com/users/kinglozzer/orgs","repos_url":"https://api.github.com/users/kinglozzer/repos","events_url":"https://api.github.com/users/kinglozzer/events{/privacy}","received_events_url":"https://api.github.com/users/kinglozzer/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T09:12:07Z","updated_at":"2016-10-06T09:12:07Z","body":"Reviewed the new commit, nothing merge blocking 👍 "}}
{"actor":{"display_login":"kinglozzer"}}