{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/comments/92053136","pull_request_review_id":12563027,"id":92053136,"diff_hunk":"@@ -185,11 +185,12 @@ var get_data = function() {\n     transformData = data;\n \n     var slider = document.getElementById('slider');\n-    slider.noUiSlider.on('update', function( values, handle ) {\n-  \t  var year = \"\" + Math.round(values[handle]);\n-    \tsetYear(year);\n-    });\n-\n+    if(slider.noUiSlider){","path":"layout/js/map.js","position":9,"original_position":9,"commit_id":"c5f4f5bafe7fc7f4eb8a41565501e19a43da9579","original_commit_id":"c5f4f5bafe7fc7f4eb8a41565501e19a43da9579","user":{"login":"jiwalker-usgs","id":1173041,"avatar_url":"https://avatars.githubusercontent.com/u/1173041?v=3","gravatar_id":"","url":"https://api.github.com/users/jiwalker-usgs","html_url":"https://github.com/jiwalker-usgs","followers_url":"https://api.github.com/users/jiwalker-usgs/followers","following_url":"https://api.github.com/users/jiwalker-usgs/following{/other_user}","gists_url":"https://api.github.com/users/jiwalker-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/jiwalker-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiwalker-usgs/subscriptions","organizations_url":"https://api.github.com/users/jiwalker-usgs/orgs","repos_url":"https://api.github.com/users/jiwalker-usgs/repos","events_url":"https://api.github.com/users/jiwalker-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/jiwalker-usgs/received_events","type":"User","site_admin":false},"body":"That is probably fine, there is no Ajax involved on that side.","created_at":"2016-12-12T22:15:06Z","updated_at":"2016-12-12T22:15:06Z","html_url":"https://github.com/USGS-VIZLAB/water-use/pull/187#discussion_r92053136","pull_request_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/comments/92053136"},"html":{"href":"https://github.com/USGS-VIZLAB/water-use/pull/187#discussion_r92053136"},"pull_request":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187","id":97642206,"html_url":"https://github.com/USGS-VIZLAB/water-use/pull/187","diff_url":"https://github.com/USGS-VIZLAB/water-use/pull/187.diff","patch_url":"https://github.com/USGS-VIZLAB/water-use/pull/187.patch","issue_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues/187","number":187,"state":"open","locked":false,"title":"fix loading issue?","user":{"login":"wdwatkins","id":13987349,"avatar_url":"https://avatars.githubusercontent.com/u/13987349?v=3","gravatar_id":"","url":"https://api.github.com/users/wdwatkins","html_url":"https://github.com/wdwatkins","followers_url":"https://api.github.com/users/wdwatkins/followers","following_url":"https://api.github.com/users/wdwatkins/following{/other_user}","gists_url":"https://api.github.com/users/wdwatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/wdwatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdwatkins/subscriptions","organizations_url":"https://api.github.com/users/wdwatkins/orgs","repos_url":"https://api.github.com/users/wdwatkins/repos","events_url":"https://api.github.com/users/wdwatkins/events{/privacy}","received_events_url":"https://api.github.com/users/wdwatkins/received_events","type":"User","site_admin":false},"body":"@jiwalker-usgs review?  I can't recreate the loading problem locally, but this doesn't break it at least.    The problem looks to be the slider object not existing. \r\n\r\nOr should it be just `if(slider){` ?","created_at":"2016-12-12T21:58:11Z","updated_at":"2016-12-12T22:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65066b0e52a7c99d6c5806010c176938aae1c2c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187/commits","review_comments_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187/comments","review_comment_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues/187/comments","statuses_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/statuses/c5f4f5bafe7fc7f4eb8a41565501e19a43da9579","head":{"label":"wdwatkins:master","ref":"master","sha":"c5f4f5bafe7fc7f4eb8a41565501e19a43da9579","user":{"login":"wdwatkins","id":13987349,"avatar_url":"https://avatars.githubusercontent.com/u/13987349?v=3","gravatar_id":"","url":"https://api.github.com/users/wdwatkins","html_url":"https://github.com/wdwatkins","followers_url":"https://api.github.com/users/wdwatkins/followers","following_url":"https://api.github.com/users/wdwatkins/following{/other_user}","gists_url":"https://api.github.com/users/wdwatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/wdwatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdwatkins/subscriptions","organizations_url":"https://api.github.com/users/wdwatkins/orgs","repos_url":"https://api.github.com/users/wdwatkins/repos","events_url":"https://api.github.com/users/wdwatkins/events{/privacy}","received_events_url":"https://api.github.com/users/wdwatkins/received_events","type":"User","site_admin":false},"repo":{"id":75215571,"name":"water-use","full_name":"wdwatkins/water-use","owner":{"login":"wdwatkins","id":13987349,"avatar_url":"https://avatars.githubusercontent.com/u/13987349?v=3","gravatar_id":"","url":"https://api.github.com/users/wdwatkins","html_url":"https://github.com/wdwatkins","followers_url":"https://api.github.com/users/wdwatkins/followers","following_url":"https://api.github.com/users/wdwatkins/following{/other_user}","gists_url":"https://api.github.com/users/wdwatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/wdwatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdwatkins/subscriptions","organizations_url":"https://api.github.com/users/wdwatkins/orgs","repos_url":"https://api.github.com/users/wdwatkins/repos","events_url":"https://api.github.com/users/wdwatkins/events{/privacy}","received_events_url":"https://api.github.com/users/wdwatkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wdwatkins/water-use","description":"Visualization using USGS water use data.","fork":true,"url":"https://api.github.com/repos/wdwatkins/water-use","forks_url":"https://api.github.com/repos/wdwatkins/water-use/forks","keys_url":"https://api.github.com/repos/wdwatkins/water-use/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdwatkins/water-use/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdwatkins/water-use/teams","hooks_url":"https://api.github.com/repos/wdwatkins/water-use/hooks","issue_events_url":"https://api.github.com/repos/wdwatkins/water-use/issues/events{/number}","events_url":"https://api.github.com/repos/wdwatkins/water-use/events","assignees_url":"https://api.github.com/repos/wdwatkins/water-use/assignees{/user}","branches_url":"https://api.github.com/repos/wdwatkins/water-use/branches{/branch}","tags_url":"https://api.github.com/repos/wdwatkins/water-use/tags","blobs_url":"https://api.github.com/repos/wdwatkins/water-use/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdwatkins/water-use/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdwatkins/water-use/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdwatkins/water-use/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdwatkins/water-use/statuses/{sha}","languages_url":"https://api.github.com/repos/wdwatkins/water-use/languages","stargazers_url":"https://api.github.com/repos/wdwatkins/water-use/stargazers","contributors_url":"https://api.github.com/repos/wdwatkins/water-use/contributors","subscribers_url":"https://api.github.com/repos/wdwatkins/water-use/subscribers","subscription_url":"https://api.github.com/repos/wdwatkins/water-use/subscription","commits_url":"https://api.github.com/repos/wdwatkins/water-use/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdwatkins/water-use/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdwatkins/water-use/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdwatkins/water-use/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdwatkins/water-use/contents/{+path}","compare_url":"https://api.github.com/repos/wdwatkins/water-use/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdwatkins/water-use/merges","archive_url":"https://api.github.com/repos/wdwatkins/water-use/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdwatkins/water-use/downloads","issues_url":"https://api.github.com/repos/wdwatkins/water-use/issues{/number}","pulls_url":"https://api.github.com/repos/wdwatkins/water-use/pulls{/number}","milestones_url":"https://api.github.com/repos/wdwatkins/water-use/milestones{/number}","notifications_url":"https://api.github.com/repos/wdwatkins/water-use/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdwatkins/water-use/labels{/name}","releases_url":"https://api.github.com/repos/wdwatkins/water-use/releases{/id}","deployments_url":"https://api.github.com/repos/wdwatkins/water-use/deployments","created_at":"2016-11-30T18:34:46Z","updated_at":"2016-12-02T20:07:37Z","pushed_at":"2016-12-12T21:56:19Z","git_url":"git://github.com/wdwatkins/water-use.git","ssh_url":"git@github.com:wdwatkins/water-use.git","clone_url":"https://github.com/wdwatkins/water-use.git","svn_url":"https://github.com/wdwatkins/water-use","homepage":null,"size":741,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-VIZLAB:master","ref":"master","sha":"3d1b23e00029e234e0dd18de74c2bb3f8283e006","user":{"login":"USGS-VIZLAB","id":18291557,"avatar_url":"https://avatars.githubusercontent.com/u/18291557?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-VIZLAB","html_url":"https://github.com/USGS-VIZLAB","followers_url":"https://api.github.com/users/USGS-VIZLAB/followers","following_url":"https://api.github.com/users/USGS-VIZLAB/following{/other_user}","gists_url":"https://api.github.com/users/USGS-VIZLAB/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-VIZLAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-VIZLAB/subscriptions","organizations_url":"https://api.github.com/users/USGS-VIZLAB/orgs","repos_url":"https://api.github.com/users/USGS-VIZLAB/repos","events_url":"https://api.github.com/users/USGS-VIZLAB/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-VIZLAB/received_events","type":"Organization","site_admin":false},"repo":{"id":75201495,"name":"water-use","full_name":"USGS-VIZLAB/water-use","owner":{"login":"USGS-VIZLAB","id":18291557,"avatar_url":"https://avatars.githubusercontent.com/u/18291557?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-VIZLAB","html_url":"https://github.com/USGS-VIZLAB","followers_url":"https://api.github.com/users/USGS-VIZLAB/followers","following_url":"https://api.github.com/users/USGS-VIZLAB/following{/other_user}","gists_url":"https://api.github.com/users/USGS-VIZLAB/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-VIZLAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-VIZLAB/subscriptions","organizations_url":"https://api.github.com/users/USGS-VIZLAB/orgs","repos_url":"https://api.github.com/users/USGS-VIZLAB/repos","events_url":"https://api.github.com/users/USGS-VIZLAB/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-VIZLAB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-VIZLAB/water-use","description":"Visualization using USGS water use data.","fork":false,"url":"https://api.github.com/repos/USGS-VIZLAB/water-use","forks_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/forks","keys_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/teams","hooks_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/hooks","issue_events_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/events","assignees_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/tags","blobs_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/languages","stargazers_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/stargazers","contributors_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/contributors","subscribers_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/subscribers","subscription_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/subscription","commits_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/merges","archive_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/downloads","issues_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/labels{/name}","releases_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-VIZLAB/water-use/deployments","created_at":"2016-11-30T15:44:28Z","updated_at":"2016-12-02T17:06:33Z","pushed_at":"2016-12-12T21:58:11Z","git_url":"git://github.com/USGS-VIZLAB/water-use.git","ssh_url":"git@github.com:USGS-VIZLAB/water-use.git","clone_url":"https://github.com/USGS-VIZLAB/water-use.git","svn_url":"https://github.com/USGS-VIZLAB/water-use","homepage":null,"size":787,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187"},"html":{"href":"https://github.com/USGS-VIZLAB/water-use/pull/187"},"issue":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues/187"},"comments":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-VIZLAB/water-use/statuses/c5f4f5bafe7fc7f4eb8a41565501e19a43da9579"}}}}
{"actor":{"display_login":"jiwalker-usgs"}}