{"action":"created","comment":{"url":"https://api.github.com/repos/openstax/os-webview/pulls/comments/52628356","id":52628356,"diff_hunk":"@@ -1,5 +1,41 @@\n @import 'variables';\n \n+@mixin small { // <= 640\n+    @media (max-width: #{breakpoints(small)}) {\n+        @content;\n+    }\n+}\n+\n+@mixin medium {\t// 641 - 768\n+    @media (min-width: #{breakpoints(small) + 1}) and (max-width: #{breakpoints(medium)}) {\n+        @content;\n+    }\n+}\n+\n+@mixin medium-up { // >= 641\n+    @media (min-width: #{breakpoints(small) + 1}) {\n+        @content;\n+    }\n+}\n+\n+@mixin medium-down { // <= 767\n+    @media (max-width: #{breakpoints(medium) - 1}) {\n+        @content;\n+    }\n+}\n+\n+@mixin large { // >= 1024\n+    @media (min-width: #{breakpoints(large)}) {\n+        @content;\n+    }\n+}\n+\n+@mixin large-up { // >= 769\n+    @media (min-width: #{breakpoints(medium) + 1}) {\n+        @content;\n+    }\n+}","path":"src/styles/mixins/responsive.scss","position":37,"original_position":37,"commit_id":"c6efc4d70a92093486e4b8dd7fdcdaf390b626c9","original_commit_id":"c6efc4d70a92093486e4b8dd7fdcdaf390b626c9","user":{"login":"dak","id":1371232,"avatar_url":"https://avatars.githubusercontent.com/u/1371232?v=3","gravatar_id":"","url":"https://api.github.com/users/dak","html_url":"https://github.com/dak","followers_url":"https://api.github.com/users/dak/followers","following_url":"https://api.github.com/users/dak/following{/other_user}","gists_url":"https://api.github.com/users/dak/gists{/gist_id}","starred_url":"https://api.github.com/users/dak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dak/subscriptions","organizations_url":"https://api.github.com/users/dak/orgs","repos_url":"https://api.github.com/users/dak/repos","events_url":"https://api.github.com/users/dak/events{/privacy}","received_events_url":"https://api.github.com/users/dak/received_events","type":"User","site_admin":false},"body":"There's so many breakpoints here I think they're losing their usefulness.  I don't know about you, but I don't think I have a good enough memory to keep so many in my head.  They also seem to be a bit arbitrary, and there's some gaps (for example, `medium-down` cover <= 767, while `large-up` covers >= 769, which leaves 768 uncovered in that gap, although it does fall into the range of `medium` which is 641-768, which also overlaps with `medium-down`, etc ....).\r\n\r\nHow did you come up with these breakpoints?","created_at":"2016-02-11T16:42:09Z","updated_at":"2016-02-11T16:42:09Z","html_url":"https://github.com/openstax/os-webview/pull/18#discussion_r52628356","pull_request_url":"https://api.github.com/repos/openstax/os-webview/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/openstax/os-webview/pulls/comments/52628356"},"html":{"href":"https://github.com/openstax/os-webview/pull/18#discussion_r52628356"},"pull_request":{"href":"https://api.github.com/repos/openstax/os-webview/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/openstax/os-webview/pulls/18","id":58351140,"html_url":"https://github.com/openstax/os-webview/pull/18","diff_url":"https://github.com/openstax/os-webview/pull/18.diff","patch_url":"https://github.com/openstax/os-webview/pull/18.patch","issue_url":"https://api.github.com/repos/openstax/os-webview/issues/18","number":18,"state":"open","locked":false,"title":"Updated Navigation Menu","user":{"login":"zroehr","id":1282987,"avatar_url":"https://avatars.githubusercontent.com/u/1282987?v=3","gravatar_id":"","url":"https://api.github.com/users/zroehr","html_url":"https://github.com/zroehr","followers_url":"https://api.github.com/users/zroehr/followers","following_url":"https://api.github.com/users/zroehr/following{/other_user}","gists_url":"https://api.github.com/users/zroehr/gists{/gist_id}","starred_url":"https://api.github.com/users/zroehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zroehr/subscriptions","organizations_url":"https://api.github.com/users/zroehr/orgs","repos_url":"https://api.github.com/users/zroehr/repos","events_url":"https://api.github.com/users/zroehr/events{/privacy}","received_events_url":"https://api.github.com/users/zroehr/received_events","type":"User","site_admin":false},"body":"New PR for navigation with most up-to-date master included.\r\n\r\n - [x] Make Header responsive\r\n - [x] Create mobile interactions\r\n - [x] Add JS for static header when scrolled\r\n - [x] Add interactions for viewing/hiding top bar \r\n - [x] Update nav links to reflect updated design\r\n - [x] Code refactor & clean up\r\n - [x] Cross browser test\r\n - [ ] Verify WCAG A support.","created_at":"2016-02-04T21:22:50Z","updated_at":"2016-02-11T16:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78cf51fdcbbed9a71c23812973e10eb84d845b8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openstax/os-webview/pulls/18/commits","review_comments_url":"https://api.github.com/repos/openstax/os-webview/pulls/18/comments","review_comment_url":"https://api.github.com/repos/openstax/os-webview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstax/os-webview/issues/18/comments","statuses_url":"https://api.github.com/repos/openstax/os-webview/statuses/c6efc4d70a92093486e4b8dd7fdcdaf390b626c9","head":{"label":"openstax:nav-menu-new","ref":"nav-menu-new","sha":"c6efc4d70a92093486e4b8dd7fdcdaf390b626c9","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":49145909,"name":"os-webview","full_name":"openstax/os-webview","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/os-webview","description":":books: Front-end web application for the OpenStax web site","fork":false,"url":"https://api.github.com/repos/openstax/os-webview","forks_url":"https://api.github.com/repos/openstax/os-webview/forks","keys_url":"https://api.github.com/repos/openstax/os-webview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/os-webview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/os-webview/teams","hooks_url":"https://api.github.com/repos/openstax/os-webview/hooks","issue_events_url":"https://api.github.com/repos/openstax/os-webview/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/os-webview/events","assignees_url":"https://api.github.com/repos/openstax/os-webview/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/os-webview/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/os-webview/tags","blobs_url":"https://api.github.com/repos/openstax/os-webview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/os-webview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/os-webview/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/os-webview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/os-webview/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/os-webview/languages","stargazers_url":"https://api.github.com/repos/openstax/os-webview/stargazers","contributors_url":"https://api.github.com/repos/openstax/os-webview/contributors","subscribers_url":"https://api.github.com/repos/openstax/os-webview/subscribers","subscription_url":"https://api.github.com/repos/openstax/os-webview/subscription","commits_url":"https://api.github.com/repos/openstax/os-webview/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/os-webview/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/os-webview/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/os-webview/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/os-webview/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/os-webview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/os-webview/merges","archive_url":"https://api.github.com/repos/openstax/os-webview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/os-webview/downloads","issues_url":"https://api.github.com/repos/openstax/os-webview/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/os-webview/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/os-webview/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/os-webview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/os-webview/labels{/name}","releases_url":"https://api.github.com/repos/openstax/os-webview/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/os-webview/deployments","created_at":"2016-01-06T16:09:14Z","updated_at":"2016-01-12T16:50:15Z","pushed_at":"2016-02-11T04:18:45Z","git_url":"git://github.com/openstax/os-webview.git","ssh_url":"git@github.com:openstax/os-webview.git","clone_url":"https://github.com/openstax/os-webview.git","svn_url":"https://github.com/openstax/os-webview","homepage":null,"size":4427,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openstax:master","ref":"master","sha":"ada5abede167bb62748e75713581b50aa1c4b62f","user":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"repo":{"id":49145909,"name":"os-webview","full_name":"openstax/os-webview","owner":{"login":"openstax","id":3805549,"avatar_url":"https://avatars.githubusercontent.com/u/3805549?v=3","gravatar_id":"","url":"https://api.github.com/users/openstax","html_url":"https://github.com/openstax","followers_url":"https://api.github.com/users/openstax/followers","following_url":"https://api.github.com/users/openstax/following{/other_user}","gists_url":"https://api.github.com/users/openstax/gists{/gist_id}","starred_url":"https://api.github.com/users/openstax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstax/subscriptions","organizations_url":"https://api.github.com/users/openstax/orgs","repos_url":"https://api.github.com/users/openstax/repos","events_url":"https://api.github.com/users/openstax/events{/privacy}","received_events_url":"https://api.github.com/users/openstax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstax/os-webview","description":":books: Front-end web application for the OpenStax web site","fork":false,"url":"https://api.github.com/repos/openstax/os-webview","forks_url":"https://api.github.com/repos/openstax/os-webview/forks","keys_url":"https://api.github.com/repos/openstax/os-webview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstax/os-webview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstax/os-webview/teams","hooks_url":"https://api.github.com/repos/openstax/os-webview/hooks","issue_events_url":"https://api.github.com/repos/openstax/os-webview/issues/events{/number}","events_url":"https://api.github.com/repos/openstax/os-webview/events","assignees_url":"https://api.github.com/repos/openstax/os-webview/assignees{/user}","branches_url":"https://api.github.com/repos/openstax/os-webview/branches{/branch}","tags_url":"https://api.github.com/repos/openstax/os-webview/tags","blobs_url":"https://api.github.com/repos/openstax/os-webview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstax/os-webview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstax/os-webview/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstax/os-webview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstax/os-webview/statuses/{sha}","languages_url":"https://api.github.com/repos/openstax/os-webview/languages","stargazers_url":"https://api.github.com/repos/openstax/os-webview/stargazers","contributors_url":"https://api.github.com/repos/openstax/os-webview/contributors","subscribers_url":"https://api.github.com/repos/openstax/os-webview/subscribers","subscription_url":"https://api.github.com/repos/openstax/os-webview/subscription","commits_url":"https://api.github.com/repos/openstax/os-webview/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstax/os-webview/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstax/os-webview/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstax/os-webview/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstax/os-webview/contents/{+path}","compare_url":"https://api.github.com/repos/openstax/os-webview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstax/os-webview/merges","archive_url":"https://api.github.com/repos/openstax/os-webview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstax/os-webview/downloads","issues_url":"https://api.github.com/repos/openstax/os-webview/issues{/number}","pulls_url":"https://api.github.com/repos/openstax/os-webview/pulls{/number}","milestones_url":"https://api.github.com/repos/openstax/os-webview/milestones{/number}","notifications_url":"https://api.github.com/repos/openstax/os-webview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstax/os-webview/labels{/name}","releases_url":"https://api.github.com/repos/openstax/os-webview/releases{/id}","deployments_url":"https://api.github.com/repos/openstax/os-webview/deployments","created_at":"2016-01-06T16:09:14Z","updated_at":"2016-01-12T16:50:15Z","pushed_at":"2016-02-11T04:18:45Z","git_url":"git://github.com/openstax/os-webview.git","ssh_url":"git@github.com:openstax/os-webview.git","clone_url":"https://github.com/openstax/os-webview.git","svn_url":"https://github.com/openstax/os-webview","homepage":null,"size":4427,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstax/os-webview/pulls/18"},"html":{"href":"https://github.com/openstax/os-webview/pull/18"},"issue":{"href":"https://api.github.com/repos/openstax/os-webview/issues/18"},"comments":{"href":"https://api.github.com/repos/openstax/os-webview/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/openstax/os-webview/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/openstax/os-webview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstax/os-webview/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/openstax/os-webview/statuses/c6efc4d70a92093486e4b8dd7fdcdaf390b626c9"}}}}