{"action":"opened","number":11444,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/11444","id":97850112,"html_url":"https://github.com/facebook/react-native/pull/11444","diff_url":"https://github.com/facebook/react-native/pull/11444.diff","patch_url":"https://github.com/facebook/react-native/pull/11444.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/11444","number":11444,"state":"open","locked":false,"title":"Docs: add warining about possible memory leaks while using native mod…","user":{"login":"gitim","id":3778452,"avatar_url":"https://avatars.githubusercontent.com/u/3778452?v=3","gravatar_id":"","url":"https://api.github.com/users/gitim","html_url":"https://github.com/gitim","followers_url":"https://api.github.com/users/gitim/followers","following_url":"https://api.github.com/users/gitim/following{/other_user}","gists_url":"https://api.github.com/users/gitim/gists{/gist_id}","starred_url":"https://api.github.com/users/gitim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitim/subscriptions","organizations_url":"https://api.github.com/users/gitim/orgs","repos_url":"https://api.github.com/users/gitim/repos","events_url":"https://api.github.com/users/gitim/events{/privacy}","received_events_url":"https://api.github.com/users/gitim/received_events","type":"User","site_admin":false},"body":"Currently callbacks passed to native method are stored in [MessageQueue](https://github.com/facebook/react-native/blob/master/Libraries/BatchedBridge/MessageQueue.js#L160-L162) and [will be removed after invocation](https://github.com/facebook/react-native/blob/master/Libraries/BatchedBridge/MessageQueue.js#L273-L274), so to avoid memory leak in js-side the passed callback(s) must be invoked by native method. \r\n\r\nBecause of this significant nuance of callbacks usage, which is not (or not directly) mentioned  in docs, we have gained huge increase of ooms count in our app. So, I think this warning will help other developers to avoid this issue","created_at":"2016-12-13T22:34:55Z","updated_at":"2016-12-13T22:34:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/11444/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/11444/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/11444/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/5ff23fb15eba71c9d6a12b3ee891104cfdc3a88a","head":{"label":"gitim:warning-about-memory-leaks","ref":"warning-about-memory-leaks","sha":"5ff23fb15eba71c9d6a12b3ee891104cfdc3a88a","user":{"login":"gitim","id":3778452,"avatar_url":"https://avatars.githubusercontent.com/u/3778452?v=3","gravatar_id":"","url":"https://api.github.com/users/gitim","html_url":"https://github.com/gitim","followers_url":"https://api.github.com/users/gitim/followers","following_url":"https://api.github.com/users/gitim/following{/other_user}","gists_url":"https://api.github.com/users/gitim/gists{/gist_id}","starred_url":"https://api.github.com/users/gitim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitim/subscriptions","organizations_url":"https://api.github.com/users/gitim/orgs","repos_url":"https://api.github.com/users/gitim/repos","events_url":"https://api.github.com/users/gitim/events{/privacy}","received_events_url":"https://api.github.com/users/gitim/received_events","type":"User","site_admin":false},"repo":{"id":60106686,"name":"react-native","full_name":"gitim/react-native","owner":{"login":"gitim","id":3778452,"avatar_url":"https://avatars.githubusercontent.com/u/3778452?v=3","gravatar_id":"","url":"https://api.github.com/users/gitim","html_url":"https://github.com/gitim","followers_url":"https://api.github.com/users/gitim/followers","following_url":"https://api.github.com/users/gitim/following{/other_user}","gists_url":"https://api.github.com/users/gitim/gists{/gist_id}","starred_url":"https://api.github.com/users/gitim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitim/subscriptions","organizations_url":"https://api.github.com/users/gitim/orgs","repos_url":"https://api.github.com/users/gitim/repos","events_url":"https://api.github.com/users/gitim/events{/privacy}","received_events_url":"https://api.github.com/users/gitim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gitim/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/gitim/react-native","forks_url":"https://api.github.com/repos/gitim/react-native/forks","keys_url":"https://api.github.com/repos/gitim/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitim/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitim/react-native/teams","hooks_url":"https://api.github.com/repos/gitim/react-native/hooks","issue_events_url":"https://api.github.com/repos/gitim/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/gitim/react-native/events","assignees_url":"https://api.github.com/repos/gitim/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/gitim/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/gitim/react-native/tags","blobs_url":"https://api.github.com/repos/gitim/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitim/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitim/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitim/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitim/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/gitim/react-native/languages","stargazers_url":"https://api.github.com/repos/gitim/react-native/stargazers","contributors_url":"https://api.github.com/repos/gitim/react-native/contributors","subscribers_url":"https://api.github.com/repos/gitim/react-native/subscribers","subscription_url":"https://api.github.com/repos/gitim/react-native/subscription","commits_url":"https://api.github.com/repos/gitim/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitim/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitim/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitim/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitim/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/gitim/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitim/react-native/merges","archive_url":"https://api.github.com/repos/gitim/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitim/react-native/downloads","issues_url":"https://api.github.com/repos/gitim/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/gitim/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/gitim/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/gitim/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitim/react-native/labels{/name}","releases_url":"https://api.github.com/repos/gitim/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/gitim/react-native/deployments","created_at":"2016-05-31T16:42:26Z","updated_at":"2016-05-31T16:42:33Z","pushed_at":"2016-12-13T22:12:39Z","git_url":"git://github.com/gitim/react-native.git","ssh_url":"git@github.com:gitim/react-native.git","clone_url":"https://github.com/gitim/react-native.git","svn_url":"https://github.com/gitim/react-native","homepage":"http://facebook.github.io/react-native/","size":77191,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"4220063f8464a9778fd8470b3fb95fe502fb1bd0","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-12-13T21:25:44Z","pushed_at":"2016-12-13T22:34:55Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":107348,"stargazers_count":41545,"watchers_count":41545,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9479,"mirror_url":null,"open_issues_count":889,"forks":9479,"open_issues":889,"watchers":41545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11444"},"html":{"href":"https://github.com/facebook/react-native/pull/11444"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/11444"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/11444/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11444/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/11444/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/5ff23fb15eba71c9d6a12b3ee891104cfdc3a88a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"gitim"}}