{"action":"created","issue":{"url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa/issues/7","repository_url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa","labels_url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa/issues/7/comments","events_url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa/issues/7/events","html_url":"https://github.com/cretueusebiu/laravel-spark-google2fa/issues/7","id":163050842,"number":7,"title":"Invalid Barcode caused by spaces in $details['vendor']","user":{"login":"securit","id":168565,"avatar_url":"https://avatars.githubusercontent.com/u/168565?v=3","gravatar_id":"","url":"https://api.github.com/users/securit","html_url":"https://github.com/securit","followers_url":"https://api.github.com/users/securit/followers","following_url":"https://api.github.com/users/securit/following{/other_user}","gists_url":"https://api.github.com/users/securit/gists{/gist_id}","starred_url":"https://api.github.com/users/securit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/securit/subscriptions","organizations_url":"https://api.github.com/users/securit/orgs","repos_url":"https://api.github.com/users/securit/repos","events_url":"https://api.github.com/users/securit/events{/privacy}","received_events_url":"https://api.github.com/users/securit/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-29T23:34:04Z","updated_at":"2016-07-02T07:51:56Z","closed_at":"2016-07-02T07:51:33Z","body":"Hi, \r\n\r\nYou need to make your getQrUrl function URL safe by encoding it as spaces or safe characters in the $details['vendor'] string can cause the QR code generation to fail.\r\n\r\nModify line 53 of TwoFactorAuthController to URLencode the vendor details as follows:\r\n\r\n`$company = isset(Engagement::$details['vendor']) ? urlencode(Engagement::$details['vendor']) : url()->to('/');\r\n`\r\n\r\nThat will resolve this bug"},"comment":{"url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa/issues/comments/230089587","html_url":"https://github.com/cretueusebiu/laravel-spark-google2fa/issues/7#issuecomment-230089587","issue_url":"https://api.github.com/repos/cretueusebiu/laravel-spark-google2fa/issues/7","id":230089587,"user":{"login":"cretueusebiu","id":1517945,"avatar_url":"https://avatars.githubusercontent.com/u/1517945?v=3","gravatar_id":"","url":"https://api.github.com/users/cretueusebiu","html_url":"https://github.com/cretueusebiu","followers_url":"https://api.github.com/users/cretueusebiu/followers","following_url":"https://api.github.com/users/cretueusebiu/following{/other_user}","gists_url":"https://api.github.com/users/cretueusebiu/gists{/gist_id}","starred_url":"https://api.github.com/users/cretueusebiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cretueusebiu/subscriptions","organizations_url":"https://api.github.com/users/cretueusebiu/orgs","repos_url":"https://api.github.com/users/cretueusebiu/repos","events_url":"https://api.github.com/users/cretueusebiu/events{/privacy}","received_events_url":"https://api.github.com/users/cretueusebiu/received_events","type":"User","site_admin":false},"created_at":"2016-07-02T07:51:55Z","updated_at":"2016-07-02T07:51:55Z","body":"Fixed https://github.com/cretueusebiu/laravel-spark-google2fa/commit/e5bd639a1e61e72ae22965acd92644157f276a7b"}}
{"actor":{"display_login":"cretueusebiu"}}