{"action":"created","issue":{"url":"https://api.github.com/repos/meteor/meteor/issues/6148","repository_url":"https://api.github.com/repos/meteor/meteor","labels_url":"https://api.github.com/repos/meteor/meteor/issues/6148/labels{/name}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/6148/comments","events_url":"https://api.github.com/repos/meteor/meteor/issues/6148/events","html_url":"https://github.com/meteor/meteor/pull/6148","id":130978451,"number":6148,"title":"Make check check inherited properties","user":{"login":"sebakerckhof","id":88471,"avatar_url":"https://avatars.githubusercontent.com/u/88471?v=3","gravatar_id":"","url":"https://api.github.com/users/sebakerckhof","html_url":"https://github.com/sebakerckhof","followers_url":"https://api.github.com/users/sebakerckhof/followers","following_url":"https://api.github.com/users/sebakerckhof/following{/other_user}","gists_url":"https://api.github.com/users/sebakerckhof/gists{/gist_id}","starred_url":"https://api.github.com/users/sebakerckhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebakerckhof/subscriptions","organizations_url":"https://api.github.com/users/sebakerckhof/orgs","repos_url":"https://api.github.com/users/sebakerckhof/repos","events_url":"https://api.github.com/users/sebakerckhof/events{/privacy}","received_events_url":"https://api.github.com/users/sebakerckhof/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"stubailo","id":448783,"avatar_url":"https://avatars.githubusercontent.com/u/448783?v=3","gravatar_id":"","url":"https://api.github.com/users/stubailo","html_url":"https://github.com/stubailo","followers_url":"https://api.github.com/users/stubailo/followers","following_url":"https://api.github.com/users/stubailo/following{/other_user}","gists_url":"https://api.github.com/users/stubailo/gists{/gist_id}","starred_url":"https://api.github.com/users/stubailo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stubailo/subscriptions","organizations_url":"https://api.github.com/users/stubailo/orgs","repos_url":"https://api.github.com/users/stubailo/repos","events_url":"https://api.github.com/users/stubailo/events{/privacy}","received_events_url":"https://api.github.com/users/stubailo/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-02-03T10:09:44Z","updated_at":"2016-02-27T10:42:12Z","closed_at":"2016-02-04T04:20:04Z","pull_request":{"url":"https://api.github.com/repos/meteor/meteor/pulls/6148","html_url":"https://github.com/meteor/meteor/pull/6148","diff_url":"https://github.com/meteor/meteor/pull/6148.diff","patch_url":"https://github.com/meteor/meteor/pull/6148.patch"},"body":"Fixes https://github.com/meteor/meteor/issues/6140"},"comment":{"url":"https://api.github.com/repos/meteor/meteor/issues/comments/189617324","html_url":"https://github.com/meteor/meteor/pull/6148#issuecomment-189617324","issue_url":"https://api.github.com/repos/meteor/meteor/issues/6148","id":189617324,"user":{"login":"mitar","id":585279,"avatar_url":"https://avatars.githubusercontent.com/u/585279?v=3","gravatar_id":"","url":"https://api.github.com/users/mitar","html_url":"https://github.com/mitar","followers_url":"https://api.github.com/users/mitar/followers","following_url":"https://api.github.com/users/mitar/following{/other_user}","gists_url":"https://api.github.com/users/mitar/gists{/gist_id}","starred_url":"https://api.github.com/users/mitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitar/subscriptions","organizations_url":"https://api.github.com/users/mitar/orgs","repos_url":"https://api.github.com/users/mitar/repos","events_url":"https://api.github.com/users/mitar/events{/privacy}","received_events_url":"https://api.github.com/users/mitar/received_events","type":"User","site_admin":false},"created_at":"2016-02-27T10:42:12Z","updated_at":"2016-02-27T10:42:12Z","body":"> But checking if an object is a plain object is quite tricky\r\n\r\nI have the following functions in my code often:\r\n\r\n```\r\nfunction isTrueObject(value) {\r\n  return _.isObject(value) && !_.isArray(value) && !_.isFunction(value);\r\n}\r\n\r\nfunction isPlainObject(obj) {\r\n  if (isTrueObject(obj)) {\r\n    return false;\r\n  }\r\n  if (obj.constructor !== Object) {\r\n    return false;\r\n  }\r\n  return true;\r\n}\r\n```\r\n\r\nI assume `Object` is not changed because it is on the server.\r\n\r\n> you can easily sanitize it before giving it to check\r\n\r\nThe whole point of calling `check` is to have a simple one command to verify arguments of methods. Not that I have first to sanitize and then call `check`.\r\n\r\n> I do agree I should have modified the docs with this PR, because currently the docs are not correct.\r\n\r\nYes, by that you are introducing backwards incompatibility. It is not just changing docs."}}