{"action":"created","issue":{"url":"https://api.github.com/repos/mscdex/node-mariasql/issues/133","repository_url":"https://api.github.com/repos/mscdex/node-mariasql","labels_url":"https://api.github.com/repos/mscdex/node-mariasql/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/mscdex/node-mariasql/issues/133/comments","events_url":"https://api.github.com/repos/mscdex/node-mariasql/issues/133/events","html_url":"https://github.com/mscdex/node-mariasql/pull/133","id":135039173,"number":133,"title":"possible fix for prevent segfault on v8","user":{"login":"devzer01","id":4328569,"avatar_url":"https://avatars.githubusercontent.com/u/4328569?v=3","gravatar_id":"","url":"https://api.github.com/users/devzer01","html_url":"https://github.com/devzer01","followers_url":"https://api.github.com/users/devzer01/followers","following_url":"https://api.github.com/users/devzer01/following{/other_user}","gists_url":"https://api.github.com/users/devzer01/gists{/gist_id}","starred_url":"https://api.github.com/users/devzer01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devzer01/subscriptions","organizations_url":"https://api.github.com/users/devzer01/orgs","repos_url":"https://api.github.com/users/devzer01/repos","events_url":"https://api.github.com/users/devzer01/events{/privacy}","received_events_url":"https://api.github.com/users/devzer01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-02-20T06:27:59Z","updated_at":"2016-02-21T03:58:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mscdex/node-mariasql/pulls/133","html_url":"https://github.com/mscdex/node-mariasql/pull/133","diff_url":"https://github.com/mscdex/node-mariasql/pull/133.diff","patch_url":"https://github.com/mscdex/node-mariasql/pull/133.patch"},"body":"@mscdex Brian, i am not an expert on the topic. but with my limited knowledge and few hours of GDBing through the race condition, i am suggesting this fix to bindings.cc. this should handle any case where Client is garbage collected before the call ends on bindings and resulting a callback to a none existing JS object. \r\n\r\nall relevant info was added to PR #130 "},"comment":{"url":"https://api.github.com/repos/mscdex/node-mariasql/issues/comments/186735928","html_url":"https://github.com/mscdex/node-mariasql/pull/133#issuecomment-186735928","issue_url":"https://api.github.com/repos/mscdex/node-mariasql/issues/133","id":186735928,"user":{"login":"devzer01","id":4328569,"avatar_url":"https://avatars.githubusercontent.com/u/4328569?v=3","gravatar_id":"","url":"https://api.github.com/users/devzer01","html_url":"https://github.com/devzer01","followers_url":"https://api.github.com/users/devzer01/followers","following_url":"https://api.github.com/users/devzer01/following{/other_user}","gists_url":"https://api.github.com/users/devzer01/gists{/gist_id}","starred_url":"https://api.github.com/users/devzer01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devzer01/subscriptions","organizations_url":"https://api.github.com/users/devzer01/orgs","repos_url":"https://api.github.com/users/devzer01/repos","events_url":"https://api.github.com/users/devzer01/events{/privacy}","received_events_url":"https://api.github.com/users/devzer01/received_events","type":"User","site_admin":false},"created_at":"2016-02-21T03:58:32Z","updated_at":"2016-02-21T03:58:32Z","body":"do you know what is the exact version of 0.10.x? you are running on travis? because\r\n\r\n```\r\n# Fatal error in ../deps/v8/src/api.h, line 297\r\n# CHECK(allow_empty_handle || that != __null) failed\r\n```\r\n\r\nin latest 0.10.x line 297 is not that \r\n\r\nits \r\n\r\n```\r\nOPEN_HANDLE_LIST(MAKE_OPEN_HANDLE)\r\n```\r\n\r\n"}}