{"action":"created","issue":{"url":"https://api.github.com/repos/JedWatson/react-select/issues/999","repository_url":"https://api.github.com/repos/JedWatson/react-select","labels_url":"https://api.github.com/repos/JedWatson/react-select/issues/999/labels{/name}","comments_url":"https://api.github.com/repos/JedWatson/react-select/issues/999/comments","events_url":"https://api.github.com/repos/JedWatson/react-select/issues/999/events","html_url":"https://github.com/JedWatson/react-select/pull/999","id":157977785,"number":999,"title":"Implemented allowCreate and more flexible add item on comma functionality","user":{"login":"ryanzec","id":444206,"avatar_url":"https://avatars.githubusercontent.com/u/444206?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanzec","html_url":"https://github.com/ryanzec","followers_url":"https://api.github.com/users/ryanzec/followers","following_url":"https://api.github.com/users/ryanzec/following{/other_user}","gists_url":"https://api.github.com/users/ryanzec/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanzec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanzec/subscriptions","organizations_url":"https://api.github.com/users/ryanzec/orgs","repos_url":"https://api.github.com/users/ryanzec/repos","events_url":"https://api.github.com/users/ryanzec/events{/privacy}","received_events_url":"https://api.github.com/users/ryanzec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-06-01T18:39:03Z","updated_at":"2016-06-08T22:52:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JedWatson/react-select/pulls/999","html_url":"https://github.com/JedWatson/react-select/pull/999","diff_url":"https://github.com/JedWatson/react-select/pull/999.diff","patch_url":"https://github.com/JedWatson/react-select/pull/999.patch"},"body":"I took the pull request #660 (which relates to #658 and #586) and re-did it as this is a huge show stopper for me on using this library and that implementation seemed a bit broken (and the 0.9.1 does not have some of the functionality that I also need the 1.0.0-beta does).  \r\n\r\nThis adds back in the allowCreate functionality with the tests reworked to pass (I also fixed an existing failing test as it seemed to be using the old `setPropselectorChild` method instead of `setPropsForChild`)\r\n\r\n**UPDATE:**\r\n\r\nI added another commit here to add a more flexible solution to the old add item on comma when `allowCreate` and `mutli` are enabled.  My solution allows you to specific the keyCode to use to add a new item (set with the `addItemOnKeyCode` prop).  While comma is pretty common, it is not always the best option and making it flexible like this it not that much difference in the implementation.  This also allows you to turn off this feature which was not possible in the older implementation which i think is not completely uncommon.  By default the `addItemOnKeyCode` prop is set to null so that the user need to explicitly enable this functionality.\r\n\r\nAlso, I have no idea what the @coveralls messages mean.  I did run coverage reports before and after and the coverage did not go down after my src / test updates (they actually went up on 1 or 2 src files but only marginally).\r\n\r\nIf I could get an update if this will be an acceptable PR (or if any changes are needed to get this merged) and included into a npm tagged beta release relatively soon that would be great.  Without these changes, using this library is a show stopper.  Since 0.9.1 is also missing functionality the 1.x beta version has, using that version is also a show stopper.  If these features are not going to be able to be consumable through npm relatively soon, I am going to have to publish my own version to be able to move forward with this library which I would prefer not to do."},"comment":{"url":"https://api.github.com/repos/JedWatson/react-select/issues/comments/224755242","html_url":"https://github.com/JedWatson/react-select/pull/999#issuecomment-224755242","issue_url":"https://api.github.com/repos/JedWatson/react-select/issues/999","id":224755242,"user":{"login":"ryanzec","id":444206,"avatar_url":"https://avatars.githubusercontent.com/u/444206?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanzec","html_url":"https://github.com/ryanzec","followers_url":"https://api.github.com/users/ryanzec/followers","following_url":"https://api.github.com/users/ryanzec/following{/other_user}","gists_url":"https://api.github.com/users/ryanzec/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanzec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanzec/subscriptions","organizations_url":"https://api.github.com/users/ryanzec/orgs","repos_url":"https://api.github.com/users/ryanzec/repos","events_url":"https://api.github.com/users/ryanzec/events{/privacy}","received_events_url":"https://api.github.com/users/ryanzec/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T22:52:24Z","updated_at":"2016-06-08T22:52:24Z","body":"@ttrmw Are you sure that you are running against the right code as it works for me:\r\n\r\n<img width=\"433\" alt=\"screen shot 2016-06-08 at 6 39 24 pm\" src=\"https://cloud.githubusercontent.com/assets/444206/15913545/95a991ee-2da8-11e6-9471-c8d56ed67ecb.png\">\r\n\r\nand then I can add the new value just fine:\r\n\r\n<img width=\"430\" alt=\"screen shot 2016-06-08 at 6 42 12 pm\" src=\"https://cloud.githubusercontent.com/assets/444206/15913569/c81d7e24-2da8-11e6-837d-1968d9254b1c.png\">\r\n\r\nI have tested this in Chrome, FireFox, Safari, and IE 10.  Not sure whatelse to say.  Only things I can say is for someone else to try this branch to see if it is not working for them as everything is working for me."}}
{"actor":{"display_login":"ryanzec"}}