{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/62060886","id":62060886,"diff_hunk":"@@ -4160,14 +4160,14 @@ void player::pause()\n     search_surroundings();\n }\n \n-void player::shout( std::string msg )\n+void player::shout( std::string msg, const std::string &verbal_shout_id )\n {\n-    int base = 10;\n+    int base = 85;","path":"src/player.cpp","position":8,"original_position":8,"commit_id":"bfc50dc3767e70ab4a8c5a4103e01bdb21371b37","original_commit_id":"bfc50dc3767e70ab4a8c5a4103e01bdb21371b37","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"body":"Are those just for testing or are you putting them through some sort of a modifier? 85 range is more than the entire visible area.","created_at":"2016-05-04T15:30:49Z","updated_at":"2016-05-04T15:30:49Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16518#discussion_r62060886","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/62060886"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16518#discussion_r62060886"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518","id":68862224,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16518","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16518.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16518.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16518","number":16518,"state":"open","locked":false,"title":"[CR] Shout to npcs","user":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"body":"This PR adds an option in the Chat window (default C hotkey?) to shout to any nearby NPCs to call them to the player. This allows the player to call NPCs who are outside of speaking range (up to shout distance, ~100 local tiles w/o any mouth encumbrance and w/o shouting traits) or not in line of sight (e.g. in darkness). Motivation was the discussion in https://github.com/CleverRaven/Cataclysm-DDA/pull/16430.\r\n\r\nLooking for some feedback on the approach. There's a bunch of obvious duplication to be refactored, which I can take care of if the feature looks good.\r\n\r\n![beforer](https://cloud.githubusercontent.com/assets/646121/15015797/c5c9a140-11c2-11e6-9ffd-7e733ec6b3f6.png)\r\n","created_at":"2016-05-04T13:32:03Z","updated_at":"2016-05-04T15:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9d87f9a892bb02d50bbd4feaae74916aba565d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16518/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/bfc50dc3767e70ab4a8c5a4103e01bdb21371b37","head":{"label":"lucianposton:shout-to-npcs","ref":"shout-to-npcs","sha":"bfc50dc3767e70ab4a8c5a4103e01bdb21371b37","user":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"repo":{"id":18898225,"name":"Cataclysm-DDA","full_name":"lucianposton/Cataclysm-DDA","owner":{"login":"lucianposton","id":646121,"avatar_url":"https://avatars.githubusercontent.com/u/646121?v=3","gravatar_id":"","url":"https://api.github.com/users/lucianposton","html_url":"https://github.com/lucianposton","followers_url":"https://api.github.com/users/lucianposton/followers","following_url":"https://api.github.com/users/lucianposton/following{/other_user}","gists_url":"https://api.github.com/users/lucianposton/gists{/gist_id}","starred_url":"https://api.github.com/users/lucianposton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucianposton/subscriptions","organizations_url":"https://api.github.com/users/lucianposton/orgs","repos_url":"https://api.github.com/users/lucianposton/repos","events_url":"https://api.github.com/users/lucianposton/events{/privacy}","received_events_url":"https://api.github.com/users/lucianposton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lucianposton/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA","forks_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/lucianposton/Cataclysm-DDA/deployments","created_at":"2014-04-18T00:53:10Z","updated_at":"2016-03-18T02:40:32Z","pushed_at":"2016-05-04T13:47:11Z","git_url":"git://github.com/lucianposton/Cataclysm-DDA.git","ssh_url":"git@github.com:lucianposton/Cataclysm-DDA.git","clone_url":"https://github.com/lucianposton/Cataclysm-DDA.git","svn_url":"https://github.com/lucianposton/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":754657,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"f5cfd0f647ba221a58c8a0eedd126da9809a2523","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-05-03T15:16:59Z","pushed_at":"2016-05-04T14:56:11Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1017369,"stargazers_count":935,"watchers_count":935,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":872,"mirror_url":null,"open_issues_count":1183,"forks":872,"open_issues":1183,"watchers":935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16518"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16518"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16518/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16518/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/bfc50dc3767e70ab4a8c5a4103e01bdb21371b37"}}}}