{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runc/issues/1018","repository_url":"https://api.github.com/repos/opencontainers/runc","labels_url":"https://api.github.com/repos/opencontainers/runc/issues/1018/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runc/issues/1018/comments","events_url":"https://api.github.com/repos/opencontainers/runc/issues/1018/events","html_url":"https://github.com/opencontainers/runc/pull/1018","id":174945454,"number":1018,"title":"Consoles, consoles, consoles.","user":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/opencontainers/runc/labels/status/0-triage","name":"status/0-triage","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/opencontainers/runc/milestones/4","html_url":"https://github.com/opencontainers/runc/milestones/1.0.0","labels_url":"https://api.github.com/repos/opencontainers/runc/milestones/4/labels","id":1756705,"number":4,"title":"1.0.0","description":"Final milestone for the runc 1.0.0 Release","creator":{"login":"cyphar","id":2888411,"avatar_url":"https://avatars.githubusercontent.com/u/2888411?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphar","html_url":"https://github.com/cyphar","followers_url":"https://api.github.com/users/cyphar/followers","following_url":"https://api.github.com/users/cyphar/following{/other_user}","gists_url":"https://api.github.com/users/cyphar/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphar/subscriptions","organizations_url":"https://api.github.com/users/cyphar/orgs","repos_url":"https://api.github.com/users/cyphar/repos","events_url":"https://api.github.com/users/cyphar/events{/privacy}","received_events_url":"https://api.github.com/users/cyphar/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":17,"state":"open","created_at":"2016-05-09T23:22:52Z","updated_at":"2016-09-12T16:00:18Z","due_on":null,"closed_at":null},"comments":82,"created_at":"2016-09-04T12:01:10Z","updated_at":"2016-09-14T23:32:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runc/pulls/1018","html_url":"https://github.com/opencontainers/runc/pull/1018","diff_url":"https://github.com/opencontainers/runc/pull/1018.diff","patch_url":"https://github.com/opencontainers/runc/pull/1018.patch"},"body":"This is the big console rewrite. For some design information, see [this](https://gist.github.com/cyphar/8c6b9db84fc1f2cc2d037ef07942ca83). TODO list:\r\n\r\n* [x] Implement the console masterfd passing.\r\n* [x] Rewrite parts of `tty.go` to work with the new setup.\r\n* [x] Remove `--console` and add `--console-socket`.\r\n  - [x] Need to figure out a sane protocol for sending things to `--console-socket`.\r\n  - [x] Write a small implementation of a `--console-socket` consumer as a sanity check [can be done in a separate PR].\r\n* [x] Figure out how to make the test suite behave.\r\n  - [x] `TestExecInTTY`.\r\n  - [x] bats `integration`.\r\n* [x] Need to figure out why runC is blocking on `recvfd()`.\r\n\r\nFixes #814, #910 and countless other issues.\r\n~~Depends on #975, #977.~~\r\n\r\nSigned-off-by: Aleksa Sarai <asarai@suse.de>"},"comment":{"url":"https://api.github.com/repos/opencontainers/runc/issues/comments/247188767","html_url":"https://github.com/opencontainers/runc/pull/1018#issuecomment-247188767","issue_url":"https://api.github.com/repos/opencontainers/runc/issues/1018","id":247188767,"user":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars.githubusercontent.com/u/12767641?v=3","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T23:32:43Z","updated_at":"2016-09-14T23:32:43Z","body":"@cyphar ...my fault for putting two things in there.  Let me rephrase... 1) should we default the socket to container-id.soc, just a thought to make it easier to use debug etc. 2) While I get that -d (detach) needs to return to the caller I was really thinking about runc exec.  I may be somewhat confused by the runc exec command having the --console-socket option.. but then I see in the integration test case tests/integration/exec.bats the exec portion wan't changes to point to the console-socket, so I should probably just pull your PR and test it out :-)"}}
{"actor":{"display_login":"mikebrow"}}