{"action":"created","issue":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent/issues/87","repository_url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent","labels_url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent/issues/87/comments","events_url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent/issues/87/events","html_url":"https://github.com/jmxtrans/jmxtrans-agent/issues/87","id":184484097,"number":87,"title":"single line per collection rolling file writer?","user":{"login":"gliptak","id":50109,"avatar_url":"https://avatars.githubusercontent.com/u/50109?v=3","gravatar_id":"","url":"https://api.github.com/users/gliptak","html_url":"https://github.com/gliptak","followers_url":"https://api.github.com/users/gliptak/followers","following_url":"https://api.github.com/users/gliptak/following{/other_user}","gists_url":"https://api.github.com/users/gliptak/gists{/gist_id}","starred_url":"https://api.github.com/users/gliptak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gliptak/subscriptions","organizations_url":"https://api.github.com/users/gliptak/orgs","repos_url":"https://api.github.com/users/gliptak/repos","events_url":"https://api.github.com/users/gliptak/events{/privacy}","received_events_url":"https://api.github.com/users/gliptak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-21T13:26:22Z","updated_at":"2016-10-23T19:17:34Z","closed_at":null,"body":"I'm considering writing a single line per collection rolling file write in the format:\r\n\r\nkey1=value1, key2=value2, key3=value3 . . .\r\n\r\nThis allows for improved parsing by Splunk (http://dev.splunk.com/view/logging-best-practices/SP-CAAADP6) and possibly by other (file based) log collectors.\r\n\r\nWould you like this writer contributed? If so, do you have a preferred Java class name?\r\n\r\nor would you possibly like to change the formatting to single line per collection for:\r\n\r\norg\\jmxtrans\\agent\\FileOverwriterOutputWriter.java\r\norg\\jmxtrans\\agent\\RollingFileOutputWriter.java\r\n\r\nPlease comment. Thanks"},"comment":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent/issues/comments/255608065","html_url":"https://github.com/jmxtrans/jmxtrans-agent/issues/87#issuecomment-255608065","issue_url":"https://api.github.com/repos/jmxtrans/jmxtrans-agent/issues/87","id":255608065,"user":{"login":"kerlandsson","id":4170345,"avatar_url":"https://avatars.githubusercontent.com/u/4170345?v=3","gravatar_id":"","url":"https://api.github.com/users/kerlandsson","html_url":"https://github.com/kerlandsson","followers_url":"https://api.github.com/users/kerlandsson/followers","following_url":"https://api.github.com/users/kerlandsson/following{/other_user}","gists_url":"https://api.github.com/users/kerlandsson/gists{/gist_id}","starred_url":"https://api.github.com/users/kerlandsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerlandsson/subscriptions","organizations_url":"https://api.github.com/users/kerlandsson/orgs","repos_url":"https://api.github.com/users/kerlandsson/repos","events_url":"https://api.github.com/users/kerlandsson/events{/privacy}","received_events_url":"https://api.github.com/users/kerlandsson/received_events","type":"User","site_admin":false},"created_at":"2016-10-23T19:17:34Z","updated_at":"2016-10-23T19:17:34Z","body":"I would like to avoid adding a new file writer unless we can deprecate the old ones - otherwise we will have three to support, with a lot of duplication, and once we have added `FileOutputWriter` we can't really change how it is configured without breaking backwards compability.\r\n\r\nIf you want changes merged, I suggest that you for now add a configuration flag to the `RollingFileOutputWriter` to support single line logging. That does not feel too invasive.\r\n\r\nIf you want to work more on it and create a more generic `FileOutputWriter` to support all cases as I outlined above it would be appreciated!"}}
{"actor":{"display_login":"kerlandsson"}}