{"action":"opened","number":124,"pull_request":{"url":"https://api.github.com/repos/mafintosh/prebuild/pulls/124","id":71811316,"html_url":"https://github.com/mafintosh/prebuild/pull/124","diff_url":"https://github.com/mafintosh/prebuild/pull/124.diff","patch_url":"https://github.com/mafintosh/prebuild/pull/124.patch","issue_url":"https://api.github.com/repos/mafintosh/prebuild/issues/124","number":124,"state":"open","locked":false,"title":"replace simple-get to send requests through configured proxy","user":{"login":"csulok","id":1908720,"avatar_url":"https://avatars.githubusercontent.com/u/1908720?v=3","gravatar_id":"","url":"https://api.github.com/users/csulok","html_url":"https://github.com/csulok","followers_url":"https://api.github.com/users/csulok/followers","following_url":"https://api.github.com/users/csulok/following{/other_user}","gists_url":"https://api.github.com/users/csulok/gists{/gist_id}","starred_url":"https://api.github.com/users/csulok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csulok/subscriptions","organizations_url":"https://api.github.com/users/csulok/orgs","repos_url":"https://api.github.com/users/csulok/repos","events_url":"https://api.github.com/users/csulok/events{/privacy}","received_events_url":"https://api.github.com/users/csulok/received_events","type":"User","site_admin":false},"body":"I've taken a crack at solving https://github.com/mafintosh/prebuild/issues/35. In the comments you hinted at using [got](https://www.npmjs.com/package/got), but I used [request](https://www.npmjs.com/package/request) here. Couldn't get 1 test to work, where an error event is emitted directly into the response, so this is not perfect.\r\n\r\nRemaining work is to create tests for sending requests through http_proxy when configured in npm. Would appreciate any help with that!","created_at":"2016-05-28T20:48:04Z","updated_at":"2016-05-28T20:48:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mafintosh/prebuild/pulls/124/commits","review_comments_url":"https://api.github.com/repos/mafintosh/prebuild/pulls/124/comments","review_comment_url":"https://api.github.com/repos/mafintosh/prebuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mafintosh/prebuild/issues/124/comments","statuses_url":"https://api.github.com/repos/mafintosh/prebuild/statuses/8796c99cadb084e7f77ee1da806c222aa9627b75","head":{"label":"csulok:master","ref":"master","sha":"8796c99cadb084e7f77ee1da806c222aa9627b75","user":{"login":"csulok","id":1908720,"avatar_url":"https://avatars.githubusercontent.com/u/1908720?v=3","gravatar_id":"","url":"https://api.github.com/users/csulok","html_url":"https://github.com/csulok","followers_url":"https://api.github.com/users/csulok/followers","following_url":"https://api.github.com/users/csulok/following{/other_user}","gists_url":"https://api.github.com/users/csulok/gists{/gist_id}","starred_url":"https://api.github.com/users/csulok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csulok/subscriptions","organizations_url":"https://api.github.com/users/csulok/orgs","repos_url":"https://api.github.com/users/csulok/repos","events_url":"https://api.github.com/users/csulok/events{/privacy}","received_events_url":"https://api.github.com/users/csulok/received_events","type":"User","site_admin":false},"repo":{"id":59913575,"name":"prebuild","full_name":"csulok/prebuild","owner":{"login":"csulok","id":1908720,"avatar_url":"https://avatars.githubusercontent.com/u/1908720?v=3","gravatar_id":"","url":"https://api.github.com/users/csulok","html_url":"https://github.com/csulok","followers_url":"https://api.github.com/users/csulok/followers","following_url":"https://api.github.com/users/csulok/following{/other_user}","gists_url":"https://api.github.com/users/csulok/gists{/gist_id}","starred_url":"https://api.github.com/users/csulok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csulok/subscriptions","organizations_url":"https://api.github.com/users/csulok/orgs","repos_url":"https://api.github.com/users/csulok/repos","events_url":"https://api.github.com/users/csulok/events{/privacy}","received_events_url":"https://api.github.com/users/csulok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csulok/prebuild","description":"A command line tool for easily doing prebuilds for multiple version of node/iojs on a specific platform","fork":true,"url":"https://api.github.com/repos/csulok/prebuild","forks_url":"https://api.github.com/repos/csulok/prebuild/forks","keys_url":"https://api.github.com/repos/csulok/prebuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csulok/prebuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csulok/prebuild/teams","hooks_url":"https://api.github.com/repos/csulok/prebuild/hooks","issue_events_url":"https://api.github.com/repos/csulok/prebuild/issues/events{/number}","events_url":"https://api.github.com/repos/csulok/prebuild/events","assignees_url":"https://api.github.com/repos/csulok/prebuild/assignees{/user}","branches_url":"https://api.github.com/repos/csulok/prebuild/branches{/branch}","tags_url":"https://api.github.com/repos/csulok/prebuild/tags","blobs_url":"https://api.github.com/repos/csulok/prebuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csulok/prebuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csulok/prebuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/csulok/prebuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csulok/prebuild/statuses/{sha}","languages_url":"https://api.github.com/repos/csulok/prebuild/languages","stargazers_url":"https://api.github.com/repos/csulok/prebuild/stargazers","contributors_url":"https://api.github.com/repos/csulok/prebuild/contributors","subscribers_url":"https://api.github.com/repos/csulok/prebuild/subscribers","subscription_url":"https://api.github.com/repos/csulok/prebuild/subscription","commits_url":"https://api.github.com/repos/csulok/prebuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/csulok/prebuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/csulok/prebuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/csulok/prebuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/csulok/prebuild/contents/{+path}","compare_url":"https://api.github.com/repos/csulok/prebuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csulok/prebuild/merges","archive_url":"https://api.github.com/repos/csulok/prebuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csulok/prebuild/downloads","issues_url":"https://api.github.com/repos/csulok/prebuild/issues{/number}","pulls_url":"https://api.github.com/repos/csulok/prebuild/pulls{/number}","milestones_url":"https://api.github.com/repos/csulok/prebuild/milestones{/number}","notifications_url":"https://api.github.com/repos/csulok/prebuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csulok/prebuild/labels{/name}","releases_url":"https://api.github.com/repos/csulok/prebuild/releases{/id}","deployments_url":"https://api.github.com/repos/csulok/prebuild/deployments","created_at":"2016-05-28T20:41:16Z","updated_at":"2016-05-28T20:41:17Z","pushed_at":"2016-05-28T20:42:50Z","git_url":"git://github.com/csulok/prebuild.git","ssh_url":"git@github.com:csulok/prebuild.git","clone_url":"https://github.com/csulok/prebuild.git","svn_url":"https://github.com/csulok/prebuild","homepage":null,"size":216,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mafintosh:master","ref":"master","sha":"ee447175466d2734561616b025e9f75358d85066","user":{"login":"mafintosh","id":376661,"avatar_url":"https://avatars.githubusercontent.com/u/376661?v=3","gravatar_id":"","url":"https://api.github.com/users/mafintosh","html_url":"https://github.com/mafintosh","followers_url":"https://api.github.com/users/mafintosh/followers","following_url":"https://api.github.com/users/mafintosh/following{/other_user}","gists_url":"https://api.github.com/users/mafintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/mafintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafintosh/subscriptions","organizations_url":"https://api.github.com/users/mafintosh/orgs","repos_url":"https://api.github.com/users/mafintosh/repos","events_url":"https://api.github.com/users/mafintosh/events{/privacy}","received_events_url":"https://api.github.com/users/mafintosh/received_events","type":"User","site_admin":false},"repo":{"id":39695266,"name":"prebuild","full_name":"mafintosh/prebuild","owner":{"login":"mafintosh","id":376661,"avatar_url":"https://avatars.githubusercontent.com/u/376661?v=3","gravatar_id":"","url":"https://api.github.com/users/mafintosh","html_url":"https://github.com/mafintosh","followers_url":"https://api.github.com/users/mafintosh/followers","following_url":"https://api.github.com/users/mafintosh/following{/other_user}","gists_url":"https://api.github.com/users/mafintosh/gists{/gist_id}","starred_url":"https://api.github.com/users/mafintosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mafintosh/subscriptions","organizations_url":"https://api.github.com/users/mafintosh/orgs","repos_url":"https://api.github.com/users/mafintosh/repos","events_url":"https://api.github.com/users/mafintosh/events{/privacy}","received_events_url":"https://api.github.com/users/mafintosh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mafintosh/prebuild","description":"A command line tool for easily doing prebuilds for multiple version of node/iojs on a specific platform","fork":false,"url":"https://api.github.com/repos/mafintosh/prebuild","forks_url":"https://api.github.com/repos/mafintosh/prebuild/forks","keys_url":"https://api.github.com/repos/mafintosh/prebuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mafintosh/prebuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mafintosh/prebuild/teams","hooks_url":"https://api.github.com/repos/mafintosh/prebuild/hooks","issue_events_url":"https://api.github.com/repos/mafintosh/prebuild/issues/events{/number}","events_url":"https://api.github.com/repos/mafintosh/prebuild/events","assignees_url":"https://api.github.com/repos/mafintosh/prebuild/assignees{/user}","branches_url":"https://api.github.com/repos/mafintosh/prebuild/branches{/branch}","tags_url":"https://api.github.com/repos/mafintosh/prebuild/tags","blobs_url":"https://api.github.com/repos/mafintosh/prebuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mafintosh/prebuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mafintosh/prebuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/mafintosh/prebuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mafintosh/prebuild/statuses/{sha}","languages_url":"https://api.github.com/repos/mafintosh/prebuild/languages","stargazers_url":"https://api.github.com/repos/mafintosh/prebuild/stargazers","contributors_url":"https://api.github.com/repos/mafintosh/prebuild/contributors","subscribers_url":"https://api.github.com/repos/mafintosh/prebuild/subscribers","subscription_url":"https://api.github.com/repos/mafintosh/prebuild/subscription","commits_url":"https://api.github.com/repos/mafintosh/prebuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/mafintosh/prebuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/mafintosh/prebuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/mafintosh/prebuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/mafintosh/prebuild/contents/{+path}","compare_url":"https://api.github.com/repos/mafintosh/prebuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mafintosh/prebuild/merges","archive_url":"https://api.github.com/repos/mafintosh/prebuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mafintosh/prebuild/downloads","issues_url":"https://api.github.com/repos/mafintosh/prebuild/issues{/number}","pulls_url":"https://api.github.com/repos/mafintosh/prebuild/pulls{/number}","milestones_url":"https://api.github.com/repos/mafintosh/prebuild/milestones{/number}","notifications_url":"https://api.github.com/repos/mafintosh/prebuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mafintosh/prebuild/labels{/name}","releases_url":"https://api.github.com/repos/mafintosh/prebuild/releases{/id}","deployments_url":"https://api.github.com/repos/mafintosh/prebuild/deployments","created_at":"2015-07-25T17:13:57Z","updated_at":"2016-05-20T17:24:31Z","pushed_at":"2016-05-21T03:17:38Z","git_url":"git://github.com/mafintosh/prebuild.git","ssh_url":"git@github.com:mafintosh/prebuild.git","clone_url":"https://github.com/mafintosh/prebuild.git","svn_url":"https://github.com/mafintosh/prebuild","homepage":null,"size":232,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":14,"forks":11,"open_issues":14,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mafintosh/prebuild/pulls/124"},"html":{"href":"https://github.com/mafintosh/prebuild/pull/124"},"issue":{"href":"https://api.github.com/repos/mafintosh/prebuild/issues/124"},"comments":{"href":"https://api.github.com/repos/mafintosh/prebuild/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/mafintosh/prebuild/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/mafintosh/prebuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mafintosh/prebuild/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/mafintosh/prebuild/statuses/8796c99cadb084e7f77ee1da806c222aa9627b75"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":39,"changed_files":3}}
{"actor":{"display_login":"csulok"}}