{"action":"created","issue":{"url":"https://api.github.com/repos/umple/umple/issues/697","labels_url":"https://api.github.com/repos/umple/umple/issues/697/labels{/name}","comments_url":"https://api.github.com/repos/umple/umple/issues/697/comments","events_url":"https://api.github.com/repos/umple/umple/issues/697/events","html_url":"https://github.com/umple/umple/issues/697","id":127117537,"number":697,"title":"Error due to UmpleToJava JET template changes","user":{"login":"Diusrex","id":5133160,"avatar_url":"https://avatars.githubusercontent.com/u/5133160?v=3","gravatar_id":"","url":"https://api.github.com/users/Diusrex","html_url":"https://github.com/Diusrex","followers_url":"https://api.github.com/users/Diusrex/followers","following_url":"https://api.github.com/users/Diusrex/following{/other_user}","gists_url":"https://api.github.com/users/Diusrex/gists{/gist_id}","starred_url":"https://api.github.com/users/Diusrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diusrex/subscriptions","organizations_url":"https://api.github.com/users/Diusrex/orgs","repos_url":"https://api.github.com/users/Diusrex/repos","events_url":"https://api.github.com/users/Diusrex/events{/privacy}","received_events_url":"https://api.github.com/users/Diusrex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Diusrex","id":5133160,"avatar_url":"https://avatars.githubusercontent.com/u/5133160?v=3","gravatar_id":"","url":"https://api.github.com/users/Diusrex","html_url":"https://github.com/Diusrex","followers_url":"https://api.github.com/users/Diusrex/followers","following_url":"https://api.github.com/users/Diusrex/following{/other_user}","gists_url":"https://api.github.com/users/Diusrex/gists{/gist_id}","starred_url":"https://api.github.com/users/Diusrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diusrex/subscriptions","organizations_url":"https://api.github.com/users/Diusrex/orgs","repos_url":"https://api.github.com/users/Diusrex/repos","events_url":"https://api.github.com/users/Diusrex/events{/privacy}","received_events_url":"https://api.github.com/users/Diusrex/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-01-17T19:26:39Z","updated_at":"2016-01-19T00:01:42Z","closed_at":null,"body":"In commit [328c2664d9a158092772422597a53cff5d24be98](https://github.com/umple/umple/commit/328c2664d9a158092772422597a53cff5d24be98), from November 25, there were many changes to UmpleToJava/templates/association_Get_All.jet and UmpleToJava/templates/association_Set_All.jet. These changes essentially simplified the selection of association get templates, so that only the base variable name will be used.\r\n\r\nHowever, there have not been any changes to the JET generated files UmpleToJava/src/cruise/umple/compiler/java/JavaClassGenerator.java or UmpleToJava/src/cruise/umple/compiler/java/JavaSpecGenerator.java since these changes were applied.\r\n\r\nThis means that when the JET files are regenerated (which will ONLY happen in Eclipse when the UmpleToJava project is included), there are a large number of changes to the JavaClassGenerator.java required to update it to the current template.\r\n\r\nThese changes cause the full build to fail when running testbed/src/TestHarness.ump, because when the newly updated JavaClassGenerator is used, there are a lot of errors in umple/testbed/src-gen-umple/cruise/associations/specializations/{Az, Alteration, Leg, Spatula, Wheel}.java, as well as other files, due to getters and setters being assigned the same name. They get the same name due to the previously mentioned simplification of names"},"comment":{"url":"https://api.github.com/repos/umple/umple/issues/comments/172688532","html_url":"https://github.com/umple/umple/issues/697#issuecomment-172688532","issue_url":"https://api.github.com/repos/umple/umple/issues/697","id":172688532,"user":{"login":"Diusrex","id":5133160,"avatar_url":"https://avatars.githubusercontent.com/u/5133160?v=3","gravatar_id":"","url":"https://api.github.com/users/Diusrex","html_url":"https://github.com/Diusrex","followers_url":"https://api.github.com/users/Diusrex/followers","following_url":"https://api.github.com/users/Diusrex/following{/other_user}","gists_url":"https://api.github.com/users/Diusrex/gists{/gist_id}","starred_url":"https://api.github.com/users/Diusrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diusrex/subscriptions","organizations_url":"https://api.github.com/users/Diusrex/orgs","repos_url":"https://api.github.com/users/Diusrex/repos","events_url":"https://api.github.com/users/Diusrex/events{/privacy}","received_events_url":"https://api.github.com/users/Diusrex/received_events","type":"User","site_admin":false},"created_at":"2016-01-19T00:01:42Z","updated_at":"2016-01-19T00:01:42Z","body":"That was my plan, I do not believe that the changes should be kept. After some very rough testing of what happens after reverting that commit, there are still changes applied to the JavaClassGenerator, and the tests now crash. If this is indeed the case, I will be looking through the JET templates for what else was changed and not applied, which will take more time.\r\n\r\nSince they were caused by running  codegen.xml build, will likely require changing the existing templates."}}