{"action":"created","issue":{"url":"https://api.github.com/repos/google/closure-compiler/issues/2103","repository_url":"https://api.github.com/repos/google/closure-compiler","labels_url":"https://api.github.com/repos/google/closure-compiler/issues/2103/labels{/name}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/2103/comments","events_url":"https://api.github.com/repos/google/closure-compiler/issues/2103/events","html_url":"https://github.com/google/closure-compiler/pull/2103","id":185417924,"number":2103,"title":"Convert IIFE Arguments to Local Variables","user":{"login":"ChadKillingsworth","id":1247639,"avatar_url":"https://avatars.githubusercontent.com/u/1247639?v=3","gravatar_id":"","url":"https://api.github.com/users/ChadKillingsworth","html_url":"https://github.com/ChadKillingsworth","followers_url":"https://api.github.com/users/ChadKillingsworth/followers","following_url":"https://api.github.com/users/ChadKillingsworth/following{/other_user}","gists_url":"https://api.github.com/users/ChadKillingsworth/gists{/gist_id}","starred_url":"https://api.github.com/users/ChadKillingsworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChadKillingsworth/subscriptions","organizations_url":"https://api.github.com/users/ChadKillingsworth/orgs","repos_url":"https://api.github.com/users/ChadKillingsworth/repos","events_url":"https://api.github.com/users/ChadKillingsworth/events{/privacy}","received_events_url":"https://api.github.com/users/ChadKillingsworth/received_events","type":"User","site_admin":false},"labels":[{"id":147878228,"url":"https://api.github.com/repos/google/closure-compiler/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"dimvar","id":286890,"avatar_url":"https://avatars.githubusercontent.com/u/286890?v=3","gravatar_id":"","url":"https://api.github.com/users/dimvar","html_url":"https://github.com/dimvar","followers_url":"https://api.github.com/users/dimvar/followers","following_url":"https://api.github.com/users/dimvar/following{/other_user}","gists_url":"https://api.github.com/users/dimvar/gists{/gist_id}","starred_url":"https://api.github.com/users/dimvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimvar/subscriptions","organizations_url":"https://api.github.com/users/dimvar/orgs","repos_url":"https://api.github.com/users/dimvar/repos","events_url":"https://api.github.com/users/dimvar/events{/privacy}","received_events_url":"https://api.github.com/users/dimvar/received_events","type":"User","site_admin":false},"assignees":[{"login":"dimvar","id":286890,"avatar_url":"https://avatars.githubusercontent.com/u/286890?v=3","gravatar_id":"","url":"https://api.github.com/users/dimvar","html_url":"https://github.com/dimvar","followers_url":"https://api.github.com/users/dimvar/followers","following_url":"https://api.github.com/users/dimvar/following{/other_user}","gists_url":"https://api.github.com/users/dimvar/gists{/gist_id}","starred_url":"https://api.github.com/users/dimvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimvar/subscriptions","organizations_url":"https://api.github.com/users/dimvar/orgs","repos_url":"https://api.github.com/users/dimvar/repos","events_url":"https://api.github.com/users/dimvar/events{/privacy}","received_events_url":"https://api.github.com/users/dimvar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2016-10-26T14:55:02Z","updated_at":"2016-11-01T19:13:18Z","closed_at":"2016-10-31T23:05:49Z","pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/2103","html_url":"https://github.com/google/closure-compiler/pull/2103","diff_url":"https://github.com/google/closure-compiler/pull/2103.diff","patch_url":"https://github.com/google/closure-compiler/pull/2103.patch"},"body":"Passing arguments to an IIFE seems to block a lot of future optimizations - most importantly function inlining. I believe in this case it's safe to convert the function args to local variable assignments.\n\nFixes #2100 \n"},"comment":{"url":"https://api.github.com/repos/google/closure-compiler/issues/comments/257664530","html_url":"https://github.com/google/closure-compiler/pull/2103#issuecomment-257664530","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/2103","id":257664530,"user":{"login":"dimvar","id":286890,"avatar_url":"https://avatars.githubusercontent.com/u/286890?v=3","gravatar_id":"","url":"https://api.github.com/users/dimvar","html_url":"https://github.com/dimvar","followers_url":"https://api.github.com/users/dimvar/followers","following_url":"https://api.github.com/users/dimvar/following{/other_user}","gists_url":"https://api.github.com/users/dimvar/gists{/gist_id}","starred_url":"https://api.github.com/users/dimvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimvar/subscriptions","organizations_url":"https://api.github.com/users/dimvar/orgs","repos_url":"https://api.github.com/users/dimvar/repos","events_url":"https://api.github.com/users/dimvar/events{/privacy}","received_events_url":"https://api.github.com/users/dimvar/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T19:13:18Z","updated_at":"2016-11-01T19:13:18Z","body":"As mentioned in the internal thread, I tried inlining IIFEs in the past and did it incorrectly and rolled it back. The inliner is pretty complex and I don't have time at the moment to devote to it. You know the inliner better than me. If you want to improve it for this case, to handle Chad's tests, it's totally fine by me to delete this pass. I just don't have time to look into this myself."}}
{"actor":{"display_login":"dimvar"}}