{"action":"created","comment":{"url":"https://api.github.com/repos/halide/Halide/pulls/comments/75218915","id":75218915,"diff_hunk":"@@ -544,6 +560,7 @@ WEAK void delete_kernel(void *user_context, KernelInfo *kernel) {\n         arg = next;\n     }\n     free(kernel->source);","path":"src/runtime/opengl.cpp","position":42,"original_position":42,"commit_id":"a4cbf29e5d175d32b169b64bfbc5ab520f6a1f3b","original_commit_id":"a4cbf29e5d175d32b169b64bfbc5ab520f6a1f3b","user":{"login":"shoaibkamil","id":382556,"avatar_url":"https://avatars.githubusercontent.com/u/382556?v=3","gravatar_id":"","url":"https://api.github.com/users/shoaibkamil","html_url":"https://github.com/shoaibkamil","followers_url":"https://api.github.com/users/shoaibkamil/followers","following_url":"https://api.github.com/users/shoaibkamil/following{/other_user}","gists_url":"https://api.github.com/users/shoaibkamil/gists{/gist_id}","starred_url":"https://api.github.com/users/shoaibkamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoaibkamil/subscriptions","organizations_url":"https://api.github.com/users/shoaibkamil/orgs","repos_url":"https://api.github.com/users/shoaibkamil/repos","events_url":"https://api.github.com/users/shoaibkamil/events{/privacy}","received_events_url":"https://api.github.com/users/shoaibkamil/received_events","type":"User","site_admin":false},"body":"The original implementation copies the kernel source into the `kernel` struct; previously, my PR was adding an additional (leaking) copy.  I've now removed my extra copy, but this applies to the source copied by the original implementation.\r\n\r\nOptionally, we could just not store the source.  Let me know if you want me to make that change.","created_at":"2016-08-17T22:24:10Z","updated_at":"2016-08-17T22:24:10Z","html_url":"https://github.com/halide/Halide/pull/1439#discussion_r75218915","pull_request_url":"https://api.github.com/repos/halide/Halide/pulls/1439","_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments/75218915"},"html":{"href":"https://github.com/halide/Halide/pull/1439#discussion_r75218915"},"pull_request":{"href":"https://api.github.com/repos/halide/Halide/pulls/1439"}}},"pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/1439","id":80873582,"html_url":"https://github.com/halide/Halide/pull/1439","diff_url":"https://github.com/halide/Halide/pull/1439.diff","patch_url":"https://github.com/halide/Halide/pull/1439.patch","issue_url":"https://api.github.com/repos/halide/Halide/issues/1439","number":1439,"state":"open","locked":false,"title":"OpenGL: Allow multiple glsl() stages","user":{"login":"shoaibkamil","id":382556,"avatar_url":"https://avatars.githubusercontent.com/u/382556?v=3","gravatar_id":"","url":"https://api.github.com/users/shoaibkamil","html_url":"https://github.com/shoaibkamil","followers_url":"https://api.github.com/users/shoaibkamil/followers","following_url":"https://api.github.com/users/shoaibkamil/following{/other_user}","gists_url":"https://api.github.com/users/shoaibkamil/gists{/gist_id}","starred_url":"https://api.github.com/users/shoaibkamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoaibkamil/subscriptions","organizations_url":"https://api.github.com/users/shoaibkamil/orgs","repos_url":"https://api.github.com/users/shoaibkamil/repos","events_url":"https://api.github.com/users/shoaibkamil/events{/privacy}","received_events_url":"https://api.github.com/users/shoaibkamil/received_events","type":"User","site_admin":false},"body":"This fixes the bug reported by @estollnitz and allows multiple stages to be scheduled `compute_root().glsl()`.\r\n\r\nThis is sub-optimal in terms of performance in the following ways:\r\n- currently we use a linked list to track the different kernels\r\n- we use `strcmp()` to match the called kernel with the right compiled kernel\r\n\r\nPTAL & if there's any best practices for GPU runtimes w.r.t. the above sub-optimality please advise.","created_at":"2016-08-10T21:47:40Z","updated_at":"2016-08-17T22:24:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88bd346cbceb29b87ed0f07885289d45d0eed3a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/halide/Halide/pulls/1439/commits","review_comments_url":"https://api.github.com/repos/halide/Halide/pulls/1439/comments","review_comment_url":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/halide/Halide/issues/1439/comments","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/a4cbf29e5d175d32b169b64bfbc5ab520f6a1f3b","head":{"label":"shoaibkamil:glsl_multiple_stages","ref":"glsl_multiple_stages","sha":"a4cbf29e5d175d32b169b64bfbc5ab520f6a1f3b","user":{"login":"shoaibkamil","id":382556,"avatar_url":"https://avatars.githubusercontent.com/u/382556?v=3","gravatar_id":"","url":"https://api.github.com/users/shoaibkamil","html_url":"https://github.com/shoaibkamil","followers_url":"https://api.github.com/users/shoaibkamil/followers","following_url":"https://api.github.com/users/shoaibkamil/following{/other_user}","gists_url":"https://api.github.com/users/shoaibkamil/gists{/gist_id}","starred_url":"https://api.github.com/users/shoaibkamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoaibkamil/subscriptions","organizations_url":"https://api.github.com/users/shoaibkamil/orgs","repos_url":"https://api.github.com/users/shoaibkamil/repos","events_url":"https://api.github.com/users/shoaibkamil/events{/privacy}","received_events_url":"https://api.github.com/users/shoaibkamil/received_events","type":"User","site_admin":false},"repo":{"id":52046965,"name":"Halide","full_name":"shoaibkamil/Halide","owner":{"login":"shoaibkamil","id":382556,"avatar_url":"https://avatars.githubusercontent.com/u/382556?v=3","gravatar_id":"","url":"https://api.github.com/users/shoaibkamil","html_url":"https://github.com/shoaibkamil","followers_url":"https://api.github.com/users/shoaibkamil/followers","following_url":"https://api.github.com/users/shoaibkamil/following{/other_user}","gists_url":"https://api.github.com/users/shoaibkamil/gists{/gist_id}","starred_url":"https://api.github.com/users/shoaibkamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoaibkamil/subscriptions","organizations_url":"https://api.github.com/users/shoaibkamil/orgs","repos_url":"https://api.github.com/users/shoaibkamil/repos","events_url":"https://api.github.com/users/shoaibkamil/events{/privacy}","received_events_url":"https://api.github.com/users/shoaibkamil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shoaibkamil/Halide","description":"a language for image processing and computational photography","fork":true,"url":"https://api.github.com/repos/shoaibkamil/Halide","forks_url":"https://api.github.com/repos/shoaibkamil/Halide/forks","keys_url":"https://api.github.com/repos/shoaibkamil/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoaibkamil/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoaibkamil/Halide/teams","hooks_url":"https://api.github.com/repos/shoaibkamil/Halide/hooks","issue_events_url":"https://api.github.com/repos/shoaibkamil/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/shoaibkamil/Halide/events","assignees_url":"https://api.github.com/repos/shoaibkamil/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/shoaibkamil/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/shoaibkamil/Halide/tags","blobs_url":"https://api.github.com/repos/shoaibkamil/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoaibkamil/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoaibkamil/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoaibkamil/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoaibkamil/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/shoaibkamil/Halide/languages","stargazers_url":"https://api.github.com/repos/shoaibkamil/Halide/stargazers","contributors_url":"https://api.github.com/repos/shoaibkamil/Halide/contributors","subscribers_url":"https://api.github.com/repos/shoaibkamil/Halide/subscribers","subscription_url":"https://api.github.com/repos/shoaibkamil/Halide/subscription","commits_url":"https://api.github.com/repos/shoaibkamil/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoaibkamil/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoaibkamil/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoaibkamil/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoaibkamil/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/shoaibkamil/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoaibkamil/Halide/merges","archive_url":"https://api.github.com/repos/shoaibkamil/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoaibkamil/Halide/downloads","issues_url":"https://api.github.com/repos/shoaibkamil/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/shoaibkamil/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/shoaibkamil/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/shoaibkamil/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoaibkamil/Halide/labels{/name}","releases_url":"https://api.github.com/repos/shoaibkamil/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/shoaibkamil/Halide/deployments","created_at":"2016-02-18T23:36:29Z","updated_at":"2016-02-18T23:36:33Z","pushed_at":"2016-08-17T22:17:09Z","git_url":"git://github.com/shoaibkamil/Halide.git","ssh_url":"git@github.com:shoaibkamil/Halide.git","clone_url":"https://github.com/shoaibkamil/Halide.git","svn_url":"https://github.com/shoaibkamil/Halide","homepage":"http://halide-lang.org","size":217682,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"halide:master","ref":"master","sha":"7f1e8d8d9904a0946ab620b40e0cdc77aca45b08","user":{"login":"halide","id":1548551,"avatar_url":"https://avatars.githubusercontent.com/u/1548551?v=3","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"name":"Halide","full_name":"halide/Halide","owner":{"login":"halide","id":1548551,"avatar_url":"https://avatars.githubusercontent.com/u/1548551?v=3","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/halide/Halide","description":"a language for image processing and computational photography","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2016-08-15T14:08:20Z","pushed_at":"2016-08-17T22:19:59Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":275394,"stargazers_count":1359,"watchers_count":1359,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":217,"forks":280,"open_issues":217,"watchers":1359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/1439"},"html":{"href":"https://github.com/halide/Halide/pull/1439"},"issue":{"href":"https://api.github.com/repos/halide/Halide/issues/1439"},"comments":{"href":"https://api.github.com/repos/halide/Halide/issues/1439/comments"},"review_comments":{"href":"https://api.github.com/repos/halide/Halide/pulls/1439/comments"},"review_comment":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/halide/Halide/pulls/1439/commits"},"statuses":{"href":"https://api.github.com/repos/halide/Halide/statuses/a4cbf29e5d175d32b169b64bfbc5ab520f6a1f3b"}}}}
{"actor":{"display_login":"shoaibkamil"}}