{"action":"created","issue":{"url":"https://api.github.com/repos/gradle/gradle/issues/647","repository_url":"https://api.github.com/repos/gradle/gradle","labels_url":"https://api.github.com/repos/gradle/gradle/issues/647/labels{/name}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/647/comments","events_url":"https://api.github.com/repos/gradle/gradle/issues/647/events","html_url":"https://github.com/gradle/gradle/pull/647","id":156410170,"number":647,"title":"Corrected property name srcDir in customizedLayout","user":{"login":"bdurepo1","id":5446138,"avatar_url":"https://avatars.githubusercontent.com/u/5446138?v=3","gravatar_id":"","url":"https://api.github.com/users/bdurepo1","html_url":"https://github.com/bdurepo1","followers_url":"https://api.github.com/users/bdurepo1/followers","following_url":"https://api.github.com/users/bdurepo1/following{/other_user}","gists_url":"https://api.github.com/users/bdurepo1/gists{/gist_id}","starred_url":"https://api.github.com/users/bdurepo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdurepo1/subscriptions","organizations_url":"https://api.github.com/users/bdurepo1/orgs","repos_url":"https://api.github.com/users/bdurepo1/repos","events_url":"https://api.github.com/users/bdurepo1/events{/privacy}","received_events_url":"https://api.github.com/users/bdurepo1/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gradle/gradle/labels/cla-received","name":"cla-received","color":"207de5"},{"url":"https://api.github.com/repos/gradle/gradle/labels/documentation","name":"documentation","color":"fad8c7"}],"state":"open","locked":false,"assignee":{"login":"wolfs","id":423186,"avatar_url":"https://avatars.githubusercontent.com/u/423186?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfs","html_url":"https://github.com/wolfs","followers_url":"https://api.github.com/users/wolfs/followers","following_url":"https://api.github.com/users/wolfs/following{/other_user}","gists_url":"https://api.github.com/users/wolfs/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfs/subscriptions","organizations_url":"https://api.github.com/users/wolfs/orgs","repos_url":"https://api.github.com/users/wolfs/repos","events_url":"https://api.github.com/users/wolfs/events{/privacy}","received_events_url":"https://api.github.com/users/wolfs/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/gradle/gradle/milestones/2","html_url":"https://github.com/gradle/gradle/milestones/waiting-for-gradle-team","labels_url":"https://api.github.com/repos/gradle/gradle/milestones/2/labels","id":702038,"number":2,"title":"waiting-for-gradle-team","description":"","creator":{"login":"adammurdoch","id":99316,"avatar_url":"https://avatars.githubusercontent.com/u/99316?v=3","gravatar_id":"","url":"https://api.github.com/users/adammurdoch","html_url":"https://github.com/adammurdoch","followers_url":"https://api.github.com/users/adammurdoch/followers","following_url":"https://api.github.com/users/adammurdoch/following{/other_user}","gists_url":"https://api.github.com/users/adammurdoch/gists{/gist_id}","starred_url":"https://api.github.com/users/adammurdoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammurdoch/subscriptions","organizations_url":"https://api.github.com/users/adammurdoch/orgs","repos_url":"https://api.github.com/users/adammurdoch/repos","events_url":"https://api.github.com/users/adammurdoch/events{/privacy}","received_events_url":"https://api.github.com/users/adammurdoch/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":25,"state":"open","created_at":"2014-06-26T03:41:50Z","updated_at":"2016-06-06T06:23:41Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-05-24T03:00:52Z","updated_at":"2016-06-06T14:16:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/647","html_url":"https://github.com/gradle/gradle/pull/647","diff_url":"https://github.com/gradle/gradle/pull/647.diff","patch_url":"https://github.com/gradle/gradle/pull/647.patch"},"body":"Any of the checked boxes below indicate that I took action:\r\n\r\n- [x] Reviewed the [Contribution Guidelines](https://github.com/gradle/gradle/blob/master/CONTRIBUTING.md#contribution-workflow).\r\n- [x] Signed the [Gradle CLA](http://gradle.org/contributor-license-agreement/).\r\n- [x] Ensured that basic checks pass: `./gradlew quickCheck`\r\n\r\nFor all non-trivial changes that modify the behavior or public API:\r\n\r\n- [ ] Before submitting a pull request, I started a discussion on the\r\n[Gradle developer list](https://groups.google.com/forum/#!forum/gradle-dev)\r\nor can reference a [JIRA issue](https://issues.gradle.org/secure/Dashboard.jspa).\r\n- [ ] I wrote a design document. A design document can be\r\nbrief but explains the use case or problem you are trying to solve,\r\ntouches on the planned implementation approach as well as the test cases\r\nthat verify the behavior. Optimally, design documents should be submitted\r\nas a separate pull request. [Samples](https://github.com/gradle/gradle/tree/master/design-docs)\r\ncan be found in the Gradle GitHub repository. Please let us know if you need help with\r\ncreating the design document. We are happy to help!\r\n- [ ] The pull request contains an appropriate level of unit and integration\r\ntest coverage to verify the behavior. Before submitting the pull request\r\nI ran a build on your local machine via the command\r\n`./gradlew quickCheck <impacted-subproject>:check`.\r\n- [ ] The pull request updates the Gradle documentation like user guide,\r\nDSL reference and Javadocs where applicable.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gradle/gradle/issues/comments/223971843","html_url":"https://github.com/gradle/gradle/pull/647#issuecomment-223971843","issue_url":"https://api.github.com/repos/gradle/gradle/issues/647","id":223971843,"user":{"login":"big-guy","id":5387972,"avatar_url":"https://avatars.githubusercontent.com/u/5387972?v=3","gravatar_id":"","url":"https://api.github.com/users/big-guy","html_url":"https://github.com/big-guy","followers_url":"https://api.github.com/users/big-guy/followers","following_url":"https://api.github.com/users/big-guy/following{/other_user}","gists_url":"https://api.github.com/users/big-guy/gists{/gist_id}","starred_url":"https://api.github.com/users/big-guy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-guy/subscriptions","organizations_url":"https://api.github.com/users/big-guy/orgs","repos_url":"https://api.github.com/users/big-guy/repos","events_url":"https://api.github.com/users/big-guy/events{/privacy}","received_events_url":"https://api.github.com/users/big-guy/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T14:16:11Z","updated_at":"2016-06-06T14:16:11Z","body":"Hey @bdurepo1, thanks for the interest in trying to improve Gradle's documentation.\r\n\r\nI think you've found a good example of where things can be confusing for everyone.  The table in 45.7.1 is referring to important properties available in a [`SourceSet`](https://docs.gradle.org/current/dsl/org.gradle.api.tasks.SourceSet.html).  Properties here are in the Java Bean/Groovy sense (fields that have a getter and setter).  In this case, `java.srcDirs` is referring to the `srcDirs` property on [`SourceDirectorySet`](https://docs.gradle.org/current/javadoc/org/gradle/api/file/SourceDirectorySet.html), which is made up of `setSrcDirs` and `getSrcDirs` methods.  We use the same terminology in the DSL section of the user guide.  There's also a `srcDir` and a `srcDirs` method, but these are convenience methods for `getSrcDirs().add(...)` or `getSrcDirs().addAll(...)`.  I think we need to keep the table consistent (and refer to properties), which means we need to keep `java.srcDirs`. \r\n\r\nCould you describe a bit of what you had trouble with from the Udacity course? If I had to guess, most examples probably use `srcDir` and not `srcDirs` to add directories to a source set and it's not clear which type you could look at to find that method.\r\n\r\nIt's really helpful to have your fresh perspective on these things. Would it be clearer to you if separate from the 45.7.1 table there was a \"Important source set directory methods\" that called out `srcDir`, `srcDirs`, `include` and `exclude`?  In that case, we'd remove `resources.srcDirs` and `java.srcDirs` from the existing table and put the new table directly underneath. "}}
{"actor":{"display_login":"big-guy"}}