{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34800","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34800/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34800/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34800/events","html_url":"https://github.com/kubernetes/kubernetes/issues/34800","id":182970145,"number":34800,"title":"kubectl edit brokenness editing volumeMounts (list of struct)","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/component/kubectl","name":"component/kubectl","color":"0052cc"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/ux","name":"team/ux","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"ymqytw","id":2589105,"avatar_url":"https://avatars.githubusercontent.com/u/2589105?v=3","gravatar_id":"","url":"https://api.github.com/users/ymqytw","html_url":"https://github.com/ymqytw","followers_url":"https://api.github.com/users/ymqytw/followers","following_url":"https://api.github.com/users/ymqytw/following{/other_user}","gists_url":"https://api.github.com/users/ymqytw/gists{/gist_id}","starred_url":"https://api.github.com/users/ymqytw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymqytw/subscriptions","organizations_url":"https://api.github.com/users/ymqytw/orgs","repos_url":"https://api.github.com/users/ymqytw/repos","events_url":"https://api.github.com/users/ymqytw/events{/privacy}","received_events_url":"https://api.github.com/users/ymqytw/received_events","type":"User","site_admin":false},"assignees":[{"login":"ymqytw","id":2589105,"avatar_url":"https://avatars.githubusercontent.com/u/2589105?v=3","gravatar_id":"","url":"https://api.github.com/users/ymqytw","html_url":"https://github.com/ymqytw","followers_url":"https://api.github.com/users/ymqytw/followers","following_url":"https://api.github.com/users/ymqytw/following{/other_user}","gists_url":"https://api.github.com/users/ymqytw/gists{/gist_id}","starred_url":"https://api.github.com/users/ymqytw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymqytw/subscriptions","organizations_url":"https://api.github.com/users/ymqytw/orgs","repos_url":"https://api.github.com/users/ymqytw/repos","events_url":"https://api.github.com/users/ymqytw/events{/privacy}","received_events_url":"https://api.github.com/users/ymqytw/received_events","type":"User","site_admin":false},{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-10-14T05:59:56Z","updated_at":"2016-10-17T21:33:35Z","closed_at":null,"body":"Start with:\r\n\r\n```        \r\n       volumeMounts:\r\n        - mountPath: /vol\r\n          name: vol \r\n        - mountPath: /vol-456                                                                                                                                 \r\n          name: vol \r\n          subPath: d456\r\n```\r\n\r\nEdit to:\r\n\r\n```\r\n        volumeMounts:\r\n        - mountPath: /vol\r\n          name: vol \r\n        - mountPath: /vol-d2\r\n          name: vol\r\n          subPath: d2     \r\n```\r\n\r\nRead back what happened:\r\n\r\n```\r\n        volumeMounts:\r\n        - mountPath: /vol-d2\r\n          name: vol \r\n          subPath: d2\r\n        - mountPath: /vol-456\r\n          name: vol \r\n          subPath: d456\r\n```\r\n\r\nIt synthesized a COMPLETELY WRONG result.  At this point, I can not, in good conscience, advocate using kubectl edit.\r\n\r\nCan I please have `kubectl edit --replace` that doesn't go through patch brokenness.  Or better, make that default for 1.5 and make `kubectl edit --patch`   be the broken (but eventually fixed) path."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/254341016","html_url":"https://github.com/kubernetes/kubernetes/issues/34800#issuecomment-254341016","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34800","id":254341016,"user":{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T21:33:35Z","updated_at":"2016-10-17T21:33:35Z","body":"Right, the merge key needs to be unique. Maybe change to use `MountPath` as merge key? It looks to be unique. But it will be a breaking change, I guess the server regards the patch generated by old clients as invalid."}}
{"actor":{"display_login":"caesarxuchao"}}