{"action":"opened","issue":{"url":"https://api.github.com/repos/ankitbaphna/NYTimesSearch/issues/1","repository_url":"https://api.github.com/repos/ankitbaphna/NYTimesSearch","labels_url":"https://api.github.com/repos/ankitbaphna/NYTimesSearch/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ankitbaphna/NYTimesSearch/issues/1/comments","events_url":"https://api.github.com/repos/ankitbaphna/NYTimesSearch/issues/1/events","html_url":"https://github.com/ankitbaphna/NYTimesSearch/issues/1","id":185030801,"number":1,"title":"Project Feedback!","user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-25T06:37:35Z","updated_at":"2016-10-25T06:37:35Z","closed_at":null,"body":":+1: Good job getting all required and a few optional stories done. A few notes after checking out the code:\r\n\r\n* Great work on organising source code. \r\n* Nice to see you used action bar for searching\r\n* Good job on getting the Share functionality working\r\n* Great job implementing DialogFragment for filters.\r\n* Good job using the ConnectivityManager to check for network availability\r\n* Properly reused the single base method in search activity to fetch results for both initial load and the pagination\r\n* Great job using staggered grid view\r\n* Great job using ButterKnife, it makes the code much cleaner.\r\n* Good job using RecyclerView\r\n\r\nAlso, here's a more detailed [Project 2 Feedback Guide here](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) which covers the most common issues with this submitted project. Read through the [feedback guide point-by-point](http://courses.codepath.com/snippets/intro_to_android/project_2_feedback) to determine how you could improve your submission.\r\n\r\nLet us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation."}}
{"actor":{"display_login":"codepathreview"}}