{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/70076524","id":70076524,"diff_hunk":"@@ -87,6 +95,33 @@ angular.module('openshiftConsole')\n             $scope.deploymentConfig = deploymentConfig;\n             updateHPAWarnings();\n             ImageStreamResolver.fetchReferencedImageStreamImages([deploymentConfig.spec.template], $scope.imagesByDockerReference, $scope.imageStreamImageRefByDockerReference, context);\n+            copyDeploymentConfigAndEnsureEnv(deploymentConfig);\n+            $scope.saveEnvVars = function() {\n+              // copy again to clean off any of angulars $$ vars from the template","path":"app/scripts/controllers/deploymentConfig.js","position":21,"original_position":21,"commit_id":"48b5e5d1b58d61768595aac29518a0b80e33a3ac","original_commit_id":"48b5e5d1b58d61768595aac29518a0b80e33a3ac","user":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"body":"@benjaminapetersen?","created_at":"2016-07-08T13:51:40Z","updated_at":"2016-07-08T13:51:40Z","html_url":"https://github.com/openshift/origin-web-console/pull/121#discussion_r70076524","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/70076524"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/121#discussion_r70076524"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/121","id":75717553,"html_url":"https://github.com/openshift/origin-web-console/pull/121","diff_url":"https://github.com/openshift/origin-web-console/pull/121.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/121.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/121","number":121,"state":"open","locked":false,"title":"[WIP] Integrating angular-key-value-editor directive for build configs...","user":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"body":"...and deployment configs.  Also updated the Environment tabs of build, deployment, and pod pages to include \"Environment Variables\" in the heading.\r\n\r\n@benjaminapetersen, @jwforres, PTAL.","created_at":"2016-06-29T20:40:41Z","updated_at":"2016-07-08T13:51:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46e45f19a6976bb20d2ed23743d0fef18aaae32a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/121/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/121/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/121/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/48b5e5d1b58d61768595aac29518a0b80e33a3ac","head":{"label":"rhamilto:angular-key-value-editor","ref":"angular-key-value-editor","sha":"48b5e5d1b58d61768595aac29518a0b80e33a3ac","user":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"repo":{"id":58545493,"name":"origin-web-console","full_name":"rhamilto/origin-web-console","owner":{"login":"rhamilto","id":895728,"avatar_url":"https://avatars.githubusercontent.com/u/895728?v=3","gravatar_id":"","url":"https://api.github.com/users/rhamilto","html_url":"https://github.com/rhamilto","followers_url":"https://api.github.com/users/rhamilto/followers","following_url":"https://api.github.com/users/rhamilto/following{/other_user}","gists_url":"https://api.github.com/users/rhamilto/gists{/gist_id}","starred_url":"https://api.github.com/users/rhamilto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhamilto/subscriptions","organizations_url":"https://api.github.com/users/rhamilto/orgs","repos_url":"https://api.github.com/users/rhamilto/repos","events_url":"https://api.github.com/users/rhamilto/events{/privacy}","received_events_url":"https://api.github.com/users/rhamilto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhamilto/origin-web-console","description":"","fork":true,"url":"https://api.github.com/repos/rhamilto/origin-web-console","forks_url":"https://api.github.com/repos/rhamilto/origin-web-console/forks","keys_url":"https://api.github.com/repos/rhamilto/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhamilto/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhamilto/origin-web-console/teams","hooks_url":"https://api.github.com/repos/rhamilto/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/rhamilto/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/rhamilto/origin-web-console/events","assignees_url":"https://api.github.com/repos/rhamilto/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/rhamilto/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/rhamilto/origin-web-console/tags","blobs_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhamilto/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/rhamilto/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/rhamilto/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/rhamilto/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/rhamilto/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/rhamilto/origin-web-console/subscription","commits_url":"https://api.github.com/repos/rhamilto/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhamilto/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhamilto/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhamilto/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhamilto/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/rhamilto/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhamilto/origin-web-console/merges","archive_url":"https://api.github.com/repos/rhamilto/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhamilto/origin-web-console/downloads","issues_url":"https://api.github.com/repos/rhamilto/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/rhamilto/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/rhamilto/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/rhamilto/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhamilto/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/rhamilto/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/rhamilto/origin-web-console/deployments","created_at":"2016-05-11T13:04:40Z","updated_at":"2016-05-11T13:04:42Z","pushed_at":"2016-07-08T13:00:30Z","git_url":"git://github.com/rhamilto/origin-web-console.git","ssh_url":"git@github.com:rhamilto/origin-web-console.git","clone_url":"https://github.com/rhamilto/origin-web-console.git","svn_url":"https://github.com/rhamilto/origin-web-console","homepage":null,"size":6807,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0ead1450af6cb408548e067b52f2324f41d13767","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-06-20T16:37:07Z","pushed_at":"2016-07-08T13:00:30Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":7273,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":37,"forks":25,"open_issues":37,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/121"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/121"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/121"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/48b5e5d1b58d61768595aac29518a0b80e33a3ac"}}}}
{"actor":{"display_login":"rhamilto"}}