{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/92048080","pull_request_review_id":12557911,"id":92048080,"diff_hunk":"@@ -276,8 +276,12 @@ struct ASTContext::Implementation {\n     ~Arena() {\n       for (auto &conformance : SpecializedConformances)\n         conformance.~SpecializedProtocolConformance();\n+      // Work around MSVC warning: local variable is initialized but\n+      // not referenced.\n+#pragma warning (disable: 4189)","path":"lib/AST/ASTContext.cpp","position":6,"original_position":6,"commit_id":"9188bfb7bc7cb79a2e6441353a64e22a260141c4","original_commit_id":"9188bfb7bc7cb79a2e6441353a64e22a260141c4","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"We do get the following warning:\r\n\r\n> C:\\Users\\Lukey\\Documents\\GitHub\\my-swift\\swift\\lib\\AST\\ASTContext.cpp(282): warning C4189: 'conformance': local variable is initialized but not referenced\r\n\r\nvery weird...","created_at":"2016-12-12T21:48:30Z","updated_at":"2016-12-12T21:48:30Z","html_url":"https://github.com/apple/swift/pull/5948#discussion_r92048080","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/5948","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/92048080"},"html":{"href":"https://github.com/apple/swift/pull/5948#discussion_r92048080"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/5948"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5948","id":95536744,"html_url":"https://github.com/apple/swift/pull/5948","diff_url":"https://github.com/apple/swift/pull/5948.diff","patch_url":"https://github.com/apple/swift/pull/5948.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5948","number":5948,"state":"open","locked":false,"title":"Support building swift/AST with MSVC on Windows","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"Relies on apple/swift-llvm#33 but can be merged before","created_at":"2016-11-28T16:58:36Z","updated_at":"2016-12-12T21:48:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e037c6e7ce8d7f815ec919950a8e5509c2028e0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5948/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5948/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5948/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/9188bfb7bc7cb79a2e6441353a64e22a260141c4","head":{"label":"hughbe:ast-msvc","ref":"ast-msvc","sha":"9188bfb7bc7cb79a2e6441353a64e22a260141c4","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":52473012,"name":"swift","full_name":"hughbe/swift","owner":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughbe/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/hughbe/swift","forks_url":"https://api.github.com/repos/hughbe/swift/forks","keys_url":"https://api.github.com/repos/hughbe/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/swift/teams","hooks_url":"https://api.github.com/repos/hughbe/swift/hooks","issue_events_url":"https://api.github.com/repos/hughbe/swift/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/swift/events","assignees_url":"https://api.github.com/repos/hughbe/swift/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/swift/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/swift/tags","blobs_url":"https://api.github.com/repos/hughbe/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/swift/languages","stargazers_url":"https://api.github.com/repos/hughbe/swift/stargazers","contributors_url":"https://api.github.com/repos/hughbe/swift/contributors","subscribers_url":"https://api.github.com/repos/hughbe/swift/subscribers","subscription_url":"https://api.github.com/repos/hughbe/swift/subscription","commits_url":"https://api.github.com/repos/hughbe/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/swift/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/swift/merges","archive_url":"https://api.github.com/repos/hughbe/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/swift/downloads","issues_url":"https://api.github.com/repos/hughbe/swift/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/swift/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/swift/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/swift/deployments","created_at":"2016-02-24T20:42:27Z","updated_at":"2016-02-24T20:42:53Z","pushed_at":"2016-12-12T21:41:45Z","git_url":"git://github.com/hughbe/swift.git","ssh_url":"git@github.com:hughbe/swift.git","clone_url":"https://github.com/hughbe/swift.git","svn_url":"https://github.com/hughbe/swift","homepage":"https://swift.org/","size":137303,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d93d24bb07e5fa5f2a733c0f430c55c8590390d5","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-12-12T21:43:46Z","pushed_at":"2016-12-12T21:45:07Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":211313,"stargazers_count":35565,"watchers_count":35565,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5164,"mirror_url":null,"open_issues_count":133,"forks":5164,"open_issues":133,"watchers":35565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5948"},"html":{"href":"https://github.com/apple/swift/pull/5948"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5948"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5948/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5948/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5948/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/9188bfb7bc7cb79a2e6441353a64e22a260141c4"}}}}
{"actor":{"display_login":"hughbe"}}