{"action":"created","issue":{"url":"https://api.github.com/repos/testem/testem/issues/1037","repository_url":"https://api.github.com/repos/testem/testem","labels_url":"https://api.github.com/repos/testem/testem/issues/1037/labels{/name}","comments_url":"https://api.github.com/repos/testem/testem/issues/1037/comments","events_url":"https://api.github.com/repos/testem/testem/issues/1037/events","html_url":"https://github.com/testem/testem/pull/1037","id":193648823,"number":1037,"title":"Adding option to write launcher output to file.","user":{"login":"paulot","id":1701002,"avatar_url":"https://avatars.githubusercontent.com/u/1701002?v=3","gravatar_id":"","url":"https://api.github.com/users/paulot","html_url":"https://github.com/paulot","followers_url":"https://api.github.com/users/paulot/followers","following_url":"https://api.github.com/users/paulot/following{/other_user}","gists_url":"https://api.github.com/users/paulot/gists{/gist_id}","starred_url":"https://api.github.com/users/paulot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulot/subscriptions","organizations_url":"https://api.github.com/users/paulot/orgs","repos_url":"https://api.github.com/users/paulot/repos","events_url":"https://api.github.com/users/paulot/events{/privacy}","received_events_url":"https://api.github.com/users/paulot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-06T00:16:23Z","updated_at":"2016-12-06T19:07:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/testem/testem/pulls/1037","html_url":"https://github.com/testem/testem/pull/1037","diff_url":"https://github.com/testem/testem/pull/1037.diff","patch_url":"https://github.com/testem/testem/pull/1037.patch"},"body":"One common issue that we have at LinkedIn when using Testem is that we have no information on the underlying launcher that is propagated to the user. When running thousands of tests, it is not uncommon that browsers crash. This PR adds a flag \"log_launchers\" that when set to true will write the launcher's stdout and stderr to a file. This is particularly useful when things crash in ci, as we can have phantomjs' debug information propagated to the developer, rather than swallowed by Testem."},"comment":{"url":"https://api.github.com/repos/testem/testem/issues/comments/265241921","html_url":"https://github.com/testem/testem/pull/1037#issuecomment-265241921","issue_url":"https://api.github.com/repos/testem/testem/issues/1037","id":265241921,"user":{"login":"johanneswuerbach","id":864578,"avatar_url":"https://avatars.githubusercontent.com/u/864578?v=3","gravatar_id":"","url":"https://api.github.com/users/johanneswuerbach","html_url":"https://github.com/johanneswuerbach","followers_url":"https://api.github.com/users/johanneswuerbach/followers","following_url":"https://api.github.com/users/johanneswuerbach/following{/other_user}","gists_url":"https://api.github.com/users/johanneswuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/johanneswuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanneswuerbach/subscriptions","organizations_url":"https://api.github.com/users/johanneswuerbach/orgs","repos_url":"https://api.github.com/users/johanneswuerbach/repos","events_url":"https://api.github.com/users/johanneswuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/johanneswuerbach/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T19:07:48Z","updated_at":"2016-12-06T19:07:48Z","body":"It feels like you want to log in all cases where `toResult` is called https://github.com/testem/testem/blob/master/lib/runners/browser_test_runner.js#L79\r\n\r\nThose are usually out-of-order exits when the process dies, the browser never connects or disconnects in the middle."}}
{"actor":{"display_login":"johanneswuerbach"}}