{"action":"created","issue":{"url":"https://api.github.com/repos/Jasig/uPortal/issues/699","repository_url":"https://api.github.com/repos/Jasig/uPortal","labels_url":"https://api.github.com/repos/Jasig/uPortal/issues/699/labels{/name}","comments_url":"https://api.github.com/repos/Jasig/uPortal/issues/699/comments","events_url":"https://api.github.com/repos/Jasig/uPortal/issues/699/events","html_url":"https://github.com/Jasig/uPortal/pull/699","id":168930400,"number":699,"title":"Up 4694 ldap encoding","user":{"login":"jhelmer-unicon","id":7871998,"avatar_url":"https://avatars.githubusercontent.com/u/7871998?v=3","gravatar_id":"","url":"https://api.github.com/users/jhelmer-unicon","html_url":"https://github.com/jhelmer-unicon","followers_url":"https://api.github.com/users/jhelmer-unicon/followers","following_url":"https://api.github.com/users/jhelmer-unicon/following{/other_user}","gists_url":"https://api.github.com/users/jhelmer-unicon/gists{/gist_id}","starred_url":"https://api.github.com/users/jhelmer-unicon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhelmer-unicon/subscriptions","organizations_url":"https://api.github.com/users/jhelmer-unicon/orgs","repos_url":"https://api.github.com/users/jhelmer-unicon/repos","events_url":"https://api.github.com/users/jhelmer-unicon/events{/privacy}","received_events_url":"https://api.github.com/users/jhelmer-unicon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-02T16:30:59Z","updated_at":"2016-08-09T21:08:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Jasig/uPortal/pulls/699","html_url":"https://github.com/Jasig/uPortal/pull/699","diff_url":"https://github.com/Jasig/uPortal/pull/699.diff","patch_url":"https://github.com/Jasig/uPortal/pull/699.patch"},"body":"Update to @mgillian's PR (https://github.com/Jasig/uPortal/pull/678).   I'll close his PR.   The only real difference is using the spring LdapEncoder vs. rolling our own.   \r\n\r\nThere were some suggestions to try and move to LdapQueryBuilder (which ultimately, also just uses LdapEncoder).  That change is much more significant because it requires updating the spring-ldap lib and rewriting large chunks of code.  For now, I want to focus on the core issue.\r\n\r\nhttps://issues.jasig.org/browse/UP-4694"},"comment":{"url":"https://api.github.com/repos/Jasig/uPortal/issues/comments/238691967","html_url":"https://github.com/Jasig/uPortal/pull/699#issuecomment-238691967","issue_url":"https://api.github.com/repos/Jasig/uPortal/issues/699","id":238691967,"user":{"login":"jhelmer-unicon","id":7871998,"avatar_url":"https://avatars.githubusercontent.com/u/7871998?v=3","gravatar_id":"","url":"https://api.github.com/users/jhelmer-unicon","html_url":"https://github.com/jhelmer-unicon","followers_url":"https://api.github.com/users/jhelmer-unicon/followers","following_url":"https://api.github.com/users/jhelmer-unicon/following{/other_user}","gists_url":"https://api.github.com/users/jhelmer-unicon/gists{/gist_id}","starred_url":"https://api.github.com/users/jhelmer-unicon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhelmer-unicon/subscriptions","organizations_url":"https://api.github.com/users/jhelmer-unicon/orgs","repos_url":"https://api.github.com/users/jhelmer-unicon/repos","events_url":"https://api.github.com/users/jhelmer-unicon/events{/privacy}","received_events_url":"https://api.github.com/users/jhelmer-unicon/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T21:08:14Z","updated_at":"2016-08-09T21:08:14Z","body":"Last call for reviews on this.  Barring objections, will probably merge on Thurs."}}
{"actor":{"display_login":"jhelmer-unicon"}}