{"action":"created","comment":{"url":"https://api.github.com/repos/iNavFlight/inav/pulls/comments/94260391","pull_request_review_id":14791871,"id":94260391,"diff_hunk":"@@ -79,6 +79,7 @@ typedef struct {\n     // Dterm notch filtering\n #ifdef USE_DTERM_NOTCH\n     biquadFilter_t deltaNotchFilter;\n+    bool isNotchFilterInitialized;","path":"src/main/flight/pid.c","position":null,"original_position":4,"commit_id":"34e18a6657970be6308a43d4783407455d89f139","original_commit_id":"34e18a6657970be6308a43d4783407455d89f139","user":{"login":"martinbudden","id":194586,"avatar_url":"https://avatars.githubusercontent.com/u/194586?v=3","gravatar_id":"","url":"https://api.github.com/users/martinbudden","html_url":"https://github.com/martinbudden","followers_url":"https://api.github.com/users/martinbudden/followers","following_url":"https://api.github.com/users/martinbudden/following{/other_user}","gists_url":"https://api.github.com/users/martinbudden/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbudden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbudden/subscriptions","organizations_url":"https://api.github.com/users/martinbudden/orgs","repos_url":"https://api.github.com/users/martinbudden/repos","events_url":"https://api.github.com/users/martinbudden/events{/privacy}","received_events_url":"https://api.github.com/users/martinbudden/received_events","type":"User","site_admin":false},"body":"No, please do not do this. Lazy initialisation is just not appropriate here. What we need to do is ensure the initialisation sequence is correct, not have a work around like this.","created_at":"2016-12-30T21:56:25Z","updated_at":"2016-12-30T21:56:25Z","html_url":"https://github.com/iNavFlight/inav/pull/972#discussion_r94260391","pull_request_url":"https://api.github.com/repos/iNavFlight/inav/pulls/972","_links":{"self":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/comments/94260391"},"html":{"href":"https://github.com/iNavFlight/inav/pull/972#discussion_r94260391"},"pull_request":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/972"}}},"pull_request":{"url":"https://api.github.com/repos/iNavFlight/inav/pulls/972","id":99374171,"html_url":"https://github.com/iNavFlight/inav/pull/972","diff_url":"https://github.com/iNavFlight/inav/pull/972.diff","patch_url":"https://github.com/iNavFlight/inav/pull/972.patch","issue_url":"https://api.github.com/repos/iNavFlight/inav/issues/972","number":972,"state":"open","locked":false,"title":"Added Gyro notch filter and dterm setpoint weight","user":{"login":"andre92","id":4846411,"avatar_url":"https://avatars.githubusercontent.com/u/4846411?v=3","gravatar_id":"","url":"https://api.github.com/users/andre92","html_url":"https://github.com/andre92","followers_url":"https://api.github.com/users/andre92/followers","following_url":"https://api.github.com/users/andre92/following{/other_user}","gists_url":"https://api.github.com/users/andre92/gists{/gist_id}","starred_url":"https://api.github.com/users/andre92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre92/subscriptions","organizations_url":"https://api.github.com/users/andre92/orgs","repos_url":"https://api.github.com/users/andre92/repos","events_url":"https://api.github.com/users/andre92/events{/privacy}","received_events_url":"https://api.github.com/users/andre92/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-26T14:35:38Z","updated_at":"2016-12-30T21:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e097f21ffd84ef778f5cf53093cfb8b091cae66d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/iNavFlight/inav/milestones/10","html_url":"https://github.com/iNavFlight/inav/milestone/10","labels_url":"https://api.github.com/repos/iNavFlight/inav/milestones/10/labels","id":2126626,"number":10,"title":"1.6","description":"","creator":{"login":"digitalentity","id":11059099,"avatar_url":"https://avatars.githubusercontent.com/u/11059099?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalentity","html_url":"https://github.com/digitalentity","followers_url":"https://api.github.com/users/digitalentity/followers","following_url":"https://api.github.com/users/digitalentity/following{/other_user}","gists_url":"https://api.github.com/users/digitalentity/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalentity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalentity/subscriptions","organizations_url":"https://api.github.com/users/digitalentity/orgs","repos_url":"https://api.github.com/users/digitalentity/repos","events_url":"https://api.github.com/users/digitalentity/events{/privacy}","received_events_url":"https://api.github.com/users/digitalentity/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":6,"state":"open","created_at":"2016-11-10T09:15:23Z","updated_at":"2016-12-30T21:04:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/iNavFlight/inav/pulls/972/commits","review_comments_url":"https://api.github.com/repos/iNavFlight/inav/pulls/972/comments","review_comment_url":"https://api.github.com/repos/iNavFlight/inav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iNavFlight/inav/issues/972/comments","statuses_url":"https://api.github.com/repos/iNavFlight/inav/statuses/34e18a6657970be6308a43d4783407455d89f139","head":{"label":"andre92:gyro-notch-filter","ref":"gyro-notch-filter","sha":"34e18a6657970be6308a43d4783407455d89f139","user":{"login":"andre92","id":4846411,"avatar_url":"https://avatars.githubusercontent.com/u/4846411?v=3","gravatar_id":"","url":"https://api.github.com/users/andre92","html_url":"https://github.com/andre92","followers_url":"https://api.github.com/users/andre92/followers","following_url":"https://api.github.com/users/andre92/following{/other_user}","gists_url":"https://api.github.com/users/andre92/gists{/gist_id}","starred_url":"https://api.github.com/users/andre92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre92/subscriptions","organizations_url":"https://api.github.com/users/andre92/orgs","repos_url":"https://api.github.com/users/andre92/repos","events_url":"https://api.github.com/users/andre92/events{/privacy}","received_events_url":"https://api.github.com/users/andre92/received_events","type":"User","site_admin":false},"repo":{"id":77388875,"name":"inav","full_name":"andre92/inav","owner":{"login":"andre92","id":4846411,"avatar_url":"https://avatars.githubusercontent.com/u/4846411?v=3","gravatar_id":"","url":"https://api.github.com/users/andre92","html_url":"https://github.com/andre92","followers_url":"https://api.github.com/users/andre92/followers","following_url":"https://api.github.com/users/andre92/following{/other_user}","gists_url":"https://api.github.com/users/andre92/gists{/gist_id}","starred_url":"https://api.github.com/users/andre92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre92/subscriptions","organizations_url":"https://api.github.com/users/andre92/orgs","repos_url":"https://api.github.com/users/andre92/repos","events_url":"https://api.github.com/users/andre92/events{/privacy}","received_events_url":"https://api.github.com/users/andre92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andre92/inav","description":"INAV: Navigation-enabled flight control software","fork":true,"url":"https://api.github.com/repos/andre92/inav","forks_url":"https://api.github.com/repos/andre92/inav/forks","keys_url":"https://api.github.com/repos/andre92/inav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andre92/inav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andre92/inav/teams","hooks_url":"https://api.github.com/repos/andre92/inav/hooks","issue_events_url":"https://api.github.com/repos/andre92/inav/issues/events{/number}","events_url":"https://api.github.com/repos/andre92/inav/events","assignees_url":"https://api.github.com/repos/andre92/inav/assignees{/user}","branches_url":"https://api.github.com/repos/andre92/inav/branches{/branch}","tags_url":"https://api.github.com/repos/andre92/inav/tags","blobs_url":"https://api.github.com/repos/andre92/inav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andre92/inav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andre92/inav/git/refs{/sha}","trees_url":"https://api.github.com/repos/andre92/inav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andre92/inav/statuses/{sha}","languages_url":"https://api.github.com/repos/andre92/inav/languages","stargazers_url":"https://api.github.com/repos/andre92/inav/stargazers","contributors_url":"https://api.github.com/repos/andre92/inav/contributors","subscribers_url":"https://api.github.com/repos/andre92/inav/subscribers","subscription_url":"https://api.github.com/repos/andre92/inav/subscription","commits_url":"https://api.github.com/repos/andre92/inav/commits{/sha}","git_commits_url":"https://api.github.com/repos/andre92/inav/git/commits{/sha}","comments_url":"https://api.github.com/repos/andre92/inav/comments{/number}","issue_comment_url":"https://api.github.com/repos/andre92/inav/issues/comments{/number}","contents_url":"https://api.github.com/repos/andre92/inav/contents/{+path}","compare_url":"https://api.github.com/repos/andre92/inav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andre92/inav/merges","archive_url":"https://api.github.com/repos/andre92/inav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andre92/inav/downloads","issues_url":"https://api.github.com/repos/andre92/inav/issues{/number}","pulls_url":"https://api.github.com/repos/andre92/inav/pulls{/number}","milestones_url":"https://api.github.com/repos/andre92/inav/milestones{/number}","notifications_url":"https://api.github.com/repos/andre92/inav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andre92/inav/labels{/name}","releases_url":"https://api.github.com/repos/andre92/inav/releases{/id}","deployments_url":"https://api.github.com/repos/andre92/inav/deployments","created_at":"2016-12-26T14:28:34Z","updated_at":"2016-12-26T14:28:44Z","pushed_at":"2016-12-30T21:53:05Z","git_url":"git://github.com/andre92/inav.git","ssh_url":"git@github.com:andre92/inav.git","clone_url":"https://github.com/andre92/inav.git","svn_url":"https://github.com/andre92/inav","homepage":"https://inavflight.github.io","size":82185,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iNavFlight:development","ref":"development","sha":"bfa1661c46c42857f3d11dd77b3398efe5338f11","user":{"login":"iNavFlight","id":15979895,"avatar_url":"https://avatars.githubusercontent.com/u/15979895?v=3","gravatar_id":"","url":"https://api.github.com/users/iNavFlight","html_url":"https://github.com/iNavFlight","followers_url":"https://api.github.com/users/iNavFlight/followers","following_url":"https://api.github.com/users/iNavFlight/following{/other_user}","gists_url":"https://api.github.com/users/iNavFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/iNavFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNavFlight/subscriptions","organizations_url":"https://api.github.com/users/iNavFlight/orgs","repos_url":"https://api.github.com/users/iNavFlight/repos","events_url":"https://api.github.com/users/iNavFlight/events{/privacy}","received_events_url":"https://api.github.com/users/iNavFlight/received_events","type":"Organization","site_admin":false},"repo":{"id":32148604,"name":"inav","full_name":"iNavFlight/inav","owner":{"login":"iNavFlight","id":15979895,"avatar_url":"https://avatars.githubusercontent.com/u/15979895?v=3","gravatar_id":"","url":"https://api.github.com/users/iNavFlight","html_url":"https://github.com/iNavFlight","followers_url":"https://api.github.com/users/iNavFlight/followers","following_url":"https://api.github.com/users/iNavFlight/following{/other_user}","gists_url":"https://api.github.com/users/iNavFlight/gists{/gist_id}","starred_url":"https://api.github.com/users/iNavFlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNavFlight/subscriptions","organizations_url":"https://api.github.com/users/iNavFlight/orgs","repos_url":"https://api.github.com/users/iNavFlight/repos","events_url":"https://api.github.com/users/iNavFlight/events{/privacy}","received_events_url":"https://api.github.com/users/iNavFlight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iNavFlight/inav","description":"INAV: Navigation-enabled flight control software","fork":true,"url":"https://api.github.com/repos/iNavFlight/inav","forks_url":"https://api.github.com/repos/iNavFlight/inav/forks","keys_url":"https://api.github.com/repos/iNavFlight/inav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNavFlight/inav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNavFlight/inav/teams","hooks_url":"https://api.github.com/repos/iNavFlight/inav/hooks","issue_events_url":"https://api.github.com/repos/iNavFlight/inav/issues/events{/number}","events_url":"https://api.github.com/repos/iNavFlight/inav/events","assignees_url":"https://api.github.com/repos/iNavFlight/inav/assignees{/user}","branches_url":"https://api.github.com/repos/iNavFlight/inav/branches{/branch}","tags_url":"https://api.github.com/repos/iNavFlight/inav/tags","blobs_url":"https://api.github.com/repos/iNavFlight/inav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNavFlight/inav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNavFlight/inav/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNavFlight/inav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNavFlight/inav/statuses/{sha}","languages_url":"https://api.github.com/repos/iNavFlight/inav/languages","stargazers_url":"https://api.github.com/repos/iNavFlight/inav/stargazers","contributors_url":"https://api.github.com/repos/iNavFlight/inav/contributors","subscribers_url":"https://api.github.com/repos/iNavFlight/inav/subscribers","subscription_url":"https://api.github.com/repos/iNavFlight/inav/subscription","commits_url":"https://api.github.com/repos/iNavFlight/inav/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNavFlight/inav/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNavFlight/inav/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNavFlight/inav/issues/comments{/number}","contents_url":"https://api.github.com/repos/iNavFlight/inav/contents/{+path}","compare_url":"https://api.github.com/repos/iNavFlight/inav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNavFlight/inav/merges","archive_url":"https://api.github.com/repos/iNavFlight/inav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNavFlight/inav/downloads","issues_url":"https://api.github.com/repos/iNavFlight/inav/issues{/number}","pulls_url":"https://api.github.com/repos/iNavFlight/inav/pulls{/number}","milestones_url":"https://api.github.com/repos/iNavFlight/inav/milestones{/number}","notifications_url":"https://api.github.com/repos/iNavFlight/inav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNavFlight/inav/labels{/name}","releases_url":"https://api.github.com/repos/iNavFlight/inav/releases{/id}","deployments_url":"https://api.github.com/repos/iNavFlight/inav/deployments","created_at":"2015-03-13T09:58:19Z","updated_at":"2016-12-30T21:39:30Z","pushed_at":"2016-12-30T21:53:06Z","git_url":"git://github.com/iNavFlight/inav.git","ssh_url":"git@github.com:iNavFlight/inav.git","clone_url":"https://github.com/iNavFlight/inav.git","svn_url":"https://github.com/iNavFlight/inav","homepage":"https://inavflight.github.io","size":82105,"stargazers_count":155,"watchers_count":155,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":123,"forks":59,"open_issues":123,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/972"},"html":{"href":"https://github.com/iNavFlight/inav/pull/972"},"issue":{"href":"https://api.github.com/repos/iNavFlight/inav/issues/972"},"comments":{"href":"https://api.github.com/repos/iNavFlight/inav/issues/972/comments"},"review_comments":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/972/comments"},"review_comment":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iNavFlight/inav/pulls/972/commits"},"statuses":{"href":"https://api.github.com/repos/iNavFlight/inav/statuses/34e18a6657970be6308a43d4783407455d89f139"}}}}
{"actor":{"display_login":"martinbudden"}}