{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/80330777","id":80330777,"diff_hunk":"@@ -119,6 +127,27 @@ func (c *Container) NewHandle() *Handle {\n \treturn newHandle(c)\n }\n \n+// Refresh calls the propery collector to get config and runtime info\n+func (c *Container) Refresh() error {\n+\tvar o mo.VirtualMachine\n+\n+\t// make sure we have vm\n+\tif c.vm == nil {\n+\t\treturn fmt.Errorf(\"There is no backing VirtualMachine\")\n+\t}\n+\tctx := context.TODO()\n+\n+\tif err := c.vm.Properties(ctx, c.vm.Reference(), []string{\"config\", \"runtime\"}, &o); err != nil {\n+\t\treturn err\n+\t}\n+\n+\tc.Config = o.Config\n+\tc.Runtime = &o.Runtime\n+","path":"lib/portlayer/exec/container.go","position":50,"original_position":50,"commit_id":"84e68cb0360211437a630a736e9d4974ecd98a67","original_commit_id":"329e1f8cabdfbb1ffbfb2f269574b2aed752ce35","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"I understand that things can change but I'm not sure how this new code is changing what we return in those cases? Whoever was handling those should be still doing it. \r\n\r\nWe are calling this 2 get two things, the runtime.PowerState so that we can modify ExtraConfig and later we will start to get ChangeVersion attribute for making API calls and ensuring nothing changed since we last checked.","created_at":"2016-09-23T21:31:59Z","updated_at":"2016-09-23T21:31:59Z","html_url":"https://github.com/vmware/vic/pull/2454#discussion_r80330777","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2454","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/80330777"},"html":{"href":"https://github.com/vmware/vic/pull/2454#discussion_r80330777"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2454"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2454","id":86548376,"html_url":"https://github.com/vmware/vic/pull/2454","diff_url":"https://github.com/vmware/vic/pull/2454.diff","patch_url":"https://github.com/vmware/vic/pull/2454.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2454","number":2454,"state":"open","locked":false,"title":"[full ci] introduce logging and interaction subsystems","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"for the portlayer. They use file/network backed serial ports right now.\r\n\r\nAlso remove serial related code from the spec package","created_at":"2016-09-23T17:11:09Z","updated_at":"2016-09-23T21:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"febe55245c2a23eb8d17d11f09295d94e8c2c62d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2454/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2454/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2454/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/84e68cb0360211437a630a736e9d4974ecd98a67","head":{"label":"caglar10ur:serial","ref":"serial","sha":"84e68cb0360211437a630a736e9d4974ecd98a67","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"repo":{"id":55449160,"name":"vic","full_name":"caglar10ur/vic","owner":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caglar10ur/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/caglar10ur/vic","forks_url":"https://api.github.com/repos/caglar10ur/vic/forks","keys_url":"https://api.github.com/repos/caglar10ur/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caglar10ur/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caglar10ur/vic/teams","hooks_url":"https://api.github.com/repos/caglar10ur/vic/hooks","issue_events_url":"https://api.github.com/repos/caglar10ur/vic/issues/events{/number}","events_url":"https://api.github.com/repos/caglar10ur/vic/events","assignees_url":"https://api.github.com/repos/caglar10ur/vic/assignees{/user}","branches_url":"https://api.github.com/repos/caglar10ur/vic/branches{/branch}","tags_url":"https://api.github.com/repos/caglar10ur/vic/tags","blobs_url":"https://api.github.com/repos/caglar10ur/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caglar10ur/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caglar10ur/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/caglar10ur/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caglar10ur/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/caglar10ur/vic/languages","stargazers_url":"https://api.github.com/repos/caglar10ur/vic/stargazers","contributors_url":"https://api.github.com/repos/caglar10ur/vic/contributors","subscribers_url":"https://api.github.com/repos/caglar10ur/vic/subscribers","subscription_url":"https://api.github.com/repos/caglar10ur/vic/subscription","commits_url":"https://api.github.com/repos/caglar10ur/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/caglar10ur/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/caglar10ur/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/caglar10ur/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/caglar10ur/vic/contents/{+path}","compare_url":"https://api.github.com/repos/caglar10ur/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caglar10ur/vic/merges","archive_url":"https://api.github.com/repos/caglar10ur/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caglar10ur/vic/downloads","issues_url":"https://api.github.com/repos/caglar10ur/vic/issues{/number}","pulls_url":"https://api.github.com/repos/caglar10ur/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/caglar10ur/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/caglar10ur/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caglar10ur/vic/labels{/name}","releases_url":"https://api.github.com/repos/caglar10ur/vic/releases{/id}","deployments_url":"https://api.github.com/repos/caglar10ur/vic/deployments","created_at":"2016-04-04T22:13:10Z","updated_at":"2016-04-04T22:13:12Z","pushed_at":"2016-09-23T20:36:07Z","git_url":"git://github.com/caglar10ur/vic.git","ssh_url":"git@github.com:caglar10ur/vic.git","clone_url":"https://github.com/caglar10ur/vic.git","svn_url":"https://github.com/caglar10ur/vic","homepage":null,"size":29021,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"56973f26db4943ebe4f39f86d5a9a85ba8cc7e39","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-09-23T21:21:48Z","pushed_at":"2016-09-23T21:06:33Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"","size":80096,"stargazers_count":133,"watchers_count":133,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":481,"forks":50,"open_issues":481,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2454"},"html":{"href":"https://github.com/vmware/vic/pull/2454"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2454"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2454/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2454/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2454/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/84e68cb0360211437a630a736e9d4974ecd98a67"}}}}
{"actor":{"display_login":"caglar10ur"}}