{"action":"opened","issue":{"url":"https://api.github.com/repos/tmk/tmk_keyboard/issues/318","repository_url":"https://api.github.com/repos/tmk/tmk_keyboard","labels_url":"https://api.github.com/repos/tmk/tmk_keyboard/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/tmk/tmk_keyboard/issues/318/comments","events_url":"https://api.github.com/repos/tmk/tmk_keyboard/issues/318/events","html_url":"https://github.com/tmk/tmk_keyboard/issues/318","id":138106146,"number":318,"title":"action_t in actionmap","user":{"login":"tmk","id":424590,"avatar_url":"https://avatars.githubusercontent.com/u/424590?v=3","gravatar_id":"","url":"https://api.github.com/users/tmk","html_url":"https://github.com/tmk","followers_url":"https://api.github.com/users/tmk/followers","following_url":"https://api.github.com/users/tmk/following{/other_user}","gists_url":"https://api.github.com/users/tmk/gists{/gist_id}","starred_url":"https://api.github.com/users/tmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmk/subscriptions","organizations_url":"https://api.github.com/users/tmk/orgs","repos_url":"https://api.github.com/users/tmk/repos","events_url":"https://api.github.com/users/tmk/events{/privacy}","received_events_url":"https://api.github.com/users/tmk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-03T08:00:43Z","updated_at":"2016-03-03T08:00:43Z","closed_at":null,"body":"`action_t` should be used in actionmap instead of `uint16_t`.\r\n\r\nThis change breaks existent fn_actions definitions in keymap file like: `const uint16_t fn_actions[]`. `uint16_t` have to be replaced with action_t. \r\n\r\nAlso keymap should use type name like `keycode_t` instead of 'uint8_t`.\r\n\r\nPENDING: due to breaking existent keymap files of users.\r\n\r\n\r\n```diff\r\ndiff --git a/tmk_core/common/action_code.h b/tmk_core/common/action_code.h\r\nindex b39c644..c8d3a8c 100644\r\n--- a/tmk_core/common/action_code.h\r\n+++ b/tmk_core/common/action_code.h\r\n@@ -183,7 +183,7 @@ typedef union {\r\n /* action utility */\r\n #define ACTION_NO                       0\r\n #define ACTION_TRANSPARENT              1\r\n-#define ACTION(kind, param)             ((kind)<<12 | (param))\r\n+#define ACTION(kind, param)             { .code = ((kind)<<12 | (param)) }\r\n \r\n \r\n /*\r\ndiff --git a/tmk_core/common/actionmap.h b/tmk_core/common/actionmap.h\r\nindex cbbcfe9..ac52997 100644\r\n--- a/tmk_core/common/actionmap.h\r\n+++ b/tmk_core/common/actionmap.h\r\n@@ -25,7 +25,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.\r\n \r\n \r\n /* Keymapping with 16bit action codes */\r\n-extern const uint16_t actionmaps[][MATRIX_ROWS][MATRIX_COLS];\r\n+extern const action_t actionmaps[][MATRIX_ROWS][MATRIX_COLS];\r\n \r\n \r\n /* Modified key */\r\n```"}}