{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/54955038","id":54955038,"diff_hunk":"@@ -58,12 +60,16 @@\n      * \n      * @param memory The maximum amount of memory that this buffer pool can allocate\n      * @param poolableSize The buffer size to cache in the free list rather than deallocating\n+     * @param blockOnExhaustion This controls the behavior when the buffer pool is out of memory. If true the\n+     *        {@link #allocate(int, long)} call will block and wait for memory to be returned to the pool. If false\n+     *        {@link #allocate(int, long)} will throw an exception if the buffer is out of memory.\n      * @param metrics instance of Metrics\n      * @param time time instance\n      * @param metricGrpName logical group name for metrics\n      */\n-    public BufferPool(long memory, int poolableSize, Metrics metrics, Time time, String metricGrpName) {\n+    public BufferPool(long memory, int poolableSize, boolean blockOnExhaustion, Metrics metrics, Time time , String metricGrpName) {","path":"clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java","position":28,"original_position":28,"commit_id":"6e2d64ee8eedc90efff54fdd952c8d5f98a8b0d5","original_commit_id":"6e2d64ee8eedc90efff54fdd952c8d5f98a8b0d5","user":{"login":"redsanket","id":8295799,"avatar_url":"https://avatars.githubusercontent.com/u/8295799?v=3","gravatar_id":"","url":"https://api.github.com/users/redsanket","html_url":"https://github.com/redsanket","followers_url":"https://api.github.com/users/redsanket/followers","following_url":"https://api.github.com/users/redsanket/following{/other_user}","gists_url":"https://api.github.com/users/redsanket/gists{/gist_id}","starred_url":"https://api.github.com/users/redsanket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redsanket/subscriptions","organizations_url":"https://api.github.com/users/redsanket/orgs","repos_url":"https://api.github.com/users/redsanket/repos","events_url":"https://api.github.com/users/redsanket/events{/privacy}","received_events_url":"https://api.github.com/users/redsanket/received_events","type":"User","site_admin":false},"body":"space after time","created_at":"2016-03-03T21:55:23Z","updated_at":"2016-03-03T21:55:23Z","html_url":"https://github.com/apache/kafka/pull/934#discussion_r54955038","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/934","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/54955038"},"html":{"href":"https://github.com/apache/kafka/pull/934#discussion_r54955038"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/934"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/934","id":59870725,"html_url":"https://github.com/apache/kafka/pull/934","diff_url":"https://github.com/apache/kafka/pull/934.diff","patch_url":"https://github.com/apache/kafka/pull/934.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/934","number":934,"state":"open","locked":false,"title":"KAFKA-3236: Honor Producer Configuration \"block.on.buffer.full\"","user":{"login":"knusbaum","id":1819836,"avatar_url":"https://avatars.githubusercontent.com/u/1819836?v=3","gravatar_id":"","url":"https://api.github.com/users/knusbaum","html_url":"https://github.com/knusbaum","followers_url":"https://api.github.com/users/knusbaum/followers","following_url":"https://api.github.com/users/knusbaum/following{/other_user}","gists_url":"https://api.github.com/users/knusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/knusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knusbaum/subscriptions","organizations_url":"https://api.github.com/users/knusbaum/orgs","repos_url":"https://api.github.com/users/knusbaum/repos","events_url":"https://api.github.com/users/knusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/knusbaum/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-18T22:02:10Z","updated_at":"2016-03-03T21:55:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cea38acf9d50ca6ea2d4b7cf3cb2cef5c6af52b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/934/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/934/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/934/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/6e2d64ee8eedc90efff54fdd952c8d5f98a8b0d5","head":{"label":"knusbaum:KAFKA-3236-master","ref":"KAFKA-3236-master","sha":"6e2d64ee8eedc90efff54fdd952c8d5f98a8b0d5","user":{"login":"knusbaum","id":1819836,"avatar_url":"https://avatars.githubusercontent.com/u/1819836?v=3","gravatar_id":"","url":"https://api.github.com/users/knusbaum","html_url":"https://github.com/knusbaum","followers_url":"https://api.github.com/users/knusbaum/followers","following_url":"https://api.github.com/users/knusbaum/following{/other_user}","gists_url":"https://api.github.com/users/knusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/knusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knusbaum/subscriptions","organizations_url":"https://api.github.com/users/knusbaum/orgs","repos_url":"https://api.github.com/users/knusbaum/repos","events_url":"https://api.github.com/users/knusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/knusbaum/received_events","type":"User","site_admin":false},"repo":{"id":51937747,"name":"kafka","full_name":"knusbaum/kafka","owner":{"login":"knusbaum","id":1819836,"avatar_url":"https://avatars.githubusercontent.com/u/1819836?v=3","gravatar_id":"","url":"https://api.github.com/users/knusbaum","html_url":"https://github.com/knusbaum","followers_url":"https://api.github.com/users/knusbaum/followers","following_url":"https://api.github.com/users/knusbaum/following{/other_user}","gists_url":"https://api.github.com/users/knusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/knusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knusbaum/subscriptions","organizations_url":"https://api.github.com/users/knusbaum/orgs","repos_url":"https://api.github.com/users/knusbaum/repos","events_url":"https://api.github.com/users/knusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/knusbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knusbaum/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/knusbaum/kafka","forks_url":"https://api.github.com/repos/knusbaum/kafka/forks","keys_url":"https://api.github.com/repos/knusbaum/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knusbaum/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knusbaum/kafka/teams","hooks_url":"https://api.github.com/repos/knusbaum/kafka/hooks","issue_events_url":"https://api.github.com/repos/knusbaum/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/knusbaum/kafka/events","assignees_url":"https://api.github.com/repos/knusbaum/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/knusbaum/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/knusbaum/kafka/tags","blobs_url":"https://api.github.com/repos/knusbaum/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knusbaum/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knusbaum/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/knusbaum/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knusbaum/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/knusbaum/kafka/languages","stargazers_url":"https://api.github.com/repos/knusbaum/kafka/stargazers","contributors_url":"https://api.github.com/repos/knusbaum/kafka/contributors","subscribers_url":"https://api.github.com/repos/knusbaum/kafka/subscribers","subscription_url":"https://api.github.com/repos/knusbaum/kafka/subscription","commits_url":"https://api.github.com/repos/knusbaum/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/knusbaum/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/knusbaum/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/knusbaum/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/knusbaum/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/knusbaum/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knusbaum/kafka/merges","archive_url":"https://api.github.com/repos/knusbaum/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knusbaum/kafka/downloads","issues_url":"https://api.github.com/repos/knusbaum/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/knusbaum/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/knusbaum/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/knusbaum/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knusbaum/kafka/labels{/name}","releases_url":"https://api.github.com/repos/knusbaum/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/knusbaum/kafka/deployments","created_at":"2016-02-17T16:36:30Z","updated_at":"2016-02-17T16:36:34Z","pushed_at":"2016-02-24T21:31:22Z","git_url":"git://github.com/knusbaum/kafka.git","ssh_url":"git@github.com:knusbaum/kafka.git","clone_url":"https://github.com/knusbaum/kafka.git","svn_url":"https://github.com/knusbaum/kafka","homepage":null,"size":26789,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"45c8195fa14c766b200c720f316836dbb84e9d8b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-03-03T15:26:07Z","pushed_at":"2016-03-03T21:45:27Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":35438,"stargazers_count":2704,"watchers_count":2704,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1632,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":139,"forks":1632,"open_issues":139,"watchers":2704,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/934"},"html":{"href":"https://github.com/apache/kafka/pull/934"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/934"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/6e2d64ee8eedc90efff54fdd952c8d5f98a8b0d5"}}}}