{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/69024858","id":69024858,"diff_hunk":"@@ -0,0 +1,26 @@\n+# Copyright 2016 The Kubernetes Authors All rights reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+TAG = v20160627","path":"queue-health/base/Makefile","position":null,"original_position":15,"commit_id":"3fc3942e06f9b73654468195bfea56cf67027a58","original_commit_id":"a51748b70cb9b660f6179b8bf35d2bd12f6faa6e","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-06-29T20:50:12Z","updated_at":"2016-06-29T20:50:12Z","html_url":"https://github.com/kubernetes/test-infra/pull/231#discussion_r69024858","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/69024858"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/231#discussion_r69024858"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/231","id":75413612,"html_url":"https://github.com/kubernetes/test-infra/pull/231","diff_url":"https://github.com/kubernetes/test-infra/pull/231.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/231.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/231","number":231,"state":"open","locked":false,"title":"Migrate queue-health to GKE","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"Created three deployments matching how I develop the tool:\r\n\r\n* queue-health.yaml - deploys the latest version with development args\r\n* queue-health-prod.yaml - deploys the production version with production args\r\n* queue-health-graph-dev.yaml - deploys only the grapher with dev output and production input\r\n\r\nIn order to minimize docker cache points I'm setting all environment variables and running all commands inside a single layer following suggested [best practices](https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#minimize-the-number-of-layers).\r\n\r\nI'm using a base image that installs python, python requests and gcloud so that both images can share this.","created_at":"2016-06-28T03:33:50Z","updated_at":"2016-06-29T20:50:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7373cf0509ab0776fa770174669b7720666dbb1","assignee":{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmmh","id":211868,"avatar_url":"https://avatars.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/231/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/231/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/231/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/3fc3942e06f9b73654468195bfea56cf67027a58","head":{"label":"fejta:meta","ref":"meta","sha":"3fc3942e06f9b73654468195bfea56cf67027a58","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"repo":{"id":59241934,"name":"test-infra","full_name":"fejta/test-infra","owner":{"login":"fejta","id":940341,"avatar_url":"https://avatars.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fejta/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/fejta/test-infra","forks_url":"https://api.github.com/repos/fejta/test-infra/forks","keys_url":"https://api.github.com/repos/fejta/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fejta/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fejta/test-infra/teams","hooks_url":"https://api.github.com/repos/fejta/test-infra/hooks","issue_events_url":"https://api.github.com/repos/fejta/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/fejta/test-infra/events","assignees_url":"https://api.github.com/repos/fejta/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/fejta/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/fejta/test-infra/tags","blobs_url":"https://api.github.com/repos/fejta/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fejta/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fejta/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/fejta/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fejta/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/fejta/test-infra/languages","stargazers_url":"https://api.github.com/repos/fejta/test-infra/stargazers","contributors_url":"https://api.github.com/repos/fejta/test-infra/contributors","subscribers_url":"https://api.github.com/repos/fejta/test-infra/subscribers","subscription_url":"https://api.github.com/repos/fejta/test-infra/subscription","commits_url":"https://api.github.com/repos/fejta/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/fejta/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/fejta/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/fejta/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/fejta/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/fejta/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fejta/test-infra/merges","archive_url":"https://api.github.com/repos/fejta/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fejta/test-infra/downloads","issues_url":"https://api.github.com/repos/fejta/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/fejta/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/fejta/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/fejta/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fejta/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/fejta/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/fejta/test-infra/deployments","created_at":"2016-05-19T20:53:03Z","updated_at":"2016-05-19T20:53:04Z","pushed_at":"2016-06-29T20:48:34Z","git_url":"git://github.com/fejta/test-infra.git","ssh_url":"git@github.com:fejta/test-infra.git","clone_url":"https://github.com/fejta/test-infra.git","svn_url":"https://github.com/fejta/test-infra","homepage":null,"size":770,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ae6b155d380b2abda8701e00754bd0fbd5e58546","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2016-06-24T15:45:12Z","pushed_at":"2016-06-29T20:48:34Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":853,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":29,"forks":35,"open_issues":29,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/231"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/231"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/231"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/3fc3942e06f9b73654468195bfea56cf67027a58"}}}}
{"actor":{"display_login":"fejta"}}