{"action":"created","comment":{"url":"https://api.github.com/repos/google/cadvisor/pulls/comments/63244409","id":63244409,"diff_hunk":"@@ -80,7 +124,7 @@ func getRootFs(root string, parsed *parsedName) string {\n \n \tbytes, err := ioutil.ReadFile(tree)\n \tif err != nil {\n-\t\tglog.Infof(\"ReadFile failed, couldn't read %v to get upper dir: %v\", tree, err)\n+\t\tglog.Errorf(\"ReadFile failed, couldn't read %v to get upper dir: %v\", tree, err)","path":"container/rkt/helpers.go","position":112,"original_position":112,"commit_id":"29e0782cedec140df582c9422f4414e4cb3d611d","original_commit_id":"29e0782cedec140df582c9422f4414e4cb3d611d","user":{"login":"yifan-gu","id":3278588,"avatar_url":"https://avatars.githubusercontent.com/u/3278588?v=3","gravatar_id":"","url":"https://api.github.com/users/yifan-gu","html_url":"https://github.com/yifan-gu","followers_url":"https://api.github.com/users/yifan-gu/followers","following_url":"https://api.github.com/users/yifan-gu/following{/other_user}","gists_url":"https://api.github.com/users/yifan-gu/gists{/gist_id}","starred_url":"https://api.github.com/users/yifan-gu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yifan-gu/subscriptions","organizations_url":"https://api.github.com/users/yifan-gu/orgs","repos_url":"https://api.github.com/users/yifan-gu/repos","events_url":"https://api.github.com/users/yifan-gu/events{/privacy}","received_events_url":"https://api.github.com/users/yifan-gu/received_events","type":"User","site_admin":false},"body":"Question on Line 122: Do we care about non-running pods?","created_at":"2016-05-13T20:14:08Z","updated_at":"2016-05-13T20:14:08Z","html_url":"https://github.com/google/cadvisor/pull/1284#discussion_r63244409","pull_request_url":"https://api.github.com/repos/google/cadvisor/pulls/1284","_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/63244409"},"html":{"href":"https://github.com/google/cadvisor/pull/1284#discussion_r63244409"},"pull_request":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1284"}}},"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/1284","id":69919035,"html_url":"https://github.com/google/cadvisor/pull/1284","diff_url":"https://github.com/google/cadvisor/pull/1284.diff","patch_url":"https://github.com/google/cadvisor/pull/1284.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/1284","number":1284,"state":"open","locked":false,"title":"Polling rkt implementation of new watcher inteface","user":{"login":"sjpotter","id":1659735,"avatar_url":"https://avatars.githubusercontent.com/u/1659735?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpotter","html_url":"https://github.com/sjpotter","followers_url":"https://api.github.com/users/sjpotter/followers","following_url":"https://api.github.com/users/sjpotter/following{/other_user}","gists_url":"https://api.github.com/users/sjpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpotter/subscriptions","organizations_url":"https://api.github.com/users/sjpotter/orgs","repos_url":"https://api.github.com/users/sjpotter/repos","events_url":"https://api.github.com/users/sjpotter/events{/privacy}","received_events_url":"https://api.github.com/users/sjpotter/received_events","type":"User","site_admin":false},"body":"So this patch does a lot of things\r\n\r\n1) it implements a rkt watcher that polls the rkt api service (we dont have the ability to be event driven at the moment) - use a timer of 30s\r\n\r\n2) Updates rkt godep, however, rkt is cutting a new release tomorrow so this isn't a tag versioned, will be updated once its tagged, and will update the minimum rkt version it depends on\r\n\r\n3) implements the ability to override handlers\r\n\r\ncurrently if a container name is already known, we ignore it in the createContainer path, this gives us the ability to say if a container is a \"Raw\" handler, we can override it if we so choose\r\n\r\nto do this, \r\n\r\n- added a String() to each handler (perhaps use an enum type type instead?)\r\n- added a ContainerOverride event to watchers\r\n- added a overrideContainer() method to manager watcher event handler\r\n- enabled the rkt container handler to handle both raw and rkt events\r\n\r\n4) redid rkt handler to use api \r\n- verifies cgroups are from the api\r\n- uses annotations to set up labels (and return them correctly as part of Spec so k8s sees them)","created_at":"2016-05-12T22:46:13Z","updated_at":"2016-05-13T20:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b00b34d1ca71d2d647c9591eaf253aeff3225e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/1284/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/1284/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/1284/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/29e0782cedec140df582c9422f4414e4cb3d611d","head":{"label":"sjpotter:new-handler-detection-with-rkt","ref":"new-handler-detection-with-rkt","sha":"29e0782cedec140df582c9422f4414e4cb3d611d","user":{"login":"sjpotter","id":1659735,"avatar_url":"https://avatars.githubusercontent.com/u/1659735?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpotter","html_url":"https://github.com/sjpotter","followers_url":"https://api.github.com/users/sjpotter/followers","following_url":"https://api.github.com/users/sjpotter/following{/other_user}","gists_url":"https://api.github.com/users/sjpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpotter/subscriptions","organizations_url":"https://api.github.com/users/sjpotter/orgs","repos_url":"https://api.github.com/users/sjpotter/repos","events_url":"https://api.github.com/users/sjpotter/events{/privacy}","received_events_url":"https://api.github.com/users/sjpotter/received_events","type":"User","site_admin":false},"repo":{"id":49527299,"name":"cadvisor","full_name":"sjpotter/cadvisor","owner":{"login":"sjpotter","id":1659735,"avatar_url":"https://avatars.githubusercontent.com/u/1659735?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpotter","html_url":"https://github.com/sjpotter","followers_url":"https://api.github.com/users/sjpotter/followers","following_url":"https://api.github.com/users/sjpotter/following{/other_user}","gists_url":"https://api.github.com/users/sjpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpotter/subscriptions","organizations_url":"https://api.github.com/users/sjpotter/orgs","repos_url":"https://api.github.com/users/sjpotter/repos","events_url":"https://api.github.com/users/sjpotter/events{/privacy}","received_events_url":"https://api.github.com/users/sjpotter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjpotter/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/sjpotter/cadvisor","forks_url":"https://api.github.com/repos/sjpotter/cadvisor/forks","keys_url":"https://api.github.com/repos/sjpotter/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjpotter/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjpotter/cadvisor/teams","hooks_url":"https://api.github.com/repos/sjpotter/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/sjpotter/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/sjpotter/cadvisor/events","assignees_url":"https://api.github.com/repos/sjpotter/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/sjpotter/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/sjpotter/cadvisor/tags","blobs_url":"https://api.github.com/repos/sjpotter/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjpotter/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjpotter/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjpotter/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjpotter/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/sjpotter/cadvisor/languages","stargazers_url":"https://api.github.com/repos/sjpotter/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/sjpotter/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/sjpotter/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/sjpotter/cadvisor/subscription","commits_url":"https://api.github.com/repos/sjpotter/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjpotter/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjpotter/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjpotter/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjpotter/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/sjpotter/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjpotter/cadvisor/merges","archive_url":"https://api.github.com/repos/sjpotter/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjpotter/cadvisor/downloads","issues_url":"https://api.github.com/repos/sjpotter/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/sjpotter/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/sjpotter/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/sjpotter/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjpotter/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/sjpotter/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/sjpotter/cadvisor/deployments","created_at":"2016-01-12T20:35:02Z","updated_at":"2016-01-12T20:35:03Z","pushed_at":"2016-05-13T18:05:58Z","git_url":"git://github.com/sjpotter/cadvisor.git","ssh_url":"git@github.com:sjpotter/cadvisor.git","clone_url":"https://github.com/sjpotter/cadvisor.git","svn_url":"https://github.com/sjpotter/cadvisor","homepage":"","size":22152,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"fc4fcc5ac6ff5fbb4cf2a8438d514d2ddc03b651","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","deployments_url":"https://api.github.com/repos/google/cadvisor/deployments","created_at":"2014-06-09T16:36:33Z","updated_at":"2016-05-13T19:28:25Z","pushed_at":"2016-05-13T18:05:58Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":27148,"stargazers_count":3909,"watchers_count":3909,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":540,"mirror_url":null,"open_issues_count":173,"forks":540,"open_issues":173,"watchers":3909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1284"},"html":{"href":"https://github.com/google/cadvisor/pull/1284"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/1284"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/1284/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1284/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/1284/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/29e0782cedec140df582c9422f4414e4cb3d611d"}}}}