{"push_id":1338216880,"size":43,"distinct_size":1,"ref":"refs/heads/carousel_analytics","head":"29eb15562e7b84baac36067416839236c773484c","before":"b189a834a4465f9941a6a7eeead80faf3d605f22","commits":[{"sha":"8ff39290cf658eedd6a7411761403cfc25c63e95","author":{"name":"Avi Mehta","email":"b43a97773b68b61460ee0e2d6ff06c41cebc8c5c@users.noreply.github.com"},"message":"Fix indentation for scroll trigger. (#5355)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/8ff39290cf658eedd6a7411761403cfc25c63e95"},{"sha":"4407357c2592003b4ced2adfc1caf1d9c2d0aa8f","author":{"name":"Yuxi Chen","email":"d3ed8b00aef3d6036bc627e742c6eacd4a4ddb83@users.noreply.github.com"},"message":"Fix scroll position adjustment for viewer header (#5256)\n\n* change function updatePaddingTop to hideViewerHeader/showViewerHeader respectively\r\n* in ios-embed mode, no need to adjust scroll position, we set the borderTop and paddingTop instead\r\n* in android mode, no need to adjust scroll position, nothing need to be done\r\n* rearrange the order of code execution\r\n  * hideHeader: update padding/border first, then do animation\r\n  * showHeader: do animation first, then update padding/border\r\n* the scroll message sent to viewer is continuous after hide/show header event\r\n* viewport.getLayoutRect(el) remains the same after hide/show header event","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/4407357c2592003b4ced2adfc1caf1d9c2d0aa8f"},{"sha":"f39be2245d210d5b378d2ab46dcd7b041fe8179e","author":{"name":"Sriram Krishnan","email":"1b0ac1e2ab358926240d7025e9b04398107f05d4@users.noreply.github.com"},"message":"Push amp-scrollable-carousel to 100% (#5363)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/f39be2245d210d5b378d2ab46dcd7b041fe8179e"},{"sha":"1e6e3031e1e00380d67550b63e7694a2bcbd42a9","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"Prepare `BaseCustomElementProto` for Custom Elements V1 (#5348)\n\n* move class additions to on-attached\r\n\r\n* only add classes on first attach\r\n\r\n* add unit test for adding classes on first attach\r\n\r\n* remove unused var\r\n\r\n* remove unused var\r\n\r\n* remove unused var","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/1e6e3031e1e00380d67550b63e7694a2bcbd42a9"},{"sha":"ad80d753970a88368fff422390897eb5b839b7fb","author":{"name":"Sriram Krishnan","email":"1b0ac1e2ab358926240d7025e9b04398107f05d4@users.noreply.github.com"},"message":"enable type checks for <amp-accrodion> (#5389)\n\n* enable type checks for <amp-accrodion>\r\n\r\n* Review fixes","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/ad80d753970a88368fff422390897eb5b839b7fb"},{"sha":"ccca0a93dbd22922d05d26e82eb5d047e6ece0d9","author":{"name":"keithwrightbos","email":"0c07feb58e4e917b6458454156797618de9e6387@users.noreply.github.com"},"message":"Add d_imp=1 to A4A Doubleclick Request (#5375)\n\n* Update amp-ad-network-doubleclick-impl.md\r\n\r\n* Reverting doc changes\r\n\r\nThe previous change was made in error (wrong branch).\r\n\r\n* Enabled delayed impressions for doubleclick requests","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/ccca0a93dbd22922d05d26e82eb5d047e6ece0d9"},{"sha":"a0fd8a90b8c125562cb2108da0b5911a5fd5a654","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@gmail.com"},"message":"PWA: Migrate amp-dynamic-css-classes to ampdoc scope (#5358)\n\n* Migrate amp-dynamic-css-classes to ampdoc scope\r\n\r\n* linter","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/a0fd8a90b8c125562cb2108da0b5911a5fd5a654"},{"sha":"480aa99a54f151c496459b00aa718e770b1d33f5","author":{"name":"Hirokazu YOSHIDA","email":"3a42c685a142d1d0e81ad833984bdfa4272f5956@gmail.com"},"message":"Add link for LOKA amp-ad (#5393)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/480aa99a54f151c496459b00aa718e770b1d33f5"},{"sha":"91df5562164c041def8ac267db7f7cb3edec91b5","author":{"name":"erwin mombay","email":"23b600e005da61d56b5a893bb5feebde51e1fe09@users.noreply.github.com"},"message":"add assert that src or srcset should exist on resize (#5354)\n\n* add assert that src or srcset should exist on resize\r\n\r\n* retrieve Srcset instance in buildCallback","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/91df5562164c041def8ac267db7f7cb3edec91b5"},{"sha":"49a0a483195cb9f2f20648ca1b61b28ed5c352f8","author":{"name":"keithwrightbos","email":"0c07feb58e4e917b6458454156797618de9e6387@users.noreply.github.com"},"message":"Modified A4A from shadow DOM to installFriendlyIframeEmbed (#5196)\n\n* Update amp-ad-network-doubleclick-impl.md\r\n\r\n* Reverting doc changes\r\n\r\nThe previous change was made in error (wrong branch).\r\n\r\n* Initial integration with installFriendlyIframeEmbed\r\n\r\n* Review comments\r\n\r\n* Update amp-ad-network-doubleclick-impl.md\r\n\r\n* Reverting doc changes\r\n\r\nThe previous change was made in error (wrong branch).\r\n\r\n* Initial integration with installFriendlyIframeEmbed\r\n\r\n* Review comments\r\n\r\n* Change to stitching creative instead of removing portions\r\n\r\n* Update unit tests\r\n\r\n* Fix after merge with upstream/master; correct type failures within friendly-iframe-embed\r\n\r\n* Fix lint errors\r\n\r\n* remove console log","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/49a0a483195cb9f2f20648ca1b61b28ed5c352f8"},{"sha":"b4766b6d16e33048d16d94160508885a995c6359","author":{"name":"Sriram Krishnan","email":"1b0ac1e2ab358926240d7025e9b04398107f05d4@users.noreply.github.com"},"message":"Enable type checks for <amp-sidebar> (#5408)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/b4766b6d16e33048d16d94160508885a995c6359"},{"sha":"1d656fb62727b6c899a3eab576c1990d64ac71b7","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"Lighter way of detecting auto-play (#5412)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/1d656fb62727b6c899a3eab576c1990d64ac71b7"},{"sha":"afbf06306cea15aa8e5e12806ab22364b00c87c4","author":{"name":"Mohammad Khatib","email":"e3f649806135ab9932f4aacc1a779e7c0e73440c@gmail.com"},"message":"Fix internal/local navigation links scrolling (#5381)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/afbf06306cea15aa8e5e12806ab22364b00c87c4"},{"sha":"31b5a9c9e7403f2147633c72e11f5f1ee6f3f99b","author":{"name":"Mohammad Khatib","email":"e3f649806135ab9932f4aacc1a779e7c0e73440c@gmail.com"},"message":"Experiment-protect form custom-validations. (#5424)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/31b5a9c9e7403f2147633c72e11f5f1ee6f3f99b"},{"sha":"c609e02c79b18c2d568cfb66383c35bd44c334a1","author":{"name":"Avi Mehta","email":"b43a97773b68b61460ee0e2d6ff06c41cebc8c5c@users.noreply.github.com"},"message":"Support for expansion of variables with params in parts of amp-analytics. (#4855)\n\n* Support for expansion of variables with params in parts of amp-analytics config.\r\n\r\nSpecifically, the `vars` and extraUrlParams` section encoded the\r\nvariables with params before they could be expanded.\r\n\r\nFixes #4825","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/c609e02c79b18c2d568cfb66383c35bd44c334a1"},{"sha":"d0e7658333099e597b3d51542da99d584fccabca","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@gmail.com"},"message":"PWA: visibility, init parameters and dispose (#5403)\n\n* PWA: visibility, init parameters and dispose\r\n\r\n* tests\r\n\r\n* lints\r\n\r\n* test fixes\r\n\r\n* review fixes\r\n\r\n* review fixes","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/d0e7658333099e597b3d51542da99d584fccabca"},{"sha":"5d3585e308b770c45aa63320e8e3bdbe958008b8","author":{"name":"Malte Ubl","email":"1f3c93f45a3f4c99e591c749f18b1443c4c6575b@users.noreply.github.com"},"message":"A few small optimizations (#5398)\n\n\r\n- lazily init action map per element (most elements will never need it)\r\n- clean up promise resolve for element loading state\r\n- clean up elements from list of stubbed elements","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/5d3585e308b770c45aa63320e8e3bdbe958008b8"},{"sha":"ce59850f8ad2a30da883e1c92854b37ffaf129e3","author":{"name":"Hongfei Ding","email":"385e24b2043fd63635b63363f2bdc9ed5a2701b7@users.noreply.github.com"},"message":"Refactor 3p ad unit test to remove dependency on amp-ad.js. (#5417)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/ce59850f8ad2a30da883e1c92854b37ffaf129e3"},{"sha":"3182cb8167767b005c48a6d3209ab0594389687e","author":{"name":"dknecht","email":"a714ce39e965a04e4803a871ccb4de7380dc266c@columbia.edu"},"message":"Add additional amp-sidebar validator tests (#4653)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/3182cb8167767b005c48a6d3209ab0594389687e"},{"sha":"4f2ed4d678035f98c9ae69c6e5a197d1ba083565","author":{"name":"Sriram Krishnan","email":"1c21f7e6fd22417b283941c1a354a032407382c3@users.noreply.github.com"},"message":"amp-carousel - slides - Fix desktop jitter (happening on certain graphics cards). (#5435)","distinct":false,"url":"https://api.github.com/repos/camelburrito/amphtml/commits/4f2ed4d678035f98c9ae69c6e5a197d1ba083565"}]}
{"actor":{"display_login":"camelburrito"}}