{"action":"closed","number":1260,"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1260","id":67620846,"html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1260","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1260.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/1260.patch","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1260","number":1260,"state":"closed","locked":false,"title":"Added length checking to prevent stack overflow","user":{"login":"pjsg","id":1508813,"avatar_url":"https://avatars.githubusercontent.com/u/1508813?v=3","gravatar_id":"","url":"https://api.github.com/users/pjsg","html_url":"https://github.com/pjsg","followers_url":"https://api.github.com/users/pjsg/followers","following_url":"https://api.github.com/users/pjsg/following{/other_user}","gists_url":"https://api.github.com/users/pjsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsg/subscriptions","organizations_url":"https://api.github.com/users/pjsg/orgs","repos_url":"https://api.github.com/users/pjsg/repos","events_url":"https://api.github.com/users/pjsg/events{/privacy}","received_events_url":"https://api.github.com/users/pjsg/received_events","type":"User","site_admin":false},"body":"As recommended in the bug report #1254 , added length checking. Also I increased the size of the buffer to make it less likely to error out under normal circumstances.\r\n\r\nVerified that the limit works.\r\n\r\nHowever, something else terrible happens (sometimes) and I get a crash after a few seconds. I doubt that this is related..... I just opened #1261 which is a separate problem and much more difficult to exploit (if it is exploitable).","created_at":"2016-04-23T22:34:44Z","updated_at":"2016-04-24T14:45:48Z","closed_at":"2016-04-24T14:45:47Z","merged_at":"2016-04-24T14:45:47Z","merge_commit_sha":"0472587c4c5f222fc9a315ab523fb2c57be80873","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1260/commits","review_comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1260/comments","review_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1260/comments","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/157ee33b1dc4371f7669067c57740fda5710536e","head":{"label":"pjsg:coap-sec","ref":"coap-sec","sha":"157ee33b1dc4371f7669067c57740fda5710536e","user":{"login":"pjsg","id":1508813,"avatar_url":"https://avatars.githubusercontent.com/u/1508813?v=3","gravatar_id":"","url":"https://api.github.com/users/pjsg","html_url":"https://github.com/pjsg","followers_url":"https://api.github.com/users/pjsg/followers","following_url":"https://api.github.com/users/pjsg/following{/other_user}","gists_url":"https://api.github.com/users/pjsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsg/subscriptions","organizations_url":"https://api.github.com/users/pjsg/orgs","repos_url":"https://api.github.com/users/pjsg/repos","events_url":"https://api.github.com/users/pjsg/events{/privacy}","received_events_url":"https://api.github.com/users/pjsg/received_events","type":"User","site_admin":false},"repo":{"id":47082038,"name":"nodemcu-firmware","full_name":"pjsg/nodemcu-firmware","owner":{"login":"pjsg","id":1508813,"avatar_url":"https://avatars.githubusercontent.com/u/1508813?v=3","gravatar_id":"","url":"https://api.github.com/users/pjsg","html_url":"https://github.com/pjsg","followers_url":"https://api.github.com/users/pjsg/followers","following_url":"https://api.github.com/users/pjsg/following{/other_user}","gists_url":"https://api.github.com/users/pjsg/gists{/gist_id}","starred_url":"https://api.github.com/users/pjsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjsg/subscriptions","organizations_url":"https://api.github.com/users/pjsg/orgs","repos_url":"https://api.github.com/users/pjsg/repos","events_url":"https://api.github.com/users/pjsg/events{/privacy}","received_events_url":"https://api.github.com/users/pjsg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjsg/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":true,"url":"https://api.github.com/repos/pjsg/nodemcu-firmware","forks_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/pjsg/nodemcu-firmware/deployments","created_at":"2015-11-29T21:58:51Z","updated_at":"2016-02-20T10:40:37Z","pushed_at":"2016-04-24T14:36:27Z","git_url":"git://github.com/pjsg/nodemcu-firmware.git","ssh_url":"git@github.com:pjsg/nodemcu-firmware.git","clone_url":"https://github.com/pjsg/nodemcu-firmware.git","svn_url":"https://github.com/pjsg/nodemcu-firmware","homepage":"http://nodemcu.com","size":87958,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nodemcu:dev","ref":"dev","sha":"25b4285c4ddaf02ea605508f48fcac74a2741ece","user":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars.githubusercontent.com/u/9865736?v=3","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"repo":{"id":26917568,"name":"nodemcu-firmware","full_name":"nodemcu/nodemcu-firmware","owner":{"login":"nodemcu","id":9865736,"avatar_url":"https://avatars.githubusercontent.com/u/9865736?v=3","gravatar_id":"","url":"https://api.github.com/users/nodemcu","html_url":"https://github.com/nodemcu","followers_url":"https://api.github.com/users/nodemcu/followers","following_url":"https://api.github.com/users/nodemcu/following{/other_user}","gists_url":"https://api.github.com/users/nodemcu/gists{/gist_id}","starred_url":"https://api.github.com/users/nodemcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodemcu/subscriptions","organizations_url":"https://api.github.com/users/nodemcu/orgs","repos_url":"https://api.github.com/users/nodemcu/repos","events_url":"https://api.github.com/users/nodemcu/events{/privacy}","received_events_url":"https://api.github.com/users/nodemcu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nodemcu/nodemcu-firmware","description":"lua based interactive firmware for mcu like esp8266","fork":false,"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","forks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/forks","keys_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/teams","hooks_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/hooks","issue_events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/events","assignees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/tags","blobs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/languages","stargazers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/stargazers","contributors_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contributors","subscribers_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscribers","subscription_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/subscription","commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/merges","archive_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/downloads","issues_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/labels{/name}","releases_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/deployments","created_at":"2014-11-20T15:06:45Z","updated_at":"2016-04-24T11:16:32Z","pushed_at":"2016-04-24T14:45:48Z","git_url":"git://github.com/nodemcu/nodemcu-firmware.git","ssh_url":"git@github.com:nodemcu/nodemcu-firmware.git","clone_url":"https://github.com/nodemcu/nodemcu-firmware.git","svn_url":"https://github.com/nodemcu/nodemcu-firmware","homepage":"http://nodemcu.com","size":104451,"stargazers_count":2116,"watchers_count":2116,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":976,"mirror_url":null,"open_issues_count":116,"forks":976,"open_issues":116,"watchers":2116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1260"},"html":{"href":"https://github.com/nodemcu/nodemcu-firmware/pull/1260"},"issue":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1260"},"comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/1260/comments"},"review_comments":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1260/comments"},"review_comment":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/1260/commits"},"statuses":{"href":"https://api.github.com/repos/nodemcu/nodemcu-firmware/statuses/157ee33b1dc4371f7669067c57740fda5710536e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"marcelstoer","id":624195,"avatar_url":"https://avatars.githubusercontent.com/u/624195?v=3","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":1,"additions":4,"deletions":1,"changed_files":1}}