{"action":"created","comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/comments/87307759","pull_request_review_id":7925654,"id":87307759,"diff_hunk":"@@ -50,7 +50,7 @@ metadata:\n spec:\n   selector:\n     app: hello\n-  type: LoadBalancer\n+  type: ClusterIP","path":"k8s-daemonset/k8s/hello-world.yml","position":5,"original_position":5,"commit_id":"b6bef71a7b8beb9fc8774a6f7cfb55441aca1010","original_commit_id":"9d11b505ea74fbec027be9b9ea74b998f2df2701","user":{"login":"rmars","id":549258,"avatar_url":"https://avatars.githubusercontent.com/u/549258?v=3","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"Alex pointed out that we shouldn't be exposing the hello service regardless (in the other example I think we only access it via linkerd) - he suggested removing it","created_at":"2016-11-10T00:26:39Z","updated_at":"2016-11-10T00:26:39Z","html_url":"https://github.com/BuoyantIO/linkerd-examples/pull/56#discussion_r87307759","pull_request_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/comments/87307759"},"html":{"href":"https://github.com/BuoyantIO/linkerd-examples/pull/56#discussion_r87307759"},"pull_request":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56","id":92894002,"html_url":"https://github.com/BuoyantIO/linkerd-examples/pull/56","diff_url":"https://github.com/BuoyantIO/linkerd-examples/pull/56.diff","patch_url":"https://github.com/BuoyantIO/linkerd-examples/pull/56.patch","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/56","number":56,"state":"open","locked":false,"title":"Add k8s ingress configs with and without nginx","user":{"login":"rmars","id":549258,"avatar_url":"https://avatars.githubusercontent.com/u/549258?v=3","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"* add a third service (api) that calls hello\r\n* refactor l5d_headers() into its own file\r\n* stop exposing the hello service in our other configs\r\n\r\nTodos:\r\n* stop hardcoding linkerd's IP in nginx.conf\r\n* use \"real\" images insead of helloworld:test7 and helloworld:nginx3","created_at":"2016-11-09T01:51:07Z","updated_at":"2016-11-10T00:26:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae3712a7471680aa5a7ff7cc45b7bad2abbefc2b","assignee":{"login":"rmars","id":549258,"avatar_url":"https://avatars.githubusercontent.com/u/549258?v=3","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmars","id":549258,"avatar_url":"https://avatars.githubusercontent.com/u/549258?v=3","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56/commits","review_comments_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56/comments","review_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/56/comments","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/statuses/b6bef71a7b8beb9fc8774a6f7cfb55441aca1010","head":{"label":"BuoyantIO:rmars/ingress-blog","ref":"rmars/ingress-blog","sha":"b6bef71a7b8beb9fc8774a6f7cfb55441aca1010","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":54868666,"name":"linkerd-examples","full_name":"BuoyantIO/linkerd-examples","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd-examples","description":"Examples of how to configure and run linkerd","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd-examples","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/deployments","created_at":"2016-03-28T05:44:25Z","updated_at":"2016-11-02T08:03:42Z","pushed_at":"2016-11-09T23:35:39Z","git_url":"git://github.com/BuoyantIO/linkerd-examples.git","ssh_url":"git@github.com:BuoyantIO/linkerd-examples.git","clone_url":"https://github.com/BuoyantIO/linkerd-examples.git","svn_url":"https://github.com/BuoyantIO/linkerd-examples","homepage":"https://linkerd.io","size":217,"stargazers_count":62,"watchers_count":62,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":62,"default_branch":"master"}},"base":{"label":"BuoyantIO:master","ref":"master","sha":"d883d253dcdb4307722351cb532eceeffd1d6913","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":54868666,"name":"linkerd-examples","full_name":"BuoyantIO/linkerd-examples","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd-examples","description":"Examples of how to configure and run linkerd","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd-examples","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd-examples/deployments","created_at":"2016-03-28T05:44:25Z","updated_at":"2016-11-02T08:03:42Z","pushed_at":"2016-11-09T23:35:39Z","git_url":"git://github.com/BuoyantIO/linkerd-examples.git","ssh_url":"git@github.com:BuoyantIO/linkerd-examples.git","clone_url":"https://github.com/BuoyantIO/linkerd-examples.git","svn_url":"https://github.com/BuoyantIO/linkerd-examples","homepage":"https://linkerd.io","size":217,"stargazers_count":62,"watchers_count":62,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56"},"html":{"href":"https://github.com/BuoyantIO/linkerd-examples/pull/56"},"issue":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/56"},"comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/BuoyantIO/linkerd-examples/statuses/b6bef71a7b8beb9fc8774a6f7cfb55441aca1010"}}}}
{"actor":{"display_login":"rmars"}}