{"action":"created","issue":{"url":"https://api.github.com/repos/ostreedev/ostree/issues/485","repository_url":"https://api.github.com/repos/ostreedev/ostree","labels_url":"https://api.github.com/repos/ostreedev/ostree/issues/485/labels{/name}","comments_url":"https://api.github.com/repos/ostreedev/ostree/issues/485/comments","events_url":"https://api.github.com/repos/ostreedev/ostree/issues/485/events","html_url":"https://github.com/ostreedev/ostree/pull/485","id":174332885,"number":485,"title":"Fix running ostree-prepare-root with musl","user":{"login":"wmanley","id":494659,"avatar_url":"https://avatars.githubusercontent.com/u/494659?v=3","gravatar_id":"","url":"https://api.github.com/users/wmanley","html_url":"https://github.com/wmanley","followers_url":"https://api.github.com/users/wmanley/followers","following_url":"https://api.github.com/users/wmanley/following{/other_user}","gists_url":"https://api.github.com/users/wmanley/gists{/gist_id}","starred_url":"https://api.github.com/users/wmanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmanley/subscriptions","organizations_url":"https://api.github.com/users/wmanley/orgs","repos_url":"https://api.github.com/users/wmanley/repos","events_url":"https://api.github.com/users/wmanley/events{/privacy}","received_events_url":"https://api.github.com/users/wmanley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-31T17:33:58Z","updated_at":"2016-09-01T20:40:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ostreedev/ostree/pulls/485","html_url":"https://github.com/ostreedev/ostree/pull/485","diff_url":"https://github.com/ostreedev/ostree/pull/485.diff","patch_url":"https://github.com/ostreedev/ostree/pull/485.patch"},"body":"#477 provided the ability to build `ostree-prepare-root` statically against musl, but it didn't run correctly.  This allows ostree-prepare-root to work with musl's unconventional approach to implementing `realpath`.\r\n\r\nmusl libc's implementation of `realpath` works by opening the path and then\r\ndoing a lookup in `/proc/self/fd` to find the canonical path.  This fails\r\nif `/proc` is not mounted.  This causes problems for us if\r\n`ostree-prepare-root` is `init` as `/proc` won't be mounted.\r\n\r\nWe have to mount `/proc` anyway for `/proc/cmdline` so this fix just\r\nexpands the scope over which `/proc` is mounted to include both our\r\n`realpath` calls.\r\n\r\nSee also:\r\n\r\n* http://www.openwall.com/lists/musl/2016/06/08/2 and\r\n* http://git.musl-libc.org/cgit/musl/tree/src/misc/realpath.c?id=e738b8cbe64b6dd3ed9f47b6d4cd7eb2c422b38d\r\n"},"comment":{"url":"https://api.github.com/repos/ostreedev/ostree/issues/comments/244205216","html_url":"https://github.com/ostreedev/ostree/pull/485#issuecomment-244205216","issue_url":"https://api.github.com/repos/ostreedev/ostree/issues/485","id":244205216,"user":{"login":"rh-atomic-bot","id":14112924,"avatar_url":"https://avatars.githubusercontent.com/u/14112924?v=3","gravatar_id":"","url":"https://api.github.com/users/rh-atomic-bot","html_url":"https://github.com/rh-atomic-bot","followers_url":"https://api.github.com/users/rh-atomic-bot/followers","following_url":"https://api.github.com/users/rh-atomic-bot/following{/other_user}","gists_url":"https://api.github.com/users/rh-atomic-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/rh-atomic-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rh-atomic-bot/subscriptions","organizations_url":"https://api.github.com/users/rh-atomic-bot/orgs","repos_url":"https://api.github.com/users/rh-atomic-bot/repos","events_url":"https://api.github.com/users/rh-atomic-bot/events{/privacy}","received_events_url":"https://api.github.com/users/rh-atomic-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T20:40:01Z","updated_at":"2016-09-01T20:40:01Z","body":":sunny: Test successful - [status-atomicjenkins](https://aos-ci.s3.amazonaws.com/ghprb/ostreedev/ostree/2aacc6912b78e7d3158f072cd9c1b3c5d0bddc22.18691.88/index.html)\nApproved by: cgwalters\nPushing 2aacc6912b78e7d3158f072cd9c1b3c5d0bddc22 to master..."}}
{"actor":{"display_login":"rh-atomic-bot"}}