{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/comments/68451974","id":68451974,"diff_hunk":"@@ -32,10 +33,10 @@ window.addEventListener( 'beforeunload', ( event ) => {\n const rootEl = document.getElementById( 'wc-connect-admin-container' );\n \n let render = () => {\n-\tconst WCCShippingSettings = require( 'views/shipping' );\n+\tconst RootView = 'shipping-label' === rootView ? require( 'views/shipping-label' ) : require( 'views/shipping' );","path":"client/main.js","position":13,"original_position":13,"commit_id":"1ccafd535455ba9e1d3088c00e0bf31134ce002b","original_commit_id":"53144c0fb4ae021cf6ff6ee8c82e51fbf1a5a471","user":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"body":"In this case, I think having a conditional `require` is a reasonable compromise. If we `require` the 2 modules and then decide which one to render, then we are pulling the entire dependency trees of both the components in every case. This may count as micro-optimization, but if it makes start-up 50ms quicker I think is worth having one \"weird\" line.","created_at":"2016-06-24T19:42:08Z","updated_at":"2016-06-24T19:42:08Z","html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/428#discussion_r68451974","pull_request_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428","_links":{"self":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/comments/68451974"},"html":{"href":"https://github.com/Automattic/woocommerce-connect-client/pull/428#discussion_r68451974"},"pull_request":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428","id":75028238,"html_url":"https://github.com/Automattic/woocommerce-connect-client/pull/428","diff_url":"https://github.com/Automattic/woocommerce-connect-client/pull/428.diff","patch_url":"https://github.com/Automattic/woocommerce-connect-client/pull/428.patch","issue_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/428","number":428,"state":"open","locked":false,"title":"Label printing: super early draft","user":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"body":"First approach to the label printing flow.\r\n\r\nI see this PR more as a \"sanity check\" to see if we all are in the same page, and if the general architecture of the Label Printing dialog is ok.\r\n\r\nHow to test: Create an order, and go to the \"Edit Order\" admin page. Click the \"Print Label\" button in the sidebar, and enjoy the super-duper dialog.\r\n\r\nWhat works:\r\n* Opening and closing the dialog.\r\n* Tabbed navigation (you can go back to a previous step in the form by clicking its title in the \"tab\" list).\r\n* Data-driveness.\r\n* Getting the destination address from the order.\r\n* The dialog will crash if you reach the \"Preview\" step. Just a heads up :)","created_at":"2016-06-23T21:12:48Z","updated_at":"2016-06-24T19:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82a84695481d846043838e6b43e8ee9f068d646e","assignee":{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanReyLop","id":1715800,"avatar_url":"https://avatars.githubusercontent.com/u/1715800?v=3","gravatar_id":"","url":"https://api.github.com/users/DanReyLop","html_url":"https://github.com/DanReyLop","followers_url":"https://api.github.com/users/DanReyLop/followers","following_url":"https://api.github.com/users/DanReyLop/following{/other_user}","gists_url":"https://api.github.com/users/DanReyLop/gists{/gist_id}","starred_url":"https://api.github.com/users/DanReyLop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanReyLop/subscriptions","organizations_url":"https://api.github.com/users/DanReyLop/orgs","repos_url":"https://api.github.com/users/DanReyLop/repos","events_url":"https://api.github.com/users/DanReyLop/events{/privacy}","received_events_url":"https://api.github.com/users/DanReyLop/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/5","html_url":"https://github.com/Automattic/woocommerce-connect-client/milestones/Beta%20w/%20Labels","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones/5/labels","id":1813858,"number":5,"title":"Beta w/ Labels","description":"","creator":{"login":"allendav","id":1595739,"avatar_url":"https://avatars.githubusercontent.com/u/1595739?v=3","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":14,"state":"open","created_at":"2016-06-07T16:24:16Z","updated_at":"2016-06-24T17:29:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428/commits","review_comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428/comments","review_comment_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/428/comments","statuses_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/statuses/1ccafd535455ba9e1d3088c00e0bf31134ce002b","head":{"label":"Automattic:add/label-printing","ref":"add/label-printing","sha":"1ccafd535455ba9e1d3088c00e0bf31134ce002b","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":50946955,"name":"woocommerce-connect-client","full_name":"Automattic/woocommerce-connect-client","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/woocommerce-connect-client","description":"WooCommerce Connect is a feature plugin, currently in Alpha, that integrates the WooCommerce Connect SaaS into WooCommerce (2.6 beta), Alpha includes real time USPS shipping rates and introduces our React based UI. This plugin will eventually be merged into WooCommerce core.","fork":false,"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client","forks_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/forks","keys_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/teams","hooks_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/hooks","issue_events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/events","assignees_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/tags","blobs_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/languages","stargazers_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/stargazers","contributors_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/contributors","subscribers_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/subscribers","subscription_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/subscription","commits_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/merges","archive_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/downloads","issues_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/deployments","created_at":"2016-02-02T19:44:26Z","updated_at":"2016-06-21T11:31:24Z","pushed_at":"2016-06-24T18:04:25Z","git_url":"git://github.com/Automattic/woocommerce-connect-client.git","ssh_url":"git@github.com:Automattic/woocommerce-connect-client.git","clone_url":"https://github.com/Automattic/woocommerce-connect-client.git","svn_url":"https://github.com/Automattic/woocommerce-connect-client","homepage":"","size":1088,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":42,"forks":1,"open_issues":42,"watchers":28,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"fd18be7bcdfcf4b354cffacc48ad86e0672900d0","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":50946955,"name":"woocommerce-connect-client","full_name":"Automattic/woocommerce-connect-client","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/woocommerce-connect-client","description":"WooCommerce Connect is a feature plugin, currently in Alpha, that integrates the WooCommerce Connect SaaS into WooCommerce (2.6 beta), Alpha includes real time USPS shipping rates and introduces our React based UI. This plugin will eventually be merged into WooCommerce core.","fork":false,"url":"https://api.github.com/repos/Automattic/woocommerce-connect-client","forks_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/forks","keys_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/teams","hooks_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/hooks","issue_events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/events","assignees_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/tags","blobs_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/languages","stargazers_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/stargazers","contributors_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/contributors","subscribers_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/subscribers","subscription_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/subscription","commits_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/merges","archive_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/downloads","issues_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/woocommerce-connect-client/deployments","created_at":"2016-02-02T19:44:26Z","updated_at":"2016-06-21T11:31:24Z","pushed_at":"2016-06-24T18:04:25Z","git_url":"git://github.com/Automattic/woocommerce-connect-client.git","ssh_url":"git@github.com:Automattic/woocommerce-connect-client.git","clone_url":"https://github.com/Automattic/woocommerce-connect-client.git","svn_url":"https://github.com/Automattic/woocommerce-connect-client","homepage":"","size":1088,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":42,"forks":1,"open_issues":42,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428"},"html":{"href":"https://github.com/Automattic/woocommerce-connect-client/pull/428"},"issue":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/428"},"comments":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/woocommerce-connect-client/statuses/1ccafd535455ba9e1d3088c00e0bf31134ce002b"}}}}
{"actor":{"display_login":"DanReyLop"}}