{"action":"closed","number":327,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/327","id":57643551,"html_url":"https://github.com/Valloric/ycmd/pull/327","diff_url":"https://github.com/Valloric/ycmd/pull/327.diff","patch_url":"https://github.com/Valloric/ycmd/pull/327.patch","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/327","number":327,"state":"closed","locked":false,"title":"Rename completion properties","user":{"login":"Qusic","id":2141853,"avatar_url":"https://avatars.githubusercontent.com/u/2141853?v=3","gravatar_id":"","url":"https://api.github.com/users/Qusic","html_url":"https://github.com/Qusic","followers_url":"https://api.github.com/users/Qusic/followers","following_url":"https://api.github.com/users/Qusic/following{/other_user}","gists_url":"https://api.github.com/users/Qusic/gists{/gist_id}","starred_url":"https://api.github.com/users/Qusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qusic/subscriptions","organizations_url":"https://api.github.com/users/Qusic/orgs","repos_url":"https://api.github.com/users/Qusic/repos","events_url":"https://api.github.com/users/Qusic/events{/privacy}","received_events_url":"https://api.github.com/users/Qusic/received_events","type":"User","site_admin":false},"body":"This PR is part of https://github.com/Valloric/ycmd/pull/137\r\nincluding (c) (d) (f) (g)\r\n\r\n    (a) kind            ==> kind (unchanged) // such as \"class\", \"variable\"\r\n    (b) extra_data      ==> extra_data (unchanged) // completer-specific data\r\n    (c) extra_menu_info ==> result_type (renamed) // type of the completion expression, such as \"int\", \"void\"\r\n    (d) menu_text       ==> display_string (renamed) // intended to be showed in UI for that completion\r\n    (e) insertion_text  ==> completion_chunks (converted)\r\n    (f) detailed_info   ==> doc_string (merged)\r\n    (g)                 ==> typed_string (added) // type in this string to get this completion. used for filtering, sorting and grouping.\r\n\r\nNames such as `menu_text` and `extra_menu_info` are too specific to the vim client and confusing to people who make clients for other editors or new completers for other languages.\r\nActually `detailed_info` and `doc_string` are both displayed in the same preview window, concatenated. So merging them will also make it clearer. Actually `detailed_info` is removed and I will explain it later.\r\n\r\nAnother notable change is that duplicate completions are no longer merged in this PR. For example, a function and its overloads are now separate completions. To elaborate it:\r\n\r\n1. `detailed_info` used to be lines of function signatures of different overloads and now it is not needed any more. the function signature(or anything that helps to use a completion) can be obtained in `display_string` of each separate completion.\r\n2. `doc_string` used to be the value returned by `clang_getCompletionBriefComment` for the first overload of that function. however, doc strings(if any) for other overloads were lost.\r\n3. a function and its overloads will have the same value for `typed_string` and clients are still able to group completions if necessary.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/327)\n<!-- Reviewable:end -->\n","created_at":"2016-01-29T12:49:07Z","updated_at":"2016-03-23T01:24:23Z","closed_at":"2016-03-23T01:24:23Z","merged_at":null,"merge_commit_sha":"6e5686d18e513eaa21b496d7e3c3f8eac37665cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Valloric/ycmd/pulls/327/commits","review_comments_url":"https://api.github.com/repos/Valloric/ycmd/pulls/327/comments","review_comment_url":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/327/comments","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/f99d0fa943562e6e1edcf4a2803cc2001832e91d","head":{"label":"Qusic:master","ref":"master","sha":"f99d0fa943562e6e1edcf4a2803cc2001832e91d","user":{"login":"Qusic","id":2141853,"avatar_url":"https://avatars.githubusercontent.com/u/2141853?v=3","gravatar_id":"","url":"https://api.github.com/users/Qusic","html_url":"https://github.com/Qusic","followers_url":"https://api.github.com/users/Qusic/followers","following_url":"https://api.github.com/users/Qusic/following{/other_user}","gists_url":"https://api.github.com/users/Qusic/gists{/gist_id}","starred_url":"https://api.github.com/users/Qusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qusic/subscriptions","organizations_url":"https://api.github.com/users/Qusic/orgs","repos_url":"https://api.github.com/users/Qusic/repos","events_url":"https://api.github.com/users/Qusic/events{/privacy}","received_events_url":"https://api.github.com/users/Qusic/received_events","type":"User","site_admin":false},"repo":{"id":50414644,"name":"ycmd","full_name":"Qusic/ycmd","owner":{"login":"Qusic","id":2141853,"avatar_url":"https://avatars.githubusercontent.com/u/2141853?v=3","gravatar_id":"","url":"https://api.github.com/users/Qusic","html_url":"https://github.com/Qusic","followers_url":"https://api.github.com/users/Qusic/followers","following_url":"https://api.github.com/users/Qusic/following{/other_user}","gists_url":"https://api.github.com/users/Qusic/gists{/gist_id}","starred_url":"https://api.github.com/users/Qusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qusic/subscriptions","organizations_url":"https://api.github.com/users/Qusic/orgs","repos_url":"https://api.github.com/users/Qusic/repos","events_url":"https://api.github.com/users/Qusic/events{/privacy}","received_events_url":"https://api.github.com/users/Qusic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qusic/ycmd","description":"A code-completion & code-comprehension server","fork":true,"url":"https://api.github.com/repos/Qusic/ycmd","forks_url":"https://api.github.com/repos/Qusic/ycmd/forks","keys_url":"https://api.github.com/repos/Qusic/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qusic/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qusic/ycmd/teams","hooks_url":"https://api.github.com/repos/Qusic/ycmd/hooks","issue_events_url":"https://api.github.com/repos/Qusic/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/Qusic/ycmd/events","assignees_url":"https://api.github.com/repos/Qusic/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/Qusic/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/Qusic/ycmd/tags","blobs_url":"https://api.github.com/repos/Qusic/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qusic/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qusic/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qusic/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qusic/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Qusic/ycmd/languages","stargazers_url":"https://api.github.com/repos/Qusic/ycmd/stargazers","contributors_url":"https://api.github.com/repos/Qusic/ycmd/contributors","subscribers_url":"https://api.github.com/repos/Qusic/ycmd/subscribers","subscription_url":"https://api.github.com/repos/Qusic/ycmd/subscription","commits_url":"https://api.github.com/repos/Qusic/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qusic/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qusic/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qusic/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qusic/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/Qusic/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qusic/ycmd/merges","archive_url":"https://api.github.com/repos/Qusic/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qusic/ycmd/downloads","issues_url":"https://api.github.com/repos/Qusic/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/Qusic/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Qusic/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Qusic/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qusic/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/Qusic/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/Qusic/ycmd/deployments","created_at":"2016-01-26T08:26:10Z","updated_at":"2016-01-26T08:26:18Z","pushed_at":"2016-03-08T09:57:44Z","git_url":"git://github.com/Qusic/ycmd.git","ssh_url":"git@github.com:Qusic/ycmd.git","clone_url":"https://github.com/Qusic/ycmd.git","svn_url":"https://github.com/Qusic/ycmd","homepage":null,"size":8573,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Valloric:master","ref":"master","sha":"14fbdaaa5e880323aea8119073eb3da9579b721c","user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"repo":{"id":19832415,"name":"ycmd","full_name":"Valloric/ycmd","owner":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Valloric/ycmd","description":"A code-completion & code-comprehension server","fork":false,"url":"https://api.github.com/repos/Valloric/ycmd","forks_url":"https://api.github.com/repos/Valloric/ycmd/forks","keys_url":"https://api.github.com/repos/Valloric/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valloric/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valloric/ycmd/teams","hooks_url":"https://api.github.com/repos/Valloric/ycmd/hooks","issue_events_url":"https://api.github.com/repos/Valloric/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/Valloric/ycmd/events","assignees_url":"https://api.github.com/repos/Valloric/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/Valloric/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/Valloric/ycmd/tags","blobs_url":"https://api.github.com/repos/Valloric/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valloric/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valloric/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valloric/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Valloric/ycmd/languages","stargazers_url":"https://api.github.com/repos/Valloric/ycmd/stargazers","contributors_url":"https://api.github.com/repos/Valloric/ycmd/contributors","subscribers_url":"https://api.github.com/repos/Valloric/ycmd/subscribers","subscription_url":"https://api.github.com/repos/Valloric/ycmd/subscription","commits_url":"https://api.github.com/repos/Valloric/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valloric/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valloric/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valloric/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valloric/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/Valloric/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valloric/ycmd/merges","archive_url":"https://api.github.com/repos/Valloric/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valloric/ycmd/downloads","issues_url":"https://api.github.com/repos/Valloric/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/Valloric/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Valloric/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Valloric/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valloric/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/Valloric/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/Valloric/ycmd/deployments","created_at":"2014-05-15T19:30:17Z","updated_at":"2016-03-23T00:12:12Z","pushed_at":"2016-03-22T22:30:26Z","git_url":"git://github.com/Valloric/ycmd.git","ssh_url":"git@github.com:Valloric/ycmd.git","clone_url":"https://github.com/Valloric/ycmd.git","svn_url":"https://github.com/Valloric/ycmd","homepage":null,"size":9869,"stargazers_count":540,"watchers_count":540,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":297,"mirror_url":null,"open_issues_count":31,"forks":297,"open_issues":31,"watchers":540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/327"},"html":{"href":"https://github.com/Valloric/ycmd/pull/327"},"issue":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/327"},"comments":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/Valloric/ycmd/statuses/f99d0fa943562e6e1edcf4a2803cc2001832e91d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":18,"review_comments":0,"commits":10,"additions":131,"deletions":139,"changed_files":26}}