{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/comments/81239340","pull_request_review_id":2231860,"id":81239340,"diff_hunk":"@@ -0,0 +1,46 @@\n+/*\n+ * Copyright 2016 <Admobilize>\n+ * MATRIX Labs  [http://creator.matrix.one]\n+ * This file is part of MATRIX Creator MALOS\n+ *\n+ * MATRIX Creator MALOS is free software: you can redistribute it and/or\n+ * modify it under the terms of the GNU General Public License as\n+ * published by the Free Software Foundation, either version 3 of the\n+ * License, or (at your option) any later version.\n+ * This program is distributed in the hope that it will be useful, but\n+ * WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU\n+ * General Public License for more details.\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+#include <iostream>\n+#include \"./driver_lirc.h\"\n+#include \"./src/driver.pb.h\"\n+#include <stdio.h>\n+#include <stdlib.h>\n+\n+namespace matrix_malos {\n+\n+bool LircDriver::ProcessConfig(const DriverConfig& config) {\n+  LircParams lirc(config.lirc());\n+\n+  if (lirc.device() == \"\" || lirc.command() == \"\") {\n+    std::string error_msg(\"device or command parameter is missing\");\n+    error_msg += kLircDriverName;\n+    zmq_push_error_->Send(error_msg);","path":"src/driver_lirc.cpp","position":32,"original_position":32,"commit_id":"21e9f8dcd09823a3e08cf05b6a40cb80ff6c641a","original_commit_id":"21e9f8dcd09823a3e08cf05b6a40cb80ff6c641a","user":{"login":"arhuaco","id":858778,"avatar_url":"https://avatars.githubusercontent.com/u/858778?v=3","gravatar_id":"","url":"https://api.github.com/users/arhuaco","html_url":"https://github.com/arhuaco","followers_url":"https://api.github.com/users/arhuaco/followers","following_url":"https://api.github.com/users/arhuaco/following{/other_user}","gists_url":"https://api.github.com/users/arhuaco/gists{/gist_id}","starred_url":"https://api.github.com/users/arhuaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arhuaco/subscriptions","organizations_url":"https://api.github.com/users/arhuaco/orgs","repos_url":"https://api.github.com/users/arhuaco/repos","events_url":"https://api.github.com/users/arhuaco/events{/privacy}","received_events_url":"https://api.github.com/users/arhuaco/received_events","type":"User","site_admin":false},"body":"I think you can do:\r\n    zmq_push_error_->Send(\"device or command parameter is missing:\" + kLircDriverName);\r\nand save two lines.","created_at":"2016-09-29T21:33:21Z","updated_at":"2016-09-29T21:35:39Z","html_url":"https://github.com/matrix-io/matrix-creator-malos/pull/13#discussion_r81239340","pull_request_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/comments/81239340"},"html":{"href":"https://github.com/matrix-io/matrix-creator-malos/pull/13#discussion_r81239340"},"pull_request":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13","id":87391986,"html_url":"https://github.com/matrix-io/matrix-creator-malos/pull/13","diff_url":"https://github.com/matrix-io/matrix-creator-malos/pull/13.diff","patch_url":"https://github.com/matrix-io/matrix-creator-malos/pull/13.patch","issue_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/13","number":13,"state":"open","locked":false,"title":"Av/lirc driver","user":{"login":"hpsaturn","id":423856,"avatar_url":"https://avatars.githubusercontent.com/u/423856?v=3","gravatar_id":"","url":"https://api.github.com/users/hpsaturn","html_url":"https://github.com/hpsaturn","followers_url":"https://api.github.com/users/hpsaturn/followers","following_url":"https://api.github.com/users/hpsaturn/following{/other_user}","gists_url":"https://api.github.com/users/hpsaturn/gists{/gist_id}","starred_url":"https://api.github.com/users/hpsaturn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpsaturn/subscriptions","organizations_url":"https://api.github.com/users/hpsaturn/orgs","repos_url":"https://api.github.com/users/hpsaturn/repos","events_url":"https://api.github.com/users/hpsaturn/events{/privacy}","received_events_url":"https://api.github.com/users/hpsaturn/received_events","type":"User","site_admin":false},"body":"Initial basic driver for SEND commands over LIRC service","created_at":"2016-09-29T20:53:46Z","updated_at":"2016-09-29T21:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cc8d793d9f9072561d28522b684c3283f4245db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13/commits","review_comments_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13/comments","review_comment_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/13/comments","statuses_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/statuses/21e9f8dcd09823a3e08cf05b6a40cb80ff6c641a","head":{"label":"matrix-io:av/lirc_driver","ref":"av/lirc_driver","sha":"21e9f8dcd09823a3e08cf05b6a40cb80ff6c641a","user":{"login":"matrix-io","id":15808325,"avatar_url":"https://avatars.githubusercontent.com/u/15808325?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-io","html_url":"https://github.com/matrix-io","followers_url":"https://api.github.com/users/matrix-io/followers","following_url":"https://api.github.com/users/matrix-io/following{/other_user}","gists_url":"https://api.github.com/users/matrix-io/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-io/subscriptions","organizations_url":"https://api.github.com/users/matrix-io/orgs","repos_url":"https://api.github.com/users/matrix-io/repos","events_url":"https://api.github.com/users/matrix-io/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-io/received_events","type":"Organization","site_admin":false},"repo":{"id":65556722,"name":"matrix-creator-malos","full_name":"matrix-io/matrix-creator-malos","owner":{"login":"matrix-io","id":15808325,"avatar_url":"https://avatars.githubusercontent.com/u/15808325?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-io","html_url":"https://github.com/matrix-io","followers_url":"https://api.github.com/users/matrix-io/followers","following_url":"https://api.github.com/users/matrix-io/following{/other_user}","gists_url":"https://api.github.com/users/matrix-io/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-io/subscriptions","organizations_url":"https://api.github.com/users/matrix-io/orgs","repos_url":"https://api.github.com/users/matrix-io/repos","events_url":"https://api.github.com/users/matrix-io/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-io/matrix-creator-malos","description":"MATRIX Creator abstraction for MOS","fork":false,"url":"https://api.github.com/repos/matrix-io/matrix-creator-malos","forks_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/forks","keys_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/teams","hooks_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/hooks","issue_events_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/events","assignees_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/tags","blobs_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/languages","stargazers_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/stargazers","contributors_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/contributors","subscribers_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/subscribers","subscription_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/subscription","commits_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/merges","archive_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/downloads","issues_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/labels{/name}","releases_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/deployments","created_at":"2016-08-12T13:50:33Z","updated_at":"2016-08-15T14:33:50Z","pushed_at":"2016-09-29T20:53:46Z","git_url":"git://github.com/matrix-io/matrix-creator-malos.git","ssh_url":"git@github.com:matrix-io/matrix-creator-malos.git","clone_url":"https://github.com/matrix-io/matrix-creator-malos.git","svn_url":"https://github.com/matrix-io/matrix-creator-malos","homepage":null,"size":103,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"matrix-io:master","ref":"master","sha":"c661d82538c04ea9deef34b65e1ca036b2c7218e","user":{"login":"matrix-io","id":15808325,"avatar_url":"https://avatars.githubusercontent.com/u/15808325?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-io","html_url":"https://github.com/matrix-io","followers_url":"https://api.github.com/users/matrix-io/followers","following_url":"https://api.github.com/users/matrix-io/following{/other_user}","gists_url":"https://api.github.com/users/matrix-io/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-io/subscriptions","organizations_url":"https://api.github.com/users/matrix-io/orgs","repos_url":"https://api.github.com/users/matrix-io/repos","events_url":"https://api.github.com/users/matrix-io/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-io/received_events","type":"Organization","site_admin":false},"repo":{"id":65556722,"name":"matrix-creator-malos","full_name":"matrix-io/matrix-creator-malos","owner":{"login":"matrix-io","id":15808325,"avatar_url":"https://avatars.githubusercontent.com/u/15808325?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-io","html_url":"https://github.com/matrix-io","followers_url":"https://api.github.com/users/matrix-io/followers","following_url":"https://api.github.com/users/matrix-io/following{/other_user}","gists_url":"https://api.github.com/users/matrix-io/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-io/subscriptions","organizations_url":"https://api.github.com/users/matrix-io/orgs","repos_url":"https://api.github.com/users/matrix-io/repos","events_url":"https://api.github.com/users/matrix-io/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-io/matrix-creator-malos","description":"MATRIX Creator abstraction for MOS","fork":false,"url":"https://api.github.com/repos/matrix-io/matrix-creator-malos","forks_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/forks","keys_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/teams","hooks_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/hooks","issue_events_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/events","assignees_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/tags","blobs_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/languages","stargazers_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/stargazers","contributors_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/contributors","subscribers_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/subscribers","subscription_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/subscription","commits_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/merges","archive_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/downloads","issues_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/labels{/name}","releases_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-io/matrix-creator-malos/deployments","created_at":"2016-08-12T13:50:33Z","updated_at":"2016-08-15T14:33:50Z","pushed_at":"2016-09-29T20:53:46Z","git_url":"git://github.com/matrix-io/matrix-creator-malos.git","ssh_url":"git@github.com:matrix-io/matrix-creator-malos.git","clone_url":"https://github.com/matrix-io/matrix-creator-malos.git","svn_url":"https://github.com/matrix-io/matrix-creator-malos","homepage":null,"size":103,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13"},"html":{"href":"https://github.com/matrix-io/matrix-creator-malos/pull/13"},"issue":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/13"},"comments":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-io/matrix-creator-malos/statuses/21e9f8dcd09823a3e08cf05b6a40cb80ff6c641a"}}}}
{"actor":{"display_login":"arhuaco"}}