{"action":"created","comment":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/comments/88080600","pull_request_review_id":8665243,"id":88080600,"diff_hunk":"@@ -13,28 +13,41 @@ import (\n )\n \n var seedData = []string{\n-\t\"zero\", \"one\", \"two\", \"three\", \"four\", \"five\", \"six\", \"seven\", \"eight\", \"nine\", \"ten\",\n+\t\"zero\", \"one\", \"two\", \"three\", \"four\", \"five\", \"six\", \"seven\", \"eight\", \"nine\",\n }\n \n const testCollectionSize = 100000\n \n func genTestBlob() (Blob, []byte) {\n \tvar buffer bytes.Buffer\n-\tfor i := 0; i < testCollectionSize; i += 1 {\n+\tsmallTestChunks()\n+\tdefer normalProductionChunks()\n+Loop:\n+\tfor i := 0; true; i += 1 {","path":"go/types/sequence_iterator_test.go","position":16,"original_position":16,"commit_id":"5d4a845617e0b3434bb516dcefa67d7804425383","original_commit_id":"5d4a845617e0b3434bb516dcefa67d7804425383","user":{"login":"zcstarr","id":173187,"avatar_url":"https://avatars.githubusercontent.com/u/173187?v=3","gravatar_id":"","url":"https://api.github.com/users/zcstarr","html_url":"https://github.com/zcstarr","followers_url":"https://api.github.com/users/zcstarr/followers","following_url":"https://api.github.com/users/zcstarr/following{/other_user}","gists_url":"https://api.github.com/users/zcstarr/gists{/gist_id}","starred_url":"https://api.github.com/users/zcstarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcstarr/subscriptions","organizations_url":"https://api.github.com/users/zcstarr/orgs","repos_url":"https://api.github.com/users/zcstarr/repos","events_url":"https://api.github.com/users/zcstarr/events{/privacy}","received_events_url":"https://api.github.com/users/zcstarr/received_events","type":"User","site_admin":false},"body":"This might be a little more clear as a straight for loop and maybe modding the count to iterate through the set.\r\nsomething like this perhaps ?\r\nfor i:=0; buffer.Len() < testCollectionSize; i++ {\r\n\tv := seedData[ i % len(seedData)]\r\n        //writeString\r\n}","created_at":"2016-11-15T18:26:13Z","updated_at":"2016-11-15T18:26:13Z","html_url":"https://github.com/attic-labs/noms/pull/2831#discussion_r88080600","pull_request_url":"https://api.github.com/repos/attic-labs/noms/pulls/2831","_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments/88080600"},"html":{"href":"https://github.com/attic-labs/noms/pull/2831#discussion_r88080600"},"pull_request":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2831"}}},"pull_request":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/2831","id":93699945,"html_url":"https://github.com/attic-labs/noms/pull/2831","diff_url":"https://github.com/attic-labs/noms/pull/2831.diff","patch_url":"https://github.com/attic-labs/noms/pull/2831.patch","issue_url":"https://api.github.com/repos/attic-labs/noms/issues/2831","number":2831,"state":"open","locked":false,"title":"Reduce time required by sequence_iterator_test by using smaller chunk sizes","user":{"login":"ehalpern","id":852484,"avatar_url":"https://avatars.githubusercontent.com/u/852484?v=3","gravatar_id":"","url":"https://api.github.com/users/ehalpern","html_url":"https://github.com/ehalpern","followers_url":"https://api.github.com/users/ehalpern/followers","following_url":"https://api.github.com/users/ehalpern/following{/other_user}","gists_url":"https://api.github.com/users/ehalpern/gists{/gist_id}","starred_url":"https://api.github.com/users/ehalpern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehalpern/subscriptions","organizations_url":"https://api.github.com/users/ehalpern/orgs","repos_url":"https://api.github.com/users/ehalpern/repos","events_url":"https://api.github.com/users/ehalpern/events{/privacy}","received_events_url":"https://api.github.com/users/ehalpern/received_events","type":"User","site_admin":false},"body":"PR @zcstarr: reduced the test sequence sizes to speed up tests. ","created_at":"2016-11-15T04:37:02Z","updated_at":"2016-11-15T18:26:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac697b0994e2303cbf0135b9d23b0d49f9f9ec45","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/attic-labs/noms/pulls/2831/commits","review_comments_url":"https://api.github.com/repos/attic-labs/noms/pulls/2831/comments","review_comment_url":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/attic-labs/noms/issues/2831/comments","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/5d4a845617e0b3434bb516dcefa67d7804425383","head":{"label":"ehalpern:master","ref":"master","sha":"5d4a845617e0b3434bb516dcefa67d7804425383","user":{"login":"ehalpern","id":852484,"avatar_url":"https://avatars.githubusercontent.com/u/852484?v=3","gravatar_id":"","url":"https://api.github.com/users/ehalpern","html_url":"https://github.com/ehalpern","followers_url":"https://api.github.com/users/ehalpern/followers","following_url":"https://api.github.com/users/ehalpern/following{/other_user}","gists_url":"https://api.github.com/users/ehalpern/gists{/gist_id}","starred_url":"https://api.github.com/users/ehalpern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehalpern/subscriptions","organizations_url":"https://api.github.com/users/ehalpern/orgs","repos_url":"https://api.github.com/users/ehalpern/repos","events_url":"https://api.github.com/users/ehalpern/events{/privacy}","received_events_url":"https://api.github.com/users/ehalpern/received_events","type":"User","site_admin":false},"repo":{"id":64963159,"name":"noms","full_name":"ehalpern/noms","owner":{"login":"ehalpern","id":852484,"avatar_url":"https://avatars.githubusercontent.com/u/852484?v=3","gravatar_id":"","url":"https://api.github.com/users/ehalpern","html_url":"https://github.com/ehalpern","followers_url":"https://api.github.com/users/ehalpern/followers","following_url":"https://api.github.com/users/ehalpern/following{/other_user}","gists_url":"https://api.github.com/users/ehalpern/gists{/gist_id}","starred_url":"https://api.github.com/users/ehalpern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehalpern/subscriptions","organizations_url":"https://api.github.com/users/ehalpern/orgs","repos_url":"https://api.github.com/users/ehalpern/repos","events_url":"https://api.github.com/users/ehalpern/events{/privacy}","received_events_url":"https://api.github.com/users/ehalpern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehalpern/noms","description":"The versioned, forkable, syncable database","fork":true,"url":"https://api.github.com/repos/ehalpern/noms","forks_url":"https://api.github.com/repos/ehalpern/noms/forks","keys_url":"https://api.github.com/repos/ehalpern/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehalpern/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehalpern/noms/teams","hooks_url":"https://api.github.com/repos/ehalpern/noms/hooks","issue_events_url":"https://api.github.com/repos/ehalpern/noms/issues/events{/number}","events_url":"https://api.github.com/repos/ehalpern/noms/events","assignees_url":"https://api.github.com/repos/ehalpern/noms/assignees{/user}","branches_url":"https://api.github.com/repos/ehalpern/noms/branches{/branch}","tags_url":"https://api.github.com/repos/ehalpern/noms/tags","blobs_url":"https://api.github.com/repos/ehalpern/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehalpern/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehalpern/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehalpern/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehalpern/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/ehalpern/noms/languages","stargazers_url":"https://api.github.com/repos/ehalpern/noms/stargazers","contributors_url":"https://api.github.com/repos/ehalpern/noms/contributors","subscribers_url":"https://api.github.com/repos/ehalpern/noms/subscribers","subscription_url":"https://api.github.com/repos/ehalpern/noms/subscription","commits_url":"https://api.github.com/repos/ehalpern/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehalpern/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehalpern/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehalpern/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehalpern/noms/contents/{+path}","compare_url":"https://api.github.com/repos/ehalpern/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehalpern/noms/merges","archive_url":"https://api.github.com/repos/ehalpern/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehalpern/noms/downloads","issues_url":"https://api.github.com/repos/ehalpern/noms/issues{/number}","pulls_url":"https://api.github.com/repos/ehalpern/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/ehalpern/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/ehalpern/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehalpern/noms/labels{/name}","releases_url":"https://api.github.com/repos/ehalpern/noms/releases{/id}","deployments_url":"https://api.github.com/repos/ehalpern/noms/deployments","created_at":"2016-08-04T19:56:13Z","updated_at":"2016-08-04T19:56:15Z","pushed_at":"2016-11-15T04:33:57Z","git_url":"git://github.com/ehalpern/noms.git","ssh_url":"git@github.com:ehalpern/noms.git","clone_url":"https://github.com/ehalpern/noms.git","svn_url":"https://github.com/ehalpern/noms","homepage":"","size":27785,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"attic-labs:master","ref":"master","sha":"94a61c6aade84b825b7fca62309e8dd95722fcf0","user":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":36778364,"name":"noms","full_name":"attic-labs/noms","owner":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/attic-labs/noms","description":"The versioned, forkable, syncable database","fork":false,"url":"https://api.github.com/repos/attic-labs/noms","forks_url":"https://api.github.com/repos/attic-labs/noms/forks","keys_url":"https://api.github.com/repos/attic-labs/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attic-labs/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attic-labs/noms/teams","hooks_url":"https://api.github.com/repos/attic-labs/noms/hooks","issue_events_url":"https://api.github.com/repos/attic-labs/noms/issues/events{/number}","events_url":"https://api.github.com/repos/attic-labs/noms/events","assignees_url":"https://api.github.com/repos/attic-labs/noms/assignees{/user}","branches_url":"https://api.github.com/repos/attic-labs/noms/branches{/branch}","tags_url":"https://api.github.com/repos/attic-labs/noms/tags","blobs_url":"https://api.github.com/repos/attic-labs/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attic-labs/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attic-labs/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/attic-labs/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/attic-labs/noms/languages","stargazers_url":"https://api.github.com/repos/attic-labs/noms/stargazers","contributors_url":"https://api.github.com/repos/attic-labs/noms/contributors","subscribers_url":"https://api.github.com/repos/attic-labs/noms/subscribers","subscription_url":"https://api.github.com/repos/attic-labs/noms/subscription","commits_url":"https://api.github.com/repos/attic-labs/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/attic-labs/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/attic-labs/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/attic-labs/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/attic-labs/noms/contents/{+path}","compare_url":"https://api.github.com/repos/attic-labs/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attic-labs/noms/merges","archive_url":"https://api.github.com/repos/attic-labs/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attic-labs/noms/downloads","issues_url":"https://api.github.com/repos/attic-labs/noms/issues{/number}","pulls_url":"https://api.github.com/repos/attic-labs/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/attic-labs/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/attic-labs/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attic-labs/noms/labels{/name}","releases_url":"https://api.github.com/repos/attic-labs/noms/releases{/id}","deployments_url":"https://api.github.com/repos/attic-labs/noms/deployments","created_at":"2015-06-03T03:44:49Z","updated_at":"2016-11-15T13:50:31Z","pushed_at":"2016-11-15T10:24:48Z","git_url":"git://github.com/attic-labs/noms.git","ssh_url":"git@github.com:attic-labs/noms.git","clone_url":"https://github.com/attic-labs/noms.git","svn_url":"https://github.com/attic-labs/noms","homepage":"","size":40420,"stargazers_count":5841,"watchers_count":5841,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":243,"forks":168,"open_issues":243,"watchers":5841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2831"},"html":{"href":"https://github.com/attic-labs/noms/pull/2831"},"issue":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2831"},"comments":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2831/comments"},"review_comments":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2831/comments"},"review_comment":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2831/commits"},"statuses":{"href":"https://api.github.com/repos/attic-labs/noms/statuses/5d4a845617e0b3434bb516dcefa67d7804425383"}}}}
{"actor":{"display_login":"zcstarr"}}