{"action":"created","issue":{"url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView/issues/11","repository_url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView","labels_url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView/issues/11/comments","events_url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView/issues/11/events","html_url":"https://github.com/JeffreyBLewis/WebVoteView/issues/11","id":176720956,"number":11,"title":"Code that depends on manual updating each congress","user":{"login":"aaronrudkin","id":14701267,"avatar_url":"https://avatars.githubusercontent.com/u/14701267?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronrudkin","html_url":"https://github.com/aaronrudkin","followers_url":"https://api.github.com/users/aaronrudkin/followers","following_url":"https://api.github.com/users/aaronrudkin/following{/other_user}","gists_url":"https://api.github.com/users/aaronrudkin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronrudkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronrudkin/subscriptions","organizations_url":"https://api.github.com/users/aaronrudkin/orgs","repos_url":"https://api.github.com/users/aaronrudkin/repos","events_url":"https://api.github.com/users/aaronrudkin/events{/privacy}","received_events_url":"https://api.github.com/users/aaronrudkin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"JeffreyBLewis","id":4761445,"avatar_url":"https://avatars.githubusercontent.com/u/4761445?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffreyBLewis","html_url":"https://github.com/JeffreyBLewis","followers_url":"https://api.github.com/users/JeffreyBLewis/followers","following_url":"https://api.github.com/users/JeffreyBLewis/following{/other_user}","gists_url":"https://api.github.com/users/JeffreyBLewis/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffreyBLewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffreyBLewis/subscriptions","organizations_url":"https://api.github.com/users/JeffreyBLewis/orgs","repos_url":"https://api.github.com/users/JeffreyBLewis/repos","events_url":"https://api.github.com/users/JeffreyBLewis/events{/privacy}","received_events_url":"https://api.github.com/users/JeffreyBLewis/received_events","type":"User","site_admin":false},"assignees":[{"login":"JeffreyBLewis","id":4761445,"avatar_url":"https://avatars.githubusercontent.com/u/4761445?v=3","gravatar_id":"","url":"https://api.github.com/users/JeffreyBLewis","html_url":"https://github.com/JeffreyBLewis","followers_url":"https://api.github.com/users/JeffreyBLewis/followers","following_url":"https://api.github.com/users/JeffreyBLewis/following{/other_user}","gists_url":"https://api.github.com/users/JeffreyBLewis/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffreyBLewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffreyBLewis/subscriptions","organizations_url":"https://api.github.com/users/JeffreyBLewis/orgs","repos_url":"https://api.github.com/users/JeffreyBLewis/repos","events_url":"https://api.github.com/users/JeffreyBLewis/events{/privacy}","received_events_url":"https://api.github.com/users/JeffreyBLewis/received_events","type":"User","site_admin":false},{"login":"lukesonnet","id":5298599,"avatar_url":"https://avatars.githubusercontent.com/u/5298599?v=3","gravatar_id":"","url":"https://api.github.com/users/lukesonnet","html_url":"https://github.com/lukesonnet","followers_url":"https://api.github.com/users/lukesonnet/followers","following_url":"https://api.github.com/users/lukesonnet/following{/other_user}","gists_url":"https://api.github.com/users/lukesonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesonnet/subscriptions","organizations_url":"https://api.github.com/users/lukesonnet/orgs","repos_url":"https://api.github.com/users/lukesonnet/repos","events_url":"https://api.github.com/users/lukesonnet/events{/privacy}","received_events_url":"https://api.github.com/users/lukesonnet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-13T18:54:08Z","updated_at":"2016-09-13T19:09:17Z","closed_at":null,"body":"A portion of our code requires updates each congress to ensure things do not break. We should inventory this code, look at impacts to the site if we fail to update each congress (i.e. will it break features or just display poorly), decide if can we automate the transition or is it necessarily manual, note which files are affected, etc. I don't think we'll forget to do the 2017 transition to the 115th, but by the time the next one rolls around, we might be less involved.\r\n\r\n- Vote maps rely on the existence of a json file for each congress. If a map is not found for a given congress, the map will not display but the vote page will otherwise work. Jeff can speak to if it is possible to automate this further. We could also make a cron job to automatically copy this session's maps to the next session--I don't know what kind of errors this could lead to if we did. Maybe do this pre-emptively until 2020? We could also write error handling code to fall back on the most recent good map in the event that no maps exist.\r\n- The maps used for the party control map rely on state boundaries that have \"expiry date\". Jeff has set the expiry dates to 2020. If the states expire, then in 2021 our map will just be blank. This requires updating the states_all.json file. Does it make sense to maybe set them to 2050 (i.e. push the problem until we are dead or retired)? Do we expect any states to secede and/or split in two? Admission of new states isn't a problem--first, because we're not likely to passively forget when this happens. Second, because the error would only be the new state not appearing, nothing would happen to the map as a whole. I would recommend pushing the date at least a little bit past 2020.\r\n- A variety of graphs rely on a hardcoded maximum congress number for setting x-axes. If we do not change this, data from current congresses will not show up on those pages. I think it probably makes sense to hardcode the maximum congress number in exactly one place, have all of the graphs read the maximum from that one place, and then if we're confident change that one place from hardcoded to dynamic depending on the calendar or we could create a cron job to dynamically pull the maximum congress number from the vote databases. Thoughts?\r\n\r\nI have no idea if this is exhaustive. We should grep all code looking for 113, 114, or 115 (to account for off-by-one), as well as 2014, 2015, 2016, 2017, 2020, 2025, 2030. Most of this is my code but I'd appreciate it if someone else could hop in to help work through this."},"comment":{"url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView/issues/comments/246790700","html_url":"https://github.com/JeffreyBLewis/WebVoteView/issues/11#issuecomment-246790700","issue_url":"https://api.github.com/repos/JeffreyBLewis/WebVoteView/issues/11","id":246790700,"user":{"login":"aaronrudkin","id":14701267,"avatar_url":"https://avatars.githubusercontent.com/u/14701267?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronrudkin","html_url":"https://github.com/aaronrudkin","followers_url":"https://api.github.com/users/aaronrudkin/followers","following_url":"https://api.github.com/users/aaronrudkin/following{/other_user}","gists_url":"https://api.github.com/users/aaronrudkin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronrudkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronrudkin/subscriptions","organizations_url":"https://api.github.com/users/aaronrudkin/orgs","repos_url":"https://api.github.com/users/aaronrudkin/repos","events_url":"https://api.github.com/users/aaronrudkin/events{/privacy}","received_events_url":"https://api.github.com/users/aaronrudkin/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T19:09:17Z","updated_at":"2016-09-13T19:09:17Z","body":"**views/parties.tpl**, **views/congress.tpl**, **views/partiesGlance.tpl** all have hardcoded 114s. These all run python code so they can easily pull from a hardcoded config file. I have some examples of reading json config files in the model folder (for example our auth info for the email api)."}}
{"actor":{"display_login":"aaronrudkin"}}