{"action":"closed","number":1158,"pull_request":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1158","id":55079700,"html_url":"https://github.com/cogneco/ooc-kean/pull/1158","diff_url":"https://github.com/cogneco/ooc-kean/pull/1158.diff","patch_url":"https://github.com/cogneco/ooc-kean/pull/1158.patch","issue_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/1158","number":1158,"state":"closed","locked":false,"title":"Removed - operator and changed + to * in FloatEuclidTransform","user":{"login":"tomasmahlberg","id":14270984,"avatar_url":"https://avatars.githubusercontent.com/u/14270984?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasmahlberg","html_url":"https://github.com/tomasmahlberg","followers_url":"https://api.github.com/users/tomasmahlberg/followers","following_url":"https://api.github.com/users/tomasmahlberg/following{/other_user}","gists_url":"https://api.github.com/users/tomasmahlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasmahlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasmahlberg/subscriptions","organizations_url":"https://api.github.com/users/tomasmahlberg/orgs","repos_url":"https://api.github.com/users/tomasmahlberg/repos","events_url":"https://api.github.com/users/tomasmahlberg/events{/privacy}","received_events_url":"https://api.github.com/users/tomasmahlberg/received_events","type":"User","site_admin":false},"body":"Since some of the operations carried out by the `+` operator are non-commutative it makes more sense to change this to a `*` operator for clarity. If we want to do what `-` was doing previously we should have to do `euclidTransform1 * euclidTransform2 inverse` instead of `euclidTransform1 - euclidTransform2`.\r\n@niklasborwell @emilwestergren Thoughts?","created_at":"2016-01-05T11:12:34Z","updated_at":"2016-01-08T08:18:24Z","closed_at":"2016-01-08T08:18:24Z","merged_at":"2016-01-08T08:18:24Z","merge_commit_sha":"d4ccca1b878b6c64dda13ec4433ffac9a5997ea1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/1158/comments","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/e24fe2c903881132d830000f64112fa46318582f","head":{"label":"tomasmahlberg:euclidTransformOperator","ref":"euclidTransformOperator","sha":"e24fe2c903881132d830000f64112fa46318582f","user":{"login":"tomasmahlberg","id":14270984,"avatar_url":"https://avatars.githubusercontent.com/u/14270984?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasmahlberg","html_url":"https://github.com/tomasmahlberg","followers_url":"https://api.github.com/users/tomasmahlberg/followers","following_url":"https://api.github.com/users/tomasmahlberg/following{/other_user}","gists_url":"https://api.github.com/users/tomasmahlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasmahlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasmahlberg/subscriptions","organizations_url":"https://api.github.com/users/tomasmahlberg/orgs","repos_url":"https://api.github.com/users/tomasmahlberg/repos","events_url":"https://api.github.com/users/tomasmahlberg/events{/privacy}","received_events_url":"https://api.github.com/users/tomasmahlberg/received_events","type":"User","site_admin":false},"repo":{"id":42435381,"name":"ooc-kean","full_name":"tomasmahlberg/ooc-kean","owner":{"login":"tomasmahlberg","id":14270984,"avatar_url":"https://avatars.githubusercontent.com/u/14270984?v=3","gravatar_id":"","url":"https://api.github.com/users/tomasmahlberg","html_url":"https://github.com/tomasmahlberg","followers_url":"https://api.github.com/users/tomasmahlberg/followers","following_url":"https://api.github.com/users/tomasmahlberg/following{/other_user}","gists_url":"https://api.github.com/users/tomasmahlberg/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasmahlberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasmahlberg/subscriptions","organizations_url":"https://api.github.com/users/tomasmahlberg/orgs","repos_url":"https://api.github.com/users/tomasmahlberg/repos","events_url":"https://api.github.com/users/tomasmahlberg/events{/privacy}","received_events_url":"https://api.github.com/users/tomasmahlberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomasmahlberg/ooc-kean","description":"ooc port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/tomasmahlberg/ooc-kean","forks_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/forks","keys_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/teams","hooks_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/events","assignees_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/tags","blobs_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/subscription","commits_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/merges","archive_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/downloads","issues_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/tomasmahlberg/ooc-kean/releases{/id}","created_at":"2015-09-14T08:02:20Z","updated_at":"2015-09-14T08:02:21Z","pushed_at":"2016-01-08T07:53:24Z","git_url":"git://github.com/tomasmahlberg/ooc-kean.git","ssh_url":"git@github.com:tomasmahlberg/ooc-kean.git","clone_url":"https://github.com/tomasmahlberg/ooc-kean.git","svn_url":"https://github.com/tomasmahlberg/ooc-kean","homepage":"","size":29388,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cogneco:master","ref":"master","sha":"662d99449e7d9bb3797ffd3719b450a72efa33be","user":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"cogneco/ooc-kean","owner":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cogneco/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/cogneco/ooc-kean","forks_url":"https://api.github.com/repos/cogneco/ooc-kean/forks","keys_url":"https://api.github.com/repos/cogneco/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cogneco/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cogneco/ooc-kean/teams","hooks_url":"https://api.github.com/repos/cogneco/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/cogneco/ooc-kean/events","assignees_url":"https://api.github.com/repos/cogneco/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/cogneco/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/cogneco/ooc-kean/tags","blobs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cogneco/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/cogneco/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/cogneco/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/cogneco/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/cogneco/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/cogneco/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/cogneco/ooc-kean/subscription","commits_url":"https://api.github.com/repos/cogneco/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/cogneco/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/cogneco/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/cogneco/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cogneco/ooc-kean/merges","archive_url":"https://api.github.com/repos/cogneco/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cogneco/ooc-kean/downloads","issues_url":"https://api.github.com/repos/cogneco/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/cogneco/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/cogneco/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/cogneco/ooc-kean/releases{/id}","created_at":"2014-10-15T13:42:17Z","updated_at":"2015-05-08T13:13:16Z","pushed_at":"2016-01-08T08:18:25Z","git_url":"git://github.com/cogneco/ooc-kean.git","ssh_url":"git@github.com:cogneco/ooc-kean.git","clone_url":"https://github.com/cogneco/ooc-kean.git","svn_url":"https://github.com/cogneco/ooc-kean","homepage":"","size":29898,"stargazers_count":3,"watchers_count":3,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":65,"forks":18,"open_issues":65,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1158"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/1158"},"issue":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/1158"},"comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/cogneco/ooc-kean/statuses/e24fe2c903881132d830000f64112fa46318582f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"marcusnaslund","id":14308896,"avatar_url":"https://avatars.githubusercontent.com/u/14308896?v=3","gravatar_id":"","url":"https://api.github.com/users/marcusnaslund","html_url":"https://github.com/marcusnaslund","followers_url":"https://api.github.com/users/marcusnaslund/followers","following_url":"https://api.github.com/users/marcusnaslund/following{/other_user}","gists_url":"https://api.github.com/users/marcusnaslund/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusnaslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusnaslund/subscriptions","organizations_url":"https://api.github.com/users/marcusnaslund/orgs","repos_url":"https://api.github.com/users/marcusnaslund/repos","events_url":"https://api.github.com/users/marcusnaslund/events{/privacy}","received_events_url":"https://api.github.com/users/marcusnaslund/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":1,"deletions":2,"changed_files":1}}