{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/9403","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/9403/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/9403/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/9403/events","html_url":"https://github.com/dotnet/corefx/pull/9403","id":160091113,"number":9403,"title":"Add instructions for targeting .NET Core with MSBuild projects","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/3%20-%20Ready%20For%20Review","name":"3 - Ready For Review","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-14T03:40:17Z","updated_at":"2016-06-14T06:34:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/9403","html_url":"https://github.com/dotnet/corefx/pull/9403","diff_url":"https://github.com/dotnet/corefx/pull/9403.diff","patch_url":"https://github.com/dotnet/corefx/pull/9403.patch"},"body":"This updates our [outdated instructions](http://aka.ms/port2core) on how to target .NET Core with MSBuild projects.  As described in the instructions, most people today should just use project.json, but these instructions should be useful for people who are porting existing projects that use MSBuild or who have customized their build process in ways that project.json doesn't support well.\r\n\r\n@bleroy @sayedihashimi @weshaggard @ericstj @mellinoe @davkean\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/225791873","html_url":"https://github.com/dotnet/corefx/pull/9403#issuecomment-225791873","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/9403","id":225791873,"user":{"login":"mjsabby","id":1930559,"avatar_url":"https://avatars.githubusercontent.com/u/1930559?v=3","gravatar_id":"","url":"https://api.github.com/users/mjsabby","html_url":"https://github.com/mjsabby","followers_url":"https://api.github.com/users/mjsabby/followers","following_url":"https://api.github.com/users/mjsabby/following{/other_user}","gists_url":"https://api.github.com/users/mjsabby/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsabby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsabby/subscriptions","organizations_url":"https://api.github.com/users/mjsabby/orgs","repos_url":"https://api.github.com/users/mjsabby/repos","events_url":"https://api.github.com/users/mjsabby/events{/privacy}","received_events_url":"https://api.github.com/users/mjsabby/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T06:34:24Z","updated_at":"2016-06-14T06:34:24Z","body":"👍 -- this is almost exactly Bing's setup, so I think this will truly be beneficial to lots of existing customers.\r\n\r\nFew thoughts:\r\n\r\nIn creating a .net core console application, you're referring to Git repositories, can't we just put @mellinoe's props and targets in a NuGet package and have the user also specify that in addition to all the other stuff you're asking them to put in project.json?\r\n\r\nSecondly, the coretemplate repo has the same corefx GetDirectoryNameOfFileAbove. I don't think most people do that, I think they'd understand better if you just said include this 1 props file and 1 targets file and things will light up. The dirs.targets and dirs.props requires extra thought on the developer which really isn't needed.\r\n\r\nI really like this doc, primarily because it exposes the guts of how it all works, and the targets and props from NuGet I think would make it even easier to onboard.\r\n\r\nFinally, will these instructions work on MSBuild XPlat? The portable Csharp targets are there right? If so, it'd be nice to add a note and link to that repo, and let's also call out the target file imports are case-sensitive file paths."}}
{"actor":{"display_login":"mjsabby"}}