{"action":"created","issue":{"url":"https://api.github.com/repos/livecode/livecode/issues/3996","repository_url":"https://api.github.com/repos/livecode/livecode","labels_url":"https://api.github.com/repos/livecode/livecode/issues/3996/labels{/name}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/3996/comments","events_url":"https://api.github.com/repos/livecode/livecode/issues/3996/events","html_url":"https://github.com/livecode/livecode/pull/3996","id":153693155,"number":3996,"title":"Brush, spray, and eraser brushes were not initialized properly","user":{"login":"mwieder","id":1829071,"avatar_url":"https://avatars.githubusercontent.com/u/1829071?v=3","gravatar_id":"","url":"https://api.github.com/users/mwieder","html_url":"https://github.com/mwieder","followers_url":"https://api.github.com/users/mwieder/followers","following_url":"https://api.github.com/users/mwieder/following{/other_user}","gists_url":"https://api.github.com/users/mwieder/gists{/gist_id}","starred_url":"https://api.github.com/users/mwieder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwieder/subscriptions","organizations_url":"https://api.github.com/users/mwieder/orgs","repos_url":"https://api.github.com/users/mwieder/repos","events_url":"https://api.github.com/users/mwieder/events{/privacy}","received_events_url":"https://api.github.com/users/mwieder/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/livecode/livecode/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/livecode/livecode/labels/need-release-notes","name":"need-release-notes","color":"fad8c7"},{"url":"https://api.github.com/repos/livecode/livecode/labels/need-tests","name":"need-tests","color":"fad8c7"},{"url":"https://api.github.com/repos/livecode/livecode/labels/WIP","name":"WIP","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2016-05-09T02:32:12Z","updated_at":"2016-05-22T23:04:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/3996","html_url":"https://github.com/livecode/livecode/pull/3996","diff_url":"https://github.com/livecode/livecode/pull/3996.diff","patch_url":"https://github.com/livecode/livecode/pull/3996.patch"},"body":"The tools palette in LC8 attempts to assign some very large numbers (no doubt converted from negatives) to the spray, brush, and eraser properties, and these numbers do not correspond to valid images. That causes an error which is not normally displayed to the users, since it happens in a system stack. This patch fixes some suspicious-looking math in the MCInterfaceSetBrush function and also vectors setting the brush values in MCGraphicsExecResetPaint through MCInterfaceSetBrush so that the values get validated on the way in.\r\n\r\nFor extra credit, I fixed the default value of the spray brush, which was getting set to 31 instead of the documented value of 34. Something else must be fixing the value later on, because retrieving the value shows 34 anyway.\r\n\r\nThis fixes http://quality.livecode.com/show_bug.cgi?id=17553. It's working locally for me, so I'm opening this up for discussion."},"comment":{"url":"https://api.github.com/repos/livecode/livecode/issues/comments/220862131","html_url":"https://github.com/livecode/livecode/pull/3996#issuecomment-220862131","issue_url":"https://api.github.com/repos/livecode/livecode/issues/3996","id":220862131,"user":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"created_at":"2016-05-22T23:04:16Z","updated_at":"2016-05-22T23:04:16Z","body":"Oh and I'm also going to suggest we should be testing the initial defaults at the start of the test."}}
{"actor":{"display_login":"montegoulding"}}