{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/91200190","pull_request_review_id":11710164,"id":91200190,"diff_hunk":"@@ -0,0 +1,65 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.api.r\n+\n+import java.util.concurrent.atomic.AtomicInteger\n+import java.util.concurrent.ConcurrentHashMap\n+\n+/** JVM object ID wrapper */\n+private[r] case class JVMObjectId(id: String)\n+\n+/**\n+ * Counter that tracks JVM objects returned to R.\n+ * This is useful for referencing these objects in RPC calls.\n+ */\n+private[r] class JVMObjectTracker {\n+\n+  private[this] val objMap = new ConcurrentHashMap[JVMObjectId, Object]()\n+  private[this] val objCounter = new AtomicInteger()\n+\n+  /**\n+   * Returns the JVM object associated with the input key.\n+   * Returns null if the key does not exist or has been removed.\n+   */\n+  @throws[NullPointerException](\"if key is null\")\n+  final def get(id: JVMObjectId): Object = objMap.get(id)","path":"core/src/main/scala/org/apache/spark/api/r/JVMObjectTracker.scala","position":40,"original_position":40,"commit_id":"707613e8a2d5f3c3c608ba364662bee2000f9e7f","original_commit_id":"707613e8a2d5f3c3c608ba364662bee2000f9e7f","user":{"login":"felixcheung","id":8969467,"avatar_url":"https://avatars.githubusercontent.com/u/8969467?v=3","gravatar_id":"","url":"https://api.github.com/users/felixcheung","html_url":"https://github.com/felixcheung","followers_url":"https://api.github.com/users/felixcheung/followers","following_url":"https://api.github.com/users/felixcheung/following{/other_user}","gists_url":"https://api.github.com/users/felixcheung/gists{/gist_id}","starred_url":"https://api.github.com/users/felixcheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixcheung/subscriptions","organizations_url":"https://api.github.com/users/felixcheung/orgs","repos_url":"https://api.github.com/users/felixcheung/repos","events_url":"https://api.github.com/users/felixcheung/events{/privacy}","received_events_url":"https://api.github.com/users/felixcheung/received_events","type":"User","site_admin":false},"body":"I'd agree completely, but generally the R-friendly handling would need to be done on the R side.\r\nRelated JIRA:\r\nhttps://issues.apache.org/jira/browse/SPARK-17838\r\nhttps://issues.apache.org/jira/browse/SPARK-18040\r\n","created_at":"2016-12-06T23:54:46Z","updated_at":"2016-12-06T23:54:46Z","html_url":"https://github.com/apache/spark/pull/16154#discussion_r91200190","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/16154","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/91200190"},"html":{"href":"https://github.com/apache/spark/pull/16154#discussion_r91200190"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/16154"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16154","id":96606403,"html_url":"https://github.com/apache/spark/pull/16154","diff_url":"https://github.com/apache/spark/pull/16154.diff","patch_url":"https://github.com/apache/spark/pull/16154.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/16154","number":16154,"state":"open","locked":false,"title":"[SPARK-17822] [R] Make JVMObjectTracker a member variable of RBackend","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\n* This PR changes `JVMObjectTracker` from `object` to `class` and let its instance associated with each RBackend. So we can manage the lifecycle of JVM objects when there are multiple `RBackend` sessions. `RBackend.close` will clear the object tracker explicitly.\r\n* I assume that `SQLUtils` and `RRunner` do not need to track JVM instances, which could be wrong.\r\n* Small refactor of `SerDe.sqlSerDe` to increase readability.\r\n\r\n## How was this patch tested?\r\n\r\n* Added unit tests for `JVMObjectTracker`.\r\n* Wait for Jenkins to run full tests.","created_at":"2016-12-05T20:49:34Z","updated_at":"2016-12-06T23:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a8724c47dbf811bfb546a33c5fdab3ba53014db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/16154/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/16154/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/16154/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/707613e8a2d5f3c3c608ba364662bee2000f9e7f","head":{"label":"mengxr:SPARK-17822","ref":"SPARK-17822","sha":"707613e8a2d5f3c3c608ba364662bee2000f9e7f","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"repo":{"id":17278743,"name":"spark","full_name":"mengxr/spark","owner":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mengxr/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/mengxr/spark","forks_url":"https://api.github.com/repos/mengxr/spark/forks","keys_url":"https://api.github.com/repos/mengxr/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mengxr/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mengxr/spark/teams","hooks_url":"https://api.github.com/repos/mengxr/spark/hooks","issue_events_url":"https://api.github.com/repos/mengxr/spark/issues/events{/number}","events_url":"https://api.github.com/repos/mengxr/spark/events","assignees_url":"https://api.github.com/repos/mengxr/spark/assignees{/user}","branches_url":"https://api.github.com/repos/mengxr/spark/branches{/branch}","tags_url":"https://api.github.com/repos/mengxr/spark/tags","blobs_url":"https://api.github.com/repos/mengxr/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mengxr/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mengxr/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/mengxr/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mengxr/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/mengxr/spark/languages","stargazers_url":"https://api.github.com/repos/mengxr/spark/stargazers","contributors_url":"https://api.github.com/repos/mengxr/spark/contributors","subscribers_url":"https://api.github.com/repos/mengxr/spark/subscribers","subscription_url":"https://api.github.com/repos/mengxr/spark/subscription","commits_url":"https://api.github.com/repos/mengxr/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/mengxr/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/mengxr/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/mengxr/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/mengxr/spark/contents/{+path}","compare_url":"https://api.github.com/repos/mengxr/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mengxr/spark/merges","archive_url":"https://api.github.com/repos/mengxr/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mengxr/spark/downloads","issues_url":"https://api.github.com/repos/mengxr/spark/issues{/number}","pulls_url":"https://api.github.com/repos/mengxr/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/mengxr/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/mengxr/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mengxr/spark/labels{/name}","releases_url":"https://api.github.com/repos/mengxr/spark/releases{/id}","deployments_url":"https://api.github.com/repos/mengxr/spark/deployments","created_at":"2014-02-28T07:27:59Z","updated_at":"2015-07-09T23:08:59Z","pushed_at":"2016-12-05T20:40:36Z","git_url":"git://github.com/mengxr/spark.git","ssh_url":"git@github.com:mengxr/spark.git","clone_url":"https://github.com/mengxr/spark.git","svn_url":"https://github.com/mengxr/spark","homepage":null,"size":245378,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"01a7d33d0851d82fd1bb477a58d9925fe8d727d8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-12-06T21:28:29Z","pushed_at":"2016-12-06T23:42:49Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":620109,"stargazers_count":10986,"watchers_count":10986,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10259,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":457,"forks":10259,"open_issues":457,"watchers":10986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/16154"},"html":{"href":"https://github.com/apache/spark/pull/16154"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/16154"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/16154/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/16154/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/16154/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/707613e8a2d5f3c3c608ba364662bee2000f9e7f"}}}}
{"actor":{"display_login":"felixcheung"}}