{"action":"created","issue":{"url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/28","repository_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker","labels_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/28/comments","events_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/28/events","html_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/28","id":190085167,"number":28,"title":"Remove \"make up\" target.","user":{"login":"jtyberg","id":359081,"avatar_url":"https://avatars.githubusercontent.com/u/359081?v=3","gravatar_id":"","url":"https://api.github.com/users/jtyberg","html_url":"https://github.com/jtyberg","followers_url":"https://api.github.com/users/jtyberg/followers","following_url":"https://api.github.com/users/jtyberg/following{/other_user}","gists_url":"https://api.github.com/users/jtyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jtyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtyberg/subscriptions","organizations_url":"https://api.github.com/users/jtyberg/orgs","repos_url":"https://api.github.com/users/jtyberg/repos","events_url":"https://api.github.com/users/jtyberg/events{/privacy}","received_events_url":"https://api.github.com/users/jtyberg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-17T15:52:40Z","updated_at":"2016-11-18T03:00:48Z","closed_at":"2016-11-18T03:00:16Z","pull_request":{"url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/pulls/28","html_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/28","diff_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/28.diff","patch_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/28.patch"},"body":"Using `make up` adds another level of indirection to bringing up JupyterHub, and in this case, it doesn't do the right thing, and may lead to confusion (see #26).  \r\n\r\nSpecifically, `make up` does not export the environment variables in the `.env` file.\r\n\r\nWe _could_ \"fix\" this by doing:\r\n\r\n```\r\ninclude .env\r\nexport\r\n```\r\n\r\nBUT `make` works differently than `docker-compose` in that `make` would honor the file content over the shell environment variables by default.  Users would have to explicitly tell `make` to use the shell variables over the `.env` file by passing the `-e` flag (see [here](https://www.gnu.org/software/make/manual/html_node/Environment.html#Environment)):\r\n\r\n```\r\nmake -e up\r\n```\r\n\r\nWait, wut?\r\n\r\nMy fix for this is to remove `make up` and just run `docker-compose up -d` as it says in the README. (This repo _is_ about using Docker after all)."},"comment":{"url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/comments/261436722","html_url":"https://github.com/jupyterhub/jupyterhub-deploy-docker/pull/28#issuecomment-261436722","issue_url":"https://api.github.com/repos/jupyterhub/jupyterhub-deploy-docker/issues/28","id":261436722,"user":{"login":"parente","id":153745,"avatar_url":"https://avatars.githubusercontent.com/u/153745?v=3","gravatar_id":"","url":"https://api.github.com/users/parente","html_url":"https://github.com/parente","followers_url":"https://api.github.com/users/parente/followers","following_url":"https://api.github.com/users/parente/following{/other_user}","gists_url":"https://api.github.com/users/parente/gists{/gist_id}","starred_url":"https://api.github.com/users/parente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parente/subscriptions","organizations_url":"https://api.github.com/users/parente/orgs","repos_url":"https://api.github.com/users/parente/repos","events_url":"https://api.github.com/users/parente/events{/privacy}","received_events_url":"https://api.github.com/users/parente/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T03:00:48Z","updated_at":"2016-11-18T03:00:48Z","body":"No more make up. Let that natural docker beauty shine through!"}}
{"actor":{"display_login":"parente"}}