{"action":"created","issue":{"url":"https://api.github.com/repos/collectd/collectd/issues/1867","repository_url":"https://api.github.com/repos/collectd/collectd","labels_url":"https://api.github.com/repos/collectd/collectd/issues/1867/labels{/name}","comments_url":"https://api.github.com/repos/collectd/collectd/issues/1867/comments","events_url":"https://api.github.com/repos/collectd/collectd/issues/1867/events","html_url":"https://github.com/collectd/collectd/pull/1867","id":169937078,"number":1867,"title":"Making /proc and /sys path configurable","user":{"login":"mfournier","id":37533,"avatar_url":"https://avatars.githubusercontent.com/u/37533?v=3","gravatar_id":"","url":"https://api.github.com/users/mfournier","html_url":"https://github.com/mfournier","followers_url":"https://api.github.com/users/mfournier/followers","following_url":"https://api.github.com/users/mfournier/following{/other_user}","gists_url":"https://api.github.com/users/mfournier/gists{/gist_id}","starred_url":"https://api.github.com/users/mfournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfournier/subscriptions","organizations_url":"https://api.github.com/users/mfournier/orgs","repos_url":"https://api.github.com/users/mfournier/repos","events_url":"https://api.github.com/users/mfournier/events{/privacy}","received_events_url":"https://api.github.com/users/mfournier/received_events","type":"User","site_admin":false},"labels":[{"id":13824791,"url":"https://api.github.com/repos/collectd/collectd/labels/Feature","name":"Feature","color":"5319e7","default":false},{"id":441006047,"url":"https://api.github.com/repos/collectd/collectd/labels/Pending%20contributor%20action","name":"Pending contributor action","color":"d0d0d0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-08T14:29:06Z","updated_at":"2016-11-16T09:17:29Z","closed_at":"2016-11-16T09:17:29Z","pull_request":{"url":"https://api.github.com/repos/collectd/collectd/pulls/1867","html_url":"https://github.com/collectd/collectd/pull/1867","diff_url":"https://github.com/collectd/collectd/pull/1867.diff","patch_url":"https://github.com/collectd/collectd/pull/1867.patch"},"body":"This is a work in progress I wanted to submit for review before finishing it up. The use-case is detailed in #1169.\n\nBasically, set `PseudoFSPrefix \"/foo\"` in the configuration file, and the plugins will read from `/foo/proc/...` and `/foo/sys/...`.\n\nAs this touches a ton of plugins, I tried to make the patch as un-invasive as possible. My main concern now is that the string concatenation gets executed at each iteration, rather than once at plugin initialization time. But I'm not sure how to do this better without global variables or altering a lot of function prototypes. This also adds a lot of mostly duplicate code, but I'm not sure how to isolate that in a function (still not very confortable with passing strings around in C...)\n\nThere are a few more plugins that need to be converted, and the doc bits are missing, so this is definetely not ready to be merged.\n"},"comment":{"url":"https://api.github.com/repos/collectd/collectd/issues/comments/260894074","html_url":"https://github.com/collectd/collectd/pull/1867#issuecomment-260894074","issue_url":"https://api.github.com/repos/collectd/collectd/issues/1867","id":260894074,"user":{"login":"mfournier","id":37533,"avatar_url":"https://avatars.githubusercontent.com/u/37533?v=3","gravatar_id":"","url":"https://api.github.com/users/mfournier","html_url":"https://github.com/mfournier","followers_url":"https://api.github.com/users/mfournier/followers","following_url":"https://api.github.com/users/mfournier/following{/other_user}","gists_url":"https://api.github.com/users/mfournier/gists{/gist_id}","starred_url":"https://api.github.com/users/mfournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfournier/subscriptions","organizations_url":"https://api.github.com/users/mfournier/orgs","repos_url":"https://api.github.com/users/mfournier/repos","events_url":"https://api.github.com/users/mfournier/events{/privacy}","received_events_url":"https://api.github.com/users/mfournier/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T09:17:29Z","updated_at":"2016-11-16T09:17:29Z","body":"Dropping this in favor of in #2041.\r\n\r\nThis approach is a bit messy and is bound to be a maintenance burden."}}
{"actor":{"display_login":"mfournier"}}