{"action":"opened","number":117,"pull_request":{"url":"https://api.github.com/repos/thelounge/lounge/pulls/117","id":60975163,"html_url":"https://github.com/thelounge/lounge/pull/117","diff_url":"https://github.com/thelounge/lounge/pull/117.diff","patch_url":"https://github.com/thelounge/lounge/pull/117.patch","issue_url":"https://api.github.com/repos/thelounge/lounge/issues/117","number":117,"state":"open","locked":false,"title":"Remove attempts to set file modes","user":{"login":"maxpoulin64","id":5481612,"avatar_url":"https://avatars.githubusercontent.com/u/5481612?v=3","gravatar_id":"","url":"https://api.github.com/users/maxpoulin64","html_url":"https://github.com/maxpoulin64","followers_url":"https://api.github.com/users/maxpoulin64/followers","following_url":"https://api.github.com/users/maxpoulin64/following{/other_user}","gists_url":"https://api.github.com/users/maxpoulin64/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpoulin64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpoulin64/subscriptions","organizations_url":"https://api.github.com/users/maxpoulin64/orgs","repos_url":"https://api.github.com/users/maxpoulin64/repos","events_url":"https://api.github.com/users/maxpoulin64/events{/privacy}","received_events_url":"https://api.github.com/users/maxpoulin64/received_events","type":"User","site_admin":false},"body":"After some testing and manually trying to set sane file modes, it turns out the umask still applies. So it seems the logical way to handle this is to actually rely on the OS umask to set proper permissions.\r\n\r\nI have set mine to 0007, which results in the following structure:\r\n```\r\ndrwxrwx--- 3 thelounge thelounge 4096 27 fév 21:34 ./\r\n-rw-rw---- 1 thelounge thelounge 4040 27 fév 21:34 config.js\r\ndrwxrwx--- 2 thelounge thelounge 4096 27 fév 21:34 users/\r\n-rw-rw---- 1 thelounge thelounge  133 27 fév 21:34 users/Max-P.json\r\n```\r\n\r\nThis seems to be the best permissions for me, as the files are restricted to The Lounge, but the user can still allow a web server or other utilities to change the files by adding them to the lounge group.","created_at":"2016-02-28T02:39:59Z","updated_at":"2016-02-28T02:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thelounge/lounge/pulls/117/commits","review_comments_url":"https://api.github.com/repos/thelounge/lounge/pulls/117/comments","review_comment_url":"https://api.github.com/repos/thelounge/lounge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thelounge/lounge/issues/117/comments","statuses_url":"https://api.github.com/repos/thelounge/lounge/statuses/b70c0a98feb193f54361673d050b34522c35640a","head":{"label":"maxpoulin64:fix-user-filemode","ref":"fix-user-filemode","sha":"b70c0a98feb193f54361673d050b34522c35640a","user":{"login":"maxpoulin64","id":5481612,"avatar_url":"https://avatars.githubusercontent.com/u/5481612?v=3","gravatar_id":"","url":"https://api.github.com/users/maxpoulin64","html_url":"https://github.com/maxpoulin64","followers_url":"https://api.github.com/users/maxpoulin64/followers","following_url":"https://api.github.com/users/maxpoulin64/following{/other_user}","gists_url":"https://api.github.com/users/maxpoulin64/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpoulin64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpoulin64/subscriptions","organizations_url":"https://api.github.com/users/maxpoulin64/orgs","repos_url":"https://api.github.com/users/maxpoulin64/repos","events_url":"https://api.github.com/users/maxpoulin64/events{/privacy}","received_events_url":"https://api.github.com/users/maxpoulin64/received_events","type":"User","site_admin":false},"repo":{"id":51623838,"name":"lounge","full_name":"maxpoulin64/lounge","owner":{"login":"maxpoulin64","id":5481612,"avatar_url":"https://avatars.githubusercontent.com/u/5481612?v=3","gravatar_id":"","url":"https://api.github.com/users/maxpoulin64","html_url":"https://github.com/maxpoulin64","followers_url":"https://api.github.com/users/maxpoulin64/followers","following_url":"https://api.github.com/users/maxpoulin64/following{/other_user}","gists_url":"https://api.github.com/users/maxpoulin64/gists{/gist_id}","starred_url":"https://api.github.com/users/maxpoulin64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxpoulin64/subscriptions","organizations_url":"https://api.github.com/users/maxpoulin64/orgs","repos_url":"https://api.github.com/users/maxpoulin64/repos","events_url":"https://api.github.com/users/maxpoulin64/events{/privacy}","received_events_url":"https://api.github.com/users/maxpoulin64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxpoulin64/lounge","description":"The Lounge — Self-hosted web IRC client","fork":true,"url":"https://api.github.com/repos/maxpoulin64/lounge","forks_url":"https://api.github.com/repos/maxpoulin64/lounge/forks","keys_url":"https://api.github.com/repos/maxpoulin64/lounge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxpoulin64/lounge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxpoulin64/lounge/teams","hooks_url":"https://api.github.com/repos/maxpoulin64/lounge/hooks","issue_events_url":"https://api.github.com/repos/maxpoulin64/lounge/issues/events{/number}","events_url":"https://api.github.com/repos/maxpoulin64/lounge/events","assignees_url":"https://api.github.com/repos/maxpoulin64/lounge/assignees{/user}","branches_url":"https://api.github.com/repos/maxpoulin64/lounge/branches{/branch}","tags_url":"https://api.github.com/repos/maxpoulin64/lounge/tags","blobs_url":"https://api.github.com/repos/maxpoulin64/lounge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxpoulin64/lounge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxpoulin64/lounge/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxpoulin64/lounge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxpoulin64/lounge/statuses/{sha}","languages_url":"https://api.github.com/repos/maxpoulin64/lounge/languages","stargazers_url":"https://api.github.com/repos/maxpoulin64/lounge/stargazers","contributors_url":"https://api.github.com/repos/maxpoulin64/lounge/contributors","subscribers_url":"https://api.github.com/repos/maxpoulin64/lounge/subscribers","subscription_url":"https://api.github.com/repos/maxpoulin64/lounge/subscription","commits_url":"https://api.github.com/repos/maxpoulin64/lounge/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxpoulin64/lounge/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxpoulin64/lounge/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxpoulin64/lounge/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxpoulin64/lounge/contents/{+path}","compare_url":"https://api.github.com/repos/maxpoulin64/lounge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxpoulin64/lounge/merges","archive_url":"https://api.github.com/repos/maxpoulin64/lounge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxpoulin64/lounge/downloads","issues_url":"https://api.github.com/repos/maxpoulin64/lounge/issues{/number}","pulls_url":"https://api.github.com/repos/maxpoulin64/lounge/pulls{/number}","milestones_url":"https://api.github.com/repos/maxpoulin64/lounge/milestones{/number}","notifications_url":"https://api.github.com/repos/maxpoulin64/lounge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxpoulin64/lounge/labels{/name}","releases_url":"https://api.github.com/repos/maxpoulin64/lounge/releases{/id}","deployments_url":"https://api.github.com/repos/maxpoulin64/lounge/deployments","created_at":"2016-02-12T23:46:39Z","updated_at":"2016-02-12T23:46:40Z","pushed_at":"2016-02-28T02:36:16Z","git_url":"git://github.com/maxpoulin64/lounge.git","ssh_url":"git@github.com:maxpoulin64/lounge.git","clone_url":"https://github.com/maxpoulin64/lounge.git","svn_url":"https://github.com/maxpoulin64/lounge","homepage":"https://thelounge.github.io","size":4777,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thelounge:master","ref":"master","sha":"1d8667ed4bab6406ac3a1b7f3259ab8e4f9334fb","user":{"login":"thelounge","id":14336958,"avatar_url":"https://avatars.githubusercontent.com/u/14336958?v=3","gravatar_id":"","url":"https://api.github.com/users/thelounge","html_url":"https://github.com/thelounge","followers_url":"https://api.github.com/users/thelounge/followers","following_url":"https://api.github.com/users/thelounge/following{/other_user}","gists_url":"https://api.github.com/users/thelounge/gists{/gist_id}","starred_url":"https://api.github.com/users/thelounge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelounge/subscriptions","organizations_url":"https://api.github.com/users/thelounge/orgs","repos_url":"https://api.github.com/users/thelounge/repos","events_url":"https://api.github.com/users/thelounge/events{/privacy}","received_events_url":"https://api.github.com/users/thelounge/received_events","type":"Organization","site_admin":false},"repo":{"id":51344082,"name":"lounge","full_name":"thelounge/lounge","owner":{"login":"thelounge","id":14336958,"avatar_url":"https://avatars.githubusercontent.com/u/14336958?v=3","gravatar_id":"","url":"https://api.github.com/users/thelounge","html_url":"https://github.com/thelounge","followers_url":"https://api.github.com/users/thelounge/followers","following_url":"https://api.github.com/users/thelounge/following{/other_user}","gists_url":"https://api.github.com/users/thelounge/gists{/gist_id}","starred_url":"https://api.github.com/users/thelounge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thelounge/subscriptions","organizations_url":"https://api.github.com/users/thelounge/orgs","repos_url":"https://api.github.com/users/thelounge/repos","events_url":"https://api.github.com/users/thelounge/events{/privacy}","received_events_url":"https://api.github.com/users/thelounge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thelounge/lounge","description":"The Lounge — Self-hosted web IRC client","fork":false,"url":"https://api.github.com/repos/thelounge/lounge","forks_url":"https://api.github.com/repos/thelounge/lounge/forks","keys_url":"https://api.github.com/repos/thelounge/lounge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thelounge/lounge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thelounge/lounge/teams","hooks_url":"https://api.github.com/repos/thelounge/lounge/hooks","issue_events_url":"https://api.github.com/repos/thelounge/lounge/issues/events{/number}","events_url":"https://api.github.com/repos/thelounge/lounge/events","assignees_url":"https://api.github.com/repos/thelounge/lounge/assignees{/user}","branches_url":"https://api.github.com/repos/thelounge/lounge/branches{/branch}","tags_url":"https://api.github.com/repos/thelounge/lounge/tags","blobs_url":"https://api.github.com/repos/thelounge/lounge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thelounge/lounge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thelounge/lounge/git/refs{/sha}","trees_url":"https://api.github.com/repos/thelounge/lounge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thelounge/lounge/statuses/{sha}","languages_url":"https://api.github.com/repos/thelounge/lounge/languages","stargazers_url":"https://api.github.com/repos/thelounge/lounge/stargazers","contributors_url":"https://api.github.com/repos/thelounge/lounge/contributors","subscribers_url":"https://api.github.com/repos/thelounge/lounge/subscribers","subscription_url":"https://api.github.com/repos/thelounge/lounge/subscription","commits_url":"https://api.github.com/repos/thelounge/lounge/commits{/sha}","git_commits_url":"https://api.github.com/repos/thelounge/lounge/git/commits{/sha}","comments_url":"https://api.github.com/repos/thelounge/lounge/comments{/number}","issue_comment_url":"https://api.github.com/repos/thelounge/lounge/issues/comments{/number}","contents_url":"https://api.github.com/repos/thelounge/lounge/contents/{+path}","compare_url":"https://api.github.com/repos/thelounge/lounge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thelounge/lounge/merges","archive_url":"https://api.github.com/repos/thelounge/lounge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thelounge/lounge/downloads","issues_url":"https://api.github.com/repos/thelounge/lounge/issues{/number}","pulls_url":"https://api.github.com/repos/thelounge/lounge/pulls{/number}","milestones_url":"https://api.github.com/repos/thelounge/lounge/milestones{/number}","notifications_url":"https://api.github.com/repos/thelounge/lounge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thelounge/lounge/labels{/name}","releases_url":"https://api.github.com/repos/thelounge/lounge/releases{/id}","deployments_url":"https://api.github.com/repos/thelounge/lounge/deployments","created_at":"2016-02-09T03:16:03Z","updated_at":"2016-02-25T16:30:56Z","pushed_at":"2016-02-28T02:39:59Z","git_url":"git://github.com/thelounge/lounge.git","ssh_url":"git@github.com:thelounge/lounge.git","clone_url":"https://github.com/thelounge/lounge.git","svn_url":"https://github.com/thelounge/lounge","homepage":"https://thelounge.github.io","size":5818,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":62,"forks":17,"open_issues":62,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thelounge/lounge/pulls/117"},"html":{"href":"https://github.com/thelounge/lounge/pull/117"},"issue":{"href":"https://api.github.com/repos/thelounge/lounge/issues/117"},"comments":{"href":"https://api.github.com/repos/thelounge/lounge/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/thelounge/lounge/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/thelounge/lounge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thelounge/lounge/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/thelounge/lounge/statuses/b70c0a98feb193f54361673d050b34522c35640a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":3,"changed_files":1}}