{"action":"created","comment":{"url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/comments/84268367","pull_request_review_id":5055563,"id":84268367,"diff_hunk":"@@ -0,0 +1,26 @@\n+import re\n+import shutil\n+import tarfile\n+\n+\n+def get_system_id(self):\n+    \"\"\" Checking system id from archive \"\"\"\n+    tar = tarfile.open(self.archive_location, 'r')\n+    tar.extractall()\n+    self.machine_id = tar.extractfile(self.machine_id_path)","path":"insights/archive_functions.py","position":10,"original_position":10,"commit_id":"b9eeafc4c944e844ec5e737dd34e9c1758e9448f","original_commit_id":"b9eeafc4c944e844ec5e737dd34e9c1758e9448f","user":{"login":"anarang","id":2485885,"avatar_url":"https://avatars.githubusercontent.com/u/2485885?v=3","gravatar_id":"","url":"https://api.github.com/users/anarang","html_url":"https://github.com/anarang","followers_url":"https://api.github.com/users/anarang/followers","following_url":"https://api.github.com/users/anarang/following{/other_user}","gists_url":"https://api.github.com/users/anarang/gists{/gist_id}","starred_url":"https://api.github.com/users/anarang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anarang/subscriptions","organizations_url":"https://api.github.com/users/anarang/orgs","repos_url":"https://api.github.com/users/anarang/repos","events_url":"https://api.github.com/users/anarang/events{/privacy}","received_events_url":"https://api.github.com/users/anarang/received_events","type":"User","site_admin":false},"body":"@kanchan04katare try to pass the parameters to the function like this:\r\ndef get_system_id(machine_id, archive_location)\r\nWhile making a call as well to the above defined functions, respective parameters should be passed around. \r\nRefer -> https://github.com/redhataccess/rhi-pool/blob/master/insights/subset_functions.py#L3 for more clarity.","created_at":"2016-10-20T12:12:40Z","updated_at":"2016-10-20T12:12:40Z","html_url":"https://github.com/redhataccess/rhi-pool/pull/12#discussion_r84268367","pull_request_url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/comments/84268367"},"html":{"href":"https://github.com/redhataccess/rhi-pool/pull/12#discussion_r84268367"},"pull_request":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12","id":85219572,"html_url":"https://github.com/redhataccess/rhi-pool/pull/12","diff_url":"https://github.com/redhataccess/rhi-pool/pull/12.diff","patch_url":"https://github.com/redhataccess/rhi-pool/pull/12.patch","issue_url":"https://api.github.com/repos/redhataccess/rhi-pool/issues/12","number":12,"state":"open","locked":false,"title":"Added tests for upload api endpoints","user":{"login":"kanchan04katare","id":7577468,"avatar_url":"https://avatars.githubusercontent.com/u/7577468?v=3","gravatar_id":"","url":"https://api.github.com/users/kanchan04katare","html_url":"https://github.com/kanchan04katare","followers_url":"https://api.github.com/users/kanchan04katare/followers","following_url":"https://api.github.com/users/kanchan04katare/following{/other_user}","gists_url":"https://api.github.com/users/kanchan04katare/gists{/gist_id}","starred_url":"https://api.github.com/users/kanchan04katare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanchan04katare/subscriptions","organizations_url":"https://api.github.com/users/kanchan04katare/orgs","repos_url":"https://api.github.com/users/kanchan04katare/repos","events_url":"https://api.github.com/users/kanchan04katare/events{/privacy}","received_events_url":"https://api.github.com/users/kanchan04katare/received_events","type":"User","site_admin":false},"body":"Testing upload api endpoints.","created_at":"2016-09-14T12:36:48Z","updated_at":"2016-10-20T12:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4f998a57b1e8068f690b4f4da6917c39a62bf17","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12/commits","review_comments_url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12/comments","review_comment_url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhataccess/rhi-pool/issues/12/comments","statuses_url":"https://api.github.com/repos/redhataccess/rhi-pool/statuses/b9eeafc4c944e844ec5e737dd34e9c1758e9448f","head":{"label":"kanchan04katare:ui","ref":"ui","sha":"b9eeafc4c944e844ec5e737dd34e9c1758e9448f","user":{"login":"kanchan04katare","id":7577468,"avatar_url":"https://avatars.githubusercontent.com/u/7577468?v=3","gravatar_id":"","url":"https://api.github.com/users/kanchan04katare","html_url":"https://github.com/kanchan04katare","followers_url":"https://api.github.com/users/kanchan04katare/followers","following_url":"https://api.github.com/users/kanchan04katare/following{/other_user}","gists_url":"https://api.github.com/users/kanchan04katare/gists{/gist_id}","starred_url":"https://api.github.com/users/kanchan04katare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanchan04katare/subscriptions","organizations_url":"https://api.github.com/users/kanchan04katare/orgs","repos_url":"https://api.github.com/users/kanchan04katare/repos","events_url":"https://api.github.com/users/kanchan04katare/events{/privacy}","received_events_url":"https://api.github.com/users/kanchan04katare/received_events","type":"User","site_admin":false},"repo":{"id":54887341,"name":"rhi-pool","full_name":"kanchan04katare/rhi-pool","owner":{"login":"kanchan04katare","id":7577468,"avatar_url":"https://avatars.githubusercontent.com/u/7577468?v=3","gravatar_id":"","url":"https://api.github.com/users/kanchan04katare","html_url":"https://github.com/kanchan04katare","followers_url":"https://api.github.com/users/kanchan04katare/followers","following_url":"https://api.github.com/users/kanchan04katare/following{/other_user}","gists_url":"https://api.github.com/users/kanchan04katare/gists{/gist_id}","starred_url":"https://api.github.com/users/kanchan04katare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanchan04katare/subscriptions","organizations_url":"https://api.github.com/users/kanchan04katare/orgs","repos_url":"https://api.github.com/users/kanchan04katare/repos","events_url":"https://api.github.com/users/kanchan04katare/events{/privacy}","received_events_url":"https://api.github.com/users/kanchan04katare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanchan04katare/rhi-pool","description":"Tests for different components in Red Hat Insights","fork":true,"url":"https://api.github.com/repos/kanchan04katare/rhi-pool","forks_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/forks","keys_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/teams","hooks_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/hooks","issue_events_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/issues/events{/number}","events_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/events","assignees_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/assignees{/user}","branches_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/branches{/branch}","tags_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/tags","blobs_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/statuses/{sha}","languages_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/languages","stargazers_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/stargazers","contributors_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/contributors","subscribers_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/subscribers","subscription_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/subscription","commits_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/contents/{+path}","compare_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/merges","archive_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/downloads","issues_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/issues{/number}","pulls_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/pulls{/number}","milestones_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/milestones{/number}","notifications_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/labels{/name}","releases_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/releases{/id}","deployments_url":"https://api.github.com/repos/kanchan04katare/rhi-pool/deployments","created_at":"2016-03-28T11:19:22Z","updated_at":"2016-04-07T11:00:44Z","pushed_at":"2016-10-17T10:06:09Z","git_url":"git://github.com/kanchan04katare/rhi-pool.git","ssh_url":"git@github.com:kanchan04katare/rhi-pool.git","clone_url":"https://github.com/kanchan04katare/rhi-pool.git","svn_url":"https://github.com/kanchan04katare/rhi-pool","homepage":"","size":48,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhataccess:master","ref":"master","sha":"96d40452f8c156a8e9d8a7f97afe625b86685d8b","user":{"login":"redhataccess","id":6578594,"avatar_url":"https://avatars.githubusercontent.com/u/6578594?v=3","gravatar_id":"","url":"https://api.github.com/users/redhataccess","html_url":"https://github.com/redhataccess","followers_url":"https://api.github.com/users/redhataccess/followers","following_url":"https://api.github.com/users/redhataccess/following{/other_user}","gists_url":"https://api.github.com/users/redhataccess/gists{/gist_id}","starred_url":"https://api.github.com/users/redhataccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhataccess/subscriptions","organizations_url":"https://api.github.com/users/redhataccess/orgs","repos_url":"https://api.github.com/users/redhataccess/repos","events_url":"https://api.github.com/users/redhataccess/events{/privacy}","received_events_url":"https://api.github.com/users/redhataccess/received_events","type":"Organization","site_admin":false},"repo":{"id":52271028,"name":"rhi-pool","full_name":"redhataccess/rhi-pool","owner":{"login":"redhataccess","id":6578594,"avatar_url":"https://avatars.githubusercontent.com/u/6578594?v=3","gravatar_id":"","url":"https://api.github.com/users/redhataccess","html_url":"https://github.com/redhataccess","followers_url":"https://api.github.com/users/redhataccess/followers","following_url":"https://api.github.com/users/redhataccess/following{/other_user}","gists_url":"https://api.github.com/users/redhataccess/gists{/gist_id}","starred_url":"https://api.github.com/users/redhataccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhataccess/subscriptions","organizations_url":"https://api.github.com/users/redhataccess/orgs","repos_url":"https://api.github.com/users/redhataccess/repos","events_url":"https://api.github.com/users/redhataccess/events{/privacy}","received_events_url":"https://api.github.com/users/redhataccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhataccess/rhi-pool","description":"Tests for different components in Red Hat Insights","fork":false,"url":"https://api.github.com/repos/redhataccess/rhi-pool","forks_url":"https://api.github.com/repos/redhataccess/rhi-pool/forks","keys_url":"https://api.github.com/repos/redhataccess/rhi-pool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhataccess/rhi-pool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhataccess/rhi-pool/teams","hooks_url":"https://api.github.com/repos/redhataccess/rhi-pool/hooks","issue_events_url":"https://api.github.com/repos/redhataccess/rhi-pool/issues/events{/number}","events_url":"https://api.github.com/repos/redhataccess/rhi-pool/events","assignees_url":"https://api.github.com/repos/redhataccess/rhi-pool/assignees{/user}","branches_url":"https://api.github.com/repos/redhataccess/rhi-pool/branches{/branch}","tags_url":"https://api.github.com/repos/redhataccess/rhi-pool/tags","blobs_url":"https://api.github.com/repos/redhataccess/rhi-pool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhataccess/rhi-pool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhataccess/rhi-pool/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhataccess/rhi-pool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhataccess/rhi-pool/statuses/{sha}","languages_url":"https://api.github.com/repos/redhataccess/rhi-pool/languages","stargazers_url":"https://api.github.com/repos/redhataccess/rhi-pool/stargazers","contributors_url":"https://api.github.com/repos/redhataccess/rhi-pool/contributors","subscribers_url":"https://api.github.com/repos/redhataccess/rhi-pool/subscribers","subscription_url":"https://api.github.com/repos/redhataccess/rhi-pool/subscription","commits_url":"https://api.github.com/repos/redhataccess/rhi-pool/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhataccess/rhi-pool/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhataccess/rhi-pool/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhataccess/rhi-pool/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhataccess/rhi-pool/contents/{+path}","compare_url":"https://api.github.com/repos/redhataccess/rhi-pool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhataccess/rhi-pool/merges","archive_url":"https://api.github.com/repos/redhataccess/rhi-pool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhataccess/rhi-pool/downloads","issues_url":"https://api.github.com/repos/redhataccess/rhi-pool/issues{/number}","pulls_url":"https://api.github.com/repos/redhataccess/rhi-pool/pulls{/number}","milestones_url":"https://api.github.com/repos/redhataccess/rhi-pool/milestones{/number}","notifications_url":"https://api.github.com/repos/redhataccess/rhi-pool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhataccess/rhi-pool/labels{/name}","releases_url":"https://api.github.com/repos/redhataccess/rhi-pool/releases{/id}","deployments_url":"https://api.github.com/repos/redhataccess/rhi-pool/deployments","created_at":"2016-02-22T12:12:23Z","updated_at":"2016-04-13T13:17:55Z","pushed_at":"2016-10-20T08:21:37Z","git_url":"git://github.com/redhataccess/rhi-pool.git","ssh_url":"git@github.com:redhataccess/rhi-pool.git","clone_url":"https://github.com/redhataccess/rhi-pool.git","svn_url":"https://github.com/redhataccess/rhi-pool","homepage":"","size":53,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12"},"html":{"href":"https://github.com/redhataccess/rhi-pool/pull/12"},"issue":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/issues/12"},"comments":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/redhataccess/rhi-pool/statuses/b9eeafc4c944e844ec5e737dd34e9c1758e9448f"}}}}
{"actor":{"display_login":"anarang"}}