{"action":"opened","number":25,"pull_request":{"url":"https://api.github.com/repos/romartin/wirez/pulls/25","id":79709101,"html_url":"https://github.com/romartin/wirez/pull/25","diff_url":"https://github.com/romartin/wirez/pull/25.diff","patch_url":"https://github.com/romartin/wirez/pull/25.patch","issue_url":"https://api.github.com/repos/romartin/wirez/issues/25","number":25,"state":"open","locked":false,"title":"Refactor marshalling of simulation properties to fix unit test errors","user":{"login":"jlindop","id":7510088,"avatar_url":"https://avatars.githubusercontent.com/u/7510088?v=3","gravatar_id":"","url":"https://api.github.com/users/jlindop","html_url":"https://github.com/jlindop","followers_url":"https://api.github.com/users/jlindop/followers","following_url":"https://api.github.com/users/jlindop/following{/other_user}","gists_url":"https://api.github.com/users/jlindop/gists{/gist_id}","starred_url":"https://api.github.com/users/jlindop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlindop/subscriptions","organizations_url":"https://api.github.com/users/jlindop/orgs","repos_url":"https://api.github.com/users/jlindop/repos","events_url":"https://api.github.com/users/jlindop/events{/privacy}","received_events_url":"https://api.github.com/users/jlindop/received_events","type":"User","site_admin":false},"body":"@romartin \r\nThis fixes the unit test errors with the new evaluation.bpmn process.\r\nI think the reason this caused errors is that the previous evaluation process was created when User Tasks had simulation properties in the UI, whereas the new one was created after we removed the simulation properties. As a consequence, the new evaluation.bpmn process contains some empty simulation information.\r\nThe refactoring I've added was done recently by Jozef Marko in jbpm-designer, and it made sense to add it here. It does more checking for null values than the old code, which is why it fixes the unit test errors. Incidentaly, Jozef has done some other factoring of the marshalling classes which I'll also add to wirez.","created_at":"2016-08-02T10:11:36Z","updated_at":"2016-08-02T10:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/romartin/wirez/pulls/25/commits","review_comments_url":"https://api.github.com/repos/romartin/wirez/pulls/25/comments","review_comment_url":"https://api.github.com/repos/romartin/wirez/pulls/comments{/number}","comments_url":"https://api.github.com/repos/romartin/wirez/issues/25/comments","statuses_url":"https://api.github.com/repos/romartin/wirez/statuses/9cf8c888ce85c0f8d1b5b797a2952adbe2c58f6f","head":{"label":"jlindop:RefactorSimulationMarshalling","ref":"RefactorSimulationMarshalling","sha":"9cf8c888ce85c0f8d1b5b797a2952adbe2c58f6f","user":{"login":"jlindop","id":7510088,"avatar_url":"https://avatars.githubusercontent.com/u/7510088?v=3","gravatar_id":"","url":"https://api.github.com/users/jlindop","html_url":"https://github.com/jlindop","followers_url":"https://api.github.com/users/jlindop/followers","following_url":"https://api.github.com/users/jlindop/following{/other_user}","gists_url":"https://api.github.com/users/jlindop/gists{/gist_id}","starred_url":"https://api.github.com/users/jlindop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlindop/subscriptions","organizations_url":"https://api.github.com/users/jlindop/orgs","repos_url":"https://api.github.com/users/jlindop/repos","events_url":"https://api.github.com/users/jlindop/events{/privacy}","received_events_url":"https://api.github.com/users/jlindop/received_events","type":"User","site_admin":false},"repo":{"id":60840253,"name":"wirez","full_name":"jlindop/wirez","owner":{"login":"jlindop","id":7510088,"avatar_url":"https://avatars.githubusercontent.com/u/7510088?v=3","gravatar_id":"","url":"https://api.github.com/users/jlindop","html_url":"https://github.com/jlindop","followers_url":"https://api.github.com/users/jlindop/followers","following_url":"https://api.github.com/users/jlindop/following{/other_user}","gists_url":"https://api.github.com/users/jlindop/gists{/gist_id}","starred_url":"https://api.github.com/users/jlindop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlindop/subscriptions","organizations_url":"https://api.github.com/users/jlindop/orgs","repos_url":"https://api.github.com/users/jlindop/repos","events_url":"https://api.github.com/users/jlindop/events{/privacy}","received_events_url":"https://api.github.com/users/jlindop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlindop/wirez","description":"UberFire Wirez Modelling Tool","fork":true,"url":"https://api.github.com/repos/jlindop/wirez","forks_url":"https://api.github.com/repos/jlindop/wirez/forks","keys_url":"https://api.github.com/repos/jlindop/wirez/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlindop/wirez/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlindop/wirez/teams","hooks_url":"https://api.github.com/repos/jlindop/wirez/hooks","issue_events_url":"https://api.github.com/repos/jlindop/wirez/issues/events{/number}","events_url":"https://api.github.com/repos/jlindop/wirez/events","assignees_url":"https://api.github.com/repos/jlindop/wirez/assignees{/user}","branches_url":"https://api.github.com/repos/jlindop/wirez/branches{/branch}","tags_url":"https://api.github.com/repos/jlindop/wirez/tags","blobs_url":"https://api.github.com/repos/jlindop/wirez/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlindop/wirez/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlindop/wirez/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlindop/wirez/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlindop/wirez/statuses/{sha}","languages_url":"https://api.github.com/repos/jlindop/wirez/languages","stargazers_url":"https://api.github.com/repos/jlindop/wirez/stargazers","contributors_url":"https://api.github.com/repos/jlindop/wirez/contributors","subscribers_url":"https://api.github.com/repos/jlindop/wirez/subscribers","subscription_url":"https://api.github.com/repos/jlindop/wirez/subscription","commits_url":"https://api.github.com/repos/jlindop/wirez/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlindop/wirez/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlindop/wirez/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlindop/wirez/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlindop/wirez/contents/{+path}","compare_url":"https://api.github.com/repos/jlindop/wirez/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlindop/wirez/merges","archive_url":"https://api.github.com/repos/jlindop/wirez/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlindop/wirez/downloads","issues_url":"https://api.github.com/repos/jlindop/wirez/issues{/number}","pulls_url":"https://api.github.com/repos/jlindop/wirez/pulls{/number}","milestones_url":"https://api.github.com/repos/jlindop/wirez/milestones{/number}","notifications_url":"https://api.github.com/repos/jlindop/wirez/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlindop/wirez/labels{/name}","releases_url":"https://api.github.com/repos/jlindop/wirez/releases{/id}","deployments_url":"https://api.github.com/repos/jlindop/wirez/deployments","created_at":"2016-06-10T10:31:13Z","updated_at":"2016-06-10T10:31:17Z","pushed_at":"2016-08-02T10:01:45Z","git_url":"git://github.com/jlindop/wirez.git","ssh_url":"git@github.com:jlindop/wirez.git","clone_url":"https://github.com/jlindop/wirez.git","svn_url":"https://github.com/jlindop/wirez","homepage":null,"size":4268,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"romartin:master","ref":"master","sha":"5f0873cb12fe9d16cba247e849d8fd330b203937","user":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"repo":{"id":48624815,"name":"wirez","full_name":"romartin/wirez","owner":{"login":"romartin","id":4602417,"avatar_url":"https://avatars.githubusercontent.com/u/4602417?v=3","gravatar_id":"","url":"https://api.github.com/users/romartin","html_url":"https://github.com/romartin","followers_url":"https://api.github.com/users/romartin/followers","following_url":"https://api.github.com/users/romartin/following{/other_user}","gists_url":"https://api.github.com/users/romartin/gists{/gist_id}","starred_url":"https://api.github.com/users/romartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romartin/subscriptions","organizations_url":"https://api.github.com/users/romartin/orgs","repos_url":"https://api.github.com/users/romartin/repos","events_url":"https://api.github.com/users/romartin/events{/privacy}","received_events_url":"https://api.github.com/users/romartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romartin/wirez","description":"UberFire Wirez Modelling Tool","fork":false,"url":"https://api.github.com/repos/romartin/wirez","forks_url":"https://api.github.com/repos/romartin/wirez/forks","keys_url":"https://api.github.com/repos/romartin/wirez/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romartin/wirez/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romartin/wirez/teams","hooks_url":"https://api.github.com/repos/romartin/wirez/hooks","issue_events_url":"https://api.github.com/repos/romartin/wirez/issues/events{/number}","events_url":"https://api.github.com/repos/romartin/wirez/events","assignees_url":"https://api.github.com/repos/romartin/wirez/assignees{/user}","branches_url":"https://api.github.com/repos/romartin/wirez/branches{/branch}","tags_url":"https://api.github.com/repos/romartin/wirez/tags","blobs_url":"https://api.github.com/repos/romartin/wirez/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romartin/wirez/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romartin/wirez/git/refs{/sha}","trees_url":"https://api.github.com/repos/romartin/wirez/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romartin/wirez/statuses/{sha}","languages_url":"https://api.github.com/repos/romartin/wirez/languages","stargazers_url":"https://api.github.com/repos/romartin/wirez/stargazers","contributors_url":"https://api.github.com/repos/romartin/wirez/contributors","subscribers_url":"https://api.github.com/repos/romartin/wirez/subscribers","subscription_url":"https://api.github.com/repos/romartin/wirez/subscription","commits_url":"https://api.github.com/repos/romartin/wirez/commits{/sha}","git_commits_url":"https://api.github.com/repos/romartin/wirez/git/commits{/sha}","comments_url":"https://api.github.com/repos/romartin/wirez/comments{/number}","issue_comment_url":"https://api.github.com/repos/romartin/wirez/issues/comments{/number}","contents_url":"https://api.github.com/repos/romartin/wirez/contents/{+path}","compare_url":"https://api.github.com/repos/romartin/wirez/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romartin/wirez/merges","archive_url":"https://api.github.com/repos/romartin/wirez/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romartin/wirez/downloads","issues_url":"https://api.github.com/repos/romartin/wirez/issues{/number}","pulls_url":"https://api.github.com/repos/romartin/wirez/pulls{/number}","milestones_url":"https://api.github.com/repos/romartin/wirez/milestones{/number}","notifications_url":"https://api.github.com/repos/romartin/wirez/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romartin/wirez/labels{/name}","releases_url":"https://api.github.com/repos/romartin/wirez/releases{/id}","deployments_url":"https://api.github.com/repos/romartin/wirez/deployments","created_at":"2015-12-26T22:02:43Z","updated_at":"2016-01-17T18:41:42Z","pushed_at":"2016-08-02T10:11:37Z","git_url":"git://github.com/romartin/wirez.git","ssh_url":"git@github.com:romartin/wirez.git","clone_url":"https://github.com/romartin/wirez.git","svn_url":"https://github.com/romartin/wirez","homepage":null,"size":4253,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/romartin/wirez/pulls/25"},"html":{"href":"https://github.com/romartin/wirez/pull/25"},"issue":{"href":"https://api.github.com/repos/romartin/wirez/issues/25"},"comments":{"href":"https://api.github.com/repos/romartin/wirez/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/romartin/wirez/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/romartin/wirez/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/romartin/wirez/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/romartin/wirez/statuses/9cf8c888ce85c0f8d1b5b797a2952adbe2c58f6f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":218,"deletions":630,"changed_files":3}}
{"actor":{"display_login":"jlindop"}}