{"action":"created","comment":{"url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/comments/88832361","pull_request_review_id":9392398,"id":88832361,"diff_hunk":"@@ -244,6 +277,11 @@ class Joint\n \tint dof_;\n \n \tstd::string name_;\n+\n+\tbool is_mimic_ = false;\n+\tstd::string mimic_name_ = \"\";\n+\tdouble mimic_multiplier_ = 1.0;\n+\tdouble mimic_offset_ = 0.0;","path":"src/Joint.h","position":55,"original_position":55,"commit_id":"5c0e18eb365b1fce2f01e08e24732d26cc4184cb","original_commit_id":"5c0e18eb365b1fce2f01e08e24732d26cc4184cb","user":{"login":"haudren","id":4352562,"avatar_url":"https://avatars.githubusercontent.com/u/4352562?v=3","gravatar_id":"","url":"https://api.github.com/users/haudren","html_url":"https://github.com/haudren","followers_url":"https://api.github.com/users/haudren/followers","following_url":"https://api.github.com/users/haudren/following{/other_user}","gists_url":"https://api.github.com/users/haudren/gists{/gist_id}","starred_url":"https://api.github.com/users/haudren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haudren/subscriptions","organizations_url":"https://api.github.com/users/haudren/orgs","repos_url":"https://api.github.com/users/haudren/repos","events_url":"https://api.github.com/users/haudren/events{/privacy}","received_events_url":"https://api.github.com/users/haudren/received_events","type":"User","site_admin":false},"body":"All properties in RBDyn are camelCase ending with an underscore, maybe you had too much Python :snake: ","created_at":"2016-11-21T05:47:16Z","updated_at":"2016-11-21T05:47:39Z","html_url":"https://github.com/jrl-umi3218/RBDyn/pull/23#discussion_r88832361","pull_request_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/comments/88832361"},"html":{"href":"https://github.com/jrl-umi3218/RBDyn/pull/23#discussion_r88832361"},"pull_request":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23","id":94555647,"html_url":"https://github.com/jrl-umi3218/RBDyn/pull/23","diff_url":"https://github.com/jrl-umi3218/RBDyn/pull/23.diff","patch_url":"https://github.com/jrl-umi3218/RBDyn/pull/23.patch","issue_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/23","number":23,"state":"open","locked":false,"title":"Store mimic joint information","user":{"login":"gergondet","id":473543,"avatar_url":"https://avatars.githubusercontent.com/u/473543?v=3","gravatar_id":"","url":"https://api.github.com/users/gergondet","html_url":"https://github.com/gergondet","followers_url":"https://api.github.com/users/gergondet/followers","following_url":"https://api.github.com/users/gergondet/following{/other_user}","gists_url":"https://api.github.com/users/gergondet/gists{/gist_id}","starred_url":"https://api.github.com/users/gergondet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergondet/subscriptions","organizations_url":"https://api.github.com/users/gergondet/orgs","repos_url":"https://api.github.com/users/gergondet/repos","events_url":"https://api.github.com/users/gergondet/events{/privacy}","received_events_url":"https://api.github.com/users/gergondet/received_events","type":"User","site_admin":false},"body":"This PR makes it possible to store mimic joint information in a `Joint` object. \r\n\r\nBy itself, the information is not very useful in RBDyn and there is currently no way to enforce the mimic relationship in `MultiBodyConfig` for example.\r\n\r\nSee jrl-umi3218/Tasks#13 for usage in control.\r\n\r\n","created_at":"2016-11-21T05:16:55Z","updated_at":"2016-11-21T05:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af8656223b6b6617c5bb6a51d955ef423186e208","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23/commits","review_comments_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23/comments","review_comment_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/23/comments","statuses_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/statuses/5c0e18eb365b1fce2f01e08e24732d26cc4184cb","head":{"label":"jrl-umi3218:topic/MimicJoint","ref":"topic/MimicJoint","sha":"5c0e18eb365b1fce2f01e08e24732d26cc4184cb","user":{"login":"jrl-umi3218","id":410812,"avatar_url":"https://avatars.githubusercontent.com/u/410812?v=3","gravatar_id":"","url":"https://api.github.com/users/jrl-umi3218","html_url":"https://github.com/jrl-umi3218","followers_url":"https://api.github.com/users/jrl-umi3218/followers","following_url":"https://api.github.com/users/jrl-umi3218/following{/other_user}","gists_url":"https://api.github.com/users/jrl-umi3218/gists{/gist_id}","starred_url":"https://api.github.com/users/jrl-umi3218/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrl-umi3218/subscriptions","organizations_url":"https://api.github.com/users/jrl-umi3218/orgs","repos_url":"https://api.github.com/users/jrl-umi3218/repos","events_url":"https://api.github.com/users/jrl-umi3218/events{/privacy}","received_events_url":"https://api.github.com/users/jrl-umi3218/received_events","type":"Organization","site_admin":false},"repo":{"id":3740096,"name":"RBDyn","full_name":"jrl-umi3218/RBDyn","owner":{"login":"jrl-umi3218","id":410812,"avatar_url":"https://avatars.githubusercontent.com/u/410812?v=3","gravatar_id":"","url":"https://api.github.com/users/jrl-umi3218","html_url":"https://github.com/jrl-umi3218","followers_url":"https://api.github.com/users/jrl-umi3218/followers","following_url":"https://api.github.com/users/jrl-umi3218/following{/other_user}","gists_url":"https://api.github.com/users/jrl-umi3218/gists{/gist_id}","starred_url":"https://api.github.com/users/jrl-umi3218/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrl-umi3218/subscriptions","organizations_url":"https://api.github.com/users/jrl-umi3218/orgs","repos_url":"https://api.github.com/users/jrl-umi3218/repos","events_url":"https://api.github.com/users/jrl-umi3218/events{/privacy}","received_events_url":"https://api.github.com/users/jrl-umi3218/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jrl-umi3218/RBDyn","description":"RBDyn provide a set of class and function to model the dynamics of rigid body system.","fork":false,"url":"https://api.github.com/repos/jrl-umi3218/RBDyn","forks_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/forks","keys_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/teams","hooks_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/hooks","issue_events_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/events{/number}","events_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/events","assignees_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/assignees{/user}","branches_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/branches{/branch}","tags_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/tags","blobs_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/languages","stargazers_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/stargazers","contributors_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/contributors","subscribers_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/subscribers","subscription_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/subscription","commits_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/contents/{+path}","compare_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/merges","archive_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/downloads","issues_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues{/number}","pulls_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/labels{/name}","releases_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/releases{/id}","deployments_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/deployments","created_at":"2012-03-16T15:22:12Z","updated_at":"2016-10-26T09:40:48Z","pushed_at":"2016-11-21T05:16:55Z","git_url":"git://github.com/jrl-umi3218/RBDyn.git","ssh_url":"git@github.com:jrl-umi3218/RBDyn.git","clone_url":"https://github.com/jrl-umi3218/RBDyn.git","svn_url":"https://github.com/jrl-umi3218/RBDyn","homepage":"","size":1744,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":11,"default_branch":"master"}},"base":{"label":"jrl-umi3218:master","ref":"master","sha":"0f63e5e1e56f747898ef3db2c409ebac8eae249d","user":{"login":"jrl-umi3218","id":410812,"avatar_url":"https://avatars.githubusercontent.com/u/410812?v=3","gravatar_id":"","url":"https://api.github.com/users/jrl-umi3218","html_url":"https://github.com/jrl-umi3218","followers_url":"https://api.github.com/users/jrl-umi3218/followers","following_url":"https://api.github.com/users/jrl-umi3218/following{/other_user}","gists_url":"https://api.github.com/users/jrl-umi3218/gists{/gist_id}","starred_url":"https://api.github.com/users/jrl-umi3218/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrl-umi3218/subscriptions","organizations_url":"https://api.github.com/users/jrl-umi3218/orgs","repos_url":"https://api.github.com/users/jrl-umi3218/repos","events_url":"https://api.github.com/users/jrl-umi3218/events{/privacy}","received_events_url":"https://api.github.com/users/jrl-umi3218/received_events","type":"Organization","site_admin":false},"repo":{"id":3740096,"name":"RBDyn","full_name":"jrl-umi3218/RBDyn","owner":{"login":"jrl-umi3218","id":410812,"avatar_url":"https://avatars.githubusercontent.com/u/410812?v=3","gravatar_id":"","url":"https://api.github.com/users/jrl-umi3218","html_url":"https://github.com/jrl-umi3218","followers_url":"https://api.github.com/users/jrl-umi3218/followers","following_url":"https://api.github.com/users/jrl-umi3218/following{/other_user}","gists_url":"https://api.github.com/users/jrl-umi3218/gists{/gist_id}","starred_url":"https://api.github.com/users/jrl-umi3218/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrl-umi3218/subscriptions","organizations_url":"https://api.github.com/users/jrl-umi3218/orgs","repos_url":"https://api.github.com/users/jrl-umi3218/repos","events_url":"https://api.github.com/users/jrl-umi3218/events{/privacy}","received_events_url":"https://api.github.com/users/jrl-umi3218/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jrl-umi3218/RBDyn","description":"RBDyn provide a set of class and function to model the dynamics of rigid body system.","fork":false,"url":"https://api.github.com/repos/jrl-umi3218/RBDyn","forks_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/forks","keys_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/teams","hooks_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/hooks","issue_events_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/events{/number}","events_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/events","assignees_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/assignees{/user}","branches_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/branches{/branch}","tags_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/tags","blobs_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/statuses/{sha}","languages_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/languages","stargazers_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/stargazers","contributors_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/contributors","subscribers_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/subscribers","subscription_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/subscription","commits_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/contents/{+path}","compare_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/merges","archive_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/downloads","issues_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues{/number}","pulls_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls{/number}","milestones_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/milestones{/number}","notifications_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/labels{/name}","releases_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/releases{/id}","deployments_url":"https://api.github.com/repos/jrl-umi3218/RBDyn/deployments","created_at":"2012-03-16T15:22:12Z","updated_at":"2016-10-26T09:40:48Z","pushed_at":"2016-11-21T05:16:55Z","git_url":"git://github.com/jrl-umi3218/RBDyn.git","ssh_url":"git@github.com:jrl-umi3218/RBDyn.git","clone_url":"https://github.com/jrl-umi3218/RBDyn.git","svn_url":"https://github.com/jrl-umi3218/RBDyn","homepage":"","size":1744,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23"},"html":{"href":"https://github.com/jrl-umi3218/RBDyn/pull/23"},"issue":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/23"},"comments":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/jrl-umi3218/RBDyn/statuses/5c0e18eb365b1fce2f01e08e24732d26cc4184cb"}}}}
{"actor":{"display_login":"haudren"}}