{"action":"opened","number":7836,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7836","id":64144740,"html_url":"https://github.com/hazelcast/hazelcast/pull/7836","diff_url":"https://github.com/hazelcast/hazelcast/pull/7836.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/7836.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7836","number":7836,"state":"open","locked":false,"title":"Fixes client shutdown problem when connection unresponsive","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"body":"The assert in clientInvocationService shutdown that checks\r\nall invocations are cleared  via setting exception was\r\nfailing before the fix in testInvocation_whenHeartbeatStopped.\r\n\r\nThis fix guarantees that after client started shutting down\r\nfirst all connections included in progress ones are closed\r\nor canceled. Then other services started the shutdown. This\r\nway we guarantee that when clientInvocationService is shutting down\r\nthere is no invocation on the fly with live connection.","created_at":"2016-03-25T09:13:18Z","updated_at":"2016-03-25T09:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/73","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6.2","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/73/labels","id":1596983,"number":73,"title":"3.6.2","description":"","creator":{"login":"emrahkocaman","id":2887123,"avatar_url":"https://avatars.githubusercontent.com/u/2887123?v=3","gravatar_id":"","url":"https://api.github.com/users/emrahkocaman","html_url":"https://github.com/emrahkocaman","followers_url":"https://api.github.com/users/emrahkocaman/followers","following_url":"https://api.github.com/users/emrahkocaman/following{/other_user}","gists_url":"https://api.github.com/users/emrahkocaman/gists{/gist_id}","starred_url":"https://api.github.com/users/emrahkocaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emrahkocaman/subscriptions","organizations_url":"https://api.github.com/users/emrahkocaman/orgs","repos_url":"https://api.github.com/users/emrahkocaman/repos","events_url":"https://api.github.com/users/emrahkocaman/events{/privacy}","received_events_url":"https://api.github.com/users/emrahkocaman/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":45,"state":"open","created_at":"2016-02-22T12:41:01Z","updated_at":"2016-03-25T09:13:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7836/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7836/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7836/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/2dc4ce354a8ec480c43b937b8c500e1bd8a70d8e","head":{"label":"sancar:fix/shutdownProblemWhenConnectionUnresponsive/maint3.x","ref":"fix/shutdownProblemWhenConnectionUnresponsive/maint3.x","sha":"2dc4ce354a8ec480c43b937b8c500e1bd8a70d8e","user":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"repo":{"id":12152804,"name":"hazelcast","full_name":"sancar/hazelcast","owner":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sancar/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/sancar/hazelcast","forks_url":"https://api.github.com/repos/sancar/hazelcast/forks","keys_url":"https://api.github.com/repos/sancar/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sancar/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sancar/hazelcast/teams","hooks_url":"https://api.github.com/repos/sancar/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/sancar/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/sancar/hazelcast/events","assignees_url":"https://api.github.com/repos/sancar/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/sancar/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/sancar/hazelcast/tags","blobs_url":"https://api.github.com/repos/sancar/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sancar/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sancar/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/sancar/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sancar/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/sancar/hazelcast/languages","stargazers_url":"https://api.github.com/repos/sancar/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/sancar/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/sancar/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/sancar/hazelcast/subscription","commits_url":"https://api.github.com/repos/sancar/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/sancar/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/sancar/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/sancar/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/sancar/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/sancar/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sancar/hazelcast/merges","archive_url":"https://api.github.com/repos/sancar/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sancar/hazelcast/downloads","issues_url":"https://api.github.com/repos/sancar/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/sancar/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/sancar/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/sancar/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sancar/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/sancar/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/sancar/hazelcast/deployments","created_at":"2013-08-16T06:59:07Z","updated_at":"2015-04-23T16:11:55Z","pushed_at":"2016-03-25T09:12:51Z","git_url":"git://github.com/sancar/hazelcast.git","ssh_url":"git@github.com:sancar/hazelcast.git","clone_url":"https://github.com/sancar/hazelcast.git","svn_url":"https://github.com/sancar/hazelcast","homepage":"www.hazelcast.com","size":94679,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:maintenance-3.x","ref":"maintenance-3.x","sha":"e678088e66b5680e673678e9379fefb4a59b4d48","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-03-24T13:13:08Z","pushed_at":"2016-03-25T09:13:18Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":109156,"stargazers_count":1485,"watchers_count":1485,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":704,"mirror_url":null,"open_issues_count":583,"forks":704,"open_issues":583,"watchers":1485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7836"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7836"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7836"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7836/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7836/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7836/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/2dc4ce354a8ec480c43b937b8c500e1bd8a70d8e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":26,"deletions":1,"changed_files":3}}