{"action":"created","comment":{"url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/comments/73673906","id":73673906,"diff_hunk":"@@ -187,32 +187,21 @@ class ukf {\n \t{\n \t\tassert(X.size() == 2 * n + 1);\n \n-\t\tlapack::cholesky<n> L(sigma);\n+        Eigen::LLT<cov> lltOfSigma(sigma); // compute the Cholesky decomposition of A\n+        cov L = lltOfSigma.matrixL(); // retrieve factor L  in the decomposition\n \n-\t\tif (!L.isSPD())\n-\t\t{\n-\t\t\tstd::cerr << std::endl << \"sigma is not SPD:\" << std::endl\n-\t\t\t\t\t  << sigma << std::endl\n-\t\t\t\t\t  << \"---\" << std::endl;\n-\t\t\tEigen::EigenSolver<cov> eig(sigma);\n-\t\t\tstd::cerr << \"eigen values: \" << eig.eigenvalues().transpose() << std::endl;\n-\t\t}\n-\t\t\n-\t\tassert(L.isSPD());","path":"ukfom/ukf.hpp","position":27,"original_position":27,"commit_id":"9cf4176224bc0728859a8bba5dc0f439f56d7ce4","original_commit_id":"02d1b39c9f9b22a94eeee6d8937e02cacb7b0e32","user":{"login":"jhidalgocarrio","id":4748753,"avatar_url":"https://avatars.githubusercontent.com/u/4748753?v=3","gravatar_id":"","url":"https://api.github.com/users/jhidalgocarrio","html_url":"https://github.com/jhidalgocarrio","followers_url":"https://api.github.com/users/jhidalgocarrio/followers","following_url":"https://api.github.com/users/jhidalgocarrio/following{/other_user}","gists_url":"https://api.github.com/users/jhidalgocarrio/gists{/gist_id}","starred_url":"https://api.github.com/users/jhidalgocarrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhidalgocarrio/subscriptions","organizations_url":"https://api.github.com/users/jhidalgocarrio/orgs","repos_url":"https://api.github.com/users/jhidalgocarrio/repos","events_url":"https://api.github.com/users/jhidalgocarrio/events{/privacy}","received_events_url":"https://api.github.com/users/jhidalgocarrio/received_events","type":"User","site_admin":false},"body":"This is what [guaranteeSPD](https://github.com/rock-core/base-types/blob/38662f835f555e5be6de69f80402ef76cbbb08b5/base/Eigen.hpp#L58\r\n) method does. It set all negative Eigen values to 0.0\r\n","created_at":"2016-08-05T10:40:49Z","updated_at":"2016-08-05T10:40:49Z","html_url":"https://github.com/rock-slam/slam-mtk/pull/4#discussion_r73673906","pull_request_url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/comments/73673906"},"html":{"href":"https://github.com/rock-slam/slam-mtk/pull/4#discussion_r73673906"},"pull_request":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4","id":46504975,"html_url":"https://github.com/rock-slam/slam-mtk/pull/4","diff_url":"https://github.com/rock-slam/slam-mtk/pull/4.diff","patch_url":"https://github.com/rock-slam/slam-mtk/pull/4.patch","issue_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues/4","number":4,"state":"open","locked":false,"title":"remove c++11 lapack compilation errors and warning","user":{"login":"jhidalgocarrio","id":4748753,"avatar_url":"https://avatars.githubusercontent.com/u/4748753?v=3","gravatar_id":"","url":"https://api.github.com/users/jhidalgocarrio","html_url":"https://github.com/jhidalgocarrio","followers_url":"https://api.github.com/users/jhidalgocarrio/followers","following_url":"https://api.github.com/users/jhidalgocarrio/following{/other_user}","gists_url":"https://api.github.com/users/jhidalgocarrio/gists{/gist_id}","starred_url":"https://api.github.com/users/jhidalgocarrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhidalgocarrio/subscriptions","organizations_url":"https://api.github.com/users/jhidalgocarrio/orgs","repos_url":"https://api.github.com/users/jhidalgocarrio/repos","events_url":"https://api.github.com/users/jhidalgocarrio/events{/privacy}","received_events_url":"https://api.github.com/users/jhidalgocarrio/received_events","type":"User","site_admin":false},"body":"It combines PR #3 +  #2  in a single commit\r\nukfom: removed c++11 cholesky lapack error\r\nremoved lapack dependency\r\nand remove c++11 warning\r\n","created_at":"2015-10-01T10:02:57Z","updated_at":"2016-08-05T10:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aec02d5897146e95be017da5c9e2a8d5cb86a293","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4/commits","review_comments_url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4/comments","review_comment_url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues/4/comments","statuses_url":"https://api.github.com/repos/rock-slam/slam-mtk/statuses/9cf4176224bc0728859a8bba5dc0f439f56d7ce4","head":{"label":"rock-slam:cxx11_error","ref":"cxx11_error","sha":"9cf4176224bc0728859a8bba5dc0f439f56d7ce4","user":{"login":"rock-slam","id":10197317,"avatar_url":"https://avatars.githubusercontent.com/u/10197317?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-slam","html_url":"https://github.com/rock-slam","followers_url":"https://api.github.com/users/rock-slam/followers","following_url":"https://api.github.com/users/rock-slam/following{/other_user}","gists_url":"https://api.github.com/users/rock-slam/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-slam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-slam/subscriptions","organizations_url":"https://api.github.com/users/rock-slam/orgs","repos_url":"https://api.github.com/users/rock-slam/repos","events_url":"https://api.github.com/users/rock-slam/events{/privacy}","received_events_url":"https://api.github.com/users/rock-slam/received_events","type":"Organization","site_admin":false},"repo":{"id":34859449,"name":"slam-mtk","full_name":"rock-slam/slam-mtk","owner":{"login":"rock-slam","id":10197317,"avatar_url":"https://avatars.githubusercontent.com/u/10197317?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-slam","html_url":"https://github.com/rock-slam","followers_url":"https://api.github.com/users/rock-slam/followers","following_url":"https://api.github.com/users/rock-slam/following{/other_user}","gists_url":"https://api.github.com/users/rock-slam/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-slam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-slam/subscriptions","organizations_url":"https://api.github.com/users/rock-slam/orgs","repos_url":"https://api.github.com/users/rock-slam/repos","events_url":"https://api.github.com/users/rock-slam/events{/privacy}","received_events_url":"https://api.github.com/users/rock-slam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rock-slam/slam-mtk","description":" MTK is a toolkit that provides easy mechanisms to enable arbitrary algorithms to operate on manifolds. Forked from https://openslam.org","fork":false,"url":"https://api.github.com/repos/rock-slam/slam-mtk","forks_url":"https://api.github.com/repos/rock-slam/slam-mtk/forks","keys_url":"https://api.github.com/repos/rock-slam/slam-mtk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rock-slam/slam-mtk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rock-slam/slam-mtk/teams","hooks_url":"https://api.github.com/repos/rock-slam/slam-mtk/hooks","issue_events_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues/events{/number}","events_url":"https://api.github.com/repos/rock-slam/slam-mtk/events","assignees_url":"https://api.github.com/repos/rock-slam/slam-mtk/assignees{/user}","branches_url":"https://api.github.com/repos/rock-slam/slam-mtk/branches{/branch}","tags_url":"https://api.github.com/repos/rock-slam/slam-mtk/tags","blobs_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rock-slam/slam-mtk/statuses/{sha}","languages_url":"https://api.github.com/repos/rock-slam/slam-mtk/languages","stargazers_url":"https://api.github.com/repos/rock-slam/slam-mtk/stargazers","contributors_url":"https://api.github.com/repos/rock-slam/slam-mtk/contributors","subscribers_url":"https://api.github.com/repos/rock-slam/slam-mtk/subscribers","subscription_url":"https://api.github.com/repos/rock-slam/slam-mtk/subscription","commits_url":"https://api.github.com/repos/rock-slam/slam-mtk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rock-slam/slam-mtk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rock-slam/slam-mtk/contents/{+path}","compare_url":"https://api.github.com/repos/rock-slam/slam-mtk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rock-slam/slam-mtk/merges","archive_url":"https://api.github.com/repos/rock-slam/slam-mtk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rock-slam/slam-mtk/downloads","issues_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues{/number}","pulls_url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls{/number}","milestones_url":"https://api.github.com/repos/rock-slam/slam-mtk/milestones{/number}","notifications_url":"https://api.github.com/repos/rock-slam/slam-mtk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rock-slam/slam-mtk/labels{/name}","releases_url":"https://api.github.com/repos/rock-slam/slam-mtk/releases{/id}","deployments_url":"https://api.github.com/repos/rock-slam/slam-mtk/deployments","created_at":"2015-04-30T14:41:04Z","updated_at":"2016-04-27T15:55:05Z","pushed_at":"2016-08-05T10:40:33Z","git_url":"git://github.com/rock-slam/slam-mtk.git","ssh_url":"git@github.com:rock-slam/slam-mtk.git","clone_url":"https://github.com/rock-slam/slam-mtk.git","svn_url":"https://github.com/rock-slam/slam-mtk","homepage":null,"size":104,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rock-slam:master","ref":"master","sha":"f4f7bd3bc5374601eab782426f7b5f1eb7a5c868","user":{"login":"rock-slam","id":10197317,"avatar_url":"https://avatars.githubusercontent.com/u/10197317?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-slam","html_url":"https://github.com/rock-slam","followers_url":"https://api.github.com/users/rock-slam/followers","following_url":"https://api.github.com/users/rock-slam/following{/other_user}","gists_url":"https://api.github.com/users/rock-slam/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-slam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-slam/subscriptions","organizations_url":"https://api.github.com/users/rock-slam/orgs","repos_url":"https://api.github.com/users/rock-slam/repos","events_url":"https://api.github.com/users/rock-slam/events{/privacy}","received_events_url":"https://api.github.com/users/rock-slam/received_events","type":"Organization","site_admin":false},"repo":{"id":34859449,"name":"slam-mtk","full_name":"rock-slam/slam-mtk","owner":{"login":"rock-slam","id":10197317,"avatar_url":"https://avatars.githubusercontent.com/u/10197317?v=3","gravatar_id":"","url":"https://api.github.com/users/rock-slam","html_url":"https://github.com/rock-slam","followers_url":"https://api.github.com/users/rock-slam/followers","following_url":"https://api.github.com/users/rock-slam/following{/other_user}","gists_url":"https://api.github.com/users/rock-slam/gists{/gist_id}","starred_url":"https://api.github.com/users/rock-slam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock-slam/subscriptions","organizations_url":"https://api.github.com/users/rock-slam/orgs","repos_url":"https://api.github.com/users/rock-slam/repos","events_url":"https://api.github.com/users/rock-slam/events{/privacy}","received_events_url":"https://api.github.com/users/rock-slam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rock-slam/slam-mtk","description":" MTK is a toolkit that provides easy mechanisms to enable arbitrary algorithms to operate on manifolds. Forked from https://openslam.org","fork":false,"url":"https://api.github.com/repos/rock-slam/slam-mtk","forks_url":"https://api.github.com/repos/rock-slam/slam-mtk/forks","keys_url":"https://api.github.com/repos/rock-slam/slam-mtk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rock-slam/slam-mtk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rock-slam/slam-mtk/teams","hooks_url":"https://api.github.com/repos/rock-slam/slam-mtk/hooks","issue_events_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues/events{/number}","events_url":"https://api.github.com/repos/rock-slam/slam-mtk/events","assignees_url":"https://api.github.com/repos/rock-slam/slam-mtk/assignees{/user}","branches_url":"https://api.github.com/repos/rock-slam/slam-mtk/branches{/branch}","tags_url":"https://api.github.com/repos/rock-slam/slam-mtk/tags","blobs_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/refs{/sha}","trees_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rock-slam/slam-mtk/statuses/{sha}","languages_url":"https://api.github.com/repos/rock-slam/slam-mtk/languages","stargazers_url":"https://api.github.com/repos/rock-slam/slam-mtk/stargazers","contributors_url":"https://api.github.com/repos/rock-slam/slam-mtk/contributors","subscribers_url":"https://api.github.com/repos/rock-slam/slam-mtk/subscribers","subscription_url":"https://api.github.com/repos/rock-slam/slam-mtk/subscription","commits_url":"https://api.github.com/repos/rock-slam/slam-mtk/commits{/sha}","git_commits_url":"https://api.github.com/repos/rock-slam/slam-mtk/git/commits{/sha}","comments_url":"https://api.github.com/repos/rock-slam/slam-mtk/comments{/number}","issue_comment_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues/comments{/number}","contents_url":"https://api.github.com/repos/rock-slam/slam-mtk/contents/{+path}","compare_url":"https://api.github.com/repos/rock-slam/slam-mtk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rock-slam/slam-mtk/merges","archive_url":"https://api.github.com/repos/rock-slam/slam-mtk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rock-slam/slam-mtk/downloads","issues_url":"https://api.github.com/repos/rock-slam/slam-mtk/issues{/number}","pulls_url":"https://api.github.com/repos/rock-slam/slam-mtk/pulls{/number}","milestones_url":"https://api.github.com/repos/rock-slam/slam-mtk/milestones{/number}","notifications_url":"https://api.github.com/repos/rock-slam/slam-mtk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rock-slam/slam-mtk/labels{/name}","releases_url":"https://api.github.com/repos/rock-slam/slam-mtk/releases{/id}","deployments_url":"https://api.github.com/repos/rock-slam/slam-mtk/deployments","created_at":"2015-04-30T14:41:04Z","updated_at":"2016-04-27T15:55:05Z","pushed_at":"2016-08-05T10:40:33Z","git_url":"git://github.com/rock-slam/slam-mtk.git","ssh_url":"git@github.com:rock-slam/slam-mtk.git","clone_url":"https://github.com/rock-slam/slam-mtk.git","svn_url":"https://github.com/rock-slam/slam-mtk","homepage":null,"size":104,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4"},"html":{"href":"https://github.com/rock-slam/slam-mtk/pull/4"},"issue":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/issues/4"},"comments":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/rock-slam/slam-mtk/statuses/9cf4176224bc0728859a8bba5dc0f439f56d7ce4"}}}}
{"actor":{"display_login":"jhidalgocarrio"}}