{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/53461318","id":53461318,"diff_hunk":"@@ -42,22 +42,18 @@ internal interface IPartition<TElement> : IIListProvider<TElement>\n \n         IPartition<TElement> Take(int count);\n \n-        TElement ElementAt(int index);\n+        TElement TryGetElementAt(int index, out bool found);\n \n-        TElement ElementAtOrDefault(int index);\n+        TElement TryGetFirst(out bool found);\n \n-        TElement First();\n-\n-        TElement FirstOrDefault();\n-\n-        TElement Last();\n-\n-        TElement LastOrDefault();\n+        TElement TryGetLast(out bool found);","path":"src/System.Linq/src/System/Linq/Partition.cs","position":17,"original_position":17,"commit_id":"605660d2cb8ff928946b54e5521c69b807ea8f3d","original_commit_id":"605660d2cb8ff928946b54e5521c69b807ea8f3d","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"I think it'd be worth a comment about why the return and out positions are reversed here from what they'd normally be.","created_at":"2016-02-19T13:42:22Z","updated_at":"2016-02-19T13:42:22Z","html_url":"https://github.com/dotnet/corefx/pull/6127#discussion_r53461318","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/6127","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/53461318"},"html":{"href":"https://github.com/dotnet/corefx/pull/6127#discussion_r53461318"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6127"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/6127","id":59438152,"html_url":"https://github.com/dotnet/corefx/pull/6127","diff_url":"https://github.com/dotnet/corefx/pull/6127.diff","patch_url":"https://github.com/dotnet/corefx/pull/6127.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/6127","number":6127,"state":"open","locked":false,"title":"Use partitioning on list-based select iterators.","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"body":"The creation of SelectListIterator above allows for partitioning to be used with the list-based Select() iterators, improving some subsequent operations on them.\r\n\r\nCloses #2844. While there are still a few cases left, the majority of operations where implementing IList<T> could give a gain now have the same time complexity due to going through `IPartition`.\r\n\r\ncc @stephentoub @VSadov ","created_at":"2016-02-16T03:11:06Z","updated_at":"2016-02-19T13:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"012b007bacdf730104a94fe2c28d33bee2fad9a9","assignee":{"login":"VSadov","id":8218165,"avatar_url":"https://avatars.githubusercontent.com/u/8218165?v=3","gravatar_id":"","url":"https://api.github.com/users/VSadov","html_url":"https://github.com/VSadov","followers_url":"https://api.github.com/users/VSadov/followers","following_url":"https://api.github.com/users/VSadov/following{/other_user}","gists_url":"https://api.github.com/users/VSadov/gists{/gist_id}","starred_url":"https://api.github.com/users/VSadov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSadov/subscriptions","organizations_url":"https://api.github.com/users/VSadov/orgs","repos_url":"https://api.github.com/users/VSadov/repos","events_url":"https://api.github.com/users/VSadov/events{/privacy}","received_events_url":"https://api.github.com/users/VSadov/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/6127/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/6127/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/6127/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/605660d2cb8ff928946b54e5521c69b807ea8f3d","head":{"label":"JonHanna:skip_take_on_list_select","ref":"skip_take_on_list_select","sha":"605660d2cb8ff928946b54e5521c69b807ea8f3d","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"repo":{"id":38018243,"name":"corefx","full_name":"JonHanna/corefx","owner":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonHanna/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/JonHanna/corefx","forks_url":"https://api.github.com/repos/JonHanna/corefx/forks","keys_url":"https://api.github.com/repos/JonHanna/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonHanna/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonHanna/corefx/teams","hooks_url":"https://api.github.com/repos/JonHanna/corefx/hooks","issue_events_url":"https://api.github.com/repos/JonHanna/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/JonHanna/corefx/events","assignees_url":"https://api.github.com/repos/JonHanna/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/JonHanna/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/JonHanna/corefx/tags","blobs_url":"https://api.github.com/repos/JonHanna/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonHanna/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonHanna/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonHanna/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonHanna/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/JonHanna/corefx/languages","stargazers_url":"https://api.github.com/repos/JonHanna/corefx/stargazers","contributors_url":"https://api.github.com/repos/JonHanna/corefx/contributors","subscribers_url":"https://api.github.com/repos/JonHanna/corefx/subscribers","subscription_url":"https://api.github.com/repos/JonHanna/corefx/subscription","commits_url":"https://api.github.com/repos/JonHanna/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonHanna/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonHanna/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonHanna/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonHanna/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/JonHanna/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonHanna/corefx/merges","archive_url":"https://api.github.com/repos/JonHanna/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonHanna/corefx/downloads","issues_url":"https://api.github.com/repos/JonHanna/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/JonHanna/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/JonHanna/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/JonHanna/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonHanna/corefx/labels{/name}","releases_url":"https://api.github.com/repos/JonHanna/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/JonHanna/corefx/deployments","created_at":"2015-06-25T00:19:13Z","updated_at":"2016-01-12T23:30:27Z","pushed_at":"2016-02-19T09:06:27Z","git_url":"git://github.com/JonHanna/corefx.git","ssh_url":"git@github.com:JonHanna/corefx.git","clone_url":"https://github.com/JonHanna/corefx.git","svn_url":"https://github.com/JonHanna/corefx","homepage":"http://dotnet.github.io/core/","size":55850,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5790919493d7436e6a27dab5a1d8390ac92a9a59","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-19T12:39:50Z","pushed_at":"2016-02-19T13:22:54Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":66501,"stargazers_count":9159,"watchers_count":9159,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2137,"mirror_url":null,"open_issues_count":844,"forks":2137,"open_issues":844,"watchers":9159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6127"},"html":{"href":"https://github.com/dotnet/corefx/pull/6127"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6127"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/6127/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6127/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/6127/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/605660d2cb8ff928946b54e5521c69b807ea8f3d"}}}}