{"action":"closed","issue":{"url":"https://api.github.com/repos/Civcraft/NameLayer/issues/203","repository_url":"https://api.github.com/repos/Civcraft/NameLayer","labels_url":"https://api.github.com/repos/Civcraft/NameLayer/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/Civcraft/NameLayer/issues/203/comments","events_url":"https://api.github.com/repos/Civcraft/NameLayer/issues/203/events","html_url":"https://github.com/Civcraft/NameLayer/issues/203","id":163496930,"number":203,"title":"Convert NMS to reflection","user":{"login":"tyrothalos","id":6822237,"avatar_url":"https://avatars.githubusercontent.com/u/6822237?v=3","gravatar_id":"","url":"https://api.github.com/users/tyrothalos","html_url":"https://github.com/tyrothalos","followers_url":"https://api.github.com/users/tyrothalos/followers","following_url":"https://api.github.com/users/tyrothalos/following{/other_user}","gists_url":"https://api.github.com/users/tyrothalos/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrothalos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrothalos/subscriptions","organizations_url":"https://api.github.com/users/tyrothalos/orgs","repos_url":"https://api.github.com/users/tyrothalos/repos","events_url":"https://api.github.com/users/tyrothalos/events{/privacy}","received_events_url":"https://api.github.com/users/tyrothalos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-02T01:54:11Z","updated_at":"2016-08-31T23:32:05Z","closed_at":"2016-08-31T23:32:05Z","body":"Currently NameLayer uses a combination of NMS and reflection to change a player's name. However, it is possible to do this using only reflection and no NMS.\r\n\r\nRemoving the NMS dependency would:\r\n1. make it so that we do not need to create a new subproject for each new version of Minecraft.\r\n2. allow us to remove all of the NMS subprojects from the repository, making it easier for new developers to find their way around.\r\n3. allow us to remove the ridiculous circular dependency where the subprojects depend on the main project and the main project depends on the subprojects.\r\n\r\nIs there an interest in having this done, or is there an issue with using only reflection that I am unaware of (as opposed to using both NMS and reflection)?"}}
{"actor":{"display_login":"Maxopoly"}}