{"action":"closed","number":2038,"pull_request":{"url":"https://api.github.com/repos/Tribler/tribler/pulls/2038","id":62923759,"html_url":"https://github.com/Tribler/tribler/pull/2038","diff_url":"https://github.com/Tribler/tribler/pull/2038.diff","patch_url":"https://github.com/Tribler/tribler/pull/2038.patch","issue_url":"https://api.github.com/repos/Tribler/tribler/issues/2038","number":2038,"state":"closed","locked":false,"title":"Refactored tracker health check code to become asynchronous. Adjusted a part of the tribler shutdown procedure as a result.","user":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"body":"More deletions than additions while keeping the same functionality (I hope), but much more clean!\r\n\r\n- HTTP tracker code now makes use of Twisted's RedirectAgent. This means it will automatically redirect when a 30x code is returned, is asynchronous and has a timeout implemented. \r\n- The UDP tracker is now asynchronous, has a timeout added and has some bug fixes.\r\n- Shutdown of a UDP connection is now asynchronous, this is propogated in Tribler where it preparations are made for other components to shutdown asynchronous as well by using Deferreds.\r\n\r\nFixes #2035, contributing to #1848\r\n\r\nAdds **29** tests\r\nImproves responsiveness a lot, watchdog was tripping with > 10 seconds timeout. Not anymore.\r\nFixed **2** bugs\r\nImproved redirection by making use of Twisted's redirectAgent\r\nAdded lots of documentation for other generations to read (enchancement)\r\nFixed **50+** pylint style errors\r\n","created_at":"2016-03-15T15:24:18Z","updated_at":"2016-04-25T12:17:41Z","closed_at":"2016-04-25T12:17:41Z","merged_at":"2016-04-25T12:17:41Z","merge_commit_sha":"f7676496faae1a7e74963590801a639ad5b7c93f","assignee":null,"milestone":{"url":"https://api.github.com/repos/Tribler/tribler/milestones/13","html_url":"https://github.com/Tribler/tribler/milestones/V6.6%20WX3","labels_url":"https://api.github.com/repos/Tribler/tribler/milestones/13/labels","id":851033,"number":13,"title":"V6.6 WX3","description":"","creator":{"login":"synctext","id":325224,"avatar_url":"https://avatars.githubusercontent.com/u/325224?v=3","gravatar_id":"","url":"https://api.github.com/users/synctext","html_url":"https://github.com/synctext","followers_url":"https://api.github.com/users/synctext/followers","following_url":"https://api.github.com/users/synctext/following{/other_user}","gists_url":"https://api.github.com/users/synctext/gists{/gist_id}","starred_url":"https://api.github.com/users/synctext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/synctext/subscriptions","organizations_url":"https://api.github.com/users/synctext/orgs","repos_url":"https://api.github.com/users/synctext/repos","events_url":"https://api.github.com/users/synctext/events{/privacy}","received_events_url":"https://api.github.com/users/synctext/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":74,"state":"open","created_at":"2014-11-03T11:16:42Z","updated_at":"2016-04-25T12:17:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Tribler/tribler/pulls/2038/commits","review_comments_url":"https://api.github.com/repos/Tribler/tribler/pulls/2038/comments","review_comment_url":"https://api.github.com/repos/Tribler/tribler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Tribler/tribler/issues/2038/comments","statuses_url":"https://api.github.com/repos/Tribler/tribler/statuses/4de50b81f925b0f790ef0ddba156ca6ccbf20275","head":{"label":"lfdversluis:httptracker-async","ref":"httptracker-async","sha":"4de50b81f925b0f790ef0ddba156ca6ccbf20275","user":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"repo":{"id":45919494,"name":"tribler","full_name":"lfdversluis/tribler","owner":{"login":"lfdversluis","id":3618917,"avatar_url":"https://avatars.githubusercontent.com/u/3618917?v=3","gravatar_id":"","url":"https://api.github.com/users/lfdversluis","html_url":"https://github.com/lfdversluis","followers_url":"https://api.github.com/users/lfdversluis/followers","following_url":"https://api.github.com/users/lfdversluis/following{/other_user}","gists_url":"https://api.github.com/users/lfdversluis/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdversluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdversluis/subscriptions","organizations_url":"https://api.github.com/users/lfdversluis/orgs","repos_url":"https://api.github.com/users/lfdversluis/repos","events_url":"https://api.github.com/users/lfdversluis/events{/privacy}","received_events_url":"https://api.github.com/users/lfdversluis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lfdversluis/tribler","description":"Privacy with BitTorrent and resilient to shut down","fork":true,"url":"https://api.github.com/repos/lfdversluis/tribler","forks_url":"https://api.github.com/repos/lfdversluis/tribler/forks","keys_url":"https://api.github.com/repos/lfdversluis/tribler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lfdversluis/tribler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lfdversluis/tribler/teams","hooks_url":"https://api.github.com/repos/lfdversluis/tribler/hooks","issue_events_url":"https://api.github.com/repos/lfdversluis/tribler/issues/events{/number}","events_url":"https://api.github.com/repos/lfdversluis/tribler/events","assignees_url":"https://api.github.com/repos/lfdversluis/tribler/assignees{/user}","branches_url":"https://api.github.com/repos/lfdversluis/tribler/branches{/branch}","tags_url":"https://api.github.com/repos/lfdversluis/tribler/tags","blobs_url":"https://api.github.com/repos/lfdversluis/tribler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lfdversluis/tribler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lfdversluis/tribler/git/refs{/sha}","trees_url":"https://api.github.com/repos/lfdversluis/tribler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lfdversluis/tribler/statuses/{sha}","languages_url":"https://api.github.com/repos/lfdversluis/tribler/languages","stargazers_url":"https://api.github.com/repos/lfdversluis/tribler/stargazers","contributors_url":"https://api.github.com/repos/lfdversluis/tribler/contributors","subscribers_url":"https://api.github.com/repos/lfdversluis/tribler/subscribers","subscription_url":"https://api.github.com/repos/lfdversluis/tribler/subscription","commits_url":"https://api.github.com/repos/lfdversluis/tribler/commits{/sha}","git_commits_url":"https://api.github.com/repos/lfdversluis/tribler/git/commits{/sha}","comments_url":"https://api.github.com/repos/lfdversluis/tribler/comments{/number}","issue_comment_url":"https://api.github.com/repos/lfdversluis/tribler/issues/comments{/number}","contents_url":"https://api.github.com/repos/lfdversluis/tribler/contents/{+path}","compare_url":"https://api.github.com/repos/lfdversluis/tribler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lfdversluis/tribler/merges","archive_url":"https://api.github.com/repos/lfdversluis/tribler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lfdversluis/tribler/downloads","issues_url":"https://api.github.com/repos/lfdversluis/tribler/issues{/number}","pulls_url":"https://api.github.com/repos/lfdversluis/tribler/pulls{/number}","milestones_url":"https://api.github.com/repos/lfdversluis/tribler/milestones{/number}","notifications_url":"https://api.github.com/repos/lfdversluis/tribler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lfdversluis/tribler/labels{/name}","releases_url":"https://api.github.com/repos/lfdversluis/tribler/releases{/id}","deployments_url":"https://api.github.com/repos/lfdversluis/tribler/deployments","created_at":"2015-11-10T15:06:28Z","updated_at":"2016-01-11T13:41:55Z","pushed_at":"2016-04-22T15:33:22Z","git_url":"git://github.com/lfdversluis/tribler.git","ssh_url":"git@github.com:lfdversluis/tribler.git","clone_url":"https://github.com/lfdversluis/tribler.git","svn_url":"https://github.com/lfdversluis/tribler","homepage":"http://www.tribler.org","size":113895,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"devel"}},"base":{"label":"Tribler:devel","ref":"devel","sha":"91fed5b42f03fd3432b981d29dce964fe5b8606e","user":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"repo":{"id":8411137,"name":"tribler","full_name":"Tribler/tribler","owner":{"login":"Tribler","id":2913489,"avatar_url":"https://avatars.githubusercontent.com/u/2913489?v=3","gravatar_id":"","url":"https://api.github.com/users/Tribler","html_url":"https://github.com/Tribler","followers_url":"https://api.github.com/users/Tribler/followers","following_url":"https://api.github.com/users/Tribler/following{/other_user}","gists_url":"https://api.github.com/users/Tribler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tribler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tribler/subscriptions","organizations_url":"https://api.github.com/users/Tribler/orgs","repos_url":"https://api.github.com/users/Tribler/repos","events_url":"https://api.github.com/users/Tribler/events{/privacy}","received_events_url":"https://api.github.com/users/Tribler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tribler/tribler","description":"Privacy with BitTorrent and resilient to shut down","fork":false,"url":"https://api.github.com/repos/Tribler/tribler","forks_url":"https://api.github.com/repos/Tribler/tribler/forks","keys_url":"https://api.github.com/repos/Tribler/tribler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tribler/tribler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tribler/tribler/teams","hooks_url":"https://api.github.com/repos/Tribler/tribler/hooks","issue_events_url":"https://api.github.com/repos/Tribler/tribler/issues/events{/number}","events_url":"https://api.github.com/repos/Tribler/tribler/events","assignees_url":"https://api.github.com/repos/Tribler/tribler/assignees{/user}","branches_url":"https://api.github.com/repos/Tribler/tribler/branches{/branch}","tags_url":"https://api.github.com/repos/Tribler/tribler/tags","blobs_url":"https://api.github.com/repos/Tribler/tribler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tribler/tribler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tribler/tribler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tribler/tribler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tribler/tribler/statuses/{sha}","languages_url":"https://api.github.com/repos/Tribler/tribler/languages","stargazers_url":"https://api.github.com/repos/Tribler/tribler/stargazers","contributors_url":"https://api.github.com/repos/Tribler/tribler/contributors","subscribers_url":"https://api.github.com/repos/Tribler/tribler/subscribers","subscription_url":"https://api.github.com/repos/Tribler/tribler/subscription","commits_url":"https://api.github.com/repos/Tribler/tribler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tribler/tribler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tribler/tribler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tribler/tribler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tribler/tribler/contents/{+path}","compare_url":"https://api.github.com/repos/Tribler/tribler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tribler/tribler/merges","archive_url":"https://api.github.com/repos/Tribler/tribler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tribler/tribler/downloads","issues_url":"https://api.github.com/repos/Tribler/tribler/issues{/number}","pulls_url":"https://api.github.com/repos/Tribler/tribler/pulls{/number}","milestones_url":"https://api.github.com/repos/Tribler/tribler/milestones{/number}","notifications_url":"https://api.github.com/repos/Tribler/tribler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tribler/tribler/labels{/name}","releases_url":"https://api.github.com/repos/Tribler/tribler/releases{/id}","deployments_url":"https://api.github.com/repos/Tribler/tribler/deployments","created_at":"2013-02-25T14:51:58Z","updated_at":"2016-04-23T18:15:45Z","pushed_at":"2016-04-25T12:17:42Z","git_url":"git://github.com/Tribler/tribler.git","ssh_url":"git@github.com:Tribler/tribler.git","clone_url":"https://github.com/Tribler/tribler.git","svn_url":"https://github.com/Tribler/tribler","homepage":"http://www.tribler.org","size":131955,"stargazers_count":1858,"watchers_count":1858,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":240,"forks":198,"open_issues":240,"watchers":1858,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2038"},"html":{"href":"https://github.com/Tribler/tribler/pull/2038"},"issue":{"href":"https://api.github.com/repos/Tribler/tribler/issues/2038"},"comments":{"href":"https://api.github.com/repos/Tribler/tribler/issues/2038/comments"},"review_comments":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2038/comments"},"review_comment":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Tribler/tribler/pulls/2038/commits"},"statuses":{"href":"https://api.github.com/repos/Tribler/tribler/statuses/4de50b81f925b0f790ef0ddba156ca6ccbf20275"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"whirm","id":529494,"avatar_url":"https://avatars.githubusercontent.com/u/529494?v=3","gravatar_id":"","url":"https://api.github.com/users/whirm","html_url":"https://github.com/whirm","followers_url":"https://api.github.com/users/whirm/followers","following_url":"https://api.github.com/users/whirm/following{/other_user}","gists_url":"https://api.github.com/users/whirm/gists{/gist_id}","starred_url":"https://api.github.com/users/whirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whirm/subscriptions","organizations_url":"https://api.github.com/users/whirm/orgs","repos_url":"https://api.github.com/users/whirm/repos","events_url":"https://api.github.com/users/whirm/events{/privacy}","received_events_url":"https://api.github.com/users/whirm/received_events","type":"User","site_admin":false},"comments":96,"review_comments":40,"commits":2,"additions":957,"deletions":454,"changed_files":9}}