{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/1561","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/1561/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/1561/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/1561/events","html_url":"https://github.com/zulip/zulip/issues/1561","id":169814792,"number":1561,"title":"Remove up to 49 obsolete CSS classes","user":{"login":"showell","id":142908,"avatar_url":"https://avatars.githubusercontent.com/u/142908?v=3","gravatar_id":"","url":"https://api.github.com/users/showell","html_url":"https://github.com/showell","followers_url":"https://api.github.com/users/showell/followers","following_url":"https://api.github.com/users/showell/following{/other_user}","gists_url":"https://api.github.com/users/showell/gists{/gist_id}","starred_url":"https://api.github.com/users/showell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/showell/subscriptions","organizations_url":"https://api.github.com/users/showell/orgs","repos_url":"https://api.github.com/users/showell/repos","events_url":"https://api.github.com/users/showell/events{/privacy}","received_events_url":"https://api.github.com/users/showell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zulip/zulip/labels/bite%20size","name":"bite size","color":"bfe5bf"},{"url":"https://api.github.com/repos/zulip/zulip/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/zulip/zulip/labels/refactoring","name":"refactoring","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-07T20:33:06Z","updated_at":"2016-08-22T22:50:54Z","closed_at":null,"body":"The following CSS classes from `zulip.css` are probably, but not definitely, obsolete:\r\n\r\n```\r\n.actions_hovered\r\n.actions_link\r\n.bookend_tr\r\n.edit-profile\r\n.edit_content\r\n.hidden-filter\r\n.icon-vector-heart\r\n.label_for_text\r\n.loading_indicator_spinner\r\n.loading_indicator_text\r\n.logout\r\n.message-edit-tooltip-inner\r\n.message-pane\r\n.message-right\r\n.message_data\r\n.message_inline_image\r\n.messagebox-bottom\r\n.messagebox-bottom-colorblock\r\n.messages-collapse\r\n.messages-expand\r\n.open\r\n.pointer\r\n.position-relative\r\n.private_message\r\n.ps-scrollbar-y\r\n.ps-scrollbar-y-rail\r\n.root\r\n.sender_name-in-status\r\n.settings_committed\r\n.sidebar-nav\r\n.skinny-user-gravatar\r\n.sp-container\r\n.sp-palette-container\r\n.sp-preview\r\n.sp-replacer\r\n.sticky\r\n.stream\r\n.streamname\r\n.summary_colorblock\r\n.summary_row\r\n.summary_row_private_message\r\n.tiny\r\n.tooltip\r\n.user-with-mobile\r\n.user_idle\r\n.user_offline\r\n```\r\n\r\nWe should try to remove these from our CSS.  For each one the process is something like this:\r\n\r\n- grep the code to make sure it's not referenced\r\n- if it's a compound thing like `message-collapse`, see if you can find code that builds it up\r\n- do `git blame` on the zulip.css file to get some context on when the class was introduced\r\n\r\nIf you are 95% confident the class is really obsolete, submit a PR with just removing the one class, so it's easy to revert.\r\n\r\nIf the class is valid, but the code that refers to it is hard to track with grep, see if there is an easy fix to the code to make it more obvious that the class is used by either the JS code or our templates.\r\n\r\nOtherwise, update the ticket with any info you came up with in terms of tracking down the class."},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/241575280","html_url":"https://github.com/zulip/zulip/issues/1561#issuecomment-241575280","issue_url":"https://api.github.com/repos/zulip/zulip/issues/1561","id":241575280,"user":{"login":"showell","id":142908,"avatar_url":"https://avatars.githubusercontent.com/u/142908?v=3","gravatar_id":"","url":"https://api.github.com/users/showell","html_url":"https://github.com/showell","followers_url":"https://api.github.com/users/showell/followers","following_url":"https://api.github.com/users/showell/following{/other_user}","gists_url":"https://api.github.com/users/showell/gists{/gist_id}","starred_url":"https://api.github.com/users/showell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/showell/subscriptions","organizations_url":"https://api.github.com/users/showell/orgs","repos_url":"https://api.github.com/users/showell/repos","events_url":"https://api.github.com/users/showell/events{/privacy}","received_events_url":"https://api.github.com/users/showell/received_events","type":"User","site_admin":false},"created_at":"2016-08-22T22:50:54Z","updated_at":"2016-08-22T22:50:54Z","body":"Added the \"bite size\" label here.  Fixing all 49 of these is some work, but if folks want to take a nibble at a small task, you can try to pick one of these and track its git history with something like `git log -S` to see if something obviously got deprecated."}}
{"actor":{"display_login":"showell"}}