{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/58845711","id":58845711,"diff_hunk":"@@ -22,7 +22,12 @@\n  * <a href=\"http://logging.apache.org/log4j/1.2/index.html\">Apache Log4J</a>\n  * logger.\n  */\n-public class Log4JLoggerFactory extends InternalLoggerFactory {\n+public final class Log4JLoggerFactory extends InternalLoggerFactory {\n+\n+    public static final InternalLoggerFactory INSTANCE = new Log4JLoggerFactory();\n+\n+    private Log4JLoggerFactory() {","path":"common/src/main/java/io/netty/util/internal/logging/Log4JLoggerFactory.java","position":9,"original_position":9,"commit_id":"d9be9cf526cb82b1c8d8c644df45fdfd754f628c","original_commit_id":"d9be9cf526cb82b1c8d8c644df45fdfd754f628c","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"same as above","created_at":"2016-04-07T09:47:35Z","updated_at":"2016-04-07T09:47:35Z","html_url":"https://github.com/netty/netty/pull/5094#discussion_r58845711","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/5094","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/58845711"},"html":{"href":"https://github.com/netty/netty/pull/5094#discussion_r58845711"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/5094"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/5094","id":65590166,"html_url":"https://github.com/netty/netty/pull/5094","diff_url":"https://github.com/netty/netty/pull/5094.diff","patch_url":"https://github.com/netty/netty/pull/5094.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/5094","number":5094,"state":"open","locked":false,"title":"Make all InternalLoggerFactory implementations be singletons","user":{"login":"windie","id":4434300,"avatar_url":"https://avatars.githubusercontent.com/u/4434300?v=3","gravatar_id":"","url":"https://api.github.com/users/windie","html_url":"https://github.com/windie","followers_url":"https://api.github.com/users/windie/followers","following_url":"https://api.github.com/users/windie/following{/other_user}","gists_url":"https://api.github.com/users/windie/gists{/gist_id}","starred_url":"https://api.github.com/users/windie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windie/subscriptions","organizations_url":"https://api.github.com/users/windie/orgs","repos_url":"https://api.github.com/users/windie/repos","events_url":"https://api.github.com/users/windie/events{/privacy}","received_events_url":"https://api.github.com/users/windie/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIt's better to make all InternalLoggerFactory implementations be singletons according to the discussions in #5047\r\n\r\nModifications:\r\n\r\nMake all InternalLoggerFactory implementations be singletons and hide the construtors.\r\n\r\nResult:\r\n\r\nAll InternalLoggerFactory implementations be singletons.","created_at":"2016-04-07T08:17:10Z","updated_at":"2016-04-07T09:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d505d392846c99976694e7ade508a93df3cded98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/5094/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/5094/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/5094/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/d9be9cf526cb82b1c8d8c644df45fdfd754f628c","head":{"label":"windie:log-singleton","ref":"log-singleton","sha":"d9be9cf526cb82b1c8d8c644df45fdfd754f628c","user":{"login":"windie","id":4434300,"avatar_url":"https://avatars.githubusercontent.com/u/4434300?v=3","gravatar_id":"","url":"https://api.github.com/users/windie","html_url":"https://github.com/windie","followers_url":"https://api.github.com/users/windie/followers","following_url":"https://api.github.com/users/windie/following{/other_user}","gists_url":"https://api.github.com/users/windie/gists{/gist_id}","starred_url":"https://api.github.com/users/windie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windie/subscriptions","organizations_url":"https://api.github.com/users/windie/orgs","repos_url":"https://api.github.com/users/windie/repos","events_url":"https://api.github.com/users/windie/events{/privacy}","received_events_url":"https://api.github.com/users/windie/received_events","type":"User","site_admin":false},"repo":{"id":48527199,"name":"netty","full_name":"windie/netty","owner":{"login":"windie","id":4434300,"avatar_url":"https://avatars.githubusercontent.com/u/4434300?v=3","gravatar_id":"","url":"https://api.github.com/users/windie","html_url":"https://github.com/windie","followers_url":"https://api.github.com/users/windie/followers","following_url":"https://api.github.com/users/windie/following{/other_user}","gists_url":"https://api.github.com/users/windie/gists{/gist_id}","starred_url":"https://api.github.com/users/windie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windie/subscriptions","organizations_url":"https://api.github.com/users/windie/orgs","repos_url":"https://api.github.com/users/windie/repos","events_url":"https://api.github.com/users/windie/events{/privacy}","received_events_url":"https://api.github.com/users/windie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/windie/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/windie/netty","forks_url":"https://api.github.com/repos/windie/netty/forks","keys_url":"https://api.github.com/repos/windie/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windie/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windie/netty/teams","hooks_url":"https://api.github.com/repos/windie/netty/hooks","issue_events_url":"https://api.github.com/repos/windie/netty/issues/events{/number}","events_url":"https://api.github.com/repos/windie/netty/events","assignees_url":"https://api.github.com/repos/windie/netty/assignees{/user}","branches_url":"https://api.github.com/repos/windie/netty/branches{/branch}","tags_url":"https://api.github.com/repos/windie/netty/tags","blobs_url":"https://api.github.com/repos/windie/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windie/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windie/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/windie/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windie/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/windie/netty/languages","stargazers_url":"https://api.github.com/repos/windie/netty/stargazers","contributors_url":"https://api.github.com/repos/windie/netty/contributors","subscribers_url":"https://api.github.com/repos/windie/netty/subscribers","subscription_url":"https://api.github.com/repos/windie/netty/subscription","commits_url":"https://api.github.com/repos/windie/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/windie/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/windie/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/windie/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/windie/netty/contents/{+path}","compare_url":"https://api.github.com/repos/windie/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windie/netty/merges","archive_url":"https://api.github.com/repos/windie/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windie/netty/downloads","issues_url":"https://api.github.com/repos/windie/netty/issues{/number}","pulls_url":"https://api.github.com/repos/windie/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/windie/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/windie/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windie/netty/labels{/name}","releases_url":"https://api.github.com/repos/windie/netty/releases{/id}","deployments_url":"https://api.github.com/repos/windie/netty/deployments","created_at":"2015-12-24T05:50:59Z","updated_at":"2016-02-13T03:31:55Z","pushed_at":"2016-04-07T08:17:54Z","git_url":"git://github.com/windie/netty.git","ssh_url":"git@github.com:windie/netty.git","clone_url":"https://github.com/windie/netty.git","svn_url":"https://github.com/windie/netty","homepage":"http://netty.io/","size":43292,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.1"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"e053b96b5c81922e1972ac2e304746a84af459bb","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2016-04-07T03:07:51Z","pushed_at":"2016-04-07T08:17:11Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":58478,"stargazers_count":6539,"watchers_count":6539,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3318,"mirror_url":null,"open_issues_count":316,"forks":3318,"open_issues":316,"watchers":6539,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/5094"},"html":{"href":"https://github.com/netty/netty/pull/5094"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/5094"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/5094/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/5094/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/5094/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/d9be9cf526cb82b1c8d8c644df45fdfd754f628c"}}}}