{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/83751415","pull_request_review_id":4574383,"id":83751415,"diff_hunk":"@@ -58,4 +90,147 @@\n     </Copy>\n   </Target>\n \n+  <Target Name=\"CopyNonWindowsDependecyToCoreRoot\"","path":"tests/publishdependency.targets","position":62,"original_position":62,"commit_id":"69ab16ac55d423935dd40c12237903b0c3a0c170","original_commit_id":"69ab16ac55d423935dd40c12237903b0c3a0c170","user":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"body":"I believe you can pass in with '@' symbol would ensure the list can be passed in as a property and then use '%' inside to batch operate.","created_at":"2016-10-17T22:51:25Z","updated_at":"2016-10-17T22:51:25Z","html_url":"https://github.com/dotnet/coreclr/pull/7628#discussion_r83751415","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7628","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/83751415"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7628#discussion_r83751415"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7628"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7628","id":89465162,"html_url":"https://github.com/dotnet/coreclr/pull/7628","diff_url":"https://github.com/dotnet/coreclr/pull/7628.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7628.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7628","number":7628,"state":"open","locked":false,"title":"Build tests against packages & produce Core_Root for arbitrary OS","user":{"login":"wtgodbe","id":14283640,"avatar_url":"https://avatars.githubusercontent.com/u/14283640?v=3","gravatar_id":"","url":"https://api.github.com/users/wtgodbe","html_url":"https://github.com/wtgodbe","followers_url":"https://api.github.com/users/wtgodbe/followers","following_url":"https://api.github.com/users/wtgodbe/following{/other_user}","gists_url":"https://api.github.com/users/wtgodbe/gists{/gist_id}","starred_url":"https://api.github.com/users/wtgodbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtgodbe/subscriptions","organizations_url":"https://api.github.com/users/wtgodbe/orgs","repos_url":"https://api.github.com/users/wtgodbe/repos","events_url":"https://api.github.com/users/wtgodbe/events{/privacy}","received_events_url":"https://api.github.com/users/wtgodbe/received_events","type":"User","site_admin":false},"body":"This is a pretty substantial change, which will allow us to build tests against packages in CoreCLR, as well as to build a useable Coreoverlay for any OS we support (this is the test overlay directory containing all the binaries that tests need to run against). Currently, an end-to-end non-Windows test run looks like the following:\r\n\r\n- Build Product on Windows\r\n- Build Tests on Windows\r\n- Copy Product & Tests to non-Windows\r\n- Build CoreCLR Product on non-Windows\r\n- Build CoreFX Product non non-Windows\r\n- Call runtest.sh, which will gather binaries from both builds of CoreCLR & the build of CoreFX, then run tests against those binaries\r\n\r\nAfter this change, the same test run will look like the following:\r\n\r\n- Build tests on Windows\r\n- Copy tests & Coreoverlay to non-Windows\r\n- Run tests\r\n\r\nThis change does not remove the ability to run tests the old way (though that may be coming later), it just adds the option of doing it in the new way. Such a test run would involve the following commands:\r\n\r\n**Windows test run**\r\n\r\n`./build-tests.cmd buildagainstpackages`\r\n`./tests/runtest.cmd AgainstPackages`\r\n\r\n**Non-Windows test run**\r\n\r\n`./build-tests.cmd buildagainstpackages runtimed <Insert target Runtime ID here>`\r\n`(Copy tests & coreoverlay to non-windows)`\r\n`./tests/runtest.sh --coreoverlaydir=\"coreoverlay dir\" --testRootDir=\"test root dir\"`\r\n\r\nThis change will also require some minor changes to pipebuild once it goes in (in publish-packages.sh/cmd, we will need to change \"/p:ContainerName\" to \"-Container=\"\r\n\r\nCC @gkhanna79 @dotnet/coreclr-contrib ","created_at":"2016-10-14T22:31:58Z","updated_at":"2016-10-17T22:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"560bec3fb931af73f175d72db75017a4353f2af8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7628/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7628/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7628/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/69ab16ac55d423935dd40c12237903b0c3a0c170","head":{"label":"wtgodbe:HelixFinal","ref":"HelixFinal","sha":"69ab16ac55d423935dd40c12237903b0c3a0c170","user":{"login":"wtgodbe","id":14283640,"avatar_url":"https://avatars.githubusercontent.com/u/14283640?v=3","gravatar_id":"","url":"https://api.github.com/users/wtgodbe","html_url":"https://github.com/wtgodbe","followers_url":"https://api.github.com/users/wtgodbe/followers","following_url":"https://api.github.com/users/wtgodbe/following{/other_user}","gists_url":"https://api.github.com/users/wtgodbe/gists{/gist_id}","starred_url":"https://api.github.com/users/wtgodbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtgodbe/subscriptions","organizations_url":"https://api.github.com/users/wtgodbe/orgs","repos_url":"https://api.github.com/users/wtgodbe/repos","events_url":"https://api.github.com/users/wtgodbe/events{/privacy}","received_events_url":"https://api.github.com/users/wtgodbe/received_events","type":"User","site_admin":false},"repo":{"id":60204078,"name":"coreclr","full_name":"wtgodbe/coreclr","owner":{"login":"wtgodbe","id":14283640,"avatar_url":"https://avatars.githubusercontent.com/u/14283640?v=3","gravatar_id":"","url":"https://api.github.com/users/wtgodbe","html_url":"https://github.com/wtgodbe","followers_url":"https://api.github.com/users/wtgodbe/followers","following_url":"https://api.github.com/users/wtgodbe/following{/other_user}","gists_url":"https://api.github.com/users/wtgodbe/gists{/gist_id}","starred_url":"https://api.github.com/users/wtgodbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtgodbe/subscriptions","organizations_url":"https://api.github.com/users/wtgodbe/orgs","repos_url":"https://api.github.com/users/wtgodbe/repos","events_url":"https://api.github.com/users/wtgodbe/events{/privacy}","received_events_url":"https://api.github.com/users/wtgodbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wtgodbe/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/wtgodbe/coreclr","forks_url":"https://api.github.com/repos/wtgodbe/coreclr/forks","keys_url":"https://api.github.com/repos/wtgodbe/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wtgodbe/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wtgodbe/coreclr/teams","hooks_url":"https://api.github.com/repos/wtgodbe/coreclr/hooks","issue_events_url":"https://api.github.com/repos/wtgodbe/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/wtgodbe/coreclr/events","assignees_url":"https://api.github.com/repos/wtgodbe/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/wtgodbe/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/wtgodbe/coreclr/tags","blobs_url":"https://api.github.com/repos/wtgodbe/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wtgodbe/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wtgodbe/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/wtgodbe/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wtgodbe/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/wtgodbe/coreclr/languages","stargazers_url":"https://api.github.com/repos/wtgodbe/coreclr/stargazers","contributors_url":"https://api.github.com/repos/wtgodbe/coreclr/contributors","subscribers_url":"https://api.github.com/repos/wtgodbe/coreclr/subscribers","subscription_url":"https://api.github.com/repos/wtgodbe/coreclr/subscription","commits_url":"https://api.github.com/repos/wtgodbe/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/wtgodbe/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/wtgodbe/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/wtgodbe/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/wtgodbe/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/wtgodbe/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wtgodbe/coreclr/merges","archive_url":"https://api.github.com/repos/wtgodbe/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wtgodbe/coreclr/downloads","issues_url":"https://api.github.com/repos/wtgodbe/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/wtgodbe/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/wtgodbe/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/wtgodbe/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wtgodbe/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/wtgodbe/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/wtgodbe/coreclr/deployments","created_at":"2016-06-01T19:14:11Z","updated_at":"2016-06-01T19:15:39Z","pushed_at":"2016-10-17T20:49:57Z","git_url":"git://github.com/wtgodbe/coreclr.git","ssh_url":"git@github.com:wtgodbe/coreclr.git","clone_url":"https://github.com/wtgodbe/coreclr.git","svn_url":"https://github.com/wtgodbe/coreclr","homepage":"http://dotnet.github.io/","size":110559,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"27c00018be793ad5cb9d7b2d2d4fcae497963ccc","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-10-17T13:18:16Z","pushed_at":"2016-10-17T22:49:16Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":125557,"stargazers_count":6964,"watchers_count":6964,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1688,"mirror_url":null,"open_issues_count":996,"forks":1688,"open_issues":996,"watchers":6964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7628"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7628"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7628"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7628/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7628/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7628/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/69ab16ac55d423935dd40c12237903b0c3a0c170"}}}}
{"actor":{"display_login":"ramarag"}}