{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/60150184","id":60150184,"diff_hunk":"@@ -153,7 +152,6 @@ def test_conv3d(mode=mode_without_gpu, shared=theano.tensor._shared):\n     newconv3d = theano.function([], [],\n                                 updates={s_output: out},\n                                 mode=mode)\n-    check_diagonal_subtensor_view_traces(newconv3d)","path":"theano/tensor/nnet/tests/test_conv3d2d.py","position":27,"original_position":14,"commit_id":"534ede0139230428896d609bdc31455223cda10d","original_commit_id":"534ede0139230428896d609bdc31455223cda10d","user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"body":"From the comment that says \"patched implementation ... with Tf=1\", I guess it is normal that these Ops are not there, but I'll have a quick look.","created_at":"2016-04-18T23:09:33Z","updated_at":"2016-04-18T23:09:33Z","html_url":"https://github.com/Theano/Theano/pull/4376#discussion_r60150184","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4376","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/60150184"},"html":{"href":"https://github.com/Theano/Theano/pull/4376#discussion_r60150184"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4376"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4376","id":66524831,"html_url":"https://github.com/Theano/Theano/pull/4376","diff_url":"https://github.com/Theano/Theano/pull/4376.diff","patch_url":"https://github.com/Theano/Theano/pull/4376.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4376","number":4376,"state":"open","locked":false,"title":"[WIP] Use check_stack_trace helper function in tensor/nnet/tests/","user":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"body":"It needs #4290 to be merged first. I will do a rebase once done.\r\nI have only modified the asserts that were already written, I have not added any.\r\nThere are several cases I am not sure about, for which I use ops_to_check='all'.\r\n\r\nRelated ticket: #4114 @lamblin.","created_at":"2016-04-14T17:42:59Z","updated_at":"2016-04-18T23:09:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc49419f02845b9c1feaa6053b89642bde80d7f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4376/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4376/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4376/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/534ede0139230428896d609bdc31455223cda10d","head":{"label":"adbrebs:fix_stack_check_nnet","ref":"fix_stack_check_nnet","sha":"534ede0139230428896d609bdc31455223cda10d","user":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"repo":{"id":29032332,"name":"Theano","full_name":"adbrebs/Theano","owner":{"login":"adbrebs","id":6939554,"avatar_url":"https://avatars.githubusercontent.com/u/6939554?v=3","gravatar_id":"","url":"https://api.github.com/users/adbrebs","html_url":"https://github.com/adbrebs","followers_url":"https://api.github.com/users/adbrebs/followers","following_url":"https://api.github.com/users/adbrebs/following{/other_user}","gists_url":"https://api.github.com/users/adbrebs/gists{/gist_id}","starred_url":"https://api.github.com/users/adbrebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbrebs/subscriptions","organizations_url":"https://api.github.com/users/adbrebs/orgs","repos_url":"https://api.github.com/users/adbrebs/repos","events_url":"https://api.github.com/users/adbrebs/events{/privacy}","received_events_url":"https://api.github.com/users/adbrebs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adbrebs/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/adbrebs/Theano","forks_url":"https://api.github.com/repos/adbrebs/Theano/forks","keys_url":"https://api.github.com/repos/adbrebs/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adbrebs/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adbrebs/Theano/teams","hooks_url":"https://api.github.com/repos/adbrebs/Theano/hooks","issue_events_url":"https://api.github.com/repos/adbrebs/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/adbrebs/Theano/events","assignees_url":"https://api.github.com/repos/adbrebs/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/adbrebs/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/adbrebs/Theano/tags","blobs_url":"https://api.github.com/repos/adbrebs/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adbrebs/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adbrebs/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/adbrebs/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adbrebs/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/adbrebs/Theano/languages","stargazers_url":"https://api.github.com/repos/adbrebs/Theano/stargazers","contributors_url":"https://api.github.com/repos/adbrebs/Theano/contributors","subscribers_url":"https://api.github.com/repos/adbrebs/Theano/subscribers","subscription_url":"https://api.github.com/repos/adbrebs/Theano/subscription","commits_url":"https://api.github.com/repos/adbrebs/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/adbrebs/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/adbrebs/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/adbrebs/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/adbrebs/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/adbrebs/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adbrebs/Theano/merges","archive_url":"https://api.github.com/repos/adbrebs/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adbrebs/Theano/downloads","issues_url":"https://api.github.com/repos/adbrebs/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/adbrebs/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/adbrebs/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/adbrebs/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adbrebs/Theano/labels{/name}","releases_url":"https://api.github.com/repos/adbrebs/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/adbrebs/Theano/deployments","created_at":"2015-01-09T19:45:48Z","updated_at":"2016-01-22T15:17:00Z","pushed_at":"2016-04-18T22:47:36Z","git_url":"git://github.com/adbrebs/Theano.git","ssh_url":"git@github.com:adbrebs/Theano.git","clone_url":"https://github.com/adbrebs/Theano.git","svn_url":"https://github.com/adbrebs/Theano","homepage":"http://www.deeplearning.net/software/theano","size":52330,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"189b1352a9e2eceae0ea0cdb9d9ee787d322409d","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-04-18T21:59:08Z","pushed_at":"2016-04-18T22:47:37Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":72283,"stargazers_count":3529,"watchers_count":3529,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1281,"mirror_url":null,"open_issues_count":642,"forks":1281,"open_issues":642,"watchers":3529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4376"},"html":{"href":"https://github.com/Theano/Theano/pull/4376"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4376"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4376/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4376/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4376/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/534ede0139230428896d609bdc31455223cda10d"}}}}