{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5085","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5085/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5085/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5085/events","html_url":"https://github.com/nodejs/node/issues/5085","id":131476445,"number":5085,"title":"AIX fs watch improvements ","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"labels":[{"id":482979531,"url":"https://api.github.com/repos/nodejs/node/labels/aix","name":"aix","color":"466BB0","default":false},{"id":155435785,"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":482979644,"url":"https://api.github.com/repos/nodejs/node/labels/ppc","name":"ppc","color":"466BB0","default":false}],"state":"open","locked":false,"assignee":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars.githubusercontent.com/u/9373002?v=3","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-02-04T21:17:12Z","updated_at":"2016-11-25T08:36:47Z","closed_at":null,"body":"Currently  the AIX fs watch implementation requires some prior configuration and is not necessarily straight forward to use on AIX. \n\nThis issue is to track work to improve the implementation or better document to make it easier to use.\n\nCurrently the following tests fail in the CI due to fs watch not being configured:\n\nhttps://ci.nodejs.org/job/node-test-commit-aix/33/nodes=aix61-ppc64/console\n\n<PRE>\nnot ok 4 test-async-wrap-check-providers.js\n# fs.js:1329\n#     throw error;\n#     ^\n# \n# Error: watch /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js ENOSYS\n#     at exports._errnoException (util.js:859:11)\n#     at FSWatcher.start (fs.js:1327:19)\n#     at Object.fs.watch (fs.js:1355:11)\n#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js:38:4)\n#     at Module._compile (module.js:417:34)\n#     at Object.Module._extensions..js (module.js:426:10)\n#     at Module.load (module.js:357:32)\n#     at Function.Module._load (module.js:314:12)\n#     at Function.Module.runMain (module.js:451:10)\n#     at startup (node.js:139:18)\n  ---\n  duration_ms: 0.448\n\nnot ok 4 test-async-wrap-check-providers.js\n# fs.js:1329\n#     throw error;\n#     ^\n# \n# Error: watch /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js ENOSYS\n#     at exports._errnoException (util.js:859:11)\n#     at FSWatcher.start (fs.js:1327:19)\n#     at Object.fs.watch (fs.js:1355:11)\n#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-async-wrap-check-providers.js:38:4)\n#     at Module._compile (module.js:417:34)\n#     at Object.Module._extensions..js (module.js:426:10)\n#     at Module.load (module.js:357:32)\n#     at Function.Module._load (module.js:314:12)\n#     at Function.Module.runMain (module.js:451:10)\n#     at startup (node.js:139:18)\n  ---\n  duration_ms: 0.448\n\nnot ok 980 test-fs-watch.js\n# assert.js:324\n#     throw actual;\n#     ^\n# \n# Error: watch /home/iojs/node-tmp/tmp.0/watch.txt ENOSYS\n#     at exports._errnoException (util.js:859:11)\n#     at FSWatcher.start (fs.js:1327:19)\n#     at Object.fs.watch (fs.js:1355:11)\n#     at /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-fs-watch.js:41:24\n#     at Function._throws (assert.js:306:5)\n#     at Function.assert.doesNotThrow (assert.js:337:11)\n#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/sequential/test-fs-watch.js:39:8)\n#     at Module._compile (module.js:417:34)\n#     at Object.Module._extensions..js (module.js:426:10)\n#     at Module.load (module.js:357:32)\n  ---\n  duration_ms: 1.147\n  ...\n\n</PRE>\n\n\nThe short term plan will be to exclude these to get the CI to a green state while we work in parallel on the resolution\n- So we don't forget before we close this we need to revert #5187 including re-enabling the tests and undoing the change to test/parallel/test-async-wrap-check-providers.js\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/262905687","html_url":"https://github.com/nodejs/node/issues/5085#issuecomment-262905687","issue_url":"https://api.github.com/repos/nodejs/node/issues/5085","id":262905687,"user":{"login":"gireeshpunathil","id":6447530,"avatar_url":"https://avatars.githubusercontent.com/u/6447530?v=3","gravatar_id":"","url":"https://api.github.com/users/gireeshpunathil","html_url":"https://github.com/gireeshpunathil","followers_url":"https://api.github.com/users/gireeshpunathil/followers","following_url":"https://api.github.com/users/gireeshpunathil/following{/other_user}","gists_url":"https://api.github.com/users/gireeshpunathil/gists{/gist_id}","starred_url":"https://api.github.com/users/gireeshpunathil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gireeshpunathil/subscriptions","organizations_url":"https://api.github.com/users/gireeshpunathil/orgs","repos_url":"https://api.github.com/users/gireeshpunathil/repos","events_url":"https://api.github.com/users/gireeshpunathil/events{/privacy}","received_events_url":"https://api.github.com/users/gireeshpunathil/received_events","type":"User","site_admin":false},"created_at":"2016-11-25T08:36:47Z","updated_at":"2016-11-25T08:36:47Z","body":"Performed a detailed comparison between three platforms w.r.t watch behavior.\r\n\r\nOS X behavior:\r\n\r\n```\r\n#./a.out\r\ninode #: 6055885\r\n#touch a.txt\r\n* change\r\n* change\r\n#echo d > a.txt\r\n* change\r\n* change\r\n#vi a.txt, followed by save and exit\r\n* rename\r\n* rename\r\n#./a.out\r\ninode #: 6055916\r\n#\r\n\r\n```\r\nsince then, the file is no more watchable, as the inode is changed on save and exit.\r\n\r\nLinux behavior:\r\n\r\n```\r\n# ./a.out\r\ninode #: 8283484\r\n# touch a.txt\r\n* change\r\n# echo d > a.txt\r\n* change\r\n# vi a.txt, followed by save and exit\r\n* rename\r\n* change\r\n* rename\r\n* rename\r\n# ./a.out\r\ninode #: 8283483\r\n\r\n```\r\nsince then, the file is no more watchable, as the inode is changed on save and exit.\r\n\r\nAIX behavior:\r\n\r\n```\r\n# ./a.out\r\ninode #: 333\r\n# touch a.txt\r\n! no event produced\r\n# echo d > a.txt\r\n* change\r\n* change\r\n# vi a.txt, followed by save and exit\r\n* change\r\n# ./a.out\r\ninode #: 333\r\n\r\n```\r\nthe file can be continued to be watched, as the inode is not changed. I added large amount of text into to see if the amount of blocks causes a new inode to be created, but it is not to be.\r\n"}}
{"actor":{"display_login":"gireeshpunathil"}}