{"push_id":1032135736,"size":44,"distinct_size":44,"ref":"refs/heads/master","head":"515e2d7c9d2b5afe3f7c0618596f1d9e5e699315","before":"da21ad065939d0789bb90d8fd6d088b781688aa3","commits":[{"sha":"ddfd58a13ce8b56746e01f078175129aceea7f00","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":"Bug 16036: Making basket actions buttons\n\nTo test:\n1) Go to Acqui -> do a vendor search\n2) Confirm actions 'View' and 'Add to basket' are now buttons and behave as\n   expected\n\nSponsored-by: Catalyst IT\nSigned-off-by: Frédéric Demians <f.demians@tamil.fr>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/ddfd58a13ce8b56746e01f078175129aceea7f00"},{"sha":"9ecb394a8036f916bfc57ad696345cefcc6b9131","author":{"email":"9116c67f61a8025cb8cf35425d522a2ad0f46d71@myacpl.org","name":"Owen Leonard"},"message":"Bug 16036 [Follow-up] Making basket actions buttons\n\nThis trivial follow-up adds an \"actions\" class to the table cell\ncontaining the new buttons. In conjunction with the style update in Bug\n16048, this will prevent the buttons from wrapping at narrow browser\nwindow widths.\n\nTo test, apply the patch for Bug 16048 and search for a vendor in\nAcquisitions which has at least one open basket.\n\nConfirm that the \"View\" and \"Add to basket\" buttons look correct and do\nnot wrap when you make your browser window narrower.\n\nSigned-off-by: Aleisha <aleishaamohia@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/9ecb394a8036f916bfc57ad696345cefcc6b9131"},{"sha":"37ee31318063272e258c3762634fe8a676e18622","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":"Bug 15995: Making libraries actions buttons\n\nTo test:\n\n1) Go to Administration -> Libraries and Groups\n2) Confirm that the actions 'Edit' and 'Delete' are now buttons for BOTH\n   tables under one column 'Actions' and buttons behave as expected.\n\nSponsored-by: Catalyst IT\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/37ee31318063272e258c3762634fe8a676e18622"},{"sha":"c21a2917476b874e2640593dd12cfc4d3e925598","author":{"email":"9116c67f61a8025cb8cf35425d522a2ad0f46d71@myacpl.org","name":"Owen Leonard"},"message":"Bug 15995 [Follow-up] Making libraries actions buttons\n\nThis trivial follow-up adds an \"actions\" class to the table cell\ncontaining the new buttons. In conjunction with the style update in Bug\n16048, this will prevent the buttons from wrapping at narrow browser\nwindow widths.\n\nTo test, apply the patch for Bug 16048 and go to Administration ->\nLibraries and Groups.\n\nConfirm that the \"Edit\" and \"Delete\" buttons do not wrap even at narrow\nbrowser window widths.\n\nSigned-off-by: Aleisha <aleishaamohia@hotmail.com>\nYou forgot to add the class to one of the tables, but I have added it\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/c21a2917476b874e2640593dd12cfc4d3e925598"},{"sha":"2e7d614997f1f3d16d43dd5b3aba592dd7de8ca8","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":"Bug 15993: Making currency actions buttons\n\nTo test:\n\n1) Go to Administration -> Currencies and exchange rates\n2) Confirm that the actions 'Edit' and 'Delete' are now buttons and behave as expected.\n\nSponsored-by: Catalyst IT\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/2e7d614997f1f3d16d43dd5b3aba592dd7de8ca8"},{"sha":"9752d147964e1e59b60ceb2f00fa2de25d2c3f59","author":{"email":"9116c67f61a8025cb8cf35425d522a2ad0f46d71@myacpl.org","name":"Owen Leonard"},"message":"Bug 15993 [Follow-up] Making currency actions buttons\n\nThis trivial follow-up adds an \"actions\" class to the table cell\ncontaining the new buttons. In conjunction with the style update in Bug\n16048, this will prevent the buttons from wrapping at narrow browser\nwindow widths.\n\nTo test, apply the patch for Bug 16048 and go to Administration ->\nCurrencies and exchange rates.\n\nIn the table of currencies, confirm that the \"Edit\" and \"Delete\" buttons\nare not stacked one on top of the other even at narrow browser window\nwidths.\n\nSigned-off-by: Aleisha <aleishaamohia@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/9752d147964e1e59b60ceb2f00fa2de25d2c3f59"},{"sha":"6638d3f73f3395f936868fcdab2b82b0c7f15860","author":{"email":"5bd78819bb537c060dbb40c201eca07a4ff6ad0c@hotmail.com","name":"Aleisha"},"message":"Bug 15990: Making record matching rules actions buttons\n\nTo test:\n\n1) Go to Administration -> Record matching rules\n2) Confirm that the actions 'Edit' and 'Delete' are not buttons and behave as expected.\n\nSponsored-by: Catalyst IT\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/6638d3f73f3395f936868fcdab2b82b0c7f15860"},{"sha":"a5519b36a8b232066bdde3a94733619eaf56eb62","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 15990: (follow-up) Making record matching rules actions buttons\n\nAdds the actions class to the td elt to keep the buttons next to each\nother.\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/a5519b36a8b232066bdde3a94733619eaf56eb62"},{"sha":"d003b2453268036dfbbc02248e94f4571f2ce71e","author":{"email":"426f625364c21a69b07917eef7216c63bee01f3a@veron.ch","name":"Marc Véron"},"message":"Bug 16089: Acquisitions -> Invoice broken by Bug 15084\n\nTo test:\n- Reproduce error described in first comment.\n- Apply patch\n- Try to reproduce error. Page will display as expected.\n\nSigned-off-by: Owen Leonard <oleonard@myacpl.org>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/d003b2453268036dfbbc02248e94f4571f2ce71e"},{"sha":"52c77ad9145fd17b6cd263e3981dd59aad9e5b76","author":{"email":"426f625364c21a69b07917eef7216c63bee01f3a@veron.ch","name":"Marc Véron"},"message":"Bug 16089: (Follow up) Display currency symbol properly\n\nThis patch fixes the display of the currency symbol on invoice.tt\n\nSee comment #5\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/52c77ad9145fd17b6cd263e3981dd59aad9e5b76"},{"sha":"cfa76a35771bb5035e51ff70f8b35439a77cac2a","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 16073: Fix software error in circulation.pl\n\nCan't call method \"guarantor\" on an undefined value at\n/home/koha/src/circ/circulation.pl line 588.\n at /home/koha/src/circ/circulation.pl line 673\n\nIntroduced by bug 15656\n\nTest plan:\nJust trigger circ/circulation.pl\n\nSigned-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>\nTriggered circ/circulation.pl - nothing exploded, and error is gone\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/cfa76a35771bb5035e51ff70f8b35439a77cac2a"},{"sha":"8d64bb9eb0555983936077b5fab4ca1a648b6871","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 16073: (follow-up) Fix software error in circulation.pl\n\nDo not crash if the patron does not exist.\n\nTest plan:\nAccess circ/circulation.pl?borrowernumber=42424242\nyou should get an error without this patch\nWith this patch, you will get an empty patron detail page (should be\nfixed in another patch, but this behavior exists for a while)\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/8d64bb9eb0555983936077b5fab4ca1a648b6871"},{"sha":"4a3404594ff326e0babb8b7bee8e65f5646ff9f9","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 15163: Do not erase patron attributes if limited to another library\n\nThe patron attributes displayed on editing a patron are not displayed if\nlimited to another library.\n\nC4::Members::Attributes::SetBorrowerAttributes will now only delete attributes\nthe librarian is editing.\nSetBorrowerAttributes takes a new $no_branch_limit parameter. If set,\nthe branch limitations have not effect and all attributes are deleted\n(same behavior as before this patch).\n\nTest plan:\n1/ Create 2 patron attributes, without branch limitations.\n2/ Edit a patron and set a value for these attributes\n3/ Limit a patron attributes to a library (one you are not logged in\nwith).\n4/ Edit again the patron.\n=> You should not see the limited attributes\n5/ Edit the patron attributes and remove the branch limitation\n=> Without this patch, it has been removed from the database and is not\ndisplayed anymore.\n=> With this patch, you should see it.\n\nSigned-off-by: Jesse Weaver <jweaver@bywatersolutions.com>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/4a3404594ff326e0babb8b7bee8e65f5646ff9f9"},{"sha":"7aedcf643e6f7793b4ebf55b1c7cdec7ec04a25d","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 16082: Display a friendly \"patron does not exist\" message if that's the case - circulation.pl\n\nThe major part of pages you can access from a patron detail page (menu)\ndoes not take into consideration the 'patron does not exist' case.\nIf the borrowernumber is linked to a deleted patron, a friendly message\nshould be displayed instead of an empty patron detail page.\n\nTest plan:\nGo on circ/circulation.pl?borrowernumber=424242\nand   circ/circulation.pl?borrowernumber=424242&batch=1\nNotice the difference before and after this patch\n\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/7aedcf643e6f7793b4ebf55b1c7cdec7ec04a25d"},{"sha":"99f2feeed94cb88bb14653231735f35c0787cb27","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 16015: Restore the ability to delete a group of libraries\n\nIf a group of libraries is linked to at least 1 library, the group\ncannot be delete and the librarian should get a warning message.\nBut if no libraries are linked, the deletion should be allowed.\nSince bug 15294 this behavior is broken: The deletion is always blocked:\n\"This library category cannot be deleted. 0 libraries are still using\nit\", hum...\n\nTest plan:\nCreate a group of libraries, delete it\n\nSigned-off-by: Srdjan <srdjan@catalyst.net.nz>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/99f2feeed94cb88bb14653231735f35c0787cb27"},{"sha":"ec3387185dc9d388bf586abd84cfbba2f3153215","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 16010: follow-up of 15381 - FIX merge_authorities migration script\n\nCaused by commit 7e70202d34d75f988fbaea9b911347417c203aac\n    Bug 15381: Remove GetAuthType and GetAuthTypeCode\n\nIf you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2\nyou will get:\nCan't locate object method \"authtypecode\" via package \"1\" (perhaps you forgot to load \"1\"?)\n at misc/migration_tools/merge_authority.pl line 58.\n\nGetAuthority does not return a Koha::Authority but a MARC::Record:\nthere is no authtype code method!\n\nTest plan:\nperl misc/migration_tools/merge_authority.pl -f X -t Y\nShould not return any error.\nNote that if the authid X or Y does not exist, the script will die.\n\nSigned-off-by: Frédéric Demians <f.demians@tamil.fr>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/ec3387185dc9d388bf586abd84cfbba2f3153215"},{"sha":"6c1b39b4cbceb1a414a91865e15612385c2eb5b7","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 16095: Remove target=\"_blank\" when a link refer to an external link\n\nIf you click on a link that opens a new tab/window to another site, that tab\nhas access to the original window through JavaScript. The browsing context is\nrelated, even if the domains are totally different.\n\nThe tab retains access to the original window's object via window.opener, even\nif you navigate to another page or domain, in the new or original window.\nAccess to the Window object means the new window can use Window.location to\nopen a different URL in the original window, perfect for phishing attacks.\n\nDepending on the site's Same-Origin Policy settings, the new window may have\naccess to other parts of the original window's DOM as well.\n\nAny  'A HREF' that contains a target of of '_blank' or '_new' or a fixed name\nis vulnerable. Previous security best practice often suggested creating a random\nfixed name for an unpredictable namespace - that won't help with this problem!\nTargets of '_self' and '_parent' are safe.\n\nWe do not use _new (at first glance) but several _blank. Some are used\nto refer internal url, we do not need to update or remove them. Others\nare used to satisfy OPACURLOpenInNewWindow, in these case, we should add\nthe rel=\"noreferrer\" attribute to the a tags.\nIn other cases, we can simply remove them and let the users discover\nthat a mouse has more than one button (we are in 2016, they can do it!)\n\nSigned-off-by: Chris <chrisc@catalyst.net.nz>\n\nSigned-off-by: Jesse Weaver <jweaver@bywatersolutions.com>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/6c1b39b4cbceb1a414a91865e15612385c2eb5b7"},{"sha":"f1e156453a1bc636914bc5c969e1665d7108cb95","author":{"email":"90effa772b5c8a7a3420e6b7ea56e265888c5743@bugs.koha-community.org","name":"Jonathan Druart"},"message":"Bug 15840: Catch errors if userid already exists when importing patrons\n\nImport borrowers tool explodes if userid already exists. This error\nshould be caught to avoid the script to explodes.\n\nTEST PLAN\n---------\n1) back up DB\n2) drop DB, create empty DB\n3) Apply patch 15842\n4) web install all the sample data\n5) login as system user and import patron data\n   -- sample provided to trigger error.\n   -- you will get a DBIx::class exception\n      \"Duplicate entry ' for key 'userid'\"\n6) Apply this patch\n7) Repeat steps 2-5\n   -- patrons won't be inserted but an error\n      will be nicely displayed in the error list.\n8) run koha qa test tools\n\nNote that it would be easy to insert the patrons anyway and generate a\nuserid based on the surname and firstname.\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Katrin Fischer <katrin.fischer.83@web.de>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/f1e156453a1bc636914bc5c969e1665d7108cb95"},{"sha":"ad8e96b83b184fbd8b09253dee8c4ada088e4992","author":{"email":"9116c67f61a8025cb8cf35425d522a2ad0f46d71@myacpl.org","name":"Owen Leonard"},"message":"Bug 16065 - Use Font Awesome icons in dialog when duplicate patron is suspected\n\nThis patch updates the new patron template to use Font Awesome icons in\nthe dialog which is shown when a duplicate patron is suspected.\n\nThe patch modifies the CSS rules for a dialog button with \"white-space:\npre-line\" so that line breaks in button text markup are treated as line\nbreaks on display. Allowing the text to wrap prevents the buttons from\nbeing too wide and stacking one below the other.\n\nTo test, apply the patch and go to Patrons -> New patron.\n\n- Attempt to save a new patron with details matching an existing patron\n  in order to trigger the duplicate patron warning.\n- Confirm that the resulting dialog is styled correctly.\n- Confirm the behavior of both the 'Edit existing' and 'Save as new'\n  buttons.\n\nFollowed test plan, works as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/ad8e96b83b184fbd8b09253dee8c4ada088e4992"},{"sha":"974ea0c8bdc15eb357d5f3f31ecb6cf0ae3fbace","author":{"email":"9116c67f61a8025cb8cf35425d522a2ad0f46d71@myacpl.org","name":"Owen Leonard"},"message":"Bug 16064 - Remove use of image to indicate approval in tags moderation\n\nThis patch updates the tags moderation template to use text labels to\nmark tag moderation status, eliminating the use of an image file to\nsignify approval.\n\nTo test you should have some tags in each approval state: pending,\napproved, and rejected.\n\n- Apply the patch and go to Tools -> Tags.\n- Confirm that the status of each tag is clearly shown with a text\n  label.\n\nWorks as expected (Do not forget to set filter at the left to 'all' for testing)\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher brendan@bywatersolutions.com","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/974ea0c8bdc15eb357d5f3f31ecb6cf0ae3fbace"}]}