{"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments/86456515","pull_request_review_id":7116560,"id":86456515,"diff_hunk":"@@ -10,32 +10,27 @@\n #include \"Titanium/detail/TiImpl.hpp\"\n #include \"HAL/HAL.hpp\"\n #include <collection.h>\n+#include \"Hyperloop.hpp\"","path":"Examples/NG/Native/src/RequireHook.cpp","position":4,"original_position":4,"commit_id":"e5ea2a89b947214702e01dee3d03c276de5d6f6c","original_commit_id":"e5ea2a89b947214702e01dee3d03c276de5d6f6c","user":{"login":"garymathews","id":8366993,"avatar_url":"https://avatars.githubusercontent.com/u/8366993?v=3","gravatar_id":"","url":"https://api.github.com/users/garymathews","html_url":"https://github.com/garymathews","followers_url":"https://api.github.com/users/garymathews/followers","following_url":"https://api.github.com/users/garymathews/following{/other_user}","gists_url":"https://api.github.com/users/garymathews/gists{/gist_id}","starred_url":"https://api.github.com/users/garymathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garymathews/subscriptions","organizations_url":"https://api.github.com/users/garymathews/orgs","repos_url":"https://api.github.com/users/garymathews/repos","events_url":"https://api.github.com/users/garymathews/events{/privacy}","received_events_url":"https://api.github.com/users/garymathews/received_events","type":"User","site_admin":false},"body":"This is missing from the NG example app","created_at":"2016-11-03T22:25:12Z","updated_at":"2016-11-03T22:25:12Z","html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/888#discussion_r86456515","pull_request_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments/86456515"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/888#discussion_r86456515"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888","id":91151690,"html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/888","diff_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/888.diff","patch_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/888.patch","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/888","number":888,"state":"open","locked":false,"title":"[TIMOB-24093] Hyperloop for Windows (Reflection based)","user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"body":"Ready for review.\r\n\r\n[TIMOB-24093](https://jira.appcelerator.org/browse/TIMOB-24093)\r\n\r\nHyperloop for Windows. Basically removes previous Hyperloop (static version) and introduces reflection-based Hyperloop.\r\n\r\nThis needs Appcelerator Platform Pro account as well as `hyperloop` module for Windows.\r\n\r\n# How to Test\r\n\r\n- Download Titanium SDK build artifacts from here: [titanium_mobile_windows_10_prs/1249/artifact/dist/windows](http://studio-jenkins.appcelerator.org/job/titanium_mobile_windows_10_prs/1249/artifact/dist/windows/) as well as [titanium_mobile_windows_8.1_prs/991/artifact/dist/windows](http://studio-jenkins.appcelerator.org/job/titanium_mobile_windows_8.1_prs/991/artifact/dist/windows/), and extract/replace them with your Titanium SDK `windows` directory.\r\n- Make sure you have installed `hyperloop` module and you have Appcelerator Platform Pro account\r\n\r\n```javascript\r\nvar win = Ti.UI.createWindow({ backgroundColor: 'green' });\r\nwin.addEventListener('open', function () {\r\n\r\n    // Test instance method call\r\n    var System_Object = require('System.Object');\r\n    var object = new System_Object();\r\n    alert(object.GetHashCode());\r\n});\r\nwin.open();\r\n```\r\n\r\nIn addition to that you'll need to set hyperloop module in your `tiapp.xml`.\r\n\r\n```xml\r\n<modules>\r\n  <module platform=\"windows\">hyperloop</module>\r\n</modules>\r\n```","created_at":"2016-10-27T08:09:28Z","updated_at":"2016-11-03T22:25:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2451b238cf2fd5fe7a9da5bc8abc3ee72ba4b46","assignee":{"login":"garymathews","id":8366993,"avatar_url":"https://avatars.githubusercontent.com/u/8366993?v=3","gravatar_id":"","url":"https://api.github.com/users/garymathews","html_url":"https://github.com/garymathews","followers_url":"https://api.github.com/users/garymathews/followers","following_url":"https://api.github.com/users/garymathews/following{/other_user}","gists_url":"https://api.github.com/users/garymathews/gists{/gist_id}","starred_url":"https://api.github.com/users/garymathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garymathews/subscriptions","organizations_url":"https://api.github.com/users/garymathews/orgs","repos_url":"https://api.github.com/users/garymathews/repos","events_url":"https://api.github.com/users/garymathews/events{/privacy}","received_events_url":"https://api.github.com/users/garymathews/received_events","type":"User","site_admin":false},"assignees":[{"login":"garymathews","id":8366993,"avatar_url":"https://avatars.githubusercontent.com/u/8366993?v=3","gravatar_id":"","url":"https://api.github.com/users/garymathews","html_url":"https://github.com/garymathews","followers_url":"https://api.github.com/users/garymathews/followers","following_url":"https://api.github.com/users/garymathews/following{/other_user}","gists_url":"https://api.github.com/users/garymathews/gists{/gist_id}","starred_url":"https://api.github.com/users/garymathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garymathews/subscriptions","organizations_url":"https://api.github.com/users/garymathews/orgs","repos_url":"https://api.github.com/users/garymathews/repos","events_url":"https://api.github.com/users/garymathews/events{/privacy}","received_events_url":"https://api.github.com/users/garymathews/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888/commits","review_comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888/comments","review_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/888/comments","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/e5ea2a89b947214702e01dee3d03c276de5d6f6c","head":{"label":"infosia:Hyperloop","ref":"Hyperloop","sha":"e5ea2a89b947214702e01dee3d03c276de5d6f6c","user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"repo":{"id":33272635,"name":"titanium_mobile_windows","full_name":"infosia/titanium_mobile_windows","owner":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infosia/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":true,"url":"https://api.github.com/repos/infosia/titanium_mobile_windows","forks_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/releases{/id}","deployments_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/deployments","created_at":"2015-04-01T20:57:51Z","updated_at":"2016-01-13T00:26:59Z","pushed_at":"2016-11-03T04:41:57Z","git_url":"git://github.com/infosia/titanium_mobile_windows.git","ssh_url":"git@github.com:infosia/titanium_mobile_windows.git","clone_url":"https://github.com/infosia/titanium_mobile_windows.git","svn_url":"https://github.com/infosia/titanium_mobile_windows","homepage":null,"size":66222,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"aa12e11ed63c8849309078c8c55a9d80b53117d2","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":27684398,"name":"titanium_mobile_windows","full_name":"appcelerator/titanium_mobile_windows","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":false,"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows","forks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/deployments","created_at":"2014-12-07T20:55:18Z","updated_at":"2016-10-23T08:10:43Z","pushed_at":"2016-11-03T04:44:44Z","git_url":"git://github.com/appcelerator/titanium_mobile_windows.git","ssh_url":"git@github.com:appcelerator/titanium_mobile_windows.git","clone_url":"https://github.com/appcelerator/titanium_mobile_windows.git","svn_url":"https://github.com/appcelerator/titanium_mobile_windows","homepage":null,"size":72288,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/888"},"issue":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/888"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/888/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/888/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/e5ea2a89b947214702e01dee3d03c276de5d6f6c"}}}}
{"actor":{"display_login":"garymathews"}}