{"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments/72054883","id":72054883,"diff_hunk":"@@ -1,31 +1,46 @@\n import { EventEmitter } from 'events';\n import shortId from 'shortid';\n import OS from 'os-family';\n-import { resize as resizeWindow, getViewportSize } from 'testcafe-browser-natives';\n+import { getViewportSize, generateThumbnail } from 'testcafe-browser-natives';\n import { isServiceCommand } from './commands/utils';\n import COMMAND_TYPE from './commands/type';\n import Warning from '../warnings';\n import WARNING_MESSAGE from '../warnings/message';\n \n+\n+const SCREENSHOT_MANIPULATION_DESCRIPTION = 'take a screenshot';\n+const RESIZE_MANIPULATION_DESCRIPTION     = 'do a window resize';\n+\n+\n export default class BrowserManipulationQueue extends EventEmitter {\n-    constructor (windowId, screenshotCapturer) {\n+    constructor (browserConnection, screenshotCapturer) {\n         super();\n \n-        this.commands           = [];\n-        this.windowId           = windowId;\n-        this.screenshotCapturer = screenshotCapturer;\n+        this.commands            = [];\n+        this.windowId            = browserConnection.id;\n+        this.browserProviderName = browserConnection.browserInfo.providerName;\n+        this.browserProvider     = browserConnection.provider;\n+        this.screenshotCapturer  = screenshotCapturer;\n     }\n \n-    async _resizeWindow (currentWidth, currentHeight, width, height) {\n-        return await resizeWindow(this.windowId, currentWidth, currentHeight, width, height);\n+\n+    async _resizeWindow (pageInfo, width, height) {\n+        try {\n+            return await this.browserProvider.resizeWindow(this.windowId, pageInfo, width, height);\n+        }\n+        catch (err) {\n+            this.emit('warning', new Warning(WARNING_MESSAGE.browserManipulationError,","path":"src/test-run/browser-manipulation-queue.js","position":39,"original_position":39,"commit_id":"67cb5419bce4326d640f9c3ef2cd7a46b42d3fa5","original_commit_id":"67cb5419bce4326d640f9c3ef2cd7a46b42d3fa5","user":{"login":"inikulin","id":453071,"avatar_url":"https://avatars.githubusercontent.com/u/453071?v=3","gravatar_id":"","url":"https://api.github.com/users/inikulin","html_url":"https://github.com/inikulin","followers_url":"https://api.github.com/users/inikulin/followers","following_url":"https://api.github.com/users/inikulin/following{/other_user}","gists_url":"https://api.github.com/users/inikulin/gists{/gist_id}","starred_url":"https://api.github.com/users/inikulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikulin/subscriptions","organizations_url":"https://api.github.com/users/inikulin/orgs","repos_url":"https://api.github.com/users/inikulin/repos","events_url":"https://api.github.com/users/inikulin/events{/privacy}","received_events_url":"https://api.github.com/users/inikulin/received_events","type":"User","site_admin":false},"body":"Why we need this `DESCRIPTION` parts? Can we get rid of them?","created_at":"2016-07-25T12:31:01Z","updated_at":"2016-07-25T12:31:01Z","html_url":"https://github.com/DevExpress/testcafe/pull/573#discussion_r72054883","pull_request_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments/72054883"},"html":{"href":"https://github.com/DevExpress/testcafe/pull/573#discussion_r72054883"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/DevExpress/testcafe/pulls/573","id":72359189,"html_url":"https://github.com/DevExpress/testcafe/pull/573","diff_url":"https://github.com/DevExpress/testcafe/pull/573.diff","patch_url":"https://github.com/DevExpress/testcafe/pull/573.patch","issue_url":"https://api.github.com/repos/DevExpress/testcafe/issues/573","number":573,"state":"open","locked":false,"title":"Implement browser providers backend (closes #207)","user":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"body":"\\cc @inikulin @AlexanderMoskovkin @helen-dikareva \r\nBTW, I expect that #543 will be landed first.","created_at":"2016-06-02T14:46:01Z","updated_at":"2016-07-25T12:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03d17d441a0083780316440f4b8acb9f62d1646c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/573/commits","review_comments_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/573/comments","review_comment_url":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/testcafe/issues/573/comments","statuses_url":"https://api.github.com/repos/DevExpress/testcafe/statuses/67cb5419bce4326d640f9c3ef2cd7a46b42d3fa5","head":{"label":"AndreyBelym:browser-providers","ref":"browser-providers","sha":"67cb5419bce4326d640f9c3ef2cd7a46b42d3fa5","user":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"repo":{"id":41853769,"name":"testcafe","full_name":"AndreyBelym/testcafe","owner":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreyBelym/testcafe","description":"","fork":true,"url":"https://api.github.com/repos/AndreyBelym/testcafe","forks_url":"https://api.github.com/repos/AndreyBelym/testcafe/forks","keys_url":"https://api.github.com/repos/AndreyBelym/testcafe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreyBelym/testcafe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreyBelym/testcafe/teams","hooks_url":"https://api.github.com/repos/AndreyBelym/testcafe/hooks","issue_events_url":"https://api.github.com/repos/AndreyBelym/testcafe/issues/events{/number}","events_url":"https://api.github.com/repos/AndreyBelym/testcafe/events","assignees_url":"https://api.github.com/repos/AndreyBelym/testcafe/assignees{/user}","branches_url":"https://api.github.com/repos/AndreyBelym/testcafe/branches{/branch}","tags_url":"https://api.github.com/repos/AndreyBelym/testcafe/tags","blobs_url":"https://api.github.com/repos/AndreyBelym/testcafe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreyBelym/testcafe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreyBelym/testcafe/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreyBelym/testcafe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreyBelym/testcafe/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreyBelym/testcafe/languages","stargazers_url":"https://api.github.com/repos/AndreyBelym/testcafe/stargazers","contributors_url":"https://api.github.com/repos/AndreyBelym/testcafe/contributors","subscribers_url":"https://api.github.com/repos/AndreyBelym/testcafe/subscribers","subscription_url":"https://api.github.com/repos/AndreyBelym/testcafe/subscription","commits_url":"https://api.github.com/repos/AndreyBelym/testcafe/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreyBelym/testcafe/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreyBelym/testcafe/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreyBelym/testcafe/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreyBelym/testcafe/contents/{+path}","compare_url":"https://api.github.com/repos/AndreyBelym/testcafe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreyBelym/testcafe/merges","archive_url":"https://api.github.com/repos/AndreyBelym/testcafe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreyBelym/testcafe/downloads","issues_url":"https://api.github.com/repos/AndreyBelym/testcafe/issues{/number}","pulls_url":"https://api.github.com/repos/AndreyBelym/testcafe/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreyBelym/testcafe/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreyBelym/testcafe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreyBelym/testcafe/labels{/name}","releases_url":"https://api.github.com/repos/AndreyBelym/testcafe/releases{/id}","deployments_url":"https://api.github.com/repos/AndreyBelym/testcafe/deployments","created_at":"2015-09-03T10:21:22Z","updated_at":"2016-01-11T13:03:33Z","pushed_at":"2016-07-25T09:31:49Z","git_url":"git://github.com/AndreyBelym/testcafe.git","ssh_url":"git@github.com:AndreyBelym/testcafe.git","clone_url":"https://github.com/AndreyBelym/testcafe.git","svn_url":"https://github.com/AndreyBelym/testcafe","homepage":null,"size":26085,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DevExpress:master","ref":"master","sha":"3ab50c5614d11fe82f3ed5c494a406ce7b13012e","user":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars.githubusercontent.com/u/4243232?v=3","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":34262857,"name":"testcafe","full_name":"DevExpress/testcafe","owner":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars.githubusercontent.com/u/4243232?v=3","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevExpress/testcafe","description":"","fork":false,"url":"https://api.github.com/repos/DevExpress/testcafe","forks_url":"https://api.github.com/repos/DevExpress/testcafe/forks","keys_url":"https://api.github.com/repos/DevExpress/testcafe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/testcafe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/testcafe/teams","hooks_url":"https://api.github.com/repos/DevExpress/testcafe/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/testcafe/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/testcafe/events","assignees_url":"https://api.github.com/repos/DevExpress/testcafe/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/testcafe/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/testcafe/tags","blobs_url":"https://api.github.com/repos/DevExpress/testcafe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/testcafe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/testcafe/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/testcafe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/testcafe/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/testcafe/languages","stargazers_url":"https://api.github.com/repos/DevExpress/testcafe/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/testcafe/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/testcafe/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/testcafe/subscription","commits_url":"https://api.github.com/repos/DevExpress/testcafe/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/testcafe/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/testcafe/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/testcafe/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/testcafe/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/testcafe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/testcafe/merges","archive_url":"https://api.github.com/repos/DevExpress/testcafe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/testcafe/downloads","issues_url":"https://api.github.com/repos/DevExpress/testcafe/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/testcafe/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/testcafe/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/testcafe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/testcafe/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/testcafe/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/testcafe/deployments","created_at":"2015-04-20T13:43:28Z","updated_at":"2016-05-06T11:53:58Z","pushed_at":"2016-07-25T12:06:16Z","git_url":"git://github.com/DevExpress/testcafe.git","ssh_url":"git@github.com:DevExpress/testcafe.git","clone_url":"https://github.com/DevExpress/testcafe.git","svn_url":"https://github.com/DevExpress/testcafe","homepage":null,"size":27446,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":66,"forks":14,"open_issues":66,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/573"},"html":{"href":"https://github.com/DevExpress/testcafe/pull/573"},"issue":{"href":"https://api.github.com/repos/DevExpress/testcafe/issues/573"},"comments":{"href":"https://api.github.com/repos/DevExpress/testcafe/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/testcafe/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/testcafe/statuses/67cb5419bce4326d640f9c3ef2cd7a46b42d3fa5"}}}}
{"actor":{"display_login":"inikulin"}}