{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16057","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16057/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16057/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16057/events","html_url":"https://github.com/cms-sw/cmssw/pull/16057","id":180385818,"number":16057,"title":"Fixes for HCAL premixing","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":1590,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-10-04T14:11:59Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-09-30T19:39:07Z","updated_at":"2016-10-04T14:18:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16057","html_url":"https://github.com/cms-sw/cmssw/pull/16057","diff_url":"https://github.com/cms-sw/cmssw/pull/16057.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16057.patch"},"body":"The first two commits in this PR fix regressions that were unknowingly introduced before pre12 (which prevent premixing from running at all):\r\n1) Premixing config for new packer\r\n2) Packing and unpacking presamples value for QIE8 in new packer\r\n\r\nThe second two commits fix known issues specifically for QIE11 premixing:\r\n3) Packing and unpacking QIE11 flag word (used for premixing error bits)\r\n4) Disabling SiPM dark current noise during premixing step 1\r\n\r\nThe following plots compare the QIE11 ADC distribution with standard mixing (blue) vs. premixing (red).\r\n\r\nAfter commits 1,2:\r\n![adc](http://kjplanet.com/pr/adc_standard_vs_premix_pre12_fix1,2.png)\r\n\r\nAfter commits 1,2,3: (better agreement at high ADC where error bits are used)\r\n![adc](http://kjplanet.com/pr/adc_standard_vs_premix_pre12_fix1,2,3.png)\r\n\r\nAfter commits 1,2,3,4: (better agreement at low ADC where single pe noise was previously duplicated)\r\n![adc](http://kjplanet.com/pr/adc_standard_vs_premix_pre12_fix1,2,3,4.png)\r\n\r\nattn: @jmmans, @lihux25, @mdhildreth "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/251401268","html_url":"https://github.com/cms-sw/cmssw/pull/16057#issuecomment-251401268","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16057","id":251401268,"user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T14:18:15Z","updated_at":"2016-10-04T14:18:15Z","body":"@slava77 @cvuosalo @civanch @mdhildreth please sign"}}
{"actor":{"display_login":"kpedro88"}}