{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/10868","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/10868/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10868/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/10868/events","html_url":"https://github.com/openshift/origin/pull/10868","id":176054500,"number":10868,"title":"BuildConfig: emit event on missing ImageStream","user":{"login":"mmilata","id":85857,"avatar_url":"https://avatars.githubusercontent.com/u/85857?v=3","gravatar_id":"","url":"https://api.github.com/users/mmilata","html_url":"https://github.com/mmilata","followers_url":"https://api.github.com/users/mmilata/followers","following_url":"https://api.github.com/users/mmilata/following{/other_user}","gists_url":"https://api.github.com/users/mmilata/gists{/gist_id}","starred_url":"https://api.github.com/users/mmilata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmilata/subscriptions","organizations_url":"https://api.github.com/users/mmilata/orgs","repos_url":"https://api.github.com/users/mmilata/repos","events_url":"https://api.github.com/users/mmilata/events{/privacy}","received_events_url":"https://api.github.com/users/mmilata/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/15","html_url":"https://github.com/openshift/origin/milestones/1.4.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/15/labels","id":1919116,"number":15,"title":"1.4.0","description":"","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":17,"state":"open","created_at":"2016-08-02T19:12:47Z","updated_at":"2016-09-21T08:39:41Z","due_on":"2016-10-29T04:00:00Z","closed_at":null},"comments":11,"created_at":"2016-09-09T16:42:14Z","updated_at":"2016-09-21T09:02:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10868","html_url":"https://github.com/openshift/origin/pull/10868","diff_url":"https://github.com/openshift/origin/pull/10868.diff","patch_url":"https://github.com/openshift/origin/pull/10868.patch"},"body":"Fixes #8523.\r\n\r\nThis is probably not the right fix but I'd like to open a PR to ask some questions:\r\n\r\n* Where in the chain of `if err != nil ... return err` should the event be created? It probably makes sense to do it right after `resolveImageStream` returns error in `pkg/build/generator/generator.go:generateBuildFromConfig` however I'm not really sure how to get hold of `EventRecorder` or how to initialize it if it should be a new member of `BuildGenerator` struct.\r\n* Because BuildConfigs haven't generated events before they are not displayed in `oc describe bc foo`, should I extend `oc` to do this?\r\n* I noticed some harmless bugs, like [this redundant if](https://github.com/openshift/origin/blob/v1.3.0-rc1/pkg/build/generator/generator.go#L577), should I include it in this commit, open separate PR or just ignore it?"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/248553116","html_url":"https://github.com/openshift/origin/pull/10868#issuecomment-248553116","issue_url":"https://api.github.com/repos/openshift/origin/issues/10868","id":248553116,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T09:02:24Z","updated_at":"2016-09-21T09:02:24Z","body":"Evaluated for origin merge up to 5fe9204f71fe5eef679d74e8ee7ac4d0fa46eb1c"}}
{"actor":{"display_login":"openshift-bot"}}