{"action":"created","issue":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1035","repository_url":"https://api.github.com/repos/simplabs/ember-simple-auth","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1035/labels{/name}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1035/comments","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1035/events","html_url":"https://github.com/simplabs/ember-simple-auth/pull/1035","id":168182497,"number":1035,"title":"FastBoot Compatibility","user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"labels":[{"id":74292514,"url":"https://api.github.com/repos/simplabs/ember-simple-auth/labels/feature","name":"feature","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"assignees":[{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones/23","html_url":"https://github.com/simplabs/ember-simple-auth/milestones/1.2","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones/23/labels","id":1570361,"number":23,"title":"1.2","description":"","creator":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":36,"state":"open","created_at":"2016-02-08T13:37:28Z","updated_at":"2016-09-29T17:37:06Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2016-07-28T19:57:34Z","updated_at":"2016-11-23T12:47:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1035","html_url":"https://github.com/simplabs/ember-simple-auth/pull/1035","diff_url":"https://github.com/simplabs/ember-simple-auth/pull/1035.diff","patch_url":"https://github.com/simplabs/ember-simple-auth/pull/1035.patch"},"body":"This makes Ember Simple Auth compatible with FastBoot.\r\n\r\nThe goal of this is for Ember Simple auth to support FastBoot out of the box without the need for anyone to change anything to their ESA setup (except for switching to the cookie session store as `localStorage` doesn't work in FastBoot obviously).\r\n### TODO\r\n- [x] ~~replace [`window.btoa`](https://github.com/simplabs/ember-simple-auth/blob/master/addon/authenticators/oauth2-password-grant.js#L125) with sth. that works in FastBoot~~ (FastBoot exposes a `window` global (which is the sandbox) which means this works already)\r\n- [x] replace [`window.location`](https://github.com/simplabs/ember-simple-auth/blob/master/addon/mixins/application-route-mixin.js#L123) with sth. that works in FastBoot\r\n- [x] don't try [binding to `localStorage` events with jQuery](https://github.com/simplabs/ember-simple-auth/blob/master/addon/session-stores/local-storage.js#L85) when running in FastBoot\r\n- [x] inject the FastBoot service into the cookie store manually in an initializer\r\n- [x] write integration tests using ember-cli-addon-tests\r\n- [x] use `ember-network` instead of jQuery's AJAX methods, see #1066 \r\n- [x] replace occurences of jQuery, `window` etc. in the docs with sth. that works in FastBoot\r\n- [x] fix tests (FastBoot tests seem to fail randomly - must be some sort of race condition or so)\r\n"},"comment":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/comments/262504176","html_url":"https://github.com/simplabs/ember-simple-auth/pull/1035#issuecomment-262504176","issue_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1035","id":262504176,"user":{"login":"marcoow","id":1510,"avatar_url":"https://avatars.githubusercontent.com/u/1510?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoow","html_url":"https://github.com/marcoow","followers_url":"https://api.github.com/users/marcoow/followers","following_url":"https://api.github.com/users/marcoow/following{/other_user}","gists_url":"https://api.github.com/users/marcoow/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoow/subscriptions","organizations_url":"https://api.github.com/users/marcoow/orgs","repos_url":"https://api.github.com/users/marcoow/repos","events_url":"https://api.github.com/users/marcoow/events{/privacy}","received_events_url":"https://api.github.com/users/marcoow/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T12:47:32Z","updated_at":"2016-11-23T12:47:32Z","body":"[This](https://github.com/lolmaus/lolma.us/blob/1cf778c53d2ee1601843cf7452d985e8e608aaf4/app/pods/application/route.js#L41) will reject when you're not running on FastBoot. I'm not sure what a subsequent call to `modelFor` will result in."}}
{"actor":{"display_login":"marcoow"}}