{"action":"created","issue":{"url":"https://api.github.com/repos/TokTok/toxcore/issues/19","repository_url":"https://api.github.com/repos/TokTok/toxcore","labels_url":"https://api.github.com/repos/TokTok/toxcore/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/TokTok/toxcore/issues/19/comments","events_url":"https://api.github.com/repos/TokTok/toxcore/issues/19/events","html_url":"https://github.com/TokTok/toxcore/pull/19","id":169829804,"number":19,"title":" Replace *Tox as a pointer to *Messenger to it's own struct","user":{"login":"GrayHatter","id":243408,"avatar_url":"https://avatars.githubusercontent.com/u/243408?v=3","gravatar_id":"","url":"https://api.github.com/users/GrayHatter","html_url":"https://github.com/GrayHatter","followers_url":"https://api.github.com/users/GrayHatter/followers","following_url":"https://api.github.com/users/GrayHatter/following{/other_user}","gists_url":"https://api.github.com/users/GrayHatter/gists{/gist_id}","starred_url":"https://api.github.com/users/GrayHatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrayHatter/subscriptions","organizations_url":"https://api.github.com/users/GrayHatter/orgs","repos_url":"https://api.github.com/users/GrayHatter/repos","events_url":"https://api.github.com/users/GrayHatter/events{/privacy}","received_events_url":"https://api.github.com/users/GrayHatter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"JFreegman","id":1646057,"avatar_url":"https://avatars.githubusercontent.com/u/1646057?v=3","gravatar_id":"","url":"https://api.github.com/users/JFreegman","html_url":"https://github.com/JFreegman","followers_url":"https://api.github.com/users/JFreegman/followers","following_url":"https://api.github.com/users/JFreegman/following{/other_user}","gists_url":"https://api.github.com/users/JFreegman/gists{/gist_id}","starred_url":"https://api.github.com/users/JFreegman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFreegman/subscriptions","organizations_url":"https://api.github.com/users/JFreegman/orgs","repos_url":"https://api.github.com/users/JFreegman/repos","events_url":"https://api.github.com/users/JFreegman/events{/privacy}","received_events_url":"https://api.github.com/users/JFreegman/received_events","type":"User","site_admin":false},"assignees":[{"login":"JFreegman","id":1646057,"avatar_url":"https://avatars.githubusercontent.com/u/1646057?v=3","gravatar_id":"","url":"https://api.github.com/users/JFreegman","html_url":"https://github.com/JFreegman","followers_url":"https://api.github.com/users/JFreegman/followers","following_url":"https://api.github.com/users/JFreegman/following{/other_user}","gists_url":"https://api.github.com/users/JFreegman/gists{/gist_id}","starred_url":"https://api.github.com/users/JFreegman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JFreegman/subscriptions","organizations_url":"https://api.github.com/users/JFreegman/orgs","repos_url":"https://api.github.com/users/JFreegman/repos","events_url":"https://api.github.com/users/JFreegman/events{/privacy}","received_events_url":"https://api.github.com/users/JFreegman/received_events","type":"User","site_admin":false},{"login":"nurupo","id":1855294,"avatar_url":"https://avatars.githubusercontent.com/u/1855294?v=3","gravatar_id":"","url":"https://api.github.com/users/nurupo","html_url":"https://github.com/nurupo","followers_url":"https://api.github.com/users/nurupo/followers","following_url":"https://api.github.com/users/nurupo/following{/other_user}","gists_url":"https://api.github.com/users/nurupo/gists{/gist_id}","starred_url":"https://api.github.com/users/nurupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurupo/subscriptions","organizations_url":"https://api.github.com/users/nurupo/orgs","repos_url":"https://api.github.com/users/nurupo/repos","events_url":"https://api.github.com/users/nurupo/events{/privacy}","received_events_url":"https://api.github.com/users/nurupo/received_events","type":"User","site_admin":false},{"login":"irungentoo","id":2226611,"avatar_url":"https://avatars.githubusercontent.com/u/2226611?v=3","gravatar_id":"","url":"https://api.github.com/users/irungentoo","html_url":"https://github.com/irungentoo","followers_url":"https://api.github.com/users/irungentoo/followers","following_url":"https://api.github.com/users/irungentoo/following{/other_user}","gists_url":"https://api.github.com/users/irungentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/irungentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irungentoo/subscriptions","organizations_url":"https://api.github.com/users/irungentoo/orgs","repos_url":"https://api.github.com/users/irungentoo/repos","events_url":"https://api.github.com/users/irungentoo/events{/privacy}","received_events_url":"https://api.github.com/users/irungentoo/received_events","type":"User","site_admin":false},{"login":"tux3","id":5155966,"avatar_url":"https://avatars.githubusercontent.com/u/5155966?v=3","gravatar_id":"","url":"https://api.github.com/users/tux3","html_url":"https://github.com/tux3","followers_url":"https://api.github.com/users/tux3/followers","following_url":"https://api.github.com/users/tux3/following{/other_user}","gists_url":"https://api.github.com/users/tux3/gists{/gist_id}","starred_url":"https://api.github.com/users/tux3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tux3/subscriptions","organizations_url":"https://api.github.com/users/tux3/orgs","repos_url":"https://api.github.com/users/tux3/repos","events_url":"https://api.github.com/users/tux3/events{/privacy}","received_events_url":"https://api.github.com/users/tux3/received_events","type":"User","site_admin":false},{"login":"Encrypt","id":9038199,"avatar_url":"https://avatars.githubusercontent.com/u/9038199?v=3","gravatar_id":"","url":"https://api.github.com/users/Encrypt","html_url":"https://github.com/Encrypt","followers_url":"https://api.github.com/users/Encrypt/followers","following_url":"https://api.github.com/users/Encrypt/following{/other_user}","gists_url":"https://api.github.com/users/Encrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/Encrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Encrypt/subscriptions","organizations_url":"https://api.github.com/users/Encrypt/orgs","repos_url":"https://api.github.com/users/Encrypt/repos","events_url":"https://api.github.com/users/Encrypt/events{/privacy}","received_events_url":"https://api.github.com/users/Encrypt/received_events","type":"User","site_admin":false},{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},{"login":"endoffile78","id":11342054,"avatar_url":"https://avatars.githubusercontent.com/u/11342054?v=3","gravatar_id":"","url":"https://api.github.com/users/endoffile78","html_url":"https://github.com/endoffile78","followers_url":"https://api.github.com/users/endoffile78/followers","following_url":"https://api.github.com/users/endoffile78/following{/other_user}","gists_url":"https://api.github.com/users/endoffile78/gists{/gist_id}","starred_url":"https://api.github.com/users/endoffile78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endoffile78/subscriptions","organizations_url":"https://api.github.com/users/endoffile78/orgs","repos_url":"https://api.github.com/users/endoffile78/repos","events_url":"https://api.github.com/users/endoffile78/events{/privacy}","received_events_url":"https://api.github.com/users/endoffile78/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-08-08T01:54:53Z","updated_at":"2016-08-08T02:00:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TokTok/toxcore/pulls/19","html_url":"https://github.com/TokTok/toxcore/pull/19","diff_url":"https://github.com/TokTok/toxcore/pull/19.diff","patch_url":"https://github.com/TokTok/toxcore/pull/19.patch"},"body":"Oh, boy... I knew this commit was going to be huge, but I didn't know how big.\r\nThere's no way to make this smaller, without breaking more stuff, as it is, it\r\nonly compiles if you\r\n./configure --disable-tests --disable-testing --disable-av ...\r\n\r\nFor the most of it, It's a lot of sane renames, and close consideration. With\r\nthe notable exception of group.{c,h} & tox_old_code.h. Both of which I decided\r\nto do bulk replacements of *Group_Chats to *Tox, and linking the code on line 1\r\nof the function to avoid changing a lot of lines with important code. I decided\r\nto do it this way because the global plan for toxcore is to replace the current\r\ngroupchats with something better. So this change was quick, instead of detailed.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/toktok/toxcore/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/TokTok/toxcore/issues/comments/238125944","html_url":"https://github.com/TokTok/toxcore/pull/19#issuecomment-238125944","issue_url":"https://api.github.com/repos/TokTok/toxcore/issues/19","id":238125944,"user":{"login":"GrayHatter","id":243408,"avatar_url":"https://avatars.githubusercontent.com/u/243408?v=3","gravatar_id":"","url":"https://api.github.com/users/GrayHatter","html_url":"https://github.com/GrayHatter","followers_url":"https://api.github.com/users/GrayHatter/followers","following_url":"https://api.github.com/users/GrayHatter/following{/other_user}","gists_url":"https://api.github.com/users/GrayHatter/gists{/gist_id}","starred_url":"https://api.github.com/users/GrayHatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrayHatter/subscriptions","organizations_url":"https://api.github.com/users/GrayHatter/orgs","repos_url":"https://api.github.com/users/GrayHatter/repos","events_url":"https://api.github.com/users/GrayHatter/events{/privacy}","received_events_url":"https://api.github.com/users/GrayHatter/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T02:00:22Z","updated_at":"2016-08-08T02:00:22Z","body":"I assigned a little bit of everyone. @JFreegman and @nurupo because the last I heard, you want to make sure someone reviews the changes I make to toxcore. Here's your chance. @irungentoo PTAL, I'm sure there's something I could be doing better if I knew as much about toxcore as you. \r\n\r\n@tux3 you're really the one I think will be able to give it the most time/attention. It's a little messy around the save new save functions you wrote (removed). They're coming next.\r\n\r\n@Encrypt @endoffile78 Same as #18, the more toxcore code you see the more you'll be able to help. (And another pair of eyes never hurt!)\r\n\r\nThanks guys!\r\n\r\n"}}
{"actor":{"display_login":"GrayHatter"}}