{"action":"created","comment":{"url":"https://api.github.com/repos/vstakhov/rmilter/pulls/comments/89490232","pull_request_review_id":10035138,"id":89490232,"diff_hunk":"@@ -241,14 +243,39 @@ main(int argc, char *argv[])\n \t\tcase 'v':\n \t\t\tversion ();\n \t\t\tbreak;\n+\t\tcase 's':\n+\t\t\tif (optarg == NULL || *optarg == '\\0') {\n+\t\t\t\tfprintf(stderr, \"Illegal syslog name: %s\\n\",\n+\t\t\t\t\t\toptarg);\n+\t\t\t\texit(EX_USAGE);\n+\t\t\t}\n+\t\t\telse {\n+\t\t\t\tchar *s_pos;\n+\t\t\t\tsize_t length = 0;\n+\n+\t\t\t\ts_pos = optarg;\n+\t\t\t\twhile (*optarg++) length++;","path":"src/main.c","position":38,"original_position":38,"commit_id":"a6fc41fc8f17b3d4282976f02f3150b29a953274","original_commit_id":"a6fc41fc8f17b3d4282976f02f3150b29a953274","user":{"login":"vstakhov","id":487344,"avatar_url":"https://avatars.githubusercontent.com/u/487344?v=3","gravatar_id":"","url":"https://api.github.com/users/vstakhov","html_url":"https://github.com/vstakhov","followers_url":"https://api.github.com/users/vstakhov/followers","following_url":"https://api.github.com/users/vstakhov/following{/other_user}","gists_url":"https://api.github.com/users/vstakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/vstakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstakhov/subscriptions","organizations_url":"https://api.github.com/users/vstakhov/orgs","repos_url":"https://api.github.com/users/vstakhov/repos","events_url":"https://api.github.com/users/vstakhov/events{/privacy}","received_events_url":"https://api.github.com/users/vstakhov/received_events","type":"User","site_admin":false},"body":"Why not `strlen`?","created_at":"2016-11-24T12:37:19Z","updated_at":"2016-11-24T12:37:19Z","html_url":"https://github.com/vstakhov/rmilter/pull/167#discussion_r89490232","pull_request_url":"https://api.github.com/repos/vstakhov/rmilter/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/vstakhov/rmilter/pulls/comments/89490232"},"html":{"href":"https://github.com/vstakhov/rmilter/pull/167#discussion_r89490232"},"pull_request":{"href":"https://api.github.com/repos/vstakhov/rmilter/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/vstakhov/rmilter/pulls/167","id":95161768,"html_url":"https://github.com/vstakhov/rmilter/pull/167","diff_url":"https://github.com/vstakhov/rmilter/pull/167.diff","patch_url":"https://github.com/vstakhov/rmilter/pull/167.patch","issue_url":"https://api.github.com/repos/vstakhov/rmilter/issues/167","number":167,"state":"open","locked":false,"title":"Add custom syslog name support","user":{"login":"croessner","id":2562594,"avatar_url":"https://avatars.githubusercontent.com/u/2562594?v=3","gravatar_id":"","url":"https://api.github.com/users/croessner","html_url":"https://github.com/croessner","followers_url":"https://api.github.com/users/croessner/followers","following_url":"https://api.github.com/users/croessner/following{/other_user}","gists_url":"https://api.github.com/users/croessner/gists{/gist_id}","starred_url":"https://api.github.com/users/croessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croessner/subscriptions","organizations_url":"https://api.github.com/users/croessner/orgs","repos_url":"https://api.github.com/users/croessner/repos","events_url":"https://api.github.com/users/croessner/events{/privacy}","received_events_url":"https://api.github.com/users/croessner/received_events","type":"User","site_admin":false},"body":"You can set a custom syslog name with command line parameter \"-s\". The default name is \"rmilter\"","created_at":"2016-11-24T11:29:54Z","updated_at":"2016-11-24T12:38:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36f3e89e80cd6298763e531b90154f43d5448d9e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vstakhov/rmilter/pulls/167/commits","review_comments_url":"https://api.github.com/repos/vstakhov/rmilter/pulls/167/comments","review_comment_url":"https://api.github.com/repos/vstakhov/rmilter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vstakhov/rmilter/issues/167/comments","statuses_url":"https://api.github.com/repos/vstakhov/rmilter/statuses/a6fc41fc8f17b3d4282976f02f3150b29a953274","head":{"label":"croessner:master","ref":"master","sha":"a6fc41fc8f17b3d4282976f02f3150b29a953274","user":{"login":"croessner","id":2562594,"avatar_url":"https://avatars.githubusercontent.com/u/2562594?v=3","gravatar_id":"","url":"https://api.github.com/users/croessner","html_url":"https://github.com/croessner","followers_url":"https://api.github.com/users/croessner/followers","following_url":"https://api.github.com/users/croessner/following{/other_user}","gists_url":"https://api.github.com/users/croessner/gists{/gist_id}","starred_url":"https://api.github.com/users/croessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croessner/subscriptions","organizations_url":"https://api.github.com/users/croessner/orgs","repos_url":"https://api.github.com/users/croessner/repos","events_url":"https://api.github.com/users/croessner/events{/privacy}","received_events_url":"https://api.github.com/users/croessner/received_events","type":"User","site_admin":false},"repo":{"id":74666642,"name":"rmilter","full_name":"croessner/rmilter","owner":{"login":"croessner","id":2562594,"avatar_url":"https://avatars.githubusercontent.com/u/2562594?v=3","gravatar_id":"","url":"https://api.github.com/users/croessner","html_url":"https://github.com/croessner","followers_url":"https://api.github.com/users/croessner/followers","following_url":"https://api.github.com/users/croessner/following{/other_user}","gists_url":"https://api.github.com/users/croessner/gists{/gist_id}","starred_url":"https://api.github.com/users/croessner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croessner/subscriptions","organizations_url":"https://api.github.com/users/croessner/orgs","repos_url":"https://api.github.com/users/croessner/repos","events_url":"https://api.github.com/users/croessner/events{/privacy}","received_events_url":"https://api.github.com/users/croessner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/croessner/rmilter","description":"Another sendmail milter for different mail checks.","fork":true,"url":"https://api.github.com/repos/croessner/rmilter","forks_url":"https://api.github.com/repos/croessner/rmilter/forks","keys_url":"https://api.github.com/repos/croessner/rmilter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/croessner/rmilter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/croessner/rmilter/teams","hooks_url":"https://api.github.com/repos/croessner/rmilter/hooks","issue_events_url":"https://api.github.com/repos/croessner/rmilter/issues/events{/number}","events_url":"https://api.github.com/repos/croessner/rmilter/events","assignees_url":"https://api.github.com/repos/croessner/rmilter/assignees{/user}","branches_url":"https://api.github.com/repos/croessner/rmilter/branches{/branch}","tags_url":"https://api.github.com/repos/croessner/rmilter/tags","blobs_url":"https://api.github.com/repos/croessner/rmilter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/croessner/rmilter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/croessner/rmilter/git/refs{/sha}","trees_url":"https://api.github.com/repos/croessner/rmilter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/croessner/rmilter/statuses/{sha}","languages_url":"https://api.github.com/repos/croessner/rmilter/languages","stargazers_url":"https://api.github.com/repos/croessner/rmilter/stargazers","contributors_url":"https://api.github.com/repos/croessner/rmilter/contributors","subscribers_url":"https://api.github.com/repos/croessner/rmilter/subscribers","subscription_url":"https://api.github.com/repos/croessner/rmilter/subscription","commits_url":"https://api.github.com/repos/croessner/rmilter/commits{/sha}","git_commits_url":"https://api.github.com/repos/croessner/rmilter/git/commits{/sha}","comments_url":"https://api.github.com/repos/croessner/rmilter/comments{/number}","issue_comment_url":"https://api.github.com/repos/croessner/rmilter/issues/comments{/number}","contents_url":"https://api.github.com/repos/croessner/rmilter/contents/{+path}","compare_url":"https://api.github.com/repos/croessner/rmilter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/croessner/rmilter/merges","archive_url":"https://api.github.com/repos/croessner/rmilter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/croessner/rmilter/downloads","issues_url":"https://api.github.com/repos/croessner/rmilter/issues{/number}","pulls_url":"https://api.github.com/repos/croessner/rmilter/pulls{/number}","milestones_url":"https://api.github.com/repos/croessner/rmilter/milestones{/number}","notifications_url":"https://api.github.com/repos/croessner/rmilter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/croessner/rmilter/labels{/name}","releases_url":"https://api.github.com/repos/croessner/rmilter/releases{/id}","deployments_url":"https://api.github.com/repos/croessner/rmilter/deployments","created_at":"2016-11-24T11:23:11Z","updated_at":"2016-11-24T11:23:13Z","pushed_at":"2016-11-24T11:25:42Z","git_url":"git://github.com/croessner/rmilter.git","ssh_url":"git@github.com:croessner/rmilter.git","clone_url":"https://github.com/croessner/rmilter.git","svn_url":"https://github.com/croessner/rmilter","homepage":null,"size":1881,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vstakhov:master","ref":"master","sha":"e106583bd1282d9a99c901454b06fb62a55f7336","user":{"login":"vstakhov","id":487344,"avatar_url":"https://avatars.githubusercontent.com/u/487344?v=3","gravatar_id":"","url":"https://api.github.com/users/vstakhov","html_url":"https://github.com/vstakhov","followers_url":"https://api.github.com/users/vstakhov/followers","following_url":"https://api.github.com/users/vstakhov/following{/other_user}","gists_url":"https://api.github.com/users/vstakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/vstakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstakhov/subscriptions","organizations_url":"https://api.github.com/users/vstakhov/orgs","repos_url":"https://api.github.com/users/vstakhov/repos","events_url":"https://api.github.com/users/vstakhov/events{/privacy}","received_events_url":"https://api.github.com/users/vstakhov/received_events","type":"User","site_admin":false},"repo":{"id":9549335,"name":"rmilter","full_name":"vstakhov/rmilter","owner":{"login":"vstakhov","id":487344,"avatar_url":"https://avatars.githubusercontent.com/u/487344?v=3","gravatar_id":"","url":"https://api.github.com/users/vstakhov","html_url":"https://github.com/vstakhov","followers_url":"https://api.github.com/users/vstakhov/followers","following_url":"https://api.github.com/users/vstakhov/following{/other_user}","gists_url":"https://api.github.com/users/vstakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/vstakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstakhov/subscriptions","organizations_url":"https://api.github.com/users/vstakhov/orgs","repos_url":"https://api.github.com/users/vstakhov/repos","events_url":"https://api.github.com/users/vstakhov/events{/privacy}","received_events_url":"https://api.github.com/users/vstakhov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vstakhov/rmilter","description":"Another sendmail milter for different mail checks.","fork":false,"url":"https://api.github.com/repos/vstakhov/rmilter","forks_url":"https://api.github.com/repos/vstakhov/rmilter/forks","keys_url":"https://api.github.com/repos/vstakhov/rmilter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vstakhov/rmilter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vstakhov/rmilter/teams","hooks_url":"https://api.github.com/repos/vstakhov/rmilter/hooks","issue_events_url":"https://api.github.com/repos/vstakhov/rmilter/issues/events{/number}","events_url":"https://api.github.com/repos/vstakhov/rmilter/events","assignees_url":"https://api.github.com/repos/vstakhov/rmilter/assignees{/user}","branches_url":"https://api.github.com/repos/vstakhov/rmilter/branches{/branch}","tags_url":"https://api.github.com/repos/vstakhov/rmilter/tags","blobs_url":"https://api.github.com/repos/vstakhov/rmilter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vstakhov/rmilter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vstakhov/rmilter/git/refs{/sha}","trees_url":"https://api.github.com/repos/vstakhov/rmilter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vstakhov/rmilter/statuses/{sha}","languages_url":"https://api.github.com/repos/vstakhov/rmilter/languages","stargazers_url":"https://api.github.com/repos/vstakhov/rmilter/stargazers","contributors_url":"https://api.github.com/repos/vstakhov/rmilter/contributors","subscribers_url":"https://api.github.com/repos/vstakhov/rmilter/subscribers","subscription_url":"https://api.github.com/repos/vstakhov/rmilter/subscription","commits_url":"https://api.github.com/repos/vstakhov/rmilter/commits{/sha}","git_commits_url":"https://api.github.com/repos/vstakhov/rmilter/git/commits{/sha}","comments_url":"https://api.github.com/repos/vstakhov/rmilter/comments{/number}","issue_comment_url":"https://api.github.com/repos/vstakhov/rmilter/issues/comments{/number}","contents_url":"https://api.github.com/repos/vstakhov/rmilter/contents/{+path}","compare_url":"https://api.github.com/repos/vstakhov/rmilter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vstakhov/rmilter/merges","archive_url":"https://api.github.com/repos/vstakhov/rmilter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vstakhov/rmilter/downloads","issues_url":"https://api.github.com/repos/vstakhov/rmilter/issues{/number}","pulls_url":"https://api.github.com/repos/vstakhov/rmilter/pulls{/number}","milestones_url":"https://api.github.com/repos/vstakhov/rmilter/milestones{/number}","notifications_url":"https://api.github.com/repos/vstakhov/rmilter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vstakhov/rmilter/labels{/name}","releases_url":"https://api.github.com/repos/vstakhov/rmilter/releases{/id}","deployments_url":"https://api.github.com/repos/vstakhov/rmilter/deployments","created_at":"2013-04-19T16:14:04Z","updated_at":"2016-11-17T09:16:11Z","pushed_at":"2016-11-24T11:29:54Z","git_url":"git://github.com/vstakhov/rmilter.git","ssh_url":"git@github.com:vstakhov/rmilter.git","clone_url":"https://github.com/vstakhov/rmilter.git","svn_url":"https://github.com/vstakhov/rmilter","homepage":null,"size":1883,"stargazers_count":69,"watchers_count":69,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":32,"forks":21,"open_issues":32,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vstakhov/rmilter/pulls/167"},"html":{"href":"https://github.com/vstakhov/rmilter/pull/167"},"issue":{"href":"https://api.github.com/repos/vstakhov/rmilter/issues/167"},"comments":{"href":"https://api.github.com/repos/vstakhov/rmilter/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/vstakhov/rmilter/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/vstakhov/rmilter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vstakhov/rmilter/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/vstakhov/rmilter/statuses/a6fc41fc8f17b3d4282976f02f3150b29a953274"}}}}
{"actor":{"display_login":"vstakhov"}}