{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/81864352","pull_request_review_id":2813451,"id":81864352,"diff_hunk":"@@ -146,16 +146,8 @@\n \n     std::fill(origins.begin(), origins.end(), CGPoint{ c_arbitraryFloat, c_arbitraryFloat });\n     CTFrameGetLineOrigins(frame, CFRangeMake(-110, 0), origins.data());\n-    EXPECT_NEAR(0.0f, origins[0].x, c_errorDelta);\n-    EXPECT_NEAR(43.1641f, origins[0].y, c_errorDelta);\n-    EXPECT_NEAR(0.0f, origins[1].x, c_errorDelta);\n-    EXPECT_NEAR(96.3672f, origins[1].y, c_errorDelta);\n-    EXPECT_NEAR(0.0f, origins[2].x, c_errorDelta);\n-    EXPECT_NEAR(149.5703f, origins[2].y, c_errorDelta);\n-    EXPECT_NEAR(0.0f, origins[3].x, c_errorDelta);\n-    EXPECT_NEAR(202.7734f, origins[3].y, c_errorDelta);\n-    EXPECT_EQ(c_arbitraryFloat, origins[4].x);\n-    EXPECT_EQ(c_arbitraryFloat, origins[4].y);","path":"tests/unittests/CoreText/CTFrameTests.mm","position":13,"original_position":13,"commit_id":"1e34aa86d9052ecd9bc44d106f905382224f58b4","original_commit_id":"1e34aa86d9052ecd9bc44d106f905382224f58b4","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"body":"did these turn out to be 'bad cases' where we had the wrong return values before? if so, can we add some comments to label them as such?\r\n\r\n---\r\nIn reply to: [81864283](https://github.com/Microsoft/WinObjC/pull/1079#discussion_r81864283) [](ancestors = 81864283)","created_at":"2016-10-04T22:05:32Z","updated_at":"2016-10-04T22:05:32Z","html_url":"https://github.com/Microsoft/WinObjC/pull/1079#discussion_r81864352","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/81864352"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1079#discussion_r81864352"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079","id":87947363,"html_url":"https://github.com/Microsoft/WinObjC/pull/1079","diff_url":"https://github.com/Microsoft/WinObjC/pull/1079.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/1079.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1079","number":1079,"state":"open","locked":false,"title":"Fully implement CTRunDraw and CTRunGetTypographicBounds","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"body":"CTRunDraw now handles the range parameter and CTRunGetTypographicBounds gets the bounds for the text in given range rather than for the font.  Also rewrites CTLineGetTypographicBounds using CTRunGetTypographicBounds and small cleanups.\r\n\r\nFixes #963","created_at":"2016-10-04T18:22:59Z","updated_at":"2016-10-04T22:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b42632a7c68eaab17f848f3482e79506d9df6af7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1079/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/1e34aa86d9052ecd9bc44d106f905382224f58b4","head":{"label":"aballway:coretext","ref":"coretext","sha":"1e34aa86d9052ecd9bc44d106f905382224f58b4","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"repo":{"id":62087158,"name":"WinObjC","full_name":"aballway/WinObjC","owner":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aballway/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/aballway/WinObjC","forks_url":"https://api.github.com/repos/aballway/WinObjC/forks","keys_url":"https://api.github.com/repos/aballway/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aballway/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aballway/WinObjC/teams","hooks_url":"https://api.github.com/repos/aballway/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/aballway/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/aballway/WinObjC/events","assignees_url":"https://api.github.com/repos/aballway/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/aballway/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/aballway/WinObjC/tags","blobs_url":"https://api.github.com/repos/aballway/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aballway/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aballway/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/aballway/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aballway/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/aballway/WinObjC/languages","stargazers_url":"https://api.github.com/repos/aballway/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/aballway/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/aballway/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/aballway/WinObjC/subscription","commits_url":"https://api.github.com/repos/aballway/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/aballway/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/aballway/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/aballway/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/aballway/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/aballway/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aballway/WinObjC/merges","archive_url":"https://api.github.com/repos/aballway/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aballway/WinObjC/downloads","issues_url":"https://api.github.com/repos/aballway/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/aballway/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/aballway/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/aballway/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aballway/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/aballway/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/aballway/WinObjC/deployments","created_at":"2016-06-27T20:48:04Z","updated_at":"2016-06-28T17:00:56Z","pushed_at":"2016-10-04T18:20:43Z","git_url":"git://github.com/aballway/WinObjC.git","ssh_url":"git@github.com:aballway/WinObjC.git","clone_url":"https://github.com/aballway/WinObjC.git","svn_url":"https://github.com/aballway/WinObjC","homepage":"","size":329832,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:CT-DW","ref":"CT-DW","sha":"fee3fcae6a298acafd9b87db0d0c8689fdc0bbdc","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-10-04T16:30:05Z","pushed_at":"2016-10-04T20:45:58Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":334257,"stargazers_count":5466,"watchers_count":5466,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":700,"mirror_url":null,"open_issues_count":222,"forks":700,"open_issues":222,"watchers":5466,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1079"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1079"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/1e34aa86d9052ecd9bc44d106f905382224f58b4"}}}}
{"actor":{"display_login":"ms-jihua"}}