{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/runtime-tools/issues/285","repository_url":"https://api.github.com/repos/opencontainers/runtime-tools","labels_url":"https://api.github.com/repos/opencontainers/runtime-tools/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/runtime-tools/issues/285/comments","events_url":"https://api.github.com/repos/opencontainers/runtime-tools/issues/285/events","html_url":"https://github.com/opencontainers/runtime-tools/pull/285","id":192519410,"number":285,"title":"Carry 232: fix issue #228 replace start to run","user":{"login":"Mashimiao","id":4852224,"avatar_url":"https://avatars.githubusercontent.com/u/4852224?v=3","gravatar_id":"","url":"https://api.github.com/users/Mashimiao","html_url":"https://github.com/Mashimiao","followers_url":"https://api.github.com/users/Mashimiao/followers","following_url":"https://api.github.com/users/Mashimiao/following{/other_user}","gists_url":"https://api.github.com/users/Mashimiao/gists{/gist_id}","starred_url":"https://api.github.com/users/Mashimiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mashimiao/subscriptions","organizations_url":"https://api.github.com/users/Mashimiao/orgs","repos_url":"https://api.github.com/users/Mashimiao/repos","events_url":"https://api.github.com/users/Mashimiao/events{/privacy}","received_events_url":"https://api.github.com/users/Mashimiao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-11-30T09:46:21Z","updated_at":"2016-12-01T08:53:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencontainers/runtime-tools/pulls/285","html_url":"https://github.com/opencontainers/runtime-tools/pull/285","diff_url":"https://github.com/opencontainers/runtime-tools/pull/285.diff","patch_url":"https://github.com/opencontainers/runtime-tools/pull/285.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/opencontainers/runtime-tools/issues/comments/264115865","html_url":"https://github.com/opencontainers/runtime-tools/pull/285#issuecomment-264115865","issue_url":"https://api.github.com/repos/opencontainers/runtime-tools/issues/285","id":264115865,"user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T08:53:16Z","updated_at":"2016-12-01T08:53:16Z","body":"On Thu, Dec 01, 2016 at 12:35:40AM -0800, Ma Shimiao wrote:\n> On 12/01/2016 04:07 PM, W. Trevor King wrote:\n> > How would you feel about landing that change without carrying the\n> > commit from #232 until someone writes the wrapper?\n> \n> … Do you mean if I insisted on rolling my own output, I should push\n> a new PR with the new commit in this PR?  Or something else?\n\nThis PR currently has two commits:\n\n* 6117361, carried from #232, breaks test_runtime.sh's exit code.\n* d76bbd7, new in this PR, adjusts stdout for runtimetest.\n\nI'm agnostic on d76bbd7.  It can land or not as you see fit.\n\nI'd rather not land 6117361 without *also* landing a wrapper to set\nsubreaper and catch the runtimetest exit code for us.\n\nIf you want d76bbd7 without 6117361 (which is fine with me), you could\ndo something like:\n\n  $ git checkout carry-232\n  $ git rebase --onto origin/master HEAD^\n  $ git push -f Mashimiao carry-232\n\nalthough at that point the branch has nothing to do with #232.  If the\nbranch-name missmatch bothers you, you could create a new branch with\njust d76bbd7 and open a new PR.  And if you aren't convinced by my\npush-back against 6117361 (without the subreaper wrapper), you can\nleave this PR exactly as it stands :p.\n"}}
{"actor":{"display_login":"wking"}}