{"action":"created","issue":{"url":"https://api.github.com/repos/fifengine/fifengine/issues/907","repository_url":"https://api.github.com/repos/fifengine/fifengine","labels_url":"https://api.github.com/repos/fifengine/fifengine/issues/907/labels{/name}","comments_url":"https://api.github.com/repos/fifengine/fifengine/issues/907/comments","events_url":"https://api.github.com/repos/fifengine/fifengine/issues/907/events","html_url":"https://github.com/fifengine/fifengine/issues/907","id":176007254,"number":907,"title":"How to package fifengine correctly?","user":{"login":"jakoch","id":85608,"avatar_url":"https://avatars.githubusercontent.com/u/85608?v=3","gravatar_id":"","url":"https://api.github.com/users/jakoch","html_url":"https://github.com/jakoch","followers_url":"https://api.github.com/users/jakoch/followers","following_url":"https://api.github.com/users/jakoch/following{/other_user}","gists_url":"https://api.github.com/users/jakoch/gists{/gist_id}","starred_url":"https://api.github.com/users/jakoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakoch/subscriptions","organizations_url":"https://api.github.com/users/jakoch/orgs","repos_url":"https://api.github.com/users/jakoch/repos","events_url":"https://api.github.com/users/jakoch/events{/privacy}","received_events_url":"https://api.github.com/users/jakoch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-09T13:18:45Z","updated_at":"2016-09-12T14:58:07Z","closed_at":null,"body":"I need some guidance on what to package for which target.\r\n\r\n**Appveyor  - MSVC**\r\nThe current release for MSVC looks like this:\r\nhttps://ci.appveyor.com/api/buildjobs/1jr93aqlgoexunv6/artifacts/fifengine-VC.zip\r\n\r\n- Is the name correct? Or should this be `libfife-VC.zip`\r\n- Should `fifechan` be included? \r\n- To support a C++ upstream project (e.g. the [cpp-tutorial1](https://github.com/fifengine/cpp-tutorials/blob/master/src/tutorial_1/CMakeLists.txt)), we need to add the header includes and somehow generate a shared binary file `fifengine.dll`, right? Shared lib is not in the CMakeList.txt, yet, right?\r\n- I guess the C++ header includes are not needed for a Python client, right?\r\n  - https://github.com/fifengine/fifengine/blob/master/CMakeLists.txt#L496-L503\r\n  - Should we release separately for Python and C++ clients?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/fifengine/fifengine/issues/comments/246375313","html_url":"https://github.com/fifengine/fifengine/issues/907#issuecomment-246375313","issue_url":"https://api.github.com/repos/fifengine/fifengine/issues/907","id":246375313,"user":{"login":"prock-fife","id":801221,"avatar_url":"https://avatars.githubusercontent.com/u/801221?v=3","gravatar_id":"","url":"https://api.github.com/users/prock-fife","html_url":"https://github.com/prock-fife","followers_url":"https://api.github.com/users/prock-fife/followers","following_url":"https://api.github.com/users/prock-fife/following{/other_user}","gists_url":"https://api.github.com/users/prock-fife/gists{/gist_id}","starred_url":"https://api.github.com/users/prock-fife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prock-fife/subscriptions","organizations_url":"https://api.github.com/users/prock-fife/orgs","repos_url":"https://api.github.com/users/prock-fife/repos","events_url":"https://api.github.com/users/prock-fife/events{/privacy}","received_events_url":"https://api.github.com/users/prock-fife/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T14:58:07Z","updated_at":"2016-09-12T14:58:07Z","body":"> I copied the pyd and lib. But i'm also not sure, if i need to copy all dependency dlls there.\r\n\r\nThe python installer should have all required libraries in it so someone can start using the python library right after installing it.  I have no way to test it at the moment.\r\n\r\nIs the dependencies zip intended to be for exactly? "}}
{"actor":{"display_login":"prock-fife"}}