{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/67180282","id":67180282,"diff_hunk":"@@ -254,18 +254,16 @@ def raw(self):\n     def __iter__(self):\n         return iter(self._do_search())\n \n-    def raw_facets(self):\n-        return self._do_search().results.get('facets', {})\n+    def raw_aggregations(self):\n+        return self._do_search().results.get('aggregations', {})\n \n     @property\n-    def facets(self):\n-        facets = {}\n-        for key, val in self.raw_facets().items():\n-            if val['_type'] == 'terms':\n-                facets[key] = [v for v in val['terms']]\n-            elif val['_type'] == 'range':\n-                facets[key] = [v for v in val['ranges']]\n-        return facets\n+    def aggregations(self):","path":"src/olympia/amo/search.py","position":68,"original_position":68,"commit_id":"8da2edadeca1ab6d2dac05ffa64079b5bd973661","original_commit_id":"8da2edadeca1ab6d2dac05ffa64079b5bd973661","user":{"login":"EnTeQuAk","id":139033,"avatar_url":"https://avatars.githubusercontent.com/u/139033?v=3","gravatar_id":"","url":"https://api.github.com/users/EnTeQuAk","html_url":"https://github.com/EnTeQuAk","followers_url":"https://api.github.com/users/EnTeQuAk/followers","following_url":"https://api.github.com/users/EnTeQuAk/following{/other_user}","gists_url":"https://api.github.com/users/EnTeQuAk/gists{/gist_id}","starred_url":"https://api.github.com/users/EnTeQuAk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnTeQuAk/subscriptions","organizations_url":"https://api.github.com/users/EnTeQuAk/orgs","repos_url":"https://api.github.com/users/EnTeQuAk/repos","events_url":"https://api.github.com/users/EnTeQuAk/events{/privacy}","received_events_url":"https://api.github.com/users/EnTeQuAk/received_events","type":"User","site_admin":false},"body":"I would love to see a small test that verifies it works as expected. I don't see any edgecases so it should be reasonable to do.","created_at":"2016-06-15T15:07:51Z","updated_at":"2016-06-15T15:07:51Z","html_url":"https://github.com/mozilla/addons-server/pull/2899#discussion_r67180282","pull_request_url":"https://api.github.com/repos/mozilla/addons-server/pulls/2899","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments/67180282"},"html":{"href":"https://github.com/mozilla/addons-server/pull/2899#discussion_r67180282"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2899"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-server/pulls/2899","id":73917591,"html_url":"https://github.com/mozilla/addons-server/pull/2899","diff_url":"https://github.com/mozilla/addons-server/pull/2899.diff","patch_url":"https://github.com/mozilla/addons-server/pull/2899.patch","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/2899","number":2899,"state":"open","locked":false,"title":"Replace elasticsearch facets queries with aggregation queries","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"Facets are deprecated and removed in Elasticsearch 2.x","created_at":"2016-06-15T14:05:54Z","updated_at":"2016-06-15T15:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"388afa3e9e9d872952cbffdbdd40b1a2eacc27d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-server/pulls/2899/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-server/pulls/2899/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/2899/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/8da2edadeca1ab6d2dac05ffa64079b5bd973661","head":{"label":"diox:facets-to-aggregations","ref":"facets-to-aggregations","sha":"8da2edadeca1ab6d2dac05ffa64079b5bd973661","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"repo":{"id":16844921,"name":"olympia","full_name":"diox/olympia","owner":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diox/olympia","description":"AMO, reloaded.","fork":true,"url":"https://api.github.com/repos/diox/olympia","forks_url":"https://api.github.com/repos/diox/olympia/forks","keys_url":"https://api.github.com/repos/diox/olympia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diox/olympia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diox/olympia/teams","hooks_url":"https://api.github.com/repos/diox/olympia/hooks","issue_events_url":"https://api.github.com/repos/diox/olympia/issues/events{/number}","events_url":"https://api.github.com/repos/diox/olympia/events","assignees_url":"https://api.github.com/repos/diox/olympia/assignees{/user}","branches_url":"https://api.github.com/repos/diox/olympia/branches{/branch}","tags_url":"https://api.github.com/repos/diox/olympia/tags","blobs_url":"https://api.github.com/repos/diox/olympia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diox/olympia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diox/olympia/git/refs{/sha}","trees_url":"https://api.github.com/repos/diox/olympia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diox/olympia/statuses/{sha}","languages_url":"https://api.github.com/repos/diox/olympia/languages","stargazers_url":"https://api.github.com/repos/diox/olympia/stargazers","contributors_url":"https://api.github.com/repos/diox/olympia/contributors","subscribers_url":"https://api.github.com/repos/diox/olympia/subscribers","subscription_url":"https://api.github.com/repos/diox/olympia/subscription","commits_url":"https://api.github.com/repos/diox/olympia/commits{/sha}","git_commits_url":"https://api.github.com/repos/diox/olympia/git/commits{/sha}","comments_url":"https://api.github.com/repos/diox/olympia/comments{/number}","issue_comment_url":"https://api.github.com/repos/diox/olympia/issues/comments{/number}","contents_url":"https://api.github.com/repos/diox/olympia/contents/{+path}","compare_url":"https://api.github.com/repos/diox/olympia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diox/olympia/merges","archive_url":"https://api.github.com/repos/diox/olympia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diox/olympia/downloads","issues_url":"https://api.github.com/repos/diox/olympia/issues{/number}","pulls_url":"https://api.github.com/repos/diox/olympia/pulls{/number}","milestones_url":"https://api.github.com/repos/diox/olympia/milestones{/number}","notifications_url":"https://api.github.com/repos/diox/olympia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diox/olympia/labels{/name}","releases_url":"https://api.github.com/repos/diox/olympia/releases{/id}","deployments_url":"https://api.github.com/repos/diox/olympia/deployments","created_at":"2014-02-14T17:54:49Z","updated_at":"2014-12-16T18:15:35Z","pushed_at":"2016-06-15T14:59:15Z","git_url":"git://github.com/diox/olympia.git","ssh_url":"git@github.com:diox/olympia.git","clone_url":"https://github.com/diox/olympia.git","svn_url":"https://github.com/diox/olympia","homepage":"","size":540935,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6934e06fb7982b123148ef6673447809e1193082","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":16416867,"name":"addons-server","full_name":"mozilla/addons-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-server","description":"addons.mozilla.org Django app","fork":false,"url":"https://api.github.com/repos/mozilla/addons-server","forks_url":"https://api.github.com/repos/mozilla/addons-server/forks","keys_url":"https://api.github.com/repos/mozilla/addons-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-server/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-server/events","assignees_url":"https://api.github.com/repos/mozilla/addons-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-server/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-server/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-server/merges","archive_url":"https://api.github.com/repos/mozilla/addons-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-server/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/addons-server/deployments","created_at":"2014-01-31T18:44:15Z","updated_at":"2016-06-06T17:06:30Z","pushed_at":"2016-06-15T15:00:27Z","git_url":"git://github.com/mozilla/addons-server.git","ssh_url":"git@github.com:mozilla/addons-server.git","clone_url":"https://github.com/mozilla/addons-server.git","svn_url":"https://github.com/mozilla/addons-server","homepage":"https://addons.mozilla.org/","size":568402,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":237,"forks":154,"open_issues":237,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2899"},"html":{"href":"https://github.com/mozilla/addons-server/pull/2899"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/2899"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-server/issues/2899/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2899/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-server/pulls/2899/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-server/statuses/8da2edadeca1ab6d2dac05ffa64079b5bd973661"}}}}
{"actor":{"display_login":"EnTeQuAk"}}