{"action":"created","issue":{"url":"https://api.github.com/repos/matrix-org/synapse/issues/1640","repository_url":"https://api.github.com/repos/matrix-org/synapse","labels_url":"https://api.github.com/repos/matrix-org/synapse/issues/1640/labels{/name}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/1640/comments","events_url":"https://api.github.com/repos/matrix-org/synapse/issues/1640/events","html_url":"https://github.com/matrix-org/synapse/pull/1640","id":191060146,"number":1640,"title":"Return early on /sync code paths if a '*' filter is used","user":{"login":"Kegsay","id":7190048,"avatar_url":"https://avatars.githubusercontent.com/u/7190048?v=3","gravatar_id":"","url":"https://api.github.com/users/Kegsay","html_url":"https://github.com/Kegsay","followers_url":"https://api.github.com/users/Kegsay/followers","following_url":"https://api.github.com/users/Kegsay/following{/other_user}","gists_url":"https://api.github.com/users/Kegsay/gists{/gist_id}","starred_url":"https://api.github.com/users/Kegsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kegsay/subscriptions","organizations_url":"https://api.github.com/users/Kegsay/orgs","repos_url":"https://api.github.com/users/Kegsay/repos","events_url":"https://api.github.com/users/Kegsay/events{/privacy}","received_events_url":"https://api.github.com/users/Kegsay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"erikjohnston","id":8428120,"avatar_url":"https://avatars.githubusercontent.com/u/8428120?v=3","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false},"assignees":[{"login":"erikjohnston","id":8428120,"avatar_url":"https://avatars.githubusercontent.com/u/8428120?v=3","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-22T16:45:08Z","updated_at":"2016-11-22T16:59:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/1640","html_url":"https://github.com/matrix-org/synapse/pull/1640","diff_url":"https://github.com/matrix-org/synapse/pull/1640.diff","patch_url":"https://github.com/matrix-org/synapse/pull/1640.patch"},"body":"Currently checks for `*` filters on:\r\n - Presence events\r\n - Ephemeral room events\r\n - Room timeline events\r\n\r\nThis is currently very conservative in that it only does this if there is no\r\n`since` token. This limits the risk to clients likely to be doing one-off\r\nsyncs (like bridges), but does mean that normal human clients won't benefit\r\nfrom the time savings here. If the savings are large enough, I would consider\r\ngeneralising this to just check the filter."},"comment":{"url":"https://api.github.com/repos/matrix-org/synapse/issues/comments/262298892","html_url":"https://github.com/matrix-org/synapse/pull/1640#issuecomment-262298892","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/1640","id":262298892,"user":{"login":"erikjohnston","id":8428120,"avatar_url":"https://avatars.githubusercontent.com/u/8428120?v=3","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T16:59:42Z","updated_at":"2016-11-22T16:59:42Z","body":"lgtm"}}
{"actor":{"display_login":"erikjohnston"}}