{"action":"closed","number":88,"pull_request":{"url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/88","id":97990756,"html_url":"https://github.com/Kinvey/js-sdk/pull/88","diff_url":"https://github.com/Kinvey/js-sdk/pull/88.diff","patch_url":"https://github.com/Kinvey/js-sdk/pull/88.patch","issue_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/88","number":88,"state":"closed","locked":false,"title":"Bugfix for sync() not persisting pulled entities","user":{"login":"tejasranade","id":1953831,"avatar_url":"https://avatars.githubusercontent.com/u/1953831?v=3","gravatar_id":"","url":"https://api.github.com/users/tejasranade","html_url":"https://github.com/tejasranade","followers_url":"https://api.github.com/users/tejasranade/followers","following_url":"https://api.github.com/users/tejasranade/following{/other_user}","gists_url":"https://api.github.com/users/tejasranade/gists{/gist_id}","starred_url":"https://api.github.com/users/tejasranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejasranade/subscriptions","organizations_url":"https://api.github.com/users/tejasranade/orgs","repos_url":"https://api.github.com/users/tejasranade/repos","events_url":"https://api.github.com/users/tejasranade/events{/privacy}","received_events_url":"https://api.github.com/users/tejasranade/received_events","type":"User","site_admin":false},"body":"#### Description\r\nRefers to MLIBZ-1553\r\n\r\nOn the `SyncStore`, the `sync()` method fails to persist the entities that are pulled from the backend. The `pull()` method works as intended.\r\n\r\n#### Changes\r\n\r\nThe solution is to not delegate `sync()` to the `syncManager`, but instead implement it in the store itself. This way, the `push` and `pull` methods of the store get used.\r\n\r\n#### Tests\r\n\r\nAdded a new unit test for `store.sync()`.\r\n","created_at":"2016-12-14T16:48:11Z","updated_at":"2016-12-14T20:49:57Z","closed_at":"2016-12-14T20:49:57Z","merged_at":"2016-12-14T20:49:57Z","merge_commit_sha":"ab2a79daf27ccc3c137081d2c9f2cacaab81bc26","assignee":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars.githubusercontent.com/u/950052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"assignees":[{"login":"thomasconner","id":950052,"avatar_url":"https://avatars.githubusercontent.com/u/950052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/88/commits","review_comments_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/88/comments","review_comment_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/88/comments","statuses_url":"https://api.github.com/repos/Kinvey/js-sdk/statuses/50f98ea558480608ba02cf790a844c3e34c546b7","head":{"label":"Kinvey:MLIBZ-1553_sync_bug","ref":"MLIBZ-1553_sync_bug","sha":"50f98ea558480608ba02cf790a844c3e34c546b7","user":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"repo":{"id":30971013,"name":"js-sdk","full_name":"Kinvey/js-sdk","owner":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinvey/js-sdk","description":"JavaScript Core SDK - shared code for all Kinvey JS SDKs","fork":false,"url":"https://api.github.com/repos/Kinvey/js-sdk","forks_url":"https://api.github.com/repos/Kinvey/js-sdk/forks","keys_url":"https://api.github.com/repos/Kinvey/js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinvey/js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinvey/js-sdk/teams","hooks_url":"https://api.github.com/repos/Kinvey/js-sdk/hooks","issue_events_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Kinvey/js-sdk/events","assignees_url":"https://api.github.com/repos/Kinvey/js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Kinvey/js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Kinvey/js-sdk/tags","blobs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinvey/js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinvey/js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinvey/js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinvey/js-sdk/languages","stargazers_url":"https://api.github.com/repos/Kinvey/js-sdk/stargazers","contributors_url":"https://api.github.com/repos/Kinvey/js-sdk/contributors","subscribers_url":"https://api.github.com/repos/Kinvey/js-sdk/subscribers","subscription_url":"https://api.github.com/repos/Kinvey/js-sdk/subscription","commits_url":"https://api.github.com/repos/Kinvey/js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinvey/js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinvey/js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinvey/js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Kinvey/js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinvey/js-sdk/merges","archive_url":"https://api.github.com/repos/Kinvey/js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinvey/js-sdk/downloads","issues_url":"https://api.github.com/repos/Kinvey/js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinvey/js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinvey/js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinvey/js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Kinvey/js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Kinvey/js-sdk/deployments","created_at":"2015-02-18T15:20:34Z","updated_at":"2016-12-06T20:42:56Z","pushed_at":"2016-12-14T20:49:57Z","git_url":"git://github.com/Kinvey/js-sdk.git","ssh_url":"git@github.com:Kinvey/js-sdk.git","clone_url":"https://github.com/Kinvey/js-sdk.git","svn_url":"https://github.com/Kinvey/js-sdk","homepage":"http://devcenter.kinvey.com","size":23488,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"Kinvey:master","ref":"master","sha":"24935ff410e21b59d0878ce8b3842761af101366","user":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"repo":{"id":30971013,"name":"js-sdk","full_name":"Kinvey/js-sdk","owner":{"login":"Kinvey","id":1276480,"avatar_url":"https://avatars.githubusercontent.com/u/1276480?v=3","gravatar_id":"","url":"https://api.github.com/users/Kinvey","html_url":"https://github.com/Kinvey","followers_url":"https://api.github.com/users/Kinvey/followers","following_url":"https://api.github.com/users/Kinvey/following{/other_user}","gists_url":"https://api.github.com/users/Kinvey/gists{/gist_id}","starred_url":"https://api.github.com/users/Kinvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kinvey/subscriptions","organizations_url":"https://api.github.com/users/Kinvey/orgs","repos_url":"https://api.github.com/users/Kinvey/repos","events_url":"https://api.github.com/users/Kinvey/events{/privacy}","received_events_url":"https://api.github.com/users/Kinvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kinvey/js-sdk","description":"JavaScript Core SDK - shared code for all Kinvey JS SDKs","fork":false,"url":"https://api.github.com/repos/Kinvey/js-sdk","forks_url":"https://api.github.com/repos/Kinvey/js-sdk/forks","keys_url":"https://api.github.com/repos/Kinvey/js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kinvey/js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kinvey/js-sdk/teams","hooks_url":"https://api.github.com/repos/Kinvey/js-sdk/hooks","issue_events_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Kinvey/js-sdk/events","assignees_url":"https://api.github.com/repos/Kinvey/js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Kinvey/js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Kinvey/js-sdk/tags","blobs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kinvey/js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kinvey/js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kinvey/js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kinvey/js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Kinvey/js-sdk/languages","stargazers_url":"https://api.github.com/repos/Kinvey/js-sdk/stargazers","contributors_url":"https://api.github.com/repos/Kinvey/js-sdk/contributors","subscribers_url":"https://api.github.com/repos/Kinvey/js-sdk/subscribers","subscription_url":"https://api.github.com/repos/Kinvey/js-sdk/subscription","commits_url":"https://api.github.com/repos/Kinvey/js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kinvey/js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kinvey/js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kinvey/js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kinvey/js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Kinvey/js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kinvey/js-sdk/merges","archive_url":"https://api.github.com/repos/Kinvey/js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kinvey/js-sdk/downloads","issues_url":"https://api.github.com/repos/Kinvey/js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Kinvey/js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Kinvey/js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Kinvey/js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kinvey/js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Kinvey/js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Kinvey/js-sdk/deployments","created_at":"2015-02-18T15:20:34Z","updated_at":"2016-12-06T20:42:56Z","pushed_at":"2016-12-14T20:49:57Z","git_url":"git://github.com/Kinvey/js-sdk.git","ssh_url":"git@github.com:Kinvey/js-sdk.git","clone_url":"https://github.com/Kinvey/js-sdk.git","svn_url":"https://github.com/Kinvey/js-sdk","homepage":"http://devcenter.kinvey.com","size":23488,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/88"},"html":{"href":"https://github.com/Kinvey/js-sdk/pull/88"},"issue":{"href":"https://api.github.com/repos/Kinvey/js-sdk/issues/88"},"comments":{"href":"https://api.github.com/repos/Kinvey/js-sdk/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kinvey/js-sdk/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/Kinvey/js-sdk/statuses/50f98ea558480608ba02cf790a844c3e34c546b7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thomasconner","id":950052,"avatar_url":"https://avatars.githubusercontent.com/u/950052?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasconner","html_url":"https://github.com/thomasconner","followers_url":"https://api.github.com/users/thomasconner/followers","following_url":"https://api.github.com/users/thomasconner/following{/other_user}","gists_url":"https://api.github.com/users/thomasconner/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasconner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasconner/subscriptions","organizations_url":"https://api.github.com/users/thomasconner/orgs","repos_url":"https://api.github.com/users/thomasconner/repos","events_url":"https://api.github.com/users/thomasconner/events{/privacy}","received_events_url":"https://api.github.com/users/thomasconner/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":47,"deletions":16,"changed_files":3}}
{"actor":{"display_login":"thomasconner"}}