{"action":"created","comment":{"url":"https://api.github.com/repos/romana/romana/pulls/comments/54521673","id":54521673,"diff_hunk":"@@ -0,0 +1,36 @@\n+---\n+# Ensure stack nodes are ready for installation\n+- hosts: stack_nodes\n+  tasks:\n+    - name: Wait for cloud-init to complete\n+      wait_for: path=\"/var/lib/cloud/instance/boot-finished\" state=present\n+\n+# Apply common settings to all nodes prior to installation\n+- hosts: stack_nodes\n+  roles:\n+    - system/ubuntu\n+\n+# Include stack playbooks. Only the configured stack will be installed.\n+- include: config.devstack.yml\n+# - include: config.openstack.yml\n+- include: config.kubernetes.yml\n+\n+# Install Romana\n+- hosts: controller\n+  roles:\n+    - romana/install-master\n+\n+# Include romana+stack playbooks. Only the configured stack will be applied\n+- include: romana.devstack.yml","path":"romana-install/config.yml","position":24,"original_position":24,"commit_id":"f5e868881ff5a9fded1388dc2a8822702bd7f311","original_commit_id":"f5e868881ff5a9fded1388dc2a8822702bd7f311","user":{"login":"jbrendel","id":233741,"avatar_url":"https://avatars.githubusercontent.com/u/233741?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrendel","html_url":"https://github.com/jbrendel","followers_url":"https://api.github.com/users/jbrendel/followers","following_url":"https://api.github.com/users/jbrendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrendel/subscriptions","organizations_url":"https://api.github.com/users/jbrendel/orgs","repos_url":"https://api.github.com/users/jbrendel/repos","events_url":"https://api.github.com/users/jbrendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrendel/received_events","type":"User","site_admin":false},"body":"\"When\" on the include?","created_at":"2016-03-01T04:27:38Z","updated_at":"2016-03-01T04:27:38Z","html_url":"https://github.com/romana/romana/pull/76#discussion_r54521673","pull_request_url":"https://api.github.com/repos/romana/romana/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/romana/romana/pulls/comments/54521673"},"html":{"href":"https://github.com/romana/romana/pull/76#discussion_r54521673"},"pull_request":{"href":"https://api.github.com/repos/romana/romana/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/romana/romana/pulls/76","id":61021134,"html_url":"https://github.com/romana/romana/pull/76","diff_url":"https://github.com/romana/romana/pull/76.diff","patch_url":"https://github.com/romana/romana/pull/76.patch","issue_url":"https://api.github.com/repos/romana/romana/issues/76","number":76,"state":"open","locked":false,"title":"Kubernetes installation target for romana-setup","user":{"login":"cgilmour","id":892558,"avatar_url":"https://avatars.githubusercontent.com/u/892558?v=3","gravatar_id":"","url":"https://api.github.com/users/cgilmour","html_url":"https://github.com/cgilmour","followers_url":"https://api.github.com/users/cgilmour/followers","following_url":"https://api.github.com/users/cgilmour/following{/other_user}","gists_url":"https://api.github.com/users/cgilmour/gists{/gist_id}","starred_url":"https://api.github.com/users/cgilmour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgilmour/subscriptions","organizations_url":"https://api.github.com/users/cgilmour/orgs","repos_url":"https://api.github.com/users/cgilmour/repos","events_url":"https://api.github.com/users/cgilmour/events{/privacy}","received_events_url":"https://api.github.com/users/cgilmour/received_events","type":"User","site_admin":false},"body":"Fairly large changes made in romana-install to support having four combinations with Romana installed\r\n1) AWS + Devstack -- romana-setup (without options)\r\n2) AWS + Kubernetes -- romana-setup -s kubernetes\r\n3) Vagrant + Devstack -- romana-setup -p vagrant\r\n4) Vagrant + Kubernetes -- romana-setup -p vagrant -s kubernetes\r\n\r\nDocumentation updates will follow after the functionality is reviewed and tested, so I'm initiating a PR now instead of later on.\r\n\r\nSpecial note: To make it easier for users on AWS, they don't need to have their EC2 key provided or update the 'shared-key-1' thing. However, to make it easier for them, it's harder for us. To use the same EC2 key for people across a team, there's a one-time action: `echo \"shared-key-1\" > ~/.aws/ec2_keypair`\r\n\r\nAlso note, because this branch name matches a folder at the top of the repo, if you're checking out the branch to test, you need to add `--` to the end of the command, eg: `git checkout kubernetes --`","created_at":"2016-02-29T02:48:40Z","updated_at":"2016-03-01T04:27:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e86641dd56eda5389d5ba2fd3e5100b4fe8afbd4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/romana/romana/pulls/76/commits","review_comments_url":"https://api.github.com/repos/romana/romana/pulls/76/comments","review_comment_url":"https://api.github.com/repos/romana/romana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/romana/romana/issues/76/comments","statuses_url":"https://api.github.com/repos/romana/romana/statuses/f5e868881ff5a9fded1388dc2a8822702bd7f311","head":{"label":"romana:kubernetes","ref":"kubernetes","sha":"f5e868881ff5a9fded1388dc2a8822702bd7f311","user":{"login":"romana","id":9849297,"avatar_url":"https://avatars.githubusercontent.com/u/9849297?v=3","gravatar_id":"","url":"https://api.github.com/users/romana","html_url":"https://github.com/romana","followers_url":"https://api.github.com/users/romana/followers","following_url":"https://api.github.com/users/romana/following{/other_user}","gists_url":"https://api.github.com/users/romana/gists{/gist_id}","starred_url":"https://api.github.com/users/romana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romana/subscriptions","organizations_url":"https://api.github.com/users/romana/orgs","repos_url":"https://api.github.com/users/romana/repos","events_url":"https://api.github.com/users/romana/events{/privacy}","received_events_url":"https://api.github.com/users/romana/received_events","type":"Organization","site_admin":false},"repo":{"id":46245975,"name":"romana","full_name":"romana/romana","owner":{"login":"romana","id":9849297,"avatar_url":"https://avatars.githubusercontent.com/u/9849297?v=3","gravatar_id":"","url":"https://api.github.com/users/romana","html_url":"https://github.com/romana","followers_url":"https://api.github.com/users/romana/followers","following_url":"https://api.github.com/users/romana/following{/other_user}","gists_url":"https://api.github.com/users/romana/gists{/gist_id}","starred_url":"https://api.github.com/users/romana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romana/subscriptions","organizations_url":"https://api.github.com/users/romana/orgs","repos_url":"https://api.github.com/users/romana/repos","events_url":"https://api.github.com/users/romana/events{/privacy}","received_events_url":"https://api.github.com/users/romana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/romana/romana","description":"The Romana Project - Installation scripts, documentation, issue tracker and wiki. Start here.","fork":false,"url":"https://api.github.com/repos/romana/romana","forks_url":"https://api.github.com/repos/romana/romana/forks","keys_url":"https://api.github.com/repos/romana/romana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romana/romana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romana/romana/teams","hooks_url":"https://api.github.com/repos/romana/romana/hooks","issue_events_url":"https://api.github.com/repos/romana/romana/issues/events{/number}","events_url":"https://api.github.com/repos/romana/romana/events","assignees_url":"https://api.github.com/repos/romana/romana/assignees{/user}","branches_url":"https://api.github.com/repos/romana/romana/branches{/branch}","tags_url":"https://api.github.com/repos/romana/romana/tags","blobs_url":"https://api.github.com/repos/romana/romana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romana/romana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romana/romana/git/refs{/sha}","trees_url":"https://api.github.com/repos/romana/romana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romana/romana/statuses/{sha}","languages_url":"https://api.github.com/repos/romana/romana/languages","stargazers_url":"https://api.github.com/repos/romana/romana/stargazers","contributors_url":"https://api.github.com/repos/romana/romana/contributors","subscribers_url":"https://api.github.com/repos/romana/romana/subscribers","subscription_url":"https://api.github.com/repos/romana/romana/subscription","commits_url":"https://api.github.com/repos/romana/romana/commits{/sha}","git_commits_url":"https://api.github.com/repos/romana/romana/git/commits{/sha}","comments_url":"https://api.github.com/repos/romana/romana/comments{/number}","issue_comment_url":"https://api.github.com/repos/romana/romana/issues/comments{/number}","contents_url":"https://api.github.com/repos/romana/romana/contents/{+path}","compare_url":"https://api.github.com/repos/romana/romana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romana/romana/merges","archive_url":"https://api.github.com/repos/romana/romana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romana/romana/downloads","issues_url":"https://api.github.com/repos/romana/romana/issues{/number}","pulls_url":"https://api.github.com/repos/romana/romana/pulls{/number}","milestones_url":"https://api.github.com/repos/romana/romana/milestones{/number}","notifications_url":"https://api.github.com/repos/romana/romana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romana/romana/labels{/name}","releases_url":"https://api.github.com/repos/romana/romana/releases{/id}","deployments_url":"https://api.github.com/repos/romana/romana/deployments","created_at":"2015-11-16T02:02:24Z","updated_at":"2016-02-26T03:22:28Z","pushed_at":"2016-02-29T02:48:41Z","git_url":"git://github.com/romana/romana.git","ssh_url":"git@github.com:romana/romana.git","clone_url":"https://github.com/romana/romana.git","svn_url":"https://github.com/romana/romana","homepage":"","size":552,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":14,"default_branch":"master"}},"base":{"label":"romana:master","ref":"master","sha":"885ca319973e9dc5906b242d5b49ee6da9fdd9c8","user":{"login":"romana","id":9849297,"avatar_url":"https://avatars.githubusercontent.com/u/9849297?v=3","gravatar_id":"","url":"https://api.github.com/users/romana","html_url":"https://github.com/romana","followers_url":"https://api.github.com/users/romana/followers","following_url":"https://api.github.com/users/romana/following{/other_user}","gists_url":"https://api.github.com/users/romana/gists{/gist_id}","starred_url":"https://api.github.com/users/romana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romana/subscriptions","organizations_url":"https://api.github.com/users/romana/orgs","repos_url":"https://api.github.com/users/romana/repos","events_url":"https://api.github.com/users/romana/events{/privacy}","received_events_url":"https://api.github.com/users/romana/received_events","type":"Organization","site_admin":false},"repo":{"id":46245975,"name":"romana","full_name":"romana/romana","owner":{"login":"romana","id":9849297,"avatar_url":"https://avatars.githubusercontent.com/u/9849297?v=3","gravatar_id":"","url":"https://api.github.com/users/romana","html_url":"https://github.com/romana","followers_url":"https://api.github.com/users/romana/followers","following_url":"https://api.github.com/users/romana/following{/other_user}","gists_url":"https://api.github.com/users/romana/gists{/gist_id}","starred_url":"https://api.github.com/users/romana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romana/subscriptions","organizations_url":"https://api.github.com/users/romana/orgs","repos_url":"https://api.github.com/users/romana/repos","events_url":"https://api.github.com/users/romana/events{/privacy}","received_events_url":"https://api.github.com/users/romana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/romana/romana","description":"The Romana Project - Installation scripts, documentation, issue tracker and wiki. Start here.","fork":false,"url":"https://api.github.com/repos/romana/romana","forks_url":"https://api.github.com/repos/romana/romana/forks","keys_url":"https://api.github.com/repos/romana/romana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romana/romana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romana/romana/teams","hooks_url":"https://api.github.com/repos/romana/romana/hooks","issue_events_url":"https://api.github.com/repos/romana/romana/issues/events{/number}","events_url":"https://api.github.com/repos/romana/romana/events","assignees_url":"https://api.github.com/repos/romana/romana/assignees{/user}","branches_url":"https://api.github.com/repos/romana/romana/branches{/branch}","tags_url":"https://api.github.com/repos/romana/romana/tags","blobs_url":"https://api.github.com/repos/romana/romana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romana/romana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romana/romana/git/refs{/sha}","trees_url":"https://api.github.com/repos/romana/romana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romana/romana/statuses/{sha}","languages_url":"https://api.github.com/repos/romana/romana/languages","stargazers_url":"https://api.github.com/repos/romana/romana/stargazers","contributors_url":"https://api.github.com/repos/romana/romana/contributors","subscribers_url":"https://api.github.com/repos/romana/romana/subscribers","subscription_url":"https://api.github.com/repos/romana/romana/subscription","commits_url":"https://api.github.com/repos/romana/romana/commits{/sha}","git_commits_url":"https://api.github.com/repos/romana/romana/git/commits{/sha}","comments_url":"https://api.github.com/repos/romana/romana/comments{/number}","issue_comment_url":"https://api.github.com/repos/romana/romana/issues/comments{/number}","contents_url":"https://api.github.com/repos/romana/romana/contents/{+path}","compare_url":"https://api.github.com/repos/romana/romana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romana/romana/merges","archive_url":"https://api.github.com/repos/romana/romana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romana/romana/downloads","issues_url":"https://api.github.com/repos/romana/romana/issues{/number}","pulls_url":"https://api.github.com/repos/romana/romana/pulls{/number}","milestones_url":"https://api.github.com/repos/romana/romana/milestones{/number}","notifications_url":"https://api.github.com/repos/romana/romana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romana/romana/labels{/name}","releases_url":"https://api.github.com/repos/romana/romana/releases{/id}","deployments_url":"https://api.github.com/repos/romana/romana/deployments","created_at":"2015-11-16T02:02:24Z","updated_at":"2016-02-26T03:22:28Z","pushed_at":"2016-02-29T02:48:41Z","git_url":"git://github.com/romana/romana.git","ssh_url":"git@github.com:romana/romana.git","clone_url":"https://github.com/romana/romana.git","svn_url":"https://github.com/romana/romana","homepage":"","size":552,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/romana/romana/pulls/76"},"html":{"href":"https://github.com/romana/romana/pull/76"},"issue":{"href":"https://api.github.com/repos/romana/romana/issues/76"},"comments":{"href":"https://api.github.com/repos/romana/romana/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/romana/romana/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/romana/romana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/romana/romana/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/romana/romana/statuses/f5e868881ff5a9fded1388dc2a8822702bd7f311"}}}}