{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/78445094","id":78445094,"diff_hunk":"@@ -406,9 +407,9 @@ private TextSpan GetRegionSpanForReference(SourceText sourceText, TextSpan refer\n                 // Produce SymbolDisplayParts for both sets of ClassifiedSpans.  This will\n                 // also produce parts for the regions between the sections that the classifiers\n                 // returned results for (i.e. for things like spaces and plain text).\n-                var syntaxParts = Classifier.ConvertClassifications(\n+                var syntaxParts = Microsoft.CodeAnalysis.LanguageServices.SymbolDisplayClassificationHelper.ConvertClassifications(","path":"src/VisualStudio/Next/FindReferences/StreamingFindReferencesPresenter.TableDataSourceFindReferencesContext.cs","position":30,"original_position":30,"commit_id":"dfcbc673433f710a6fb4084ae68361e7e5e4918c","original_commit_id":"dfcbc673433f710a6fb4084ae68361e7e5e4918c","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"Why fully qualified?","created_at":"2016-09-12T20:10:06Z","updated_at":"2016-09-12T20:10:06Z","html_url":"https://github.com/dotnet/roslyn/pull/13741#discussion_r78445094","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13741","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/78445094"},"html":{"href":"https://github.com/dotnet/roslyn/pull/13741#discussion_r78445094"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13741"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/13741","id":84932177,"html_url":"https://github.com/dotnet/roslyn/pull/13741","diff_url":"https://github.com/dotnet/roslyn/pull/13741.diff","patch_url":"https://github.com/dotnet/roslyn/pull/13741.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/13741","number":13741,"state":"open","locked":false,"title":"editor targets workspace layer API directly","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"body":"@Pilchie @CyrusNajmabadi @DustinCampbell @dpoeschl @jasonmalinowski @rchande  please take look and comment on this draft change to the Classification Service API.\r\n\r\nThe interesting things that happened here is that the editor layer service got removed, and the workspace layer service got refactored.  A change to take note of is that the GetClassificationsXXXAsync API's now return an ImmutableArray of ClassifiedSpan's instead of passing a list in.  It appears this list argument enabled the API to optimally not cause any allocations, or quite few.  With the change, the returned list is allocated each time the API is used.  Of course, this needed to change for a variety of reasons, such as potentially using the API cross process boundaries and the fact that async methods with out-like args is an easy pit of failure for users.\r\n\r\nNote, the provider/classifier model has not been changed and has been left as a C#/VB only implementation detail, since it depends on syntax trees and symbols.  It is not intended to be made public.","created_at":"2016-09-12T19:46:05Z","updated_at":"2016-09-12T20:10:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39ca6b112e3f345672df0beba151e934a0f1ec99","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13741/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13741/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/13741/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/dfcbc673433f710a6fb4084ae68361e7e5e4918c","head":{"label":"mattwar:ClassificationAPI","ref":"ClassificationAPI","sha":"dfcbc673433f710a6fb4084ae68361e7e5e4918c","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"repo":{"id":30200787,"name":"roslyn","full_name":"mattwar/roslyn","owner":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattwar/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/mattwar/roslyn","forks_url":"https://api.github.com/repos/mattwar/roslyn/forks","keys_url":"https://api.github.com/repos/mattwar/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattwar/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattwar/roslyn/teams","hooks_url":"https://api.github.com/repos/mattwar/roslyn/hooks","issue_events_url":"https://api.github.com/repos/mattwar/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/mattwar/roslyn/events","assignees_url":"https://api.github.com/repos/mattwar/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/mattwar/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/mattwar/roslyn/tags","blobs_url":"https://api.github.com/repos/mattwar/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattwar/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattwar/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattwar/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattwar/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/mattwar/roslyn/languages","stargazers_url":"https://api.github.com/repos/mattwar/roslyn/stargazers","contributors_url":"https://api.github.com/repos/mattwar/roslyn/contributors","subscribers_url":"https://api.github.com/repos/mattwar/roslyn/subscribers","subscription_url":"https://api.github.com/repos/mattwar/roslyn/subscription","commits_url":"https://api.github.com/repos/mattwar/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattwar/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattwar/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattwar/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattwar/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/mattwar/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattwar/roslyn/merges","archive_url":"https://api.github.com/repos/mattwar/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattwar/roslyn/downloads","issues_url":"https://api.github.com/repos/mattwar/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/mattwar/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/mattwar/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/mattwar/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattwar/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/mattwar/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/mattwar/roslyn/deployments","created_at":"2015-02-02T18:12:54Z","updated_at":"2016-01-19T21:03:29Z","pushed_at":"2016-09-09T20:32:45Z","git_url":"git://github.com/mattwar/roslyn.git","ssh_url":"git@github.com:mattwar/roslyn.git","clone_url":"https://github.com/mattwar/roslyn.git","svn_url":"https://github.com/mattwar/roslyn","homepage":"","size":170102,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ed41c225e187b81cd55abb9d54d1d61feda39e5a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-09-12T19:47:17Z","pushed_at":"2016-09-12T19:50:00Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":333975,"stargazers_count":6197,"watchers_count":6197,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1481,"mirror_url":null,"open_issues_count":3191,"forks":1481,"open_issues":3191,"watchers":6197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13741"},"html":{"href":"https://github.com/dotnet/roslyn/pull/13741"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/13741"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/13741/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13741/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13741/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/dfcbc673433f710a6fb4084ae68361e7e5e4918c"}}}}
{"actor":{"display_login":"CyrusNajmabadi"}}