{"action":"created","comment":{"url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/comments/54703131","id":54703131,"diff_hunk":"@@ -87,6 +86,7 @@ public void run(SourceContext<WindowedValue<T>> ctx) throws Exception {\n \t\t\t\tcontext.collectWithTimestamp(makeWindowedValue(item, timestamp), timestamp.getMillis());\n \t\t\t}\n \n+\t\t\t// TODO: This will run the loop only until the underlying reader first indicates input has stalled.\n \t\t\t// try to go to the next record","path":"src/main/java/com/dataartisans/flink/dataflow/translation/wrappers/streaming/io/UnboundedSourceWrapper.java","position":22,"original_position":22,"commit_id":"95755323fb4630b6d0741c308e730c5446c17d21","original_commit_id":"95755323fb4630b6d0741c308e730c5446c17d21","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"Agreed. We should wait instead of busy blocking.","created_at":"2016-03-02T10:08:55Z","updated_at":"2016-03-02T10:08:55Z","html_url":"https://github.com/dataArtisans/flink-dataflow/pull/16#discussion_r54703131","pull_request_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/comments/54703131"},"html":{"href":"https://github.com/dataArtisans/flink-dataflow/pull/16#discussion_r54703131"},"pull_request":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16","id":61300955,"html_url":"https://github.com/dataArtisans/flink-dataflow/pull/16","diff_url":"https://github.com/dataArtisans/flink-dataflow/pull/16.diff","patch_url":"https://github.com/dataArtisans/flink-dataflow/pull/16.patch","issue_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues/16","number":16,"state":"open","locked":false,"title":"Update runner to Flink 1.0-SNAPSHOT and Beam 1.5.0-SNAPSHOT","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"body":"[This is a few commits behind HEAD, I'll fix that next].\r\n\r\nTrack changes made to Beam (nee Google Dataflow) from 1.0 to 1.5.0-SNAPSHOT.\r\nBiggest changes are in the FlinkGroupAlsoByWindowsWrapper and FlinkStateInternals.\r\nUpdate the units tests.\r\n\r\nIssues:\r\n* FlinkStateInternals will need to be reworked to use the native Flink per-key state.\r\n* PipelineOptions need to be explicitly serialized/deserialized onto the workers.\r\n* Not ready for production use, but neither is Beam currently so that's fine.\r\n ","created_at":"2016-03-01T20:12:45Z","updated_at":"2016-03-02T10:08:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d783c40f8f888852254d0c693301b08c09c9ebf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16/commits","review_comments_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16/comments","review_comment_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues/16/comments","statuses_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/statuses/95755323fb4630b6d0741c308e730c5446c17d21","head":{"label":"mshields822:master","ref":"master","sha":"95755323fb4630b6d0741c308e730c5446c17d21","user":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"repo":{"id":52641581,"name":"flink-dataflow","full_name":"mshields822/flink-dataflow","owner":{"login":"mshields822","id":11642236,"avatar_url":"https://avatars.githubusercontent.com/u/11642236?v=3","gravatar_id":"","url":"https://api.github.com/users/mshields822","html_url":"https://github.com/mshields822","followers_url":"https://api.github.com/users/mshields822/followers","following_url":"https://api.github.com/users/mshields822/following{/other_user}","gists_url":"https://api.github.com/users/mshields822/gists{/gist_id}","starred_url":"https://api.github.com/users/mshields822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshields822/subscriptions","organizations_url":"https://api.github.com/users/mshields822/orgs","repos_url":"https://api.github.com/users/mshields822/repos","events_url":"https://api.github.com/users/mshields822/events{/privacy}","received_events_url":"https://api.github.com/users/mshields822/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mshields822/flink-dataflow","description":"Google Dataflow Runner for Apache Flink","fork":true,"url":"https://api.github.com/repos/mshields822/flink-dataflow","forks_url":"https://api.github.com/repos/mshields822/flink-dataflow/forks","keys_url":"https://api.github.com/repos/mshields822/flink-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mshields822/flink-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mshields822/flink-dataflow/teams","hooks_url":"https://api.github.com/repos/mshields822/flink-dataflow/hooks","issue_events_url":"https://api.github.com/repos/mshields822/flink-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/mshields822/flink-dataflow/events","assignees_url":"https://api.github.com/repos/mshields822/flink-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/mshields822/flink-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/mshields822/flink-dataflow/tags","blobs_url":"https://api.github.com/repos/mshields822/flink-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mshields822/flink-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mshields822/flink-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mshields822/flink-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mshields822/flink-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/mshields822/flink-dataflow/languages","stargazers_url":"https://api.github.com/repos/mshields822/flink-dataflow/stargazers","contributors_url":"https://api.github.com/repos/mshields822/flink-dataflow/contributors","subscribers_url":"https://api.github.com/repos/mshields822/flink-dataflow/subscribers","subscription_url":"https://api.github.com/repos/mshields822/flink-dataflow/subscription","commits_url":"https://api.github.com/repos/mshields822/flink-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mshields822/flink-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mshields822/flink-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mshields822/flink-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mshields822/flink-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/mshields822/flink-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mshields822/flink-dataflow/merges","archive_url":"https://api.github.com/repos/mshields822/flink-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mshields822/flink-dataflow/downloads","issues_url":"https://api.github.com/repos/mshields822/flink-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/mshields822/flink-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/mshields822/flink-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/mshields822/flink-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mshields822/flink-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/mshields822/flink-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/mshields822/flink-dataflow/deployments","created_at":"2016-02-27T00:24:51Z","updated_at":"2016-02-27T00:24:52Z","pushed_at":"2016-03-01T21:15:15Z","git_url":"git://github.com/mshields822/flink-dataflow.git","ssh_url":"git@github.com:mshields822/flink-dataflow.git","clone_url":"https://github.com/mshields822/flink-dataflow.git","svn_url":"https://github.com/mshields822/flink-dataflow","homepage":null,"size":451,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dataArtisans:master","ref":"master","sha":"0ea22e405615e81a45231b6cfa6cf3f01b00db01","user":{"login":"dataArtisans","id":10691110,"avatar_url":"https://avatars.githubusercontent.com/u/10691110?v=3","gravatar_id":"","url":"https://api.github.com/users/dataArtisans","html_url":"https://github.com/dataArtisans","followers_url":"https://api.github.com/users/dataArtisans/followers","following_url":"https://api.github.com/users/dataArtisans/following{/other_user}","gists_url":"https://api.github.com/users/dataArtisans/gists{/gist_id}","starred_url":"https://api.github.com/users/dataArtisans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataArtisans/subscriptions","organizations_url":"https://api.github.com/users/dataArtisans/orgs","repos_url":"https://api.github.com/users/dataArtisans/repos","events_url":"https://api.github.com/users/dataArtisans/events{/privacy}","received_events_url":"https://api.github.com/users/dataArtisans/received_events","type":"Organization","site_admin":false},"repo":{"id":31009769,"name":"flink-dataflow","full_name":"dataArtisans/flink-dataflow","owner":{"login":"dataArtisans","id":10691110,"avatar_url":"https://avatars.githubusercontent.com/u/10691110?v=3","gravatar_id":"","url":"https://api.github.com/users/dataArtisans","html_url":"https://github.com/dataArtisans","followers_url":"https://api.github.com/users/dataArtisans/followers","following_url":"https://api.github.com/users/dataArtisans/following{/other_user}","gists_url":"https://api.github.com/users/dataArtisans/gists{/gist_id}","starred_url":"https://api.github.com/users/dataArtisans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dataArtisans/subscriptions","organizations_url":"https://api.github.com/users/dataArtisans/orgs","repos_url":"https://api.github.com/users/dataArtisans/repos","events_url":"https://api.github.com/users/dataArtisans/events{/privacy}","received_events_url":"https://api.github.com/users/dataArtisans/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dataArtisans/flink-dataflow","description":"Google Dataflow Runner for Apache Flink","fork":false,"url":"https://api.github.com/repos/dataArtisans/flink-dataflow","forks_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/forks","keys_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/teams","hooks_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/hooks","issue_events_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/events","assignees_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/tags","blobs_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/languages","stargazers_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/stargazers","contributors_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/contributors","subscribers_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/subscribers","subscription_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/subscription","commits_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/merges","archive_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/downloads","issues_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/dataArtisans/flink-dataflow/deployments","created_at":"2015-02-19T10:07:35Z","updated_at":"2016-02-28T05:40:09Z","pushed_at":"2016-03-01T21:15:15Z","git_url":"git://github.com/dataArtisans/flink-dataflow.git","ssh_url":"git@github.com:dataArtisans/flink-dataflow.git","clone_url":"https://github.com/dataArtisans/flink-dataflow.git","svn_url":"https://github.com/dataArtisans/flink-dataflow","homepage":null,"size":481,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16"},"html":{"href":"https://github.com/dataArtisans/flink-dataflow/pull/16"},"issue":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues/16"},"comments":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/dataArtisans/flink-dataflow/statuses/95755323fb4630b6d0741c308e730c5446c17d21"}}}}