{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/83524293","pull_request_review_id":4365764,"id":83524293,"diff_hunk":"@@ -1,3 +1,4 @@\n+# coding: utf-8","path":"activerecord/test/cases/base_test.rb","position":1,"original_position":1,"commit_id":"0f102b9697ce7e9885fc5f7525b99c3674ff3130","original_commit_id":"0f102b9697ce7e9885fc5f7525b99c3674ff3130","user":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"body":"Why?","created_at":"2016-10-15T02:46:47Z","updated_at":"2016-10-15T02:48:37Z","html_url":"https://github.com/rails/rails/pull/26789#discussion_r83524293","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/26789","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/83524293"},"html":{"href":"https://github.com/rails/rails/pull/26789#discussion_r83524293"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/26789"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/26789","id":89409980,"html_url":"https://github.com/rails/rails/pull/26789","diff_url":"https://github.com/rails/rails/pull/26789.diff","patch_url":"https://github.com/rails/rails/pull/26789.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/26789","number":26789,"state":"open","locked":false,"title":"Removed ActiveRecord::Type::Value","user":{"login":"iainbeeston","id":111963,"avatar_url":"https://avatars.githubusercontent.com/u/111963?v=3","gravatar_id":"","url":"https://api.github.com/users/iainbeeston","html_url":"https://github.com/iainbeeston","followers_url":"https://api.github.com/users/iainbeeston/followers","following_url":"https://api.github.com/users/iainbeeston/following{/other_user}","gists_url":"https://api.github.com/users/iainbeeston/gists{/gist_id}","starred_url":"https://api.github.com/users/iainbeeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iainbeeston/subscriptions","organizations_url":"https://api.github.com/users/iainbeeston/orgs","repos_url":"https://api.github.com/users/iainbeeston/repos","events_url":"https://api.github.com/users/iainbeeston/events{/privacy}","received_events_url":"https://api.github.com/users/iainbeeston/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nThe base class in the ActiveModel type API is `ActiveModel::Type::Value`, from which other types are subclassed (eg. `ActiveModel::Type::ImmutableString < ActiveModel::Type::Value`). ActiveRecord subclasses `ActiveModel::Type::Value` with it's own `Value` class. However, most of the ActiveRecord type classes don't use this base class, but instead are subclassed from ActiveModel's `Value` class. Other ActiveRecord type classes do sublass the ActiveRecord `Value` class.\r\n\r\nFor example,\r\n\r\n| Subclasses `ActiveModel::Type::Value` | Subclasses `ActiveRecord::Type::Value` |\r\n---|----|----\r\n| `Decimal`, `Integer`, `String`... | `Time`, `Date`, `Array`... |\r\n\r\nI believe there's a risk here, which is that if`ActiveRecord::Type::Value` is modified, the changes would be reflected inconsistently and could cause subtle bugs, because only the types that subclass `ActiveRecord::Type::Value` would pick up the changes.\r\n\r\nMy suggestion is that `ActiveRecord::Type::Value` should be removed entirely, which would mean that there is only one `Value` class, and everything is subclassed from that, in a single class hierarchy.","created_at":"2016-10-14T15:58:11Z","updated_at":"2016-10-15T02:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4ec7b0510eb28e4414297e6fdabe441cf9786a6","assignee":{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":true},"assignees":[{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":true}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/26789/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/26789/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/26789/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/0f102b9697ce7e9885fc5f7525b99c3674ff3130","head":{"label":"iainbeeston:remove-activerecord-type-value","ref":"remove-activerecord-type-value","sha":"0f102b9697ce7e9885fc5f7525b99c3674ff3130","user":{"login":"iainbeeston","id":111963,"avatar_url":"https://avatars.githubusercontent.com/u/111963?v=3","gravatar_id":"","url":"https://api.github.com/users/iainbeeston","html_url":"https://github.com/iainbeeston","followers_url":"https://api.github.com/users/iainbeeston/followers","following_url":"https://api.github.com/users/iainbeeston/following{/other_user}","gists_url":"https://api.github.com/users/iainbeeston/gists{/gist_id}","starred_url":"https://api.github.com/users/iainbeeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iainbeeston/subscriptions","organizations_url":"https://api.github.com/users/iainbeeston/orgs","repos_url":"https://api.github.com/users/iainbeeston/repos","events_url":"https://api.github.com/users/iainbeeston/events{/privacy}","received_events_url":"https://api.github.com/users/iainbeeston/received_events","type":"User","site_admin":false},"repo":{"id":9850033,"name":"rails","full_name":"iainbeeston/rails","owner":{"login":"iainbeeston","id":111963,"avatar_url":"https://avatars.githubusercontent.com/u/111963?v=3","gravatar_id":"","url":"https://api.github.com/users/iainbeeston","html_url":"https://github.com/iainbeeston","followers_url":"https://api.github.com/users/iainbeeston/followers","following_url":"https://api.github.com/users/iainbeeston/following{/other_user}","gists_url":"https://api.github.com/users/iainbeeston/gists{/gist_id}","starred_url":"https://api.github.com/users/iainbeeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iainbeeston/subscriptions","organizations_url":"https://api.github.com/users/iainbeeston/orgs","repos_url":"https://api.github.com/users/iainbeeston/repos","events_url":"https://api.github.com/users/iainbeeston/events{/privacy}","received_events_url":"https://api.github.com/users/iainbeeston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iainbeeston/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/iainbeeston/rails","forks_url":"https://api.github.com/repos/iainbeeston/rails/forks","keys_url":"https://api.github.com/repos/iainbeeston/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iainbeeston/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iainbeeston/rails/teams","hooks_url":"https://api.github.com/repos/iainbeeston/rails/hooks","issue_events_url":"https://api.github.com/repos/iainbeeston/rails/issues/events{/number}","events_url":"https://api.github.com/repos/iainbeeston/rails/events","assignees_url":"https://api.github.com/repos/iainbeeston/rails/assignees{/user}","branches_url":"https://api.github.com/repos/iainbeeston/rails/branches{/branch}","tags_url":"https://api.github.com/repos/iainbeeston/rails/tags","blobs_url":"https://api.github.com/repos/iainbeeston/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iainbeeston/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iainbeeston/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/iainbeeston/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iainbeeston/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/iainbeeston/rails/languages","stargazers_url":"https://api.github.com/repos/iainbeeston/rails/stargazers","contributors_url":"https://api.github.com/repos/iainbeeston/rails/contributors","subscribers_url":"https://api.github.com/repos/iainbeeston/rails/subscribers","subscription_url":"https://api.github.com/repos/iainbeeston/rails/subscription","commits_url":"https://api.github.com/repos/iainbeeston/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/iainbeeston/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/iainbeeston/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/iainbeeston/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/iainbeeston/rails/contents/{+path}","compare_url":"https://api.github.com/repos/iainbeeston/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iainbeeston/rails/merges","archive_url":"https://api.github.com/repos/iainbeeston/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iainbeeston/rails/downloads","issues_url":"https://api.github.com/repos/iainbeeston/rails/issues{/number}","pulls_url":"https://api.github.com/repos/iainbeeston/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/iainbeeston/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/iainbeeston/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iainbeeston/rails/labels{/name}","releases_url":"https://api.github.com/repos/iainbeeston/rails/releases{/id}","deployments_url":"https://api.github.com/repos/iainbeeston/rails/deployments","created_at":"2013-05-04T06:00:42Z","updated_at":"2015-04-03T08:37:41Z","pushed_at":"2016-10-14T19:21:29Z","git_url":"git://github.com/iainbeeston/rails.git","ssh_url":"git@github.com:iainbeeston/rails.git","clone_url":"https://github.com/iainbeeston/rails.git","svn_url":"https://github.com/iainbeeston/rails","homepage":"http://rubyonrails.org","size":127870,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"159b774887cfb3d5c862b2b48d24d75b658e47af","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-10-14T22:15:01Z","pushed_at":"2016-10-15T02:37:50Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":347527,"stargazers_count":33047,"watchers_count":33047,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13463,"mirror_url":null,"open_issues_count":1225,"forks":13463,"open_issues":1225,"watchers":33047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/26789"},"html":{"href":"https://github.com/rails/rails/pull/26789"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/26789"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/26789/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/26789/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/26789/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/0f102b9697ce7e9885fc5f7525b99c3674ff3130"}}}}
{"actor":{"display_login":"rafaelfranca"}}