{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/58162390","id":58162390,"diff_hunk":"@@ -206,6 +239,55 @@ func (lbc *loadBalancerController) sync(key string) {\n \t})\n }\n \n+func (lbc *loadBalancerController) syncIngress(key string) {\n+\tif !lbc.controllersInSync() {\n+\t\tlbc.ingQueue.requeue(key, fmt.Errorf(\"deferring sync till endpoints controller has synced\"))\n+\t\treturn\n+\t}\n+\n+\tobj, ingExists, err := lbc.ingLister.Store.GetByKey(key)\n+\tif err != nil {\n+\t\tlbc.ingQueue.requeue(key, err)\n+\t\treturn\n+\t}\n+\n+\tif ingExists {","path":"ingress/controllers/nginx/controller.go","position":90,"original_position":90,"commit_id":"20ef17e1d06052df412ee6484a1e263ba243fc5f","original_commit_id":"20ef17e1d06052df412ee6484a1e263ba243fc5f","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"nit: i prefer !ingExists { return } so we don't get the additional indent.","created_at":"2016-04-01T04:54:44Z","updated_at":"2016-04-01T04:54:44Z","html_url":"https://github.com/kubernetes/contrib/pull/681#discussion_r58162390","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/681","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/58162390"},"html":{"href":"https://github.com/kubernetes/contrib/pull/681#discussion_r58162390"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/681"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/681","id":64728822,"html_url":"https://github.com/kubernetes/contrib/pull/681","diff_url":"https://github.com/kubernetes/contrib/pull/681.diff","patch_url":"https://github.com/kubernetes/contrib/pull/681.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/681","number":681,"state":"open","locked":false,"title":"WIP: Update Ingress status information in nginx controller","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"```\r\nold-mbp:~ aledbf$ kubectl get ing\r\nNAME      RULE          BACKEND   ADDRESS\r\nechomap   -                       172.17.4.99\r\n          foo.bar.com\r\n          /foo          echoheaders-x:80\r\n          bar.baz.com\r\n          /bar          echoheaders-y:80\r\n          /foo          echoheaders-x:80\r\nold-mbp:~ aledbf$ kubectl describe  ing\r\nName:     echomap\r\nNamespace:    default\r\nAddress:    172.17.4.99\r\nDefault backend:  default-http-backend:80 (<none>)\r\nRules:\r\n  Host    Path  Backends\r\n  ----    ----  --------\r\n  foo.bar.com\r\n        /foo  echoheaders-x:80 (10.2.68.4:8080)\r\n  bar.baz.com\r\n        /bar  echoheaders-y:80 (10.2.68.4:8080)\r\n        /foo  echoheaders-x:80 (10.2.68.4:8080)\r\nAnnotations:\r\nEvents:\r\n  FirstSeen LastSeen  Count From        SubobjectPath Type    Reason  Message\r\n  --------- --------  ----- ----        ------------- --------  ------  -------\r\n  38s   38s   1 {loadbalancer-controller }      Normal    CREATE  default/echomap\r\n  38s   38s   1 {loadbalancer-controller }      Normal    CREATE  ip: 172.17.4.99\r\n  38s   38s   1 {loadbalancer-controller }      Normal    UPDATE  default/echomap\r\n\r\n```\r\n\r\n```\r\nold-mbp:~ aledbf$ kubectl get events -w\r\nFIRSTSEEN                       LASTSEEN                        COUNT     NAME                             KIND                    SUBOBJECT                           TYPE      REASON             SOURCE                      MESSAGE\r\n2016-03-31 00:03:55 -0300 CLT   2016-03-31 00:03:55 -0300 CLT   1         nginx-ingress-controller   ReplicationController             Normal    SuccessfulCreate   {replication-controller }   Created pod: nginx-ingress-controller-wdrix\r\n2016-03-31 00:03:55 -0300 CLT   2016-03-31 00:03:55 -0300 CLT   1         nginx-ingress-controller-wdrix   Pod                 Normal    Scheduled   {default-scheduler }   Successfully assigned nginx-ingress-controller-wdrix to 172.17.4.99\r\n2016-03-31 00:03:55 -0300 CLT   2016-03-31 00:03:55 -0300 CLT   1         nginx-ingress-controller-wdrix   Pod       spec.containers{nginx-ingress-lb}   Normal    Pulling   {kubelet 172.17.4.99}   pulling image \"aledbf/nginx-third-party:0.9\"\r\n2016-03-31 00:04:08 -0300 CLT   2016-03-31 00:04:08 -0300 CLT   1         nginx-ingress-controller-wdrix   Pod       spec.containers{nginx-ingress-lb}   Normal    Pulled    {kubelet 172.17.4.99}   Successfully pulled image \"aledbf/nginx-third-party:0.9\"\r\n2016-03-31 00:04:08 -0300 CLT   2016-03-31 00:04:08 -0300 CLT   1         nginx-ingress-controller-wdrix   Pod       spec.containers{nginx-ingress-lb}   Normal    Created   {kubelet 172.17.4.99}   Created container with docker id 68c6a6f8ec6d\r\n2016-03-31 00:04:08 -0300 CLT   2016-03-31 00:04:08 -0300 CLT   1         nginx-ingress-controller-wdrix   Pod       spec.containers{nginx-ingress-lb}   Normal    Started   {kubelet 172.17.4.99}   Started container with docker id 68c6a6f8ec6d\r\n2016-03-31 00:04:08 -0300 CLT   2016-03-31 00:04:08 -0300 CLT   1         echomap   Ingress             Normal    CREATE    {loadbalancer-controller }   default/echomap\r\n\r\n2016-03-31 00:04:27 -0300 CLT   2016-03-31 00:04:27 -0300 CLT   1         nginx-ingress-controller   ReplicationController             Normal    SuccessfulDelete   {replication-controller }   Deleted pod: nginx-ingress-controller-wdrix\r\n2016-03-31 00:04:27 -0300 CLT   2016-03-31 00:04:27 -0300 CLT   1         echomap   Ingress             Normal    DELETE    {loadbalancer-controller }   ip: 172.17.4.99\r\n2016-03-31 00:04:57 -0300 CLT   2016-03-31 00:04:57 -0300 CLT   1         nginx-ingress-controller-wdrix   Pod       spec.containers{nginx-ingress-lb}   Normal    Killing   {kubelet 172.17.4.99}   Killing container with docker id 68c6a6f8ec6d: Need to kill pod.\r\n```","created_at":"2016-03-31T03:08:29Z","updated_at":"2016-04-01T04:54:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18118bdfc1f30c136937b753b991877fc45df067","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/681/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/681/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/681/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/20ef17e1d06052df412ee6484a1e263ba243fc5f","head":{"label":"aledbf:add-lb-status","ref":"add-lb-status","sha":"20ef17e1d06052df412ee6484a1e263ba243fc5f","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":42607552,"name":"contrib","full_name":"aledbf/contrib","owner":{"login":"aledbf","id":161571,"avatar_url":"https://avatars.githubusercontent.com/u/161571?v=3","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledbf/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/aledbf/contrib","forks_url":"https://api.github.com/repos/aledbf/contrib/forks","keys_url":"https://api.github.com/repos/aledbf/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/contrib/teams","hooks_url":"https://api.github.com/repos/aledbf/contrib/hooks","issue_events_url":"https://api.github.com/repos/aledbf/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/contrib/events","assignees_url":"https://api.github.com/repos/aledbf/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/contrib/tags","blobs_url":"https://api.github.com/repos/aledbf/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/contrib/languages","stargazers_url":"https://api.github.com/repos/aledbf/contrib/stargazers","contributors_url":"https://api.github.com/repos/aledbf/contrib/contributors","subscribers_url":"https://api.github.com/repos/aledbf/contrib/subscribers","subscription_url":"https://api.github.com/repos/aledbf/contrib/subscription","commits_url":"https://api.github.com/repos/aledbf/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledbf/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/contrib/merges","archive_url":"https://api.github.com/repos/aledbf/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/contrib/downloads","issues_url":"https://api.github.com/repos/aledbf/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/contrib/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/aledbf/contrib/deployments","created_at":"2015-09-16T19:04:49Z","updated_at":"2016-01-11T19:27:11Z","pushed_at":"2016-04-01T04:31:42Z","git_url":"git://github.com/aledbf/contrib.git","ssh_url":"git@github.com:aledbf/contrib.git","clone_url":"https://github.com/aledbf/contrib.git","svn_url":"https://github.com/aledbf/contrib","homepage":"","size":24397,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"70aa5aa6c92fecb29bb298940a8241bce9e71795","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-04-01T00:39:42Z","pushed_at":"2016-04-01T04:31:43Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":40063,"stargazers_count":218,"watchers_count":218,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":143,"forks":199,"open_issues":143,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/681"},"html":{"href":"https://github.com/kubernetes/contrib/pull/681"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/681"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/681/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/681/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/681/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/20ef17e1d06052df412ee6484a1e263ba243fc5f"}}}}