{"action":"created","issue":{"url":"https://api.github.com/repos/google/cadvisor/issues/1349","repository_url":"https://api.github.com/repos/google/cadvisor","labels_url":"https://api.github.com/repos/google/cadvisor/issues/1349/labels{/name}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/1349/comments","events_url":"https://api.github.com/repos/google/cadvisor/issues/1349/events","html_url":"https://github.com/google/cadvisor/pull/1349","id":161999835,"number":1349,"title":"Add support to the handler to support fetching the ip address and files","user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars.githubusercontent.com/u/691166?v=3","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-23T19:07:56Z","updated_at":"2016-06-30T15:11:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/1349","html_url":"https://github.com/google/cadvisor/pull/1349","diff_url":"https://github.com/google/cadvisor/pull/1349.diff","patch_url":"https://github.com/google/cadvisor/pull/1349.patch"},"body":"Adds support to the handler to be able to fetch the ip address of a container and the files from within a container.\r\n\r\nSupport added for docker containers, but if someone knows more about the raw or rkt containers, they should also be updated to add in this support.\r\n\r\nBeing able to fetch the ip address of container is essential for supporting custom metrics. Without this we need to be able to know the ip address before starting the container. This is especially cumbersome with kuberentes as it requires setting up hostports and manually managing each container that wants to expose metrics. The support added here will work with both plain docker images and kubernetes pods.\r\n\r\nNote: this is in piece of the PR sent for https://github.com/google/cadvisor/pull/1328 as it has been deemed more appropriate to split that request into smaller separate ones."},"comment":{"url":"https://api.github.com/repos/google/cadvisor/issues/comments/229689372","html_url":"https://github.com/google/cadvisor/pull/1349#issuecomment-229689372","issue_url":"https://api.github.com/repos/google/cadvisor/issues/1349","id":229689372,"user":{"login":"mwringe","id":691166,"avatar_url":"https://avatars.githubusercontent.com/u/691166?v=3","gravatar_id":"","url":"https://api.github.com/users/mwringe","html_url":"https://github.com/mwringe","followers_url":"https://api.github.com/users/mwringe/followers","following_url":"https://api.github.com/users/mwringe/following{/other_user}","gists_url":"https://api.github.com/users/mwringe/gists{/gist_id}","starred_url":"https://api.github.com/users/mwringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwringe/subscriptions","organizations_url":"https://api.github.com/users/mwringe/orgs","repos_url":"https://api.github.com/users/mwringe/repos","events_url":"https://api.github.com/users/mwringe/events{/privacy}","received_events_url":"https://api.github.com/users/mwringe/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T15:11:27Z","updated_at":"2016-06-30T15:11:27Z","body":"Bump, anything I can do to get this pushed through any faster?"}}
{"actor":{"display_login":"mwringe"}}