{"action":"closed","number":6555,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6555","id":68795217,"html_url":"https://github.com/nodejs/node/pull/6555","diff_url":"https://github.com/nodejs/node/pull/6555.diff","patch_url":"https://github.com/nodejs/node/pull/6555.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6555","number":6555,"state":"closed","locked":false,"title":"test: fix unreliable known_issues test","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting a pull request to Node.js. Before you submit, please\r\nreview below requirements and walk through the checklist. You can 'tick'\r\na box by using the letter \"x\": [x].\r\n\r\nRun the test suite by invoking: `make -j4 lint test` on linux or\r\n`vcbuild test nosign` on Windows.\r\n\r\nIf this aims to fix a regression or you’re adding a feature, make sure you also\r\nwrite a test. Finally – if possible – a benchmark that quantifies your changes.\r\n\r\nFinally, read through our contributors guide and make adjustments as necessary:\r\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n\r\n<!-- remove lines that do not apply to you -->\r\n\r\n- [x] tests and code linting passes\r\n- [x] the commit message follows commit guidelines\r\n\r\n\r\n##### Affected core subsystem(s)\r\n\r\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\r\n\r\ntest\r\n##### Description of change\r\n\r\n<!-- provide a description of the change below this comment -->\r\n\r\n`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX\r\nmachines and not failing at all on Windows. Revised test fails reliably\r\non POSIX and is skipped (in CI) on Windows where the issue does not\r\nexist.\r\n\r\nFixes: https://github.com/nodejs/node/issues/6527","created_at":"2016-05-04T00:10:34Z","updated_at":"2016-05-06T02:43:38Z","closed_at":"2016-05-06T02:43:38Z","merged_at":null,"merge_commit_sha":"b715ce8577b565066e502f19bbb849ffb6978f68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6555/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6555/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6555/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/e594ea5d0621d55f58cfefd3442e25d2c55371b6","head":{"label":"Trott:known","ref":"known","sha":"e594ea5d0621d55f58cfefd3442e25d2c55371b6","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"repo":{"id":35707182,"name":"io.js","full_name":"Trott/io.js","owner":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Trott/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/Trott/io.js","forks_url":"https://api.github.com/repos/Trott/io.js/forks","keys_url":"https://api.github.com/repos/Trott/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trott/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trott/io.js/teams","hooks_url":"https://api.github.com/repos/Trott/io.js/hooks","issue_events_url":"https://api.github.com/repos/Trott/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/Trott/io.js/events","assignees_url":"https://api.github.com/repos/Trott/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/Trott/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/Trott/io.js/tags","blobs_url":"https://api.github.com/repos/Trott/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trott/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trott/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trott/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trott/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Trott/io.js/languages","stargazers_url":"https://api.github.com/repos/Trott/io.js/stargazers","contributors_url":"https://api.github.com/repos/Trott/io.js/contributors","subscribers_url":"https://api.github.com/repos/Trott/io.js/subscribers","subscription_url":"https://api.github.com/repos/Trott/io.js/subscription","commits_url":"https://api.github.com/repos/Trott/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trott/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trott/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trott/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trott/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/Trott/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trott/io.js/merges","archive_url":"https://api.github.com/repos/Trott/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trott/io.js/downloads","issues_url":"https://api.github.com/repos/Trott/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/Trott/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Trott/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Trott/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trott/io.js/labels{/name}","releases_url":"https://api.github.com/repos/Trott/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/Trott/io.js/deployments","created_at":"2015-05-16T02:50:59Z","updated_at":"2016-01-11T17:20:02Z","pushed_at":"2016-05-06T02:43:20Z","git_url":"git://github.com/Trott/io.js.git","ssh_url":"git@github.com:Trott/io.js.git","clone_url":"https://github.com/Trott/io.js.git","svn_url":"https://github.com/Trott/io.js","homepage":"https://iojs.org","size":196475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"330ea769efe83d4a117c86f482998a9613d51230","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-05-06T02:41:44Z","pushed_at":"2016-05-06T02:43:14Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":257045,"stargazers_count":22901,"watchers_count":22901,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3189,"mirror_url":null,"open_issues_count":645,"forks":3189,"open_issues":645,"watchers":22901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6555"},"html":{"href":"https://github.com/nodejs/node/pull/6555"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6555"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6555/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6555/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6555/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/e594ea5d0621d55f58cfefd3442e25d2c55371b6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":6,"commits":1,"additions":31,"deletions":4,"changed_files":2}}