{"action":"created","issue":{"url":"https://api.github.com/repos/QIICR/Reporting/issues/111","repository_url":"https://api.github.com/repos/QIICR/Reporting","labels_url":"https://api.github.com/repos/QIICR/Reporting/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/QIICR/Reporting/issues/111/comments","events_url":"https://api.github.com/repos/QIICR/Reporting/issues/111/events","html_url":"https://github.com/QIICR/Reporting/issues/111","id":191396450,"number":111,"title":"Segment anatomic region/modifier is not populated on SEG import","user":{"login":"fedorov","id":313942,"avatar_url":"https://avatars.githubusercontent.com/u/313942?v=3","gravatar_id":"","url":"https://api.github.com/users/fedorov","html_url":"https://github.com/fedorov","followers_url":"https://api.github.com/users/fedorov/followers","following_url":"https://api.github.com/users/fedorov/following{/other_user}","gists_url":"https://api.github.com/users/fedorov/gists{/gist_id}","starred_url":"https://api.github.com/users/fedorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedorov/subscriptions","organizations_url":"https://api.github.com/users/fedorov/orgs","repos_url":"https://api.github.com/users/fedorov/repos","events_url":"https://api.github.com/users/fedorov/events{/privacy}","received_events_url":"https://api.github.com/users/fedorov/received_events","type":"User","site_admin":false},"labels":[{"id":441910805,"url":"https://api.github.com/repos/QIICR/Reporting/labels/bug","name":"bug","color":"e99695","default":true}],"state":"open","locked":false,"assignee":{"login":"cpinter","id":1325980,"avatar_url":"https://avatars.githubusercontent.com/u/1325980?v=3","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false},"assignees":[{"login":"cpinter","id":1325980,"avatar_url":"https://avatars.githubusercontent.com/u/1325980?v=3","gravatar_id":"","url":"https://api.github.com/users/cpinter","html_url":"https://github.com/cpinter","followers_url":"https://api.github.com/users/cpinter/followers","following_url":"https://api.github.com/users/cpinter/following{/other_user}","gists_url":"https://api.github.com/users/cpinter/gists{/gist_id}","starred_url":"https://api.github.com/users/cpinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpinter/subscriptions","organizations_url":"https://api.github.com/users/cpinter/orgs","repos_url":"https://api.github.com/users/cpinter/repos","events_url":"https://api.github.com/users/cpinter/events{/privacy}","received_events_url":"https://api.github.com/users/cpinter/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-23T22:48:24Z","updated_at":"2016-11-24T20:12:33Z","closed_at":null,"body":"This issue was discussed in https://github.com/QIICR/Reporting/issues/107#issuecomment-262632176, and is consistently reproducible with the dataset 2 from this page: https://fedorov.gitbooks.io/rsna2016-qirr-dicom4qi/content/instructions/sr-tid1500.html\r\n\r\nIt would be good to have it implemented the same way as in http://qiicr.org/dcmqi/#/seg - there is a separate selector for anatomic region context. And then at the time SEG is imported, a dynamic one is created as done for the category/type context. \r\n\r\n@cpinter says:\r\n> \r\n> Implementing it should be pretty straightforward, I think I can do it tomorrow.\r\n> \r\n> There is a combobox for anatomic context, and the logic is in place already. Hiding the combobox if there is only one loaded anatomic context is only a feature I added. So adding a new context for the SEG the same way a new terminology context is added will be no problem."},"comment":{"url":"https://api.github.com/repos/QIICR/Reporting/issues/comments/262839606","html_url":"https://github.com/QIICR/Reporting/issues/111#issuecomment-262839606","issue_url":"https://api.github.com/repos/QIICR/Reporting/issues/111","id":262839606,"user":{"login":"fedorov","id":313942,"avatar_url":"https://avatars.githubusercontent.com/u/313942?v=3","gravatar_id":"","url":"https://api.github.com/users/fedorov","html_url":"https://github.com/fedorov","followers_url":"https://api.github.com/users/fedorov/followers","following_url":"https://api.github.com/users/fedorov/following{/other_user}","gists_url":"https://api.github.com/users/fedorov/gists{/gist_id}","starred_url":"https://api.github.com/users/fedorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedorov/subscriptions","organizations_url":"https://api.github.com/users/fedorov/orgs","repos_url":"https://api.github.com/users/fedorov/repos","events_url":"https://api.github.com/users/fedorov/events{/privacy}","received_events_url":"https://api.github.com/users/fedorov/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T20:12:33Z","updated_at":"2016-11-24T20:12:33Z","body":"Csaba, it's an inconsistency in dcmqi schema - https://github.com/QIICR/dcmqi/blob/master/doc/seg-schema.json#L136-L141. Indeed, it would be consistent if both AnatomicRegion and AnatomicRegionModifier ended in CodeSequence. \r\n\r\nHowever, I am reluctant to change this now, since there are multiple other projects that use current version of dcmqi for the RSNA interoperability exhibit. This change would need to propagate to many places in the code. Thanks for #114, but I think I will keep it open for now.\r\n\r\nI hope at RSNA there will be an opportunity to agree with the other users of dcmqi on the naming conventions and procedures for code and schema updates."}}
{"actor":{"display_login":"fedorov"}}