{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3253","repository_url":"https://api.github.com/repos/ipfs/go-ipfs","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3253/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3253/comments","events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3253/events","html_url":"https://github.com/ipfs/go-ipfs/pull/3253","id":178897891,"number":3253,"title":"bitswap: redo: don't re-provide blocks we've provided very recently","user":{"login":"kevina","id":1271492,"avatar_url":"https://avatars.githubusercontent.com/u/1271492?v=3","gravatar_id":"","url":"https://api.github.com/users/kevina","html_url":"https://github.com/kevina","followers_url":"https://api.github.com/users/kevina/followers","following_url":"https://api.github.com/users/kevina/following{/other_user}","gists_url":"https://api.github.com/users/kevina/gists{/gist_id}","starred_url":"https://api.github.com/users/kevina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevina/subscriptions","organizations_url":"https://api.github.com/users/kevina/orgs","repos_url":"https://api.github.com/users/kevina/repos","events_url":"https://api.github.com/users/kevina/events{/privacy}","received_events_url":"https://api.github.com/users/kevina/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/needs%20review","name":"needs review","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-23T14:53:05Z","updated_at":"2016-10-06T02:07:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/3253","html_url":"https://github.com/ipfs/go-ipfs/pull/3253","diff_url":"https://github.com/ipfs/go-ipfs/pull/3253.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/3253.patch"},"body":"Pull request #3105 (bitswap: don't re-provide blocks we've provided very recently) broke adding files via the filestore (i.e., --no-copy, #2634).  The filestore code requires that all writes go through to the blockstore.  In addition the blockstore already checks if a block already exists.  This change avoids calling `Has()` is the blockservice and instead modifies the blockstore interface to return the blocks actually added.\r\n\r\n#3105 also changed AddBlocks (now AddObjects) to just return the blocks added.  This pull request restores the original behavior.  At this point I am not even sure if this return value is used anywhere."},"comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments/251849568","html_url":"https://github.com/ipfs/go-ipfs/pull/3253#issuecomment-251849568","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/3253","id":251849568,"user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T02:07:01Z","updated_at":"2016-10-06T02:07:01Z","body":"Alright, finally getting to this one. We're gonna have to find a different way to do this. Changing the return signature like that shouldnt be necessary. You say you could use your own blockservice instead? what would that roughly look like?"}}
{"actor":{"display_login":"whyrusleeping"}}