{"action":"created","comment":{"url":"https://api.github.com/repos/salsify/avro_turf/pulls/comments/58048020","id":58048020,"diff_hunk":"@@ -28,6 +28,29 @@ def register(subject, schema)\n     id\n   end\n \n+  # List all subjects\n+  def subjects\n+    get('/subjects')\n+  end\n+\n+  # List all versions for a subject\n+  def subject_versions(subject)\n+    get(\"/subjects/#{subject}/versions\")","path":"lib/avro_turf/schema_registry.rb","position":11,"original_position":11,"commit_id":"ac91b7d23937cc825e24debdf19e4a2df1abf545","original_commit_id":"ac91b7d23937cc825e24debdf19e4a2df1abf545","user":{"login":"tjwp","id":1476506,"avatar_url":"https://avatars.githubusercontent.com/u/1476506?v=3","gravatar_id":"","url":"https://api.github.com/users/tjwp","html_url":"https://github.com/tjwp","followers_url":"https://api.github.com/users/tjwp/followers","following_url":"https://api.github.com/users/tjwp/following{/other_user}","gists_url":"https://api.github.com/users/tjwp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwp/subscriptions","organizations_url":"https://api.github.com/users/tjwp/orgs","repos_url":"https://api.github.com/users/tjwp/repos","events_url":"https://api.github.com/users/tjwp/events{/privacy}","received_events_url":"https://api.github.com/users/tjwp/received_events","type":"User","site_admin":false},"body":"I don't think so. As used they should only contain: [A-Za-z0-9_\\.]","created_at":"2016-03-31T12:55:13Z","updated_at":"2016-03-31T12:55:13Z","html_url":"https://github.com/salsify/avro_turf/pull/3#discussion_r58048020","pull_request_url":"https://api.github.com/repos/salsify/avro_turf/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/salsify/avro_turf/pulls/comments/58048020"},"html":{"href":"https://github.com/salsify/avro_turf/pull/3#discussion_r58048020"},"pull_request":{"href":"https://api.github.com/repos/salsify/avro_turf/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/salsify/avro_turf/pulls/3","id":64780818,"html_url":"https://github.com/salsify/avro_turf/pull/3","diff_url":"https://github.com/salsify/avro_turf/pull/3.diff","patch_url":"https://github.com/salsify/avro_turf/pull/3.patch","issue_url":"https://api.github.com/repos/salsify/avro_turf/issues/3","number":3,"state":"open","locked":false,"title":"Expand Schema Registry support","user":{"login":"tjwp","id":1476506,"avatar_url":"https://avatars.githubusercontent.com/u/1476506?v=3","gravatar_id":"","url":"https://api.github.com/users/tjwp","html_url":"https://github.com/tjwp","followers_url":"https://api.github.com/users/tjwp/followers","following_url":"https://api.github.com/users/tjwp/following{/other_user}","gists_url":"https://api.github.com/users/tjwp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwp/subscriptions","organizations_url":"https://api.github.com/users/tjwp/orgs","repos_url":"https://api.github.com/users/tjwp/repos","events_url":"https://api.github.com/users/tjwp/events{/privacy}","received_events_url":"https://api.github.com/users/tjwp/received_events","type":"User","site_admin":false},"body":"This PR is against the salsify-master branch.\r\n\r\nThis change completes support for the Subjects resource of the Schema Registry. Responses for the additional endpoints are not cached. The `CachedSchemaRegistry` is modified to delegate to the upstream `SchemaRegistry` so that the same API is available via either registry.\r\n\r\nThe `FakeSchemaRegistry` had to also be expanded to support testing. Tests have been refactored into a shared example that is used to test both the cached and the regular `SchemaRegistry`.\r\n\r\nPrime: @jturkel ","created_at":"2016-03-31T12:22:13Z","updated_at":"2016-03-31T12:55:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb1191408ac3de5489661cc79836e1551e7a5cc","assignee":{"login":"jturkel","id":2598096,"avatar_url":"https://avatars.githubusercontent.com/u/2598096?v=3","gravatar_id":"","url":"https://api.github.com/users/jturkel","html_url":"https://github.com/jturkel","followers_url":"https://api.github.com/users/jturkel/followers","following_url":"https://api.github.com/users/jturkel/following{/other_user}","gists_url":"https://api.github.com/users/jturkel/gists{/gist_id}","starred_url":"https://api.github.com/users/jturkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jturkel/subscriptions","organizations_url":"https://api.github.com/users/jturkel/orgs","repos_url":"https://api.github.com/users/jturkel/repos","events_url":"https://api.github.com/users/jturkel/events{/privacy}","received_events_url":"https://api.github.com/users/jturkel/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/salsify/avro_turf/pulls/3/commits","review_comments_url":"https://api.github.com/repos/salsify/avro_turf/pulls/3/comments","review_comment_url":"https://api.github.com/repos/salsify/avro_turf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salsify/avro_turf/issues/3/comments","statuses_url":"https://api.github.com/repos/salsify/avro_turf/statuses/ac91b7d23937cc825e24debdf19e4a2df1abf545","head":{"label":"salsify:expanded-api","ref":"expanded-api","sha":"ac91b7d23937cc825e24debdf19e4a2df1abf545","user":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"repo":{"id":54667157,"name":"avro_turf","full_name":"salsify/avro_turf","owner":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsify/avro_turf","description":"A library that makes it easier to use the Avro serialization format from Ruby.","fork":true,"url":"https://api.github.com/repos/salsify/avro_turf","forks_url":"https://api.github.com/repos/salsify/avro_turf/forks","keys_url":"https://api.github.com/repos/salsify/avro_turf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsify/avro_turf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsify/avro_turf/teams","hooks_url":"https://api.github.com/repos/salsify/avro_turf/hooks","issue_events_url":"https://api.github.com/repos/salsify/avro_turf/issues/events{/number}","events_url":"https://api.github.com/repos/salsify/avro_turf/events","assignees_url":"https://api.github.com/repos/salsify/avro_turf/assignees{/user}","branches_url":"https://api.github.com/repos/salsify/avro_turf/branches{/branch}","tags_url":"https://api.github.com/repos/salsify/avro_turf/tags","blobs_url":"https://api.github.com/repos/salsify/avro_turf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsify/avro_turf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsify/avro_turf/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsify/avro_turf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsify/avro_turf/statuses/{sha}","languages_url":"https://api.github.com/repos/salsify/avro_turf/languages","stargazers_url":"https://api.github.com/repos/salsify/avro_turf/stargazers","contributors_url":"https://api.github.com/repos/salsify/avro_turf/contributors","subscribers_url":"https://api.github.com/repos/salsify/avro_turf/subscribers","subscription_url":"https://api.github.com/repos/salsify/avro_turf/subscription","commits_url":"https://api.github.com/repos/salsify/avro_turf/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsify/avro_turf/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsify/avro_turf/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsify/avro_turf/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsify/avro_turf/contents/{+path}","compare_url":"https://api.github.com/repos/salsify/avro_turf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsify/avro_turf/merges","archive_url":"https://api.github.com/repos/salsify/avro_turf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsify/avro_turf/downloads","issues_url":"https://api.github.com/repos/salsify/avro_turf/issues{/number}","pulls_url":"https://api.github.com/repos/salsify/avro_turf/pulls{/number}","milestones_url":"https://api.github.com/repos/salsify/avro_turf/milestones{/number}","notifications_url":"https://api.github.com/repos/salsify/avro_turf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsify/avro_turf/labels{/name}","releases_url":"https://api.github.com/repos/salsify/avro_turf/releases{/id}","deployments_url":"https://api.github.com/repos/salsify/avro_turf/deployments","created_at":"2016-03-24T19:03:50Z","updated_at":"2016-03-24T19:03:51Z","pushed_at":"2016-03-31T12:22:13Z","git_url":"git://github.com/salsify/avro_turf.git","ssh_url":"git@github.com:salsify/avro_turf.git","clone_url":"https://github.com/salsify/avro_turf.git","svn_url":"https://github.com/salsify/avro_turf","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"salsify:salsify-master","ref":"salsify-master","sha":"212465587b8944c38ca97d452c55f7b909db2c4c","user":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"repo":{"id":54667157,"name":"avro_turf","full_name":"salsify/avro_turf","owner":{"login":"salsify","id":2165267,"avatar_url":"https://avatars.githubusercontent.com/u/2165267?v=3","gravatar_id":"","url":"https://api.github.com/users/salsify","html_url":"https://github.com/salsify","followers_url":"https://api.github.com/users/salsify/followers","following_url":"https://api.github.com/users/salsify/following{/other_user}","gists_url":"https://api.github.com/users/salsify/gists{/gist_id}","starred_url":"https://api.github.com/users/salsify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsify/subscriptions","organizations_url":"https://api.github.com/users/salsify/orgs","repos_url":"https://api.github.com/users/salsify/repos","events_url":"https://api.github.com/users/salsify/events{/privacy}","received_events_url":"https://api.github.com/users/salsify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salsify/avro_turf","description":"A library that makes it easier to use the Avro serialization format from Ruby.","fork":true,"url":"https://api.github.com/repos/salsify/avro_turf","forks_url":"https://api.github.com/repos/salsify/avro_turf/forks","keys_url":"https://api.github.com/repos/salsify/avro_turf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salsify/avro_turf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salsify/avro_turf/teams","hooks_url":"https://api.github.com/repos/salsify/avro_turf/hooks","issue_events_url":"https://api.github.com/repos/salsify/avro_turf/issues/events{/number}","events_url":"https://api.github.com/repos/salsify/avro_turf/events","assignees_url":"https://api.github.com/repos/salsify/avro_turf/assignees{/user}","branches_url":"https://api.github.com/repos/salsify/avro_turf/branches{/branch}","tags_url":"https://api.github.com/repos/salsify/avro_turf/tags","blobs_url":"https://api.github.com/repos/salsify/avro_turf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salsify/avro_turf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salsify/avro_turf/git/refs{/sha}","trees_url":"https://api.github.com/repos/salsify/avro_turf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salsify/avro_turf/statuses/{sha}","languages_url":"https://api.github.com/repos/salsify/avro_turf/languages","stargazers_url":"https://api.github.com/repos/salsify/avro_turf/stargazers","contributors_url":"https://api.github.com/repos/salsify/avro_turf/contributors","subscribers_url":"https://api.github.com/repos/salsify/avro_turf/subscribers","subscription_url":"https://api.github.com/repos/salsify/avro_turf/subscription","commits_url":"https://api.github.com/repos/salsify/avro_turf/commits{/sha}","git_commits_url":"https://api.github.com/repos/salsify/avro_turf/git/commits{/sha}","comments_url":"https://api.github.com/repos/salsify/avro_turf/comments{/number}","issue_comment_url":"https://api.github.com/repos/salsify/avro_turf/issues/comments{/number}","contents_url":"https://api.github.com/repos/salsify/avro_turf/contents/{+path}","compare_url":"https://api.github.com/repos/salsify/avro_turf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salsify/avro_turf/merges","archive_url":"https://api.github.com/repos/salsify/avro_turf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salsify/avro_turf/downloads","issues_url":"https://api.github.com/repos/salsify/avro_turf/issues{/number}","pulls_url":"https://api.github.com/repos/salsify/avro_turf/pulls{/number}","milestones_url":"https://api.github.com/repos/salsify/avro_turf/milestones{/number}","notifications_url":"https://api.github.com/repos/salsify/avro_turf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salsify/avro_turf/labels{/name}","releases_url":"https://api.github.com/repos/salsify/avro_turf/releases{/id}","deployments_url":"https://api.github.com/repos/salsify/avro_turf/deployments","created_at":"2016-03-24T19:03:50Z","updated_at":"2016-03-24T19:03:51Z","pushed_at":"2016-03-31T12:22:13Z","git_url":"git://github.com/salsify/avro_turf.git","ssh_url":"git@github.com:salsify/avro_turf.git","clone_url":"https://github.com/salsify/avro_turf.git","svn_url":"https://github.com/salsify/avro_turf","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salsify/avro_turf/pulls/3"},"html":{"href":"https://github.com/salsify/avro_turf/pull/3"},"issue":{"href":"https://api.github.com/repos/salsify/avro_turf/issues/3"},"comments":{"href":"https://api.github.com/repos/salsify/avro_turf/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/salsify/avro_turf/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/salsify/avro_turf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salsify/avro_turf/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/salsify/avro_turf/statuses/ac91b7d23937cc825e24debdf19e4a2df1abf545"}}}}