{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6658","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6658/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6658/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6658/events","html_url":"https://github.com/ManageIQ/manageiq/pull/6658","id":133538825,"number":6658,"title":"[wip] add ems_id to container definitions and inline it in containers","user":{"login":"moolitayer","id":3010449,"avatar_url":"https://avatars.githubusercontent.com/u/3010449?v=3","gravatar_id":"","url":"https://api.github.com/users/moolitayer","html_url":"https://github.com/moolitayer","followers_url":"https://api.github.com/users/moolitayer/followers","following_url":"https://api.github.com/users/moolitayer/following{/other_user}","gists_url":"https://api.github.com/users/moolitayer/gists{/gist_id}","starred_url":"https://api.github.com/users/moolitayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moolitayer/subscriptions","organizations_url":"https://api.github.com/users/moolitayer/orgs","repos_url":"https://api.github.com/users/moolitayer/repos","events_url":"https://api.github.com/users/moolitayer/events{/privacy}","received_events_url":"https://api.github.com/users/moolitayer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/containers","name":"providers/containers","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-14T13:22:02Z","updated_at":"2016-02-14T13:46:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6658","html_url":"https://github.com/ManageIQ/manageiq/pull/6658","diff_url":"https://github.com/ManageIQ/manageiq/pull/6658.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/6658.patch"},"body":"Going through joins to know what is the provider of a container is too costly"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/183891356","html_url":"https://github.com/ManageIQ/manageiq/pull/6658#issuecomment-183891356","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6658","id":183891356,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-02-14T13:46:53Z","updated_at":"2016-02-14T13:46:53Z","body":"<rubocop />Checked commits https://github.com/moolitayer/manageiq/compare/7d178acffdb6d00f7488e0fe5989e0d52d92d4da~...fe9affeea85719448e814b04258ebb5232cc1922 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0\n12 files checked, 7 offenses detected\n\n**app/models/container_definition.rb**\n- [ ] :large_orange_diamond: - [Line 4](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/container_definition.rb#L4), Col 10 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :large_orange_diamond: - [Line 19](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/container_definition.rb#L19), Col 1 - [Style/EmptyLinesAroundClassBody](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Style/EmptyLinesAroundClassBody) - Extra empty line detected at class body end.\n- [ ] :small_blue_diamond: - [Line 10](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/container_definition.rb#L10), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for disconnect_inv is too high. [17/15]\n\n**app/models/container_group.rb**\n- [ ] :small_blue_diamond: - [Line 79](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/container_group.rb#L79), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for disconnect_inv is too high. [21/15]\n\n**app/models/ems_refresh/save_inventory_container.rb**\n- [ ] :small_blue_diamond: - [Line 217](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/ems_refresh/save_inventory_container.rb#L217), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [127/120]\n\n**app/models/ems_refresh/save_inventory_helper.rb**\n- [ ] :small_blue_diamond: - [Line 32](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/ems_refresh/save_inventory_helper.rb#L32), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for save_inventory_multi is too high. [20.35/15]\n- [ ] :small_blue_diamond: - [Line 32](https://github.com/moolitayer/manageiq/blob/fe9affeea85719448e814b04258ebb5232cc1922/app/models/ems_refresh/save_inventory_helper.rb#L32), Col 27 - [Metrics/ParameterLists](http://rubydoc.info/gems/rubocop/0.34.2/RuboCop/Cop/Metrics/ParameterLists) - Avoid parameter lists longer than 5 parameters.\n"}}