{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/1455","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/1455/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/1455/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/1455/events","html_url":"https://github.com/magento/magento2/pull/1455","id":93697582,"number":1455,"title":"Improve Password EAV Attribute Backend model","user":{"login":"ihor-sviziev","id":1873745,"avatar_url":"https://avatars.githubusercontent.com/u/1873745?v=3","gravatar_id":"","url":"https://api.github.com/users/ihor-sviziev","html_url":"https://github.com/ihor-sviziev","followers_url":"https://api.github.com/users/ihor-sviziev/followers","following_url":"https://api.github.com/users/ihor-sviziev/following{/other_user}","gists_url":"https://api.github.com/users/ihor-sviziev/gists{/gist_id}","starred_url":"https://api.github.com/users/ihor-sviziev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihor-sviziev/subscriptions","organizations_url":"https://api.github.com/users/ihor-sviziev/orgs","repos_url":"https://api.github.com/users/ihor-sviziev/repos","events_url":"https://api.github.com/users/ihor-sviziev/events{/privacy}","received_events_url":"https://api.github.com/users/ihor-sviziev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magento/magento2/labels/accept","name":"accept","color":"009800"},{"url":"https://api.github.com/repos/magento/magento2/labels/CS","name":"CS","color":"fad8c7"},{"url":"https://api.github.com/repos/magento/magento2/labels/TECH","name":"TECH","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"slavvka","id":9741905,"avatar_url":"https://avatars.githubusercontent.com/u/9741905?v=3","gravatar_id":"","url":"https://api.github.com/users/slavvka","html_url":"https://github.com/slavvka","followers_url":"https://api.github.com/users/slavvka/followers","following_url":"https://api.github.com/users/slavvka/following{/other_user}","gists_url":"https://api.github.com/users/slavvka/gists{/gist_id}","starred_url":"https://api.github.com/users/slavvka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavvka/subscriptions","organizations_url":"https://api.github.com/users/slavvka/orgs","repos_url":"https://api.github.com/users/slavvka/repos","events_url":"https://api.github.com/users/slavvka/events{/privacy}","received_events_url":"https://api.github.com/users/slavvka/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-07-08T05:13:22Z","updated_at":"2016-03-30T16:34:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/1455","html_url":"https://github.com/magento/magento2/pull/1455","diff_url":"https://github.com/magento/magento2/pull/1455.diff","patch_url":"https://github.com/magento/magento2/pull/1455.patch"},"body":"1. In method beforeSave $object->getPassword() can return not a string, so would be great to convert value to string to prevent converting value to string in all places and as result we may have not unexpected behavior behavior in future, when code will be changed. Also == operator would be great replace with === because there we will have two strings, to type converting needed.\r\n\r\n2. In method validate $object->getPassword() and $object->getPasswordConfirm() may be not a string. As example password is string 'myPassword', password confirm is true. ```'myPassword' == true \r\n``` Result will be *true*.\r\nSo those params were converted to string and and compared with ===.\r\n3. Would be great to define which object type will be received in beforeSave and validate methods to be sure that we got \\Magento\\Framework\\Object and this method contains getPassword and getPasswordConfirm (or __call method, which will process them correct). I didn't changed those methods because they defined in parent class wo type declaration."},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/203515591","html_url":"https://github.com/magento/magento2/pull/1455#issuecomment-203515591","issue_url":"https://api.github.com/repos/magento/magento2/issues/1455","id":203515591,"user":{"login":"KrystynaKabannyk","id":17929386,"avatar_url":"https://avatars.githubusercontent.com/u/17929386?v=3","gravatar_id":"","url":"https://api.github.com/users/KrystynaKabannyk","html_url":"https://github.com/KrystynaKabannyk","followers_url":"https://api.github.com/users/KrystynaKabannyk/followers","following_url":"https://api.github.com/users/KrystynaKabannyk/following{/other_user}","gists_url":"https://api.github.com/users/KrystynaKabannyk/gists{/gist_id}","starred_url":"https://api.github.com/users/KrystynaKabannyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrystynaKabannyk/subscriptions","organizations_url":"https://api.github.com/users/KrystynaKabannyk/orgs","repos_url":"https://api.github.com/users/KrystynaKabannyk/repos","events_url":"https://api.github.com/users/KrystynaKabannyk/events{/privacy}","received_events_url":"https://api.github.com/users/KrystynaKabannyk/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T16:34:49Z","updated_at":"2016-03-30T16:34:49Z","body":"Hello @ihor-sviziev, are you still interested in this pull request? If yes, could you update the code and cover it by Travis tests?"}}