{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/90957312","pull_request_review_id":11470869,"id":90957312,"diff_hunk":"@@ -252,7 +252,7 @@ exports.init = function (cli) {\n             result = client.sites.createOrUpdateSiteConfig(resourceGroup, name, jsonObj, _);\n             log.info('Webapp ' + name + ' configuration has been updated ');\n           }\n-          cli.interaction.formatOutput(result);\n+          cli.interaction.formatOutput(result, function(){});","path":"lib/commands/arm/webapp/webapp.config._js","position":5,"original_position":5,"commit_id":"439a06b84e651a8a19ec5bea99846e6337491a64","original_commit_id":"439a06b84e651a8a19ec5bea99846e6337491a64","user":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"this is incorrect. The function cannot be empty. That function tells the CLI how the data in the result will be displayed to the user. An empty function will do nothing. It will surely not throw an error \"humanOutputGenerator\" is not a function. But, how useful is this empty function? Shouldn't you be printing the content of the result?","created_at":"2016-12-05T21:18:26Z","updated_at":"2016-12-05T21:18:26Z","html_url":"https://github.com/Azure/azure-xplat-cli/pull/3364#discussion_r90957312","pull_request_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments/90957312"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/3364#discussion_r90957312"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364","id":96359496,"html_url":"https://github.com/Azure/azure-xplat-cli/pull/3364","diff_url":"https://github.com/Azure/azure-xplat-cli/pull/3364.diff","patch_url":"https://github.com/Azure/azure-xplat-cli/pull/3364.patch","issue_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3364","number":3364,"state":"open","locked":false,"title":"Fixed cli.interaction in webapp config set","user":{"login":"LukaszStem","id":20563423,"avatar_url":"https://avatars.githubusercontent.com/u/20563423?v=3","gravatar_id":"","url":"https://api.github.com/users/LukaszStem","html_url":"https://github.com/LukaszStem","followers_url":"https://api.github.com/users/LukaszStem/followers","following_url":"https://api.github.com/users/LukaszStem/following{/other_user}","gists_url":"https://api.github.com/users/LukaszStem/gists{/gist_id}","starred_url":"https://api.github.com/users/LukaszStem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukaszStem/subscriptions","organizations_url":"https://api.github.com/users/LukaszStem/orgs","repos_url":"https://api.github.com/users/LukaszStem/repos","events_url":"https://api.github.com/users/LukaszStem/events{/privacy}","received_events_url":"https://api.github.com/users/LukaszStem/received_events","type":"User","site_admin":false},"body":"One line change, this cmd will no longer generate \r\n## error:   humanOutputGenerator is not a function\r\n\r\nPlease let me know if there is a more proper way of fixing this.\r\n\r\n","created_at":"2016-12-02T21:53:29Z","updated_at":"2016-12-05T21:18:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5502647752c9c2a853cc054fa786112c92e07282","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3364/comments","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/439a06b84e651a8a19ec5bea99846e6337491a64","head":{"label":"LukaszStem:dev","ref":"dev","sha":"439a06b84e651a8a19ec5bea99846e6337491a64","user":{"login":"LukaszStem","id":20563423,"avatar_url":"https://avatars.githubusercontent.com/u/20563423?v=3","gravatar_id":"","url":"https://api.github.com/users/LukaszStem","html_url":"https://github.com/LukaszStem","followers_url":"https://api.github.com/users/LukaszStem/followers","following_url":"https://api.github.com/users/LukaszStem/following{/other_user}","gists_url":"https://api.github.com/users/LukaszStem/gists{/gist_id}","starred_url":"https://api.github.com/users/LukaszStem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukaszStem/subscriptions","organizations_url":"https://api.github.com/users/LukaszStem/orgs","repos_url":"https://api.github.com/users/LukaszStem/repos","events_url":"https://api.github.com/users/LukaszStem/events{/privacy}","received_events_url":"https://api.github.com/users/LukaszStem/received_events","type":"User","site_admin":false},"repo":{"id":71166472,"name":"azure-xplat-cli","full_name":"LukaszStem/azure-xplat-cli","owner":{"login":"LukaszStem","id":20563423,"avatar_url":"https://avatars.githubusercontent.com/u/20563423?v=3","gravatar_id":"","url":"https://api.github.com/users/LukaszStem","html_url":"https://github.com/LukaszStem","followers_url":"https://api.github.com/users/LukaszStem/followers","following_url":"https://api.github.com/users/LukaszStem/following{/other_user}","gists_url":"https://api.github.com/users/LukaszStem/gists{/gist_id}","starred_url":"https://api.github.com/users/LukaszStem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukaszStem/subscriptions","organizations_url":"https://api.github.com/users/LukaszStem/orgs","repos_url":"https://api.github.com/users/LukaszStem/repos","events_url":"https://api.github.com/users/LukaszStem/events{/privacy}","received_events_url":"https://api.github.com/users/LukaszStem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LukaszStem/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":true,"url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli","forks_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/releases{/id}","deployments_url":"https://api.github.com/repos/LukaszStem/azure-xplat-cli/deployments","created_at":"2016-10-17T18:01:53Z","updated_at":"2016-10-17T18:02:01Z","pushed_at":"2016-12-02T21:50:55Z","git_url":"git://github.com/LukaszStem/azure-xplat-cli.git","ssh_url":"git@github.com:LukaszStem/azure-xplat-cli.git","clone_url":"https://github.com/LukaszStem/azure-xplat-cli.git","svn_url":"https://github.com/LukaszStem/azure-xplat-cli","homepage":"","size":87754,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"c3311d9e88526b5e4eeee1b0f8421357a2a38c2c","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":6506651,"name":"azure-xplat-cli","full_name":"Azure/azure-xplat-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-xplat-cli","description":"Microsoft Azure Cross Platform Command Line","fork":false,"url":"https://api.github.com/repos/Azure/azure-xplat-cli","forks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-xplat-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-xplat-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-xplat-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-xplat-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-xplat-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-xplat-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-xplat-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-xplat-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-xplat-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-xplat-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-xplat-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-xplat-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-xplat-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-xplat-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-xplat-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-xplat-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-xplat-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-xplat-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-xplat-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-xplat-cli/deployments","created_at":"2012-11-02T13:43:50Z","updated_at":"2016-12-05T18:57:58Z","pushed_at":"2016-12-05T19:50:17Z","git_url":"git://github.com/Azure/azure-xplat-cli.git","ssh_url":"git@github.com:Azure/azure-xplat-cli.git","clone_url":"https://github.com/Azure/azure-xplat-cli.git","svn_url":"https://github.com/Azure/azure-xplat-cli","homepage":"","size":106830,"stargazers_count":509,"watchers_count":509,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":369,"mirror_url":null,"open_issues_count":212,"forks":369,"open_issues":212,"watchers":509,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364"},"html":{"href":"https://github.com/Azure/azure-xplat-cli/pull/3364"},"issue":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3364"},"comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/issues/3364/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/pulls/3364/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-xplat-cli/statuses/439a06b84e651a8a19ec5bea99846e6337491a64"}}}}
{"actor":{"display_login":"amarzavery"}}