{"action":"created","comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments/83145839","pull_request_review_id":4004644,"id":83145839,"diff_hunk":"@@ -139,6 +147,44 @@ WebProcessingServiceCatalogFunction.parameterConverters = [\n         }\n     },\n     {\n+        id: 'RegionType',\n+        inputToFunctionParameter: function(catalogFunction, input) {\n+            if (!defined(input.LiteralData)) {\n+                return undefined;\n+            }\n+\n+            if (input.Identifier !== \"regionType\") {\n+                return undefined;\n+            }\n+\n+            var allowedValues = input.LiteralData.AllowedValues;\n+            var validRegionTypes;\n+            if (defined(allowedValues)) {\n+                var allowed = allowedValues.Value.slice();\n+                if (typeof(allowed) === \"string\") {","path":"lib/Models/WebProcessingServiceCatalogFunction.js","position":47,"original_position":47,"commit_id":"e6e46557eb1b4641104459f008deaae32837bb0b","original_commit_id":"efa8d7dccdbc5a9b7b5363fc31a7861c559acb8a","user":{"login":"kring","id":924374,"avatar_url":"https://avatars.githubusercontent.com/u/924374?v=3","gravatar_id":"","url":"https://api.github.com/users/kring","html_url":"https://github.com/kring","followers_url":"https://api.github.com/users/kring/followers","following_url":"https://api.github.com/users/kring/following{/other_user}","gists_url":"https://api.github.com/users/kring/gists{/gist_id}","starred_url":"https://api.github.com/users/kring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kring/subscriptions","organizations_url":"https://api.github.com/users/kring/orgs","repos_url":"https://api.github.com/users/kring/repos","events_url":"https://api.github.com/users/kring/events{/privacy}","received_events_url":"https://api.github.com/users/kring/received_events","type":"User","site_admin":false},"body":"No parenthesis around `(allowed)`, use single quotes.","created_at":"2016-10-13T05:18:47Z","updated_at":"2016-10-13T05:18:47Z","html_url":"https://github.com/TerriaJS/terriajs/pull/2170#discussion_r83145839","pull_request_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170","_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments/83145839"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/2170#discussion_r83145839"},"pull_request":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170"}}},"pull_request":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170","id":89117489,"html_url":"https://github.com/TerriaJS/terriajs/pull/2170","diff_url":"https://github.com/TerriaJS/terriajs/pull/2170.diff","patch_url":"https://github.com/TerriaJS/terriajs/pull/2170.patch","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2170","number":2170,"state":"open","locked":false,"title":"Region WPS","user":{"login":"rdengate","id":3466267,"avatar_url":"https://avatars.githubusercontent.com/u/3466267?v=3","gravatar_id":"","url":"https://api.github.com/users/rdengate","html_url":"https://github.com/rdengate","followers_url":"https://api.github.com/users/rdengate/followers","following_url":"https://api.github.com/users/rdengate/following{/other_user}","gists_url":"https://api.github.com/users/rdengate/gists{/gist_id}","starred_url":"https://api.github.com/users/rdengate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdengate/subscriptions","organizations_url":"https://api.github.com/users/rdengate/orgs","repos_url":"https://api.github.com/users/rdengate/repos","events_url":"https://api.github.com/users/rdengate/events{/privacy}","received_events_url":"https://api.github.com/users/rdengate/received_events","type":"User","site_admin":false},"body":"This allows region as a WPS input parameter, and also changes the widget so that the region is selected on the map rather than on a preview map in the data catalog (this change affects Analytics as well). \r\n\r\nFixes some bugs as well. For example, countries can now be selected by clicking on the map rather than only via autocomplete, and autocomplete now works if user enters a capital letter as the first letter of the region.","created_at":"2016-10-13T00:19:18Z","updated_at":"2016-10-13T05:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"517ca97ba574ec3b34263f134c1a0b107678cb4f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170/commits","review_comments_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170/comments","review_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2170/comments","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/e6e46557eb1b4641104459f008deaae32837bb0b","head":{"label":"TerriaJS:rd_region_wps","ref":"rd_region_wps","sha":"e6e46557eb1b4641104459f008deaae32837bb0b","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2016-10-08T15:49:18Z","pushed_at":"2016-10-13T05:31:22Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":59639,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":256,"forks":73,"open_issues":256,"watchers":139,"default_branch":"master"}},"base":{"label":"TerriaJS:master","ref":"master","sha":"9bc4474ba8655a7b58ad0874899d48002fb76f21","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars.githubusercontent.com/u/12078432?v=3","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2016-10-08T15:49:18Z","pushed_at":"2016-10-13T05:31:22Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":59639,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":256,"forks":73,"open_issues":256,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/2170"},"issue":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/2170"},"comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/2170/comments"},"review_comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170/comments"},"review_comment":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2170/commits"},"statuses":{"href":"https://api.github.com/repos/TerriaJS/terriajs/statuses/e6e46557eb1b4641104459f008deaae32837bb0b"}}}}
{"actor":{"display_login":"kring"}}