{"action":"created","issue":{"url":"https://api.github.com/repos/ros/ros_comm/issues/882","repository_url":"https://api.github.com/repos/ros/ros_comm","labels_url":"https://api.github.com/repos/ros/ros_comm/issues/882/labels{/name}","comments_url":"https://api.github.com/repos/ros/ros_comm/issues/882/comments","events_url":"https://api.github.com/repos/ros/ros_comm/issues/882/events","html_url":"https://github.com/ros/ros_comm/pull/882","id":174051881,"number":882,"title":"[roslaunch] Added condition to skip empty ('') <include> paths","user":{"login":"jliviero","id":16312082,"avatar_url":"https://avatars.githubusercontent.com/u/16312082?v=3","gravatar_id":"","url":"https://api.github.com/users/jliviero","html_url":"https://github.com/jliviero","followers_url":"https://api.github.com/users/jliviero/followers","following_url":"https://api.github.com/users/jliviero/following{/other_user}","gists_url":"https://api.github.com/users/jliviero/gists{/gist_id}","starred_url":"https://api.github.com/users/jliviero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jliviero/subscriptions","organizations_url":"https://api.github.com/users/jliviero/orgs","repos_url":"https://api.github.com/users/jliviero/repos","events_url":"https://api.github.com/users/jliviero/events{/privacy}","received_events_url":"https://api.github.com/users/jliviero/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ros/ros_comm/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-30T15:33:26Z","updated_at":"2016-09-07T18:06:36Z","closed_at":"2016-09-07T18:06:35Z","pull_request":{"url":"https://api.github.com/repos/ros/ros_comm/pulls/882","html_url":"https://github.com/ros/ros_comm/pull/882","diff_url":"https://github.com/ros/ros_comm/pull/882.diff","patch_url":"https://github.com/ros/ros_comm/pull/882.patch"},"body":"Our internal build system runs roslaunch-check against relevant packages, which will fail when it encounters `<include file='' />`. This change allows roslaunch-check to pass, but prints a warning when such an include is encountered.\r\n\r\nThis allows a file path to be passed in as an arg, and left empty by default, and still have roslaunch-check pass (but with a warning).  For example:\r\n\r\n```\r\n<launch>\r\n  <arg name=\"some_mesh_launch\" default=\"\"/>\r\n\r\n  <group if=\"$(eval len(some_mesh_launch) > 0)\">\r\n    <include file=\"$(arg some_mesh_launch)\"/>\r\n  </group>\r\n\r\n</launch>\r\n```"},"comment":{"url":"https://api.github.com/repos/ros/ros_comm/issues/comments/245367551","html_url":"https://github.com/ros/ros_comm/pull/882#issuecomment-245367551","issue_url":"https://api.github.com/repos/ros/ros_comm/issues/882","id":245367551,"user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T18:06:35Z","updated_at":"2016-09-07T18:06:35Z","body":"Any unnecessary whitespace changes just make it more difficult to backport changes between different branches. Therefore I have cherry-picked your patch (without the whitespace changes) to the *kinetic-devel* branch: b323b8d5987036357fe2b272b57a77cc9ee2647b\r\n\r\nThank you for the PR."}}
{"actor":{"display_login":"dirk-thomas"}}