{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/84479711","pull_request_review_id":5256864,"id":84479711,"diff_hunk":"@@ -12,7 +12,7 @@ ARG         DEBIAN_FRONTEND=noninteractive\n user root\n # Install required npm packages\n RUN  curl -sL https://deb.nodesource.com/setup_6.x | bash - && \\\n-        apt-get install -y -o APT::Install-Recommends=false -o APT::Install-Suggests=false \\","path":"master/contrib/docker/pythonnode_worker/Dockerfile","position":4,"original_position":4,"commit_id":"95beb7e33e9b63dc9b43c189eaf1991e191660c6","original_commit_id":"95beb7e33e9b63dc9b43c189eaf1991e191660c6","user":{"login":"capitalaslash","id":204102,"avatar_url":"https://avatars.githubusercontent.com/u/204102?v=3","gravatar_id":"","url":"https://api.github.com/users/capitalaslash","html_url":"https://github.com/capitalaslash","followers_url":"https://api.github.com/users/capitalaslash/followers","following_url":"https://api.github.com/users/capitalaslash/following{/other_user}","gists_url":"https://api.github.com/users/capitalaslash/gists{/gist_id}","starred_url":"https://api.github.com/users/capitalaslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capitalaslash/subscriptions","organizations_url":"https://api.github.com/users/capitalaslash/orgs","repos_url":"https://api.github.com/users/capitalaslash/repos","events_url":"https://api.github.com/users/capitalaslash/events{/privacy}","received_events_url":"https://api.github.com/users/capitalaslash/received_events","type":"User","site_admin":false},"body":"sorry, I removed that line and did not bother to check the script.\r\nanyway, as this should be an example for general purpose workers, it seems not so clear (at least to me). maybe mention it in the comment above?","created_at":"2016-10-21T13:36:33Z","updated_at":"2016-10-21T13:36:33Z","html_url":"https://github.com/buildbot/buildbot/pull/2458#discussion_r84479711","pull_request_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2458","_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments/84479711"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2458#discussion_r84479711"},"pull_request":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2458"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2458","id":90378256,"html_url":"https://github.com/buildbot/buildbot/pull/2458","diff_url":"https://github.com/buildbot/buildbot/pull/2458.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2458.patch","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2458","number":2458,"state":"open","locked":false,"title":"worker Dockerfile bugfix","user":{"login":"capitalaslash","id":204102,"avatar_url":"https://avatars.githubusercontent.com/u/204102?v=3","gravatar_id":"","url":"https://api.github.com/users/capitalaslash","html_url":"https://github.com/capitalaslash","followers_url":"https://api.github.com/users/capitalaslash/followers","following_url":"https://api.github.com/users/capitalaslash/following{/other_user}","gists_url":"https://api.github.com/users/capitalaslash/gists{/gist_id}","starred_url":"https://api.github.com/users/capitalaslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capitalaslash/subscriptions","organizations_url":"https://api.github.com/users/capitalaslash/orgs","repos_url":"https://api.github.com/users/capitalaslash/repos","events_url":"https://api.github.com/users/capitalaslash/events{/privacy}","received_events_url":"https://api.github.com/users/capitalaslash/received_events","type":"User","site_admin":false},"body":"before `apt-get install` always `apt-get update`, otherwise no packages will be found.","created_at":"2016-10-21T13:01:22Z","updated_at":"2016-10-21T13:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"398236cb6f7d956797193e4e94855236eabd6b82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2458/commits","review_comments_url":"https://api.github.com/repos/buildbot/buildbot/pulls/2458/comments","review_comment_url":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2458/comments","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/95beb7e33e9b63dc9b43c189eaf1991e191660c6","head":{"label":"capitalaslash:patch-1","ref":"patch-1","sha":"95beb7e33e9b63dc9b43c189eaf1991e191660c6","user":{"login":"capitalaslash","id":204102,"avatar_url":"https://avatars.githubusercontent.com/u/204102?v=3","gravatar_id":"","url":"https://api.github.com/users/capitalaslash","html_url":"https://github.com/capitalaslash","followers_url":"https://api.github.com/users/capitalaslash/followers","following_url":"https://api.github.com/users/capitalaslash/following{/other_user}","gists_url":"https://api.github.com/users/capitalaslash/gists{/gist_id}","starred_url":"https://api.github.com/users/capitalaslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capitalaslash/subscriptions","organizations_url":"https://api.github.com/users/capitalaslash/orgs","repos_url":"https://api.github.com/users/capitalaslash/repos","events_url":"https://api.github.com/users/capitalaslash/events{/privacy}","received_events_url":"https://api.github.com/users/capitalaslash/received_events","type":"User","site_admin":false},"repo":{"id":71564712,"name":"buildbot","full_name":"capitalaslash/buildbot","owner":{"login":"capitalaslash","id":204102,"avatar_url":"https://avatars.githubusercontent.com/u/204102?v=3","gravatar_id":"","url":"https://api.github.com/users/capitalaslash","html_url":"https://github.com/capitalaslash","followers_url":"https://api.github.com/users/capitalaslash/followers","following_url":"https://api.github.com/users/capitalaslash/following{/other_user}","gists_url":"https://api.github.com/users/capitalaslash/gists{/gist_id}","starred_url":"https://api.github.com/users/capitalaslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capitalaslash/subscriptions","organizations_url":"https://api.github.com/users/capitalaslash/orgs","repos_url":"https://api.github.com/users/capitalaslash/repos","events_url":"https://api.github.com/users/capitalaslash/events{/privacy}","received_events_url":"https://api.github.com/users/capitalaslash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/capitalaslash/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":true,"url":"https://api.github.com/repos/capitalaslash/buildbot","forks_url":"https://api.github.com/repos/capitalaslash/buildbot/forks","keys_url":"https://api.github.com/repos/capitalaslash/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capitalaslash/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capitalaslash/buildbot/teams","hooks_url":"https://api.github.com/repos/capitalaslash/buildbot/hooks","issue_events_url":"https://api.github.com/repos/capitalaslash/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/capitalaslash/buildbot/events","assignees_url":"https://api.github.com/repos/capitalaslash/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/capitalaslash/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/capitalaslash/buildbot/tags","blobs_url":"https://api.github.com/repos/capitalaslash/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capitalaslash/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capitalaslash/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/capitalaslash/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capitalaslash/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/capitalaslash/buildbot/languages","stargazers_url":"https://api.github.com/repos/capitalaslash/buildbot/stargazers","contributors_url":"https://api.github.com/repos/capitalaslash/buildbot/contributors","subscribers_url":"https://api.github.com/repos/capitalaslash/buildbot/subscribers","subscription_url":"https://api.github.com/repos/capitalaslash/buildbot/subscription","commits_url":"https://api.github.com/repos/capitalaslash/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/capitalaslash/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/capitalaslash/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/capitalaslash/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/capitalaslash/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/capitalaslash/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capitalaslash/buildbot/merges","archive_url":"https://api.github.com/repos/capitalaslash/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capitalaslash/buildbot/downloads","issues_url":"https://api.github.com/repos/capitalaslash/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/capitalaslash/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/capitalaslash/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/capitalaslash/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capitalaslash/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/capitalaslash/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/capitalaslash/buildbot/deployments","created_at":"2016-10-21T12:56:12Z","updated_at":"2016-10-21T12:56:22Z","pushed_at":"2016-10-21T13:08:01Z","git_url":"git://github.com/capitalaslash/buildbot.git","ssh_url":"git@github.com:capitalaslash/buildbot.git","clone_url":"https://github.com/capitalaslash/buildbot.git","svn_url":"https://github.com/capitalaslash/buildbot","homepage":"http://buildbot.net","size":90821,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"4387bb1f09eb7993035b9fbd4d6d5bb3d8f5c80b","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":760165,"name":"buildbot","full_name":"buildbot/buildbot","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/buildbot","description":"Python-based continuous integration testing framework; your pull requests are more than welcome!","fork":false,"url":"https://api.github.com/repos/buildbot/buildbot","forks_url":"https://api.github.com/repos/buildbot/buildbot/forks","keys_url":"https://api.github.com/repos/buildbot/buildbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/buildbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/buildbot/teams","hooks_url":"https://api.github.com/repos/buildbot/buildbot/hooks","issue_events_url":"https://api.github.com/repos/buildbot/buildbot/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/buildbot/events","assignees_url":"https://api.github.com/repos/buildbot/buildbot/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/buildbot/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/buildbot/tags","blobs_url":"https://api.github.com/repos/buildbot/buildbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/buildbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/buildbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/buildbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/buildbot/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/buildbot/languages","stargazers_url":"https://api.github.com/repos/buildbot/buildbot/stargazers","contributors_url":"https://api.github.com/repos/buildbot/buildbot/contributors","subscribers_url":"https://api.github.com/repos/buildbot/buildbot/subscribers","subscription_url":"https://api.github.com/repos/buildbot/buildbot/subscription","commits_url":"https://api.github.com/repos/buildbot/buildbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/buildbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/buildbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/buildbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/buildbot/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/buildbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/buildbot/merges","archive_url":"https://api.github.com/repos/buildbot/buildbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/buildbot/downloads","issues_url":"https://api.github.com/repos/buildbot/buildbot/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/buildbot/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/buildbot/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/buildbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/buildbot/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/buildbot/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/buildbot/deployments","created_at":"2010-07-06T17:56:53Z","updated_at":"2016-10-21T07:52:38Z","pushed_at":"2016-10-21T13:29:17Z","git_url":"git://github.com/buildbot/buildbot.git","ssh_url":"git@github.com:buildbot/buildbot.git","clone_url":"https://github.com/buildbot/buildbot.git","svn_url":"https://github.com/buildbot/buildbot","homepage":"http://buildbot.net","size":90885,"stargazers_count":2408,"watchers_count":2408,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":973,"mirror_url":null,"open_issues_count":13,"forks":973,"open_issues":13,"watchers":2408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2458"},"html":{"href":"https://github.com/buildbot/buildbot/pull/2458"},"issue":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2458"},"comments":{"href":"https://api.github.com/repos/buildbot/buildbot/issues/2458/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2458/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/buildbot/pulls/2458/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/buildbot/statuses/95beb7e33e9b63dc9b43c189eaf1991e191660c6"}}}}
{"actor":{"display_login":"capitalaslash"}}