{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/70387707","id":70387707,"diff_hunk":"@@ -168,6 +170,11 @@ public DataSourceModule( final GraphDatabaseFacadeFactory.Dependencies dependenc\n         DbmsOperations dbmsOperations = new NonTransactionalDbmsOperations( procedures );\n         deps.satisfyDependency( dbmsOperations );\n \n+        for ( SessionManager candidate : Service.load( SessionManager.class ) )","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/factory/DataSourceModule.java","position":12,"original_position":20,"commit_id":"d9995575591650b3319776c4385ddf3bb4c29d7f","original_commit_id":"5e5fddf4ba6762bf15b33f89369bc1c3c28b6335","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars.githubusercontent.com/u/3527193?v=3","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"body":"Still, I cannot see any good alternatives. The service mechanism was used to avoid circular dependencies between kernel and bolt. I guess we would run into problem if another SessionManager is introduced as a Service, but that is not something that is done by accident, and anyway needs additional work on what that would actually mean. Happy to take suggestions over say slack, but otherwise I think we could take this solution for now, and solve later problems later.","created_at":"2016-07-12T07:18:33Z","updated_at":"2016-07-12T07:18:33Z","html_url":"https://github.com/neo4j/neo4j/pull/7532#discussion_r70387707","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7532","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/70387707"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7532#discussion_r70387707"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7532"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/7532","id":76588936,"html_url":"https://github.com/neo4j/neo4j/pull/7532","diff_url":"https://github.com/neo4j/neo4j/pull/7532.diff","patch_url":"https://github.com/neo4j/neo4j/pull/7532.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/7532","number":7532,"state":"open","locked":false,"title":"Procedures for managing bolt sessions","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars.githubusercontent.com/u/3527193?v=3","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"body":"- Added a procedure call test to Bolt\r\n\r\n- Added a procedure for listing the number of active Bolt sessions per user\r\n\r\n- Added a procedure allowing for the termination of all a user's Bolt sessions\r\n","created_at":"2016-07-07T12:48:07Z","updated_at":"2016-07-12T07:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01ee4b4058f8dd0cd1591d18e1ffd11b00cd6bdf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7532/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7532/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/7532/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/d9995575591650b3319776c4385ddf3bb4c29d7f","head":{"label":"fickludd:3.1-manage-bolt-sessions","ref":"3.1-manage-bolt-sessions","sha":"d9995575591650b3319776c4385ddf3bb4c29d7f","user":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars.githubusercontent.com/u/3527193?v=3","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"repo":{"id":60172359,"name":"neo4j","full_name":"fickludd/neo4j","owner":{"login":"fickludd","id":3527193,"avatar_url":"https://avatars.githubusercontent.com/u/3527193?v=3","gravatar_id":"","url":"https://api.github.com/users/fickludd","html_url":"https://github.com/fickludd","followers_url":"https://api.github.com/users/fickludd/followers","following_url":"https://api.github.com/users/fickludd/following{/other_user}","gists_url":"https://api.github.com/users/fickludd/gists{/gist_id}","starred_url":"https://api.github.com/users/fickludd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fickludd/subscriptions","organizations_url":"https://api.github.com/users/fickludd/orgs","repos_url":"https://api.github.com/users/fickludd/repos","events_url":"https://api.github.com/users/fickludd/events{/privacy}","received_events_url":"https://api.github.com/users/fickludd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fickludd/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/fickludd/neo4j","forks_url":"https://api.github.com/repos/fickludd/neo4j/forks","keys_url":"https://api.github.com/repos/fickludd/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fickludd/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fickludd/neo4j/teams","hooks_url":"https://api.github.com/repos/fickludd/neo4j/hooks","issue_events_url":"https://api.github.com/repos/fickludd/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/fickludd/neo4j/events","assignees_url":"https://api.github.com/repos/fickludd/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/fickludd/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/fickludd/neo4j/tags","blobs_url":"https://api.github.com/repos/fickludd/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fickludd/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fickludd/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/fickludd/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fickludd/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/fickludd/neo4j/languages","stargazers_url":"https://api.github.com/repos/fickludd/neo4j/stargazers","contributors_url":"https://api.github.com/repos/fickludd/neo4j/contributors","subscribers_url":"https://api.github.com/repos/fickludd/neo4j/subscribers","subscription_url":"https://api.github.com/repos/fickludd/neo4j/subscription","commits_url":"https://api.github.com/repos/fickludd/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/fickludd/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/fickludd/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/fickludd/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/fickludd/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/fickludd/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fickludd/neo4j/merges","archive_url":"https://api.github.com/repos/fickludd/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fickludd/neo4j/downloads","issues_url":"https://api.github.com/repos/fickludd/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/fickludd/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/fickludd/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/fickludd/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fickludd/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/fickludd/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/fickludd/neo4j/deployments","created_at":"2016-06-01T11:49:30Z","updated_at":"2016-07-01T13:40:19Z","pushed_at":"2016-07-12T07:11:53Z","git_url":"git://github.com/fickludd/neo4j.git","ssh_url":"git@github.com:fickludd/neo4j.git","clone_url":"https://github.com/fickludd/neo4j.git","svn_url":"https://github.com/fickludd/neo4j","homepage":"http://neo4j.com","size":304162,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"3.1"}},"base":{"label":"neo4j:3.1","ref":"3.1","sha":"e8c3e31f8945ad71c5c428c3d123bac8f5593d86","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-07-11T20:20:53Z","pushed_at":"2016-07-12T07:11:55Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":371494,"stargazers_count":2783,"watchers_count":2783,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":946,"mirror_url":null,"open_issues_count":380,"forks":946,"open_issues":380,"watchers":2783,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7532"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7532"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7532"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7532/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7532/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7532/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/d9995575591650b3319776c4385ddf3bb4c29d7f"}}}}
{"actor":{"display_login":"fickludd"}}