{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/85647867","pull_request_review_id":6353716,"id":85647867,"diff_hunk":"@@ -0,0 +1,664 @@\n+===============================\n+Integration with module systems\n+===============================\n+\n+The use of module systems to manage user environment in a controlled way\n+is a common practice at HPC centers that is often embraced also by individual\n+programmers on their development machines. To blend in this common practice\n+Spack provides integration with `Environment Modules\n+<http://modules.sourceforge.net/>`_ ,  `LMod\n+<http://lmod.readthedocs.io/en/latest/>`_ and `Dotkit <https://computing.llnl.gov/?set=jobs&page=dotkit>`_ by:\n+\n+* generating module files after a successful installation\n+* providing commands that can leverage the spec syntax to manipulate modules\n+\n+In the following you will see how to activate shell support for commands in Spack\n+that requires it, and discover what benefits this may bring with respect to deal\n+directly with automatically generated module files.\n+\n+.. note::\n+\n+   If your machine does not already have a module system installed,\n+   we advise you to use either Environment Modules or LMod. See :ref:`InstallEnvironmentModules`\n+   for more details.\n+\n+----------------------\n+Activate shell support\n+----------------------\n+","path":"lib/spack/docs/module_file_support.rst","position":28,"original_position":28,"commit_id":"83a5690bd3325e615b41689880762bf907c11f0d","original_commit_id":"83a5690bd3325e615b41689880762bf907c11f0d","user":{"login":"citibeth","id":1924215,"avatar_url":"https://avatars.githubusercontent.com/u/1924215?v=3","gravatar_id":"","url":"https://api.github.com/users/citibeth","html_url":"https://github.com/citibeth","followers_url":"https://api.github.com/users/citibeth/followers","following_url":"https://api.github.com/users/citibeth/following{/other_user}","gists_url":"https://api.github.com/users/citibeth/gists{/gist_id}","starred_url":"https://api.github.com/users/citibeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citibeth/subscriptions","organizations_url":"https://api.github.com/users/citibeth/orgs","repos_url":"https://api.github.com/users/citibeth/repos","events_url":"https://api.github.com/users/citibeth/events{/privacy}","received_events_url":"https://api.github.com/users/citibeth/received_events","type":"User","site_admin":false},"body":"> that one of the things that step does is makes Spack's environment modules available for use.\r\n\r\n...except you can already use them without activating Spack shell support.\r\n","created_at":"2016-10-29T20:34:56Z","updated_at":"2016-10-29T20:34:56Z","html_url":"https://github.com/LLNL/spack/pull/2169#discussion_r85647867","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/2169","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/85647867"},"html":{"href":"https://github.com/LLNL/spack/pull/2169#discussion_r85647867"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2169"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/2169","id":91491045,"html_url":"https://github.com/LLNL/spack/pull/2169","diff_url":"https://github.com/LLNL/spack/pull/2169.diff","patch_url":"https://github.com/LLNL/spack/pull/2169.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/2169","number":2169,"state":"open","locked":false,"title":"module file support: major rework of docs","user":{"login":"alalazo","id":4199709,"avatar_url":"https://avatars.githubusercontent.com/u/4199709?v=3","gravatar_id":"","url":"https://api.github.com/users/alalazo","html_url":"https://github.com/alalazo","followers_url":"https://api.github.com/users/alalazo/followers","following_url":"https://api.github.com/users/alalazo/following{/other_user}","gists_url":"https://api.github.com/users/alalazo/gists{/gist_id}","starred_url":"https://api.github.com/users/alalazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalazo/subscriptions","organizations_url":"https://api.github.com/users/alalazo/orgs","repos_url":"https://api.github.com/users/alalazo/repos","events_url":"https://api.github.com/users/alalazo/events{/privacy}","received_events_url":"https://api.github.com/users/alalazo/received_events","type":"User","site_admin":false},"body":"##### Modifications\r\n- [x] Give more prominence to module file support in spack\r\n- [x] Add details to docs on module file generation and maintenance\r\n- [x] Add ``lmod`` to docs\r\n- [x] Change syntax for naming schemes according to #1848 \r\n\r\n@tgamblin @adamjstewart @citibeth @glennpj @davydden @scheibelp : could you please have a look and suggest modifications / fixes if needed ?","created_at":"2016-10-29T14:45:35Z","updated_at":"2016-10-29T20:34:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f79ee240af56e51cb0f374a43cbf9da33f4bec3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/2169/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/2169/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/2169/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/83a5690bd3325e615b41689880762bf907c11f0d","head":{"label":"epfl-scitas:documentation/update_for_modules","ref":"documentation/update_for_modules","sha":"83a5690bd3325e615b41689880762bf907c11f0d","user":{"login":"epfl-scitas","id":14820957,"avatar_url":"https://avatars.githubusercontent.com/u/14820957?v=3","gravatar_id":"","url":"https://api.github.com/users/epfl-scitas","html_url":"https://github.com/epfl-scitas","followers_url":"https://api.github.com/users/epfl-scitas/followers","following_url":"https://api.github.com/users/epfl-scitas/following{/other_user}","gists_url":"https://api.github.com/users/epfl-scitas/gists{/gist_id}","starred_url":"https://api.github.com/users/epfl-scitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epfl-scitas/subscriptions","organizations_url":"https://api.github.com/users/epfl-scitas/orgs","repos_url":"https://api.github.com/users/epfl-scitas/repos","events_url":"https://api.github.com/users/epfl-scitas/events{/privacy}","received_events_url":"https://api.github.com/users/epfl-scitas/received_events","type":"Organization","site_admin":false},"repo":{"id":43118298,"name":"spack","full_name":"epfl-scitas/spack","owner":{"login":"epfl-scitas","id":14820957,"avatar_url":"https://avatars.githubusercontent.com/u/14820957?v=3","gravatar_id":"","url":"https://api.github.com/users/epfl-scitas","html_url":"https://github.com/epfl-scitas","followers_url":"https://api.github.com/users/epfl-scitas/followers","following_url":"https://api.github.com/users/epfl-scitas/following{/other_user}","gists_url":"https://api.github.com/users/epfl-scitas/gists{/gist_id}","starred_url":"https://api.github.com/users/epfl-scitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epfl-scitas/subscriptions","organizations_url":"https://api.github.com/users/epfl-scitas/orgs","repos_url":"https://api.github.com/users/epfl-scitas/repos","events_url":"https://api.github.com/users/epfl-scitas/events{/privacy}","received_events_url":"https://api.github.com/users/epfl-scitas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/epfl-scitas/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/epfl-scitas/spack","forks_url":"https://api.github.com/repos/epfl-scitas/spack/forks","keys_url":"https://api.github.com/repos/epfl-scitas/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epfl-scitas/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epfl-scitas/spack/teams","hooks_url":"https://api.github.com/repos/epfl-scitas/spack/hooks","issue_events_url":"https://api.github.com/repos/epfl-scitas/spack/issues/events{/number}","events_url":"https://api.github.com/repos/epfl-scitas/spack/events","assignees_url":"https://api.github.com/repos/epfl-scitas/spack/assignees{/user}","branches_url":"https://api.github.com/repos/epfl-scitas/spack/branches{/branch}","tags_url":"https://api.github.com/repos/epfl-scitas/spack/tags","blobs_url":"https://api.github.com/repos/epfl-scitas/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epfl-scitas/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epfl-scitas/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/epfl-scitas/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epfl-scitas/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/epfl-scitas/spack/languages","stargazers_url":"https://api.github.com/repos/epfl-scitas/spack/stargazers","contributors_url":"https://api.github.com/repos/epfl-scitas/spack/contributors","subscribers_url":"https://api.github.com/repos/epfl-scitas/spack/subscribers","subscription_url":"https://api.github.com/repos/epfl-scitas/spack/subscription","commits_url":"https://api.github.com/repos/epfl-scitas/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/epfl-scitas/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/epfl-scitas/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/epfl-scitas/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/epfl-scitas/spack/contents/{+path}","compare_url":"https://api.github.com/repos/epfl-scitas/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epfl-scitas/spack/merges","archive_url":"https://api.github.com/repos/epfl-scitas/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epfl-scitas/spack/downloads","issues_url":"https://api.github.com/repos/epfl-scitas/spack/issues{/number}","pulls_url":"https://api.github.com/repos/epfl-scitas/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/epfl-scitas/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/epfl-scitas/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epfl-scitas/spack/labels{/name}","releases_url":"https://api.github.com/repos/epfl-scitas/spack/releases{/id}","deployments_url":"https://api.github.com/repos/epfl-scitas/spack/deployments","created_at":"2015-09-25T08:01:24Z","updated_at":"2016-10-25T12:16:40Z","pushed_at":"2016-10-29T16:24:14Z","git_url":"git://github.com/epfl-scitas/spack.git","ssh_url":"git@github.com:epfl-scitas/spack.git","clone_url":"https://github.com/epfl-scitas/spack.git","svn_url":"https://github.com/epfl-scitas/spack","homepage":"http://scalability-llnl.github.io/spack","size":12436,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"releases/lafnetscha"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"c82985cb5e280981a1064855f1577c9a22ac5700","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-10-22T21:29:06Z","pushed_at":"2016-10-29T16:24:14Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":21000,"stargazers_count":166,"watchers_count":166,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":151,"mirror_url":null,"open_issues_count":361,"forks":151,"open_issues":361,"watchers":166,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2169"},"html":{"href":"https://github.com/LLNL/spack/pull/2169"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/2169"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/2169/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2169/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2169/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/83a5690bd3325e615b41689880762bf907c11f0d"}}}}
{"actor":{"display_login":"citibeth"}}