{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/69740579","id":69740579,"diff_hunk":"@@ -203,3 +211,49 @@ func (s Service) LabelsByPrefix(prefix string) map[string]string {\n \t}\n \treturn returnLabels\n }\n+\n+func (me Service) ExternalPorts() []Port {\n+\text := []Port{}\n+\n+\tfor _, port := range me.Ports {\n+\t\tif port.Balancer != 0 {\n+\t\t\text = append(ext, port)\n+\t\t}\n+\t}\n+\n+\treturn ext\n+}\n+\n+func (me Service) InternalPorts() []Port {\n+\tinternal := []Port{}\n+\n+\tfor _, port := range me.Ports {\n+\t\tif port.Balancer == 0 {\n+\t\t\tinternal = append(internal, port)\n+\t\t}\n+\t}\n+\n+\treturn internal\n+}\n+\n+func (me Service) ContainerPorts() []string {\n+\text := []string{}\n+\n+\tfor _, port := range me.Ports {\n+\t\tif port.Container != 0 {\n+\t\t\text = append(ext, strconv.Itoa(port.Container))\n+\t\t}\n+\t}\n+\n+\tsort.Strings(ext)\n+\n+\treturn ext\n+}\n+\n+func (me Service) RegistryImage(appName, buildId string, outputs map[string]string) string {\n+\tif registryId := outputs[\"RegistryId\"]; registryId != \"\" {","path":"manifest/service.go","position":69,"original_position":69,"commit_id":"1636ec603cd1ba1b8af3721efbe4f84b4b58e8be","original_commit_id":"1636ec603cd1ba1b8af3721efbe4f84b4b58e8be","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"var registryId should be registryID","created_at":"2016-07-06T14:27:56Z","updated_at":"2016-07-06T14:27:56Z","html_url":"https://github.com/convox/rack/pull/845#discussion_r69740579","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/845","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/69740579"},"html":{"href":"https://github.com/convox/rack/pull/845#discussion_r69740579"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/845"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/845","id":76441446,"html_url":"https://github.com/convox/rack/pull/845","diff_url":"https://github.com/convox/rack/pull/845.diff","patch_url":"https://github.com/convox/rack/pull/845.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/845","number":845,"state":"open","locked":false,"title":"One manifest to rule them all","user":{"login":"awsmsrc","id":994907,"avatar_url":"https://avatars.githubusercontent.com/u/994907?v=3","gravatar_id":"","url":"https://api.github.com/users/awsmsrc","html_url":"https://github.com/awsmsrc","followers_url":"https://api.github.com/users/awsmsrc/followers","following_url":"https://api.github.com/users/awsmsrc/following{/other_user}","gists_url":"https://api.github.com/users/awsmsrc/gists{/gist_id}","starred_url":"https://api.github.com/users/awsmsrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awsmsrc/subscriptions","organizations_url":"https://api.github.com/users/awsmsrc/orgs","repos_url":"https://api.github.com/users/awsmsrc/repos","events_url":"https://api.github.com/users/awsmsrc/events{/privacy}","received_events_url":"https://api.github.com/users/awsmsrc/received_events","type":"User","site_admin":false},"body":"## Release Playbook\r\n- [ ] Rebase against master\r\n- [ ] Release branch ()\r\n- [ ] Pass CI ()\r\n- [ ] Code review\r\n- [ ] Merge into master\r\n- [ ] Release master ()\r\n- [ ] Pass CI ()\r\n- [ ] Update staging rack\r\n- [ ] Edit [Rack release record](https://github.com/convox/rack/releases) and/or update [docs](https://github.com/convox/convox.github.io)\r\n- [ ] Publish release\r\n- [ ] Release CLI\r\n","created_at":"2016-07-06T14:27:44Z","updated_at":"2016-07-06T14:27:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e4f08f09ffb0f67d4ad72c87261fa9cb5a05729","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/845/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/845/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/845/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/1636ec603cd1ba1b8af3721efbe4f84b4b58e8be","head":{"label":"convox:one_manifest_to_rule_them_all","ref":"one_manifest_to_rule_them_all","sha":"1636ec603cd1ba1b8af3721efbe4f84b4b58e8be","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-07-06T12:32:43Z","pushed_at":"2016-07-06T14:27:44Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":52858,"stargazers_count":1212,"watchers_count":1212,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":118,"forks":80,"open_issues":118,"watchers":1212,"default_branch":"master"}},"base":{"label":"convox:start-refactor","ref":"start-refactor","sha":"1db0aab7052d380bb6064df67b73e18b6b12f453","user":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"avatar_url":"https://avatars.githubusercontent.com/u/10547780?v=3","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS on AWS","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2016-07-06T12:32:43Z","pushed_at":"2016-07-06T14:27:44Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":52858,"stargazers_count":1212,"watchers_count":1212,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":118,"forks":80,"open_issues":118,"watchers":1212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/845"},"html":{"href":"https://github.com/convox/rack/pull/845"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/845"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/845/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/845/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/845/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/1636ec603cd1ba1b8af3721efbe4f84b4b58e8be"}}}}
{"actor":{"display_login":"houndci-bot"}}