{"action":"created","issue":{"url":"https://api.github.com/repos/strongback/strongback-java/issues/86","repository_url":"https://api.github.com/repos/strongback/strongback-java","labels_url":"https://api.github.com/repos/strongback/strongback-java/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/strongback/strongback-java/issues/86/comments","events_url":"https://api.github.com/repos/strongback/strongback-java/issues/86/events","html_url":"https://github.com/strongback/strongback-java/issues/86","id":198036337,"number":86,"title":"Mock solenoids ","user":{"login":"FilipKernan","id":14916958,"avatar_url":"https://avatars.githubusercontent.com/u/14916958?v=3","gravatar_id":"","url":"https://api.github.com/users/FilipKernan","html_url":"https://github.com/FilipKernan","followers_url":"https://api.github.com/users/FilipKernan/followers","following_url":"https://api.github.com/users/FilipKernan/following{/other_user}","gists_url":"https://api.github.com/users/FilipKernan/gists{/gist_id}","starred_url":"https://api.github.com/users/FilipKernan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FilipKernan/subscriptions","organizations_url":"https://api.github.com/users/FilipKernan/orgs","repos_url":"https://api.github.com/users/FilipKernan/repos","events_url":"https://api.github.com/users/FilipKernan/events{/privacy}","received_events_url":"https://api.github.com/users/FilipKernan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-29T16:51:28Z","updated_at":"2016-12-29T19:35:31Z","closed_at":null,"body":"The instantaneousSolenoid() method and the manualSolenoid() return essentially the same object.  From what I have gathered from the code is that the manualSolenoid() should be set to false.\r\n`/**\r\n     * Create a solenoid that operates instantaneously and immediately stops.\r\n     *\r\n     * @return the mock solenoid; never null\r\n     */\r\n    public static MockSolenoid instantaneousSolenoid() {\r\n        return new MockSolenoid(true);\r\n    }\r\n\r\n    /**\r\n     * Create a solenoid that operates infinitely slowly and must be manually {@link MockSolenoid#stop() stopped}.\r\n     *\r\n     * @return the mock solenoid; never null\r\n     */\r\n    public static MockSolenoid manualSolenoid() {\r\n        return new MockSolenoid(true);\r\n    }`"},"comment":{"url":"https://api.github.com/repos/strongback/strongback-java/issues/comments/269681410","html_url":"https://github.com/strongback/strongback-java/issues/86#issuecomment-269681410","issue_url":"https://api.github.com/repos/strongback/strongback-java/issues/86","id":269681410,"user":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T19:35:31Z","updated_at":"2016-12-29T19:35:31Z","body":"@FilipKernan, yeah, I think you're right. The `manualSolenoid` method should call `new MockSolenoid(false);`. Do you want to submit a pull request? (If so, please feel free to add your name to the `CONTRIBUTORS` file in the root of the repository in a second commit within the same pull request.)"}}
{"actor":{"display_login":"rhauch"}}