{"action":"created","issue":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/425","repository_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore","labels_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/425/labels{/name}","comments_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/425/comments","events_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/425/events","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/425","id":197233272,"number":425,"title":"Redux Implementation ","user":{"login":"ihoegen","id":11003242,"avatar_url":"https://avatars.githubusercontent.com/u/11003242?v=3","gravatar_id":"","url":"https://api.github.com/users/ihoegen","html_url":"https://github.com/ihoegen","followers_url":"https://api.github.com/users/ihoegen/followers","following_url":"https://api.github.com/users/ihoegen/following{/other_user}","gists_url":"https://api.github.com/users/ihoegen/gists{/gist_id}","starred_url":"https://api.github.com/users/ihoegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihoegen/subscriptions","organizations_url":"https://api.github.com/users/ihoegen/orgs","repos_url":"https://api.github.com/users/ihoegen/repos","events_url":"https://api.github.com/users/ihoegen/events{/privacy}","received_events_url":"https://api.github.com/users/ihoegen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-12-22T18:08:25Z","updated_at":"2016-12-23T17:33:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/pulls/425","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/425","diff_url":"https://github.com/unfoldingWord-dev/translationCore/pull/425.diff","patch_url":"https://github.com/unfoldingWord-dev/translationCore/pull/425.patch"},"body":"This pull request brings in a redux approach to the API, and changes the Settings modal to a dummy component.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/unfoldingword-dev/translationcore/425)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/comments/269022215","html_url":"https://github.com/unfoldingWord-dev/translationCore/pull/425#issuecomment-269022215","issue_url":"https://api.github.com/repos/unfoldingWord-dev/translationCore/issues/425","id":269022215,"user":{"login":"RoyalSix","id":16184018,"avatar_url":"https://avatars.githubusercontent.com/u/16184018?v=3","gravatar_id":"","url":"https://api.github.com/users/RoyalSix","html_url":"https://github.com/RoyalSix","followers_url":"https://api.github.com/users/RoyalSix/followers","following_url":"https://api.github.com/users/RoyalSix/following{/other_user}","gists_url":"https://api.github.com/users/RoyalSix/gists{/gist_id}","starred_url":"https://api.github.com/users/RoyalSix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoyalSix/subscriptions","organizations_url":"https://api.github.com/users/RoyalSix/orgs","repos_url":"https://api.github.com/users/RoyalSix/repos","events_url":"https://api.github.com/users/RoyalSix/events{/privacy}","received_events_url":"https://api.github.com/users/RoyalSix/received_events","type":"User","site_admin":false},"created_at":"2016-12-23T17:33:31Z","updated_at":"2016-12-23T17:33:31Z","body":"I think we should require the npm module redux, this implementation does seem very close to redux, but we shouldn't be trying to abstract redux, it looks like you sort of made a wrapper / api for its actual implementation. This is also not using reducers. \n\n---\n\nReview status: 0 of 8 files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/unfoldingword-dev/translationcore/425#-:-KZghJJyxiH_rYevDN-X:b-n4io9o)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"RoyalSix"}}