{"action":"created","comment":{"url":"https://api.github.com/repos/signalfx/signalfx-java/pulls/comments/56221136","id":56221136,"diff_hunk":"@@ -0,0 +1,84 @@\n+# SignalFx jvm agent\n+\n+## How to build\n+mvn clean install\n+\n+## How to attach to the java application\n+1. build the project\n+2. The agent resides in signalfx-jvm-agent.jar in the target directory\n+3. When launching the java application include the following parameters:\n+java -javaagent:/some/path/signalfx-jvm-agent.jar=path_to_jmx_trans_config \\\n+-Dcom.signalfx.hostUrl=http://sfproxy-integrations1--aaaa.int.signalfuse.com:28080 \\","path":"signalfx-jvm-agent/README.md","position":11,"original_position":11,"commit_id":"9e4fdddde39e6a7457d711dc937765ad81dc289d","original_commit_id":"9e4fdddde39e6a7457d711dc937765ad81dc289d","user":{"login":"cep21","id":20358,"avatar_url":"https://avatars.githubusercontent.com/u/20358?v=3","gravatar_id":"","url":"https://api.github.com/users/cep21","html_url":"https://github.com/cep21","followers_url":"https://api.github.com/users/cep21/followers","following_url":"https://api.github.com/users/cep21/following{/other_user}","gists_url":"https://api.github.com/users/cep21/gists{/gist_id}","starred_url":"https://api.github.com/users/cep21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cep21/subscriptions","organizations_url":"https://api.github.com/users/cep21/orgs","repos_url":"https://api.github.com/users/cep21/repos","events_url":"https://api.github.com/users/cep21/events{/privacy}","received_events_url":"https://api.github.com/users/cep21/received_events","type":"User","site_admin":false},"body":"I wouldn't put this in the example at all, and instead add it as separate documentation later (like you did)","created_at":"2016-03-15T18:58:35Z","updated_at":"2016-03-15T18:58:35Z","html_url":"https://github.com/signalfx/signalfx-java/pull/19#discussion_r56221136","pull_request_url":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-java/pulls/comments/56221136"},"html":{"href":"https://github.com/signalfx/signalfx-java/pull/19#discussion_r56221136"},"pull_request":{"href":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19","id":62847561,"html_url":"https://github.com/signalfx/signalfx-java/pull/19","diff_url":"https://github.com/signalfx/signalfx-java/pull/19.diff","patch_url":"https://github.com/signalfx/signalfx-java/pull/19.patch","issue_url":"https://api.github.com/repos/signalfx/signalfx-java/issues/19","number":19,"state":"open","locked":false,"title":"SignalFx jvm agent prototype","user":{"login":"vzhabiuks","id":17709461,"avatar_url":"https://avatars.githubusercontent.com/u/17709461?v=3","gravatar_id":"","url":"https://api.github.com/users/vzhabiuks","html_url":"https://github.com/vzhabiuks","followers_url":"https://api.github.com/users/vzhabiuks/followers","following_url":"https://api.github.com/users/vzhabiuks/following{/other_user}","gists_url":"https://api.github.com/users/vzhabiuks/gists{/gist_id}","starred_url":"https://api.github.com/users/vzhabiuks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vzhabiuks/subscriptions","organizations_url":"https://api.github.com/users/vzhabiuks/orgs","repos_url":"https://api.github.com/users/vzhabiuks/repos","events_url":"https://api.github.com/users/vzhabiuks/events{/privacy}","received_events_url":"https://api.github.com/users/vzhabiuks/received_events","type":"User","site_admin":false},"body":"Basic implementation. Will add more features, unit tests and documentation\r\n\r\nDo not merge!","created_at":"2016-03-15T02:41:12Z","updated_at":"2016-03-15T18:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c7fa7442ca25f3e1da50ee84dc015c4fae8642e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19/commits","review_comments_url":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19/comments","review_comment_url":"https://api.github.com/repos/signalfx/signalfx-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalfx/signalfx-java/issues/19/comments","statuses_url":"https://api.github.com/repos/signalfx/signalfx-java/statuses/9e4fdddde39e6a7457d711dc937765ad81dc289d","head":{"label":"signalfx:vz_agent","ref":"vz_agent","sha":"9e4fdddde39e6a7457d711dc937765ad81dc289d","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":22741052,"name":"signalfx-java","full_name":"signalfx/signalfx-java","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-java","description":"Java libraries for SignalFx code","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-java","forks_url":"https://api.github.com/repos/signalfx/signalfx-java/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-java/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-java/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-java/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-java/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-java/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-java/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-java/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-java/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-java/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-java/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-java/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-java/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-java/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-java/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-java/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-java/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-java/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-java/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-java/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-java/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-java/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-java/deployments","created_at":"2014-08-08T00:41:18Z","updated_at":"2016-02-19T05:12:54Z","pushed_at":"2016-03-15T02:41:12Z","git_url":"git://github.com/signalfx/signalfx-java.git","ssh_url":"git@github.com:signalfx/signalfx-java.git","clone_url":"https://github.com/signalfx/signalfx-java.git","svn_url":"https://github.com/signalfx/signalfx-java","homepage":"https://signalfx.com/","size":339,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"signalfx:master","ref":"master","sha":"d5d92ac956d08effff300aa6a3af3a380c46c23f","user":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"repo":{"id":22741052,"name":"signalfx-java","full_name":"signalfx/signalfx-java","owner":{"login":"signalfx","id":8184587,"avatar_url":"https://avatars.githubusercontent.com/u/8184587?v=3","gravatar_id":"","url":"https://api.github.com/users/signalfx","html_url":"https://github.com/signalfx","followers_url":"https://api.github.com/users/signalfx/followers","following_url":"https://api.github.com/users/signalfx/following{/other_user}","gists_url":"https://api.github.com/users/signalfx/gists{/gist_id}","starred_url":"https://api.github.com/users/signalfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalfx/subscriptions","organizations_url":"https://api.github.com/users/signalfx/orgs","repos_url":"https://api.github.com/users/signalfx/repos","events_url":"https://api.github.com/users/signalfx/events{/privacy}","received_events_url":"https://api.github.com/users/signalfx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalfx/signalfx-java","description":"Java libraries for SignalFx code","fork":false,"url":"https://api.github.com/repos/signalfx/signalfx-java","forks_url":"https://api.github.com/repos/signalfx/signalfx-java/forks","keys_url":"https://api.github.com/repos/signalfx/signalfx-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalfx/signalfx-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalfx/signalfx-java/teams","hooks_url":"https://api.github.com/repos/signalfx/signalfx-java/hooks","issue_events_url":"https://api.github.com/repos/signalfx/signalfx-java/issues/events{/number}","events_url":"https://api.github.com/repos/signalfx/signalfx-java/events","assignees_url":"https://api.github.com/repos/signalfx/signalfx-java/assignees{/user}","branches_url":"https://api.github.com/repos/signalfx/signalfx-java/branches{/branch}","tags_url":"https://api.github.com/repos/signalfx/signalfx-java/tags","blobs_url":"https://api.github.com/repos/signalfx/signalfx-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalfx/signalfx-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalfx/signalfx-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalfx/signalfx-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalfx/signalfx-java/statuses/{sha}","languages_url":"https://api.github.com/repos/signalfx/signalfx-java/languages","stargazers_url":"https://api.github.com/repos/signalfx/signalfx-java/stargazers","contributors_url":"https://api.github.com/repos/signalfx/signalfx-java/contributors","subscribers_url":"https://api.github.com/repos/signalfx/signalfx-java/subscribers","subscription_url":"https://api.github.com/repos/signalfx/signalfx-java/subscription","commits_url":"https://api.github.com/repos/signalfx/signalfx-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalfx/signalfx-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalfx/signalfx-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalfx/signalfx-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalfx/signalfx-java/contents/{+path}","compare_url":"https://api.github.com/repos/signalfx/signalfx-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalfx/signalfx-java/merges","archive_url":"https://api.github.com/repos/signalfx/signalfx-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalfx/signalfx-java/downloads","issues_url":"https://api.github.com/repos/signalfx/signalfx-java/issues{/number}","pulls_url":"https://api.github.com/repos/signalfx/signalfx-java/pulls{/number}","milestones_url":"https://api.github.com/repos/signalfx/signalfx-java/milestones{/number}","notifications_url":"https://api.github.com/repos/signalfx/signalfx-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalfx/signalfx-java/labels{/name}","releases_url":"https://api.github.com/repos/signalfx/signalfx-java/releases{/id}","deployments_url":"https://api.github.com/repos/signalfx/signalfx-java/deployments","created_at":"2014-08-08T00:41:18Z","updated_at":"2016-02-19T05:12:54Z","pushed_at":"2016-03-15T02:41:12Z","git_url":"git://github.com/signalfx/signalfx-java.git","ssh_url":"git@github.com:signalfx/signalfx-java.git","clone_url":"https://github.com/signalfx/signalfx-java.git","svn_url":"https://github.com/signalfx/signalfx-java","homepage":"https://signalfx.com/","size":339,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19"},"html":{"href":"https://github.com/signalfx/signalfx-java/pull/19"},"issue":{"href":"https://api.github.com/repos/signalfx/signalfx-java/issues/19"},"comments":{"href":"https://api.github.com/repos/signalfx/signalfx-java/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/signalfx/signalfx-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalfx/signalfx-java/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/signalfx/signalfx-java/statuses/9e4fdddde39e6a7457d711dc937765ad81dc289d"}}}}