{"action":"created","comment":{"url":"https://api.github.com/repos/pythonnet/pythonnet/pulls/comments/52359677","id":52359677,"diff_hunk":"@@ -92,51 +95,54 @@ internal class MethodBinder {\n          }\n \n \n-\t\t //====================================================================\n-\t\t // Given a sequence of MethodInfo and two sequences of type parameters, \n-\t\t // return the MethodInfo that matches the signature and the closed generic.\n-\t\t //====================================================================\n-\n-\t\t internal static MethodInfo MatchSignatureAndParameters(MethodInfo[] mi, Type[] genericTp, Type[] sigTp)\n-\t\t {\n-\t\t\t int genericCount = genericTp.Length;\n-\t\t\t int signatureCount = sigTp.Length;\n-\t\t\t for (int i = 0; i < mi.Length; i++)\n-\t\t\t {\n-\t\t\t\t if (!mi[i].IsGenericMethodDefinition)\n-\t\t\t\t {\n-\t\t\t\t\t continue;\n-\t\t\t\t }\n-\t\t\t\t Type[] genericArgs = mi[i].GetGenericArguments();\n-\t\t\t\t if (genericArgs.Length != genericCount)\n-\t\t\t\t {\n-\t\t\t\t\t continue;\n-\t\t\t\t }\n-\t\t\t\t ParameterInfo[] pi = mi[i].GetParameters();\n-\t\t\t\t if (pi.Length != signatureCount)\n-\t\t\t\t {\n-\t\t\t\t\t continue;\n-\t\t\t\t }\n-\t\t\t\t for (int n = 0; n < pi.Length; n++)\n-\t\t\t\t {\n-\t\t\t\t\t if (sigTp[n] != pi[n].ParameterType)\n-\t\t\t\t\t {\n-\t\t\t\t\t\t break;\n-\t\t\t\t\t }\n-\t\t\t\t\t if (n == (pi.Length - 1))\n-\t\t\t\t\t {\n-\t\t\t\t\t\t MethodInfo match = mi[i];\n-\t\t\t\t\t\t if (match.IsGenericMethodDefinition)\n-\t\t\t\t\t\t {\n-\t\t\t\t\t\t\t Type[] typeArgs = match.GetGenericArguments();\n-\t\t\t\t\t\t\t return match.MakeGenericMethod(genericTp);\n-\t\t\t\t\t\t }\n-\t\t\t\t\t\t return match;\n-\t\t\t\t\t }\n-\t\t\t\t }\n-\t\t\t }\n-\t\t\t return null;\n-\t\t }\n+         //====================================================================","path":"src/runtime/methodbinder.cs","position":61,"original_position":61,"commit_id":"1c80917c505e4eb7f24429c89f53b78bb3bed783","original_commit_id":"1c80917c505e4eb7f24429c89f53b78bb3bed783","user":{"login":"denfromufa","id":7870949,"avatar_url":"https://avatars.githubusercontent.com/u/7870949?v=3","gravatar_id":"","url":"https://api.github.com/users/denfromufa","html_url":"https://github.com/denfromufa","followers_url":"https://api.github.com/users/denfromufa/followers","following_url":"https://api.github.com/users/denfromufa/following{/other_user}","gists_url":"https://api.github.com/users/denfromufa/gists{/gist_id}","starred_url":"https://api.github.com/users/denfromufa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denfromufa/subscriptions","organizations_url":"https://api.github.com/users/denfromufa/orgs","repos_url":"https://api.github.com/users/denfromufa/repos","events_url":"https://api.github.com/users/denfromufa/events{/privacy}","received_events_url":"https://api.github.com/users/denfromufa/received_events","type":"User","site_admin":false},"body":"I installed VS Power Tools in between these commits, that's why whitespace/tab fixes.","created_at":"2016-02-09T19:24:51Z","updated_at":"2016-02-09T19:24:51Z","html_url":"https://github.com/pythonnet/pythonnet/pull/137#discussion_r52359677","pull_request_url":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/pythonnet/pythonnet/pulls/comments/52359677"},"html":{"href":"https://github.com/pythonnet/pythonnet/pull/137#discussion_r52359677"},"pull_request":{"href":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137","id":58571384,"html_url":"https://github.com/pythonnet/pythonnet/pull/137","diff_url":"https://github.com/pythonnet/pythonnet/pull/137.diff","patch_url":"https://github.com/pythonnet/pythonnet/pull/137.patch","issue_url":"https://api.github.com/repos/pythonnet/pythonnet/issues/137","number":137,"state":"open","locked":false,"title":"Update methodbinder.cs","user":{"login":"denfromufa","id":7870949,"avatar_url":"https://avatars.githubusercontent.com/u/7870949?v=3","gravatar_id":"","url":"https://api.github.com/users/denfromufa","html_url":"https://github.com/denfromufa","followers_url":"https://api.github.com/users/denfromufa/followers","following_url":"https://api.github.com/users/denfromufa/following{/other_user}","gists_url":"https://api.github.com/users/denfromufa/gists{/gist_id}","starred_url":"https://api.github.com/users/denfromufa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denfromufa/subscriptions","organizations_url":"https://api.github.com/users/denfromufa/orgs","repos_url":"https://api.github.com/users/denfromufa/repos","events_url":"https://api.github.com/users/denfromufa/events{/privacy}","received_events_url":"https://api.github.com/users/denfromufa/received_events","type":"User","site_admin":false},"body":"this fixes issue https://github.com/pythonnet/pythonnet/issues/131\r\n\r\nI tested on System.Math.Abs(50.5) & System.Math.Max(50.5,50.1)","created_at":"2016-02-08T05:09:38Z","updated_at":"2016-02-09T19:24:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d32fc98c89fc42a542c043f9453fa59daeabc50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137/commits","review_comments_url":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137/comments","review_comment_url":"https://api.github.com/repos/pythonnet/pythonnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pythonnet/pythonnet/issues/137/comments","statuses_url":"https://api.github.com/repos/pythonnet/pythonnet/statuses/1c80917c505e4eb7f24429c89f53b78bb3bed783","head":{"label":"denfromufa:patch-2","ref":"patch-2","sha":"1c80917c505e4eb7f24429c89f53b78bb3bed783","user":{"login":"denfromufa","id":7870949,"avatar_url":"https://avatars.githubusercontent.com/u/7870949?v=3","gravatar_id":"","url":"https://api.github.com/users/denfromufa","html_url":"https://github.com/denfromufa","followers_url":"https://api.github.com/users/denfromufa/followers","following_url":"https://api.github.com/users/denfromufa/following{/other_user}","gists_url":"https://api.github.com/users/denfromufa/gists{/gist_id}","starred_url":"https://api.github.com/users/denfromufa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denfromufa/subscriptions","organizations_url":"https://api.github.com/users/denfromufa/orgs","repos_url":"https://api.github.com/users/denfromufa/repos","events_url":"https://api.github.com/users/denfromufa/events{/privacy}","received_events_url":"https://api.github.com/users/denfromufa/received_events","type":"User","site_admin":false},"repo":{"id":50558094,"name":"pythonnet","full_name":"denfromufa/pythonnet","owner":{"login":"denfromufa","id":7870949,"avatar_url":"https://avatars.githubusercontent.com/u/7870949?v=3","gravatar_id":"","url":"https://api.github.com/users/denfromufa","html_url":"https://github.com/denfromufa","followers_url":"https://api.github.com/users/denfromufa/followers","following_url":"https://api.github.com/users/denfromufa/following{/other_user}","gists_url":"https://api.github.com/users/denfromufa/gists{/gist_id}","starred_url":"https://api.github.com/users/denfromufa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denfromufa/subscriptions","organizations_url":"https://api.github.com/users/denfromufa/orgs","repos_url":"https://api.github.com/users/denfromufa/repos","events_url":"https://api.github.com/users/denfromufa/events{/privacy}","received_events_url":"https://api.github.com/users/denfromufa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denfromufa/pythonnet","description":"Python for .NET is a package that gives Python programmers nearly seamless integration with the .NET Common Language Runtime (CLR) and provides a powerful application scripting tool for .NET developers.","fork":true,"url":"https://api.github.com/repos/denfromufa/pythonnet","forks_url":"https://api.github.com/repos/denfromufa/pythonnet/forks","keys_url":"https://api.github.com/repos/denfromufa/pythonnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denfromufa/pythonnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denfromufa/pythonnet/teams","hooks_url":"https://api.github.com/repos/denfromufa/pythonnet/hooks","issue_events_url":"https://api.github.com/repos/denfromufa/pythonnet/issues/events{/number}","events_url":"https://api.github.com/repos/denfromufa/pythonnet/events","assignees_url":"https://api.github.com/repos/denfromufa/pythonnet/assignees{/user}","branches_url":"https://api.github.com/repos/denfromufa/pythonnet/branches{/branch}","tags_url":"https://api.github.com/repos/denfromufa/pythonnet/tags","blobs_url":"https://api.github.com/repos/denfromufa/pythonnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denfromufa/pythonnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denfromufa/pythonnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/denfromufa/pythonnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denfromufa/pythonnet/statuses/{sha}","languages_url":"https://api.github.com/repos/denfromufa/pythonnet/languages","stargazers_url":"https://api.github.com/repos/denfromufa/pythonnet/stargazers","contributors_url":"https://api.github.com/repos/denfromufa/pythonnet/contributors","subscribers_url":"https://api.github.com/repos/denfromufa/pythonnet/subscribers","subscription_url":"https://api.github.com/repos/denfromufa/pythonnet/subscription","commits_url":"https://api.github.com/repos/denfromufa/pythonnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/denfromufa/pythonnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/denfromufa/pythonnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/denfromufa/pythonnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/denfromufa/pythonnet/contents/{+path}","compare_url":"https://api.github.com/repos/denfromufa/pythonnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denfromufa/pythonnet/merges","archive_url":"https://api.github.com/repos/denfromufa/pythonnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denfromufa/pythonnet/downloads","issues_url":"https://api.github.com/repos/denfromufa/pythonnet/issues{/number}","pulls_url":"https://api.github.com/repos/denfromufa/pythonnet/pulls{/number}","milestones_url":"https://api.github.com/repos/denfromufa/pythonnet/milestones{/number}","notifications_url":"https://api.github.com/repos/denfromufa/pythonnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denfromufa/pythonnet/labels{/name}","releases_url":"https://api.github.com/repos/denfromufa/pythonnet/releases{/id}","deployments_url":"https://api.github.com/repos/denfromufa/pythonnet/deployments","created_at":"2016-01-28T05:26:54Z","updated_at":"2016-01-28T05:26:55Z","pushed_at":"2016-02-09T17:52:26Z","git_url":"git://github.com/denfromufa/pythonnet.git","ssh_url":"git@github.com:denfromufa/pythonnet.git","clone_url":"https://github.com/denfromufa/pythonnet.git","svn_url":"https://github.com/denfromufa/pythonnet","homepage":"http://pythonnet.github.io","size":2482,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pythonnet:develop","ref":"develop","sha":"105245ee87ec348e9f1d9c878afa0315d19d4d1a","user":{"login":"pythonnet","id":6050430,"avatar_url":"https://avatars.githubusercontent.com/u/6050430?v=3","gravatar_id":"","url":"https://api.github.com/users/pythonnet","html_url":"https://github.com/pythonnet","followers_url":"https://api.github.com/users/pythonnet/followers","following_url":"https://api.github.com/users/pythonnet/following{/other_user}","gists_url":"https://api.github.com/users/pythonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/pythonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pythonnet/subscriptions","organizations_url":"https://api.github.com/users/pythonnet/orgs","repos_url":"https://api.github.com/users/pythonnet/repos","events_url":"https://api.github.com/users/pythonnet/events{/privacy}","received_events_url":"https://api.github.com/users/pythonnet/received_events","type":"Organization","site_admin":false},"repo":{"id":14748123,"name":"pythonnet","full_name":"pythonnet/pythonnet","owner":{"login":"pythonnet","id":6050430,"avatar_url":"https://avatars.githubusercontent.com/u/6050430?v=3","gravatar_id":"","url":"https://api.github.com/users/pythonnet","html_url":"https://github.com/pythonnet","followers_url":"https://api.github.com/users/pythonnet/followers","following_url":"https://api.github.com/users/pythonnet/following{/other_user}","gists_url":"https://api.github.com/users/pythonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/pythonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pythonnet/subscriptions","organizations_url":"https://api.github.com/users/pythonnet/orgs","repos_url":"https://api.github.com/users/pythonnet/repos","events_url":"https://api.github.com/users/pythonnet/events{/privacy}","received_events_url":"https://api.github.com/users/pythonnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pythonnet/pythonnet","description":"Python for .NET is a package that gives Python programmers nearly seamless integration with the .NET Common Language Runtime (CLR) and provides a powerful application scripting tool for .NET developers.","fork":false,"url":"https://api.github.com/repos/pythonnet/pythonnet","forks_url":"https://api.github.com/repos/pythonnet/pythonnet/forks","keys_url":"https://api.github.com/repos/pythonnet/pythonnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pythonnet/pythonnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pythonnet/pythonnet/teams","hooks_url":"https://api.github.com/repos/pythonnet/pythonnet/hooks","issue_events_url":"https://api.github.com/repos/pythonnet/pythonnet/issues/events{/number}","events_url":"https://api.github.com/repos/pythonnet/pythonnet/events","assignees_url":"https://api.github.com/repos/pythonnet/pythonnet/assignees{/user}","branches_url":"https://api.github.com/repos/pythonnet/pythonnet/branches{/branch}","tags_url":"https://api.github.com/repos/pythonnet/pythonnet/tags","blobs_url":"https://api.github.com/repos/pythonnet/pythonnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pythonnet/pythonnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pythonnet/pythonnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/pythonnet/pythonnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pythonnet/pythonnet/statuses/{sha}","languages_url":"https://api.github.com/repos/pythonnet/pythonnet/languages","stargazers_url":"https://api.github.com/repos/pythonnet/pythonnet/stargazers","contributors_url":"https://api.github.com/repos/pythonnet/pythonnet/contributors","subscribers_url":"https://api.github.com/repos/pythonnet/pythonnet/subscribers","subscription_url":"https://api.github.com/repos/pythonnet/pythonnet/subscription","commits_url":"https://api.github.com/repos/pythonnet/pythonnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/pythonnet/pythonnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/pythonnet/pythonnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/pythonnet/pythonnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/pythonnet/pythonnet/contents/{+path}","compare_url":"https://api.github.com/repos/pythonnet/pythonnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pythonnet/pythonnet/merges","archive_url":"https://api.github.com/repos/pythonnet/pythonnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pythonnet/pythonnet/downloads","issues_url":"https://api.github.com/repos/pythonnet/pythonnet/issues{/number}","pulls_url":"https://api.github.com/repos/pythonnet/pythonnet/pulls{/number}","milestones_url":"https://api.github.com/repos/pythonnet/pythonnet/milestones{/number}","notifications_url":"https://api.github.com/repos/pythonnet/pythonnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pythonnet/pythonnet/labels{/name}","releases_url":"https://api.github.com/repos/pythonnet/pythonnet/releases{/id}","deployments_url":"https://api.github.com/repos/pythonnet/pythonnet/deployments","created_at":"2013-11-27T13:42:20Z","updated_at":"2016-02-01T03:02:57Z","pushed_at":"2016-02-09T17:52:26Z","git_url":"git://github.com/pythonnet/pythonnet.git","ssh_url":"git@github.com:pythonnet/pythonnet.git","clone_url":"https://github.com/pythonnet/pythonnet.git","svn_url":"https://github.com/pythonnet/pythonnet","homepage":"http://pythonnet.github.io","size":2709,"stargazers_count":116,"watchers_count":116,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":44,"forks":50,"open_issues":44,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137"},"html":{"href":"https://github.com/pythonnet/pythonnet/pull/137"},"issue":{"href":"https://api.github.com/repos/pythonnet/pythonnet/issues/137"},"comments":{"href":"https://api.github.com/repos/pythonnet/pythonnet/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/pythonnet/pythonnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pythonnet/pythonnet/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/pythonnet/pythonnet/statuses/1c80917c505e4eb7f24429c89f53b78bb3bed783"}}}}