{"action":"created","issue":{"url":"https://api.github.com/repos/matiassingers/ipa-metadata/issues/12","repository_url":"https://api.github.com/repos/matiassingers/ipa-metadata","labels_url":"https://api.github.com/repos/matiassingers/ipa-metadata/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/matiassingers/ipa-metadata/issues/12/comments","events_url":"https://api.github.com/repos/matiassingers/ipa-metadata/issues/12/events","html_url":"https://github.com/matiassingers/ipa-metadata/pull/12","id":123756635,"number":12,"title":"[bugfix] escape whitespace for filepath. Use nodejs path to make path","user":{"login":"drunkhacker","id":461823,"avatar_url":"https://avatars.githubusercontent.com/u/461823?v=3","gravatar_id":"","url":"https://api.github.com/users/drunkhacker","html_url":"https://github.com/drunkhacker","followers_url":"https://api.github.com/users/drunkhacker/followers","following_url":"https://api.github.com/users/drunkhacker/following{/other_user}","gists_url":"https://api.github.com/users/drunkhacker/gists{/gist_id}","starred_url":"https://api.github.com/users/drunkhacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drunkhacker/subscriptions","organizations_url":"https://api.github.com/users/drunkhacker/orgs","repos_url":"https://api.github.com/users/drunkhacker/repos","events_url":"https://api.github.com/users/drunkhacker/events{/privacy}","received_events_url":"https://api.github.com/users/drunkhacker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-24T04:23:16Z","updated_at":"2016-03-09T13:02:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matiassingers/ipa-metadata/pulls/12","html_url":"https://github.com/matiassingers/ipa-metadata/pull/12","diff_url":"https://github.com/matiassingers/ipa-metadata/pull/12.diff","patch_url":"https://github.com/matiassingers/ipa-metadata/pull/12.patch"},"body":"There's a problem for parsing ipa file of which scheme has whitespace in it.\r\nWhen the scheme name has whitespace, generated `.ipa` file has white-spaced `.app` file in it.\r\nBecause of this, several failure can occur on this library. So I escaped path before use, but when I try to escape spaces right before `plist.readFileSync`, it throws me an error. (I think it is because it escapes filename internally). \r\n\r\nOther than reading plist, `path` are used for concatenating command forked by `exec`, so I think it will be fine in most cases. Consider this PR, and please fix this bug. Thanks.\r\n"},"comment":{"url":"https://api.github.com/repos/matiassingers/ipa-metadata/issues/comments/194286984","html_url":"https://github.com/matiassingers/ipa-metadata/pull/12#issuecomment-194286984","issue_url":"https://api.github.com/repos/matiassingers/ipa-metadata/issues/12","id":194286984,"user":{"login":"dreyhomedev","id":1984510,"avatar_url":"https://avatars.githubusercontent.com/u/1984510?v=3","gravatar_id":"","url":"https://api.github.com/users/dreyhomedev","html_url":"https://github.com/dreyhomedev","followers_url":"https://api.github.com/users/dreyhomedev/followers","following_url":"https://api.github.com/users/dreyhomedev/following{/other_user}","gists_url":"https://api.github.com/users/dreyhomedev/gists{/gist_id}","starred_url":"https://api.github.com/users/dreyhomedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreyhomedev/subscriptions","organizations_url":"https://api.github.com/users/dreyhomedev/orgs","repos_url":"https://api.github.com/users/dreyhomedev/repos","events_url":"https://api.github.com/users/dreyhomedev/events{/privacy}","received_events_url":"https://api.github.com/users/dreyhomedev/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T13:02:49Z","updated_at":"2016-03-09T13:02:49Z","body":"Same Issue here.\r\nHope for Merge of this fix soon."}}