{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31","repository_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics","labels_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31/comments","events_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31/events","html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31","id":177518583,"number":31,"title":"(TK-404) Add jolokia Servlet as metrics/v2","user":{"login":"Sharpie","id":54181,"avatar_url":"https://avatars.githubusercontent.com/u/54181?v=3","gravatar_id":"","url":"https://api.github.com/users/Sharpie","html_url":"https://github.com/Sharpie","followers_url":"https://api.github.com/users/Sharpie/followers","following_url":"https://api.github.com/users/Sharpie/following{/other_user}","gists_url":"https://api.github.com/users/Sharpie/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharpie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharpie/subscriptions","organizations_url":"https://api.github.com/users/Sharpie/orgs","repos_url":"https://api.github.com/users/Sharpie/repos","events_url":"https://api.github.com/users/Sharpie/events{/privacy}","received_events_url":"https://api.github.com/users/Sharpie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2016-09-16T20:54:45Z","updated_at":"2016-12-12T20:33:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/pulls/31","html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31","diff_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31.diff","patch_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31.patch"},"body":"This patch adds the jolokia-core library to the dependency list and\nmounts its servlet at 'metrics/v2' when the `metrics-webservice` is in\nuse. Jolokia is a small library that wraps a REST API around JMX and\nprovides great features such as globbing, attribute extraction and much\nmore.\n\nExample query using globbing and parameter extraction:\n\n```\ncurl -k 'https://localhost:8140/metrics/v2/read/java.lang:name=*,type=GarbageCollector/CollectionCount,CollectionTime'\n```\n\n**CAVEATS**\n- The Jolokia API also exposes JMX control functionality, so \"write\"\n  and \"exec\" operations are currently restricted by a static\n  authorization configuration in `resources/jolokia-access.xml`.\n- The servlet is currently mounted directly using the WebserverService\n  add-servlet-handler method, instead of going through the comidi\n  routes defined in:\n  \n  ```\n  puppetlabs.trapperkeeper.services.metrics.metrics-core\n  ```\n"},"comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/comments/266544479","html_url":"https://github.com/puppetlabs/trapperkeeper-metrics/pull/31#issuecomment-266544479","issue_url":"https://api.github.com/repos/puppetlabs/trapperkeeper-metrics/issues/31","id":266544479,"user":{"login":"camlow325","id":5652737,"avatar_url":"https://avatars.githubusercontent.com/u/5652737?v=3","gravatar_id":"","url":"https://api.github.com/users/camlow325","html_url":"https://github.com/camlow325","followers_url":"https://api.github.com/users/camlow325/followers","following_url":"https://api.github.com/users/camlow325/following{/other_user}","gists_url":"https://api.github.com/users/camlow325/gists{/gist_id}","starred_url":"https://api.github.com/users/camlow325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camlow325/subscriptions","organizations_url":"https://api.github.com/users/camlow325/orgs","repos_url":"https://api.github.com/users/camlow325/repos","events_url":"https://api.github.com/users/camlow325/events{/privacy}","received_events_url":"https://api.github.com/users/camlow325/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T20:33:10Z","updated_at":"2016-12-12T20:33:10Z","body":"I'm still +1 on this after reviewing the latest changes.  I tested manually with a multi-server webserver config where the \"/metrics\" endpoint was mounted on a non-default webserver (like it presumably would be when integrated with pe-console-services at some point).  Both the \"/v1\" and \"/v2\" endpoints appeared to have been mounted properly to the non-default webserver.  Requests to each returned successful responses for me.\r\n\r\n@cprice404, @rlinehan - what do you think about this one, then?"}}
{"actor":{"display_login":"camlow325"}}