{"action":"closed","number":405,"pull_request":{"url":"https://api.github.com/repos/guardian/riff-raff/pulls/405","id":96571479,"html_url":"https://github.com/guardian/riff-raff/pull/405","diff_url":"https://github.com/guardian/riff-raff/pull/405.diff","patch_url":"https://github.com/guardian/riff-raff/pull/405.patch","issue_url":"https://api.github.com/repos/guardian/riff-raff/issues/405","number":405,"state":"closed","locked":false,"title":"Ensure that actorNames are really unique","user":{"login":"sihil","id":1236466,"avatar_url":"https://avatars.githubusercontent.com/u/1236466?v=3","gravatar_id":"","url":"https://api.github.com/users/sihil","html_url":"https://github.com/sihil","followers_url":"https://api.github.com/users/sihil/followers","following_url":"https://api.github.com/users/sihil/following{/other_user}","gists_url":"https://api.github.com/users/sihil/gists{/gist_id}","starred_url":"https://api.github.com/users/sihil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihil/subscriptions","organizations_url":"https://api.github.com/users/sihil/orgs","repos_url":"https://api.github.com/users/sihil/repos","events_url":"https://api.github.com/users/sihil/events{/privacy}","received_events_url":"https://api.github.com/users/sihil/received_events","type":"User","site_admin":false},"body":"This previously relied on there being an always increasing number of child actors. This is not reliable, especially when there are errors. Instead, we use a counter that is internal to the actor (task name is not guaranteed to have only the subset of actor-name-safe characters).","created_at":"2016-12-05T17:18:46Z","updated_at":"2016-12-06T10:25:47Z","closed_at":"2016-12-06T10:25:47Z","merged_at":"2016-12-06T10:25:47Z","merge_commit_sha":"ba2010d75375ef48cb0f488cd3c5fb569eda598d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/riff-raff/pulls/405/commits","review_comments_url":"https://api.github.com/repos/guardian/riff-raff/pulls/405/comments","review_comment_url":"https://api.github.com/repos/guardian/riff-raff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/riff-raff/issues/405/comments","statuses_url":"https://api.github.com/repos/guardian/riff-raff/statuses/cea3639f47200d2b500cae40d92bee219a37f1a1","head":{"label":"guardian:sh-unique-actor-names","ref":"sh-unique-actor-names","sha":"cea3639f47200d2b500cae40d92bee219a37f1a1","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":2233038,"name":"riff-raff","full_name":"guardian/riff-raff","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/riff-raff","description":"The Guardian's deployment platform","fork":false,"url":"https://api.github.com/repos/guardian/riff-raff","forks_url":"https://api.github.com/repos/guardian/riff-raff/forks","keys_url":"https://api.github.com/repos/guardian/riff-raff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/riff-raff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/riff-raff/teams","hooks_url":"https://api.github.com/repos/guardian/riff-raff/hooks","issue_events_url":"https://api.github.com/repos/guardian/riff-raff/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/riff-raff/events","assignees_url":"https://api.github.com/repos/guardian/riff-raff/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/riff-raff/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/riff-raff/tags","blobs_url":"https://api.github.com/repos/guardian/riff-raff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/riff-raff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/riff-raff/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/riff-raff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/riff-raff/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/riff-raff/languages","stargazers_url":"https://api.github.com/repos/guardian/riff-raff/stargazers","contributors_url":"https://api.github.com/repos/guardian/riff-raff/contributors","subscribers_url":"https://api.github.com/repos/guardian/riff-raff/subscribers","subscription_url":"https://api.github.com/repos/guardian/riff-raff/subscription","commits_url":"https://api.github.com/repos/guardian/riff-raff/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/riff-raff/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/riff-raff/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/riff-raff/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/riff-raff/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/riff-raff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/riff-raff/merges","archive_url":"https://api.github.com/repos/guardian/riff-raff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/riff-raff/downloads","issues_url":"https://api.github.com/repos/guardian/riff-raff/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/riff-raff/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/riff-raff/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/riff-raff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/riff-raff/labels{/name}","releases_url":"https://api.github.com/repos/guardian/riff-raff/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/riff-raff/deployments","created_at":"2011-08-19T09:05:26Z","updated_at":"2016-12-01T20:19:26Z","pushed_at":"2016-12-06T10:25:48Z","git_url":"git://github.com/guardian/riff-raff.git","ssh_url":"git@github.com:guardian/riff-raff.git","clone_url":"https://github.com/guardian/riff-raff.git","svn_url":"https://github.com/guardian/riff-raff","homepage":"","size":9309,"stargazers_count":149,"watchers_count":149,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":8,"forks":12,"open_issues":8,"watchers":149,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"9892a44e689ddba3f7d4a9801d77ca639c9ed0bb","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":2233038,"name":"riff-raff","full_name":"guardian/riff-raff","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/riff-raff","description":"The Guardian's deployment platform","fork":false,"url":"https://api.github.com/repos/guardian/riff-raff","forks_url":"https://api.github.com/repos/guardian/riff-raff/forks","keys_url":"https://api.github.com/repos/guardian/riff-raff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/riff-raff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/riff-raff/teams","hooks_url":"https://api.github.com/repos/guardian/riff-raff/hooks","issue_events_url":"https://api.github.com/repos/guardian/riff-raff/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/riff-raff/events","assignees_url":"https://api.github.com/repos/guardian/riff-raff/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/riff-raff/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/riff-raff/tags","blobs_url":"https://api.github.com/repos/guardian/riff-raff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/riff-raff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/riff-raff/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/riff-raff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/riff-raff/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/riff-raff/languages","stargazers_url":"https://api.github.com/repos/guardian/riff-raff/stargazers","contributors_url":"https://api.github.com/repos/guardian/riff-raff/contributors","subscribers_url":"https://api.github.com/repos/guardian/riff-raff/subscribers","subscription_url":"https://api.github.com/repos/guardian/riff-raff/subscription","commits_url":"https://api.github.com/repos/guardian/riff-raff/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/riff-raff/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/riff-raff/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/riff-raff/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/riff-raff/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/riff-raff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/riff-raff/merges","archive_url":"https://api.github.com/repos/guardian/riff-raff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/riff-raff/downloads","issues_url":"https://api.github.com/repos/guardian/riff-raff/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/riff-raff/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/riff-raff/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/riff-raff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/riff-raff/labels{/name}","releases_url":"https://api.github.com/repos/guardian/riff-raff/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/riff-raff/deployments","created_at":"2011-08-19T09:05:26Z","updated_at":"2016-12-01T20:19:26Z","pushed_at":"2016-12-06T10:25:48Z","git_url":"git://github.com/guardian/riff-raff.git","ssh_url":"git@github.com:guardian/riff-raff.git","clone_url":"https://github.com/guardian/riff-raff.git","svn_url":"https://github.com/guardian/riff-raff","homepage":"","size":9309,"stargazers_count":149,"watchers_count":149,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":8,"forks":12,"open_issues":8,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/405"},"html":{"href":"https://github.com/guardian/riff-raff/pull/405"},"issue":{"href":"https://api.github.com/repos/guardian/riff-raff/issues/405"},"comments":{"href":"https://api.github.com/repos/guardian/riff-raff/issues/405/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/405/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/riff-raff/pulls/405/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/riff-raff/statuses/cea3639f47200d2b500cae40d92bee219a37f1a1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sihil","id":1236466,"avatar_url":"https://avatars.githubusercontent.com/u/1236466?v=3","gravatar_id":"","url":"https://api.github.com/users/sihil","html_url":"https://github.com/sihil","followers_url":"https://api.github.com/users/sihil/followers","following_url":"https://api.github.com/users/sihil/following{/other_user}","gists_url":"https://api.github.com/users/sihil/gists{/gist_id}","starred_url":"https://api.github.com/users/sihil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihil/subscriptions","organizations_url":"https://api.github.com/users/sihil/orgs","repos_url":"https://api.github.com/users/sihil/repos","events_url":"https://api.github.com/users/sihil/events{/privacy}","received_events_url":"https://api.github.com/users/sihil/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"sihil"}}