{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/72674328","id":72674328,"diff_hunk":"@@ -54,27 +64,88 @@ func GetImageRegistryAuth(auths *client.AuthConfigurations, imageName string) cl\n \t\tglog.V(5).Infof(\"Using %s credentials for pulling %s\", auth.Email, imageName)\n \t\treturn auth\n \t}\n-\treturn client.AuthConfiguration{}\n+\treturn api.AuthConfig{}\n }\n \n // LoadImageRegistryAuth loads and returns the set of client auth objects from a docker config\n // json file.\n-func LoadImageRegistryAuth(dockerCfg io.Reader) *client.AuthConfigurations {\n-\tauths, err := client.NewAuthConfigurations(dockerCfg)\n+func LoadImageRegistryAuth(dockerCfg io.Reader) *AuthConfigurations {\n+\tauths, err := NewAuthConfigurations(dockerCfg)\n \tif err != nil {\n \t\tglog.V(0).Infof(\"error: Unable to load docker config\")\n \t\treturn nil\n \t}\n \treturn auths\n }\n \n+// begin borrowed from fsouza","path":"pkg/docker/util.go","position":71,"original_position":71,"commit_id":"41d1fc0a3fccc90faeb93db9e60c4f701e1dbd4b","original_commit_id":"41d1fc0a3fccc90faeb93db9e60c4f701e1dbd4b","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"definitely depending on go-dockerclient isn't what we want, i guess i'm still struggling to understand how k8s handles reading a docker config.json and finding auths, and why we can't leverage it in some way.\r\n","created_at":"2016-07-28T18:19:59Z","updated_at":"2016-07-28T18:19:59Z","html_url":"https://github.com/openshift/source-to-image/pull/554#discussion_r72674328","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/554","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/72674328"},"html":{"href":"https://github.com/openshift/source-to-image/pull/554#discussion_r72674328"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/554","id":78717192,"html_url":"https://github.com/openshift/source-to-image/pull/554","diff_url":"https://github.com/openshift/source-to-image/pull/554.diff","patch_url":"https://github.com/openshift/source-to-image/pull/554.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/554","number":554,"state":"open","locked":false,"title":"Move to kube and engine2","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"OK, let it begin  ..... \r\n\r\n@bparees @csrwng @jupierce @oatmealraisin @php-coder @PI-Victor @soltysh ","created_at":"2016-07-25T17:07:43Z","updated_at":"2016-07-28T18:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4aa589a5a96f61dfb38bbb1e884635037800cdf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/554/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/554/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/554/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/41d1fc0a3fccc90faeb93db9e60c4f701e1dbd4b","head":{"label":"gabemontero:moveToKubeAndEngine2","ref":"moveToKubeAndEngine2","sha":"41d1fc0a3fccc90faeb93db9e60c4f701e1dbd4b","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36944033,"name":"source-to-image","full_name":"gabemontero/source-to-image","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/gabemontero/source-to-image","forks_url":"https://api.github.com/repos/gabemontero/source-to-image/forks","keys_url":"https://api.github.com/repos/gabemontero/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/source-to-image/teams","hooks_url":"https://api.github.com/repos/gabemontero/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/source-to-image/events","assignees_url":"https://api.github.com/repos/gabemontero/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/source-to-image/tags","blobs_url":"https://api.github.com/repos/gabemontero/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/source-to-image/languages","stargazers_url":"https://api.github.com/repos/gabemontero/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/source-to-image/subscription","commits_url":"https://api.github.com/repos/gabemontero/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/source-to-image/merges","archive_url":"https://api.github.com/repos/gabemontero/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/source-to-image/downloads","issues_url":"https://api.github.com/repos/gabemontero/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/source-to-image/deployments","created_at":"2015-06-05T16:49:12Z","updated_at":"2016-01-17T16:58:35Z","pushed_at":"2016-07-27T15:45:44Z","git_url":"git://github.com/gabemontero/source-to-image.git","ssh_url":"git@github.com:gabemontero/source-to-image.git","clone_url":"https://github.com/gabemontero/source-to-image.git","svn_url":"https://github.com/gabemontero/source-to-image","homepage":"","size":11593,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3632461ab64707aad489203b99889650cdf02647","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/source-to-image/deployments","created_at":"2014-01-28T19:32:40Z","updated_at":"2016-07-25T01:40:52Z","pushed_at":"2016-07-28T16:34:08Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":11709,"stargazers_count":269,"watchers_count":269,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":23,"forks":129,"open_issues":23,"watchers":269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/554"},"html":{"href":"https://github.com/openshift/source-to-image/pull/554"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/554"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/41d1fc0a3fccc90faeb93db9e60c4f701e1dbd4b"}}}}
{"actor":{"display_login":"bparees"}}