{"action":"created","issue":{"url":"https://api.github.com/repos/dokan-dev/dokany/issues/130","labels_url":"https://api.github.com/repos/dokan-dev/dokany/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/dokan-dev/dokany/issues/130/comments","events_url":"https://api.github.com/repos/dokan-dev/dokany/issues/130/events","html_url":"https://github.com/dokan-dev/dokany/pull/130","id":124693306,"number":130,"title":"Fix the Dokan FUSE library","user":{"login":"toksaitov","id":97272,"avatar_url":"https://avatars.githubusercontent.com/u/97272?v=3","gravatar_id":"","url":"https://api.github.com/users/toksaitov","html_url":"https://github.com/toksaitov","followers_url":"https://api.github.com/users/toksaitov/followers","following_url":"https://api.github.com/users/toksaitov/following{/other_user}","gists_url":"https://api.github.com/users/toksaitov/gists{/gist_id}","starred_url":"https://api.github.com/users/toksaitov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toksaitov/subscriptions","organizations_url":"https://api.github.com/users/toksaitov/orgs","repos_url":"https://api.github.com/users/toksaitov/repos","events_url":"https://api.github.com/users/toksaitov/events{/privacy}","received_events_url":"https://api.github.com/users/toksaitov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-04T04:05:22Z","updated_at":"2016-01-04T07:33:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dokan-dev/dokany/pulls/130","html_url":"https://github.com/dokan-dev/dokany/pull/130","diff_url":"https://github.com/dokan-dev/dokany/pull/130.diff","patch_url":"https://github.com/dokan-dev/dokany/pull/130.patch"},"body":"Hi,\r\n\r\nI have found a number of problems with the FUSE wrapper while trying to port my FUSE file system from *nix to Windows. Here's my attempt to fix them. Please, check commit messages for more information.\r\n\r\nSample use cases before\r\nhttp://i.imgur.com/kDFPyPW.gifv\r\n…and after\r\nhttp://i.imgur.com/dcUGsAd.gifv\r\n\r\nBest regards,\r\nDmitrii Toksaitov"},"comment":{"url":"https://api.github.com/repos/dokan-dev/dokany/issues/comments/168603037","html_url":"https://github.com/dokan-dev/dokany/pull/130#issuecomment-168603037","issue_url":"https://api.github.com/repos/dokan-dev/dokany/issues/130","id":168603037,"user":{"login":"Liryna","id":4311419,"avatar_url":"https://avatars.githubusercontent.com/u/4311419?v=3","gravatar_id":"","url":"https://api.github.com/users/Liryna","html_url":"https://github.com/Liryna","followers_url":"https://api.github.com/users/Liryna/followers","following_url":"https://api.github.com/users/Liryna/following{/other_user}","gists_url":"https://api.github.com/users/Liryna/gists{/gist_id}","starred_url":"https://api.github.com/users/Liryna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liryna/subscriptions","organizations_url":"https://api.github.com/users/Liryna/orgs","repos_url":"https://api.github.com/users/Liryna/repos","events_url":"https://api.github.com/users/Liryna/events{/privacy}","received_events_url":"https://api.github.com/users/Liryna/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T07:33:54Z","updated_at":"2016-01-04T07:33:54Z","body":"Hello @toksaitov ,\r\n\r\nThank you for your pull request ! \r\n\r\nAlways great to see people using the FUSE API !\r\n\r\nAbout https://github.com/toksaitov/dokany/commit/030fcf791e8e830ce1b98072f6428da7c4fcaa2a, it is great that you have add it ! \r\n```\r\nAccording to Windows development documentation for the\r\n`CreateFile` function, for a similar case with a disposition set to\r\n`FILE_CREATE`, we have to set the last error to `ERROR_FILE_EXISTS`.\r\n```\r\nThis is currently not handle :smiley: but I will add it.\r\n```\r\nAccording to Windows development documentation for the `CreateFile` function, in\r\ncase a call to `CreateFile` with a `CreateDisposition` set to `FILE_OPEN` or\r\n`FILE_OVERWRITE` can’t find a file to open or truncate, we have to set the last\r\nerror to `ERROR_FILE_NOT_FOUND `.\r\n```\r\nWe are always setting `FILE_DOES_NOT_EXIST` in case of createfile error. https://github.com/dokan-dev/dokany/blob/master/dokan/create.c#L219\r\nI will look if this have to be changed.\r\n\r\nFor https://github.com/toksaitov/dokany/commit/3f2f5de91554802c3bf4c27c5c01cc7e76b45e7d, could you show me the ReactOS code ? I have no fuse sample so I will trust you on this.\r\n\r\nhttps://github.com/toksaitov/dokany/commit/566ff428631162d25322a32c82ef88290b09a0fe#diff-a8f32b6fd8169cac1606e8d8b0f497c1R400 Does calling delete during createfile is the correct workflow for FUSE ?\r\n\r\nVery great PR ! Otherwise than dokan_fuse issue, did you had to change a lot of your fuse driver to make it work with dokan ?"}}