{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/73568206","id":73568206,"diff_hunk":"@@ -0,0 +1,80 @@\n+test_name 'FACT-1361 - C59029 networking facts should be fully populated'","path":"acceptance/tests/facts/networking_facts.rb","position":1,"original_position":1,"commit_id":"4ba2bf4f239e2fd54224b28913a82ffb183ae986","original_commit_id":"4ba2bf4f239e2fd54224b28913a82ffb183ae986","user":{"login":"er0ck","id":7454093,"avatar_url":"https://avatars.githubusercontent.com/u/7454093?v=3","gravatar_id":"","url":"https://api.github.com/users/er0ck","html_url":"https://github.com/er0ck","followers_url":"https://api.github.com/users/er0ck/followers","following_url":"https://api.github.com/users/er0ck/following{/other_user}","gists_url":"https://api.github.com/users/er0ck/gists{/gist_id}","starred_url":"https://api.github.com/users/er0ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/er0ck/subscriptions","organizations_url":"https://api.github.com/users/er0ck/orgs","repos_url":"https://api.github.com/users/er0ck/repos","events_url":"https://api.github.com/users/er0ck/events{/privacy}","received_events_url":"https://api.github.com/users/er0ck/received_events","type":"User","site_admin":false},"body":"test_name and step should have `do/end` to create blocks, and proper indentation in logs","created_at":"2016-08-04T17:40:30Z","updated_at":"2016-08-04T17:40:30Z","html_url":"https://github.com/puppetlabs/facter/pull/1390#discussion_r73568206","pull_request_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1390","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments/73568206"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1390#discussion_r73568206"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1390"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/facter/pulls/1390","id":79994037,"html_url":"https://github.com/puppetlabs/facter/pull/1390","diff_url":"https://github.com/puppetlabs/facter/pull/1390.diff","patch_url":"https://github.com/puppetlabs/facter/pull/1390.patch","issue_url":"https://api.github.com/repos/puppetlabs/facter/issues/1390","number":1390,"state":"open","locked":false,"title":"(FACT-1361) Create networking fact acceptance test","user":{"login":"phongdly","id":6462695,"avatar_url":"https://avatars.githubusercontent.com/u/6462695?v=3","gravatar_id":"","url":"https://api.github.com/users/phongdly","html_url":"https://github.com/phongdly","followers_url":"https://api.github.com/users/phongdly/followers","following_url":"https://api.github.com/users/phongdly/following{/other_user}","gists_url":"https://api.github.com/users/phongdly/gists{/gist_id}","starred_url":"https://api.github.com/users/phongdly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongdly/subscriptions","organizations_url":"https://api.github.com/users/phongdly/orgs","repos_url":"https://api.github.com/users/phongdly/repos","events_url":"https://api.github.com/users/phongdly/events{/privacy}","received_events_url":"https://api.github.com/users/phongdly/received_events","type":"User","site_admin":false},"body":"Prior to this PR, networking facts were verified in each individual test cases in acceptance/tests/facts/<platform>.rb\r\n\r\nThis PR pulls out the networking portion of all the tests in acceptance/tests/facts into new acceptance test, acceptance/tests/facts/networking_facts.rb\r\n\r\nThis will also help to test networking facts in many more platforms in puppet-agent CI, instead of being confined to only 9 platforms in acceptance/tests/facts","created_at":"2016-08-03T23:03:37Z","updated_at":"2016-08-04T17:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e53a13fe49db4a773aa7f49502a9b1fcfe3499e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1390/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/facter/pulls/1390/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/facter/issues/1390/comments","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/4ba2bf4f239e2fd54224b28913a82ffb183ae986","head":{"label":"phongdly:FACT-1361/create_networking_fact_acceptance_test","ref":"FACT-1361/create_networking_fact_acceptance_test","sha":"4ba2bf4f239e2fd54224b28913a82ffb183ae986","user":{"login":"phongdly","id":6462695,"avatar_url":"https://avatars.githubusercontent.com/u/6462695?v=3","gravatar_id":"","url":"https://api.github.com/users/phongdly","html_url":"https://github.com/phongdly","followers_url":"https://api.github.com/users/phongdly/followers","following_url":"https://api.github.com/users/phongdly/following{/other_user}","gists_url":"https://api.github.com/users/phongdly/gists{/gist_id}","starred_url":"https://api.github.com/users/phongdly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongdly/subscriptions","organizations_url":"https://api.github.com/users/phongdly/orgs","repos_url":"https://api.github.com/users/phongdly/repos","events_url":"https://api.github.com/users/phongdly/events{/privacy}","received_events_url":"https://api.github.com/users/phongdly/received_events","type":"User","site_admin":false},"repo":{"id":64344512,"name":"facter","full_name":"phongdly/facter","owner":{"login":"phongdly","id":6462695,"avatar_url":"https://avatars.githubusercontent.com/u/6462695?v=3","gravatar_id":"","url":"https://api.github.com/users/phongdly","html_url":"https://github.com/phongdly","followers_url":"https://api.github.com/users/phongdly/followers","following_url":"https://api.github.com/users/phongdly/following{/other_user}","gists_url":"https://api.github.com/users/phongdly/gists{/gist_id}","starred_url":"https://api.github.com/users/phongdly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phongdly/subscriptions","organizations_url":"https://api.github.com/users/phongdly/orgs","repos_url":"https://api.github.com/users/phongdly/repos","events_url":"https://api.github.com/users/phongdly/events{/privacy}","received_events_url":"https://api.github.com/users/phongdly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phongdly/facter","description":"Collect and display system facts","fork":true,"url":"https://api.github.com/repos/phongdly/facter","forks_url":"https://api.github.com/repos/phongdly/facter/forks","keys_url":"https://api.github.com/repos/phongdly/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phongdly/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phongdly/facter/teams","hooks_url":"https://api.github.com/repos/phongdly/facter/hooks","issue_events_url":"https://api.github.com/repos/phongdly/facter/issues/events{/number}","events_url":"https://api.github.com/repos/phongdly/facter/events","assignees_url":"https://api.github.com/repos/phongdly/facter/assignees{/user}","branches_url":"https://api.github.com/repos/phongdly/facter/branches{/branch}","tags_url":"https://api.github.com/repos/phongdly/facter/tags","blobs_url":"https://api.github.com/repos/phongdly/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phongdly/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phongdly/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/phongdly/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phongdly/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/phongdly/facter/languages","stargazers_url":"https://api.github.com/repos/phongdly/facter/stargazers","contributors_url":"https://api.github.com/repos/phongdly/facter/contributors","subscribers_url":"https://api.github.com/repos/phongdly/facter/subscribers","subscription_url":"https://api.github.com/repos/phongdly/facter/subscription","commits_url":"https://api.github.com/repos/phongdly/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/phongdly/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/phongdly/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/phongdly/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/phongdly/facter/contents/{+path}","compare_url":"https://api.github.com/repos/phongdly/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phongdly/facter/merges","archive_url":"https://api.github.com/repos/phongdly/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phongdly/facter/downloads","issues_url":"https://api.github.com/repos/phongdly/facter/issues{/number}","pulls_url":"https://api.github.com/repos/phongdly/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/phongdly/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/phongdly/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phongdly/facter/labels{/name}","releases_url":"https://api.github.com/repos/phongdly/facter/releases{/id}","deployments_url":"https://api.github.com/repos/phongdly/facter/deployments","created_at":"2016-07-27T21:59:07Z","updated_at":"2016-07-27T21:59:11Z","pushed_at":"2016-08-03T23:09:15Z","git_url":"git://github.com/phongdly/facter.git","ssh_url":"git@github.com:phongdly/facter.git","clone_url":"https://github.com/phongdly/facter.git","svn_url":"https://github.com/phongdly/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":13146,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"c86b3086f45c9de980fd23176c15e37fddf20cd4","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910757,"name":"facter","full_name":"puppetlabs/facter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/facter","description":"Collect and display system facts","fork":false,"url":"https://api.github.com/repos/puppetlabs/facter","forks_url":"https://api.github.com/repos/puppetlabs/facter/forks","keys_url":"https://api.github.com/repos/puppetlabs/facter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/facter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/facter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/facter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/facter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/facter/events","assignees_url":"https://api.github.com/repos/puppetlabs/facter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/facter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/facter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/facter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/facter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/facter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/facter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/facter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/facter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/facter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/facter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/facter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/facter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/facter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/facter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/facter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/facter/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/facter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/facter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/facter/merges","archive_url":"https://api.github.com/repos/puppetlabs/facter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/facter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/facter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/facter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/facter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/facter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/facter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/facter/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/facter/deployments","created_at":"2010-09-14T19:31:04Z","updated_at":"2016-07-30T12:18:48Z","pushed_at":"2016-08-04T16:29:24Z","git_url":"git://github.com/puppetlabs/facter.git","ssh_url":"git@github.com:puppetlabs/facter.git","clone_url":"https://github.com/puppetlabs/facter.git","svn_url":"https://github.com/puppetlabs/facter","homepage":"https://tickets.puppet.com/browse/FACT","size":19810,"stargazers_count":444,"watchers_count":444,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":394,"mirror_url":null,"open_issues_count":8,"forks":394,"open_issues":8,"watchers":444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1390"},"html":{"href":"https://github.com/puppetlabs/facter/pull/1390"},"issue":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1390"},"comments":{"href":"https://api.github.com/repos/puppetlabs/facter/issues/1390/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1390/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/facter/pulls/1390/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/facter/statuses/4ba2bf4f239e2fd54224b28913a82ffb183ae986"}}}}
{"actor":{"display_login":"er0ck"}}