{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/76685523","id":76685523,"diff_hunk":"@@ -85,10 +85,18 @@ protected EntityId(EntityType entity) {\n \n   protected abstract Iterable<String> toIdParts();\n \n+  /**\n+   *  Deprecated method to rename to getEntityType(). Use {@link #getEntityType()}\n+   */\n+  @Deprecated\n   public final EntityType getEntity() {\n     return entity;\n   }\n \n+  public final EntityType getEntityType() {\n+    return entity;","path":"cdap-proto/src/main/java/co/cask/cdap/proto/id/EntityId.java","position":13,"original_position":13,"commit_id":"17588dfbe24918ce7953ede16296bf86f116d99f","original_commit_id":"17588dfbe24918ce7953ede16296bf86f116d99f","user":{"login":"riwazp7","id":10622945,"avatar_url":"https://avatars.githubusercontent.com/u/10622945?v=3","gravatar_id":"","url":"https://api.github.com/users/riwazp7","html_url":"https://github.com/riwazp7","followers_url":"https://api.github.com/users/riwazp7/followers","following_url":"https://api.github.com/users/riwazp7/following{/other_user}","gists_url":"https://api.github.com/users/riwazp7/gists{/gist_id}","starred_url":"https://api.github.com/users/riwazp7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riwazp7/subscriptions","organizations_url":"https://api.github.com/users/riwazp7/orgs","repos_url":"https://api.github.com/users/riwazp7/repos","events_url":"https://api.github.com/users/riwazp7/events{/privacy}","received_events_url":"https://api.github.com/users/riwazp7/received_events","type":"User","site_admin":false},"body":"I tried renaming it but there are a lot of places in docs that we'd have to rename the variable name too. I'll take another look.","created_at":"2016-08-29T20:55:54Z","updated_at":"2016-08-29T20:55:54Z","html_url":"https://github.com/caskdata/cdap/pull/6600#discussion_r76685523","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/6600","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/76685523"},"html":{"href":"https://github.com/caskdata/cdap/pull/6600#discussion_r76685523"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6600"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/6600","id":83156426,"html_url":"https://github.com/caskdata/cdap/pull/6600","diff_url":"https://github.com/caskdata/cdap/pull/6600.diff","patch_url":"https://github.com/caskdata/cdap/pull/6600.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/6600","number":6600,"state":"open","locked":false,"title":"CDAP-5577 Deprecated getEntity() and added the same method with name …","user":{"login":"riwazp7","id":10622945,"avatar_url":"https://avatars.githubusercontent.com/u/10622945?v=3","gravatar_id":"","url":"https://api.github.com/users/riwazp7","html_url":"https://github.com/riwazp7","followers_url":"https://api.github.com/users/riwazp7/followers","following_url":"https://api.github.com/users/riwazp7/following{/other_user}","gists_url":"https://api.github.com/users/riwazp7/gists{/gist_id}","starred_url":"https://api.github.com/users/riwazp7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riwazp7/subscriptions","organizations_url":"https://api.github.com/users/riwazp7/orgs","repos_url":"https://api.github.com/users/riwazp7/repos","events_url":"https://api.github.com/users/riwazp7/events{/privacy}","received_events_url":"https://api.github.com/users/riwazp7/received_events","type":"User","site_admin":false},"body":"…getEntityType()\r\n\r\nhttps://issues.cask.co/browse/CDAP-5577: EntityId.getEntity() returns EntityType. Rename to getEntityType()\r\n\r\nNot sure if this is the right approach but I deprecated the method instead of renaming it as several projects use it. Will rename the usages of the method but don't wanna break anything in the meantime.\r\n\r\nJIRA to remove the method after two versions: https://issues.cask.co/browse/CDAP-7185","created_at":"2016-08-29T19:50:01Z","updated_at":"2016-08-29T20:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc6527cba790025cd4007cd0dcdbefb8e6e2006c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/6600/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/6600/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/6600/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/17588dfbe24918ce7953ede16296bf86f116d99f","head":{"label":"caskdata:fix/CDAP-5577","ref":"fix/CDAP-5577","sha":"17588dfbe24918ce7953ede16296bf86f116d99f","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-08-26T11:05:32Z","pushed_at":"2016-08-29T20:55:29Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":636366,"stargazers_count":136,"watchers_count":136,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":23,"forks":53,"open_issues":23,"watchers":136,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"2fa01a1de5a69f9cdf78ad4d8a179d3d926de5c8","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-08-26T11:05:32Z","pushed_at":"2016-08-29T20:55:29Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":636366,"stargazers_count":136,"watchers_count":136,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":23,"forks":53,"open_issues":23,"watchers":136,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6600"},"html":{"href":"https://github.com/caskdata/cdap/pull/6600"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6600"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/6600/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6600/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/6600/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/17588dfbe24918ce7953ede16296bf86f116d99f"}}}}
{"actor":{"display_login":"riwazp7"}}