{"action":"created","comment":{"url":"https://api.github.com/repos/openthread/openthread/pulls/comments/83003696","pull_request_review_id":3871864,"id":83003696,"diff_hunk":"@@ -128,6 +129,11 @@ test_message_SOURCES         = test_platform.cpp test_message.cpp\n test_ncp_buffer_LDADD        = $(COMMON_LDADD)\n test_ncp_buffer_SOURCES      = test_platform.cpp test_ncp_buffer.cpp\n \n+test_settings_LDADD          = $(COMMON_LDADD)  \\\n+                               $(top_builddir)/examples/platforms/posix/libopenthread-posix.a \\\n+                               $(NULL)\n+test_settings_SOURCES        = test_settings.cpp","path":"tests/unit/Makefile.am","position":15,"original_position":15,"commit_id":"7d961edeea5c8555ce8745138cbe59e2f1f73e4b","original_commit_id":"7d961edeea5c8555ce8745138cbe59e2f1f73e4b","user":{"login":"nibanks","id":20663557,"avatar_url":"https://avatars.githubusercontent.com/u/20663557?v=3","gravatar_id":"","url":"https://api.github.com/users/nibanks","html_url":"https://github.com/nibanks","followers_url":"https://api.github.com/users/nibanks/followers","following_url":"https://api.github.com/users/nibanks/following{/other_user}","gists_url":"https://api.github.com/users/nibanks/gists{/gist_id}","starred_url":"https://api.github.com/users/nibanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibanks/subscriptions","organizations_url":"https://api.github.com/users/nibanks/orgs","repos_url":"https://api.github.com/users/nibanks/repos","events_url":"https://api.github.com/users/nibanks/events{/privacy}","received_events_url":"https://api.github.com/users/nibanks/received_events","type":"User","site_admin":false},"body":"Can we please follow the model of the tests not depending on a specific platform? Can you please include the `test_platform.cpp` as the other tests above do?","created_at":"2016-10-12T13:27:03Z","updated_at":"2016-10-12T13:28:56Z","html_url":"https://github.com/openthread/openthread/pull/775#discussion_r83003696","pull_request_url":"https://api.github.com/repos/openthread/openthread/pulls/775","_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments/83003696"},"html":{"href":"https://github.com/openthread/openthread/pull/775#discussion_r83003696"},"pull_request":{"href":"https://api.github.com/repos/openthread/openthread/pulls/775"}}},"pull_request":{"url":"https://api.github.com/repos/openthread/openthread/pulls/775","id":88548091,"html_url":"https://github.com/openthread/openthread/pull/775","diff_url":"https://github.com/openthread/openthread/pull/775.diff","patch_url":"https://github.com/openthread/openthread/pull/775.patch","issue_url":"https://api.github.com/repos/openthread/openthread/issues/775","number":775,"state":"open","locked":false,"title":"Settings Driver","user":{"login":"lluwang","id":19200149,"avatar_url":"https://avatars.githubusercontent.com/u/19200149?v=3","gravatar_id":"","url":"https://api.github.com/users/lluwang","html_url":"https://github.com/lluwang","followers_url":"https://api.github.com/users/lluwang/followers","following_url":"https://api.github.com/users/lluwang/following{/other_user}","gists_url":"https://api.github.com/users/lluwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lluwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluwang/subscriptions","organizations_url":"https://api.github.com/users/lluwang/orgs","repos_url":"https://api.github.com/users/lluwang/repos","events_url":"https://api.github.com/users/lluwang/events{/privacy}","received_events_url":"https://api.github.com/users/lluwang/received_events","type":"User","site_admin":false},"body":"This is one of PRs for 9.2.8.","created_at":"2016-10-08T14:50:00Z","updated_at":"2016-10-12T13:28:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dec3f82ea3aae06b968bba2c003a80f0f23eb22e","assignee":{"login":"jwhui","id":16142208,"avatar_url":"https://avatars.githubusercontent.com/u/16142208?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhui","html_url":"https://github.com/jwhui","followers_url":"https://api.github.com/users/jwhui/followers","following_url":"https://api.github.com/users/jwhui/following{/other_user}","gists_url":"https://api.github.com/users/jwhui/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhui/subscriptions","organizations_url":"https://api.github.com/users/jwhui/orgs","repos_url":"https://api.github.com/users/jwhui/repos","events_url":"https://api.github.com/users/jwhui/events{/privacy}","received_events_url":"https://api.github.com/users/jwhui/received_events","type":"User","site_admin":false},"assignees":[{"login":"jwhui","id":16142208,"avatar_url":"https://avatars.githubusercontent.com/u/16142208?v=3","gravatar_id":"","url":"https://api.github.com/users/jwhui","html_url":"https://github.com/jwhui","followers_url":"https://api.github.com/users/jwhui/followers","following_url":"https://api.github.com/users/jwhui/following{/other_user}","gists_url":"https://api.github.com/users/jwhui/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhui/subscriptions","organizations_url":"https://api.github.com/users/jwhui/orgs","repos_url":"https://api.github.com/users/jwhui/repos","events_url":"https://api.github.com/users/jwhui/events{/privacy}","received_events_url":"https://api.github.com/users/jwhui/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openthread/openthread/milestones/1","html_url":"https://github.com/openthread/openthread/milestones/0.01.00%20(Initial%20Official%20Release)","labels_url":"https://api.github.com/repos/openthread/openthread/milestones/1/labels","id":1775078,"number":1,"title":"0.01.00 (Initial Official Release)","description":"First official release.","creator":{"login":"darconeous","id":686678,"avatar_url":"https://avatars.githubusercontent.com/u/686678?v=3","gravatar_id":"","url":"https://api.github.com/users/darconeous","html_url":"https://github.com/darconeous","followers_url":"https://api.github.com/users/darconeous/followers","following_url":"https://api.github.com/users/darconeous/following{/other_user}","gists_url":"https://api.github.com/users/darconeous/gists{/gist_id}","starred_url":"https://api.github.com/users/darconeous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darconeous/subscriptions","organizations_url":"https://api.github.com/users/darconeous/orgs","repos_url":"https://api.github.com/users/darconeous/repos","events_url":"https://api.github.com/users/darconeous/events{/privacy}","received_events_url":"https://api.github.com/users/darconeous/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":580,"state":"open","created_at":"2016-05-18T22:19:18Z","updated_at":"2016-10-12T00:40:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openthread/openthread/pulls/775/commits","review_comments_url":"https://api.github.com/repos/openthread/openthread/pulls/775/comments","review_comment_url":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/openthread/issues/775/comments","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/7d961edeea5c8555ce8745138cbe59e2f1f73e4b","head":{"label":"lluwang:pr/settings_driver","ref":"pr/settings_driver","sha":"7d961edeea5c8555ce8745138cbe59e2f1f73e4b","user":{"login":"lluwang","id":19200149,"avatar_url":"https://avatars.githubusercontent.com/u/19200149?v=3","gravatar_id":"","url":"https://api.github.com/users/lluwang","html_url":"https://github.com/lluwang","followers_url":"https://api.github.com/users/lluwang/followers","following_url":"https://api.github.com/users/lluwang/following{/other_user}","gists_url":"https://api.github.com/users/lluwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lluwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluwang/subscriptions","organizations_url":"https://api.github.com/users/lluwang/orgs","repos_url":"https://api.github.com/users/lluwang/repos","events_url":"https://api.github.com/users/lluwang/events{/privacy}","received_events_url":"https://api.github.com/users/lluwang/received_events","type":"User","site_admin":false},"repo":{"id":58849333,"name":"openthread","full_name":"lluwang/openthread","owner":{"login":"lluwang","id":19200149,"avatar_url":"https://avatars.githubusercontent.com/u/19200149?v=3","gravatar_id":"","url":"https://api.github.com/users/lluwang","html_url":"https://github.com/lluwang","followers_url":"https://api.github.com/users/lluwang/followers","following_url":"https://api.github.com/users/lluwang/following{/other_user}","gists_url":"https://api.github.com/users/lluwang/gists{/gist_id}","starred_url":"https://api.github.com/users/lluwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluwang/subscriptions","organizations_url":"https://api.github.com/users/lluwang/orgs","repos_url":"https://api.github.com/users/lluwang/repos","events_url":"https://api.github.com/users/lluwang/events{/privacy}","received_events_url":"https://api.github.com/users/lluwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lluwang/openthread","description":"OpenThread is an open-source implementation of the Thread networking protocol","fork":true,"url":"https://api.github.com/repos/lluwang/openthread","forks_url":"https://api.github.com/repos/lluwang/openthread/forks","keys_url":"https://api.github.com/repos/lluwang/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lluwang/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lluwang/openthread/teams","hooks_url":"https://api.github.com/repos/lluwang/openthread/hooks","issue_events_url":"https://api.github.com/repos/lluwang/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/lluwang/openthread/events","assignees_url":"https://api.github.com/repos/lluwang/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/lluwang/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/lluwang/openthread/tags","blobs_url":"https://api.github.com/repos/lluwang/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lluwang/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lluwang/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/lluwang/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lluwang/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/lluwang/openthread/languages","stargazers_url":"https://api.github.com/repos/lluwang/openthread/stargazers","contributors_url":"https://api.github.com/repos/lluwang/openthread/contributors","subscribers_url":"https://api.github.com/repos/lluwang/openthread/subscribers","subscription_url":"https://api.github.com/repos/lluwang/openthread/subscription","commits_url":"https://api.github.com/repos/lluwang/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/lluwang/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/lluwang/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/lluwang/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/lluwang/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/lluwang/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lluwang/openthread/merges","archive_url":"https://api.github.com/repos/lluwang/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lluwang/openthread/downloads","issues_url":"https://api.github.com/repos/lluwang/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/lluwang/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/lluwang/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/lluwang/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lluwang/openthread/labels{/name}","releases_url":"https://api.github.com/repos/lluwang/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/lluwang/openthread/deployments","created_at":"2016-05-15T07:27:25Z","updated_at":"2016-05-15T07:27:27Z","pushed_at":"2016-10-12T08:53:50Z","git_url":"git://github.com/lluwang/openthread.git","ssh_url":"git@github.com:lluwang/openthread.git","clone_url":"https://github.com/lluwang/openthread.git","svn_url":"https://github.com/lluwang/openthread","homepage":"","size":94282,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"10f9204da2e6e343d7af24f160de385e1bf0dfa7","user":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":55808787,"name":"openthread","full_name":"openthread/openthread","owner":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":false,"url":"https://api.github.com/repos/openthread/openthread","forks_url":"https://api.github.com/repos/openthread/openthread/forks","keys_url":"https://api.github.com/repos/openthread/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/openthread/teams","hooks_url":"https://api.github.com/repos/openthread/openthread/hooks","issue_events_url":"https://api.github.com/repos/openthread/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/openthread/events","assignees_url":"https://api.github.com/repos/openthread/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/openthread/tags","blobs_url":"https://api.github.com/repos/openthread/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/openthread/languages","stargazers_url":"https://api.github.com/repos/openthread/openthread/stargazers","contributors_url":"https://api.github.com/repos/openthread/openthread/contributors","subscribers_url":"https://api.github.com/repos/openthread/openthread/subscribers","subscription_url":"https://api.github.com/repos/openthread/openthread/subscription","commits_url":"https://api.github.com/repos/openthread/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/openthread/merges","archive_url":"https://api.github.com/repos/openthread/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/openthread/downloads","issues_url":"https://api.github.com/repos/openthread/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/openthread/labels{/name}","releases_url":"https://api.github.com/repos/openthread/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/openthread/deployments","created_at":"2016-04-08T20:47:41Z","updated_at":"2016-10-09T22:36:03Z","pushed_at":"2016-10-12T13:27:32Z","git_url":"git://github.com/openthread/openthread.git","ssh_url":"git@github.com:openthread/openthread.git","clone_url":"https://github.com/openthread/openthread.git","svn_url":"https://github.com/openthread/openthread","homepage":"","size":275720,"stargazers_count":994,"watchers_count":994,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":220,"mirror_url":null,"open_issues_count":44,"forks":220,"open_issues":44,"watchers":994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/775"},"html":{"href":"https://github.com/openthread/openthread/pull/775"},"issue":{"href":"https://api.github.com/repos/openthread/openthread/issues/775"},"comments":{"href":"https://api.github.com/repos/openthread/openthread/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/openthread/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/openthread/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/openthread/statuses/7d961edeea5c8555ce8745138cbe59e2f1f73e4b"}}}}
{"actor":{"display_login":"nibanks"}}