{"action":"closed","number":2221,"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/2221","id":88136206,"html_url":"https://github.com/python/mypy/pull/2221","diff_url":"https://github.com/python/mypy/pull/2221.diff","patch_url":"https://github.com/python/mypy/pull/2221.patch","issue_url":"https://api.github.com/repos/python/mypy/issues/2221","number":2221,"state":"closed","locked":false,"title":"[WIP] Tighten Lvalues and remove all references to Node","user":{"login":"elazarg","id":5108069,"avatar_url":"https://avatars.githubusercontent.com/u/5108069?v=3","gravatar_id":"","url":"https://api.github.com/users/elazarg","html_url":"https://github.com/elazarg","followers_url":"https://api.github.com/users/elazarg/followers","following_url":"https://api.github.com/users/elazarg/following{/other_user}","gists_url":"https://api.github.com/users/elazarg/gists{/gist_id}","starred_url":"https://api.github.com/users/elazarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elazarg/subscriptions","organizations_url":"https://api.github.com/users/elazarg/orgs","repos_url":"https://api.github.com/users/elazarg/repos","events_url":"https://api.github.com/users/elazarg/events{/privacy}","received_events_url":"https://api.github.com/users/elazarg/received_events","type":"User","site_admin":false},"body":"<s>TypeMap is tighten to Dict[Expression, Type], which will help removing most of the remaining references to Node. It will also allow moving `literal` and `literal_hash` from Node to Expression (leaving only line and column as data in Node), possibly making it easier to perform the NB regarding TypeMap (see inside).\r\n\r\nOne culprit is that TypeMap is Optional everywhere now. Admittedly I don't understand why is it Optional at all.</s>\r\n\r\n[I intend to use this PR as a reference for changes in much smaller chunks]\r\n\r\nAll references to Node are removed from everywhere except mypy.node.\r\n\r\nMake Lvalue a separate Union type. This has many implications; I think the PR can serve as a demonstration for now.\r\n\r\nThe need for dedicated LvalueTuple and LvalueStar is seen through the casts needed when accessing their elements. Perhaps making them generic can help.","created_at":"2016-10-05T18:57:31Z","updated_at":"2016-10-06T20:48:46Z","closed_at":"2016-10-06T20:48:46Z","merged_at":null,"merge_commit_sha":"36876709bda32999f99621a4e59bad060ceaed17","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/mypy/pulls/2221/commits","review_comments_url":"https://api.github.com/repos/python/mypy/pulls/2221/comments","review_comment_url":"https://api.github.com/repos/python/mypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/mypy/issues/2221/comments","statuses_url":"https://api.github.com/repos/python/mypy/statuses/a2df9c41fd5bc7321c841e3a24d838b7ee437d5c","head":{"label":"elazarg:extract_typemap","ref":"extract_typemap","sha":"a2df9c41fd5bc7321c841e3a24d838b7ee437d5c","user":{"login":"elazarg","id":5108069,"avatar_url":"https://avatars.githubusercontent.com/u/5108069?v=3","gravatar_id":"","url":"https://api.github.com/users/elazarg","html_url":"https://github.com/elazarg","followers_url":"https://api.github.com/users/elazarg/followers","following_url":"https://api.github.com/users/elazarg/following{/other_user}","gists_url":"https://api.github.com/users/elazarg/gists{/gist_id}","starred_url":"https://api.github.com/users/elazarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elazarg/subscriptions","organizations_url":"https://api.github.com/users/elazarg/orgs","repos_url":"https://api.github.com/users/elazarg/repos","events_url":"https://api.github.com/users/elazarg/events{/privacy}","received_events_url":"https://api.github.com/users/elazarg/received_events","type":"User","site_admin":false},"repo":{"id":62555292,"name":"mypy","full_name":"elazarg/mypy","owner":{"login":"elazarg","id":5108069,"avatar_url":"https://avatars.githubusercontent.com/u/5108069?v=3","gravatar_id":"","url":"https://api.github.com/users/elazarg","html_url":"https://github.com/elazarg","followers_url":"https://api.github.com/users/elazarg/followers","following_url":"https://api.github.com/users/elazarg/following{/other_user}","gists_url":"https://api.github.com/users/elazarg/gists{/gist_id}","starred_url":"https://api.github.com/users/elazarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elazarg/subscriptions","organizations_url":"https://api.github.com/users/elazarg/orgs","repos_url":"https://api.github.com/users/elazarg/repos","events_url":"https://api.github.com/users/elazarg/events{/privacy}","received_events_url":"https://api.github.com/users/elazarg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elazarg/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":true,"url":"https://api.github.com/repos/elazarg/mypy","forks_url":"https://api.github.com/repos/elazarg/mypy/forks","keys_url":"https://api.github.com/repos/elazarg/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elazarg/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elazarg/mypy/teams","hooks_url":"https://api.github.com/repos/elazarg/mypy/hooks","issue_events_url":"https://api.github.com/repos/elazarg/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/elazarg/mypy/events","assignees_url":"https://api.github.com/repos/elazarg/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/elazarg/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/elazarg/mypy/tags","blobs_url":"https://api.github.com/repos/elazarg/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elazarg/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elazarg/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/elazarg/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elazarg/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/elazarg/mypy/languages","stargazers_url":"https://api.github.com/repos/elazarg/mypy/stargazers","contributors_url":"https://api.github.com/repos/elazarg/mypy/contributors","subscribers_url":"https://api.github.com/repos/elazarg/mypy/subscribers","subscription_url":"https://api.github.com/repos/elazarg/mypy/subscription","commits_url":"https://api.github.com/repos/elazarg/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/elazarg/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/elazarg/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/elazarg/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/elazarg/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/elazarg/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elazarg/mypy/merges","archive_url":"https://api.github.com/repos/elazarg/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elazarg/mypy/downloads","issues_url":"https://api.github.com/repos/elazarg/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/elazarg/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/elazarg/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/elazarg/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elazarg/mypy/labels{/name}","releases_url":"https://api.github.com/repos/elazarg/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/elazarg/mypy/deployments","created_at":"2016-07-04T10:54:58Z","updated_at":"2016-07-04T10:55:00Z","pushed_at":"2016-10-06T20:41:38Z","git_url":"git://github.com/elazarg/mypy.git","ssh_url":"git@github.com:elazarg/mypy.git","clone_url":"https://github.com/elazarg/mypy.git","svn_url":"https://github.com/elazarg/mypy","homepage":"http://www.mypy-lang.org/","size":15938,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"62ad163210149148e71422dddc82b5005d7b06e0","user":{"login":"python","id":1525981,"avatar_url":"https://avatars.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":7053637,"name":"mypy","full_name":"python/mypy","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":false,"url":"https://api.github.com/repos/python/mypy","forks_url":"https://api.github.com/repos/python/mypy/forks","keys_url":"https://api.github.com/repos/python/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/mypy/teams","hooks_url":"https://api.github.com/repos/python/mypy/hooks","issue_events_url":"https://api.github.com/repos/python/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/python/mypy/events","assignees_url":"https://api.github.com/repos/python/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/python/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/python/mypy/tags","blobs_url":"https://api.github.com/repos/python/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/python/mypy/languages","stargazers_url":"https://api.github.com/repos/python/mypy/stargazers","contributors_url":"https://api.github.com/repos/python/mypy/contributors","subscribers_url":"https://api.github.com/repos/python/mypy/subscribers","subscription_url":"https://api.github.com/repos/python/mypy/subscription","commits_url":"https://api.github.com/repos/python/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/python/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/mypy/merges","archive_url":"https://api.github.com/repos/python/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/mypy/downloads","issues_url":"https://api.github.com/repos/python/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/python/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/python/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/python/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/mypy/labels{/name}","releases_url":"https://api.github.com/repos/python/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/python/mypy/deployments","created_at":"2012-12-07T13:30:23Z","updated_at":"2016-10-06T19:03:26Z","pushed_at":"2016-10-06T20:45:34Z","git_url":"git://github.com/python/mypy.git","ssh_url":"git@github.com:python/mypy.git","clone_url":"https://github.com/python/mypy.git","svn_url":"https://github.com/python/mypy","homepage":"http://www.mypy-lang.org/","size":18630,"stargazers_count":1771,"watchers_count":1771,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":490,"forks":211,"open_issues":490,"watchers":1771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/2221"},"html":{"href":"https://github.com/python/mypy/pull/2221"},"issue":{"href":"https://api.github.com/repos/python/mypy/issues/2221"},"comments":{"href":"https://api.github.com/repos/python/mypy/issues/2221/comments"},"review_comments":{"href":"https://api.github.com/repos/python/mypy/pulls/2221/comments"},"review_comment":{"href":"https://api.github.com/repos/python/mypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/mypy/pulls/2221/commits"},"statuses":{"href":"https://api.github.com/repos/python/mypy/statuses/a2df9c41fd5bc7321c841e3a24d838b7ee437d5c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":3,"commits":14,"additions":398,"deletions":300,"changed_files":16}}
{"actor":{"display_login":"elazarg"}}