{"action":"created","comment":{"url":"https://api.github.com/repos/garethr/garethr-docker/pulls/comments/54420442","id":54420442,"diff_hunk":"@@ -120,8 +120,7 @@\n   }\n \n   $_manage_service = $manage_service ? {\n-    false   => undef,\n-    true    => 'Service[docker]',\n+    true    => Service['docker'],\n     default => undef,","path":"manifests/service.pp","position":16,"original_position":16,"commit_id":"ed0855d5e9e3d1984e1249f39375c2716cf10584","original_commit_id":"ed0855d5e9e3d1984e1249f39375c2716cf10584","user":{"login":"jovandeginste","id":3170771,"avatar_url":"https://avatars.githubusercontent.com/u/3170771?v=3","gravatar_id":"","url":"https://api.github.com/users/jovandeginste","html_url":"https://github.com/jovandeginste","followers_url":"https://api.github.com/users/jovandeginste/followers","following_url":"https://api.github.com/users/jovandeginste/following{/other_user}","gists_url":"https://api.github.com/users/jovandeginste/gists{/gist_id}","starred_url":"https://api.github.com/users/jovandeginste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jovandeginste/subscriptions","organizations_url":"https://api.github.com/users/jovandeginste/orgs","repos_url":"https://api.github.com/users/jovandeginste/repos","events_url":"https://api.github.com/users/jovandeginste/events{/privacy}","received_events_url":"https://api.github.com/users/jovandeginste/received_events","type":"User","site_admin":false},"body":"'undef' should be '[]' (Otherwise, I get this error:\r\n\r\n```\r\nError: Parameter notify failed on File[/etc/sysconfig/docker-storage-setup]: No title provided and :undef is not a valid resource reference at <xxx>docker/manifests/service.pp:135\r\n```","created_at":"2016-02-29T15:03:01Z","updated_at":"2016-02-29T15:03:01Z","html_url":"https://github.com/garethr/garethr-docker/pull/453#discussion_r54420442","pull_request_url":"https://api.github.com/repos/garethr/garethr-docker/pulls/453","_links":{"self":{"href":"https://api.github.com/repos/garethr/garethr-docker/pulls/comments/54420442"},"html":{"href":"https://github.com/garethr/garethr-docker/pull/453#discussion_r54420442"},"pull_request":{"href":"https://api.github.com/repos/garethr/garethr-docker/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/garethr/garethr-docker/pulls/453","id":61074511,"html_url":"https://github.com/garethr/garethr-docker/pull/453","diff_url":"https://github.com/garethr/garethr-docker/pull/453.diff","patch_url":"https://github.com/garethr/garethr-docker/pull/453.patch","issue_url":"https://api.github.com/repos/garethr/garethr-docker/issues/453","number":453,"state":"open","locked":false,"title":"Don't quote dependency references","user":{"login":"PierreR","id":93115,"avatar_url":"https://avatars.githubusercontent.com/u/93115?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"body":"'language-puppet' chokes on this (rightly I would argue).","created_at":"2016-02-29T13:02:59Z","updated_at":"2016-02-29T15:03:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ce1f401e17c8537a588002e18774708a9d4564f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/garethr/garethr-docker/pulls/453/commits","review_comments_url":"https://api.github.com/repos/garethr/garethr-docker/pulls/453/comments","review_comment_url":"https://api.github.com/repos/garethr/garethr-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/garethr/garethr-docker/issues/453/comments","statuses_url":"https://api.github.com/repos/garethr/garethr-docker/statuses/ed0855d5e9e3d1984e1249f39375c2716cf10584","head":{"label":"PierreR:patch-1","ref":"patch-1","sha":"ed0855d5e9e3d1984e1249f39375c2716cf10584","user":{"login":"PierreR","id":93115,"avatar_url":"https://avatars.githubusercontent.com/u/93115?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"repo":{"id":46281342,"name":"garethr-docker","full_name":"PierreR/garethr-docker","owner":{"login":"PierreR","id":93115,"avatar_url":"https://avatars.githubusercontent.com/u/93115?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreR","html_url":"https://github.com/PierreR","followers_url":"https://api.github.com/users/PierreR/followers","following_url":"https://api.github.com/users/PierreR/following{/other_user}","gists_url":"https://api.github.com/users/PierreR/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreR/subscriptions","organizations_url":"https://api.github.com/users/PierreR/orgs","repos_url":"https://api.github.com/users/PierreR/repos","events_url":"https://api.github.com/users/PierreR/events{/privacy}","received_events_url":"https://api.github.com/users/PierreR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PierreR/garethr-docker","description":"Puppet module for managing docker","fork":true,"url":"https://api.github.com/repos/PierreR/garethr-docker","forks_url":"https://api.github.com/repos/PierreR/garethr-docker/forks","keys_url":"https://api.github.com/repos/PierreR/garethr-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PierreR/garethr-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PierreR/garethr-docker/teams","hooks_url":"https://api.github.com/repos/PierreR/garethr-docker/hooks","issue_events_url":"https://api.github.com/repos/PierreR/garethr-docker/issues/events{/number}","events_url":"https://api.github.com/repos/PierreR/garethr-docker/events","assignees_url":"https://api.github.com/repos/PierreR/garethr-docker/assignees{/user}","branches_url":"https://api.github.com/repos/PierreR/garethr-docker/branches{/branch}","tags_url":"https://api.github.com/repos/PierreR/garethr-docker/tags","blobs_url":"https://api.github.com/repos/PierreR/garethr-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PierreR/garethr-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PierreR/garethr-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/PierreR/garethr-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PierreR/garethr-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/PierreR/garethr-docker/languages","stargazers_url":"https://api.github.com/repos/PierreR/garethr-docker/stargazers","contributors_url":"https://api.github.com/repos/PierreR/garethr-docker/contributors","subscribers_url":"https://api.github.com/repos/PierreR/garethr-docker/subscribers","subscription_url":"https://api.github.com/repos/PierreR/garethr-docker/subscription","commits_url":"https://api.github.com/repos/PierreR/garethr-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/PierreR/garethr-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/PierreR/garethr-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/PierreR/garethr-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/PierreR/garethr-docker/contents/{+path}","compare_url":"https://api.github.com/repos/PierreR/garethr-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PierreR/garethr-docker/merges","archive_url":"https://api.github.com/repos/PierreR/garethr-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PierreR/garethr-docker/downloads","issues_url":"https://api.github.com/repos/PierreR/garethr-docker/issues{/number}","pulls_url":"https://api.github.com/repos/PierreR/garethr-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/PierreR/garethr-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/PierreR/garethr-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PierreR/garethr-docker/labels{/name}","releases_url":"https://api.github.com/repos/PierreR/garethr-docker/releases{/id}","deployments_url":"https://api.github.com/repos/PierreR/garethr-docker/deployments","created_at":"2015-11-16T14:54:23Z","updated_at":"2015-11-16T14:54:24Z","pushed_at":"2016-02-29T14:51:46Z","git_url":"git://github.com/PierreR/garethr-docker.git","ssh_url":"git@github.com:PierreR/garethr-docker.git","clone_url":"https://github.com/PierreR/garethr-docker.git","svn_url":"https://github.com/PierreR/garethr-docker","homepage":null,"size":941,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"garethr:master","ref":"master","sha":"2cbc2878120aae4da5bc988f38d96dfe960191de","user":{"login":"garethr","id":2029,"avatar_url":"https://avatars.githubusercontent.com/u/2029?v=3","gravatar_id":"","url":"https://api.github.com/users/garethr","html_url":"https://github.com/garethr","followers_url":"https://api.github.com/users/garethr/followers","following_url":"https://api.github.com/users/garethr/following{/other_user}","gists_url":"https://api.github.com/users/garethr/gists{/gist_id}","starred_url":"https://api.github.com/users/garethr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethr/subscriptions","organizations_url":"https://api.github.com/users/garethr/orgs","repos_url":"https://api.github.com/users/garethr/repos","events_url":"https://api.github.com/users/garethr/events{/privacy}","received_events_url":"https://api.github.com/users/garethr/received_events","type":"User","site_admin":false},"repo":{"id":9897045,"name":"garethr-docker","full_name":"garethr/garethr-docker","owner":{"login":"garethr","id":2029,"avatar_url":"https://avatars.githubusercontent.com/u/2029?v=3","gravatar_id":"","url":"https://api.github.com/users/garethr","html_url":"https://github.com/garethr","followers_url":"https://api.github.com/users/garethr/followers","following_url":"https://api.github.com/users/garethr/following{/other_user}","gists_url":"https://api.github.com/users/garethr/gists{/gist_id}","starred_url":"https://api.github.com/users/garethr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethr/subscriptions","organizations_url":"https://api.github.com/users/garethr/orgs","repos_url":"https://api.github.com/users/garethr/repos","events_url":"https://api.github.com/users/garethr/events{/privacy}","received_events_url":"https://api.github.com/users/garethr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethr/garethr-docker","description":"Puppet module for managing docker","fork":false,"url":"https://api.github.com/repos/garethr/garethr-docker","forks_url":"https://api.github.com/repos/garethr/garethr-docker/forks","keys_url":"https://api.github.com/repos/garethr/garethr-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethr/garethr-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethr/garethr-docker/teams","hooks_url":"https://api.github.com/repos/garethr/garethr-docker/hooks","issue_events_url":"https://api.github.com/repos/garethr/garethr-docker/issues/events{/number}","events_url":"https://api.github.com/repos/garethr/garethr-docker/events","assignees_url":"https://api.github.com/repos/garethr/garethr-docker/assignees{/user}","branches_url":"https://api.github.com/repos/garethr/garethr-docker/branches{/branch}","tags_url":"https://api.github.com/repos/garethr/garethr-docker/tags","blobs_url":"https://api.github.com/repos/garethr/garethr-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethr/garethr-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethr/garethr-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethr/garethr-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethr/garethr-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/garethr/garethr-docker/languages","stargazers_url":"https://api.github.com/repos/garethr/garethr-docker/stargazers","contributors_url":"https://api.github.com/repos/garethr/garethr-docker/contributors","subscribers_url":"https://api.github.com/repos/garethr/garethr-docker/subscribers","subscription_url":"https://api.github.com/repos/garethr/garethr-docker/subscription","commits_url":"https://api.github.com/repos/garethr/garethr-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethr/garethr-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethr/garethr-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethr/garethr-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/garethr/garethr-docker/contents/{+path}","compare_url":"https://api.github.com/repos/garethr/garethr-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethr/garethr-docker/merges","archive_url":"https://api.github.com/repos/garethr/garethr-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethr/garethr-docker/downloads","issues_url":"https://api.github.com/repos/garethr/garethr-docker/issues{/number}","pulls_url":"https://api.github.com/repos/garethr/garethr-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/garethr/garethr-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/garethr/garethr-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethr/garethr-docker/labels{/name}","releases_url":"https://api.github.com/repos/garethr/garethr-docker/releases{/id}","deployments_url":"https://api.github.com/repos/garethr/garethr-docker/deployments","created_at":"2013-05-06T21:13:55Z","updated_at":"2016-02-23T06:56:43Z","pushed_at":"2016-02-29T14:51:47Z","git_url":"git://github.com/garethr/garethr-docker.git","ssh_url":"git@github.com:garethr/garethr-docker.git","clone_url":"https://github.com/garethr/garethr-docker.git","svn_url":"https://github.com/garethr/garethr-docker","homepage":null,"size":1611,"stargazers_count":303,"watchers_count":303,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":354,"mirror_url":null,"open_issues_count":55,"forks":354,"open_issues":55,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/garethr/garethr-docker/pulls/453"},"html":{"href":"https://github.com/garethr/garethr-docker/pull/453"},"issue":{"href":"https://api.github.com/repos/garethr/garethr-docker/issues/453"},"comments":{"href":"https://api.github.com/repos/garethr/garethr-docker/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/garethr/garethr-docker/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/garethr/garethr-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/garethr/garethr-docker/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/garethr/garethr-docker/statuses/ed0855d5e9e3d1984e1249f39375c2716cf10584"}}}}