{"action":"created","comment":{"url":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments/49971959","id":49971959,"diff_hunk":"@@ -1,50 +1,103 @@\n+'use strict';\n import ReactDOM from 'react-dom';\n-import React from 'react';\n+import React, { Component, PropTypes } from 'react'\n+import { Redirect, Router, Route } from 'react-router';\n import classNames from 'classnames';\n import \"bootstrap-webpack!bootstrap-webpack/bootstrap.config.js\";\n-import { Nav, Input, ButtonInput } from \"react-bootstrap\";\n+import { Input, ButtonInput, Form, Well } from \"react-bootstrap\";\n+import './Login.css';\n+import Main_login from './Main_login'\n+import SampleViewContainer from '../containers/SampleViewContainer'","path":"mxcube3/ui/components/Login.jsx","position":12,"original_position":12,"commit_id":"58f45b13f9f08989129e78e2809292aaddd7b327","original_commit_id":"58f45b13f9f08989129e78e2809292aaddd7b327","user":{"login":"mguijarr","id":2834952,"avatar_url":"https://avatars.githubusercontent.com/u/2834952?v=3","gravatar_id":"","url":"https://api.github.com/users/mguijarr","html_url":"https://github.com/mguijarr","followers_url":"https://api.github.com/users/mguijarr/followers","following_url":"https://api.github.com/users/mguijarr/following{/other_user}","gists_url":"https://api.github.com/users/mguijarr/gists{/gist_id}","starred_url":"https://api.github.com/users/mguijarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mguijarr/subscriptions","organizations_url":"https://api.github.com/users/mguijarr/orgs","repos_url":"https://api.github.com/users/mguijarr/repos","events_url":"https://api.github.com/users/mguijarr/events{/privacy}","received_events_url":"https://api.github.com/users/mguijarr/received_events","type":"User","site_admin":false},"body":"Why the Login component has to import SampleViewContainer ?\r\nI think it is better if Login component is only for the login feature.\r\nMoreover, this is a component not a container so I don't think it\r\nshould contain big parts of the application.","created_at":"2016-01-18T08:40:26Z","updated_at":"2016-01-18T08:40:26Z","html_url":"https://github.com/mxcube/mxcube3/pull/96#discussion_r49971959","pull_request_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments/49971959"},"html":{"href":"https://github.com/mxcube/mxcube3/pull/96#discussion_r49971959"},"pull_request":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/mxcube/mxcube3/pulls/96","id":56279275,"html_url":"https://github.com/mxcube/mxcube3/pull/96","diff_url":"https://github.com/mxcube/mxcube3/pull/96.diff","patch_url":"https://github.com/mxcube/mxcube3/pull/96.patch","issue_url":"https://api.github.com/repos/mxcube/mxcube3/issues/96","number":96,"state":"open","locked":false,"title":"A Separate Login Page","user":{"login":"JieNanMAXIV","id":14329743,"avatar_url":"https://avatars.githubusercontent.com/u/14329743?v=3","gravatar_id":"","url":"https://api.github.com/users/JieNanMAXIV","html_url":"https://github.com/JieNanMAXIV","followers_url":"https://api.github.com/users/JieNanMAXIV/followers","following_url":"https://api.github.com/users/JieNanMAXIV/following{/other_user}","gists_url":"https://api.github.com/users/JieNanMAXIV/gists{/gist_id}","starred_url":"https://api.github.com/users/JieNanMAXIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieNanMAXIV/subscriptions","organizations_url":"https://api.github.com/users/JieNanMAXIV/orgs","repos_url":"https://api.github.com/users/JieNanMAXIV/repos","events_url":"https://api.github.com/users/JieNanMAXIV/events{/privacy}","received_events_url":"https://api.github.com/users/JieNanMAXIV/received_events","type":"User","site_admin":false},"body":"Add a separate login page as the start page, with the following features / changes,\r\n- load the synchrotron_name and beamline_name from session HO (session.xml) and display on the login page\r\n- depending on LoginType that is defined in dbconnection.xml, the placeholder of LoginID is either User or Proposal\r\n- after submission, the form is disabled and a loader icon is displayed while waiting for the response from Server\r\n- Proposal info and SignOut are added into NavBar props (removed from login props), for displaying proposal info and logging out.\r\n- Login form can be submitted by pressing \"Sign In\" button or return key.\r\n- Login error msg from Server is displayed on the top in the errorNotification panel.\r\n  ","created_at":"2016-01-17T14:53:01Z","updated_at":"2016-01-18T08:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07d51655e54539fc05442071794f7c870ca2c353","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/96/commits","review_comments_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/96/comments","review_comment_url":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxcube/mxcube3/issues/96/comments","statuses_url":"https://api.github.com/repos/mxcube/mxcube3/statuses/58f45b13f9f08989129e78e2809292aaddd7b327","head":{"label":"JieNanMAXIV:master","ref":"master","sha":"58f45b13f9f08989129e78e2809292aaddd7b327","user":{"login":"JieNanMAXIV","id":14329743,"avatar_url":"https://avatars.githubusercontent.com/u/14329743?v=3","gravatar_id":"","url":"https://api.github.com/users/JieNanMAXIV","html_url":"https://github.com/JieNanMAXIV","followers_url":"https://api.github.com/users/JieNanMAXIV/followers","following_url":"https://api.github.com/users/JieNanMAXIV/following{/other_user}","gists_url":"https://api.github.com/users/JieNanMAXIV/gists{/gist_id}","starred_url":"https://api.github.com/users/JieNanMAXIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieNanMAXIV/subscriptions","organizations_url":"https://api.github.com/users/JieNanMAXIV/orgs","repos_url":"https://api.github.com/users/JieNanMAXIV/repos","events_url":"https://api.github.com/users/JieNanMAXIV/events{/privacy}","received_events_url":"https://api.github.com/users/JieNanMAXIV/received_events","type":"User","site_admin":false},"repo":{"id":49719452,"name":"mxcube3","full_name":"JieNanMAXIV/mxcube3","owner":{"login":"JieNanMAXIV","id":14329743,"avatar_url":"https://avatars.githubusercontent.com/u/14329743?v=3","gravatar_id":"","url":"https://api.github.com/users/JieNanMAXIV","html_url":"https://github.com/JieNanMAXIV","followers_url":"https://api.github.com/users/JieNanMAXIV/followers","following_url":"https://api.github.com/users/JieNanMAXIV/following{/other_user}","gists_url":"https://api.github.com/users/JieNanMAXIV/gists{/gist_id}","starred_url":"https://api.github.com/users/JieNanMAXIV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieNanMAXIV/subscriptions","organizations_url":"https://api.github.com/users/JieNanMAXIV/orgs","repos_url":"https://api.github.com/users/JieNanMAXIV/repos","events_url":"https://api.github.com/users/JieNanMAXIV/events{/privacy}","received_events_url":"https://api.github.com/users/JieNanMAXIV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JieNanMAXIV/mxcube3","description":"MXCuBE 3 (web)","fork":true,"url":"https://api.github.com/repos/JieNanMAXIV/mxcube3","forks_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/forks","keys_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/teams","hooks_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/hooks","issue_events_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/issues/events{/number}","events_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/events","assignees_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/assignees{/user}","branches_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/branches{/branch}","tags_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/tags","blobs_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/git/refs{/sha}","trees_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/statuses/{sha}","languages_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/languages","stargazers_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/stargazers","contributors_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/contributors","subscribers_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/subscribers","subscription_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/subscription","commits_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/commits{/sha}","git_commits_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/git/commits{/sha}","comments_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/comments{/number}","issue_comment_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/issues/comments{/number}","contents_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/contents/{+path}","compare_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/merges","archive_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/downloads","issues_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/issues{/number}","pulls_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/pulls{/number}","milestones_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/milestones{/number}","notifications_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/labels{/name}","releases_url":"https://api.github.com/repos/JieNanMAXIV/mxcube3/releases{/id}","created_at":"2016-01-15T13:10:25Z","updated_at":"2016-01-15T13:10:26Z","pushed_at":"2016-01-17T14:29:18Z","git_url":"git://github.com/JieNanMAXIV/mxcube3.git","ssh_url":"git@github.com:JieNanMAXIV/mxcube3.git","clone_url":"https://github.com/JieNanMAXIV/mxcube3.git","svn_url":"https://github.com/JieNanMAXIV/mxcube3","homepage":null,"size":2073,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxcube:master","ref":"master","sha":"5332601631c4623f3feaf0540cc089a4433a92c9","user":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars.githubusercontent.com/u/4322027?v=3","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"repo":{"id":42655839,"name":"mxcube3","full_name":"mxcube/mxcube3","owner":{"login":"mxcube","id":4322027,"avatar_url":"https://avatars.githubusercontent.com/u/4322027?v=3","gravatar_id":"","url":"https://api.github.com/users/mxcube","html_url":"https://github.com/mxcube","followers_url":"https://api.github.com/users/mxcube/followers","following_url":"https://api.github.com/users/mxcube/following{/other_user}","gists_url":"https://api.github.com/users/mxcube/gists{/gist_id}","starred_url":"https://api.github.com/users/mxcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxcube/subscriptions","organizations_url":"https://api.github.com/users/mxcube/orgs","repos_url":"https://api.github.com/users/mxcube/repos","events_url":"https://api.github.com/users/mxcube/events{/privacy}","received_events_url":"https://api.github.com/users/mxcube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mxcube/mxcube3","description":"MXCuBE 3 (web)","fork":false,"url":"https://api.github.com/repos/mxcube/mxcube3","forks_url":"https://api.github.com/repos/mxcube/mxcube3/forks","keys_url":"https://api.github.com/repos/mxcube/mxcube3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxcube/mxcube3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxcube/mxcube3/teams","hooks_url":"https://api.github.com/repos/mxcube/mxcube3/hooks","issue_events_url":"https://api.github.com/repos/mxcube/mxcube3/issues/events{/number}","events_url":"https://api.github.com/repos/mxcube/mxcube3/events","assignees_url":"https://api.github.com/repos/mxcube/mxcube3/assignees{/user}","branches_url":"https://api.github.com/repos/mxcube/mxcube3/branches{/branch}","tags_url":"https://api.github.com/repos/mxcube/mxcube3/tags","blobs_url":"https://api.github.com/repos/mxcube/mxcube3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxcube/mxcube3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxcube/mxcube3/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxcube/mxcube3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxcube/mxcube3/statuses/{sha}","languages_url":"https://api.github.com/repos/mxcube/mxcube3/languages","stargazers_url":"https://api.github.com/repos/mxcube/mxcube3/stargazers","contributors_url":"https://api.github.com/repos/mxcube/mxcube3/contributors","subscribers_url":"https://api.github.com/repos/mxcube/mxcube3/subscribers","subscription_url":"https://api.github.com/repos/mxcube/mxcube3/subscription","commits_url":"https://api.github.com/repos/mxcube/mxcube3/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxcube/mxcube3/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxcube/mxcube3/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxcube/mxcube3/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxcube/mxcube3/contents/{+path}","compare_url":"https://api.github.com/repos/mxcube/mxcube3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxcube/mxcube3/merges","archive_url":"https://api.github.com/repos/mxcube/mxcube3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxcube/mxcube3/downloads","issues_url":"https://api.github.com/repos/mxcube/mxcube3/issues{/number}","pulls_url":"https://api.github.com/repos/mxcube/mxcube3/pulls{/number}","milestones_url":"https://api.github.com/repos/mxcube/mxcube3/milestones{/number}","notifications_url":"https://api.github.com/repos/mxcube/mxcube3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxcube/mxcube3/labels{/name}","releases_url":"https://api.github.com/repos/mxcube/mxcube3/releases{/id}","created_at":"2015-09-17T12:47:34Z","updated_at":"2016-01-11T09:54:28Z","pushed_at":"2016-01-17T14:53:01Z","git_url":"git://github.com/mxcube/mxcube3.git","ssh_url":"git@github.com:mxcube/mxcube3.git","clone_url":"https://github.com/mxcube/mxcube3.git","svn_url":"https://github.com/mxcube/mxcube3","homepage":null,"size":2027,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":22,"forks":6,"open_issues":22,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/96"},"html":{"href":"https://github.com/mxcube/mxcube3/pull/96"},"issue":{"href":"https://api.github.com/repos/mxcube/mxcube3/issues/96"},"comments":{"href":"https://api.github.com/repos/mxcube/mxcube3/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxcube/mxcube3/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/mxcube/mxcube3/statuses/58f45b13f9f08989129e78e2809292aaddd7b327"}}}}