{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/88577949","pull_request_review_id":9148730,"id":88577949,"diff_hunk":"@@ -41,6 +49,62 @@ swift::_SwiftEmptyArrayStorage swift::_swiftEmptyArrayStorage = {\n   }\n };\n \n+\n+\n+swift::_SwiftEmptyDictionaryStorage swift::_swiftEmptyDictionaryStorage = {","path":"stdlib/public/stubs/GlobalObjects.cpp","position":21,"original_position":21,"commit_id":"cf6767a0225108c28c0ff194e14db892bb31e5dc","original_commit_id":"cf6767a0225108c28c0ff194e14db892bb31e5dc","user":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"body":"Want me to do that to the existing Array decl too?","created_at":"2016-11-18T00:27:25Z","updated_at":"2016-11-18T00:27:25Z","html_url":"https://github.com/apple/swift/pull/5850#discussion_r88577949","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/5850","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/88577949"},"html":{"href":"https://github.com/apple/swift/pull/5850#discussion_r88577949"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/5850"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5850","id":94278988,"html_url":"https://github.com/apple/swift/pull/5850","diff_url":"https://github.com/apple/swift/pull/5850.diff","patch_url":"https://github.com/apple/swift/pull/5850.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5850","number":5850,"state":"open","locked":false,"title":"[runtime] move the empty Dictionary and Set singletons to rodata","user":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"body":"Basically just a mirror of what Array does. \r\n\r\nResolves rdar://18220063","created_at":"2016-11-18T00:10:54Z","updated_at":"2016-11-18T00:27:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c9d17ac4720eda72359940ceb3e934d4eb5ccb2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5850/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5850/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5850/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/cf6767a0225108c28c0ff194e14db892bb31e5dc","head":{"label":"Gankro:empty","ref":"empty","sha":"cf6767a0225108c28c0ff194e14db892bb31e5dc","user":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"repo":{"id":68046246,"name":"swift","full_name":"Gankro/swift","owner":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gankro/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/Gankro/swift","forks_url":"https://api.github.com/repos/Gankro/swift/forks","keys_url":"https://api.github.com/repos/Gankro/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gankro/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gankro/swift/teams","hooks_url":"https://api.github.com/repos/Gankro/swift/hooks","issue_events_url":"https://api.github.com/repos/Gankro/swift/issues/events{/number}","events_url":"https://api.github.com/repos/Gankro/swift/events","assignees_url":"https://api.github.com/repos/Gankro/swift/assignees{/user}","branches_url":"https://api.github.com/repos/Gankro/swift/branches{/branch}","tags_url":"https://api.github.com/repos/Gankro/swift/tags","blobs_url":"https://api.github.com/repos/Gankro/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gankro/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gankro/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gankro/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gankro/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/Gankro/swift/languages","stargazers_url":"https://api.github.com/repos/Gankro/swift/stargazers","contributors_url":"https://api.github.com/repos/Gankro/swift/contributors","subscribers_url":"https://api.github.com/repos/Gankro/swift/subscribers","subscription_url":"https://api.github.com/repos/Gankro/swift/subscription","commits_url":"https://api.github.com/repos/Gankro/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gankro/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gankro/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gankro/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gankro/swift/contents/{+path}","compare_url":"https://api.github.com/repos/Gankro/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gankro/swift/merges","archive_url":"https://api.github.com/repos/Gankro/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gankro/swift/downloads","issues_url":"https://api.github.com/repos/Gankro/swift/issues{/number}","pulls_url":"https://api.github.com/repos/Gankro/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/Gankro/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/Gankro/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gankro/swift/labels{/name}","releases_url":"https://api.github.com/repos/Gankro/swift/releases{/id}","deployments_url":"https://api.github.com/repos/Gankro/swift/deployments","created_at":"2016-09-12T20:45:50Z","updated_at":"2016-11-12T20:23:53Z","pushed_at":"2016-11-18T00:07:19Z","git_url":"git://github.com/Gankro/swift.git","ssh_url":"git@github.com:Gankro/swift.git","clone_url":"https://github.com/Gankro/swift.git","svn_url":"https://github.com/Gankro/swift","homepage":"https://swift.org/","size":130398,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d7753f6f41b2d62e1da36543e4d8d5150db4ea56","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-11-17T23:14:58Z","pushed_at":"2016-11-18T00:24:22Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":198782,"stargazers_count":35187,"watchers_count":35187,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5064,"mirror_url":null,"open_issues_count":118,"forks":5064,"open_issues":118,"watchers":35187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5850"},"html":{"href":"https://github.com/apple/swift/pull/5850"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5850"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5850/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5850/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5850/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/cf6767a0225108c28c0ff194e14db892bb31e5dc"}}}}
{"actor":{"display_login":"Gankro"}}