{"action":"created","comment":{"url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/comments/70758698","id":70758698,"diff_hunk":"@@ -167,8 +163,7 @@ protected String encrypt(String value, Cipher writer) throws SecurePreferencesEx\n \t\tcatch (UnsupportedEncodingException e) {\n \t\t\tthrow new SecurePreferencesException(e);\n \t\t}\n-\t\tString secureValueEncoded = Base64.encodeToString(secureValue, Base64.NO_WRAP);\n-\t\treturn secureValueEncoded;\n+\t\treturn Base64.encodeToString(secureValue, Base64.NO_WRAP);","path":"src/SecurePreferences.java","position":74,"original_position":74,"commit_id":"19eb2c09120e75b1f506075688081abfab7ead99","original_commit_id":"19eb2c09120e75b1f506075688081abfab7ead99","user":{"login":"Xmashine","id":18101935,"avatar_url":"https://avatars.githubusercontent.com/u/18101935?v=3","gravatar_id":"","url":"https://api.github.com/users/Xmashine","html_url":"https://github.com/Xmashine","followers_url":"https://api.github.com/users/Xmashine/followers","following_url":"https://api.github.com/users/Xmashine/following{/other_user}","gists_url":"https://api.github.com/users/Xmashine/gists{/gist_id}","starred_url":"https://api.github.com/users/Xmashine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xmashine/subscriptions","organizations_url":"https://api.github.com/users/Xmashine/orgs","repos_url":"https://api.github.com/users/Xmashine/repos","events_url":"https://api.github.com/users/Xmashine/events{/privacy}","received_events_url":"https://api.github.com/users/Xmashine/received_events","type":"User","site_admin":false},"body":"Simplified code to improve performances.","created_at":"2016-07-14T07:18:40Z","updated_at":"2016-07-14T07:18:40Z","html_url":"https://github.com/sveinungkb/encrypted-userprefs/pull/4#discussion_r70758698","pull_request_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/comments/70758698"},"html":{"href":"https://github.com/sveinungkb/encrypted-userprefs/pull/4#discussion_r70758698"},"pull_request":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4","id":77376863,"html_url":"https://github.com/sveinungkb/encrypted-userprefs/pull/4","diff_url":"https://github.com/sveinungkb/encrypted-userprefs/pull/4.diff","patch_url":"https://github.com/sveinungkb/encrypted-userprefs/pull/4.patch","issue_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues/4","number":4,"state":"open","locked":false,"title":"Fixed some bugs and improved performances","user":{"login":"Xmashine","id":18101935,"avatar_url":"https://avatars.githubusercontent.com/u/18101935?v=3","gravatar_id":"","url":"https://api.github.com/users/Xmashine","html_url":"https://github.com/Xmashine","followers_url":"https://api.github.com/users/Xmashine/followers","following_url":"https://api.github.com/users/Xmashine/following{/other_user}","gists_url":"https://api.github.com/users/Xmashine/gists{/gist_id}","starred_url":"https://api.github.com/users/Xmashine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xmashine/subscriptions","organizations_url":"https://api.github.com/users/Xmashine/orgs","repos_url":"https://api.github.com/users/Xmashine/repos","events_url":"https://api.github.com/users/Xmashine/events{/privacy}","received_events_url":"https://api.github.com/users/Xmashine/received_events","type":"User","site_admin":false},"body":"### Minor improvements and bug fixes\r\n```java\r\n.commit(); -> .apply();\r\ndeleted static byte[] voids because Innit classes cannot have static declaration\r\ncollapsed some double catch { ...\r\nimproved code to be safest and fastest\r\n```","created_at":"2016-07-13T23:09:25Z","updated_at":"2016-07-14T07:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e78526971029ab4e8a1df9bfc31352007dbe756","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4/commits","review_comments_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4/comments","review_comment_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues/4/comments","statuses_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/statuses/19eb2c09120e75b1f506075688081abfab7ead99","head":{"label":"Xmashine:patch-1","ref":"patch-1","sha":"19eb2c09120e75b1f506075688081abfab7ead99","user":{"login":"Xmashine","id":18101935,"avatar_url":"https://avatars.githubusercontent.com/u/18101935?v=3","gravatar_id":"","url":"https://api.github.com/users/Xmashine","html_url":"https://github.com/Xmashine","followers_url":"https://api.github.com/users/Xmashine/followers","following_url":"https://api.github.com/users/Xmashine/following{/other_user}","gists_url":"https://api.github.com/users/Xmashine/gists{/gist_id}","starred_url":"https://api.github.com/users/Xmashine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xmashine/subscriptions","organizations_url":"https://api.github.com/users/Xmashine/orgs","repos_url":"https://api.github.com/users/Xmashine/repos","events_url":"https://api.github.com/users/Xmashine/events{/privacy}","received_events_url":"https://api.github.com/users/Xmashine/received_events","type":"User","site_admin":false},"repo":{"id":63285116,"name":"encrypted-userprefs","full_name":"Xmashine/encrypted-userprefs","owner":{"login":"Xmashine","id":18101935,"avatar_url":"https://avatars.githubusercontent.com/u/18101935?v=3","gravatar_id":"","url":"https://api.github.com/users/Xmashine","html_url":"https://github.com/Xmashine","followers_url":"https://api.github.com/users/Xmashine/followers","following_url":"https://api.github.com/users/Xmashine/following{/other_user}","gists_url":"https://api.github.com/users/Xmashine/gists{/gist_id}","starred_url":"https://api.github.com/users/Xmashine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xmashine/subscriptions","organizations_url":"https://api.github.com/users/Xmashine/orgs","repos_url":"https://api.github.com/users/Xmashine/repos","events_url":"https://api.github.com/users/Xmashine/events{/privacy}","received_events_url":"https://api.github.com/users/Xmashine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Xmashine/encrypted-userprefs","description":"A slightly less insecure wrapper for SharedUserPreferences for Android. Keys and values encrypted using a symmetric cipher.","fork":true,"url":"https://api.github.com/repos/Xmashine/encrypted-userprefs","forks_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/forks","keys_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/teams","hooks_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/hooks","issue_events_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/issues/events{/number}","events_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/events","assignees_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/assignees{/user}","branches_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/branches{/branch}","tags_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/tags","blobs_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/statuses/{sha}","languages_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/languages","stargazers_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/stargazers","contributors_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/contributors","subscribers_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/subscribers","subscription_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/subscription","commits_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/contents/{+path}","compare_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/merges","archive_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/downloads","issues_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/issues{/number}","pulls_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/pulls{/number}","milestones_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/milestones{/number}","notifications_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/labels{/name}","releases_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/releases{/id}","deployments_url":"https://api.github.com/repos/Xmashine/encrypted-userprefs/deployments","created_at":"2016-07-13T23:00:22Z","updated_at":"2016-07-13T23:00:23Z","pushed_at":"2016-07-13T23:06:45Z","git_url":"git://github.com/Xmashine/encrypted-userprefs.git","ssh_url":"git@github.com:Xmashine/encrypted-userprefs.git","clone_url":"https://github.com/Xmashine/encrypted-userprefs.git","svn_url":"https://github.com/Xmashine/encrypted-userprefs","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sveinungkb:master","ref":"master","sha":"4be00c6c3f6a067b7c3cd534f0232f57434a9da6","user":{"login":"sveinungkb","id":526922,"avatar_url":"https://avatars.githubusercontent.com/u/526922?v=3","gravatar_id":"","url":"https://api.github.com/users/sveinungkb","html_url":"https://github.com/sveinungkb","followers_url":"https://api.github.com/users/sveinungkb/followers","following_url":"https://api.github.com/users/sveinungkb/following{/other_user}","gists_url":"https://api.github.com/users/sveinungkb/gists{/gist_id}","starred_url":"https://api.github.com/users/sveinungkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveinungkb/subscriptions","organizations_url":"https://api.github.com/users/sveinungkb/orgs","repos_url":"https://api.github.com/users/sveinungkb/repos","events_url":"https://api.github.com/users/sveinungkb/events{/privacy}","received_events_url":"https://api.github.com/users/sveinungkb/received_events","type":"User","site_admin":false},"repo":{"id":4390276,"name":"encrypted-userprefs","full_name":"sveinungkb/encrypted-userprefs","owner":{"login":"sveinungkb","id":526922,"avatar_url":"https://avatars.githubusercontent.com/u/526922?v=3","gravatar_id":"","url":"https://api.github.com/users/sveinungkb","html_url":"https://github.com/sveinungkb","followers_url":"https://api.github.com/users/sveinungkb/followers","following_url":"https://api.github.com/users/sveinungkb/following{/other_user}","gists_url":"https://api.github.com/users/sveinungkb/gists{/gist_id}","starred_url":"https://api.github.com/users/sveinungkb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sveinungkb/subscriptions","organizations_url":"https://api.github.com/users/sveinungkb/orgs","repos_url":"https://api.github.com/users/sveinungkb/repos","events_url":"https://api.github.com/users/sveinungkb/events{/privacy}","received_events_url":"https://api.github.com/users/sveinungkb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sveinungkb/encrypted-userprefs","description":"A slightly less insecure wrapper for SharedUserPreferences for Android. Keys and values encrypted using a symmetric cipher.","fork":false,"url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs","forks_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/forks","keys_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/teams","hooks_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/hooks","issue_events_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues/events{/number}","events_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/events","assignees_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/assignees{/user}","branches_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/branches{/branch}","tags_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/tags","blobs_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/statuses/{sha}","languages_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/languages","stargazers_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/stargazers","contributors_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/contributors","subscribers_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/subscribers","subscription_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/subscription","commits_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/contents/{+path}","compare_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/merges","archive_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/downloads","issues_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues{/number}","pulls_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls{/number}","milestones_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/milestones{/number}","notifications_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/labels{/name}","releases_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/releases{/id}","deployments_url":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/deployments","created_at":"2012-05-21T05:35:58Z","updated_at":"2016-07-13T19:07:07Z","pushed_at":"2016-07-13T23:09:25Z","git_url":"git://github.com/sveinungkb/encrypted-userprefs.git","ssh_url":"git@github.com:sveinungkb/encrypted-userprefs.git","clone_url":"https://github.com/sveinungkb/encrypted-userprefs.git","svn_url":"https://github.com/sveinungkb/encrypted-userprefs","homepage":null,"size":114,"stargazers_count":180,"watchers_count":180,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":4,"forks":54,"open_issues":4,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4"},"html":{"href":"https://github.com/sveinungkb/encrypted-userprefs/pull/4"},"issue":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues/4"},"comments":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/sveinungkb/encrypted-userprefs/statuses/19eb2c09120e75b1f506075688081abfab7ead99"}}}}
{"actor":{"display_login":"Xmashine"}}