{"action":"created","issue":{"url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/345","repository_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp","labels_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/345/comments","events_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/345/events","html_url":"https://github.com/simplesamlphp/simplesamlphp/pull/345","id":139378256,"number":345,"title":"Changes for PHP 7.","user":{"login":"brentboghosian","id":4840249,"avatar_url":"https://avatars.githubusercontent.com/u/4840249?v=3","gravatar_id":"","url":"https://api.github.com/users/brentboghosian","html_url":"https://github.com/brentboghosian","followers_url":"https://api.github.com/users/brentboghosian/followers","following_url":"https://api.github.com/users/brentboghosian/following{/other_user}","gists_url":"https://api.github.com/users/brentboghosian/gists{/gist_id}","starred_url":"https://api.github.com/users/brentboghosian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentboghosian/subscriptions","organizations_url":"https://api.github.com/users/brentboghosian/orgs","repos_url":"https://api.github.com/users/brentboghosian/repos","events_url":"https://api.github.com/users/brentboghosian/events{/privacy}","received_events_url":"https://api.github.com/users/brentboghosian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-08T19:59:42Z","updated_at":"2016-03-08T21:27:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/pulls/345","html_url":"https://github.com/simplesamlphp/simplesamlphp/pull/345","diff_url":"https://github.com/simplesamlphp/simplesamlphp/pull/345.diff","patch_url":"https://github.com/simplesamlphp/simplesamlphp/pull/345.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/comments/193975214","html_url":"https://github.com/simplesamlphp/simplesamlphp/pull/345#issuecomment-193975214","issue_url":"https://api.github.com/repos/simplesamlphp/simplesamlphp/issues/345","id":193975214,"user":{"login":"brentboghosian","id":4840249,"avatar_url":"https://avatars.githubusercontent.com/u/4840249?v=3","gravatar_id":"","url":"https://api.github.com/users/brentboghosian","html_url":"https://github.com/brentboghosian","followers_url":"https://api.github.com/users/brentboghosian/followers","following_url":"https://api.github.com/users/brentboghosian/following{/other_user}","gists_url":"https://api.github.com/users/brentboghosian/gists{/gist_id}","starred_url":"https://api.github.com/users/brentboghosian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentboghosian/subscriptions","organizations_url":"https://api.github.com/users/brentboghosian/orgs","repos_url":"https://api.github.com/users/brentboghosian/repos","events_url":"https://api.github.com/users/brentboghosian/events{/privacy}","received_events_url":"https://api.github.com/users/brentboghosian/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T21:27:20Z","updated_at":"2016-03-08T21:27:20Z","body":"On Tue, Mar 8, 2016 at 3:11 PM, Thijs Kinkhorst <notifications@github.com>\nwrote:\n\n> Hi Brent, thanks! About the change for set_magic_quotes_runtime(), I'm not\n> sure that's right. According to the documentation, in PHP 5.3.x this\n> function is still relevant, so I don't think it should only be invoked when\n> the PHP version < 5.3. Also, in PHP 7 get_magic_quotes_runtime is still\n> there but will always return false, so why is the extra wrap with\n> version_compare necessary?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/simplesamlphp/simplesamlphp/pull/345#issuecomment-193948259>\n> .\n>\nVery good point.\nWould you like me to remove that change and resubmit the pull request,\nwithout it?\n\nCheers!\n-- \n\nBrent Boghosian           brent.boghosian@remote-learner.net\nLead Software Architect   http://www.remote-learner.net/\n519-772-3910 x176         Open Source * Moodle Hosting/Development\n"}}