{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/activity-streams/pulls/comments/57101720","id":57101720,"diff_hunk":"@@ -150,6 +154,47 @@ exports.test_TabTracker_reactivating = function*(assert) {\n   }\n };\n \n+exports.test_TabTracker_latency = function*(assert) {\n+  let pingData;\n+  let tabClosedPromise = new Promise(resolve => {\n+    let onOpen = function(tab) {\n+      function onPageLoaded() {\n+        Services.obs.removeObserver(onPageLoaded, \"performance-log-complete\");\n+        setTimeout(function() {\n+          tab.close(() => {\n+            tabs.removeListener(\"pageshow\", onOpen);\n+          });\n+        }, 10);\n+      }\n+      Services.obs.addObserver(onPageLoaded, \"performance-log-complete\");\n+    };\n+\n+    tabs.on(\"pageshow\", onOpen);\n+\n+    let Observer = {","path":"test/test-TabTracker.js","position":32,"original_position":32,"commit_id":"eb66fc871614af0885c42382cda768c86a23dcd4","original_commit_id":"eb66fc871614af0885c42382cda768c86a23dcd4","user":{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false},"body":"nit: please use the function parameter for observers. it is more concise","created_at":"2016-03-23T02:27:05Z","updated_at":"2016-03-23T02:27:05Z","html_url":"https://github.com/mozilla/activity-streams/pull/341#discussion_r57101720","pull_request_url":"https://api.github.com/repos/mozilla/activity-streams/pulls/341","_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-streams/pulls/comments/57101720"},"html":{"href":"https://github.com/mozilla/activity-streams/pull/341#discussion_r57101720"},"pull_request":{"href":"https://api.github.com/repos/mozilla/activity-streams/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-streams/pulls/341","id":63629863,"html_url":"https://github.com/mozilla/activity-streams/pull/341","diff_url":"https://github.com/mozilla/activity-streams/pull/341.diff","patch_url":"https://github.com/mozilla/activity-streams/pull/341.patch","issue_url":"https://api.github.com/repos/mozilla/activity-streams/issues/341","number":341,"state":"open","locked":false,"title":"Closes #308 - Add load latency to telemetry ping","user":{"login":"mzhilyaev","id":999285,"avatar_url":"https://avatars.githubusercontent.com/u/999285?v=3","gravatar_id":"","url":"https://api.github.com/users/mzhilyaev","html_url":"https://github.com/mzhilyaev","followers_url":"https://api.github.com/users/mzhilyaev/followers","following_url":"https://api.github.com/users/mzhilyaev/following{/other_user}","gists_url":"https://api.github.com/users/mzhilyaev/gists{/gist_id}","starred_url":"https://api.github.com/users/mzhilyaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzhilyaev/subscriptions","organizations_url":"https://api.github.com/users/mzhilyaev/orgs","repos_url":"https://api.github.com/users/mzhilyaev/repos","events_url":"https://api.github.com/users/mzhilyaev/events{/privacy}","received_events_url":"https://api.github.com/users/mzhilyaev/received_events","type":"User","site_admin":false},"body":"Fixes #308 ","created_at":"2016-03-21T20:49:10Z","updated_at":"2016-03-23T02:27:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a48da3d4ef52b5c84a9bf985bfae85716f5859","assignee":{"login":"emtwo","id":784781,"avatar_url":"https://avatars.githubusercontent.com/u/784781?v=3","gravatar_id":"","url":"https://api.github.com/users/emtwo","html_url":"https://github.com/emtwo","followers_url":"https://api.github.com/users/emtwo/followers","following_url":"https://api.github.com/users/emtwo/following{/other_user}","gists_url":"https://api.github.com/users/emtwo/gists{/gist_id}","starred_url":"https://api.github.com/users/emtwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emtwo/subscriptions","organizations_url":"https://api.github.com/users/emtwo/orgs","repos_url":"https://api.github.com/users/emtwo/repos","events_url":"https://api.github.com/users/emtwo/events{/privacy}","received_events_url":"https://api.github.com/users/emtwo/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-streams/pulls/341/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-streams/pulls/341/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-streams/issues/341/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-streams/statuses/eb66fc871614af0885c42382cda768c86a23dcd4","head":{"label":"mozilla:Bug308-LatencyPing","ref":"Bug308-LatencyPing","sha":"eb66fc871614af0885c42382cda768c86a23dcd4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-streams","full_name":"mozilla/activity-streams","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-streams","description":" MVP prototype add-on for activity streams","fork":false,"url":"https://api.github.com/repos/mozilla/activity-streams","forks_url":"https://api.github.com/repos/mozilla/activity-streams/forks","keys_url":"https://api.github.com/repos/mozilla/activity-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-streams/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-streams/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-streams/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-streams/events","assignees_url":"https://api.github.com/repos/mozilla/activity-streams/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-streams/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-streams/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-streams/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-streams/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-streams/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-streams/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-streams/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-streams/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-streams/merges","archive_url":"https://api.github.com/repos/mozilla/activity-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-streams/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-streams/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-streams/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-streams/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-streams/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2016-03-18T22:26:10Z","pushed_at":"2016-03-22T21:19:21Z","git_url":"git://github.com/mozilla/activity-streams.git","ssh_url":"git@github.com:mozilla/activity-streams.git","clone_url":"https://github.com/mozilla/activity-streams.git","svn_url":"https://github.com/mozilla/activity-streams","homepage":"","size":537,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":82,"forks":7,"open_issues":82,"watchers":12,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"96e3523f3e30c8f72f60b463336361ccaeae0cfb","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-streams","full_name":"mozilla/activity-streams","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-streams","description":" MVP prototype add-on for activity streams","fork":false,"url":"https://api.github.com/repos/mozilla/activity-streams","forks_url":"https://api.github.com/repos/mozilla/activity-streams/forks","keys_url":"https://api.github.com/repos/mozilla/activity-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-streams/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-streams/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-streams/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-streams/events","assignees_url":"https://api.github.com/repos/mozilla/activity-streams/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-streams/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-streams/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-streams/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-streams/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-streams/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-streams/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-streams/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-streams/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-streams/merges","archive_url":"https://api.github.com/repos/mozilla/activity-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-streams/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-streams/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-streams/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-streams/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-streams/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2016-03-18T22:26:10Z","pushed_at":"2016-03-22T21:19:21Z","git_url":"git://github.com/mozilla/activity-streams.git","ssh_url":"git@github.com:mozilla/activity-streams.git","clone_url":"https://github.com/mozilla/activity-streams.git","svn_url":"https://github.com/mozilla/activity-streams","homepage":"","size":537,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":82,"forks":7,"open_issues":82,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-streams/pulls/341"},"html":{"href":"https://github.com/mozilla/activity-streams/pull/341"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-streams/issues/341"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-streams/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-streams/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-streams/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-streams/statuses/eb66fc871614af0885c42382cda768c86a23dcd4"}}}}