{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/69175690","id":69175690,"diff_hunk":"@@ -1,10 +1,132 @@\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <Project ToolsVersion=\"14.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n-    \n-    <UsingTask TaskName=\"PkgTargets\" AssemblyFile=\"$(CLIBuildDll)\" />\n+    <UsingTask TaskName=\"ReplaceFileContents\" AssemblyFile=\"$(CLIBuildDll)\" />\n+  \n+    <Target Name=\"SetupPkgInputsOutputs\">\n+      <PropertyGroup>\n+        <InstallerOutputDirectory>$(PackagesDirectory)</InstallerOutputDirectory>\n+        <PkgIntermediateDirectory>$(IntermediateDirectory)/pkgs/$(SdkVersion)</PkgIntermediateDirectory>\n \n-    <Target Name=\"GeneratePkgs\" >\n-        <PkgTargets />\n+        <SdkInstallerFile>$(InstallerOutputDirectory)/$(ArtifactNameWithVersionSdk)$(InstallerExtension)</SdkInstallerFile>\n+        <CombinedFrameworkSdkHostInstallerFile>$(InstallerOutputDirectory)/$(ArtifactNameWithVersionCombinedHostHostFxrFrameworkSdk)$(BundleExtension)</CombinedFrameworkSdkHostInstallerFile>\n+\n+        <!-- Rename is intentional to reduce confusion over generated vs downloaded pkg's -->\n+        <DownloadedSharedFrameworkInstallerFile>$(SharedFrameworkInstallerFile)</DownloadedSharedFrameworkInstallerFile> \n+        <DownloadedHostFxrInstallerFile>$(HostFxrInstallerFile)</DownloadedHostFxrInstallerFile>\n+        <DownloadedSharedHostInstallerFile>$(SharedHostInstallerFile)</DownloadedSharedHostInstallerFile>\n+        \n+        <!-- Properties for pkg build -->\n+        <SharedHostComponentId>com.microsoft.dotnet.sharedhost.component.osx.x64</SharedHostComponentId>\n+        <HostFxrComponentId>com.microsoft.dotnet.hostfxr.component.osx.x64</HostFxrComponentId>\n+        <SharedFrameworkComponentId>com.microsoft.dotnet.sharedframework.$(SharedFrameworkNugetName).$(SharedFrameworkVersion).component.osx.x64</SharedFrameworkComponentId>\n+        <SdkComponentId>com.microsoft.dotnet.dev.$(SdkVersion).component.osx.x64</SdkComponentId>\n+        <SdkProductArchiveId>com.microsoft.dotnet.dev.$(SdkVersion).osx.x64</SdkProductArchiveId>\n+        \n+        <PkgInstallDirectory>/usr/local/share/dotnet</PkgInstallDirectory>\n+\n+        <SdkPkgScriptsDirectory>$(RepoRoot)/packaging/osx/clisdk/scripts</SdkPkgScriptsDirectory>\n+        <SdkProductArchiveResourcesDirectory>$(RepoRoot)/packaging/osx/clisdk/resources</SdkProductArchiveResourcesDirectory>\n+        \n+        <SdkProductArchiveDistributionTemplateFile>$(RepoRoot)/packaging/osx/clisdk/Distribution-Template</SdkProductArchiveDistributionTemplateFile>\n+        <SdkProductArchiveDistributionFile>$(PkgIntermediateDirectory)/CLI-SDK-Formatted-Distribution-Template.xml</SdkProductArchiveDistributionFile>\n+        \n+        <SdkPkgIntermediatePath>$(PkgIntermediateDirectory)/$(SdkComponentId).pkg</SdkPkgIntermediatePath>\n+        <SharedFrameworkPkgIntermediatePath>$(PkgIntermediateDirectory)/$(SharedFrameworkComponentId).pkg</SharedFrameworkPkgIntermediatePath>\n+        <SharedHostPkgIntermediatePath>$(PkgIntermediateDirectory)/$(SharedHostComponentId).pkg</SharedHostPkgIntermediatePath>\n+        <HostFxrPkgIntermediatePath>$(PkgIntermediateDirectory)/$(HostFxrComponentId).pkg</HostFxrPkgIntermediatePath>\n+      </PropertyGroup>\n+\n+      <ItemGroup>\n+        <DistributionTemplateReplacement Include=\"{SharedFxComponentId}\">\n+          <ReplacementString>$(SharedFrameworkComponentId)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{SharedHostComponentId}\">\n+          <ReplacementString>$(SharedHostComponentId)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{HostFxrComponentId}\">\n+          <ReplacementString>$(HostFxrComponentId)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{CLISdkComponentId}\">\n+          <ReplacementString>$(SdkComponentId)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{CLISdkNugetVersion}\">\n+          <ReplacementString>$(SdkVersion)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{CLISdkBrandName}\">\n+          <ReplacementString>$(SdkBrandName)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{SharedFxBrandName}\">\n+          <ReplacementString>$(SharedFrameworkBrandName)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{SharedHostBrandName}\">\n+          <ReplacementString>$(SharedHostBrandName)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+        <DistributionTemplateReplacement Include=\"{HostFxrBrandName}\">\n+          <ReplacementString>$(HostFxrBrandName)</ReplacementString>\n+        </DistributionTemplateReplacement>\n+      </ItemGroup>\n+\n+      <!-- Consumed By Publish -->\n+      <ItemGroup>\n+        <GeneratedInstallers Include=\"$(SdkInstallerFile);$(CombinedFrameworkSdkHostInstallerFile)\" />\n+      </ItemGroup>\n     </Target>\n \n+    <Target Name=\"GenerateSdkPkg\" \n+            Inputs=\"$(SdkLayoutOutputDirectory);\"\n+            Outputs=\"$(SdkInstallerFile)\"\n+            DependsOnTargets=\"Init;Layout;SetupPkgInputsOutputs\"\n+            Condition=\" '%(OSName)' == 'osx' \">\n+      \n+      <Exec Command=\"pkgbuild\n+                     --root '$(SdkLayoutOutputDirectory)'\n+                     --identifier '$(SdkComponentId)'\n+                     --version '$(SdkVersion)'\n+                     --install-location '$(PkgInstallDirectory)'\n+                     --scripts '$(SdkPkgScriptsDirectory)'\n+                     '$(SdkInstallerFile)'\" />\n+    </Target>\n+\n+    <Target Name=\"GenerateSdkProductArchive\"\n+            Inputs=\"$(SdkInstallerFile);\n+                    $(DownloadedSharedFrameworkInstallerFile);\n+                    $(DownloadedHostFxrInstallerFile);\n+                    $(DownloadedSharedHostInstallerFile)\"\n+            DependsOnTargets=\"Init;Layout;SetupPkgInputsOutputs;GenerateSdkPkg\"","path":"build/package/Microsoft.DotNet.Cli.Installer.PKG.targets","position":99,"original_position":99,"commit_id":"28feb9bdb3220e9b687d320840bd42f9390213de","original_commit_id":"28feb9bdb3220e9b687d320840bd42f9390213de","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"I don't think we need to list every single DependsOnTarget do we?  This target depends on GenerateSdkPkg, which depends on the first 3.  So why list the first 3 again here?","created_at":"2016-06-30T17:34:13Z","updated_at":"2016-06-30T17:34:13Z","html_url":"https://github.com/dotnet/cli/pull/3738#discussion_r69175690","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/3738","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/69175690"},"html":{"href":"https://github.com/dotnet/cli/pull/3738#discussion_r69175690"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3738"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/3738","id":75750409,"html_url":"https://github.com/dotnet/cli/pull/3738","diff_url":"https://github.com/dotnet/cli/pull/3738.diff","patch_url":"https://github.com/dotnet/cli/pull/3738.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/3738","number":3738,"state":"open","locked":false,"title":"[WIP] MSBuild Deb + Pkg Targets","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"body":"Throwing up early. Deb targets will incoming. \r\n\r\n@eerhardt @piotrpMSFT @livarcocc @sokket ","created_at":"2016-06-30T02:12:12Z","updated_at":"2016-06-30T17:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec643c3824fa2d0a28f4b61e20d0664ddd47015c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/3738/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/3738/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/3738/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/28feb9bdb3220e9b687d320840bd42f9390213de","head":{"label":"brthor:brthor/deb-pkg-targets","ref":"brthor/deb-pkg-targets","sha":"28feb9bdb3220e9b687d320840bd42f9390213de","user":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"repo":{"id":46514660,"name":"cli","full_name":"brthor/cli","owner":{"login":"brthor","id":14280892,"avatar_url":"https://avatars.githubusercontent.com/u/14280892?v=3","gravatar_id":"","url":"https://api.github.com/users/brthor","html_url":"https://github.com/brthor","followers_url":"https://api.github.com/users/brthor/followers","following_url":"https://api.github.com/users/brthor/following{/other_user}","gists_url":"https://api.github.com/users/brthor/gists{/gist_id}","starred_url":"https://api.github.com/users/brthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brthor/subscriptions","organizations_url":"https://api.github.com/users/brthor/orgs","repos_url":"https://api.github.com/users/brthor/repos","events_url":"https://api.github.com/users/brthor/events{/privacy}","received_events_url":"https://api.github.com/users/brthor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brthor/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/brthor/cli","forks_url":"https://api.github.com/repos/brthor/cli/forks","keys_url":"https://api.github.com/repos/brthor/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brthor/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brthor/cli/teams","hooks_url":"https://api.github.com/repos/brthor/cli/hooks","issue_events_url":"https://api.github.com/repos/brthor/cli/issues/events{/number}","events_url":"https://api.github.com/repos/brthor/cli/events","assignees_url":"https://api.github.com/repos/brthor/cli/assignees{/user}","branches_url":"https://api.github.com/repos/brthor/cli/branches{/branch}","tags_url":"https://api.github.com/repos/brthor/cli/tags","blobs_url":"https://api.github.com/repos/brthor/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brthor/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brthor/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/brthor/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brthor/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/brthor/cli/languages","stargazers_url":"https://api.github.com/repos/brthor/cli/stargazers","contributors_url":"https://api.github.com/repos/brthor/cli/contributors","subscribers_url":"https://api.github.com/repos/brthor/cli/subscribers","subscription_url":"https://api.github.com/repos/brthor/cli/subscription","commits_url":"https://api.github.com/repos/brthor/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/brthor/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/brthor/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/brthor/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/brthor/cli/contents/{+path}","compare_url":"https://api.github.com/repos/brthor/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brthor/cli/merges","archive_url":"https://api.github.com/repos/brthor/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brthor/cli/downloads","issues_url":"https://api.github.com/repos/brthor/cli/issues{/number}","pulls_url":"https://api.github.com/repos/brthor/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/brthor/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/brthor/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brthor/cli/labels{/name}","releases_url":"https://api.github.com/repos/brthor/cli/releases{/id}","deployments_url":"https://api.github.com/repos/brthor/cli/deployments","created_at":"2015-11-19T19:17:23Z","updated_at":"2016-06-01T22:27:26Z","pushed_at":"2016-06-30T02:11:39Z","git_url":"git://github.com/brthor/cli.git","ssh_url":"git@github.com:brthor/cli.git","clone_url":"https://github.com/brthor/cli.git","svn_url":"https://github.com/brthor/cli","homepage":"http://dotnet.github.io/","size":103249,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:feature/msbuild","ref":"feature/msbuild","sha":"7b7251222f9af9d7133ba2398a69f5fe69e9728d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-06-30T15:00:38Z","pushed_at":"2016-06-30T17:04:44Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"http://dot.net/","size":118129,"stargazers_count":1224,"watchers_count":1224,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":283,"mirror_url":null,"open_issues_count":859,"forks":283,"open_issues":859,"watchers":1224,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3738"},"html":{"href":"https://github.com/dotnet/cli/pull/3738"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/3738"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/3738/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3738/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/3738/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/28feb9bdb3220e9b687d320840bd42f9390213de"}}}}
{"actor":{"display_login":"eerhardt"}}