{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2160","repository_url":"https://api.github.com/repos/magnumripper/JohnTheRipper","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2160/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2160/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2160/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2160","id":162508635,"number":2160,"title":"Pot lines longer than 1024 bytes smashes stack or buffers in some cases.","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"assignees":[{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2","html_url":"https://github.com/magnumripper/JohnTheRipper/milestones/1.8.0-jumbo-2","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/milestones/2/labels","id":492145,"number":2,"title":"1.8.0-jumbo-2","description":"Please assign ALL issues which should be in J2 to this milestone, and lets push forward in fixing all of them.","creator":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":266,"state":"open","created_at":"2013-11-21T06:59:25Z","updated_at":"2016-07-06T18:46:39Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-06-27T17:46:53Z","updated_at":"2016-07-08T12:05:13Z","closed_at":null,"body":"We need to protect ourselves from old pot lines from when LINE_BUFFER_SIZE was 0x30000. I believe the problem is already limited to just a few combinations of memory-map, node/fork/MPI and rules. I will investigate further and try to establish a solid test case.\r\n\r\nCare should be taken to not harm performance."},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/231343085","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2160#issuecomment-231343085","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2160","id":231343085,"user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars.githubusercontent.com/u/1268598?v=3","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"created_at":"2016-07-08T12:05:13Z","updated_at":"2016-07-08T12:05:13Z","body":"I had a good look at this. `mgetl()` in fact has the same protection for overlong lines as `fgetl()` has.\r\n\r\nHere's what I think was happening:\r\n1. We read a legacy super-long pot line and truncated it properly to our current, smaller, LINE_BUFFER_SIZE.\r\n2. --loopback was used, so the line was scanned for `:` field separator. In the truncated line none was found, so the truncated ciphertext was used. This is now optimized away in 786ffd2, we have no use for a truncated ciphertext as a candidate!\r\n3. The long (but perfectly within proper limits) line triggered [this core bug](http://www.openwall.com/lists/john-dev/2016/07/06/1), yet to fix.\r\n\r\nSo it could just as well have been a plain wordlist and not loopback mode."}}
{"actor":{"display_login":"magnumripper"}}