{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/608","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/608/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/608/events","html_url":"https://github.com/zulip/zulip/pull/608","id":144954456,"number":608,"title":"Generic cache references","user":{"login":"007","id":195099,"avatar_url":"https://avatars.githubusercontent.com/u/195099?v=3","gravatar_id":"","url":"https://api.github.com/users/007","html_url":"https://github.com/007","followers_url":"https://api.github.com/users/007/followers","following_url":"https://api.github.com/users/007/following{/other_user}","gists_url":"https://api.github.com/users/007/gists{/gist_id}","starred_url":"https://api.github.com/users/007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/007/subscriptions","organizations_url":"https://api.github.com/users/007/orgs","repos_url":"https://api.github.com/users/007/repos","events_url":"https://api.github.com/users/007/events{/privacy}","received_events_url":"https://api.github.com/users/007/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-31T16:46:55Z","updated_at":"2016-03-31T17:00:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/608","html_url":"https://github.com/zulip/zulip/pull/608","diff_url":"https://github.com/zulip/zulip/pull/608.diff","patch_url":"https://github.com/zulip/zulip/pull/608.patch"},"body":"Related to #378, switch all non-specific cache references to generic `remote_cache` instead of `memcached`.\r\n\r\nWould have just switched `\\w*memcached\\w*` to `\\w*cache\\w*`, but there are a few functions / variables where they would overlap and might cause problems.\r\n\r\nThere are still a ton of references to memcached throughout the code, but **hopefully** those are all actual memcached references, and some will stay even if the backing store is changed (e.g. [zerver/lib/cache.py `cache`](https://github.com/zulip/zulip/blob/master/zerver/lib/cache.py#L218))."},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/204021109","html_url":"https://github.com/zulip/zulip/pull/608#issuecomment-204021109","issue_url":"https://api.github.com/repos/zulip/zulip/issues/608","id":204021109,"user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T17:00:08Z","updated_at":"2016-03-31T17:00:08Z","body":"Awesome, thanks for doing this @007 !  Posted one inline comment, a few more requests:\r\n* In the last commit, use \"remote cache\" rather than \"cache\" in the places you don't already -- I think it's a lot clearer since we also use in-process caches in most places.\r\n* For \"models updated\", can you update to a more detailed commit message like \"Update memcached => remote_cache in models.\" ?  That'd be a lot clearer for folks reading the history what this commit relates to.  Similar feedback for the last commit.\r\n* On \"fix output stats\", https://github.com/vulcand/vulcand/issues/112 and the code it links to suggest that underscores are OK."}}