{"action":"created","issue":{"url":"https://api.github.com/repos/haskell/cabal/issues/4067","repository_url":"https://api.github.com/repos/haskell/cabal","labels_url":"https://api.github.com/repos/haskell/cabal/issues/4067/labels{/name}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/4067/comments","events_url":"https://api.github.com/repos/haskell/cabal/issues/4067/events","html_url":"https://github.com/haskell/cabal/pull/4067","id":186201492,"number":4067,"title":"[WIP] Make more dependency types","user":{"login":"Ericson2314","id":1055245,"avatar_url":"https://avatars.githubusercontent.com/u/1055245?v=3","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-31T04:38:30Z","updated_at":"2016-11-01T18:06:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/4067","html_url":"https://github.com/haskell/cabal/pull/4067","diff_url":"https://github.com/haskell/cabal/pull/4067.diff","patch_url":"https://github.com/haskell/cabal/pull/4067.patch"},"body":"This is a follow-up to https://github.com/haskell/cabal/pull/4057, so until that is dealt with this diff will also be humongous and unreviewable.\r\n \r\nThis PR makes separate types for different types of dependencies:\r\n - `Dependency` is now just for regular (usually library) dependencies on haskell packages\r\n - `LegacyExeDependecy` for legacy `build-tools` dependencies \r\n - `PkgconfigDependecy` for pkg-config dependencies\r\n\r\nAdditionally, there is a newtype `PkgconfigName` for pkg-config library names. For Cabal's uses alone this wouldn't be worth it, but cabal-install already distinguishes these libraries widely with `PackageName`. Continuing to use `PackageName` seemed inconsistent with the newly-rigorous use of `Dependecy`, while going back to `String` seemed like a step backwards.\r\n\r\nPlain `String` is used for legacy built tool names, as those can mean quite different things, and very little code was using `PackageName` and not `String` for them.\r\n\r\nNote I had to make some orphan instances (module-wise, not package-wise) in order to avoid a `Distribution.ParserUtils` <-> `Distribution.Package` cyclic dep. This can go away once the old parser is removed.\r\n"},"comment":{"url":"https://api.github.com/repos/haskell/cabal/issues/comments/257644461","html_url":"https://github.com/haskell/cabal/pull/4067#issuecomment-257644461","issue_url":"https://api.github.com/repos/haskell/cabal/issues/4067","id":257644461,"user":{"login":"Ericson2314","id":1055245,"avatar_url":"https://avatars.githubusercontent.com/u/1055245?v=3","gravatar_id":"","url":"https://api.github.com/users/Ericson2314","html_url":"https://github.com/Ericson2314","followers_url":"https://api.github.com/users/Ericson2314/followers","following_url":"https://api.github.com/users/Ericson2314/following{/other_user}","gists_url":"https://api.github.com/users/Ericson2314/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericson2314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericson2314/subscriptions","organizations_url":"https://api.github.com/users/Ericson2314/orgs","repos_url":"https://api.github.com/users/Ericson2314/repos","events_url":"https://api.github.com/users/Ericson2314/events{/privacy}","received_events_url":"https://api.github.com/users/Ericson2314/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T18:06:39Z","updated_at":"2016-11-01T18:06:39Z","body":"@ezyang also despite the not-invalidated diffs aboved I think I fixed everything you mentioned if you want to toggle your review :)."}}
{"actor":{"display_login":"Ericson2314"}}