{"action":"created","issue":{"url":"https://api.github.com/repos/TokTok/c-toxcore/issues/343","repository_url":"https://api.github.com/repos/TokTok/c-toxcore","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/343/labels{/name}","comments_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/343/comments","events_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/343/events","html_url":"https://github.com/TokTok/c-toxcore/pull/343","id":196320606,"number":343,"title":"Wrap all sodium/nacl functions in crypto_core.c.","user":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nurupo","id":1855294,"avatar_url":"https://avatars.githubusercontent.com/u/1855294?v=3","gravatar_id":"","url":"https://api.github.com/users/nurupo","html_url":"https://github.com/nurupo","followers_url":"https://api.github.com/users/nurupo/followers","following_url":"https://api.github.com/users/nurupo/following{/other_user}","gists_url":"https://api.github.com/users/nurupo/gists{/gist_id}","starred_url":"https://api.github.com/users/nurupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurupo/subscriptions","organizations_url":"https://api.github.com/users/nurupo/orgs","repos_url":"https://api.github.com/users/nurupo/repos","events_url":"https://api.github.com/users/nurupo/events{/privacy}","received_events_url":"https://api.github.com/users/nurupo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nurupo","id":1855294,"avatar_url":"https://avatars.githubusercontent.com/u/1855294?v=3","gravatar_id":"","url":"https://api.github.com/users/nurupo","html_url":"https://github.com/nurupo","followers_url":"https://api.github.com/users/nurupo/followers","following_url":"https://api.github.com/users/nurupo/following{/other_user}","gists_url":"https://api.github.com/users/nurupo/gists{/gist_id}","starred_url":"https://api.github.com/users/nurupo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nurupo/subscriptions","organizations_url":"https://api.github.com/users/nurupo/orgs","repos_url":"https://api.github.com/users/nurupo/repos","events_url":"https://api.github.com/users/nurupo/events{/privacy}","received_events_url":"https://api.github.com/users/nurupo/received_events","type":"User","site_admin":false},{"login":"Diadlo","id":6306608,"avatar_url":"https://avatars.githubusercontent.com/u/6306608?v=3","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false},{"login":"robinlinden","id":8304462,"avatar_url":"https://avatars.githubusercontent.com/u/8304462?v=3","gravatar_id":"","url":"https://api.github.com/users/robinlinden","html_url":"https://github.com/robinlinden","followers_url":"https://api.github.com/users/robinlinden/followers","following_url":"https://api.github.com/users/robinlinden/following{/other_user}","gists_url":"https://api.github.com/users/robinlinden/gists{/gist_id}","starred_url":"https://api.github.com/users/robinlinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinlinden/subscriptions","organizations_url":"https://api.github.com/users/robinlinden/orgs","repos_url":"https://api.github.com/users/robinlinden/repos","events_url":"https://api.github.com/users/robinlinden/events{/privacy}","received_events_url":"https://api.github.com/users/robinlinden/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/TokTok/c-toxcore/milestones/16","html_url":"https://github.com/TokTok/c-toxcore/milestone/16","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/milestones/16/labels","id":2137825,"number":16,"title":"v0.1.2","description":"","creator":{"login":"iphydf","id":10647936,"avatar_url":"https://avatars.githubusercontent.com/u/10647936?v=3","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":3,"state":"open","created_at":"2016-11-15T22:11:02Z","updated_at":"2016-12-19T23:59:17Z","due_on":"2016-12-23T08:00:00Z","closed_at":null},"comments":12,"created_at":"2016-12-19T02:49:19Z","updated_at":"2016-12-20T09:08:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/343","html_url":"https://github.com/TokTok/c-toxcore/pull/343","diff_url":"https://github.com/TokTok/c-toxcore/pull/343.diff","patch_url":"https://github.com/TokTok/c-toxcore/pull/343.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/toktok/c-toxcore/343)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/TokTok/c-toxcore/issues/comments/268191727","html_url":"https://github.com/TokTok/c-toxcore/pull/343#issuecomment-268191727","issue_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/343","id":268191727,"user":{"login":"robinlinden","id":8304462,"avatar_url":"https://avatars.githubusercontent.com/u/8304462?v=3","gravatar_id":"","url":"https://api.github.com/users/robinlinden","html_url":"https://github.com/robinlinden","followers_url":"https://api.github.com/users/robinlinden/followers","following_url":"https://api.github.com/users/robinlinden/following{/other_user}","gists_url":"https://api.github.com/users/robinlinden/gists{/gist_id}","starred_url":"https://api.github.com/users/robinlinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinlinden/subscriptions","organizations_url":"https://api.github.com/users/robinlinden/orgs","repos_url":"https://api.github.com/users/robinlinden/repos","events_url":"https://api.github.com/users/robinlinden/events{/privacy}","received_events_url":"https://api.github.com/users/robinlinden/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T09:08:18Z","updated_at":"2016-12-20T09:08:18Z","body":"\n\n\n\nReviewed 8 of 45 files at r1, 1 of 1 files at r6, 1 of 3 files at r7, 1 of 2 files at r8.\nReview status: all files reviewed at latest revision, 11 unresolved discussions.\n\n---\n\n*[auto_tests/messenger_test.c, line 28 at r8](https://reviewable.io:443/reviews/toktok/c-toxcore/343#-KZQRQ2A2C7qYX0ced_O:-KZQRQ2BOiPsuwRvUC4R:b-nxz2zh) ([raw file](https://github.com/toktok/c-toxcore/blob/2eb2fe01a45c4603b6f6360551ca541c9c18a18a/auto_tests/messenger_test.c#L28)):*\n> ```C\n> \n> #if VANILLA_NACL\n> #include <crypto_box.h> // crypto_box_PUBLICKEYBYTES and other defines.\n> ```\n\nAre we still going to use these defines?\n\n---\n\n*[auto_tests/messenger_test.c, line 140 at r8](https://reviewable.io:443/reviews/toktok/c-toxcore/343#-KZQQ-iPWfPfLgU6tpgi:-KZQQ-iQuysNQDirHgii:bu9m7mg) ([raw file](https://github.com/toktok/c-toxcore/blob/2eb2fe01a45c4603b6f6360551ca541c9c18a18a/auto_tests/messenger_test.c#L140)):*\n> ```C\n>     int good_len = strlen(good_data);\n>     int bad_len = strlen(bad_data);\n>     int really_bad_len = (MAX_CRYPTO_PACKET_SIZE - crypto_box_PUBLICKEYBYTES\n> ```\n\nStill using `crypto_box_PUBLICKEYBYTES` etc. here.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/toktok/c-toxcore/343)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"robinlinden"}}