{"action":"created","comment":{"url":"https://api.github.com/repos/axfelix/globus_oai/pulls/comments/89877103","pull_request_review_id":10407926,"id":89877103,"diff_hunk":"@@ -22,7 +24,7 @@ def __init__(self, params):\n \tdef setDefaults(self, defaults):\n \t\t\"\"\" Inherit global configs, but they do not overwrite local configs \"\"\"\n \t\tfor k,v in defaults.items():\n-\t\t\tif isinstance(k, str) or isinstance(k, unicode):\n+\t\t\tif isinstance(k, str) or isinstance(k, unicode) and not isinstance(v, list):","path":"harvester/HarvestRepository.py","position":14,"original_position":14,"commit_id":"709e13e76e9d2d8921b9e15206b09a9b5eaaa4f3","original_commit_id":"709e13e76e9d2d8921b9e15206b09a9b5eaaa4f3","user":{"login":"usask-rc","id":19416365,"avatar_url":"https://avatars.githubusercontent.com/u/19416365?v=3","gravatar_id":"","url":"https://api.github.com/users/usask-rc","html_url":"https://github.com/usask-rc","followers_url":"https://api.github.com/users/usask-rc/followers","following_url":"https://api.github.com/users/usask-rc/following{/other_user}","gists_url":"https://api.github.com/users/usask-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/usask-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usask-rc/subscriptions","organizations_url":"https://api.github.com/users/usask-rc/orgs","repos_url":"https://api.github.com/users/usask-rc/repos","events_url":"https://api.github.com/users/usask-rc/events{/privacy}","received_events_url":"https://api.github.com/users/usask-rc/received_events","type":"User","site_admin":false},"body":"The intent is this: add all configuration definitions from the parent scope into this repo's scope, but don't overwrite any values that are already defined.\r\n\r\nThe current code is checking for strings in the KEYS, but I think I originally intended to check for strings in the VALUES.  So I propose to change the line to this:\r\n\r\nif isinstance(v, str) or isinstance(v, unicode):\r\n\r\nBut then maybe I'm doing this backwards, and the global values should be put in place first, and then the local values are set after, which would eliminate all of this \"checking to see if it is set\" logic.","created_at":"2016-11-28T20:28:06Z","updated_at":"2016-11-28T20:28:06Z","html_url":"https://github.com/axfelix/globus_oai/pull/18#discussion_r89877103","pull_request_url":"https://api.github.com/repos/axfelix/globus_oai/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/axfelix/globus_oai/pulls/comments/89877103"},"html":{"href":"https://github.com/axfelix/globus_oai/pull/18#discussion_r89877103"},"pull_request":{"href":"https://api.github.com/repos/axfelix/globus_oai/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/axfelix/globus_oai/pulls/18","id":95353151,"html_url":"https://github.com/axfelix/globus_oai/pull/18","diff_url":"https://github.com/axfelix/globus_oai/pull/18.diff","patch_url":"https://github.com/axfelix/globus_oai/pull/18.patch","issue_url":"https://api.github.com/repos/axfelix/globus_oai/issues/18","number":18,"state":"open","locked":false,"title":"Added two parameters to harvester initialization","user":{"login":"usask-rc","id":19416365,"avatar_url":"https://avatars.githubusercontent.com/u/19416365?v=3","gravatar_id":"","url":"https://api.github.com/users/usask-rc","html_url":"https://github.com/usask-rc","followers_url":"https://api.github.com/users/usask-rc/followers","following_url":"https://api.github.com/users/usask-rc/following{/other_user}","gists_url":"https://api.github.com/users/usask-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/usask-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usask-rc/subscriptions","organizations_url":"https://api.github.com/users/usask-rc/orgs","repos_url":"https://api.github.com/users/usask-rc/repos","events_url":"https://api.github.com/users/usask-rc/events{/privacy}","received_events_url":"https://api.github.com/users/usask-rc/received_events","type":"User","site_admin":false},"body":"Also made sure records were not refreshed when repo is disabled","created_at":"2016-11-25T23:05:11Z","updated_at":"2016-11-28T20:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea39c04ed2bd2e4f3918fbac6c5a8267efb0b2ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/axfelix/globus_oai/pulls/18/commits","review_comments_url":"https://api.github.com/repos/axfelix/globus_oai/pulls/18/comments","review_comment_url":"https://api.github.com/repos/axfelix/globus_oai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axfelix/globus_oai/issues/18/comments","statuses_url":"https://api.github.com/repos/axfelix/globus_oai/statuses/709e13e76e9d2d8921b9e15206b09a9b5eaaa4f3","head":{"label":"usask-rc:master","ref":"master","sha":"709e13e76e9d2d8921b9e15206b09a9b5eaaa4f3","user":{"login":"usask-rc","id":19416365,"avatar_url":"https://avatars.githubusercontent.com/u/19416365?v=3","gravatar_id":"","url":"https://api.github.com/users/usask-rc","html_url":"https://github.com/usask-rc","followers_url":"https://api.github.com/users/usask-rc/followers","following_url":"https://api.github.com/users/usask-rc/following{/other_user}","gists_url":"https://api.github.com/users/usask-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/usask-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usask-rc/subscriptions","organizations_url":"https://api.github.com/users/usask-rc/orgs","repos_url":"https://api.github.com/users/usask-rc/repos","events_url":"https://api.github.com/users/usask-rc/events{/privacy}","received_events_url":"https://api.github.com/users/usask-rc/received_events","type":"User","site_admin":false},"repo":{"id":64497289,"name":"globus_oai","full_name":"usask-rc/globus_oai","owner":{"login":"usask-rc","id":19416365,"avatar_url":"https://avatars.githubusercontent.com/u/19416365?v=3","gravatar_id":"","url":"https://api.github.com/users/usask-rc","html_url":"https://github.com/usask-rc","followers_url":"https://api.github.com/users/usask-rc/followers","following_url":"https://api.github.com/users/usask-rc/following{/other_user}","gists_url":"https://api.github.com/users/usask-rc/gists{/gist_id}","starred_url":"https://api.github.com/users/usask-rc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usask-rc/subscriptions","organizations_url":"https://api.github.com/users/usask-rc/orgs","repos_url":"https://api.github.com/users/usask-rc/repos","events_url":"https://api.github.com/users/usask-rc/events{/privacy}","received_events_url":"https://api.github.com/users/usask-rc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/usask-rc/globus_oai","description":null,"fork":true,"url":"https://api.github.com/repos/usask-rc/globus_oai","forks_url":"https://api.github.com/repos/usask-rc/globus_oai/forks","keys_url":"https://api.github.com/repos/usask-rc/globus_oai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usask-rc/globus_oai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usask-rc/globus_oai/teams","hooks_url":"https://api.github.com/repos/usask-rc/globus_oai/hooks","issue_events_url":"https://api.github.com/repos/usask-rc/globus_oai/issues/events{/number}","events_url":"https://api.github.com/repos/usask-rc/globus_oai/events","assignees_url":"https://api.github.com/repos/usask-rc/globus_oai/assignees{/user}","branches_url":"https://api.github.com/repos/usask-rc/globus_oai/branches{/branch}","tags_url":"https://api.github.com/repos/usask-rc/globus_oai/tags","blobs_url":"https://api.github.com/repos/usask-rc/globus_oai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usask-rc/globus_oai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usask-rc/globus_oai/git/refs{/sha}","trees_url":"https://api.github.com/repos/usask-rc/globus_oai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usask-rc/globus_oai/statuses/{sha}","languages_url":"https://api.github.com/repos/usask-rc/globus_oai/languages","stargazers_url":"https://api.github.com/repos/usask-rc/globus_oai/stargazers","contributors_url":"https://api.github.com/repos/usask-rc/globus_oai/contributors","subscribers_url":"https://api.github.com/repos/usask-rc/globus_oai/subscribers","subscription_url":"https://api.github.com/repos/usask-rc/globus_oai/subscription","commits_url":"https://api.github.com/repos/usask-rc/globus_oai/commits{/sha}","git_commits_url":"https://api.github.com/repos/usask-rc/globus_oai/git/commits{/sha}","comments_url":"https://api.github.com/repos/usask-rc/globus_oai/comments{/number}","issue_comment_url":"https://api.github.com/repos/usask-rc/globus_oai/issues/comments{/number}","contents_url":"https://api.github.com/repos/usask-rc/globus_oai/contents/{+path}","compare_url":"https://api.github.com/repos/usask-rc/globus_oai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usask-rc/globus_oai/merges","archive_url":"https://api.github.com/repos/usask-rc/globus_oai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usask-rc/globus_oai/downloads","issues_url":"https://api.github.com/repos/usask-rc/globus_oai/issues{/number}","pulls_url":"https://api.github.com/repos/usask-rc/globus_oai/pulls{/number}","milestones_url":"https://api.github.com/repos/usask-rc/globus_oai/milestones{/number}","notifications_url":"https://api.github.com/repos/usask-rc/globus_oai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usask-rc/globus_oai/labels{/name}","releases_url":"https://api.github.com/repos/usask-rc/globus_oai/releases{/id}","deployments_url":"https://api.github.com/repos/usask-rc/globus_oai/deployments","created_at":"2016-07-29T17:08:54Z","updated_at":"2016-07-29T17:08:55Z","pushed_at":"2016-11-25T23:04:15Z","git_url":"git://github.com/usask-rc/globus_oai.git","ssh_url":"git@github.com:usask-rc/globus_oai.git","clone_url":"https://github.com/usask-rc/globus_oai.git","svn_url":"https://github.com/usask-rc/globus_oai","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"axfelix:master","ref":"master","sha":"a91d6828933043d8d0963e7e4cda00232295f9be","user":{"login":"axfelix","id":252047,"avatar_url":"https://avatars.githubusercontent.com/u/252047?v=3","gravatar_id":"","url":"https://api.github.com/users/axfelix","html_url":"https://github.com/axfelix","followers_url":"https://api.github.com/users/axfelix/followers","following_url":"https://api.github.com/users/axfelix/following{/other_user}","gists_url":"https://api.github.com/users/axfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/axfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axfelix/subscriptions","organizations_url":"https://api.github.com/users/axfelix/orgs","repos_url":"https://api.github.com/users/axfelix/repos","events_url":"https://api.github.com/users/axfelix/events{/privacy}","received_events_url":"https://api.github.com/users/axfelix/received_events","type":"User","site_admin":false},"repo":{"id":56172672,"name":"globus_oai","full_name":"axfelix/globus_oai","owner":{"login":"axfelix","id":252047,"avatar_url":"https://avatars.githubusercontent.com/u/252047?v=3","gravatar_id":"","url":"https://api.github.com/users/axfelix","html_url":"https://github.com/axfelix","followers_url":"https://api.github.com/users/axfelix/followers","following_url":"https://api.github.com/users/axfelix/following{/other_user}","gists_url":"https://api.github.com/users/axfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/axfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axfelix/subscriptions","organizations_url":"https://api.github.com/users/axfelix/orgs","repos_url":"https://api.github.com/users/axfelix/repos","events_url":"https://api.github.com/users/axfelix/events{/privacy}","received_events_url":"https://api.github.com/users/axfelix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axfelix/globus_oai","description":null,"fork":false,"url":"https://api.github.com/repos/axfelix/globus_oai","forks_url":"https://api.github.com/repos/axfelix/globus_oai/forks","keys_url":"https://api.github.com/repos/axfelix/globus_oai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axfelix/globus_oai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axfelix/globus_oai/teams","hooks_url":"https://api.github.com/repos/axfelix/globus_oai/hooks","issue_events_url":"https://api.github.com/repos/axfelix/globus_oai/issues/events{/number}","events_url":"https://api.github.com/repos/axfelix/globus_oai/events","assignees_url":"https://api.github.com/repos/axfelix/globus_oai/assignees{/user}","branches_url":"https://api.github.com/repos/axfelix/globus_oai/branches{/branch}","tags_url":"https://api.github.com/repos/axfelix/globus_oai/tags","blobs_url":"https://api.github.com/repos/axfelix/globus_oai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axfelix/globus_oai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axfelix/globus_oai/git/refs{/sha}","trees_url":"https://api.github.com/repos/axfelix/globus_oai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axfelix/globus_oai/statuses/{sha}","languages_url":"https://api.github.com/repos/axfelix/globus_oai/languages","stargazers_url":"https://api.github.com/repos/axfelix/globus_oai/stargazers","contributors_url":"https://api.github.com/repos/axfelix/globus_oai/contributors","subscribers_url":"https://api.github.com/repos/axfelix/globus_oai/subscribers","subscription_url":"https://api.github.com/repos/axfelix/globus_oai/subscription","commits_url":"https://api.github.com/repos/axfelix/globus_oai/commits{/sha}","git_commits_url":"https://api.github.com/repos/axfelix/globus_oai/git/commits{/sha}","comments_url":"https://api.github.com/repos/axfelix/globus_oai/comments{/number}","issue_comment_url":"https://api.github.com/repos/axfelix/globus_oai/issues/comments{/number}","contents_url":"https://api.github.com/repos/axfelix/globus_oai/contents/{+path}","compare_url":"https://api.github.com/repos/axfelix/globus_oai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axfelix/globus_oai/merges","archive_url":"https://api.github.com/repos/axfelix/globus_oai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axfelix/globus_oai/downloads","issues_url":"https://api.github.com/repos/axfelix/globus_oai/issues{/number}","pulls_url":"https://api.github.com/repos/axfelix/globus_oai/pulls{/number}","milestones_url":"https://api.github.com/repos/axfelix/globus_oai/milestones{/number}","notifications_url":"https://api.github.com/repos/axfelix/globus_oai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axfelix/globus_oai/labels{/name}","releases_url":"https://api.github.com/repos/axfelix/globus_oai/releases{/id}","deployments_url":"https://api.github.com/repos/axfelix/globus_oai/deployments","created_at":"2016-04-13T17:32:50Z","updated_at":"2016-04-13T17:34:40Z","pushed_at":"2016-11-25T23:05:12Z","git_url":"git://github.com/axfelix/globus_oai.git","ssh_url":"git@github.com:axfelix/globus_oai.git","clone_url":"https://github.com/axfelix/globus_oai.git","svn_url":"https://github.com/axfelix/globus_oai","homepage":null,"size":120,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/axfelix/globus_oai/pulls/18"},"html":{"href":"https://github.com/axfelix/globus_oai/pull/18"},"issue":{"href":"https://api.github.com/repos/axfelix/globus_oai/issues/18"},"comments":{"href":"https://api.github.com/repos/axfelix/globus_oai/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/axfelix/globus_oai/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/axfelix/globus_oai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axfelix/globus_oai/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/axfelix/globus_oai/statuses/709e13e76e9d2d8921b9e15206b09a9b5eaaa4f3"}}}}
{"actor":{"display_login":"usask-rc"}}