{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/13839","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13839/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13839/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13839/events","html_url":"https://github.com/cms-sw/cmssw/pull/13839","id":143524907,"number":13839,"title":"CTPPS: new EventFilter for raw-to-digi conversion of TOTEM RP data","user":{"login":"jan-kaspar","id":17830858,"avatar_url":"https://avatars.githubusercontent.com/u/17830858?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-kaspar","html_url":"https://github.com/jan-kaspar","followers_url":"https://api.github.com/users/jan-kaspar/followers","following_url":"https://api.github.com/users/jan-kaspar/following{/other_user}","gists_url":"https://api.github.com/users/jan-kaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-kaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-kaspar/subscriptions","organizations_url":"https://api.github.com/users/jan-kaspar/orgs","repos_url":"https://api.github.com/users/jan-kaspar/repos","events_url":"https://api.github.com/users/jan-kaspar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-kaspar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/daq-pending","name":"daq-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":416,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-04-21T20:16:20Z","due_on":null,"closed_at":null},"comments":60,"created_at":"2016-03-25T15:33:39Z","updated_at":"2016-04-21T20:28:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/13839","html_url":"https://github.com/cms-sw/cmssw/pull/13839","diff_url":"https://github.com/cms-sw/cmssw/pull/13839.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/13839.patch"},"body":"Validation config file using TOTEM-standalone data:\r\n```\r\n  EventFilter/TotemRawToDigi/test/totem_standalone_raw_data_test.py\r\n```\r\nwith the expected output:\r\n```\r\n  EventFilter/TotemRawToDigi/test/totem_standalone_raw_data_test.reference_output\r\n```"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/213101212","html_url":"https://github.com/cms-sw/cmssw/pull/13839#issuecomment-213101212","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/13839","id":213101212,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T20:28:02Z","updated_at":"2016-04-21T20:28:02Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/13839\t4160777\r\n- code changes are to add unpacking TOTEM RP and Trigger FEDs (two separate unpackers)\r\n- jenkins tests pass, more specifically compilation and static code analysis\r\n- tested locally with the supplied test file, using both the reference emulated data file as well as a file from run2 data taking without totem: the behaviour looks OK (no noise generated and the module takes ~<1ms to run)\r\n\r\nThere are still some strings being manipulated\r\nhttps://slava77sk.web.cern.ch/slava77sk/reco/cgi-bin/igprof-navigator/CMSSW_8_1_X_2016-04-20-1100-sign689_268608_MiniDaq_all_pp-4160777/451\r\nI'm not sure if it's from the bare stringstream mentioned in a few places\r\nhttps://github.com/cms-sw/cmssw/pull/13839/files#diff-a46153d0e76f60e101e7915225bca648R61, but maybe I missed the relationship in flags and there is some string manipulation still in place\r\nThis is with emulated data.\r\nLet's revisit this once this runs on something real.\r\n\r\n"}}