{"push_id":1313186863,"size":4,"distinct_size":4,"ref":"refs/heads/master","head":"f08bb28702a2df5d2f9e3a354aa63cf7e738dc58","before":"19966242163611e61d45ee4033f28aa6f967906a","commits":[{"sha":"97544ed1770bf3c169f3b8f3711917bbf37045bc","author":{"name":"yuuji.yaginuma","email":"b1bc678335c01ebd6debb3ede5487e599c040f7b@gmail.com"},"message":"add check of argument\n\n`#fetch_multi` in case did not cache hit, to write a cache using the block value.\nhttps://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache.rb#L383..L384\n\nTherefore, block is a need to pass always, I think should check first.","distinct":true,"url":"https://api.github.com/repos/mechanicles/rails/commits/97544ed1770bf3c169f3b8f3711917bbf37045bc"},{"sha":"bf19c2230d20f7679b1fb52505c49c183627b235","author":{"name":"Richard Schneeman","email":"c14a41698892ba9bb4ba113f863cf6ac7adc56d2@gmail.com"},"message":"Merge pull request #26524 from y-yagi/add_check_of_argument\n\nadd check of argument","distinct":true,"url":"https://api.github.com/repos/mechanicles/rails/commits/bf19c2230d20f7679b1fb52505c49c183627b235"},{"sha":"7e350c67057affccde176eeeffcffbe10806feda","author":{"name":"Kir Shatrov","email":"be0e345f4bbe70da8dad69f79b03e798a3cd4fd1@me.com"},"message":"Fix memoization bug on ActionDispatch::TestRequest#request_method=\n\nTestRequest have been overrriding request_method setter since 2009,\nbut the actual implementation in Request (not TestRequest) has been\nchanged since that. Now it's also using @request_method instance\nvariable to keep the state.\n\nThe override in TestRequest have not been calling `super`, which caused\na bug that after accessing #requst_method the value was memoized and\nthen we've never been able to change it anymore:\n\n```\nreq = ActionDispatch::TestRequest.create\nputs \"was: #{req.request_method}\" # memoized here\nreq.request_method = \"POST\"\nputs \"became: #{req.request_method}\"\n```\n\noutput:\n\n```\nwas: GET\nbecame: GET\n```\n\nSince the whole purpose of overriding the setter in TestRequest is to\nupcase it, I'm changing it to `super(method.to_s.upcase)`","distinct":true,"url":"https://api.github.com/repos/mechanicles/rails/commits/7e350c67057affccde176eeeffcffbe10806feda"},{"sha":"f08bb28702a2df5d2f9e3a354aa63cf7e738dc58","author":{"name":"Arthur Nogueira Neves","email":"f27a17fc90c00d8c248d8510a1084221738b492b@arthurnn.com"},"message":"Merge pull request #26589 from kirs/ad-test-request-method\n\nFix memoization bug on ActionDispatch::TestRequest#request_method=","distinct":true,"url":"https://api.github.com/repos/mechanicles/rails/commits/f08bb28702a2df5d2f9e3a354aa63cf7e738dc58"}]}
{"actor":{"display_login":"mechanicles"}}