{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19944","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19944/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19944/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19944/events","html_url":"https://github.com/kubernetes/kubernetes/pull/19944","id":128021271,"number":19944,"title":"Set Docker custom metric label for cAdvisor if custom metric volume is mounted","user":{"login":"mwielgus","id":11994812,"avatar_url":"https://avatars.githubusercontent.com/u/11994812?v=3","gravatar_id":"","url":"https://api.github.com/users/mwielgus","html_url":"https://github.com/mwielgus","followers_url":"https://api.github.com/users/mwielgus/followers","following_url":"https://api.github.com/users/mwielgus/following{/other_user}","gists_url":"https://api.github.com/users/mwielgus/gists{/gist_id}","starred_url":"https://api.github.com/users/mwielgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwielgus/subscriptions","organizations_url":"https://api.github.com/users/mwielgus/orgs","repos_url":"https://api.github.com/users/mwielgus/repos","events_url":"https://api.github.com/users/mwielgus/events{/privacy}","received_events_url":"https://api.github.com/users/mwielgus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"comments":17,"created_at":"2016-01-21T21:16:38Z","updated_at":"2016-02-03T17:47:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19944","html_url":"https://github.com/kubernetes/kubernetes/pull/19944","diff_url":"https://github.com/kubernetes/kubernetes/pull/19944.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19944.patch"},"body":"As agreed with @erictune, @dchen1107 and @bgrant0607  alpha support for Custom Metics in 1.2 will be enabled by the presence of a volume (configmap) mounted in a well-defined location.\r\n\r\nPR is based on #18295 by @jszczepkowski."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/179371830","html_url":"https://github.com/kubernetes/kubernetes/pull/19944#issuecomment-179371830","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19944","id":179371830,"user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"created_at":"2016-02-03T17:47:57Z","updated_at":"2016-02-03T17:47:57Z","body":"Sorry for not proceed this pr earlier due to ...\r\n\r\nThe pr looks good to me overall, except I do think @vishh has a good point here on fixing the path to the config file something like /var/cadvisor/config.json. But on another side, we don't have a full picture on how cadvisor is going to be after 1.2 / 1.3. For example, running a standalone cadvisor pod for monitoring, and have minimal cadvisor library linked with kubelet, then which cadvisor has the ownership of that fixed directory? I don't know yet. \r\n\r\nSo I don't want to block this nice alpha feature here. @mwielgus please rebase. Thanks!\r\n\r\n"}}