{"action":"created","issue":{"url":"https://api.github.com/repos/gatling/maven-shade-plugin/issues/1","repository_url":"https://api.github.com/repos/gatling/maven-shade-plugin","labels_url":"https://api.github.com/repos/gatling/maven-shade-plugin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/gatling/maven-shade-plugin/issues/1/comments","events_url":"https://api.github.com/repos/gatling/maven-shade-plugin/issues/1/events","html_url":"https://github.com/gatling/maven-shade-plugin/pull/1","id":186911528,"number":1,"title":"Support fully shaded test JAR","user":{"login":"jfallows","id":2099911,"avatar_url":"https://avatars.githubusercontent.com/u/2099911?v=3","gravatar_id":"","url":"https://api.github.com/users/jfallows","html_url":"https://github.com/jfallows","followers_url":"https://api.github.com/users/jfallows/followers","following_url":"https://api.github.com/users/jfallows/following{/other_user}","gists_url":"https://api.github.com/users/jfallows/gists{/gist_id}","starred_url":"https://api.github.com/users/jfallows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfallows/subscriptions","organizations_url":"https://api.github.com/users/jfallows/orgs","repos_url":"https://api.github.com/users/jfallows/repos","events_url":"https://api.github.com/users/jfallows/events{/privacy}","received_events_url":"https://api.github.com/users/jfallows/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-02T20:30:01Z","updated_at":"2016-11-02T21:20:56Z","closed_at":"2016-11-02T21:20:56Z","pull_request":{"url":"https://api.github.com/repos/gatling/maven-shade-plugin/pulls/1","html_url":"https://github.com/gatling/maven-shade-plugin/pull/1","diff_url":"https://github.com/gatling/maven-shade-plugin/pull/1.diff","patch_url":"https://github.com/gatling/maven-shade-plugin/pull/1.patch"},"body":"Support creating a fully shaded test JAR, with all dependencies (including `compile` scope), and without requiring that the test JAR be deployed when the project is released.\r\n\r\nThe major changes are:\r\n- add `testOutputFile` with semantics of `outputFile` for shaded test JAR\r\n- add `createTestJar` to create test JAR if not present, but without attaching as project artifact\r\n- add `shadeJar` (default: true) to support shading only the test JAR but not the main JAR\r\n- change `shadeTestJar` behavior to include `compile` scope dependencies too\r\n- fix NPE in `ShadeMojoTest` that was present before making these changes\r\n\r\nThe use case that drove this requirement was to be able to run [OpenJDK jmh](http://openjdk.java.net/projects/code-tools/jmh/) micro benchmarks from a shaded test JAR without requiring the main JAR to be shaded and without requiring the test JAR to be deployed when the main JAR is released."},"comment":{"url":"https://api.github.com/repos/gatling/maven-shade-plugin/issues/comments/258002796","html_url":"https://github.com/gatling/maven-shade-plugin/pull/1#issuecomment-258002796","issue_url":"https://api.github.com/repos/gatling/maven-shade-plugin/issues/1","id":258002796,"user":{"login":"slandelle","id":849197,"avatar_url":"https://avatars.githubusercontent.com/u/849197?v=3","gravatar_id":"","url":"https://api.github.com/users/slandelle","html_url":"https://github.com/slandelle","followers_url":"https://api.github.com/users/slandelle/followers","following_url":"https://api.github.com/users/slandelle/following{/other_user}","gists_url":"https://api.github.com/users/slandelle/gists{/gist_id}","starred_url":"https://api.github.com/users/slandelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slandelle/subscriptions","organizations_url":"https://api.github.com/users/slandelle/orgs","repos_url":"https://api.github.com/users/slandelle/repos","events_url":"https://api.github.com/users/slandelle/events{/privacy}","received_events_url":"https://api.github.com/users/slandelle/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T21:20:56Z","updated_at":"2016-11-02T21:20:56Z","body":"We did fork the `maven-shade-plugin` (like [quite a few others did too](https://github.com/search?utf8=%E2%9C%93&q=maven-shade-plugin), probably for the same reason).\r\n\r\nForking an open-source project is definitively not something we liked doing. We did so because we were really short on time, and needed some changes and fixes that seemed to be stalled for ages on their bugtracker and felt we wouldn't make it in time otherwise.\r\n\r\nStill, we absolutely don't intended to hurt the `maven-shade-plugin` developers' feelings and turn this repository into an \"official\" fork where we would accept contributions, bring news features and fixes and basically become a competitor of the original one. We'd rather switch back to the official version if it meets our needs.\r\n\r\nSo, I'm sorry, but I'll have to turn your PR down. Please be sure that I really appreciate the effort you put into trying to contribute.\r\n\r\nRegards"}}
{"actor":{"display_login":"slandelle"}}