{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/comments/92078605","pull_request_review_id":12588121,"id":92078605,"diff_hunk":"@@ -17,9 +17,19 @@ namespace :gettext do\n   end\n \n   def files_to_translate\n-    GettextSetup.config['source_files'].map do |p|\n+    files = GettextSetup.config['source_files'].map do |p|\n       Dir.glob(p)\n     end.flatten\n+    # check for optional list of files to exclude from string\n+    # extraction\n+    files_to_exclude = GettextSetup.config['exclude_files']\n+    if (files_to_exclude)","path":"lib/tasks/gettext.rake","position":null,"original_position":11,"commit_id":"37cf98a4ed561c6cab991939f81aed40ff69107b","original_commit_id":"818885a7653bc7670295d41ba4647e879c990c3b","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"body":"Ah - I hadn't realized that bit was controversial :) ah well. so many ways to do the same thing in ruby.","created_at":"2016-12-13T01:12:59Z","updated_at":"2016-12-13T01:12:59Z","html_url":"https://github.com/puppetlabs/gettext-setup-gem/pull/15#discussion_r92078605","pull_request_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/comments/92078605"},"html":{"href":"https://github.com/puppetlabs/gettext-setup-gem/pull/15#discussion_r92078605"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15","id":97666583,"html_url":"https://github.com/puppetlabs/gettext-setup-gem/pull/15","diff_url":"https://github.com/puppetlabs/gettext-setup-gem/pull/15.diff","patch_url":"https://github.com/puppetlabs/gettext-setup-gem/pull/15.patch","issue_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues/15","number":15,"state":"open","locked":false,"title":"(INTL-8) Add a config option to exclude certain files from translation","user":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"body":"This commit allows the user to add an `exclude_files` field to the\r\nconfig file, which contains a list of file paths to be excluded from\r\nthe files specified with the `source_files` option.","created_at":"2016-12-13T00:53:12Z","updated_at":"2016-12-13T01:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a9fddfd0cc2c6dd888c01b396a97f5cd214436f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues/15/comments","statuses_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/statuses/37cf98a4ed561c6cab991939f81aed40ff69107b","head":{"label":"Magisus:exclude-files/INTL-8","ref":"exclude-files/INTL-8","sha":"37cf98a4ed561c6cab991939f81aed40ff69107b","user":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"repo":{"id":74999880,"name":"gettext-setup-gem","full_name":"Magisus/gettext-setup-gem","owner":{"login":"Magisus","id":839145,"avatar_url":"https://avatars.githubusercontent.com/u/839145?v=3","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Magisus/gettext-setup-gem","description":"A gem that configures gettext for internationalization","fork":true,"url":"https://api.github.com/repos/Magisus/gettext-setup-gem","forks_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/forks","keys_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/teams","hooks_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/hooks","issue_events_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/issues/events{/number}","events_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/events","assignees_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/assignees{/user}","branches_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/branches{/branch}","tags_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/tags","blobs_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/statuses/{sha}","languages_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/languages","stargazers_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/stargazers","contributors_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/contributors","subscribers_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/subscribers","subscription_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/subscription","commits_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/contents/{+path}","compare_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/merges","archive_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/downloads","issues_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/issues{/number}","pulls_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/pulls{/number}","milestones_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/milestones{/number}","notifications_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/labels{/name}","releases_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/releases{/id}","deployments_url":"https://api.github.com/repos/Magisus/gettext-setup-gem/deployments","created_at":"2016-11-28T18:02:51Z","updated_at":"2016-11-28T18:02:52Z","pushed_at":"2016-12-13T01:11:10Z","git_url":"git://github.com/Magisus/gettext-setup-gem.git","ssh_url":"git@github.com:Magisus/gettext-setup-gem.git","clone_url":"https://github.com/Magisus/gettext-setup-gem.git","svn_url":"https://github.com/Magisus/gettext-setup-gem","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"9d71cecbd472a378aa20736aaf44e904261b5e79","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":60299510,"name":"gettext-setup-gem","full_name":"puppetlabs/gettext-setup-gem","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/gettext-setup-gem","description":"A gem that configures gettext for internationalization","fork":false,"url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem","forks_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/forks","keys_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/teams","hooks_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/events","assignees_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/tags","blobs_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/subscription","commits_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/merges","archive_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/downloads","issues_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/deployments","created_at":"2016-06-02T21:45:58Z","updated_at":"2016-12-01T00:05:57Z","pushed_at":"2016-12-13T01:11:10Z","git_url":"git://github.com/puppetlabs/gettext-setup-gem.git","ssh_url":"git@github.com:puppetlabs/gettext-setup-gem.git","clone_url":"https://github.com/puppetlabs/gettext-setup-gem.git","svn_url":"https://github.com/puppetlabs/gettext-setup-gem","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15"},"html":{"href":"https://github.com/puppetlabs/gettext-setup-gem/pull/15"},"issue":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues/15"},"comments":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/gettext-setup-gem/statuses/37cf98a4ed561c6cab991939f81aed40ff69107b"}}}}
{"actor":{"display_login":"MosesMendoza"}}