{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/86283106","pull_request_review_id":6947030,"id":86283106,"diff_hunk":"@@ -245,4 +245,18 @@ private static void validatePort(String name, int port) {\n     public String toString() {\n         return \"Endpoint(\" + authority() + ')';\n     }\n+\n+    @Override\n+    public boolean equals(Object obj) {\n+        if (obj instanceof Endpoint) {","path":"core/src/main/java/com/linecorp/armeria/client/Endpoint.java","position":7,"original_position":7,"commit_id":"f9e0251d0f20d616b1e03e284ae8c2031cc1599b","original_commit_id":"f9e0251d0f20d616b1e03e284ae8c2031cc1599b","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"Please add `this == obj` check","created_at":"2016-11-03T03:44:44Z","updated_at":"2016-11-03T03:44:44Z","html_url":"https://github.com/line/armeria/pull/320#discussion_r86283106","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/86283106"},"html":{"href":"https://github.com/line/armeria/pull/320#discussion_r86283106"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/320","id":91955917,"html_url":"https://github.com/line/armeria/pull/320","diff_url":"https://github.com/line/armeria/pull/320.diff","patch_url":"https://github.com/line/armeria/pull/320.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/320","number":320,"state":"open","locked":false,"title":"Master","user":{"login":"jonefeewang","id":3032599,"avatar_url":"https://avatars.githubusercontent.com/u/3032599?v=3","gravatar_id":"","url":"https://api.github.com/users/jonefeewang","html_url":"https://github.com/jonefeewang","followers_url":"https://api.github.com/users/jonefeewang/followers","following_url":"https://api.github.com/users/jonefeewang/following{/other_user}","gists_url":"https://api.github.com/users/jonefeewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonefeewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonefeewang/subscriptions","organizations_url":"https://api.github.com/users/jonefeewang/orgs","repos_url":"https://api.github.com/users/jonefeewang/repos","events_url":"https://api.github.com/users/jonefeewang/events{/privacy}","received_events_url":"https://api.github.com/users/jonefeewang/received_events","type":"User","site_admin":false},"body":"add a zookeeper EndpointGroup implementation .It will get the group information from a zookeeper zNode, any update to it will  reflect asynchronously to the system","created_at":"2016-11-02T11:55:06Z","updated_at":"2016-11-03T03:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97582123e4165c3b3d4e6669d9a2eb217f362a94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/line/armeria/pulls/320/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/320/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/320/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/f9e0251d0f20d616b1e03e284ae8c2031cc1599b","head":{"label":"jonefeewang:master","ref":"master","sha":"f9e0251d0f20d616b1e03e284ae8c2031cc1599b","user":{"login":"jonefeewang","id":3032599,"avatar_url":"https://avatars.githubusercontent.com/u/3032599?v=3","gravatar_id":"","url":"https://api.github.com/users/jonefeewang","html_url":"https://github.com/jonefeewang","followers_url":"https://api.github.com/users/jonefeewang/followers","following_url":"https://api.github.com/users/jonefeewang/following{/other_user}","gists_url":"https://api.github.com/users/jonefeewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonefeewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonefeewang/subscriptions","organizations_url":"https://api.github.com/users/jonefeewang/orgs","repos_url":"https://api.github.com/users/jonefeewang/repos","events_url":"https://api.github.com/users/jonefeewang/events{/privacy}","received_events_url":"https://api.github.com/users/jonefeewang/received_events","type":"User","site_admin":false},"repo":{"id":67778997,"name":"armeria","full_name":"jonefeewang/armeria","owner":{"login":"jonefeewang","id":3032599,"avatar_url":"https://avatars.githubusercontent.com/u/3032599?v=3","gravatar_id":"","url":"https://api.github.com/users/jonefeewang","html_url":"https://github.com/jonefeewang","followers_url":"https://api.github.com/users/jonefeewang/followers","following_url":"https://api.github.com/users/jonefeewang/following{/other_user}","gists_url":"https://api.github.com/users/jonefeewang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonefeewang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonefeewang/subscriptions","organizations_url":"https://api.github.com/users/jonefeewang/orgs","repos_url":"https://api.github.com/users/jonefeewang/repos","events_url":"https://api.github.com/users/jonefeewang/events{/privacy}","received_events_url":"https://api.github.com/users/jonefeewang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonefeewang/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/jonefeewang/armeria","forks_url":"https://api.github.com/repos/jonefeewang/armeria/forks","keys_url":"https://api.github.com/repos/jonefeewang/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonefeewang/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonefeewang/armeria/teams","hooks_url":"https://api.github.com/repos/jonefeewang/armeria/hooks","issue_events_url":"https://api.github.com/repos/jonefeewang/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/jonefeewang/armeria/events","assignees_url":"https://api.github.com/repos/jonefeewang/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/jonefeewang/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/jonefeewang/armeria/tags","blobs_url":"https://api.github.com/repos/jonefeewang/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonefeewang/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonefeewang/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonefeewang/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonefeewang/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/jonefeewang/armeria/languages","stargazers_url":"https://api.github.com/repos/jonefeewang/armeria/stargazers","contributors_url":"https://api.github.com/repos/jonefeewang/armeria/contributors","subscribers_url":"https://api.github.com/repos/jonefeewang/armeria/subscribers","subscription_url":"https://api.github.com/repos/jonefeewang/armeria/subscription","commits_url":"https://api.github.com/repos/jonefeewang/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonefeewang/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonefeewang/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonefeewang/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonefeewang/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/jonefeewang/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonefeewang/armeria/merges","archive_url":"https://api.github.com/repos/jonefeewang/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonefeewang/armeria/downloads","issues_url":"https://api.github.com/repos/jonefeewang/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/jonefeewang/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/jonefeewang/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/jonefeewang/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonefeewang/armeria/labels{/name}","releases_url":"https://api.github.com/repos/jonefeewang/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/jonefeewang/armeria/deployments","created_at":"2016-09-09T08:00:04Z","updated_at":"2016-09-09T08:00:07Z","pushed_at":"2016-11-02T11:52:11Z","git_url":"git://github.com/jonefeewang/armeria.git","ssh_url":"git@github.com:jonefeewang/armeria.git","clone_url":"https://github.com/jonefeewang/armeria.git","svn_url":"https://github.com/jonefeewang/armeria","homepage":"http://line.github.io/armeria/","size":13520,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"d0f482bdc72fa3ad7717efdccf8bfca57f4484bf","user":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars.githubusercontent.com/u/13128444?v=3","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2016-10-29T16:45:41Z","pushed_at":"2016-11-02T11:55:06Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":15238,"stargazers_count":566,"watchers_count":566,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":136,"mirror_url":null,"open_issues_count":33,"forks":136,"open_issues":33,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/320"},"html":{"href":"https://github.com/line/armeria/pull/320"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/320"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/f9e0251d0f20d616b1e03e284ae8c2031cc1599b"}}}}
{"actor":{"display_login":"trustin"}}