{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip-electron/pulls/69","id":84766548,"html_url":"https://github.com/zulip/zulip-electron/pull/69","diff_url":"https://github.com/zulip/zulip-electron/pull/69.diff","patch_url":"https://github.com/zulip/zulip-electron/pull/69.patch","issue_url":"https://api.github.com/repos/zulip/zulip-electron/issues/69","number":69,"state":"closed","locked":false,"title":"Use the standard method to get the electron app location","user":{"login":"steele","id":704294,"avatar_url":"https://avatars.githubusercontent.com/u/704294?v=3","gravatar_id":"","url":"https://api.github.com/users/steele","html_url":"https://github.com/steele","followers_url":"https://api.github.com/users/steele/followers","following_url":"https://api.github.com/users/steele/following{/other_user}","gists_url":"https://api.github.com/users/steele/gists{/gist_id}","starred_url":"https://api.github.com/users/steele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steele/subscriptions","organizations_url":"https://api.github.com/users/steele/orgs","repos_url":"https://api.github.com/users/steele/repos","events_url":"https://api.github.com/users/steele/events{/privacy}","received_events_url":"https://api.github.com/users/steele/received_events","type":"User","site_admin":false},"body":"When running \"npm run test\" under Windows, the tests failed to run as there was a general failure to launch the electron application. This was due to the gulpfile.js specifying the node_modules/.bin/electron file directly.\r\n\r\nAs per the guidance at https://github.com/electron-userland/electron-prebuilt programmatic usage acquires the path to electron by require('electron'). This change now results in a success test execution of the project on my Windows system.\r\n\r\nTested Zulip-Desktop 0.3.1 (based upon e12ad6e) on Windows 7 Enteprise SP1","created_at":"2016-09-10T20:14:42Z","updated_at":"2016-09-10T20:24:23Z","closed_at":"2016-09-10T20:24:23Z","merged_at":"2016-09-10T20:24:22Z","merge_commit_sha":"5cc3bf0dc8fcfa16c8ac8980dca519215ef78400","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/69/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/69/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip-electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip-electron/issues/69/comments","statuses_url":"https://api.github.com/repos/zulip/zulip-electron/statuses/c594979d9be6b93542095108b04a723501ca9e12","head":{"label":"steele:windows-test-fix","ref":"windows-test-fix","sha":"c594979d9be6b93542095108b04a723501ca9e12","user":{"login":"steele","id":704294,"avatar_url":"https://avatars.githubusercontent.com/u/704294?v=3","gravatar_id":"","url":"https://api.github.com/users/steele","html_url":"https://github.com/steele","followers_url":"https://api.github.com/users/steele/followers","following_url":"https://api.github.com/users/steele/following{/other_user}","gists_url":"https://api.github.com/users/steele/gists{/gist_id}","starred_url":"https://api.github.com/users/steele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steele/subscriptions","organizations_url":"https://api.github.com/users/steele/orgs","repos_url":"https://api.github.com/users/steele/repos","events_url":"https://api.github.com/users/steele/events{/privacy}","received_events_url":"https://api.github.com/users/steele/received_events","type":"User","site_admin":false},"repo":{"id":67793085,"name":"zulip-electron","full_name":"steele/zulip-electron","owner":{"login":"steele","id":704294,"avatar_url":"https://avatars.githubusercontent.com/u/704294?v=3","gravatar_id":"","url":"https://api.github.com/users/steele","html_url":"https://github.com/steele","followers_url":"https://api.github.com/users/steele/followers","following_url":"https://api.github.com/users/steele/following{/other_user}","gists_url":"https://api.github.com/users/steele/gists{/gist_id}","starred_url":"https://api.github.com/users/steele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steele/subscriptions","organizations_url":"https://api.github.com/users/steele/orgs","repos_url":"https://api.github.com/users/steele/repos","events_url":"https://api.github.com/users/steele/events{/privacy}","received_events_url":"https://api.github.com/users/steele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steele/zulip-electron","description":":boom: Zulip Desktop Client [WIP]","fork":true,"url":"https://api.github.com/repos/steele/zulip-electron","forks_url":"https://api.github.com/repos/steele/zulip-electron/forks","keys_url":"https://api.github.com/repos/steele/zulip-electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steele/zulip-electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steele/zulip-electron/teams","hooks_url":"https://api.github.com/repos/steele/zulip-electron/hooks","issue_events_url":"https://api.github.com/repos/steele/zulip-electron/issues/events{/number}","events_url":"https://api.github.com/repos/steele/zulip-electron/events","assignees_url":"https://api.github.com/repos/steele/zulip-electron/assignees{/user}","branches_url":"https://api.github.com/repos/steele/zulip-electron/branches{/branch}","tags_url":"https://api.github.com/repos/steele/zulip-electron/tags","blobs_url":"https://api.github.com/repos/steele/zulip-electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steele/zulip-electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steele/zulip-electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/steele/zulip-electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steele/zulip-electron/statuses/{sha}","languages_url":"https://api.github.com/repos/steele/zulip-electron/languages","stargazers_url":"https://api.github.com/repos/steele/zulip-electron/stargazers","contributors_url":"https://api.github.com/repos/steele/zulip-electron/contributors","subscribers_url":"https://api.github.com/repos/steele/zulip-electron/subscribers","subscription_url":"https://api.github.com/repos/steele/zulip-electron/subscription","commits_url":"https://api.github.com/repos/steele/zulip-electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/steele/zulip-electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/steele/zulip-electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/steele/zulip-electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/steele/zulip-electron/contents/{+path}","compare_url":"https://api.github.com/repos/steele/zulip-electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steele/zulip-electron/merges","archive_url":"https://api.github.com/repos/steele/zulip-electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steele/zulip-electron/downloads","issues_url":"https://api.github.com/repos/steele/zulip-electron/issues{/number}","pulls_url":"https://api.github.com/repos/steele/zulip-electron/pulls{/number}","milestones_url":"https://api.github.com/repos/steele/zulip-electron/milestones{/number}","notifications_url":"https://api.github.com/repos/steele/zulip-electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steele/zulip-electron/labels{/name}","releases_url":"https://api.github.com/repos/steele/zulip-electron/releases{/id}","deployments_url":"https://api.github.com/repos/steele/zulip-electron/deployments","created_at":"2016-09-09T11:19:05Z","updated_at":"2016-09-09T11:19:06Z","pushed_at":"2016-09-10T20:04:55Z","git_url":"git://github.com/steele/zulip-electron.git","ssh_url":"git@github.com:steele/zulip-electron.git","clone_url":"https://github.com/steele/zulip-electron.git","svn_url":"https://github.com/steele/zulip-electron","homepage":"","size":269,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"e12ad6e1d54b0cdb4c26fdba5beb5959addf7dd8","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":60656871,"name":"zulip-electron","full_name":"zulip/zulip-electron","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip-electron","description":":boom: Zulip Desktop Client [WIP]","fork":false,"url":"https://api.github.com/repos/zulip/zulip-electron","forks_url":"https://api.github.com/repos/zulip/zulip-electron/forks","keys_url":"https://api.github.com/repos/zulip/zulip-electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip-electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip-electron/teams","hooks_url":"https://api.github.com/repos/zulip/zulip-electron/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip-electron/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip-electron/events","assignees_url":"https://api.github.com/repos/zulip/zulip-electron/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip-electron/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip-electron/tags","blobs_url":"https://api.github.com/repos/zulip/zulip-electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip-electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip-electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip-electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip-electron/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip-electron/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip-electron/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip-electron/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip-electron/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip-electron/subscription","commits_url":"https://api.github.com/repos/zulip/zulip-electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip-electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip-electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip-electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip-electron/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip-electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip-electron/merges","archive_url":"https://api.github.com/repos/zulip/zulip-electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip-electron/downloads","issues_url":"https://api.github.com/repos/zulip/zulip-electron/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip-electron/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip-electron/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip-electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip-electron/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip-electron/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip-electron/deployments","created_at":"2016-06-08T00:48:28Z","updated_at":"2016-08-28T08:14:00Z","pushed_at":"2016-09-10T20:24:22Z","git_url":"git://github.com/zulip/zulip-electron.git","ssh_url":"git@github.com:zulip/zulip-electron.git","clone_url":"https://github.com/zulip/zulip-electron.git","svn_url":"https://github.com/zulip/zulip-electron","homepage":"","size":276,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":17,"forks":13,"open_issues":17,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/69"},"html":{"href":"https://github.com/zulip/zulip-electron/pull/69"},"issue":{"href":"https://api.github.com/repos/zulip/zulip-electron/issues/69"},"comments":{"href":"https://api.github.com/repos/zulip/zulip-electron/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip-electron/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip-electron/statuses/c594979d9be6b93542095108b04a723501ca9e12"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"akashnimare","id":2263909,"avatar_url":"https://avatars.githubusercontent.com/u/2263909?v=3","gravatar_id":"","url":"https://api.github.com/users/akashnimare","html_url":"https://github.com/akashnimare","followers_url":"https://api.github.com/users/akashnimare/followers","following_url":"https://api.github.com/users/akashnimare/following{/other_user}","gists_url":"https://api.github.com/users/akashnimare/gists{/gist_id}","starred_url":"https://api.github.com/users/akashnimare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akashnimare/subscriptions","organizations_url":"https://api.github.com/users/akashnimare/orgs","repos_url":"https://api.github.com/users/akashnimare/repos","events_url":"https://api.github.com/users/akashnimare/events{/privacy}","received_events_url":"https://api.github.com/users/akashnimare/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"akashnimare"}}