{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/77594438","id":77594438,"diff_hunk":"@@ -127,24 +124,24 @@ def download(self, reference, package_ids, remote=None):\n         @param remote: install only from that remote\n         \"\"\"\n         assert(isinstance(reference, ConanFileReference))\n-        remote_proxy = ConanProxy(self._paths, self._user_io, self._remote_manager, remote)\n+        remote_proxy = ConanProxy(self._client_cache, self._user_io, self._remote_manager, remote)\n \n         if package_ids:\n             remote_proxy.download_packages(reference, package_ids)\n         else:  # Not specified packages, download all\n-            info = remote_proxy.search(str(reference), ignorecase=False)\n-            if reference not in info:\n+            packages_props = remote_proxy.search_packages(reference, \"\") # No filter by properties","path":"conans/client/manager.py","position":83,"original_position":83,"commit_id":"f12c885364197cf3ca3734ae969d8dfc0c008783","original_commit_id":"f12c885364197cf3ca3734ae969d8dfc0c008783","user":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars.githubusercontent.com/u/15367152?v=3","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"body":"Check if second parameter should be None instead of \"\". And write a test if not existing.","created_at":"2016-09-06T08:44:39Z","updated_at":"2016-09-06T08:44:39Z","html_url":"https://github.com/conan-io/conan/pull/460#discussion_r77594438","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/77594438"},"html":{"href":"https://github.com/conan-io/conan/pull/460#discussion_r77594438"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/460","id":84081160,"html_url":"https://github.com/conan-io/conan/pull/460","diff_url":"https://github.com/conan-io/conan/pull/460.diff","patch_url":"https://github.com/conan-io/conan/pull/460.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/460","number":460,"state":"open","locked":false,"title":"Feature/stores refactor and search divided","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars.githubusercontent.com/u/3807515?v=3","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-06T08:35:51Z","updated_at":"2016-09-06T08:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3c4cb30e6d1ab80476437bd4574e218f23965b9","assignee":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars.githubusercontent.com/u/15367152?v=3","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"assignees":[{"login":"memsharded","id":15367152,"avatar_url":"https://avatars.githubusercontent.com/u/15367152?v=3","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/460/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/460/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/460/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/f12c885364197cf3ca3734ae969d8dfc0c008783","head":{"label":"lasote:feature/stores_refactor_and_search_divided","ref":"feature/stores_refactor_and_search_divided","sha":"f12c885364197cf3ca3734ae969d8dfc0c008783","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars.githubusercontent.com/u/3807515?v=3","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"repo":{"id":47204017,"name":"conan","full_name":"lasote/conan","owner":{"login":"lasote","id":3807515,"avatar_url":"https://avatars.githubusercontent.com/u/3807515?v=3","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lasote/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/lasote/conan","forks_url":"https://api.github.com/repos/lasote/conan/forks","keys_url":"https://api.github.com/repos/lasote/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lasote/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lasote/conan/teams","hooks_url":"https://api.github.com/repos/lasote/conan/hooks","issue_events_url":"https://api.github.com/repos/lasote/conan/issues/events{/number}","events_url":"https://api.github.com/repos/lasote/conan/events","assignees_url":"https://api.github.com/repos/lasote/conan/assignees{/user}","branches_url":"https://api.github.com/repos/lasote/conan/branches{/branch}","tags_url":"https://api.github.com/repos/lasote/conan/tags","blobs_url":"https://api.github.com/repos/lasote/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lasote/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lasote/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/lasote/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lasote/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/lasote/conan/languages","stargazers_url":"https://api.github.com/repos/lasote/conan/stargazers","contributors_url":"https://api.github.com/repos/lasote/conan/contributors","subscribers_url":"https://api.github.com/repos/lasote/conan/subscribers","subscription_url":"https://api.github.com/repos/lasote/conan/subscription","commits_url":"https://api.github.com/repos/lasote/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/lasote/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/lasote/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/lasote/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/lasote/conan/contents/{+path}","compare_url":"https://api.github.com/repos/lasote/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lasote/conan/merges","archive_url":"https://api.github.com/repos/lasote/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lasote/conan/downloads","issues_url":"https://api.github.com/repos/lasote/conan/issues{/number}","pulls_url":"https://api.github.com/repos/lasote/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/lasote/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/lasote/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lasote/conan/labels{/name}","releases_url":"https://api.github.com/repos/lasote/conan/releases{/id}","deployments_url":"https://api.github.com/repos/lasote/conan/deployments","created_at":"2015-12-01T16:56:42Z","updated_at":"2016-01-11T09:54:04Z","pushed_at":"2016-09-06T07:57:36Z","git_url":"git://github.com/lasote/conan.git","ssh_url":"git@github.com:lasote/conan.git","clone_url":"https://github.com/lasote/conan.git","svn_url":"https://github.com/lasote/conan","homepage":"https://conan.io","size":1145,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"c55c5840680c95f8fbecbeca7bf36fde0edea86b","user":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2016-09-05T06:09:03Z","pushed_at":"2016-09-06T08:35:51Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":1107,"stargazers_count":555,"watchers_count":555,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":67,"forks":56,"open_issues":67,"watchers":555,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/460"},"html":{"href":"https://github.com/conan-io/conan/pull/460"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/460"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/f12c885364197cf3ca3734ae969d8dfc0c008783"}}}}
{"actor":{"display_login":"memsharded"}}