{"action":"created","comment":{"url":"https://api.github.com/repos/gocd/gocd/pulls/comments/65873922","id":65873922,"diff_hunk":"@@ -339,4 +348,18 @@ public void setEntityId(Long entityId) {\n     public void setEntityType(String entityType) {\n         this.entityType = entityType;\n     }\n+\n+    @Override\n+    public ConfigOrigin getOrigin() {\n+        return origin;\n+    }\n+\n+    public boolean isRemote()\n+    {\n+        return origin != null && !origin.isLocal();","path":"config/config-api/src/com/thoughtworks/go/config/EnvironmentVariableConfig.java","position":44,"original_position":44,"commit_id":"7ae5136df6acca638f653f8a1956d7720bd28eab","original_commit_id":"7ae5136df6acca638f653f8a1956d7720bd28eab","user":{"login":"tomzo","id":5710970,"avatar_url":"https://avatars.githubusercontent.com/u/5710970?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzo","html_url":"https://github.com/tomzo","followers_url":"https://api.github.com/users/tomzo/followers","following_url":"https://api.github.com/users/tomzo/following{/other_user}","gists_url":"https://api.github.com/users/tomzo/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzo/subscriptions","organizations_url":"https://api.github.com/users/tomzo/orgs","repos_url":"https://api.github.com/users/tomzo/repos","events_url":"https://api.github.com/users/tomzo/events{/privacy}","received_events_url":"https://api.github.com/users/tomzo/received_events","type":"User","site_admin":false},"body":"So you mean we could have something like\r\n```\r\nprivate ConfigOrigin origin = new NullOrigin();\r\n```\r\nin all classes that have `origin` field?\r\nI think it might not work in all cases, e.g. magical loader instantiates elements by reflection, it would be null then. But we can try. Do you want a commit added in this PR or should we refactor with your changes too?","created_at":"2016-06-06T11:19:38Z","updated_at":"2016-06-06T11:19:38Z","html_url":"https://github.com/gocd/gocd/pull/2265#discussion_r65873922","pull_request_url":"https://api.github.com/repos/gocd/gocd/pulls/2265","_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments/65873922"},"html":{"href":"https://github.com/gocd/gocd/pull/2265#discussion_r65873922"},"pull_request":{"href":"https://api.github.com/repos/gocd/gocd/pulls/2265"}}},"pull_request":{"url":"https://api.github.com/repos/gocd/gocd/pulls/2265","id":72626445,"html_url":"https://github.com/gocd/gocd/pull/2265","diff_url":"https://github.com/gocd/gocd/pull/2265.diff","patch_url":"https://github.com/gocd/gocd/pull/2265.patch","issue_url":"https://api.github.com/repos/gocd/gocd/issues/2265","number":2265,"state":"open","locked":false,"title":"1133 rails ui","user":{"login":"tomzo","id":5710970,"avatar_url":"https://avatars.githubusercontent.com/u/5710970?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzo","html_url":"https://github.com/tomzo","followers_url":"https://api.github.com/users/tomzo/followers","following_url":"https://api.github.com/users/tomzo/following{/other_user}","gists_url":"https://api.github.com/users/tomzo/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzo/subscriptions","organizations_url":"https://api.github.com/users/tomzo/orgs","repos_url":"https://api.github.com/users/tomzo/repos","events_url":"https://api.github.com/users/tomzo/events{/privacy}","received_events_url":"https://api.github.com/users/tomzo/received_events","type":"User","site_admin":false},"body":"\"Rails only\" changes to display only local elements of configurations.\r\nThis is non-functional, mostly updates in views. A few changes in java to split remote from local config.\r\n\r\nI have extracted these commits from #1810, there will be a second PR on top of #2256\r\n\r\n@jyotisingh I think you saw these all changes in this PR already. If you are fine with it, then I'd like it to be merged first. Then we can discuss #2256 and my second PR #2266","created_at":"2016-06-05T11:00:56Z","updated_at":"2016-06-06T11:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e2a9f19797ccbe25b1efdffbbe11f1364fcf8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gocd/gocd/pulls/2265/commits","review_comments_url":"https://api.github.com/repos/gocd/gocd/pulls/2265/comments","review_comment_url":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gocd/gocd/issues/2265/comments","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/7ae5136df6acca638f653f8a1956d7720bd28eab","head":{"label":"tomzo:1133-rails-ui","ref":"1133-rails-ui","sha":"7ae5136df6acca638f653f8a1956d7720bd28eab","user":{"login":"tomzo","id":5710970,"avatar_url":"https://avatars.githubusercontent.com/u/5710970?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzo","html_url":"https://github.com/tomzo","followers_url":"https://api.github.com/users/tomzo/followers","following_url":"https://api.github.com/users/tomzo/following{/other_user}","gists_url":"https://api.github.com/users/tomzo/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzo/subscriptions","organizations_url":"https://api.github.com/users/tomzo/orgs","repos_url":"https://api.github.com/users/tomzo/repos","events_url":"https://api.github.com/users/tomzo/events{/privacy}","received_events_url":"https://api.github.com/users/tomzo/received_events","type":"User","site_admin":false},"repo":{"id":36937918,"name":"gocd","full_name":"tomzo/gocd","owner":{"login":"tomzo","id":5710970,"avatar_url":"https://avatars.githubusercontent.com/u/5710970?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzo","html_url":"https://github.com/tomzo","followers_url":"https://api.github.com/users/tomzo/followers","following_url":"https://api.github.com/users/tomzo/following{/other_user}","gists_url":"https://api.github.com/users/tomzo/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzo/subscriptions","organizations_url":"https://api.github.com/users/tomzo/orgs","repos_url":"https://api.github.com/users/tomzo/repos","events_url":"https://api.github.com/users/tomzo/events{/privacy}","received_events_url":"https://api.github.com/users/tomzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomzo/gocd","description":"Fork of Go Continuous Delivery with implemented configuration from source control","fork":true,"url":"https://api.github.com/repos/tomzo/gocd","forks_url":"https://api.github.com/repos/tomzo/gocd/forks","keys_url":"https://api.github.com/repos/tomzo/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomzo/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomzo/gocd/teams","hooks_url":"https://api.github.com/repos/tomzo/gocd/hooks","issue_events_url":"https://api.github.com/repos/tomzo/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/tomzo/gocd/events","assignees_url":"https://api.github.com/repos/tomzo/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/tomzo/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/tomzo/gocd/tags","blobs_url":"https://api.github.com/repos/tomzo/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomzo/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomzo/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomzo/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomzo/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/tomzo/gocd/languages","stargazers_url":"https://api.github.com/repos/tomzo/gocd/stargazers","contributors_url":"https://api.github.com/repos/tomzo/gocd/contributors","subscribers_url":"https://api.github.com/repos/tomzo/gocd/subscribers","subscription_url":"https://api.github.com/repos/tomzo/gocd/subscription","commits_url":"https://api.github.com/repos/tomzo/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomzo/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomzo/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomzo/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomzo/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/tomzo/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomzo/gocd/merges","archive_url":"https://api.github.com/repos/tomzo/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomzo/gocd/downloads","issues_url":"https://api.github.com/repos/tomzo/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/tomzo/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/tomzo/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/tomzo/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomzo/gocd/labels{/name}","releases_url":"https://api.github.com/repos/tomzo/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/tomzo/gocd/deployments","created_at":"2015-06-05T14:42:08Z","updated_at":"2016-01-23T19:45:08Z","pushed_at":"2016-06-05T15:22:23Z","git_url":"git://github.com/tomzo/gocd.git","ssh_url":"git@github.com:tomzo/gocd.git","clone_url":"https://github.com/tomzo/gocd.git","svn_url":"https://github.com/tomzo/gocd","homepage":"","size":234618,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"15.3"}},"base":{"label":"gocd:master","ref":"master","sha":"46370d56753cd2b161fb3fef9fc6a820a32f5c88","user":{"login":"gocd","id":6099846,"avatar_url":"https://avatars.githubusercontent.com/u/6099846?v=3","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"repo":{"id":15155534,"name":"gocd","full_name":"gocd/gocd","owner":{"login":"gocd","id":6099846,"avatar_url":"https://avatars.githubusercontent.com/u/6099846?v=3","gravatar_id":"","url":"https://api.github.com/users/gocd","html_url":"https://github.com/gocd","followers_url":"https://api.github.com/users/gocd/followers","following_url":"https://api.github.com/users/gocd/following{/other_user}","gists_url":"https://api.github.com/users/gocd/gists{/gist_id}","starred_url":"https://api.github.com/users/gocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocd/subscriptions","organizations_url":"https://api.github.com/users/gocd/orgs","repos_url":"https://api.github.com/users/gocd/repos","events_url":"https://api.github.com/users/gocd/events{/privacy}","received_events_url":"https://api.github.com/users/gocd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gocd/gocd","description":"Main repository for GoCD - Continuous Delivery server","fork":false,"url":"https://api.github.com/repos/gocd/gocd","forks_url":"https://api.github.com/repos/gocd/gocd/forks","keys_url":"https://api.github.com/repos/gocd/gocd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gocd/gocd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gocd/gocd/teams","hooks_url":"https://api.github.com/repos/gocd/gocd/hooks","issue_events_url":"https://api.github.com/repos/gocd/gocd/issues/events{/number}","events_url":"https://api.github.com/repos/gocd/gocd/events","assignees_url":"https://api.github.com/repos/gocd/gocd/assignees{/user}","branches_url":"https://api.github.com/repos/gocd/gocd/branches{/branch}","tags_url":"https://api.github.com/repos/gocd/gocd/tags","blobs_url":"https://api.github.com/repos/gocd/gocd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gocd/gocd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gocd/gocd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gocd/gocd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gocd/gocd/statuses/{sha}","languages_url":"https://api.github.com/repos/gocd/gocd/languages","stargazers_url":"https://api.github.com/repos/gocd/gocd/stargazers","contributors_url":"https://api.github.com/repos/gocd/gocd/contributors","subscribers_url":"https://api.github.com/repos/gocd/gocd/subscribers","subscription_url":"https://api.github.com/repos/gocd/gocd/subscription","commits_url":"https://api.github.com/repos/gocd/gocd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gocd/gocd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gocd/gocd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gocd/gocd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gocd/gocd/contents/{+path}","compare_url":"https://api.github.com/repos/gocd/gocd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gocd/gocd/merges","archive_url":"https://api.github.com/repos/gocd/gocd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gocd/gocd/downloads","issues_url":"https://api.github.com/repos/gocd/gocd/issues{/number}","pulls_url":"https://api.github.com/repos/gocd/gocd/pulls{/number}","milestones_url":"https://api.github.com/repos/gocd/gocd/milestones{/number}","notifications_url":"https://api.github.com/repos/gocd/gocd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gocd/gocd/labels{/name}","releases_url":"https://api.github.com/repos/gocd/gocd/releases{/id}","deployments_url":"https://api.github.com/repos/gocd/gocd/deployments","created_at":"2013-12-13T05:26:16Z","updated_at":"2016-06-06T07:25:18Z","pushed_at":"2016-06-06T11:00:34Z","git_url":"git://github.com/gocd/gocd.git","ssh_url":"git@github.com:gocd/gocd.git","clone_url":"https://github.com/gocd/gocd.git","svn_url":"https://github.com/gocd/gocd","homepage":"https://go.cd","size":306366,"stargazers_count":2407,"watchers_count":2407,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":428,"mirror_url":null,"open_issues_count":623,"forks":428,"open_issues":623,"watchers":2407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gocd/gocd/pulls/2265"},"html":{"href":"https://github.com/gocd/gocd/pull/2265"},"issue":{"href":"https://api.github.com/repos/gocd/gocd/issues/2265"},"comments":{"href":"https://api.github.com/repos/gocd/gocd/issues/2265/comments"},"review_comments":{"href":"https://api.github.com/repos/gocd/gocd/pulls/2265/comments"},"review_comment":{"href":"https://api.github.com/repos/gocd/gocd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gocd/gocd/pulls/2265/commits"},"statuses":{"href":"https://api.github.com/repos/gocd/gocd/statuses/7ae5136df6acca638f653f8a1956d7720bd28eab"}}}}
{"actor":{"display_login":"tomzo"}}