{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/78129910","id":78129910,"diff_hunk":"@@ -330,22 +508,32 @@ def _enqueue_feedback_thread_status_change_email_task(\n \n \n def _enqueue_suggestion_email_task(exploration_id, thread_id):\n-    \"\"\"Adds a 'send suggestion email' task into taskqueue.\"\"\"\n+    \"\"\"Adds a 'send suggestion email' task into task queue.\n+\n+    Args:\n+        exploration_id: str.\n+        thread_is: str.\n+    \"\"\"\n \n     payload = {\n         'exploration_id': exploration_id,\n         'thread_id': thread_id\n     }\n-    # Suggestion emails are sent immidiately.\n+    # Suggestion emails are sent immediately.","path":"core/domain/feedback_services.py","position":428,"original_position":428,"commit_id":"6880cef3c574df6470cc24210644ec7360ab76f4","original_commit_id":"6880cef3c574df6470cc24210644ec7360ab76f4","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"+1, thanks!","created_at":"2016-09-09T05:15:56Z","updated_at":"2016-09-09T05:15:56Z","html_url":"https://github.com/oppia/oppia/pull/2465#discussion_r78129910","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/2465","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/78129910"},"html":{"href":"https://github.com/oppia/oppia/pull/2465#discussion_r78129910"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/2465"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/2465","id":84506910,"html_url":"https://github.com/oppia/oppia/pull/2465","diff_url":"https://github.com/oppia/oppia/pull/2465.diff","patch_url":"https://github.com/oppia/oppia/pull/2465.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/2465","number":2465,"state":"open","locked":false,"title":"Add docstring for feedback_service.py","user":{"login":"Andimeo","id":5801576,"avatar_url":"https://avatars.githubusercontent.com/u/5801576?v=3","gravatar_id":"","url":"https://api.github.com/users/Andimeo","html_url":"https://github.com/Andimeo","followers_url":"https://api.github.com/users/Andimeo/followers","following_url":"https://api.github.com/users/Andimeo/following{/other_user}","gists_url":"https://api.github.com/users/Andimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Andimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andimeo/subscriptions","organizations_url":"https://api.github.com/users/Andimeo/orgs","repos_url":"https://api.github.com/users/Andimeo/repos","events_url":"https://api.github.com/users/Andimeo/events{/privacy}","received_events_url":"https://api.github.com/users/Andimeo/received_events","type":"User","site_admin":false},"body":"Add docstring for feedback_service.py.\r\n\r\nNote: for some obvious arguments I'd rather not put any verbose explanation. The variable name explains everything.","created_at":"2016-09-08T16:05:19Z","updated_at":"2016-09-09T05:15:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ac4787ae8459b74aab3e991a0ab5182d24fd461","assignee":{"login":"wxyxinyu","id":5061134,"avatar_url":"https://avatars.githubusercontent.com/u/5061134?v=3","gravatar_id":"","url":"https://api.github.com/users/wxyxinyu","html_url":"https://github.com/wxyxinyu","followers_url":"https://api.github.com/users/wxyxinyu/followers","following_url":"https://api.github.com/users/wxyxinyu/following{/other_user}","gists_url":"https://api.github.com/users/wxyxinyu/gists{/gist_id}","starred_url":"https://api.github.com/users/wxyxinyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxyxinyu/subscriptions","organizations_url":"https://api.github.com/users/wxyxinyu/orgs","repos_url":"https://api.github.com/users/wxyxinyu/repos","events_url":"https://api.github.com/users/wxyxinyu/events{/privacy}","received_events_url":"https://api.github.com/users/wxyxinyu/received_events","type":"User","site_admin":false},"assignees":[{"login":"wxyxinyu","id":5061134,"avatar_url":"https://avatars.githubusercontent.com/u/5061134?v=3","gravatar_id":"","url":"https://api.github.com/users/wxyxinyu","html_url":"https://github.com/wxyxinyu","followers_url":"https://api.github.com/users/wxyxinyu/followers","following_url":"https://api.github.com/users/wxyxinyu/following{/other_user}","gists_url":"https://api.github.com/users/wxyxinyu/gists{/gist_id}","starred_url":"https://api.github.com/users/wxyxinyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxyxinyu/subscriptions","organizations_url":"https://api.github.com/users/wxyxinyu/orgs","repos_url":"https://api.github.com/users/wxyxinyu/repos","events_url":"https://api.github.com/users/wxyxinyu/events{/privacy}","received_events_url":"https://api.github.com/users/wxyxinyu/received_events","type":"User","site_admin":false},{"login":"seanlip","id":10575562,"avatar_url":"https://avatars.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/2465/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/2465/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/2465/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/6880cef3c574df6470cc24210644ec7360ab76f4","head":{"label":"Andimeo:docstring","ref":"docstring","sha":"6880cef3c574df6470cc24210644ec7360ab76f4","user":{"login":"Andimeo","id":5801576,"avatar_url":"https://avatars.githubusercontent.com/u/5801576?v=3","gravatar_id":"","url":"https://api.github.com/users/Andimeo","html_url":"https://github.com/Andimeo","followers_url":"https://api.github.com/users/Andimeo/followers","following_url":"https://api.github.com/users/Andimeo/following{/other_user}","gists_url":"https://api.github.com/users/Andimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Andimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andimeo/subscriptions","organizations_url":"https://api.github.com/users/Andimeo/orgs","repos_url":"https://api.github.com/users/Andimeo/repos","events_url":"https://api.github.com/users/Andimeo/events{/privacy}","received_events_url":"https://api.github.com/users/Andimeo/received_events","type":"User","site_admin":false},"repo":{"id":67465587,"name":"oppia","full_name":"Andimeo/oppia","owner":{"login":"Andimeo","id":5801576,"avatar_url":"https://avatars.githubusercontent.com/u/5801576?v=3","gravatar_id":"","url":"https://api.github.com/users/Andimeo","html_url":"https://github.com/Andimeo","followers_url":"https://api.github.com/users/Andimeo/followers","following_url":"https://api.github.com/users/Andimeo/following{/other_user}","gists_url":"https://api.github.com/users/Andimeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Andimeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andimeo/subscriptions","organizations_url":"https://api.github.com/users/Andimeo/orgs","repos_url":"https://api.github.com/users/Andimeo/repos","events_url":"https://api.github.com/users/Andimeo/events{/privacy}","received_events_url":"https://api.github.com/users/Andimeo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andimeo/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/Andimeo/oppia","forks_url":"https://api.github.com/repos/Andimeo/oppia/forks","keys_url":"https://api.github.com/repos/Andimeo/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andimeo/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andimeo/oppia/teams","hooks_url":"https://api.github.com/repos/Andimeo/oppia/hooks","issue_events_url":"https://api.github.com/repos/Andimeo/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/Andimeo/oppia/events","assignees_url":"https://api.github.com/repos/Andimeo/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/Andimeo/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/Andimeo/oppia/tags","blobs_url":"https://api.github.com/repos/Andimeo/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andimeo/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andimeo/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andimeo/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andimeo/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/Andimeo/oppia/languages","stargazers_url":"https://api.github.com/repos/Andimeo/oppia/stargazers","contributors_url":"https://api.github.com/repos/Andimeo/oppia/contributors","subscribers_url":"https://api.github.com/repos/Andimeo/oppia/subscribers","subscription_url":"https://api.github.com/repos/Andimeo/oppia/subscription","commits_url":"https://api.github.com/repos/Andimeo/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andimeo/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andimeo/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andimeo/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andimeo/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/Andimeo/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andimeo/oppia/merges","archive_url":"https://api.github.com/repos/Andimeo/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andimeo/oppia/downloads","issues_url":"https://api.github.com/repos/Andimeo/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/Andimeo/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/Andimeo/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/Andimeo/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andimeo/oppia/labels{/name}","releases_url":"https://api.github.com/repos/Andimeo/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/Andimeo/oppia/deployments","created_at":"2016-09-06T02:18:51Z","updated_at":"2016-09-06T02:18:57Z","pushed_at":"2016-09-08T16:02:28Z","git_url":"git://github.com/Andimeo/oppia.git","ssh_url":"git@github.com:Andimeo/oppia.git","clone_url":"https://github.com/Andimeo/oppia.git","svn_url":"https://github.com/Andimeo/oppia","homepage":"https://www.oppia.org","size":47399,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"05d483134c11757bdf3c629787bcf192d6fbddfb","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2016-09-08T18:20:53Z","pushed_at":"2016-09-09T02:41:20Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":89127,"stargazers_count":159,"watchers_count":159,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":350,"forks":248,"open_issues":350,"watchers":159,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/2465"},"html":{"href":"https://github.com/oppia/oppia/pull/2465"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/2465"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/2465/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/2465/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/2465/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/6880cef3c574df6470cc24210644ec7360ab76f4"}}}}
{"actor":{"display_login":"seanlip"}}