{"action":"created","comment":{"url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/comments/76746870","id":76746870,"diff_hunk":"@@ -327,4 +328,31 @@ public Map getMap() {\n \t\t}\n \t\treturn deviceInfo.getDeviceInfo();\n \t}\n+\t\n+\t/**\n+\t * Gets the sensor info\n+\t *\n+\t * @param currentTime the current time\n+\t * @param random      the random object\n+\t * @return the sensor info\n+\t */\n+\tpublic SignatureOuterClass.Signature.SensorInfo getSensorSignature(long currentTime, Random random) {\n+\t\tif (sensorInfo.getSensorInfo() == null || sensorInfo.getTimestampCreate() != 0L) {\n+\t\t\treturn SensorInfo.getDefault(this, currentTime, random);\n+\t\t}\n+\t\treturn sensorInfo.getSensorInfo();\n+\t}\n+\t\n+\t/**\n+\t * Gets the activity status\n+\t *\n+\t * @param random the random object\n+\t * @return the activity status\n+\t */\n+\tpublic SignatureOuterClass.Signature.ActivityStatus getActivitySignature(Random random) {\n+\t\tif (activityStatus.getActivityStatus() == null) {","path":"library/src/main/java/com/pokegoapi/api/PokemonGo.java","position":34,"original_position":34,"commit_id":"322bb86f675fe32403a94652b0fc4fd08018f431","original_commit_id":"322bb86f675fe32403a94652b0fc4fd08018f431","user":{"login":"FabianTerhorst","id":3597376,"avatar_url":"https://avatars.githubusercontent.com/u/3597376?v=3","gravatar_id":"","url":"https://api.github.com/users/FabianTerhorst","html_url":"https://github.com/FabianTerhorst","followers_url":"https://api.github.com/users/FabianTerhorst/followers","following_url":"https://api.github.com/users/FabianTerhorst/following{/other_user}","gists_url":"https://api.github.com/users/FabianTerhorst/gists{/gist_id}","starred_url":"https://api.github.com/users/FabianTerhorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabianTerhorst/subscriptions","organizations_url":"https://api.github.com/users/FabianTerhorst/orgs","repos_url":"https://api.github.com/users/FabianTerhorst/repos","events_url":"https://api.github.com/users/FabianTerhorst/events{/privacy}","received_events_url":"https://api.github.com/users/FabianTerhorst/received_events","type":"User","site_admin":false},"body":"This is not null save","created_at":"2016-08-30T08:03:25Z","updated_at":"2016-08-30T08:03:25Z","html_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/720#discussion_r76746870","pull_request_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720","_links":{"self":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/comments/76746870"},"html":{"href":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/720#discussion_r76746870"},"pull_request":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720"}}},"pull_request":{"url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720","id":83111935,"html_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/720","diff_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/720.diff","patch_url":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/720.patch","issue_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/720","number":720,"state":"closed","locked":false,"title":"Prefer user values to maintain consistency","user":{"login":"LoungeKatt","id":1173913,"avatar_url":"https://avatars.githubusercontent.com/u/1173913?v=3","gravatar_id":"","url":"https://api.github.com/users/LoungeKatt","html_url":"https://github.com/LoungeKatt","followers_url":"https://api.github.com/users/LoungeKatt/followers","following_url":"https://api.github.com/users/LoungeKatt/following{/other_user}","gists_url":"https://api.github.com/users/LoungeKatt/gists{/gist_id}","starred_url":"https://api.github.com/users/LoungeKatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoungeKatt/subscriptions","organizations_url":"https://api.github.com/users/LoungeKatt/orgs","repos_url":"https://api.github.com/users/LoungeKatt/repos","events_url":"https://api.github.com/users/LoungeKatt/events{/privacy}","received_events_url":"https://api.github.com/users/LoungeKatt/received_events","type":"User","site_admin":false},"body":"A random should not be used when a user value exists, since this is supposed to be signing a call by wrapping it with what should be an extended reading of the same device in the same place.\r\n\r\nSensorInfo should favor user values before attempting to instantiate / update a default\r\n\r\nActivityStatus should allow user configuration and favor it before instantiating a default","created_at":"2016-08-29T14:51:52Z","updated_at":"2016-08-30T08:03:25Z","closed_at":"2016-08-30T02:39:49Z","merged_at":"2016-08-30T02:39:49Z","merge_commit_sha":"7117fa52add3ca090123a75aeccb56195a0ea69f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720/commits","review_comments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720/comments","review_comment_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/720/comments","statuses_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/statuses/322bb86f675fe32403a94652b0fc4fd08018f431","head":{"label":"AbandonedCart:devel","ref":"devel","sha":"322bb86f675fe32403a94652b0fc4fd08018f431","user":{"login":"AbandonedCart","id":6947003,"avatar_url":"https://avatars.githubusercontent.com/u/6947003?v=3","gravatar_id":"","url":"https://api.github.com/users/AbandonedCart","html_url":"https://github.com/AbandonedCart","followers_url":"https://api.github.com/users/AbandonedCart/followers","following_url":"https://api.github.com/users/AbandonedCart/following{/other_user}","gists_url":"https://api.github.com/users/AbandonedCart/gists{/gist_id}","starred_url":"https://api.github.com/users/AbandonedCart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbandonedCart/subscriptions","organizations_url":"https://api.github.com/users/AbandonedCart/orgs","repos_url":"https://api.github.com/users/AbandonedCart/repos","events_url":"https://api.github.com/users/AbandonedCart/events{/privacy}","received_events_url":"https://api.github.com/users/AbandonedCart/received_events","type":"Organization","site_admin":false},"repo":{"id":65727557,"name":"PokeGOAPI-Java","full_name":"AbandonedCart/PokeGOAPI-Java","owner":{"login":"AbandonedCart","id":6947003,"avatar_url":"https://avatars.githubusercontent.com/u/6947003?v=3","gravatar_id":"","url":"https://api.github.com/users/AbandonedCart","html_url":"https://github.com/AbandonedCart","followers_url":"https://api.github.com/users/AbandonedCart/followers","following_url":"https://api.github.com/users/AbandonedCart/following{/other_user}","gists_url":"https://api.github.com/users/AbandonedCart/gists{/gist_id}","starred_url":"https://api.github.com/users/AbandonedCart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbandonedCart/subscriptions","organizations_url":"https://api.github.com/users/AbandonedCart/orgs","repos_url":"https://api.github.com/users/AbandonedCart/repos","events_url":"https://api.github.com/users/AbandonedCart/events{/privacy}","received_events_url":"https://api.github.com/users/AbandonedCart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AbandonedCart/PokeGOAPI-Java","description":"Pokemon Go API","fork":true,"url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java","forks_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/forks","keys_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/teams","hooks_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/hooks","issue_events_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/issues/events{/number}","events_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/events","assignees_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/assignees{/user}","branches_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/branches{/branch}","tags_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/tags","blobs_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/languages","stargazers_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/stargazers","contributors_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/contributors","subscribers_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/subscribers","subscription_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/subscription","commits_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/contents/{+path}","compare_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/merges","archive_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/downloads","issues_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/issues{/number}","pulls_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/labels{/name}","releases_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/releases{/id}","deployments_url":"https://api.github.com/repos/AbandonedCart/PokeGOAPI-Java/deployments","created_at":"2016-08-15T11:32:50Z","updated_at":"2016-08-15T11:32:52Z","pushed_at":"2016-08-30T02:35:27Z","git_url":"git://github.com/AbandonedCart/PokeGOAPI-Java.git","ssh_url":"git@github.com:AbandonedCart/PokeGOAPI-Java.git","clone_url":"https://github.com/AbandonedCart/PokeGOAPI-Java.git","svn_url":"https://github.com/AbandonedCart/PokeGOAPI-Java","homepage":null,"size":9715,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"Grover-c13:Development","ref":"Development","sha":"a6bc8c85f23d405a1681245ff56c0c3d7c18250e","user":{"login":"Grover-c13","id":1520101,"avatar_url":"https://avatars.githubusercontent.com/u/1520101?v=3","gravatar_id":"","url":"https://api.github.com/users/Grover-c13","html_url":"https://github.com/Grover-c13","followers_url":"https://api.github.com/users/Grover-c13/followers","following_url":"https://api.github.com/users/Grover-c13/following{/other_user}","gists_url":"https://api.github.com/users/Grover-c13/gists{/gist_id}","starred_url":"https://api.github.com/users/Grover-c13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grover-c13/subscriptions","organizations_url":"https://api.github.com/users/Grover-c13/orgs","repos_url":"https://api.github.com/users/Grover-c13/repos","events_url":"https://api.github.com/users/Grover-c13/events{/privacy}","received_events_url":"https://api.github.com/users/Grover-c13/received_events","type":"User","site_admin":false},"repo":{"id":63499395,"name":"PokeGOAPI-Java","full_name":"Grover-c13/PokeGOAPI-Java","owner":{"login":"Grover-c13","id":1520101,"avatar_url":"https://avatars.githubusercontent.com/u/1520101?v=3","gravatar_id":"","url":"https://api.github.com/users/Grover-c13","html_url":"https://github.com/Grover-c13","followers_url":"https://api.github.com/users/Grover-c13/followers","following_url":"https://api.github.com/users/Grover-c13/following{/other_user}","gists_url":"https://api.github.com/users/Grover-c13/gists{/gist_id}","starred_url":"https://api.github.com/users/Grover-c13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grover-c13/subscriptions","organizations_url":"https://api.github.com/users/Grover-c13/orgs","repos_url":"https://api.github.com/users/Grover-c13/repos","events_url":"https://api.github.com/users/Grover-c13/events{/privacy}","received_events_url":"https://api.github.com/users/Grover-c13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Grover-c13/PokeGOAPI-Java","description":"Pokemon Go API","fork":false,"url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java","forks_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/forks","keys_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/teams","hooks_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/hooks","issue_events_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/events{/number}","events_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/events","assignees_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/assignees{/user}","branches_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/branches{/branch}","tags_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/tags","blobs_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/languages","stargazers_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/stargazers","contributors_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/contributors","subscribers_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/subscribers","subscription_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/subscription","commits_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/contents/{+path}","compare_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/merges","archive_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/downloads","issues_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues{/number}","pulls_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/labels{/name}","releases_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/releases{/id}","deployments_url":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/deployments","created_at":"2016-07-16T19:35:42Z","updated_at":"2016-08-30T01:09:35Z","pushed_at":"2016-08-30T07:38:48Z","git_url":"git://github.com/Grover-c13/PokeGOAPI-Java.git","ssh_url":"git@github.com:Grover-c13/PokeGOAPI-Java.git","clone_url":"https://github.com/Grover-c13/PokeGOAPI-Java.git","svn_url":"https://github.com/Grover-c13/PokeGOAPI-Java","homepage":null,"size":13623,"stargazers_count":1089,"watchers_count":1089,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":383,"mirror_url":null,"open_issues_count":30,"forks":383,"open_issues":30,"watchers":1089,"default_branch":"Development"}},"_links":{"self":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720"},"html":{"href":"https://github.com/Grover-c13/PokeGOAPI-Java/pull/720"},"issue":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/720"},"comments":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/Grover-c13/PokeGOAPI-Java/statuses/322bb86f675fe32403a94652b0fc4fd08018f431"}}}}
{"actor":{"display_login":"FabianTerhorst"}}