{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/82499909","pull_request_review_id":3406077,"id":82499909,"diff_hunk":"@@ -1980,27 +1985,40 @@ void PianoRoll::mouseMoveEvent( QMouseEvent * me )\n \t\treturn;\n \t}\n \n+\tif( me->x() > WHITE_KEY_WIDTH\n+\t\t\t&& me->x() < width() - PR_RIGHT_MARGIN - 2\n+\t\t\t&& me->y() < height() - PR_BOTTOM_MARGIN - m_notesEditHeight )\n+\t{\n+\t\tm_mouseInPianoRoll = true;\n+\t}\n+\telse\n+\t{\n+\t\tm_mouseInPianoRoll = false;\n+\t}\n+\n+\tsetMousePointer();\n+\n \tif( m_action == ActionNone && me->buttons() == 0 )\n \t{\n \t\tif( me->y() > keyAreaBottom() && me->y() < noteEditTop() )\n \t\t{\n-\t\t\tQApplication::setOverrideCursor(\n-\t\t\t\t\tQCursor( Qt::SizeVerCursor ) );\n+\t\t\tsetCursor( Qt::SizeVerCursor );\n \t\t\treturn;\n \t\t}\n \t}\n \telse if( m_action == ActionResizeNoteEditArea )\n \t{\n \t\t// change m_notesEditHeight and then repaint\n+\t\tsetCursor( Qt::SizeVerCursor );\n \t\tm_notesEditHeight = tLimit<int>(\n \t\t\t\t\tm_oldNotesEditHeight - ( me->y() - m_moveStartY ),\n \t\t\t\t\tNOTE_EDIT_MIN_HEIGHT,\n \t\t\t\t\theight() - PR_TOP_MARGIN - NOTE_EDIT_RESIZE_BAR -\n-\t\t\t\t\t\t\t\t\tPR_BOTTOM_MARGIN - KEY_AREA_MIN_HEIGHT );\n+\t\t\t\t\tPR_BOTTOM_MARGIN - KEY_AREA_MIN_HEIGHT );\n \t\trepaint();\n \t\treturn;\n \t}\n-\n+\t","path":"src/gui/editors/PianoRoll.cpp","position":69,"original_position":69,"commit_id":"faa4801197b8854b9c3d26e2cf57ea6e7126bc9e","original_commit_id":"faa4801197b8854b9c3d26e2cf57ea6e7126bc9e","user":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"body":"unecessary   white space here","created_at":"2016-10-08T10:09:21Z","updated_at":"2016-10-08T10:09:21Z","html_url":"https://github.com/LMMS/lmms/pull/3065#discussion_r82499909","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/3065","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/82499909"},"html":{"href":"https://github.com/LMMS/lmms/pull/3065#discussion_r82499909"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3065"}}},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/3065","id":88268556,"html_url":"https://github.com/LMMS/lmms/pull/3065","diff_url":"https://github.com/LMMS/lmms/pull/3065.diff","patch_url":"https://github.com/LMMS/lmms/pull/3065.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/3065","number":3065,"state":"open","locked":false,"title":"improve mouse pointer in piano roll editor","user":{"login":"BaraMGB","id":6502580,"avatar_url":"https://avatars.githubusercontent.com/u/6502580?v=3","gravatar_id":"","url":"https://api.github.com/users/BaraMGB","html_url":"https://github.com/BaraMGB","followers_url":"https://api.github.com/users/BaraMGB/followers","following_url":"https://api.github.com/users/BaraMGB/following{/other_user}","gists_url":"https://api.github.com/users/BaraMGB/gists{/gist_id}","starred_url":"https://api.github.com/users/BaraMGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaraMGB/subscriptions","organizations_url":"https://api.github.com/users/BaraMGB/orgs","repos_url":"https://api.github.com/users/BaraMGB/repos","events_url":"https://api.github.com/users/BaraMGB/events{/privacy}","received_events_url":"https://api.github.com/users/BaraMGB/received_events","type":"User","site_admin":false},"body":"I can't make screenshots with mouse pointer. \r\n\r\nThis PR change the following things:\r\n\r\n- the mouse pointer changes its appearance proper on all borders of the key area\r\n- we use a pencil ( or eraser ) instead of the arrow with pencil icon\r\n- the rubberband icon don't stuck anymore on a border when the mouse pointer leaves the area\r\n\r\n","created_at":"2016-10-06T14:05:43Z","updated_at":"2016-10-08T10:09:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"258683ec41a793f757f08d032866e19c71c8c871","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/3065/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/3065/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/3065/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/faa4801197b8854b9c3d26e2cf57ea6e7126bc9e","head":{"label":"BaraMGB:pianorollmousepointer","ref":"pianorollmousepointer","sha":"faa4801197b8854b9c3d26e2cf57ea6e7126bc9e","user":{"login":"BaraMGB","id":6502580,"avatar_url":"https://avatars.githubusercontent.com/u/6502580?v=3","gravatar_id":"","url":"https://api.github.com/users/BaraMGB","html_url":"https://github.com/BaraMGB","followers_url":"https://api.github.com/users/BaraMGB/followers","following_url":"https://api.github.com/users/BaraMGB/following{/other_user}","gists_url":"https://api.github.com/users/BaraMGB/gists{/gist_id}","starred_url":"https://api.github.com/users/BaraMGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaraMGB/subscriptions","organizations_url":"https://api.github.com/users/BaraMGB/orgs","repos_url":"https://api.github.com/users/BaraMGB/repos","events_url":"https://api.github.com/users/BaraMGB/events{/privacy}","received_events_url":"https://api.github.com/users/BaraMGB/received_events","type":"User","site_admin":false},"repo":{"id":49070157,"name":"lmms","full_name":"BaraMGB/lmms","owner":{"login":"BaraMGB","id":6502580,"avatar_url":"https://avatars.githubusercontent.com/u/6502580?v=3","gravatar_id":"","url":"https://api.github.com/users/BaraMGB","html_url":"https://github.com/BaraMGB","followers_url":"https://api.github.com/users/BaraMGB/followers","following_url":"https://api.github.com/users/BaraMGB/following{/other_user}","gists_url":"https://api.github.com/users/BaraMGB/gists{/gist_id}","starred_url":"https://api.github.com/users/BaraMGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaraMGB/subscriptions","organizations_url":"https://api.github.com/users/BaraMGB/orgs","repos_url":"https://api.github.com/users/BaraMGB/repos","events_url":"https://api.github.com/users/BaraMGB/events{/privacy}","received_events_url":"https://api.github.com/users/BaraMGB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BaraMGB/lmms","description":"cross-platform music production software","fork":true,"url":"https://api.github.com/repos/BaraMGB/lmms","forks_url":"https://api.github.com/repos/BaraMGB/lmms/forks","keys_url":"https://api.github.com/repos/BaraMGB/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BaraMGB/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BaraMGB/lmms/teams","hooks_url":"https://api.github.com/repos/BaraMGB/lmms/hooks","issue_events_url":"https://api.github.com/repos/BaraMGB/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/BaraMGB/lmms/events","assignees_url":"https://api.github.com/repos/BaraMGB/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/BaraMGB/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/BaraMGB/lmms/tags","blobs_url":"https://api.github.com/repos/BaraMGB/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BaraMGB/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BaraMGB/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/BaraMGB/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BaraMGB/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/BaraMGB/lmms/languages","stargazers_url":"https://api.github.com/repos/BaraMGB/lmms/stargazers","contributors_url":"https://api.github.com/repos/BaraMGB/lmms/contributors","subscribers_url":"https://api.github.com/repos/BaraMGB/lmms/subscribers","subscription_url":"https://api.github.com/repos/BaraMGB/lmms/subscription","commits_url":"https://api.github.com/repos/BaraMGB/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/BaraMGB/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/BaraMGB/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/BaraMGB/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/BaraMGB/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/BaraMGB/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BaraMGB/lmms/merges","archive_url":"https://api.github.com/repos/BaraMGB/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BaraMGB/lmms/downloads","issues_url":"https://api.github.com/repos/BaraMGB/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/BaraMGB/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/BaraMGB/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/BaraMGB/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BaraMGB/lmms/labels{/name}","releases_url":"https://api.github.com/repos/BaraMGB/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/BaraMGB/lmms/deployments","created_at":"2016-01-05T14:15:31Z","updated_at":"2016-10-01T12:50:48Z","pushed_at":"2016-10-08T09:58:33Z","git_url":"git://github.com/BaraMGB/lmms.git","ssh_url":"git@github.com:BaraMGB/lmms.git","clone_url":"https://github.com/BaraMGB/lmms.git","svn_url":"https://github.com/BaraMGB/lmms","homepage":"http://lmms.io/","size":73683,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LMMS:master","ref":"master","sha":"54b1da55c29cd191c120c87f7fba489a544d0dfb","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"Cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/LMMS/lmms/deployments","created_at":"2014-01-09T20:43:43Z","updated_at":"2016-10-06T14:56:48Z","pushed_at":"2016-10-08T09:58:34Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"https://lmms.io/","size":83971,"stargazers_count":932,"watchers_count":932,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":507,"forks":239,"open_issues":507,"watchers":932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3065"},"html":{"href":"https://github.com/LMMS/lmms/pull/3065"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/3065"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/3065/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3065/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/3065/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/faa4801197b8854b9c3d26e2cf57ea6e7126bc9e"}}}}
{"actor":{"display_login":"Umcaruje"}}