{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/79537249","id":79537249,"diff_hunk":"@@ -110,9 +111,115 @@ func (client ServicePrincipalsClient) ListResponder(resp *http.Response) (result\n \terr = autorest.Respond(\n \t\tresp,\n \t\tclient.ByInspecting(),\n-\t\tazure.WithErrorUnlessStatusCode(http.StatusOK),\n+\t\tWithOdataErrorUnlessStatusCode(http.StatusOK),\n+\t\tautorest.ByUnmarshallingJSON(&result),\n+\t\tautorest.ByClosing())\n+\tresult.Response = autorest.Response{Response: resp}\n+\treturn\n+}\n+\n+func (client ServicePrincipalsClient) ListPasswordCredentials(objectId string) (result PasswordCredentialsListResult, err error) {","path":"provider/azure/internal/ad/serviceprincipals.go","position":74,"original_position":74,"commit_id":"894211713c96be351b3cdf51209da025a431a86c","original_commit_id":"894211713c96be351b3cdf51209da025a431a86c","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars.githubusercontent.com/u/9034160?v=3","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"body":"Comments here and on other calls would be helpful \\o/","created_at":"2016-09-20T05:11:26Z","updated_at":"2016-09-20T05:13:06Z","html_url":"https://github.com/juju/juju/pull/6271#discussion_r79537249","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/6271","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/79537249"},"html":{"href":"https://github.com/juju/juju/pull/6271#discussion_r79537249"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/6271"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6271","id":85729907,"html_url":"https://github.com/juju/juju/pull/6271","diff_url":"https://github.com/juju/juju/pull/6271.diff","patch_url":"https://github.com/juju/juju/pull/6271.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6271","number":6271,"state":"open","locked":false,"title":"provider/azure: update AD client","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"body":"This updates the Azure Active Directory client, in preparation for a\nfollow-up which adds the interactive auth-type to the Azure provider. We do\nnot need to manipulate Applications, only Service Principals; so the\napplications client has been removed. The users client has been added so\nthat we can log the identity of the user that authenticated.\n\nThe WithOdataErrorUnlessStatusCode function is a copy of\nWithErrorUnlessStatusCode from the autorest/azure package, except that it\nexpects the error object's name to be \"odata.error\" instead of just\n\"error\", and does not extract the error message. This is not yet used, and\nwill be tested in a follow-up.\n\nRequires https://github.com/juju/juju/pull/6270","created_at":"2016-09-19T01:24:55Z","updated_at":"2016-09-20T05:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55c06306583ea800ed05e7f41777497ca2b87270","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6271/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6271/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6271/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/894211713c96be351b3cdf51209da025a431a86c","head":{"label":"axw:azure-auth-devicecode-ad-update","ref":"azure-auth-devicecode-ad-update","sha":"894211713c96be351b3cdf51209da025a431a86c","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"repo":{"id":20466577,"name":"juju","full_name":"axw/juju","owner":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axw/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/axw/juju","forks_url":"https://api.github.com/repos/axw/juju/forks","keys_url":"https://api.github.com/repos/axw/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axw/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axw/juju/teams","hooks_url":"https://api.github.com/repos/axw/juju/hooks","issue_events_url":"https://api.github.com/repos/axw/juju/issues/events{/number}","events_url":"https://api.github.com/repos/axw/juju/events","assignees_url":"https://api.github.com/repos/axw/juju/assignees{/user}","branches_url":"https://api.github.com/repos/axw/juju/branches{/branch}","tags_url":"https://api.github.com/repos/axw/juju/tags","blobs_url":"https://api.github.com/repos/axw/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axw/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axw/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/axw/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axw/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/axw/juju/languages","stargazers_url":"https://api.github.com/repos/axw/juju/stargazers","contributors_url":"https://api.github.com/repos/axw/juju/contributors","subscribers_url":"https://api.github.com/repos/axw/juju/subscribers","subscription_url":"https://api.github.com/repos/axw/juju/subscription","commits_url":"https://api.github.com/repos/axw/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/axw/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/axw/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/axw/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/axw/juju/contents/{+path}","compare_url":"https://api.github.com/repos/axw/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axw/juju/merges","archive_url":"https://api.github.com/repos/axw/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axw/juju/downloads","issues_url":"https://api.github.com/repos/axw/juju/issues{/number}","pulls_url":"https://api.github.com/repos/axw/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/axw/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/axw/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axw/juju/labels{/name}","releases_url":"https://api.github.com/repos/axw/juju/releases{/id}","deployments_url":"https://api.github.com/repos/axw/juju/deployments","created_at":"2014-06-04T01:51:25Z","updated_at":"2016-08-11T02:25:45Z","pushed_at":"2016-09-20T05:02:08Z","git_url":"git://github.com/axw/juju.git","ssh_url":"git@github.com:axw/juju.git","clone_url":"https://github.com/axw/juju.git","svn_url":"https://github.com/axw/juju","homepage":null,"size":103108,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"550e086471e680d8e54740e4f1ea8bc15a06dcc8","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-09-19T16:09:56Z","pushed_at":"2016-09-20T05:12:31Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":125618,"stargazers_count":502,"watchers_count":502,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":23,"forks":156,"open_issues":23,"watchers":502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6271"},"html":{"href":"https://github.com/juju/juju/pull/6271"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6271"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6271/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6271/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6271/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/894211713c96be351b3cdf51209da025a431a86c"}}}}
{"actor":{"display_login":"anastasiamac"}}