{"action":"created","comment":{"url":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments/93351148","pull_request_review_id":13876821,"id":93351148,"diff_hunk":"@@ -47,7 +47,7 @@ protected void onCreate(Bundle savedInstanceState) {\n         optimizelyManager = myApplication.getOptimizelyManager();\n \n         // Load Optimizely from a compiled in data file\n-        final OptimizelyClient optimizely = optimizelyManager.initialize(this, R.raw.data_file);\n+        final OptimizelyClient optimizely = optimizelyManager.initialize(getApplicationContext(), R.raw.data_file);","path":"test-app/src/main/java/com/optimizely/ab/android/test_app/MainActivity.java","position":5,"original_position":5,"commit_id":"7c2eef014dd96e1d15e9440998f5873cf843133f","original_commit_id":"7c2eef014dd96e1d15e9440998f5873cf843133f","user":{"login":"jophde","id":240023,"avatar_url":"https://avatars.githubusercontent.com/u/240023?v=3","gravatar_id":"","url":"https://api.github.com/users/jophde","html_url":"https://github.com/jophde","followers_url":"https://api.github.com/users/jophde/followers","following_url":"https://api.github.com/users/jophde/following{/other_user}","gists_url":"https://api.github.com/users/jophde/gists{/gist_id}","starred_url":"https://api.github.com/users/jophde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jophde/subscriptions","organizations_url":"https://api.github.com/users/jophde/orgs","repos_url":"https://api.github.com/users/jophde/repos","events_url":"https://api.github.com/users/jophde/events{/privacy}","received_events_url":"https://api.github.com/users/jophde/received_events","type":"User","site_admin":false},"body":"It's fine to pass this here.  We already get the activity context internally in the manager.  Your previous change checking the type of the binder should be enough to stop the crash.  The onServiceConnected(...) method may be called multiple times since we are still using application context but you are filtering out the calls that we are not interested in now.  ","created_at":"2016-12-20T23:59:48Z","updated_at":"2016-12-20T23:59:48Z","html_url":"https://github.com/optimizely/android-sdk/pull/59#discussion_r93351148","pull_request_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments/93351148"},"html":{"href":"https://github.com/optimizely/android-sdk/pull/59#discussion_r93351148"},"pull_request":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/optimizely/android-sdk/pulls/59","id":98846861,"html_url":"https://github.com/optimizely/android-sdk/pull/59","diff_url":"https://github.com/optimizely/android-sdk/pull/59.diff","patch_url":"https://github.com/optimizely/android-sdk/pull/59.patch","issue_url":"https://api.github.com/repos/optimizely/android-sdk/issues/59","number":59,"state":"open","locked":false,"title":"Fix various bugs and crashes.","user":{"login":"mikeng13","id":1365958,"avatar_url":"https://avatars.githubusercontent.com/u/1365958?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeng13","html_url":"https://github.com/mikeng13","followers_url":"https://api.github.com/users/mikeng13/followers","following_url":"https://api.github.com/users/mikeng13/following{/other_user}","gists_url":"https://api.github.com/users/mikeng13/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeng13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeng13/subscriptions","organizations_url":"https://api.github.com/users/mikeng13/orgs","repos_url":"https://api.github.com/users/mikeng13/repos","events_url":"https://api.github.com/users/mikeng13/events{/privacy}","received_events_url":"https://api.github.com/users/mikeng13/received_events","type":"User","site_admin":false},"body":"@optimizely/fullstack-devs \r\n\r\nThis fixes a number of crashes and bugs that our beta customer pointed out.","created_at":"2016-12-20T23:43:03Z","updated_at":"2016-12-20T23:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c7273674885fa45a8e0c2eef4f382aab01ed5a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/59/commits","review_comments_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/59/comments","review_comment_url":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/android-sdk/issues/59/comments","statuses_url":"https://api.github.com/repos/optimizely/android-sdk/statuses/7c2eef014dd96e1d15e9440998f5873cf843133f","head":{"label":"optimizely:mng/fix-various-crashes","ref":"mng/fix-various-crashes","sha":"7c2eef014dd96e1d15e9440998f5873cf843133f","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":64177091,"name":"android-sdk","full_name":"optimizely/android-sdk","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/android-sdk","description":"Optimizely X Android SDK","fork":false,"url":"https://api.github.com/repos/optimizely/android-sdk","forks_url":"https://api.github.com/repos/optimizely/android-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/android-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/android-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/android-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/android-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/android-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/android-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/android-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/android-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/android-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/android-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/android-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/android-sdk/deployments","created_at":"2016-07-26T00:32:26Z","updated_at":"2016-10-24T17:41:56Z","pushed_at":"2016-12-20T23:43:04Z","git_url":"git://github.com/optimizely/android-sdk.git","ssh_url":"git@github.com:optimizely/android-sdk.git","clone_url":"https://github.com/optimizely/android-sdk.git","svn_url":"https://github.com/optimizely/android-sdk","homepage":"https://developers.optimizely.com/x/solutions/sdks/introduction/index.html?language=android&platform=mobile","size":653,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"devel"}},"base":{"label":"optimizely:devel","ref":"devel","sha":"6517f4a057cbe8acc0b5c6b1a093be46a6f2f9f3","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":64177091,"name":"android-sdk","full_name":"optimizely/android-sdk","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/android-sdk","description":"Optimizely X Android SDK","fork":false,"url":"https://api.github.com/repos/optimizely/android-sdk","forks_url":"https://api.github.com/repos/optimizely/android-sdk/forks","keys_url":"https://api.github.com/repos/optimizely/android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/android-sdk/teams","hooks_url":"https://api.github.com/repos/optimizely/android-sdk/hooks","issue_events_url":"https://api.github.com/repos/optimizely/android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/android-sdk/events","assignees_url":"https://api.github.com/repos/optimizely/android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/android-sdk/tags","blobs_url":"https://api.github.com/repos/optimizely/android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/android-sdk/languages","stargazers_url":"https://api.github.com/repos/optimizely/android-sdk/stargazers","contributors_url":"https://api.github.com/repos/optimizely/android-sdk/contributors","subscribers_url":"https://api.github.com/repos/optimizely/android-sdk/subscribers","subscription_url":"https://api.github.com/repos/optimizely/android-sdk/subscription","commits_url":"https://api.github.com/repos/optimizely/android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/android-sdk/merges","archive_url":"https://api.github.com/repos/optimizely/android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/android-sdk/downloads","issues_url":"https://api.github.com/repos/optimizely/android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/optimizely/android-sdk/deployments","created_at":"2016-07-26T00:32:26Z","updated_at":"2016-10-24T17:41:56Z","pushed_at":"2016-12-20T23:43:04Z","git_url":"git://github.com/optimizely/android-sdk.git","ssh_url":"git@github.com:optimizely/android-sdk.git","clone_url":"https://github.com/optimizely/android-sdk.git","svn_url":"https://github.com/optimizely/android-sdk","homepage":"https://developers.optimizely.com/x/solutions/sdks/introduction/index.html?language=android&platform=mobile","size":653,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/59"},"html":{"href":"https://github.com/optimizely/android-sdk/pull/59"},"issue":{"href":"https://api.github.com/repos/optimizely/android-sdk/issues/59"},"comments":{"href":"https://api.github.com/repos/optimizely/android-sdk/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/android-sdk/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/android-sdk/statuses/7c2eef014dd96e1d15e9440998f5873cf843133f"}}}}
{"actor":{"display_login":"jophde"}}