{"action":"created","issue":{"url":"https://api.github.com/repos/NLog/NLog/issues/1799","repository_url":"https://api.github.com/repos/NLog/NLog","labels_url":"https://api.github.com/repos/NLog/NLog/issues/1799/labels{/name}","comments_url":"https://api.github.com/repos/NLog/NLog/issues/1799/comments","events_url":"https://api.github.com/repos/NLog/NLog/issues/1799/events","html_url":"https://github.com/NLog/NLog/pull/1799","id":192433425,"number":1799,"title":"FileTarget: performance improvement 10-70% faster & optimized memory allocation by reusing buffer","user":{"login":"snakefoot","id":11509660,"avatar_url":"https://avatars.githubusercontent.com/u/11509660?v=3","gravatar_id":"","url":"https://api.github.com/users/snakefoot","html_url":"https://github.com/snakefoot","followers_url":"https://api.github.com/users/snakefoot/followers","following_url":"https://api.github.com/users/snakefoot/following{/other_user}","gists_url":"https://api.github.com/users/snakefoot/gists{/gist_id}","starred_url":"https://api.github.com/users/snakefoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snakefoot/subscriptions","organizations_url":"https://api.github.com/users/snakefoot/orgs","repos_url":"https://api.github.com/users/snakefoot/repos","events_url":"https://api.github.com/users/snakefoot/events{/privacy}","received_events_url":"https://api.github.com/users/snakefoot/received_events","type":"User","site_admin":false},"labels":[{"id":32727452,"url":"https://api.github.com/repos/NLog/NLog/labels/feature","name":"feature","color":"02e10c","default":false},{"id":295599144,"url":"https://api.github.com/repos/NLog/NLog/labels/performance","name":"performance","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NLog/NLog/milestones/34","html_url":"https://github.com/NLog/NLog/milestone/34","labels_url":"https://api.github.com/repos/NLog/NLog/milestones/34/labels","id":2166959,"number":34,"title":"4.4.1","description":"","creator":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":14,"state":"open","created_at":"2016-11-30T17:47:50Z","updated_at":"2016-12-22T19:08:29Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2016-11-29T23:37:47Z","updated_at":"2016-12-22T19:14:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NLog/NLog/pulls/1799","html_url":"https://github.com/NLog/NLog/pull/1799","diff_url":"https://github.com/NLog/NLog/pull/1799.diff","patch_url":"https://github.com/NLog/NLog/pull/1799.patch"},"body":"FileTarget and AsyncTargetWrapper with optimized memory allocations for layout rendering, encoding and streaming. Optimization is disabled by default with setting RestrictedBufferReuse (Default = true)\r\n\r\nIntroduced a new property AsyncTargetWrapper.FullBatchSizeWriteLimit (Default = 5). It gives better performance to have many small writes. But have increased AsyncTargetWrapper.BatchSize to 200. \r\n\r\nRefactoring of #1663\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/nlog/nlog/1799)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/NLog/NLog/issues/comments/268869727","html_url":"https://github.com/NLog/NLog/pull/1799#issuecomment-268869727","issue_url":"https://api.github.com/repos/NLog/NLog/issues/1799","id":268869727,"user":{"login":"304NotModified","id":5808377,"avatar_url":"https://avatars.githubusercontent.com/u/5808377?v=3","gravatar_id":"","url":"https://api.github.com/users/304NotModified","html_url":"https://github.com/304NotModified","followers_url":"https://api.github.com/users/304NotModified/followers","following_url":"https://api.github.com/users/304NotModified/following{/other_user}","gists_url":"https://api.github.com/users/304NotModified/gists{/gist_id}","starred_url":"https://api.github.com/users/304NotModified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/304NotModified/subscriptions","organizations_url":"https://api.github.com/users/304NotModified/orgs","repos_url":"https://api.github.com/users/304NotModified/repos","events_url":"https://api.github.com/users/304NotModified/events{/privacy}","received_events_url":"https://api.github.com/users/304NotModified/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T19:14:19Z","updated_at":"2016-12-22T19:14:19Z","body":"\n\n\n\nReviewed 28 of 29 files at r5.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[src/NLog/LoggerImpl.cs, line 87 at r4](https://reviewable.io:443/reviews/nlog/nlog/1799#-KZYX3Gmm3JfKrI4xICa:-KZbx5jIuo4cXjAU72CK:b2nid0f) ([raw file](https://github.com/nlog/nlog/blob/fe85cdc9a11d85c1c9560cd0c6d8dfce691cd94e/src/NLog/LoggerImpl.cs#L87)):*\n<details><summary><i>Previously, snakefoot (Rolf Kristensen) wrote…</i></summary><blockquote>\n\nThought one could only have one LogManager with one LogFactory. Have reverted the change.\n</blockquote></details>\n\nthx\n\n---\n\n*[src/NLog/Targets/Target.cs, line 68 at r5](https://reviewable.io:443/reviews/nlog/nlog/1799#-KZbwfkbDu8QVlyUb0Zd:-KZbwfkbDu8QVlyUb0Ze:bo1rwg3) ([raw file](https://github.com/nlog/nlog/blob/b1cd501eede7d25ba58fd77f39daf6aa33128c65/src/NLog/Targets/Target.cs#L68)):*\n> ```Smalltalk\n>         /// <docgen category='Performance Tuning Options' order='10' />\n>         public bool RestrictedBufferReuse { get { return _restrictedBufferReuse; } set { _restrictedBufferReuse = value; } }\n>         private bool _restrictedBufferReuse = true;\n> ```\n\nis there a reason why this isn't an auto property?\n\n---\n\n*[src/NLog/Targets/Wrappers/AsyncRequestQueue-T.cs, line 137 at r5](https://reviewable.io:443/reviews/nlog/nlog/1799#-KZbwx4R8AOro9E8okm4:-KZbwx4R8AOro9E8okm5:b-q12qol) ([raw file](https://github.com/nlog/nlog/blob/5be4aa919e9612e1efae618528c7ab125eb61368/src/NLog/Targets/Wrappers/AsyncRequestQueue-T.cs#L137)):*\n> ```Smalltalk\n>             lock (this)\n>             {\n>                 if (count == -1 || this.logEventInfoQueue.Count < count)\n> ```\n\nis this not needed anymore?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/nlog/nlog/1799)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"304NotModified"}}