{"action":"created","issue":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/1655","repository_url":"https://api.github.com/repos/supercollider/supercollider","labels_url":"https://api.github.com/repos/supercollider/supercollider/issues/1655/labels{/name}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/1655/comments","events_url":"https://api.github.com/repos/supercollider/supercollider/issues/1655/events","html_url":"https://github.com/supercollider/supercollider/pull/1655","id":106848676,"number":1655,"title":"Topic/refactor server clean","user":{"login":"telephon","id":1810559,"avatar_url":"https://avatars.githubusercontent.com/u/1810559?v=3","gravatar_id":"","url":"https://api.github.com/users/telephon","html_url":"https://github.com/telephon","followers_url":"https://api.github.com/users/telephon/followers","following_url":"https://api.github.com/users/telephon/following{/other_user}","gists_url":"https://api.github.com/users/telephon/gists{/gist_id}","starred_url":"https://api.github.com/users/telephon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telephon/subscriptions","organizations_url":"https://api.github.com/users/telephon/orgs","repos_url":"https://api.github.com/users/telephon/repos","events_url":"https://api.github.com/users/telephon/events{/privacy}","received_events_url":"https://api.github.com/users/telephon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/supercollider/supercollider/labels/api%20change","name":"api change","color":"fbca04"},{"url":"https://api.github.com/repos/supercollider/supercollider/labels/comp:%20class%20library","name":"comp: class library","color":"CFFF7D"},{"url":"https://api.github.com/repos/supercollider/supercollider/labels/env:%20Qt%20IDE","name":"env: Qt IDE","color":"90D1B0"},{"url":"https://api.github.com/repos/supercollider/supercollider/labels/has-conflicts","name":"has-conflicts","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"telephon","id":1810559,"avatar_url":"https://avatars.githubusercontent.com/u/1810559?v=3","gravatar_id":"","url":"https://api.github.com/users/telephon","html_url":"https://github.com/telephon","followers_url":"https://api.github.com/users/telephon/followers","following_url":"https://api.github.com/users/telephon/following{/other_user}","gists_url":"https://api.github.com/users/telephon/gists{/gist_id}","starred_url":"https://api.github.com/users/telephon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telephon/subscriptions","organizations_url":"https://api.github.com/users/telephon/orgs","repos_url":"https://api.github.com/users/telephon/repos","events_url":"https://api.github.com/users/telephon/events{/privacy}","received_events_url":"https://api.github.com/users/telephon/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/supercollider/supercollider/milestones/7","html_url":"https://github.com/supercollider/supercollider/milestones/3.8","labels_url":"https://api.github.com/repos/supercollider/supercollider/milestones/7/labels","id":1021746,"number":7,"title":"3.8","description":"","creator":{"login":"scztt","id":145037,"avatar_url":"https://avatars.githubusercontent.com/u/145037?v=3","gravatar_id":"","url":"https://api.github.com/users/scztt","html_url":"https://github.com/scztt","followers_url":"https://api.github.com/users/scztt/followers","following_url":"https://api.github.com/users/scztt/following{/other_user}","gists_url":"https://api.github.com/users/scztt/gists{/gist_id}","starred_url":"https://api.github.com/users/scztt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scztt/subscriptions","organizations_url":"https://api.github.com/users/scztt/orgs","repos_url":"https://api.github.com/users/scztt/repos","events_url":"https://api.github.com/users/scztt/events{/privacy}","received_events_url":"https://api.github.com/users/scztt/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":30,"state":"open","created_at":"2015-03-14T22:55:35Z","updated_at":"2016-03-17T19:30:28Z","due_on":"2016-05-31T22:00:00Z","closed_at":null},"comments":26,"created_at":"2015-09-16T19:43:22Z","updated_at":"2016-03-18T21:10:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/1655","html_url":"https://github.com/supercollider/supercollider/pull/1655","diff_url":"https://github.com/supercollider/supercollider/pull/1655.diff","patch_url":"https://github.com/supercollider/supercollider/pull/1655.patch"},"body":"Cleans up the Server implementation, which needed it.\r\n\r\nThis PR is still being developed, but it shouldn't break and can be tested – it is planned for ````3.8````.\r\n\r\nThis fixes #774 and fixes #889: instead of just assuming that the server is dead, it is taken to be unresponsive. It also fixes #1484.\r\n\r\nIt factors out all statusWatcher and recording functionality to a separate class (````ServerStatusWatcher```` and ````Recorder````).  This branch also implements the updating of recording display in the IDE.\r\n\r\nThere is some more refactoring, in the server code itself, the Volume class, and also the allocation of buffers in Buffer. It also moves the recording timer to the synthdef, to make the implementation more reliable eventually and also easier for other editors to implement.\r\n\r\nWhile I took care to keep the old interface, this refactor **may break code** that relies on instance variables in ````Server````, these problems are usually easy to solve, by writing, e.g. ````this.avgCPU```` instead of ````avgCPU````.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/comments/198543046","html_url":"https://github.com/supercollider/supercollider/pull/1655#issuecomment-198543046","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/1655","id":198543046,"user":{"login":"telephon","id":1810559,"avatar_url":"https://avatars.githubusercontent.com/u/1810559?v=3","gravatar_id":"","url":"https://api.github.com/users/telephon","html_url":"https://github.com/telephon","followers_url":"https://api.github.com/users/telephon/followers","following_url":"https://api.github.com/users/telephon/following{/other_user}","gists_url":"https://api.github.com/users/telephon/gists{/gist_id}","starred_url":"https://api.github.com/users/telephon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telephon/subscriptions","organizations_url":"https://api.github.com/users/telephon/orgs","repos_url":"https://api.github.com/users/telephon/repos","events_url":"https://api.github.com/users/telephon/events{/privacy}","received_events_url":"https://api.github.com/users/telephon/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T21:10:14Z","updated_at":"2016-03-18T21:10:14Z","body":"My main trouble is not the conflict (which seemed easy to manually merge), but the procedure to (1) get the correct commits and (2) not mess up the submodules."}}