{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/56224920","id":56224920,"diff_hunk":"@@ -358,7 +358,7 @@ private User createAccount(StaplerRequest req, StaplerResponse rsp, boolean self\n         if(si.fullname==null || si.fullname.length()==0)\n             si.fullname = si.username;\n \n-        if(si.email==null || !si.email.contains(\"@\"))\n+        if(isMailerPluginPresent() && (si.email==null || !si.email.contains(\"@\")))","path":"core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java","position":13,"original_position":5,"commit_id":"dac7decdce7b57a01193f4745eac76d35062fc09","original_commit_id":"5e8bb98ee071c67046fdd3a09d2021c272560207","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Yes I think this is good enough for now, just mentioning it for the record.","created_at":"2016-03-15T19:23:15Z","updated_at":"2016-03-15T19:23:15Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2122#discussion_r56224920","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/56224920"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2122#discussion_r56224920"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122","id":62805271,"html_url":"https://github.com/jenkinsci/jenkins/pull/2122","diff_url":"https://github.com/jenkinsci/jenkins/pull/2122.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2122.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2122","number":2122,"state":"open","locked":false,"title":"[JENKINS-33296] - plugin dependency issues during install","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"body":"This addresses a few issues with dependent plugins:\r\n\r\n* previously bundled plugins \"implied\" dependencies are not installed without explicit dependency references\r\n* maven-plugin was being explicitly excluded as a dependency, causing many failures\r\n* mailer had explicit dependencies in the main codebase for functionality, including saving the 'email' address field for Jenkins user accounts\r\n* dependencies were included in search text in the installer\r\n\r\nThis addresses:\r\nhttps://issues.jenkins-ci.org/browse/JENKINS-33296\r\nhttps://issues.jenkins-ci.org/browse/JENKINS-33308\r\n\r\n@jenkinsci/code-reviewers ","created_at":"2016-03-14T19:40:14Z","updated_at":"2016-03-15T19:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"588e220ecedce2a6c4c52174bfc3b96677f09353","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2122/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/dac7decdce7b57a01193f4745eac76d35062fc09","head":{"label":"kzantow:2.0","ref":"2.0","sha":"dac7decdce7b57a01193f4745eac76d35062fc09","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"repo":{"id":41372898,"name":"jenkins","full_name":"kzantow/jenkins","owner":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kzantow/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/kzantow/jenkins","forks_url":"https://api.github.com/repos/kzantow/jenkins/forks","keys_url":"https://api.github.com/repos/kzantow/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kzantow/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kzantow/jenkins/teams","hooks_url":"https://api.github.com/repos/kzantow/jenkins/hooks","issue_events_url":"https://api.github.com/repos/kzantow/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/kzantow/jenkins/events","assignees_url":"https://api.github.com/repos/kzantow/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/kzantow/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/kzantow/jenkins/tags","blobs_url":"https://api.github.com/repos/kzantow/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kzantow/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kzantow/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/kzantow/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kzantow/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/kzantow/jenkins/languages","stargazers_url":"https://api.github.com/repos/kzantow/jenkins/stargazers","contributors_url":"https://api.github.com/repos/kzantow/jenkins/contributors","subscribers_url":"https://api.github.com/repos/kzantow/jenkins/subscribers","subscription_url":"https://api.github.com/repos/kzantow/jenkins/subscription","commits_url":"https://api.github.com/repos/kzantow/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/kzantow/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/kzantow/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/kzantow/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/kzantow/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/kzantow/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kzantow/jenkins/merges","archive_url":"https://api.github.com/repos/kzantow/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kzantow/jenkins/downloads","issues_url":"https://api.github.com/repos/kzantow/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/kzantow/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/kzantow/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/kzantow/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kzantow/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/kzantow/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/kzantow/jenkins/deployments","created_at":"2015-08-25T15:52:29Z","updated_at":"2015-08-25T15:52:51Z","pushed_at":"2016-03-15T19:14:27Z","git_url":"git://github.com/kzantow/jenkins.git","ssh_url":"git@github.com:kzantow/jenkins.git","clone_url":"https://github.com/kzantow/jenkins.git","svn_url":"https://github.com/kzantow/jenkins","homepage":"http://jenkins-ci.org/","size":91046,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:2.0","ref":"2.0","sha":"25ac68ec8f6cbbf163f6c583c9e3cf3fb0a1a094","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-03-15T13:47:25Z","pushed_at":"2016-03-15T19:14:30Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":96951,"stargazers_count":5316,"watchers_count":5316,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2367,"mirror_url":null,"open_issues_count":141,"forks":2367,"open_issues":141,"watchers":5316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2122"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2122"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2122/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2122/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/dac7decdce7b57a01193f4745eac76d35062fc09"}}}}