{"action":"created","issue":{"url":"https://api.github.com/repos/Qucs/qucs/issues/202","repository_url":"https://api.github.com/repos/Qucs/qucs","labels_url":"https://api.github.com/repos/Qucs/qucs/issues/202/labels{/name}","comments_url":"https://api.github.com/repos/Qucs/qucs/issues/202/comments","events_url":"https://api.github.com/repos/Qucs/qucs/issues/202/events","html_url":"https://github.com/Qucs/qucs/pull/202","id":56087066,"number":202,"title":"qucsator : avoid taking a time step that will bring too close to a breakpoint.","user":{"login":"in3otd","id":9018179,"avatar_url":"https://avatars.githubusercontent.com/u/9018179?v=3","gravatar_id":"","url":"https://api.github.com/users/in3otd","html_url":"https://github.com/in3otd","followers_url":"https://api.github.com/users/in3otd/followers","following_url":"https://api.github.com/users/in3otd/following{/other_user}","gists_url":"https://api.github.com/users/in3otd/gists{/gist_id}","starred_url":"https://api.github.com/users/in3otd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in3otd/subscriptions","organizations_url":"https://api.github.com/users/in3otd/orgs","repos_url":"https://api.github.com/users/in3otd/repos","events_url":"https://api.github.com/users/in3otd/events{/privacy}","received_events_url":"https://api.github.com/users/in3otd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Qucs/qucs/labels/bug","name":"bug","color":"e11d21"},{"url":"https://api.github.com/repos/Qucs/qucs/labels/qucsator","name":"qucsator","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Qucs/qucs/milestones/2","html_url":"https://github.com/Qucs/qucs/milestones/0.0.19","labels_url":"https://api.github.com/repos/Qucs/qucs/milestones/2/labels","id":776520,"number":2,"title":"0.0.19","description":"Features and Fixes to be included on the next stable release.","creator":{"login":"guitorri","id":1388949,"avatar_url":"https://avatars.githubusercontent.com/u/1388949?v=3","gravatar_id":"","url":"https://api.github.com/users/guitorri","html_url":"https://github.com/guitorri","followers_url":"https://api.github.com/users/guitorri/followers","following_url":"https://api.github.com/users/guitorri/following{/other_user}","gists_url":"https://api.github.com/users/guitorri/gists{/gist_id}","starred_url":"https://api.github.com/users/guitorri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guitorri/subscriptions","organizations_url":"https://api.github.com/users/guitorri/orgs","repos_url":"https://api.github.com/users/guitorri/repos","events_url":"https://api.github.com/users/guitorri/events{/privacy}","received_events_url":"https://api.github.com/users/guitorri/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":112,"state":"open","created_at":"2014-09-03T09:26:06Z","updated_at":"2016-04-17T20:51:30Z","due_on":"2016-02-04T23:00:00Z","closed_at":null},"comments":23,"created_at":"2015-01-30T21:29:07Z","updated_at":"2016-07-14T20:50:16Z","closed_at":"2016-01-27T19:49:20Z","pull_request":{"url":"https://api.github.com/repos/Qucs/qucs/pulls/202","html_url":"https://github.com/Qucs/qucs/pull/202","diff_url":"https://github.com/Qucs/qucs/pull/202.diff","patch_url":"https://github.com/Qucs/qucs/pull/202.patch"},"body":"quick fix for #186 : the issue is related to the fact that for this particular simulation the internal time steps taken should have been submultiples of the user-requested time steps (print steps). In practice after some internal steps the simulator came very close, but not exactly on, to a print time step, probably due to numerical errors and then it attempted to take a very small time step (same order of magnitude as the machine precision) to reach the print step. This very small step likely caused to have companion circuits with extreme values.\r\nNow, in case a step will bring too close to a print step, it will be reduced so that the next step will be larger. Might not work with a lot of corner cases, but is good enough for the #186 circuit.\r\nWhile this passes all the `qucs-test` circuits, with no appreciable changes in the simulation time, it might not be the best solution, feel free to keep it on hold.\r\nAnd unfortunately it does not solve the transient simulation issues of the other known problematic circuits..."},"comment":{"url":"https://api.github.com/repos/Qucs/qucs/issues/comments/232788288","html_url":"https://github.com/Qucs/qucs/pull/202#issuecomment-232788288","issue_url":"https://api.github.com/repos/Qucs/qucs/issues/202","id":232788288,"user":{"login":"in3otd","id":9018179,"avatar_url":"https://avatars.githubusercontent.com/u/9018179?v=3","gravatar_id":"","url":"https://api.github.com/users/in3otd","html_url":"https://github.com/in3otd","followers_url":"https://api.github.com/users/in3otd/followers","following_url":"https://api.github.com/users/in3otd/following{/other_user}","gists_url":"https://api.github.com/users/in3otd/gists{/gist_id}","starred_url":"https://api.github.com/users/in3otd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/in3otd/subscriptions","organizations_url":"https://api.github.com/users/in3otd/orgs","repos_url":"https://api.github.com/users/in3otd/repos","events_url":"https://api.github.com/users/in3otd/events{/privacy}","received_events_url":"https://api.github.com/users/in3otd/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T20:50:16Z","updated_at":"2016-07-14T20:50:16Z","body":"with the current `release-0.0.19` code, your circuit here fails on the [assert](https://github.com/Qucs/qucs/blob/master/qucs-core/src/components/tswitch.cpp#L196) due to an incorrect resistance calculated for the switch S2. It seems that the `Roff-Ron` difference is smaller than the double precision, so the computed resistance is not right. BTW, are you using a 32 or 64 b OS?\r\nI have again rewritten the expression for the resistance calculation to try avoiding these numerical errors, now the simulation hangs at 16% (t=1.0001 s). Did not yet try your changes, though.\r\n\r\n\"my\" circuits has other issues also, I think: I've often had the impression that the LTE calculation for some components gives bad results as the timestep gets smaller trying to achieve convergence on a time point, as a results the timestep is reduced even further until it gets so small that the Jacobian becomes singular. The computed LTE and other internal variables can be easily put in the output dataset, so these can be plotted along the usual circuit variables, to see if this is the source of the problem. Will post an example later."}}
{"actor":{"display_login":"in3otd"}}