{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/business-requirement/pulls/comments/79071452","id":79071452,"diff_hunk":"@@ -0,0 +1,81 @@\n+# -*- coding: utf-8 -*-\n+# © 2016 Elico Corp (https://www.elico-corp.com).\n+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).\n+from openerp import api, fields, models\n+from openerp.tools.translate import _\n+from openerp.osv import osv\n+\n+\n+class Project(models.Model):\n+    _inherit = \"project.project\"\n+\n+    origin = fields.Char('Source Document')\n+\n+    @api.multi\n+    def generate_project_wizard(self):\n+        br_ids = self.env.context.get('br_ids', False)\n+        from_project = False\n+        if not br_ids:\n+            br_ids = self.br_ids\n+            from_project = True\n+        default_uom = self.env['project.config.settings'].\\\n+            get_default_time_unit('time_unit')\n+        default_uom = default_uom.get('time_unit', False)\n+        if not default_uom:\n+            raise osv.except_osv(\n+                _('Error'),\n+                _(\"\"\"Please set working time default unit in project config settings\n+                \"\"\"))\n+        lines = []\n+        for br in br_ids:\n+            if br.state not in ['approved', 'cancel', 'done']:\n+                raise osv.except_osv(\n+                    _('Error'),\n+                    _(\"\"\"All business requirements of the project should be approved/canceled/done\n+                    \"\"\"))\n+            if br.state != 'approved':\n+                continue\n+            for deliverables in br.deliverable_lines:\n+                for line in deliverables.resource_ids:\n+                    if line.resource_type != 'task':\n+                        continue\n+                    generated = self.env['project.task'].search(\n+                        [('br_resource_id', '=', line.id)])\n+                    if generated:\n+                        continue\n+                    lines.append(line.id)\n+\n+        if not lines:\n+            raise osv.except_osv(\n+                _('Error'),\n+                _(\"\"\"There is no available business requirement resource line to\n+                    generate task\"\"\"))\n+        if from_project:\n+            br_ids = [x for x in br_ids if x.parent_id.id is False]","path":"business_requirement_deliverable_project/models/project.py","position":54,"original_position":54,"commit_id":"4fd80f0936a131e8159d8718445140c466ffa388","original_commit_id":"d99ce340fcebd76d0f3e2c3d01851d71d6452616","user":{"login":"dreispt","id":1246629,"avatar_url":"https://avatars.githubusercontent.com/u/1246629?v=3","gravatar_id":"","url":"https://api.github.com/users/dreispt","html_url":"https://github.com/dreispt","followers_url":"https://api.github.com/users/dreispt/followers","following_url":"https://api.github.com/users/dreispt/following{/other_user}","gists_url":"https://api.github.com/users/dreispt/gists{/gist_id}","starred_url":"https://api.github.com/users/dreispt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreispt/subscriptions","organizations_url":"https://api.github.com/users/dreispt/orgs","repos_url":"https://api.github.com/users/dreispt/repos","events_url":"https://api.github.com/users/dreispt/events{/privacy}","received_events_url":"https://api.github.com/users/dreispt/received_events","type":"User","site_admin":false},"body":"@seb-elico IMO `x* is good: it's common to use those common short variable names in self contained comprehension lists.","created_at":"2016-09-15T21:59:49Z","updated_at":"2016-09-15T21:59:49Z","html_url":"https://github.com/OCA/business-requirement/pull/9#discussion_r79071452","pull_request_url":"https://api.github.com/repos/OCA/business-requirement/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/OCA/business-requirement/pulls/comments/79071452"},"html":{"href":"https://github.com/OCA/business-requirement/pull/9#discussion_r79071452"},"pull_request":{"href":"https://api.github.com/repos/OCA/business-requirement/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/business-requirement/pulls/9","id":72451327,"html_url":"https://github.com/OCA/business-requirement/pull/9","diff_url":"https://github.com/OCA/business-requirement/pull/9.diff","patch_url":"https://github.com/OCA/business-requirement/pull/9.patch","issue_url":"https://api.github.com/repos/OCA/business-requirement/issues/9","number":9,"state":"open","locked":false,"title":"[WIP] business_requirement_project","user":{"login":"victormartinelicocorp","id":16461806,"avatar_url":"https://avatars.githubusercontent.com/u/16461806?v=3","gravatar_id":"","url":"https://api.github.com/users/victormartinelicocorp","html_url":"https://github.com/victormartinelicocorp","followers_url":"https://api.github.com/users/victormartinelicocorp/followers","following_url":"https://api.github.com/users/victormartinelicocorp/following{/other_user}","gists_url":"https://api.github.com/users/victormartinelicocorp/gists{/gist_id}","starred_url":"https://api.github.com/users/victormartinelicocorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victormartinelicocorp/subscriptions","organizations_url":"https://api.github.com/users/victormartinelicocorp/orgs","repos_url":"https://api.github.com/users/victormartinelicocorp/repos","events_url":"https://api.github.com/users/victormartinelicocorp/events{/privacy}","received_events_url":"https://api.github.com/users/victormartinelicocorp/received_events","type":"User","site_admin":false},"body":"This is the new PR which replaces the old one: https://github.com/OCA/project/pull/144\r\n\r\n----\r\nDepends on:\r\n  - [ ] business_requirement_deliverable #3\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244847223%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244847224%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244854156%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77581869%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77581901%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586346%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586401%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586442%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586455%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586523%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586556%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586630%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77587137%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77587280%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244876260%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244896865%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244901312%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244902153%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77610915%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77610927%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611021%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611044%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611085%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611121%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611211%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611251%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611698%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611716%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611738%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611908%22%2C%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244920771%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/models/project.py%2052%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586556%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22remove%20%5C%22%21%5C%22%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A46%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/project.py%3AL1-82%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/README.rst%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586346%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20will%20fix%20the%20README%20in%20a%20separate%20PR%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A44%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/README.rst%3AL1-246%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/wizard/generate_projects_view.xml%2015%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611908%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Use%20%60%5C%22%60%20for%20params%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A43%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/wizard/generate_projects_view.xml%3AL1-35%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/models/business.py%2013%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586630%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Not%20sure%20about%20the%20guideline%20here%3A%20I%20think%20it%20should%20be%20project%2C%20not%20projects%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A47%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/business.py%3AL1-41%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/tests/test_br.py%20284%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611021%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/x/br_id/%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A36%3A48Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/tests/test_br.py%3AL1-287%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/tests/test_br.py%20285%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611044%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/x/br_id/%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A36%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/tests/test_br.py%3AL1-287%22%7D%2C%20%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23issuecomment-244847223%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%5Cn%5B%21%5BCoverage%20Status%5D%28https%3A//coveralls.io/builds/7755791/badge%29%5D%28https%3A//coveralls.io/builds/7755791%29%5Cn%5CnCoverage%20decreased%20%28-27.07%25%29%20to%2063.588%25%20when%20pulling%20%2A%2A011a168e1c8617b8a451ae4235815d44ff3437ab%20on%20victormartinelicocorp%3A7_business_requirement_project%2A%2A%20into%20%2A%2A8442e3f9a190330236592eafbc1f94dfe571a1ed%20on%20OCA%3A8.0%2A%2A.%5Cn%22%2C%20%22created_at%22%3A%20%222016-09-06T04%3A29%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2354108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/coveralls%22%7D%7D%2C%20%7B%22body%22%3A%20%22%5Cn%5B%21%5BCoverage%20Status%5D%28https%3A//coveralls.io/builds/7755791/badge%29%5D%28https%3A//coveralls.io/builds/7755791%29%5Cn%5CnCoverage%20decreased%20%28-27.07%25%29%20to%2063.588%25%20when%20pulling%20%2A%2A011a168e1c8617b8a451ae4235815d44ff3437ab%20on%20victormartinelicocorp%3A7_business_requirement_project%2A%2A%20into%20%2A%2A8442e3f9a190330236592eafbc1f94dfe571a1ed%20on%20OCA%3A8.0%2A%2A.%5Cn%22%2C%20%22created_at%22%3A%20%222016-09-06T04%3A29%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2354108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/coveralls%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40elicoidal%20%40seb-elico%5Cr%5CnCould%20review%3F.%20In%20the%20meanwhile%20I%27ll%20work%20to%20increase%20the%20coverall.%22%2C%20%22created_at%22%3A%20%222016-09-06T05%3A37%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/16461806%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/victormartinelicocorp%22%7D%7D%2C%20%7B%22body%22%3A%20%22%5Cn%5B%21%5BCoverage%20Status%5D%28https%3A//coveralls.io/builds/7757464/badge%29%5D%28https%3A//coveralls.io/builds/7757464%29%5Cn%5CnCoverage%20decreased%20%28-20.5%25%29%20to%2070.185%25%20when%20pulling%20%2A%2A3c96929898ee685234701c3d8dde4cdbd8c2fd44%20on%20victormartinelicocorp%3A7_business_requirement_project%2A%2A%20into%20%2A%2A8442e3f9a190330236592eafbc1f94dfe571a1ed%20on%20OCA%3A8.0%2A%2A.%5Cn%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A53%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2354108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/coveralls%22%7D%7D%2C%20%7B%22body%22%3A%20%22%5Cn%5B%21%5BCoverage%20Status%5D%28https%3A//coveralls.io/builds/7758585/badge%29%5D%28https%3A//coveralls.io/builds/7758585%29%5Cn%5CnCoverage%20decreased%20%28-20.5%25%29%20to%2070.185%25%20when%20pulling%20%2A%2Ad99ce340fcebd76d0f3e2c3d01851d71d6452616%20on%20victormartinelicocorp%3A7_business_requirement_project%2A%2A%20into%20%2A%2A8442e3f9a190330236592eafbc1f94dfe571a1ed%20on%20OCA%3A8.0%2A%2A.%5Cn%22%2C%20%22created_at%22%3A%20%222016-09-06T09%3A23%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2354108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/coveralls%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%20%5Cr%5CnI%20will%20regenerate%20the%20README%20in%20separate%20PR%22%2C%20%22created_at%22%3A%20%222016-09-06T09%3A41%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3E%3A%2B1%3A%5Cr%5CnI%20will%20regenerate%20the%20README%20in%20separate%20PR%5Cr%5Cn%5Cr%5Cn%40elicoidal%20%20I%20will%20wait%20to%20merge%20your%20PR%20before%20commit%20again.%22%2C%20%22created_at%22%3A%20%222016-09-06T09%3A45%3A42Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/16461806%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/victormartinelicocorp%22%7D%7D%2C%20%7B%22body%22%3A%20%22%5Cn%5B%21%5BCoverage%20Status%5D%28https%3A//coveralls.io/builds/7760018/badge%29%5D%28https%3A//coveralls.io/builds/7760018%29%5Cn%5CnCoverage%20decreased%20%28-20.5%25%29%20to%2070.185%25%20when%20pulling%20%2A%2A4fd80f0936a131e8159d8718445140c466ffa388%20on%20victormartinelicocorp%3A7_business_requirement_project%2A%2A%20into%20%2A%2A8442e3f9a190330236592eafbc1f94dfe571a1ed%20on%20OCA%3A8.0%2A%2A.%5Cn%22%2C%20%22created_at%22%3A%20%222016-09-06T11%3A17%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2354108%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/coveralls%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/wizard/generate_projects.py%2080%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611698%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/x/project_id/%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A42%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/wizard/generate_projects.py%3AL1-217%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/models/project.py%2034%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586442%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22requirements%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A45%3A22Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%2C%20%7B%22body%22%3A%20%22remove%20%5C%22%21%5C%22%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A45%3A29Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/project.py%3AL1-82%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/wizard/generate_projects.py%2084%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611716%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/x/task_id/%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A42%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/wizard/generate_projects.py%3AL1-217%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/views/business_view.xml%2044%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611085%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Wrong%20format%2C%20please%20fix%20it%21%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A37%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/views/business_view.xml%3AL1-99%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/wizard/generate_projects.py%2088%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611738%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Wrong%20format%2C%20please%20fix%20it%21%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A42%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/wizard/generate_projects.py%3AL1-217%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/wizard/generate_projects.py%2023%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77587137%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22true%20as%20default%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A51%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/wizard/generate_projects.py%3AL1-214%22%7D%2C%20%22Pull%20011a168e1c8617b8a451ae4235815d44ff3437ab%20business_requirement_deliverable_project/README.rst%20222%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77581869%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22remove%20this%20line%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A03%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/README.rst%3AL1-257%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/views/business_view.xml%2092%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611251%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Wrong%20format%2C%20please%20fix%20it%21%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A38%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/views/business_view.xml%3AL1-99%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/models/project.py%2027%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586523%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Unit%20of%20Measure%5Cr%5CnRemove%20%5C%22%21%5C%22%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A46%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/project.py%3AL1-82%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/wizard/generate_projects.py%2095%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77587280%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Find%20a%20better%20method%20name%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A52%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/wizard/generate_projects.py%3AL1-214%22%7D%2C%20%22Pull%203c96929898ee685234701c3d8dde4cdbd8c2fd44%20business_requirement_deliverable_project/models/business.py%2030%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77586401%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22tasks%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A45%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/business.py%3AL1-41%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/views/business_view.xml%2073%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611211%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Replace%20%60%27%60%20by%20%60%5C%22%60%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A38%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/views/business_view.xml%3AL1-99%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/views/business_view.xml%2053%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77611121%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Remove%20space%20after%20%60id%60%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A37%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/views/business_view.xml%3AL1-99%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/models/project.py%2054%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77610915%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/x/br_id/%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A35%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/project.py%3AL1-82%22%7D%2C%20%22Pull%20011a168e1c8617b8a451ae4235815d44ff3437ab%20business_requirement_deliverable_project/README.rst%20233%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77581901%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22remove%3A%20we%20dont%20use%20this%20logo%20in%20our%20module%22%2C%20%22created_at%22%3A%20%222016-09-06T07%3A04%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/README.rst%3AL1-257%22%7D%2C%20%22Pull%20d99ce340fcebd76d0f3e2c3d01851d71d6452616%20business_requirement_deliverable_project/models/project.py%2058%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/OCA/business-requirement/pull/9%23discussion_r77610927%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/x/br_id/%22%2C%20%22created_at%22%3A%20%222016-09-06T10%3A36%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/10879075%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/seb-elico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_project/models/project.py%3AL1-82%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#issuecomment-244847223'>General Comment</a></b>\n- <a href='https://github.com/coveralls'><img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'></a> [![Coverage Status](https://coveralls.io/builds/7755791/badge)](https://coveralls.io/builds/7755791)\nCoverage decreased (-27.07%) to 63.588% when pulling **011a168e1c8617b8a451ae4235815d44ff3437ab on victormartinelicocorp:7_business_requirement_project** into **8442e3f9a190330236592eafbc1f94dfe571a1ed on OCA:8.0**.\n- <a href='https://github.com/coveralls'><img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'></a> [![Coverage Status](https://coveralls.io/builds/7755791/badge)](https://coveralls.io/builds/7755791)\nCoverage decreased (-27.07%) to 63.588% when pulling **011a168e1c8617b8a451ae4235815d44ff3437ab on victormartinelicocorp:7_business_requirement_project** into **8442e3f9a190330236592eafbc1f94dfe571a1ed on OCA:8.0**.\n- <a href='https://github.com/victormartinelicocorp'><img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'></a> @elicoidal @seb-elico\nCould review?. In the meanwhile I'll work to increase the coverall.\n- <a href='https://github.com/coveralls'><img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'></a> [![Coverage Status](https://coveralls.io/builds/7757464/badge)](https://coveralls.io/builds/7757464)\nCoverage decreased (-20.5%) to 70.185% when pulling **3c96929898ee685234701c3d8dde4cdbd8c2fd44 on victormartinelicocorp:7_business_requirement_project** into **8442e3f9a190330236592eafbc1f94dfe571a1ed on OCA:8.0**.\n- <a href='https://github.com/coveralls'><img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'></a> [![Coverage Status](https://coveralls.io/builds/7758585/badge)](https://coveralls.io/builds/7758585)\nCoverage decreased (-20.5%) to 70.185% when pulling **d99ce340fcebd76d0f3e2c3d01851d71d6452616 on victormartinelicocorp:7_business_requirement_project** into **8442e3f9a190330236592eafbc1f94dfe571a1ed on OCA:8.0**.\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> :+1:\nI will regenerate the README in separate PR\n- <a href='https://github.com/victormartinelicocorp'><img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'></a> >:+1:\nI will regenerate the README in separate PR\n@elicoidal  I will wait to merge your PR before commit again.\n- <a href='https://github.com/coveralls'><img border=0 src='https://avatars.githubusercontent.com/u/2354108?v=3' height=16 width=16'></a> [![Coverage Status](https://coveralls.io/builds/7760018/badge)](https://coveralls.io/builds/7760018)\nCoverage decreased (-20.5%) to 70.185% when pulling **4fd80f0936a131e8159d8718445140c466ffa388 on victormartinelicocorp:7_business_requirement_project** into **8442e3f9a190330236592eafbc1f94dfe571a1ed on OCA:8.0**.\n- [ ] <a href='#crh-comment-Pull 011a168e1c8617b8a451ae4235815d44ff3437ab business_requirement_deliverable_project/README.rst 222'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77581869'>File: business_requirement_deliverable_project/README.rst:L1-257</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> remove this line\n- [ ] <a href='#crh-comment-Pull 011a168e1c8617b8a451ae4235815d44ff3437ab business_requirement_deliverable_project/README.rst 233'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77581901'>File: business_requirement_deliverable_project/README.rst:L1-257</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> remove: we dont use this logo in our module\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/README.rst 1'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77586346'>File: business_requirement_deliverable_project/README.rst:L1-246</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> I will fix the README in a separate PR\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/models/business.py 30'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77586401'>File: business_requirement_deliverable_project/models/business.py:L1-41</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> tasks\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/models/project.py 34'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77586442'>File: business_requirement_deliverable_project/models/project.py:L1-82</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> requirements\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> remove \"!\"\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/models/project.py 27'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77586523'>File: business_requirement_deliverable_project/models/project.py:L1-82</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> Unit of Measure\nRemove \"!\"\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/models/project.py 52'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77586556'>File: business_requirement_deliverable_project/models/project.py:L1-82</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> remove \"!\"\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/models/business.py 13'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77586630'>File: business_requirement_deliverable_project/models/business.py:L1-41</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> Not sure about the guideline here: I think it should be project, not projects\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/wizard/generate_projects.py 23'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77587137'>File: business_requirement_deliverable_project/wizard/generate_projects.py:L1-214</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> true as default\n- [ ] <a href='#crh-comment-Pull 3c96929898ee685234701c3d8dde4cdbd8c2fd44 business_requirement_deliverable_project/wizard/generate_projects.py 95'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77587280'>File: business_requirement_deliverable_project/wizard/generate_projects.py:L1-214</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> Find a better method name\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/models/project.py 54'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77610915'>File: business_requirement_deliverable_project/models/project.py:L1-82</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> s/x/br_id/\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/models/project.py 58'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77610927'>File: business_requirement_deliverable_project/models/project.py:L1-82</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> s/x/br_id/\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/tests/test_br.py 284'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611021'>File: business_requirement_deliverable_project/tests/test_br.py:L1-287</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> s/x/br_id/\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/tests/test_br.py 285'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611044'>File: business_requirement_deliverable_project/tests/test_br.py:L1-287</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> s/x/br_id/\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/views/business_view.xml 44'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611085'>File: business_requirement_deliverable_project/views/business_view.xml:L1-99</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> Wrong format, please fix it!\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/views/business_view.xml 53'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611121'>File: business_requirement_deliverable_project/views/business_view.xml:L1-99</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> Remove space after `id`\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/views/business_view.xml 73'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611211'>File: business_requirement_deliverable_project/views/business_view.xml:L1-99</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> Replace `'` by `\"`\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/views/business_view.xml 92'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611251'>File: business_requirement_deliverable_project/views/business_view.xml:L1-99</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> Wrong format, please fix it!\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/wizard/generate_projects.py 80'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611698'>File: business_requirement_deliverable_project/wizard/generate_projects.py:L1-217</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> s/x/project_id/\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/wizard/generate_projects.py 84'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611716'>File: business_requirement_deliverable_project/wizard/generate_projects.py:L1-217</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> s/x/task_id/\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/wizard/generate_projects.py 88'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611738'>File: business_requirement_deliverable_project/wizard/generate_projects.py:L1-217</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> Wrong format, please fix it!\n- [ ] <a href='#crh-comment-Pull d99ce340fcebd76d0f3e2c3d01851d71d6452616 business_requirement_deliverable_project/wizard/generate_projects_view.xml 15'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/OCA/business-requirement/pull/9#discussion_r77611908'>File: business_requirement_deliverable_project/wizard/generate_projects_view.xml:L1-35</a></b>\n- <a href='https://github.com/seb-elico'><img border=0 src='https://avatars.githubusercontent.com/u/10879075?v=3' height=16 width=16'></a> Use `\"` for params\n\n\n<a href='https://www.codereviewhub.com/OCA/business-requirement/pull/9?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/OCA/business-requirement/pull/9?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/OCA/business-requirement/pull/9'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-06-03T04:06:09Z","updated_at":"2016-09-15T21:59:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3af44dd442132784431910084a801762bc45a06b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/business-requirement/pulls/9/commits","review_comments_url":"https://api.github.com/repos/OCA/business-requirement/pulls/9/comments","review_comment_url":"https://api.github.com/repos/OCA/business-requirement/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/business-requirement/issues/9/comments","statuses_url":"https://api.github.com/repos/OCA/business-requirement/statuses/4fd80f0936a131e8159d8718445140c466ffa388","head":{"label":"victormartinelicocorp:7_business_requirement_project","ref":"7_business_requirement_project","sha":"4fd80f0936a131e8159d8718445140c466ffa388","user":{"login":"victormartinelicocorp","id":16461806,"avatar_url":"https://avatars.githubusercontent.com/u/16461806?v=3","gravatar_id":"","url":"https://api.github.com/users/victormartinelicocorp","html_url":"https://github.com/victormartinelicocorp","followers_url":"https://api.github.com/users/victormartinelicocorp/followers","following_url":"https://api.github.com/users/victormartinelicocorp/following{/other_user}","gists_url":"https://api.github.com/users/victormartinelicocorp/gists{/gist_id}","starred_url":"https://api.github.com/users/victormartinelicocorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victormartinelicocorp/subscriptions","organizations_url":"https://api.github.com/users/victormartinelicocorp/orgs","repos_url":"https://api.github.com/users/victormartinelicocorp/repos","events_url":"https://api.github.com/users/victormartinelicocorp/events{/privacy}","received_events_url":"https://api.github.com/users/victormartinelicocorp/received_events","type":"User","site_admin":false},"repo":{"id":60246888,"name":"business-requirement","full_name":"victormartinelicocorp/business-requirement","owner":{"login":"victormartinelicocorp","id":16461806,"avatar_url":"https://avatars.githubusercontent.com/u/16461806?v=3","gravatar_id":"","url":"https://api.github.com/users/victormartinelicocorp","html_url":"https://github.com/victormartinelicocorp","followers_url":"https://api.github.com/users/victormartinelicocorp/followers","following_url":"https://api.github.com/users/victormartinelicocorp/following{/other_user}","gists_url":"https://api.github.com/users/victormartinelicocorp/gists{/gist_id}","starred_url":"https://api.github.com/users/victormartinelicocorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victormartinelicocorp/subscriptions","organizations_url":"https://api.github.com/users/victormartinelicocorp/orgs","repos_url":"https://api.github.com/users/victormartinelicocorp/repos","events_url":"https://api.github.com/users/victormartinelicocorp/events{/privacy}","received_events_url":"https://api.github.com/users/victormartinelicocorp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victormartinelicocorp/business-requirement","description":"Business Requirements Management via Odoo","fork":true,"url":"https://api.github.com/repos/victormartinelicocorp/business-requirement","forks_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/forks","keys_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/teams","hooks_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/hooks","issue_events_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/issues/events{/number}","events_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/events","assignees_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/assignees{/user}","branches_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/branches{/branch}","tags_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/tags","blobs_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/git/refs{/sha}","trees_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/statuses/{sha}","languages_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/languages","stargazers_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/stargazers","contributors_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/contributors","subscribers_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/subscribers","subscription_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/subscription","commits_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/commits{/sha}","git_commits_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/git/commits{/sha}","comments_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/comments{/number}","issue_comment_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/issues/comments{/number}","contents_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/contents/{+path}","compare_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/merges","archive_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/downloads","issues_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/issues{/number}","pulls_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/pulls{/number}","milestones_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/milestones{/number}","notifications_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/labels{/name}","releases_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/releases{/id}","deployments_url":"https://api.github.com/repos/victormartinelicocorp/business-requirement/deployments","created_at":"2016-06-02T08:35:12Z","updated_at":"2016-06-25T09:36:35Z","pushed_at":"2016-09-15T01:58:21Z","git_url":"git://github.com/victormartinelicocorp/business-requirement.git","ssh_url":"git@github.com:victormartinelicocorp/business-requirement.git","clone_url":"https://github.com/victormartinelicocorp/business-requirement.git","svn_url":"https://github.com/victormartinelicocorp/business-requirement","homepage":null,"size":2396,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"9.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"8442e3f9a190330236592eafbc1f94dfe571a1ed","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":60178509,"name":"business-requirement","full_name":"OCA/business-requirement","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/business-requirement","description":"Business Requirements Management via Odoo","fork":false,"url":"https://api.github.com/repos/OCA/business-requirement","forks_url":"https://api.github.com/repos/OCA/business-requirement/forks","keys_url":"https://api.github.com/repos/OCA/business-requirement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/business-requirement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/business-requirement/teams","hooks_url":"https://api.github.com/repos/OCA/business-requirement/hooks","issue_events_url":"https://api.github.com/repos/OCA/business-requirement/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/business-requirement/events","assignees_url":"https://api.github.com/repos/OCA/business-requirement/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/business-requirement/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/business-requirement/tags","blobs_url":"https://api.github.com/repos/OCA/business-requirement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/business-requirement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/business-requirement/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/business-requirement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/business-requirement/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/business-requirement/languages","stargazers_url":"https://api.github.com/repos/OCA/business-requirement/stargazers","contributors_url":"https://api.github.com/repos/OCA/business-requirement/contributors","subscribers_url":"https://api.github.com/repos/OCA/business-requirement/subscribers","subscription_url":"https://api.github.com/repos/OCA/business-requirement/subscription","commits_url":"https://api.github.com/repos/OCA/business-requirement/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/business-requirement/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/business-requirement/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/business-requirement/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/business-requirement/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/business-requirement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/business-requirement/merges","archive_url":"https://api.github.com/repos/OCA/business-requirement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/business-requirement/downloads","issues_url":"https://api.github.com/repos/OCA/business-requirement/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/business-requirement/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/business-requirement/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/business-requirement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/business-requirement/labels{/name}","releases_url":"https://api.github.com/repos/OCA/business-requirement/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/business-requirement/deployments","created_at":"2016-06-01T13:18:18Z","updated_at":"2016-09-15T13:35:56Z","pushed_at":"2016-09-15T16:15:22Z","git_url":"git://github.com/OCA/business-requirement.git","ssh_url":"git@github.com:OCA/business-requirement.git","clone_url":"https://github.com/OCA/business-requirement.git","svn_url":"https://github.com/OCA/business-requirement","homepage":null,"size":2528,"stargazers_count":6,"watchers_count":6,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":6,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/business-requirement/pulls/9"},"html":{"href":"https://github.com/OCA/business-requirement/pull/9"},"issue":{"href":"https://api.github.com/repos/OCA/business-requirement/issues/9"},"comments":{"href":"https://api.github.com/repos/OCA/business-requirement/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/business-requirement/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/business-requirement/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/business-requirement/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/business-requirement/statuses/4fd80f0936a131e8159d8718445140c466ffa388"}}}}
{"actor":{"display_login":"dreispt"}}