{"action":"created","comment":{"url":"https://api.github.com/repos/airlift/airlift/pulls/comments/61910911","id":61910911,"diff_hunk":"@@ -57,6 +67,9 @@ public static ThreadPoolExecutor newBoundedThreadPool(int minThreads, int maxThr\n         @Override\n         public boolean offer(T o)\n         {\n+            if (queue.size() < sizeSupplier.getAsInt()) {","path":"concurrent/src/main/java/io/airlift/concurrent/BoundedThreadPool.java","position":44,"original_position":44,"commit_id":"b8a7afc630cc5a8903a1d9b693f3e1f9d92b91cc","original_commit_id":"b8a7afc630cc5a8903a1d9b693f3e1f9d92b91cc","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"body":"add javadoc to the class that mention this behavior","created_at":"2016-05-03T16:22:43Z","updated_at":"2016-05-03T16:22:43Z","html_url":"https://github.com/airlift/airlift/pull/413#discussion_r61910911","pull_request_url":"https://api.github.com/repos/airlift/airlift/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/airlift/airlift/pulls/comments/61910911"},"html":{"href":"https://github.com/airlift/airlift/pull/413#discussion_r61910911"},"pull_request":{"href":"https://api.github.com/repos/airlift/airlift/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/airlift/airlift/pulls/413","id":68725269,"html_url":"https://github.com/airlift/airlift/pull/413","diff_url":"https://github.com/airlift/airlift/pull/413.diff","patch_url":"https://github.com/airlift/airlift/pull/413.patch","issue_url":"https://api.github.com/repos/airlift/airlift/issues/413","number":413,"state":"open","locked":false,"title":"Fix behavior of BoundedThreadPool","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"Previously, it would behave as a fixed thread pool.","created_at":"2016-05-03T15:31:24Z","updated_at":"2016-05-03T16:22:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a9bf0d5064c8032877570aa14750e84aa9d9bb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/airlift/airlift/pulls/413/commits","review_comments_url":"https://api.github.com/repos/airlift/airlift/pulls/413/comments","review_comment_url":"https://api.github.com/repos/airlift/airlift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airlift/airlift/issues/413/comments","statuses_url":"https://api.github.com/repos/airlift/airlift/statuses/b8a7afc630cc5a8903a1d9b693f3e1f9d92b91cc","head":{"label":"electrum:bounded","ref":"bounded","sha":"b8a7afc630cc5a8903a1d9b693f3e1f9d92b91cc","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"repo":{"id":5072056,"name":"airlift","full_name":"electrum/airlift","owner":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/electrum/airlift","description":"","fork":true,"url":"https://api.github.com/repos/electrum/airlift","forks_url":"https://api.github.com/repos/electrum/airlift/forks","keys_url":"https://api.github.com/repos/electrum/airlift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electrum/airlift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electrum/airlift/teams","hooks_url":"https://api.github.com/repos/electrum/airlift/hooks","issue_events_url":"https://api.github.com/repos/electrum/airlift/issues/events{/number}","events_url":"https://api.github.com/repos/electrum/airlift/events","assignees_url":"https://api.github.com/repos/electrum/airlift/assignees{/user}","branches_url":"https://api.github.com/repos/electrum/airlift/branches{/branch}","tags_url":"https://api.github.com/repos/electrum/airlift/tags","blobs_url":"https://api.github.com/repos/electrum/airlift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electrum/airlift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electrum/airlift/git/refs{/sha}","trees_url":"https://api.github.com/repos/electrum/airlift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electrum/airlift/statuses/{sha}","languages_url":"https://api.github.com/repos/electrum/airlift/languages","stargazers_url":"https://api.github.com/repos/electrum/airlift/stargazers","contributors_url":"https://api.github.com/repos/electrum/airlift/contributors","subscribers_url":"https://api.github.com/repos/electrum/airlift/subscribers","subscription_url":"https://api.github.com/repos/electrum/airlift/subscription","commits_url":"https://api.github.com/repos/electrum/airlift/commits{/sha}","git_commits_url":"https://api.github.com/repos/electrum/airlift/git/commits{/sha}","comments_url":"https://api.github.com/repos/electrum/airlift/comments{/number}","issue_comment_url":"https://api.github.com/repos/electrum/airlift/issues/comments{/number}","contents_url":"https://api.github.com/repos/electrum/airlift/contents/{+path}","compare_url":"https://api.github.com/repos/electrum/airlift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electrum/airlift/merges","archive_url":"https://api.github.com/repos/electrum/airlift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electrum/airlift/downloads","issues_url":"https://api.github.com/repos/electrum/airlift/issues{/number}","pulls_url":"https://api.github.com/repos/electrum/airlift/pulls{/number}","milestones_url":"https://api.github.com/repos/electrum/airlift/milestones{/number}","notifications_url":"https://api.github.com/repos/electrum/airlift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electrum/airlift/labels{/name}","releases_url":"https://api.github.com/repos/electrum/airlift/releases{/id}","deployments_url":"https://api.github.com/repos/electrum/airlift/deployments","created_at":"2012-07-16T19:08:24Z","updated_at":"2015-05-08T20:33:34Z","pushed_at":"2016-05-03T15:34:26Z","git_url":"git://github.com/electrum/airlift.git","ssh_url":"git@github.com:electrum/airlift.git","clone_url":"https://github.com/electrum/airlift.git","svn_url":"https://github.com/electrum/airlift","homepage":null,"size":19922,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"airlift:master","ref":"master","sha":"cbf6a6fa46d62d004930a318e4a1cd2ec5ae6a92","user":{"login":"airlift","id":1855389,"avatar_url":"https://avatars.githubusercontent.com/u/1855389?v=3","gravatar_id":"","url":"https://api.github.com/users/airlift","html_url":"https://github.com/airlift","followers_url":"https://api.github.com/users/airlift/followers","following_url":"https://api.github.com/users/airlift/following{/other_user}","gists_url":"https://api.github.com/users/airlift/gists{/gist_id}","starred_url":"https://api.github.com/users/airlift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airlift/subscriptions","organizations_url":"https://api.github.com/users/airlift/orgs","repos_url":"https://api.github.com/users/airlift/repos","events_url":"https://api.github.com/users/airlift/events{/privacy}","received_events_url":"https://api.github.com/users/airlift/received_events","type":"Organization","site_admin":false},"repo":{"id":4681328,"name":"airlift","full_name":"airlift/airlift","owner":{"login":"airlift","id":1855389,"avatar_url":"https://avatars.githubusercontent.com/u/1855389?v=3","gravatar_id":"","url":"https://api.github.com/users/airlift","html_url":"https://github.com/airlift","followers_url":"https://api.github.com/users/airlift/followers","following_url":"https://api.github.com/users/airlift/following{/other_user}","gists_url":"https://api.github.com/users/airlift/gists{/gist_id}","starred_url":"https://api.github.com/users/airlift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airlift/subscriptions","organizations_url":"https://api.github.com/users/airlift/orgs","repos_url":"https://api.github.com/users/airlift/repos","events_url":"https://api.github.com/users/airlift/events{/privacy}","received_events_url":"https://api.github.com/users/airlift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airlift/airlift","description":"Airlift framework for building REST services","fork":false,"url":"https://api.github.com/repos/airlift/airlift","forks_url":"https://api.github.com/repos/airlift/airlift/forks","keys_url":"https://api.github.com/repos/airlift/airlift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airlift/airlift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airlift/airlift/teams","hooks_url":"https://api.github.com/repos/airlift/airlift/hooks","issue_events_url":"https://api.github.com/repos/airlift/airlift/issues/events{/number}","events_url":"https://api.github.com/repos/airlift/airlift/events","assignees_url":"https://api.github.com/repos/airlift/airlift/assignees{/user}","branches_url":"https://api.github.com/repos/airlift/airlift/branches{/branch}","tags_url":"https://api.github.com/repos/airlift/airlift/tags","blobs_url":"https://api.github.com/repos/airlift/airlift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airlift/airlift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airlift/airlift/git/refs{/sha}","trees_url":"https://api.github.com/repos/airlift/airlift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airlift/airlift/statuses/{sha}","languages_url":"https://api.github.com/repos/airlift/airlift/languages","stargazers_url":"https://api.github.com/repos/airlift/airlift/stargazers","contributors_url":"https://api.github.com/repos/airlift/airlift/contributors","subscribers_url":"https://api.github.com/repos/airlift/airlift/subscribers","subscription_url":"https://api.github.com/repos/airlift/airlift/subscription","commits_url":"https://api.github.com/repos/airlift/airlift/commits{/sha}","git_commits_url":"https://api.github.com/repos/airlift/airlift/git/commits{/sha}","comments_url":"https://api.github.com/repos/airlift/airlift/comments{/number}","issue_comment_url":"https://api.github.com/repos/airlift/airlift/issues/comments{/number}","contents_url":"https://api.github.com/repos/airlift/airlift/contents/{+path}","compare_url":"https://api.github.com/repos/airlift/airlift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airlift/airlift/merges","archive_url":"https://api.github.com/repos/airlift/airlift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airlift/airlift/downloads","issues_url":"https://api.github.com/repos/airlift/airlift/issues{/number}","pulls_url":"https://api.github.com/repos/airlift/airlift/pulls{/number}","milestones_url":"https://api.github.com/repos/airlift/airlift/milestones{/number}","notifications_url":"https://api.github.com/repos/airlift/airlift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airlift/airlift/labels{/name}","releases_url":"https://api.github.com/repos/airlift/airlift/releases{/id}","deployments_url":"https://api.github.com/repos/airlift/airlift/deployments","created_at":"2012-06-16T00:33:13Z","updated_at":"2016-04-18T15:16:51Z","pushed_at":"2016-05-03T15:34:26Z","git_url":"git://github.com/airlift/airlift.git","ssh_url":"git@github.com:airlift/airlift.git","clone_url":"https://github.com/airlift/airlift.git","svn_url":"https://github.com/airlift/airlift","homepage":"","size":21552,"stargazers_count":151,"watchers_count":151,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":39,"forks":73,"open_issues":39,"watchers":151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airlift/airlift/pulls/413"},"html":{"href":"https://github.com/airlift/airlift/pull/413"},"issue":{"href":"https://api.github.com/repos/airlift/airlift/issues/413"},"comments":{"href":"https://api.github.com/repos/airlift/airlift/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/airlift/airlift/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/airlift/airlift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airlift/airlift/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/airlift/airlift/statuses/b8a7afc630cc5a8903a1d9b693f3e1f9d92b91cc"}}}}