{"action":"created","issue":{"url":"https://api.github.com/repos/sahlberg/libiscsi/issues/208","repository_url":"https://api.github.com/repos/sahlberg/libiscsi","labels_url":"https://api.github.com/repos/sahlberg/libiscsi/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/sahlberg/libiscsi/issues/208/comments","events_url":"https://api.github.com/repos/sahlberg/libiscsi/issues/208/events","html_url":"https://github.com/sahlberg/libiscsi/pull/208","id":157486518,"number":208,"title":"Tests: WRITESAME 0-blocks fixes and improvements","user":{"login":"sitsofe","id":4005180,"avatar_url":"https://avatars.githubusercontent.com/u/4005180?v=3","gravatar_id":"","url":"https://api.github.com/users/sitsofe","html_url":"https://github.com/sitsofe","followers_url":"https://api.github.com/users/sitsofe/followers","following_url":"https://api.github.com/users/sitsofe/following{/other_user}","gists_url":"https://api.github.com/users/sitsofe/gists{/gist_id}","starred_url":"https://api.github.com/users/sitsofe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitsofe/subscriptions","organizations_url":"https://api.github.com/users/sitsofe/orgs","repos_url":"https://api.github.com/users/sitsofe/repos","events_url":"https://api.github.com/users/sitsofe/events{/privacy}","received_events_url":"https://api.github.com/users/sitsofe/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-30T11:41:24Z","updated_at":"2016-06-02T05:20:21Z","closed_at":"2016-06-02T02:41:20Z","pull_request":{"url":"https://api.github.com/repos/sahlberg/libiscsi/pulls/208","html_url":"https://github.com/sahlberg/libiscsi/pull/208","diff_url":"https://github.com/sahlberg/libiscsi/pull/208.diff","patch_url":"https://github.com/sahlberg/libiscsi/pull/208.patch"},"body":"The current WRITE SAME (WS) 0 blocks test at LBA 0 isn't always correct\r\nbecause if:\r\n- The target's WSNZ bit set is 0\r\n- The target's MAXIMUM WRITE SAME LENGTH (MWSL) is greater than 0\r\n- We are issuing a WS with a NUMBER OF LOGICAL BLOCKS of 0\r\n\r\nthen whether the command should return success or failure depends on\r\nwhether the starting LBA is within MWSL blocks of the end of the LUN\r\n(see http://www.t10.org/pipermail/t10/2016-May/017988.html for details).\r\n\r\nReplace the vestigial code which tried to handle this (but no longer\r\nworked since commit 8585e4509b72c9d1e8f814d67d53847a75c6a535 ) and add\r\nsome additional MAXIMUM WRITE SAME LENGTH tests.\r\n\r\nSigned-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>\r\n\r\nCC'ing @ddiss, @bvanassche ."},"comment":{"url":"https://api.github.com/repos/sahlberg/libiscsi/issues/comments/223197917","html_url":"https://github.com/sahlberg/libiscsi/pull/208#issuecomment-223197917","issue_url":"https://api.github.com/repos/sahlberg/libiscsi/issues/208","id":223197917,"user":{"login":"sitsofe","id":4005180,"avatar_url":"https://avatars.githubusercontent.com/u/4005180?v=3","gravatar_id":"","url":"https://api.github.com/users/sitsofe","html_url":"https://github.com/sitsofe","followers_url":"https://api.github.com/users/sitsofe/followers","following_url":"https://api.github.com/users/sitsofe/following{/other_user}","gists_url":"https://api.github.com/users/sitsofe/gists{/gist_id}","starred_url":"https://api.github.com/users/sitsofe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitsofe/subscriptions","organizations_url":"https://api.github.com/users/sitsofe/orgs","repos_url":"https://api.github.com/users/sitsofe/repos","events_url":"https://api.github.com/users/sitsofe/events{/privacy}","received_events_url":"https://api.github.com/users/sitsofe/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T05:20:21Z","updated_at":"2016-06-02T05:20:21Z","body":"@sahlberg: You've got a good memory! I do run libiscsi on a Mac (in addition to Linux) but I don't have any RDMA devices. If it such a target can be easily faked or you just want to see what happens on the at compilation or on iSCSI paths I should be able to still help. If the patch is a pull request let me know and I'll try it before you merge it."}}
{"actor":{"display_login":"sitsofe"}}