{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments/55599390","id":55599390,"diff_hunk":"@@ -1,13 +1,10 @@\n <?xml version='1.0' encoding='windows-1252'?>\n <Wix xmlns='http://schemas.microsoft.com/wix/2006/wi' xmlns:util=\"http://schemas.microsoft.com/wix/UtilExtension\">\n   <Fragment>\n-    <ComponentGroup Id=\"Service_MARIONETTECOLLECTIVE\">\n-      <ComponentRef Id=\"Service_MARIONETTECOLLECTIVE_svc\" />\n-    </ComponentGroup>\n-\n-    <DirectoryRef Id=\"MARIONETTECOLLECTIVEBINDIR\">\n-      <Component Id='Service_MARIONETTECOLLECTIVE_svc'\n+    <ComponentGroup Id=\"<%= get_service(\"marionette-collective\").component_group %>\">","path":"resources/windows/wix/service.mcollective.wxs.erb","position":10,"original_position":10,"commit_id":"3364791eb0e89080695cb73c6a892b5b81f8f8ac","original_commit_id":"3364791eb0e89080695cb73c6a892b5b81f8f8ac","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"body":"Does this still need the `Service_` prefix?","created_at":"2016-03-09T22:12:02Z","updated_at":"2016-03-09T22:12:02Z","html_url":"https://github.com/puppetlabs/puppet-agent/pull/565#discussion_r55599390","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments/55599390"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/565#discussion_r55599390"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565","id":62160127,"html_url":"https://github.com/puppetlabs/puppet-agent/pull/565","diff_url":"https://github.com/puppetlabs/puppet-agent/pull/565.diff","patch_url":"https://github.com/puppetlabs/puppet-agent/pull/565.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/565","number":565,"state":"open","locked":false,"title":"(maint) Update Services for windows","user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"body":"tl;dr: the way we currently do services is bad, it reqiures users know how vanagon autogenerates some values, so I changed it so they can just call in to vanagon for the stuff they need. \r\n\r\nRequires Vanagon PR: https://github.com/puppetlabs/vanagon/pull/312","created_at":"2016-03-09T00:17:02Z","updated_at":"2016-03-09T22:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6e6ce258e0264e90f05fe4819285335d03418b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/565/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/3364791eb0e89080695cb73c6a892b5b81f8f8ac","head":{"label":"McdonaldSeanp:maint/update_mco_service_name_windows","ref":"maint/update_mco_service_name_windows","sha":"3364791eb0e89080695cb73c6a892b5b81f8f8ac","user":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"repo":{"id":48137575,"name":"puppet-agent-1","full_name":"McdonaldSeanp/puppet-agent-1","owner":{"login":"McdonaldSeanp","id":6415932,"avatar_url":"https://avatars.githubusercontent.com/u/6415932?v=3","gravatar_id":"","url":"https://api.github.com/users/McdonaldSeanp","html_url":"https://github.com/McdonaldSeanp","followers_url":"https://api.github.com/users/McdonaldSeanp/followers","following_url":"https://api.github.com/users/McdonaldSeanp/following{/other_user}","gists_url":"https://api.github.com/users/McdonaldSeanp/gists{/gist_id}","starred_url":"https://api.github.com/users/McdonaldSeanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McdonaldSeanp/subscriptions","organizations_url":"https://api.github.com/users/McdonaldSeanp/orgs","repos_url":"https://api.github.com/users/McdonaldSeanp/repos","events_url":"https://api.github.com/users/McdonaldSeanp/events{/privacy}","received_events_url":"https://api.github.com/users/McdonaldSeanp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/McdonaldSeanp/puppet-agent-1","description":"All of the directions for building a puppet agent package.","fork":true,"url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1","forks_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/forks","keys_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/teams","hooks_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/hooks","issue_events_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/issues/events{/number}","events_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/events","assignees_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/assignees{/user}","branches_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/branches{/branch}","tags_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/tags","blobs_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/statuses/{sha}","languages_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/languages","stargazers_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/stargazers","contributors_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/contributors","subscribers_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/subscribers","subscription_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/subscription","commits_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/contents/{+path}","compare_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/merges","archive_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/downloads","issues_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/issues{/number}","pulls_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/pulls{/number}","milestones_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/milestones{/number}","notifications_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/labels{/name}","releases_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/releases{/id}","deployments_url":"https://api.github.com/repos/McdonaldSeanp/puppet-agent-1/deployments","created_at":"2015-12-16T21:59:16Z","updated_at":"2016-01-29T18:55:27Z","pushed_at":"2016-03-09T21:30:27Z","git_url":"git://github.com/McdonaldSeanp/puppet-agent-1.git","ssh_url":"git@github.com:McdonaldSeanp/puppet-agent-1.git","clone_url":"https://github.com/McdonaldSeanp/puppet-agent-1.git","svn_url":"https://github.com/McdonaldSeanp/puppet-agent-1","homepage":null,"size":3527,"stargazers_count":0,"watchers_count":0,"language":"Groff","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"efeb960b2c9795bea83424d1d6a56e3ee695b30f","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26777895,"name":"puppet-agent","full_name":"puppetlabs/puppet-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-agent","forks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-agent/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/deployments","created_at":"2014-11-17T21:23:08Z","updated_at":"2016-02-11T15:46:00Z","pushed_at":"2016-03-09T21:30:28Z","git_url":"git://github.com/puppetlabs/puppet-agent.git","ssh_url":"git@github.com:puppetlabs/puppet-agent.git","clone_url":"https://github.com/puppetlabs/puppet-agent.git","svn_url":"https://github.com/puppetlabs/puppet-agent","homepage":null,"size":3869,"stargazers_count":5,"watchers_count":5,"language":"Groff","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":2,"forks":28,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/565"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/565"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/565/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/565/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/3364791eb0e89080695cb73c6a892b5b81f8f8ac"}}}}