{"action":"created","issue":{"url":"https://api.github.com/repos/LookingForMe/lookingfor/issues/72","repository_url":"https://api.github.com/repos/LookingForMe/lookingfor","labels_url":"https://api.github.com/repos/LookingForMe/lookingfor/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/LookingForMe/lookingfor/issues/72/comments","events_url":"https://api.github.com/repos/LookingForMe/lookingfor/issues/72/events","html_url":"https://github.com/LookingForMe/lookingfor/pull/72","id":158172434,"number":72,"title":"[WIP] Normalizing locations #69","user":{"login":"erinnachen","id":12789537,"avatar_url":"https://avatars.githubusercontent.com/u/12789537?v=3","gravatar_id":"","url":"https://api.github.com/users/erinnachen","html_url":"https://github.com/erinnachen","followers_url":"https://api.github.com/users/erinnachen/followers","following_url":"https://api.github.com/users/erinnachen/following{/other_user}","gists_url":"https://api.github.com/users/erinnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/erinnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erinnachen/subscriptions","organizations_url":"https://api.github.com/users/erinnachen/orgs","repos_url":"https://api.github.com/users/erinnachen/repos","events_url":"https://api.github.com/users/erinnachen/events{/privacy}","received_events_url":"https://api.github.com/users/erinnachen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2016-06-02T15:37:54Z","updated_at":"2016-06-15T14:54:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LookingForMe/lookingfor/pulls/72","html_url":"https://github.com/LookingForMe/lookingfor/pull/72","diff_url":"https://github.com/LookingForMe/lookingfor/pull/72.diff","patch_url":"https://github.com/LookingForMe/lookingfor/pull/72.patch"},"body":"This normalizes the information from location column on the jobs table. Location is now implemented as a separate model with a single field, name.\r\n\r\n* Added a migration to move current location information into a different column called old_location.\r\n* Added location model\r\n* Created a location_id column on the Jobs model to refer to a single location: Locations have many jobs and jobs belong to a location\r\n* Changed the job factory to reflect the association with location\r\n* Added a location factory\r\n* JobFetcher now expects that the entry hash has a location field (similar to category), removed location from the jobs field\r\n  * Raw entry in tests modified to reflect this change.\r\n* Added additional tests for job fetcher\r\n* All feature/model tests pass\r\n\r\nOutstanding issues:\r\n[ ] Waiting on #37 to be sorted out to convert old_locations to a location (rake task)\r\n[ ] After above is handled, a migration will remove old_locations from the jobs table\r\n[ ] Looking at some of the entries, we will have to smartly parse the locations. One challenge is that foreign countries may come in as full descriptions and from another service is referred by abbreviation: e.g. London, UK and London, United Kingdom and these should be parse to the same location. Another example is dealing with the fact that some US locations also have US or USA appended to the end. Another thing to think about is that multiple locations may be parsed from a job listing.\r\n\r\nAny thoughts? @rrgayhart @NickyBobby @brennanholtzclaw @hhoopes \r\n"},"comment":{"url":"https://api.github.com/repos/LookingForMe/lookingfor/issues/comments/226212917","html_url":"https://github.com/LookingForMe/lookingfor/pull/72#issuecomment-226212917","issue_url":"https://api.github.com/repos/LookingForMe/lookingfor/issues/72","id":226212917,"user":{"login":"NickyBobby","id":13855453,"avatar_url":"https://avatars.githubusercontent.com/u/13855453?v=3","gravatar_id":"","url":"https://api.github.com/users/NickyBobby","html_url":"https://github.com/NickyBobby","followers_url":"https://api.github.com/users/NickyBobby/followers","following_url":"https://api.github.com/users/NickyBobby/following{/other_user}","gists_url":"https://api.github.com/users/NickyBobby/gists{/gist_id}","starred_url":"https://api.github.com/users/NickyBobby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickyBobby/subscriptions","organizations_url":"https://api.github.com/users/NickyBobby/orgs","repos_url":"https://api.github.com/users/NickyBobby/repos","events_url":"https://api.github.com/users/NickyBobby/events{/privacy}","received_events_url":"https://api.github.com/users/NickyBobby/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T14:54:40Z","updated_at":"2016-06-15T14:54:40Z","body":"If no one has any objections I'll merge this branch now. @hhoopes @brennanholtzclaw @rrgayhart "}}
{"actor":{"display_login":"NickyBobby"}}