{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/65421945","id":65421945,"diff_hunk":"@@ -355,7 +356,8 @@ public int size()\n     }\n     Set<String> result = new TreeSet<>();\n     for (TypeGraphVertex node : tgv.allInstantiableDescendants) {\n-      if ((isAncestor(InputOperator.class.getName(), node.typeName) || !getAllInputPorts(node).isEmpty())) {\n+      if ((isAncestor(InputOperator.class.getName(), node.typeName) || isAncestor(Module.class.getName(), node.typeName)","path":"engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java","position":13,"original_position":13,"commit_id":"f60bcd2b514ea7895197131cc991db5b6b2ad887","original_commit_id":"f60bcd2b514ea7895197131cc991db5b6b2ad887","user":{"login":"siyuanh","id":5375712,"avatar_url":"https://avatars.githubusercontent.com/u/5375712?v=3","gravatar_id":"","url":"https://api.github.com/users/siyuanh","html_url":"https://github.com/siyuanh","followers_url":"https://api.github.com/users/siyuanh/followers","following_url":"https://api.github.com/users/siyuanh/following{/other_user}","gists_url":"https://api.github.com/users/siyuanh/gists{/gist_id}","starred_url":"https://api.github.com/users/siyuanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siyuanh/subscriptions","organizations_url":"https://api.github.com/users/siyuanh/orgs","repos_url":"https://api.github.com/users/siyuanh/repos","events_url":"https://api.github.com/users/siyuanh/events{/privacy}","received_events_url":"https://api.github.com/users/siyuanh/received_events","type":"User","site_admin":false},"body":" Method should do what the name suggest . Should either change the name of the method or have this in a separate method. There are same problem in TypeGraph and OperatorDiscover, please fix them as well. Otherwise, it would be confusing and error-prone in the future.","created_at":"2016-06-01T18:59:23Z","updated_at":"2016-06-01T18:59:23Z","html_url":"https://github.com/apache/incubator-apex-core/pull/338#discussion_r65421945","pull_request_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments/65421945"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/338#discussion_r65421945"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338","id":70701546,"html_url":"https://github.com/apache/incubator-apex-core/pull/338","diff_url":"https://github.com/apache/incubator-apex-core/pull/338.diff","patch_url":"https://github.com/apache/incubator-apex-core/pull/338.patch","issue_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/338","number":338,"state":"open","locked":false,"title":"APEXCORE-463 : fixed condition to allow modules that do not have input port","user":{"login":"shubham-pathak22","id":3529753,"avatar_url":"https://avatars.githubusercontent.com/u/3529753?v=3","gravatar_id":"","url":"https://api.github.com/users/shubham-pathak22","html_url":"https://github.com/shubham-pathak22","followers_url":"https://api.github.com/users/shubham-pathak22/followers","following_url":"https://api.github.com/users/shubham-pathak22/following{/other_user}","gists_url":"https://api.github.com/users/shubham-pathak22/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham-pathak22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham-pathak22/subscriptions","organizations_url":"https://api.github.com/users/shubham-pathak22/orgs","repos_url":"https://api.github.com/users/shubham-pathak22/repos","events_url":"https://api.github.com/users/shubham-pathak22/events{/privacy}","received_events_url":"https://api.github.com/users/shubham-pathak22/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-19T14:14:38Z","updated_at":"2016-06-01T18:59:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f0c29b6d7556fee3468e9f8c9fe7ef8a100113b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/338/comments","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/f60bcd2b514ea7895197131cc991db5b6b2ad887","head":{"label":"shubham-pathak22:APEXCORE-463","ref":"APEXCORE-463","sha":"f60bcd2b514ea7895197131cc991db5b6b2ad887","user":{"login":"shubham-pathak22","id":3529753,"avatar_url":"https://avatars.githubusercontent.com/u/3529753?v=3","gravatar_id":"","url":"https://api.github.com/users/shubham-pathak22","html_url":"https://github.com/shubham-pathak22","followers_url":"https://api.github.com/users/shubham-pathak22/followers","following_url":"https://api.github.com/users/shubham-pathak22/following{/other_user}","gists_url":"https://api.github.com/users/shubham-pathak22/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham-pathak22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham-pathak22/subscriptions","organizations_url":"https://api.github.com/users/shubham-pathak22/orgs","repos_url":"https://api.github.com/users/shubham-pathak22/repos","events_url":"https://api.github.com/users/shubham-pathak22/events{/privacy}","received_events_url":"https://api.github.com/users/shubham-pathak22/received_events","type":"User","site_admin":false},"repo":{"id":42051661,"name":"incubator-apex-core","full_name":"shubham-pathak22/incubator-apex-core","owner":{"login":"shubham-pathak22","id":3529753,"avatar_url":"https://avatars.githubusercontent.com/u/3529753?v=3","gravatar_id":"","url":"https://api.github.com/users/shubham-pathak22","html_url":"https://github.com/shubham-pathak22","followers_url":"https://api.github.com/users/shubham-pathak22/followers","following_url":"https://api.github.com/users/shubham-pathak22/following{/other_user}","gists_url":"https://api.github.com/users/shubham-pathak22/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham-pathak22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham-pathak22/subscriptions","organizations_url":"https://api.github.com/users/shubham-pathak22/orgs","repos_url":"https://api.github.com/users/shubham-pathak22/repos","events_url":"https://api.github.com/users/shubham-pathak22/events{/privacy}","received_events_url":"https://api.github.com/users/shubham-pathak22/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shubham-pathak22/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":true,"url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core","forks_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/shubham-pathak22/incubator-apex-core/deployments","created_at":"2015-09-07T12:26:43Z","updated_at":"2015-09-07T12:26:44Z","pushed_at":"2016-05-19T13:54:37Z","git_url":"git://github.com/shubham-pathak22/incubator-apex-core.git","ssh_url":"git@github.com:shubham-pathak22/incubator-apex-core.git","clone_url":"https://github.com/shubham-pathak22/incubator-apex-core.git","svn_url":"https://github.com/shubham-pathak22/incubator-apex-core","homepage":null,"size":13487,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7813d860d93b840910552a8ac4e5b9575e340422","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"name":"incubator-apex-core","full_name":"apache/incubator-apex-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-apex-core","forks_url":"https://api.github.com/repos/apache/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/apache/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/apache/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/apache/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/apache/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/apache/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/apache/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-apex-core/deployments","created_at":"2015-08-25T07:00:05Z","updated_at":"2016-05-26T01:33:54Z","pushed_at":"2016-06-01T18:49:40Z","git_url":"git://github.com/apache/incubator-apex-core.git","ssh_url":"git@github.com:apache/incubator-apex-core.git","clone_url":"https://github.com/apache/incubator-apex-core.git","svn_url":"https://github.com/apache/incubator-apex-core","homepage":null,"size":20580,"stargazers_count":130,"watchers_count":130,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":"git://git.apache.org/incubator-apex-core.git","open_issues_count":8,"forks":83,"open_issues":8,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338"},"html":{"href":"https://github.com/apache/incubator-apex-core/pull/338"},"issue":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/338"},"comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-apex-core/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-apex-core/statuses/f60bcd2b514ea7895197131cc991db5b6b2ad887"}}}}
{"actor":{"display_login":"siyuanh"}}