{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1558","repository_url":"https://api.github.com/repos/devtools-html/debugger.html","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1558/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1558/comments","events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1558/events","html_url":"https://github.com/devtools-html/debugger.html/issues/1558","id":197870704,"number":1558,"title":"[Breakpoints] Move toggle button","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"labels":[{"id":346505999,"url":"https://api.github.com/repos/devtools-html/debugger.html/labels/discussion","name":"discussion","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-28T15:30:21Z","updated_at":"2017-01-01T19:49:04Z","closed_at":null,"body":"@Dalimil's great work in #1546 got me to re-think how we want to treat toggling breakpoints.\r\n\r\nPreviously, the button was entirely user-set i.e. I click it to disable all bps, i click it again to re-enable all bps. This was a broken metaphor because you could also enable and disable bps individually. His PR, made it act like a group checkbox which accurately reflects the BPs aggregate state.\r\n\r\nGiven that, it would be nice to change the iconography to that of a checkbox so that its clearer for the user. Also, it would be nice to move the button to the breakpoints header so it's not confused with other App state. \r\n\r\nDown the road, I see us using the breakpoints header space better, so this is inline with the direction we're going\r\n\r\n![breakpoints-checkboxes](https://cloud.githubusercontent.com/assets/254562/21524880/633ba3d0-cce7-11e6-95ee-8e898814708b.jpg)\r\n\r\nCC @clarkbw, @Dalimil "},"comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments/269916695","html_url":"https://github.com/devtools-html/debugger.html/issues/1558#issuecomment-269916695","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/1558","id":269916695,"user":{"login":"Dalimil","id":4202539,"avatar_url":"https://avatars.githubusercontent.com/u/4202539?v=3","gravatar_id":"","url":"https://api.github.com/users/Dalimil","html_url":"https://github.com/Dalimil","followers_url":"https://api.github.com/users/Dalimil/followers","following_url":"https://api.github.com/users/Dalimil/following{/other_user}","gists_url":"https://api.github.com/users/Dalimil/gists{/gist_id}","starred_url":"https://api.github.com/users/Dalimil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dalimil/subscriptions","organizations_url":"https://api.github.com/users/Dalimil/orgs","repos_url":"https://api.github.com/users/Dalimil/repos","events_url":"https://api.github.com/users/Dalimil/events{/privacy}","received_events_url":"https://api.github.com/users/Dalimil/received_events","type":"User","site_admin":false},"created_at":"2017-01-01T19:49:04Z","updated_at":"2017-01-01T19:49:04Z","body":"I'm working on this... but the component state is a bit complicated to maintain because 'indeterminate' can only be sent via JavaScript and 'checked=true' seems to override 'indeterminate=true'. It would need to be an uncontrolled input that is initialized after it mounts..."}}
{"actor":{"display_login":"Dalimil"}}