{"action":"closed","number":249,"pull_request":{"url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/249","id":65489000,"html_url":"https://github.com/schmittjoh/JMSDiExtraBundle/pull/249","diff_url":"https://github.com/schmittjoh/JMSDiExtraBundle/pull/249.diff","patch_url":"https://github.com/schmittjoh/JMSDiExtraBundle/pull/249.patch","issue_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues/249","number":249,"state":"closed","locked":false,"title":"Add shared service parameter (replaces scope SF3)","user":{"login":"mrardon","id":634533,"avatar_url":"https://avatars.githubusercontent.com/u/634533?v=3","gravatar_id":"","url":"https://api.github.com/users/mrardon","html_url":"https://github.com/mrardon","followers_url":"https://api.github.com/users/mrardon/followers","following_url":"https://api.github.com/users/mrardon/following{/other_user}","gists_url":"https://api.github.com/users/mrardon/gists{/gist_id}","starred_url":"https://api.github.com/users/mrardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrardon/subscriptions","organizations_url":"https://api.github.com/users/mrardon/orgs","repos_url":"https://api.github.com/users/mrardon/repos","events_url":"https://api.github.com/users/mrardon/events{/privacy}","received_events_url":"https://api.github.com/users/mrardon/received_events","type":"User","site_admin":false},"body":"Was using some prototype scoped services which were removed in 3.0 in favor of shared = false.\r\n\r\nRef: https://github.com/symfony/symfony/blob/master/UPGRADE-3.0.md#dependencyinjection\r\n\r\n\r\nI am not sure of any implications of doing this and leaving both available regardless of Symfony version so let me know if there is a better strategy to solve this problem.","created_at":"2016-04-06T15:42:56Z","updated_at":"2016-04-18T17:22:48Z","closed_at":"2016-04-18T17:22:48Z","merged_at":"2016-04-18T17:22:48Z","merge_commit_sha":"5ccf7f89990fab48d1fceca557f5369598a9ffb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/249/commits","review_comments_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/249/comments","review_comment_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues/249/comments","statuses_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/statuses/49886d50555d0a742d2f15947277c1a16346db06","head":{"label":"mrardon:mrardon-add-shared","ref":"mrardon-add-shared","sha":"49886d50555d0a742d2f15947277c1a16346db06","user":{"login":"mrardon","id":634533,"avatar_url":"https://avatars.githubusercontent.com/u/634533?v=3","gravatar_id":"","url":"https://api.github.com/users/mrardon","html_url":"https://github.com/mrardon","followers_url":"https://api.github.com/users/mrardon/followers","following_url":"https://api.github.com/users/mrardon/following{/other_user}","gists_url":"https://api.github.com/users/mrardon/gists{/gist_id}","starred_url":"https://api.github.com/users/mrardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrardon/subscriptions","organizations_url":"https://api.github.com/users/mrardon/orgs","repos_url":"https://api.github.com/users/mrardon/repos","events_url":"https://api.github.com/users/mrardon/events{/privacy}","received_events_url":"https://api.github.com/users/mrardon/received_events","type":"User","site_admin":false},"repo":{"id":55617728,"name":"JMSDiExtraBundle","full_name":"mrardon/JMSDiExtraBundle","owner":{"login":"mrardon","id":634533,"avatar_url":"https://avatars.githubusercontent.com/u/634533?v=3","gravatar_id":"","url":"https://api.github.com/users/mrardon","html_url":"https://github.com/mrardon","followers_url":"https://api.github.com/users/mrardon/followers","following_url":"https://api.github.com/users/mrardon/following{/other_user}","gists_url":"https://api.github.com/users/mrardon/gists{/gist_id}","starred_url":"https://api.github.com/users/mrardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrardon/subscriptions","organizations_url":"https://api.github.com/users/mrardon/orgs","repos_url":"https://api.github.com/users/mrardon/repos","events_url":"https://api.github.com/users/mrardon/events{/privacy}","received_events_url":"https://api.github.com/users/mrardon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrardon/JMSDiExtraBundle","description":"Provides Advanced Dependency Injection Features for Symfony2","fork":true,"url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle","forks_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/forks","keys_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/teams","hooks_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/hooks","issue_events_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/issues/events{/number}","events_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/events","assignees_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/assignees{/user}","branches_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/branches{/branch}","tags_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/tags","blobs_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/languages","stargazers_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/stargazers","contributors_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/contributors","subscribers_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/subscribers","subscription_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/subscription","commits_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/contents/{+path}","compare_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/merges","archive_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/downloads","issues_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/issues{/number}","pulls_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/labels{/name}","releases_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/releases{/id}","deployments_url":"https://api.github.com/repos/mrardon/JMSDiExtraBundle/deployments","created_at":"2016-04-06T15:27:49Z","updated_at":"2016-04-06T15:27:49Z","pushed_at":"2016-04-06T15:37:47Z","git_url":"git://github.com/mrardon/JMSDiExtraBundle.git","ssh_url":"git@github.com:mrardon/JMSDiExtraBundle.git","clone_url":"https://github.com/mrardon/JMSDiExtraBundle.git","svn_url":"https://github.com/mrardon/JMSDiExtraBundle","homepage":"http://jmsyst.com/bundles/JMSDiExtraBundle","size":395,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"schmittjoh:master","ref":"master","sha":"9a5e7bef575fe1ff4e06bc8b1422d2d984ed8972","user":{"login":"schmittjoh","id":197017,"avatar_url":"https://avatars.githubusercontent.com/u/197017?v=3","gravatar_id":"","url":"https://api.github.com/users/schmittjoh","html_url":"https://github.com/schmittjoh","followers_url":"https://api.github.com/users/schmittjoh/followers","following_url":"https://api.github.com/users/schmittjoh/following{/other_user}","gists_url":"https://api.github.com/users/schmittjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/schmittjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmittjoh/subscriptions","organizations_url":"https://api.github.com/users/schmittjoh/orgs","repos_url":"https://api.github.com/users/schmittjoh/repos","events_url":"https://api.github.com/users/schmittjoh/events{/privacy}","received_events_url":"https://api.github.com/users/schmittjoh/received_events","type":"User","site_admin":false},"repo":{"id":1952092,"name":"JMSDiExtraBundle","full_name":"schmittjoh/JMSDiExtraBundle","owner":{"login":"schmittjoh","id":197017,"avatar_url":"https://avatars.githubusercontent.com/u/197017?v=3","gravatar_id":"","url":"https://api.github.com/users/schmittjoh","html_url":"https://github.com/schmittjoh","followers_url":"https://api.github.com/users/schmittjoh/followers","following_url":"https://api.github.com/users/schmittjoh/following{/other_user}","gists_url":"https://api.github.com/users/schmittjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/schmittjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmittjoh/subscriptions","organizations_url":"https://api.github.com/users/schmittjoh/orgs","repos_url":"https://api.github.com/users/schmittjoh/repos","events_url":"https://api.github.com/users/schmittjoh/events{/privacy}","received_events_url":"https://api.github.com/users/schmittjoh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmittjoh/JMSDiExtraBundle","description":"Provides Advanced Dependency Injection Features for Symfony2","fork":false,"url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle","forks_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/forks","keys_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/teams","hooks_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/hooks","issue_events_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues/events{/number}","events_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/events","assignees_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/assignees{/user}","branches_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/branches{/branch}","tags_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/tags","blobs_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/languages","stargazers_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/stargazers","contributors_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/contributors","subscribers_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/subscribers","subscription_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/subscription","commits_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/contents/{+path}","compare_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/merges","archive_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/downloads","issues_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues{/number}","pulls_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/labels{/name}","releases_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/releases{/id}","deployments_url":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/deployments","created_at":"2011-06-25T13:20:39Z","updated_at":"2016-04-15T12:56:21Z","pushed_at":"2016-04-18T17:22:48Z","git_url":"git://github.com/schmittjoh/JMSDiExtraBundle.git","ssh_url":"git@github.com:schmittjoh/JMSDiExtraBundle.git","clone_url":"https://github.com/schmittjoh/JMSDiExtraBundle.git","svn_url":"https://github.com/schmittjoh/JMSDiExtraBundle","homepage":"http://jmsyst.com/bundles/JMSDiExtraBundle","size":545,"stargazers_count":236,"watchers_count":236,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":90,"forks":93,"open_issues":90,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/249"},"html":{"href":"https://github.com/schmittjoh/JMSDiExtraBundle/pull/249"},"issue":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues/249"},"comments":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/schmittjoh/JMSDiExtraBundle/statuses/49886d50555d0a742d2f15947277c1a16346db06"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Ener-Getick","id":6871899,"avatar_url":"https://avatars.githubusercontent.com/u/6871899?v=3","gravatar_id":"","url":"https://api.github.com/users/Ener-Getick","html_url":"https://github.com/Ener-Getick","followers_url":"https://api.github.com/users/Ener-Getick/followers","following_url":"https://api.github.com/users/Ener-Getick/following{/other_user}","gists_url":"https://api.github.com/users/Ener-Getick/gists{/gist_id}","starred_url":"https://api.github.com/users/Ener-Getick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ener-Getick/subscriptions","organizations_url":"https://api.github.com/users/Ener-Getick/orgs","repos_url":"https://api.github.com/users/Ener-Getick/repos","events_url":"https://api.github.com/users/Ener-Getick/events{/privacy}","received_events_url":"https://api.github.com/users/Ener-Getick/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":0,"changed_files":4}}