{"action":"created","comment":{"url":"https://api.github.com/repos/icecc/icecream/pulls/comments/56590754","id":56590754,"diff_hunk":"@@ -27,6 +27,29 @@ is_contained ()\n   esac\n }\n \n+# Equivalent to Linux readlink -f command\n+resolve_path ()\n+{\n+    TARGET_FILE=$1\n+\n+    cd `dirname $TARGET_FILE`","path":"client/icecc-create-env.in","position":9,"original_position":9,"commit_id":"80f3dccdac35188b3f5882bc9ef7fd9c8d288d34","original_commit_id":"80f3dccdac35188b3f5882bc9ef7fd9c8d288d34","user":{"login":"HenryMiller1","id":9381906,"avatar_url":"https://avatars.githubusercontent.com/u/9381906?v=3","gravatar_id":"","url":"https://api.github.com/users/HenryMiller1","html_url":"https://github.com/HenryMiller1","followers_url":"https://api.github.com/users/HenryMiller1/followers","following_url":"https://api.github.com/users/HenryMiller1/following{/other_user}","gists_url":"https://api.github.com/users/HenryMiller1/gists{/gist_id}","starred_url":"https://api.github.com/users/HenryMiller1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenryMiller1/subscriptions","organizations_url":"https://api.github.com/users/HenryMiller1/orgs","repos_url":"https://api.github.com/users/HenryMiller1/repos","events_url":"https://api.github.com/users/HenryMiller1/events{/privacy}","received_events_url":"https://api.github.com/users/HenryMiller1/received_events","type":"User","site_admin":false},"body":"use pushd here and popd at the end of the function.  Or run this all in a subshell.","created_at":"2016-03-17T22:49:25Z","updated_at":"2016-03-17T22:49:25Z","html_url":"https://github.com/icecc/icecream/pull/139#discussion_r56590754","pull_request_url":"https://api.github.com/repos/icecc/icecream/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/icecc/icecream/pulls/comments/56590754"},"html":{"href":"https://github.com/icecc/icecream/pull/139#discussion_r56590754"},"pull_request":{"href":"https://api.github.com/repos/icecc/icecream/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/icecc/icecream/pulls/139","id":43717581,"html_url":"https://github.com/icecc/icecream/pull/139","diff_url":"https://github.com/icecc/icecream/pull/139.diff","patch_url":"https://github.com/icecc/icecream/pull/139.patch","issue_url":"https://api.github.com/repos/icecc/icecream/issues/139","number":139,"state":"open","locked":false,"title":"Fix relative paths to toolchain files","user":{"login":"jineshkj","id":467935,"avatar_url":"https://avatars.githubusercontent.com/u/467935?v=3","gravatar_id":"","url":"https://api.github.com/users/jineshkj","html_url":"https://github.com/jineshkj","followers_url":"https://api.github.com/users/jineshkj/followers","following_url":"https://api.github.com/users/jineshkj/following{/other_user}","gists_url":"https://api.github.com/users/jineshkj/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshkj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshkj/subscriptions","organizations_url":"https://api.github.com/users/jineshkj/orgs","repos_url":"https://api.github.com/users/jineshkj/repos","events_url":"https://api.github.com/users/jineshkj/events{/privacy}","received_events_url":"https://api.github.com/users/jineshkj/received_events","type":"User","site_admin":false},"body":"Use 'readlink -e' to follow the compiler and toolchain file to their\r\nfully resolved location without which relative paths generated will\r\nbe incorrect especially when the compiler itself is pointed by a\r\nsymbolic link.","created_at":"2015-08-30T18:09:32Z","updated_at":"2016-03-17T22:49:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"918f25949a80a33abbea3cbbd76e5423d323fdaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/icecc/icecream/pulls/139/commits","review_comments_url":"https://api.github.com/repos/icecc/icecream/pulls/139/comments","review_comment_url":"https://api.github.com/repos/icecc/icecream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/icecc/icecream/issues/139/comments","statuses_url":"https://api.github.com/repos/icecc/icecream/statuses/80f3dccdac35188b3f5882bc9ef7fd9c8d288d34","head":{"label":"jineshkj:master","ref":"master","sha":"80f3dccdac35188b3f5882bc9ef7fd9c8d288d34","user":{"login":"jineshkj","id":467935,"avatar_url":"https://avatars.githubusercontent.com/u/467935?v=3","gravatar_id":"","url":"https://api.github.com/users/jineshkj","html_url":"https://github.com/jineshkj","followers_url":"https://api.github.com/users/jineshkj/followers","following_url":"https://api.github.com/users/jineshkj/following{/other_user}","gists_url":"https://api.github.com/users/jineshkj/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshkj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshkj/subscriptions","organizations_url":"https://api.github.com/users/jineshkj/orgs","repos_url":"https://api.github.com/users/jineshkj/repos","events_url":"https://api.github.com/users/jineshkj/events{/privacy}","received_events_url":"https://api.github.com/users/jineshkj/received_events","type":"User","site_admin":false},"repo":{"id":41637513,"name":"icecream","full_name":"jineshkj/icecream","owner":{"login":"jineshkj","id":467935,"avatar_url":"https://avatars.githubusercontent.com/u/467935?v=3","gravatar_id":"","url":"https://api.github.com/users/jineshkj","html_url":"https://github.com/jineshkj","followers_url":"https://api.github.com/users/jineshkj/followers","following_url":"https://api.github.com/users/jineshkj/following{/other_user}","gists_url":"https://api.github.com/users/jineshkj/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshkj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshkj/subscriptions","organizations_url":"https://api.github.com/users/jineshkj/orgs","repos_url":"https://api.github.com/users/jineshkj/repos","events_url":"https://api.github.com/users/jineshkj/events{/privacy}","received_events_url":"https://api.github.com/users/jineshkj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jineshkj/icecream","description":"Distributed compiler with a central scheduler to share build load","fork":true,"url":"https://api.github.com/repos/jineshkj/icecream","forks_url":"https://api.github.com/repos/jineshkj/icecream/forks","keys_url":"https://api.github.com/repos/jineshkj/icecream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jineshkj/icecream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jineshkj/icecream/teams","hooks_url":"https://api.github.com/repos/jineshkj/icecream/hooks","issue_events_url":"https://api.github.com/repos/jineshkj/icecream/issues/events{/number}","events_url":"https://api.github.com/repos/jineshkj/icecream/events","assignees_url":"https://api.github.com/repos/jineshkj/icecream/assignees{/user}","branches_url":"https://api.github.com/repos/jineshkj/icecream/branches{/branch}","tags_url":"https://api.github.com/repos/jineshkj/icecream/tags","blobs_url":"https://api.github.com/repos/jineshkj/icecream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jineshkj/icecream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jineshkj/icecream/git/refs{/sha}","trees_url":"https://api.github.com/repos/jineshkj/icecream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jineshkj/icecream/statuses/{sha}","languages_url":"https://api.github.com/repos/jineshkj/icecream/languages","stargazers_url":"https://api.github.com/repos/jineshkj/icecream/stargazers","contributors_url":"https://api.github.com/repos/jineshkj/icecream/contributors","subscribers_url":"https://api.github.com/repos/jineshkj/icecream/subscribers","subscription_url":"https://api.github.com/repos/jineshkj/icecream/subscription","commits_url":"https://api.github.com/repos/jineshkj/icecream/commits{/sha}","git_commits_url":"https://api.github.com/repos/jineshkj/icecream/git/commits{/sha}","comments_url":"https://api.github.com/repos/jineshkj/icecream/comments{/number}","issue_comment_url":"https://api.github.com/repos/jineshkj/icecream/issues/comments{/number}","contents_url":"https://api.github.com/repos/jineshkj/icecream/contents/{+path}","compare_url":"https://api.github.com/repos/jineshkj/icecream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jineshkj/icecream/merges","archive_url":"https://api.github.com/repos/jineshkj/icecream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jineshkj/icecream/downloads","issues_url":"https://api.github.com/repos/jineshkj/icecream/issues{/number}","pulls_url":"https://api.github.com/repos/jineshkj/icecream/pulls{/number}","milestones_url":"https://api.github.com/repos/jineshkj/icecream/milestones{/number}","notifications_url":"https://api.github.com/repos/jineshkj/icecream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jineshkj/icecream/labels{/name}","releases_url":"https://api.github.com/repos/jineshkj/icecream/releases{/id}","deployments_url":"https://api.github.com/repos/jineshkj/icecream/deployments","created_at":"2015-08-30T17:50:03Z","updated_at":"2015-08-30T17:50:04Z","pushed_at":"2015-09-07T00:08:23Z","git_url":"git://github.com/jineshkj/icecream.git","ssh_url":"git@github.com:jineshkj/icecream.git","clone_url":"https://github.com/jineshkj/icecream.git","svn_url":"https://github.com/jineshkj/icecream","homepage":null,"size":3861,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"icecc:master","ref":"master","sha":"7449982553e76b4bc3acd9d37edec2acd213d8b0","user":{"login":"icecc","id":2630014,"avatar_url":"https://avatars.githubusercontent.com/u/2630014?v=3","gravatar_id":"","url":"https://api.github.com/users/icecc","html_url":"https://github.com/icecc","followers_url":"https://api.github.com/users/icecc/followers","following_url":"https://api.github.com/users/icecc/following{/other_user}","gists_url":"https://api.github.com/users/icecc/gists{/gist_id}","starred_url":"https://api.github.com/users/icecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icecc/subscriptions","organizations_url":"https://api.github.com/users/icecc/orgs","repos_url":"https://api.github.com/users/icecc/repos","events_url":"https://api.github.com/users/icecc/events{/privacy}","received_events_url":"https://api.github.com/users/icecc/received_events","type":"Organization","site_admin":false},"repo":{"id":6349186,"name":"icecream","full_name":"icecc/icecream","owner":{"login":"icecc","id":2630014,"avatar_url":"https://avatars.githubusercontent.com/u/2630014?v=3","gravatar_id":"","url":"https://api.github.com/users/icecc","html_url":"https://github.com/icecc","followers_url":"https://api.github.com/users/icecc/followers","following_url":"https://api.github.com/users/icecc/following{/other_user}","gists_url":"https://api.github.com/users/icecc/gists{/gist_id}","starred_url":"https://api.github.com/users/icecc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icecc/subscriptions","organizations_url":"https://api.github.com/users/icecc/orgs","repos_url":"https://api.github.com/users/icecc/repos","events_url":"https://api.github.com/users/icecc/events{/privacy}","received_events_url":"https://api.github.com/users/icecc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/icecc/icecream","description":"Distributed compiler with a central scheduler to share build load","fork":false,"url":"https://api.github.com/repos/icecc/icecream","forks_url":"https://api.github.com/repos/icecc/icecream/forks","keys_url":"https://api.github.com/repos/icecc/icecream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icecc/icecream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icecc/icecream/teams","hooks_url":"https://api.github.com/repos/icecc/icecream/hooks","issue_events_url":"https://api.github.com/repos/icecc/icecream/issues/events{/number}","events_url":"https://api.github.com/repos/icecc/icecream/events","assignees_url":"https://api.github.com/repos/icecc/icecream/assignees{/user}","branches_url":"https://api.github.com/repos/icecc/icecream/branches{/branch}","tags_url":"https://api.github.com/repos/icecc/icecream/tags","blobs_url":"https://api.github.com/repos/icecc/icecream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icecc/icecream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icecc/icecream/git/refs{/sha}","trees_url":"https://api.github.com/repos/icecc/icecream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icecc/icecream/statuses/{sha}","languages_url":"https://api.github.com/repos/icecc/icecream/languages","stargazers_url":"https://api.github.com/repos/icecc/icecream/stargazers","contributors_url":"https://api.github.com/repos/icecc/icecream/contributors","subscribers_url":"https://api.github.com/repos/icecc/icecream/subscribers","subscription_url":"https://api.github.com/repos/icecc/icecream/subscription","commits_url":"https://api.github.com/repos/icecc/icecream/commits{/sha}","git_commits_url":"https://api.github.com/repos/icecc/icecream/git/commits{/sha}","comments_url":"https://api.github.com/repos/icecc/icecream/comments{/number}","issue_comment_url":"https://api.github.com/repos/icecc/icecream/issues/comments{/number}","contents_url":"https://api.github.com/repos/icecc/icecream/contents/{+path}","compare_url":"https://api.github.com/repos/icecc/icecream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icecc/icecream/merges","archive_url":"https://api.github.com/repos/icecc/icecream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icecc/icecream/downloads","issues_url":"https://api.github.com/repos/icecc/icecream/issues{/number}","pulls_url":"https://api.github.com/repos/icecc/icecream/pulls{/number}","milestones_url":"https://api.github.com/repos/icecc/icecream/milestones{/number}","notifications_url":"https://api.github.com/repos/icecc/icecream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icecc/icecream/labels{/name}","releases_url":"https://api.github.com/repos/icecc/icecream/releases{/id}","deployments_url":"https://api.github.com/repos/icecc/icecream/deployments","created_at":"2012-10-23T08:33:43Z","updated_at":"2016-03-17T04:54:20Z","pushed_at":"2016-03-16T18:50:28Z","git_url":"git://github.com/icecc/icecream.git","ssh_url":"git@github.com:icecc/icecream.git","clone_url":"https://github.com/icecc/icecream.git","svn_url":"https://github.com/icecc/icecream","homepage":null,"size":4532,"stargazers_count":212,"watchers_count":212,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":31,"forks":72,"open_issues":31,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/icecc/icecream/pulls/139"},"html":{"href":"https://github.com/icecc/icecream/pull/139"},"issue":{"href":"https://api.github.com/repos/icecc/icecream/issues/139"},"comments":{"href":"https://api.github.com/repos/icecc/icecream/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/icecc/icecream/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/icecc/icecream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/icecc/icecream/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/icecc/icecream/statuses/80f3dccdac35188b3f5882bc9ef7fd9c8d288d34"}}}}