{"action":"closed","number":167,"pull_request":{"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/167","id":93425397,"html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/167","diff_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/167.diff","patch_url":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/167.patch","issue_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/167","number":167,"state":"closed","locked":false,"title":"initial resume API for SETUP/RESUME","user":{"login":"tmontgomery","id":1979352,"avatar_url":"https://avatars.githubusercontent.com/u/1979352?v=3","gravatar_id":"","url":"https://api.github.com/users/tmontgomery","html_url":"https://github.com/tmontgomery","followers_url":"https://api.github.com/users/tmontgomery/followers","following_url":"https://api.github.com/users/tmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/tmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmontgomery/subscriptions","organizations_url":"https://api.github.com/users/tmontgomery/orgs","repos_url":"https://api.github.com/users/tmontgomery/repos","events_url":"https://api.github.com/users/tmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/tmontgomery/received_events","type":"User","site_admin":false},"body":"I've been iterating on the API for resume. Feedback welcome.\r\n\r\nThe hideous method of \"resumeFromSocket\" and technique has been removed. Now RequestHandler has a `handleResume` method that is called instead.\r\n\r\nThe state for the connection is kept in a `StreamState` object (name is not very good, but can't think of a better one. Open to suggestions). This state is now created by the return value of `RequestHandler::handleSetupPayload` and returned in `RequestHandler::handleResume`.\r\n\r\nThis is not perfect, but it seems cleaner. By bringing the stream state out into its own object, it can be managed easier. It also decouples it from the ReactiveSocket. RequestHandler is maybe not the perfect place to put SETUP and RESUME logic, but we could break those out into their own handler. Would love opinions on that.\r\n\r\nThe aspects of marking dirty/clean are not included in this PR. I wanted to get feedback on this first and get it sorted then include what I have been playing with for dirty/clean.\r\n","created_at":"2016-11-12T02:51:31Z","updated_at":"2016-11-15T23:23:49Z","closed_at":"2016-11-15T23:23:49Z","merged_at":"2016-11-15T23:23:49Z","merge_commit_sha":"5f8cd24c2ab11f307c4938bab8af3096c1067d5b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/167/commits","review_comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/167/comments","review_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/167/comments","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/statuses/d8e10679ae8ad8af68fa181bbb31db6935870cbc","head":{"label":"tmontgomery:resume-api","ref":"resume-api","sha":"d8e10679ae8ad8af68fa181bbb31db6935870cbc","user":{"login":"tmontgomery","id":1979352,"avatar_url":"https://avatars.githubusercontent.com/u/1979352?v=3","gravatar_id":"","url":"https://api.github.com/users/tmontgomery","html_url":"https://github.com/tmontgomery","followers_url":"https://api.github.com/users/tmontgomery/followers","following_url":"https://api.github.com/users/tmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/tmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmontgomery/subscriptions","organizations_url":"https://api.github.com/users/tmontgomery/orgs","repos_url":"https://api.github.com/users/tmontgomery/repos","events_url":"https://api.github.com/users/tmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/tmontgomery/received_events","type":"User","site_admin":false},"repo":{"id":66572857,"name":"reactivesocket-cpp","full_name":"tmontgomery/reactivesocket-cpp","owner":{"login":"tmontgomery","id":1979352,"avatar_url":"https://avatars.githubusercontent.com/u/1979352?v=3","gravatar_id":"","url":"https://api.github.com/users/tmontgomery","html_url":"https://github.com/tmontgomery","followers_url":"https://api.github.com/users/tmontgomery/followers","following_url":"https://api.github.com/users/tmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/tmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmontgomery/subscriptions","organizations_url":"https://api.github.com/users/tmontgomery/orgs","repos_url":"https://api.github.com/users/tmontgomery/repos","events_url":"https://api.github.com/users/tmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/tmontgomery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmontgomery/reactivesocket-cpp","description":"C++ implementation of ReactiveSocket","fork":true,"url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp","forks_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/forks","keys_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/teams","hooks_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/hooks","issue_events_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/events","assignees_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/tags","blobs_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/languages","stargazers_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/stargazers","contributors_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/contributors","subscribers_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/subscribers","subscription_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/subscription","commits_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/merges","archive_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/downloads","issues_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/labels{/name}","releases_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/tmontgomery/reactivesocket-cpp/deployments","created_at":"2016-08-25T16:00:32Z","updated_at":"2016-08-25T16:00:33Z","pushed_at":"2016-11-12T02:41:58Z","git_url":"git://github.com/tmontgomery/reactivesocket-cpp.git","ssh_url":"git@github.com:tmontgomery/reactivesocket-cpp.git","clone_url":"https://github.com/tmontgomery/reactivesocket-cpp.git","svn_url":"https://github.com/tmontgomery/reactivesocket-cpp","homepage":null,"size":1994,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveSocket:master","ref":"master","sha":"55bb69bc969b0d859d5f971c71fbb0fddf7d2f5d","user":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"repo":{"id":53889141,"name":"reactivesocket-cpp","full_name":"ReactiveSocket/reactivesocket-cpp","owner":{"login":"ReactiveSocket","id":13168916,"avatar_url":"https://avatars.githubusercontent.com/u/13168916?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveSocket","html_url":"https://github.com/ReactiveSocket","followers_url":"https://api.github.com/users/ReactiveSocket/followers","following_url":"https://api.github.com/users/ReactiveSocket/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveSocket/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveSocket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveSocket/subscriptions","organizations_url":"https://api.github.com/users/ReactiveSocket/orgs","repos_url":"https://api.github.com/users/ReactiveSocket/repos","events_url":"https://api.github.com/users/ReactiveSocket/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveSocket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveSocket/reactivesocket-cpp","description":"C++ implementation of ReactiveSocket","fork":false,"url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp","forks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/forks","keys_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/teams","hooks_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/hooks","issue_events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/events","assignees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/tags","blobs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/languages","stargazers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/stargazers","contributors_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/contributors","subscribers_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/subscribers","subscription_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/subscription","commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/merges","archive_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/downloads","issues_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/deployments","created_at":"2016-03-14T20:20:55Z","updated_at":"2016-11-01T07:44:51Z","pushed_at":"2016-11-15T23:23:49Z","git_url":"git://github.com/ReactiveSocket/reactivesocket-cpp.git","ssh_url":"git@github.com:ReactiveSocket/reactivesocket-cpp.git","clone_url":"https://github.com/ReactiveSocket/reactivesocket-cpp.git","svn_url":"https://github.com/ReactiveSocket/reactivesocket-cpp","homepage":null,"size":2168,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":22,"forks":13,"open_issues":22,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/167"},"html":{"href":"https://github.com/ReactiveSocket/reactivesocket-cpp/pull/167"},"issue":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/167"},"comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveSocket/reactivesocket-cpp/statuses/d8e10679ae8ad8af68fa181bbb31db6935870cbc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lehecka","id":8785194,"avatar_url":"https://avatars.githubusercontent.com/u/8785194?v=3","gravatar_id":"","url":"https://api.github.com/users/lehecka","html_url":"https://github.com/lehecka","followers_url":"https://api.github.com/users/lehecka/followers","following_url":"https://api.github.com/users/lehecka/following{/other_user}","gists_url":"https://api.github.com/users/lehecka/gists{/gist_id}","starred_url":"https://api.github.com/users/lehecka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehecka/subscriptions","organizations_url":"https://api.github.com/users/lehecka/orgs","repos_url":"https://api.github.com/users/lehecka/repos","events_url":"https://api.github.com/users/lehecka/events{/privacy}","received_events_url":"https://api.github.com/users/lehecka/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":210,"deletions":142,"changed_files":18}}
{"actor":{"display_login":"lehecka"}}