{"action":"closed","number":2394,"pull_request":{"url":"https://api.github.com/repos/pixijs/pixi.js/pulls/2394","id":62670191,"html_url":"https://github.com/pixijs/pixi.js/pull/2394","diff_url":"https://github.com/pixijs/pixi.js/pull/2394.diff","patch_url":"https://github.com/pixijs/pixi.js/pull/2394.patch","issue_url":"https://api.github.com/repos/pixijs/pixi.js/issues/2394","number":2394,"state":"closed","locked":false,"title":"Proposal for issue #2377, SpritesheetParser middleware may block UI for large spritesheets","user":{"login":"lukastaegert","id":12949268,"avatar_url":"https://avatars.githubusercontent.com/u/12949268?v=3","gravatar_id":"","url":"https://api.github.com/users/lukastaegert","html_url":"https://github.com/lukastaegert","followers_url":"https://api.github.com/users/lukastaegert/followers","following_url":"https://api.github.com/users/lukastaegert/following{/other_user}","gists_url":"https://api.github.com/users/lukastaegert/gists{/gist_id}","starred_url":"https://api.github.com/users/lukastaegert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukastaegert/subscriptions","organizations_url":"https://api.github.com/users/lukastaegert/orgs","repos_url":"https://api.github.com/users/lukastaegert/repos","events_url":"https://api.github.com/users/lukastaegert/events{/privacy}","received_events_url":"https://api.github.com/users/lukastaegert/received_events","type":"User","site_admin":false},"body":"* This changes the sprite sheet parser to automatically parse a sprite sheet in batches of 1000 frames if it contains more than 1000 frames\r\n* After each batch, the event loop is skipped once to not block the UI\r\n* Not implemented: As discussed in the previous version of this pull request, it might be a good idea to make batching optional via a parameter; as this might influence the interface of the loader, this was not implemented here\r\n* Also fixes a problem where, when calling loader.reset() after loading a sprite sheet JSON has started but before its corresponding image resource has started loading, a left-over …_image resource might remain in loader.resources[], leading to an error message when trying to load the corresponding JSON again","created_at":"2016-03-13T12:51:11Z","updated_at":"2016-03-13T23:04:45Z","closed_at":"2016-03-13T23:04:45Z","merged_at":null,"merge_commit_sha":"e98751417d04b2057f9962c1c3edcb155860a607","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pixijs/pixi.js/pulls/2394/commits","review_comments_url":"https://api.github.com/repos/pixijs/pixi.js/pulls/2394/comments","review_comment_url":"https://api.github.com/repos/pixijs/pixi.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixijs/pixi.js/issues/2394/comments","statuses_url":"https://api.github.com/repos/pixijs/pixi.js/statuses/3012d8302e5ea164bacc6fd9e8e614a8e7415b8e","head":{"label":"lukastaegert:dev","ref":"dev","sha":"3012d8302e5ea164bacc6fd9e8e614a8e7415b8e","user":{"login":"lukastaegert","id":12949268,"avatar_url":"https://avatars.githubusercontent.com/u/12949268?v=3","gravatar_id":"","url":"https://api.github.com/users/lukastaegert","html_url":"https://github.com/lukastaegert","followers_url":"https://api.github.com/users/lukastaegert/followers","following_url":"https://api.github.com/users/lukastaegert/following{/other_user}","gists_url":"https://api.github.com/users/lukastaegert/gists{/gist_id}","starred_url":"https://api.github.com/users/lukastaegert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukastaegert/subscriptions","organizations_url":"https://api.github.com/users/lukastaegert/orgs","repos_url":"https://api.github.com/users/lukastaegert/repos","events_url":"https://api.github.com/users/lukastaegert/events{/privacy}","received_events_url":"https://api.github.com/users/lukastaegert/received_events","type":"User","site_admin":false},"repo":{"id":53781298,"name":"pixi.js","full_name":"lukastaegert/pixi.js","owner":{"login":"lukastaegert","id":12949268,"avatar_url":"https://avatars.githubusercontent.com/u/12949268?v=3","gravatar_id":"","url":"https://api.github.com/users/lukastaegert","html_url":"https://github.com/lukastaegert","followers_url":"https://api.github.com/users/lukastaegert/followers","following_url":"https://api.github.com/users/lukastaegert/following{/other_user}","gists_url":"https://api.github.com/users/lukastaegert/gists{/gist_id}","starred_url":"https://api.github.com/users/lukastaegert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukastaegert/subscriptions","organizations_url":"https://api.github.com/users/lukastaegert/orgs","repos_url":"https://api.github.com/users/lukastaegert/repos","events_url":"https://api.github.com/users/lukastaegert/events{/privacy}","received_events_url":"https://api.github.com/users/lukastaegert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukastaegert/pixi.js","description":"Super fast HTML 5 2D rendering engine that uses webGL with canvas fallback","fork":true,"url":"https://api.github.com/repos/lukastaegert/pixi.js","forks_url":"https://api.github.com/repos/lukastaegert/pixi.js/forks","keys_url":"https://api.github.com/repos/lukastaegert/pixi.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukastaegert/pixi.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukastaegert/pixi.js/teams","hooks_url":"https://api.github.com/repos/lukastaegert/pixi.js/hooks","issue_events_url":"https://api.github.com/repos/lukastaegert/pixi.js/issues/events{/number}","events_url":"https://api.github.com/repos/lukastaegert/pixi.js/events","assignees_url":"https://api.github.com/repos/lukastaegert/pixi.js/assignees{/user}","branches_url":"https://api.github.com/repos/lukastaegert/pixi.js/branches{/branch}","tags_url":"https://api.github.com/repos/lukastaegert/pixi.js/tags","blobs_url":"https://api.github.com/repos/lukastaegert/pixi.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukastaegert/pixi.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukastaegert/pixi.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukastaegert/pixi.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukastaegert/pixi.js/statuses/{sha}","languages_url":"https://api.github.com/repos/lukastaegert/pixi.js/languages","stargazers_url":"https://api.github.com/repos/lukastaegert/pixi.js/stargazers","contributors_url":"https://api.github.com/repos/lukastaegert/pixi.js/contributors","subscribers_url":"https://api.github.com/repos/lukastaegert/pixi.js/subscribers","subscription_url":"https://api.github.com/repos/lukastaegert/pixi.js/subscription","commits_url":"https://api.github.com/repos/lukastaegert/pixi.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukastaegert/pixi.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukastaegert/pixi.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukastaegert/pixi.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukastaegert/pixi.js/contents/{+path}","compare_url":"https://api.github.com/repos/lukastaegert/pixi.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukastaegert/pixi.js/merges","archive_url":"https://api.github.com/repos/lukastaegert/pixi.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukastaegert/pixi.js/downloads","issues_url":"https://api.github.com/repos/lukastaegert/pixi.js/issues{/number}","pulls_url":"https://api.github.com/repos/lukastaegert/pixi.js/pulls{/number}","milestones_url":"https://api.github.com/repos/lukastaegert/pixi.js/milestones{/number}","notifications_url":"https://api.github.com/repos/lukastaegert/pixi.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukastaegert/pixi.js/labels{/name}","releases_url":"https://api.github.com/repos/lukastaegert/pixi.js/releases{/id}","deployments_url":"https://api.github.com/repos/lukastaegert/pixi.js/deployments","created_at":"2016-03-13T11:23:54Z","updated_at":"2016-03-13T11:23:56Z","pushed_at":"2016-03-13T12:41:47Z","git_url":"git://github.com/lukastaegert/pixi.js.git","ssh_url":"git@github.com:lukastaegert/pixi.js.git","clone_url":"https://github.com/lukastaegert/pixi.js.git","svn_url":"https://github.com/lukastaegert/pixi.js","homepage":null,"size":53275,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pixijs:dev","ref":"dev","sha":"a55b38eb8bf6050ff9a791a1fa59228afbb20181","user":{"login":"pixijs","id":5406849,"avatar_url":"https://avatars.githubusercontent.com/u/5406849?v=3","gravatar_id":"","url":"https://api.github.com/users/pixijs","html_url":"https://github.com/pixijs","followers_url":"https://api.github.com/users/pixijs/followers","following_url":"https://api.github.com/users/pixijs/following{/other_user}","gists_url":"https://api.github.com/users/pixijs/gists{/gist_id}","starred_url":"https://api.github.com/users/pixijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixijs/subscriptions","organizations_url":"https://api.github.com/users/pixijs/orgs","repos_url":"https://api.github.com/users/pixijs/repos","events_url":"https://api.github.com/users/pixijs/events{/privacy}","received_events_url":"https://api.github.com/users/pixijs/received_events","type":"Organization","site_admin":false},"repo":{"id":7741856,"name":"pixi.js","full_name":"pixijs/pixi.js","owner":{"login":"pixijs","id":5406849,"avatar_url":"https://avatars.githubusercontent.com/u/5406849?v=3","gravatar_id":"","url":"https://api.github.com/users/pixijs","html_url":"https://github.com/pixijs","followers_url":"https://api.github.com/users/pixijs/followers","following_url":"https://api.github.com/users/pixijs/following{/other_user}","gists_url":"https://api.github.com/users/pixijs/gists{/gist_id}","starred_url":"https://api.github.com/users/pixijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixijs/subscriptions","organizations_url":"https://api.github.com/users/pixijs/orgs","repos_url":"https://api.github.com/users/pixijs/repos","events_url":"https://api.github.com/users/pixijs/events{/privacy}","received_events_url":"https://api.github.com/users/pixijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pixijs/pixi.js","description":"Super fast HTML 5 2D rendering engine that uses webGL with canvas fallback","fork":false,"url":"https://api.github.com/repos/pixijs/pixi.js","forks_url":"https://api.github.com/repos/pixijs/pixi.js/forks","keys_url":"https://api.github.com/repos/pixijs/pixi.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixijs/pixi.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixijs/pixi.js/teams","hooks_url":"https://api.github.com/repos/pixijs/pixi.js/hooks","issue_events_url":"https://api.github.com/repos/pixijs/pixi.js/issues/events{/number}","events_url":"https://api.github.com/repos/pixijs/pixi.js/events","assignees_url":"https://api.github.com/repos/pixijs/pixi.js/assignees{/user}","branches_url":"https://api.github.com/repos/pixijs/pixi.js/branches{/branch}","tags_url":"https://api.github.com/repos/pixijs/pixi.js/tags","blobs_url":"https://api.github.com/repos/pixijs/pixi.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixijs/pixi.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixijs/pixi.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixijs/pixi.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixijs/pixi.js/statuses/{sha}","languages_url":"https://api.github.com/repos/pixijs/pixi.js/languages","stargazers_url":"https://api.github.com/repos/pixijs/pixi.js/stargazers","contributors_url":"https://api.github.com/repos/pixijs/pixi.js/contributors","subscribers_url":"https://api.github.com/repos/pixijs/pixi.js/subscribers","subscription_url":"https://api.github.com/repos/pixijs/pixi.js/subscription","commits_url":"https://api.github.com/repos/pixijs/pixi.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixijs/pixi.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixijs/pixi.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixijs/pixi.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixijs/pixi.js/contents/{+path}","compare_url":"https://api.github.com/repos/pixijs/pixi.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixijs/pixi.js/merges","archive_url":"https://api.github.com/repos/pixijs/pixi.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixijs/pixi.js/downloads","issues_url":"https://api.github.com/repos/pixijs/pixi.js/issues{/number}","pulls_url":"https://api.github.com/repos/pixijs/pixi.js/pulls{/number}","milestones_url":"https://api.github.com/repos/pixijs/pixi.js/milestones{/number}","notifications_url":"https://api.github.com/repos/pixijs/pixi.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixijs/pixi.js/labels{/name}","releases_url":"https://api.github.com/repos/pixijs/pixi.js/releases{/id}","deployments_url":"https://api.github.com/repos/pixijs/pixi.js/deployments","created_at":"2013-01-21T22:40:50Z","updated_at":"2016-03-13T22:25:25Z","pushed_at":"2016-03-13T23:00:24Z","git_url":"git://github.com/pixijs/pixi.js.git","ssh_url":"git@github.com:pixijs/pixi.js.git","clone_url":"https://github.com/pixijs/pixi.js.git","svn_url":"https://github.com/pixijs/pixi.js","homepage":null,"size":70023,"stargazers_count":9934,"watchers_count":9934,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1932,"mirror_url":null,"open_issues_count":215,"forks":1932,"open_issues":215,"watchers":9934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixijs/pixi.js/pulls/2394"},"html":{"href":"https://github.com/pixijs/pixi.js/pull/2394"},"issue":{"href":"https://api.github.com/repos/pixijs/pixi.js/issues/2394"},"comments":{"href":"https://api.github.com/repos/pixijs/pixi.js/issues/2394/comments"},"review_comments":{"href":"https://api.github.com/repos/pixijs/pixi.js/pulls/2394/comments"},"review_comment":{"href":"https://api.github.com/repos/pixijs/pixi.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixijs/pixi.js/pulls/2394/commits"},"statuses":{"href":"https://api.github.com/repos/pixijs/pixi.js/statuses/3012d8302e5ea164bacc6fd9e8e614a8e7415b8e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":3,"additions":77,"deletions":42,"changed_files":1}}