{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/82467043","pull_request_review_id":3376061,"id":82467043,"diff_hunk":"@@ -465,97 +522,256 @@ var _ = framework.KubeDescribe(\"PersistentVolumes\", func() {\n \t\t}\n \t})\n \n-\t// Individual tests follow:\n-\t//\n-\t// Create an nfs PV, then a claim that matches the PV, and a pod that\n-\t// contains the claim. Verify that the PV and PVC bind correctly, and\n-\t// that the pod can write to the nfs volume.\n-\tIt(\"should create a non-pre-bound PV and PVC: test write access [Flaky]\", func() {\n-\n-\t\tpv, pvc, err = createPVPVC(c, serverIP, ns, false)\n-\t\tif err != nil {\n-\t\t\tframework.Failf(\"%v\", err)\n-\t\t}\n-\n-\t\t// validate PV-PVC, create and verify writer pod, delete PVC\n-\t\t// and PV\n-\t\tpv, pvc, err = completeTest(f, c, ns, pv, pvc)\n-\t\tif err != nil {\n-\t\t\tframework.Failf(\"%v\", err)\n-\t\t}\n-\t})\n-\n-\t// Create a claim first, then a nfs PV that matches the claim, and a\n-\t// pod that contains the claim. Verify that the PV and PVC bind\n-\t// correctly, and that the pod can write to the nfs volume.\n-\tIt(\"create a PVC and non-pre-bound PV: test write access [Flaky]\", func() {\n+\t///////////////////////////////////////////////////////////////////////\n+\t//\t\t\t\tNFS\n+\t///////////////////////////////////////////////////////////////////////\n+\t// Testing configurations of a single a PV/PVC pair, multiple evenly paired PVs/PVCs,\n+\t// and multiple unevenly paired PV/PVCs\n+\tframework.KubeDescribe(\"PV:NFS\", func() {\n \n-\t\tpv, pvc, err = createPVCPV(c, serverIP, ns, false)\n-\t\tif err != nil {\n-\t\t\tframework.Failf(\"%v\", err)\n+\t\tpvConfig = persistentVolumeConfig {\n+\t\t\tpvsource: api.PersistentVolumeSource{\n+\t\t\t\tNFS: &api.NFSVolumeSource{\n+\t\t\t\t\tServer:   serverIP,\n+\t\t\t\t\tPath:     \"/exports\",\n+\t\t\t\t\tReadOnly: false,\n+\t\t\t\t},\n+\t\t\t},\n \t\t}\n \n-\t\t// validate PV-PVC, create and verify writer pod, delete PVC\n-\t\t// and PV\n-\t\tpv, pvc, err = completeTest(f, c, ns, pv, pvc)\n-\t\tif err != nil {\n-\t\t\tframework.Failf(\"%v\", err)\n-\t\t}\n-\t})\n+\t\tContext(\"with Single PV - PVC pairs\", func() {\n \n-\t// Create a claim first, then a pre-bound nfs PV that matches the claim,\n-\t// and a pod that contains the claim. Verify that the PV and PVC bind\n-\t// correctly, and that the pod can write to the nfs volume.\n-\tIt(\"create a PVC and a pre-bound PV: test write access [Flaky]\", func() {\n+\t\t\tvar pv *api.PersistentVolume\n+\t\t\tvar pvc *api.PersistentVolumeClaim\n \n-\t\tpv, pvc, err = createPVCPV(c, serverIP, ns, true)\n-\t\tif err != nil {\n-\t\t\tframework.Failf(\"%v\", err)\n-\t\t}\n+\t\t\tpvConfig = persistentVolumeConfig{","path":"test/e2e/persistent_volumes.go","position":802,"original_position":802,"commit_id":"af0dcc4d7bb7aa6b8bbe2d3e2d47aa73f56ed524","original_commit_id":"af0dcc4d7bb7aa6b8bbe2d3e2d47aa73f56ed524","user":{"login":"jeffvance","id":3076896,"avatar_url":"https://avatars.githubusercontent.com/u/3076896?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},"body":"Why is pvConfig set here in in KubeDescribe() above? It appears to be the same definition.","created_at":"2016-10-07T20:47:30Z","updated_at":"2016-10-07T20:47:30Z","html_url":"https://github.com/kubernetes/kubernetes/pull/34353#discussion_r82467043","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/82467043"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/34353#discussion_r82467043"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353","id":88497308,"html_url":"https://github.com/kubernetes/kubernetes/pull/34353","diff_url":"https://github.com/kubernetes/kubernetes/pull/34353.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/34353.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34353","number":34353,"state":"open","locked":false,"title":"Gce persistentvolume testing","user":{"login":"copejon","id":6430994,"avatar_url":"https://avatars.githubusercontent.com/u/6430994?v=3","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"body":"Add E2E PersistentVolume test for a GCE environment.  Tests that deleting a PVC before the referencing pod does not fail on unmount and detach during pod deletion.\r\n\r\nDEPENDENT ON #31732 \r\n\r\ncc @jeffvance\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/34353)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-07T19:48:27Z","updated_at":"2016-10-07T20:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbfc88212137bbdc620c11cdc888a030536e0143","assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"assignees":[{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/34353/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/af0dcc4d7bb7aa6b8bbe2d3e2d47aa73f56ed524","head":{"label":"copejon:gce-persistentvolume-testing","ref":"gce-persistentvolume-testing","sha":"af0dcc4d7bb7aa6b8bbe2d3e2d47aa73f56ed524","user":{"login":"copejon","id":6430994,"avatar_url":"https://avatars.githubusercontent.com/u/6430994?v=3","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"repo":{"id":58394557,"name":"kubernetes","full_name":"copejon/kubernetes","owner":{"login":"copejon","id":6430994,"avatar_url":"https://avatars.githubusercontent.com/u/6430994?v=3","gravatar_id":"","url":"https://api.github.com/users/copejon","html_url":"https://github.com/copejon","followers_url":"https://api.github.com/users/copejon/followers","following_url":"https://api.github.com/users/copejon/following{/other_user}","gists_url":"https://api.github.com/users/copejon/gists{/gist_id}","starred_url":"https://api.github.com/users/copejon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/copejon/subscriptions","organizations_url":"https://api.github.com/users/copejon/orgs","repos_url":"https://api.github.com/users/copejon/repos","events_url":"https://api.github.com/users/copejon/events{/privacy}","received_events_url":"https://api.github.com/users/copejon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/copejon/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/copejon/kubernetes","forks_url":"https://api.github.com/repos/copejon/kubernetes/forks","keys_url":"https://api.github.com/repos/copejon/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/copejon/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/copejon/kubernetes/teams","hooks_url":"https://api.github.com/repos/copejon/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/copejon/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/copejon/kubernetes/events","assignees_url":"https://api.github.com/repos/copejon/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/copejon/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/copejon/kubernetes/tags","blobs_url":"https://api.github.com/repos/copejon/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/copejon/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/copejon/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/copejon/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/copejon/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/copejon/kubernetes/languages","stargazers_url":"https://api.github.com/repos/copejon/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/copejon/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/copejon/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/copejon/kubernetes/subscription","commits_url":"https://api.github.com/repos/copejon/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/copejon/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/copejon/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/copejon/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/copejon/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/copejon/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/copejon/kubernetes/merges","archive_url":"https://api.github.com/repos/copejon/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/copejon/kubernetes/downloads","issues_url":"https://api.github.com/repos/copejon/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/copejon/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/copejon/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/copejon/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/copejon/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/copejon/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/copejon/kubernetes/deployments","created_at":"2016-05-09T17:18:41Z","updated_at":"2016-05-12T17:47:50Z","pushed_at":"2016-10-07T19:55:02Z","git_url":"git://github.com/copejon/kubernetes.git","ssh_url":"git@github.com:copejon/kubernetes.git","clone_url":"https://github.com/copejon/kubernetes.git","svn_url":"https://github.com/copejon/kubernetes","homepage":"http://kubernetes.io","size":329756,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c23346f3915d0a58cc68cbe6241f4e375278f445","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-07T20:04:25Z","pushed_at":"2016-10-07T20:46:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":580111,"stargazers_count":17375,"watchers_count":17375,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5634,"mirror_url":null,"open_issues_count":4873,"forks":5634,"open_issues":4873,"watchers":17375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/34353"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/34353"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/34353/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/34353/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/af0dcc4d7bb7aa6b8bbe2d3e2d47aa73f56ed524"}}}}
{"actor":{"display_login":"jeffvance"}}