{"action":"created","issue":{"url":"https://api.github.com/repos/milligram/milligram/issues/131","repository_url":"https://api.github.com/repos/milligram/milligram","labels_url":"https://api.github.com/repos/milligram/milligram/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/milligram/milligram/issues/131/comments","events_url":"https://api.github.com/repos/milligram/milligram/issues/131/events","html_url":"https://github.com/milligram/milligram/issues/131","id":192091199,"number":131,"title":"<strong> isn't bold","user":{"login":"garretwilson","id":627125,"avatar_url":"https://avatars.githubusercontent.com/u/627125?v=3","gravatar_id":"","url":"https://api.github.com/users/garretwilson","html_url":"https://github.com/garretwilson","followers_url":"https://api.github.com/users/garretwilson/followers","following_url":"https://api.github.com/users/garretwilson/following{/other_user}","gists_url":"https://api.github.com/users/garretwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/garretwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garretwilson/subscriptions","organizations_url":"https://api.github.com/users/garretwilson/orgs","repos_url":"https://api.github.com/users/garretwilson/repos","events_url":"https://api.github.com/users/garretwilson/events{/privacy}","received_events_url":"https://api.github.com/users/garretwilson/received_events","type":"User","site_admin":false},"labels":[{"id":308480753,"url":"https://api.github.com/repos/milligram/milligram/labels/awaiting%20reply","name":"awaiting reply","color":"5319e7","default":false},{"id":298019477,"url":"https://api.github.com/repos/milligram/milligram/labels/help%20wanted","name":"help wanted","color":"bfe5bf","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-11-28T19:08:48Z","updated_at":"2016-12-14T20:33:39Z","closed_at":null,"body":"Wow, I just realized that `<strong>` doesn't get bold by default. In fact it doesn't seem to have any style.\r\n\r\nI'm about to give up on Milligram for a \"reasonable defaults out of the box\" CSS library. I welcome recommendations for something else.\r\n\r\nTake for example the following HTML5 file:\r\n\r\n```html\r\n<!DOCTYPE html>\r\n<html lang=\"en-US\">\r\n\r\n<head>\r\n\t<title>Milligram Strong Bug</title>\r\n\t<link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Roboto:300,300italic,700,700italic\">\r\n\t<link rel=\"stylesheet\" href=\"css/normalize.css\">\r\n\t<link rel=\"stylesheet\" href=\"css/milligram.min.css\">\r\n</head>\r\n\r\n<body>\r\n\t<p>This paragraph should have <strong>strong</strong> text.</p>\r\n\t<p>This paragraph should have <b>bold</b> text.</p>\r\n</body>\r\n\r\n</html>\r\n```\r\n\r\nObviously, substitute your own paths for your local Normalize and Milligram copies. (I didn't see any CDN URLs for Milligram or I would have used them in this example.)\r\n\r\nNow open it up in Chrome or Firefox (the two browsers I tested this in). You'll see that there is no bold text. There should be.\r\n\r\nThe cause? This gets interesting. It looks like `normalize.css` is setting the `font-weight` to `bolder`. But it doesn't show up. Changing this to `bold` makes the bold show up.\r\n\r\nThe problem seems to be that the Roboto font doesn't support varying degrees of bold.\r\n\r\n(At first I said to see http://stackoverflow.com/q/39405766/421049 , but that reference looks unrelated --- although that is a different different issue that presents a problem.)\r\n\r\n`normalize.css` is technically correct in that semantically the value `bolder` is better in this case. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=12154\r\n\r\nHowever because Milligram _knows_ that it is using a font that doesn't support varying degrees of bolder, I think that you must override `normalize.css` and use `bold` unless you have a better idea. Otherwise if the font does not show up in bold this is a Milligram --- even if you claim that it's Roboto's fault (and it may be).\r\n\r\nThat's my opinion at the moment until presented with a better explanation. 😄 "},"comment":{"url":"https://api.github.com/repos/milligram/milligram/issues/comments/267148383","html_url":"https://github.com/milligram/milligram/issues/131#issuecomment-267148383","issue_url":"https://api.github.com/repos/milligram/milligram/issues/131","id":267148383,"user":{"login":"chmln","id":11352152,"avatar_url":"https://avatars.githubusercontent.com/u/11352152?v=3","gravatar_id":"","url":"https://api.github.com/users/chmln","html_url":"https://github.com/chmln","followers_url":"https://api.github.com/users/chmln/followers","following_url":"https://api.github.com/users/chmln/following{/other_user}","gists_url":"https://api.github.com/users/chmln/gists{/gist_id}","starred_url":"https://api.github.com/users/chmln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chmln/subscriptions","organizations_url":"https://api.github.com/users/chmln/orgs","repos_url":"https://api.github.com/users/chmln/repos","events_url":"https://api.github.com/users/chmln/events{/privacy}","received_events_url":"https://api.github.com/users/chmln/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T20:33:39Z","updated_at":"2016-12-14T20:33:39Z","body":"> I don't know what \"perf\"\r\n\r\nPerformance.\r\n\r\n@cjpatoilo I think the 'right' solution would be to have `body` with `font-weight: 400`, i.e. not overriding the default `font-weight`.\r\n\r\nThat will:\r\n1. Make `bolder`, `lighter` font properties function correctly\r\n2. Provide better typography. Light fonts are an eye strain, and lack readability. (see comparison below)\r\n\r\n![light](https://cloud.githubusercontent.com/assets/11352152/21199678/82034b36-c212-11e6-8c3b-d9f84ce6e933.png)\r\n![regular](https://cloud.githubusercontent.com/assets/11352152/21199680/841bb23c-c212-11e6-9d6c-a24165eb83bb.png)\r\n"}}
{"actor":{"display_login":"chmln"}}