{"action":"created","comment":{"url":"https://api.github.com/repos/servo/rust-mozjs/pulls/comments/68907058","id":68907058,"diff_hunk":"@@ -270,41 +268,103 @@ impl RootKind for Value {\n     fn rootKind() -> jsapi::RootKind { jsapi::RootKind::Value }\n }\n \n-impl<T: RootKind + Copy> Rooted<T> {\n-    pub fn new_with_addr(cx: *mut JSContext, initial: T, addr: *const u8) -> Rooted<T> {\n-        let ctxfriend: &mut ContextFriendFields = unsafe {\n-            mem::transmute(cx)\n-        };\n-\n-        let kind = T::rootKind() as usize;\n-        let root = Rooted::<T> {\n+impl<T> Rooted<T> {\n+    pub fn new_unrooted(initial: T) -> Rooted<T> {","path":"src/rust.rs","position":38,"original_position":38,"commit_id":"71333b8f824bd8adb6198c070ec033722106dc92","original_commit_id":"71333b8f824bd8adb6198c070ec033722106dc92","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"I suppose so? But what do you put there in `Rooted::new_unrooted`?","created_at":"2016-06-29T08:46:24Z","updated_at":"2016-06-29T08:46:24Z","html_url":"https://github.com/servo/rust-mozjs/pull/272#discussion_r68907058","pull_request_url":"https://api.github.com/repos/servo/rust-mozjs/pulls/272","_links":{"self":{"href":"https://api.github.com/repos/servo/rust-mozjs/pulls/comments/68907058"},"html":{"href":"https://github.com/servo/rust-mozjs/pull/272#discussion_r68907058"},"pull_request":{"href":"https://api.github.com/repos/servo/rust-mozjs/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/servo/rust-mozjs/pulls/272","id":75231442,"html_url":"https://github.com/servo/rust-mozjs/pull/272","diff_url":"https://github.com/servo/rust-mozjs/pull/272.diff","patch_url":"https://github.com/servo/rust-mozjs/pull/272.patch","issue_url":"https://api.github.com/repos/servo/rust-mozjs/issues/272","number":272,"state":"closed","locked":false,"title":"Replace return_address usage in Rooted with a stack guard and a rooted! macro.","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Part of a potential solution for rust-lang/rust#34227.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/rust-mozjs/272)\n<!-- Reviewable:end -->\n","created_at":"2016-06-26T14:43:19Z","updated_at":"2016-06-29T08:46:24Z","closed_at":"2016-06-27T18:06:39Z","merged_at":"2016-06-27T18:06:39Z","merge_commit_sha":"71333b8f824bd8adb6198c070ec033722106dc92","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/rust-mozjs/pulls/272/commits","review_comments_url":"https://api.github.com/repos/servo/rust-mozjs/pulls/272/comments","review_comment_url":"https://api.github.com/repos/servo/rust-mozjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/rust-mozjs/issues/272/comments","statuses_url":"https://api.github.com/repos/servo/rust-mozjs/statuses/71333b8f824bd8adb6198c070ec033722106dc92","head":{"label":"eddyb:back-to-roots","ref":"back-to-roots","sha":"71333b8f824bd8adb6198c070ec033722106dc92","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"repo":{"id":61993276,"name":"rust-mozjs","full_name":"eddyb/rust-mozjs","owner":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddyb/rust-mozjs","description":"Rust bindings to SpiderMonkey","fork":true,"url":"https://api.github.com/repos/eddyb/rust-mozjs","forks_url":"https://api.github.com/repos/eddyb/rust-mozjs/forks","keys_url":"https://api.github.com/repos/eddyb/rust-mozjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddyb/rust-mozjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddyb/rust-mozjs/teams","hooks_url":"https://api.github.com/repos/eddyb/rust-mozjs/hooks","issue_events_url":"https://api.github.com/repos/eddyb/rust-mozjs/issues/events{/number}","events_url":"https://api.github.com/repos/eddyb/rust-mozjs/events","assignees_url":"https://api.github.com/repos/eddyb/rust-mozjs/assignees{/user}","branches_url":"https://api.github.com/repos/eddyb/rust-mozjs/branches{/branch}","tags_url":"https://api.github.com/repos/eddyb/rust-mozjs/tags","blobs_url":"https://api.github.com/repos/eddyb/rust-mozjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddyb/rust-mozjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddyb/rust-mozjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddyb/rust-mozjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddyb/rust-mozjs/statuses/{sha}","languages_url":"https://api.github.com/repos/eddyb/rust-mozjs/languages","stargazers_url":"https://api.github.com/repos/eddyb/rust-mozjs/stargazers","contributors_url":"https://api.github.com/repos/eddyb/rust-mozjs/contributors","subscribers_url":"https://api.github.com/repos/eddyb/rust-mozjs/subscribers","subscription_url":"https://api.github.com/repos/eddyb/rust-mozjs/subscription","commits_url":"https://api.github.com/repos/eddyb/rust-mozjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddyb/rust-mozjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddyb/rust-mozjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddyb/rust-mozjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/eddyb/rust-mozjs/contents/{+path}","compare_url":"https://api.github.com/repos/eddyb/rust-mozjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddyb/rust-mozjs/merges","archive_url":"https://api.github.com/repos/eddyb/rust-mozjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddyb/rust-mozjs/downloads","issues_url":"https://api.github.com/repos/eddyb/rust-mozjs/issues{/number}","pulls_url":"https://api.github.com/repos/eddyb/rust-mozjs/pulls{/number}","milestones_url":"https://api.github.com/repos/eddyb/rust-mozjs/milestones{/number}","notifications_url":"https://api.github.com/repos/eddyb/rust-mozjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddyb/rust-mozjs/labels{/name}","releases_url":"https://api.github.com/repos/eddyb/rust-mozjs/releases{/id}","deployments_url":"https://api.github.com/repos/eddyb/rust-mozjs/deployments","created_at":"2016-06-26T14:41:22Z","updated_at":"2016-06-26T14:41:23Z","pushed_at":"2016-06-27T18:24:13Z","git_url":"git://github.com/eddyb/rust-mozjs.git","ssh_url":"git@github.com:eddyb/rust-mozjs.git","clone_url":"https://github.com/eddyb/rust-mozjs.git","svn_url":"https://github.com/eddyb/rust-mozjs","homepage":"","size":1181,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"707bfb4ff4fe2c0abde1cc2bb87ac35ff8f40aaa","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3861673,"name":"rust-mozjs","full_name":"servo/rust-mozjs","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/rust-mozjs","description":"Rust bindings to SpiderMonkey","fork":false,"url":"https://api.github.com/repos/servo/rust-mozjs","forks_url":"https://api.github.com/repos/servo/rust-mozjs/forks","keys_url":"https://api.github.com/repos/servo/rust-mozjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/rust-mozjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/rust-mozjs/teams","hooks_url":"https://api.github.com/repos/servo/rust-mozjs/hooks","issue_events_url":"https://api.github.com/repos/servo/rust-mozjs/issues/events{/number}","events_url":"https://api.github.com/repos/servo/rust-mozjs/events","assignees_url":"https://api.github.com/repos/servo/rust-mozjs/assignees{/user}","branches_url":"https://api.github.com/repos/servo/rust-mozjs/branches{/branch}","tags_url":"https://api.github.com/repos/servo/rust-mozjs/tags","blobs_url":"https://api.github.com/repos/servo/rust-mozjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/rust-mozjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/rust-mozjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/rust-mozjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/rust-mozjs/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/rust-mozjs/languages","stargazers_url":"https://api.github.com/repos/servo/rust-mozjs/stargazers","contributors_url":"https://api.github.com/repos/servo/rust-mozjs/contributors","subscribers_url":"https://api.github.com/repos/servo/rust-mozjs/subscribers","subscription_url":"https://api.github.com/repos/servo/rust-mozjs/subscription","commits_url":"https://api.github.com/repos/servo/rust-mozjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/rust-mozjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/rust-mozjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/rust-mozjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/rust-mozjs/contents/{+path}","compare_url":"https://api.github.com/repos/servo/rust-mozjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/rust-mozjs/merges","archive_url":"https://api.github.com/repos/servo/rust-mozjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/rust-mozjs/downloads","issues_url":"https://api.github.com/repos/servo/rust-mozjs/issues{/number}","pulls_url":"https://api.github.com/repos/servo/rust-mozjs/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/rust-mozjs/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/rust-mozjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/rust-mozjs/labels{/name}","releases_url":"https://api.github.com/repos/servo/rust-mozjs/releases{/id}","deployments_url":"https://api.github.com/repos/servo/rust-mozjs/deployments","created_at":"2012-03-29T02:07:23Z","updated_at":"2016-06-08T15:13:07Z","pushed_at":"2016-06-28T09:11:18Z","git_url":"git://github.com/servo/rust-mozjs.git","ssh_url":"git@github.com:servo/rust-mozjs.git","clone_url":"https://github.com/servo/rust-mozjs.git","svn_url":"https://github.com/servo/rust-mozjs","homepage":"","size":1704,"stargazers_count":66,"watchers_count":66,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":30,"forks":60,"open_issues":30,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/rust-mozjs/pulls/272"},"html":{"href":"https://github.com/servo/rust-mozjs/pull/272"},"issue":{"href":"https://api.github.com/repos/servo/rust-mozjs/issues/272"},"comments":{"href":"https://api.github.com/repos/servo/rust-mozjs/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/rust-mozjs/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/rust-mozjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/rust-mozjs/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/servo/rust-mozjs/statuses/71333b8f824bd8adb6198c070ec033722106dc92"}}}}
{"actor":{"display_login":"eddyb"}}