{"action":"created","issue":{"url":"https://api.github.com/repos/Notalib/LYT/issues/694","repository_url":"https://api.github.com/repos/Notalib/LYT","labels_url":"https://api.github.com/repos/Notalib/LYT/issues/694/labels{/name}","comments_url":"https://api.github.com/repos/Notalib/LYT/issues/694/comments","events_url":"https://api.github.com/repos/Notalib/LYT/issues/694/events","html_url":"https://github.com/Notalib/LYT/pull/694","id":135076928,"number":694,"title":"Fix highlighting of MTM books","user":{"login":"saebekassebil","id":118532,"avatar_url":"https://avatars.githubusercontent.com/u/118532?v=3","gravatar_id":"","url":"https://api.github.com/users/saebekassebil","html_url":"https://github.com/saebekassebil","followers_url":"https://api.github.com/users/saebekassebil/followers","following_url":"https://api.github.com/users/saebekassebil/following{/other_user}","gists_url":"https://api.github.com/users/saebekassebil/gists{/gist_id}","starred_url":"https://api.github.com/users/saebekassebil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saebekassebil/subscriptions","organizations_url":"https://api.github.com/users/saebekassebil/orgs","repos_url":"https://api.github.com/users/saebekassebil/repos","events_url":"https://api.github.com/users/saebekassebil/events{/privacy}","received_events_url":"https://api.github.com/users/saebekassebil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-20T13:57:29Z","updated_at":"2016-02-24T09:56:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Notalib/LYT/pulls/694","html_url":"https://github.com/Notalib/LYT/pull/694","diff_url":"https://github.com/Notalib/LYT/pull/694.diff","patch_url":"https://github.com/Notalib/LYT/pull/694.patch"},"body":"Fixes [NOTA-2285](https://notalib.atlassian.net/browse/NOTA-2285)\r\n\r\nSome MTM books have content in the following format:\r\n`<p> -> <span> -> <a> -> Text`\r\nfor each paragraph. We use:\r\n`<p> -> <a> -> Text`\r\n\r\nProblem is, that our books don't use the span element inside, and so we don't highlight their books properly. This fixes it, by assuming **all** books have a containing `<p>` element for each paragraph, and then highlighting the containing `<p>` element, even if that is not the element being referenced from the `SMIL` file.. I think all our books have that (at least our stylesheet assume it), but we should probably test this on a few books before pulling.\r\n\r\nThe problem with the current solution is, that we only assume that `<p>` elements get referenced from the `SMIL` files. That is not true. In the case of MTM's books, sometimes it's the contained `<span>` tag that gets referenced. Because we're using `opacity` to highlight different tags, we have all `<p>` tags set to `opacity: 0.4` by default, and when they're `.active` they get a `opacity: 1`.\r\n\r\n@m-abs or @dfg-nota could you take a look at this and see if I'm missing something totally?"},"comment":{"url":"https://api.github.com/repos/Notalib/LYT/issues/comments/188171289","html_url":"https://github.com/Notalib/LYT/pull/694#issuecomment-188171289","issue_url":"https://api.github.com/repos/Notalib/LYT/issues/694","id":188171289,"user":{"login":"saebekassebil","id":118532,"avatar_url":"https://avatars.githubusercontent.com/u/118532?v=3","gravatar_id":"","url":"https://api.github.com/users/saebekassebil","html_url":"https://github.com/saebekassebil","followers_url":"https://api.github.com/users/saebekassebil/followers","following_url":"https://api.github.com/users/saebekassebil/following{/other_user}","gists_url":"https://api.github.com/users/saebekassebil/gists{/gist_id}","starred_url":"https://api.github.com/users/saebekassebil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saebekassebil/subscriptions","organizations_url":"https://api.github.com/users/saebekassebil/orgs","repos_url":"https://api.github.com/users/saebekassebil/repos","events_url":"https://api.github.com/users/saebekassebil/events{/privacy}","received_events_url":"https://api.github.com/users/saebekassebil/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T09:56:15Z","updated_at":"2016-02-24T09:56:15Z","body":"Hej @m-abs. Hvad siger du til det her? Det vil fixe sætnings-opmærkning for MTM og vil (så vidt jeg kan teste mig til) ikke påvirke vores opmærkning. Egentlig minder de her regler meget om den fra ord-opmærkning."}}