{"comment":{"url":"https://api.github.com/repos/SlateFoundation/slate-cbl/comments/20122267","html_url":"https://github.com/SlateFoundation/slate-cbl/commit/63280859e3b2a29e3ca8ccbca9058fa01c07d7cd#commitcomment-20122267","id":20122267,"user":{"login":"themightychris","id":458494,"avatar_url":"https://avatars.githubusercontent.com/u/458494?v=3","gravatar_id":"","url":"https://api.github.com/users/themightychris","html_url":"https://github.com/themightychris","followers_url":"https://api.github.com/users/themightychris/followers","following_url":"https://api.github.com/users/themightychris/following{/other_user}","gists_url":"https://api.github.com/users/themightychris/gists{/gist_id}","starred_url":"https://api.github.com/users/themightychris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themightychris/subscriptions","organizations_url":"https://api.github.com/users/themightychris/orgs","repos_url":"https://api.github.com/users/themightychris/repos","events_url":"https://api.github.com/users/themightychris/events{/privacy}","received_events_url":"https://api.github.com/users/themightychris/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"63280859e3b2a29e3ca8ccbca9058fa01c07d7cd","created_at":"2016-12-08T17:01:29Z","updated_at":"2016-12-08T17:01:29Z","body":"@nbey looks OK to me overall. All those strings building the SQL query should be single-quoted though.\r\n\r\nAlso, rather than passing in `$demonstrationConditions` as a string, I'd suggest accepting the parameter as `array $demonstrationConditions = []` and then plugging it into the query with: `count($demonstrationConditions) ? ' AND (' . implode(') AND (', Demonstrations\\Demonstration::mapConditions($demonstrationConditions) . ')' : ''`\r\n\r\nThis lets you follow common conventions for conditions like passing in `['Field' => 'value', 'ARBITRARY_EXPRESSION']` "}}
{"actor":{"display_login":"themightychris"}}