{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/dns-java/pulls/comments/74029686","id":74029686,"diff_hunk":"@@ -30,6 +30,7 @@\n   private final List<ChangeNotifier<T>> changeNotifiers;\n \n   private volatile Set<T> records = ImmutableSet.of();\n+  private volatile boolean waitingForFirstEvent = true;","path":"src/main/java/com/spotify/dns/AggregatingChangeNotifier.java","position":4,"original_position":4,"commit_id":"8f8662fb076457674722eccc74d1c51f9d93e82c","original_commit_id":"a6d51cfed817d3e5f5d5de33b7aaf4a18a51e5d2","user":{"login":"spkrka","id":5349266,"avatar_url":"https://avatars.githubusercontent.com/u/5349266?v=3","gravatar_id":"","url":"https://api.github.com/users/spkrka","html_url":"https://github.com/spkrka","followers_url":"https://api.github.com/users/spkrka/followers","following_url":"https://api.github.com/users/spkrka/following{/other_user}","gists_url":"https://api.github.com/users/spkrka/gists{/gist_id}","starred_url":"https://api.github.com/users/spkrka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spkrka/subscriptions","organizations_url":"https://api.github.com/users/spkrka/orgs","repos_url":"https://api.github.com/users/spkrka/repos","events_url":"https://api.github.com/users/spkrka/events{/privacy}","received_events_url":"https://api.github.com/users/spkrka/received_events","type":"User","site_admin":false},"body":"No specific `Atomic` operations are needed. I guess it could use some `compareAndSet` instead actually, is that what you meant?","created_at":"2016-08-09T09:54:01Z","updated_at":"2016-08-09T09:54:01Z","html_url":"https://github.com/spotify/dns-java/pull/25#discussion_r74029686","pull_request_url":"https://api.github.com/repos/spotify/dns-java/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/spotify/dns-java/pulls/comments/74029686"},"html":{"href":"https://github.com/spotify/dns-java/pull/25#discussion_r74029686"},"pull_request":{"href":"https://api.github.com/repos/spotify/dns-java/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/dns-java/pulls/25","id":80587923,"html_url":"https://github.com/spotify/dns-java/pull/25","diff_url":"https://github.com/spotify/dns-java/pull/25.diff","patch_url":"https://github.com/spotify/dns-java/pull/25.patch","issue_url":"https://api.github.com/repos/spotify/dns-java/issues/25","number":25,"state":"open","locked":false,"title":"Fix change notification for empty DNS result.","user":{"login":"spkrka","id":5349266,"avatar_url":"https://avatars.githubusercontent.com/u/5349266?v=3","gravatar_id":"","url":"https://api.github.com/users/spkrka","html_url":"https://github.com/spkrka","followers_url":"https://api.github.com/users/spkrka/followers","following_url":"https://api.github.com/users/spkrka/following{/other_user}","gists_url":"https://api.github.com/users/spkrka/gists{/gist_id}","starred_url":"https://api.github.com/users/spkrka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spkrka/subscriptions","organizations_url":"https://api.github.com/users/spkrka/orgs","repos_url":"https://api.github.com/users/spkrka/repos","events_url":"https://api.github.com/users/spkrka/events{/privacy}","received_events_url":"https://api.github.com/users/spkrka/received_events","type":"User","site_admin":false},"body":"Make sure an initial DNS change event is fired even if the result set\nis empty. This is useful for differentiating \"no result yet\" from\n\"empty result\".","created_at":"2016-08-09T09:25:27Z","updated_at":"2016-08-09T09:54:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a410cceb38c90b03070730e4966ab8df2740af8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/dns-java/pulls/25/commits","review_comments_url":"https://api.github.com/repos/spotify/dns-java/pulls/25/comments","review_comment_url":"https://api.github.com/repos/spotify/dns-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/dns-java/issues/25/comments","statuses_url":"https://api.github.com/repos/spotify/dns-java/statuses/8f8662fb076457674722eccc74d1c51f9d93e82c","head":{"label":"spkrka:krka/notifier","ref":"krka/notifier","sha":"8f8662fb076457674722eccc74d1c51f9d93e82c","user":{"login":"spkrka","id":5349266,"avatar_url":"https://avatars.githubusercontent.com/u/5349266?v=3","gravatar_id":"","url":"https://api.github.com/users/spkrka","html_url":"https://github.com/spkrka","followers_url":"https://api.github.com/users/spkrka/followers","following_url":"https://api.github.com/users/spkrka/following{/other_user}","gists_url":"https://api.github.com/users/spkrka/gists{/gist_id}","starred_url":"https://api.github.com/users/spkrka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spkrka/subscriptions","organizations_url":"https://api.github.com/users/spkrka/orgs","repos_url":"https://api.github.com/users/spkrka/repos","events_url":"https://api.github.com/users/spkrka/events{/privacy}","received_events_url":"https://api.github.com/users/spkrka/received_events","type":"User","site_admin":false},"repo":{"id":65281743,"name":"dns-java","full_name":"spkrka/dns-java","owner":{"login":"spkrka","id":5349266,"avatar_url":"https://avatars.githubusercontent.com/u/5349266?v=3","gravatar_id":"","url":"https://api.github.com/users/spkrka","html_url":"https://github.com/spkrka","followers_url":"https://api.github.com/users/spkrka/followers","following_url":"https://api.github.com/users/spkrka/following{/other_user}","gists_url":"https://api.github.com/users/spkrka/gists{/gist_id}","starred_url":"https://api.github.com/users/spkrka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spkrka/subscriptions","organizations_url":"https://api.github.com/users/spkrka/orgs","repos_url":"https://api.github.com/users/spkrka/repos","events_url":"https://api.github.com/users/spkrka/events{/privacy}","received_events_url":"https://api.github.com/users/spkrka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spkrka/dns-java","description":"DNS wrapper library that provides SRV lookup functionality","fork":true,"url":"https://api.github.com/repos/spkrka/dns-java","forks_url":"https://api.github.com/repos/spkrka/dns-java/forks","keys_url":"https://api.github.com/repos/spkrka/dns-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spkrka/dns-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spkrka/dns-java/teams","hooks_url":"https://api.github.com/repos/spkrka/dns-java/hooks","issue_events_url":"https://api.github.com/repos/spkrka/dns-java/issues/events{/number}","events_url":"https://api.github.com/repos/spkrka/dns-java/events","assignees_url":"https://api.github.com/repos/spkrka/dns-java/assignees{/user}","branches_url":"https://api.github.com/repos/spkrka/dns-java/branches{/branch}","tags_url":"https://api.github.com/repos/spkrka/dns-java/tags","blobs_url":"https://api.github.com/repos/spkrka/dns-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spkrka/dns-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spkrka/dns-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/spkrka/dns-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spkrka/dns-java/statuses/{sha}","languages_url":"https://api.github.com/repos/spkrka/dns-java/languages","stargazers_url":"https://api.github.com/repos/spkrka/dns-java/stargazers","contributors_url":"https://api.github.com/repos/spkrka/dns-java/contributors","subscribers_url":"https://api.github.com/repos/spkrka/dns-java/subscribers","subscription_url":"https://api.github.com/repos/spkrka/dns-java/subscription","commits_url":"https://api.github.com/repos/spkrka/dns-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/spkrka/dns-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/spkrka/dns-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/spkrka/dns-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/spkrka/dns-java/contents/{+path}","compare_url":"https://api.github.com/repos/spkrka/dns-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spkrka/dns-java/merges","archive_url":"https://api.github.com/repos/spkrka/dns-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spkrka/dns-java/downloads","issues_url":"https://api.github.com/repos/spkrka/dns-java/issues{/number}","pulls_url":"https://api.github.com/repos/spkrka/dns-java/pulls{/number}","milestones_url":"https://api.github.com/repos/spkrka/dns-java/milestones{/number}","notifications_url":"https://api.github.com/repos/spkrka/dns-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spkrka/dns-java/labels{/name}","releases_url":"https://api.github.com/repos/spkrka/dns-java/releases{/id}","deployments_url":"https://api.github.com/repos/spkrka/dns-java/deployments","created_at":"2016-08-09T09:23:50Z","updated_at":"2016-08-09T09:23:52Z","pushed_at":"2016-08-09T09:39:02Z","git_url":"git://github.com/spkrka/dns-java.git","ssh_url":"git@github.com:spkrka/dns-java.git","clone_url":"https://github.com/spkrka/dns-java.git","svn_url":"https://github.com/spkrka/dns-java","homepage":null,"size":142,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"c8bfd1fbc41800d79beabfff934869487b14583c","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":17630966,"name":"dns-java","full_name":"spotify/dns-java","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/dns-java","description":"DNS wrapper library that provides SRV lookup functionality","fork":false,"url":"https://api.github.com/repos/spotify/dns-java","forks_url":"https://api.github.com/repos/spotify/dns-java/forks","keys_url":"https://api.github.com/repos/spotify/dns-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/dns-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/dns-java/teams","hooks_url":"https://api.github.com/repos/spotify/dns-java/hooks","issue_events_url":"https://api.github.com/repos/spotify/dns-java/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/dns-java/events","assignees_url":"https://api.github.com/repos/spotify/dns-java/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/dns-java/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/dns-java/tags","blobs_url":"https://api.github.com/repos/spotify/dns-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/dns-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/dns-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/dns-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/dns-java/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/dns-java/languages","stargazers_url":"https://api.github.com/repos/spotify/dns-java/stargazers","contributors_url":"https://api.github.com/repos/spotify/dns-java/contributors","subscribers_url":"https://api.github.com/repos/spotify/dns-java/subscribers","subscription_url":"https://api.github.com/repos/spotify/dns-java/subscription","commits_url":"https://api.github.com/repos/spotify/dns-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/dns-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/dns-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/dns-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/dns-java/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/dns-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/dns-java/merges","archive_url":"https://api.github.com/repos/spotify/dns-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/dns-java/downloads","issues_url":"https://api.github.com/repos/spotify/dns-java/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/dns-java/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/dns-java/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/dns-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/dns-java/labels{/name}","releases_url":"https://api.github.com/repos/spotify/dns-java/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/dns-java/deployments","created_at":"2014-03-11T13:16:54Z","updated_at":"2016-08-02T09:30:16Z","pushed_at":"2016-08-09T09:39:03Z","git_url":"git://github.com/spotify/dns-java.git","ssh_url":"git@github.com:spotify/dns-java.git","clone_url":"https://github.com/spotify/dns-java.git","svn_url":"https://github.com/spotify/dns-java","homepage":null,"size":142,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":3,"forks":18,"open_issues":3,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/dns-java/pulls/25"},"html":{"href":"https://github.com/spotify/dns-java/pull/25"},"issue":{"href":"https://api.github.com/repos/spotify/dns-java/issues/25"},"comments":{"href":"https://api.github.com/repos/spotify/dns-java/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/dns-java/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/dns-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/dns-java/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/dns-java/statuses/8f8662fb076457674722eccc74d1c51f9d93e82c"}}}}
{"actor":{"display_login":"spkrka"}}