{"action":"created","comment":{"url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/comments/65878023","id":65878023,"diff_hunk":"@@ -400,7 +404,7 @@ module jsonpatch {\n     for (var t = oldKeys.length - 1; t >= 0; t--) {\n       var key = oldKeys[t];\n       var oldVal = mirror[key];\n-      if (obj.hasOwnProperty(key)) {\n+      if (obj.hasOwnProperty(key) && !(_isArray(obj) === false && obj[key] === undefined)) {","path":"src/json-patch-duplex.ts","position":26,"original_position":26,"commit_id":"17832631912d0c3afad21633a75323448a50381c","original_commit_id":"17832631912d0c3afad21633a75323448a50381c","user":{"login":"warpech","id":566463,"avatar_url":"https://avatars.githubusercontent.com/u/566463?v=3","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"body":"I haven't because I have nothing to compare it to. We have current behaviour that is wrong but fast, and new behaviour which is good but slower.\r\n\r\nOne thing for sure, the condition should be reverted to: `(obj[key] === undefined && _isArray(obj) === false)`","created_at":"2016-06-06T11:58:17Z","updated_at":"2016-06-06T11:58:17Z","html_url":"https://github.com/Starcounter-Jack/JSON-Patch/pull/107#discussion_r65878023","pull_request_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/comments/65878023"},"html":{"href":"https://github.com/Starcounter-Jack/JSON-Patch/pull/107#discussion_r65878023"},"pull_request":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107","id":72519313,"html_url":"https://github.com/Starcounter-Jack/JSON-Patch/pull/107","diff_url":"https://github.com/Starcounter-Jack/JSON-Patch/pull/107.diff","patch_url":"https://github.com/Starcounter-Jack/JSON-Patch/pull/107.patch","issue_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/107","number":107,"state":"open","locked":false,"title":"Change the behavior in case of `undefined` value","user":{"login":"warpech","id":566463,"avatar_url":"https://avatars.githubusercontent.com/u/566463?v=3","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"body":"This is a fix for issues #105, #90, #60, #32 and a part of #76 that describes a problem with undefined\r\n\r\nall tests pass after this commit","created_at":"2016-06-03T14:49:40Z","updated_at":"2016-06-06T11:58:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4763a3a536ba3604d4f5035215cadeb99845a602","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107/commits","review_comments_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107/comments","review_comment_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/107/comments","statuses_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/statuses/17832631912d0c3afad21633a75323448a50381c","head":{"label":"Starcounter-Jack:feature/reimplement-undefined-105","ref":"feature/reimplement-undefined-105","sha":"17832631912d0c3afad21633a75323448a50381c","user":{"login":"Starcounter-Jack","id":1219049,"avatar_url":"https://avatars.githubusercontent.com/u/1219049?v=3","gravatar_id":"","url":"https://api.github.com/users/Starcounter-Jack","html_url":"https://github.com/Starcounter-Jack","followers_url":"https://api.github.com/users/Starcounter-Jack/followers","following_url":"https://api.github.com/users/Starcounter-Jack/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter-Jack/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter-Jack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter-Jack/subscriptions","organizations_url":"https://api.github.com/users/Starcounter-Jack/orgs","repos_url":"https://api.github.com/users/Starcounter-Jack/repos","events_url":"https://api.github.com/users/Starcounter-Jack/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter-Jack/received_events","type":"User","site_admin":false},"repo":{"id":8818872,"name":"JSON-Patch","full_name":"Starcounter-Jack/JSON-Patch","owner":{"login":"Starcounter-Jack","id":1219049,"avatar_url":"https://avatars.githubusercontent.com/u/1219049?v=3","gravatar_id":"","url":"https://api.github.com/users/Starcounter-Jack","html_url":"https://github.com/Starcounter-Jack","followers_url":"https://api.github.com/users/Starcounter-Jack/followers","following_url":"https://api.github.com/users/Starcounter-Jack/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter-Jack/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter-Jack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter-Jack/subscriptions","organizations_url":"https://api.github.com/users/Starcounter-Jack/orgs","repos_url":"https://api.github.com/users/Starcounter-Jack/repos","events_url":"https://api.github.com/users/Starcounter-Jack/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter-Jack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter-Jack/JSON-Patch","description":"Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.","fork":false,"url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch","forks_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/forks","keys_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/teams","hooks_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/hooks","issue_events_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/events","assignees_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/tags","blobs_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/languages","stargazers_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/stargazers","contributors_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/contributors","subscribers_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/subscribers","subscription_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/subscription","commits_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/merges","archive_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/downloads","issues_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/deployments","created_at":"2013-03-16T13:08:46Z","updated_at":"2016-06-02T10:23:16Z","pushed_at":"2016-06-03T14:49:41Z","git_url":"git://github.com/Starcounter-Jack/JSON-Patch.git","ssh_url":"git@github.com:Starcounter-Jack/JSON-Patch.git","clone_url":"https://github.com/Starcounter-Jack/JSON-Patch.git","svn_url":"https://github.com/Starcounter-Jack/JSON-Patch","homepage":"","size":817,"stargazers_count":389,"watchers_count":389,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":30,"forks":71,"open_issues":30,"watchers":389,"default_branch":"master"}},"base":{"label":"Starcounter-Jack:master","ref":"master","sha":"42eed929fead55ec1d316bc24f37403b9659c574","user":{"login":"Starcounter-Jack","id":1219049,"avatar_url":"https://avatars.githubusercontent.com/u/1219049?v=3","gravatar_id":"","url":"https://api.github.com/users/Starcounter-Jack","html_url":"https://github.com/Starcounter-Jack","followers_url":"https://api.github.com/users/Starcounter-Jack/followers","following_url":"https://api.github.com/users/Starcounter-Jack/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter-Jack/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter-Jack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter-Jack/subscriptions","organizations_url":"https://api.github.com/users/Starcounter-Jack/orgs","repos_url":"https://api.github.com/users/Starcounter-Jack/repos","events_url":"https://api.github.com/users/Starcounter-Jack/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter-Jack/received_events","type":"User","site_admin":false},"repo":{"id":8818872,"name":"JSON-Patch","full_name":"Starcounter-Jack/JSON-Patch","owner":{"login":"Starcounter-Jack","id":1219049,"avatar_url":"https://avatars.githubusercontent.com/u/1219049?v=3","gravatar_id":"","url":"https://api.github.com/users/Starcounter-Jack","html_url":"https://github.com/Starcounter-Jack","followers_url":"https://api.github.com/users/Starcounter-Jack/followers","following_url":"https://api.github.com/users/Starcounter-Jack/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter-Jack/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter-Jack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter-Jack/subscriptions","organizations_url":"https://api.github.com/users/Starcounter-Jack/orgs","repos_url":"https://api.github.com/users/Starcounter-Jack/repos","events_url":"https://api.github.com/users/Starcounter-Jack/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter-Jack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter-Jack/JSON-Patch","description":"Lean and mean Javascript implementation of the JSON-Patch standard (RFC 6902). Update JSON documents using delta patches.","fork":false,"url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch","forks_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/forks","keys_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/teams","hooks_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/hooks","issue_events_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/events","assignees_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/tags","blobs_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/languages","stargazers_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/stargazers","contributors_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/contributors","subscribers_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/subscribers","subscription_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/subscription","commits_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/merges","archive_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/downloads","issues_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/deployments","created_at":"2013-03-16T13:08:46Z","updated_at":"2016-06-02T10:23:16Z","pushed_at":"2016-06-03T14:49:41Z","git_url":"git://github.com/Starcounter-Jack/JSON-Patch.git","ssh_url":"git@github.com:Starcounter-Jack/JSON-Patch.git","clone_url":"https://github.com/Starcounter-Jack/JSON-Patch.git","svn_url":"https://github.com/Starcounter-Jack/JSON-Patch","homepage":"","size":817,"stargazers_count":389,"watchers_count":389,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":30,"forks":71,"open_issues":30,"watchers":389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107"},"html":{"href":"https://github.com/Starcounter-Jack/JSON-Patch/pull/107"},"issue":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/107"},"comments":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/Starcounter-Jack/JSON-Patch/statuses/17832631912d0c3afad21633a75323448a50381c"}}}}
{"actor":{"display_login":"warpech"}}