{"action":"created","issue":{"url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/163","repository_url":"https://api.github.com/repos/dwmkerr/angular-modal-service","labels_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/163/comments","events_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/163/events","html_url":"https://github.com/dwmkerr/angular-modal-service/pull/163","id":161706528,"number":163,"title":"Fix #90 and #71 at the expense of `$element` injection","user":{"login":"ipavlic","id":982962,"avatar_url":"https://avatars.githubusercontent.com/u/982962?v=3","gravatar_id":"","url":"https://api.github.com/users/ipavlic","html_url":"https://github.com/ipavlic","followers_url":"https://api.github.com/users/ipavlic/followers","following_url":"https://api.github.com/users/ipavlic/following{/other_user}","gists_url":"https://api.github.com/users/ipavlic/gists{/gist_id}","starred_url":"https://api.github.com/users/ipavlic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipavlic/subscriptions","organizations_url":"https://api.github.com/users/ipavlic/orgs","repos_url":"https://api.github.com/users/ipavlic/repos","events_url":"https://api.github.com/users/ipavlic/events{/privacy}","received_events_url":"https://api.github.com/users/ipavlic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-22T15:01:14Z","updated_at":"2016-06-22T15:04:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dwmkerr/angular-modal-service/pulls/163","html_url":"https://github.com/dwmkerr/angular-modal-service/pull/163","diff_url":"https://github.com/dwmkerr/angular-modal-service/pull/163.diff","patch_url":"https://github.com/dwmkerr/angular-modal-service/pull/163.patch"},"body":"If the controller is instantiated after compiling and linking, any directives included in the model template won't have access to controller input values.\r\n\r\nFor example, take a modal template which includes a `foo` directive, `<foo bar=\"vm.inputValue\"></foo>`. If compile and link functions are executed first, then `foo`'s controller is instantiated during before compilation.\r\n\r\nHowever, since the modal controller is instantiated in code *after* the linking, the `inputValue` is undefined. This makes it impossible to use directives/components which require values from the modal controller."},"comment":{"url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/comments/227773337","html_url":"https://github.com/dwmkerr/angular-modal-service/pull/163#issuecomment-227773337","issue_url":"https://api.github.com/repos/dwmkerr/angular-modal-service/issues/163","id":227773337,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-06-22T15:04:43Z","updated_at":"2016-06-22T15:04:43Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6706487/badge)](https://coveralls.io/builds/6706487)\n\nCoverage decreased (-1.8%) to 84.127% when pulling **5e168fe156435d58f676704068625ffa251bc6ce on ipavlic:master** into **2c07464da8b661d6721827809f61e1870733bcd6 on dwmkerr:master**.\n"}}
{"actor":{"display_login":"coveralls"}}