{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/69358383","id":69358383,"diff_hunk":"@@ -1709,3 +1709,45 @@ QUnit.test( \"Iterability of jQuery objects (gh-1693)\", function( assert ) {\n \t\tassert.ok( true, \"The browser doesn't support Symbols\" );\n \t}\n } );\n+\n+QUnit[ jQuery.Deferred ? \"test\" : \"skip\" ]( \"jQuery.readyException (original)\", function( assert ) {","path":"test/unit/core.js","position":5,"original_position":5,"commit_id":"682c5e48ff58d383fb2d6f3a7e251a1edeb02941","original_commit_id":"682c5e48ff58d383fb2d6f3a7e251a1edeb02941","user":{"login":"markelog","id":945528,"avatar_url":"https://avatars.githubusercontent.com/u/945528?v=3","gravatar_id":"","url":"https://api.github.com/users/markelog","html_url":"https://github.com/markelog","followers_url":"https://api.github.com/users/markelog/followers","following_url":"https://api.github.com/users/markelog/following{/other_user}","gists_url":"https://api.github.com/users/markelog/gists{/gist_id}","starred_url":"https://api.github.com/users/markelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelog/subscriptions","organizations_url":"https://api.github.com/users/markelog/orgs","repos_url":"https://api.github.com/users/markelog/repos","events_url":"https://api.github.com/users/markelog/events{/privacy}","received_events_url":"https://api.github.com/users/markelog/received_events","type":"User","site_admin":false},"body":"Core tests will not gonna run if you build jQuery without `Deferred`, it seems this guard is redundant? ","created_at":"2016-07-01T21:35:23Z","updated_at":"2016-07-01T21:35:23Z","html_url":"https://github.com/jquery/jquery/pull/3210#discussion_r69358383","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/3210","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/69358383"},"html":{"href":"https://github.com/jquery/jquery/pull/3210#discussion_r69358383"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3210"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/3210","id":75638075,"html_url":"https://github.com/jquery/jquery/pull/3210","diff_url":"https://github.com/jquery/jquery/pull/3210.diff","patch_url":"https://github.com/jquery/jquery/pull/3210.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/3210","number":3210,"state":"open","locked":false,"title":"Core: Re-throw errors that happened in callbacks wrapped in jQuery ready","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"### Summary ###\r\n<!--\r\nDescribe what this PR does. All but trivial changes (e.g. typos)\r\nshould start with an issue. Mention the issue number here.\r\n-->\r\nRe-throw errors that happened in callbacks wrapped in jQuery ready\r\n\r\nAlso, expose jQuery.readyException that allows to overwrite the default\r\nready error handler.\r\n\r\n### Checklist ###\r\nMark an `[x]` for completed items, if you're not sure leave them unchecked and we can assist.\r\n\r\n* [x] All authors have signed the CLA at https://contribute.jquery.com/CLA/\r\n* [x] New tests have been added to show the fix or feature works\r\n* [x] Grunt build and unit tests pass locally with these changes\r\n* [x] If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com (https://github.com/jquery/api.jquery.com/issues/942)\r\n\r\nThanks! Bots and humans will be around shortly to check it out.\r\n\r\nFixes gh-3174","created_at":"2016-06-29T12:22:15Z","updated_at":"2016-07-01T21:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf84fbd1cdca655207dcb279c1e6e223c2f797d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/3210/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/3210/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/3210/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/682c5e48ff58d383fb2d6f3a7e251a1edeb02941","head":{"label":"mgol:readyException","ref":"readyException","sha":"682c5e48ff58d383fb2d6f3a7e251a1edeb02941","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"repo":{"id":8512091,"name":"jquery","full_name":"mgol/jquery","owner":{"login":"mgol","id":1758366,"avatar_url":"https://avatars.githubusercontent.com/u/1758366?v=3","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgol/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/mgol/jquery","forks_url":"https://api.github.com/repos/mgol/jquery/forks","keys_url":"https://api.github.com/repos/mgol/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgol/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgol/jquery/teams","hooks_url":"https://api.github.com/repos/mgol/jquery/hooks","issue_events_url":"https://api.github.com/repos/mgol/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/mgol/jquery/events","assignees_url":"https://api.github.com/repos/mgol/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/mgol/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/mgol/jquery/tags","blobs_url":"https://api.github.com/repos/mgol/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgol/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgol/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgol/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgol/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/mgol/jquery/languages","stargazers_url":"https://api.github.com/repos/mgol/jquery/stargazers","contributors_url":"https://api.github.com/repos/mgol/jquery/contributors","subscribers_url":"https://api.github.com/repos/mgol/jquery/subscribers","subscription_url":"https://api.github.com/repos/mgol/jquery/subscription","commits_url":"https://api.github.com/repos/mgol/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgol/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgol/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgol/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgol/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/mgol/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgol/jquery/merges","archive_url":"https://api.github.com/repos/mgol/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgol/jquery/downloads","issues_url":"https://api.github.com/repos/mgol/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/mgol/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/mgol/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/mgol/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgol/jquery/labels{/name}","releases_url":"https://api.github.com/repos/mgol/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/mgol/jquery/deployments","created_at":"2013-03-01T23:04:07Z","updated_at":"2015-07-06T14:20:48Z","pushed_at":"2016-06-29T12:21:39Z","git_url":"git://github.com/mgol/jquery.git","ssh_url":"git@github.com:mgol/jquery.git","clone_url":"https://github.com/mgol/jquery.git","svn_url":"https://github.com/mgol/jquery","homepage":"http://jquery.com/","size":23584,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"25d8ccd1112d75394b91071ff7eba13283aaf898","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/jquery/jquery/deployments","created_at":"2009-04-03T15:20:14Z","updated_at":"2016-07-01T20:53:57Z","pushed_at":"2016-06-29T12:22:15Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"https://jquery.com/","size":44443,"stargazers_count":40197,"watchers_count":40197,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":10817,"mirror_url":null,"open_issues_count":59,"forks":10817,"open_issues":59,"watchers":40197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3210"},"html":{"href":"https://github.com/jquery/jquery/pull/3210"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/3210"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/3210/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3210/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3210/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/682c5e48ff58d383fb2d6f3a7e251a1edeb02941"}}}}
{"actor":{"display_login":"markelog"}}