{"action":"created","comment":{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/comments/77311262","id":77311262,"diff_hunk":"@@ -376,6 +380,12 @@ ConnectionEndpoint.prototype._registerAuthenticatedSocket  = function( socketWra\n \t\tsocketWrapper.sendMessage( C.TOPIC.AUTH, C.ACTIONS.ACK, [ messageBuilder.typed( userData.clientData ) ] );\n \t}\n \n+\tif( userData.username != 'OPEN' ) {\n+\t\tvar msg = messageBuilder.getMsg( C.TOPIC.PRESENCE, C.ACTIONS.PRESENCE_ADD, [ messageBuilder.typed( userData.username ) ] );\n+\t\tdebugger;\n+\t\tsetTimeout( this.onMessage( socketWrapper, msg ), 0);","path":"src/message/connection-endpoint.js","position":18,"original_position":18,"commit_id":"9741f61eb2883b9213785c7bb3ad6c4afef4f9e5","original_commit_id":"9741f61eb2883b9213785c7bb3ad6c4afef4f9e5","user":{"login":"yasserf","id":2734923,"avatar_url":"https://avatars.githubusercontent.com/u/2734923?v=3","gravatar_id":"","url":"https://api.github.com/users/yasserf","html_url":"https://github.com/yasserf","followers_url":"https://api.github.com/users/yasserf/followers","following_url":"https://api.github.com/users/yasserf/following{/other_user}","gists_url":"https://api.github.com/users/yasserf/gists{/gist_id}","starred_url":"https://api.github.com/users/yasserf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasserf/subscriptions","organizations_url":"https://api.github.com/users/yasserf/orgs","repos_url":"https://api.github.com/users/yasserf/repos","events_url":"https://api.github.com/users/yasserf/events{/privacy}","received_events_url":"https://api.github.com/users/yasserf/received_events","type":"User","site_admin":false},"body":"We might also need to actually call the method directly on the presense, i been thinking about this approach and it can easily allow users to trigger the same event using that topic and message which would break the state of the system. See deepstream.io comment","created_at":"2016-09-02T08:32:41Z","updated_at":"2016-09-02T08:32:41Z","html_url":"https://github.com/deepstreamIO/deepstream.io/pull/349#discussion_r77311262","pull_request_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/comments/77311262"},"html":{"href":"https://github.com/deepstreamIO/deepstream.io/pull/349#discussion_r77311262"},"pull_request":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349","id":83761216,"html_url":"https://github.com/deepstreamIO/deepstream.io/pull/349","diff_url":"https://github.com/deepstreamIO/deepstream.io/pull/349.diff","patch_url":"https://github.com/deepstreamIO/deepstream.io/pull/349.patch","issue_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues/349","number":349,"state":"open","locked":false,"title":"[WIP] Feature/presence","user":{"login":"AlexBHarley","id":11168524,"avatar_url":"https://avatars.githubusercontent.com/u/11168524?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexBHarley","html_url":"https://github.com/AlexBHarley","followers_url":"https://api.github.com/users/AlexBHarley/followers","following_url":"https://api.github.com/users/AlexBHarley/following{/other_user}","gists_url":"https://api.github.com/users/AlexBHarley/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexBHarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexBHarley/subscriptions","organizations_url":"https://api.github.com/users/AlexBHarley/orgs","repos_url":"https://api.github.com/users/AlexBHarley/repos","events_url":"https://api.github.com/users/AlexBHarley/events{/privacy}","received_events_url":"https://api.github.com/users/AlexBHarley/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-02T08:10:05Z","updated_at":"2016-09-02T08:32:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"809090ecb2b117fedb355bc43699dcae50d53495","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349/commits","review_comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349/comments","review_comment_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues/349/comments","statuses_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/statuses/9741f61eb2883b9213785c7bb3ad6c4afef4f9e5","head":{"label":"AlexBHarley:feature/presence","ref":"feature/presence","sha":"9741f61eb2883b9213785c7bb3ad6c4afef4f9e5","user":{"login":"AlexBHarley","id":11168524,"avatar_url":"https://avatars.githubusercontent.com/u/11168524?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexBHarley","html_url":"https://github.com/AlexBHarley","followers_url":"https://api.github.com/users/AlexBHarley/followers","following_url":"https://api.github.com/users/AlexBHarley/following{/other_user}","gists_url":"https://api.github.com/users/AlexBHarley/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexBHarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexBHarley/subscriptions","organizations_url":"https://api.github.com/users/AlexBHarley/orgs","repos_url":"https://api.github.com/users/AlexBHarley/repos","events_url":"https://api.github.com/users/AlexBHarley/events{/privacy}","received_events_url":"https://api.github.com/users/AlexBHarley/received_events","type":"User","site_admin":false},"repo":{"id":62229542,"name":"deepstream.io","full_name":"AlexBHarley/deepstream.io","owner":{"login":"AlexBHarley","id":11168524,"avatar_url":"https://avatars.githubusercontent.com/u/11168524?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexBHarley","html_url":"https://github.com/AlexBHarley","followers_url":"https://api.github.com/users/AlexBHarley/followers","following_url":"https://api.github.com/users/AlexBHarley/following{/other_user}","gists_url":"https://api.github.com/users/AlexBHarley/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexBHarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexBHarley/subscriptions","organizations_url":"https://api.github.com/users/AlexBHarley/orgs","repos_url":"https://api.github.com/users/AlexBHarley/repos","events_url":"https://api.github.com/users/AlexBHarley/events{/privacy}","received_events_url":"https://api.github.com/users/AlexBHarley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexBHarley/deepstream.io","description":"deepstream.io node server","fork":true,"url":"https://api.github.com/repos/AlexBHarley/deepstream.io","forks_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/forks","keys_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/teams","hooks_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/hooks","issue_events_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/issues/events{/number}","events_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/events","assignees_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/assignees{/user}","branches_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/branches{/branch}","tags_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/tags","blobs_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/languages","stargazers_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/stargazers","contributors_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/contributors","subscribers_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/subscribers","subscription_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/subscription","commits_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/contents/{+path}","compare_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/merges","archive_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/downloads","issues_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/issues{/number}","pulls_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/labels{/name}","releases_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/releases{/id}","deployments_url":"https://api.github.com/repos/AlexBHarley/deepstream.io/deployments","created_at":"2016-06-29T13:51:26Z","updated_at":"2016-06-29T13:51:27Z","pushed_at":"2016-09-02T08:07:09Z","git_url":"git://github.com/AlexBHarley/deepstream.io.git","ssh_url":"git@github.com:AlexBHarley/deepstream.io.git","clone_url":"https://github.com/AlexBHarley/deepstream.io.git","svn_url":"https://github.com/AlexBHarley/deepstream.io","homepage":"http://deepstream.io/","size":5879,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deepstreamIO:master","ref":"master","sha":"c6ba47e9d5ed89dafa5108a6a19535843b62362e","user":{"login":"deepstreamIO","id":9024218,"avatar_url":"https://avatars.githubusercontent.com/u/9024218?v=3","gravatar_id":"","url":"https://api.github.com/users/deepstreamIO","html_url":"https://github.com/deepstreamIO","followers_url":"https://api.github.com/users/deepstreamIO/followers","following_url":"https://api.github.com/users/deepstreamIO/following{/other_user}","gists_url":"https://api.github.com/users/deepstreamIO/gists{/gist_id}","starred_url":"https://api.github.com/users/deepstreamIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepstreamIO/subscriptions","organizations_url":"https://api.github.com/users/deepstreamIO/orgs","repos_url":"https://api.github.com/users/deepstreamIO/repos","events_url":"https://api.github.com/users/deepstreamIO/events{/privacy}","received_events_url":"https://api.github.com/users/deepstreamIO/received_events","type":"Organization","site_admin":false},"repo":{"id":26390092,"name":"deepstream.io","full_name":"deepstreamIO/deepstream.io","owner":{"login":"deepstreamIO","id":9024218,"avatar_url":"https://avatars.githubusercontent.com/u/9024218?v=3","gravatar_id":"","url":"https://api.github.com/users/deepstreamIO","html_url":"https://github.com/deepstreamIO","followers_url":"https://api.github.com/users/deepstreamIO/followers","following_url":"https://api.github.com/users/deepstreamIO/following{/other_user}","gists_url":"https://api.github.com/users/deepstreamIO/gists{/gist_id}","starred_url":"https://api.github.com/users/deepstreamIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepstreamIO/subscriptions","organizations_url":"https://api.github.com/users/deepstreamIO/orgs","repos_url":"https://api.github.com/users/deepstreamIO/repos","events_url":"https://api.github.com/users/deepstreamIO/events{/privacy}","received_events_url":"https://api.github.com/users/deepstreamIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deepstreamIO/deepstream.io","description":"deepstream.io server","fork":false,"url":"https://api.github.com/repos/deepstreamIO/deepstream.io","forks_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/forks","keys_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/teams","hooks_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/hooks","issue_events_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues/events{/number}","events_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/events","assignees_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/assignees{/user}","branches_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/branches{/branch}","tags_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/tags","blobs_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/statuses/{sha}","languages_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/languages","stargazers_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/stargazers","contributors_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/contributors","subscribers_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/subscribers","subscription_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/subscription","commits_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/contents/{+path}","compare_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/merges","archive_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/downloads","issues_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues{/number}","pulls_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls{/number}","milestones_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/milestones{/number}","notifications_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/labels{/name}","releases_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/releases{/id}","deployments_url":"https://api.github.com/repos/deepstreamIO/deepstream.io/deployments","created_at":"2014-11-09T08:30:01Z","updated_at":"2016-09-02T07:24:21Z","pushed_at":"2016-09-02T08:10:06Z","git_url":"git://github.com/deepstreamIO/deepstream.io.git","ssh_url":"git@github.com:deepstreamIO/deepstream.io.git","clone_url":"https://github.com/deepstreamIO/deepstream.io.git","svn_url":"https://github.com/deepstreamIO/deepstream.io","homepage":"http://deepstream.io/","size":6458,"stargazers_count":2540,"watchers_count":2540,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":65,"forks":88,"open_issues":65,"watchers":2540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349"},"html":{"href":"https://github.com/deepstreamIO/deepstream.io/pull/349"},"issue":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues/349"},"comments":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/deepstreamIO/deepstream.io/statuses/9741f61eb2883b9213785c7bb3ad6c4afef4f9e5"}}}}
{"actor":{"display_login":"yasserf"}}