{"action":"created","comment":{"url":"https://api.github.com/repos/opesci/devito/pulls/comments/74243603","id":74243603,"diff_hunk":"@@ -244,42 +439,64 @@ def __init__(self, *args, **kwargs):\n         else:\n             self.nt = kwargs.get('nt')\n             self.npoint = kwargs.get('npoint')\n+            ndim = kwargs.get('ndim')\n             kwargs['shape'] = (self.nt, self.npoint)\n-            DenseData.__init__(self, *args, **kwargs)\n+            super(PointData, self).__init__(self, *args, **kwargs)\n+            coordinates = kwargs.get('coordinates')\n+            self.coordinates = CoordinateData(name='%s_coords' % self.name,\n+                                              data=coordinates, ndim=ndim,\n+                                              nt=self.nt, npoint=self.npoint)\n+            self.coordinates.data[:] = kwargs.get('coordinates')[:]\n             # Store final instance in symbol cache\n             self._cache_put(self)\n \n     def __new__(cls, *args, **kwargs):\n         nt = kwargs.get('nt')\n         npoint = kwargs.get('npoint')\n         kwargs['shape'] = (nt, npoint)\n+\n         return DenseData.__new__(cls, *args, **kwargs)\n \n     @classmethod\n     def indices(cls, shape):\n         \"\"\"Return the default dimension indices for a given data shape\n \n         :param shape: Shape of the spatial data\n+        :return: indices used for axis.\n         \"\"\"\n         _indices = [t, x, y, z]\n+\n         return _indices[:len(shape) + 1]\n \n \n class MemmapManager():","path":"devito/interfaces.py","position":449,"original_position":449,"commit_id":"d4a1f4565e4d801278fa29537e74f3ae35ff0543","original_commit_id":"d4a1f4565e4d801278fa29537e74f3ae35ff0543","user":{"login":"pp1336","id":19698704,"avatar_url":"https://avatars.githubusercontent.com/u/19698704?v=3","gravatar_id":"","url":"https://api.github.com/users/pp1336","html_url":"https://github.com/pp1336","followers_url":"https://api.github.com/users/pp1336/followers","following_url":"https://api.github.com/users/pp1336/following{/other_user}","gists_url":"https://api.github.com/users/pp1336/gists{/gist_id}","starred_url":"https://api.github.com/users/pp1336/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp1336/subscriptions","organizations_url":"https://api.github.com/users/pp1336/orgs","repos_url":"https://api.github.com/users/pp1336/repos","events_url":"https://api.github.com/users/pp1336/events{/privacy}","received_events_url":"https://api.github.com/users/pp1336/received_events","type":"User","site_admin":false},"body":"Just here","created_at":"2016-08-10T13:30:48Z","updated_at":"2016-08-10T13:30:48Z","html_url":"https://github.com/opesci/devito/pull/81#discussion_r74243603","pull_request_url":"https://api.github.com/repos/opesci/devito/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments/74243603"},"html":{"href":"https://github.com/opesci/devito/pull/81#discussion_r74243603"},"pull_request":{"href":"https://api.github.com/repos/opesci/devito/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/opesci/devito/pulls/81","id":80774025,"html_url":"https://github.com/opesci/devito/pull/81","diff_url":"https://github.com/opesci/devito/pull/81.diff","patch_url":"https://github.com/opesci/devito/pull/81.patch","issue_url":"https://api.github.com/repos/opesci/devito/issues/81","number":81,"state":"open","locked":false,"title":"Refinement over use of memmap","user":{"login":"pp1336","id":19698704,"avatar_url":"https://avatars.githubusercontent.com/u/19698704?v=3","gravatar_id":"","url":"https://api.github.com/users/pp1336","html_url":"https://github.com/pp1336","followers_url":"https://api.github.com/users/pp1336/followers","following_url":"https://api.github.com/users/pp1336/following{/other_user}","gists_url":"https://api.github.com/users/pp1336/gists{/gist_id}","starred_url":"https://api.github.com/users/pp1336/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp1336/subscriptions","organizations_url":"https://api.github.com/users/pp1336/orgs","repos_url":"https://api.github.com/users/pp1336/repos","events_url":"https://api.github.com/users/pp1336/events{/privacy}","received_events_url":"https://api.github.com/users/pp1336/received_events","type":"User","site_admin":false},"body":"Add some comments.\r\nAdd the ability to have files of repeated name, which happened in acoustic_example(though in this case it may not cause an issue, but similar cases can happen in the future).\r\nAdd the ability to retain created file, default behaviour is to delete all files created.\r\n\r\nPlease ignore changes at places other than devito/interface.MemmapManager, those are just merge conflict.","created_at":"2016-08-10T10:57:14Z","updated_at":"2016-08-10T13:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opesci/devito/pulls/81/commits","review_comments_url":"https://api.github.com/repos/opesci/devito/pulls/81/comments","review_comment_url":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opesci/devito/issues/81/comments","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/d4a1f4565e4d801278fa29537e74f3ae35ff0543","head":{"label":"opesci:memmap","ref":"memmap","sha":"d4a1f4565e4d801278fa29537e74f3ae35ff0543","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation for the inversion workflow","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2016-04-22T12:11:36Z","pushed_at":"2016-08-10T13:14:30Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":null,"size":1714,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"base":{"label":"opesci:master","ref":"master","sha":"ebef3d1945c1d49be44d75f9f33afa59d86c2d64","user":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"repo":{"id":54585666,"name":"devito","full_name":"opesci/devito","owner":{"login":"opesci","id":10018551,"avatar_url":"https://avatars.githubusercontent.com/u/10018551?v=3","gravatar_id":"","url":"https://api.github.com/users/opesci","html_url":"https://github.com/opesci","followers_url":"https://api.github.com/users/opesci/followers","following_url":"https://api.github.com/users/opesci/following{/other_user}","gists_url":"https://api.github.com/users/opesci/gists{/gist_id}","starred_url":"https://api.github.com/users/opesci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opesci/subscriptions","organizations_url":"https://api.github.com/users/opesci/orgs","repos_url":"https://api.github.com/users/opesci/repos","events_url":"https://api.github.com/users/opesci/events{/privacy}","received_events_url":"https://api.github.com/users/opesci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opesci/devito","description":"Code generation for the inversion workflow","fork":false,"url":"https://api.github.com/repos/opesci/devito","forks_url":"https://api.github.com/repos/opesci/devito/forks","keys_url":"https://api.github.com/repos/opesci/devito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opesci/devito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opesci/devito/teams","hooks_url":"https://api.github.com/repos/opesci/devito/hooks","issue_events_url":"https://api.github.com/repos/opesci/devito/issues/events{/number}","events_url":"https://api.github.com/repos/opesci/devito/events","assignees_url":"https://api.github.com/repos/opesci/devito/assignees{/user}","branches_url":"https://api.github.com/repos/opesci/devito/branches{/branch}","tags_url":"https://api.github.com/repos/opesci/devito/tags","blobs_url":"https://api.github.com/repos/opesci/devito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opesci/devito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opesci/devito/git/refs{/sha}","trees_url":"https://api.github.com/repos/opesci/devito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opesci/devito/statuses/{sha}","languages_url":"https://api.github.com/repos/opesci/devito/languages","stargazers_url":"https://api.github.com/repos/opesci/devito/stargazers","contributors_url":"https://api.github.com/repos/opesci/devito/contributors","subscribers_url":"https://api.github.com/repos/opesci/devito/subscribers","subscription_url":"https://api.github.com/repos/opesci/devito/subscription","commits_url":"https://api.github.com/repos/opesci/devito/commits{/sha}","git_commits_url":"https://api.github.com/repos/opesci/devito/git/commits{/sha}","comments_url":"https://api.github.com/repos/opesci/devito/comments{/number}","issue_comment_url":"https://api.github.com/repos/opesci/devito/issues/comments{/number}","contents_url":"https://api.github.com/repos/opesci/devito/contents/{+path}","compare_url":"https://api.github.com/repos/opesci/devito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opesci/devito/merges","archive_url":"https://api.github.com/repos/opesci/devito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opesci/devito/downloads","issues_url":"https://api.github.com/repos/opesci/devito/issues{/number}","pulls_url":"https://api.github.com/repos/opesci/devito/pulls{/number}","milestones_url":"https://api.github.com/repos/opesci/devito/milestones{/number}","notifications_url":"https://api.github.com/repos/opesci/devito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opesci/devito/labels{/name}","releases_url":"https://api.github.com/repos/opesci/devito/releases{/id}","deployments_url":"https://api.github.com/repos/opesci/devito/deployments","created_at":"2016-03-23T18:59:49Z","updated_at":"2016-04-22T12:11:36Z","pushed_at":"2016-08-10T13:14:30Z","git_url":"git://github.com/opesci/devito.git","ssh_url":"git@github.com:opesci/devito.git","clone_url":"https://github.com/opesci/devito.git","svn_url":"https://github.com/opesci/devito","homepage":null,"size":1714,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opesci/devito/pulls/81"},"html":{"href":"https://github.com/opesci/devito/pull/81"},"issue":{"href":"https://api.github.com/repos/opesci/devito/issues/81"},"comments":{"href":"https://api.github.com/repos/opesci/devito/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/opesci/devito/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/opesci/devito/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opesci/devito/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/opesci/devito/statuses/d4a1f4565e4d801278fa29537e74f3ae35ff0543"}}}}
{"actor":{"display_login":"pp1336"}}