{"action":"opened","number":1243,"pull_request":{"url":"https://api.github.com/repos/shoes/shoes4/pulls/1243","id":73252943,"html_url":"https://github.com/shoes/shoes4/pull/1243","diff_url":"https://github.com/shoes/shoes4/pull/1243.diff","patch_url":"https://github.com/shoes/shoes4/pull/1243.patch","issue_url":"https://api.github.com/repos/shoes/shoes4/issues/1243","number":1243,"state":"open","locked":false,"title":"Resolve 8 RuboCop issues","user":{"login":"rubycoder","id":437106,"avatar_url":"https://avatars.githubusercontent.com/u/437106?v=3","gravatar_id":"","url":"https://api.github.com/users/rubycoder","html_url":"https://github.com/rubycoder","followers_url":"https://api.github.com/users/rubycoder/followers","following_url":"https://api.github.com/users/rubycoder/following{/other_user}","gists_url":"https://api.github.com/users/rubycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/rubycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubycoder/subscriptions","organizations_url":"https://api.github.com/users/rubycoder/orgs","repos_url":"https://api.github.com/users/rubycoder/repos","events_url":"https://api.github.com/users/rubycoder/events{/privacy}","received_events_url":"https://api.github.com/users/rubycoder/received_events","type":"User","site_admin":false},"body":"The remaining RuboCop issues are ones where, IMHO, we arguably don't want to change the code simply to avoid a RuboCop message.\r\n\r\n```\r\nshoes/app.rb:60:7: C: Performance/RedundantMerge: Use options[:owner] = self instead of options.merge! owner: self.\r\n      options.merge! owner: self\r\n      ^^^^^^^^^^^^^^^^^^^^^^^^^^\r\nshoes/slot_contents.rb:27:7: C: Performance/RedundantBlockCall: Use yield instead of blk.call.\r\n      blk.call\r\n      ^^^^^^^^\r\nshoes/dsl.rb:586:7: C: Performance/RedundantBlockCall: Use yield instead of blk.call.\r\n      blk.call if blk\r\n      ^^^^^^^^\r\nshoes/slot.rb:288:21: C: Style/MultilineMethodCallIndentation: Align select with contents. on line 287.\r\n                    select(&:takes_up_space?).\r\n                    ^^^^^^\r\nshoes/slot.rb:289:21: C: Style/MultilineMethodCallIndentation: Align reject with contents. on line 287.\r\n                    reject(&:hidden?).\r\n                    ^^^^^^\r\nshoes/slot.rb:290:21: C: Style/MultilineMethodCallIndentation: Align map with contents. on line 287.\r\n                    map(&:absolute_bottom).\r\n                    ^^^\r\nshoes/slot.rb:291:21: C: Style/MultilineMethodCallIndentation: Align max with contents. on line 287.\r\n                    max\r\n                    ^^^\r\nshoes/text_block.rb:132:21: C: Style/MultilineMethodCallIndentation: Align .split with .gsub on line 131.\r\n                    .split(',').map { |x| x.strip.gsub(/[\"]/, '') }\r\n                    ^^^^^^\r\n```","created_at":"2016-06-09T17:22:24Z","updated_at":"2016-06-09T17:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shoes/shoes4/pulls/1243/commits","review_comments_url":"https://api.github.com/repos/shoes/shoes4/pulls/1243/comments","review_comment_url":"https://api.github.com/repos/shoes/shoes4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shoes/shoes4/issues/1243/comments","statuses_url":"https://api.github.com/repos/shoes/shoes4/statuses/b4025a95d5738bea9fa40da6ccc4ba5bcd7422e3","head":{"label":"rubycoder:rubocop_5","ref":"rubocop_5","sha":"b4025a95d5738bea9fa40da6ccc4ba5bcd7422e3","user":{"login":"rubycoder","id":437106,"avatar_url":"https://avatars.githubusercontent.com/u/437106?v=3","gravatar_id":"","url":"https://api.github.com/users/rubycoder","html_url":"https://github.com/rubycoder","followers_url":"https://api.github.com/users/rubycoder/followers","following_url":"https://api.github.com/users/rubycoder/following{/other_user}","gists_url":"https://api.github.com/users/rubycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/rubycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubycoder/subscriptions","organizations_url":"https://api.github.com/users/rubycoder/orgs","repos_url":"https://api.github.com/users/rubycoder/repos","events_url":"https://api.github.com/users/rubycoder/events{/privacy}","received_events_url":"https://api.github.com/users/rubycoder/received_events","type":"User","site_admin":false},"repo":{"id":59868981,"name":"shoes4","full_name":"rubycoder/shoes4","owner":{"login":"rubycoder","id":437106,"avatar_url":"https://avatars.githubusercontent.com/u/437106?v=3","gravatar_id":"","url":"https://api.github.com/users/rubycoder","html_url":"https://github.com/rubycoder","followers_url":"https://api.github.com/users/rubycoder/followers","following_url":"https://api.github.com/users/rubycoder/following{/other_user}","gists_url":"https://api.github.com/users/rubycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/rubycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubycoder/subscriptions","organizations_url":"https://api.github.com/users/rubycoder/orgs","repos_url":"https://api.github.com/users/rubycoder/repos","events_url":"https://api.github.com/users/rubycoder/events{/privacy}","received_events_url":"https://api.github.com/users/rubycoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubycoder/shoes4","description":"Shoes 4 : the next version of Shoes","fork":true,"url":"https://api.github.com/repos/rubycoder/shoes4","forks_url":"https://api.github.com/repos/rubycoder/shoes4/forks","keys_url":"https://api.github.com/repos/rubycoder/shoes4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubycoder/shoes4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubycoder/shoes4/teams","hooks_url":"https://api.github.com/repos/rubycoder/shoes4/hooks","issue_events_url":"https://api.github.com/repos/rubycoder/shoes4/issues/events{/number}","events_url":"https://api.github.com/repos/rubycoder/shoes4/events","assignees_url":"https://api.github.com/repos/rubycoder/shoes4/assignees{/user}","branches_url":"https://api.github.com/repos/rubycoder/shoes4/branches{/branch}","tags_url":"https://api.github.com/repos/rubycoder/shoes4/tags","blobs_url":"https://api.github.com/repos/rubycoder/shoes4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubycoder/shoes4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubycoder/shoes4/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubycoder/shoes4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubycoder/shoes4/statuses/{sha}","languages_url":"https://api.github.com/repos/rubycoder/shoes4/languages","stargazers_url":"https://api.github.com/repos/rubycoder/shoes4/stargazers","contributors_url":"https://api.github.com/repos/rubycoder/shoes4/contributors","subscribers_url":"https://api.github.com/repos/rubycoder/shoes4/subscribers","subscription_url":"https://api.github.com/repos/rubycoder/shoes4/subscription","commits_url":"https://api.github.com/repos/rubycoder/shoes4/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubycoder/shoes4/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubycoder/shoes4/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubycoder/shoes4/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubycoder/shoes4/contents/{+path}","compare_url":"https://api.github.com/repos/rubycoder/shoes4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubycoder/shoes4/merges","archive_url":"https://api.github.com/repos/rubycoder/shoes4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubycoder/shoes4/downloads","issues_url":"https://api.github.com/repos/rubycoder/shoes4/issues{/number}","pulls_url":"https://api.github.com/repos/rubycoder/shoes4/pulls{/number}","milestones_url":"https://api.github.com/repos/rubycoder/shoes4/milestones{/number}","notifications_url":"https://api.github.com/repos/rubycoder/shoes4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubycoder/shoes4/labels{/name}","releases_url":"https://api.github.com/repos/rubycoder/shoes4/releases{/id}","deployments_url":"https://api.github.com/repos/rubycoder/shoes4/deployments","created_at":"2016-05-27T23:52:25Z","updated_at":"2016-05-27T23:52:30Z","pushed_at":"2016-06-09T17:11:56Z","git_url":"git://github.com/rubycoder/shoes4.git","ssh_url":"git@github.com:rubycoder/shoes4.git","clone_url":"https://github.com/rubycoder/shoes4.git","svn_url":"https://github.com/rubycoder/shoes4","homepage":"","size":55172,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shoes:master","ref":"master","sha":"2c180fae39f04ca7f3da3f1e0c9c37b33c1b466d","user":{"login":"shoes","id":119935,"avatar_url":"https://avatars.githubusercontent.com/u/119935?v=3","gravatar_id":"","url":"https://api.github.com/users/shoes","html_url":"https://github.com/shoes","followers_url":"https://api.github.com/users/shoes/followers","following_url":"https://api.github.com/users/shoes/following{/other_user}","gists_url":"https://api.github.com/users/shoes/gists{/gist_id}","starred_url":"https://api.github.com/users/shoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoes/subscriptions","organizations_url":"https://api.github.com/users/shoes/orgs","repos_url":"https://api.github.com/users/shoes/repos","events_url":"https://api.github.com/users/shoes/events{/privacy}","received_events_url":"https://api.github.com/users/shoes/received_events","type":"Organization","site_admin":false},"repo":{"id":4434126,"name":"shoes4","full_name":"shoes/shoes4","owner":{"login":"shoes","id":119935,"avatar_url":"https://avatars.githubusercontent.com/u/119935?v=3","gravatar_id":"","url":"https://api.github.com/users/shoes","html_url":"https://github.com/shoes","followers_url":"https://api.github.com/users/shoes/followers","following_url":"https://api.github.com/users/shoes/following{/other_user}","gists_url":"https://api.github.com/users/shoes/gists{/gist_id}","starred_url":"https://api.github.com/users/shoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoes/subscriptions","organizations_url":"https://api.github.com/users/shoes/orgs","repos_url":"https://api.github.com/users/shoes/repos","events_url":"https://api.github.com/users/shoes/events{/privacy}","received_events_url":"https://api.github.com/users/shoes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shoes/shoes4","description":"Shoes 4 : the next version of Shoes","fork":false,"url":"https://api.github.com/repos/shoes/shoes4","forks_url":"https://api.github.com/repos/shoes/shoes4/forks","keys_url":"https://api.github.com/repos/shoes/shoes4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoes/shoes4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoes/shoes4/teams","hooks_url":"https://api.github.com/repos/shoes/shoes4/hooks","issue_events_url":"https://api.github.com/repos/shoes/shoes4/issues/events{/number}","events_url":"https://api.github.com/repos/shoes/shoes4/events","assignees_url":"https://api.github.com/repos/shoes/shoes4/assignees{/user}","branches_url":"https://api.github.com/repos/shoes/shoes4/branches{/branch}","tags_url":"https://api.github.com/repos/shoes/shoes4/tags","blobs_url":"https://api.github.com/repos/shoes/shoes4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoes/shoes4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoes/shoes4/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoes/shoes4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoes/shoes4/statuses/{sha}","languages_url":"https://api.github.com/repos/shoes/shoes4/languages","stargazers_url":"https://api.github.com/repos/shoes/shoes4/stargazers","contributors_url":"https://api.github.com/repos/shoes/shoes4/contributors","subscribers_url":"https://api.github.com/repos/shoes/shoes4/subscribers","subscription_url":"https://api.github.com/repos/shoes/shoes4/subscription","commits_url":"https://api.github.com/repos/shoes/shoes4/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoes/shoes4/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoes/shoes4/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoes/shoes4/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoes/shoes4/contents/{+path}","compare_url":"https://api.github.com/repos/shoes/shoes4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoes/shoes4/merges","archive_url":"https://api.github.com/repos/shoes/shoes4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoes/shoes4/downloads","issues_url":"https://api.github.com/repos/shoes/shoes4/issues{/number}","pulls_url":"https://api.github.com/repos/shoes/shoes4/pulls{/number}","milestones_url":"https://api.github.com/repos/shoes/shoes4/milestones{/number}","notifications_url":"https://api.github.com/repos/shoes/shoes4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoes/shoes4/labels{/name}","releases_url":"https://api.github.com/repos/shoes/shoes4/releases{/id}","deployments_url":"https://api.github.com/repos/shoes/shoes4/deployments","created_at":"2012-05-24T14:57:59Z","updated_at":"2016-06-09T10:14:27Z","pushed_at":"2016-06-08T15:00:10Z","git_url":"git://github.com/shoes/shoes4.git","ssh_url":"git@github.com:shoes/shoes4.git","clone_url":"https://github.com/shoes/shoes4.git","svn_url":"https://github.com/shoes/shoes4","homepage":"","size":56623,"stargazers_count":978,"watchers_count":978,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":140,"forks":166,"open_issues":140,"watchers":978,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/1243"},"html":{"href":"https://github.com/shoes/shoes4/pull/1243"},"issue":{"href":"https://api.github.com/repos/shoes/shoes4/issues/1243"},"comments":{"href":"https://api.github.com/repos/shoes/shoes4/issues/1243/comments"},"review_comments":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/1243/comments"},"review_comment":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shoes/shoes4/pulls/1243/commits"},"statuses":{"href":"https://api.github.com/repos/shoes/shoes4/statuses/b4025a95d5738bea9fa40da6ccc4ba5bcd7422e3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":8,"changed_files":5}}
{"actor":{"display_login":"rubycoder"}}