{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/30682","labels_url":"https://api.github.com/repos/saltstack/salt/issues/30682/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/30682/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/30682/events","html_url":"https://github.com/saltstack/salt/pull/30682","id":129229917,"number":30682,"title":"Pop values from new_tags set before loading into dict value","user":{"login":"atengler","id":11465219,"avatar_url":"https://avatars.githubusercontent.com/u/11465219?v=3","gravatar_id":"","url":"https://api.github.com/users/atengler","html_url":"https://github.com/atengler","followers_url":"https://api.github.com/users/atengler/followers","following_url":"https://api.github.com/users/atengler/following{/other_user}","gists_url":"https://api.github.com/users/atengler/gists{/gist_id}","starred_url":"https://api.github.com/users/atengler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atengler/subscriptions","organizations_url":"https://api.github.com/users/atengler/orgs","repos_url":"https://api.github.com/users/atengler/repos","events_url":"https://api.github.com/users/atengler/events{/privacy}","received_events_url":"https://api.github.com/users/atengler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-27T18:34:21Z","updated_at":"2016-01-28T10:26:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/30682","html_url":"https://github.com/saltstack/salt/pull/30682","diff_url":"https://github.com/saltstack/salt/pull/30682.diff","patch_url":"https://github.com/saltstack/salt/pull/30682.patch"},"body":"This was causing state to fail with - Passed invalid arguments: can't serialize set([' tag']). Everytime when tags were defined. I described this issue here - https://github.com/saltstack/salt/issues/30681"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/176109973","html_url":"https://github.com/saltstack/salt/pull/30682#issuecomment-176109973","issue_url":"https://api.github.com/repos/saltstack/salt/issues/30682","id":176109973,"user":{"login":"atengler","id":11465219,"avatar_url":"https://avatars.githubusercontent.com/u/11465219?v=3","gravatar_id":"","url":"https://api.github.com/users/atengler","html_url":"https://github.com/atengler","followers_url":"https://api.github.com/users/atengler/followers","following_url":"https://api.github.com/users/atengler/following{/other_user}","gists_url":"https://api.github.com/users/atengler/gists{/gist_id}","starred_url":"https://api.github.com/users/atengler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atengler/subscriptions","organizations_url":"https://api.github.com/users/atengler/orgs","repos_url":"https://api.github.com/users/atengler/repos","events_url":"https://api.github.com/users/atengler/events{/privacy}","received_events_url":"https://api.github.com/users/atengler/received_events","type":"User","site_admin":false},"created_at":"2016-01-28T10:26:03Z","updated_at":"2016-01-28T10:26:03Z","body":"My bad, I chose wrong way of unpacking the values from the set, but the way I use to to input the tags (as string or as list in SLS) doesn't seem to be related to my issue. My issue goes away when I unpack new_tags before loading it to ret['changes'], I'm having this issue with both approaches of defining the tags in sls. I think the failing test actually expects to have the values in set thought, which breaks states for me"}}