{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/54","id":68662497,"html_url":"https://github.com/sendgridlabs/go-kinesis/pull/54","diff_url":"https://github.com/sendgridlabs/go-kinesis/pull/54.diff","patch_url":"https://github.com/sendgridlabs/go-kinesis/pull/54.patch","issue_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues/54","number":54,"state":"closed","locked":false,"title":"[BUG] GetRecordsRecords: ApproximateArrivalTimestamp is float, not int","user":{"login":"ceralena","id":615299,"avatar_url":"https://avatars.githubusercontent.com/u/615299?v=3","gravatar_id":"","url":"https://api.github.com/users/ceralena","html_url":"https://github.com/ceralena","followers_url":"https://api.github.com/users/ceralena/followers","following_url":"https://api.github.com/users/ceralena/following{/other_user}","gists_url":"https://api.github.com/users/ceralena/gists{/gist_id}","starred_url":"https://api.github.com/users/ceralena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceralena/subscriptions","organizations_url":"https://api.github.com/users/ceralena/orgs","repos_url":"https://api.github.com/users/ceralena/repos","events_url":"https://api.github.com/users/ceralena/events{/privacy}","received_events_url":"https://api.github.com/users/ceralena/received_events","type":"User","site_admin":false},"body":"Unfortunately the change in #53 was not correct - this value is a float, not an `int`. I was misled by the docs phrasing it this way:\r\n\r\n> The timestamp has millisecond precision.\r\n\r\nThis seems to mean that it's a second, with the three decimal points representing the milliseconds.\r\n\r\nI assume the reason it was still passing tests is that `kinesalite` doesn't set the value at all, so it wasn't failing?","created_at":"2016-05-03T06:23:44Z","updated_at":"2016-05-03T15:44:02Z","closed_at":"2016-05-03T15:44:02Z","merged_at":"2016-05-03T15:44:02Z","merge_commit_sha":"b0e552a08e9a4c60d68fbcf5fc436bc1c782ede2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/54/commits","review_comments_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/54/comments","review_comment_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues/54/comments","statuses_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/statuses/4f46b80aee4d9c42113d48c4872d35e4ddfcfdb7","head":{"label":"Learnosity:master","ref":"master","sha":"4f46b80aee4d9c42113d48c4872d35e4ddfcfdb7","user":{"login":"Learnosity","id":1028818,"avatar_url":"https://avatars.githubusercontent.com/u/1028818?v=3","gravatar_id":"","url":"https://api.github.com/users/Learnosity","html_url":"https://github.com/Learnosity","followers_url":"https://api.github.com/users/Learnosity/followers","following_url":"https://api.github.com/users/Learnosity/following{/other_user}","gists_url":"https://api.github.com/users/Learnosity/gists{/gist_id}","starred_url":"https://api.github.com/users/Learnosity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Learnosity/subscriptions","organizations_url":"https://api.github.com/users/Learnosity/orgs","repos_url":"https://api.github.com/users/Learnosity/repos","events_url":"https://api.github.com/users/Learnosity/events{/privacy}","received_events_url":"https://api.github.com/users/Learnosity/received_events","type":"Organization","site_admin":false},"repo":{"id":51277562,"name":"go-kinesis","full_name":"Learnosity/go-kinesis","owner":{"login":"Learnosity","id":1028818,"avatar_url":"https://avatars.githubusercontent.com/u/1028818?v=3","gravatar_id":"","url":"https://api.github.com/users/Learnosity","html_url":"https://github.com/Learnosity","followers_url":"https://api.github.com/users/Learnosity/followers","following_url":"https://api.github.com/users/Learnosity/following{/other_user}","gists_url":"https://api.github.com/users/Learnosity/gists{/gist_id}","starred_url":"https://api.github.com/users/Learnosity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Learnosity/subscriptions","organizations_url":"https://api.github.com/users/Learnosity/orgs","repos_url":"https://api.github.com/users/Learnosity/repos","events_url":"https://api.github.com/users/Learnosity/events{/privacy}","received_events_url":"https://api.github.com/users/Learnosity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Learnosity/go-kinesis","description":"GO library for AWS Kinesis","fork":true,"url":"https://api.github.com/repos/Learnosity/go-kinesis","forks_url":"https://api.github.com/repos/Learnosity/go-kinesis/forks","keys_url":"https://api.github.com/repos/Learnosity/go-kinesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Learnosity/go-kinesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Learnosity/go-kinesis/teams","hooks_url":"https://api.github.com/repos/Learnosity/go-kinesis/hooks","issue_events_url":"https://api.github.com/repos/Learnosity/go-kinesis/issues/events{/number}","events_url":"https://api.github.com/repos/Learnosity/go-kinesis/events","assignees_url":"https://api.github.com/repos/Learnosity/go-kinesis/assignees{/user}","branches_url":"https://api.github.com/repos/Learnosity/go-kinesis/branches{/branch}","tags_url":"https://api.github.com/repos/Learnosity/go-kinesis/tags","blobs_url":"https://api.github.com/repos/Learnosity/go-kinesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Learnosity/go-kinesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Learnosity/go-kinesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Learnosity/go-kinesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Learnosity/go-kinesis/statuses/{sha}","languages_url":"https://api.github.com/repos/Learnosity/go-kinesis/languages","stargazers_url":"https://api.github.com/repos/Learnosity/go-kinesis/stargazers","contributors_url":"https://api.github.com/repos/Learnosity/go-kinesis/contributors","subscribers_url":"https://api.github.com/repos/Learnosity/go-kinesis/subscribers","subscription_url":"https://api.github.com/repos/Learnosity/go-kinesis/subscription","commits_url":"https://api.github.com/repos/Learnosity/go-kinesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Learnosity/go-kinesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Learnosity/go-kinesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Learnosity/go-kinesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Learnosity/go-kinesis/contents/{+path}","compare_url":"https://api.github.com/repos/Learnosity/go-kinesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Learnosity/go-kinesis/merges","archive_url":"https://api.github.com/repos/Learnosity/go-kinesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Learnosity/go-kinesis/downloads","issues_url":"https://api.github.com/repos/Learnosity/go-kinesis/issues{/number}","pulls_url":"https://api.github.com/repos/Learnosity/go-kinesis/pulls{/number}","milestones_url":"https://api.github.com/repos/Learnosity/go-kinesis/milestones{/number}","notifications_url":"https://api.github.com/repos/Learnosity/go-kinesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Learnosity/go-kinesis/labels{/name}","releases_url":"https://api.github.com/repos/Learnosity/go-kinesis/releases{/id}","deployments_url":"https://api.github.com/repos/Learnosity/go-kinesis/deployments","created_at":"2016-02-08T03:30:37Z","updated_at":"2016-02-08T03:30:38Z","pushed_at":"2016-05-03T06:21:31Z","git_url":"git://github.com/Learnosity/go-kinesis.git","ssh_url":"git@github.com:Learnosity/go-kinesis.git","clone_url":"https://github.com/Learnosity/go-kinesis.git","svn_url":"https://github.com/Learnosity/go-kinesis","homepage":null,"size":126,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sendgridlabs:master","ref":"master","sha":"c2687ac18c1a9a3e37c0fb66340e6e8d1fd69faa","user":{"login":"sendgridlabs","id":1581830,"avatar_url":"https://avatars.githubusercontent.com/u/1581830?v=3","gravatar_id":"","url":"https://api.github.com/users/sendgridlabs","html_url":"https://github.com/sendgridlabs","followers_url":"https://api.github.com/users/sendgridlabs/followers","following_url":"https://api.github.com/users/sendgridlabs/following{/other_user}","gists_url":"https://api.github.com/users/sendgridlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgridlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgridlabs/subscriptions","organizations_url":"https://api.github.com/users/sendgridlabs/orgs","repos_url":"https://api.github.com/users/sendgridlabs/repos","events_url":"https://api.github.com/users/sendgridlabs/events{/privacy}","received_events_url":"https://api.github.com/users/sendgridlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":14756156,"name":"go-kinesis","full_name":"sendgridlabs/go-kinesis","owner":{"login":"sendgridlabs","id":1581830,"avatar_url":"https://avatars.githubusercontent.com/u/1581830?v=3","gravatar_id":"","url":"https://api.github.com/users/sendgridlabs","html_url":"https://github.com/sendgridlabs","followers_url":"https://api.github.com/users/sendgridlabs/followers","following_url":"https://api.github.com/users/sendgridlabs/following{/other_user}","gists_url":"https://api.github.com/users/sendgridlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgridlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgridlabs/subscriptions","organizations_url":"https://api.github.com/users/sendgridlabs/orgs","repos_url":"https://api.github.com/users/sendgridlabs/repos","events_url":"https://api.github.com/users/sendgridlabs/events{/privacy}","received_events_url":"https://api.github.com/users/sendgridlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sendgridlabs/go-kinesis","description":"GO library for AWS Kinesis","fork":false,"url":"https://api.github.com/repos/sendgridlabs/go-kinesis","forks_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/forks","keys_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/teams","hooks_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/hooks","issue_events_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues/events{/number}","events_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/events","assignees_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/assignees{/user}","branches_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/branches{/branch}","tags_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/tags","blobs_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/git/refs{/sha}","trees_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/statuses/{sha}","languages_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/languages","stargazers_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/stargazers","contributors_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/contributors","subscribers_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/subscribers","subscription_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/subscription","commits_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/commits{/sha}","git_commits_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/git/commits{/sha}","comments_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/comments{/number}","issue_comment_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues/comments{/number}","contents_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/contents/{+path}","compare_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/merges","archive_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/downloads","issues_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues{/number}","pulls_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls{/number}","milestones_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/milestones{/number}","notifications_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/labels{/name}","releases_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/releases{/id}","deployments_url":"https://api.github.com/repos/sendgridlabs/go-kinesis/deployments","created_at":"2013-11-27T18:59:11Z","updated_at":"2016-05-01T18:05:52Z","pushed_at":"2016-05-03T15:44:02Z","git_url":"git://github.com/sendgridlabs/go-kinesis.git","ssh_url":"git@github.com:sendgridlabs/go-kinesis.git","clone_url":"https://github.com/sendgridlabs/go-kinesis.git","svn_url":"https://github.com/sendgridlabs/go-kinesis","homepage":null,"size":132,"stargazers_count":73,"watchers_count":73,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":6,"forks":34,"open_issues":6,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/54"},"html":{"href":"https://github.com/sendgridlabs/go-kinesis/pull/54"},"issue":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues/54"},"comments":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/sendgridlabs/go-kinesis/statuses/4f46b80aee4d9c42113d48c4872d35e4ddfcfdb7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"le0pard","id":98444,"avatar_url":"https://avatars.githubusercontent.com/u/98444?v=3","gravatar_id":"","url":"https://api.github.com/users/le0pard","html_url":"https://github.com/le0pard","followers_url":"https://api.github.com/users/le0pard/followers","following_url":"https://api.github.com/users/le0pard/following{/other_user}","gists_url":"https://api.github.com/users/le0pard/gists{/gist_id}","starred_url":"https://api.github.com/users/le0pard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/le0pard/subscriptions","organizations_url":"https://api.github.com/users/le0pard/orgs","repos_url":"https://api.github.com/users/le0pard/repos","events_url":"https://api.github.com/users/le0pard/events{/privacy}","received_events_url":"https://api.github.com/users/le0pard/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}