{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/94278996","pull_request_review_id":14808711,"id":94278996,"diff_hunk":"@@ -142,8 +142,16 @@ private void logIntermediateRendererListForDebugging(List<Node> orderedNodes) {\n                     // will bind another FBO.\n                     for (StateChange currentStateReset : node.getDesiredStateResets()) {\n                         if (sameClassStateChangeNotFoundInThe(nextEnabledNode, currentStateReset)) {\n-                            taskList.add(currentStateReset.generateTask());\n-                            persistentStateChanges.remove(currentStateReset.getClass());\n+                            persistentStateChange = persistentStateChanges.get(currentStateReset.getClass());\n+\n+                            // A reset state change is necessary only if an identical state change isn't already persisting.\n+                            if (persistentStateChange == null || !currentStateReset.equals(persistentStateChange)) {\n+                                taskList.add(currentStateReset.generateTask());\n+\n+                                // This makes sure that the reset state change persists so that future state changes\n+                                // which are identical to the reset state change are not added.\n+                                persistentStateChanges.put(currentStateReset.getClass(), currentStateReset);\n+                            }","path":"engine/src/main/java/org/terasology/rendering/dag/RenderTaskListGenerator.java","position":33,"original_position":33,"commit_id":"47db88907ec0937dfb232264b6a8290c222bf69a","original_commit_id":"47db88907ec0937dfb232264b6a8290c222bf69a","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"body":"All good, thank you.","created_at":"2017-01-01T00:21:22Z","updated_at":"2017-01-01T00:25:04Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2702#discussion_r94278996","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/94278996"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2702#discussion_r94278996"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702","id":99307971,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2702","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2702.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2702.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2702","number":2702,"state":"open","locked":false,"title":"Use dimensions instead to compare SetViewportSizeOf instances","user":{"login":"eviltak","id":8018181,"avatar_url":"https://avatars.githubusercontent.com/u/8018181?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltak","html_url":"https://github.com/eviltak","followers_url":"https://api.github.com/users/eviltak/followers","following_url":"https://api.github.com/users/eviltak/following{/other_user}","gists_url":"https://api.github.com/users/eviltak/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltak/subscriptions","organizations_url":"https://api.github.com/users/eviltak/orgs","repos_url":"https://api.github.com/users/eviltak/repos","events_url":"https://api.github.com/users/eviltak/events{/privacy}","received_events_url":"https://api.github.com/users/eviltak/received_events","type":"User","site_admin":false},"body":"Fixes #2688. \r\n","created_at":"2016-12-24T17:33:31Z","updated_at":"2017-01-01T00:25:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb6c1f511a41bbf144b06ffad1b50d5209c1c4ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2702/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/47db88907ec0937dfb232264b6a8290c222bf69a","head":{"label":"eviltak:issue-2688","ref":"issue-2688","sha":"47db88907ec0937dfb232264b6a8290c222bf69a","user":{"login":"eviltak","id":8018181,"avatar_url":"https://avatars.githubusercontent.com/u/8018181?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltak","html_url":"https://github.com/eviltak","followers_url":"https://api.github.com/users/eviltak/followers","following_url":"https://api.github.com/users/eviltak/following{/other_user}","gists_url":"https://api.github.com/users/eviltak/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltak/subscriptions","organizations_url":"https://api.github.com/users/eviltak/orgs","repos_url":"https://api.github.com/users/eviltak/repos","events_url":"https://api.github.com/users/eviltak/events{/privacy}","received_events_url":"https://api.github.com/users/eviltak/received_events","type":"User","site_admin":false},"repo":{"id":75466839,"name":"Terasology","full_name":"eviltak/Terasology","owner":{"login":"eviltak","id":8018181,"avatar_url":"https://avatars.githubusercontent.com/u/8018181?v=3","gravatar_id":"","url":"https://api.github.com/users/eviltak","html_url":"https://github.com/eviltak","followers_url":"https://api.github.com/users/eviltak/followers","following_url":"https://api.github.com/users/eviltak/following{/other_user}","gists_url":"https://api.github.com/users/eviltak/gists{/gist_id}","starred_url":"https://api.github.com/users/eviltak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviltak/subscriptions","organizations_url":"https://api.github.com/users/eviltak/orgs","repos_url":"https://api.github.com/users/eviltak/repos","events_url":"https://api.github.com/users/eviltak/events{/privacy}","received_events_url":"https://api.github.com/users/eviltak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eviltak/Terasology","description":"Terasology - open source voxel world","fork":true,"url":"https://api.github.com/repos/eviltak/Terasology","forks_url":"https://api.github.com/repos/eviltak/Terasology/forks","keys_url":"https://api.github.com/repos/eviltak/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eviltak/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eviltak/Terasology/teams","hooks_url":"https://api.github.com/repos/eviltak/Terasology/hooks","issue_events_url":"https://api.github.com/repos/eviltak/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/eviltak/Terasology/events","assignees_url":"https://api.github.com/repos/eviltak/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/eviltak/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/eviltak/Terasology/tags","blobs_url":"https://api.github.com/repos/eviltak/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eviltak/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eviltak/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/eviltak/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eviltak/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/eviltak/Terasology/languages","stargazers_url":"https://api.github.com/repos/eviltak/Terasology/stargazers","contributors_url":"https://api.github.com/repos/eviltak/Terasology/contributors","subscribers_url":"https://api.github.com/repos/eviltak/Terasology/subscribers","subscription_url":"https://api.github.com/repos/eviltak/Terasology/subscription","commits_url":"https://api.github.com/repos/eviltak/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/eviltak/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/eviltak/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/eviltak/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/eviltak/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/eviltak/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eviltak/Terasology/merges","archive_url":"https://api.github.com/repos/eviltak/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eviltak/Terasology/downloads","issues_url":"https://api.github.com/repos/eviltak/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/eviltak/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/eviltak/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/eviltak/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eviltak/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/eviltak/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/eviltak/Terasology/deployments","created_at":"2016-12-03T10:19:18Z","updated_at":"2016-12-03T10:19:29Z","pushed_at":"2016-12-30T08:56:10Z","git_url":"git://github.com/eviltak/Terasology.git","ssh_url":"git@github.com:eviltak/Terasology.git","clone_url":"https://github.com/eviltak/Terasology.git","svn_url":"https://github.com/eviltak/Terasology","homepage":"http://terasology.org","size":276945,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"fb54a41fa9fc52f34beff3dbcfc60ba3737b5e60","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2016-12-31T04:04:25Z","pushed_at":"2016-12-31T15:51:37Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":277021,"stargazers_count":1803,"watchers_count":1803,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":797,"mirror_url":null,"open_issues_count":350,"forks":797,"open_issues":350,"watchers":1803,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2702"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2702"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2702/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2702/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/47db88907ec0937dfb232264b6a8290c222bf69a"}}}}
{"actor":{"display_login":"emanuele3d"}}