{"action":"closed","number":4363,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4363","id":96459704,"html_url":"https://github.com/RobotLocomotion/drake/pull/4363","diff_url":"https://github.com/RobotLocomotion/drake/pull/4363.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/4363.patch","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4363","number":4363,"state":"closed","locked":false,"title":"Removes Downward Package Crawling From Parsers","user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"body":"This PR eliminates the \"downward crawling\" that was being done by the parsers as they search for ROS packages. Instead of crawling down the directory tree for the packages, the parsers now crawl up provided the original directory is within `drake-distro`. Alternatively, applications can provide a pre-populated package map. A utility method is provided that populates this map with models in `drake/examples/`. Thus this PR resolves #3435.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/4363)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-12-05T02:16:38Z","updated_at":"2016-12-12T16:15:46Z","closed_at":"2016-12-12T16:15:46Z","merged_at":"2016-12-12T16:15:46Z","merge_commit_sha":"4adb76a5403f819cf0ecfb1c98b6c5864d4040ac","assignee":{"login":"amcastro-tri","id":17601461,"avatar_url":"https://avatars.githubusercontent.com/u/17601461?v=3","gravatar_id":"","url":"https://api.github.com/users/amcastro-tri","html_url":"https://github.com/amcastro-tri","followers_url":"https://api.github.com/users/amcastro-tri/followers","following_url":"https://api.github.com/users/amcastro-tri/following{/other_user}","gists_url":"https://api.github.com/users/amcastro-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/amcastro-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcastro-tri/subscriptions","organizations_url":"https://api.github.com/users/amcastro-tri/orgs","repos_url":"https://api.github.com/users/amcastro-tri/repos","events_url":"https://api.github.com/users/amcastro-tri/events{/privacy}","received_events_url":"https://api.github.com/users/amcastro-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},{"login":"amcastro-tri","id":17601461,"avatar_url":"https://avatars.githubusercontent.com/u/17601461?v=3","gravatar_id":"","url":"https://api.github.com/users/amcastro-tri","html_url":"https://github.com/amcastro-tri","followers_url":"https://api.github.com/users/amcastro-tri/followers","following_url":"https://api.github.com/users/amcastro-tri/following{/other_user}","gists_url":"https://api.github.com/users/amcastro-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/amcastro-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcastro-tri/subscriptions","organizations_url":"https://api.github.com/users/amcastro-tri/orgs","repos_url":"https://api.github.com/users/amcastro-tri/repos","events_url":"https://api.github.com/users/amcastro-tri/events{/privacy}","received_events_url":"https://api.github.com/users/amcastro-tri/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4363/commits","review_comments_url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4363/comments","review_comment_url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/4363/comments","statuses_url":"https://api.github.com/repos/RobotLocomotion/drake/statuses/db7c1a06d7eb410edaa59dab398b2ced565eec5b","head":{"label":"liangfok:feature/remove_crawling","ref":"feature/remove_crawling","sha":"db7c1a06d7eb410edaa59dab398b2ced565eec5b","user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"repo":{"id":50609101,"name":"drake","full_name":"liangfok/drake","owner":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liangfok/drake","description":"A planning, control, and analysis toolbox for nonlinear dynamical systems.  Please see the WIKI for documentation.","fork":true,"url":"https://api.github.com/repos/liangfok/drake","forks_url":"https://api.github.com/repos/liangfok/drake/forks","keys_url":"https://api.github.com/repos/liangfok/drake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liangfok/drake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liangfok/drake/teams","hooks_url":"https://api.github.com/repos/liangfok/drake/hooks","issue_events_url":"https://api.github.com/repos/liangfok/drake/issues/events{/number}","events_url":"https://api.github.com/repos/liangfok/drake/events","assignees_url":"https://api.github.com/repos/liangfok/drake/assignees{/user}","branches_url":"https://api.github.com/repos/liangfok/drake/branches{/branch}","tags_url":"https://api.github.com/repos/liangfok/drake/tags","blobs_url":"https://api.github.com/repos/liangfok/drake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liangfok/drake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liangfok/drake/git/refs{/sha}","trees_url":"https://api.github.com/repos/liangfok/drake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liangfok/drake/statuses/{sha}","languages_url":"https://api.github.com/repos/liangfok/drake/languages","stargazers_url":"https://api.github.com/repos/liangfok/drake/stargazers","contributors_url":"https://api.github.com/repos/liangfok/drake/contributors","subscribers_url":"https://api.github.com/repos/liangfok/drake/subscribers","subscription_url":"https://api.github.com/repos/liangfok/drake/subscription","commits_url":"https://api.github.com/repos/liangfok/drake/commits{/sha}","git_commits_url":"https://api.github.com/repos/liangfok/drake/git/commits{/sha}","comments_url":"https://api.github.com/repos/liangfok/drake/comments{/number}","issue_comment_url":"https://api.github.com/repos/liangfok/drake/issues/comments{/number}","contents_url":"https://api.github.com/repos/liangfok/drake/contents/{+path}","compare_url":"https://api.github.com/repos/liangfok/drake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liangfok/drake/merges","archive_url":"https://api.github.com/repos/liangfok/drake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liangfok/drake/downloads","issues_url":"https://api.github.com/repos/liangfok/drake/issues{/number}","pulls_url":"https://api.github.com/repos/liangfok/drake/pulls{/number}","milestones_url":"https://api.github.com/repos/liangfok/drake/milestones{/number}","notifications_url":"https://api.github.com/repos/liangfok/drake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liangfok/drake/labels{/name}","releases_url":"https://api.github.com/repos/liangfok/drake/releases{/id}","deployments_url":"https://api.github.com/repos/liangfok/drake/deployments","created_at":"2016-01-28T19:51:29Z","updated_at":"2016-11-09T22:36:05Z","pushed_at":"2016-12-12T16:15:26Z","git_url":"git://github.com/liangfok/drake.git","ssh_url":"git@github.com:liangfok/drake.git","clone_url":"https://github.com/liangfok/drake.git","svn_url":"https://github.com/liangfok/drake","homepage":"https://github.com/RobotLocomotion/drake/wiki","size":202975,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RobotLocomotion:master","ref":"master","sha":"16b3802abf3cf1d9fb7bda45dbc36ecccfcc19ed","user":{"login":"RobotLocomotion","id":6496345,"avatar_url":"https://avatars.githubusercontent.com/u/6496345?v=3","gravatar_id":"","url":"https://api.github.com/users/RobotLocomotion","html_url":"https://github.com/RobotLocomotion","followers_url":"https://api.github.com/users/RobotLocomotion/followers","following_url":"https://api.github.com/users/RobotLocomotion/following{/other_user}","gists_url":"https://api.github.com/users/RobotLocomotion/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotLocomotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotLocomotion/subscriptions","organizations_url":"https://api.github.com/users/RobotLocomotion/orgs","repos_url":"https://api.github.com/users/RobotLocomotion/repos","events_url":"https://api.github.com/users/RobotLocomotion/events{/privacy}","received_events_url":"https://api.github.com/users/RobotLocomotion/received_events","type":"Organization","site_admin":false},"repo":{"id":16256144,"name":"drake","full_name":"RobotLocomotion/drake","owner":{"login":"RobotLocomotion","id":6496345,"avatar_url":"https://avatars.githubusercontent.com/u/6496345?v=3","gravatar_id":"","url":"https://api.github.com/users/RobotLocomotion","html_url":"https://github.com/RobotLocomotion","followers_url":"https://api.github.com/users/RobotLocomotion/followers","following_url":"https://api.github.com/users/RobotLocomotion/following{/other_user}","gists_url":"https://api.github.com/users/RobotLocomotion/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotLocomotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotLocomotion/subscriptions","organizations_url":"https://api.github.com/users/RobotLocomotion/orgs","repos_url":"https://api.github.com/users/RobotLocomotion/repos","events_url":"https://api.github.com/users/RobotLocomotion/events{/privacy}","received_events_url":"https://api.github.com/users/RobotLocomotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RobotLocomotion/drake","description":"A planning, control, and analysis toolbox for nonlinear dynamical systems.  More info at","fork":false,"url":"https://api.github.com/repos/RobotLocomotion/drake","forks_url":"https://api.github.com/repos/RobotLocomotion/drake/forks","keys_url":"https://api.github.com/repos/RobotLocomotion/drake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobotLocomotion/drake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobotLocomotion/drake/teams","hooks_url":"https://api.github.com/repos/RobotLocomotion/drake/hooks","issue_events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/events{/number}","events_url":"https://api.github.com/repos/RobotLocomotion/drake/events","assignees_url":"https://api.github.com/repos/RobotLocomotion/drake/assignees{/user}","branches_url":"https://api.github.com/repos/RobotLocomotion/drake/branches{/branch}","tags_url":"https://api.github.com/repos/RobotLocomotion/drake/tags","blobs_url":"https://api.github.com/repos/RobotLocomotion/drake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobotLocomotion/drake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobotLocomotion/drake/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobotLocomotion/drake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobotLocomotion/drake/statuses/{sha}","languages_url":"https://api.github.com/repos/RobotLocomotion/drake/languages","stargazers_url":"https://api.github.com/repos/RobotLocomotion/drake/stargazers","contributors_url":"https://api.github.com/repos/RobotLocomotion/drake/contributors","subscribers_url":"https://api.github.com/repos/RobotLocomotion/drake/subscribers","subscription_url":"https://api.github.com/repos/RobotLocomotion/drake/subscription","commits_url":"https://api.github.com/repos/RobotLocomotion/drake/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobotLocomotion/drake/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobotLocomotion/drake/contents/{+path}","compare_url":"https://api.github.com/repos/RobotLocomotion/drake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobotLocomotion/drake/merges","archive_url":"https://api.github.com/repos/RobotLocomotion/drake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobotLocomotion/drake/downloads","issues_url":"https://api.github.com/repos/RobotLocomotion/drake/issues{/number}","pulls_url":"https://api.github.com/repos/RobotLocomotion/drake/pulls{/number}","milestones_url":"https://api.github.com/repos/RobotLocomotion/drake/milestones{/number}","notifications_url":"https://api.github.com/repos/RobotLocomotion/drake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/labels{/name}","releases_url":"https://api.github.com/repos/RobotLocomotion/drake/releases{/id}","deployments_url":"https://api.github.com/repos/RobotLocomotion/drake/deployments","created_at":"2014-01-26T16:11:05Z","updated_at":"2016-12-12T08:26:11Z","pushed_at":"2016-12-12T16:15:46Z","git_url":"git://github.com/RobotLocomotion/drake.git","ssh_url":"git@github.com:RobotLocomotion/drake.git","clone_url":"https://github.com/RobotLocomotion/drake.git","svn_url":"https://github.com/RobotLocomotion/drake","homepage":"http://drake.mit.edu","size":329563,"stargazers_count":546,"watchers_count":546,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":344,"mirror_url":null,"open_issues_count":495,"forks":344,"open_issues":495,"watchers":546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4363"},"html":{"href":"https://github.com/RobotLocomotion/drake/pull/4363"},"issue":{"href":"https://api.github.com/repos/RobotLocomotion/drake/issues/4363"},"comments":{"href":"https://api.github.com/repos/RobotLocomotion/drake/issues/4363/comments"},"review_comments":{"href":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4363/comments"},"review_comment":{"href":"https://api.github.com/repos/RobotLocomotion/drake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RobotLocomotion/drake/pulls/4363/commits"},"statuses":{"href":"https://api.github.com/repos/RobotLocomotion/drake/statuses/db7c1a06d7eb410edaa59dab398b2ced565eec5b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jwnimmer-tri","id":17596505,"avatar_url":"https://avatars.githubusercontent.com/u/17596505?v=3","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"comments":68,"review_comments":0,"commits":68,"additions":1233,"deletions":553,"changed_files":54}}
{"actor":{"display_login":"jwnimmer-tri"}}