{"action":"created","comment":{"url":"https://api.github.com/repos/ensime/ensime-server/pulls/comments/86675347","pull_request_review_id":7323564,"id":86675347,"diff_hunk":"@@ -211,5 +218,23 @@ private class NotSoSimpleJavaFileObject(\n     simpleName: String,\n     kind: JavaFileObject.Kind\n   ): Boolean = false // this can probably be optimised, but the intended javac use is not clear\n-\n+  override def equals(other: Any): Boolean = this.f match {\n+    case RawFile(rf) => other match {\n+      case p: Path => rf.toString == p.toString\n+      case r: RawFile => rf.toString == r.file.toString\n+      case _ => false\n+    }\n+    case ArchiveFile(p, e) => other match {\n+      case af: ArchiveFile => af.entry.toString == e && af.jar.toFile.toString == p.toFile.toString\n+      case _ => false\n+    }\n+  }\n+  override def hashCode(): Int = f match {","path":"core/src/main/scala/org/ensime/core/javac/JavaCompiler.scala","position":144,"original_position":89,"commit_id":"6ba25c73ba38591b080bc34511b8c387e4576962","original_commit_id":"6ba25c73ba38591b080bc34511b8c387e4576962","user":{"login":"fommil","id":1914041,"avatar_url":"https://avatars.githubusercontent.com/u/1914041?v=3","gravatar_id":"","url":"https://api.github.com/users/fommil","html_url":"https://github.com/fommil","followers_url":"https://api.github.com/users/fommil/followers","following_url":"https://api.github.com/users/fommil/following{/other_user}","gists_url":"https://api.github.com/users/fommil/gists{/gist_id}","starred_url":"https://api.github.com/users/fommil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fommil/subscriptions","organizations_url":"https://api.github.com/users/fommil/orgs","repos_url":"https://api.github.com/users/fommil/repos","events_url":"https://api.github.com/users/fommil/events{/privacy}","received_events_url":"https://api.github.com/users/fommil/received_events","type":"User","site_admin":false},"body":"no need to pattern match","created_at":"2016-11-05T23:25:29Z","updated_at":"2016-11-05T23:25:29Z","html_url":"https://github.com/ensime/ensime-server/pull/1637#discussion_r86675347","pull_request_url":"https://api.github.com/repos/ensime/ensime-server/pulls/1637","_links":{"self":{"href":"https://api.github.com/repos/ensime/ensime-server/pulls/comments/86675347"},"html":{"href":"https://github.com/ensime/ensime-server/pull/1637#discussion_r86675347"},"pull_request":{"href":"https://api.github.com/repos/ensime/ensime-server/pulls/1637"}}},"pull_request":{"url":"https://api.github.com/repos/ensime/ensime-server/pulls/1637","id":92265052,"html_url":"https://github.com/ensime/ensime-server/pull/1637","diff_url":"https://github.com/ensime/ensime-server/pull/1637.diff","patch_url":"https://github.com/ensime/ensime-server/pull/1637.patch","issue_url":"https://api.github.com/repos/ensime/ensime-server/issues/1637","number":1637,"state":"open","locked":false,"title":"Jar urls","user":{"login":"hardmettle","id":1940869,"avatar_url":"https://avatars.githubusercontent.com/u/1940869?v=3","gravatar_id":"","url":"https://api.github.com/users/hardmettle","html_url":"https://github.com/hardmettle","followers_url":"https://api.github.com/users/hardmettle/followers","following_url":"https://api.github.com/users/hardmettle/following{/other_user}","gists_url":"https://api.github.com/users/hardmettle/gists{/gist_id}","starred_url":"https://api.github.com/users/hardmettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardmettle/subscriptions","organizations_url":"https://api.github.com/users/hardmettle/orgs","repos_url":"https://api.github.com/users/hardmettle/repos","events_url":"https://api.github.com/users/hardmettle/events{/privacy}","received_events_url":"https://api.github.com/users/hardmettle/received_events","type":"User","site_admin":false},"body":"@fommil Finally did the right way . Please take a look .","created_at":"2016-11-04T00:22:41Z","updated_at":"2016-11-05T23:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32ed6c153bcf8693919d610b0b2c751a2fce9892","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ensime/ensime-server/pulls/1637/commits","review_comments_url":"https://api.github.com/repos/ensime/ensime-server/pulls/1637/comments","review_comment_url":"https://api.github.com/repos/ensime/ensime-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ensime/ensime-server/issues/1637/comments","statuses_url":"https://api.github.com/repos/ensime/ensime-server/statuses/6ba25c73ba38591b080bc34511b8c387e4576962","head":{"label":"hardmettle:jar-urls","ref":"jar-urls","sha":"6ba25c73ba38591b080bc34511b8c387e4576962","user":{"login":"hardmettle","id":1940869,"avatar_url":"https://avatars.githubusercontent.com/u/1940869?v=3","gravatar_id":"","url":"https://api.github.com/users/hardmettle","html_url":"https://github.com/hardmettle","followers_url":"https://api.github.com/users/hardmettle/followers","following_url":"https://api.github.com/users/hardmettle/following{/other_user}","gists_url":"https://api.github.com/users/hardmettle/gists{/gist_id}","starred_url":"https://api.github.com/users/hardmettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardmettle/subscriptions","organizations_url":"https://api.github.com/users/hardmettle/orgs","repos_url":"https://api.github.com/users/hardmettle/repos","events_url":"https://api.github.com/users/hardmettle/events{/privacy}","received_events_url":"https://api.github.com/users/hardmettle/received_events","type":"User","site_admin":false},"repo":{"id":60905702,"name":"ensime-server","full_name":"hardmettle/ensime-server","owner":{"login":"hardmettle","id":1940869,"avatar_url":"https://avatars.githubusercontent.com/u/1940869?v=3","gravatar_id":"","url":"https://api.github.com/users/hardmettle","html_url":"https://github.com/hardmettle","followers_url":"https://api.github.com/users/hardmettle/followers","following_url":"https://api.github.com/users/hardmettle/following{/other_user}","gists_url":"https://api.github.com/users/hardmettle/gists{/gist_id}","starred_url":"https://api.github.com/users/hardmettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardmettle/subscriptions","organizations_url":"https://api.github.com/users/hardmettle/orgs","repos_url":"https://api.github.com/users/hardmettle/repos","events_url":"https://api.github.com/users/hardmettle/events{/privacy}","received_events_url":"https://api.github.com/users/hardmettle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hardmettle/ensime-server","description":"ENSIME JVM Process","fork":true,"url":"https://api.github.com/repos/hardmettle/ensime-server","forks_url":"https://api.github.com/repos/hardmettle/ensime-server/forks","keys_url":"https://api.github.com/repos/hardmettle/ensime-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hardmettle/ensime-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hardmettle/ensime-server/teams","hooks_url":"https://api.github.com/repos/hardmettle/ensime-server/hooks","issue_events_url":"https://api.github.com/repos/hardmettle/ensime-server/issues/events{/number}","events_url":"https://api.github.com/repos/hardmettle/ensime-server/events","assignees_url":"https://api.github.com/repos/hardmettle/ensime-server/assignees{/user}","branches_url":"https://api.github.com/repos/hardmettle/ensime-server/branches{/branch}","tags_url":"https://api.github.com/repos/hardmettle/ensime-server/tags","blobs_url":"https://api.github.com/repos/hardmettle/ensime-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hardmettle/ensime-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hardmettle/ensime-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hardmettle/ensime-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hardmettle/ensime-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hardmettle/ensime-server/languages","stargazers_url":"https://api.github.com/repos/hardmettle/ensime-server/stargazers","contributors_url":"https://api.github.com/repos/hardmettle/ensime-server/contributors","subscribers_url":"https://api.github.com/repos/hardmettle/ensime-server/subscribers","subscription_url":"https://api.github.com/repos/hardmettle/ensime-server/subscription","commits_url":"https://api.github.com/repos/hardmettle/ensime-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hardmettle/ensime-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hardmettle/ensime-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hardmettle/ensime-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hardmettle/ensime-server/contents/{+path}","compare_url":"https://api.github.com/repos/hardmettle/ensime-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hardmettle/ensime-server/merges","archive_url":"https://api.github.com/repos/hardmettle/ensime-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hardmettle/ensime-server/downloads","issues_url":"https://api.github.com/repos/hardmettle/ensime-server/issues{/number}","pulls_url":"https://api.github.com/repos/hardmettle/ensime-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hardmettle/ensime-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hardmettle/ensime-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hardmettle/ensime-server/labels{/name}","releases_url":"https://api.github.com/repos/hardmettle/ensime-server/releases{/id}","deployments_url":"https://api.github.com/repos/hardmettle/ensime-server/deployments","created_at":"2016-06-11T12:17:37Z","updated_at":"2016-06-11T12:17:39Z","pushed_at":"2016-11-05T23:05:23Z","git_url":"git://github.com/hardmettle/ensime-server.git","ssh_url":"git@github.com:hardmettle/ensime-server.git","clone_url":"https://github.com/hardmettle/ensime-server.git","svn_url":"https://github.com/hardmettle/ensime-server","homepage":"","size":10734,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.0"}},"base":{"label":"ensime:2.0","ref":"2.0","sha":"d03d4b7ed6f3343081fd307a71796343a6b209f0","user":{"login":"ensime","id":5089042,"avatar_url":"https://avatars.githubusercontent.com/u/5089042?v=3","gravatar_id":"","url":"https://api.github.com/users/ensime","html_url":"https://github.com/ensime","followers_url":"https://api.github.com/users/ensime/followers","following_url":"https://api.github.com/users/ensime/following{/other_user}","gists_url":"https://api.github.com/users/ensime/gists{/gist_id}","starred_url":"https://api.github.com/users/ensime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ensime/subscriptions","organizations_url":"https://api.github.com/users/ensime/orgs","repos_url":"https://api.github.com/users/ensime/repos","events_url":"https://api.github.com/users/ensime/events{/privacy}","received_events_url":"https://api.github.com/users/ensime/received_events","type":"Organization","site_admin":false},"repo":{"id":578384,"name":"ensime-server","full_name":"ensime/ensime-server","owner":{"login":"ensime","id":5089042,"avatar_url":"https://avatars.githubusercontent.com/u/5089042?v=3","gravatar_id":"","url":"https://api.github.com/users/ensime","html_url":"https://github.com/ensime","followers_url":"https://api.github.com/users/ensime/followers","following_url":"https://api.github.com/users/ensime/following{/other_user}","gists_url":"https://api.github.com/users/ensime/gists{/gist_id}","starred_url":"https://api.github.com/users/ensime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ensime/subscriptions","organizations_url":"https://api.github.com/users/ensime/orgs","repos_url":"https://api.github.com/users/ensime/repos","events_url":"https://api.github.com/users/ensime/events{/privacy}","received_events_url":"https://api.github.com/users/ensime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ensime/ensime-server","description":"ENSIME JVM Process","fork":false,"url":"https://api.github.com/repos/ensime/ensime-server","forks_url":"https://api.github.com/repos/ensime/ensime-server/forks","keys_url":"https://api.github.com/repos/ensime/ensime-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ensime/ensime-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ensime/ensime-server/teams","hooks_url":"https://api.github.com/repos/ensime/ensime-server/hooks","issue_events_url":"https://api.github.com/repos/ensime/ensime-server/issues/events{/number}","events_url":"https://api.github.com/repos/ensime/ensime-server/events","assignees_url":"https://api.github.com/repos/ensime/ensime-server/assignees{/user}","branches_url":"https://api.github.com/repos/ensime/ensime-server/branches{/branch}","tags_url":"https://api.github.com/repos/ensime/ensime-server/tags","blobs_url":"https://api.github.com/repos/ensime/ensime-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ensime/ensime-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ensime/ensime-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/ensime/ensime-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ensime/ensime-server/statuses/{sha}","languages_url":"https://api.github.com/repos/ensime/ensime-server/languages","stargazers_url":"https://api.github.com/repos/ensime/ensime-server/stargazers","contributors_url":"https://api.github.com/repos/ensime/ensime-server/contributors","subscribers_url":"https://api.github.com/repos/ensime/ensime-server/subscribers","subscription_url":"https://api.github.com/repos/ensime/ensime-server/subscription","commits_url":"https://api.github.com/repos/ensime/ensime-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/ensime/ensime-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/ensime/ensime-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/ensime/ensime-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/ensime/ensime-server/contents/{+path}","compare_url":"https://api.github.com/repos/ensime/ensime-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ensime/ensime-server/merges","archive_url":"https://api.github.com/repos/ensime/ensime-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ensime/ensime-server/downloads","issues_url":"https://api.github.com/repos/ensime/ensime-server/issues{/number}","pulls_url":"https://api.github.com/repos/ensime/ensime-server/pulls{/number}","milestones_url":"https://api.github.com/repos/ensime/ensime-server/milestones{/number}","notifications_url":"https://api.github.com/repos/ensime/ensime-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ensime/ensime-server/labels{/name}","releases_url":"https://api.github.com/repos/ensime/ensime-server/releases{/id}","deployments_url":"https://api.github.com/repos/ensime/ensime-server/deployments","created_at":"2010-03-25T00:57:54Z","updated_at":"2016-10-31T13:47:14Z","pushed_at":"2016-11-05T23:20:03Z","git_url":"git://github.com/ensime/ensime-server.git","ssh_url":"git@github.com:ensime/ensime-server.git","clone_url":"https://github.com/ensime/ensime-server.git","svn_url":"https://github.com/ensime/ensime-server","homepage":"","size":72330,"stargazers_count":1090,"watchers_count":1090,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":94,"forks":252,"open_issues":94,"watchers":1090,"default_branch":"2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/ensime/ensime-server/pulls/1637"},"html":{"href":"https://github.com/ensime/ensime-server/pull/1637"},"issue":{"href":"https://api.github.com/repos/ensime/ensime-server/issues/1637"},"comments":{"href":"https://api.github.com/repos/ensime/ensime-server/issues/1637/comments"},"review_comments":{"href":"https://api.github.com/repos/ensime/ensime-server/pulls/1637/comments"},"review_comment":{"href":"https://api.github.com/repos/ensime/ensime-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ensime/ensime-server/pulls/1637/commits"},"statuses":{"href":"https://api.github.com/repos/ensime/ensime-server/statuses/6ba25c73ba38591b080bc34511b8c387e4576962"}}}}
{"actor":{"display_login":"fommil"}}