{"action":"created","comment":{"url":"https://api.github.com/repos/nguy/artview/pulls/comments/51499443","id":51499443,"diff_hunk":"@@ -258,40 +266,91 @@ def AdvanceFileSelect(self, findex):\n             return\n         self.fileindex = findex\n         self.filename = self.Vfilelist.value[findex]\n-        self.menu._openfile(filename=self.filename)\n-        self._update_InfoUI()\n+        self._openfile(self.filename)\n \n     def goto_first_file(self):\n         self.fileindex = 0\n         self.AdvanceFileSelect(self.fileindex)\n+        self._update_tools()\n \n     def goto_last_file(self):\n         self.fileindex = len(self.Vfilelist.value) - 1\n         self.AdvanceFileSelect(self.fileindex)\n+        self._update_tools()\n \n     def goto_prev_file(self):\n         self.fileindex = self.fileindex - 1\n-        self.act_prev.setToolTip(\n-            'Previous file: %s'%os.path.basename(self.Vfilelist.value[self.fileindex - 1]))\n-        self.act_next.setToolTip(\n-            'Next file: %s'%os.path.basename(self.Vfilelist.value[self.fileindex + 1]))\n         self.AdvanceFileSelect(self.fileindex)\n+        self._update_tools()\n \n     def goto_next_file(self):\n         self.fileindex = self.fileindex + 1\n-        self.act_prev.setToolTip(\n-            'Previous file: %s'%os.path.basename(self.Vfilelist.value[self.fileindex - 1]))\n-        self.act_next.setToolTip(\n-            'Next file: %s'%os.path.basename(self.Vfilelist.value[self.fileindex + 1]))\n         self.AdvanceFileSelect(self.fileindex)\n+        self._update_tools()\n \n-    def NewFileList(self, variable, value, strong):\n-        '''respond to change in radar.'''\n-        if self.Vfilelist.value is None:\n+    def _openfile(self, filename=None):\n+        '''Open a file via a file selection window.'''\n+        print(\"Opening file \" + filename)","path":"artview/components/nav.py","position":220,"original_position":220,"commit_id":"9490a38ba35f27fd8d1db17f154e2e5651bc7365","original_commit_id":"9490a38ba35f27fd8d1db17f154e2e5651bc7365","user":{"login":"nguy","id":1863738,"avatar_url":"https://avatars.githubusercontent.com/u/1863738?v=3","gravatar_id":"","url":"https://api.github.com/users/nguy","html_url":"https://github.com/nguy","followers_url":"https://api.github.com/users/nguy/followers","following_url":"https://api.github.com/users/nguy/following{/other_user}","gists_url":"https://api.github.com/users/nguy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguy/subscriptions","organizations_url":"https://api.github.com/users/nguy/orgs","repos_url":"https://api.github.com/users/nguy/repos","events_url":"https://api.github.com/users/nguy/events{/privacy}","received_events_url":"https://api.github.com/users/nguy/received_events","type":"User","site_admin":false},"body":"Okay, gotcha.","created_at":"2016-02-01T23:32:56Z","updated_at":"2016-02-01T23:32:56Z","html_url":"https://github.com/nguy/artview/pull/125#discussion_r51499443","pull_request_url":"https://api.github.com/repos/nguy/artview/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/nguy/artview/pulls/comments/51499443"},"html":{"href":"https://github.com/nguy/artview/pull/125#discussion_r51499443"},"pull_request":{"href":"https://api.github.com/repos/nguy/artview/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/nguy/artview/pulls/125","id":57910682,"html_url":"https://github.com/nguy/artview/pull/125","diff_url":"https://github.com/nguy/artview/pull/125.diff","patch_url":"https://github.com/nguy/artview/pull/125.patch","issue_url":"https://api.github.com/repos/nguy/artview/issues/125","number":125,"state":"open","locked":false,"title":"correct handel of Vfilelist","user":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"body":"Af first I thought it would be just a simple correction, for instance adding NewFilelist to the SharedVariables dict. But I notice there were several small things that needed correction. I will make comments and hope you can figure out were it got it wrong.","created_at":"2016-02-01T22:28:35Z","updated_at":"2016-02-01T23:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b05d4809992233ef782d968fe22dd37d99854a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nguy/artview/pulls/125/commits","review_comments_url":"https://api.github.com/repos/nguy/artview/pulls/125/comments","review_comment_url":"https://api.github.com/repos/nguy/artview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nguy/artview/issues/125/comments","statuses_url":"https://api.github.com/repos/nguy/artview/statuses/9490a38ba35f27fd8d1db17f154e2e5651bc7365","head":{"label":"gamaanderson:ng-menu-update","ref":"ng-menu-update","sha":"9490a38ba35f27fd8d1db17f154e2e5651bc7365","user":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"repo":{"id":34174315,"name":"artview","full_name":"gamaanderson/artview","owner":{"login":"gamaanderson","id":7915525,"avatar_url":"https://avatars.githubusercontent.com/u/7915525?v=3","gravatar_id":"","url":"https://api.github.com/users/gamaanderson","html_url":"https://github.com/gamaanderson","followers_url":"https://api.github.com/users/gamaanderson/followers","following_url":"https://api.github.com/users/gamaanderson/following{/other_user}","gists_url":"https://api.github.com/users/gamaanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/gamaanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamaanderson/subscriptions","organizations_url":"https://api.github.com/users/gamaanderson/orgs","repos_url":"https://api.github.com/users/gamaanderson/repos","events_url":"https://api.github.com/users/gamaanderson/events{/privacy}","received_events_url":"https://api.github.com/users/gamaanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gamaanderson/artview","description":"ARM Radar Toolkit Viewer","fork":true,"url":"https://api.github.com/repos/gamaanderson/artview","forks_url":"https://api.github.com/repos/gamaanderson/artview/forks","keys_url":"https://api.github.com/repos/gamaanderson/artview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamaanderson/artview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamaanderson/artview/teams","hooks_url":"https://api.github.com/repos/gamaanderson/artview/hooks","issue_events_url":"https://api.github.com/repos/gamaanderson/artview/issues/events{/number}","events_url":"https://api.github.com/repos/gamaanderson/artview/events","assignees_url":"https://api.github.com/repos/gamaanderson/artview/assignees{/user}","branches_url":"https://api.github.com/repos/gamaanderson/artview/branches{/branch}","tags_url":"https://api.github.com/repos/gamaanderson/artview/tags","blobs_url":"https://api.github.com/repos/gamaanderson/artview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamaanderson/artview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamaanderson/artview/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamaanderson/artview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamaanderson/artview/statuses/{sha}","languages_url":"https://api.github.com/repos/gamaanderson/artview/languages","stargazers_url":"https://api.github.com/repos/gamaanderson/artview/stargazers","contributors_url":"https://api.github.com/repos/gamaanderson/artview/contributors","subscribers_url":"https://api.github.com/repos/gamaanderson/artview/subscribers","subscription_url":"https://api.github.com/repos/gamaanderson/artview/subscription","commits_url":"https://api.github.com/repos/gamaanderson/artview/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamaanderson/artview/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamaanderson/artview/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamaanderson/artview/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamaanderson/artview/contents/{+path}","compare_url":"https://api.github.com/repos/gamaanderson/artview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamaanderson/artview/merges","archive_url":"https://api.github.com/repos/gamaanderson/artview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamaanderson/artview/downloads","issues_url":"https://api.github.com/repos/gamaanderson/artview/issues{/number}","pulls_url":"https://api.github.com/repos/gamaanderson/artview/pulls{/number}","milestones_url":"https://api.github.com/repos/gamaanderson/artview/milestones{/number}","notifications_url":"https://api.github.com/repos/gamaanderson/artview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamaanderson/artview/labels{/name}","releases_url":"https://api.github.com/repos/gamaanderson/artview/releases{/id}","deployments_url":"https://api.github.com/repos/gamaanderson/artview/deployments","created_at":"2015-04-18T16:58:10Z","updated_at":"2016-01-13T20:32:48Z","pushed_at":"2016-02-01T22:23:46Z","git_url":"git://github.com/gamaanderson/artview.git","ssh_url":"git@github.com:gamaanderson/artview.git","clone_url":"https://github.com/gamaanderson/artview.git","svn_url":"https://github.com/gamaanderson/artview","homepage":null,"size":11354,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nguy:ng-menu-update","ref":"ng-menu-update","sha":"793f91cddfddcee193d06c48030cce7f325f14f7","user":{"login":"nguy","id":1863738,"avatar_url":"https://avatars.githubusercontent.com/u/1863738?v=3","gravatar_id":"","url":"https://api.github.com/users/nguy","html_url":"https://github.com/nguy","followers_url":"https://api.github.com/users/nguy/followers","following_url":"https://api.github.com/users/nguy/following{/other_user}","gists_url":"https://api.github.com/users/nguy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguy/subscriptions","organizations_url":"https://api.github.com/users/nguy/orgs","repos_url":"https://api.github.com/users/nguy/repos","events_url":"https://api.github.com/users/nguy/events{/privacy}","received_events_url":"https://api.github.com/users/nguy/received_events","type":"User","site_admin":false},"repo":{"id":24516568,"name":"artview","full_name":"nguy/artview","owner":{"login":"nguy","id":1863738,"avatar_url":"https://avatars.githubusercontent.com/u/1863738?v=3","gravatar_id":"","url":"https://api.github.com/users/nguy","html_url":"https://github.com/nguy","followers_url":"https://api.github.com/users/nguy/followers","following_url":"https://api.github.com/users/nguy/following{/other_user}","gists_url":"https://api.github.com/users/nguy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguy/subscriptions","organizations_url":"https://api.github.com/users/nguy/orgs","repos_url":"https://api.github.com/users/nguy/repos","events_url":"https://api.github.com/users/nguy/events{/privacy}","received_events_url":"https://api.github.com/users/nguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nguy/artview","description":"ARM Radar Toolkit Viewer","fork":false,"url":"https://api.github.com/repos/nguy/artview","forks_url":"https://api.github.com/repos/nguy/artview/forks","keys_url":"https://api.github.com/repos/nguy/artview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nguy/artview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nguy/artview/teams","hooks_url":"https://api.github.com/repos/nguy/artview/hooks","issue_events_url":"https://api.github.com/repos/nguy/artview/issues/events{/number}","events_url":"https://api.github.com/repos/nguy/artview/events","assignees_url":"https://api.github.com/repos/nguy/artview/assignees{/user}","branches_url":"https://api.github.com/repos/nguy/artview/branches{/branch}","tags_url":"https://api.github.com/repos/nguy/artview/tags","blobs_url":"https://api.github.com/repos/nguy/artview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nguy/artview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nguy/artview/git/refs{/sha}","trees_url":"https://api.github.com/repos/nguy/artview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nguy/artview/statuses/{sha}","languages_url":"https://api.github.com/repos/nguy/artview/languages","stargazers_url":"https://api.github.com/repos/nguy/artview/stargazers","contributors_url":"https://api.github.com/repos/nguy/artview/contributors","subscribers_url":"https://api.github.com/repos/nguy/artview/subscribers","subscription_url":"https://api.github.com/repos/nguy/artview/subscription","commits_url":"https://api.github.com/repos/nguy/artview/commits{/sha}","git_commits_url":"https://api.github.com/repos/nguy/artview/git/commits{/sha}","comments_url":"https://api.github.com/repos/nguy/artview/comments{/number}","issue_comment_url":"https://api.github.com/repos/nguy/artview/issues/comments{/number}","contents_url":"https://api.github.com/repos/nguy/artview/contents/{+path}","compare_url":"https://api.github.com/repos/nguy/artview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nguy/artview/merges","archive_url":"https://api.github.com/repos/nguy/artview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nguy/artview/downloads","issues_url":"https://api.github.com/repos/nguy/artview/issues{/number}","pulls_url":"https://api.github.com/repos/nguy/artview/pulls{/number}","milestones_url":"https://api.github.com/repos/nguy/artview/milestones{/number}","notifications_url":"https://api.github.com/repos/nguy/artview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nguy/artview/labels{/name}","releases_url":"https://api.github.com/repos/nguy/artview/releases{/id}","deployments_url":"https://api.github.com/repos/nguy/artview/deployments","created_at":"2014-09-26T21:53:26Z","updated_at":"2016-01-20T23:32:03Z","pushed_at":"2016-02-01T22:28:35Z","git_url":"git://github.com/nguy/artview.git","ssh_url":"git@github.com:nguy/artview.git","clone_url":"https://github.com/nguy/artview.git","svn_url":"https://github.com/nguy/artview","homepage":null,"size":11412,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":20,"forks":10,"open_issues":20,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nguy/artview/pulls/125"},"html":{"href":"https://github.com/nguy/artview/pull/125"},"issue":{"href":"https://api.github.com/repos/nguy/artview/issues/125"},"comments":{"href":"https://api.github.com/repos/nguy/artview/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/nguy/artview/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/nguy/artview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nguy/artview/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/nguy/artview/statuses/9490a38ba35f27fd8d1db17f154e2e5651bc7365"}}}}