{"action":"created","issue":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/1500","repository_url":"https://api.github.com/repos/danielgindi/Charts","labels_url":"https://api.github.com/repos/danielgindi/Charts/issues/1500/labels{/name}","comments_url":"https://api.github.com/repos/danielgindi/Charts/issues/1500/comments","events_url":"https://api.github.com/repos/danielgindi/Charts/issues/1500/events","html_url":"https://github.com/danielgindi/Charts/issues/1500","id":178050352,"number":1500,"title":"noDataText overflows","user":{"login":"EdwinOtten","id":5310778,"avatar_url":"https://avatars.githubusercontent.com/u/5310778?v=3","gravatar_id":"","url":"https://api.github.com/users/EdwinOtten","html_url":"https://github.com/EdwinOtten","followers_url":"https://api.github.com/users/EdwinOtten/followers","following_url":"https://api.github.com/users/EdwinOtten/following{/other_user}","gists_url":"https://api.github.com/users/EdwinOtten/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwinOtten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwinOtten/subscriptions","organizations_url":"https://api.github.com/users/EdwinOtten/orgs","repos_url":"https://api.github.com/users/EdwinOtten/repos","events_url":"https://api.github.com/users/EdwinOtten/events{/privacy}","received_events_url":"https://api.github.com/users/EdwinOtten/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-20T12:49:45Z","updated_at":"2016-09-20T13:55:14Z","closed_at":"2016-09-20T13:45:08Z","body":"### Issue ###\r\nThe noDataText and noDataTextDescription of the ChartViewBase are centered. When these strings are too long to fit on one line the text simply runs off-screen, as shown in the screenshot below:\r\n\r\n<img src=\"https://cloud.githubusercontent.com/assets/5310778/18667592/884564a8-7f31-11e6-993b-05c460730c7c.png\" width=\"318\">\r\n\r\n\r\n### Cause ###\r\nThe issue is caused by the method used to render the noDataText. In ```/Charts/ChartViewBase.swift``` around line 316 and 328 you can see that ```ChartUtils.drawText()``` is being used, which does not support multiline.\r\n\r\n\r\n### Suggested fix ###\r\nI suggest using ```ChartUtils.drawMultilineText()``` to be able to handle long texts. I already got this working on my fork and will create a pull request referencing this issue. Below you can see an example of this fix:\r\n\r\n<img src=\"https://cloud.githubusercontent.com/assets/5310778/18667598/8c72e276-7f31-11e6-836d-a4589df2950f.png\" width=\"318\">"},"comment":{"url":"https://api.github.com/repos/danielgindi/Charts/issues/comments/248308107","html_url":"https://github.com/danielgindi/Charts/issues/1500#issuecomment-248308107","issue_url":"https://api.github.com/repos/danielgindi/Charts/issues/1500","id":248308107,"user":{"login":"EdwinOtten","id":5310778,"avatar_url":"https://avatars.githubusercontent.com/u/5310778?v=3","gravatar_id":"","url":"https://api.github.com/users/EdwinOtten","html_url":"https://github.com/EdwinOtten","followers_url":"https://api.github.com/users/EdwinOtten/followers","following_url":"https://api.github.com/users/EdwinOtten/following{/other_user}","gists_url":"https://api.github.com/users/EdwinOtten/gists{/gist_id}","starred_url":"https://api.github.com/users/EdwinOtten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdwinOtten/subscriptions","organizations_url":"https://api.github.com/users/EdwinOtten/orgs","repos_url":"https://api.github.com/users/EdwinOtten/repos","events_url":"https://api.github.com/users/EdwinOtten/events{/privacy}","received_events_url":"https://api.github.com/users/EdwinOtten/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T13:55:14Z","updated_at":"2016-09-20T13:55:14Z","body":"For sure! I'm just holding of until the official 3.0 release.\n\nWell.. at least if someone needs the fix specifically on 2.2.5 they can\nfind it here ;-)\n\nOp di 20 sep. 2016 15:45 schreef Daniel Cohen Gindi <\nnotifications@github.com>:\n\n> Closed #1500 <https://github.com/danielgindi/Charts/issues/1500>.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/danielgindi/Charts/issues/1500#event-795665676>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AFEJOj60XmK6bAXfvUD-GCj38KJ7wDyVks5qr-N0gaJpZM4KBlXB>\n> .\n>\n"}}
{"actor":{"display_login":"EdwinOtten"}}