{"push_id":1226570688,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"c3d0bec0475b3ca95d99ba74d88649397b1e14a4","before":"c01e87d24e3344d3ac76e4ebf22fc2584314a4e2","commits":[{"sha":"c3d0bec0475b3ca95d99ba74d88649397b1e14a4","author":{"name":"Charles Marsh","email":"9a65f4850753c7446e0f8a24d00afda8ff2e5285@khanacademy.org"},"message":"Refine button sizing to accurately account for popovers and toolbar\n\nSummary:\nThis diff implements two changes to our button-sizing logic:\n\n1. Rather than always accommodating for the possibility that a popover will extend\n   by one row above the keypad, expose the maximal number of rows (with popovers\n   expanded) that each keypad will span. (This will allow us to gain some real\n   estate, especially for the Expression keypad, which doesn't have a popover in\n   the top row.)\n2. Assume that the bottom toolbar is always visible. We wanted to have the toolbar\n   animate out of view on some form factors, but didn't get around to implementing\n   it.\n\nOn Asana @ https://app.asana.com/0/157213482411363/160437514738956.\n\nTest Plan:\n- Open up the keypad on a bunch of devices.\n    - Confirm that the buttons are slightly larger on all form factors (apart from landscape phones,\n      which now account for the bottom bar).\n\nReviewers: kevinb, jared\n\nReviewed By: kevinb, jared\n\nDifferential Revision: https://phabricator.khanacademy.org/D29446","distinct":true,"url":"https://api.github.com/repos/Khan/math-input/commits/c3d0bec0475b3ca95d99ba74d88649397b1e14a4"}]}
{"actor":{"display_login":"crm416"}}