{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/comments/82696743","pull_request_review_id":3586361,"id":82696743,"diff_hunk":"@@ -89,7 +89,12 @@ def prepend_path_in_shell_profile(path)\n     # cut the actual value of ARG_MAX in half for safety since\n     # environment variables count toward the total\n     def max_command_length\n-      Utils.popen_read(\"/usr/bin/getconf\", \"ARG_MAX\").to_i / 2\n+      Utils.popen_read(\"/usr/bin/getconf\", \"ARG_MAX\").to_i - 2 * environment_variables_length","path":"Library/Homebrew/utils/shell.rb","position":null,"original_position":5,"commit_id":"024f3f76ea95e8c8bbeb04dd70ce7c9e1bad5549","original_commit_id":"026346c3fc24ee16db3c8a14410ba358ac592316","user":{"login":"jawshooah","id":4551271,"avatar_url":"https://avatars.githubusercontent.com/u/4551271?v=3","gravatar_id":"","url":"https://api.github.com/users/jawshooah","html_url":"https://github.com/jawshooah","followers_url":"https://api.github.com/users/jawshooah/followers","following_url":"https://api.github.com/users/jawshooah/following{/other_user}","gists_url":"https://api.github.com/users/jawshooah/gists{/gist_id}","starred_url":"https://api.github.com/users/jawshooah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawshooah/subscriptions","organizations_url":"https://api.github.com/users/jawshooah/orgs","repos_url":"https://api.github.com/users/jawshooah/repos","events_url":"https://api.github.com/users/jawshooah/events{/privacy}","received_events_url":"https://api.github.com/users/jawshooah/received_events","type":"User","site_admin":false},"body":"Nice, I figured there was a reason it felt right to cut it in half!","created_at":"2016-10-10T22:44:20Z","updated_at":"2016-10-10T22:44:20Z","html_url":"https://github.com/Homebrew/brew/pull/1258#discussion_r82696743","pull_request_url":"https://api.github.com/repos/Homebrew/brew/pulls/1258","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments/82696743"},"html":{"href":"https://github.com/Homebrew/brew/pull/1258#discussion_r82696743"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1258"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/1258","id":88723221,"html_url":"https://github.com/Homebrew/brew/pull/1258","diff_url":"https://github.com/Homebrew/brew/pull/1258.diff","patch_url":"https://github.com/Homebrew/brew/pull/1258.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/1258","number":1258,"state":"open","locked":false,"title":"keg_relocate: run /usr/bin/file in batches","user":{"login":"jawshooah","id":4551271,"avatar_url":"https://avatars.githubusercontent.com/u/4551271?v=3","gravatar_id":"","url":"https://api.github.com/users/jawshooah","html_url":"https://github.com/jawshooah","followers_url":"https://api.github.com/users/jawshooah/followers","following_url":"https://api.github.com/users/jawshooah/following{/other_user}","gists_url":"https://api.github.com/users/jawshooah/gists{/gist_id}","starred_url":"https://api.github.com/users/jawshooah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawshooah/subscriptions","organizations_url":"https://api.github.com/users/jawshooah/orgs","repos_url":"https://api.github.com/users/jawshooah/repos","events_url":"https://api.github.com/users/jawshooah/events{/privacy}","received_events_url":"https://api.github.com/users/jawshooah/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nRather than running `/usr/bin/file` on each individual file to determine its type, split all files into batches as large as possible and run `/usr/bin/file` on each batch.\r\n\r\nThis is an alternative solution to #1250 as suggested by @reitermarkus in https://github.com/Homebrew/brew/pull/1253#discussion_r82602685, though the two solutions could be combined.","created_at":"2016-10-10T20:11:00Z","updated_at":"2016-10-10T22:44:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8d660b882189d14f90a3cf73e2f9efa4b0fcafd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/1258/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/1258/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/1258/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/024f3f76ea95e8c8bbeb04dd70ce7c9e1bad5549","head":{"label":"jawshooah:perf/keg-batch-text-files","ref":"perf/keg-batch-text-files","sha":"024f3f76ea95e8c8bbeb04dd70ce7c9e1bad5549","user":{"login":"jawshooah","id":4551271,"avatar_url":"https://avatars.githubusercontent.com/u/4551271?v=3","gravatar_id":"","url":"https://api.github.com/users/jawshooah","html_url":"https://github.com/jawshooah","followers_url":"https://api.github.com/users/jawshooah/followers","following_url":"https://api.github.com/users/jawshooah/following{/other_user}","gists_url":"https://api.github.com/users/jawshooah/gists{/gist_id}","starred_url":"https://api.github.com/users/jawshooah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawshooah/subscriptions","organizations_url":"https://api.github.com/users/jawshooah/orgs","repos_url":"https://api.github.com/users/jawshooah/repos","events_url":"https://api.github.com/users/jawshooah/events{/privacy}","received_events_url":"https://api.github.com/users/jawshooah/received_events","type":"User","site_admin":false},"repo":{"id":56008366,"name":"brew","full_name":"jawshooah/brew","owner":{"login":"jawshooah","id":4551271,"avatar_url":"https://avatars.githubusercontent.com/u/4551271?v=3","gravatar_id":"","url":"https://api.github.com/users/jawshooah","html_url":"https://github.com/jawshooah","followers_url":"https://api.github.com/users/jawshooah/followers","following_url":"https://api.github.com/users/jawshooah/following{/other_user}","gists_url":"https://api.github.com/users/jawshooah/gists{/gist_id}","starred_url":"https://api.github.com/users/jawshooah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jawshooah/subscriptions","organizations_url":"https://api.github.com/users/jawshooah/orgs","repos_url":"https://api.github.com/users/jawshooah/repos","events_url":"https://api.github.com/users/jawshooah/events{/privacy}","received_events_url":"https://api.github.com/users/jawshooah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jawshooah/brew","description":":beer: The missing package manager for OS X","fork":true,"url":"https://api.github.com/repos/jawshooah/brew","forks_url":"https://api.github.com/repos/jawshooah/brew/forks","keys_url":"https://api.github.com/repos/jawshooah/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jawshooah/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jawshooah/brew/teams","hooks_url":"https://api.github.com/repos/jawshooah/brew/hooks","issue_events_url":"https://api.github.com/repos/jawshooah/brew/issues/events{/number}","events_url":"https://api.github.com/repos/jawshooah/brew/events","assignees_url":"https://api.github.com/repos/jawshooah/brew/assignees{/user}","branches_url":"https://api.github.com/repos/jawshooah/brew/branches{/branch}","tags_url":"https://api.github.com/repos/jawshooah/brew/tags","blobs_url":"https://api.github.com/repos/jawshooah/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jawshooah/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jawshooah/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/jawshooah/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jawshooah/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/jawshooah/brew/languages","stargazers_url":"https://api.github.com/repos/jawshooah/brew/stargazers","contributors_url":"https://api.github.com/repos/jawshooah/brew/contributors","subscribers_url":"https://api.github.com/repos/jawshooah/brew/subscribers","subscription_url":"https://api.github.com/repos/jawshooah/brew/subscription","commits_url":"https://api.github.com/repos/jawshooah/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/jawshooah/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/jawshooah/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/jawshooah/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/jawshooah/brew/contents/{+path}","compare_url":"https://api.github.com/repos/jawshooah/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jawshooah/brew/merges","archive_url":"https://api.github.com/repos/jawshooah/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jawshooah/brew/downloads","issues_url":"https://api.github.com/repos/jawshooah/brew/issues{/number}","pulls_url":"https://api.github.com/repos/jawshooah/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/jawshooah/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/jawshooah/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jawshooah/brew/labels{/name}","releases_url":"https://api.github.com/repos/jawshooah/brew/releases{/id}","deployments_url":"https://api.github.com/repos/jawshooah/brew/deployments","created_at":"2016-04-11T21:17:39Z","updated_at":"2016-04-11T21:17:41Z","pushed_at":"2016-10-10T22:33:55Z","git_url":"git://github.com/jawshooah/brew.git","ssh_url":"git@github.com:jawshooah/brew.git","clone_url":"https://github.com/jawshooah/brew.git","svn_url":"https://github.com/jawshooah/brew","homepage":"http://brew.sh","size":17211,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"6be6ce33e0e5967f8e67801875bff6ab3f99b1ef","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":":beer: The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2016-10-10T22:03:46Z","pushed_at":"2016-10-10T22:33:56Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"http://brew.sh","size":18140,"stargazers_count":3957,"watchers_count":3957,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1077,"mirror_url":null,"open_issues_count":50,"forks":1077,"open_issues":50,"watchers":3957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1258"},"html":{"href":"https://github.com/Homebrew/brew/pull/1258"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1258"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/1258/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1258/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/1258/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/024f3f76ea95e8c8bbeb04dd70ce7c9e1bad5549"}}}}
{"actor":{"display_login":"jawshooah"}}