{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/69180866","id":69180866,"diff_hunk":"@@ -0,0 +1,82 @@\n+/*\n+  Copyright (C) 2016 by the authors of the ASPECT code.\n+\n+  This file is part of ASPECT.\n+\n+  ASPECT is free software; you can redistribute it and/or modify\n+  it under the terms of the GNU General Public License as published by\n+  the Free Software Foundation; either version 2, or (at your option)\n+  any later version.\n+\n+  ASPECT is distributed in the hope that it will be useful,\n+  but WITHOUT ANY WARRANTY; without even the implied warranty of\n+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+  GNU General Public License for more details.\n+\n+  You should have received a copy of the GNU General Public License\n+  along with ASPECT; see the file doc/COPYING.  If not see\n+  <http://www.gnu.org/licenses/>.\n+*/\n+\n+\n+#ifndef __aspect__postprocess_visualization_vof_values_h\n+#define __aspect__postprocess_visualization_vof_values_h\n+\n+#include <aspect/postprocess/visualization.h>\n+#include <aspect/simulator_access.h>\n+\n+namespace aspect\n+{\n+  namespace Postprocess\n+  {\n+    namespace VisualizationPostprocessors\n+    {\n+      template <int dim>\n+      class VoFValues","path":"include/aspect/postprocess/visualization/vof_values.h","position":35,"original_position":35,"commit_id":"d6980fbded42d3095dd45fcf40d65c29454fbc6c","original_commit_id":"d6980fbded42d3095dd45fcf40d65c29454fbc6c","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"documentation missing","created_at":"2016-06-30T18:02:43Z","updated_at":"2016-06-30T18:02:43Z","html_url":"https://github.com/geodynamics/aspect/pull/835#discussion_r69180866","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/835","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/69180866"},"html":{"href":"https://github.com/geodynamics/aspect/pull/835#discussion_r69180866"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/835"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/835","id":68400276,"html_url":"https://github.com/geodynamics/aspect/pull/835","diff_url":"https://github.com/geodynamics/aspect/pull/835.diff","patch_url":"https://github.com/geodynamics/aspect/pull/835.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/835","number":835,"state":"open","locked":false,"title":"[WIP] Add VoF Interface tracking","user":{"login":"class4kayaker","id":1050493,"avatar_url":"https://avatars.githubusercontent.com/u/1050493?v=3","gravatar_id":"","url":"https://api.github.com/users/class4kayaker","html_url":"https://github.com/class4kayaker","followers_url":"https://api.github.com/users/class4kayaker/followers","following_url":"https://api.github.com/users/class4kayaker/following{/other_user}","gists_url":"https://api.github.com/users/class4kayaker/gists{/gist_id}","starred_url":"https://api.github.com/users/class4kayaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/class4kayaker/subscriptions","organizations_url":"https://api.github.com/users/class4kayaker/orgs","repos_url":"https://api.github.com/users/class4kayaker/repos","events_url":"https://api.github.com/users/class4kayaker/events{/privacy}","received_events_url":"https://api.github.com/users/class4kayaker/received_events","type":"User","site_admin":false},"body":"This is an implementation of the VoF based interface tracking implemented in #823, modified to link more closely with the main model. Currently the majority of the logic is implemented in the Simulator class due to relative ease of initial implementation. Moving most of these into a separate encapsulating class is planned, though some modification of approach may be necessary. Some of the modifications may be dependent on whether and how the results of the implementation are desired by the main model.\r\n\r\nCurrent features:\r\n- Signed distance Level Set or composition function initialization\r\n- Dimensionally split, explicit update based on computed velocity field (Standard for VoF based methods due to problems from double fluxing induced by geometric flux calculation)\r\n- Creation of internal per cell LS field for the interface reconstruction, primarily useful for visualization of reconstructed interface (left over from considering storing the reconstructed interface as a LS, not currently used for computation)\r\n\r\nCurrent limitations:\r\n- Only functional for 2D\r\n- Can only handle parallelogram meshes\r\n- Cannot handle variations in refinement level\r\n\r\nPlanned improvements:\r\n- Make interface LS data available to MaterialModel (as composition?)\r\n\r\nPossible improvements:\r\n- Couple to level set method\r\n- Reduce computation to narrow band around interface (Probably not worth additional code complexity)","created_at":"2016-04-29T16:44:33Z","updated_at":"2016-06-30T18:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b1d6cdec4993363d8a08d26aa8483ee6f7832a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/835/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/835/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/835/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/d6980fbded42d3095dd45fcf40d65c29454fbc6c","head":{"label":"class4kayaker:vofinterfaceSig","ref":"vofinterfaceSig","sha":"d6980fbded42d3095dd45fcf40d65c29454fbc6c","user":{"login":"class4kayaker","id":1050493,"avatar_url":"https://avatars.githubusercontent.com/u/1050493?v=3","gravatar_id":"","url":"https://api.github.com/users/class4kayaker","html_url":"https://github.com/class4kayaker","followers_url":"https://api.github.com/users/class4kayaker/followers","following_url":"https://api.github.com/users/class4kayaker/following{/other_user}","gists_url":"https://api.github.com/users/class4kayaker/gists{/gist_id}","starred_url":"https://api.github.com/users/class4kayaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/class4kayaker/subscriptions","organizations_url":"https://api.github.com/users/class4kayaker/orgs","repos_url":"https://api.github.com/users/class4kayaker/repos","events_url":"https://api.github.com/users/class4kayaker/events{/privacy}","received_events_url":"https://api.github.com/users/class4kayaker/received_events","type":"User","site_admin":false},"repo":{"id":53872697,"name":"aspect","full_name":"class4kayaker/aspect","owner":{"login":"class4kayaker","id":1050493,"avatar_url":"https://avatars.githubusercontent.com/u/1050493?v=3","gravatar_id":"","url":"https://api.github.com/users/class4kayaker","html_url":"https://github.com/class4kayaker","followers_url":"https://api.github.com/users/class4kayaker/followers","following_url":"https://api.github.com/users/class4kayaker/following{/other_user}","gists_url":"https://api.github.com/users/class4kayaker/gists{/gist_id}","starred_url":"https://api.github.com/users/class4kayaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/class4kayaker/subscriptions","organizations_url":"https://api.github.com/users/class4kayaker/orgs","repos_url":"https://api.github.com/users/class4kayaker/repos","events_url":"https://api.github.com/users/class4kayaker/events{/privacy}","received_events_url":"https://api.github.com/users/class4kayaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/class4kayaker/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/class4kayaker/aspect","forks_url":"https://api.github.com/repos/class4kayaker/aspect/forks","keys_url":"https://api.github.com/repos/class4kayaker/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/class4kayaker/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/class4kayaker/aspect/teams","hooks_url":"https://api.github.com/repos/class4kayaker/aspect/hooks","issue_events_url":"https://api.github.com/repos/class4kayaker/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/class4kayaker/aspect/events","assignees_url":"https://api.github.com/repos/class4kayaker/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/class4kayaker/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/class4kayaker/aspect/tags","blobs_url":"https://api.github.com/repos/class4kayaker/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/class4kayaker/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/class4kayaker/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/class4kayaker/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/class4kayaker/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/class4kayaker/aspect/languages","stargazers_url":"https://api.github.com/repos/class4kayaker/aspect/stargazers","contributors_url":"https://api.github.com/repos/class4kayaker/aspect/contributors","subscribers_url":"https://api.github.com/repos/class4kayaker/aspect/subscribers","subscription_url":"https://api.github.com/repos/class4kayaker/aspect/subscription","commits_url":"https://api.github.com/repos/class4kayaker/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/class4kayaker/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/class4kayaker/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/class4kayaker/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/class4kayaker/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/class4kayaker/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/class4kayaker/aspect/merges","archive_url":"https://api.github.com/repos/class4kayaker/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/class4kayaker/aspect/downloads","issues_url":"https://api.github.com/repos/class4kayaker/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/class4kayaker/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/class4kayaker/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/class4kayaker/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/class4kayaker/aspect/labels{/name}","releases_url":"https://api.github.com/repos/class4kayaker/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/class4kayaker/aspect/deployments","created_at":"2016-03-14T16:28:54Z","updated_at":"2016-03-14T16:29:02Z","pushed_at":"2016-06-29T22:53:30Z","git_url":"git://github.com/class4kayaker/aspect.git","ssh_url":"git@github.com:class4kayaker/aspect.git","clone_url":"https://github.com/class4kayaker/aspect.git","svn_url":"https://github.com/class4kayaker/aspect","homepage":"http://aspect.dealii.org/","size":127725,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"1790d0ae52ba1a2d1c404ccc13eb92351f3b3857","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2016-06-28T02:05:15Z","pushed_at":"2016-06-30T17:22:37Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":142310,"stargazers_count":27,"watchers_count":27,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":145,"forks":57,"open_issues":145,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/835"},"html":{"href":"https://github.com/geodynamics/aspect/pull/835"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/835"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/835/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/835/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/835/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/d6980fbded42d3095dd45fcf40d65c29454fbc6c"}}}}
{"actor":{"display_login":"bangerth"}}