{"action":"created","issue":{"url":"https://api.github.com/repos/Polymer/polymer/issues/4232","repository_url":"https://api.github.com/repos/Polymer/polymer","labels_url":"https://api.github.com/repos/Polymer/polymer/issues/4232/labels{/name}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/4232/comments","events_url":"https://api.github.com/repos/Polymer/polymer/issues/4232/events","html_url":"https://github.com/Polymer/polymer/pull/4232","id":196939195,"number":4232,"title":"Clicks on labels don't check their corresponding inputs","user":{"login":"tmaroschik","id":771756,"avatar_url":"https://avatars.githubusercontent.com/u/771756?v=3","gravatar_id":"","url":"https://api.github.com/users/tmaroschik","html_url":"https://github.com/tmaroschik","followers_url":"https://api.github.com/users/tmaroschik/followers","following_url":"https://api.github.com/users/tmaroschik/following{/other_user}","gists_url":"https://api.github.com/users/tmaroschik/gists{/gist_id}","starred_url":"https://api.github.com/users/tmaroschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmaroschik/subscriptions","organizations_url":"https://api.github.com/users/tmaroschik/orgs","repos_url":"https://api.github.com/users/tmaroschik/repos","events_url":"https://api.github.com/users/tmaroschik/events{/privacy}","received_events_url":"https://api.github.com/users/tmaroschik/received_events","type":"User","site_admin":false},"labels":[{"id":88354527,"url":"https://api.github.com/repos/Polymer/polymer/labels/cla:%20no","name":"cla: no","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-21T13:58:09Z","updated_at":"2016-12-21T13:58:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/4232","html_url":"https://github.com/Polymer/polymer/pull/4232","diff_url":"https://github.com/Polymer/polymer/pull/4232.diff","patch_url":"https://github.com/Polymer/polymer/pull/4232.patch"},"body":"Example here https://jsbin.com/dolayuhatu/edit?html,js,console,output\r\n\r\nIf you click on the checkbox one click event is triggered. If you click on the label, two click events are fired. One on the label, one separate on the input field. If default is prevented on the input field, the checkbox won't be checked.\r\n\r\nIn Polymer in the Gesture handler, the mouseCanceler takes care of canceling ghost clicks. As the input field is most likely not in the event path of the label, the input click event default is prevented which results in a prevented checked state, at least in Safari on iOS10.\r\n\r\nThe fix resolves the forward target of the label click and saves it until the second click event arrives. If it's stored it just skips further canceling."},"comment":{"url":"https://api.github.com/repos/Polymer/polymer/issues/comments/268528806","html_url":"https://github.com/Polymer/polymer/pull/4232#issuecomment-268528806","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/4232","id":268528806,"user":{"login":"googlebot","id":5384588,"avatar_url":"https://avatars.githubusercontent.com/u/5384588?v=3","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T13:58:11Z","updated_at":"2016-12-21T13:58:11Z","body":"Thanks for your pull request.  It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\n:memo: **Please visit <https://cla.developers.google.com/> to sign.**\n\nOnce you've signed, please reply here (e.g. `I signed it!`) and we'll verify.  Thanks.\n\n---\n\n- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n- If you signed the CLA as a corporation, please let us know the company's name.\n\n<!-- need_sender_cla -->"}}
{"actor":{"display_login":"googlebot"}}