{"action":"created","comment":{"url":"https://api.github.com/repos/yoshuawuyts/choo/pulls/comments/65809107","id":65809107,"diff_hunk":"@@ -187,9 +189,16 @@ function choo () {\n // initial application state model\n // obj -> obj\n function appInit (opts) {\n+  var initialLocation\n+  if (opts.history !== false) {","path":"index.js","position":14,"original_position":14,"commit_id":"7e837a47eb4e90cefb8fa8c82472660a9c5c1a7a","original_commit_id":"7e837a47eb4e90cefb8fa8c82472660a9c5c1a7a","user":{"login":"yoshuawuyts","id":2467194,"avatar_url":"https://avatars.githubusercontent.com/u/2467194?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshuawuyts","html_url":"https://github.com/yoshuawuyts","followers_url":"https://api.github.com/users/yoshuawuyts/followers","following_url":"https://api.github.com/users/yoshuawuyts/following{/other_user}","gists_url":"https://api.github.com/users/yoshuawuyts/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshuawuyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshuawuyts/subscriptions","organizations_url":"https://api.github.com/users/yoshuawuyts/orgs","repos_url":"https://api.github.com/users/yoshuawuyts/repos","events_url":"https://api.github.com/users/yoshuawuyts/events{/privacy}","received_events_url":"https://api.github.com/users/yoshuawuyts/received_events","type":"User","site_admin":false},"body":"perhaps a ternary if it fits?","created_at":"2016-06-04T23:27:44Z","updated_at":"2016-06-04T23:27:44Z","html_url":"https://github.com/yoshuawuyts/choo/pull/40#discussion_r65809107","pull_request_url":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/yoshuawuyts/choo/pulls/comments/65809107"},"html":{"href":"https://github.com/yoshuawuyts/choo/pull/40#discussion_r65809107"},"pull_request":{"href":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40","id":72615226,"html_url":"https://github.com/yoshuawuyts/choo/pull/40","diff_url":"https://github.com/yoshuawuyts/choo/pull/40.diff","patch_url":"https://github.com/yoshuawuyts/choo/pull/40.patch","issue_url":"https://api.github.com/repos/yoshuawuyts/choo/issues/40","number":40,"state":"open","locked":false,"title":"Hash routing (WIP)","user":{"login":"timwis","id":761444,"avatar_url":"https://avatars.githubusercontent.com/u/761444?v=3","gravatar_id":"","url":"https://api.github.com/users/timwis","html_url":"https://github.com/timwis","followers_url":"https://api.github.com/users/timwis/followers","following_url":"https://api.github.com/users/timwis/following{/other_user}","gists_url":"https://api.github.com/users/timwis/gists{/gist_id}","starred_url":"https://api.github.com/users/timwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timwis/subscriptions","organizations_url":"https://api.github.com/users/timwis/orgs","repos_url":"https://api.github.com/users/timwis/repos","events_url":"https://api.github.com/users/timwis/events{/privacy}","received_events_url":"https://api.github.com/users/timwis/received_events","type":"User","site_admin":false},"body":"**Work in progress** - not ready to merge\r\n\r\nThis pull request leverages the recent work of @nlocnila in yoshuawuyts/sheet-router#18 to add hash routing support. The current code works, but could be optimized. Wanted to get feedback on the direction first.\r\n\r\nNote that to use this, users must use `app.start(null, {history: false, href: false})`. Otherwise `href` hijacks the anchor tags.","created_at":"2016-06-04T22:47:33Z","updated_at":"2016-06-04T23:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3cb60ab2a3720ede32c18a1c0982aabfca5a9c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40/commits","review_comments_url":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40/comments","review_comment_url":"https://api.github.com/repos/yoshuawuyts/choo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yoshuawuyts/choo/issues/40/comments","statuses_url":"https://api.github.com/repos/yoshuawuyts/choo/statuses/7e837a47eb4e90cefb8fa8c82472660a9c5c1a7a","head":{"label":"timwis:hash","ref":"hash","sha":"7e837a47eb4e90cefb8fa8c82472660a9c5c1a7a","user":{"login":"timwis","id":761444,"avatar_url":"https://avatars.githubusercontent.com/u/761444?v=3","gravatar_id":"","url":"https://api.github.com/users/timwis","html_url":"https://github.com/timwis","followers_url":"https://api.github.com/users/timwis/followers","following_url":"https://api.github.com/users/timwis/following{/other_user}","gists_url":"https://api.github.com/users/timwis/gists{/gist_id}","starred_url":"https://api.github.com/users/timwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timwis/subscriptions","organizations_url":"https://api.github.com/users/timwis/orgs","repos_url":"https://api.github.com/users/timwis/repos","events_url":"https://api.github.com/users/timwis/events{/privacy}","received_events_url":"https://api.github.com/users/timwis/received_events","type":"User","site_admin":false},"repo":{"id":59477507,"name":"choo","full_name":"timwis/choo","owner":{"login":"timwis","id":761444,"avatar_url":"https://avatars.githubusercontent.com/u/761444?v=3","gravatar_id":"","url":"https://api.github.com/users/timwis","html_url":"https://github.com/timwis","followers_url":"https://api.github.com/users/timwis/followers","following_url":"https://api.github.com/users/timwis/following{/other_user}","gists_url":"https://api.github.com/users/timwis/gists{/gist_id}","starred_url":"https://api.github.com/users/timwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timwis/subscriptions","organizations_url":"https://api.github.com/users/timwis/orgs","repos_url":"https://api.github.com/users/timwis/repos","events_url":"https://api.github.com/users/timwis/events{/privacy}","received_events_url":"https://api.github.com/users/timwis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timwis/choo","description":":steam_locomotive::train::train::train::train::train: - framework for creating sturdy web applications","fork":true,"url":"https://api.github.com/repos/timwis/choo","forks_url":"https://api.github.com/repos/timwis/choo/forks","keys_url":"https://api.github.com/repos/timwis/choo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timwis/choo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timwis/choo/teams","hooks_url":"https://api.github.com/repos/timwis/choo/hooks","issue_events_url":"https://api.github.com/repos/timwis/choo/issues/events{/number}","events_url":"https://api.github.com/repos/timwis/choo/events","assignees_url":"https://api.github.com/repos/timwis/choo/assignees{/user}","branches_url":"https://api.github.com/repos/timwis/choo/branches{/branch}","tags_url":"https://api.github.com/repos/timwis/choo/tags","blobs_url":"https://api.github.com/repos/timwis/choo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timwis/choo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timwis/choo/git/refs{/sha}","trees_url":"https://api.github.com/repos/timwis/choo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timwis/choo/statuses/{sha}","languages_url":"https://api.github.com/repos/timwis/choo/languages","stargazers_url":"https://api.github.com/repos/timwis/choo/stargazers","contributors_url":"https://api.github.com/repos/timwis/choo/contributors","subscribers_url":"https://api.github.com/repos/timwis/choo/subscribers","subscription_url":"https://api.github.com/repos/timwis/choo/subscription","commits_url":"https://api.github.com/repos/timwis/choo/commits{/sha}","git_commits_url":"https://api.github.com/repos/timwis/choo/git/commits{/sha}","comments_url":"https://api.github.com/repos/timwis/choo/comments{/number}","issue_comment_url":"https://api.github.com/repos/timwis/choo/issues/comments{/number}","contents_url":"https://api.github.com/repos/timwis/choo/contents/{+path}","compare_url":"https://api.github.com/repos/timwis/choo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timwis/choo/merges","archive_url":"https://api.github.com/repos/timwis/choo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timwis/choo/downloads","issues_url":"https://api.github.com/repos/timwis/choo/issues{/number}","pulls_url":"https://api.github.com/repos/timwis/choo/pulls{/number}","milestones_url":"https://api.github.com/repos/timwis/choo/milestones{/number}","notifications_url":"https://api.github.com/repos/timwis/choo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timwis/choo/labels{/name}","releases_url":"https://api.github.com/repos/timwis/choo/releases{/id}","deployments_url":"https://api.github.com/repos/timwis/choo/deployments","created_at":"2016-05-23T11:35:00Z","updated_at":"2016-05-23T11:35:00Z","pushed_at":"2016-06-04T22:44:09Z","git_url":"git://github.com/timwis/choo.git","ssh_url":"git@github.com:timwis/choo.git","clone_url":"https://github.com/timwis/choo.git","svn_url":"https://github.com/timwis/choo","homepage":"","size":150,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yoshuawuyts:master","ref":"master","sha":"8066c450beb355cb3ee96b90a03d0014511ae25b","user":{"login":"yoshuawuyts","id":2467194,"avatar_url":"https://avatars.githubusercontent.com/u/2467194?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshuawuyts","html_url":"https://github.com/yoshuawuyts","followers_url":"https://api.github.com/users/yoshuawuyts/followers","following_url":"https://api.github.com/users/yoshuawuyts/following{/other_user}","gists_url":"https://api.github.com/users/yoshuawuyts/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshuawuyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshuawuyts/subscriptions","organizations_url":"https://api.github.com/users/yoshuawuyts/orgs","repos_url":"https://api.github.com/users/yoshuawuyts/repos","events_url":"https://api.github.com/users/yoshuawuyts/events{/privacy}","received_events_url":"https://api.github.com/users/yoshuawuyts/received_events","type":"User","site_admin":false},"repo":{"id":58482213,"name":"choo","full_name":"yoshuawuyts/choo","owner":{"login":"yoshuawuyts","id":2467194,"avatar_url":"https://avatars.githubusercontent.com/u/2467194?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshuawuyts","html_url":"https://github.com/yoshuawuyts","followers_url":"https://api.github.com/users/yoshuawuyts/followers","following_url":"https://api.github.com/users/yoshuawuyts/following{/other_user}","gists_url":"https://api.github.com/users/yoshuawuyts/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshuawuyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshuawuyts/subscriptions","organizations_url":"https://api.github.com/users/yoshuawuyts/orgs","repos_url":"https://api.github.com/users/yoshuawuyts/repos","events_url":"https://api.github.com/users/yoshuawuyts/events{/privacy}","received_events_url":"https://api.github.com/users/yoshuawuyts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoshuawuyts/choo","description":":steam_locomotive::train::train::train::train::train: - sturdy frontend framework","fork":false,"url":"https://api.github.com/repos/yoshuawuyts/choo","forks_url":"https://api.github.com/repos/yoshuawuyts/choo/forks","keys_url":"https://api.github.com/repos/yoshuawuyts/choo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoshuawuyts/choo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoshuawuyts/choo/teams","hooks_url":"https://api.github.com/repos/yoshuawuyts/choo/hooks","issue_events_url":"https://api.github.com/repos/yoshuawuyts/choo/issues/events{/number}","events_url":"https://api.github.com/repos/yoshuawuyts/choo/events","assignees_url":"https://api.github.com/repos/yoshuawuyts/choo/assignees{/user}","branches_url":"https://api.github.com/repos/yoshuawuyts/choo/branches{/branch}","tags_url":"https://api.github.com/repos/yoshuawuyts/choo/tags","blobs_url":"https://api.github.com/repos/yoshuawuyts/choo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoshuawuyts/choo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoshuawuyts/choo/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoshuawuyts/choo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoshuawuyts/choo/statuses/{sha}","languages_url":"https://api.github.com/repos/yoshuawuyts/choo/languages","stargazers_url":"https://api.github.com/repos/yoshuawuyts/choo/stargazers","contributors_url":"https://api.github.com/repos/yoshuawuyts/choo/contributors","subscribers_url":"https://api.github.com/repos/yoshuawuyts/choo/subscribers","subscription_url":"https://api.github.com/repos/yoshuawuyts/choo/subscription","commits_url":"https://api.github.com/repos/yoshuawuyts/choo/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoshuawuyts/choo/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoshuawuyts/choo/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoshuawuyts/choo/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoshuawuyts/choo/contents/{+path}","compare_url":"https://api.github.com/repos/yoshuawuyts/choo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoshuawuyts/choo/merges","archive_url":"https://api.github.com/repos/yoshuawuyts/choo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoshuawuyts/choo/downloads","issues_url":"https://api.github.com/repos/yoshuawuyts/choo/issues{/number}","pulls_url":"https://api.github.com/repos/yoshuawuyts/choo/pulls{/number}","milestones_url":"https://api.github.com/repos/yoshuawuyts/choo/milestones{/number}","notifications_url":"https://api.github.com/repos/yoshuawuyts/choo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoshuawuyts/choo/labels{/name}","releases_url":"https://api.github.com/repos/yoshuawuyts/choo/releases{/id}","deployments_url":"https://api.github.com/repos/yoshuawuyts/choo/deployments","created_at":"2016-05-10T17:50:35Z","updated_at":"2016-06-04T17:12:00Z","pushed_at":"2016-06-04T22:47:33Z","git_url":"git://github.com/yoshuawuyts/choo.git","ssh_url":"git@github.com:yoshuawuyts/choo.git","clone_url":"https://github.com/yoshuawuyts/choo.git","svn_url":"https://github.com/yoshuawuyts/choo","homepage":"","size":173,"stargazers_count":281,"watchers_count":281,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":13,"forks":10,"open_issues":13,"watchers":281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40"},"html":{"href":"https://github.com/yoshuawuyts/choo/pull/40"},"issue":{"href":"https://api.github.com/repos/yoshuawuyts/choo/issues/40"},"comments":{"href":"https://api.github.com/repos/yoshuawuyts/choo/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/yoshuawuyts/choo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yoshuawuyts/choo/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/yoshuawuyts/choo/statuses/7e837a47eb4e90cefb8fa8c82472660a9c5c1a7a"}}}}
{"actor":{"display_login":"yoshuawuyts"}}