{"action":"created","comment":{"url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/comments/63248508","id":63248508,"diff_hunk":"@@ -73,7 +73,18 @@\n       is: 'expedition-button',\n       properties: {},\n       _onTap: function(e) {\n-        this.fire('tap');\n+        var target = e.target;\n+        while (target.nodeName.toLowerCase() !== 'body' && target.nodeName.toLowerCase() !== 'expedition-button') {\n+          target = target.parentNode;\n+        }\n+\n+        if (target.getAttribute('href')) {","path":"app/elements/base/expedition-button.html","position":null,"original_position":10,"commit_id":"f702560e31dde82da0938c58e1f5b7e7d04c73f0","original_commit_id":"dd3f2913dd52585251c45f906c5f62eca82f5508","user":{"login":"toddmedema","id":775657,"avatar_url":"https://avatars.githubusercontent.com/u/775657?v=3","gravatar_id":"","url":"https://api.github.com/users/toddmedema","html_url":"https://github.com/toddmedema","followers_url":"https://api.github.com/users/toddmedema/followers","following_url":"https://api.github.com/users/toddmedema/following{/other_user}","gists_url":"https://api.github.com/users/toddmedema/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmedema/subscriptions","organizations_url":"https://api.github.com/users/toddmedema/orgs","repos_url":"https://api.github.com/users/toddmedema/repos","events_url":"https://api.github.com/users/toddmedema/events{/privacy}","received_events_url":"https://api.github.com/users/toddmedema/received_events","type":"User","site_admin":false},"body":"@smartin015 yep - even better, realized that we can just check for expedition button - the alternative is that it keeps looping all the way up to the root HTML element, and then parentNode is undefined. Check out the new push","created_at":"2016-05-13T20:44:41Z","updated_at":"2016-05-13T20:44:41Z","html_url":"https://github.com/Fabricate-IO/expedition-app/pull/74#discussion_r63248508","pull_request_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/comments/63248508"},"html":{"href":"https://github.com/Fabricate-IO/expedition-app/pull/74#discussion_r63248508"},"pull_request":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74","id":69727628,"html_url":"https://github.com/Fabricate-IO/expedition-app/pull/74","diff_url":"https://github.com/Fabricate-IO/expedition-app/pull/74.diff","patch_url":"https://github.com/Fabricate-IO/expedition-app/pull/74.patch","issue_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/74","number":74,"state":"open","locked":false,"title":"add href support to expedition-button","user":{"login":"toddmedema","id":775657,"avatar_url":"https://avatars.githubusercontent.com/u/775657?v=3","gravatar_id":"","url":"https://api.github.com/users/toddmedema","html_url":"https://github.com/toddmedema","followers_url":"https://api.github.com/users/toddmedema/followers","following_url":"https://api.github.com/users/toddmedema/following{/other_user}","gists_url":"https://api.github.com/users/toddmedema/gists{/gist_id}","starred_url":"https://api.github.com/users/toddmedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddmedema/subscriptions","organizations_url":"https://api.github.com/users/toddmedema/orgs","repos_url":"https://api.github.com/users/toddmedema/repos","events_url":"https://api.github.com/users/toddmedema/events{/privacy}","received_events_url":"https://api.github.com/users/toddmedema/received_events","type":"User","site_admin":false},"body":"closes https://github.com/Fabricate-IO/expedition-app/issues/73\r\n\r\ncloses https://github.com/Fabricate-IO/expedition-app/issues/37","created_at":"2016-05-11T19:24:41Z","updated_at":"2016-05-13T20:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d0f71d1bdef8b0ac7dd3b588baa2ffb22ea8b1","assignee":{"login":"smartin015","id":607666,"avatar_url":"https://avatars.githubusercontent.com/u/607666?v=3","gravatar_id":"","url":"https://api.github.com/users/smartin015","html_url":"https://github.com/smartin015","followers_url":"https://api.github.com/users/smartin015/followers","following_url":"https://api.github.com/users/smartin015/following{/other_user}","gists_url":"https://api.github.com/users/smartin015/gists{/gist_id}","starred_url":"https://api.github.com/users/smartin015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartin015/subscriptions","organizations_url":"https://api.github.com/users/smartin015/orgs","repos_url":"https://api.github.com/users/smartin015/repos","events_url":"https://api.github.com/users/smartin015/events{/privacy}","received_events_url":"https://api.github.com/users/smartin015/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74/commits","review_comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74/comments","review_comment_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/74/comments","statuses_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/statuses/f702560e31dde82da0938c58e1f5b7e7d04c73f0","head":{"label":"Fabricate-IO:linkfix","ref":"linkfix","sha":"f702560e31dde82da0938c58e1f5b7e7d04c73f0","user":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"repo":{"id":55982594,"name":"expedition-app","full_name":"Fabricate-IO/expedition-app","owner":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fabricate-IO/expedition-app","description":"The App for Expedition: The Roleplaying Card Game","fork":false,"url":"https://api.github.com/repos/Fabricate-IO/expedition-app","forks_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/forks","keys_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/teams","hooks_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/hooks","issue_events_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/events{/number}","events_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/events","assignees_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/assignees{/user}","branches_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/branches{/branch}","tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/tags","blobs_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/statuses/{sha}","languages_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/languages","stargazers_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/stargazers","contributors_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/contributors","subscribers_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/subscribers","subscription_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/subscription","commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/contents/{+path}","compare_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/merges","archive_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/downloads","issues_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues{/number}","pulls_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls{/number}","milestones_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/milestones{/number}","notifications_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/labels{/name}","releases_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/releases{/id}","deployments_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/deployments","created_at":"2016-04-11T15:08:06Z","updated_at":"2016-05-11T15:38:38Z","pushed_at":"2016-05-13T20:44:25Z","git_url":"git://github.com/Fabricate-IO/expedition-app.git","ssh_url":"git@github.com:Fabricate-IO/expedition-app.git","clone_url":"https://github.com/Fabricate-IO/expedition-app.git","svn_url":"https://github.com/Fabricate-IO/expedition-app","homepage":null,"size":8244,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":54,"forks":3,"open_issues":54,"watchers":2,"default_branch":"master"}},"base":{"label":"Fabricate-IO:master","ref":"master","sha":"b9766a71940f484571af562d22e78c2adf48051d","user":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"repo":{"id":55982594,"name":"expedition-app","full_name":"Fabricate-IO/expedition-app","owner":{"login":"Fabricate-IO","id":17938647,"avatar_url":"https://avatars.githubusercontent.com/u/17938647?v=3","gravatar_id":"","url":"https://api.github.com/users/Fabricate-IO","html_url":"https://github.com/Fabricate-IO","followers_url":"https://api.github.com/users/Fabricate-IO/followers","following_url":"https://api.github.com/users/Fabricate-IO/following{/other_user}","gists_url":"https://api.github.com/users/Fabricate-IO/gists{/gist_id}","starred_url":"https://api.github.com/users/Fabricate-IO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fabricate-IO/subscriptions","organizations_url":"https://api.github.com/users/Fabricate-IO/orgs","repos_url":"https://api.github.com/users/Fabricate-IO/repos","events_url":"https://api.github.com/users/Fabricate-IO/events{/privacy}","received_events_url":"https://api.github.com/users/Fabricate-IO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fabricate-IO/expedition-app","description":"The App for Expedition: The Roleplaying Card Game","fork":false,"url":"https://api.github.com/repos/Fabricate-IO/expedition-app","forks_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/forks","keys_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/teams","hooks_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/hooks","issue_events_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/events{/number}","events_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/events","assignees_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/assignees{/user}","branches_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/branches{/branch}","tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/tags","blobs_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/statuses/{sha}","languages_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/languages","stargazers_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/stargazers","contributors_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/contributors","subscribers_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/subscribers","subscription_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/subscription","commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/contents/{+path}","compare_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/merges","archive_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/downloads","issues_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues{/number}","pulls_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls{/number}","milestones_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/milestones{/number}","notifications_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/labels{/name}","releases_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/releases{/id}","deployments_url":"https://api.github.com/repos/Fabricate-IO/expedition-app/deployments","created_at":"2016-04-11T15:08:06Z","updated_at":"2016-05-11T15:38:38Z","pushed_at":"2016-05-13T20:44:25Z","git_url":"git://github.com/Fabricate-IO/expedition-app.git","ssh_url":"git@github.com:Fabricate-IO/expedition-app.git","clone_url":"https://github.com/Fabricate-IO/expedition-app.git","svn_url":"https://github.com/Fabricate-IO/expedition-app","homepage":null,"size":8244,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":54,"forks":3,"open_issues":54,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74"},"html":{"href":"https://github.com/Fabricate-IO/expedition-app/pull/74"},"issue":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/74"},"comments":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/Fabricate-IO/expedition-app/statuses/f702560e31dde82da0938c58e1f5b7e7d04c73f0"}}}}