{"comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/comments/16946289","html_url":"https://github.com/apache/parquet-cpp/commit/f785e4c7b46e5fa21da5a49051285ae2264e3758#commitcomment-16946289","id":16946289,"user":{"login":"wesm","id":329591,"avatar_url":"https://avatars.githubusercontent.com/u/329591?v=3","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"position":27,"line":47,"path":"src/parquet/schema/types.cc","commit_id":"f785e4c7b46e5fa21da5a49051285ae2264e3758","created_at":"2016-04-03T22:47:16Z","updated_at":"2016-04-03T22:47:16Z","body":"Given the typical nesting of schemas, this isn't likely to be a performance bottleneck, but I agree that the `vector::reserve`` here could be safely skipped (or use a new-style for-loop over `path_` and `vector::push_back` )"}}