{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/15387","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15387/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15387/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15387/events","html_url":"https://github.com/cms-sw/cmssw/pull/15387","id":169910572,"number":15387,"title":"\"Seal\" L1T unpacking plugin declarations.","user":{"login":"matz-e","id":2151261,"avatar_url":"https://avatars.githubusercontent.com/u/2151261?v=3","gravatar_id":"","url":"https://api.github.com/users/matz-e","html_url":"https://github.com/matz-e","followers_url":"https://api.github.com/users/matz-e/followers","following_url":"https://api.github.com/users/matz-e/following{/other_user}","gists_url":"https://api.github.com/users/matz-e/gists{/gist_id}","starred_url":"https://api.github.com/users/matz-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matz-e/subscriptions","organizations_url":"https://api.github.com/users/matz-e/orgs","repos_url":"https://api.github.com/users/matz-e/repos","events_url":"https://api.github.com/users/matz-e/events{/privacy}","received_events_url":"https://api.github.com/users/matz-e/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":1425,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-14T08:17:41Z","due_on":null,"closed_at":null},"comments":45,"created_at":"2016-08-08T12:25:26Z","updated_at":"2016-09-14T09:43:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15387","html_url":"https://github.com/cms-sw/cmssw/pull/15387","diff_url":"https://github.com/cms-sw/cmssw/pull/15387.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15387.patch"},"body":"Factor out headers for the (un)packing of the L1T and seal the modules in the `plugins` directory.  Allows other packages to depend on `L1TRawToDigi` as a library, as needed for DQM."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/246960466","html_url":"https://github.com/cms-sw/cmssw/pull/15387#issuecomment-246960466","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15387","id":246960466,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T09:43:46Z","updated_at":"2016-09-14T09:43:46Z","body":"-1\n\nTested at: 93914c3aa51b2790b0ce4d1173ae9cb70780e2da\n\nYou can see the results of the tests here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-15387/15124/summary.html\n\nI found follow errors while testing this PR\n\n**Failed tests:  Build  ClangBuild**\n\n* **Build**:\n\nI found an error when building: \n \n <pre>>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTTokens.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFCollections.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockHeaders.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/JetUnpacker.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EtSumPacker.cc \n\f/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonPacker.cc:7:36: fatal error: IntermediateMuonPacker.h: No such file or directory\n\f\fcompilation terminated.\n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GTCollections.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonUnpacker.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EGammaUnpacker.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/BMTFSetup.cc \n\f</pre>\n\n* **Clang**:\n\nI found a compilation error while trying to compile with clang: \nI used this command: \n scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'\n\n\n <pre>>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GlobalAlgBlkUnpacker.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/TauUnpacker.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockTrailers.cc \n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/MPUnpacker.cc \n\f/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonPacker.cc:7:10: fatal error: 'IntermediateMuonPacker.h' file not found\n\f\f#include \"IntermediateMuonPacker.h\"\n\f         ^\n\f1 error generated.\n\f>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-09-13-2300/src/EventFilter/L1TRawToDigi/plugins/implementations_stage2/GMTSetup.cc \n\f1 warning generated.\n\f</pre>\n"}}
{"actor":{"display_login":"cmsbuild"}}