{"action":"opened","number":65,"pull_request":{"url":"https://api.github.com/repos/graalvm/sulong/pulls/65","id":61712740,"html_url":"https://github.com/graalvm/sulong/pull/65","diff_url":"https://github.com/graalvm/sulong/pull/65.diff","patch_url":"https://github.com/graalvm/sulong/pull/65.patch","issue_url":"https://api.github.com/repos/graalvm/sulong/issues/65","number":65,"state":"open","locked":false,"title":"Fix mixed native and Sulong calls in indirect calls","user":{"login":"mrigger","id":14328197,"avatar_url":"https://avatars.githubusercontent.com/u/14328197?v=3","gravatar_id":"","url":"https://api.github.com/users/mrigger","html_url":"https://github.com/mrigger","followers_url":"https://api.github.com/users/mrigger/followers","following_url":"https://api.github.com/users/mrigger/following{/other_user}","gists_url":"https://api.github.com/users/mrigger/gists{/gist_id}","starred_url":"https://api.github.com/users/mrigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrigger/subscriptions","organizations_url":"https://api.github.com/users/mrigger/orgs","repos_url":"https://api.github.com/users/mrigger/repos","events_url":"https://api.github.com/users/mrigger/events{/privacy}","received_events_url":"https://api.github.com/users/mrigger/received_events","type":"User","site_admin":false},"body":"Previously, mixed native and Sulong calls in indirect calls (for function pointer calls that exceeded the polymorphic inline cache limit) did not work. \r\n\r\nPreviously, native functions in the indirect call node could not receive address arguments. With this change, addresses are passed as long values in function pointer calls, and the Sulong function prologue converts them again to addresses. The native functions can use the long values directly.\r\n\r\nThe indirect call node simply did not consider native functions and only performed a lookup for Sulong function. With this change, also native functions are considered. To prevent a bailout through too many lookups (of the same function) we now cache the looked up function handles.\r\n\r\nI also added a regression test case that stresses mixed Sulong and native function pointer calls.","created_at":"2016-03-04T13:39:48Z","updated_at":"2016-03-04T13:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/graalvm/sulong/pulls/65/commits","review_comments_url":"https://api.github.com/repos/graalvm/sulong/pulls/65/comments","review_comment_url":"https://api.github.com/repos/graalvm/sulong/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graalvm/sulong/issues/65/comments","statuses_url":"https://api.github.com/repos/graalvm/sulong/statuses/6e57ae3548df7bb77d43abee70cc3a6273310bc0","head":{"label":"mrigger:native-calls","ref":"native-calls","sha":"6e57ae3548df7bb77d43abee70cc3a6273310bc0","user":{"login":"mrigger","id":14328197,"avatar_url":"https://avatars.githubusercontent.com/u/14328197?v=3","gravatar_id":"","url":"https://api.github.com/users/mrigger","html_url":"https://github.com/mrigger","followers_url":"https://api.github.com/users/mrigger/followers","following_url":"https://api.github.com/users/mrigger/following{/other_user}","gists_url":"https://api.github.com/users/mrigger/gists{/gist_id}","starred_url":"https://api.github.com/users/mrigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrigger/subscriptions","organizations_url":"https://api.github.com/users/mrigger/orgs","repos_url":"https://api.github.com/users/mrigger/repos","events_url":"https://api.github.com/users/mrigger/events{/privacy}","received_events_url":"https://api.github.com/users/mrigger/received_events","type":"User","site_admin":false},"repo":{"id":53136741,"name":"sulong","full_name":"mrigger/sulong","owner":{"login":"mrigger","id":14328197,"avatar_url":"https://avatars.githubusercontent.com/u/14328197?v=3","gravatar_id":"","url":"https://api.github.com/users/mrigger","html_url":"https://github.com/mrigger","followers_url":"https://api.github.com/users/mrigger/followers","following_url":"https://api.github.com/users/mrigger/following{/other_user}","gists_url":"https://api.github.com/users/mrigger/gists{/gist_id}","starred_url":"https://api.github.com/users/mrigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrigger/subscriptions","organizations_url":"https://api.github.com/users/mrigger/orgs","repos_url":"https://api.github.com/users/mrigger/repos","events_url":"https://api.github.com/users/mrigger/events{/privacy}","received_events_url":"https://api.github.com/users/mrigger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrigger/sulong","description":"","fork":true,"url":"https://api.github.com/repos/mrigger/sulong","forks_url":"https://api.github.com/repos/mrigger/sulong/forks","keys_url":"https://api.github.com/repos/mrigger/sulong/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrigger/sulong/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrigger/sulong/teams","hooks_url":"https://api.github.com/repos/mrigger/sulong/hooks","issue_events_url":"https://api.github.com/repos/mrigger/sulong/issues/events{/number}","events_url":"https://api.github.com/repos/mrigger/sulong/events","assignees_url":"https://api.github.com/repos/mrigger/sulong/assignees{/user}","branches_url":"https://api.github.com/repos/mrigger/sulong/branches{/branch}","tags_url":"https://api.github.com/repos/mrigger/sulong/tags","blobs_url":"https://api.github.com/repos/mrigger/sulong/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrigger/sulong/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrigger/sulong/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrigger/sulong/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrigger/sulong/statuses/{sha}","languages_url":"https://api.github.com/repos/mrigger/sulong/languages","stargazers_url":"https://api.github.com/repos/mrigger/sulong/stargazers","contributors_url":"https://api.github.com/repos/mrigger/sulong/contributors","subscribers_url":"https://api.github.com/repos/mrigger/sulong/subscribers","subscription_url":"https://api.github.com/repos/mrigger/sulong/subscription","commits_url":"https://api.github.com/repos/mrigger/sulong/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrigger/sulong/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrigger/sulong/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrigger/sulong/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrigger/sulong/contents/{+path}","compare_url":"https://api.github.com/repos/mrigger/sulong/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrigger/sulong/merges","archive_url":"https://api.github.com/repos/mrigger/sulong/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrigger/sulong/downloads","issues_url":"https://api.github.com/repos/mrigger/sulong/issues{/number}","pulls_url":"https://api.github.com/repos/mrigger/sulong/pulls{/number}","milestones_url":"https://api.github.com/repos/mrigger/sulong/milestones{/number}","notifications_url":"https://api.github.com/repos/mrigger/sulong/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrigger/sulong/labels{/name}","releases_url":"https://api.github.com/repos/mrigger/sulong/releases{/id}","deployments_url":"https://api.github.com/repos/mrigger/sulong/deployments","created_at":"2016-03-04T13:19:23Z","updated_at":"2016-03-04T13:19:25Z","pushed_at":"2016-03-04T13:39:13Z","git_url":"git://github.com/mrigger/sulong.git","ssh_url":"git@github.com:mrigger/sulong.git","clone_url":"https://github.com/mrigger/sulong.git","svn_url":"https://github.com/mrigger/sulong","homepage":null,"size":674,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graalvm:master","ref":"master","sha":"8f5b0edc852b01da08254f38f91a390fdfe5b5d3","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":49868718,"name":"sulong","full_name":"graalvm/sulong","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/sulong","description":"","fork":false,"url":"https://api.github.com/repos/graalvm/sulong","forks_url":"https://api.github.com/repos/graalvm/sulong/forks","keys_url":"https://api.github.com/repos/graalvm/sulong/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/sulong/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/sulong/teams","hooks_url":"https://api.github.com/repos/graalvm/sulong/hooks","issue_events_url":"https://api.github.com/repos/graalvm/sulong/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/sulong/events","assignees_url":"https://api.github.com/repos/graalvm/sulong/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/sulong/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/sulong/tags","blobs_url":"https://api.github.com/repos/graalvm/sulong/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/sulong/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/sulong/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/sulong/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/sulong/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/sulong/languages","stargazers_url":"https://api.github.com/repos/graalvm/sulong/stargazers","contributors_url":"https://api.github.com/repos/graalvm/sulong/contributors","subscribers_url":"https://api.github.com/repos/graalvm/sulong/subscribers","subscription_url":"https://api.github.com/repos/graalvm/sulong/subscription","commits_url":"https://api.github.com/repos/graalvm/sulong/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/sulong/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/sulong/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/sulong/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/sulong/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/sulong/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/sulong/merges","archive_url":"https://api.github.com/repos/graalvm/sulong/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/sulong/downloads","issues_url":"https://api.github.com/repos/graalvm/sulong/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/sulong/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/sulong/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/sulong/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/sulong/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/sulong/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/sulong/deployments","created_at":"2016-01-18T10:12:52Z","updated_at":"2016-02-21T19:18:47Z","pushed_at":"2016-03-04T13:39:48Z","git_url":"git://github.com/graalvm/sulong.git","ssh_url":"git@github.com:graalvm/sulong.git","clone_url":"https://github.com/graalvm/sulong.git","svn_url":"https://github.com/graalvm/sulong","homepage":null,"size":678,"stargazers_count":62,"watchers_count":62,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":14,"forks":3,"open_issues":14,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graalvm/sulong/pulls/65"},"html":{"href":"https://github.com/graalvm/sulong/pull/65"},"issue":{"href":"https://api.github.com/repos/graalvm/sulong/issues/65"},"comments":{"href":"https://api.github.com/repos/graalvm/sulong/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/graalvm/sulong/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/graalvm/sulong/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graalvm/sulong/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/graalvm/sulong/statuses/6e57ae3548df7bb77d43abee70cc3a6273310bc0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":161,"deletions":34,"changed_files":12}}