{"action":"created","comment":{"url":"https://api.github.com/repos/sublimehq/Packages/pulls/comments/68113102","id":68113102,"diff_hunk":"@@ -9,12 +9,12 @@ scope: source.scala\n contexts:\n   main:\n     - include: storage-modifiers\n-    - include: keywords\n     - include: declarations\n     - include: inheritance\n     - include: imports\n     - include: comments\n     - include: block-comments\n+    - include: keywords","path":"Scala/Scala.sublime-syntax","position":10,"original_position":10,"commit_id":"dcc291e924176c10d22bbf65985a3b193ce2c1d4","original_commit_id":"dcc291e924176c10d22bbf65985a3b193ce2c1d4","user":{"login":"mkhl","id":505,"avatar_url":"https://avatars.githubusercontent.com/u/505?v=3","gravatar_id":"","url":"https://api.github.com/users/mkhl","html_url":"https://github.com/mkhl","followers_url":"https://api.github.com/users/mkhl/followers","following_url":"https://api.github.com/users/mkhl/following{/other_user}","gists_url":"https://api.github.com/users/mkhl/gists{/gist_id}","starred_url":"https://api.github.com/users/mkhl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkhl/subscriptions","organizations_url":"https://api.github.com/users/mkhl/orgs","repos_url":"https://api.github.com/users/mkhl/repos","events_url":"https://api.github.com/users/mkhl/events{/privacy}","received_events_url":"https://api.github.com/users/mkhl/received_events","type":"User","site_admin":false},"body":"Adding the new keywords this high can prevent other patterns from matching, e.g. I believe your matching of `new` would prevent `initialization` from matching its expected `new` keyword.\r\n\r\nI’d also recommend keeping the same scope for keywords that you’re matching without context now, e.g. `type` is `keyword.declaration.scala` in `declarations`.\r\n\r\nIt’s a pity the scopes have diverged from the TextMate grammar so much…","created_at":"2016-06-22T18:53:06Z","updated_at":"2016-06-22T18:53:06Z","html_url":"https://github.com/sublimehq/Packages/pull/488#discussion_r68113102","pull_request_url":"https://api.github.com/repos/sublimehq/Packages/pulls/488","_links":{"self":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/comments/68113102"},"html":{"href":"https://github.com/sublimehq/Packages/pull/488#discussion_r68113102"},"pull_request":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/488"}}},"pull_request":{"url":"https://api.github.com/repos/sublimehq/Packages/pulls/488","id":74536535,"html_url":"https://github.com/sublimehq/Packages/pull/488","diff_url":"https://github.com/sublimehq/Packages/pull/488.diff","patch_url":"https://github.com/sublimehq/Packages/pull/488.patch","issue_url":"https://api.github.com/repos/sublimehq/Packages/issues/488","number":488,"state":"open","locked":false,"title":"[Scala] Keyword highlighting","user":{"login":"djspiewak","id":752,"avatar_url":"https://avatars.githubusercontent.com/u/752?v=3","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"body":"The Scala mode does this weird thing where it only highlights certain keywords in context (e.g. `class` is only highlighted in `class Foo`, not when by itself).  This is deceptive since these keywords aren't valid identifiers.  This PR adds fallback highlighting support for those keywords.\r\n\r\nAlso adds support for highlighting `macro` and `???`, the latter of which isn't actually a keyword, but most people treat it as if it is.","created_at":"2016-06-21T00:53:08Z","updated_at":"2016-06-22T18:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d04b2f563207c419689bc38dbfe9a2593c03808","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sublimehq/Packages/pulls/488/commits","review_comments_url":"https://api.github.com/repos/sublimehq/Packages/pulls/488/comments","review_comment_url":"https://api.github.com/repos/sublimehq/Packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sublimehq/Packages/issues/488/comments","statuses_url":"https://api.github.com/repos/sublimehq/Packages/statuses/dcc291e924176c10d22bbf65985a3b193ce2c1d4","head":{"label":"djspiewak:feature/scala-keyword-highlighting","ref":"feature/scala-keyword-highlighting","sha":"dcc291e924176c10d22bbf65985a3b193ce2c1d4","user":{"login":"djspiewak","id":752,"avatar_url":"https://avatars.githubusercontent.com/u/752?v=3","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"repo":{"id":37565415,"name":"Packages","full_name":"djspiewak/Packages","owner":{"login":"djspiewak","id":752,"avatar_url":"https://avatars.githubusercontent.com/u/752?v=3","gravatar_id":"","url":"https://api.github.com/users/djspiewak","html_url":"https://github.com/djspiewak","followers_url":"https://api.github.com/users/djspiewak/followers","following_url":"https://api.github.com/users/djspiewak/following{/other_user}","gists_url":"https://api.github.com/users/djspiewak/gists{/gist_id}","starred_url":"https://api.github.com/users/djspiewak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djspiewak/subscriptions","organizations_url":"https://api.github.com/users/djspiewak/orgs","repos_url":"https://api.github.com/users/djspiewak/repos","events_url":"https://api.github.com/users/djspiewak/events{/privacy}","received_events_url":"https://api.github.com/users/djspiewak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djspiewak/Packages","description":"","fork":true,"url":"https://api.github.com/repos/djspiewak/Packages","forks_url":"https://api.github.com/repos/djspiewak/Packages/forks","keys_url":"https://api.github.com/repos/djspiewak/Packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djspiewak/Packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djspiewak/Packages/teams","hooks_url":"https://api.github.com/repos/djspiewak/Packages/hooks","issue_events_url":"https://api.github.com/repos/djspiewak/Packages/issues/events{/number}","events_url":"https://api.github.com/repos/djspiewak/Packages/events","assignees_url":"https://api.github.com/repos/djspiewak/Packages/assignees{/user}","branches_url":"https://api.github.com/repos/djspiewak/Packages/branches{/branch}","tags_url":"https://api.github.com/repos/djspiewak/Packages/tags","blobs_url":"https://api.github.com/repos/djspiewak/Packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djspiewak/Packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djspiewak/Packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/djspiewak/Packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djspiewak/Packages/statuses/{sha}","languages_url":"https://api.github.com/repos/djspiewak/Packages/languages","stargazers_url":"https://api.github.com/repos/djspiewak/Packages/stargazers","contributors_url":"https://api.github.com/repos/djspiewak/Packages/contributors","subscribers_url":"https://api.github.com/repos/djspiewak/Packages/subscribers","subscription_url":"https://api.github.com/repos/djspiewak/Packages/subscription","commits_url":"https://api.github.com/repos/djspiewak/Packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/djspiewak/Packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/djspiewak/Packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/djspiewak/Packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/djspiewak/Packages/contents/{+path}","compare_url":"https://api.github.com/repos/djspiewak/Packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djspiewak/Packages/merges","archive_url":"https://api.github.com/repos/djspiewak/Packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djspiewak/Packages/downloads","issues_url":"https://api.github.com/repos/djspiewak/Packages/issues{/number}","pulls_url":"https://api.github.com/repos/djspiewak/Packages/pulls{/number}","milestones_url":"https://api.github.com/repos/djspiewak/Packages/milestones{/number}","notifications_url":"https://api.github.com/repos/djspiewak/Packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djspiewak/Packages/labels{/name}","releases_url":"https://api.github.com/repos/djspiewak/Packages/releases{/id}","deployments_url":"https://api.github.com/repos/djspiewak/Packages/deployments","created_at":"2015-06-17T01:29:40Z","updated_at":"2016-05-13T18:06:40Z","pushed_at":"2016-06-22T18:13:49Z","git_url":"git://github.com/djspiewak/Packages.git","ssh_url":"git@github.com:djspiewak/Packages.git","clone_url":"https://github.com/djspiewak/Packages.git","svn_url":"https://github.com/djspiewak/Packages","homepage":null,"size":3331,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sublimehq:master","ref":"master","sha":"c2efe686120c5e6fa3ede3bb9a3b34852527f55c","user":{"login":"sublimehq","id":1161584,"avatar_url":"https://avatars.githubusercontent.com/u/1161584?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimehq","html_url":"https://github.com/sublimehq","followers_url":"https://api.github.com/users/sublimehq/followers","following_url":"https://api.github.com/users/sublimehq/following{/other_user}","gists_url":"https://api.github.com/users/sublimehq/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimehq/subscriptions","organizations_url":"https://api.github.com/users/sublimehq/orgs","repos_url":"https://api.github.com/users/sublimehq/repos","events_url":"https://api.github.com/users/sublimehq/events{/privacy}","received_events_url":"https://api.github.com/users/sublimehq/received_events","type":"User","site_admin":false},"repo":{"id":37357499,"name":"Packages","full_name":"sublimehq/Packages","owner":{"login":"sublimehq","id":1161584,"avatar_url":"https://avatars.githubusercontent.com/u/1161584?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimehq","html_url":"https://github.com/sublimehq","followers_url":"https://api.github.com/users/sublimehq/followers","following_url":"https://api.github.com/users/sublimehq/following{/other_user}","gists_url":"https://api.github.com/users/sublimehq/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimehq/subscriptions","organizations_url":"https://api.github.com/users/sublimehq/orgs","repos_url":"https://api.github.com/users/sublimehq/repos","events_url":"https://api.github.com/users/sublimehq/events{/privacy}","received_events_url":"https://api.github.com/users/sublimehq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sublimehq/Packages","description":"","fork":false,"url":"https://api.github.com/repos/sublimehq/Packages","forks_url":"https://api.github.com/repos/sublimehq/Packages/forks","keys_url":"https://api.github.com/repos/sublimehq/Packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sublimehq/Packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sublimehq/Packages/teams","hooks_url":"https://api.github.com/repos/sublimehq/Packages/hooks","issue_events_url":"https://api.github.com/repos/sublimehq/Packages/issues/events{/number}","events_url":"https://api.github.com/repos/sublimehq/Packages/events","assignees_url":"https://api.github.com/repos/sublimehq/Packages/assignees{/user}","branches_url":"https://api.github.com/repos/sublimehq/Packages/branches{/branch}","tags_url":"https://api.github.com/repos/sublimehq/Packages/tags","blobs_url":"https://api.github.com/repos/sublimehq/Packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sublimehq/Packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sublimehq/Packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/sublimehq/Packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sublimehq/Packages/statuses/{sha}","languages_url":"https://api.github.com/repos/sublimehq/Packages/languages","stargazers_url":"https://api.github.com/repos/sublimehq/Packages/stargazers","contributors_url":"https://api.github.com/repos/sublimehq/Packages/contributors","subscribers_url":"https://api.github.com/repos/sublimehq/Packages/subscribers","subscription_url":"https://api.github.com/repos/sublimehq/Packages/subscription","commits_url":"https://api.github.com/repos/sublimehq/Packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/sublimehq/Packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/sublimehq/Packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/sublimehq/Packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/sublimehq/Packages/contents/{+path}","compare_url":"https://api.github.com/repos/sublimehq/Packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sublimehq/Packages/merges","archive_url":"https://api.github.com/repos/sublimehq/Packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sublimehq/Packages/downloads","issues_url":"https://api.github.com/repos/sublimehq/Packages/issues{/number}","pulls_url":"https://api.github.com/repos/sublimehq/Packages/pulls{/number}","milestones_url":"https://api.github.com/repos/sublimehq/Packages/milestones{/number}","notifications_url":"https://api.github.com/repos/sublimehq/Packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sublimehq/Packages/labels{/name}","releases_url":"https://api.github.com/repos/sublimehq/Packages/releases{/id}","deployments_url":"https://api.github.com/repos/sublimehq/Packages/deployments","created_at":"2015-06-13T04:17:44Z","updated_at":"2016-06-22T10:53:15Z","pushed_at":"2016-06-22T18:11:15Z","git_url":"git://github.com/sublimehq/Packages.git","ssh_url":"git@github.com:sublimehq/Packages.git","clone_url":"https://github.com/sublimehq/Packages.git","svn_url":"https://github.com/sublimehq/Packages","homepage":null,"size":4240,"stargazers_count":2463,"watchers_count":2463,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":54,"forks":239,"open_issues":54,"watchers":2463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/488"},"html":{"href":"https://github.com/sublimehq/Packages/pull/488"},"issue":{"href":"https://api.github.com/repos/sublimehq/Packages/issues/488"},"comments":{"href":"https://api.github.com/repos/sublimehq/Packages/issues/488/comments"},"review_comments":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/488/comments"},"review_comment":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/488/commits"},"statuses":{"href":"https://api.github.com/repos/sublimehq/Packages/statuses/dcc291e924176c10d22bbf65985a3b193ce2c1d4"}}}}
{"actor":{"display_login":"mkhl"}}