{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/74169200","id":74169200,"diff_hunk":"@@ -853,6 +861,16 @@ private static double ComputeWeightedDistance(ForEachStatementSyntax left, ForEa\n             return AdjustForLocalsInBlock(distance, left.Statement, right.Statement, localsWeight: 0.6);\n         }\n \n+        private static double ComputeWeightedDistance(ForEachComponentStatementSyntax left, ForEachComponentStatementSyntax right)\n+        {\n+            double statementDistance = ComputeDistance(left.Statement, right.Statement);\n+            double expressionDistance = ComputeDistance(left.Expression, right.Expression);\n+            double identifierDistance = ComputeDistance(left.VariableComponent, right.VariableComponent);\n+\n+            double distance = identifierDistance * 0.7 + expressionDistance * 0.2 + statementDistance * 0.1;","path":"src/Features/CSharp/Portable/EditAndContinue/StatementSyntaxComparer.cs","position":34,"original_position":34,"commit_id":"54e1b10fdb949bb0a46dbdaf1901ffd334ad2e36","original_commit_id":"54e1b10fdb949bb0a46dbdaf1901ffd334ad2e36","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"Perhaps these two lines can be extracted to a helper ```ComputeForEachWeightedDistance(left.Statement, left.Expression, rigth.Statement, right.Expression, identifierDistance)```. ","created_at":"2016-08-10T00:36:16Z","updated_at":"2016-08-10T00:36:16Z","html_url":"https://github.com/dotnet/roslyn/pull/13051#discussion_r74169200","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13051","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/74169200"},"html":{"href":"https://github.com/dotnet/roslyn/pull/13051#discussion_r74169200"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13051"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/13051","id":80710439,"html_url":"https://github.com/dotnet/roslyn/pull/13051","diff_url":"https://github.com/dotnet/roslyn/pull/13051.diff","patch_url":"https://github.com/dotnet/roslyn/pull/13051.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/13051","number":13051,"state":"open","locked":false,"title":"Implement tree diffing for edit-and-continue for some C# 7 features.","user":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"body":"@tmat Is this correct, more-or-less? What would be the next step for this? Where can I find tests which I should add to?","created_at":"2016-08-09T23:09:07Z","updated_at":"2016-08-10T00:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a51dee0e71956010e71aea7471b794ef93adf10d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13051/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/13051/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/13051/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/54e1b10fdb949bb0a46dbdaf1901ffd334ad2e36","head":{"label":"gafter:c7diff","ref":"c7diff","sha":"54e1b10fdb949bb0a46dbdaf1901ffd334ad2e36","user":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"repo":{"id":30125216,"name":"roslyn","full_name":"gafter/roslyn","owner":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gafter/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/gafter/roslyn","forks_url":"https://api.github.com/repos/gafter/roslyn/forks","keys_url":"https://api.github.com/repos/gafter/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gafter/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gafter/roslyn/teams","hooks_url":"https://api.github.com/repos/gafter/roslyn/hooks","issue_events_url":"https://api.github.com/repos/gafter/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/gafter/roslyn/events","assignees_url":"https://api.github.com/repos/gafter/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/gafter/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/gafter/roslyn/tags","blobs_url":"https://api.github.com/repos/gafter/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gafter/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gafter/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/gafter/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gafter/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/gafter/roslyn/languages","stargazers_url":"https://api.github.com/repos/gafter/roslyn/stargazers","contributors_url":"https://api.github.com/repos/gafter/roslyn/contributors","subscribers_url":"https://api.github.com/repos/gafter/roslyn/subscribers","subscription_url":"https://api.github.com/repos/gafter/roslyn/subscription","commits_url":"https://api.github.com/repos/gafter/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/gafter/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/gafter/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/gafter/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/gafter/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/gafter/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gafter/roslyn/merges","archive_url":"https://api.github.com/repos/gafter/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gafter/roslyn/downloads","issues_url":"https://api.github.com/repos/gafter/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/gafter/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/gafter/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/gafter/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gafter/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/gafter/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/gafter/roslyn/deployments","created_at":"2015-01-31T20:26:12Z","updated_at":"2016-02-18T04:08:14Z","pushed_at":"2016-08-09T23:07:34Z","git_url":"git://github.com/gafter/roslyn.git","ssh_url":"git@github.com:gafter/roslyn.git","clone_url":"https://github.com/gafter/roslyn.git","svn_url":"https://github.com/gafter/roslyn","homepage":"","size":161301,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b4e6dbe3f17ac0c67f281c138a318e69b04aab91","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-08-09T22:35:41Z","pushed_at":"2016-08-10T00:19:03Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":322835,"stargazers_count":5978,"watchers_count":5978,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1426,"mirror_url":null,"open_issues_count":3112,"forks":1426,"open_issues":3112,"watchers":5978,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13051"},"html":{"href":"https://github.com/dotnet/roslyn/pull/13051"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/13051"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/13051/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13051/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/13051/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/54e1b10fdb949bb0a46dbdaf1901ffd334ad2e36"}}}}
{"actor":{"display_login":"tmat"}}