{"push_id":1175859412,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"eca39e2f3f3082bf997183879e5999b4f61faf8b","before":"0209bc3cbe40d6196654d4103c46b02707dd1ea7","commits":[{"sha":"eca39e2f3f3082bf997183879e5999b4f61faf8b","author":{"name":"Damien CORNEAU","email":"3934fe76957efd50a828a20da9557cf8bd803e79@gmail.com"},"message":"[ZEPPELIN-846] Fix Long Notebook Dropdown\n\n### What is this PR for?\nThis PR is fixing the bug by implementing a new layout for the Notebook Dropdown menu.\nReason being that setting a maximum height and having a scrollbar doesn't mix with having bootstrap submenus.\n\nIn term of dropdown layout, I think we have 2 options:\n* The one I implemented, a tree view similar to the one in the home page, I can probably uniform both of them later. One possible problem is the dropdown width getting bigger and bigger as we indent at each submenu.\n* The second one would not have any indent, but use a background color to show elements in the same folder (A grey that goes clearer as we go in the submenus)\n\n<img width=\"691\" alt=\"screen shot 2016-06-25 at 1 42 41 am\" src=\"https://cloud.githubusercontent.com/assets/710411/16344155/2d387af0-3a76-11e6-87ba-9626d9f17fea.png\">\n\nReworking the whole notebook list and dropdown will probably need a lot more work later (especially in term of refactoring and code cleaning), so I'm not sure where the scope of this PR should stop, especially with the release coming. I think the layout I implemented is fine to solve the immediate problem, and it is always possible to switch to the layout of option 2 later if we think it is best.\n\n### What type of PR is it?\nHot Fix\n\n### Todos\n* [ ] - Rebase & Double Check the filtering and Notebook ordering after #1066\n\n### What is the Jira issue?\nhttps://issues.apache.org/jira/browse/ZEPPELIN-846\n\n### How should this be tested?\nJust play with the folder structure and check the notebook dropdown\n\n### Screenshots (if appropriate)\n![openingfolder](https://cloud.githubusercontent.com/assets/710411/16343658/583e1064-3a73-11e6-8607-bcdced587636.gif)\n\n![notebookisrunnable](https://cloud.githubusercontent.com/assets/710411/16343663/5c10894c-3a73-11e6-9f54-c32136d3437a.gif)\n\n### Questions:\n* Does the licenses files need update? No\n* Is there breaking changes for older versions? No\n* Does this needs documentation? No\n\nAuthor: Damien CORNEAU <corneadoug@gmail.com>\n\nCloses #1081 from corneadoug/fix/longNavbarNotebookList and squashes the following commits:\n\n223a7d3 [Damien CORNEAU] Fix Notebook dropdown css when on mobile\n8170782 [Damien CORNEAU] Fix Notebook ordering in dropdown\n5a0fa09 [Damien CORNEAU] fix jshint errors\na52b219 [Damien CORNEAU] Change Notebook dropdown style","distinct":true,"url":"https://api.github.com/repos/apache/zeppelin/commits/eca39e2f3f3082bf997183879e5999b4f61faf8b"}]}
{"actor":{"display_login":"asfgit"}}