{"action":"created","issue":{"url":"https://api.github.com/repos/rajanadar/VaultSharp/issues/6","repository_url":"https://api.github.com/repos/rajanadar/VaultSharp","labels_url":"https://api.github.com/repos/rajanadar/VaultSharp/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/rajanadar/VaultSharp/issues/6/comments","events_url":"https://api.github.com/repos/rajanadar/VaultSharp/issues/6/events","html_url":"https://github.com/rajanadar/VaultSharp/pull/6","id":168337565,"number":6,"title":"update Newtonsoft.Json library, and use ILRepack on release builds to package JSON.net into the dll","user":{"login":"georgefrank","id":4315023,"avatar_url":"https://avatars.githubusercontent.com/u/4315023?v=3","gravatar_id":"","url":"https://api.github.com/users/georgefrank","html_url":"https://github.com/georgefrank","followers_url":"https://api.github.com/users/georgefrank/followers","following_url":"https://api.github.com/users/georgefrank/following{/other_user}","gists_url":"https://api.github.com/users/georgefrank/gists{/gist_id}","starred_url":"https://api.github.com/users/georgefrank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgefrank/subscriptions","organizations_url":"https://api.github.com/users/georgefrank/orgs","repos_url":"https://api.github.com/users/georgefrank/repos","events_url":"https://api.github.com/users/georgefrank/events{/privacy}","received_events_url":"https://api.github.com/users/georgefrank/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-29T14:30:43Z","updated_at":"2016-07-29T20:46:34Z","closed_at":"2016-07-29T20:40:29Z","pull_request":{"url":"https://api.github.com/repos/rajanadar/VaultSharp/pulls/6","html_url":"https://github.com/rajanadar/VaultSharp/pull/6","diff_url":"https://github.com/rajanadar/VaultSharp/pull/6.diff","patch_url":"https://github.com/rajanadar/VaultSharp/pull/6.patch"},"body":"In order to reduce the clashing of JSON.net dependencies, this PR adds build steps that, on a release build, will take Newtonsoft.json.dll and package it into the VaultSharp.dll. When others import the VaultSharp.dll file, they can use whatever version of JSON.net they want and it will not clash with the version used by VaultSharp.dll.\r\n\r\nThis commit essentially duplicates the change in the .Net library for Consul (https://github.com/PlayFab/consuldotnet/pull/52). This is to solve the same issue that exists with that library: https://github.com/PlayFab/consuldotnet/issues/28"},"comment":{"url":"https://api.github.com/repos/rajanadar/VaultSharp/issues/comments/236289100","html_url":"https://github.com/rajanadar/VaultSharp/pull/6#issuecomment-236289100","issue_url":"https://api.github.com/repos/rajanadar/VaultSharp/issues/6","id":236289100,"user":{"login":"rajanadar","id":376958,"avatar_url":"https://avatars.githubusercontent.com/u/376958?v=3","gravatar_id":"","url":"https://api.github.com/users/rajanadar","html_url":"https://github.com/rajanadar","followers_url":"https://api.github.com/users/rajanadar/followers","following_url":"https://api.github.com/users/rajanadar/following{/other_user}","gists_url":"https://api.github.com/users/rajanadar/gists{/gist_id}","starred_url":"https://api.github.com/users/rajanadar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajanadar/subscriptions","organizations_url":"https://api.github.com/users/rajanadar/orgs","repos_url":"https://api.github.com/users/rajanadar/repos","events_url":"https://api.github.com/users/rajanadar/events{/privacy}","received_events_url":"https://api.github.com/users/rajanadar/received_events","type":"User","site_admin":false},"created_at":"2016-07-29T20:46:34Z","updated_at":"2016-07-29T20:46:34Z","body":"thanks @georgefrank for raising this issue.\r\n\r\nin general for VaultSharp or for any consumable NuGet package, i have left it to the assembly binding redirection settings to take care of multiple versions, when the package is consumed by clients. did your web.config or app.config not take care of this?\r\n\r\nand say we package Json DLL today.. and tomorrow VaultSharp needs 2 more assemblies.. we don't want to keep packing dlls into this.. \r\n\r\nanyway, i'll think through this a bit more and if it makes sense, i'll incorporate it into the next version.\r\n\r\nthank you for using the dll and raising this issue and the PR."}}
{"actor":{"display_login":"rajanadar"}}