{"action":"created","issue":{"url":"https://api.github.com/repos/NativeScript/android-runtime/issues/457","repository_url":"https://api.github.com/repos/NativeScript/android-runtime","labels_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/457/labels{/name}","comments_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/457/comments","events_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/457/events","html_url":"https://github.com/NativeScript/android-runtime/pull/457","id":155525734,"number":457,"title":"Integrate: d.ts build-time generation","user":{"login":"Plamen5kov","id":5918351,"avatar_url":"https://avatars.githubusercontent.com/u/5918351?v=3","gravatar_id":"","url":"https://api.github.com/users/Plamen5kov","html_url":"https://github.com/Plamen5kov","followers_url":"https://api.github.com/users/Plamen5kov/followers","following_url":"https://api.github.com/users/Plamen5kov/following{/other_user}","gists_url":"https://api.github.com/users/Plamen5kov/gists{/gist_id}","starred_url":"https://api.github.com/users/Plamen5kov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plamen5kov/subscriptions","organizations_url":"https://api.github.com/users/Plamen5kov/orgs","repos_url":"https://api.github.com/users/Plamen5kov/repos","events_url":"https://api.github.com/users/Plamen5kov/events{/privacy}","received_events_url":"https://api.github.com/users/Plamen5kov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-05-18T15:05:33Z","updated_at":"2016-06-09T11:17:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NativeScript/android-runtime/pulls/457","html_url":"https://github.com/NativeScript/android-runtime/pull/457","diff_url":"https://github.com/NativeScript/android-runtime/pull/457.diff","patch_url":"https://github.com/NativeScript/android-runtime/pull/457.patch"},"body":"This PR integrates a dts generator in the gradle build. The default build will generate dts files if an environment variable is declared, as it is in iOS: https://github.com/NativeScript/ios-runtime/blob/master/build/scripts/metadata-generation-build-step#L36\r\nThe environment variable has the same name: `TNS_TYPESCRIPT_DECLARATIONS_PATH`\r\n\r\n* generates dts when necessary\r\n* optimized build caching\r\n* needs integration with CLI\r\n* tested with the 2.0 version of the modules (need to test with more third party libraries)\r\n\r\nping: @slavchev @blagoev @Pip3r4o @atanasovg "},"comment":{"url":"https://api.github.com/repos/NativeScript/android-runtime/issues/comments/224866455","html_url":"https://github.com/NativeScript/android-runtime/pull/457#issuecomment-224866455","issue_url":"https://api.github.com/repos/NativeScript/android-runtime/issues/457","id":224866455,"user":{"login":"Plamen5kov","id":5918351,"avatar_url":"https://avatars.githubusercontent.com/u/5918351?v=3","gravatar_id":"","url":"https://api.github.com/users/Plamen5kov","html_url":"https://github.com/Plamen5kov","followers_url":"https://api.github.com/users/Plamen5kov/followers","following_url":"https://api.github.com/users/Plamen5kov/following{/other_user}","gists_url":"https://api.github.com/users/Plamen5kov/gists{/gist_id}","starred_url":"https://api.github.com/users/Plamen5kov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plamen5kov/subscriptions","organizations_url":"https://api.github.com/users/Plamen5kov/orgs","repos_url":"https://api.github.com/users/Plamen5kov/repos","events_url":"https://api.github.com/users/Plamen5kov/events{/privacy}","received_events_url":"https://api.github.com/users/Plamen5kov/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T11:17:27Z","updated_at":"2016-06-09T11:17:27Z","body":"As @jasssonpet states the environment variable approach is temporary. \r\n\r\n---\r\n* `...TNS_TYPESCRIPT_DECLARATIONS_PATH variable we want to have denotes an output path (am I right?)...`\r\n* @ErjanGavalji you are right.\r\n\r\n---\r\n* `Before we proceed with this pull, I'd like us to verify how is it working with real TypeScript applications and plugins.`\r\n* @atanasovg I think you're right. I've tested the dts generation only against our tns-core-modules, but a more extensive testing is needed before figuring out the final way the build-tools will work together, however I hope we can agree to an iterative approach, and implement the features in the dts generator one by one, starting with the minimal required dts files that will support our tns-core-modules.\r\n\r\n---\r\n"}}
{"actor":{"display_login":"Plamen5kov"}}