{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/flow/issues/1753","repository_url":"https://api.github.com/repos/facebook/flow","labels_url":"https://api.github.com/repos/facebook/flow/issues/1753/labels{/name}","comments_url":"https://api.github.com/repos/facebook/flow/issues/1753/comments","events_url":"https://api.github.com/repos/facebook/flow/issues/1753/events","html_url":"https://github.com/facebook/flow/pull/1753","id":153488653,"number":1753,"title":"Fix Makefile rebuilding of object files","user":{"login":"mroch","id":3012,"avatar_url":"https://avatars.githubusercontent.com/u/3012?v=3","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-06T16:28:32Z","updated_at":"2016-05-06T16:28:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/flow/pulls/1753","html_url":"https://github.com/facebook/flow/pull/1753","diff_url":"https://github.com/facebook/flow/pull/1753.diff","patch_url":"https://github.com/facebook/flow/pull/1753.patch"},"body":"I was having problems with `make` not picking up changes to `.c` files. I think the problem is that `build-flow` depends on `build-flow-native-deps` which does not actually depend on the `.c` files, so that step was getting skipped.\r\n\r\nAs I started tweaking stuff, I eventually just replaced the target that runs `ocamlbuild` on all `.o` files with a rule that directly runs `ocamlopt` on each `.c` file, letting `make` instead of `ocamlbuild` decide when it's dirty. this is faster.\r\n\r\nTest Plan: changed hh_shared.c, ran `make`. before, it wasn't picking up my changes unless I deleted `_build/`. after, it works. running `make` again doesn't rebuild things that are clean."},"comment":{"url":"https://api.github.com/repos/facebook/flow/issues/comments/217490998","html_url":"https://github.com/facebook/flow/pull/1753#issuecomment-217490998","issue_url":"https://api.github.com/repos/facebook/flow/issues/1753","id":217490998,"user":{"login":"mroch","id":3012,"avatar_url":"https://avatars.githubusercontent.com/u/3012?v=3","gravatar_id":"","url":"https://api.github.com/users/mroch","html_url":"https://github.com/mroch","followers_url":"https://api.github.com/users/mroch/followers","following_url":"https://api.github.com/users/mroch/following{/other_user}","gists_url":"https://api.github.com/users/mroch/gists{/gist_id}","starred_url":"https://api.github.com/users/mroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroch/subscriptions","organizations_url":"https://api.github.com/users/mroch/orgs","repos_url":"https://api.github.com/users/mroch/repos","events_url":"https://api.github.com/users/mroch/events{/privacy}","received_events_url":"https://api.github.com/users/mroch/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T16:28:43Z","updated_at":"2016-05-06T16:28:43Z","body":"@facebook-github-bot import"}}