{"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/84682991","pull_request_review_id":5444322,"id":84682991,"diff_hunk":"@@ -39,22 +39,40 @@\n \n     protected PrefetchInfo prefetchInfo;\n \n+    protected Set<String> subtypes;\n+\n+    protected Set<String> blacklistedSubtypes;\n+\n+    protected Set<String> allowedSubtypes;\n+\n     /**\n      * Constructs a document type. Schemas and facets must include those from the super type.\n      */\n     public DocumentTypeImpl(String name, DocumentType superType, List<Schema> schemas, Collection<String> facets,\n-            PrefetchInfo prefetchInfo) {\n+            PrefetchInfo prefetchInfo, Collection<String> subtypes, Collection<String> blacklistedSubtypes) {","path":"nuxeo-core/nuxeo-core-schema/src/main/java/org/nuxeo/ecm/core/schema/DocumentTypeImpl.java","position":15,"original_position":15,"commit_id":"71f072593f04b6560668faf7fe0195d245ccae10","original_commit_id":"71f072593f04b6560668faf7fe0195d245ccae10","user":{"login":"troger","id":116786,"avatar_url":"https://avatars.githubusercontent.com/u/116786?v=3","gravatar_id":"","url":"https://api.github.com/users/troger","html_url":"https://github.com/troger","followers_url":"https://api.github.com/users/troger/followers","following_url":"https://api.github.com/users/troger/following{/other_user}","gists_url":"https://api.github.com/users/troger/gists{/gist_id}","starred_url":"https://api.github.com/users/troger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troger/subscriptions","organizations_url":"https://api.github.com/users/troger/orgs","repos_url":"https://api.github.com/users/troger/repos","events_url":"https://api.github.com/users/troger/events{/privacy}","received_events_url":"https://api.github.com/users/troger/received_events","type":"User","site_admin":false},"body":"As it's a public API, you should keep the old method there and add a new one with your new args.","created_at":"2016-10-24T13:09:44Z","updated_at":"2016-10-24T13:22:11Z","html_url":"https://github.com/nuxeo/nuxeo/pull/302#discussion_r84682991","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/84682991"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/302#discussion_r84682991"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302","id":90584615,"html_url":"https://github.com/nuxeo/nuxeo/pull/302","diff_url":"https://github.com/nuxeo/nuxeo/pull/302.diff","patch_url":"https://github.com/nuxeo/nuxeo/pull/302.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/302","number":302,"state":"open","locked":false,"title":"NXP-20571: add subtype declaration to core","user":{"login":"Gabez0r","id":13537427,"avatar_url":"https://avatars.githubusercontent.com/u/13537427?v=3","gravatar_id":"","url":"https://api.github.com/users/Gabez0r","html_url":"https://github.com/Gabez0r","followers_url":"https://api.github.com/users/Gabez0r/followers","following_url":"https://api.github.com/users/Gabez0r/following{/other_user}","gists_url":"https://api.github.com/users/Gabez0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabez0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabez0r/subscriptions","organizations_url":"https://api.github.com/users/Gabez0r/orgs","repos_url":"https://api.github.com/users/Gabez0r/repos","events_url":"https://api.github.com/users/Gabez0r/events{/privacy}","received_events_url":"https://api.github.com/users/Gabez0r/received_events","type":"User","site_admin":false},"body":"Proposal to add subtype declaration at the core level, while still propagating subtype definitions on nuxeo-platform-types to core.","created_at":"2016-10-24T10:19:41Z","updated_at":"2016-10-24T13:22:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96e9d80bb8d11514f51f49a572c8589d072775ca","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/302/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/71f072593f04b6560668faf7fe0195d245ccae10","head":{"label":"nuxeo:feature-NXP-20571-move-subtype-declaration-to-core","ref":"feature-NXP-20571-move-subtype-declaration-to-core","sha":"71f072593f04b6560668faf7fe0195d245ccae10","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"name":"nuxeo","full_name":"nuxeo/nuxeo","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2016-10-24T09:18:31Z","pushed_at":"2016-10-24T13:04:59Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":253256,"stargazers_count":120,"watchers_count":120,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":17,"forks":89,"open_issues":17,"watchers":120,"default_branch":"master"}},"base":{"label":"nuxeo:master","ref":"master","sha":"de0644091acaeaedc8ad513ec122b113dc491577","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"name":"nuxeo","full_name":"nuxeo/nuxeo","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2016-10-24T09:18:31Z","pushed_at":"2016-10-24T13:04:59Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":253256,"stargazers_count":120,"watchers_count":120,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":17,"forks":89,"open_issues":17,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/302"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/302"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo/statuses/71f072593f04b6560668faf7fe0195d245ccae10"}}}}
{"actor":{"display_login":"troger"}}