{"action":"created","issue":{"url":"https://api.github.com/repos/Nexxado/ProjectHands/issues/5","repository_url":"https://api.github.com/repos/Nexxado/ProjectHands","labels_url":"https://api.github.com/repos/Nexxado/ProjectHands/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/Nexxado/ProjectHands/issues/5/comments","events_url":"https://api.github.com/repos/Nexxado/ProjectHands/issues/5/events","html_url":"https://github.com/Nexxado/ProjectHands/issues/5","id":143799351,"number":5,"title":"SDS Document","user":{"login":"Nexxado","id":12609607,"avatar_url":"https://avatars.githubusercontent.com/u/12609607?v=3","gravatar_id":"","url":"https://api.github.com/users/Nexxado","html_url":"https://github.com/Nexxado","followers_url":"https://api.github.com/users/Nexxado/followers","following_url":"https://api.github.com/users/Nexxado/following{/other_user}","gists_url":"https://api.github.com/users/Nexxado/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexxado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexxado/subscriptions","organizations_url":"https://api.github.com/users/Nexxado/orgs","repos_url":"https://api.github.com/users/Nexxado/repos","events_url":"https://api.github.com/users/Nexxado/events{/privacy}","received_events_url":"https://api.github.com/users/Nexxado/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Nexxado/ProjectHands/labels/Course%20Submission","name":"Course Submission","color":"009688"}],"state":"open","locked":false,"assignee":{"login":"ItamarShDev","id":953371,"avatar_url":"https://avatars.githubusercontent.com/u/953371?v=3","gravatar_id":"","url":"https://api.github.com/users/ItamarShDev","html_url":"https://github.com/ItamarShDev","followers_url":"https://api.github.com/users/ItamarShDev/followers","following_url":"https://api.github.com/users/ItamarShDev/following{/other_user}","gists_url":"https://api.github.com/users/ItamarShDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ItamarShDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItamarShDev/subscriptions","organizations_url":"https://api.github.com/users/ItamarShDev/orgs","repos_url":"https://api.github.com/users/ItamarShDev/repos","events_url":"https://api.github.com/users/ItamarShDev/events{/privacy}","received_events_url":"https://api.github.com/users/ItamarShDev/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-03-27T11:19:24Z","updated_at":"2016-03-30T09:15:36Z","closed_at":null,"body":"Finished [SDS document](https://github.com/Nexxado/ProjectHands/wiki/SDS)\r\n"},"comment":{"url":"https://api.github.com/repos/Nexxado/ProjectHands/issues/comments/203339012","html_url":"https://github.com/Nexxado/ProjectHands/issues/5#issuecomment-203339012","issue_url":"https://api.github.com/repos/Nexxado/ProjectHands/issues/5","id":203339012,"user":{"login":"robi-y","id":1009495,"avatar_url":"https://avatars.githubusercontent.com/u/1009495?v=3","gravatar_id":"","url":"https://api.github.com/users/robi-y","html_url":"https://github.com/robi-y","followers_url":"https://api.github.com/users/robi-y/followers","following_url":"https://api.github.com/users/robi-y/following{/other_user}","gists_url":"https://api.github.com/users/robi-y/gists{/gist_id}","starred_url":"https://api.github.com/users/robi-y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robi-y/subscriptions","organizations_url":"https://api.github.com/users/robi-y/orgs","repos_url":"https://api.github.com/users/robi-y/repos","events_url":"https://api.github.com/users/robi-y/events{/privacy}","received_events_url":"https://api.github.com/users/robi-y/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T09:15:36Z","updated_at":"2016-03-30T09:15:36Z","body":"I'm writing here a detailed review:\r\n### SDS Page\r\n- well organised (:+1: for the table of content)\r\n- excellent document goal\r\n- Capabilities list (originally was not connected to risks - corrected)\r\n- links to updated risk plan (I see it was updated), user manual (headers are just fine for now), review summary (please add a section what you fixed following the oral and written review and update in this issue comments) \r\n\r\n- Diagrams\r\n  - use of official UML diagrams :+1: \r\n  - excellent explanations of diagram purpose, considerataios and risks.\r\n  - class diagram: nice use of multiplicities on class relations\r\n  - state diagram: I'm not sure it is so interesting, we dicussed on class allready\r\n  - sequence diagram (actually one behaviral diagram is enough): I prefer describing more uniqe scenarios than login and register (and you explained that you have a uniqe registration process)\r\n\r\n- Sections\r\n  - Persistent: many times it is good to add a diagram for the DB tables (e.g. ERD)\r\n  - non-functional requirements: the first two are really parts of the functional ones.\r\n  - :100: : for starting a test plan (although it was optional), it is \r\n\r\n- Review Summary\r\n  - please complete and let us know when ready\r\n\r\nExcellent work! keep it"}}