{"action":"created","comment":{"url":"https://api.github.com/repos/samkhal/biped/pulls/comments/90910128","pull_request_review_id":11423615,"id":90910128,"diff_hunk":"@@ -0,0 +1,107 @@\n+// Implementation of slave_bridge.hpp","path":"serial_communication/serial_bridge/slave/slave_bridge_impl.hpp","position":1,"original_position":1,"commit_id":"b0abe1969dd1c7101a36e16e15c770c7dfca388e","original_commit_id":"b0abe1969dd1c7101a36e16e15c770c7dfca388e","user":{"login":"samkhal","id":5384883,"avatar_url":"https://avatars.githubusercontent.com/u/5384883?v=3","gravatar_id":"","url":"https://api.github.com/users/samkhal","html_url":"https://github.com/samkhal","followers_url":"https://api.github.com/users/samkhal/followers","following_url":"https://api.github.com/users/samkhal/following{/other_user}","gists_url":"https://api.github.com/users/samkhal/gists{/gist_id}","starred_url":"https://api.github.com/users/samkhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samkhal/subscriptions","organizations_url":"https://api.github.com/users/samkhal/orgs","repos_url":"https://api.github.com/users/samkhal/repos","events_url":"https://api.github.com/users/samkhal/events{/privacy}","received_events_url":"https://api.github.com/users/samkhal/received_events","type":"User","site_admin":false},"body":"Since templated functions must be generated at compile time, their definitions must be available from `#include` statements; otherwise the compiler has no way of knowing how to create them. So all of the code is in header files, but I separated out the implementation and included it from the bottom of slave_bridge.hpp","created_at":"2016-12-05T17:09:13Z","updated_at":"2016-12-05T17:09:13Z","html_url":"https://github.com/samkhal/biped/pull/2#discussion_r90910128","pull_request_url":"https://api.github.com/repos/samkhal/biped/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/samkhal/biped/pulls/comments/90910128"},"html":{"href":"https://github.com/samkhal/biped/pull/2#discussion_r90910128"},"pull_request":{"href":"https://api.github.com/repos/samkhal/biped/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/samkhal/biped/pulls/2","id":96563096,"html_url":"https://github.com/samkhal/biped/pull/2","diff_url":"https://github.com/samkhal/biped/pull/2.diff","patch_url":"https://github.com/samkhal/biped/pull/2.patch","issue_url":"https://api.github.com/repos/samkhal/biped/issues/2","number":2,"state":"open","locked":false,"title":"all of serial bridge","user":{"login":"samkhal","id":5384883,"avatar_url":"https://avatars.githubusercontent.com/u/5384883?v=3","gravatar_id":"","url":"https://api.github.com/users/samkhal","html_url":"https://github.com/samkhal","followers_url":"https://api.github.com/users/samkhal/followers","following_url":"https://api.github.com/users/samkhal/following{/other_user}","gists_url":"https://api.github.com/users/samkhal/gists{/gist_id}","starred_url":"https://api.github.com/users/samkhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samkhal/subscriptions","organizations_url":"https://api.github.com/users/samkhal/orgs","repos_url":"https://api.github.com/users/samkhal/repos","events_url":"https://api.github.com/users/samkhal/events{/privacy}","received_events_url":"https://api.github.com/users/samkhal/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/samkhal/biped/2)\n<!-- Reviewable:end -->\n","created_at":"2016-12-05T16:35:32Z","updated_at":"2016-12-05T17:09:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaceeb4f5526592b39becd6c3604e4acd4ccadd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/samkhal/biped/pulls/2/commits","review_comments_url":"https://api.github.com/repos/samkhal/biped/pulls/2/comments","review_comment_url":"https://api.github.com/repos/samkhal/biped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samkhal/biped/issues/2/comments","statuses_url":"https://api.github.com/repos/samkhal/biped/statuses/b0abe1969dd1c7101a36e16e15c770c7dfca388e","head":{"label":"samkhal:review-changes","ref":"review-changes","sha":"b0abe1969dd1c7101a36e16e15c770c7dfca388e","user":{"login":"samkhal","id":5384883,"avatar_url":"https://avatars.githubusercontent.com/u/5384883?v=3","gravatar_id":"","url":"https://api.github.com/users/samkhal","html_url":"https://github.com/samkhal","followers_url":"https://api.github.com/users/samkhal/followers","following_url":"https://api.github.com/users/samkhal/following{/other_user}","gists_url":"https://api.github.com/users/samkhal/gists{/gist_id}","starred_url":"https://api.github.com/users/samkhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samkhal/subscriptions","organizations_url":"https://api.github.com/users/samkhal/orgs","repos_url":"https://api.github.com/users/samkhal/repos","events_url":"https://api.github.com/users/samkhal/events{/privacy}","received_events_url":"https://api.github.com/users/samkhal/received_events","type":"User","site_admin":false},"repo":{"id":51670384,"name":"biped","full_name":"samkhal/biped","owner":{"login":"samkhal","id":5384883,"avatar_url":"https://avatars.githubusercontent.com/u/5384883?v=3","gravatar_id":"","url":"https://api.github.com/users/samkhal","html_url":"https://github.com/samkhal","followers_url":"https://api.github.com/users/samkhal/followers","following_url":"https://api.github.com/users/samkhal/following{/other_user}","gists_url":"https://api.github.com/users/samkhal/gists{/gist_id}","starred_url":"https://api.github.com/users/samkhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samkhal/subscriptions","organizations_url":"https://api.github.com/users/samkhal/orgs","repos_url":"https://api.github.com/users/samkhal/repos","events_url":"https://api.github.com/users/samkhal/events{/privacy}","received_events_url":"https://api.github.com/users/samkhal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samkhal/biped","description":null,"fork":false,"url":"https://api.github.com/repos/samkhal/biped","forks_url":"https://api.github.com/repos/samkhal/biped/forks","keys_url":"https://api.github.com/repos/samkhal/biped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samkhal/biped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samkhal/biped/teams","hooks_url":"https://api.github.com/repos/samkhal/biped/hooks","issue_events_url":"https://api.github.com/repos/samkhal/biped/issues/events{/number}","events_url":"https://api.github.com/repos/samkhal/biped/events","assignees_url":"https://api.github.com/repos/samkhal/biped/assignees{/user}","branches_url":"https://api.github.com/repos/samkhal/biped/branches{/branch}","tags_url":"https://api.github.com/repos/samkhal/biped/tags","blobs_url":"https://api.github.com/repos/samkhal/biped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samkhal/biped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samkhal/biped/git/refs{/sha}","trees_url":"https://api.github.com/repos/samkhal/biped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samkhal/biped/statuses/{sha}","languages_url":"https://api.github.com/repos/samkhal/biped/languages","stargazers_url":"https://api.github.com/repos/samkhal/biped/stargazers","contributors_url":"https://api.github.com/repos/samkhal/biped/contributors","subscribers_url":"https://api.github.com/repos/samkhal/biped/subscribers","subscription_url":"https://api.github.com/repos/samkhal/biped/subscription","commits_url":"https://api.github.com/repos/samkhal/biped/commits{/sha}","git_commits_url":"https://api.github.com/repos/samkhal/biped/git/commits{/sha}","comments_url":"https://api.github.com/repos/samkhal/biped/comments{/number}","issue_comment_url":"https://api.github.com/repos/samkhal/biped/issues/comments{/number}","contents_url":"https://api.github.com/repos/samkhal/biped/contents/{+path}","compare_url":"https://api.github.com/repos/samkhal/biped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samkhal/biped/merges","archive_url":"https://api.github.com/repos/samkhal/biped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samkhal/biped/downloads","issues_url":"https://api.github.com/repos/samkhal/biped/issues{/number}","pulls_url":"https://api.github.com/repos/samkhal/biped/pulls{/number}","milestones_url":"https://api.github.com/repos/samkhal/biped/milestones{/number}","notifications_url":"https://api.github.com/repos/samkhal/biped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samkhal/biped/labels{/name}","releases_url":"https://api.github.com/repos/samkhal/biped/releases{/id}","deployments_url":"https://api.github.com/repos/samkhal/biped/deployments","created_at":"2016-02-13T23:16:07Z","updated_at":"2016-02-13T23:17:11Z","pushed_at":"2016-12-05T16:37:26Z","git_url":"git://github.com/samkhal/biped.git","ssh_url":"git@github.com:samkhal/biped.git","clone_url":"https://github.com/samkhal/biped.git","svn_url":"https://github.com/samkhal/biped","homepage":null,"size":183371,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"samkhal:review-base","ref":"review-base","sha":"a791086a4b9535e7dc0f8d641cd59ab30f068a07","user":{"login":"samkhal","id":5384883,"avatar_url":"https://avatars.githubusercontent.com/u/5384883?v=3","gravatar_id":"","url":"https://api.github.com/users/samkhal","html_url":"https://github.com/samkhal","followers_url":"https://api.github.com/users/samkhal/followers","following_url":"https://api.github.com/users/samkhal/following{/other_user}","gists_url":"https://api.github.com/users/samkhal/gists{/gist_id}","starred_url":"https://api.github.com/users/samkhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samkhal/subscriptions","organizations_url":"https://api.github.com/users/samkhal/orgs","repos_url":"https://api.github.com/users/samkhal/repos","events_url":"https://api.github.com/users/samkhal/events{/privacy}","received_events_url":"https://api.github.com/users/samkhal/received_events","type":"User","site_admin":false},"repo":{"id":51670384,"name":"biped","full_name":"samkhal/biped","owner":{"login":"samkhal","id":5384883,"avatar_url":"https://avatars.githubusercontent.com/u/5384883?v=3","gravatar_id":"","url":"https://api.github.com/users/samkhal","html_url":"https://github.com/samkhal","followers_url":"https://api.github.com/users/samkhal/followers","following_url":"https://api.github.com/users/samkhal/following{/other_user}","gists_url":"https://api.github.com/users/samkhal/gists{/gist_id}","starred_url":"https://api.github.com/users/samkhal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samkhal/subscriptions","organizations_url":"https://api.github.com/users/samkhal/orgs","repos_url":"https://api.github.com/users/samkhal/repos","events_url":"https://api.github.com/users/samkhal/events{/privacy}","received_events_url":"https://api.github.com/users/samkhal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samkhal/biped","description":null,"fork":false,"url":"https://api.github.com/repos/samkhal/biped","forks_url":"https://api.github.com/repos/samkhal/biped/forks","keys_url":"https://api.github.com/repos/samkhal/biped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samkhal/biped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samkhal/biped/teams","hooks_url":"https://api.github.com/repos/samkhal/biped/hooks","issue_events_url":"https://api.github.com/repos/samkhal/biped/issues/events{/number}","events_url":"https://api.github.com/repos/samkhal/biped/events","assignees_url":"https://api.github.com/repos/samkhal/biped/assignees{/user}","branches_url":"https://api.github.com/repos/samkhal/biped/branches{/branch}","tags_url":"https://api.github.com/repos/samkhal/biped/tags","blobs_url":"https://api.github.com/repos/samkhal/biped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samkhal/biped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samkhal/biped/git/refs{/sha}","trees_url":"https://api.github.com/repos/samkhal/biped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samkhal/biped/statuses/{sha}","languages_url":"https://api.github.com/repos/samkhal/biped/languages","stargazers_url":"https://api.github.com/repos/samkhal/biped/stargazers","contributors_url":"https://api.github.com/repos/samkhal/biped/contributors","subscribers_url":"https://api.github.com/repos/samkhal/biped/subscribers","subscription_url":"https://api.github.com/repos/samkhal/biped/subscription","commits_url":"https://api.github.com/repos/samkhal/biped/commits{/sha}","git_commits_url":"https://api.github.com/repos/samkhal/biped/git/commits{/sha}","comments_url":"https://api.github.com/repos/samkhal/biped/comments{/number}","issue_comment_url":"https://api.github.com/repos/samkhal/biped/issues/comments{/number}","contents_url":"https://api.github.com/repos/samkhal/biped/contents/{+path}","compare_url":"https://api.github.com/repos/samkhal/biped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samkhal/biped/merges","archive_url":"https://api.github.com/repos/samkhal/biped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samkhal/biped/downloads","issues_url":"https://api.github.com/repos/samkhal/biped/issues{/number}","pulls_url":"https://api.github.com/repos/samkhal/biped/pulls{/number}","milestones_url":"https://api.github.com/repos/samkhal/biped/milestones{/number}","notifications_url":"https://api.github.com/repos/samkhal/biped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samkhal/biped/labels{/name}","releases_url":"https://api.github.com/repos/samkhal/biped/releases{/id}","deployments_url":"https://api.github.com/repos/samkhal/biped/deployments","created_at":"2016-02-13T23:16:07Z","updated_at":"2016-02-13T23:17:11Z","pushed_at":"2016-12-05T16:37:26Z","git_url":"git://github.com/samkhal/biped.git","ssh_url":"git@github.com:samkhal/biped.git","clone_url":"https://github.com/samkhal/biped.git","svn_url":"https://github.com/samkhal/biped","homepage":null,"size":183371,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samkhal/biped/pulls/2"},"html":{"href":"https://github.com/samkhal/biped/pull/2"},"issue":{"href":"https://api.github.com/repos/samkhal/biped/issues/2"},"comments":{"href":"https://api.github.com/repos/samkhal/biped/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/samkhal/biped/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/samkhal/biped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samkhal/biped/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/samkhal/biped/statuses/b0abe1969dd1c7101a36e16e15c770c7dfca388e"}}}}
{"actor":{"display_login":"samkhal"}}