{"action":"created","issue":{"url":"https://api.github.com/repos/apache/storm/issues/1209","repository_url":"https://api.github.com/repos/apache/storm","labels_url":"https://api.github.com/repos/apache/storm/issues/1209/labels{/name}","comments_url":"https://api.github.com/repos/apache/storm/issues/1209/comments","events_url":"https://api.github.com/repos/apache/storm/issues/1209/events","html_url":"https://github.com/apache/storm/pull/1209","id":140516537,"number":1209,"title":"STORM-956: When the execute() or nextTuple() hang on external resources, stop the Worker's heartbeat","user":{"login":"srdo","id":4324588,"avatar_url":"https://avatars.githubusercontent.com/u/4324588?v=3","gravatar_id":"","url":"https://api.github.com/users/srdo","html_url":"https://github.com/srdo","followers_url":"https://api.github.com/users/srdo/followers","following_url":"https://api.github.com/users/srdo/following{/other_user}","gists_url":"https://api.github.com/users/srdo/gists{/gist_id}","starred_url":"https://api.github.com/users/srdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srdo/subscriptions","organizations_url":"https://api.github.com/users/srdo/orgs","repos_url":"https://api.github.com/users/srdo/repos","events_url":"https://api.github.com/users/srdo/events{/privacy}","received_events_url":"https://api.github.com/users/srdo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-13T19:06:28Z","updated_at":"2016-03-13T19:34:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/1209","html_url":"https://github.com/apache/storm/pull/1209","diff_url":"https://github.com/apache/storm/pull/1209.diff","patch_url":"https://github.com/apache/storm/pull/1209.patch"},"body":"The previous PR at https://github.com/apache/storm/pull/647 doesn't look active anymore. Having Storm tell you which components are backing up would still be a nice feature to have.\r\n\r\nI've taken a look at implementing the suggestions from the previous PR, but I have a few questions.\r\n\r\nThe previous discussion seemed to point toward shutting down the worker when an executor is hanging. I'm guessing there's no nice way to just restart the hanging executors? Is it sufficient to call shutdown on the worker object from do-executor-heartbeats?\r\n\r\nI'm not really sure what Constants/SYSTEM_EXECUTOR_ID is for? Should it be ignored when checking for hanging executors?\r\n\r\nI'm hoping to add the zookeeper/metrics logging and shutdown functionality soon if the idea of this PR is sound."},"comment":{"url":"https://api.github.com/repos/apache/storm/issues/comments/196028832","html_url":"https://github.com/apache/storm/pull/1209#issuecomment-196028832","issue_url":"https://api.github.com/repos/apache/storm/issues/1209","id":196028832,"user":{"login":"srdo","id":4324588,"avatar_url":"https://avatars.githubusercontent.com/u/4324588?v=3","gravatar_id":"","url":"https://api.github.com/users/srdo","html_url":"https://github.com/srdo","followers_url":"https://api.github.com/users/srdo/followers","following_url":"https://api.github.com/users/srdo/following{/other_user}","gists_url":"https://api.github.com/users/srdo/gists{/gist_id}","starred_url":"https://api.github.com/users/srdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srdo/subscriptions","organizations_url":"https://api.github.com/users/srdo/orgs","repos_url":"https://api.github.com/users/srdo/repos","events_url":"https://api.github.com/users/srdo/events{/privacy}","received_events_url":"https://api.github.com/users/srdo/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T19:34:11Z","updated_at":"2016-03-13T19:34:11Z","body":"I don't want this merged yet, just posted to get feedback :)"}}