{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/51203537","id":51203537,"diff_hunk":"@@ -66,11 +66,13 @@ The [http-liveness.yaml](http-liveness.yaml) demonstrates the HTTP check.\n       httpGet:\n         path: /healthz\n         port: 8080\n+        httpHeaders:\n+          X-Custom-Header: [ Awesome ]","path":"docs/user-guide/liveness/README.md","position":5,"original_position":5,"commit_id":"ad88a00d9484f22312047af18c7cbae5588abb37","original_commit_id":"46817ee9eb2c3b37789da96216e03459adefd8f6","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":"Yeah, that's a good question. @thockin's way is probably more consistent with the rest of the API but the current way is going to be a lot more compact. I don't think there's much risk of us wanting to add other fields in here, so I guess I have an extremely minor preference for the current way. up to @thockin ","created_at":"2016-01-28T23:10:32Z","updated_at":"2016-01-28T23:10:32Z","html_url":"https://github.com/kubernetes/kubernetes/pull/20116#discussion_r51203537","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/51203537"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20116#discussion_r51203537"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116","id":57144770,"html_url":"https://github.com/kubernetes/kubernetes/pull/20116","diff_url":"https://github.com/kubernetes/kubernetes/pull/20116.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/20116.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20116","number":20116,"state":"open","locked":false,"title":"Add httpHeaders to httpGet liveness probe","user":{"login":"therc","id":13481082,"avatar_url":"https://avatars.githubusercontent.com/u/13481082?v=3","gravatar_id":"","url":"https://api.github.com/users/therc","html_url":"https://github.com/therc","followers_url":"https://api.github.com/users/therc/followers","following_url":"https://api.github.com/users/therc/following{/other_user}","gists_url":"https://api.github.com/users/therc/gists{/gist_id}","starred_url":"https://api.github.com/users/therc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therc/subscriptions","organizations_url":"https://api.github.com/users/therc/orgs","repos_url":"https://api.github.com/users/therc/repos","events_url":"https://api.github.com/users/therc/events{/privacy}","received_events_url":"https://api.github.com/users/therc/received_events","type":"User","site_admin":false},"body":"Also update existing documentation and try to steer users away from 'host'.\r\n\r\nFixes #14713 \r\n\r\ncc: @thockin ","created_at":"2016-01-25T23:00:28Z","updated_at":"2016-01-28T23:10:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9cc428d58cc4242facfe506cd6a6fb8b53914a1","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20116/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ad88a00d9484f22312047af18c7cbae5588abb37","head":{"label":"Clarifai:http-headers","ref":"http-headers","sha":"ad88a00d9484f22312047af18c7cbae5588abb37","user":{"login":"Clarifai","id":8550654,"avatar_url":"https://avatars.githubusercontent.com/u/8550654?v=3","gravatar_id":"","url":"https://api.github.com/users/Clarifai","html_url":"https://github.com/Clarifai","followers_url":"https://api.github.com/users/Clarifai/followers","following_url":"https://api.github.com/users/Clarifai/following{/other_user}","gists_url":"https://api.github.com/users/Clarifai/gists{/gist_id}","starred_url":"https://api.github.com/users/Clarifai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clarifai/subscriptions","organizations_url":"https://api.github.com/users/Clarifai/orgs","repos_url":"https://api.github.com/users/Clarifai/repos","events_url":"https://api.github.com/users/Clarifai/events{/privacy}","received_events_url":"https://api.github.com/users/Clarifai/received_events","type":"Organization","site_admin":false},"repo":{"id":49165232,"name":"kubernetes","full_name":"Clarifai/kubernetes","owner":{"login":"Clarifai","id":8550654,"avatar_url":"https://avatars.githubusercontent.com/u/8550654?v=3","gravatar_id":"","url":"https://api.github.com/users/Clarifai","html_url":"https://github.com/Clarifai","followers_url":"https://api.github.com/users/Clarifai/followers","following_url":"https://api.github.com/users/Clarifai/following{/other_user}","gists_url":"https://api.github.com/users/Clarifai/gists{/gist_id}","starred_url":"https://api.github.com/users/Clarifai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clarifai/subscriptions","organizations_url":"https://api.github.com/users/Clarifai/orgs","repos_url":"https://api.github.com/users/Clarifai/repos","events_url":"https://api.github.com/users/Clarifai/events{/privacy}","received_events_url":"https://api.github.com/users/Clarifai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clarifai/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/Clarifai/kubernetes","forks_url":"https://api.github.com/repos/Clarifai/kubernetes/forks","keys_url":"https://api.github.com/repos/Clarifai/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clarifai/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clarifai/kubernetes/teams","hooks_url":"https://api.github.com/repos/Clarifai/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Clarifai/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Clarifai/kubernetes/events","assignees_url":"https://api.github.com/repos/Clarifai/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Clarifai/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Clarifai/kubernetes/tags","blobs_url":"https://api.github.com/repos/Clarifai/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clarifai/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clarifai/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clarifai/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clarifai/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Clarifai/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Clarifai/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Clarifai/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Clarifai/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Clarifai/kubernetes/subscription","commits_url":"https://api.github.com/repos/Clarifai/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clarifai/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clarifai/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clarifai/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clarifai/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Clarifai/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clarifai/kubernetes/merges","archive_url":"https://api.github.com/repos/Clarifai/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clarifai/kubernetes/downloads","issues_url":"https://api.github.com/repos/Clarifai/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Clarifai/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Clarifai/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Clarifai/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clarifai/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Clarifai/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Clarifai/kubernetes/deployments","created_at":"2016-01-06T22:19:11Z","updated_at":"2016-01-11T08:28:58Z","pushed_at":"2016-01-28T21:50:28Z","git_url":"git://github.com/Clarifai/kubernetes.git","ssh_url":"git@github.com:Clarifai/kubernetes.git","clone_url":"https://github.com/Clarifai/kubernetes.git","svn_url":"https://github.com/Clarifai/kubernetes","homepage":"http://kubernetes.io","size":155435,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"326a29d706c84f97b1dae80a6ab426645c4295a1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-28T20:57:33Z","pushed_at":"2016-01-28T23:08:23Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":311935,"stargazers_count":12398,"watchers_count":12398,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3504,"mirror_url":null,"open_issues_count":2852,"forks":3504,"open_issues":2852,"watchers":12398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20116"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20116"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20116/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20116/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ad88a00d9484f22312047af18c7cbae5588abb37"}}}}