{"action":"created","issue":{"url":"https://api.github.com/repos/OpenSC/OpenSC/issues/856","repository_url":"https://api.github.com/repos/OpenSC/OpenSC","labels_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/856/labels{/name}","comments_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/856/comments","events_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/856/events","html_url":"https://github.com/OpenSC/OpenSC/pull/856","id":171824822,"number":856,"title":"Fixing of pinpad problem.","user":{"login":"larssilven","id":6523478,"avatar_url":"https://avatars.githubusercontent.com/u/6523478?v=3","gravatar_id":"","url":"https://api.github.com/users/larssilven","html_url":"https://github.com/larssilven","followers_url":"https://api.github.com/users/larssilven/followers","following_url":"https://api.github.com/users/larssilven/following{/other_user}","gists_url":"https://api.github.com/users/larssilven/gists{/gist_id}","starred_url":"https://api.github.com/users/larssilven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larssilven/subscriptions","organizations_url":"https://api.github.com/users/larssilven/orgs","repos_url":"https://api.github.com/users/larssilven/repos","events_url":"https://api.github.com/users/larssilven/events{/privacy}","received_events_url":"https://api.github.com/users/larssilven/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-18T06:08:11Z","updated_at":"2016-08-26T20:29:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenSC/OpenSC/pulls/856","html_url":"https://github.com/OpenSC/OpenSC/pull/856","diff_url":"https://github.com/OpenSC/OpenSC/pull/856.diff","patch_url":"https://github.com/OpenSC/OpenSC/pull/856.patch"},"body":"\r\n\r\nThere is a problem with pinpad readers and the myeid smart card.\r\nI believe there will be similar problems with other cards.\r\n\r\nC_Login works fine when done with a NULL_PTR PIN; the pinpad prompts the user for PIN and then a CHV is done when entered.\r\nBut then if more than one C_xxx is done requiring the application to be logged on; this second C_xxx will fail with p11 error code CKR_PIN_LEN_RANGE (0xA2).\r\n\r\nThis fixes the p11 so that the user will be prompted for PIN on the pinpad every time a CHV is needed.\r\nMaybe there is a better way to fix this bogus long PIN code (256 chars) than done in this request. Someone with good opensc knowledge ought to review it and change it if needed.\r\n\r\nAlso the myeid card should format the PIN objects so that no extra CHV is needed after C_Logon until C_Logout or application end.\r\n"},"comment":{"url":"https://api.github.com/repos/OpenSC/OpenSC/issues/comments/242843187","html_url":"https://github.com/OpenSC/OpenSC/pull/856#issuecomment-242843187","issue_url":"https://api.github.com/repos/OpenSC/OpenSC/issues/856","id":242843187,"user":{"login":"dengert","id":865329,"avatar_url":"https://avatars.githubusercontent.com/u/865329?v=3","gravatar_id":"","url":"https://api.github.com/users/dengert","html_url":"https://github.com/dengert","followers_url":"https://api.github.com/users/dengert/followers","following_url":"https://api.github.com/users/dengert/following{/other_user}","gists_url":"https://api.github.com/users/dengert/gists{/gist_id}","starred_url":"https://api.github.com/users/dengert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengert/subscriptions","organizations_url":"https://api.github.com/users/dengert/orgs","repos_url":"https://api.github.com/users/dengert/repos","events_url":"https://api.github.com/users/dengert/events{/privacy}","received_events_url":"https://api.github.com/users/dengert/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T20:29:02Z","updated_at":"2016-08-26T20:29:02Z","body":"\r\n  \r\n    \r\n  \r\n  \r\n    OpenSC developers who use PKCS#115 cards and PIN PAD reader, please\r\n    look at this issue.\r\n    \r\n    From 256, the pin pad reader can not handle to 8 which is the max\r\n    pin size as defined for the card is an improvment. \r\n    So it looks like it is closer.  Other developers who can reproduce\r\n    the problem (Frank? Vicktor?) should look at this .\r\n    \r\n    \r\n    \r\n    On 8/26/2016 7:51 AM, Lars Silvén\r\n      wrote:\r\n    \r\n    \r\n      Tried your patch Doug but it did not work.\r\n        As before first time the card needs PIN the pinpad reader is\r\n        asked since NULL_PTR has been used for password in C_Login.\r\n        But the second time the reader are trying to use some other PIN\r\n        that has eight character. Before it was 256 chars. It should be\r\n        0 chars.\r\n        Same line 2357 in the log: http://aline.nu/~lars/opensc/dengert.log\r\n      —\r\n        You are receiving this because you commented.\r\n        Reply to this email directly, view\r\n          it on GitHub, or mute\r\n          the thread.\r\n      \r\n        \r\n          \r\n          \r\n        \r\n        \r\n      \r\n      {\"api_version\":\"1.0\",\"publisher\":{\"api_key\":\"05dde50f1d1a384dd78767c55493e4bb\",\"name\":\"GitHub\"},\"entity\":{\"external_key\":\"github/OpenSC/OpenSC\",\"title\":\"OpenSC/OpenSC\",\"subtitle\":\"GitHub repository\",\"main_image_url\":\"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png\",\"avatar_image_url\":\"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png\",\"action\":{\"name\":\"Open in GitHub\",\"url\":\"https://github.com/OpenSC/OpenSC\"}},\"updates\":{\"snippets\":[{\"icon\":\"PERSON\",\"message\":\"@larssilven in #856: Tried your patch Doug but it did not work.\\r\\nAs before first time the card needs PIN the pinpad reader is asked since NULL_PTR has been used for password in C_Login.\\r\\nBut the second time the reader are trying to use some other PIN that has eight character. Before it was 256 chars. It should be 0 chars.\\r\\nSame line 2357 in the log: http://aline.nu/~lars/opensc/dengert.log\"}],\"action\":{\"name\":\"View Pull Request\",\"url\":\"https://github.com/OpenSC/OpenSC/pull/856#issuecomment-242726806\"}}}\r\n    \r\n    \r\n    -- \r\n\r\n Douglas E. Engert  <DEEngert@gmail.com>"}}
{"actor":{"display_login":"dengert"}}