{"action":"created","issue":{"url":"https://api.github.com/repos/campoy/embedmd/issues/28","repository_url":"https://api.github.com/repos/campoy/embedmd","labels_url":"https://api.github.com/repos/campoy/embedmd/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/campoy/embedmd/issues/28/comments","events_url":"https://api.github.com/repos/campoy/embedmd/issues/28/events","html_url":"https://github.com/campoy/embedmd/pull/28","id":188954562,"number":28,"title":"extracting the main functionality into a resuable lib","user":{"login":"campoy","id":2237452,"avatar_url":"https://avatars.githubusercontent.com/u/2237452?v=3","gravatar_id":"","url":"https://api.github.com/users/campoy","html_url":"https://github.com/campoy","followers_url":"https://api.github.com/users/campoy/followers","following_url":"https://api.github.com/users/campoy/following{/other_user}","gists_url":"https://api.github.com/users/campoy/gists{/gist_id}","starred_url":"https://api.github.com/users/campoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campoy/subscriptions","organizations_url":"https://api.github.com/users/campoy/orgs","repos_url":"https://api.github.com/users/campoy/repos","events_url":"https://api.github.com/users/campoy/events{/privacy}","received_events_url":"https://api.github.com/users/campoy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-13T06:15:16Z","updated_at":"2016-11-15T20:18:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/campoy/embedmd/pulls/28","html_url":"https://github.com/campoy/embedmd/pull/28","diff_url":"https://github.com/campoy/embedmd/pull/28.diff","patch_url":"https://github.com/campoy/embedmd/pull/28.patch"},"body":"Fixes #10."},"comment":{"url":"https://api.github.com/repos/campoy/embedmd/issues/comments/260755327","html_url":"https://github.com/campoy/embedmd/pull/28#issuecomment-260755327","issue_url":"https://api.github.com/repos/campoy/embedmd/issues/28","id":260755327,"user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"created_at":"2016-11-15T20:18:35Z","updated_at":"2016-11-15T20:18:35Z","body":"A high level comment for you to consider (but not necessarily do) is to keep the library at `github.com/campoy/embedmd` import path, and move the command to `github.com/campoy/embedmd/cmd/embedmd`.\r\n\r\nThe `cmd/foo` pattern is pretty common and I think it's nice. It lets you avoid the stuttering in `github.com/campoy/embedmd/embedmd` import path, and makes it more visible where the command/libraries are. But it's definitely a matter of taste, so completely up to you.\r\n\r\nSome examples of the pattern:\r\n\r\n- https://godoc.org/golang.org/x/tools/cmd\r\n- https://github.com/bradfitz/issuemirror/commit/af29bba36e54185782b614beeacd310a01a62211\r\n- https://github.com/dominikh/go-simple/tree/master/cmd/gosimple"}}
{"actor":{"display_login":"shurcooL"}}