{"action":"created","comment":{"url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/comments/59001868","id":59001868,"diff_hunk":"@@ -1,10 +1,28 @@\n+import Stencil\n+import PathKit\n import Vapor\n \n-public class Provider: Vapor.Provider {\n-\tpublic static let renderer = StencilRenderer()\n-\n-\tpublic static func boot(application: Application) {\n-\t\tView.renderers[\".stencil\"] = self.renderer\n-\t}\n-\n+extension Application {\n+  var resourcesDir: String { return workDir + \"Resources/\" }\n+  var viewsDir: String { return resourcesDir + \"Views/\" }\n }\n+\n+public class Provider: Vapor.Provider {\n+  public static var renderer: StencilRenderer?\n+  \n+  public static func boot(application: Application) {","path":"Sources/Provider.swift","position":null,"original_position":20,"commit_id":"c3862c5ac01ca821697e9b389bb6a241b4ad420e","original_commit_id":"abd68f7a2ea199a6adf748df98919033a2340083","user":{"login":"ratranqu","id":17026861,"avatar_url":"https://avatars.githubusercontent.com/u/17026861?v=3","gravatar_id":"","url":"https://api.github.com/users/ratranqu","html_url":"https://github.com/ratranqu","followers_url":"https://api.github.com/users/ratranqu/followers","following_url":"https://api.github.com/users/ratranqu/following{/other_user}","gists_url":"https://api.github.com/users/ratranqu/gists{/gist_id}","starred_url":"https://api.github.com/users/ratranqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratranqu/subscriptions","organizations_url":"https://api.github.com/users/ratranqu/orgs","repos_url":"https://api.github.com/users/ratranqu/repos","events_url":"https://api.github.com/users/ratranqu/events{/privacy}","received_events_url":"https://api.github.com/users/ratranqu/received_events","type":"User","site_admin":false},"body":"I made the call to drop the static for the renderer as well. it's what makes most sense. let me know if not.","created_at":"2016-04-08T09:39:20Z","updated_at":"2016-04-08T09:39:20Z","html_url":"https://github.com/qutheory/vapor-stencil/pull/5#discussion_r59001868","pull_request_url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/comments/59001868"},"html":{"href":"https://github.com/qutheory/vapor-stencil/pull/5#discussion_r59001868"},"pull_request":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5","id":64811767,"html_url":"https://github.com/qutheory/vapor-stencil/pull/5","diff_url":"https://github.com/qutheory/vapor-stencil/pull/5.diff","patch_url":"https://github.com/qutheory/vapor-stencil/pull/5.patch","issue_url":"https://api.github.com/repos/qutheory/vapor-stencil/issues/5","number":5,"state":"open","locked":false,"title":"support 03-24","user":{"login":"ratranqu","id":17026861,"avatar_url":"https://avatars.githubusercontent.com/u/17026861?v=3","gravatar_id":"","url":"https://api.github.com/users/ratranqu","html_url":"https://github.com/ratranqu","followers_url":"https://api.github.com/users/ratranqu/followers","following_url":"https://api.github.com/users/ratranqu/following{/other_user}","gists_url":"https://api.github.com/users/ratranqu/gists{/gist_id}","starred_url":"https://api.github.com/users/ratranqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratranqu/subscriptions","organizations_url":"https://api.github.com/users/ratranqu/orgs","repos_url":"https://api.github.com/users/ratranqu/repos","events_url":"https://api.github.com/users/ratranqu/events{/privacy}","received_events_url":"https://api.github.com/users/ratranqu/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI fixed to work with Vapour 0.4.1 and added support for swift 3.0 (DEVELOPMENT-SNAPSHOT-2016-03-24-a) using macros checking the swift version, so should work both with 2.2 and (current) 3.0 dev.\r\n\r\nSwift 3.0 related changes are mostly about keeping up with the swift-3-api-guidelines induced changes.\r\n\r\nAs I've also changed Package.swift to point to the relevant Stencil release, you may want (depending on timing) to keep my changes to that file or not.","created_at":"2016-03-31T15:40:41Z","updated_at":"2016-04-08T09:39:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a0b2eb0f6679673e57e8813fa31ad7482589c0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5/commits","review_comments_url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5/comments","review_comment_url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qutheory/vapor-stencil/issues/5/comments","statuses_url":"https://api.github.com/repos/qutheory/vapor-stencil/statuses/c3862c5ac01ca821697e9b389bb6a241b4ad420e","head":{"label":"ratranqu:master","ref":"master","sha":"c3862c5ac01ca821697e9b389bb6a241b4ad420e","user":{"login":"ratranqu","id":17026861,"avatar_url":"https://avatars.githubusercontent.com/u/17026861?v=3","gravatar_id":"","url":"https://api.github.com/users/ratranqu","html_url":"https://github.com/ratranqu","followers_url":"https://api.github.com/users/ratranqu/followers","following_url":"https://api.github.com/users/ratranqu/following{/other_user}","gists_url":"https://api.github.com/users/ratranqu/gists{/gist_id}","starred_url":"https://api.github.com/users/ratranqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratranqu/subscriptions","organizations_url":"https://api.github.com/users/ratranqu/orgs","repos_url":"https://api.github.com/users/ratranqu/repos","events_url":"https://api.github.com/users/ratranqu/events{/privacy}","received_events_url":"https://api.github.com/users/ratranqu/received_events","type":"User","site_admin":false},"repo":{"id":55157034,"name":"vapor-stencil","full_name":"ratranqu/vapor-stencil","owner":{"login":"ratranqu","id":17026861,"avatar_url":"https://avatars.githubusercontent.com/u/17026861?v=3","gravatar_id":"","url":"https://api.github.com/users/ratranqu","html_url":"https://github.com/ratranqu","followers_url":"https://api.github.com/users/ratranqu/followers","following_url":"https://api.github.com/users/ratranqu/following{/other_user}","gists_url":"https://api.github.com/users/ratranqu/gists{/gist_id}","starred_url":"https://api.github.com/users/ratranqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratranqu/subscriptions","organizations_url":"https://api.github.com/users/ratranqu/orgs","repos_url":"https://api.github.com/users/ratranqu/repos","events_url":"https://api.github.com/users/ratranqu/events{/privacy}","received_events_url":"https://api.github.com/users/ratranqu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ratranqu/vapor-stencil","description":"Stencil view renderer for Vapor","fork":true,"url":"https://api.github.com/repos/ratranqu/vapor-stencil","forks_url":"https://api.github.com/repos/ratranqu/vapor-stencil/forks","keys_url":"https://api.github.com/repos/ratranqu/vapor-stencil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ratranqu/vapor-stencil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ratranqu/vapor-stencil/teams","hooks_url":"https://api.github.com/repos/ratranqu/vapor-stencil/hooks","issue_events_url":"https://api.github.com/repos/ratranqu/vapor-stencil/issues/events{/number}","events_url":"https://api.github.com/repos/ratranqu/vapor-stencil/events","assignees_url":"https://api.github.com/repos/ratranqu/vapor-stencil/assignees{/user}","branches_url":"https://api.github.com/repos/ratranqu/vapor-stencil/branches{/branch}","tags_url":"https://api.github.com/repos/ratranqu/vapor-stencil/tags","blobs_url":"https://api.github.com/repos/ratranqu/vapor-stencil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ratranqu/vapor-stencil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ratranqu/vapor-stencil/git/refs{/sha}","trees_url":"https://api.github.com/repos/ratranqu/vapor-stencil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ratranqu/vapor-stencil/statuses/{sha}","languages_url":"https://api.github.com/repos/ratranqu/vapor-stencil/languages","stargazers_url":"https://api.github.com/repos/ratranqu/vapor-stencil/stargazers","contributors_url":"https://api.github.com/repos/ratranqu/vapor-stencil/contributors","subscribers_url":"https://api.github.com/repos/ratranqu/vapor-stencil/subscribers","subscription_url":"https://api.github.com/repos/ratranqu/vapor-stencil/subscription","commits_url":"https://api.github.com/repos/ratranqu/vapor-stencil/commits{/sha}","git_commits_url":"https://api.github.com/repos/ratranqu/vapor-stencil/git/commits{/sha}","comments_url":"https://api.github.com/repos/ratranqu/vapor-stencil/comments{/number}","issue_comment_url":"https://api.github.com/repos/ratranqu/vapor-stencil/issues/comments{/number}","contents_url":"https://api.github.com/repos/ratranqu/vapor-stencil/contents/{+path}","compare_url":"https://api.github.com/repos/ratranqu/vapor-stencil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ratranqu/vapor-stencil/merges","archive_url":"https://api.github.com/repos/ratranqu/vapor-stencil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ratranqu/vapor-stencil/downloads","issues_url":"https://api.github.com/repos/ratranqu/vapor-stencil/issues{/number}","pulls_url":"https://api.github.com/repos/ratranqu/vapor-stencil/pulls{/number}","milestones_url":"https://api.github.com/repos/ratranqu/vapor-stencil/milestones{/number}","notifications_url":"https://api.github.com/repos/ratranqu/vapor-stencil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ratranqu/vapor-stencil/labels{/name}","releases_url":"https://api.github.com/repos/ratranqu/vapor-stencil/releases{/id}","deployments_url":"https://api.github.com/repos/ratranqu/vapor-stencil/deployments","created_at":"2016-03-31T14:29:11Z","updated_at":"2016-03-31T14:29:12Z","pushed_at":"2016-04-08T09:38:23Z","git_url":"git://github.com/ratranqu/vapor-stencil.git","ssh_url":"git@github.com:ratranqu/vapor-stencil.git","clone_url":"https://github.com/ratranqu/vapor-stencil.git","svn_url":"https://github.com/ratranqu/vapor-stencil","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qutheory:master","ref":"master","sha":"263f7b73a5ea0a7cfeda092867b196d0a46fe324","user":{"login":"qutheory","id":17364220,"avatar_url":"https://avatars.githubusercontent.com/u/17364220?v=3","gravatar_id":"","url":"https://api.github.com/users/qutheory","html_url":"https://github.com/qutheory","followers_url":"https://api.github.com/users/qutheory/followers","following_url":"https://api.github.com/users/qutheory/following{/other_user}","gists_url":"https://api.github.com/users/qutheory/gists{/gist_id}","starred_url":"https://api.github.com/users/qutheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutheory/subscriptions","organizations_url":"https://api.github.com/users/qutheory/orgs","repos_url":"https://api.github.com/users/qutheory/repos","events_url":"https://api.github.com/users/qutheory/events{/privacy}","received_events_url":"https://api.github.com/users/qutheory/received_events","type":"Organization","site_admin":false},"repo":{"id":51337883,"name":"vapor-stencil","full_name":"qutheory/vapor-stencil","owner":{"login":"qutheory","id":17364220,"avatar_url":"https://avatars.githubusercontent.com/u/17364220?v=3","gravatar_id":"","url":"https://api.github.com/users/qutheory","html_url":"https://github.com/qutheory","followers_url":"https://api.github.com/users/qutheory/followers","following_url":"https://api.github.com/users/qutheory/following{/other_user}","gists_url":"https://api.github.com/users/qutheory/gists{/gist_id}","starred_url":"https://api.github.com/users/qutheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutheory/subscriptions","organizations_url":"https://api.github.com/users/qutheory/orgs","repos_url":"https://api.github.com/users/qutheory/repos","events_url":"https://api.github.com/users/qutheory/events{/privacy}","received_events_url":"https://api.github.com/users/qutheory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qutheory/vapor-stencil","description":"Stencil view renderer for Vapor","fork":false,"url":"https://api.github.com/repos/qutheory/vapor-stencil","forks_url":"https://api.github.com/repos/qutheory/vapor-stencil/forks","keys_url":"https://api.github.com/repos/qutheory/vapor-stencil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qutheory/vapor-stencil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qutheory/vapor-stencil/teams","hooks_url":"https://api.github.com/repos/qutheory/vapor-stencil/hooks","issue_events_url":"https://api.github.com/repos/qutheory/vapor-stencil/issues/events{/number}","events_url":"https://api.github.com/repos/qutheory/vapor-stencil/events","assignees_url":"https://api.github.com/repos/qutheory/vapor-stencil/assignees{/user}","branches_url":"https://api.github.com/repos/qutheory/vapor-stencil/branches{/branch}","tags_url":"https://api.github.com/repos/qutheory/vapor-stencil/tags","blobs_url":"https://api.github.com/repos/qutheory/vapor-stencil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qutheory/vapor-stencil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qutheory/vapor-stencil/git/refs{/sha}","trees_url":"https://api.github.com/repos/qutheory/vapor-stencil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qutheory/vapor-stencil/statuses/{sha}","languages_url":"https://api.github.com/repos/qutheory/vapor-stencil/languages","stargazers_url":"https://api.github.com/repos/qutheory/vapor-stencil/stargazers","contributors_url":"https://api.github.com/repos/qutheory/vapor-stencil/contributors","subscribers_url":"https://api.github.com/repos/qutheory/vapor-stencil/subscribers","subscription_url":"https://api.github.com/repos/qutheory/vapor-stencil/subscription","commits_url":"https://api.github.com/repos/qutheory/vapor-stencil/commits{/sha}","git_commits_url":"https://api.github.com/repos/qutheory/vapor-stencil/git/commits{/sha}","comments_url":"https://api.github.com/repos/qutheory/vapor-stencil/comments{/number}","issue_comment_url":"https://api.github.com/repos/qutheory/vapor-stencil/issues/comments{/number}","contents_url":"https://api.github.com/repos/qutheory/vapor-stencil/contents/{+path}","compare_url":"https://api.github.com/repos/qutheory/vapor-stencil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qutheory/vapor-stencil/merges","archive_url":"https://api.github.com/repos/qutheory/vapor-stencil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qutheory/vapor-stencil/downloads","issues_url":"https://api.github.com/repos/qutheory/vapor-stencil/issues{/number}","pulls_url":"https://api.github.com/repos/qutheory/vapor-stencil/pulls{/number}","milestones_url":"https://api.github.com/repos/qutheory/vapor-stencil/milestones{/number}","notifications_url":"https://api.github.com/repos/qutheory/vapor-stencil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qutheory/vapor-stencil/labels{/name}","releases_url":"https://api.github.com/repos/qutheory/vapor-stencil/releases{/id}","deployments_url":"https://api.github.com/repos/qutheory/vapor-stencil/deployments","created_at":"2016-02-09T00:36:44Z","updated_at":"2016-04-07T05:22:52Z","pushed_at":"2016-04-08T09:38:24Z","git_url":"git://github.com/qutheory/vapor-stencil.git","ssh_url":"git@github.com:qutheory/vapor-stencil.git","clone_url":"https://github.com/qutheory/vapor-stencil.git","svn_url":"https://github.com/qutheory/vapor-stencil","homepage":null,"size":7,"stargazers_count":3,"watchers_count":3,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5"},"html":{"href":"https://github.com/qutheory/vapor-stencil/pull/5"},"issue":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/issues/5"},"comments":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/qutheory/vapor-stencil/statuses/c3862c5ac01ca821697e9b389bb6a241b4ad420e"}}}}