{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/94024689","pull_request_review_id":14551975,"id":94024689,"diff_hunk":"@@ -0,0 +1,69 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.operator.scalar;\n+\n+import org.testng.annotations.Test;\n+\n+import static com.facebook.presto.spi.type.VarcharType.VARCHAR;\n+\n+public class TestFormatUtilsFunctions\n+        extends AbstractTestFunctions\n+{\n+    @Test\n+    public void testFormatCount()","path":"presto-main/src/test/java/com/facebook/presto/operator/scalar/TestFormatUtilsFunctions.java","position":24,"original_position":24,"commit_id":"c6c0f94ec8c681615661ca103a64f9f14315683d","original_commit_id":"c6c0f94ec8c681615661ca103a64f9f14315683d","user":{"login":"fiedukow","id":297223,"avatar_url":"https://avatars.githubusercontent.com/u/297223?v=3","gravatar_id":"","url":"https://api.github.com/users/fiedukow","html_url":"https://github.com/fiedukow","followers_url":"https://api.github.com/users/fiedukow/followers","following_url":"https://api.github.com/users/fiedukow/following{/other_user}","gists_url":"https://api.github.com/users/fiedukow/gists{/gist_id}","starred_url":"https://api.github.com/users/fiedukow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiedukow/subscriptions","organizations_url":"https://api.github.com/users/fiedukow/orgs","repos_url":"https://api.github.com/users/fiedukow/repos","events_url":"https://api.github.com/users/fiedukow/events{/privacy}","received_events_url":"https://api.github.com/users/fiedukow/received_events","type":"User","site_admin":false},"body":"Please test rounding explicitly showing intentions (this is good candidate for separate test function).\r\nInclude some cases of rounding up.\r\nNote that there is explicit assumption about rounding mode in the code (`format.setRoundingMode(RoundingMode.HALF_UP);`), so it's nice to express that in tests as well.","created_at":"2016-12-28T12:00:28Z","updated_at":"2016-12-28T12:22:56Z","html_url":"https://github.com/prestodb/presto/pull/6437#discussion_r94024689","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/6437","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/94024689"},"html":{"href":"https://github.com/prestodb/presto/pull/6437#discussion_r94024689"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6437"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/6437","id":91036636,"html_url":"https://github.com/prestodb/presto/pull/6437","diff_url":"https://github.com/prestodb/presto/pull/6437.diff","patch_url":"https://github.com/prestodb/presto/pull/6437.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/6437","number":6437,"state":"open","locked":false,"title":"[WIP] Add function to to shorten and format numbers","user":{"login":"yuokada","id":387284,"avatar_url":"https://avatars.githubusercontent.com/u/387284?v=3","gravatar_id":"","url":"https://api.github.com/users/yuokada","html_url":"https://github.com/yuokada","followers_url":"https://api.github.com/users/yuokada/followers","following_url":"https://api.github.com/users/yuokada/following{/other_user}","gists_url":"https://api.github.com/users/yuokada/gists{/gist_id}","starred_url":"https://api.github.com/users/yuokada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuokada/subscriptions","organizations_url":"https://api.github.com/users/yuokada/orgs","repos_url":"https://api.github.com/users/yuokada/repos","events_url":"https://api.github.com/users/yuokada/events{/privacy}","received_events_url":"https://api.github.com/users/yuokada/received_events","type":"User","site_admin":false},"body":"solved #4130 \r\n# TODO\r\n- [ ] Document\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestodb/presto/6437)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-26T16:07:08Z","updated_at":"2016-12-28T12:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88a940f6b8da5a1148c96d64c57df3727dc60b66","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/6437/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/6437/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/6437/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/c6c0f94ec8c681615661ca103a64f9f14315683d","head":{"label":"yuokada:feature/format_count","ref":"feature/format_count","sha":"c6c0f94ec8c681615661ca103a64f9f14315683d","user":{"login":"yuokada","id":387284,"avatar_url":"https://avatars.githubusercontent.com/u/387284?v=3","gravatar_id":"","url":"https://api.github.com/users/yuokada","html_url":"https://github.com/yuokada","followers_url":"https://api.github.com/users/yuokada/followers","following_url":"https://api.github.com/users/yuokada/following{/other_user}","gists_url":"https://api.github.com/users/yuokada/gists{/gist_id}","starred_url":"https://api.github.com/users/yuokada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuokada/subscriptions","organizations_url":"https://api.github.com/users/yuokada/orgs","repos_url":"https://api.github.com/users/yuokada/repos","events_url":"https://api.github.com/users/yuokada/events{/privacy}","received_events_url":"https://api.github.com/users/yuokada/received_events","type":"User","site_admin":false},"repo":{"id":69168843,"name":"presto","full_name":"yuokada/presto","owner":{"login":"yuokada","id":387284,"avatar_url":"https://avatars.githubusercontent.com/u/387284?v=3","gravatar_id":"","url":"https://api.github.com/users/yuokada","html_url":"https://github.com/yuokada","followers_url":"https://api.github.com/users/yuokada/followers","following_url":"https://api.github.com/users/yuokada/following{/other_user}","gists_url":"https://api.github.com/users/yuokada/gists{/gist_id}","starred_url":"https://api.github.com/users/yuokada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuokada/subscriptions","organizations_url":"https://api.github.com/users/yuokada/orgs","repos_url":"https://api.github.com/users/yuokada/repos","events_url":"https://api.github.com/users/yuokada/events{/privacy}","received_events_url":"https://api.github.com/users/yuokada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuokada/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/yuokada/presto","forks_url":"https://api.github.com/repos/yuokada/presto/forks","keys_url":"https://api.github.com/repos/yuokada/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuokada/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuokada/presto/teams","hooks_url":"https://api.github.com/repos/yuokada/presto/hooks","issue_events_url":"https://api.github.com/repos/yuokada/presto/issues/events{/number}","events_url":"https://api.github.com/repos/yuokada/presto/events","assignees_url":"https://api.github.com/repos/yuokada/presto/assignees{/user}","branches_url":"https://api.github.com/repos/yuokada/presto/branches{/branch}","tags_url":"https://api.github.com/repos/yuokada/presto/tags","blobs_url":"https://api.github.com/repos/yuokada/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuokada/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuokada/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuokada/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuokada/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/yuokada/presto/languages","stargazers_url":"https://api.github.com/repos/yuokada/presto/stargazers","contributors_url":"https://api.github.com/repos/yuokada/presto/contributors","subscribers_url":"https://api.github.com/repos/yuokada/presto/subscribers","subscription_url":"https://api.github.com/repos/yuokada/presto/subscription","commits_url":"https://api.github.com/repos/yuokada/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuokada/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuokada/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuokada/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuokada/presto/contents/{+path}","compare_url":"https://api.github.com/repos/yuokada/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuokada/presto/merges","archive_url":"https://api.github.com/repos/yuokada/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuokada/presto/downloads","issues_url":"https://api.github.com/repos/yuokada/presto/issues{/number}","pulls_url":"https://api.github.com/repos/yuokada/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/yuokada/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/yuokada/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuokada/presto/labels{/name}","releases_url":"https://api.github.com/repos/yuokada/presto/releases{/id}","deployments_url":"https://api.github.com/repos/yuokada/presto/deployments","created_at":"2016-09-25T14:21:30Z","updated_at":"2016-09-25T14:21:44Z","pushed_at":"2016-12-28T00:57:13Z","git_url":"git://github.com/yuokada/presto.git","ssh_url":"git@github.com:yuokada/presto.git","clone_url":"https://github.com/yuokada/presto.git","svn_url":"https://github.com/yuokada/presto","homepage":"https://prestodb.io","size":64141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"e4f7d5c616ae69ff85f160d523c3091b56b10f76","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-12-28T11:24:36Z","pushed_at":"2016-12-28T10:38:38Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":64264,"stargazers_count":5448,"watchers_count":5448,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1717,"mirror_url":null,"open_issues_count":826,"forks":1717,"open_issues":826,"watchers":5448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6437"},"html":{"href":"https://github.com/prestodb/presto/pull/6437"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/6437"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/6437/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6437/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/6437/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/c6c0f94ec8c681615661ca103a64f9f14315683d"}}}}
{"actor":{"display_login":"fiedukow"}}