{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/5958","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/5958/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5958/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/5958/events","html_url":"https://github.com/nodejs/node/pull/5958","id":144661863,"number":5958,"title":"repl: Copying tab characters into the repl calls tabComplete","user":{"login":"ghaiklor","id":3625244,"avatar_url":"https://avatars.githubusercontent.com/u/3625244?v=3","gravatar_id":"","url":"https://api.github.com/users/ghaiklor","html_url":"https://github.com/ghaiklor","followers_url":"https://api.github.com/users/ghaiklor/followers","following_url":"https://api.github.com/users/ghaiklor/following{/other_user}","gists_url":"https://api.github.com/users/ghaiklor/gists{/gist_id}","starred_url":"https://api.github.com/users/ghaiklor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghaiklor/subscriptions","organizations_url":"https://api.github.com/users/ghaiklor/orgs","repos_url":"https://api.github.com/users/ghaiklor/repos","events_url":"https://api.github.com/users/ghaiklor/events{/privacy}","received_events_url":"https://api.github.com/users/ghaiklor/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/repl","name":"repl","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-03-30T17:34:00Z","updated_at":"2016-04-05T11:59:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5958","html_url":"https://github.com/nodejs/node/pull/5958","diff_url":"https://github.com/nodejs/node/pull/5958.diff","patch_url":"https://github.com/nodejs/node/pull/5958.patch"},"body":"### Pull Request check-list\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [x] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n\r\n### Affected core subsystem(s)\r\n\r\nrepl\r\n\r\n### Description of change\r\n\r\nIssue - https://github.com/nodejs/node/issues/5954\r\n\r\nWhen you are copying tab-indented code into the repl, repl calls tabComplete function.\r\nThere is no actual pressing the button, so we need to ignore it."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/205770002","html_url":"https://github.com/nodejs/node/pull/5958#issuecomment-205770002","issue_url":"https://api.github.com/repos/nodejs/node/issues/5958","id":205770002,"user":{"login":"benjamingr","id":1315533,"avatar_url":"https://avatars.githubusercontent.com/u/1315533?v=3","gravatar_id":"","url":"https://api.github.com/users/benjamingr","html_url":"https://github.com/benjamingr","followers_url":"https://api.github.com/users/benjamingr/followers","following_url":"https://api.github.com/users/benjamingr/following{/other_user}","gists_url":"https://api.github.com/users/benjamingr/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamingr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamingr/subscriptions","organizations_url":"https://api.github.com/users/benjamingr/orgs","repos_url":"https://api.github.com/users/benjamingr/repos","events_url":"https://api.github.com/users/benjamingr/events{/privacy}","received_events_url":"https://api.github.com/users/benjamingr/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T11:59:11Z","updated_at":"2016-04-05T11:59:11Z","body":"This is better, replacing it with spaces was only a way to fix the autocomplete issue.\r\n\r\nMind adding a line explaining why that `if` was added there so future readers can understand the problem being solved? With a comment generally LGTM."}}