{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/76485064","id":76485064,"diff_hunk":"@@ -417,21 +417,6 @@ pub struct AssociatedType<'tcx> {\n     pub container: ImplOrTraitItemContainer,\n }\n \n-#[derive(Clone, PartialEq, RustcDecodable, RustcEncodable)]\n-pub struct ItemVariances {","path":"src/librustc/ty/mod.rs","position":23,"original_position":23,"commit_id":"d03b7620ba34b8651abe0d3c4af0ce6f8768bb9f","original_commit_id":"d03b7620ba34b8651abe0d3c4af0ce6f8768bb9f","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"body":"Nit: I think I'd have preferred to keep this struct around as a newtype'd Vec, personally. But I don't really care. And I feel guilty even mentioning it. But I will anyway.","created_at":"2016-08-26T20:43:14Z","updated_at":"2016-08-26T20:43:14Z","html_url":"https://github.com/rust-lang/rust/pull/36002#discussion_r76485064","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/36002","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/76485064"},"html":{"href":"https://github.com/rust-lang/rust/pull/36002#discussion_r76485064"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36002"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36002","id":82802551,"html_url":"https://github.com/rust-lang/rust/pull/36002","diff_url":"https://github.com/rust-lang/rust/pull/36002.diff","patch_url":"https://github.com/rust-lang/rust/pull/36002.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36002","number":36002,"state":"open","locked":false,"title":"Combine types and regions in Substs into one interleaved list.","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Previously, `Substs` would contain types and regions, in two separate vectors, for example:\r\n```rust\r\n<X as Trait<'a, 'b, A, B>>::method::<'p, 'q, T, U>\r\n/* corresponds to */\r\nSubsts { regions: ['a, 'b, 'p, 'q], types: [X, A, B, T, U] }\r\n```\r\n\r\nThis PR continues the work started in #35605 by further removing the distinction.\r\nA new abstraction over types and regions is introduced in the compiler, `Kind`.\r\nEach `Kind` is a pointer (`&TyS` or `&Region`), with the lowest two bits used as a tag.\r\nTwo bits were used instead of just one (type = `0`, region = `1`) to allow adding more kinds.\r\n\r\n`Substs` contain only a `Vec<Kind>`, with `Self` first, followed by regions and types (in the definition order):\r\n```rust\r\nSubsts { params: [X, 'a, 'b, A, B, 'p, 'q, T, U] }\r\n```\r\nThe resulting interleaved list has the property of being the concatenation of parameters for the (potentially) nested generic items it describes, and can be sliced back into those components:\r\n```rust\r\nparams[0..5] = [X, 'a, 'b, A, B] // <X as Trait<'a, 'b, A, B>>\r\nparams[5..9] = ['p, 'q, T, U] // <_>::method::<'p, 'q, T, U>\r\n```\r\n\r\nr? @nikomatsakis","created_at":"2016-08-25T22:13:41Z","updated_at":"2016-08-26T20:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d196a23e4b314d911b568cd0a18a918e7c4ff48","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/36002/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/36002/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36002/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d03b7620ba34b8651abe0d3c4af0ce6f8768bb9f","head":{"label":"eddyb:abstract-kindness","ref":"abstract-kindness","sha":"d03b7620ba34b8651abe0d3c4af0ce6f8768bb9f","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"repo":{"id":13473977,"name":"rust","full_name":"eddyb/rust","owner":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eddyb/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/eddyb/rust","forks_url":"https://api.github.com/repos/eddyb/rust/forks","keys_url":"https://api.github.com/repos/eddyb/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eddyb/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eddyb/rust/teams","hooks_url":"https://api.github.com/repos/eddyb/rust/hooks","issue_events_url":"https://api.github.com/repos/eddyb/rust/issues/events{/number}","events_url":"https://api.github.com/repos/eddyb/rust/events","assignees_url":"https://api.github.com/repos/eddyb/rust/assignees{/user}","branches_url":"https://api.github.com/repos/eddyb/rust/branches{/branch}","tags_url":"https://api.github.com/repos/eddyb/rust/tags","blobs_url":"https://api.github.com/repos/eddyb/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eddyb/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eddyb/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/eddyb/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eddyb/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/eddyb/rust/languages","stargazers_url":"https://api.github.com/repos/eddyb/rust/stargazers","contributors_url":"https://api.github.com/repos/eddyb/rust/contributors","subscribers_url":"https://api.github.com/repos/eddyb/rust/subscribers","subscription_url":"https://api.github.com/repos/eddyb/rust/subscription","commits_url":"https://api.github.com/repos/eddyb/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/eddyb/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/eddyb/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/eddyb/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/eddyb/rust/contents/{+path}","compare_url":"https://api.github.com/repos/eddyb/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eddyb/rust/merges","archive_url":"https://api.github.com/repos/eddyb/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eddyb/rust/downloads","issues_url":"https://api.github.com/repos/eddyb/rust/issues{/number}","pulls_url":"https://api.github.com/repos/eddyb/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/eddyb/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/eddyb/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eddyb/rust/labels{/name}","releases_url":"https://api.github.com/repos/eddyb/rust/releases{/id}","deployments_url":"https://api.github.com/repos/eddyb/rust/deployments","created_at":"2013-10-10T14:40:52Z","updated_at":"2015-06-10T12:47:08Z","pushed_at":"2016-08-26T04:39:26Z","git_url":"git://github.com/eddyb/rust.git","ssh_url":"git@github.com:eddyb/rust.git","clone_url":"https://github.com/eddyb/rust.git","svn_url":"https://github.com/eddyb/rust","homepage":"http://www.rust-lang.org","size":298300,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"71bdeea561355ba5adbc9a1f44f4f866a75a15c4","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-08-26T20:29:12Z","pushed_at":"2016-08-26T19:39:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":506536,"stargazers_count":18085,"watchers_count":18085,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3485,"mirror_url":null,"open_issues_count":2775,"forks":3485,"open_issues":2775,"watchers":18085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36002"},"html":{"href":"https://github.com/rust-lang/rust/pull/36002"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36002"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36002/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36002/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36002/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d03b7620ba34b8651abe0d3c4af0ce6f8768bb9f"}}}}
{"actor":{"display_login":"nikomatsakis"}}