{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/deployments/pulls/comments/83007829","pull_request_review_id":3875780,"id":83007829,"diff_hunk":"@@ -44,12 +45,13 @@ func (p *RESTView) RenderSuccessGet(w rest.ResponseWriter, object interface{}) {\n \tw.WriteJson(object)\n }\n \n-func (p *RESTView) RenderError(w rest.ResponseWriter, err error, status int) {\n+func (p *RESTView) RenderError(w rest.ResponseWriter, err error, status int, l *log.Logger) {\n+\tl.F(log.Ctx{log.LogHttpCode: status}).Error(err.Error())","path":"resources/images/view/view.go","position":14,"original_position":14,"commit_id":"e7a52c03cb600f4dfe14bc48ca5a03aa735d7d2a","original_commit_id":"e7a52c03cb600f4dfe14bc48ca5a03aa735d7d2a","user":{"login":"maciejmrowiec","id":1391631,"avatar_url":"https://avatars.githubusercontent.com/u/1391631?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejmrowiec","html_url":"https://github.com/maciejmrowiec","followers_url":"https://api.github.com/users/maciejmrowiec/followers","following_url":"https://api.github.com/users/maciejmrowiec/following{/other_user}","gists_url":"https://api.github.com/users/maciejmrowiec/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejmrowiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejmrowiec/subscriptions","organizations_url":"https://api.github.com/users/maciejmrowiec/orgs","repos_url":"https://api.github.com/users/maciejmrowiec/repos","events_url":"https://api.github.com/users/maciejmrowiec/events{/privacy}","received_events_url":"https://api.github.com/users/maciejmrowiec/received_events","type":"User","site_admin":false},"body":"Access log middleware already logs http codes","created_at":"2016-10-12T13:46:32Z","updated_at":"2016-10-12T13:46:32Z","html_url":"https://github.com/mendersoftware/deployments/pull/159#discussion_r83007829","pull_request_url":"https://api.github.com/repos/mendersoftware/deployments/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/deployments/pulls/comments/83007829"},"html":{"href":"https://github.com/mendersoftware/deployments/pull/159#discussion_r83007829"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/deployments/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/deployments/pulls/159","id":88834313,"html_url":"https://github.com/mendersoftware/deployments/pull/159","diff_url":"https://github.com/mendersoftware/deployments/pull/159.diff","patch_url":"https://github.com/mendersoftware/deployments/pull/159.patch","issue_url":"https://api.github.com/repos/mendersoftware/deployments/issues/159","number":159,"state":"open","locked":false,"title":"Introduce logging","user":{"login":"mchalski","id":18258178,"avatar_url":"https://avatars.githubusercontent.com/u/18258178?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalski","html_url":"https://github.com/mchalski","followers_url":"https://api.github.com/users/mchalski/followers","following_url":"https://api.github.com/users/mchalski/following{/other_user}","gists_url":"https://api.github.com/users/mchalski/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalski/subscriptions","organizations_url":"https://api.github.com/users/mchalski/orgs","repos_url":"https://api.github.com/users/mchalski/repos","events_url":"https://api.github.com/users/mchalski/events{/privacy}","received_events_url":"https://api.github.com/users/mchalski/received_events","type":"User","site_admin":false},"body":"Issues: MEN-533\r\n\r\nDoesn't include propagating the requestid to inventory (yet).\r\n\r\n@maciejmrowiec @kjaskiewiczz \r\n\r\nEDIT: this still needs some fixes in tests/mocks, I'll keep them coming\r\nEDIT2: all fixes done","created_at":"2016-10-11T13:40:41Z","updated_at":"2016-10-12T13:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edd4bbec035f954b599725e871807736a82b2ca3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/deployments/pulls/159/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/deployments/pulls/159/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/deployments/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/deployments/issues/159/comments","statuses_url":"https://api.github.com/repos/mendersoftware/deployments/statuses/e7a52c03cb600f4dfe14bc48ca5a03aa735d7d2a","head":{"label":"mchalski:logging","ref":"logging","sha":"e7a52c03cb600f4dfe14bc48ca5a03aa735d7d2a","user":{"login":"mchalski","id":18258178,"avatar_url":"https://avatars.githubusercontent.com/u/18258178?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalski","html_url":"https://github.com/mchalski","followers_url":"https://api.github.com/users/mchalski/followers","following_url":"https://api.github.com/users/mchalski/following{/other_user}","gists_url":"https://api.github.com/users/mchalski/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalski/subscriptions","organizations_url":"https://api.github.com/users/mchalski/orgs","repos_url":"https://api.github.com/users/mchalski/repos","events_url":"https://api.github.com/users/mchalski/events{/privacy}","received_events_url":"https://api.github.com/users/mchalski/received_events","type":"User","site_admin":false},"repo":{"id":70476050,"name":"deployments","full_name":"mchalski/deployments","owner":{"login":"mchalski","id":18258178,"avatar_url":"https://avatars.githubusercontent.com/u/18258178?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalski","html_url":"https://github.com/mchalski","followers_url":"https://api.github.com/users/mchalski/followers","following_url":"https://api.github.com/users/mchalski/following{/other_user}","gists_url":"https://api.github.com/users/mchalski/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalski/subscriptions","organizations_url":"https://api.github.com/users/mchalski/orgs","repos_url":"https://api.github.com/users/mchalski/repos","events_url":"https://api.github.com/users/mchalski/events{/privacy}","received_events_url":"https://api.github.com/users/mchalski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchalski/deployments","description":"Microservice for managing software deployments for IIoT devices within Mender ecosystem.","fork":true,"url":"https://api.github.com/repos/mchalski/deployments","forks_url":"https://api.github.com/repos/mchalski/deployments/forks","keys_url":"https://api.github.com/repos/mchalski/deployments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchalski/deployments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchalski/deployments/teams","hooks_url":"https://api.github.com/repos/mchalski/deployments/hooks","issue_events_url":"https://api.github.com/repos/mchalski/deployments/issues/events{/number}","events_url":"https://api.github.com/repos/mchalski/deployments/events","assignees_url":"https://api.github.com/repos/mchalski/deployments/assignees{/user}","branches_url":"https://api.github.com/repos/mchalski/deployments/branches{/branch}","tags_url":"https://api.github.com/repos/mchalski/deployments/tags","blobs_url":"https://api.github.com/repos/mchalski/deployments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchalski/deployments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchalski/deployments/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchalski/deployments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchalski/deployments/statuses/{sha}","languages_url":"https://api.github.com/repos/mchalski/deployments/languages","stargazers_url":"https://api.github.com/repos/mchalski/deployments/stargazers","contributors_url":"https://api.github.com/repos/mchalski/deployments/contributors","subscribers_url":"https://api.github.com/repos/mchalski/deployments/subscribers","subscription_url":"https://api.github.com/repos/mchalski/deployments/subscription","commits_url":"https://api.github.com/repos/mchalski/deployments/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchalski/deployments/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchalski/deployments/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchalski/deployments/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchalski/deployments/contents/{+path}","compare_url":"https://api.github.com/repos/mchalski/deployments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchalski/deployments/merges","archive_url":"https://api.github.com/repos/mchalski/deployments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchalski/deployments/downloads","issues_url":"https://api.github.com/repos/mchalski/deployments/issues{/number}","pulls_url":"https://api.github.com/repos/mchalski/deployments/pulls{/number}","milestones_url":"https://api.github.com/repos/mchalski/deployments/milestones{/number}","notifications_url":"https://api.github.com/repos/mchalski/deployments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchalski/deployments/labels{/name}","releases_url":"https://api.github.com/repos/mchalski/deployments/releases{/id}","deployments_url":"https://api.github.com/repos/mchalski/deployments/deployments","created_at":"2016-10-10T10:06:48Z","updated_at":"2016-10-10T10:06:49Z","pushed_at":"2016-10-12T07:38:03Z","git_url":"git://github.com/mchalski/deployments.git","ssh_url":"git@github.com:mchalski/deployments.git","clone_url":"https://github.com/mchalski/deployments.git","svn_url":"https://github.com/mchalski/deployments","homepage":"mender.io","size":1338,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"c6dec50e430a78d66c9367656e9625a9704bcc98","user":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":46868944,"name":"deployments","full_name":"mendersoftware/deployments","owner":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendersoftware/deployments","description":"Microservice for managing software deployments for IIoT devices within Mender ecosystem.","fork":false,"url":"https://api.github.com/repos/mendersoftware/deployments","forks_url":"https://api.github.com/repos/mendersoftware/deployments/forks","keys_url":"https://api.github.com/repos/mendersoftware/deployments/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/deployments/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/deployments/teams","hooks_url":"https://api.github.com/repos/mendersoftware/deployments/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/deployments/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/deployments/events","assignees_url":"https://api.github.com/repos/mendersoftware/deployments/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/deployments/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/deployments/tags","blobs_url":"https://api.github.com/repos/mendersoftware/deployments/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/deployments/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/deployments/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/deployments/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/deployments/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/deployments/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/deployments/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/deployments/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/deployments/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/deployments/subscription","commits_url":"https://api.github.com/repos/mendersoftware/deployments/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/deployments/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/deployments/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/deployments/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/deployments/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/deployments/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/deployments/merges","archive_url":"https://api.github.com/repos/mendersoftware/deployments/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/deployments/downloads","issues_url":"https://api.github.com/repos/mendersoftware/deployments/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/deployments/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/deployments/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/deployments/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/deployments/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/deployments/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/deployments/deployments","created_at":"2015-11-25T15:09:38Z","updated_at":"2016-10-03T11:36:02Z","pushed_at":"2016-10-12T11:44:24Z","git_url":"git://github.com/mendersoftware/deployments.git","ssh_url":"git@github.com:mendersoftware/deployments.git","clone_url":"https://github.com/mendersoftware/deployments.git","svn_url":"https://github.com/mendersoftware/deployments","homepage":"mender.io","size":1407,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/deployments/pulls/159"},"html":{"href":"https://github.com/mendersoftware/deployments/pull/159"},"issue":{"href":"https://api.github.com/repos/mendersoftware/deployments/issues/159"},"comments":{"href":"https://api.github.com/repos/mendersoftware/deployments/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/deployments/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/deployments/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/deployments/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/deployments/statuses/e7a52c03cb600f4dfe14bc48ca5a03aa735d7d2a"}}}}
{"actor":{"display_login":"maciejmrowiec"}}