{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/83303782","pull_request_review_id":4157402,"id":83303782,"diff_hunk":"@@ -210,8 +216,8 @@\n     (jdbc/with-transacted-connection db\n       (scf-storage/maybe-activate-node! certname producer-timestamp)\n       (scf-storage/add-report! report received))\n-    (log/infof \"[%s] [%s] puppet v%s - %s\"\n-               id\n+    (log/infof \"[%s-%d] '%s' puppet v%s command processed for %s\"\n+               id, (tcoerce/to-long received)","path":"src/puppetlabs/puppetdb/command.clj","position":68,"original_position":68,"commit_id":"2980f4db6e46a6e456a139ec2ccc64e026cf2f0f","original_commit_id":"2980f4db6e46a6e456a139ec2ccc64e026cf2f0f","user":{"login":"aperiodic","id":115510,"avatar_url":"https://avatars.githubusercontent.com/u/115510?v=3","gravatar_id":"","url":"https://api.github.com/users/aperiodic","html_url":"https://github.com/aperiodic","followers_url":"https://api.github.com/users/aperiodic/followers","following_url":"https://api.github.com/users/aperiodic/following{/other_user}","gists_url":"https://api.github.com/users/aperiodic/gists{/gist_id}","starred_url":"https://api.github.com/users/aperiodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aperiodic/subscriptions","organizations_url":"https://api.github.com/users/aperiodic/orgs","repos_url":"https://api.github.com/users/aperiodic/repos","events_url":"https://api.github.com/users/aperiodic/events{/privacy}","received_events_url":"https://api.github.com/users/aperiodic/received_events","type":"User","site_admin":false},"body":"I typically use a comma when some lines have only one argument and other lines have multiple, but I'm not too attached to it. I'll add the `trs`","created_at":"2016-10-13T20:26:06Z","updated_at":"2016-10-13T20:26:07Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/2081#discussion_r83303782","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/83303782"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/2081#discussion_r83303782"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081","id":87582030,"html_url":"https://github.com/puppetlabs/puppetdb/pull/2081","diff_url":"https://github.com/puppetlabs/puppetdb/pull/2081.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/2081.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2081","number":2081,"state":"open","locked":false,"title":"(PDB-3067) Improve command logging","user":{"login":"aperiodic","id":115510,"avatar_url":"https://avatars.githubusercontent.com/u/115510?v=3","gravatar_id":"","url":"https://api.github.com/users/aperiodic","html_url":"https://github.com/aperiodic","followers_url":"https://api.github.com/users/aperiodic/followers","following_url":"https://api.github.com/users/aperiodic/following{/other_user}","gists_url":"https://api.github.com/users/aperiodic/gists{/gist_id}","starred_url":"https://api.github.com/users/aperiodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aperiodic/subscriptions","organizations_url":"https://api.github.com/users/aperiodic/orgs","repos_url":"https://api.github.com/users/aperiodic/repos","events_url":"https://api.github.com/users/aperiodic/events{/privacy}","received_events_url":"https://api.github.com/users/aperiodic/received_events","type":"User","site_admin":false},"body":"(**NB:** these commits depend on #2077 and should be merged after it.)\r\n\r\nChange the message identifier in the command namespace's log/info\r\ninvocations to be a concatenation of the stockpile ID and the timestamp\r\nthe message was received at, in order to guarantee uniqueness across\r\nrestarts (as the stockpile ID may reset).\r\n\r\nChange the overall structure of the logged message in the same form so\r\nit's clear *what* is being logged.\r\n\r\nWhen a command is placed on the queue, log its ID, command name, and\r\ncertname at the debug level, similarly to the logging after the command is\r\nprocessed.","created_at":"2016-09-30T23:41:31Z","updated_at":"2016-10-13T20:26:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d6cb3085ac9a26a14779c06458104c065f8aabc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2081/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/2980f4db6e46a6e456a139ec2ccc64e026cf2f0f","head":{"label":"aperiodic:pdb-3067-new-command-logging","ref":"pdb-3067-new-command-logging","sha":"2980f4db6e46a6e456a139ec2ccc64e026cf2f0f","user":{"login":"aperiodic","id":115510,"avatar_url":"https://avatars.githubusercontent.com/u/115510?v=3","gravatar_id":"","url":"https://api.github.com/users/aperiodic","html_url":"https://github.com/aperiodic","followers_url":"https://api.github.com/users/aperiodic/followers","following_url":"https://api.github.com/users/aperiodic/following{/other_user}","gists_url":"https://api.github.com/users/aperiodic/gists{/gist_id}","starred_url":"https://api.github.com/users/aperiodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aperiodic/subscriptions","organizations_url":"https://api.github.com/users/aperiodic/orgs","repos_url":"https://api.github.com/users/aperiodic/repos","events_url":"https://api.github.com/users/aperiodic/events{/privacy}","received_events_url":"https://api.github.com/users/aperiodic/received_events","type":"User","site_admin":false},"repo":{"id":67833014,"name":"puppetdb","full_name":"aperiodic/puppetdb","owner":{"login":"aperiodic","id":115510,"avatar_url":"https://avatars.githubusercontent.com/u/115510?v=3","gravatar_id":"","url":"https://api.github.com/users/aperiodic","html_url":"https://github.com/aperiodic","followers_url":"https://api.github.com/users/aperiodic/followers","following_url":"https://api.github.com/users/aperiodic/following{/other_user}","gists_url":"https://api.github.com/users/aperiodic/gists{/gist_id}","starred_url":"https://api.github.com/users/aperiodic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aperiodic/subscriptions","organizations_url":"https://api.github.com/users/aperiodic/orgs","repos_url":"https://api.github.com/users/aperiodic/repos","events_url":"https://api.github.com/users/aperiodic/events{/privacy}","received_events_url":"https://api.github.com/users/aperiodic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aperiodic/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/aperiodic/puppetdb","forks_url":"https://api.github.com/repos/aperiodic/puppetdb/forks","keys_url":"https://api.github.com/repos/aperiodic/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aperiodic/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aperiodic/puppetdb/teams","hooks_url":"https://api.github.com/repos/aperiodic/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/aperiodic/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/aperiodic/puppetdb/events","assignees_url":"https://api.github.com/repos/aperiodic/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/aperiodic/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/aperiodic/puppetdb/tags","blobs_url":"https://api.github.com/repos/aperiodic/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aperiodic/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aperiodic/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/aperiodic/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aperiodic/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/aperiodic/puppetdb/languages","stargazers_url":"https://api.github.com/repos/aperiodic/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/aperiodic/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/aperiodic/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/aperiodic/puppetdb/subscription","commits_url":"https://api.github.com/repos/aperiodic/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/aperiodic/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/aperiodic/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/aperiodic/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/aperiodic/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/aperiodic/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aperiodic/puppetdb/merges","archive_url":"https://api.github.com/repos/aperiodic/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aperiodic/puppetdb/downloads","issues_url":"https://api.github.com/repos/aperiodic/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/aperiodic/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/aperiodic/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/aperiodic/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aperiodic/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/aperiodic/puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/aperiodic/puppetdb/deployments","created_at":"2016-09-09T21:11:26Z","updated_at":"2016-09-09T21:11:29Z","pushed_at":"2016-10-10T21:18:14Z","git_url":"git://github.com/aperiodic/puppetdb.git","ssh_url":"git@github.com:aperiodic/puppetdb.git","clone_url":"https://github.com/aperiodic/puppetdb.git","svn_url":"https://github.com/aperiodic/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":16792,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"ac03a89079883d71297252cc3f5530b3e45e3c4d","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetdb/deployments","created_at":"2011-08-11T18:54:46Z","updated_at":"2016-09-23T10:07:04Z","pushed_at":"2016-10-12T22:52:07Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":20536,"stargazers_count":195,"watchers_count":195,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":7,"forks":162,"open_issues":7,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/2081"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2081"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2081/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2081/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/2980f4db6e46a6e456a139ec2ccc64e026cf2f0f"}}}}
{"actor":{"display_login":"aperiodic"}}