{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/81899378","pull_request_review_id":2845302,"id":81899378,"diff_hunk":"@@ -358,9 +366,18 @@ impl<'a, 'cfg> Context<'a, 'cfg> {\n                 })\n             } else {\n                 None\n+                /*","path":"src/cargo/ops/cargo_rustc/context.rs","position":26,"original_position":26,"commit_id":"488e743b734ea13364886141ee72b1d8ffdf403c","original_commit_id":"488e743b734ea13364886141ee72b1d8ffdf403c","user":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"body":"I left this code commented out to highlight a point.\r\nI believe that when building a path dependency, this function returns None in order to not \"pollute the suffix\" of the executable or the library.\r\n\r\nHowever, this means that when building across features, it appears to build to the same executable/library name.\r\n\r\nIt's correctly separating the .fingerprint, but not the actual built executable.","created_at":"2016-10-05T04:38:25Z","updated_at":"2016-10-05T04:43:21Z","html_url":"https://github.com/rust-lang/cargo/pull/3102#discussion_r81899378","pull_request_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3102","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments/81899378"},"html":{"href":"https://github.com/rust-lang/cargo/pull/3102#discussion_r81899378"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3102"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/3102","id":85751382,"html_url":"https://github.com/rust-lang/cargo/pull/3102","diff_url":"https://github.com/rust-lang/cargo/pull/3102.diff","patch_url":"https://github.com/rust-lang/cargo/pull/3102.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/3102","number":3102,"state":"open","locked":false,"title":"Mix feature flags into fingerprint/metadata shorthash","user":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"body":"Since building dependencies results in different libraries\r\ndepending on the feature flags, I added the feature flags into\r\nthe short_hash.\r\n\r\nThis solves an issue when multiple crates share a target directory\r\nor multiple targets share a common library with divergent feature\r\nflag choice.\r\n\r\nI'm not sure if this architecturally the best way to solve this problem, but I did confirm that this fixes the issue I was seeing. I can also add a test for this case if this code is taking the right approach (or if it would help illustrate the issue).","created_at":"2016-09-19T08:05:42Z","updated_at":"2016-10-05T04:43:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff9f8cbb1a5f77875640cd91b9e3b6e53b8debc4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3102/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/3102/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/3102/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/488e743b734ea13364886141ee72b1d8ffdf403c","head":{"label":"nipunn1313:attempt","ref":"attempt","sha":"488e743b734ea13364886141ee72b1d8ffdf403c","user":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"repo":{"id":68582550,"name":"cargo","full_name":"nipunn1313/cargo","owner":{"login":"nipunn1313","id":1300387,"avatar_url":"https://avatars.githubusercontent.com/u/1300387?v=3","gravatar_id":"","url":"https://api.github.com/users/nipunn1313","html_url":"https://github.com/nipunn1313","followers_url":"https://api.github.com/users/nipunn1313/followers","following_url":"https://api.github.com/users/nipunn1313/following{/other_user}","gists_url":"https://api.github.com/users/nipunn1313/gists{/gist_id}","starred_url":"https://api.github.com/users/nipunn1313/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipunn1313/subscriptions","organizations_url":"https://api.github.com/users/nipunn1313/orgs","repos_url":"https://api.github.com/users/nipunn1313/repos","events_url":"https://api.github.com/users/nipunn1313/events{/privacy}","received_events_url":"https://api.github.com/users/nipunn1313/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nipunn1313/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/nipunn1313/cargo","forks_url":"https://api.github.com/repos/nipunn1313/cargo/forks","keys_url":"https://api.github.com/repos/nipunn1313/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipunn1313/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipunn1313/cargo/teams","hooks_url":"https://api.github.com/repos/nipunn1313/cargo/hooks","issue_events_url":"https://api.github.com/repos/nipunn1313/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/nipunn1313/cargo/events","assignees_url":"https://api.github.com/repos/nipunn1313/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/nipunn1313/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/nipunn1313/cargo/tags","blobs_url":"https://api.github.com/repos/nipunn1313/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipunn1313/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipunn1313/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipunn1313/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipunn1313/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/nipunn1313/cargo/languages","stargazers_url":"https://api.github.com/repos/nipunn1313/cargo/stargazers","contributors_url":"https://api.github.com/repos/nipunn1313/cargo/contributors","subscribers_url":"https://api.github.com/repos/nipunn1313/cargo/subscribers","subscription_url":"https://api.github.com/repos/nipunn1313/cargo/subscription","commits_url":"https://api.github.com/repos/nipunn1313/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipunn1313/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipunn1313/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipunn1313/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipunn1313/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/nipunn1313/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipunn1313/cargo/merges","archive_url":"https://api.github.com/repos/nipunn1313/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipunn1313/cargo/downloads","issues_url":"https://api.github.com/repos/nipunn1313/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/nipunn1313/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/nipunn1313/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/nipunn1313/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipunn1313/cargo/labels{/name}","releases_url":"https://api.github.com/repos/nipunn1313/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/nipunn1313/cargo/deployments","created_at":"2016-09-19T07:57:30Z","updated_at":"2016-09-19T07:57:33Z","pushed_at":"2016-10-05T04:29:04Z","git_url":"git://github.com/nipunn1313/cargo.git","ssh_url":"git@github.com:nipunn1313/cargo.git","clone_url":"https://github.com/nipunn1313/cargo.git","svn_url":"https://github.com/nipunn1313/cargo","homepage":"https://crates.io/","size":12021,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"fe0a4a7dd9fd2db95dc2935f48c74144089681fa","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2016-10-04T00:38:51Z","pushed_at":"2016-10-05T04:29:04Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"https://crates.io/","size":81747,"stargazers_count":1821,"watchers_count":1821,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":450,"mirror_url":null,"open_issues_count":399,"forks":450,"open_issues":399,"watchers":1821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3102"},"html":{"href":"https://github.com/rust-lang/cargo/pull/3102"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/3102"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/3102/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3102/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/3102/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/488e743b734ea13364886141ee72b1d8ffdf403c"}}}}
{"actor":{"display_login":"nipunn1313"}}