{"action":"closed","number":6316,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6316","id":67892002,"html_url":"https://github.com/cockroachdb/cockroach/pull/6316","diff_url":"https://github.com/cockroachdb/cockroach/pull/6316.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6316.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6316","number":6316,"state":"closed","locked":false,"title":"sql: implement generic indexed variables for expressions","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"body":"Implementing generic support for expression variables that are addressed using\r\nan index. This replaces the `scanQValues` and will also be used by the new\r\nTableReader.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6316)\n<!-- Reviewable:end -->\n","created_at":"2016-04-26T14:08:03Z","updated_at":"2016-04-26T22:34:48Z","closed_at":"2016-04-26T22:34:48Z","merged_at":"2016-04-26T22:34:48Z","merge_commit_sha":"534ed380b3f8c5f8a31b4eddfd3ff8e32cb59222","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6316/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6316/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6316/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/5c5cc4900a68af2e25a84983eb91bf61634db230","head":{"label":"RaduBerinde:refactor-scan-qvals","ref":"refactor-scan-qvals","sha":"5c5cc4900a68af2e25a84983eb91bf61634db230","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"repo":{"id":49111463,"name":"cockroach","full_name":"RaduBerinde/cockroach","owner":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RaduBerinde/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/RaduBerinde/cockroach","forks_url":"https://api.github.com/repos/RaduBerinde/cockroach/forks","keys_url":"https://api.github.com/repos/RaduBerinde/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaduBerinde/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaduBerinde/cockroach/teams","hooks_url":"https://api.github.com/repos/RaduBerinde/cockroach/hooks","issue_events_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/RaduBerinde/cockroach/events","assignees_url":"https://api.github.com/repos/RaduBerinde/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/RaduBerinde/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/RaduBerinde/cockroach/tags","blobs_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaduBerinde/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/RaduBerinde/cockroach/languages","stargazers_url":"https://api.github.com/repos/RaduBerinde/cockroach/stargazers","contributors_url":"https://api.github.com/repos/RaduBerinde/cockroach/contributors","subscribers_url":"https://api.github.com/repos/RaduBerinde/cockroach/subscribers","subscription_url":"https://api.github.com/repos/RaduBerinde/cockroach/subscription","commits_url":"https://api.github.com/repos/RaduBerinde/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaduBerinde/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaduBerinde/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaduBerinde/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/RaduBerinde/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaduBerinde/cockroach/merges","archive_url":"https://api.github.com/repos/RaduBerinde/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaduBerinde/cockroach/downloads","issues_url":"https://api.github.com/repos/RaduBerinde/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/RaduBerinde/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/RaduBerinde/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/RaduBerinde/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaduBerinde/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/RaduBerinde/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/RaduBerinde/cockroach/deployments","created_at":"2016-01-06T04:07:30Z","updated_at":"2016-04-16T08:06:40Z","pushed_at":"2016-04-26T21:29:47Z","git_url":"git://github.com/RaduBerinde/cockroach.git","ssh_url":"git@github.com:RaduBerinde/cockroach.git","clone_url":"https://github.com/RaduBerinde/cockroach.git","svn_url":"https://github.com/RaduBerinde/cockroach","homepage":"http://www.cockroachlabs.com","size":153857,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"5e458b9fbd693ac494191177774aa79f59b86796","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-04-26T19:40:55Z","pushed_at":"2016-04-26T22:34:48Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":199067,"stargazers_count":6776,"watchers_count":6776,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":643,"mirror_url":null,"open_issues_count":417,"forks":643,"open_issues":417,"watchers":6776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6316"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/6316"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/6316"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/6316/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6316/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6316/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/5c5cc4900a68af2e25a84983eb91bf61634db230"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":209,"deletions":58,"changed_files":7}}