{"action":"created","comment":{"url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/comments/90270633","pull_request_review_id":10792079,"id":90270633,"diff_hunk":"@@ -112,7 +117,15 @@ protected void configure() {\n     @Named(\"akka-config\")\n     @SuppressFBWarnings(\"UPM_UNCALLED_PRIVATE_METHOD\") // Invoked reflectively by Guice\n     private Config provideAkkaConfig() {\n-        return ConfigFactory.parseMap(_configuration.getAkkaConfiguration(), _configuration.toString());\n+        try {\n+            final String akkaJsonConfig = OBJECT_MAPPER.writeValueAsString(_configuration.getAkkaConfiguration());","path":"src/main/java/com/arpnetworking/clusteraggregator/GuiceModule.java","position":34,"original_position":34,"commit_id":"fb8ca303afd50cf5f0be1f0180fac3e15e68dc02","original_commit_id":"fb8ca303afd50cf5f0be1f0180fac3e15e68dc02","user":{"login":"vjkoskela","id":1775197,"avatar_url":"https://avatars.githubusercontent.com/u/1775197?v=3","gravatar_id":"","url":"https://api.github.com/users/vjkoskela","html_url":"https://github.com/vjkoskela","followers_url":"https://api.github.com/users/vjkoskela/followers","following_url":"https://api.github.com/users/vjkoskela/following{/other_user}","gists_url":"https://api.github.com/users/vjkoskela/gists{/gist_id}","starred_url":"https://api.github.com/users/vjkoskela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjkoskela/subscriptions","organizations_url":"https://api.github.com/users/vjkoskela/orgs","repos_url":"https://api.github.com/users/vjkoskela/repos","events_url":"https://api.github.com/users/vjkoskela/events{/privacy}","received_events_url":"https://api.github.com/users/vjkoskela/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-11-30T16:31:24Z","updated_at":"2016-11-30T16:31:24Z","html_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator/pull/48#discussion_r90270633","pull_request_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/comments/90270633"},"html":{"href":"https://github.com/ArpNetworking/metrics-cluster-aggregator/pull/48#discussion_r90270633"},"pull_request":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48","id":95800068,"html_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator/pull/48","diff_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator/pull/48.diff","patch_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator/pull/48.patch","issue_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/48","number":48,"state":"open","locked":false,"title":"Switched from Java serialization to Kyro serialization for remoting.","user":{"login":"vjkoskela","id":1775197,"avatar_url":"https://avatars.githubusercontent.com/u/1775197?v=3","gravatar_id":"","url":"https://api.github.com/users/vjkoskela","html_url":"https://github.com/vjkoskela","followers_url":"https://api.github.com/users/vjkoskela/followers","following_url":"https://api.github.com/users/vjkoskela/following{/other_user}","gists_url":"https://api.github.com/users/vjkoskela/gists{/gist_id}","starred_url":"https://api.github.com/users/vjkoskela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjkoskela/subscriptions","organizations_url":"https://api.github.com/users/vjkoskela/orgs","repos_url":"https://api.github.com/users/vjkoskela/repos","events_url":"https://api.github.com/users/vjkoskela/events{/privacy}","received_events_url":"https://api.github.com/users/vjkoskela/received_events","type":"User","site_admin":false},"body":"To debug serialization (test only) add this under \"akka\" in config.json:\r\n```\r\n\"serialize-messages\": \"on\"\r\n```\r\n\r\nMore information on configuring serialization here: http://doc.akka.io/docs/akka/2.4/java/serialization.html\r\n\r\nAnd regarding the Kyro serializer here:\r\nhttps://github.com/romix/akka-kryo-serialization\r\n\r\nThe protostuff and quickser serializers were considered, but Kyro was the only one in Maven Central with reasonable maintenance record. Unlike protobuf it does not require any separation of serialized classes. However, this is a double edged sword. \r\n\r\nWe should separate our actor messages from our regular data model. Not saying we should switch to Protobuf, but rather we have a separate modeling issues and not blocking this and #47 on it I used Kryo to just serialize everything.","created_at":"2016-11-29T23:46:51Z","updated_at":"2016-11-30T16:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"172d84df2cda2b147f3592573a5c48f8d8c07155","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48/commits","review_comments_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48/comments","review_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/48/comments","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/statuses/fb8ca303afd50cf5f0be1f0180fac3e15e68dc02","head":{"label":"ArpNetworking:serialization","ref":"serialization","sha":"fb8ca303afd50cf5f0be1f0180fac3e15e68dc02","user":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":54176925,"name":"metrics-cluster-aggregator","full_name":"ArpNetworking/metrics-cluster-aggregator","owner":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator","description":null,"fork":false,"url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator","forks_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/forks","keys_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/teams","hooks_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/hooks","issue_events_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/events{/number}","events_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/events","assignees_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/assignees{/user}","branches_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/branches{/branch}","tags_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/tags","blobs_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/languages","stargazers_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/stargazers","contributors_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/contributors","subscribers_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/subscribers","subscription_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/subscription","commits_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/contents/{+path}","compare_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/merges","archive_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/downloads","issues_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues{/number}","pulls_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/labels{/name}","releases_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/releases{/id}","deployments_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/deployments","created_at":"2016-03-18T05:43:24Z","updated_at":"2016-11-16T23:20:12Z","pushed_at":"2016-11-30T16:26:57Z","git_url":"git://github.com/ArpNetworking/metrics-cluster-aggregator.git","ssh_url":"git@github.com:ArpNetworking/metrics-cluster-aggregator.git","clone_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator.git","svn_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator","homepage":null,"size":948,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":2,"default_branch":"master"}},"base":{"label":"ArpNetworking:master","ref":"master","sha":"915e9d69c39a8e4b55e1bd8d8b5b254988e86e8e","user":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"repo":{"id":54176925,"name":"metrics-cluster-aggregator","full_name":"ArpNetworking/metrics-cluster-aggregator","owner":{"login":"ArpNetworking","id":7937343,"avatar_url":"https://avatars.githubusercontent.com/u/7937343?v=3","gravatar_id":"","url":"https://api.github.com/users/ArpNetworking","html_url":"https://github.com/ArpNetworking","followers_url":"https://api.github.com/users/ArpNetworking/followers","following_url":"https://api.github.com/users/ArpNetworking/following{/other_user}","gists_url":"https://api.github.com/users/ArpNetworking/gists{/gist_id}","starred_url":"https://api.github.com/users/ArpNetworking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArpNetworking/subscriptions","organizations_url":"https://api.github.com/users/ArpNetworking/orgs","repos_url":"https://api.github.com/users/ArpNetworking/repos","events_url":"https://api.github.com/users/ArpNetworking/events{/privacy}","received_events_url":"https://api.github.com/users/ArpNetworking/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator","description":null,"fork":false,"url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator","forks_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/forks","keys_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/teams","hooks_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/hooks","issue_events_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/events{/number}","events_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/events","assignees_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/assignees{/user}","branches_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/branches{/branch}","tags_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/tags","blobs_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/languages","stargazers_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/stargazers","contributors_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/contributors","subscribers_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/subscribers","subscription_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/subscription","commits_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/contents/{+path}","compare_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/merges","archive_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/downloads","issues_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues{/number}","pulls_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/labels{/name}","releases_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/releases{/id}","deployments_url":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/deployments","created_at":"2016-03-18T05:43:24Z","updated_at":"2016-11-16T23:20:12Z","pushed_at":"2016-11-30T16:26:57Z","git_url":"git://github.com/ArpNetworking/metrics-cluster-aggregator.git","ssh_url":"git@github.com:ArpNetworking/metrics-cluster-aggregator.git","clone_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator.git","svn_url":"https://github.com/ArpNetworking/metrics-cluster-aggregator","homepage":null,"size":948,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":11,"forks":3,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48"},"html":{"href":"https://github.com/ArpNetworking/metrics-cluster-aggregator/pull/48"},"issue":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/48"},"comments":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/ArpNetworking/metrics-cluster-aggregator/statuses/fb8ca303afd50cf5f0be1f0180fac3e15e68dc02"}}}}
{"actor":{"display_login":"vjkoskela"}}