{"action":"created","comment":{"url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/comments/77911728","id":77911728,"diff_hunk":"@@ -50,7 +51,20 @@\n   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());\n \n   @Override\n-  public void init(@SuppressWarnings(\"rawtypes\") NamedList args) {}\n+  public void init(@SuppressWarnings(\"rawtypes\") NamedList args) {\n+    LTRThreadInterface.maxThreads  = getInt(args.get(\"LTRMaxThreads\"), LTRThreadInterface.DEFAULT_MAX_THREADS, \"LTRMaxThreads\");\n+    LTRThreadInterface.maxQueryThreads = getInt(args.get(\"LTRMaxQueryThreads\"), LTRThreadInterface.DEFAULT_MAX_QUERYTHREADS, \"LTRMaxQueryThreads\");\n+  }\n+  private int getInt(Object thObj, int defValue, String paramName){\n+     if (thObj != null) {\n+       try{\n+          return Integer.parseInt(thObj.toString());\n+       }catch(NumberFormatException nfe){\n+          log.error(\"{}: {} not an integer using defaultValue: {}\", nfe.toString(), paramName, defValue);","path":"solr/contrib/ltr/src/java/org/apache/solr/ltr/ranking/LTRQParserPlugin.java","position":22,"original_position":22,"commit_id":"d987b3bea28b44afe15e5394539ac67156f88916","original_commit_id":"d987b3bea28b44afe15e5394539ac67156f88916","user":{"login":"mnilsson23","id":16671874,"avatar_url":"https://avatars.githubusercontent.com/u/16671874?v=3","gravatar_id":"","url":"https://api.github.com/users/mnilsson23","html_url":"https://github.com/mnilsson23","followers_url":"https://api.github.com/users/mnilsson23/followers","following_url":"https://api.github.com/users/mnilsson23/following{/other_user}","gists_url":"https://api.github.com/users/mnilsson23/gists{/gist_id}","starred_url":"https://api.github.com/users/mnilsson23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnilsson23/subscriptions","organizations_url":"https://api.github.com/users/mnilsson23/orgs","repos_url":"https://api.github.com/users/mnilsson23/repos","events_url":"https://api.github.com/users/mnilsson23/events{/privacy}","received_events_url":"https://api.github.com/users/mnilsson23/received_events","type":"User","site_admin":false},"body":"Should we really be silently failing here?  I feel like we should still throw the exception, just like if you specified a garbage class in the schema, startup will/should fail.","created_at":"2016-09-07T21:56:47Z","updated_at":"2016-09-07T21:56:47Z","html_url":"https://github.com/bloomberg/lucene-solr/pull/68#discussion_r77911728","pull_request_url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/comments/77911728"},"html":{"href":"https://github.com/bloomberg/lucene-solr/pull/68#discussion_r77911728"},"pull_request":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68","id":83675088,"html_url":"https://github.com/bloomberg/lucene-solr/pull/68","diff_url":"https://github.com/bloomberg/lucene-solr/pull/68.diff","patch_url":"https://github.com/bloomberg/lucene-solr/pull/68.patch","issue_url":"https://api.github.com/repos/bloomberg/lucene-solr/issues/68","number":68,"state":"open","locked":false,"title":"Parallel weight creation in LTR","user":{"login":"nsanthapuri","id":20782020,"avatar_url":"https://avatars.githubusercontent.com/u/20782020?v=3","gravatar_id":"","url":"https://api.github.com/users/nsanthapuri","html_url":"https://github.com/nsanthapuri","followers_url":"https://api.github.com/users/nsanthapuri/followers","following_url":"https://api.github.com/users/nsanthapuri/following{/other_user}","gists_url":"https://api.github.com/users/nsanthapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/nsanthapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsanthapuri/subscriptions","organizations_url":"https://api.github.com/users/nsanthapuri/orgs","repos_url":"https://api.github.com/users/nsanthapuri/repos","events_url":"https://api.github.com/users/nsanthapuri/events{/privacy}","received_events_url":"https://api.github.com/users/nsanthapuri/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-01T17:36:15Z","updated_at":"2016-09-07T21:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e435d31d17b8ed796851669e5782d620f8b7e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68/commits","review_comments_url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68/comments","review_comment_url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/lucene-solr/issues/68/comments","statuses_url":"https://api.github.com/repos/bloomberg/lucene-solr/statuses/d987b3bea28b44afe15e5394539ac67156f88916","head":{"label":"nsanthapuri:parallelWeightCreation4","ref":"parallelWeightCreation4","sha":"d987b3bea28b44afe15e5394539ac67156f88916","user":{"login":"nsanthapuri","id":20782020,"avatar_url":"https://avatars.githubusercontent.com/u/20782020?v=3","gravatar_id":"","url":"https://api.github.com/users/nsanthapuri","html_url":"https://github.com/nsanthapuri","followers_url":"https://api.github.com/users/nsanthapuri/followers","following_url":"https://api.github.com/users/nsanthapuri/following{/other_user}","gists_url":"https://api.github.com/users/nsanthapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/nsanthapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsanthapuri/subscriptions","organizations_url":"https://api.github.com/users/nsanthapuri/orgs","repos_url":"https://api.github.com/users/nsanthapuri/repos","events_url":"https://api.github.com/users/nsanthapuri/events{/privacy}","received_events_url":"https://api.github.com/users/nsanthapuri/received_events","type":"User","site_admin":false},"repo":{"id":64705350,"name":"lucene-solr","full_name":"nsanthapuri/lucene-solr","owner":{"login":"nsanthapuri","id":20782020,"avatar_url":"https://avatars.githubusercontent.com/u/20782020?v=3","gravatar_id":"","url":"https://api.github.com/users/nsanthapuri","html_url":"https://github.com/nsanthapuri","followers_url":"https://api.github.com/users/nsanthapuri/followers","following_url":"https://api.github.com/users/nsanthapuri/following{/other_user}","gists_url":"https://api.github.com/users/nsanthapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/nsanthapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsanthapuri/subscriptions","organizations_url":"https://api.github.com/users/nsanthapuri/orgs","repos_url":"https://api.github.com/users/nsanthapuri/repos","events_url":"https://api.github.com/users/nsanthapuri/events{/privacy}","received_events_url":"https://api.github.com/users/nsanthapuri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsanthapuri/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/nsanthapuri/lucene-solr","forks_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/forks","keys_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/teams","hooks_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/events","assignees_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/tags","blobs_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/subscription","commits_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/merges","archive_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/downloads","issues_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/nsanthapuri/lucene-solr/deployments","created_at":"2016-08-01T22:16:33Z","updated_at":"2016-08-01T22:17:06Z","pushed_at":"2016-09-07T18:20:37Z","git_url":"git://github.com/nsanthapuri/lucene-solr.git","ssh_url":"git@github.com:nsanthapuri/lucene-solr.git","clone_url":"https://github.com/nsanthapuri/lucene-solr.git","svn_url":"https://github.com/nsanthapuri/lucene-solr","homepage":null,"size":424088,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master-ltr-plugin-develop","ref":"master-ltr-plugin-develop","sha":"67533ec391df3ad11e9156d38f0f7bde356e7cee","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":50526942,"name":"lucene-solr","full_name":"bloomberg/lucene-solr","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/bloomberg/lucene-solr","forks_url":"https://api.github.com/repos/bloomberg/lucene-solr/forks","keys_url":"https://api.github.com/repos/bloomberg/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/lucene-solr/teams","hooks_url":"https://api.github.com/repos/bloomberg/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/lucene-solr/events","assignees_url":"https://api.github.com/repos/bloomberg/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/lucene-solr/tags","blobs_url":"https://api.github.com/repos/bloomberg/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/bloomberg/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/lucene-solr/subscription","commits_url":"https://api.github.com/repos/bloomberg/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/lucene-solr/merges","archive_url":"https://api.github.com/repos/bloomberg/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/lucene-solr/downloads","issues_url":"https://api.github.com/repos/bloomberg/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/lucene-solr/deployments","created_at":"2016-01-27T18:02:47Z","updated_at":"2016-08-26T18:15:05Z","pushed_at":"2016-09-07T21:29:57Z","git_url":"git://github.com/bloomberg/lucene-solr.git","ssh_url":"git@github.com:bloomberg/lucene-solr.git","clone_url":"https://github.com/bloomberg/lucene-solr.git","svn_url":"https://github.com/bloomberg/lucene-solr","homepage":null,"size":444248,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68"},"html":{"href":"https://github.com/bloomberg/lucene-solr/pull/68"},"issue":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/issues/68"},"comments":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/lucene-solr/statuses/d987b3bea28b44afe15e5394539ac67156f88916"}}}}
{"actor":{"display_login":"mnilsson23"}}