{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/82753833","pull_request_review_id":3638402,"id":82753833,"diff_hunk":"@@ -65,6 +67,7 @@ public ClientEndpointImpl(ClientEngineImpl clientEngine, Connection conn) {\n         } else {\n             socketAddress = null;\n         }\n+        this.clientVersion = -1;","path":"hazelcast/src/main/java/com/hazelcast/client/impl/ClientEndpointImpl.java","position":20,"original_position":20,"commit_id":"d64674245d77931584e18146b414f9f594227867","original_commit_id":"a38efaf137dc4a70c683e4a34cc94d372d212e20","user":{"login":"vbekiaris","id":1212378,"avatar_url":"https://avatars.githubusercontent.com/u/1212378?v=3","gravatar_id":"","url":"https://api.github.com/users/vbekiaris","html_url":"https://github.com/vbekiaris","followers_url":"https://api.github.com/users/vbekiaris/followers","following_url":"https://api.github.com/users/vbekiaris/following{/other_user}","gists_url":"https://api.github.com/users/vbekiaris/gists{/gist_id}","starred_url":"https://api.github.com/users/vbekiaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbekiaris/subscriptions","organizations_url":"https://api.github.com/users/vbekiaris/orgs","repos_url":"https://api.github.com/users/vbekiaris/repos","events_url":"https://api.github.com/users/vbekiaris/events{/privacy}","received_events_url":"https://api.github.com/users/vbekiaris/received_events","type":"User","site_admin":false},"body":"`UNKNOWN_HAZELCAST_VERSION`?","created_at":"2016-10-11T09:19:23Z","updated_at":"2016-10-11T10:01:01Z","html_url":"https://github.com/hazelcast/hazelcast/pull/9066#discussion_r82753833","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/82753833"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/9066#discussion_r82753833"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066","id":88428235,"html_url":"https://github.com/hazelcast/hazelcast/pull/9066","diff_url":"https://github.com/hazelcast/hazelcast/pull/9066.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/9066.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9066","number":9066,"state":"open","locked":false,"title":"Cache getconfig and create config does not work for 3.6.x client connecting to the 3.7.x server","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"body":"Adds `toObject(Data, Class)` interface to `SerializationService`. This interface allows deserialization using a known object type.\r\n\r\nAdds the capability to deserialize a `DataSerializable` using a custom class name in the deserialized data rather than the actual object class name (e.g. the derived class name).\r\n\r\nAdds client and server version exchange during connection authentication.\r\n\r\nAdds compatibility fixes for Cache createConfig and getConfig requests and responses.\r\n\r\nAdds a 3.6.x compatibility switch to the server and client. Namely, the following properties: `hazelcast.compatibility.3.6_client`, `hazelcast.compatibility.3.6_server`. By default, this property is not set and 3.7.3, 3.8-SNAPSHOT will work with 3.7.x but not with 3.6.x. To make it work with 3.6.x, then the switch should be used.\r\n\r\nFixes https://github.com/hazelcast/hazelcast/issues/9006 and https://github.com/hazelcast/hazelcast/issues/9004","created_at":"2016-10-07T12:18:55Z","updated_at":"2016-10-11T10:01:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f80ad646b944b0bba6ae1d7d19be5143f8d5bfc6","assignee":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"assignees":[{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.8","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76/labels","id":1774122,"number":76,"title":"3.8","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":170,"closed_issues":199,"state":"open","created_at":"2016-05-18T14:13:56Z","updated_at":"2016-10-11T09:16:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9066/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d64674245d77931584e18146b414f9f594227867","head":{"label":"ihsandemir:getCacheConfigCompatibilityFix","ref":"getCacheConfigCompatibilityFix","sha":"d64674245d77931584e18146b414f9f594227867","user":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"repo":{"id":37186359,"name":"hazelcast","full_name":"ihsandemir/hazelcast","owner":{"login":"ihsandemir","id":7543261,"avatar_url":"https://avatars.githubusercontent.com/u/7543261?v=3","gravatar_id":"","url":"https://api.github.com/users/ihsandemir","html_url":"https://github.com/ihsandemir","followers_url":"https://api.github.com/users/ihsandemir/followers","following_url":"https://api.github.com/users/ihsandemir/following{/other_user}","gists_url":"https://api.github.com/users/ihsandemir/gists{/gist_id}","starred_url":"https://api.github.com/users/ihsandemir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihsandemir/subscriptions","organizations_url":"https://api.github.com/users/ihsandemir/orgs","repos_url":"https://api.github.com/users/ihsandemir/repos","events_url":"https://api.github.com/users/ihsandemir/events{/privacy}","received_events_url":"https://api.github.com/users/ihsandemir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ihsandemir/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/ihsandemir/hazelcast","forks_url":"https://api.github.com/repos/ihsandemir/hazelcast/forks","keys_url":"https://api.github.com/repos/ihsandemir/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ihsandemir/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ihsandemir/hazelcast/teams","hooks_url":"https://api.github.com/repos/ihsandemir/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/ihsandemir/hazelcast/events","assignees_url":"https://api.github.com/repos/ihsandemir/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/ihsandemir/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/ihsandemir/hazelcast/tags","blobs_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ihsandemir/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/ihsandemir/hazelcast/languages","stargazers_url":"https://api.github.com/repos/ihsandemir/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/ihsandemir/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/ihsandemir/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/ihsandemir/hazelcast/subscription","commits_url":"https://api.github.com/repos/ihsandemir/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/ihsandemir/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/ihsandemir/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/ihsandemir/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/ihsandemir/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ihsandemir/hazelcast/merges","archive_url":"https://api.github.com/repos/ihsandemir/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ihsandemir/hazelcast/downloads","issues_url":"https://api.github.com/repos/ihsandemir/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/ihsandemir/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/ihsandemir/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/ihsandemir/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ihsandemir/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/ihsandemir/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/ihsandemir/hazelcast/deployments","created_at":"2015-06-10T08:58:34Z","updated_at":"2015-06-10T08:58:48Z","pushed_at":"2016-10-11T09:17:37Z","git_url":"git://github.com/ihsandemir/hazelcast.git","ssh_url":"git@github.com:ihsandemir/hazelcast.git","clone_url":"https://github.com/ihsandemir/hazelcast.git","svn_url":"https://github.com/ihsandemir/hazelcast","homepage":"www.hazelcast.com","size":97006,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"bdca7fb96516b5d45d3528e94c156da044c0875b","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-10-10T14:27:59Z","pushed_at":"2016-10-11T09:23:10Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":134384,"stargazers_count":1747,"watchers_count":1747,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":818,"mirror_url":null,"open_issues_count":640,"forks":818,"open_issues":640,"watchers":1747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/9066"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/9066"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/9066/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9066/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/d64674245d77931584e18146b414f9f594227867"}}}}
{"actor":{"display_login":"vbekiaris"}}