{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/events","html_url":"https://github.com/mixxxdj/mixxx/pull/858","id":126973789,"number":858,"title":"Move menu logic and VC/Passthrough/Mic checking out of MixxxMainWindow.","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2016-01-15T22:45:46Z","updated_at":"2016-02-06T23:53:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858","html_url":"https://github.com/mixxxdj/mixxx/pull/858","diff_url":"https://github.com/mixxxdj/mixxx/pull/858.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/858.patch"},"body":"Drops 1000+ lines from mixxx.h/mixxx.cpp -- now they're \"only\" 1400 lines!\r\n\r\nI'm out for the weekend but figured I'd get this PR started. Some notes:\r\n\r\n* I removed the re-creation of the menu bar when toggling full screen. Bug #885890 and #1076789. I'd like to see if we still need this workaround on Trusty onwards. Maybe various bugs are fixed? In either case, @Pegasus-RPG reported that menubars are still broken on KDE so maybe this isn't the right fix after all.\r\n\r\n* I removed the partial menubar creation during bootup -- for me, QWidget::setMenuBar takes 95% of the time in initMenuBar() so not creating the full menubar doesn't seem like much of a savings to me at the code complexity cost it introduced.\r\n\r\n* I still have some TODO(rryan)'s in WMainMenuBar that I intend to fix before merging."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/180888987","html_url":"https://github.com/mixxxdj/mixxx/pull/858#issuecomment-180888987","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858","id":180888987,"user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"created_at":"2016-02-06T23:53:57Z","updated_at":"2016-02-06T23:53:57Z","body":"I'd like to get this in -- any further comments?"}}