{"action":"created","issue":{"url":"https://api.github.com/repos/melpa/melpa/issues/3620","repository_url":"https://api.github.com/repos/melpa/melpa","labels_url":"https://api.github.com/repos/melpa/melpa/issues/3620/labels{/name}","comments_url":"https://api.github.com/repos/melpa/melpa/issues/3620/comments","events_url":"https://api.github.com/repos/melpa/melpa/issues/3620/events","html_url":"https://github.com/melpa/melpa/pull/3620","id":135645256,"number":3620,"title":"Add sudo-edit package to recipes.","user":{"login":"nflath","id":46835,"avatar_url":"https://avatars.githubusercontent.com/u/46835?v=3","gravatar_id":"","url":"https://api.github.com/users/nflath","html_url":"https://github.com/nflath","followers_url":"https://api.github.com/users/nflath/followers","following_url":"https://api.github.com/users/nflath/following{/other_user}","gists_url":"https://api.github.com/users/nflath/gists{/gist_id}","starred_url":"https://api.github.com/users/nflath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nflath/subscriptions","organizations_url":"https://api.github.com/users/nflath/orgs","repos_url":"https://api.github.com/users/nflath/repos","events_url":"https://api.github.com/users/nflath/events{/privacy}","received_events_url":"https://api.github.com/users/nflath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-23T06:06:26Z","updated_at":"2016-02-23T08:09:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/melpa/melpa/pulls/3620","html_url":"https://github.com/melpa/melpa/pull/3620","diff_url":"https://github.com/melpa/melpa/pull/3620.diff","patch_url":"https://github.com/melpa/melpa/pull/3620.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/melpa/melpa/issues/comments/187595806","html_url":"https://github.com/melpa/melpa/pull/3620#issuecomment-187595806","issue_url":"https://api.github.com/repos/melpa/melpa/issues/3620","id":187595806,"user":{"login":"purcell","id":5636,"avatar_url":"https://avatars.githubusercontent.com/u/5636?v=3","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T08:09:02Z","updated_at":"2016-02-23T08:09:02Z","body":"Thanks. Looks good, but please don't do this:\r\n\r\n```el\r\n(global-set-key (kbd \"C-c C-r\") 'sudo-edit-current-file)\r\n```\r\n\r\nThe user should choose any global keybindings. Maybe suggest the above in the `Commentary` section of the file.\r\n\r\nIf you want to make the code more robust, you might consider handling the case where `buffer-file-name` is nil. And maybe `(concat \"/sudo:root@localhost:\" x)` should be extracted as a little helper function to avoid repeating the magic string.\r\n\r\nWhen I commit this I'd squash the two commits to keep our history clean. If you have a moment to that, it would make my life easier."}}