{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/dynomite/pulls/comments/63566005","id":63566005,"diff_hunk":"@@ -114,65 +114,10 @@ server_active(struct conn *conn)\n \treturn false;\n }\n \n-static rstatus_t\n-server_each_set_owner(void *elem, void *data)\n-{\n-\tstruct server *s = elem;\n-\tstruct server_pool *sp = data;\n-\n-\ts->owner = sp;\n-\n-\treturn DN_OK;\n-}\n-\n static void\n-server_deinit(struct array *server)\n+server_deinit(struct server **pdatastore)","path":"src/dyn_server.c","position":17,"original_position":17,"commit_id":"3c3dd02b6ebd2f36c51f6aaea7a8c8ecae5f1b78","original_commit_id":"1583f17370a940f8299dc27dc77ae38186f1c5cf","user":{"login":"shailesh33","id":12148455,"avatar_url":"https://avatars.githubusercontent.com/u/12148455?v=3","gravatar_id":"","url":"https://api.github.com/users/shailesh33","html_url":"https://github.com/shailesh33","followers_url":"https://api.github.com/users/shailesh33/followers","following_url":"https://api.github.com/users/shailesh33/following{/other_user}","gists_url":"https://api.github.com/users/shailesh33/gists{/gist_id}","starred_url":"https://api.github.com/users/shailesh33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shailesh33/subscriptions","organizations_url":"https://api.github.com/users/shailesh33/orgs","repos_url":"https://api.github.com/users/shailesh33/repos","events_url":"https://api.github.com/users/shailesh33/events{/privacy}","received_events_url":"https://api.github.com/users/shailesh33/received_events","type":"User","site_admin":false},"body":"I did the right thing (almost)","created_at":"2016-05-17T17:25:27Z","updated_at":"2016-05-17T17:25:27Z","html_url":"https://github.com/Netflix/dynomite/pull/291#discussion_r63566005","pull_request_url":"https://api.github.com/repos/Netflix/dynomite/pulls/291","_links":{"self":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/comments/63566005"},"html":{"href":"https://github.com/Netflix/dynomite/pull/291#discussion_r63566005"},"pull_request":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/dynomite/pulls/291","id":68962425,"html_url":"https://github.com/Netflix/dynomite/pull/291","diff_url":"https://github.com/Netflix/dynomite/pull/291.diff","patch_url":"https://github.com/Netflix/dynomite/pull/291.patch","issue_url":"https://api.github.com/repos/Netflix/dynomite/issues/291","number":291,"state":"open","locked":false,"title":"Cleanup dyn_conf","user":{"login":"shailesh33","id":12148455,"avatar_url":"https://avatars.githubusercontent.com/u/12148455?v=3","gravatar_id":"","url":"https://api.github.com/users/shailesh33","html_url":"https://github.com/shailesh33","followers_url":"https://api.github.com/users/shailesh33/followers","following_url":"https://api.github.com/users/shailesh33/following{/other_user}","gists_url":"https://api.github.com/users/shailesh33/gists{/gist_id}","starred_url":"https://api.github.com/users/shailesh33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shailesh33/subscriptions","organizations_url":"https://api.github.com/users/shailesh33/orgs","repos_url":"https://api.github.com/users/shailesh33/repos","events_url":"https://api.github.com/users/shailesh33/events{/privacy}","received_events_url":"https://api.github.com/users/shailesh33/received_events","type":"User","site_admin":false},"body":"    o Mainly try to keep dyn_conf.h clean so its understood whats the\r\ninterface\r\n    o Create a new enum type of secure server option and use that\r\n    o reduce the warnings in dyn_conf.c\r\n    o Get ride of ctx_id\r\n\r\nSorry about the messy diff. Its only because of function reordering","created_at":"2016-05-05T03:27:42Z","updated_at":"2016-05-17T17:25:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8108759070d411722e91474d97c0b9d52a436028","assignee":{"login":"ipapapa","id":4562887,"avatar_url":"https://avatars.githubusercontent.com/u/4562887?v=3","gravatar_id":"","url":"https://api.github.com/users/ipapapa","html_url":"https://github.com/ipapapa","followers_url":"https://api.github.com/users/ipapapa/followers","following_url":"https://api.github.com/users/ipapapa/following{/other_user}","gists_url":"https://api.github.com/users/ipapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ipapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipapapa/subscriptions","organizations_url":"https://api.github.com/users/ipapapa/orgs","repos_url":"https://api.github.com/users/ipapapa/repos","events_url":"https://api.github.com/users/ipapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ipapapa/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/dynomite/pulls/291/commits","review_comments_url":"https://api.github.com/repos/Netflix/dynomite/pulls/291/comments","review_comment_url":"https://api.github.com/repos/Netflix/dynomite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/dynomite/issues/291/comments","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/3c3dd02b6ebd2f36c51f6aaea7a8c8ecae5f1b78","head":{"label":"Netflix:cleanup","ref":"cleanup","sha":"3c3dd02b6ebd2f36c51f6aaea7a8c8ecae5f1b78","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":13484625,"name":"dynomite","full_name":"Netflix/dynomite","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/dynomite","description":"A generic dynamo implementation for different k-v storage engines","fork":false,"url":"https://api.github.com/repos/Netflix/dynomite","forks_url":"https://api.github.com/repos/Netflix/dynomite/forks","keys_url":"https://api.github.com/repos/Netflix/dynomite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/dynomite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/dynomite/teams","hooks_url":"https://api.github.com/repos/Netflix/dynomite/hooks","issue_events_url":"https://api.github.com/repos/Netflix/dynomite/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/dynomite/events","assignees_url":"https://api.github.com/repos/Netflix/dynomite/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/dynomite/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/dynomite/tags","blobs_url":"https://api.github.com/repos/Netflix/dynomite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/dynomite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/dynomite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/dynomite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/dynomite/languages","stargazers_url":"https://api.github.com/repos/Netflix/dynomite/stargazers","contributors_url":"https://api.github.com/repos/Netflix/dynomite/contributors","subscribers_url":"https://api.github.com/repos/Netflix/dynomite/subscribers","subscription_url":"https://api.github.com/repos/Netflix/dynomite/subscription","commits_url":"https://api.github.com/repos/Netflix/dynomite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/dynomite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/dynomite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/dynomite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/dynomite/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/dynomite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/dynomite/merges","archive_url":"https://api.github.com/repos/Netflix/dynomite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/dynomite/downloads","issues_url":"https://api.github.com/repos/Netflix/dynomite/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/dynomite/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/dynomite/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/dynomite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/dynomite/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/dynomite/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/dynomite/deployments","created_at":"2013-10-10T22:36:31Z","updated_at":"2016-05-17T14:21:21Z","pushed_at":"2016-05-17T17:25:07Z","git_url":"git://github.com/Netflix/dynomite.git","ssh_url":"git@github.com:Netflix/dynomite.git","clone_url":"https://github.com/Netflix/dynomite.git","svn_url":"https://github.com/Netflix/dynomite","homepage":"","size":4445,"stargazers_count":1329,"watchers_count":1329,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":47,"forks":154,"open_issues":47,"watchers":1329,"default_branch":"dev"}},"base":{"label":"Netflix:dev","ref":"dev","sha":"17e565a4eb99d958b800cd0254f40e6139070ee9","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":13484625,"name":"dynomite","full_name":"Netflix/dynomite","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/dynomite","description":"A generic dynamo implementation for different k-v storage engines","fork":false,"url":"https://api.github.com/repos/Netflix/dynomite","forks_url":"https://api.github.com/repos/Netflix/dynomite/forks","keys_url":"https://api.github.com/repos/Netflix/dynomite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/dynomite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/dynomite/teams","hooks_url":"https://api.github.com/repos/Netflix/dynomite/hooks","issue_events_url":"https://api.github.com/repos/Netflix/dynomite/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/dynomite/events","assignees_url":"https://api.github.com/repos/Netflix/dynomite/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/dynomite/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/dynomite/tags","blobs_url":"https://api.github.com/repos/Netflix/dynomite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/dynomite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/dynomite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/dynomite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/dynomite/languages","stargazers_url":"https://api.github.com/repos/Netflix/dynomite/stargazers","contributors_url":"https://api.github.com/repos/Netflix/dynomite/contributors","subscribers_url":"https://api.github.com/repos/Netflix/dynomite/subscribers","subscription_url":"https://api.github.com/repos/Netflix/dynomite/subscription","commits_url":"https://api.github.com/repos/Netflix/dynomite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/dynomite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/dynomite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/dynomite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/dynomite/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/dynomite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/dynomite/merges","archive_url":"https://api.github.com/repos/Netflix/dynomite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/dynomite/downloads","issues_url":"https://api.github.com/repos/Netflix/dynomite/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/dynomite/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/dynomite/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/dynomite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/dynomite/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/dynomite/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/dynomite/deployments","created_at":"2013-10-10T22:36:31Z","updated_at":"2016-05-17T14:21:21Z","pushed_at":"2016-05-17T17:25:07Z","git_url":"git://github.com/Netflix/dynomite.git","ssh_url":"git@github.com:Netflix/dynomite.git","clone_url":"https://github.com/Netflix/dynomite.git","svn_url":"https://github.com/Netflix/dynomite","homepage":"","size":4445,"stargazers_count":1329,"watchers_count":1329,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":47,"forks":154,"open_issues":47,"watchers":1329,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/291"},"html":{"href":"https://github.com/Netflix/dynomite/pull/291"},"issue":{"href":"https://api.github.com/repos/Netflix/dynomite/issues/291"},"comments":{"href":"https://api.github.com/repos/Netflix/dynomite/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/dynomite/statuses/3c3dd02b6ebd2f36c51f6aaea7a8c8ecae5f1b78"}}}}