{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/8164","repository_url":"https://api.github.com/repos/zurb/foundation-sites","labels_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8164/labels{/name}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8164/comments","events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8164/events","html_url":"https://github.com/zurb/foundation-sites/issues/8164","id":133775719,"number":8164,"title":"Vertical rhythm in Foundation 6","user":{"login":"karland","id":4803370,"avatar_url":"https://avatars.githubusercontent.com/u/4803370?v=3","gravatar_id":"","url":"https://api.github.com/users/karland","html_url":"https://github.com/karland","followers_url":"https://api.github.com/users/karland/followers","following_url":"https://api.github.com/users/karland/following{/other_user}","gists_url":"https://api.github.com/users/karland/gists{/gist_id}","starred_url":"https://api.github.com/users/karland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karland/subscriptions","organizations_url":"https://api.github.com/users/karland/orgs","repos_url":"https://api.github.com/users/karland/repos","events_url":"https://api.github.com/users/karland/events{/privacy}","received_events_url":"https://api.github.com/users/karland/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zurb/foundation-sites/labels/feature","name":"feature","color":"eeeeee"},{"url":"https://api.github.com/repos/zurb/foundation-sites/labels/scss","name":"scss","color":"c6538c"}],"state":"open","locked":false,"assignee":{"login":"brettsmason","id":73229,"avatar_url":"https://avatars.githubusercontent.com/u/73229?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsmason","html_url":"https://github.com/brettsmason","followers_url":"https://api.github.com/users/brettsmason/followers","following_url":"https://api.github.com/users/brettsmason/following{/other_user}","gists_url":"https://api.github.com/users/brettsmason/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsmason/subscriptions","organizations_url":"https://api.github.com/users/brettsmason/orgs","repos_url":"https://api.github.com/users/brettsmason/repos","events_url":"https://api.github.com/users/brettsmason/events{/privacy}","received_events_url":"https://api.github.com/users/brettsmason/received_events","type":"User","site_admin":false},"assignees":[{"login":"brettsmason","id":73229,"avatar_url":"https://avatars.githubusercontent.com/u/73229?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsmason","html_url":"https://github.com/brettsmason","followers_url":"https://api.github.com/users/brettsmason/followers","following_url":"https://api.github.com/users/brettsmason/following{/other_user}","gists_url":"https://api.github.com/users/brettsmason/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsmason/subscriptions","organizations_url":"https://api.github.com/users/brettsmason/orgs","repos_url":"https://api.github.com/users/brettsmason/repos","events_url":"https://api.github.com/users/brettsmason/events{/privacy}","received_events_url":"https://api.github.com/users/brettsmason/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2016-02-15T17:38:42Z","updated_at":"2016-10-20T06:53:30Z","closed_at":null,"body":"@gakimball @rafibomb A lot of people love vertical rhythms in their sites, me included. There are external tools to achieve this, but I think it would be nice if F6 would make it a little easier to actually make the appropriate settings in `_settings.scss` without external dependencies. \r\n\r\nThe basic idea for achieving vertical rhythm in F6 would be to have all all top/bottom margins and paddings and all `line-heights` to be a multiple of the `$global-lineheight`. This is almost already possible now, but here are some necessary changes:\r\n+ add `$header-line-heights` similar to `$header-sizes`. This allows to choose the line-height, when header-sizes change responsively\r\n+ form-elements are not behaving very vertical ryhthm like. They would require to be explicitey styled with `$form-element-padding` and `$form-element-margin` (the `$form-spacing` would then play a less important role)\r\n+ change docs\r\n\r\nI am happy to make a PR, but before I would like to check with ZURB if this is actually desired. \r\n\r\nThe old default values for the current line-height-settings and margins or paddings would remain."},"comment":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments/255023995","html_url":"https://github.com/zurb/foundation-sites/issues/8164#issuecomment-255023995","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/8164","id":255023995,"user":{"login":"brettsmason","id":73229,"avatar_url":"https://avatars.githubusercontent.com/u/73229?v=3","gravatar_id":"","url":"https://api.github.com/users/brettsmason","html_url":"https://github.com/brettsmason","followers_url":"https://api.github.com/users/brettsmason/followers","following_url":"https://api.github.com/users/brettsmason/following{/other_user}","gists_url":"https://api.github.com/users/brettsmason/gists{/gist_id}","starred_url":"https://api.github.com/users/brettsmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettsmason/subscriptions","organizations_url":"https://api.github.com/users/brettsmason/orgs","repos_url":"https://api.github.com/users/brettsmason/repos","events_url":"https://api.github.com/users/brettsmason/events{/privacy}","received_events_url":"https://api.github.com/users/brettsmason/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T06:53:29Z","updated_at":"2016-10-20T06:53:29Z","body":"@andycochran I agree about `$header-sizes` not being the ideal variable to use - I just thought it might be easier, but I agree a new map would probably be better and deprecate the other variables (and remove in 6.4 for example). One map would also be easier to output the styles from than multiple.\r\n\r\nI'm trying to also think ahead of how we would treat other components with similar functionality once headers are done - do you think `${component}-styles` is right, or do you think we should be mentioning rhythm? I guess I'm not sure if everyone will understand rhythm, so styles is probably right.\r\n\r\nOut of your examples, I like the simplicity of number 1 (similar to my first example). However number 2 (same as mine here: http://codepen.io/brettsmason/pen/rrYkBo) is a lot more readable. However I think its going to end up being far too long going forward, but happy to discuss that further.\r\n\r\nOn the one hand your first example would work well if we were to expand to forms in terms of the labels being clear, but I dont know how you would associate the values with anything in that scenario, so we end up with the same issue as my first example.\r\n\r\nWith comments and good documentation do you think we can adapt one of first examples to work? Like you also mentioned, inheritance is taken care of by not entering a value.\r\n\r\nI'm wondering if a vertical rythm function would also be useful. So instead of having to look at modularscale.com etc, we can work it out for them (not sure how needed this is or not).\r\n\r\nWhat about a `$vertical-rhythm` map, with breakpoint sizes in and a scale in each size? Not sure how exactly this could work yet though.\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"brettsmason"}}