{"action":"created","comment":{"url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments/80329745","id":80329745,"diff_hunk":"@@ -108,6 +108,26 @@ config :ex_aws,\n \n This means it will first look for the AWS standard `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` environment variables, and fall back using instance meta-data if those don't exist. You should set those environment variables to your credentials, or configure an instance that this library runs on to have an iam role.\n \n+## Retries\n+\n+ExAws will retry failed AWS API requests using exponential backoff per the \"Full Jitter\" formula described in https://www.awsarchitectureblog.com/2015/03/backoff.html\n+\n+The algorithm uses three values, which are configurable:\n+\n+```\n+# default values shown below\n+\n+config :ex_aws, retries: %{\n+  max_attempts: 10,\n+  base_backoff_in_ms: 10,\n+  max_backoff_in_ms: 10_000,\n+}","path":"README.md","position":17,"original_position":17,"commit_id":"c7091cc2eb7314fb83a5482a295c70b5568eef39","original_commit_id":"c7091cc2eb7314fb83a5482a295c70b5568eef39","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars.githubusercontent.com/u/247817?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"body":"Because you're using the Access behaviour when accessing retries this probably doesn't really require any changes to the config module, but you should confirm that it works happily anyway.","created_at":"2016-09-23T21:24:53Z","updated_at":"2016-09-23T21:24:57Z","html_url":"https://github.com/CargoSense/ex_aws/pull/225#discussion_r80329745","pull_request_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments/80329745"},"html":{"href":"https://github.com/CargoSense/ex_aws/pull/225#discussion_r80329745"},"pull_request":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225","id":86571484,"html_url":"https://github.com/CargoSense/ex_aws/pull/225","diff_url":"https://github.com/CargoSense/ex_aws/pull/225.diff","patch_url":"https://github.com/CargoSense/ex_aws/pull/225.patch","issue_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/225","number":225,"state":"open","locked":false,"title":"Move retry options to configuration","user":{"login":"ajvondrak","id":600924,"avatar_url":"https://avatars.githubusercontent.com/u/600924?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvondrak","html_url":"https://github.com/ajvondrak","followers_url":"https://api.github.com/users/ajvondrak/followers","following_url":"https://api.github.com/users/ajvondrak/following{/other_user}","gists_url":"https://api.github.com/users/ajvondrak/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvondrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvondrak/subscriptions","organizations_url":"https://api.github.com/users/ajvondrak/orgs","repos_url":"https://api.github.com/users/ajvondrak/repos","events_url":"https://api.github.com/users/ajvondrak/events{/privacy}","received_events_url":"https://api.github.com/users/ajvondrak/received_events","type":"User","site_admin":false},"body":"No tests, but there weren't tests around this code in the first place. I did try it out on my project locally (using a `path:` dependency) and it seems to work as planned. Hope the code isn't too ugly!\r\n\r\nFixes #224.","created_at":"2016-09-23T19:55:12Z","updated_at":"2016-09-23T21:24:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43122d932e515b35cb21ac6e67e025a4432aad79","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225/commits","review_comments_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225/comments","review_comment_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/225/comments","statuses_url":"https://api.github.com/repos/CargoSense/ex_aws/statuses/c7091cc2eb7314fb83a5482a295c70b5568eef39","head":{"label":"ajvondrak:configurable_retries","ref":"configurable_retries","sha":"c7091cc2eb7314fb83a5482a295c70b5568eef39","user":{"login":"ajvondrak","id":600924,"avatar_url":"https://avatars.githubusercontent.com/u/600924?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvondrak","html_url":"https://github.com/ajvondrak","followers_url":"https://api.github.com/users/ajvondrak/followers","following_url":"https://api.github.com/users/ajvondrak/following{/other_user}","gists_url":"https://api.github.com/users/ajvondrak/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvondrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvondrak/subscriptions","organizations_url":"https://api.github.com/users/ajvondrak/orgs","repos_url":"https://api.github.com/users/ajvondrak/repos","events_url":"https://api.github.com/users/ajvondrak/events{/privacy}","received_events_url":"https://api.github.com/users/ajvondrak/received_events","type":"User","site_admin":false},"repo":{"id":69053956,"name":"ex_aws","full_name":"ajvondrak/ex_aws","owner":{"login":"ajvondrak","id":600924,"avatar_url":"https://avatars.githubusercontent.com/u/600924?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvondrak","html_url":"https://github.com/ajvondrak","followers_url":"https://api.github.com/users/ajvondrak/followers","following_url":"https://api.github.com/users/ajvondrak/following{/other_user}","gists_url":"https://api.github.com/users/ajvondrak/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvondrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvondrak/subscriptions","organizations_url":"https://api.github.com/users/ajvondrak/orgs","repos_url":"https://api.github.com/users/ajvondrak/repos","events_url":"https://api.github.com/users/ajvondrak/events{/privacy}","received_events_url":"https://api.github.com/users/ajvondrak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajvondrak/ex_aws","description":"A flexible, easy to use set of clients AWS APIs for Elixir","fork":true,"url":"https://api.github.com/repos/ajvondrak/ex_aws","forks_url":"https://api.github.com/repos/ajvondrak/ex_aws/forks","keys_url":"https://api.github.com/repos/ajvondrak/ex_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajvondrak/ex_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajvondrak/ex_aws/teams","hooks_url":"https://api.github.com/repos/ajvondrak/ex_aws/hooks","issue_events_url":"https://api.github.com/repos/ajvondrak/ex_aws/issues/events{/number}","events_url":"https://api.github.com/repos/ajvondrak/ex_aws/events","assignees_url":"https://api.github.com/repos/ajvondrak/ex_aws/assignees{/user}","branches_url":"https://api.github.com/repos/ajvondrak/ex_aws/branches{/branch}","tags_url":"https://api.github.com/repos/ajvondrak/ex_aws/tags","blobs_url":"https://api.github.com/repos/ajvondrak/ex_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajvondrak/ex_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajvondrak/ex_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajvondrak/ex_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajvondrak/ex_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/ajvondrak/ex_aws/languages","stargazers_url":"https://api.github.com/repos/ajvondrak/ex_aws/stargazers","contributors_url":"https://api.github.com/repos/ajvondrak/ex_aws/contributors","subscribers_url":"https://api.github.com/repos/ajvondrak/ex_aws/subscribers","subscription_url":"https://api.github.com/repos/ajvondrak/ex_aws/subscription","commits_url":"https://api.github.com/repos/ajvondrak/ex_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajvondrak/ex_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajvondrak/ex_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajvondrak/ex_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajvondrak/ex_aws/contents/{+path}","compare_url":"https://api.github.com/repos/ajvondrak/ex_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajvondrak/ex_aws/merges","archive_url":"https://api.github.com/repos/ajvondrak/ex_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajvondrak/ex_aws/downloads","issues_url":"https://api.github.com/repos/ajvondrak/ex_aws/issues{/number}","pulls_url":"https://api.github.com/repos/ajvondrak/ex_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/ajvondrak/ex_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/ajvondrak/ex_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajvondrak/ex_aws/labels{/name}","releases_url":"https://api.github.com/repos/ajvondrak/ex_aws/releases{/id}","deployments_url":"https://api.github.com/repos/ajvondrak/ex_aws/deployments","created_at":"2016-09-23T19:16:34Z","updated_at":"2016-09-23T19:16:36Z","pushed_at":"2016-09-23T19:53:09Z","git_url":"git://github.com/ajvondrak/ex_aws.git","ssh_url":"git@github.com:ajvondrak/ex_aws.git","clone_url":"https://github.com/ajvondrak/ex_aws.git","svn_url":"https://github.com/ajvondrak/ex_aws","homepage":"https://hex.pm/packages/ex_aws","size":982,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CargoSense:master","ref":"master","sha":"ce3d727b42154e37105b717cabb50e16db1ff001","user":{"login":"CargoSense","id":3963271,"avatar_url":"https://avatars.githubusercontent.com/u/3963271?v=3","gravatar_id":"","url":"https://api.github.com/users/CargoSense","html_url":"https://github.com/CargoSense","followers_url":"https://api.github.com/users/CargoSense/followers","following_url":"https://api.github.com/users/CargoSense/following{/other_user}","gists_url":"https://api.github.com/users/CargoSense/gists{/gist_id}","starred_url":"https://api.github.com/users/CargoSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CargoSense/subscriptions","organizations_url":"https://api.github.com/users/CargoSense/orgs","repos_url":"https://api.github.com/users/CargoSense/repos","events_url":"https://api.github.com/users/CargoSense/events{/privacy}","received_events_url":"https://api.github.com/users/CargoSense/received_events","type":"Organization","site_admin":false},"repo":{"id":24062989,"name":"ex_aws","full_name":"CargoSense/ex_aws","owner":{"login":"CargoSense","id":3963271,"avatar_url":"https://avatars.githubusercontent.com/u/3963271?v=3","gravatar_id":"","url":"https://api.github.com/users/CargoSense","html_url":"https://github.com/CargoSense","followers_url":"https://api.github.com/users/CargoSense/followers","following_url":"https://api.github.com/users/CargoSense/following{/other_user}","gists_url":"https://api.github.com/users/CargoSense/gists{/gist_id}","starred_url":"https://api.github.com/users/CargoSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CargoSense/subscriptions","organizations_url":"https://api.github.com/users/CargoSense/orgs","repos_url":"https://api.github.com/users/CargoSense/repos","events_url":"https://api.github.com/users/CargoSense/events{/privacy}","received_events_url":"https://api.github.com/users/CargoSense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CargoSense/ex_aws","description":"A flexible, easy to use set of clients AWS APIs for Elixir","fork":false,"url":"https://api.github.com/repos/CargoSense/ex_aws","forks_url":"https://api.github.com/repos/CargoSense/ex_aws/forks","keys_url":"https://api.github.com/repos/CargoSense/ex_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CargoSense/ex_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CargoSense/ex_aws/teams","hooks_url":"https://api.github.com/repos/CargoSense/ex_aws/hooks","issue_events_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/events{/number}","events_url":"https://api.github.com/repos/CargoSense/ex_aws/events","assignees_url":"https://api.github.com/repos/CargoSense/ex_aws/assignees{/user}","branches_url":"https://api.github.com/repos/CargoSense/ex_aws/branches{/branch}","tags_url":"https://api.github.com/repos/CargoSense/ex_aws/tags","blobs_url":"https://api.github.com/repos/CargoSense/ex_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CargoSense/ex_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CargoSense/ex_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/CargoSense/ex_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CargoSense/ex_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/CargoSense/ex_aws/languages","stargazers_url":"https://api.github.com/repos/CargoSense/ex_aws/stargazers","contributors_url":"https://api.github.com/repos/CargoSense/ex_aws/contributors","subscribers_url":"https://api.github.com/repos/CargoSense/ex_aws/subscribers","subscription_url":"https://api.github.com/repos/CargoSense/ex_aws/subscription","commits_url":"https://api.github.com/repos/CargoSense/ex_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/CargoSense/ex_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/CargoSense/ex_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/CargoSense/ex_aws/contents/{+path}","compare_url":"https://api.github.com/repos/CargoSense/ex_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CargoSense/ex_aws/merges","archive_url":"https://api.github.com/repos/CargoSense/ex_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CargoSense/ex_aws/downloads","issues_url":"https://api.github.com/repos/CargoSense/ex_aws/issues{/number}","pulls_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/CargoSense/ex_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/CargoSense/ex_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CargoSense/ex_aws/labels{/name}","releases_url":"https://api.github.com/repos/CargoSense/ex_aws/releases{/id}","deployments_url":"https://api.github.com/repos/CargoSense/ex_aws/deployments","created_at":"2014-09-15T16:02:48Z","updated_at":"2016-09-22T14:30:36Z","pushed_at":"2016-09-23T19:55:12Z","git_url":"git://github.com/CargoSense/ex_aws.git","ssh_url":"git@github.com:CargoSense/ex_aws.git","clone_url":"https://github.com/CargoSense/ex_aws.git","svn_url":"https://github.com/CargoSense/ex_aws","homepage":"https://hex.pm/packages/ex_aws","size":1283,"stargazers_count":218,"watchers_count":218,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":14,"forks":80,"open_issues":14,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225"},"html":{"href":"https://github.com/CargoSense/ex_aws/pull/225"},"issue":{"href":"https://api.github.com/repos/CargoSense/ex_aws/issues/225"},"comments":{"href":"https://api.github.com/repos/CargoSense/ex_aws/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/CargoSense/ex_aws/statuses/c7091cc2eb7314fb83a5482a295c70b5568eef39"}}}}
{"actor":{"display_login":"benwilson512"}}