{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/88387491","pull_request_review_id":8961479,"id":88387491,"diff_hunk":"@@ -442,24 +445,26 @@ func (t *tether) Register(name string, extension Extension) {\n func (t *tether) handleSessionExit(session *SessionConfig) {\n \tdefer trace.End(trace.Begin(\"handling exit of session \" + session.ID))\n \n-\tsession.Lock()\n-\tdefer session.Unlock()\n-\n \tif session.wait != nil {\n+\t\tlog.Debugf(\"Waiting on session.wait\")\n \t\tsession.wait.Wait()\n+\t\tlog.Debugf(\"Wait on session.wait completed\")\n \t}\n \n-\t// reader must be closed before calling wait, and this must interrupt the underlying Read\n-\t// or Wait will not return.\n+\tlog.Debugf(\"Calling wait on cmd\")\n+\tlog.Errorf(\"Wait returned %s\", session.Cmd.Wait())","path":"lib/tether/tether.go","position":42,"original_position":42,"commit_id":"a86b67de07785ff8a8fb46a75fe12388bba37fd9","original_commit_id":"a86b67de07785ff8a8fb46a75fe12388bba37fd9","user":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars.githubusercontent.com/u/4350891?v=3","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"body":"is it an error?","created_at":"2016-11-17T05:06:13Z","updated_at":"2016-11-17T05:08:57Z","html_url":"https://github.com/vmware/vic/pull/3185#discussion_r88387491","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/3185","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/88387491"},"html":{"href":"https://github.com/vmware/vic/pull/3185#discussion_r88387491"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/3185"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/3185","id":93845305,"html_url":"https://github.com/vmware/vic/pull/3185","diff_url":"https://github.com/vmware/vic/pull/3185.diff","patch_url":"https://github.com/vmware/vic/pull/3185.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/3185","number":3185,"state":"open","locked":false,"title":"[full ci] Fix docker run/run -i and run -t truncation","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"We now control Std{in|out|err}Pipe's directly and copy between them and dio\r\n\r\nThis PR also;\r\n\r\n- Adds OpenStdin bool to the SessionConfig to indicate whether we should be opening stdin or not\r\n- Sets the serial lines speed to 115200.\r\n- Various cleanups\r\n\r\nFixes #2660\r\n","created_at":"2016-11-15T20:50:10Z","updated_at":"2016-11-17T05:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40e1f3d0af43d4a2ab7b2bb78154c209dfac25fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/3185/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/3185/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/3185/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/a86b67de07785ff8a8fb46a75fe12388bba37fd9","head":{"label":"caglar10ur:CloseStdin","ref":"CloseStdin","sha":"a86b67de07785ff8a8fb46a75fe12388bba37fd9","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"repo":{"id":55449160,"name":"vic","full_name":"caglar10ur/vic","owner":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caglar10ur/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/caglar10ur/vic","forks_url":"https://api.github.com/repos/caglar10ur/vic/forks","keys_url":"https://api.github.com/repos/caglar10ur/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caglar10ur/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caglar10ur/vic/teams","hooks_url":"https://api.github.com/repos/caglar10ur/vic/hooks","issue_events_url":"https://api.github.com/repos/caglar10ur/vic/issues/events{/number}","events_url":"https://api.github.com/repos/caglar10ur/vic/events","assignees_url":"https://api.github.com/repos/caglar10ur/vic/assignees{/user}","branches_url":"https://api.github.com/repos/caglar10ur/vic/branches{/branch}","tags_url":"https://api.github.com/repos/caglar10ur/vic/tags","blobs_url":"https://api.github.com/repos/caglar10ur/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caglar10ur/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caglar10ur/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/caglar10ur/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caglar10ur/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/caglar10ur/vic/languages","stargazers_url":"https://api.github.com/repos/caglar10ur/vic/stargazers","contributors_url":"https://api.github.com/repos/caglar10ur/vic/contributors","subscribers_url":"https://api.github.com/repos/caglar10ur/vic/subscribers","subscription_url":"https://api.github.com/repos/caglar10ur/vic/subscription","commits_url":"https://api.github.com/repos/caglar10ur/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/caglar10ur/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/caglar10ur/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/caglar10ur/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/caglar10ur/vic/contents/{+path}","compare_url":"https://api.github.com/repos/caglar10ur/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caglar10ur/vic/merges","archive_url":"https://api.github.com/repos/caglar10ur/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caglar10ur/vic/downloads","issues_url":"https://api.github.com/repos/caglar10ur/vic/issues{/number}","pulls_url":"https://api.github.com/repos/caglar10ur/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/caglar10ur/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/caglar10ur/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caglar10ur/vic/labels{/name}","releases_url":"https://api.github.com/repos/caglar10ur/vic/releases{/id}","deployments_url":"https://api.github.com/repos/caglar10ur/vic/deployments","created_at":"2016-04-04T22:13:10Z","updated_at":"2016-04-04T22:13:12Z","pushed_at":"2016-11-17T04:40:49Z","git_url":"git://github.com/caglar10ur/vic.git","ssh_url":"git@github.com:caglar10ur/vic.git","clone_url":"https://github.com/caglar10ur/vic.git","svn_url":"https://github.com/caglar10ur/vic","homepage":null,"size":31078,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"7b2d9ace1e384005ca7c0e3cbbffa77b43ddc63f","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-11-14T09:07:21Z","pushed_at":"2016-11-17T04:46:11Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"","size":86211,"stargazers_count":150,"watchers_count":150,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":490,"forks":58,"open_issues":490,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/3185"},"html":{"href":"https://github.com/vmware/vic/pull/3185"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/3185"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/3185/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/3185/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/3185/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/a86b67de07785ff8a8fb46a75fe12388bba37fd9"}}}}
{"actor":{"display_login":"vburenin"}}