{"action":"created","comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/93789043","pull_request_review_id":14325601,"id":93789043,"diff_hunk":"@@ -0,0 +1,53 @@\n+# -*- coding: utf-8 -*-\n+# Copyright 2007-2016 The HyperSpy developers\n+#\n+# This file is part of  HyperSpy.\n+#\n+#  HyperSpy is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+#  HyperSpy is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with  HyperSpy.  If not, see <http://www.gnu.org/licenses/>.\n+\n+\n+from hyperspy.signals import BaseSignal, Signal1D, ComplexSignal2D\n+\n+\n+class ElectronWaveImage(ComplexSignal2D):\n+\n+    \"\"\"ComplexSignal2D subclass for electron wave images.\"\"\"\n+\n+    _signal_type = 'electron_wave'\n+\n+    def display_reconstruction_parameters(self):","path":"hyperspy/_signals/electron_wave_image.py","position":29,"original_position":29,"commit_id":"d522fd1ce4ad5a067467d7b30dd98bd0dd586f69","original_commit_id":"3ebec5f34ff2d38e1cea7be5cafee7a50ec40562","user":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"body":"I am happy to merge this PR except for this method that seems to me half cooked as it is not very useful for n-dimensional signals. I imagine that it would be more useful a method that displays the parameters using the markers on a multi-dimensional figure. I suggest that we leave this class (`ElectronWaveImage`) for another pull request. Notice that, as the reconstructed waves will have \"electron_wave\" signal type, they'll be assigned this class once it is ready to merge in another PR.","created_at":"2016-12-23T17:54:14Z","updated_at":"2016-12-23T17:54:14Z","html_url":"https://github.com/hyperspy/hyperspy/pull/1322#discussion_r93789043","pull_request_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322","_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/93789043"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/1322#discussion_r93789043"},"pull_request":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322"}}},"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322","id":92548268,"html_url":"https://github.com/hyperspy/hyperspy/pull/1322","diff_url":"https://github.com/hyperspy/hyperspy/pull/1322.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/1322.patch","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1322","number":1322,"state":"open","locked":false,"title":"NEW: HologramImage class, misc/holography package. Strong revision of #1152","user":{"login":"woozey","id":14218320,"avatar_url":"https://avatars.githubusercontent.com/u/14218320?v=3","gravatar_id":"","url":"https://api.github.com/users/woozey","html_url":"https://github.com/woozey","followers_url":"https://api.github.com/users/woozey/followers","following_url":"https://api.github.com/users/woozey/following{/other_user}","gists_url":"https://api.github.com/users/woozey/gists{/gist_id}","starred_url":"https://api.github.com/users/woozey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woozey/subscriptions","organizations_url":"https://api.github.com/users/woozey/orgs","repos_url":"https://api.github.com/users/woozey/repos","events_url":"https://api.github.com/users/woozey/events{/privacy}","received_events_url":"https://api.github.com/users/woozey/received_events","type":"User","site_admin":false},"body":"Finally, after long time, here is the revision of #1152: new PR for electron holography functionality also with contributions from @FWin22. Briefly about the revision:\r\n\r\n- _reconstruct_phase_ method is split in several functions which operate on _nparrays_ which are placed in holography package (_misc.holography_)\r\n- _HologramImage_ class contains methods which are warpers for the functions of holography package operating on the objects with _nav_dim>0_\r\n- Reconstruction parameters are split in more feasible way: _sb_size, sb_position, sb_smooth_\r\n- Improved: searching for sideband; smoothing of sideband filter.\r\n- Added: possibility to input sideband filter size in physical units (i.e. mrad or 1/nm); possibility to change output shape.\r\n\r\n@francisco-dlp Unfortunately, couldn't apply _map()_ since it works in place, whereas _reconstruct_phase_ method is able to change shape of the output. Also as we have discussed, I'll submit a PR to to hyperspy demos \r\n\r\n@CodeMonkeyJan is welcome to comment too))\r\n\r\nUpdate: corresponding PR with demo https://github.com/hyperspy/hyperspy-demos/pull/29","created_at":"2016-11-07T09:27:45Z","updated_at":"2016-12-23T17:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"478c5981c27466192d190b142788fc57ed5b22be","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322/commits","review_comments_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322/comments","review_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/1322/comments","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/d522fd1ce4ad5a067467d7b30dd98bd0dd586f69","head":{"label":"woozey:holography","ref":"holography","sha":"d522fd1ce4ad5a067467d7b30dd98bd0dd586f69","user":{"login":"woozey","id":14218320,"avatar_url":"https://avatars.githubusercontent.com/u/14218320?v=3","gravatar_id":"","url":"https://api.github.com/users/woozey","html_url":"https://github.com/woozey","followers_url":"https://api.github.com/users/woozey/followers","following_url":"https://api.github.com/users/woozey/following{/other_user}","gists_url":"https://api.github.com/users/woozey/gists{/gist_id}","starred_url":"https://api.github.com/users/woozey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woozey/subscriptions","organizations_url":"https://api.github.com/users/woozey/orgs","repos_url":"https://api.github.com/users/woozey/repos","events_url":"https://api.github.com/users/woozey/events{/privacy}","received_events_url":"https://api.github.com/users/woozey/received_events","type":"User","site_admin":false},"repo":{"id":63332355,"name":"hyperspy","full_name":"woozey/hyperspy","owner":{"login":"woozey","id":14218320,"avatar_url":"https://avatars.githubusercontent.com/u/14218320?v=3","gravatar_id":"","url":"https://api.github.com/users/woozey","html_url":"https://github.com/woozey","followers_url":"https://api.github.com/users/woozey/followers","following_url":"https://api.github.com/users/woozey/following{/other_user}","gists_url":"https://api.github.com/users/woozey/gists{/gist_id}","starred_url":"https://api.github.com/users/woozey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woozey/subscriptions","organizations_url":"https://api.github.com/users/woozey/orgs","repos_url":"https://api.github.com/users/woozey/repos","events_url":"https://api.github.com/users/woozey/events{/privacy}","received_events_url":"https://api.github.com/users/woozey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woozey/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/woozey/hyperspy","forks_url":"https://api.github.com/repos/woozey/hyperspy/forks","keys_url":"https://api.github.com/repos/woozey/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woozey/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woozey/hyperspy/teams","hooks_url":"https://api.github.com/repos/woozey/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/woozey/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/woozey/hyperspy/events","assignees_url":"https://api.github.com/repos/woozey/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/woozey/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/woozey/hyperspy/tags","blobs_url":"https://api.github.com/repos/woozey/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woozey/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woozey/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/woozey/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woozey/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/woozey/hyperspy/languages","stargazers_url":"https://api.github.com/repos/woozey/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/woozey/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/woozey/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/woozey/hyperspy/subscription","commits_url":"https://api.github.com/repos/woozey/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/woozey/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/woozey/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/woozey/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/woozey/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/woozey/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woozey/hyperspy/merges","archive_url":"https://api.github.com/repos/woozey/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woozey/hyperspy/downloads","issues_url":"https://api.github.com/repos/woozey/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/woozey/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/woozey/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/woozey/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woozey/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/woozey/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/woozey/hyperspy/deployments","created_at":"2016-07-14T11:49:03Z","updated_at":"2016-07-14T11:49:07Z","pushed_at":"2016-12-23T17:43:20Z","git_url":"git://github.com/woozey/hyperspy.git","ssh_url":"git@github.com:woozey/hyperspy.git","clone_url":"https://github.com/woozey/hyperspy.git","svn_url":"https://github.com/woozey/hyperspy","homepage":"http://www.hyperspy.org","size":87591,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperspy:RELEASE_next_minor","ref":"RELEASE_next_minor","sha":"bbc79eab2ed5dbfa8d48b76932d186d5fc098a5f","user":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"repo":{"id":2233998,"name":"hyperspy","full_name":"hyperspy/hyperspy","owner":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperspy/hyperspy","description":"Multidimensional data analysis","fork":false,"url":"https://api.github.com/repos/hyperspy/hyperspy","forks_url":"https://api.github.com/repos/hyperspy/hyperspy/forks","keys_url":"https://api.github.com/repos/hyperspy/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperspy/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperspy/hyperspy/teams","hooks_url":"https://api.github.com/repos/hyperspy/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/hyperspy/hyperspy/events","assignees_url":"https://api.github.com/repos/hyperspy/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/hyperspy/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/hyperspy/hyperspy/tags","blobs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperspy/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperspy/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperspy/hyperspy/languages","stargazers_url":"https://api.github.com/repos/hyperspy/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/hyperspy/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/hyperspy/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/hyperspy/hyperspy/subscription","commits_url":"https://api.github.com/repos/hyperspy/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperspy/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperspy/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/hyperspy/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperspy/hyperspy/merges","archive_url":"https://api.github.com/repos/hyperspy/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperspy/hyperspy/downloads","issues_url":"https://api.github.com/repos/hyperspy/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperspy/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/hyperspy/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/hyperspy/hyperspy/deployments","created_at":"2011-08-19T13:14:36Z","updated_at":"2016-12-16T22:50:57Z","pushed_at":"2016-12-23T17:43:22Z","git_url":"git://github.com/hyperspy/hyperspy.git","ssh_url":"git@github.com:hyperspy/hyperspy.git","clone_url":"https://github.com/hyperspy/hyperspy.git","svn_url":"https://github.com/hyperspy/hyperspy","homepage":"http://www.hyperspy.org","size":98787,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":169,"forks":51,"open_issues":169,"watchers":80,"default_branch":"RELEASE_next_minor"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/1322"},"issue":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/1322"},"comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/1322/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/1322/commits"},"statuses":{"href":"https://api.github.com/repos/hyperspy/hyperspy/statuses/d522fd1ce4ad5a067467d7b30dd98bd0dd586f69"}}}}
{"actor":{"display_login":"francisco-dlp"}}