{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/comments/52830977","id":52830977,"diff_hunk":"@@ -1703,8 +1703,7 @@ private String constructAssertionConsumerUrl(MessageContext messageContext) {\n         //Note: Do not change to construct the assertionConsumerUrl directly using servicePrefix instead of headers.get(\"HOST\").\n         //It always gives IP for host which cause invalid assertionConsumerUrl\n         String assertionConsumerUrl = servicePrefix.substring(0, servicePrefix.indexOf(\"/\") + 2) +\n-                                      headers.get(\"HOST\") + messageContext.getProperty(\"REST_API_CONTEXT\") +\n-                                      \"/\" + messageContext.getProperty(\"SYNAPSE_REST_API_VERSION\") + \"/\";\n+                headers.get(\"HOST\") + messageContext.getProperty(\"REST_API_CONTEXT\") + \"/\";\n ","path":"components/appmgt/org.wso2.carbon.appmgt.gateway/src/main/java/org/wso2/carbon/appmgt/gateway/handlers/security/saml2/SAML2AuthenticationHandler.java","position":7,"original_position":7,"commit_id":"a0c428ac1f77e7ed7582382ac7303aa1f161e7a6","original_commit_id":"a0c428ac1f77e7ed7582382ac7303aa1f161e7a6","user":{"login":"sajithar","id":11549922,"avatar_url":"https://avatars.githubusercontent.com/u/11549922?v=3","gravatar_id":"","url":"https://api.github.com/users/sajithar","html_url":"https://github.com/sajithar","followers_url":"https://api.github.com/users/sajithar/followers","following_url":"https://api.github.com/users/sajithar/following{/other_user}","gists_url":"https://api.github.com/users/sajithar/gists{/gist_id}","starred_url":"https://api.github.com/users/sajithar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajithar/subscriptions","organizations_url":"https://api.github.com/users/sajithar/orgs","repos_url":"https://api.github.com/users/sajithar/repos","events_url":"https://api.github.com/users/sajithar/events{/privacy}","received_events_url":"https://api.github.com/users/sajithar/received_events","type":"User","site_admin":false},"body":"Cannot use pre-defined constant `AppMConstants.HOST` here, because its value is \"[Host](https://github.com/wso2/carbon-appmgt/blob/63a8f872440f1bd77e34d1cb630db903dd075299/components/org.wso2.carbon.appmgt.impl/src/main/java/org/wso2/carbon/appmgt/impl/AppMConstants.java#L590)\", not \"HOST\".\r\nfixed in commit 938f3cb491db8c72b33cb1c5e1b438311bc44acf of PR #153 ","created_at":"2016-02-13T17:48:27Z","updated_at":"2016-02-13T17:48:27Z","html_url":"https://github.com/wso2/carbon-appmgt/pull/63#discussion_r52830977","pull_request_url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/comments/52830977"},"html":{"href":"https://github.com/wso2/carbon-appmgt/pull/63#discussion_r52830977"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63","id":36930090,"html_url":"https://github.com/wso2/carbon-appmgt/pull/63","diff_url":"https://github.com/wso2/carbon-appmgt/pull/63.diff","patch_url":"https://github.com/wso2/carbon-appmgt/pull/63.patch","issue_url":"https://api.github.com/repos/wso2/carbon-appmgt/issues/63","number":63,"state":"closed","locked":false,"title":"App versioning","user":{"login":"sajithar","id":11549922,"avatar_url":"https://avatars.githubusercontent.com/u/11549922?v=3","gravatar_id":"","url":"https://api.github.com/users/sajithar","html_url":"https://github.com/sajithar","followers_url":"https://api.github.com/users/sajithar/followers","following_url":"https://api.github.com/users/sajithar/following{/other_user}","gists_url":"https://api.github.com/users/sajithar/gists{/gist_id}","starred_url":"https://api.github.com/users/sajithar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajithar/subscriptions","organizations_url":"https://api.github.com/users/sajithar/orgs","repos_url":"https://api.github.com/users/sajithar/repos","events_url":"https://api.github.com/users/sajithar/events{/privacy}","received_events_url":"https://api.github.com/users/sajithar/received_events","type":"User","site_admin":false},"body":"Implementing feature: Improving app versioning support in App Manager","created_at":"2015-06-04T12:42:18Z","updated_at":"2016-02-13T17:48:27Z","closed_at":"2015-06-05T07:55:48Z","merged_at":"2015-06-05T07:55:48Z","merge_commit_sha":"28d6ba2731586433c5a77d2f1ca21cf3c9033bc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-appmgt/issues/63/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-appmgt/statuses/a0c428ac1f77e7ed7582382ac7303aa1f161e7a6","head":{"label":"sajithar:app-versioning","ref":"app-versioning","sha":"a0c428ac1f77e7ed7582382ac7303aa1f161e7a6","user":{"login":"sajithar","id":11549922,"avatar_url":"https://avatars.githubusercontent.com/u/11549922?v=3","gravatar_id":"","url":"https://api.github.com/users/sajithar","html_url":"https://github.com/sajithar","followers_url":"https://api.github.com/users/sajithar/followers","following_url":"https://api.github.com/users/sajithar/following{/other_user}","gists_url":"https://api.github.com/users/sajithar/gists{/gist_id}","starred_url":"https://api.github.com/users/sajithar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajithar/subscriptions","organizations_url":"https://api.github.com/users/sajithar/orgs","repos_url":"https://api.github.com/users/sajithar/repos","events_url":"https://api.github.com/users/sajithar/events{/privacy}","received_events_url":"https://api.github.com/users/sajithar/received_events","type":"User","site_admin":false},"repo":{"id":33473668,"name":"carbon-appmgt","full_name":"sajithar/carbon-appmgt","owner":{"login":"sajithar","id":11549922,"avatar_url":"https://avatars.githubusercontent.com/u/11549922?v=3","gravatar_id":"","url":"https://api.github.com/users/sajithar","html_url":"https://github.com/sajithar","followers_url":"https://api.github.com/users/sajithar/followers","following_url":"https://api.github.com/users/sajithar/following{/other_user}","gists_url":"https://api.github.com/users/sajithar/gists{/gist_id}","starred_url":"https://api.github.com/users/sajithar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajithar/subscriptions","organizations_url":"https://api.github.com/users/sajithar/orgs","repos_url":"https://api.github.com/users/sajithar/repos","events_url":"https://api.github.com/users/sajithar/events{/privacy}","received_events_url":"https://api.github.com/users/sajithar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sajithar/carbon-appmgt","description":"","fork":true,"url":"https://api.github.com/repos/sajithar/carbon-appmgt","forks_url":"https://api.github.com/repos/sajithar/carbon-appmgt/forks","keys_url":"https://api.github.com/repos/sajithar/carbon-appmgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sajithar/carbon-appmgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sajithar/carbon-appmgt/teams","hooks_url":"https://api.github.com/repos/sajithar/carbon-appmgt/hooks","issue_events_url":"https://api.github.com/repos/sajithar/carbon-appmgt/issues/events{/number}","events_url":"https://api.github.com/repos/sajithar/carbon-appmgt/events","assignees_url":"https://api.github.com/repos/sajithar/carbon-appmgt/assignees{/user}","branches_url":"https://api.github.com/repos/sajithar/carbon-appmgt/branches{/branch}","tags_url":"https://api.github.com/repos/sajithar/carbon-appmgt/tags","blobs_url":"https://api.github.com/repos/sajithar/carbon-appmgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sajithar/carbon-appmgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sajithar/carbon-appmgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sajithar/carbon-appmgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sajithar/carbon-appmgt/statuses/{sha}","languages_url":"https://api.github.com/repos/sajithar/carbon-appmgt/languages","stargazers_url":"https://api.github.com/repos/sajithar/carbon-appmgt/stargazers","contributors_url":"https://api.github.com/repos/sajithar/carbon-appmgt/contributors","subscribers_url":"https://api.github.com/repos/sajithar/carbon-appmgt/subscribers","subscription_url":"https://api.github.com/repos/sajithar/carbon-appmgt/subscription","commits_url":"https://api.github.com/repos/sajithar/carbon-appmgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sajithar/carbon-appmgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sajithar/carbon-appmgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sajithar/carbon-appmgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sajithar/carbon-appmgt/contents/{+path}","compare_url":"https://api.github.com/repos/sajithar/carbon-appmgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sajithar/carbon-appmgt/merges","archive_url":"https://api.github.com/repos/sajithar/carbon-appmgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sajithar/carbon-appmgt/downloads","issues_url":"https://api.github.com/repos/sajithar/carbon-appmgt/issues{/number}","pulls_url":"https://api.github.com/repos/sajithar/carbon-appmgt/pulls{/number}","milestones_url":"https://api.github.com/repos/sajithar/carbon-appmgt/milestones{/number}","notifications_url":"https://api.github.com/repos/sajithar/carbon-appmgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sajithar/carbon-appmgt/labels{/name}","releases_url":"https://api.github.com/repos/sajithar/carbon-appmgt/releases{/id}","deployments_url":"https://api.github.com/repos/sajithar/carbon-appmgt/deployments","created_at":"2015-04-06T08:43:07Z","updated_at":"2016-01-18T09:01:44Z","pushed_at":"2016-02-13T17:47:03Z","git_url":"git://github.com/sajithar/carbon-appmgt.git","ssh_url":"git@github.com:sajithar/carbon-appmgt.git","clone_url":"https://github.com/sajithar/carbon-appmgt.git","svn_url":"https://github.com/sajithar/carbon-appmgt","homepage":null,"size":22386,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"93bcb54fd4d8ead34d4a1a21b384817cd8508530","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":17201753,"name":"carbon-appmgt","full_name":"wso2/carbon-appmgt","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-appmgt","description":"","fork":false,"url":"https://api.github.com/repos/wso2/carbon-appmgt","forks_url":"https://api.github.com/repos/wso2/carbon-appmgt/forks","keys_url":"https://api.github.com/repos/wso2/carbon-appmgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-appmgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-appmgt/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-appmgt/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-appmgt/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-appmgt/events","assignees_url":"https://api.github.com/repos/wso2/carbon-appmgt/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-appmgt/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-appmgt/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-appmgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-appmgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-appmgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-appmgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-appmgt/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-appmgt/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-appmgt/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-appmgt/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-appmgt/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-appmgt/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-appmgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-appmgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-appmgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-appmgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-appmgt/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-appmgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-appmgt/merges","archive_url":"https://api.github.com/repos/wso2/carbon-appmgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-appmgt/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-appmgt/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-appmgt/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-appmgt/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-appmgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-appmgt/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-appmgt/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-appmgt/deployments","created_at":"2014-02-26T06:47:05Z","updated_at":"2016-01-11T08:40:27Z","pushed_at":"2016-02-13T17:47:04Z","git_url":"git://github.com/wso2/carbon-appmgt.git","ssh_url":"git@github.com:wso2/carbon-appmgt.git","clone_url":"https://github.com/wso2/carbon-appmgt.git","svn_url":"https://github.com/wso2/carbon-appmgt","homepage":null,"size":23819,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":5,"forks":25,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63"},"html":{"href":"https://github.com/wso2/carbon-appmgt/pull/63"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/issues/63"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-appmgt/statuses/a0c428ac1f77e7ed7582382ac7303aa1f161e7a6"}}}}