{"action":"created","comment":{"url":"https://api.github.com/repos/fingerbank/perl-client/pulls/comments/56871974","id":56871974,"diff_hunk":"@@ -19,7 +19,7 @@ BEGIN {\n     use Exporter ();\n     our ( @ISA, @EXPORT_OK );\n     @ISA = qw(Exporter);\n-    @EXPORT_OK = qw($FALSE $TRUE $YES $NO);\n+    @EXPORT_OK = qw($FALSE $TRUE $YES $NO $FINGERBANK_USER $DEFAULT_BACKUP_RETENTION);","path":"lib/fingerbank/Constant.pm","position":5,"original_position":5,"commit_id":"0f8789e592865c561f88b572a09e3874563d5568","original_commit_id":"0f8789e592865c561f88b572a09e3874563d5568","user":{"login":"dwlfrth","id":633234,"avatar_url":"https://avatars.githubusercontent.com/u/633234?v=3","gravatar_id":"","url":"https://api.github.com/users/dwlfrth","html_url":"https://github.com/dwlfrth","followers_url":"https://api.github.com/users/dwlfrth/followers","following_url":"https://api.github.com/users/dwlfrth/following{/other_user}","gists_url":"https://api.github.com/users/dwlfrth/gists{/gist_id}","starred_url":"https://api.github.com/users/dwlfrth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwlfrth/subscriptions","organizations_url":"https://api.github.com/users/dwlfrth/orgs","repos_url":"https://api.github.com/users/dwlfrth/repos","events_url":"https://api.github.com/users/dwlfrth/events{/privacy}","received_events_url":"https://api.github.com/users/dwlfrth/received_events","type":"User","site_admin":false},"body":"Not sure theses (FINGERBANK_USER, DEFAULT_BACKUP_RETENTION) should be exported...\r\nFALSE, TRUE, YES, NO are since we use them a lot but I'm a strong believer (not related to Justin Bieber) that we should \"avoid\" export and use \"full path\"","created_at":"2016-03-21T18:27:18Z","updated_at":"2016-03-21T18:27:18Z","html_url":"https://github.com/fingerbank/perl-client/pull/9#discussion_r56871974","pull_request_url":"https://api.github.com/repos/fingerbank/perl-client/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/fingerbank/perl-client/pulls/comments/56871974"},"html":{"href":"https://github.com/fingerbank/perl-client/pull/9#discussion_r56871974"},"pull_request":{"href":"https://api.github.com/repos/fingerbank/perl-client/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/fingerbank/perl-client/pulls/9","id":61133986,"html_url":"https://github.com/fingerbank/perl-client/pull/9","diff_url":"https://github.com/fingerbank/perl-client/pull/9.diff","patch_url":"https://github.com/fingerbank/perl-client/pull/9.patch","issue_url":"https://api.github.com/repos/fingerbank/perl-client/issues/9","number":9,"state":"open","locked":false,"title":"Feature/redis storage","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"# Description\r\nAdd a Redis based storage for local combination detection that will replace what the Upstream schema did in LocalDB\r\n\r\n# Impacts\r\nLocal combination detection\r\n\r\n# Code / PR Dependencies\r\nPR 1216 from inverse-inc/packetfence\r\n","created_at":"2016-02-29T19:52:14Z","updated_at":"2016-03-21T18:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0512ceedaea9fd7bd026ab2d04b8828d0b5a1f4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fingerbank/perl-client/pulls/9/commits","review_comments_url":"https://api.github.com/repos/fingerbank/perl-client/pulls/9/comments","review_comment_url":"https://api.github.com/repos/fingerbank/perl-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fingerbank/perl-client/issues/9/comments","statuses_url":"https://api.github.com/repos/fingerbank/perl-client/statuses/0f8789e592865c561f88b572a09e3874563d5568","head":{"label":"fingerbank:feature/redis-storage","ref":"feature/redis-storage","sha":"0f8789e592865c561f88b572a09e3874563d5568","user":{"login":"fingerbank","id":15897152,"avatar_url":"https://avatars.githubusercontent.com/u/15897152?v=3","gravatar_id":"","url":"https://api.github.com/users/fingerbank","html_url":"https://github.com/fingerbank","followers_url":"https://api.github.com/users/fingerbank/followers","following_url":"https://api.github.com/users/fingerbank/following{/other_user}","gists_url":"https://api.github.com/users/fingerbank/gists{/gist_id}","starred_url":"https://api.github.com/users/fingerbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingerbank/subscriptions","organizations_url":"https://api.github.com/users/fingerbank/orgs","repos_url":"https://api.github.com/users/fingerbank/repos","events_url":"https://api.github.com/users/fingerbank/events{/privacy}","received_events_url":"https://api.github.com/users/fingerbank/received_events","type":"Organization","site_admin":false},"repo":{"id":46375148,"name":"perl-client","full_name":"fingerbank/perl-client","owner":{"login":"fingerbank","id":15897152,"avatar_url":"https://avatars.githubusercontent.com/u/15897152?v=3","gravatar_id":"","url":"https://api.github.com/users/fingerbank","html_url":"https://github.com/fingerbank","followers_url":"https://api.github.com/users/fingerbank/followers","following_url":"https://api.github.com/users/fingerbank/following{/other_user}","gists_url":"https://api.github.com/users/fingerbank/gists{/gist_id}","starred_url":"https://api.github.com/users/fingerbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingerbank/subscriptions","organizations_url":"https://api.github.com/users/fingerbank/orgs","repos_url":"https://api.github.com/users/fingerbank/repos","events_url":"https://api.github.com/users/fingerbank/events{/privacy}","received_events_url":"https://api.github.com/users/fingerbank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fingerbank/perl-client","description":"Home of the Fingerbank perl client codebase, make yourself cozy","fork":false,"url":"https://api.github.com/repos/fingerbank/perl-client","forks_url":"https://api.github.com/repos/fingerbank/perl-client/forks","keys_url":"https://api.github.com/repos/fingerbank/perl-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fingerbank/perl-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fingerbank/perl-client/teams","hooks_url":"https://api.github.com/repos/fingerbank/perl-client/hooks","issue_events_url":"https://api.github.com/repos/fingerbank/perl-client/issues/events{/number}","events_url":"https://api.github.com/repos/fingerbank/perl-client/events","assignees_url":"https://api.github.com/repos/fingerbank/perl-client/assignees{/user}","branches_url":"https://api.github.com/repos/fingerbank/perl-client/branches{/branch}","tags_url":"https://api.github.com/repos/fingerbank/perl-client/tags","blobs_url":"https://api.github.com/repos/fingerbank/perl-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fingerbank/perl-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fingerbank/perl-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/fingerbank/perl-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fingerbank/perl-client/statuses/{sha}","languages_url":"https://api.github.com/repos/fingerbank/perl-client/languages","stargazers_url":"https://api.github.com/repos/fingerbank/perl-client/stargazers","contributors_url":"https://api.github.com/repos/fingerbank/perl-client/contributors","subscribers_url":"https://api.github.com/repos/fingerbank/perl-client/subscribers","subscription_url":"https://api.github.com/repos/fingerbank/perl-client/subscription","commits_url":"https://api.github.com/repos/fingerbank/perl-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/fingerbank/perl-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/fingerbank/perl-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/fingerbank/perl-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/fingerbank/perl-client/contents/{+path}","compare_url":"https://api.github.com/repos/fingerbank/perl-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fingerbank/perl-client/merges","archive_url":"https://api.github.com/repos/fingerbank/perl-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fingerbank/perl-client/downloads","issues_url":"https://api.github.com/repos/fingerbank/perl-client/issues{/number}","pulls_url":"https://api.github.com/repos/fingerbank/perl-client/pulls{/number}","milestones_url":"https://api.github.com/repos/fingerbank/perl-client/milestones{/number}","notifications_url":"https://api.github.com/repos/fingerbank/perl-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fingerbank/perl-client/labels{/name}","releases_url":"https://api.github.com/repos/fingerbank/perl-client/releases{/id}","deployments_url":"https://api.github.com/repos/fingerbank/perl-client/deployments","created_at":"2015-11-17T21:00:15Z","updated_at":"2016-02-23T20:24:15Z","pushed_at":"2016-03-18T11:53:29Z","git_url":"git://github.com/fingerbank/perl-client.git","ssh_url":"git@github.com:fingerbank/perl-client.git","clone_url":"https://github.com/fingerbank/perl-client.git","svn_url":"https://github.com/fingerbank/perl-client","homepage":"","size":3455,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"fingerbank:master","ref":"master","sha":"5f1010df7b0c329c10fcd2e565a6416d7f3629fb","user":{"login":"fingerbank","id":15897152,"avatar_url":"https://avatars.githubusercontent.com/u/15897152?v=3","gravatar_id":"","url":"https://api.github.com/users/fingerbank","html_url":"https://github.com/fingerbank","followers_url":"https://api.github.com/users/fingerbank/followers","following_url":"https://api.github.com/users/fingerbank/following{/other_user}","gists_url":"https://api.github.com/users/fingerbank/gists{/gist_id}","starred_url":"https://api.github.com/users/fingerbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingerbank/subscriptions","organizations_url":"https://api.github.com/users/fingerbank/orgs","repos_url":"https://api.github.com/users/fingerbank/repos","events_url":"https://api.github.com/users/fingerbank/events{/privacy}","received_events_url":"https://api.github.com/users/fingerbank/received_events","type":"Organization","site_admin":false},"repo":{"id":46375148,"name":"perl-client","full_name":"fingerbank/perl-client","owner":{"login":"fingerbank","id":15897152,"avatar_url":"https://avatars.githubusercontent.com/u/15897152?v=3","gravatar_id":"","url":"https://api.github.com/users/fingerbank","html_url":"https://github.com/fingerbank","followers_url":"https://api.github.com/users/fingerbank/followers","following_url":"https://api.github.com/users/fingerbank/following{/other_user}","gists_url":"https://api.github.com/users/fingerbank/gists{/gist_id}","starred_url":"https://api.github.com/users/fingerbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingerbank/subscriptions","organizations_url":"https://api.github.com/users/fingerbank/orgs","repos_url":"https://api.github.com/users/fingerbank/repos","events_url":"https://api.github.com/users/fingerbank/events{/privacy}","received_events_url":"https://api.github.com/users/fingerbank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fingerbank/perl-client","description":"Home of the Fingerbank perl client codebase, make yourself cozy","fork":false,"url":"https://api.github.com/repos/fingerbank/perl-client","forks_url":"https://api.github.com/repos/fingerbank/perl-client/forks","keys_url":"https://api.github.com/repos/fingerbank/perl-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fingerbank/perl-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fingerbank/perl-client/teams","hooks_url":"https://api.github.com/repos/fingerbank/perl-client/hooks","issue_events_url":"https://api.github.com/repos/fingerbank/perl-client/issues/events{/number}","events_url":"https://api.github.com/repos/fingerbank/perl-client/events","assignees_url":"https://api.github.com/repos/fingerbank/perl-client/assignees{/user}","branches_url":"https://api.github.com/repos/fingerbank/perl-client/branches{/branch}","tags_url":"https://api.github.com/repos/fingerbank/perl-client/tags","blobs_url":"https://api.github.com/repos/fingerbank/perl-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fingerbank/perl-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fingerbank/perl-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/fingerbank/perl-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fingerbank/perl-client/statuses/{sha}","languages_url":"https://api.github.com/repos/fingerbank/perl-client/languages","stargazers_url":"https://api.github.com/repos/fingerbank/perl-client/stargazers","contributors_url":"https://api.github.com/repos/fingerbank/perl-client/contributors","subscribers_url":"https://api.github.com/repos/fingerbank/perl-client/subscribers","subscription_url":"https://api.github.com/repos/fingerbank/perl-client/subscription","commits_url":"https://api.github.com/repos/fingerbank/perl-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/fingerbank/perl-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/fingerbank/perl-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/fingerbank/perl-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/fingerbank/perl-client/contents/{+path}","compare_url":"https://api.github.com/repos/fingerbank/perl-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fingerbank/perl-client/merges","archive_url":"https://api.github.com/repos/fingerbank/perl-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fingerbank/perl-client/downloads","issues_url":"https://api.github.com/repos/fingerbank/perl-client/issues{/number}","pulls_url":"https://api.github.com/repos/fingerbank/perl-client/pulls{/number}","milestones_url":"https://api.github.com/repos/fingerbank/perl-client/milestones{/number}","notifications_url":"https://api.github.com/repos/fingerbank/perl-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fingerbank/perl-client/labels{/name}","releases_url":"https://api.github.com/repos/fingerbank/perl-client/releases{/id}","deployments_url":"https://api.github.com/repos/fingerbank/perl-client/deployments","created_at":"2015-11-17T21:00:15Z","updated_at":"2016-02-23T20:24:15Z","pushed_at":"2016-03-18T11:53:29Z","git_url":"git://github.com/fingerbank/perl-client.git","ssh_url":"git@github.com:fingerbank/perl-client.git","clone_url":"https://github.com/fingerbank/perl-client.git","svn_url":"https://github.com/fingerbank/perl-client","homepage":"","size":3455,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fingerbank/perl-client/pulls/9"},"html":{"href":"https://github.com/fingerbank/perl-client/pull/9"},"issue":{"href":"https://api.github.com/repos/fingerbank/perl-client/issues/9"},"comments":{"href":"https://api.github.com/repos/fingerbank/perl-client/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/fingerbank/perl-client/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/fingerbank/perl-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fingerbank/perl-client/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/fingerbank/perl-client/statuses/0f8789e592865c561f88b572a09e3874563d5568"}}}}