{"action":"created","issue":{"url":"https://api.github.com/repos/scrapy/scrapy/issues/1880","repository_url":"https://api.github.com/repos/scrapy/scrapy","labels_url":"https://api.github.com/repos/scrapy/scrapy/issues/1880/labels{/name}","comments_url":"https://api.github.com/repos/scrapy/scrapy/issues/1880/comments","events_url":"https://api.github.com/repos/scrapy/scrapy/issues/1880/events","html_url":"https://github.com/scrapy/scrapy/pull/1880","id":143497297,"number":1880,"title":"Add encoding to Link object + re-enable HTML entities links tests","user":{"login":"redapple","id":886296,"avatar_url":"https://avatars.githubusercontent.com/u/886296?v=3","gravatar_id":"","url":"https://api.github.com/users/redapple","html_url":"https://github.com/redapple","followers_url":"https://api.github.com/users/redapple/followers","following_url":"https://api.github.com/users/redapple/following{/other_user}","gists_url":"https://api.github.com/users/redapple/gists{/gist_id}","starred_url":"https://api.github.com/users/redapple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redapple/subscriptions","organizations_url":"https://api.github.com/users/redapple/orgs","repos_url":"https://api.github.com/users/redapple/repos","events_url":"https://api.github.com/users/redapple/events{/privacy}","received_events_url":"https://api.github.com/users/redapple/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-25T13:24:15Z","updated_at":"2016-03-25T20:01:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scrapy/scrapy/pulls/1880","html_url":"https://github.com/scrapy/scrapy/pull/1880","diff_url":"https://github.com/scrapy/scrapy/pull/1880.diff","patch_url":"https://github.com/scrapy/scrapy/pull/1880.patch"},"body":"Built on top of https://github.com/scrapy/scrapy/pull/1874\r\n\r\nShould fix #1403.\r\n\r\nI had to add a `encoding` attribute for the `Link` objects to build proper URLs.\r\n\r\n[`url = urljoin(response_url, url)`](https://github.com/scrapy/scrapy/blob/master/scrapy/linkextractors/lxmlhtml.py#L61) after processing the base_URL-joined attribute looks wrong to me. I'm not even sure we should pass attributes to `process_value` after this baseURL joining."},"comment":{"url":"https://api.github.com/repos/scrapy/scrapy/issues/comments/201463553","html_url":"https://github.com/scrapy/scrapy/pull/1880#issuecomment-201463553","issue_url":"https://api.github.com/repos/scrapy/scrapy/issues/1880","id":201463553,"user":{"login":"kmike","id":107893,"avatar_url":"https://avatars.githubusercontent.com/u/107893?v=3","gravatar_id":"","url":"https://api.github.com/users/kmike","html_url":"https://github.com/kmike","followers_url":"https://api.github.com/users/kmike/followers","following_url":"https://api.github.com/users/kmike/following{/other_user}","gists_url":"https://api.github.com/users/kmike/gists{/gist_id}","starred_url":"https://api.github.com/users/kmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmike/subscriptions","organizations_url":"https://api.github.com/users/kmike/orgs","repos_url":"https://api.github.com/users/kmike/repos","events_url":"https://api.github.com/users/kmike/events{/privacy}","received_events_url":"https://api.github.com/users/kmike/received_events","type":"User","site_admin":false},"created_at":"2016-03-25T20:01:19Z","updated_at":"2016-03-25T20:01:19Z","body":"@stav I think that's temporarily, to make tests working until w3lib with fixes is released."}}