{"push_id":1235330637,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"cd6b91aac89d4ec372a1d1fe21fe45a0d8201cd8","before":"fda849e6e57d04d6d8b4e7f0f98b4ef6282cdd47","commits":[{"sha":"cd6b91aac89d4ec372a1d1fe21fe45a0d8201cd8","author":{"name":"Kelly Redding","email":"2894d7e03c6ae5c66147eb684e632271ba826fad@kellyredding.com"},"message":"(hotfix) fix tests for ruby2; make Remote complain if given `nil` hosts\n\nThe Task private method `dk_lookup_ssh_hosts`, if no hosts\nsettings are given or defaulted, will return `[nil]` in ruby 1.8.7\nbut will return `[]` in ruby 2.  This was causing task tests to\npass in ruby 1.8.7 that should have been failing b/c no hosts were\nconfigured or given.  The test were failing in Ruby 2 as expected\nbut we had missed this b/c we forgot to test in ruby 2.\n\nThis updates the task tests to configure default hosts for the\ntasks so they won't fail in ruby 2 and won't eval hosts to `[nil]`\nin 1.8.7.  This gets the Task tests working as expected.\n\nThis also updates the Remote host validation logic to look for\n`nil` items in any given host lists.  This is not only a more\nrobust check that can reveal unintended errors, it also would have\nrevealed the bad Task tests and made them fail in 1.8.7.","distinct":true,"url":"https://api.github.com/repos/redding/dk/commits/cd6b91aac89d4ec372a1d1fe21fe45a0d8201cd8"}]}
{"actor":{"display_login":"kellyredding"}}