{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments/63564213","id":63564213,"diff_hunk":"@@ -0,0 +1,147 @@\n+package osxnative\n+\n+import (\n+\t\"github.com/taskcluster/taskcluster-worker/engines\"\n+\t\"github.com/taskcluster/taskcluster-worker/runtime\"\n+\t\"io\"\n+\t\"mime\"\n+\t\"net/http\"\n+\t\"os\"\n+\t\"os/exec\"\n+)\n+\n+// white list of environment variables that must\n+// be passed to the child process\n+var environmentWhitelist = []string{\n+\t\"PATH\",\n+\t\"HOME\",\n+\t\"USER\",\n+\t\"SHELL\",\n+\t\"TMPDIR\",\n+\t\"PWD\",\n+\t\"EDITOR\",\n+\t\"LANG\",\n+\t\"LOGNAME\",\n+\t\"TERM\",\n+\t\"TERM_PROGRAM\",\n+}\n+\n+type sandbox struct {\n+\tcontext     *runtime.TaskContext\n+\ttaskPayload *payload\n+\tenv         *[]string","path":"engines/osxnative/sandbox.go","position":32,"original_position":32,"commit_id":"fbd29901f3f09ee5e0c68a4d2f2119c514b2b24b","original_commit_id":"fbd29901f3f09ee5e0c68a4d2f2119c514b2b24b","user":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"body":"Good catch.","created_at":"2016-05-17T17:15:36Z","updated_at":"2016-05-17T17:15:36Z","html_url":"https://github.com/taskcluster/taskcluster-worker/pull/67#discussion_r63564213","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments/63564213"},"html":{"href":"https://github.com/taskcluster/taskcluster-worker/pull/67#discussion_r63564213"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67","id":67337625,"html_url":"https://github.com/taskcluster/taskcluster-worker/pull/67","diff_url":"https://github.com/taskcluster/taskcluster-worker/pull/67.diff","patch_url":"https://github.com/taskcluster/taskcluster-worker/pull/67.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/67","number":67,"state":"open","locked":false,"title":"Bug 1265789 and Bug 1265792","user":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"body":"Bug 1265789: Define the config and payload Mac OSX engine schemas.\r\nThe configs are a subset of the windows definitions.\r\n\r\nBug 1265792: Make OSX engine able to run a simple commmad.\r\nIt simply blindly run the given command. Sample run: https://tools.taskcluster.net/task-inspector/#PTi3sU8VSYWQwRR3GdB7QQ/\r\n\r\nThere is also a small commit to report the missing field in a schema parsing error.\r\n\r\nr? @gregarndt @petemoore ","created_at":"2016-04-21T11:22:50Z","updated_at":"2016-05-17T17:15:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31af6db6c5a3afeb0a6780defd6e0d82fa7f6344","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/67/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/fbd29901f3f09ee5e0c68a4d2f2119c514b2b24b","head":{"label":"walac:macosx","ref":"macosx","sha":"fbd29901f3f09ee5e0c68a4d2f2119c514b2b24b","user":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"repo":{"id":53348051,"name":"taskcluster-worker","full_name":"walac/taskcluster-worker","owner":{"login":"walac","id":611309,"avatar_url":"https://avatars.githubusercontent.com/u/611309?v=3","gravatar_id":"","url":"https://api.github.com/users/walac","html_url":"https://github.com/walac","followers_url":"https://api.github.com/users/walac/followers","following_url":"https://api.github.com/users/walac/following{/other_user}","gists_url":"https://api.github.com/users/walac/gists{/gist_id}","starred_url":"https://api.github.com/users/walac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walac/subscriptions","organizations_url":"https://api.github.com/users/walac/orgs","repos_url":"https://api.github.com/users/walac/repos","events_url":"https://api.github.com/users/walac/events{/privacy}","received_events_url":"https://api.github.com/users/walac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/walac/taskcluster-worker","description":"Primary worker for TaskCluster","fork":true,"url":"https://api.github.com/repos/walac/taskcluster-worker","forks_url":"https://api.github.com/repos/walac/taskcluster-worker/forks","keys_url":"https://api.github.com/repos/walac/taskcluster-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walac/taskcluster-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walac/taskcluster-worker/teams","hooks_url":"https://api.github.com/repos/walac/taskcluster-worker/hooks","issue_events_url":"https://api.github.com/repos/walac/taskcluster-worker/issues/events{/number}","events_url":"https://api.github.com/repos/walac/taskcluster-worker/events","assignees_url":"https://api.github.com/repos/walac/taskcluster-worker/assignees{/user}","branches_url":"https://api.github.com/repos/walac/taskcluster-worker/branches{/branch}","tags_url":"https://api.github.com/repos/walac/taskcluster-worker/tags","blobs_url":"https://api.github.com/repos/walac/taskcluster-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walac/taskcluster-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walac/taskcluster-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/walac/taskcluster-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walac/taskcluster-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/walac/taskcluster-worker/languages","stargazers_url":"https://api.github.com/repos/walac/taskcluster-worker/stargazers","contributors_url":"https://api.github.com/repos/walac/taskcluster-worker/contributors","subscribers_url":"https://api.github.com/repos/walac/taskcluster-worker/subscribers","subscription_url":"https://api.github.com/repos/walac/taskcluster-worker/subscription","commits_url":"https://api.github.com/repos/walac/taskcluster-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/walac/taskcluster-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/walac/taskcluster-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/walac/taskcluster-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/walac/taskcluster-worker/contents/{+path}","compare_url":"https://api.github.com/repos/walac/taskcluster-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walac/taskcluster-worker/merges","archive_url":"https://api.github.com/repos/walac/taskcluster-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walac/taskcluster-worker/downloads","issues_url":"https://api.github.com/repos/walac/taskcluster-worker/issues{/number}","pulls_url":"https://api.github.com/repos/walac/taskcluster-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/walac/taskcluster-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/walac/taskcluster-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walac/taskcluster-worker/labels{/name}","releases_url":"https://api.github.com/repos/walac/taskcluster-worker/releases{/id}","deployments_url":"https://api.github.com/repos/walac/taskcluster-worker/deployments","created_at":"2016-03-07T18:21:08Z","updated_at":"2016-03-07T18:21:09Z","pushed_at":"2016-05-04T14:30:59Z","git_url":"git://github.com/walac/taskcluster-worker.git","ssh_url":"git@github.com:walac/taskcluster-worker.git","clone_url":"https://github.com/walac/taskcluster-worker.git","svn_url":"https://github.com/walac/taskcluster-worker","homepage":"https://godoc.org/github.com/taskcluster/taskcluster-worker","size":391,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"51ceb04dc0960f045f7da2ee3b598be07b66835d","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":43515791,"name":"taskcluster-worker","full_name":"taskcluster/taskcluster-worker","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-worker","description":"Primary worker for TaskCluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-worker","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-worker/deployments","created_at":"2015-10-01T19:15:39Z","updated_at":"2016-03-02T00:08:50Z","pushed_at":"2016-05-17T05:20:52Z","git_url":"git://github.com/taskcluster/taskcluster-worker.git","ssh_url":"git@github.com:taskcluster/taskcluster-worker.git","clone_url":"https://github.com/taskcluster/taskcluster-worker.git","svn_url":"https://github.com/taskcluster/taskcluster-worker","homepage":"https://godoc.org/github.com/taskcluster/taskcluster-worker","size":33569,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67"},"html":{"href":"https://github.com/taskcluster/taskcluster-worker/pull/67"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/67"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-worker/statuses/fbd29901f3f09ee5e0c68a4d2f2119c514b2b24b"}}}}