{"action":"created","issue":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1648","repository_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1648/labels{/name}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1648/comments","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1648/events","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1648","id":197064933,"number":1648,"title":"Fix Google Tile Layer screenshots","user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"labels":[{"id":194213367,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"arottersman","id":7633670,"avatar_url":"https://avatars.githubusercontent.com/u/7633670?v=3","gravatar_id":"","url":"https://api.github.com/users/arottersman","html_url":"https://github.com/arottersman","followers_url":"https://api.github.com/users/arottersman/followers","following_url":"https://api.github.com/users/arottersman/following{/other_user}","gists_url":"https://api.github.com/users/arottersman/gists{/gist_id}","starred_url":"https://api.github.com/users/arottersman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arottersman/subscriptions","organizations_url":"https://api.github.com/users/arottersman/orgs","repos_url":"https://api.github.com/users/arottersman/repos","events_url":"https://api.github.com/users/arottersman/events{/privacy}","received_events_url":"https://api.github.com/users/arottersman/received_events","type":"User","site_admin":false},"assignees":[{"login":"arottersman","id":7633670,"avatar_url":"https://avatars.githubusercontent.com/u/7633670?v=3","gravatar_id":"","url":"https://api.github.com/users/arottersman","html_url":"https://github.com/arottersman","followers_url":"https://api.github.com/users/arottersman/followers","following_url":"https://api.github.com/users/arottersman/following{/other_user}","gists_url":"https://api.github.com/users/arottersman/gists{/gist_id}","starred_url":"https://api.github.com/users/arottersman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arottersman/subscriptions","organizations_url":"https://api.github.com/users/arottersman/orgs","repos_url":"https://api.github.com/users/arottersman/repos","events_url":"https://api.github.com/users/arottersman/events{/privacy}","received_events_url":"https://api.github.com/users/arottersman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-22T00:15:46Z","updated_at":"2016-12-22T16:54:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1648","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1648","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1648.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1648.patch"},"body":"## Overview\r\n\r\nThe Google Maps JavaScript API always uses CSS transforms, which are not supported by PhantomJS. We convert the CSS transform values to CSS left and top values before each screenshot, and restore them immediately afterwards. This allows the screenshot to capture the map accurately.\r\n\r\nGot the idea from here: https://github.com/niklasvh/html2canvas/issues/345#issuecomment-71774787\r\n\r\n## Testing Instructions\r\n\r\nCheck out the branch and bundle the scripts. `ngrok` your local app.\r\n\r\n * Open Firefox.\r\n * Go to https://authoring.concord.org/activities/5644.\r\n * Open the dev tools, and replace the iframe `src` to your ngrok rather than `app.wikiwatershed.org`. Preserve the `itsi_embed` flag. It should look like something like this: `https://b011c760.ngrok.io?itsi_embed=true`.\r\n * Take screenshots with all four basemap types. Ensure that they render correctly.\r\n\r\nDo the same test in Chrome.\r\n\r\nConnects #1639 \r\nConnects #1640 "},"comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments/268841554","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1648#issuecomment-268841554","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1648","id":268841554,"user":{"login":"rajadain","id":1430060,"avatar_url":"https://avatars.githubusercontent.com/u/1430060?v=3","gravatar_id":"","url":"https://api.github.com/users/rajadain","html_url":"https://github.com/rajadain","followers_url":"https://api.github.com/users/rajadain/followers","following_url":"https://api.github.com/users/rajadain/following{/other_user}","gists_url":"https://api.github.com/users/rajadain/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadain/subscriptions","organizations_url":"https://api.github.com/users/rajadain/orgs","repos_url":"https://api.github.com/users/rajadain/repos","events_url":"https://api.github.com/users/rajadain/events{/privacy}","received_events_url":"https://api.github.com/users/rajadain/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T16:54:01Z","updated_at":"2016-12-22T16:54:01Z","body":"I'm not quite sure why, but adding a guard for only doing the switch when the Google tile layer is visible seems to have worked. This is ready for another look."}}
{"actor":{"display_login":"rajadain"}}