{"action":"created","issue":{"url":"https://api.github.com/repos/mfogel/django-timezone-field/issues/30","labels_url":"https://api.github.com/repos/mfogel/django-timezone-field/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/mfogel/django-timezone-field/issues/30/comments","events_url":"https://api.github.com/repos/mfogel/django-timezone-field/issues/30/events","html_url":"https://github.com/mfogel/django-timezone-field/pull/30","id":125708043,"number":30,"title":"Adds handling for Django SubfieldBase deprecation","user":{"login":"arecker","id":5051721,"avatar_url":"https://avatars.githubusercontent.com/u/5051721?v=3","gravatar_id":"","url":"https://api.github.com/users/arecker","html_url":"https://github.com/arecker","followers_url":"https://api.github.com/users/arecker/followers","following_url":"https://api.github.com/users/arecker/following{/other_user}","gists_url":"https://api.github.com/users/arecker/gists{/gist_id}","starred_url":"https://api.github.com/users/arecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arecker/subscriptions","organizations_url":"https://api.github.com/users/arecker/orgs","repos_url":"https://api.github.com/users/arecker/repos","events_url":"https://api.github.com/users/arecker/events{/privacy}","received_events_url":"https://api.github.com/users/arecker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-08T22:30:52Z","updated_at":"2016-01-31T18:02:10Z","closed_at":"2016-01-31T18:02:10Z","pull_request":{"url":"https://api.github.com/repos/mfogel/django-timezone-field/pulls/30","html_url":"https://github.com/mfogel/django-timezone-field/pull/30","diff_url":"https://github.com/mfogel/django-timezone-field/pull/30.diff","patch_url":"https://github.com/mfogel/django-timezone-field/pull/30.patch"},"body":"Handles upcoming deprecation for SubfieldBase.\r\n\r\nInspired by [this](https://github.com/pennersr/django-allauth/pull/1118/files) merge request."},"comment":{"url":"https://api.github.com/repos/mfogel/django-timezone-field/issues/comments/177564793","html_url":"https://github.com/mfogel/django-timezone-field/pull/30#issuecomment-177564793","issue_url":"https://api.github.com/repos/mfogel/django-timezone-field/issues/30","id":177564793,"user":{"login":"mfogel","id":69902,"avatar_url":"https://avatars.githubusercontent.com/u/69902?v=3","gravatar_id":"","url":"https://api.github.com/users/mfogel","html_url":"https://github.com/mfogel","followers_url":"https://api.github.com/users/mfogel/followers","following_url":"https://api.github.com/users/mfogel/following{/other_user}","gists_url":"https://api.github.com/users/mfogel/gists{/gist_id}","starred_url":"https://api.github.com/users/mfogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfogel/subscriptions","organizations_url":"https://api.github.com/users/mfogel/orgs","repos_url":"https://api.github.com/users/mfogel/repos","events_url":"https://api.github.com/users/mfogel/events{/privacy}","received_events_url":"https://api.github.com/users/mfogel/received_events","type":"User","site_admin":false},"created_at":"2016-01-31T18:02:10Z","updated_at":"2016-01-31T18:02:10Z","body":"I think the failing forms tests came from a change in django's behavior as noted [here](https://docs.djangoproject.com/en/1.9/releases/1.8/#subfieldbase). \"Note that the new approach does not call the to_python() method on assignment...\" The tests were assuming `to_python()` would be called on assignment, and thus a validation error thrown. I've changed around those tests so they now explicitly call `full_clean()` to trigger the validation errors.\r\n\r\nI should have cherry-picked this commit over and then adjusted things from there - apologies, @arecker I didn't think to do it. Appreciate you writing this up, it was helpful.\r\n\r\nThis functionality will be included in the next release pushed to pypi, which I will get out there later today."}}