{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/comments/74841832","id":74841832,"diff_hunk":"@@ -60,4 +73,69 @@\n         r.assertLogContains(\"Apache Maven 3\", r.assertBuildStatusSuccess(p.scheduleBuild2(0)));\n     }\n \n+    @Test public void toolWithSymbol() throws Exception {\n+        File buildDirectory = new File(System.getProperty(\"buildDirectory\", \"target\")); // TODO relative path\n+        File toolHome = new File(buildDirectory, \"mockTools\");\n+        MockToolWithSymbol tool = new MockToolWithSymbol(\"mock-tool-with-symbol\", toolHome.getAbsolutePath(), JenkinsRule.NO_PROPERTIES);\n+        Jenkins.getInstance().getDescriptorByType(MockToolWithSymbol.MockToolWithSymbolDescriptor.class).setInstallations(tool);\n+        String name = tool.getName();\n+\n+        String type = \"mockToolWithSymbol\";\n+\n+        WorkflowJob p = r.jenkins.createProject(WorkflowJob.class, \"p\");\n+        p.setDefinition(new CpsFlowDefinition(\"node {def home = tool name: '\" + name + \"', type: '\" + type + \"'}\",","path":"src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java","position":63,"original_position":61,"commit_id":"b06fc31a0a8bff019e5b5f5944b9deaa2ffd3138","original_commit_id":"b06fc31a0a8bff019e5b5f5944b9deaa2ffd3138","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"A little stronger to `echo` that `home` to make sure it is `toolHome`.","created_at":"2016-08-15T21:49:19Z","updated_at":"2016-08-15T21:49:19Z","html_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16#discussion_r74841832","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/comments/74841832"},"html":{"href":"https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16#discussion_r74841832"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16","id":81251670,"html_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16","diff_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16.diff","patch_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues/16","number":16,"state":"open","locked":false,"title":"[FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types.","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"body":"[JENKINS-37397](https://issues.jenkins-ci.org/browse/JENKINS-37397)\r\n\r\nFall back to allowing descriptor IDs as well.\r\n\r\n[JENKINS-37386](https://issues.jenkins-ci.org/browse/JENKINS-37386) is driving getting `@Symbol` on `ToolDescriptor`s, so this will not be hugely useful until that's everywhere, but still, better to do ahead of time than after the fact!\r\n\r\ncc @reviewbybees esp @jglick and @oleg-nenashev ","created_at":"2016-08-14T19:11:37Z","updated_at":"2016-08-15T21:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b4138d9b3c7b718f6fd24cf96553e05f4c14841","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues/16/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/statuses/b06fc31a0a8bff019e5b5f5944b9deaa2ffd3138","head":{"label":"abayer:jenkins-37397","ref":"jenkins-37397","sha":"b06fc31a0a8bff019e5b5f5944b9deaa2ffd3138","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"repo":{"id":61080394,"name":"workflow-basic-steps-plugin","full_name":"abayer/workflow-basic-steps-plugin","owner":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abayer/workflow-basic-steps-plugin","description":"","fork":true,"url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin","forks_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/forks","keys_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/teams","hooks_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/hooks","issue_events_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/events","assignees_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/tags","blobs_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/languages","stargazers_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/stargazers","contributors_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/contributors","subscribers_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/subscribers","subscription_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/subscription","commits_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/merges","archive_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/downloads","issues_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/labels{/name}","releases_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/abayer/workflow-basic-steps-plugin/deployments","created_at":"2016-06-14T01:02:30Z","updated_at":"2016-06-14T01:02:31Z","pushed_at":"2016-08-15T20:25:26Z","git_url":"git://github.com/abayer/workflow-basic-steps-plugin.git","ssh_url":"git@github.com:abayer/workflow-basic-steps-plugin.git","clone_url":"https://github.com/abayer/workflow-basic-steps-plugin.git","svn_url":"https://github.com/abayer/workflow-basic-steps-plugin","homepage":"","size":476,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"b1703f03db97d53cb73d2a08ac10a268cb7c6a2e","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55541978,"name":"workflow-basic-steps-plugin","full_name":"jenkinsci/workflow-basic-steps-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/deployments","created_at":"2016-04-05T20:09:34Z","updated_at":"2016-08-08T21:33:41Z","pushed_at":"2016-08-15T20:25:27Z","git_url":"git://github.com/jenkinsci/workflow-basic-steps-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-basic-steps-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-basic-steps-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Basic+Steps+Plugin","size":484,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":5,"forks":20,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16"},"html":{"href":"https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues/16"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-basic-steps-plugin/statuses/b06fc31a0a8bff019e5b5f5944b9deaa2ffd3138"}}}}
{"actor":{"display_login":"jglick"}}