{"action":"created","issue":{"url":"https://api.github.com/repos/redhat-developer-tooling/katapult/issues/34","repository_url":"https://api.github.com/repos/redhat-developer-tooling/katapult","labels_url":"https://api.github.com/repos/redhat-developer-tooling/katapult/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/redhat-developer-tooling/katapult/issues/34/comments","events_url":"https://api.github.com/repos/redhat-developer-tooling/katapult/issues/34/events","html_url":"https://github.com/redhat-developer-tooling/katapult/pull/34","id":146778487,"number":34,"title":"externalize the github developer app id and secret","user":{"login":"starksm64","id":332210,"avatar_url":"https://avatars.githubusercontent.com/u/332210?v=3","gravatar_id":"","url":"https://api.github.com/users/starksm64","html_url":"https://github.com/starksm64","followers_url":"https://api.github.com/users/starksm64/followers","following_url":"https://api.github.com/users/starksm64/following{/other_user}","gists_url":"https://api.github.com/users/starksm64/gists{/gist_id}","starred_url":"https://api.github.com/users/starksm64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starksm64/subscriptions","organizations_url":"https://api.github.com/users/starksm64/orgs","repos_url":"https://api.github.com/users/starksm64/repos","events_url":"https://api.github.com/users/starksm64/events{/privacy}","received_events_url":"https://api.github.com/users/starksm64/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-08T00:24:02Z","updated_at":"2016-04-08T19:35:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/redhat-developer-tooling/katapult/pulls/34","html_url":"https://github.com/redhat-developer-tooling/katapult/pull/34","diff_url":"https://github.com/redhat-developer-tooling/katapult/pull/34.diff","patch_url":"https://github.com/redhat-developer-tooling/katapult/pull/34.patch"},"body":"Here is a candidate change to properly externalize the github dev app id and secret, for #27. Because of how the callback url in the dev app is part of its configuration, we will need two types of dev apps, those with callback urls appropriate for testing and those with callback urls for the production deployment. The README documents the setup of two additional GITHUB_DEV_APP_CLIENT_ID and GITHUB_DEV_APP_SECRET environment variables that should be assigned a test environment type of developer app. We should have a tooling developer app with a callback url of http://localhost:8080/katapult/api/github/callback that org developers can use for testing.\r\n\r\nWe will need another production github developer app with the appropriate callback url as well.\r\n"},"comment":{"url":"https://api.github.com/repos/redhat-developer-tooling/katapult/issues/comments/207571637","html_url":"https://github.com/redhat-developer-tooling/katapult/pull/34#issuecomment-207571637","issue_url":"https://api.github.com/repos/redhat-developer-tooling/katapult/issues/34","id":207571637,"user":{"login":"starksm64","id":332210,"avatar_url":"https://avatars.githubusercontent.com/u/332210?v=3","gravatar_id":"","url":"https://api.github.com/users/starksm64","html_url":"https://github.com/starksm64","followers_url":"https://api.github.com/users/starksm64/followers","following_url":"https://api.github.com/users/starksm64/following{/other_user}","gists_url":"https://api.github.com/users/starksm64/gists{/gist_id}","starred_url":"https://api.github.com/users/starksm64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starksm64/subscriptions","organizations_url":"https://api.github.com/users/starksm64/orgs","repos_url":"https://api.github.com/users/starksm64/repos","events_url":"https://api.github.com/users/starksm64/events{/privacy}","received_events_url":"https://api.github.com/users/starksm64/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T19:35:27Z","updated_at":"2016-04-08T19:35:27Z","body":"That is fine, and no, by default the wildfly containers don't run with a security manager on openshift."}}