{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2020","repository_url":"https://api.github.com/repos/OpenMS/OpenMS","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2020/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2020/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2020/events","html_url":"https://github.com/OpenMS/OpenMS/issues/2020","id":160469159,"number":2020,"title":"ConsensusID tool writes incorrect float values","user":{"login":"lars20070","id":6149805,"avatar_url":"https://avatars.githubusercontent.com/u/6149805?v=3","gravatar_id":"","url":"https://api.github.com/users/lars20070","html_url":"https://github.com/lars20070","followers_url":"https://api.github.com/users/lars20070/followers","following_url":"https://api.github.com/users/lars20070/following{/other_user}","gists_url":"https://api.github.com/users/lars20070/gists{/gist_id}","starred_url":"https://api.github.com/users/lars20070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars20070/subscriptions","organizations_url":"https://api.github.com/users/lars20070/orgs","repos_url":"https://api.github.com/users/lars20070/repos","events_url":"https://api.github.com/users/lars20070/events{/privacy}","received_events_url":"https://api.github.com/users/lars20070/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenMS/OpenMS/labels/critical","name":"critical","color":"e11d21"},{"url":"https://api.github.com/repos/OpenMS/OpenMS/labels/defect","name":"defect","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-06-15T16:43:35Z","updated_at":"2016-07-06T15:45:06Z","closed_at":null,"body":"The `ConsensusID` tool writes values such as `value=\"1.#INF\"`. See for example.\r\n```\r\n<PeptideIdentification score_type=\"XTandem\" higher_score_better=\"true\" significance_threshold=\"0\" MZ=\"484.821270750295\" RT=\"1573.41798\" >\r\n\t<PeptideHit score=\"16.3\" sequence=\"(Dimethyl:2H(6)13C(2))YLSPLALR\" charge=\"2\" >\r\n\t\t<UserParam type=\"float\" name=\"consensus_support\" value=\"1.#INF\"/>\r\n\t</PeptideHit>\r\n</PeptideIdentification>\r\n```\r\nwhich leads to a crash/exception in the following `PeptideIndexer`.\r\nhttps://github.com/OpenMS/OpenMS/blob/develop/src/openms/include/OpenMS/DATASTRUCTURES/StringUtils.h#L727\r\n\r\nThe workflow did run under Windows."},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/230813300","html_url":"https://github.com/OpenMS/OpenMS/issues/2020#issuecomment-230813300","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/2020","id":230813300,"user":{"login":"hendrikweisser","id":2251068,"avatar_url":"https://avatars.githubusercontent.com/u/2251068?v=3","gravatar_id":"","url":"https://api.github.com/users/hendrikweisser","html_url":"https://github.com/hendrikweisser","followers_url":"https://api.github.com/users/hendrikweisser/followers","following_url":"https://api.github.com/users/hendrikweisser/following{/other_user}","gists_url":"https://api.github.com/users/hendrikweisser/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikweisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikweisser/subscriptions","organizations_url":"https://api.github.com/users/hendrikweisser/orgs","repos_url":"https://api.github.com/users/hendrikweisser/repos","events_url":"https://api.github.com/users/hendrikweisser/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikweisser/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T15:45:06Z","updated_at":"2016-07-06T15:45:06Z","body":"> In the context of best (identical score types from the same search engine), min_support should not been used at all.\r\n\r\nYes, I agree, but the support calculation is orthogonal to the score calculation."}}
{"actor":{"display_login":"hendrikweisser"}}