{"push_id":1214176427,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"29622ffb0f2116f242bcddb38aec7a9100dda7ea","before":"a0be1c386d5179d79bd9de449d3e09ed341cc6aa","commits":[{"sha":"e792bd734f3535995d3d34dba43259965b65c51e","author":{"name":"brucedawson","email":"13e2c5f81b1ae9908bf3ae2aeff8c80d100f0b04@chromium.org"},"message":"Shrink gn's chrome.dll - now smaller than gyp's\n\nMore work to shrink gn's chrome.dll\n\nThe three largest globals that were present in gn's chrome.dll but not in gyp's chrome.dll were eliminated by using /verbose linker output to track the object files that pulled them in and then conditionally changing source_set targets to static_library targets. Specifically:\n\nunigram_table, in compact_enc_det.obj\n- Referenced by TextResourceDecoder.obj from //third_party/WebKit/Source/core:html - some other source_set targets in this file were also modified\n\ngpu::ApplyFramebufferAttachmentCMAAINTELResourceManager::cmaa_frag_s1_ and cmaa_frag_s2_, in gles2_cmd_apply_framebuffer_attachment_cmaa_intel.obj from //gpu/command_buffer/service:service_sources\n- Referenced by gpu_command_buffer_stub.obj from //gpu/ipc/service:ipc_service_sources\n- Referenced by gpu_video_decode_accelerator.obj from //media/gpu/ipc/service:service\n- Referenced by gpu_child_thread.obj from //content/gpu:gpu_sources\n- Referenced by gpu_video_decode_accelerator_factory.obj from //content/public/gpu:gpu_sources\n\nAs of R406709 this shrinks gn's 32-bit official chrome.dll file size from 38,907,904 bytes to 37,571,584 bytes - an unexpected 1,336,320 byte savings, mostly from the .text section. There is also ~67,000 bytes of memory-only savings in the zero-init part of the .data section.\n\nAt the same revision gyp's 32-bit official chrome.dll file size is 37,843,456 bytes - 271,872 bytes *larger* than the gn version.\n\nThere are still globals that are present in gn's chrome.dll but not gyp's chrome.dll, so the optimization technique can still be applied some more, but the priority is much lower now that gn is winning.\n\nThis is a follow-on to crrev.com/2163823002.\n\nBUG=624274\nCQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel\n\nReview-Url: https://codereview.chromium.org/2163933003\nCr-Commit-Position: refs/heads/master@{#406912}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/e792bd734f3535995d3d34dba43259965b65c51e"},{"sha":"224e6490115e915ed5e6bc72a7a0bafe32d29389","author":{"name":"wangxianzhu","email":"2007e6f3e7f8d81e81fdceba15608a5e3f2f9f7e@chromium.org"},"message":"Better performance for -LayoutUnit\n\nBUG=629932\n\nReview-Url: https://codereview.chromium.org/2171813002\nCr-Commit-Position: refs/heads/master@{#406913}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/224e6490115e915ed5e6bc72a7a0bafe32d29389"},{"sha":"29622ffb0f2116f242bcddb38aec7a9100dda7ea","author":{"name":"xidachen","email":"b11cbecc7777db26b49025fa7b4a518af95fb223@chromium.org"},"message":"Fix integer over flow issue in HTMLCanvasElement::canCreateImageBuffer\n\nRight now in this method, it does a size.width() * size.height(), and\nthat could cause integer overflow.\n\nThis CL fix that by using CheckedNumeric<int>.\n\nBUG=630024\n\nReview-Url: https://codereview.chromium.org/2170693003\nCr-Commit-Position: refs/heads/master@{#406914}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/29622ffb0f2116f242bcddb38aec7a9100dda7ea"}]}
{"actor":{"display_login":"dstockwell"}}