{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9296","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9296/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9296/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9296/events","html_url":"https://github.com/ManageIQ/manageiq/pull/9296","id":161231941,"number":9296,"title":"[WIP] Linking of Middleware with VMs","user":{"login":"jpkrohling","id":13387,"avatar_url":"https://avatars.githubusercontent.com/u/13387?v=3","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gem%20changes","name":"gem changes","color":"6A92BC"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/hawkular","name":"providers/hawkular","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-20T16:03:20Z","updated_at":"2016-06-20T16:12:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9296","html_url":"https://github.com/ManageIQ/manageiq/pull/9296","diff_url":"https://github.com/ManageIQ/manageiq/pull/9296.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9296.patch"},"body":"Purpose or Intent\r\n-----------------\r\nThis PR introduces the `lives_on` to Middleware. Hawkular exposes the `/etc/machine-id` on its `feeds` and we use this value to lookup for an existing managed VM on other providers. If a VM with a matching Machine ID is found, `lives_on` is populated with data from this VM. \r\n\r\nThis allows for a later UI navigation between Cloud <-> Hypervisor <-> VM <-> Middleware.\r\n\r\nSteps for Testing/QA\r\n--------------------\r\nSet RHEV-M with one Hypervisor and one VM\r\nAdd this RHEV-M to MiQ\r\nInstall Hawkular Services into the VM\r\nAdd this Hawkular instance to MiQ\r\nCheck that the `lives_on` for the Hawkular record is populated with data from the VM on the Hypervisor "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/227190081","html_url":"https://github.com/ManageIQ/manageiq/pull/9296#issuecomment-227190081","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9296","id":227190081,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T16:12:25Z","updated_at":"2016-06-20T16:12:25Z","body":"<rubocop />Checked commits https://github.com/jpkrohling/manageiq/compare/0867d97883c80e489ee26bed701dd5db237681c0~...22f23ca63566254702b711cc11118a6faf67b6e9 with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1\n7 files checked, 29 offenses detected\n\n**app/models/manageiq/providers/hawkular/middleware_manager.rb**\n- [ ] :large_orange_diamond: - [Line 69](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L69), Col 71 - [Style/SpaceInsideBlockBraces](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceInsideBlockBraces) - Space missing inside }.\n- [ ] :large_orange_diamond: - [Line 70](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L70), Col 33 - [Style/AndOr](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AndOr) - Use `||` instead of `or`.\n- [ ] :large_orange_diamond: - [Line 75](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L75), Col 41 - [Style/AndOr](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AndOr) - Use `||` instead of `or`.\n- [ ] :large_orange_diamond: - [Line 84](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L84), Col 57 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 84](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L84), Col 57 - [Style/HashSyntax](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/HashSyntax) - Use hash rockets syntax.\n- [ ] :large_orange_diamond: - [Line 85](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L85), Col 57 - [Style/HashSyntax](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/HashSyntax) - Use hash rockets syntax.\n- [ ] :large_orange_diamond: - [Line 86](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L86), Col 65 - [Style/HashSyntax](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/HashSyntax) - Use hash rockets syntax.\n- [ ] :small_blue_diamond: - [Line 65](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager.rb#L65), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for machine_id is too high. [18.17/15]\n\n**app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb**\n- [ ] :large_orange_diamond: - [Line 51](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L51), Col 21 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 51](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L51), Col 39 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 51](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L51), Col 57 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 51](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L51), Col 75 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 52](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L52), Col 13 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 52](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L52), Col 26 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 52](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L52), Col 44 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 53](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L53), Col 13 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 53](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L53), Col 26 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 53](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L53), Col 45 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 54](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L54), Col 13 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 54](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L54), Col 26 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 55](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L55), Col 13 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineOperationIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 66](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L66), Col 13 - [Style/MultilineMethodCallIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineMethodCallIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 67](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L67), Col 13 - [Style/MultilineMethodCallIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineMethodCallIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 68](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L68), Col 13 - [Style/MultilineMethodCallIndentation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/MultilineMethodCallIndentation) - Use 2 (not 4) spaces for indenting an expression spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 86](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L86), Col 66 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 86](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L86), Col 66 - [Style/HashSyntax](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/HashSyntax) - Use hash rockets syntax.\n- [ ] :large_orange_diamond: - [Line 87](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L87), Col 66 - [Style/HashSyntax](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/HashSyntax) - Use hash rockets syntax.\n- [ ] :small_blue_diamond: - [Line 49](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L49), Col 7 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for alternate_machine_id is too high. [23/15]\n- [ ] :small_blue_diamond: - [Line 65](https://github.com/jpkrohling/manageiq/blob/22f23ca63566254702b711cc11118a6faf67b6e9/app/models/manageiq/providers/hawkular/middleware_manager/refresh_parser.rb#L65), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [152/120]\n"}}
{"actor":{"display_login":"miq-bot"}}