{"action":"created","comment":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/comments/73700230","id":73700230,"diff_hunk":"@@ -154,39 +158,6 @@ public function __get($strKey)\n \t\treturn parent::__get($strKey);\n \t}\n \n-\n-\t/**\n-\t * Redirect to the login screen if authentication fails\n-\t *\n-\t * @return boolean True if the user could be authenticated\n-\t */\n-\tpublic function authenticate()","path":"src/Resources/contao/classes/BackendUser.php","position":null,"original_position":28,"commit_id":"58e6b65c9569fd70532332118dbdb7baac834bcf","original_commit_id":"c6212647e3e739daf360dc448d9b3364fe5d4f50","user":{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false},"body":"The method is back in there - I've got it wrong in the first view. \r\nIf we now use `BackendUser::authenticate()` we are compatible to all other backend entry points (see https://github.com/contao/core-bundle/pull/559/commits/58e6b65c9569fd70532332118dbdb7baac834bcf).","created_at":"2016-08-05T14:23:53Z","updated_at":"2016-08-05T14:23:53Z","html_url":"https://github.com/contao/core-bundle/pull/559#discussion_r73700230","pull_request_url":"https://api.github.com/repos/contao/core-bundle/pulls/559","_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments/73700230"},"html":{"href":"https://github.com/contao/core-bundle/pull/559#discussion_r73700230"},"pull_request":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/559"}}},"pull_request":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/559","id":79855500,"html_url":"https://github.com/contao/core-bundle/pull/559","diff_url":"https://github.com/contao/core-bundle/pull/559.diff","patch_url":"https://github.com/contao/core-bundle/pull/559.patch","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/559","number":559,"state":"open","locked":false,"title":"[WIP] Symfony authentication","user":{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false},"body":"This is an early working draft to use the replace the current `simple_preauth` mechanism with the Symfony `form_login` authentication listener.\r\n\r\nPlease review and mention all missed topics.\r\n\r\nToDos:\r\n- [ ] Implement `$GLOBALS['TL_HOOKS']['postAuthenticate']` as an event?\r\n- [ ] Test frontend preview\r\n- [ ] Use `from_login` for `FrontendUser` (members) as well\r\n- [ ] Implement role switcher / impersonate any `FrontendUser` for frontend preview\r\n- [ ] Write tests","created_at":"2016-08-03T06:44:08Z","updated_at":"2016-08-05T14:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"232db422f0df94be709d91f067770da2384d87bf","assignee":{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false},"assignees":[{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/contao/core-bundle/pulls/559/commits","review_comments_url":"https://api.github.com/repos/contao/core-bundle/pulls/559/comments","review_comment_url":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/559/comments","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/58e6b65c9569fd70532332118dbdb7baac834bcf","head":{"label":"bytehead:feature/symfony-authentication","ref":"feature/symfony-authentication","sha":"58e6b65c9569fd70532332118dbdb7baac834bcf","user":{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false},"repo":{"id":44699489,"name":"core-bundle","full_name":"bytehead/core-bundle","owner":{"login":"bytehead","id":754921,"avatar_url":"https://avatars.githubusercontent.com/u/754921?v=3","gravatar_id":"","url":"https://api.github.com/users/bytehead","html_url":"https://github.com/bytehead","followers_url":"https://api.github.com/users/bytehead/followers","following_url":"https://api.github.com/users/bytehead/following{/other_user}","gists_url":"https://api.github.com/users/bytehead/gists{/gist_id}","starred_url":"https://api.github.com/users/bytehead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bytehead/subscriptions","organizations_url":"https://api.github.com/users/bytehead/orgs","repos_url":"https://api.github.com/users/bytehead/repos","events_url":"https://api.github.com/users/bytehead/events{/privacy}","received_events_url":"https://api.github.com/users/bytehead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bytehead/core-bundle","description":"Contao 4 core bundle","fork":true,"url":"https://api.github.com/repos/bytehead/core-bundle","forks_url":"https://api.github.com/repos/bytehead/core-bundle/forks","keys_url":"https://api.github.com/repos/bytehead/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bytehead/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bytehead/core-bundle/teams","hooks_url":"https://api.github.com/repos/bytehead/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/bytehead/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/bytehead/core-bundle/events","assignees_url":"https://api.github.com/repos/bytehead/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/bytehead/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/bytehead/core-bundle/tags","blobs_url":"https://api.github.com/repos/bytehead/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bytehead/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bytehead/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/bytehead/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bytehead/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/bytehead/core-bundle/languages","stargazers_url":"https://api.github.com/repos/bytehead/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/bytehead/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/bytehead/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/bytehead/core-bundle/subscription","commits_url":"https://api.github.com/repos/bytehead/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/bytehead/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/bytehead/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/bytehead/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/bytehead/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/bytehead/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bytehead/core-bundle/merges","archive_url":"https://api.github.com/repos/bytehead/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bytehead/core-bundle/downloads","issues_url":"https://api.github.com/repos/bytehead/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/bytehead/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/bytehead/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/bytehead/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bytehead/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/bytehead/core-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/bytehead/core-bundle/deployments","created_at":"2015-10-21T19:33:30Z","updated_at":"2016-04-21T17:01:57Z","pushed_at":"2016-08-05T14:21:25Z","git_url":"git://github.com/bytehead/core-bundle.git","ssh_url":"git@github.com:bytehead/core-bundle.git","clone_url":"https://github.com/bytehead/core-bundle.git","svn_url":"https://github.com/bytehead/core-bundle","homepage":"","size":29121,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contao:develop","ref":"develop","sha":"001f54808353d0936c913a83d2438f351a8175e1","user":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":20519851,"name":"core-bundle","full_name":"contao/core-bundle","owner":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contao/core-bundle","description":"Contao 4 core bundle","fork":false,"url":"https://api.github.com/repos/contao/core-bundle","forks_url":"https://api.github.com/repos/contao/core-bundle/forks","keys_url":"https://api.github.com/repos/contao/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/core-bundle/teams","hooks_url":"https://api.github.com/repos/contao/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/contao/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/contao/core-bundle/events","assignees_url":"https://api.github.com/repos/contao/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/contao/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/contao/core-bundle/tags","blobs_url":"https://api.github.com/repos/contao/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/core-bundle/languages","stargazers_url":"https://api.github.com/repos/contao/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/contao/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/contao/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/contao/core-bundle/subscription","commits_url":"https://api.github.com/repos/contao/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/contao/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/core-bundle/merges","archive_url":"https://api.github.com/repos/contao/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/core-bundle/downloads","issues_url":"https://api.github.com/repos/contao/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/contao/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/contao/core-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/contao/core-bundle/deployments","created_at":"2014-06-05T09:45:55Z","updated_at":"2016-06-14T14:23:35Z","pushed_at":"2016-08-05T14:21:25Z","git_url":"git://github.com/contao/core-bundle.git","ssh_url":"git@github.com:contao/core-bundle.git","clone_url":"https://github.com/contao/core-bundle.git","svn_url":"https://github.com/contao/core-bundle","homepage":"","size":31195,"stargazers_count":39,"watchers_count":39,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":34,"forks":18,"open_issues":34,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/559"},"html":{"href":"https://github.com/contao/core-bundle/pull/559"},"issue":{"href":"https://api.github.com/repos/contao/core-bundle/issues/559"},"comments":{"href":"https://api.github.com/repos/contao/core-bundle/issues/559/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/559/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/559/commits"},"statuses":{"href":"https://api.github.com/repos/contao/core-bundle/statuses/58e6b65c9569fd70532332118dbdb7baac834bcf"}}}}
{"actor":{"display_login":"bytehead"}}