{"action":"created","comment":{"url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/comments/63438032","id":63438032,"diff_hunk":"@@ -41,7 +41,7 @@ defmodule Absinthe.Execution.Arguments do\n \n   defp add_argument(%Language.Argument{value: value} = ast_node, %Type.Argument{type: inner_type} = type, type_stack, meta) do\n     meta = meta |> add_deprecation_notice(type, inner_type, [type.name | type_stack], ast_node)\n-    add_argument(value, inner_type, [type.name | type_stack], meta)\n+    add_argument(value, type, [type.name | type_stack], meta)","path":"lib/absinthe/execution/arguments.ex","position":5,"original_position":5,"commit_id":"fe7a6019f68638fdfeab61030619db90b4fc0a01","original_commit_id":"fe7a6019f68638fdfeab61030619db90b4fc0a01","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars.githubusercontent.com/u/247817?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"body":"We need to pass the inner type along because that's the type of the argument.","created_at":"2016-05-16T22:37:51Z","updated_at":"2016-05-16T22:37:51Z","html_url":"https://github.com/absinthe-graphql/absinthe/pull/114#discussion_r63438032","pull_request_url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/comments/63438032"},"html":{"href":"https://github.com/absinthe-graphql/absinthe/pull/114#discussion_r63438032"},"pull_request":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114","id":69347683,"html_url":"https://github.com/absinthe-graphql/absinthe/pull/114","diff_url":"https://github.com/absinthe-graphql/absinthe/pull/114.diff","patch_url":"https://github.com/absinthe-graphql/absinthe/pull/114.patch","issue_url":"https://api.github.com/repos/absinthe-graphql/absinthe/issues/114","number":114,"state":"open","locked":false,"title":"Use default_values if variables are missing","user":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"body":"Hey folks, I started taking a stab at fixing #102 last night as I noticed this issue when experimenting with querying an app I'm building.\n\nI was able to get a new test to pass, but I've introduced ~60 other failures.\n\nI'm not yet that familiar with the codebase...but I can continue working on this to fix up the remaining failures to get my feet wet.\n\nI believe the main issue is that the `add_argument` function clauses are expecting the \"inner type\" but in order to get access to the `default_value`,\nthe whole `Absinthe.Type.Argument` needs to be passed around.\n\nLet me know if I'm missing something.","created_at":"2016-05-09T13:48:05Z","updated_at":"2016-05-16T22:37:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d2d0ba9e972919ed8bd3f0dc08effa985a74f1b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114/commits","review_comments_url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114/comments","review_comment_url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/absinthe-graphql/absinthe/issues/114/comments","statuses_url":"https://api.github.com/repos/absinthe-graphql/absinthe/statuses/fe7a6019f68638fdfeab61030619db90b4fc0a01","head":{"label":"scrogson:fix_default_values","ref":"fix_default_values","sha":"fe7a6019f68638fdfeab61030619db90b4fc0a01","user":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"repo":{"id":58348986,"name":"absinthe","full_name":"scrogson/absinthe","owner":{"login":"scrogson","id":53274,"avatar_url":"https://avatars.githubusercontent.com/u/53274?v=3","gravatar_id":"","url":"https://api.github.com/users/scrogson","html_url":"https://github.com/scrogson","followers_url":"https://api.github.com/users/scrogson/followers","following_url":"https://api.github.com/users/scrogson/following{/other_user}","gists_url":"https://api.github.com/users/scrogson/gists{/gist_id}","starred_url":"https://api.github.com/users/scrogson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrogson/subscriptions","organizations_url":"https://api.github.com/users/scrogson/orgs","repos_url":"https://api.github.com/users/scrogson/repos","events_url":"https://api.github.com/users/scrogson/events{/privacy}","received_events_url":"https://api.github.com/users/scrogson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scrogson/absinthe","description":"GraphQL for Elixir","fork":true,"url":"https://api.github.com/repos/scrogson/absinthe","forks_url":"https://api.github.com/repos/scrogson/absinthe/forks","keys_url":"https://api.github.com/repos/scrogson/absinthe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrogson/absinthe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrogson/absinthe/teams","hooks_url":"https://api.github.com/repos/scrogson/absinthe/hooks","issue_events_url":"https://api.github.com/repos/scrogson/absinthe/issues/events{/number}","events_url":"https://api.github.com/repos/scrogson/absinthe/events","assignees_url":"https://api.github.com/repos/scrogson/absinthe/assignees{/user}","branches_url":"https://api.github.com/repos/scrogson/absinthe/branches{/branch}","tags_url":"https://api.github.com/repos/scrogson/absinthe/tags","blobs_url":"https://api.github.com/repos/scrogson/absinthe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrogson/absinthe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrogson/absinthe/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrogson/absinthe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrogson/absinthe/statuses/{sha}","languages_url":"https://api.github.com/repos/scrogson/absinthe/languages","stargazers_url":"https://api.github.com/repos/scrogson/absinthe/stargazers","contributors_url":"https://api.github.com/repos/scrogson/absinthe/contributors","subscribers_url":"https://api.github.com/repos/scrogson/absinthe/subscribers","subscription_url":"https://api.github.com/repos/scrogson/absinthe/subscription","commits_url":"https://api.github.com/repos/scrogson/absinthe/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrogson/absinthe/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrogson/absinthe/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrogson/absinthe/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrogson/absinthe/contents/{+path}","compare_url":"https://api.github.com/repos/scrogson/absinthe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrogson/absinthe/merges","archive_url":"https://api.github.com/repos/scrogson/absinthe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrogson/absinthe/downloads","issues_url":"https://api.github.com/repos/scrogson/absinthe/issues{/number}","pulls_url":"https://api.github.com/repos/scrogson/absinthe/pulls{/number}","milestones_url":"https://api.github.com/repos/scrogson/absinthe/milestones{/number}","notifications_url":"https://api.github.com/repos/scrogson/absinthe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrogson/absinthe/labels{/name}","releases_url":"https://api.github.com/repos/scrogson/absinthe/releases{/id}","deployments_url":"https://api.github.com/repos/scrogson/absinthe/deployments","created_at":"2016-05-09T04:46:03Z","updated_at":"2016-05-09T04:46:04Z","pushed_at":"2016-05-09T13:40:54Z","git_url":"git://github.com/scrogson/absinthe.git","ssh_url":"git@github.com:scrogson/absinthe.git","clone_url":"https://github.com/scrogson/absinthe.git","svn_url":"https://github.com/scrogson/absinthe","homepage":"http://absinthe-graphql.org","size":789,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"absinthe-graphql:master","ref":"master","sha":"aa7e9c83dc10603c72f80e09a60d12495bc1c6b7","user":{"login":"absinthe-graphql","id":16964118,"avatar_url":"https://avatars.githubusercontent.com/u/16964118?v=3","gravatar_id":"","url":"https://api.github.com/users/absinthe-graphql","html_url":"https://github.com/absinthe-graphql","followers_url":"https://api.github.com/users/absinthe-graphql/followers","following_url":"https://api.github.com/users/absinthe-graphql/following{/other_user}","gists_url":"https://api.github.com/users/absinthe-graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/absinthe-graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absinthe-graphql/subscriptions","organizations_url":"https://api.github.com/users/absinthe-graphql/orgs","repos_url":"https://api.github.com/users/absinthe-graphql/repos","events_url":"https://api.github.com/users/absinthe-graphql/events{/privacy}","received_events_url":"https://api.github.com/users/absinthe-graphql/received_events","type":"Organization","site_admin":false},"repo":{"id":44419624,"name":"absinthe","full_name":"absinthe-graphql/absinthe","owner":{"login":"absinthe-graphql","id":16964118,"avatar_url":"https://avatars.githubusercontent.com/u/16964118?v=3","gravatar_id":"","url":"https://api.github.com/users/absinthe-graphql","html_url":"https://github.com/absinthe-graphql","followers_url":"https://api.github.com/users/absinthe-graphql/followers","following_url":"https://api.github.com/users/absinthe-graphql/following{/other_user}","gists_url":"https://api.github.com/users/absinthe-graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/absinthe-graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absinthe-graphql/subscriptions","organizations_url":"https://api.github.com/users/absinthe-graphql/orgs","repos_url":"https://api.github.com/users/absinthe-graphql/repos","events_url":"https://api.github.com/users/absinthe-graphql/events{/privacy}","received_events_url":"https://api.github.com/users/absinthe-graphql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/absinthe-graphql/absinthe","description":"GraphQL for Elixir","fork":false,"url":"https://api.github.com/repos/absinthe-graphql/absinthe","forks_url":"https://api.github.com/repos/absinthe-graphql/absinthe/forks","keys_url":"https://api.github.com/repos/absinthe-graphql/absinthe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/absinthe-graphql/absinthe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/absinthe-graphql/absinthe/teams","hooks_url":"https://api.github.com/repos/absinthe-graphql/absinthe/hooks","issue_events_url":"https://api.github.com/repos/absinthe-graphql/absinthe/issues/events{/number}","events_url":"https://api.github.com/repos/absinthe-graphql/absinthe/events","assignees_url":"https://api.github.com/repos/absinthe-graphql/absinthe/assignees{/user}","branches_url":"https://api.github.com/repos/absinthe-graphql/absinthe/branches{/branch}","tags_url":"https://api.github.com/repos/absinthe-graphql/absinthe/tags","blobs_url":"https://api.github.com/repos/absinthe-graphql/absinthe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/absinthe-graphql/absinthe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/absinthe-graphql/absinthe/git/refs{/sha}","trees_url":"https://api.github.com/repos/absinthe-graphql/absinthe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/absinthe-graphql/absinthe/statuses/{sha}","languages_url":"https://api.github.com/repos/absinthe-graphql/absinthe/languages","stargazers_url":"https://api.github.com/repos/absinthe-graphql/absinthe/stargazers","contributors_url":"https://api.github.com/repos/absinthe-graphql/absinthe/contributors","subscribers_url":"https://api.github.com/repos/absinthe-graphql/absinthe/subscribers","subscription_url":"https://api.github.com/repos/absinthe-graphql/absinthe/subscription","commits_url":"https://api.github.com/repos/absinthe-graphql/absinthe/commits{/sha}","git_commits_url":"https://api.github.com/repos/absinthe-graphql/absinthe/git/commits{/sha}","comments_url":"https://api.github.com/repos/absinthe-graphql/absinthe/comments{/number}","issue_comment_url":"https://api.github.com/repos/absinthe-graphql/absinthe/issues/comments{/number}","contents_url":"https://api.github.com/repos/absinthe-graphql/absinthe/contents/{+path}","compare_url":"https://api.github.com/repos/absinthe-graphql/absinthe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/absinthe-graphql/absinthe/merges","archive_url":"https://api.github.com/repos/absinthe-graphql/absinthe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/absinthe-graphql/absinthe/downloads","issues_url":"https://api.github.com/repos/absinthe-graphql/absinthe/issues{/number}","pulls_url":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls{/number}","milestones_url":"https://api.github.com/repos/absinthe-graphql/absinthe/milestones{/number}","notifications_url":"https://api.github.com/repos/absinthe-graphql/absinthe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/absinthe-graphql/absinthe/labels{/name}","releases_url":"https://api.github.com/repos/absinthe-graphql/absinthe/releases{/id}","deployments_url":"https://api.github.com/repos/absinthe-graphql/absinthe/deployments","created_at":"2015-10-17T01:56:28Z","updated_at":"2016-05-16T16:39:00Z","pushed_at":"2016-05-12T09:03:56Z","git_url":"git://github.com/absinthe-graphql/absinthe.git","ssh_url":"git@github.com:absinthe-graphql/absinthe.git","clone_url":"https://github.com/absinthe-graphql/absinthe.git","svn_url":"https://github.com/absinthe-graphql/absinthe","homepage":"http://absinthe-graphql.org","size":810,"stargazers_count":257,"watchers_count":257,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":11,"forks":10,"open_issues":11,"watchers":257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114"},"html":{"href":"https://github.com/absinthe-graphql/absinthe/pull/114"},"issue":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/issues/114"},"comments":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/absinthe-graphql/absinthe/statuses/fe7a6019f68638fdfeab61030619db90b4fc0a01"}}}}