{"action":"created","issue":{"url":"https://api.github.com/repos/delba/SwiftyOAuth/issues/11","repository_url":"https://api.github.com/repos/delba/SwiftyOAuth","labels_url":"https://api.github.com/repos/delba/SwiftyOAuth/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/delba/SwiftyOAuth/issues/11/comments","events_url":"https://api.github.com/repos/delba/SwiftyOAuth/issues/11/events","html_url":"https://github.com/delba/SwiftyOAuth/issues/11","id":159763810,"number":11,"title":"Issue in following the README for handling incoming requests in the AppDelegate","user":{"login":"fabiomassimo","id":2462167,"avatar_url":"https://avatars.githubusercontent.com/u/2462167?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiomassimo","html_url":"https://github.com/fabiomassimo","followers_url":"https://api.github.com/users/fabiomassimo/followers","following_url":"https://api.github.com/users/fabiomassimo/following{/other_user}","gists_url":"https://api.github.com/users/fabiomassimo/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiomassimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiomassimo/subscriptions","organizations_url":"https://api.github.com/users/fabiomassimo/orgs","repos_url":"https://api.github.com/users/fabiomassimo/repos","events_url":"https://api.github.com/users/fabiomassimo/events{/privacy}","received_events_url":"https://api.github.com/users/fabiomassimo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-11T08:54:16Z","updated_at":"2016-06-11T16:27:32Z","closed_at":"2016-06-11T10:24:13Z","body":"From the docs:\r\n\r\n```\r\nStep 2: Handle the incoming requests\r\n\r\nHandle the incoming requests in your AppDelegate:\r\n\r\nfunc application(app: UIApplication, openURL url: NSURL, options: [String : AnyObject]) -> Bool {\r\n    github.handleURL(url, options: options)\r\n\r\n    return true\r\n}\r\n```\r\n\r\nUnfortunately, while I was following the README, I found out that that the delegate method signature is slightly different:\r\n\r\n```swift\r\nfunc application(application: UIApplication, openURL url: NSURL, sourceApplication: String?, annotation: AnyObject) -> Bool\r\n```\r\n\r\nThis causes an inconsistency with the designated method to handle an URL from the Provider.\r\n\r\n```swift\r\n    /**\r\n     Handles the incoming URL.\r\n     \r\n     - parameter URL:     The incoming URL to handle.\r\n     - parameter options: A dictionary of launch options.\r\n     */\r\n    public func handleURL(URL: NSURL, options: [String : AnyObject])\r\n```\r\n\r\nI think it should be rewritten in something like:\r\n\r\n```swift\r\npublic func handleURL(URL: NSURL, sourceApplication: String?) \r\n``` \r\n\r\nSuch that the *Step 2* from the README would look like:\r\n\r\n```swift\r\nfunc application(application: UIApplication, openURL url: NSURL, sourceApplication: String?, annotation: AnyObject) -> Bool {\r\n    github.handleURL(url, sourceApplication: sourceApplication)\r\n\r\n    return true\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/delba/SwiftyOAuth/issues/comments/225373029","html_url":"https://github.com/delba/SwiftyOAuth/issues/11#issuecomment-225373029","issue_url":"https://api.github.com/repos/delba/SwiftyOAuth/issues/11","id":225373029,"user":{"login":"delba","id":2891970,"avatar_url":"https://avatars.githubusercontent.com/u/2891970?v=3","gravatar_id":"","url":"https://api.github.com/users/delba","html_url":"https://github.com/delba","followers_url":"https://api.github.com/users/delba/followers","following_url":"https://api.github.com/users/delba/following{/other_user}","gists_url":"https://api.github.com/users/delba/gists{/gist_id}","starred_url":"https://api.github.com/users/delba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delba/subscriptions","organizations_url":"https://api.github.com/users/delba/orgs","repos_url":"https://api.github.com/users/delba/repos","events_url":"https://api.github.com/users/delba/events{/privacy}","received_events_url":"https://api.github.com/users/delba/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T16:27:32Z","updated_at":"2016-06-11T16:27:32Z","body":"It took me way longer than expected but here it is: f2b743aabb03d67b9e723646efdd52aae630ac4b"}}
{"actor":{"display_login":"delba"}}