{"action":"created","issue":{"url":"https://api.github.com/repos/wesbland/mpi-forum-historic/issues/60","repository_url":"https://api.github.com/repos/wesbland/mpi-forum-historic","labels_url":"https://api.github.com/repos/wesbland/mpi-forum-historic/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/wesbland/mpi-forum-historic/issues/60/comments","events_url":"https://api.github.com/repos/wesbland/mpi-forum-historic/issues/60/events","html_url":"https://github.com/wesbland/mpi-forum-historic/issues/60","id":166686823,"number":60,"title":"Modernize example on p 279","user":{"login":"wesbland","id":1561207,"avatar_url":"https://avatars.githubusercontent.com/u/1561207?v=3","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wesbland","id":1561207,"avatar_url":"https://avatars.githubusercontent.com/u/1561207?v=3","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"assignees":[{"login":"wesbland","id":1561207,"avatar_url":"https://avatars.githubusercontent.com/u/1561207?v=3","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wesbland/mpi-forum-historic/milestones/7","html_url":"https://github.com/wesbland/mpi-forum-historic/milestones/2009/06/08%20California","labels_url":"https://api.github.com/repos/wesbland/mpi-forum-historic/milestones/7/labels","id":1894747,"number":7,"title":"2009/06/08 California","description":"","creator":{"login":"wesbland","id":1561207,"avatar_url":"https://avatars.githubusercontent.com/u/1561207?v=3","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"closed","created_at":"2016-07-20T18:12:54Z","updated_at":"2016-07-20T21:29:56Z","due_on":"2009-06-10T04:00:00Z","closed_at":"2016-07-20T18:12:54Z"},"comments":6,"created_at":"2016-07-20T21:29:53Z","updated_at":"2016-07-20T21:30:06Z","closed_at":null,"body":"**Originally by _gropp_ on 2008-12-10 12:23:29 -0600**\n\n___\nOn page 279, lines 8-10, the old K&R form is used:\n\n\n```\nint main( argc, argv )\nint argc;\nchar **argv;\n```\n\nThis also appears on page 25.\n\n## History\nThis code is from the original MPI 1 standard.\n\n## Proposed Solution\n\nWe should use the modern form in the following places\n\np25, lines 21-23, replace\n\n```\nmain( argc, argv ) \nint argc; \nchar **argv; \n```\n\nwith\n\n\n```\nint main( int argc, char **argv )\n```\n\n\np279, lines 8-10, replace\n\n\n```\n\nint main(argc, argv) \nint argc; \nchar **argv;\n```\n\nwith\n\n```\nint main( int argc, char **argv )\n```\n\n\n## Impact on Implementations\nNone\n\n## Impact on Applications / Users\nNone\n\n## Alternative Solutions\nLeave as is.\n\n## Entry for the Change Log\n\nN/A\n"},"comment":{"url":"https://api.github.com/repos/wesbland/mpi-forum-historic/issues/comments/234089333","html_url":"https://github.com/wesbland/mpi-forum-historic/issues/60#issuecomment-234089333","issue_url":"https://api.github.com/repos/wesbland/mpi-forum-historic/issues/60","id":234089333,"user":{"login":"wesbland","id":1561207,"avatar_url":"https://avatars.githubusercontent.com/u/1561207?v=3","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T21:30:06Z","updated_at":"2016-07-20T21:30:06Z","body":"**Originally by _RolfRabenseifner_ on 2009-01-19 09:27:00 -0600**\n\n___\nMy review: Based on the comments above, I would also keep it as proposed, i.e., char **argv.\n\nI checked again all \"main(\" and \"main (\" and found only these 2 locations.\n\nTherefore, for me, all is fine."}}
{"actor":{"display_login":"wesbland"}}