{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/71400928","id":71400928,"diff_hunk":"@@ -6827,6 +6860,12 @@ void        CodeGen::genCompareLong(GenTreePtr  treeNode)\n     assert(varTypeIsLong(op1->TypeGet()) && varTypeIsLong(op2->TypeGet()));","path":"src/jit/codegenxarch.cpp","position":222,"original_position":222,"commit_id":"201b9c75fa8ae6a21201a20a2593c25346f5e067","original_commit_id":"201b9c75fa8ae6a21201a20a2593c25346f5e067","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"body":"Since you are here, please consider splitting this assert into two asserts\r\n\r\ne.g.\r\n```\r\nassert(varTypeIsLong(op1));\r\nassert(varTypeIsLong(op2));\r\n```","created_at":"2016-07-19T18:54:16Z","updated_at":"2016-07-19T18:54:16Z","html_url":"https://github.com/dotnet/coreclr/pull/6219#discussion_r71400928","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6219","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/71400928"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6219#discussion_r71400928"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6219"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6219","id":76992973,"html_url":"https://github.com/dotnet/coreclr/pull/6219","diff_url":"https://github.com/dotnet/coreclr/pull/6219.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6219.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6219","number":6219,"state":"open","locked":false,"title":"Fix silent bad codegen in signed comparison","user":{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars.githubusercontent.com/u/9666644?v=3","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false},"body":"While working on #5956, I uncovered a silent bad codegen bug in signed\r\ncomparison. The way the code was written, we'd do an unsigned set after a\r\nsigned compare/jump from the high comparison. However, in this case, we\r\nneed to make sure that we are honoring the sign of the comparison done on\r\nthe high part of the operation, and the lo comparison would still want to\r\nbe an unsigned compare followed by an unsigned set. This change splits\r\ncomparisons into two cases: 1) A signed comparison where we have two jumps\r\nfor the high part (GT_GT, GT_LT, GT_GE, and GT_LE), which require a signed\r\nset if the high comparisons are true, and an unsigned set if not, and 2)\r\nAn unsigned comparison, or a comparison where the sign does not matter for\r\nthe compare (GT_NE, GT_EQ), which just require an unsigned set for both\r\nthe high and lo operations (the code we already had in genCompareLong).","created_at":"2016-07-11T17:35:39Z","updated_at":"2016-07-19T18:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5d70fa624cf281ab6a4d4fffb344b32f87b0fb0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6219/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6219/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6219/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/201b9c75fa8ae6a21201a20a2593c25346f5e067","head":{"label":"adiaaida:compareLongs","ref":"compareLongs","sha":"201b9c75fa8ae6a21201a20a2593c25346f5e067","user":{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars.githubusercontent.com/u/9666644?v=3","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false},"repo":{"id":31043145,"name":"coreclr","full_name":"adiaaida/coreclr","owner":{"login":"adiaaida","id":9666644,"avatar_url":"https://avatars.githubusercontent.com/u/9666644?v=3","gravatar_id":"","url":"https://api.github.com/users/adiaaida","html_url":"https://github.com/adiaaida","followers_url":"https://api.github.com/users/adiaaida/followers","following_url":"https://api.github.com/users/adiaaida/following{/other_user}","gists_url":"https://api.github.com/users/adiaaida/gists{/gist_id}","starred_url":"https://api.github.com/users/adiaaida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adiaaida/subscriptions","organizations_url":"https://api.github.com/users/adiaaida/orgs","repos_url":"https://api.github.com/users/adiaaida/repos","events_url":"https://api.github.com/users/adiaaida/events{/privacy}","received_events_url":"https://api.github.com/users/adiaaida/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adiaaida/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/adiaaida/coreclr","forks_url":"https://api.github.com/repos/adiaaida/coreclr/forks","keys_url":"https://api.github.com/repos/adiaaida/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adiaaida/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adiaaida/coreclr/teams","hooks_url":"https://api.github.com/repos/adiaaida/coreclr/hooks","issue_events_url":"https://api.github.com/repos/adiaaida/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/adiaaida/coreclr/events","assignees_url":"https://api.github.com/repos/adiaaida/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/adiaaida/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/adiaaida/coreclr/tags","blobs_url":"https://api.github.com/repos/adiaaida/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adiaaida/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adiaaida/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/adiaaida/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adiaaida/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/adiaaida/coreclr/languages","stargazers_url":"https://api.github.com/repos/adiaaida/coreclr/stargazers","contributors_url":"https://api.github.com/repos/adiaaida/coreclr/contributors","subscribers_url":"https://api.github.com/repos/adiaaida/coreclr/subscribers","subscription_url":"https://api.github.com/repos/adiaaida/coreclr/subscription","commits_url":"https://api.github.com/repos/adiaaida/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/adiaaida/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/adiaaida/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/adiaaida/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/adiaaida/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/adiaaida/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adiaaida/coreclr/merges","archive_url":"https://api.github.com/repos/adiaaida/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adiaaida/coreclr/downloads","issues_url":"https://api.github.com/repos/adiaaida/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/adiaaida/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/adiaaida/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/adiaaida/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adiaaida/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/adiaaida/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/adiaaida/coreclr/deployments","created_at":"2015-02-19T23:48:03Z","updated_at":"2016-01-25T21:55:06Z","pushed_at":"2016-07-19T14:35:10Z","git_url":"git://github.com/adiaaida/coreclr.git","ssh_url":"git@github.com:adiaaida/coreclr.git","clone_url":"https://github.com/adiaaida/coreclr.git","svn_url":"https://github.com/adiaaida/coreclr","homepage":"","size":93198,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"b306172d0545e2a292619b880a3c8d07bb46d396","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-07-19T07:13:28Z","pushed_at":"2016-07-19T18:20:00Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://dotnet.github.io/","size":101545,"stargazers_count":6689,"watchers_count":6689,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1548,"mirror_url":null,"open_issues_count":903,"forks":1548,"open_issues":903,"watchers":6689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6219"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6219"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6219"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6219/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6219/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6219/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/201b9c75fa8ae6a21201a20a2593c25346f5e067"}}}}
{"actor":{"display_login":"sivarv"}}