{"push_id":1281244065,"size":4,"distinct_size":4,"ref":"refs/heads/master","head":"b739ce6ddcce15884630bab00621922daa32f341","before":"ae52b462431688e531f34bcffcf62369520b823b","commits":[{"sha":"c2545e25f097698d2983ff3625ae76f13db388d1","author":{"name":"carlosgc@webkit.org","email":"f0d8198c2f2c7571e9504148b3ae623d3bc1c7c7@webkit.org"},"message":"Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.\n\n* BuildSlaveSupport/built-product-archive:\n(archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests\nthat no longer exist.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@205394 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/c2545e25f097698d2983ff3625ae76f13db388d1"},{"sha":"855b35bdf184e6d5c1855a192b5c317ba7345e5f","author":{"name":"carlosgc@webkit.org","email":"f0d8198c2f2c7571e9504148b3ae623d3bc1c7c7@webkit.org"},"message":"[Threaded Compositor] Move the viewport controller off the compositing thread\nhttps://bugs.webkit.org/show_bug.cgi?id=161532\n\nReviewed by Michael Catanzaro.\n\nWhile working on bug #161242 I've realized that having the view port controller in the compositing thread makes\neverything more complex. The viewport controller receives changes about things like contents size, viewport\nsize, etc. and uses that information to compute the visible contents rect and page scale factor. Then it\nnotifies back to main thread about the computed visible contents rect and page scale. Those computations are not\nheave at all, so they could be done in the main thread and we would avoid communications between the main and\ncompositing thread in both directions. The main thread needs the visible contents rect to notify the compositing\ncoordinator and the page cale to scale the page in case of pixed layout. But the compositing thread only needs\nto know the effective scale and scroll position. So, instead of going to the compositing thread after every\nchange that might update the visible contents rect and page scale factor, we could do those calculations in the\nmain thread and only notify the compositing thread about the actual changes in the scroll position and effective scale.\n\n* Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:\n(WebKit::CoordinatedGraphicsScene::createTilesIfNeeded): Return early if backingStore is nullptr, which can\nhappen if the layer shouldn't have a backing store and was removed by the previous call to prepareContentBackingStore().\n(WebKit::CoordinatedGraphicsScene::updateTilesIfNeeded): Ditto.\n* Shared/CoordinatedGraphics/SimpleViewportController.cpp:\n(WebKit::SimpleViewportController::SimpleViewportController): Remove the client since we no longer need to\nnotify about changes.\n(WebKit::SimpleViewportController::didChangeViewportSize): Remove call to syncVisibleContents().\n(WebKit::SimpleViewportController::didChangeContentsSize): Ditto.\n(WebKit::SimpleViewportController::didChangeViewportAttributes): Ditto.\n(WebKit::SimpleViewportController::didScroll): Removed unused scrollBy methods and renamed scrollTo as\ndidiScroll for consistency. Save the position without calling boundContentsPosition, because that's already\ndonde when the position is used to compute the contents visible rectangle.\n(WebKit::SimpleViewportController::visibleContentsRect): No need to notify about the changes.\n(WebKit::SimpleViewportController::visibleContentsSize): Deleted.\n* Shared/CoordinatedGraphics/SimpleViewportController.h:\n* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:\n(WebKit::ThreadedCompositor::create): Pass a reference to the client instead of a pointer. It's no longer\npossible to have a valid pointer when the object has been destroyed, so we can better use a reference now.\n(WebKit::ThreadedCompositor::ThreadedCompositor): Ditto.\n(WebKit::ThreadedCompositor::~ThreadedCompositor): Remove assert.\n(WebKit::ThreadedCompositor::invalidate): No need to invalidate the client.\n(WebKit::ThreadedCompositor::setScaleFactor): Set the effective scale factor that should be used for rendering.\n(WebKit::ThreadedCompositor::setScrollPosition): Set the current scroll position and effective scale factor.\n(WebKit::ThreadedCompositor::setViewportSize): Set the viewport size and effective scale factor.\n(WebKit::ThreadedCompositor::renderNextFrame): Update m_client use that is no longer a pointer.\n(WebKit::ThreadedCompositor::commitScrollOffset): Ditto.\n(WebKit::ThreadedCompositor::renderLayerTree): Call glViewport after a resize and use m_viewportSize,\nm_scrollPosition and m_scaleFactor members.\n(WebKit::ThreadedCompositor::didChangeVisibleRect): Deleted.\n* Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:\n* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:\n(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Pass the compositor client as a\nreference to ThreadedCompositor constructor.\n(WebKit::ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents): Update the viewport and call didChangeViewport().\n(WebKit::ThreadedCoordinatedLayerTreeHost::contentsSizeChanged): Ditto.\n(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged): Pass the effective scale factor to\nthe compositor.\n(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange): Update the viewport, the compositor and call didChangeViewport().\n(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportProperties): Update the viewport and call didChangeViewport().\n(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewport): Notify the compositing coordinator about the new\nvisible contents rectangle, and update the threaded compositor if needed.\n* WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@205395 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/855b35bdf184e6d5c1855a192b5c317ba7345e5f"},{"sha":"3cfd6a83deeef1f1b65e41e123d5e2f480c2dc00","author":{"name":"mmaxfield@apple.com","email":"eb32da43949c574eef76b422382a5964a7838f01@apple.com"},"message":"[Cocoa] Distinguish between paint advances and base advances\nhttps://bugs.webkit.org/show_bug.cgi?id=160892\n\nReviewed by Simon Fraser.\n\nSource/WebCore:\n\nThis patch introduces the concept of a layout (or \"base\") advance which is distinct\nfrom a painting advance. In extremely complicated scripts such as Urdu, it is common\nfor a glyph advance to be negative in the horizontal direction, and have large advances\nin the vertical direction. In particular, in cursive scripts, the glyph placement is\nonly indirectly related to where the actual characters lie. Conceptually, these glyph\nlocations are correct for painting, but are not correct when performing width\nmeasurements.\n\nIn many text engines, glyph shaping actually can be split into two phases: adjusting\nadvances, and then placing glyphs relative to those advances. The secondary glyph\nplacement step is much more context-sensitive than the first step. In addition, when\nmultiple glyphs combine to form a character, it is common for one glyph to own the\nfull base advance for the character, and for the other glyphs in the character to\nhave zero base advances. (Then, in the glyph placement phase, the other glyphs get\nplaced all around.)\n\nBecause of the context-insensitivity of the base advances, it is valuable to use\nthese for text measurement. Then, when we want to paint, we should add in the extra\norigins. This dramatically improves the layout of complex fonts like Noto Nastaliq.\n\nThis patch migrates WebKit to use this two-phase shaping.\n\nNo new tests just yet, because I have to create a font which exercises the\nadvanced glyph placement support.\n\n* platform/graphics/GlyphBuffer.h:\n(WebCore::GlyphBufferAdvance::setHeight):\n(WebCore::GlyphBufferAdvance::setWidth): Deleted.\n* platform/graphics/TextRun.h:\n(WebCore::TextRun::TextRun):\n(WebCore::TextRun::shouldDisableLayoutSpecificAdvances):\n(WebCore::TextRun::setShouldDisableLayoutSpecificAdvances):\n(WebCore::TextRun::spacingDisabled): Deleted.\n(WebCore::TextRun::setCharacterScanForCodePath): Deleted.\n* platform/graphics/cocoa/FontCascadeCocoa.mm:\n(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):\n* platform/graphics/mac/ComplexTextController.cpp:\n(WebCore::ComplexTextController::ComplexTextController):\n(WebCore::ComplexTextController::offsetForPosition):\n(WebCore::ComplexTextController::collectComplexTextRuns):\n(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic):\n(WebCore::ComplexTextController::runWidthSoFarFraction):\n(WebCore::ComplexTextController::advance):\n(WebCore::ComplexTextController::adjustGlyphsAndAdvances):\n* platform/graphics/mac/ComplexTextController.h:\n(WebCore::ComplexTextController::ComplexTextRun::create):\n(WebCore::ComplexTextController::ComplexTextRun::baseAdvances):\n(WebCore::ComplexTextController::ComplexTextRun::glyphOrigins):\n(WebCore::ComplexTextController::useLayoutSpecificAdvances):\n(WebCore::ComplexTextController::finalRoundingWidth): Deleted.\n(WebCore::ComplexTextController::ComplexTextRun::advances): Deleted.\n* platform/graphics/mac/ComplexTextControllerCoreText.mm:\n(SOFT_LINK):\n(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):\n(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):\n* platform/spi/cocoa/CoreTextSPI.h:\n\nLayoutTests:\n\nUpdate tests. There are some expected (small) changes in metrics due to this patch.\n\n* platform/mac-elcapitan/css2.1/t051202-c26-psudo-nest-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.png.\n* platform/mac-elcapitan/css2.1/t051202-c26-psudo-nest-00-c-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.txt.\n* platform/mac-elcapitan/css2.1/t1508-c527-font-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t1508-c527-font-00-b-expected.png.\n* platform/mac-elcapitan/css2.1/t1508-c527-font-00-b-expected.txt: Added.\n* platform/mac-elcapitan/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Copied from LayoutTests/platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png.\n* platform/mac-elcapitan/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Copied from LayoutTests/platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt.\n* platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.png:\n* platform/mac/css2.1/t051202-c26-psudo-nest-00-c-expected.txt:\n* platform/mac/css2.1/t1508-c527-font-00-b-expected.png:\n* platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Added.\n* platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:\n* platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@205396 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/3cfd6a83deeef1f1b65e41e123d5e2f480c2dc00"},{"sha":"b739ce6ddcce15884630bab00621922daa32f341","author":{"name":"mcatanzaro@igalia.com","email":"7b19e692e49d0869d2f7e9dc328e9f48faa0407c@igalia.com"},"message":"[GTK] -Wmissing-field-initializers on WaylandCompositor.cpp:295\nhttps://bugs.webkit.org/show_bug.cgi?id=161524\n\nReviewed by Carlos Garcia Campos.\n\n* UIProcess/gtk/WaylandCompositor.cpp:\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@205397 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/b739ce6ddcce15884630bab00621922daa32f341"}]}
{"actor":{"display_login":"kisg"}}