{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/80083013","id":80083013,"diff_hunk":"@@ -1076,20 +1076,20 @@ namespace Patterns\n  *     ...\n  *     // declaration of entries\n  *     ...\n- *     prm.read_input (cin);         // read input from standard in,\n+ *     prm.parse_input (std::cin); // read input from standard in,\n  *     // or\n- *     prm.read_input (\"simulation.in\");\n+ *     prm.parse_input (\"simulation.in\");","path":"include/deal.II/base/parameter_handler.h","position":17,"original_position":17,"commit_id":"5abda21fb0e949f0ab3eec4b18e4028715529f84","original_commit_id":"5abda21fb0e949f0ab3eec4b18e4028715529f84","user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"body":"can you change this to \"simulation.prm\"?","created_at":"2016-09-22T16:38:19Z","updated_at":"2016-09-22T16:38:19Z","html_url":"https://github.com/dealii/dealii/pull/3122#discussion_r80083013","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/3122","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/80083013"},"html":{"href":"https://github.com/dealii/dealii/pull/3122#discussion_r80083013"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3122"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/3122","id":85509048,"html_url":"https://github.com/dealii/dealii/pull/3122","diff_url":"https://github.com/dealii/dealii/pull/3122.diff","patch_url":"https://github.com/dealii/dealii/pull/3122.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/3122","number":3122,"state":"open","locked":false,"title":"Parameterhandler exceptions","user":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"body":"This PR overhauls our handling of exceptions within `ParameterHandler`: all of its methods now through exceptions instead of using a boolean error code to signify failure.\r\n\r\nOne odd place where this does not quite work is the variant of `read_input` which can optionally save the default parameters to a file upon failure. Several of the tests utilize this feature so I kept it the way it was, even though I think this should really be two different functions.","created_at":"2016-09-16T01:56:24Z","updated_at":"2016-09-22T16:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d98ed3df95bc3929e1a999b8d803a3f0be9bd52","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/3122/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/3122/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/3122/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/5abda21fb0e949f0ab3eec4b18e4028715529f84","head":{"label":"drwells:parameterhandler-exceptions","ref":"parameterhandler-exceptions","sha":"5abda21fb0e949f0ab3eec4b18e4028715529f84","user":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"repo":{"id":28924344,"name":"dealii","full_name":"drwells/dealii","owner":{"login":"drwells","id":3917035,"avatar_url":"https://avatars.githubusercontent.com/u/3917035?v=3","gravatar_id":"","url":"https://api.github.com/users/drwells","html_url":"https://github.com/drwells","followers_url":"https://api.github.com/users/drwells/followers","following_url":"https://api.github.com/users/drwells/following{/other_user}","gists_url":"https://api.github.com/users/drwells/gists{/gist_id}","starred_url":"https://api.github.com/users/drwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drwells/subscriptions","organizations_url":"https://api.github.com/users/drwells/orgs","repos_url":"https://api.github.com/users/drwells/repos","events_url":"https://api.github.com/users/drwells/events{/privacy}","received_events_url":"https://api.github.com/users/drwells/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drwells/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/drwells/dealii","forks_url":"https://api.github.com/repos/drwells/dealii/forks","keys_url":"https://api.github.com/repos/drwells/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drwells/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drwells/dealii/teams","hooks_url":"https://api.github.com/repos/drwells/dealii/hooks","issue_events_url":"https://api.github.com/repos/drwells/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/drwells/dealii/events","assignees_url":"https://api.github.com/repos/drwells/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/drwells/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/drwells/dealii/tags","blobs_url":"https://api.github.com/repos/drwells/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drwells/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drwells/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/drwells/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drwells/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/drwells/dealii/languages","stargazers_url":"https://api.github.com/repos/drwells/dealii/stargazers","contributors_url":"https://api.github.com/repos/drwells/dealii/contributors","subscribers_url":"https://api.github.com/repos/drwells/dealii/subscribers","subscription_url":"https://api.github.com/repos/drwells/dealii/subscription","commits_url":"https://api.github.com/repos/drwells/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/drwells/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/drwells/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/drwells/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/drwells/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/drwells/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drwells/dealii/merges","archive_url":"https://api.github.com/repos/drwells/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drwells/dealii/downloads","issues_url":"https://api.github.com/repos/drwells/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/drwells/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/drwells/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/drwells/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drwells/dealii/labels{/name}","releases_url":"https://api.github.com/repos/drwells/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/drwells/dealii/deployments","created_at":"2015-01-07T17:03:37Z","updated_at":"2016-02-12T16:15:57Z","pushed_at":"2016-09-22T13:58:05Z","git_url":"git://github.com/drwells/dealii.git","ssh_url":"git@github.com:drwells/dealii.git","clone_url":"https://github.com/drwells/dealii.git","svn_url":"https://github.com/drwells/dealii","homepage":"http://www.dealii.org/","size":146772,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"2863c8df4cc3c3f94739bf929292e704a55fdf15","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-09-18T22:50:25Z","pushed_at":"2016-09-22T15:25:36Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":168126,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":184,"forks":185,"open_issues":184,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3122"},"html":{"href":"https://github.com/dealii/dealii/pull/3122"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/3122"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/3122/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3122/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/3122/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/5abda21fb0e949f0ab3eec4b18e4028715529f84"}}}}
{"actor":{"display_login":"tjhei"}}