{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/comments/81689612","pull_request_review_id":2650853,"id":81689612,"diff_hunk":"@@ -0,0 +1,133 @@\n+swagger: '2.0'\n+info:\n+  version: '0.1.0'\n+  title: Device authentication\n+  description: |\n+      An API for device authentication handling. Not exposed via the API Gateway - intended for internal use only.\n+\n+basePath: '/api/0.1.0/'","path":"docs/internal_api.yml","position":8,"original_position":8,"commit_id":"08bd492653aa09e7dfb5569cca02aca3806cd4d5","original_commit_id":"08bd492653aa09e7dfb5569cca02aca3806cd4d5","user":{"login":"marekswiecznik","id":890814,"avatar_url":"https://avatars.githubusercontent.com/u/890814?v=3","gravatar_id":"","url":"https://api.github.com/users/marekswiecznik","html_url":"https://github.com/marekswiecznik","followers_url":"https://api.github.com/users/marekswiecznik/followers","following_url":"https://api.github.com/users/marekswiecznik/following{/other_user}","gists_url":"https://api.github.com/users/marekswiecznik/gists{/gist_id}","starred_url":"https://api.github.com/users/marekswiecznik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekswiecznik/subscriptions","organizations_url":"https://api.github.com/users/marekswiecznik/orgs","repos_url":"https://api.github.com/users/marekswiecznik/repos","events_url":"https://api.github.com/users/marekswiecznik/events{/privacy}","received_events_url":"https://api.github.com/users/marekswiecznik/received_events","type":"User","site_admin":false},"body":"missing 'host' attribute, MEN-664","created_at":"2016-10-04T05:30:54Z","updated_at":"2016-10-04T05:35:29Z","html_url":"https://github.com/mendersoftware/deviceauth/pull/61#discussion_r81689612","pull_request_url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/comments/81689612"},"html":{"href":"https://github.com/mendersoftware/deviceauth/pull/61#discussion_r81689612"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61","id":87779953,"html_url":"https://github.com/mendersoftware/deviceauth/pull/61","diff_url":"https://github.com/mendersoftware/deviceauth/pull/61.diff","patch_url":"https://github.com/mendersoftware/deviceauth/pull/61.patch","issue_url":"https://api.github.com/repos/mendersoftware/deviceauth/issues/61","number":61,"state":"open","locked":false,"title":"docs: api specs edited to match the API spec guide","user":{"login":"mchalski","id":18258178,"avatar_url":"https://avatars.githubusercontent.com/u/18258178?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalski","html_url":"https://github.com/mchalski","followers_url":"https://api.github.com/users/mchalski/followers","following_url":"https://api.github.com/users/mchalski/following{/other_user}","gists_url":"https://api.github.com/users/mchalski/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalski/subscriptions","organizations_url":"https://api.github.com/users/mchalski/orgs","repos_url":"https://api.github.com/users/mchalski/repos","events_url":"https://api.github.com/users/mchalski/events{/privacy}","received_events_url":"https://api.github.com/users/mchalski/received_events","type":"User","site_admin":false},"body":"Note that this is much more than just the layout, below is a changelog of sorts, since the comparison may be difficult even with a diff at hand. \r\n\r\nLayout: \r\n- besides introducing Michael's guidelines - reworded the verbose api description, moved lots of details to where they IMO belong (param/schema descriptions)\r\n\r\nContent:\r\n- removed everything concerning tenant tokens - not supported, not required, could only confuse people\r\n- removed bits about id data encryption - sth for a distant future, currently 100% plain text\r\n- added missing but required 'seq_no' to AuthRequest\r\n- removed the bit about the issued JWT being additionally encrypted with a device's key...IMO it's clearly just a regular token in base64 form\r\n- added missing token standard 'iss' claim\r\n- removed a couple of unimplemented methods\r\n\r\nNew doc type\r\n- it turned out there are methods which don't belong either to 'integrations' or 'devices'; they're only accessible internally in the Docker network (POST /token/verify, PUT /device/{id}/status)\r\n- they were removed from both docs, a 3rd type of doc was introduced to not lose this info\r\n- side effect - 'integrations' doc is empty now, so I removed it\r\n\r\nObserved quirks:\r\n- the returned JWT is 'application/json', but in fact it's a blob of text - could be problematic in the final render\r\n\r\n@maciejmrowiec @michaelatmender @bboozzoo @kjaskiewiczz @marekswiecznik ","created_at":"2016-10-03T19:54:28Z","updated_at":"2016-10-04T05:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"559afcd95305e375f013eb408badfc31b4f9e05b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/deviceauth/issues/61/comments","statuses_url":"https://api.github.com/repos/mendersoftware/deviceauth/statuses/08bd492653aa09e7dfb5569cca02aca3806cd4d5","head":{"label":"mchalski:api_spec_template","ref":"api_spec_template","sha":"08bd492653aa09e7dfb5569cca02aca3806cd4d5","user":{"login":"mchalski","id":18258178,"avatar_url":"https://avatars.githubusercontent.com/u/18258178?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalski","html_url":"https://github.com/mchalski","followers_url":"https://api.github.com/users/mchalski/followers","following_url":"https://api.github.com/users/mchalski/following{/other_user}","gists_url":"https://api.github.com/users/mchalski/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalski/subscriptions","organizations_url":"https://api.github.com/users/mchalski/orgs","repos_url":"https://api.github.com/users/mchalski/repos","events_url":"https://api.github.com/users/mchalski/events{/privacy}","received_events_url":"https://api.github.com/users/mchalski/received_events","type":"User","site_admin":false},"repo":{"id":69662755,"name":"deviceauth","full_name":"mchalski/deviceauth","owner":{"login":"mchalski","id":18258178,"avatar_url":"https://avatars.githubusercontent.com/u/18258178?v=3","gravatar_id":"","url":"https://api.github.com/users/mchalski","html_url":"https://github.com/mchalski","followers_url":"https://api.github.com/users/mchalski/followers","following_url":"https://api.github.com/users/mchalski/following{/other_user}","gists_url":"https://api.github.com/users/mchalski/gists{/gist_id}","starred_url":"https://api.github.com/users/mchalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchalski/subscriptions","organizations_url":"https://api.github.com/users/mchalski/orgs","repos_url":"https://api.github.com/users/mchalski/repos","events_url":"https://api.github.com/users/mchalski/events{/privacy}","received_events_url":"https://api.github.com/users/mchalski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchalski/deviceauth","description":"Mender Device Authentication Service","fork":true,"url":"https://api.github.com/repos/mchalski/deviceauth","forks_url":"https://api.github.com/repos/mchalski/deviceauth/forks","keys_url":"https://api.github.com/repos/mchalski/deviceauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchalski/deviceauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchalski/deviceauth/teams","hooks_url":"https://api.github.com/repos/mchalski/deviceauth/hooks","issue_events_url":"https://api.github.com/repos/mchalski/deviceauth/issues/events{/number}","events_url":"https://api.github.com/repos/mchalski/deviceauth/events","assignees_url":"https://api.github.com/repos/mchalski/deviceauth/assignees{/user}","branches_url":"https://api.github.com/repos/mchalski/deviceauth/branches{/branch}","tags_url":"https://api.github.com/repos/mchalski/deviceauth/tags","blobs_url":"https://api.github.com/repos/mchalski/deviceauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchalski/deviceauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchalski/deviceauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchalski/deviceauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchalski/deviceauth/statuses/{sha}","languages_url":"https://api.github.com/repos/mchalski/deviceauth/languages","stargazers_url":"https://api.github.com/repos/mchalski/deviceauth/stargazers","contributors_url":"https://api.github.com/repos/mchalski/deviceauth/contributors","subscribers_url":"https://api.github.com/repos/mchalski/deviceauth/subscribers","subscription_url":"https://api.github.com/repos/mchalski/deviceauth/subscription","commits_url":"https://api.github.com/repos/mchalski/deviceauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchalski/deviceauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchalski/deviceauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchalski/deviceauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchalski/deviceauth/contents/{+path}","compare_url":"https://api.github.com/repos/mchalski/deviceauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchalski/deviceauth/merges","archive_url":"https://api.github.com/repos/mchalski/deviceauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchalski/deviceauth/downloads","issues_url":"https://api.github.com/repos/mchalski/deviceauth/issues{/number}","pulls_url":"https://api.github.com/repos/mchalski/deviceauth/pulls{/number}","milestones_url":"https://api.github.com/repos/mchalski/deviceauth/milestones{/number}","notifications_url":"https://api.github.com/repos/mchalski/deviceauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchalski/deviceauth/labels{/name}","releases_url":"https://api.github.com/repos/mchalski/deviceauth/releases{/id}","deployments_url":"https://api.github.com/repos/mchalski/deviceauth/deployments","created_at":"2016-09-30T11:53:52Z","updated_at":"2016-09-30T11:53:53Z","pushed_at":"2016-10-03T19:30:32Z","git_url":"git://github.com/mchalski/deviceauth.git","ssh_url":"git@github.com:mchalski/deviceauth.git","clone_url":"https://github.com/mchalski/deviceauth.git","svn_url":"https://github.com/mchalski/deviceauth","homepage":"https://mender.io","size":1185,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"b2b10bac72cae475662faa5df4b60f00367ca909","user":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":56838113,"name":"deviceauth","full_name":"mendersoftware/deviceauth","owner":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendersoftware/deviceauth","description":"Mender Device Authentication Service","fork":false,"url":"https://api.github.com/repos/mendersoftware/deviceauth","forks_url":"https://api.github.com/repos/mendersoftware/deviceauth/forks","keys_url":"https://api.github.com/repos/mendersoftware/deviceauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/deviceauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/deviceauth/teams","hooks_url":"https://api.github.com/repos/mendersoftware/deviceauth/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/deviceauth/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/deviceauth/events","assignees_url":"https://api.github.com/repos/mendersoftware/deviceauth/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/deviceauth/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/deviceauth/tags","blobs_url":"https://api.github.com/repos/mendersoftware/deviceauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/deviceauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/deviceauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/deviceauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/deviceauth/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/deviceauth/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/deviceauth/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/deviceauth/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/deviceauth/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/deviceauth/subscription","commits_url":"https://api.github.com/repos/mendersoftware/deviceauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/deviceauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/deviceauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/deviceauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/deviceauth/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/deviceauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/deviceauth/merges","archive_url":"https://api.github.com/repos/mendersoftware/deviceauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/deviceauth/downloads","issues_url":"https://api.github.com/repos/mendersoftware/deviceauth/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/deviceauth/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/deviceauth/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/deviceauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/deviceauth/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/deviceauth/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/deviceauth/deployments","created_at":"2016-04-22T08:07:38Z","updated_at":"2016-09-26T10:14:58Z","pushed_at":"2016-10-04T05:29:20Z","git_url":"git://github.com/mendersoftware/deviceauth.git","ssh_url":"git@github.com:mendersoftware/deviceauth.git","clone_url":"https://github.com/mendersoftware/deviceauth.git","svn_url":"https://github.com/mendersoftware/deviceauth","homepage":"https://mender.io","size":1202,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61"},"html":{"href":"https://github.com/mendersoftware/deviceauth/pull/61"},"issue":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/issues/61"},"comments":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/deviceauth/statuses/08bd492653aa09e7dfb5569cca02aca3806cd4d5"}}}}
{"actor":{"display_login":"marekswiecznik"}}