{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/81480925","pull_request_review_id":2458331,"id":81480925,"diff_hunk":"@@ -472,10 +488,11 @@ void mapblock_mesh_generate_special(MeshMakeData *data,\n \t\t\t\tfor(u32 j=0; j<4; j++)\n \t\t\t\t{\n \t\t\t\t\tv3s16 neighbordir = cornerdir - halfdirs[j];\n-\t\t\t\t\tcontent_t content = neighbor_contents[neighbordir];\n+\n+\t\t\t\t\tNeighbourData &neighbour_data = neighbour_datas[NeighbourToIndex(neighbordir)];\n+\t\t\t\t\tcontent_t& content = neighbour_data.content;\n \t\t\t\t\t// If top is liquid, draw starting from top of node\n-\t\t\t\t\tif(neighbor_flags[neighbordir] &\n-\t\t\t\t\t\t\tneighborflag_top_is_same_liquid)\n+\t\t\t\t\tif (neighbour_data.flags & neighborflag_top_is_same_liquid)","path":"src/content_mapblock.cpp","position":60,"original_position":60,"commit_id":"9a2d4a24fd35c393f505d82acf3f14ee61417d22","original_commit_id":"9a2d4a24fd35c393f505d82acf3f14ee61417d22","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"To be fair the whole file is full of curly brackets on wrong lines, missing spaces, maybe style cleanup can be another commit?","created_at":"2016-10-02T23:41:33Z","updated_at":"2016-10-02T23:41:33Z","html_url":"https://github.com/minetest/minetest/pull/4544#discussion_r81480925","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/4544","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/81480925"},"html":{"href":"https://github.com/minetest/minetest/pull/4544#discussion_r81480925"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4544"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/4544","id":86535881,"html_url":"https://github.com/minetest/minetest/pull/4544","diff_url":"https://github.com/minetest/minetest/pull/4544.diff","patch_url":"https://github.com/minetest/minetest/pull/4544.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/4544","number":4544,"state":"open","locked":false,"title":"mapblock_mesh_generate_special improvements","user":{"login":"gregorycu","id":1516163,"avatar_url":"https://avatars.githubusercontent.com/u/1516163?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorycu","html_url":"https://github.com/gregorycu","followers_url":"https://api.github.com/users/gregorycu/followers","following_url":"https://api.github.com/users/gregorycu/following{/other_user}","gists_url":"https://api.github.com/users/gregorycu/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorycu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorycu/subscriptions","organizations_url":"https://api.github.com/users/gregorycu/orgs","repos_url":"https://api.github.com/users/gregorycu/repos","events_url":"https://api.github.com/users/gregorycu/events{/privacy}","received_events_url":"https://api.github.com/users/gregorycu/received_events","type":"User","site_admin":false},"body":"Remove uses of std::map\r\nMake sure we use ContentFeatures reference not value\r\n\r\nOn my machine, Windows x64:\r\nThis speeds up mapblock_mesh_generate_special by 35%.\r\nThis function used to represent 24% of UpdateThread's CPU work\r\nAfter these changes, it's down to 14%.\r\nIn real terms, the average call time was 1.1ms. Now it's 0.65ms.","created_at":"2016-09-23T15:46:27Z","updated_at":"2016-10-02T23:41:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf41d5bbaf42e7d5dc8b77a85ad1450a5a2eb070","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/4544/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/4544/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/4544/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/9a2d4a24fd35c393f505d82acf3f14ee61417d22","head":{"label":"gregorycu:SpeedUpUpdateThread","ref":"SpeedUpUpdateThread","sha":"9a2d4a24fd35c393f505d82acf3f14ee61417d22","user":{"login":"gregorycu","id":1516163,"avatar_url":"https://avatars.githubusercontent.com/u/1516163?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorycu","html_url":"https://github.com/gregorycu","followers_url":"https://api.github.com/users/gregorycu/followers","following_url":"https://api.github.com/users/gregorycu/following{/other_user}","gists_url":"https://api.github.com/users/gregorycu/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorycu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorycu/subscriptions","organizations_url":"https://api.github.com/users/gregorycu/orgs","repos_url":"https://api.github.com/users/gregorycu/repos","events_url":"https://api.github.com/users/gregorycu/events{/privacy}","received_events_url":"https://api.github.com/users/gregorycu/received_events","type":"User","site_admin":false},"repo":{"id":29135581,"name":"minetest","full_name":"gregorycu/minetest","owner":{"login":"gregorycu","id":1516163,"avatar_url":"https://avatars.githubusercontent.com/u/1516163?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorycu","html_url":"https://github.com/gregorycu","followers_url":"https://api.github.com/users/gregorycu/followers","following_url":"https://api.github.com/users/gregorycu/following{/other_user}","gists_url":"https://api.github.com/users/gregorycu/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorycu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorycu/subscriptions","organizations_url":"https://api.github.com/users/gregorycu/orgs","repos_url":"https://api.github.com/users/gregorycu/repos","events_url":"https://api.github.com/users/gregorycu/events{/privacy}","received_events_url":"https://api.github.com/users/gregorycu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregorycu/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/gregorycu/minetest","forks_url":"https://api.github.com/repos/gregorycu/minetest/forks","keys_url":"https://api.github.com/repos/gregorycu/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorycu/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorycu/minetest/teams","hooks_url":"https://api.github.com/repos/gregorycu/minetest/hooks","issue_events_url":"https://api.github.com/repos/gregorycu/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/gregorycu/minetest/events","assignees_url":"https://api.github.com/repos/gregorycu/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/gregorycu/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/gregorycu/minetest/tags","blobs_url":"https://api.github.com/repos/gregorycu/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorycu/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorycu/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorycu/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorycu/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorycu/minetest/languages","stargazers_url":"https://api.github.com/repos/gregorycu/minetest/stargazers","contributors_url":"https://api.github.com/repos/gregorycu/minetest/contributors","subscribers_url":"https://api.github.com/repos/gregorycu/minetest/subscribers","subscription_url":"https://api.github.com/repos/gregorycu/minetest/subscription","commits_url":"https://api.github.com/repos/gregorycu/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorycu/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorycu/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorycu/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorycu/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/gregorycu/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorycu/minetest/merges","archive_url":"https://api.github.com/repos/gregorycu/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorycu/minetest/downloads","issues_url":"https://api.github.com/repos/gregorycu/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/gregorycu/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorycu/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorycu/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorycu/minetest/labels{/name}","releases_url":"https://api.github.com/repos/gregorycu/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/gregorycu/minetest/deployments","created_at":"2015-01-12T13:00:30Z","updated_at":"2016-02-28T02:36:39Z","pushed_at":"2016-09-25T15:58:04Z","git_url":"git://github.com/gregorycu/minetest.git","ssh_url":"git@github.com:gregorycu/minetest.git","clone_url":"https://github.com/gregorycu/minetest.git","svn_url":"https://github.com/gregorycu/minetest","homepage":"http://minetest.net/","size":42335,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"33a606c034a6dfea4a011b6d69077455bbb56746","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-10-02T13:57:23Z","pushed_at":"2016-10-02T23:40:09Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":117102,"stargazers_count":2169,"watchers_count":2169,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":677,"mirror_url":null,"open_issues_count":877,"forks":677,"open_issues":877,"watchers":2169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4544"},"html":{"href":"https://github.com/minetest/minetest/pull/4544"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/4544"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/4544/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4544/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4544/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/9a2d4a24fd35c393f505d82acf3f14ee61417d22"}}}}
{"actor":{"display_login":"paramat"}}