{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/comments/55668412","id":55668412,"diff_hunk":"@@ -23,12 +25,12 @@\n   }\n \n   file { '/opt/kafka/config/server.properties':\n+    ensure  => present,","path":"manifests/broker/config.pp","position":22,"original_position":22,"commit_id":"b13a458d8de47d628e53d4e624afc69ef8d10ad7","original_commit_id":"5d6a5821ab92349b9ad06d4e0d2409e5c6b44426","user":{"login":"dhoppe","id":1111056,"avatar_url":"https://avatars.githubusercontent.com/u/1111056?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoppe","html_url":"https://github.com/dhoppe","followers_url":"https://api.github.com/users/dhoppe/followers","following_url":"https://api.github.com/users/dhoppe/following{/other_user}","gists_url":"https://api.github.com/users/dhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoppe/subscriptions","organizations_url":"https://api.github.com/users/dhoppe/orgs","repos_url":"https://api.github.com/users/dhoppe/repos","events_url":"https://api.github.com/users/dhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/dhoppe/received_events","type":"User","site_admin":false},"body":"No that was about the broken class ```mirror```.","created_at":"2016-03-10T11:50:22Z","updated_at":"2016-03-10T11:50:22Z","html_url":"https://github.com/voxpupuli/puppet-kafka/pull/46#discussion_r55668412","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/comments/55668412"},"html":{"href":"https://github.com/voxpupuli/puppet-kafka/pull/46#discussion_r55668412"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46","id":62359223,"html_url":"https://github.com/voxpupuli/puppet-kafka/pull/46","diff_url":"https://github.com/voxpupuli/puppet-kafka/pull/46.diff","patch_url":"https://github.com/voxpupuli/puppet-kafka/pull/46.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46","number":46,"state":"open","locked":false,"title":"Fix classes broker::consumer and broker::producer","user":{"login":"dhoppe","id":1111056,"avatar_url":"https://avatars.githubusercontent.com/u/1111056?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoppe","html_url":"https://github.com/dhoppe","followers_url":"https://api.github.com/users/dhoppe/followers","following_url":"https://api.github.com/users/dhoppe/following{/other_user}","gists_url":"https://api.github.com/users/dhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoppe/subscriptions","organizations_url":"https://api.github.com/users/dhoppe/orgs","repos_url":"https://api.github.com/users/dhoppe/repos","events_url":"https://api.github.com/users/dhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/dhoppe/received_events","type":"User","site_admin":false},"body":"I am writing a couple of beaker tests and came across the following problems:\r\n\r\nThe generated Inits Scripts were broken because of\r\n- missing equal signs\r\n- empty parameters\r\n- obsolete parameters\r\n- some parameters are required\r\n- wrong process names\r\n\r\nThe file resource did not notified the correct service and the config parameters for properties file or Init Script should be managed at the main class. \r\n\r\nI know that this would force a major release, but on the other hand this part of the Kafka module could not have worked before. ","created_at":"2016-03-10T09:13:56Z","updated_at":"2016-03-10T11:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75ab1f7db5bda5eba278f346e7574acde0f84f3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/statuses/b13a458d8de47d628e53d4e624afc69ef8d10ad7","head":{"label":"dhoppe:service","ref":"service","sha":"b13a458d8de47d628e53d4e624afc69ef8d10ad7","user":{"login":"dhoppe","id":1111056,"avatar_url":"https://avatars.githubusercontent.com/u/1111056?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoppe","html_url":"https://github.com/dhoppe","followers_url":"https://api.github.com/users/dhoppe/followers","following_url":"https://api.github.com/users/dhoppe/following{/other_user}","gists_url":"https://api.github.com/users/dhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoppe/subscriptions","organizations_url":"https://api.github.com/users/dhoppe/orgs","repos_url":"https://api.github.com/users/dhoppe/repos","events_url":"https://api.github.com/users/dhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/dhoppe/received_events","type":"User","site_admin":false},"repo":{"id":53417970,"name":"puppet-kafka","full_name":"dhoppe/puppet-kafka","owner":{"login":"dhoppe","id":1111056,"avatar_url":"https://avatars.githubusercontent.com/u/1111056?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoppe","html_url":"https://github.com/dhoppe","followers_url":"https://api.github.com/users/dhoppe/followers","following_url":"https://api.github.com/users/dhoppe/following{/other_user}","gists_url":"https://api.github.com/users/dhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoppe/subscriptions","organizations_url":"https://api.github.com/users/dhoppe/orgs","repos_url":"https://api.github.com/users/dhoppe/repos","events_url":"https://api.github.com/users/dhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/dhoppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhoppe/puppet-kafka","description":"","fork":true,"url":"https://api.github.com/repos/dhoppe/puppet-kafka","forks_url":"https://api.github.com/repos/dhoppe/puppet-kafka/forks","keys_url":"https://api.github.com/repos/dhoppe/puppet-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhoppe/puppet-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhoppe/puppet-kafka/teams","hooks_url":"https://api.github.com/repos/dhoppe/puppet-kafka/hooks","issue_events_url":"https://api.github.com/repos/dhoppe/puppet-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/dhoppe/puppet-kafka/events","assignees_url":"https://api.github.com/repos/dhoppe/puppet-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/dhoppe/puppet-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/dhoppe/puppet-kafka/tags","blobs_url":"https://api.github.com/repos/dhoppe/puppet-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhoppe/puppet-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhoppe/puppet-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhoppe/puppet-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhoppe/puppet-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/dhoppe/puppet-kafka/languages","stargazers_url":"https://api.github.com/repos/dhoppe/puppet-kafka/stargazers","contributors_url":"https://api.github.com/repos/dhoppe/puppet-kafka/contributors","subscribers_url":"https://api.github.com/repos/dhoppe/puppet-kafka/subscribers","subscription_url":"https://api.github.com/repos/dhoppe/puppet-kafka/subscription","commits_url":"https://api.github.com/repos/dhoppe/puppet-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhoppe/puppet-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhoppe/puppet-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhoppe/puppet-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhoppe/puppet-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/dhoppe/puppet-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhoppe/puppet-kafka/merges","archive_url":"https://api.github.com/repos/dhoppe/puppet-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhoppe/puppet-kafka/downloads","issues_url":"https://api.github.com/repos/dhoppe/puppet-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/dhoppe/puppet-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/dhoppe/puppet-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/dhoppe/puppet-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhoppe/puppet-kafka/labels{/name}","releases_url":"https://api.github.com/repos/dhoppe/puppet-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/dhoppe/puppet-kafka/deployments","created_at":"2016-03-08T14:20:47Z","updated_at":"2016-03-08T14:20:48Z","pushed_at":"2016-03-10T11:49:26Z","git_url":"git://github.com/dhoppe/puppet-kafka.git","ssh_url":"git@github.com:dhoppe/puppet-kafka.git","clone_url":"https://github.com/dhoppe/puppet-kafka.git","svn_url":"https://github.com/dhoppe/puppet-kafka","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"9b91ca14fb69346d7257d3dcc6549b1b0227e238","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":20067379,"name":"puppet-kafka","full_name":"voxpupuli/puppet-kafka","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-kafka","description":"The kafka module for managing the installation and configuration of Apache Kafka","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-kafka","forks_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/deployments","created_at":"2014-05-22T15:57:31Z","updated_at":"2016-03-08T15:14:16Z","pushed_at":"2016-03-10T11:49:27Z","git_url":"git://github.com/voxpupuli/puppet-kafka.git","ssh_url":"git@github.com:voxpupuli/puppet-kafka.git","clone_url":"https://github.com/voxpupuli/puppet-kafka.git","svn_url":"https://github.com/voxpupuli/puppet-kafka","homepage":"https://forge.puppetlabs.com/puppet/kafka","size":170,"stargazers_count":13,"watchers_count":13,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":10,"forks":33,"open_issues":10,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46"},"html":{"href":"https://github.com/voxpupuli/puppet-kafka/pull/46"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-kafka/statuses/b13a458d8de47d628e53d4e624afc69ef8d10ad7"}}}}