{"action":"created","issue":{"url":"https://api.github.com/repos/Terasology/StructureTemplates/issues/1","repository_url":"https://api.github.com/repos/Terasology/StructureTemplates","labels_url":"https://api.github.com/repos/Terasology/StructureTemplates/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Terasology/StructureTemplates/issues/1/comments","events_url":"https://api.github.com/repos/Terasology/StructureTemplates/issues/1/events","html_url":"https://github.com/Terasology/StructureTemplates/pull/1","id":166798766,"number":1,"title":"getBoundingBox method for SpawnBlockRegion and a simple testcase","user":{"login":"CptCrispyCrunchy","id":11363229,"avatar_url":"https://avatars.githubusercontent.com/u/11363229?v=3","gravatar_id":"","url":"https://api.github.com/users/CptCrispyCrunchy","html_url":"https://github.com/CptCrispyCrunchy","followers_url":"https://api.github.com/users/CptCrispyCrunchy/followers","following_url":"https://api.github.com/users/CptCrispyCrunchy/following{/other_user}","gists_url":"https://api.github.com/users/CptCrispyCrunchy/gists{/gist_id}","starred_url":"https://api.github.com/users/CptCrispyCrunchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptCrispyCrunchy/subscriptions","organizations_url":"https://api.github.com/users/CptCrispyCrunchy/orgs","repos_url":"https://api.github.com/users/CptCrispyCrunchy/repos","events_url":"https://api.github.com/users/CptCrispyCrunchy/events{/privacy}","received_events_url":"https://api.github.com/users/CptCrispyCrunchy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-21T11:39:09Z","updated_at":"2016-07-28T01:44:21Z","closed_at":"2016-07-27T22:46:55Z","pull_request":{"url":"https://api.github.com/repos/Terasology/StructureTemplates/pulls/1","html_url":"https://github.com/Terasology/StructureTemplates/pull/1","diff_url":"https://github.com/Terasology/StructureTemplates/pull/1.diff","patch_url":"https://github.com/Terasology/StructureTemplates/pull/1.patch"},"body":"Needed for DynamicCities and figured it may be useful for more applications."},"comment":{"url":"https://api.github.com/repos/Terasology/StructureTemplates/issues/comments/235773492","html_url":"https://github.com/Terasology/StructureTemplates/pull/1#issuecomment-235773492","issue_url":"https://api.github.com/repos/Terasology/StructureTemplates/issues/1","id":235773492,"user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T01:44:21Z","updated_at":"2016-07-28T01:44:21Z","body":"Yep Components should never contain code. The next version of the entity system will likely make that entirely impossible even. @Josharias went down a similar path some time ago and eventually started refactoring it out again but it took way more effort to fix it later.\r\n\r\nIn this case the switch should still be easy as `getBoundingBox` could simply be moved to a utility class somewhere - static method on `Region3i` ? That also makes it available to other uses :-)"}}
{"actor":{"display_login":"Cervator"}}