{"action":"created","issue":{"url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/159","repository_url":"https://api.github.com/repos/ArcticaProject/nx-libs","labels_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/159/labels{/name}","comments_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/159/comments","events_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/159/events","html_url":"https://github.com/ArcticaProject/nx-libs/pull/159","id":162423758,"number":159,"title":"Backport X.org memory handling","user":{"login":"sunweaver","id":407231,"avatar_url":"https://avatars.githubusercontent.com/u/407231?v=3","gravatar_id":"","url":"https://api.github.com/users/sunweaver","html_url":"https://github.com/sunweaver","followers_url":"https://api.github.com/users/sunweaver/followers","following_url":"https://api.github.com/users/sunweaver/following{/other_user}","gists_url":"https://api.github.com/users/sunweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/sunweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunweaver/subscriptions","organizations_url":"https://api.github.com/users/sunweaver/orgs","repos_url":"https://api.github.com/users/sunweaver/repos","events_url":"https://api.github.com/users/sunweaver/events{/privacy}","received_events_url":"https://api.github.com/users/sunweaver/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ArcticaProject/nx-libs/labels/backport","name":"backport","color":"e99695"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ArcticaProject/nx-libs/milestones/1","html_url":"https://github.com/ArcticaProject/nx-libs/milestones/3.6.0.x","labels_url":"https://api.github.com/repos/ArcticaProject/nx-libs/milestones/1/labels","id":1113295,"number":1,"title":"3.6.0.x","description":"Release goals for 3.6.0.x:\r\n\r\n* CVE security audit (complete)\r\n* remove unused code (work in progress)\r\n* no bundled non-X11 libraries anymore (complete)\r\n* complete imake cleanup (work in progress)\r\n* replace as many libNX_X* libraries by X.org's libX* libraries (work in progress)\r\n* support for iOS (nxproxy, complete)\r\n* Unix file socket communication for nxproxy -C <-> nxproxy -S connections (todo)\r\n* allow Unix file sockets as channel endpoints (work in progress)\r\n* allow embedding of nxproxy into other windows (work in progress)\r\n* new RandR based Xinerama extension (+/- complete, more QA needed)\r\n* Fix Xcomposite extension in Xserver (todo)\r\n* Rename project to Xccc or similar (todo, to be discussed)\r\n* KDE5 support: Add minimal XInput2 support, patch KDE5, or similar (todo)\r\n* nxcomp protocol clean-up (todo)\r\n* nxcomp logging clean-up (todo)\r\n* optimizing documentation: how to tune NX connections (todo)\r\n","creator":{"login":"sunweaver","id":407231,"avatar_url":"https://avatars.githubusercontent.com/u/407231?v=3","gravatar_id":"","url":"https://api.github.com/users/sunweaver","html_url":"https://github.com/sunweaver","followers_url":"https://api.github.com/users/sunweaver/followers","following_url":"https://api.github.com/users/sunweaver/following{/other_user}","gists_url":"https://api.github.com/users/sunweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/sunweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunweaver/subscriptions","organizations_url":"https://api.github.com/users/sunweaver/orgs","repos_url":"https://api.github.com/users/sunweaver/repos","events_url":"https://api.github.com/users/sunweaver/events{/privacy}","received_events_url":"https://api.github.com/users/sunweaver/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":84,"state":"open","created_at":"2015-05-16T13:20:30Z","updated_at":"2016-07-02T11:55:18Z","due_on":"2016-06-29T22:00:00Z","closed_at":null},"comments":4,"created_at":"2016-06-27T10:47:17Z","updated_at":"2016-07-02T12:10:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ArcticaProject/nx-libs/pulls/159","html_url":"https://github.com/ArcticaProject/nx-libs/pull/159","diff_url":"https://github.com/ArcticaProject/nx-libs/pull/159.diff","patch_url":"https://github.com/ArcticaProject/nx-libs/pull/159.patch"},"body":"This PR backports memory handling changes from X.org. This PR basically backports three major commits from X.org's Xserver:\r\n\r\n```\r\n     commit cad9b053d52f62432dfd70e42e0240de77027cae\r\n     Author: Adam Jackson <ajax@redhat.com>\r\n     Date:   Tue Jul 8 13:24:25 2014 -0400\r\n    \r\n        os: Remove deprecated malloc/free wrappers\r\n    \r\n        Reviewed-by: Alex Deucher <alexander.deucher@amd.com>\r\n        Signed-off-by: Adam Jackson <ajax@redhat.com>\r\n    \r\n     commit e983848ab44b0769f97f6207f1aa8b4f127be6a9\r\n     Author: Mikhail Gusarov <dottedmag@dottedmag.net>\r\n     Date:   Thu May 6 00:16:24 2010 +0700\r\n    \r\n        Clean {X,XNF}{alloc,calloc,realloc,free,strdup} from pre-C89 baggage\r\n    \r\n        C89 guarantees alignment of pointers returned from malloc/calloc/realloc, so\r\n        stop fiddling with alignment manually and just pass the arguments to library\r\n        functions.\r\n    \r\n        Also convert silent error when negative size is passed into function into\r\n        warning in log file.\r\n    \r\n        Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>\r\n        Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>\r\n\r\ncommit 3f3ff971ecff9936cebafc813af9193b97bba89c\r\nAuthor: Mikhail Gusarov <dottedmag@dottedmag.net>\r\nDate:   Thu May 6 01:44:06 2010 +0700\r\n\r\n    Replace X-allocation functions with their C89 counterparts\r\n\r\n    The only remaining X-functions used in server are XNF*, the rest is converted to\r\n    plain alloc/calloc/realloc/free/strdup.\r\n\r\n    X* functions are still exported from server and x* macros are still defined in\r\n    header file, so both ABI and API are not affected by this change.\r\n\r\n    Signed-off-by: Mikhail Gusarov <dottedmag@dottedmag.net>\r\n    Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/comments/230098803","html_url":"https://github.com/ArcticaProject/nx-libs/pull/159#issuecomment-230098803","issue_url":"https://api.github.com/repos/ArcticaProject/nx-libs/issues/159","id":230098803,"user":{"login":"sunweaver","id":407231,"avatar_url":"https://avatars.githubusercontent.com/u/407231?v=3","gravatar_id":"","url":"https://api.github.com/users/sunweaver","html_url":"https://github.com/sunweaver","followers_url":"https://api.github.com/users/sunweaver/followers","following_url":"https://api.github.com/users/sunweaver/following{/other_user}","gists_url":"https://api.github.com/users/sunweaver/gists{/gist_id}","starred_url":"https://api.github.com/users/sunweaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunweaver/subscriptions","organizations_url":"https://api.github.com/users/sunweaver/orgs","repos_url":"https://api.github.com/users/sunweaver/repos","events_url":"https://api.github.com/users/sunweaver/events{/privacy}","received_events_url":"https://api.github.com/users/sunweaver/received_events","type":"User","site_admin":false},"created_at":"2016-07-02T12:10:41Z","updated_at":"2016-07-02T12:10:41Z","body":"> Won't this x*alloc stuff complicate upgrading the code? I agree with this cleanup in principle but is this the \r\n> right time for that?\r\n\r\n@uli42: I think it is the right time. Actually, I would love to have the code tree as similar to X.org as possilble, so that we can pick code parts from X.org directly and that the diff between X.org and nx-X11's Xserver is as minimal as possible.\r\n\r\nAlso, stuff like ABI changes or coding style should be changed before a major release. So that package maintainers can cherry-pick patches more easily. If we change the coding style (which is on my list, actually) after a release, then backporting patches is a hard endeavour.\r\n"}}
{"actor":{"display_login":"sunweaver"}}