{"action":"closed","number":952,"pull_request":{"url":"https://api.github.com/repos/apache/thrift/pulls/952","id":63080505,"html_url":"https://github.com/apache/thrift/pull/952","diff_url":"https://github.com/apache/thrift/pull/952.diff","patch_url":"https://github.com/apache/thrift/pull/952.patch","issue_url":"https://api.github.com/repos/apache/thrift/issues/952","number":952,"state":"closed","locked":false,"title":"THRIFT-3746 JSON protocol left in incorrect state on read errors","user":{"login":"tylertreat-wf","id":2872232,"avatar_url":"https://avatars.githubusercontent.com/u/2872232?v=3","gravatar_id":"","url":"https://api.github.com/users/tylertreat-wf","html_url":"https://github.com/tylertreat-wf","followers_url":"https://api.github.com/users/tylertreat-wf/followers","following_url":"https://api.github.com/users/tylertreat-wf/following{/other_user}","gists_url":"https://api.github.com/users/tylertreat-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertreat-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertreat-wf/subscriptions","organizations_url":"https://api.github.com/users/tylertreat-wf/orgs","repos_url":"https://api.github.com/users/tylertreat-wf/repos","events_url":"https://api.github.com/users/tylertreat-wf/events{/privacy}","received_events_url":"https://api.github.com/users/tylertreat-wf/received_events","type":"User","site_admin":false},"body":"This is related to THRIFT-3735, but the problem was not fully addressed\r\nthere. The JSON protocol's read buffer needs to be reset to avoid being\r\nput in an invalid state on read errors.\r\n\r\nThis also changes how the writer is reset to match what we do with the\r\nreader for consistency.\r\n\r\n@markerickson-wf @stevenosborne-wf","created_at":"2016-03-16T15:10:14Z","updated_at":"2016-03-18T14:48:44Z","closed_at":"2016-03-18T14:48:44Z","merged_at":null,"merge_commit_sha":"384fd615b91d72d00d5b9f361f6f5c4fab32aabc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/thrift/pulls/952/commits","review_comments_url":"https://api.github.com/repos/apache/thrift/pulls/952/comments","review_comment_url":"https://api.github.com/repos/apache/thrift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/thrift/issues/952/comments","statuses_url":"https://api.github.com/repos/apache/thrift/statuses/7503e55f5cc3ed65e80cf0df1da9e76ba900e103","head":{"label":"tylertreat-wf:THRIFT-3746","ref":"THRIFT-3746","sha":"7503e55f5cc3ed65e80cf0df1da9e76ba900e103","user":{"login":"tylertreat-wf","id":2872232,"avatar_url":"https://avatars.githubusercontent.com/u/2872232?v=3","gravatar_id":"","url":"https://api.github.com/users/tylertreat-wf","html_url":"https://github.com/tylertreat-wf","followers_url":"https://api.github.com/users/tylertreat-wf/followers","following_url":"https://api.github.com/users/tylertreat-wf/following{/other_user}","gists_url":"https://api.github.com/users/tylertreat-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertreat-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertreat-wf/subscriptions","organizations_url":"https://api.github.com/users/tylertreat-wf/orgs","repos_url":"https://api.github.com/users/tylertreat-wf/repos","events_url":"https://api.github.com/users/tylertreat-wf/events{/privacy}","received_events_url":"https://api.github.com/users/tylertreat-wf/received_events","type":"User","site_admin":false},"repo":{"id":46579931,"name":"thrift","full_name":"tylertreat-wf/thrift","owner":{"login":"tylertreat-wf","id":2872232,"avatar_url":"https://avatars.githubusercontent.com/u/2872232?v=3","gravatar_id":"","url":"https://api.github.com/users/tylertreat-wf","html_url":"https://github.com/tylertreat-wf","followers_url":"https://api.github.com/users/tylertreat-wf/followers","following_url":"https://api.github.com/users/tylertreat-wf/following{/other_user}","gists_url":"https://api.github.com/users/tylertreat-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertreat-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertreat-wf/subscriptions","organizations_url":"https://api.github.com/users/tylertreat-wf/orgs","repos_url":"https://api.github.com/users/tylertreat-wf/repos","events_url":"https://api.github.com/users/tylertreat-wf/events{/privacy}","received_events_url":"https://api.github.com/users/tylertreat-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tylertreat-wf/thrift","description":"Mirror of Apache Thrift","fork":true,"url":"https://api.github.com/repos/tylertreat-wf/thrift","forks_url":"https://api.github.com/repos/tylertreat-wf/thrift/forks","keys_url":"https://api.github.com/repos/tylertreat-wf/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylertreat-wf/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylertreat-wf/thrift/teams","hooks_url":"https://api.github.com/repos/tylertreat-wf/thrift/hooks","issue_events_url":"https://api.github.com/repos/tylertreat-wf/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/tylertreat-wf/thrift/events","assignees_url":"https://api.github.com/repos/tylertreat-wf/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/tylertreat-wf/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/tylertreat-wf/thrift/tags","blobs_url":"https://api.github.com/repos/tylertreat-wf/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylertreat-wf/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylertreat-wf/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylertreat-wf/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylertreat-wf/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/tylertreat-wf/thrift/languages","stargazers_url":"https://api.github.com/repos/tylertreat-wf/thrift/stargazers","contributors_url":"https://api.github.com/repos/tylertreat-wf/thrift/contributors","subscribers_url":"https://api.github.com/repos/tylertreat-wf/thrift/subscribers","subscription_url":"https://api.github.com/repos/tylertreat-wf/thrift/subscription","commits_url":"https://api.github.com/repos/tylertreat-wf/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylertreat-wf/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylertreat-wf/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylertreat-wf/thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylertreat-wf/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/tylertreat-wf/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylertreat-wf/thrift/merges","archive_url":"https://api.github.com/repos/tylertreat-wf/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylertreat-wf/thrift/downloads","issues_url":"https://api.github.com/repos/tylertreat-wf/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/tylertreat-wf/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/tylertreat-wf/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/tylertreat-wf/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylertreat-wf/thrift/labels{/name}","releases_url":"https://api.github.com/repos/tylertreat-wf/thrift/releases{/id}","deployments_url":"https://api.github.com/repos/tylertreat-wf/thrift/deployments","created_at":"2015-11-20T18:39:26Z","updated_at":"2016-03-14T18:12:26Z","pushed_at":"2016-03-16T15:08:50Z","git_url":"git://github.com/tylertreat-wf/thrift.git","ssh_url":"git@github.com:tylertreat-wf/thrift.git","clone_url":"https://github.com/tylertreat-wf/thrift.git","svn_url":"https://github.com/tylertreat-wf/thrift","homepage":"","size":16741,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1d20a370d25b7154104289bb337ab4375edf19b9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":310611,"name":"thrift","full_name":"apache/thrift","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/thrift","description":"Mirror of Apache Thrift","fork":false,"url":"https://api.github.com/repos/apache/thrift","forks_url":"https://api.github.com/repos/apache/thrift/forks","keys_url":"https://api.github.com/repos/apache/thrift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/thrift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/thrift/teams","hooks_url":"https://api.github.com/repos/apache/thrift/hooks","issue_events_url":"https://api.github.com/repos/apache/thrift/issues/events{/number}","events_url":"https://api.github.com/repos/apache/thrift/events","assignees_url":"https://api.github.com/repos/apache/thrift/assignees{/user}","branches_url":"https://api.github.com/repos/apache/thrift/branches{/branch}","tags_url":"https://api.github.com/repos/apache/thrift/tags","blobs_url":"https://api.github.com/repos/apache/thrift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/thrift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/thrift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/thrift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/thrift/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/thrift/languages","stargazers_url":"https://api.github.com/repos/apache/thrift/stargazers","contributors_url":"https://api.github.com/repos/apache/thrift/contributors","subscribers_url":"https://api.github.com/repos/apache/thrift/subscribers","subscription_url":"https://api.github.com/repos/apache/thrift/subscription","commits_url":"https://api.github.com/repos/apache/thrift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/thrift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/thrift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/thrift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/thrift/contents/{+path}","compare_url":"https://api.github.com/repos/apache/thrift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/thrift/merges","archive_url":"https://api.github.com/repos/apache/thrift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/thrift/downloads","issues_url":"https://api.github.com/repos/apache/thrift/issues{/number}","pulls_url":"https://api.github.com/repos/apache/thrift/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/thrift/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/thrift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/thrift/labels{/name}","releases_url":"https://api.github.com/repos/apache/thrift/releases{/id}","deployments_url":"https://api.github.com/repos/apache/thrift/deployments","created_at":"2009-09-18T08:00:17Z","updated_at":"2016-03-17T09:51:35Z","pushed_at":"2016-03-18T14:48:36Z","git_url":"git://github.com/apache/thrift.git","ssh_url":"git@github.com:apache/thrift.git","clone_url":"https://github.com/apache/thrift.git","svn_url":"https://github.com/apache/thrift","homepage":"","size":23008,"stargazers_count":2446,"watchers_count":2446,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1473,"mirror_url":"git://git.apache.org/thrift.git","open_issues_count":80,"forks":1473,"open_issues":80,"watchers":2446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/thrift/pulls/952"},"html":{"href":"https://github.com/apache/thrift/pull/952"},"issue":{"href":"https://api.github.com/repos/apache/thrift/issues/952"},"comments":{"href":"https://api.github.com/repos/apache/thrift/issues/952/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/thrift/pulls/952/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/thrift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/thrift/pulls/952/commits"},"statuses":{"href":"https://api.github.com/repos/apache/thrift/statuses/7503e55f5cc3ed65e80cf0df1da9e76ba900e103"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":18,"deletions":24,"changed_files":2}}