{"action":"created","comment":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/comments/49938872","id":49938872,"diff_hunk":"@@ -14,7 +14,7 @@ class Extended_PostInit_EventHandlers {\n class Extended_FiredBIS_EventHandlers {\n     class CAManBase {\n         class ADDON {\n-            firedBIS = QUOTE(if (local (_this select 0)) then {_this call FUNC(firedEHBB);};);\n+            clientFiredBIS = QUOTE(_this call FUNC(firedEHBB););","path":"addons/overpressure/CfgEventHandlers.hpp","position":null,"original_position":5,"commit_id":"893c6658a52610b7d7da41cb5c0f6bf32caa55b0","original_commit_id":"a875d6a87058e52229856b497d895ec050b86dc1","user":{"login":"PabstMirror","id":9376747,"avatar_url":"https://avatars.githubusercontent.com/u/9376747?v=3","gravatar_id":"","url":"https://api.github.com/users/PabstMirror","html_url":"https://github.com/PabstMirror","followers_url":"https://api.github.com/users/PabstMirror/followers","following_url":"https://api.github.com/users/PabstMirror/following{/other_user}","gists_url":"https://api.github.com/users/PabstMirror/gists{/gist_id}","starred_url":"https://api.github.com/users/PabstMirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PabstMirror/subscriptions","organizations_url":"https://api.github.com/users/PabstMirror/orgs","repos_url":"https://api.github.com/users/PabstMirror/repos","events_url":"https://api.github.com/users/PabstMirror/events{/privacy}","received_events_url":"https://api.github.com/users/PabstMirror/received_events","type":"User","site_admin":false},"body":"I switched the `if !([_firer] call EFUNC(common,isPlayer)) exitWith {};` in fireLauncherBackblast\r\nto `_firer != ACE_player` in firedEHBB  \r\n(because local + isPlayer could only ever be `ace_player`... I think?)\r\n\r\nIn testing re-adding the local check in the EH is slightly faster than always doing the params and `_firer != ACE_player` check when non players are shooting, so I will leave as it was.","created_at":"2016-01-16T23:40:53Z","updated_at":"2016-01-16T23:40:53Z","html_url":"https://github.com/acemod/ACE3/pull/3172#discussion_r49938872","pull_request_url":"https://api.github.com/repos/acemod/ACE3/pulls/3172","_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments/49938872"},"html":{"href":"https://github.com/acemod/ACE3/pull/3172#discussion_r49938872"},"pull_request":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3172"}}},"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/3172","id":56264256,"html_url":"https://github.com/acemod/ACE3/pull/3172","diff_url":"https://github.com/acemod/ACE3/pull/3172.diff","patch_url":"https://github.com/acemod/ACE3/pull/3172.patch","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/3172","number":3172,"state":"open","locked":false,"title":"Overpressure cleanup and fix distance check","user":{"login":"PabstMirror","id":9376747,"avatar_url":"https://avatars.githubusercontent.com/u/9376747?v=3","gravatar_id":"","url":"https://api.github.com/users/PabstMirror","html_url":"https://github.com/PabstMirror","followers_url":"https://api.github.com/users/PabstMirror/followers","following_url":"https://api.github.com/users/PabstMirror/following{/other_user}","gists_url":"https://api.github.com/users/PabstMirror/gists{/gist_id}","starred_url":"https://api.github.com/users/PabstMirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PabstMirror/subscriptions","organizations_url":"https://api.github.com/users/PabstMirror/orgs","repos_url":"https://api.github.com/users/PabstMirror/repos","events_url":"https://api.github.com/users/PabstMirror/events{/privacy}","received_events_url":"https://api.github.com/users/PabstMirror/received_events","type":"User","site_admin":false},"body":" - Cleanup, headers, modern privates\r\n - Fix #3156 (`lineIntersectsSurfaces` did not filter ffv shooter)\r\n - Added both a3 tank weapons, I am unsure why there were not already added.","created_at":"2016-01-16T22:04:23Z","updated_at":"2016-01-16T23:40:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9764c48fc9f4f50da4afff97781902192f5426fc","assignee":null,"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/13","html_url":"https://github.com/acemod/ACE3/milestones/3.5.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/13/labels","id":1433522,"number":13,"title":"3.5.0","description":"Version 3.5.0","creator":{"login":"Glowbal","id":5007509,"avatar_url":"https://avatars.githubusercontent.com/u/5007509?v=3","gravatar_id":"","url":"https://api.github.com/users/Glowbal","html_url":"https://github.com/Glowbal","followers_url":"https://api.github.com/users/Glowbal/followers","following_url":"https://api.github.com/users/Glowbal/following{/other_user}","gists_url":"https://api.github.com/users/Glowbal/gists{/gist_id}","starred_url":"https://api.github.com/users/Glowbal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glowbal/subscriptions","organizations_url":"https://api.github.com/users/Glowbal/orgs","repos_url":"https://api.github.com/users/Glowbal/repos","events_url":"https://api.github.com/users/Glowbal/events{/privacy}","received_events_url":"https://api.github.com/users/Glowbal/received_events","type":"User","site_admin":false},"open_issues":115,"closed_issues":14,"state":"open","created_at":"2015-11-28T19:44:20Z","updated_at":"2016-01-16T22:04:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/acemod/ACE3/pulls/3172/commits","review_comments_url":"https://api.github.com/repos/acemod/ACE3/pulls/3172/comments","review_comment_url":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/3172/comments","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/893c6658a52610b7d7da41cb5c0f6bf32caa55b0","head":{"label":"acemod:overpressureCleanup","ref":"overpressureCleanup","sha":"893c6658a52610b7d7da41cb5c0f6bf32caa55b0","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","created_at":"2015-01-10T19:59:12Z","updated_at":"2016-01-16T16:06:17Z","pushed_at":"2016-01-16T23:30:05Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"http://ace3mod.com/","size":384437,"stargazers_count":349,"watchers_count":349,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":283,"mirror_url":null,"open_issues_count":312,"forks":283,"open_issues":312,"watchers":349,"default_branch":"master"}},"base":{"label":"acemod:master","ref":"master","sha":"c8c91d2af755b32588a92225a84b50282c88409d","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","created_at":"2015-01-10T19:59:12Z","updated_at":"2016-01-16T16:06:17Z","pushed_at":"2016-01-16T23:30:05Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"http://ace3mod.com/","size":384437,"stargazers_count":349,"watchers_count":349,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":283,"mirror_url":null,"open_issues_count":312,"forks":283,"open_issues":312,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3172"},"html":{"href":"https://github.com/acemod/ACE3/pull/3172"},"issue":{"href":"https://api.github.com/repos/acemod/ACE3/issues/3172"},"comments":{"href":"https://api.github.com/repos/acemod/ACE3/issues/3172/comments"},"review_comments":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3172/comments"},"review_comment":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/3172/commits"},"statuses":{"href":"https://api.github.com/repos/acemod/ACE3/statuses/893c6658a52610b7d7da41cb5c0f6bf32caa55b0"}}}}