{"action":"created","issue":{"url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/issues/15","repository_url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester","labels_url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/issues/15/comments","events_url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/issues/15/events","html_url":"https://github.com/JDGrimes/wp-plugin-uninstall-tester/issues/15","id":167202410,"number":15,"title":"If a `system()` call fails, exit early with code 1","user":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-23T20:39:20Z","updated_at":"2016-07-23T21:22:20Z","closed_at":null,"body":"When the installation and usage simulation is performed remotely, there is the possibility that a PHP error will occur. When this happens, we will be oblivious to it, and will keep right on with the rest of the test. Instead, we ought to catch such errors by passing the [second parameter to `system()`](https://secure.php.net/manual/en/function.system.php), which is set to the exit code by reference. Then if we get a failure code we should bail and exit the tests with code 1."},"comment":{"url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/issues/comments/234741195","html_url":"https://github.com/JDGrimes/wp-plugin-uninstall-tester/issues/15#issuecomment-234741195","issue_url":"https://api.github.com/repos/JDGrimes/wp-plugin-uninstall-tester/issues/15","id":234741195,"user":{"login":"JDGrimes","id":4005415,"avatar_url":"https://avatars.githubusercontent.com/u/4005415?v=3","gravatar_id":"","url":"https://api.github.com/users/JDGrimes","html_url":"https://github.com/JDGrimes","followers_url":"https://api.github.com/users/JDGrimes/followers","following_url":"https://api.github.com/users/JDGrimes/following{/other_user}","gists_url":"https://api.github.com/users/JDGrimes/gists{/gist_id}","starred_url":"https://api.github.com/users/JDGrimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDGrimes/subscriptions","organizations_url":"https://api.github.com/users/JDGrimes/orgs","repos_url":"https://api.github.com/users/JDGrimes/repos","events_url":"https://api.github.com/users/JDGrimes/events{/privacy}","received_events_url":"https://api.github.com/users/JDGrimes/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T21:22:20Z","updated_at":"2016-07-23T21:22:20Z","body":"Or better yet, we could be more graceful and just call `$this->fail()`. I hadn't even thought of that. Actually, I'm not sure why we don't just do that in the places where we currently call `exit`."}}
{"actor":{"display_login":"JDGrimes"}}