{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/69350330","id":69350330,"diff_hunk":"@@ -74,12 +74,25 @@ image stream definitions] for all the provided {product-title} images.\n The PHP image supports a number of environment variables which can be set to\n control the configuration and behavior of the PHP runtime.\n \n-To set these environment variables, you can place them into\n+To set these environment variables as part of your image, you can place them into\n xref:../../dev_guide/builds.adoc#environment-files[a *_.s2i/environment_* file]\n inside your source code repository, or define them in\n xref:../../dev_guide/builds.adoc#buildconfig-environment[the environment\n section] of the build configuration's `*sourceStrategy*` definition.\n \n+You can also set environment variables to be used with an existing image when","path":"using_images/s2i_images/php.adoc","position":11,"original_position":11,"commit_id":"4f12d8f156d23bff7bc93f4be862b9dbe42197ec","original_commit_id":"4f12d8f156d23bff7bc93f4be862b9dbe42197ec","user":{"login":"ahardin-rh","id":16197393,"avatar_url":"https://avatars.githubusercontent.com/u/16197393?v=3","gravatar_id":"","url":"https://api.github.com/users/ahardin-rh","html_url":"https://github.com/ahardin-rh","followers_url":"https://api.github.com/users/ahardin-rh/followers","following_url":"https://api.github.com/users/ahardin-rh/following{/other_user}","gists_url":"https://api.github.com/users/ahardin-rh/gists{/gist_id}","starred_url":"https://api.github.com/users/ahardin-rh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahardin-rh/subscriptions","organizations_url":"https://api.github.com/users/ahardin-rh/orgs","repos_url":"https://api.github.com/users/ahardin-rh/repos","events_url":"https://api.github.com/users/ahardin-rh/events{/privacy}","received_events_url":"https://api.github.com/users/ahardin-rh/received_events","type":"User","site_admin":false},"body":"Convert links to xrefs here as well.","created_at":"2016-07-01T20:13:29Z","updated_at":"2016-07-01T20:13:29Z","html_url":"https://github.com/openshift/openshift-docs/pull/2354#discussion_r69350330","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/69350330"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/2354#discussion_r69350330"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354","id":75245185,"html_url":"https://github.com/openshift/openshift-docs/pull/2354","diff_url":"https://github.com/openshift/openshift-docs/pull/2354.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/2354.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/2354","number":2354,"state":"open","locked":false,"title":"better document env variable usage for images","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/openshift/openshift-docs/issues/2353\r\n\r\n@smarterclayton ptal\r\n","created_at":"2016-06-27T00:19:16Z","updated_at":"2016-07-01T20:13:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d400c646d23b1404aa1f24c52b9010199bb99d6b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/2354/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/4f12d8f156d23bff7bc93f4be862b9dbe42197ec","head":{"label":"bparees:dev_mode","ref":"dev_mode","sha":"4f12d8f156d23bff7bc93f4be862b9dbe42197ec","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"repo":{"id":29214292,"name":"openshift-docs","full_name":"bparees/openshift-docs","owner":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bparees/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/bparees/openshift-docs","forks_url":"https://api.github.com/repos/bparees/openshift-docs/forks","keys_url":"https://api.github.com/repos/bparees/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bparees/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bparees/openshift-docs/teams","hooks_url":"https://api.github.com/repos/bparees/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/bparees/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/bparees/openshift-docs/events","assignees_url":"https://api.github.com/repos/bparees/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/bparees/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/bparees/openshift-docs/tags","blobs_url":"https://api.github.com/repos/bparees/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bparees/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bparees/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bparees/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bparees/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/bparees/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/bparees/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/bparees/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/bparees/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/bparees/openshift-docs/subscription","commits_url":"https://api.github.com/repos/bparees/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bparees/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bparees/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bparees/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bparees/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/bparees/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bparees/openshift-docs/merges","archive_url":"https://api.github.com/repos/bparees/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bparees/openshift-docs/downloads","issues_url":"https://api.github.com/repos/bparees/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/bparees/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/bparees/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/bparees/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bparees/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/bparees/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/bparees/openshift-docs/deployments","created_at":"2015-01-13T22:20:27Z","updated_at":"2016-01-18T20:16:20Z","pushed_at":"2016-06-30T19:35:25Z","git_url":"git://github.com/bparees/openshift-docs.git","ssh_url":"git@github.com:bparees/openshift-docs.git","clone_url":"https://github.com/bparees/openshift-docs.git","svn_url":"https://github.com/bparees/openshift-docs","homepage":null,"size":12728,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"59f1b5dcc2d4e65f1a59ce2393752593a1a2b54b","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2016-06-20T19:39:32Z","pushed_at":"2016-07-01T19:57:08Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":19815,"stargazers_count":48,"watchers_count":48,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":181,"forks":224,"open_issues":181,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/2354"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/2354"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/2354/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2354/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/4f12d8f156d23bff7bc93f4be862b9dbe42197ec"}}}}
{"actor":{"display_login":"ahardin-rh"}}