{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/57568378","id":57568378,"diff_hunk":"@@ -161,6 +163,11 @@ public HttpResponse doCompleteInstall() throws IOException, ServletException {\n      * This filter will validate that the security token is provided\n      */\n     private final Filter FORCE_SETUP_WIZARD_FILTER = new Filter() {\n+        private Pattern RESOURCE_PATTERN = Pattern.compile(\".*[.](css|ttf|gif|woff|eot|png|js)\");\n+        private Pattern ALLOWED_PATHS = Pattern.compile(\n+            \"\\\\Q/login\\\\E\"\n+            + \"|\\\\Q/loginError\\\\E\"\n+            + \"|\\\\Q/securityRealm/\" + new HudsonPrivateSecurityRealm(true, false, null).getAuthenticationGatewayUrl() + \"\\\\E\");","path":"core/src/main/java/jenkins/install/SetupWizard.java","position":40,"original_position":40,"commit_id":"2968285d9a2158747bfc5fc2c93b8217bfff7702","original_commit_id":"2968285d9a2158747bfc5fc2c93b8217bfff7702","user":{"login":"batmat","id":223853,"avatar_url":"https://avatars.githubusercontent.com/u/223853?v=3","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"body":"+1 for static final (+here too, shoudn't it?)","created_at":"2016-03-28T12:52:33Z","updated_at":"2016-03-28T12:52:33Z","html_url":"https://github.com/jenkinsci/jenkins/pull/2170#discussion_r57568378","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/57568378"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2170#discussion_r57568378"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170","id":64171169,"html_url":"https://github.com/jenkinsci/jenkins/pull/2170","diff_url":"https://github.com/jenkinsci/jenkins/pull/2170.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/2170.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2170","number":2170,"state":"open","locked":false,"title":"JENKINS-33770 - not all paths restricted during SetupWizard","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"body":"Setup wizard didn't restrict access to all unnecessary paths prior to authentication.\r\n\r\nThis addresses: https://issues.jenkins-ci.org/browse/JENKINS-33770\r\n\r\n@reviewbybees\r\n","created_at":"2016-03-25T15:08:55Z","updated_at":"2016-03-28T12:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19f039828039579e089ee575116237324023c079","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/2170/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/2968285d9a2158747bfc5fc2c93b8217bfff7702","head":{"label":"kzantow:JENKINS-33770-security-token-not-always-required","ref":"JENKINS-33770-security-token-not-always-required","sha":"2968285d9a2158747bfc5fc2c93b8217bfff7702","user":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"repo":{"id":41372898,"name":"jenkins","full_name":"kzantow/jenkins","owner":{"login":"kzantow","id":3009477,"avatar_url":"https://avatars.githubusercontent.com/u/3009477?v=3","gravatar_id":"","url":"https://api.github.com/users/kzantow","html_url":"https://github.com/kzantow","followers_url":"https://api.github.com/users/kzantow/followers","following_url":"https://api.github.com/users/kzantow/following{/other_user}","gists_url":"https://api.github.com/users/kzantow/gists{/gist_id}","starred_url":"https://api.github.com/users/kzantow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzantow/subscriptions","organizations_url":"https://api.github.com/users/kzantow/orgs","repos_url":"https://api.github.com/users/kzantow/repos","events_url":"https://api.github.com/users/kzantow/events{/privacy}","received_events_url":"https://api.github.com/users/kzantow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kzantow/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/kzantow/jenkins","forks_url":"https://api.github.com/repos/kzantow/jenkins/forks","keys_url":"https://api.github.com/repos/kzantow/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kzantow/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kzantow/jenkins/teams","hooks_url":"https://api.github.com/repos/kzantow/jenkins/hooks","issue_events_url":"https://api.github.com/repos/kzantow/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/kzantow/jenkins/events","assignees_url":"https://api.github.com/repos/kzantow/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/kzantow/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/kzantow/jenkins/tags","blobs_url":"https://api.github.com/repos/kzantow/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kzantow/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kzantow/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/kzantow/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kzantow/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/kzantow/jenkins/languages","stargazers_url":"https://api.github.com/repos/kzantow/jenkins/stargazers","contributors_url":"https://api.github.com/repos/kzantow/jenkins/contributors","subscribers_url":"https://api.github.com/repos/kzantow/jenkins/subscribers","subscription_url":"https://api.github.com/repos/kzantow/jenkins/subscription","commits_url":"https://api.github.com/repos/kzantow/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/kzantow/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/kzantow/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/kzantow/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/kzantow/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/kzantow/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kzantow/jenkins/merges","archive_url":"https://api.github.com/repos/kzantow/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kzantow/jenkins/downloads","issues_url":"https://api.github.com/repos/kzantow/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/kzantow/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/kzantow/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/kzantow/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kzantow/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/kzantow/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/kzantow/jenkins/deployments","created_at":"2015-08-25T15:52:29Z","updated_at":"2015-08-25T15:52:51Z","pushed_at":"2016-03-25T15:02:53Z","git_url":"git://github.com/kzantow/jenkins.git","ssh_url":"git@github.com:kzantow/jenkins.git","clone_url":"https://github.com/kzantow/jenkins.git","svn_url":"https://github.com/kzantow/jenkins","homepage":"http://jenkins-ci.org/","size":93168,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:2.0","ref":"2.0","sha":"1873c6fb8471ea7a478b43f709262e2a6ec341b8","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2016-03-28T11:33:06Z","pushed_at":"2016-03-28T11:40:40Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":98870,"stargazers_count":5426,"watchers_count":5426,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2393,"mirror_url":null,"open_issues_count":139,"forks":2393,"open_issues":139,"watchers":5426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/2170"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2170"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/2170/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/2170/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/2968285d9a2158747bfc5fc2c93b8217bfff7702"}}}}