{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/77231457","id":77231457,"diff_hunk":"@@ -141,9 +152,25 @@ public Builder setStatsLogger(StatsLogger statsLogger) {\n             return this;\n         }\n \n+\n+        public Builder dnsResolver(DNSToSwitchMapping dnsResolver) {\n+            this.dnsResolver = dnsResolver;\n+            return this;\n+        }\n+\n+        public Builder requestTimer(HashedWheelTimer requestTimer) {","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java","position":61,"original_position":61,"commit_id":"e2ab818afcee725f916018724a7b01404cf9da81","original_commit_id":"e2ab818afcee725f916018724a7b01404cf9da81","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars.githubusercontent.com/u/1217863?v=3","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"Matteo is merging Yahoo's netty 4 change back. We can address the concern about public API and netty dependency there.","created_at":"2016-09-01T18:47:03Z","updated_at":"2016-09-01T18:47:03Z","html_url":"https://github.com/apache/bookkeeper/pull/56#discussion_r77231457","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/77231457"},"html":{"href":"https://github.com/apache/bookkeeper/pull/56#discussion_r77231457"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/56","id":77636907,"html_url":"https://github.com/apache/bookkeeper/pull/56","diff_url":"https://github.com/apache/bookkeeper/pull/56.diff","patch_url":"https://github.com/apache/bookkeeper/pull/56.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/56","number":56,"state":"open","locked":false,"title":"BOOKKEEPER-612: Region aware placement","user":{"login":"robindh","id":2607057,"avatar_url":"https://avatars.githubusercontent.com/u/2607057?v=3","gravatar_id":"","url":"https://api.github.com/users/robindh","html_url":"https://github.com/robindh","followers_url":"https://api.github.com/users/robindh/followers","following_url":"https://api.github.com/users/robindh/following{/other_user}","gists_url":"https://api.github.com/users/robindh/gists{/gist_id}","starred_url":"https://api.github.com/users/robindh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindh/subscriptions","organizations_url":"https://api.github.com/users/robindh/orgs","repos_url":"https://api.github.com/users/robindh/repos","events_url":"https://api.github.com/users/robindh/events{/privacy}","received_events_url":"https://api.github.com/users/robindh/received_events","type":"User","site_admin":false},"body":"- Introduce the concept of a two level Network Topology with region as the first level and rack as the second level\r\n- NodeBase, Node and NetworkTopology manage this two level hierarchy and position of individual nodes in this hierarchy\r\n- An implementation of RegionawareEnsemblePlacementPolicy that distributes nodes across regions and within regions uses rack aware placement to place nodes\r\n\r\nThis is a stacked diff (opening to start a review), we would still merge the dependent pull request first.","created_at":"2016-07-15T15:48:51Z","updated_at":"2016-09-01T18:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/56/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/56/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/56/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/e2ab818afcee725f916018724a7b01404cf9da81","head":{"label":"robindh:RegionAwarePlacement","ref":"RegionAwarePlacement","sha":"e2ab818afcee725f916018724a7b01404cf9da81","user":{"login":"robindh","id":2607057,"avatar_url":"https://avatars.githubusercontent.com/u/2607057?v=3","gravatar_id":"","url":"https://api.github.com/users/robindh","html_url":"https://github.com/robindh","followers_url":"https://api.github.com/users/robindh/followers","following_url":"https://api.github.com/users/robindh/following{/other_user}","gists_url":"https://api.github.com/users/robindh/gists{/gist_id}","starred_url":"https://api.github.com/users/robindh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindh/subscriptions","organizations_url":"https://api.github.com/users/robindh/orgs","repos_url":"https://api.github.com/users/robindh/repos","events_url":"https://api.github.com/users/robindh/events{/privacy}","received_events_url":"https://api.github.com/users/robindh/received_events","type":"User","site_admin":false},"repo":{"id":53805713,"name":"bookkeeper","full_name":"robindh/bookkeeper","owner":{"login":"robindh","id":2607057,"avatar_url":"https://avatars.githubusercontent.com/u/2607057?v=3","gravatar_id":"","url":"https://api.github.com/users/robindh","html_url":"https://github.com/robindh","followers_url":"https://api.github.com/users/robindh/followers","following_url":"https://api.github.com/users/robindh/following{/other_user}","gists_url":"https://api.github.com/users/robindh/gists{/gist_id}","starred_url":"https://api.github.com/users/robindh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robindh/subscriptions","organizations_url":"https://api.github.com/users/robindh/orgs","repos_url":"https://api.github.com/users/robindh/repos","events_url":"https://api.github.com/users/robindh/events{/privacy}","received_events_url":"https://api.github.com/users/robindh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robindh/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/robindh/bookkeeper","forks_url":"https://api.github.com/repos/robindh/bookkeeper/forks","keys_url":"https://api.github.com/repos/robindh/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robindh/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robindh/bookkeeper/teams","hooks_url":"https://api.github.com/repos/robindh/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/robindh/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/robindh/bookkeeper/events","assignees_url":"https://api.github.com/repos/robindh/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/robindh/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/robindh/bookkeeper/tags","blobs_url":"https://api.github.com/repos/robindh/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robindh/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robindh/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/robindh/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robindh/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/robindh/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/robindh/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/robindh/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/robindh/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/robindh/bookkeeper/subscription","commits_url":"https://api.github.com/repos/robindh/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/robindh/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/robindh/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/robindh/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/robindh/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/robindh/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robindh/bookkeeper/merges","archive_url":"https://api.github.com/repos/robindh/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robindh/bookkeeper/downloads","issues_url":"https://api.github.com/repos/robindh/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/robindh/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/robindh/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/robindh/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robindh/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/robindh/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/robindh/bookkeeper/deployments","created_at":"2016-03-13T20:21:37Z","updated_at":"2016-03-13T20:21:40Z","pushed_at":"2016-07-15T15:40:51Z","git_url":"git://github.com/robindh/bookkeeper.git","ssh_url":"git@github.com:robindh/bookkeeper.git","clone_url":"https://github.com/robindh/bookkeeper.git","svn_url":"https://github.com/robindh/bookkeeper","homepage":null,"size":8787,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2f71beb5e4b06691d4fd6c2601b78632236b3533","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2016-08-31T13:07:42Z","pushed_at":"2016-08-31T14:57:31Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":null,"size":9606,"stargazers_count":121,"watchers_count":121,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":"git://git.apache.org/bookkeeper.git","open_issues_count":4,"forks":60,"open_issues":4,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/56"},"html":{"href":"https://github.com/apache/bookkeeper/pull/56"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/56"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/e2ab818afcee725f916018724a7b01404cf9da81"}}}}
{"actor":{"display_login":"sijie"}}